FWD » Core Development » Conversion Tools

04/19/2022

12:02 PM Feature #6253: add file-set processing into p2j.cfg.xml

Please check 3821c/13794. Constantin Asofiei

10:41 AM Feature #6253: add file-set processing into p2j.cfg.xml

> > A command like this:
> > [...]
> > will use the @file-set@ configuration from the @cfg/p2j.cfg.xml@ (will assum... Greg Shah

04/18/2022

05:45 AM Bug #5135 (Closed): replace -s, -f and -x options of ConversionDriver with a single combined mode

Greg Shah

05:45 AM Feature #6253 (Closed): add file-set processing into p2j.cfg.xml

Code Review Task Branch 3821c Revision 13788
It is good. Greg Shah

04/16/2022

02:58 PM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

Greg Shah wrote:
> Any amount of whitespace (not just space char) should be ignored.
Please see 3821c/13788. Constantin Asofiei

02:58 PM Feature #6253: add file-set processing into p2j.cfg.xml

The changes are in 3821c/13788. Constantin Asofiei

04/15/2022

08:10 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

Any amount of whitespace (not just space char) should be ignored. Greg Shah

12:55 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

I created a list file for a project. The file contained several lines using the @D@ directive. I noticed there can be... Eric Faulhaber

04/14/2022

04:57 PM Feature #6253: add file-set processing into p2j.cfg.xml

> but recursive makes sense for it to default to 'true'.
Let's do it. Greg Shah

04:56 PM Feature #6253: add file-set processing into p2j.cfg.xml

Code Review Task Branch 3821c Revision 13778
The changes are good.
1. An "include file" has a special meaning i... Greg Shah

04/13/2022

09:20 AM Feature #6203: create cvtpath and move conversion database into that directory

Constantin Asofiei wrote:
> Thanks, I can duplicate it:
> * run @ant convert.list@ with 3821c - name is @MultiLine1... Roger Borrello

09:15 AM Feature #6203: create cvtpath and move conversion database into that directory

Thanks, I can duplicate it:
* run @ant convert.list@ with 3821c - name is @MultiLine1@.
* run @ant clean.all@
* ru... Constantin Asofiei

09:03 AM Feature #6203: create cvtpath and move conversion database into that directory

Constantin Asofiei wrote:
> Roger, please upload to devsrv01 your entire testcases project where you do the conversi... Roger Borrello

04:04 AM Feature #6203: create cvtpath and move conversion database into that directory

Roger, please upload to devsrv01 your entire testcases project where you do the conversion (without the p2j/ folder).... Constantin Asofiei

08:34 AM Feature #6253: add file-set processing into p2j.cfg.xml

Greg Shah wrote:
> Should we make the following common cases the default?
>
> * @recursive="true"@
> * @spec="(*... Constantin Asofiei

08:32 AM Feature #6253 (Review): add file-set processing into p2j.cfg.xml

The changes are in 3821c/13778 for both this task and #5135. Constantin Asofiei

08:28 AM Feature #6253: add file-set processing into p2j.cfg.xml

It looks good.
Should we make the following common cases the default?
* @recursive="true"@
* @spec="(*.[pPwW... Greg Shah

08:15 AM Feature #6253: add file-set processing into p2j.cfg.xml

The @file-set@ in @p2j.cfg.xml@ will look like this:... Constantin Asofiei

08:10 AM Feature #6253: add file-set processing into p2j.cfg.xml

Constantin Asofiei wrote:
> A command like this:
> [...]
> will use the @file-set@ configuration from the @cfg/p2j... Greg Shah

08:09 AM Feature #6253: add file-set processing into p2j.cfg.xml

> I've used @<file-set filename="file-set.txt" />@ (@filename@ instead of @input-file@) because of the dash in @input... Greg Shah

08:08 AM Feature #6253: add file-set processing into p2j.cfg.xml

A command like this:... Constantin Asofiei

08:07 AM Feature #6253: add file-set processing into p2j.cfg.xml

I've used @<file-set filename="file-set.txt" />@ (@filename@ instead of @input-file@) because of the dash in @input-f... Constantin Asofiei

08:32 AM Bug #5135 (Review): replace -s, -f and -x options of ConversionDriver with a single combined mode

The changes are in 3821c/13778 for both this task and #6253. Constantin Asofiei

08:28 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

OK Greg Shah

08:19 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

Z mode is stripping the @./@ prefix, because of some peculiarities when resolving the path (I need the real OS filena... Constantin Asofiei

04/12/2022

04:18 PM Feature #6203: create cvtpath and move conversion database into that directory

Ovidiu Maxiniuc wrote:
> This is odd, at least. Does it happens for a single project? It does not happen for me. It ... Roger Borrello

03:42 PM Feature #6203: create cvtpath and move conversion database into that directory

This is odd, at least. Does it happens for a single project? It does not happen for me. It is a configuration issue, ... Ovidiu Maxiniuc

03:27 PM Feature #6203: create cvtpath and move conversion database into that directory

I'm not sure if this was an intended change, but with the 13732 revision, generated filenames are no longer Camel-Cas... Roger Borrello

04/11/2022

11:25 AM Feature #6270: annotations-based per-file hints

Greg Shah wrote:
> To clarify, I meant that to maintain the WINE environment one must have an original Windows funct... Tijs Wickardt

08:54 AM Feature #6270: annotations-based per-file hints

> > a working Windows configuration
> This seems to be a misunderstanding. I meant:
> Only the binaries that are n... Greg Shah

08:48 AM Feature #6270: annotations-based per-file hints

No need for apologies, these are all valid points.
> a working Windows configuration
This seems to be a misunders... Tijs Wickardt

08:17 AM Feature #6270: annotations-based per-file hints

Every time we add *any* dependency, we add friction in the process of getting everything running properly. For conve... Greg Shah

02:41 AM Feature #6270: annotations-based per-file hints

Greg Shah wrote:
> I don't see the same value in maintaining the @.wrx@ as a resource. It cannot be easily edited, ... Tijs Wickardt

04/10/2022

07:41 PM Feature #6270: annotations-based per-file hints

I don't see the same value in maintaining the @.wrx@ as a resource. It cannot be easily edited, it can only be edite... Greg Shah

02:36 PM Feature #6270: annotations-based per-file hints

Note: https://pkgs.alpinelinux.org/package/edge/community/x86/wine
(and winetricks)
Non edge version (stable): ... Tijs Wickardt

02:16 PM Feature #6270: annotations-based per-file hints

Hynek Cihlar wrote:
> Greg Shah wrote:.
> > > .. interpret .wrx files (for example) the related annotations should ... Tijs Wickardt

12:15 PM Feature #6270: annotations-based per-file hints

Greg Shah wrote:
> > It should be limited only to information that FWD cannot deduce at the conversion.
>
> This... Tijs Wickardt

12:04 PM Feature #6270: annotations-based per-file hints

Greg Shah wrote:
> > It should be limited only to information that FWD cannot deduce at the conversion.
>
> This... Hynek Cihlar

11:14 AM Feature #6270: annotations-based per-file hints

> It should be limited only to information that FWD cannot deduce at the conversion.
This is already the case. W... Greg Shah

11:08 AM Feature #6270: annotations-based per-file hints

I like the idea of using 4GL annotations for FWD runtime hints.
It reduces the chance of an OE developer forgetting ... Tijs Wickardt

09:48 AM Feature #6270: annotations-based per-file hints

Today, we have multiple types of hints at the individual source-file level.
* "UAST Hints" are read from a file th... Greg Shah

09:14 AM Feature #6270 (New): annotations-based per-file hints

Greg Shah

04/08/2022

10:00 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

> I can either use java.nio.Path.toRealPath (if it works) to resolve the real filename at OS level, or otherwise rely... Greg Shah

09:17 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

Another issue: lets assume we are under Windows, where file names are case-insensitive; you have a @F ./Build.p@ line... Constantin Asofiei

07:45 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

> I think the schema @.hints@ should be stored with the @.df@ file, not with @.schema@.
Correct.
> More than t... Greg Shah

04/07/2022

07:05 PM Feature #6202: allow .df files to exist in a path that is not directly in data/

This note was added because of the #5034-1965. It was caused because the conversion got confused about the location o... Ovidiu Maxiniuc

01:42 PM Feature #6202: allow .df files to exist in a path that is not directly in data/

> Note that this defines the location where the .d files are, to allow the import for custom locations. This is not t... Greg Shah

11:48 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

Greg Shah wrote:
> * The @dataPath@ parameter for import could be optional. I like to have the option to override t... Ovidiu Maxiniuc

06:53 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

All of this is very good. A couple of items:
* The @dataPath@ parameter for import could be optional. I like to ... Greg Shah

02:25 PM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

And yes, it is OK to leave @-s@. Greg Shah

02:25 PM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

I was assuming that all of the modes would remain until we've migrated all projects into the @-z@. Greg Shah

02:16 PM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

Greg, I'll remove the whitelist and blacklist modes in current work, but the 'FILESPEC' (-s mode) should remain, this... Constantin Asofiei

11:19 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

Greg Shah wrote:
> Yes, this makes sense. We should also require double quoted strings when there are embedded spac... Constantin Asofiei

11:14 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

Yes, this makes sense. We should also require double quoted strings when there are embedded space characters.
<pr... Greg Shah

10:25 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

Greg, in the case where we use a file, there will be problems if there are space characters in either the file spec o... Constantin Asofiei

06:55 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

As with other flags @-z@ and @-Z@ should be equivalent. Greg Shah

06:55 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

> Greg, to make something clear: the @X@ and @I@ filters will work only on the set of files determined from the D, N,... Greg Shah

03:04 AM Bug #5135 (WIP): replace -s, -f and -x options of ConversionDriver with a single combined mode

Greg, to make something clear: the @X@ and @I@ filters will work only on the set of files determined from the D, N, F... Constantin Asofiei

11:26 AM Feature #6253 (WIP): add file-set processing into p2j.cfg.xml

Constantin Asofiei

04/06/2022

07:04 PM Feature #6202: allow .df files to exist in a path that is not directly in data/

With r13746 we have the abilities to:
* pick the .df from any subdirectory under the project's root. The path is spe... Ovidiu Maxiniuc

07:03 PM Feature #6256: improved profile support

For complex projects, the OpenEdge compilation will often be done in multiple different compile runs. Each one might... Greg Shah

06:46 PM Feature #6256 (Closed): improved profile support

Greg Shah

06:45 PM Feature #6255: simplify the namespace configuration, part deux

In #4105, many improvements were made to simplify the namespace configuration in @p2j.cfg.xml@.
I have 2 additiona... Greg Shah

06:40 PM Feature #6255 (WIP): simplify the namespace configuration, part deux

Greg Shah

06:33 PM Feature #6253: add file-set processing into p2j.cfg.xml

The global section of the @p2j.cfg.xml@ should allow the definition of a @file-set@ element which will allow the expl... Greg Shah

06:14 PM Feature #6253 (Closed): add file-set processing into p2j.cfg.xml

Greg Shah

06:17 PM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

This new file processing approach can be activated with the @-Z<input_file>@ command line option. I know this is dif... Greg Shah

05:04 PM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

I've been thinking about the syntax for this approach. Using a list of @X@ (exclude) and @I@ (include) filters is a ... Greg Shah

06:10 PM Feature #6252: cleanup of p2j.cfg.xml

Make the global section of @p2j.cfg.xml@ simpler with the following changes:
* Set good default values for @P2J_RU... Greg Shah

06:06 PM Feature #6252 (New): cleanup of p2j.cfg.xml

Greg Shah

05:20 PM Feature #3699: improve call-graph visualization to make it much more usable

I found an interesting article on the "ForceAtlas2":https://journals.plos.org/plosone/article?id=10.1371/journal.pone... Greg Shah

04/05/2022

10:06 AM Feature #6237: OEUnit support

"OEUnit":https://github.com/CameronWills/OEUnit is an open source project (Eclipse Public License) which preceded ABL... Greg Shah

10:03 AM Feature #6237 (Closed): OEUnit support

Greg Shah

04/04/2022

01:04 PM Feature #6203 (Closed): create cvtpath and move conversion database into that directory

Greg Shah

11:02 AM Feature #6203: create cvtpath and move conversion database into that directory

Greg Shah wrote:
> I'd like to push this to xfer. Please make the @build.xml@ changes in the active customer projec... Constantin Asofiei

10:55 AM Feature #6203: create cvtpath and move conversion database into that directory

I'd like to push this to xfer. Please make the @build.xml@ changes in the active customer projects so that everythin... Greg Shah

12:14 PM Feature #6202: allow .df files to exist in a path that is not directly in data/

Greg Shah wrote:
> > According to #5586, there will not be a @cvt@ in jar. The directory structure for all artifacts... Ovidiu Maxiniuc

12:05 PM Feature #6202: allow .df files to exist in a path that is not directly in data/

> According to #5586, there will not be a @cvt@ in jar. The directory structure for all artifacts must be preserved i... Greg Shah

12:03 PM Feature #6202: allow .df files to exist in a path that is not directly in data/

Constantin Asofiei wrote:
> OK, then the runtime doesn't need 'cvtpath' at all, as the root folder is the project ro... Ovidiu Maxiniuc

12:02 PM Feature #6202: allow .df files to exist in a path that is not directly in data/

Just as an FYI, in my customer project, I utilized the "deploy.dist" target to include everything needed to perform t... Roger Borrello

11:59 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > I'm confused - how will the artifacts be kept in the jar - w... Constantin Asofiei

11:56 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

Constantin Asofiei wrote:
> I'm confused - how will the artifacts be kept in the jar - will they be relative to the ... Ovidiu Maxiniuc

11:53 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Ovidiu Maxiniuc wrote:
> > > It uses @Configuration.getConv... Constantin Asofiei

11:50 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > It uses @Configuration.getConversionFolder()@ at conversion ... Ovidiu Maxiniuc

11:42 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

Ovidiu Maxiniuc wrote:
> It uses @Configuration.getConversionFolder()@ at conversion but, at runtime, the returned p... Constantin Asofiei

11:40 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

Constantin Asofiei wrote:
> Ovidiu, are you planning to jar the entire @cvt/@ folder?
Of course, not. The @build.xm... Ovidiu Maxiniuc

11:32 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

Ovidiu, are you planning to jar the entire @cvt/@ folder? For runtime, I would use a pre-defined/static 'cvtpath' (i... Constantin Asofiei

11:23 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

Greg Shah wrote:
> Please shift to use the @Configuration.getConversionFolder()@ instead of the @xmlFile@ approach. ... Ovidiu Maxiniuc

04/03/2022

11:34 AM Feature #6203: create cvtpath and move conversion database into that directory

Greg Shah wrote:
> Code Review Task Branch 3821c Revision 13732
>
> Nice!
>
> 1. @Configuration.getConversionF... Constantin Asofiei

10:34 AM Feature #6203: create cvtpath and move conversion database into that directory

Code Review Task Branch 3821c Revision 13732
Nice!
1. @Configuration.getConversionFolder()@ should have the @ex... Greg Shah

10:22 AM Feature #6203: create cvtpath and move conversion database into that directory

Greg wrote:
> When do you think you can have this ready?
Constantin wrote (2 hours later):
> Added to 3821c/1373... Greg Shah

10:38 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

Please shift to use the @Configuration.getConversionFolder()@ instead of the @xmlFile@ approach. By default it shoul... Greg Shah

04/02/2022

12:29 PM Feature #6203 (Review): create cvtpath and move conversion database into that directory

Added to 3821c/13732. Constantin Asofiei

09:57 AM Feature #6203: create cvtpath and move conversion database into that directory

Constantin: When do you think you can have this ready? Greg Shah

09:57 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

> I have the changes ready to commit but
Are these changes to FWD or are they the project changes referenced in #... Greg Shah

09:33 PM Feature #6202: allow .df files to exist in a path that is not directly in data/

I have the changes ready to commit but there are two issues.
* I only tested on PoC and hotel_gui projects. That is,... Ovidiu Maxiniuc

03/29/2022

03:34 PM Feature #1757: update ANTLR to latest version

ANTLR v3 is dead at this point and was replaced by ANTLR v4. Whether it makes sense or not to move to ANTLR v4 is no... Greg Shah

10:02 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

I would be fine with those updates to that POC project. Roger Borrello

09:49 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

Greg,
I worked with latest POC (#6088, which Roger is maintaining) when adding these changes. I have chosen it bec... Ovidiu Maxiniuc

07:09 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

Overall, I'm good with the approach. When #6203 (@cvtpath@) is available, you should remove @xmlFile@ and use @cvtpa... Greg Shah

03/26/2022

11:16 PM Feature #6202 (WIP): allow .df files to exist in a path that is not directly in data/

As noted above I added a @dataFolder@ attribute in @namespace@. This specifies the location of @.d@ data files. Toget... Ovidiu Maxiniuc

03/25/2022

01:14 PM Feature #6202: allow .df files to exist in a path that is not directly in data/

Greg Shah wrote:
> > I am now trying to fix the data_analyzer (optionally invoked using f2+m1+cb conversion profile)... Eric Faulhaber

06:00 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

> I am now trying to fix the data_analyzer (optionally invoked using f2+m1+cb conversion profile).
I think we have... Greg Shah

08:57 PM Feature #6202: allow .df files to exist in a path that is not directly in data/

In #4105 I added flexibility for loading the @.df@ file from a configured place, but there were some issues with the ... Ovidiu Maxiniuc

03/24/2022

02:01 PM Feature #6202: allow .df files to exist in a path that is not directly in data/

We aren't moving to a database in this task. Even in #5586, the database is only likely to hold non-artifacts. Some... Greg Shah

01:52 PM Feature #6202: allow .df files to exist in a path that is not directly in data/

Greg Shah wrote:
> Eric: Do you have any comments or concerns?
We have to consider runtime use of these resourc... Eric Faulhaber

03/23/2022

09:09 AM Feature #6203: create cvtpath and move conversion database into that directory

As noted in #6202 and #5586, we are going to be moving all intermediate conversion artifacts into a configurable dire... Greg Shah

09:05 AM Feature #6203 (Closed): create cvtpath and move conversion database into that directory

Greg Shah

09:03 AM Feature #6202: allow .df files to exist in a path that is not directly in data/

In #4105-52, Roger attempted to organize @.df@ files in subdirectories of @data/@. This worked for the front end sta... Greg Shah

08:38 AM Feature #6202 (Closed): allow .df files to exist in a path that is not directly in data/

Greg Shah