Project

General

Profile

Activity

From 04/08/2022 to 05/07/2022

05/04/2022

10:55 AM Feature #6320: sharded schemata
We have multiple customers that split up a large 4GL application into multiple independent modules, each of which can... Greg Shah
10:51 AM Feature #6320 (WIP): sharded schemata
Greg Shah
10:47 AM Feature #6319: IntelliJ plugin
IntelliJ plugin for integration with syntax check and running conversion (et al). This must also provide the full sup... Greg Shah
10:44 AM Feature #6319 (Rejected): IntelliJ plugin
Greg Shah

05/02/2022

11:02 AM Feature #6256: improved profile support
If there were a need for 2 main database configured:
# a *merged* configuration with all schemas in one database, na... Roger Borrello
10:25 AM Feature #6256: improved profile support
Sorry, failed refresh. Ovidiu Maxiniuc
10:24 AM Feature #6256: improved profile support
Eric Faulhaber wrote:
> Ovidiu, do I understand correctly that when the @importFile@ attribute of @namespace@ is spe... Ovidiu Maxiniuc
10:26 AM Feature #6302: Improve conversion of empty OCX arguments
This issue does not appear in known customer scenarios, so its severity reduced to LOW. Vladimir Tsichevski

05/01/2022

11:43 AM Feature #6256: improved profile support
The current changes are in 6129a/13823. Constantin Asofiei

04/30/2022

05:20 PM Feature #6256: improved profile support
Greg Shah wrote:
> We can defer any conversion issues until a second phase of work. The front end part is what is n... Constantin Asofiei
02:53 PM Feature #6256: improved profile support
We can defer any conversion issues until a second phase of work. The front end part is what is needed this week. Greg Shah
02:49 PM Feature #6256: improved profile support
Greg Shah wrote:
> My idea was to add an extra layer at the ConversionDriver level, which would associate the profil... Constantin Asofiei
02:32 PM Feature #6256: improved profile support
My idea was to add an extra layer at the ConversionDriver level, which would associate the profile with some sub-set ... Greg Shah
02:30 PM Feature #6256: improved profile support
> What if a file is part of multiple profiles?
The profiles are intended to be mutually-exclusive. We can define ... Greg Shah
02:26 PM Feature #6256: improved profile support
Greg Shah wrote:
> The files specified for the profile should be parsed/converted with the same settings as if the p... Constantin Asofiei
02:15 PM Feature #6256: improved profile support
When I said the multiple profile merge was needed, I meant a different idea.
Each profile can be run standalone. ... Greg Shah
02:07 PM Feature #6256: improved profile support
So, the approach is this:
* multiple profiles are allowed (only for conversion time), and they can be specified via ... Constantin Asofiei
02:04 PM Feature #6256: improved profile support
Eric: I think the shard idea makes good sense. We have multiple customers using this approach in OE today. The idea... Greg Shah
01:59 PM Feature #6256: improved profile support
A useful addition (medium term, not immediately) would be to be able to load multiple DF files into a single schema n... Eric Faulhaber
01:03 PM Feature #6256: improved profile support
Greg Shah wrote:
> The multi-profile merge mode is needed as part of this task.
This will be only for conversion. ... Constantin Asofiei
01:00 PM Feature #6256: improved profile support
It is a good plan. Greg Shah
12:22 PM Feature #6256: improved profile support
Constantin Asofiei wrote:
> * if no profile is set as default, let the global configuration be the default, unless o... Constantin Asofiei
12:20 PM Feature #6256: improved profile support
Greg Shah wrote:
> > The @SchemaConfig$Profile@ has a @isDefault@, which suggests that there can be a @isDefault@ at... Constantin Asofiei
12:13 PM Feature #6256: improved profile support
Greg Shah wrote:
> The multi-profile merge mode is needed as part of this task.
Understood.
 Constantin Asofiei
12:12 PM Feature #6256: improved profile support
> Do you see a need to make the profile/schema node optional? In this case, it would be inherited from the global con... Greg Shah
12:10 PM Feature #6256: improved profile support
Do you see a need to make the @profile/schema@ node optional? In this case, it would be inherited from the global con... Constantin Asofiei
11:27 AM Feature #6256: improved profile support
I don't think there is a hard requirement for that at the profile level. Greg Shah
11:26 AM Feature #6256: improved profile support
> The @SchemaConfig$Profile@ has a @isDefault@, which suggests that there can be a @isDefault@ attribute at the @prof... Greg Shah
11:26 AM Feature #6256: improved profile support
Greg Shah wrote:
> The namespace should assume @default="true"@ so that it doesn't have to be duplicated. But it sh... Constantin Asofiei
11:24 AM Feature #6256: improved profile support
The namespace should assume @default="true"@ so that it doesn't have to be duplicated. But it should be possible to ... Greg Shah
11:12 AM Feature #6256: improved profile support
The @profile@ node has only @name@ attribute in #6256-8.
The @SchemaConfig$Profile@ has a @isDefault@, which sugge... Constantin Asofiei
10:03 AM Feature #6256: improved profile support
> At least the syntax in note 5 is no longer valid, right?
Right. Greg Shah
09:56 AM Feature #6256: improved profile support
Greg Shah wrote:
> Is there some other use case I'm missing?
I don't think so.
> We already handle the namespace... Constantin Asofiei
09:49 AM Feature #6256: improved profile support
> When running in single profile mode, the profile will need to overwrite default @parameter@ and @file-set@ nodes,
... Greg Shah
09:48 AM Feature #6256: improved profile support
> each profile has the same syntax as the 'global' profile (so the namespace nodes would be added in a schema node)
... Greg Shah
09:39 AM Feature #6256: improved profile support
When running in single profile mode, the profile will need to overwrite default @parameter@ and @file-set@ nodes, and... Constantin Asofiei
09:35 AM Feature #6256: improved profile support
Greg/Eric: my thought would be the profiles to work like this:
* there is the 'global' profile which is used implici... Constantin Asofiei

04/29/2022

01:49 PM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
The function issue is actually a 4GL preprocessor quirk. I've created a testcase and checked it into [[p2j:Old UAST ... Greg Shah
01:46 PM Bug #6308 (Internal Test): post string literal alternative coding quirk in 4GL preprocessor
Greg Shah
03:25 AM Feature #6302: Improve conversion of empty OCX arguments
Vladimir, is there a customer app failing test case for this? If not I suggest you make this lower priority. Hynek Cihlar
03:06 AM Feature #6302: Improve conversion of empty OCX arguments
Vladimir Tsichevski wrote:
> The @.ast@ file seems to be correct (all parameters in the call are present, but in @.j... Hynek Cihlar

04/28/2022

07:29 PM Feature #6302: Improve conversion of empty OCX arguments
The @.ast@ file seems to be correct (all parameters in the call are present, but in @.jast@ file parameters for the @... Vladimir Tsichevski
07:08 PM Feature #6302: Improve conversion of empty OCX arguments
Vladimir Tsichevski wrote:
> Tijs Wickardt wrote:
>
> > The OpenEdge documentation states explicitly that OCX's a... Tijs Wickardt
06:18 PM Feature #6302: Improve conversion of empty OCX arguments
Tijs Wickardt wrote:
> FYI: see @testcases/oxc_to_fwd/mscomctl-treeview-ocx.w@ :
> @hNode = chCfTreeView:TreeView:... Vladimir Tsichevski
06:10 PM Feature #6302: Improve conversion of empty OCX arguments
Tijs Wickardt wrote:
> The OpenEdge documentation states explicitly that OCX's are 0-based, not 1-based like the 4... Vladimir Tsichevski
03:19 PM Feature #6302: Improve conversion of empty OCX arguments
Tijs Wickardt wrote:
> Vladimir Tsichevski wrote:
> > Seems, I was not right here: undefined values *can* be used b... Vladimir Tsichevski
03:16 PM Feature #6302: Improve conversion of empty OCX arguments
Vladimir Tsichevski wrote:
> Seems, I was not right here: undefined values *can* be used by OE to pass the "default"... Tijs Wickardt
02:50 PM Feature #6302 (WIP): Improve conversion of empty OCX arguments
Seems, I was not right here: undefined values *can* be used by OE to pass the "default" value to OCX. Moreover, undef... Vladimir Tsichevski
01:15 PM Feature #6302: Improve conversion of empty OCX arguments
This issue must be fixed along with: #5622-12. Otherwise no compilable code is created by conversion for this call. Vladimir Tsichevski
09:20 AM Feature #6302: Improve conversion of empty OCX arguments
Hynek Cihlar wrote:
> @hNode.assign(hTree.unwrapTreeView().getNodes().unwrapTreeNodeCollection().add(new integer()... Tijs Wickardt
09:16 AM Feature #6302: Improve conversion of empty OCX arguments
FYI: see @testcases/oxc_to_fwd/mscomctl-treeview-ocx.w@ :
@hNode = chCfTreeView:TreeView:Nodes:Add(,,cParentNodeID,... Tijs Wickardt
08:43 AM Feature #6302: Improve conversion of empty OCX arguments
The function parameter specification in COM type library may contain a default value. Perhaps this is the value used ... Hynek Cihlar
08:32 AM Feature #6302: Improve conversion of empty OCX arguments
Empty arguments of converted OCX method invocations are converted into "unknown" instances.
For example the follo... Hynek Cihlar
08:23 AM Feature #6302 (WIP): Improve conversion of empty OCX arguments
Hynek Cihlar
12:10 PM Feature #6256: improved profile support
Yes, the syntax is OK. Greg Shah
12:00 PM Feature #6256 (WIP): improved profile support
Incorporating the above suggestions/requirements, I have updated the sample configuration as follows:... Eric Faulhaber
07:25 AM Feature #6256: improved profile support
Greg Shah wrote:
> > I'm assuming (for now) that profile *.df files will be found in ./data/<profile-name>/.
> No, ... Ovidiu Maxiniuc

04/27/2022

07:27 PM Feature #6256: improved profile support
> Is this the right vision?
Mostly, yes. The part I don't understand is why there is a @schema@ node inside the @... Greg Shah
06:07 PM Feature #6256: improved profile support
At this moment the structure of the configuration file is:... Ovidiu Maxiniuc
04:59 PM Feature #6256: improved profile support
To translate the above configuration requirements into a sample @p2j.cfg.xml@, I understand it should look something ... Eric Faulhaber

04/26/2022

08:52 AM Feature #6255: simplify the namespace configuration, part deux
What was frustrating was that in my local testing worked, but with the main project it abended - and this was only be... Constantin Asofiei

04/24/2022

09:07 AM Feature #6255: simplify the namespace configuration, part deux
With 13811, the metadata schema can be loaded twice. This was seen in a customer project which then had ambiguous re... Greg Shah

04/22/2022

06:28 PM Feature #6255 (WIP): simplify the namespace configuration, part deux
The implementation for the initial two requests can be found in FWD starting with r13811 of 3821c.
We should keep ... Ovidiu Maxiniuc

04/19/2022

12:02 PM Feature #6253: add file-set processing into p2j.cfg.xml
Please check 3821c/13794. Constantin Asofiei
10:41 AM Feature #6253: add file-set processing into p2j.cfg.xml
> > A command like this:
> > [...]
> > will use the @file-set@ configuration from the @cfg/p2j.cfg.xml@ (will assum... Greg Shah

04/18/2022

05:45 AM Bug #5135 (Closed): replace -s, -f and -x options of ConversionDriver with a single combined mode
Greg Shah
05:45 AM Feature #6253 (Closed): add file-set processing into p2j.cfg.xml
Code Review Task Branch 3821c Revision 13788
It is good. Greg Shah

04/16/2022

02:58 PM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
Greg Shah wrote:
> Any amount of whitespace (not just space char) should be ignored.
Please see 3821c/13788. Constantin Asofiei
02:58 PM Feature #6253: add file-set processing into p2j.cfg.xml
The changes are in 3821c/13788. Constantin Asofiei

04/15/2022

08:10 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
Any amount of whitespace (not just space char) should be ignored. Greg Shah
12:55 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
I created a list file for a project. The file contained several lines using the @D@ directive. I noticed there can be... Eric Faulhaber

04/14/2022

04:57 PM Feature #6253: add file-set processing into p2j.cfg.xml
> but recursive makes sense for it to default to 'true'.
Let's do it. Greg Shah
04:56 PM Feature #6253: add file-set processing into p2j.cfg.xml
Code Review Task Branch 3821c Revision 13778
The changes are good.
1. An "include file" has a special meaning i... Greg Shah

04/13/2022

09:20 AM Feature #6203: create cvtpath and move conversion database into that directory
Constantin Asofiei wrote:
> Thanks, I can duplicate it:
> * run @ant convert.list@ with 3821c - name is @MultiLine1... Roger Borrello
09:15 AM Feature #6203: create cvtpath and move conversion database into that directory
Thanks, I can duplicate it:
* run @ant convert.list@ with 3821c - name is @MultiLine1@.
* run @ant clean.all@
* ru... Constantin Asofiei
09:03 AM Feature #6203: create cvtpath and move conversion database into that directory
Constantin Asofiei wrote:
> Roger, please upload to devsrv01 your entire testcases project where you do the conversi... Roger Borrello
04:04 AM Feature #6203: create cvtpath and move conversion database into that directory
Roger, please upload to devsrv01 your entire testcases project where you do the conversion (without the p2j/ folder).... Constantin Asofiei
08:34 AM Feature #6253: add file-set processing into p2j.cfg.xml
Greg Shah wrote:
> Should we make the following common cases the default?
>
> * @recursive="true"@
> * @spec="(*... Constantin Asofiei
08:32 AM Feature #6253 (Review): add file-set processing into p2j.cfg.xml
The changes are in 3821c/13778 for both this task and #5135. Constantin Asofiei
08:28 AM Feature #6253: add file-set processing into p2j.cfg.xml
It looks good.
Should we make the following common cases the default?
* @recursive="true"@
* @spec="(*.[pPwW... Greg Shah
08:15 AM Feature #6253: add file-set processing into p2j.cfg.xml
The @file-set@ in @p2j.cfg.xml@ will look like this:... Constantin Asofiei
08:10 AM Feature #6253: add file-set processing into p2j.cfg.xml
Constantin Asofiei wrote:
> A command like this:
> [...]
> will use the @file-set@ configuration from the @cfg/p2j... Greg Shah
08:09 AM Feature #6253: add file-set processing into p2j.cfg.xml
> I've used @<file-set filename="file-set.txt" />@ (@filename@ instead of @input-file@) because of the dash in @input... Greg Shah
08:08 AM Feature #6253: add file-set processing into p2j.cfg.xml
A command like this:... Constantin Asofiei
08:07 AM Feature #6253: add file-set processing into p2j.cfg.xml
I've used @<file-set filename="file-set.txt" />@ (@filename@ instead of @input-file@) because of the dash in @input-f... Constantin Asofiei
08:32 AM Bug #5135 (Review): replace -s, -f and -x options of ConversionDriver with a single combined mode
The changes are in 3821c/13778 for both this task and #6253. Constantin Asofiei
08:28 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
OK Greg Shah
08:19 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
Z mode is stripping the @./@ prefix, because of some peculiarities when resolving the path (I need the real OS filena... Constantin Asofiei

04/12/2022

04:18 PM Feature #6203: create cvtpath and move conversion database into that directory
Ovidiu Maxiniuc wrote:
> This is odd, at least. Does it happens for a single project? It does not happen for me. It ... Roger Borrello
03:42 PM Feature #6203: create cvtpath and move conversion database into that directory
This is odd, at least. Does it happens for a single project? It does not happen for me. It is a configuration issue, ... Ovidiu Maxiniuc
03:27 PM Feature #6203: create cvtpath and move conversion database into that directory
I'm not sure if this was an intended change, but with the 13732 revision, generated filenames are no longer Camel-Cas... Roger Borrello

04/11/2022

11:25 AM Feature #6270: annotations-based per-file hints
Greg Shah wrote:
> To clarify, I meant that to maintain the WINE environment one must have an original Windows funct... Tijs Wickardt
08:54 AM Feature #6270: annotations-based per-file hints
> > a working Windows configuration
> This seems to be a misunderstanding. I meant:
> Only the binaries that are n... Greg Shah
08:48 AM Feature #6270: annotations-based per-file hints
No need for apologies, these are all valid points.
> a working Windows configuration
This seems to be a misunders... Tijs Wickardt
08:17 AM Feature #6270: annotations-based per-file hints
Every time we add *any* dependency, we add friction in the process of getting everything running properly. For conve... Greg Shah
02:41 AM Feature #6270: annotations-based per-file hints
Greg Shah wrote:
> I don't see the same value in maintaining the @.wrx@ as a resource. It cannot be easily edited, ... Tijs Wickardt

04/10/2022

07:41 PM Feature #6270: annotations-based per-file hints
I don't see the same value in maintaining the @.wrx@ as a resource. It cannot be easily edited, it can only be edite... Greg Shah
02:36 PM Feature #6270: annotations-based per-file hints
Note: https://pkgs.alpinelinux.org/package/edge/community/x86/wine
(and winetricks)
Non edge version (stable): ... Tijs Wickardt
02:16 PM Feature #6270: annotations-based per-file hints
Hynek Cihlar wrote:
> Greg Shah wrote:.
> > > .. interpret .wrx files (for example) the related annotations should ... Tijs Wickardt
12:15 PM Feature #6270: annotations-based per-file hints
Greg Shah wrote:
> > It should be limited only to information that FWD cannot deduce at the conversion.
>
> This... Tijs Wickardt
12:04 PM Feature #6270: annotations-based per-file hints
Greg Shah wrote:
> > It should be limited only to information that FWD cannot deduce at the conversion.
>
> This... Hynek Cihlar
11:14 AM Feature #6270: annotations-based per-file hints
> It should be limited only to information that FWD cannot deduce at the conversion.
This is already the case. W... Greg Shah
11:08 AM Feature #6270: annotations-based per-file hints
I like the idea of using 4GL annotations for FWD runtime hints.
It reduces the chance of an OE developer forgetting ... Tijs Wickardt
09:48 AM Feature #6270: annotations-based per-file hints
Today, we have multiple types of hints at the individual source-file level.
* "UAST Hints" are read from a file th... Greg Shah
09:14 AM Feature #6270 (New): annotations-based per-file hints
Greg Shah

04/08/2022

10:00 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
> I can either use java.nio.Path.toRealPath (if it works) to resolve the real filename at OS level, or otherwise rely... Greg Shah
09:17 AM Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
Another issue: lets assume we are under Windows, where file names are case-insensitive; you have a @F ./Build.p@ line... Constantin Asofiei
07:45 AM Feature #6202: allow .df files to exist in a path that is not directly in data/
> I think the schema @.hints@ should be stored with the @.df@ file, not with @.schema@.
Correct.
> More than t... Greg Shah
 

Also available in: Atom