Project

General

Profile

Activity

From 09/28/2025 to 10/27/2025

10/27/2025

08:38 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
A few issues I found while testing hotel:
* All artifacts were created as BaseArtifact, there's a few places that re...
Dănuț Filimon
04:46 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
Constantin Asofiei wrote:
> Danut, is 10469a still required? I see it was archived as dead.
The fix from 10469a ...
Dănuț Filimon
04:45 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
Danut, is 10469a still required? I see it was archived as dead. Constantin Asofiei

10/24/2025

08:38 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Rebased *7180a* to latest *trunk/16242*, the branch is now at revision *16270*.
Committed *7180a/16271* to make 71...
Dănuț Filimon
07:15 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Committed *7180a/16247-16248*. Removed remaining Configuration dependencies from the ArtifactManager. (refs: #7180)
...
Dănuț Filimon
04:38 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Dănuț Filimon wrote:
> The only issue left is with removing Configuration from the AM and testing.
I have two opt...
Dănuț Filimon

10/23/2025

09:49 AM Bug #4867 (Review): Incremental conversion: change detection algorithm ignores .hints and .ext-hi...
Committed *4867a/16236*. hints and ext-hints files should trigger changes during incremental conversion.
Greg, ple...
Dănuț Filimon
07:42 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
I found https://proj.goldencode.com/projects/p2j/wiki/Chapter_12_Conversion_Hints for reference. Dănuț Filimon
07:40 AM Bug #4867 (WIP): Incremental conversion: change detection algorithm ignores .hints and .ext-hints...
... Dănuț Filimon
07:07 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Here goes another commit to *7180a/16246*! Allow ConversionData to use artifacts, added computeHash() to Artifact, us... Dănuț Filimon

10/22/2025

07:56 AM Bug #10569: Semicolon is skipped while preprocessing
To be a bit more clear: we have applications that use a 4GL quirk where @'@ and @"@ characters can be embedded inside... Greg Shah
06:18 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Committed *7180a/16245*. Addressed the rebase issues, compatibility changes and most of the review points from #7180-... Dănuț Filimon
05:47 AM Feature #6083 (Closed): schema (.df) changes in incremental conversion mode should only reconvert...
Greg Shah
05:47 AM Bug #6738 (Closed): incremental conversion when deleting program or class files
Greg Shah
05:46 AM Bug #9917 (Closed): Fileset not ignoring case
Greg Shah

10/21/2025

09:11 AM Feature #10265 (Test): schema-only conversion
Branch 10265a was merged into trunk as rev. 16227 and archived. Dănuț Filimon
09:07 AM Feature #10265 (Merge Pending): schema-only conversion
Dănuț Filimon
05:32 AM Feature #10265: schema-only conversion
Tested conversion and incremental with ETF, ChUI and 3 other customer applications. No issues found. Dănuț Filimon
05:38 AM Bug #10626: DMO names can collide on case-insensitive file-system
Dănuț Filimon wrote:
> I did a conversion with a customer application and forwarded the jars to Artur for testing, w...
Dănuț Filimon
05:33 AM Bug #10626: DMO names can collide on case-insensitive file-system
I did a conversion with a customer application and forwarded the jars to Artur for testing, where he found 3 tests fa... Dănuț Filimon
02:38 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Ovidiu Maxiniuc wrote:
>
> In your example, the key was @aced000[...]@ - (apparently) the same for all entries, so...
Octavian Adrian Gavril

10/20/2025

04:38 PM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
I think the @key@ column should be part of the @key@ in @workInsertSql@ statement, to match the unique index.
<pre...
Ovidiu Maxiniuc
10:59 AM Bug #10569: Semicolon is skipped while preprocessing
I don't think this change is OK. I deliberately excluded those chars from that rule (i.e. @// it is OK to match " or... Greg Shah
08:56 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Fixed number 1, 2, 6.
I am a bit stuk at 9, getting the Configuration out of the AM. I have to move Configuration....
Dănuț Filimon

10/17/2025

05:17 AM Bug #10639 (Review): Incremental conversion - unexpected DMO generation for space-only changes
I analyzed the current implementation that handles insertions in @H2Map@. I changed the @INSERT@ statement with @MERG... Octavian Adrian Gavril
03:01 AM Bug #10639 (WIP): Incremental conversion - unexpected DMO generation for space-only changes
Octavian Adrian Gavril
02:46 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Alexandru Lungu wrote:
>
> I understand the change and it looks functionally right to me (especially after re-read...
Octavian Adrian Gavril
04:50 AM Bug #10569 (Review): Semicolon is skipped while preprocessing
This is the patch I used to solve the issue. Both the testcases and the application scenario are fine with it. Intere... Radu Apetrii

10/16/2025

10:13 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Alexandru Lungu wrote:
> I understand the change and it looks functionally right to me (especially after re-readin...
Octavian Adrian Gavril
06:23 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
> Alex: Please review.
I understand the change and it looks functionally right to me (especially after re-reading ...
Alexandru Lungu
09:13 AM Bug #10626 (Internal Test): DMO names can collide on case-insensitive file-system
Greg Shah
09:07 AM Bug #10626: DMO names can collide on case-insensitive file-system
Greg Shah wrote:
> Code Review Task Branch 10626a Revision 16221
>
> I don't have a problem with the changes. Pl...
Dănuț Filimon
09:01 AM Bug #10626: DMO names can collide on case-insensitive file-system
Code Review Task Branch 10626a Revision 16221
I don't have a problem with the changes. Please help me understand ...
Greg Shah
02:30 AM Bug #10626 (Review): DMO names can collide on case-insensitive file-system
Greg, please review. Dănuț Filimon
02:29 AM Bug #10626: DMO names can collide on case-insensitive file-system
Dănuț Filimon wrote:
> Greg Shah wrote:
> > Is this ready for review? What is the % Done?
>
> I looked into th...
Dănuț Filimon
07:20 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
> The following pattern:
> [...] where an artifact is created to call loadTree() is because loadTree() takes an Arti...
Greg Shah
07:08 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
The following pattern:... Dănuț Filimon
04:10 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I managed to make 7180a build, but I don't like a few changes so I'll be working a bit on 7180a and also take care of... Dănuț Filimon

10/15/2025

02:16 PM Feature #10726: calculate and report code quality metrics
We will implement multiple calculations of code quality using TRPL (and possibly a subset of call graph analysis). T... Greg Shah
01:50 PM Feature #10726 (New): calculate and report code quality metrics
Greg Shah
08:52 AM Feature #7180 (WIP): create a centralized manager for the conversion list and per-file/project st...
Rebased *7180a* to latest *trunk/16220*, the branch is now at revision *16244*. I'll have to commit a few compatibili... Dănuț Filimon
05:44 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg Shah wrote:
> Code Review Task Branch 7180a Revisions 16121 through 16139
I plan to rebase and address a few...
Dănuț Filimon
07:02 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Alex: Please review. Greg Shah
06:37 AM Bug #10626: DMO names can collide on case-insensitive file-system
Greg Shah wrote:
> Is this ready for review? What is the % Done?
I looked into the ChUI project for some other ...
Dănuț Filimon
06:31 AM Bug #10626: DMO names can collide on case-insensitive file-system
Is this ready for review? What is the % Done? Greg Shah
04:50 AM Bug #10626: DMO names can collide on case-insensitive file-system
Committed *10626a/16221*. Generates names for menus, sub-menus, dmos, pojos, frames that do not collide in case-insen... Dănuț Filimon

10/14/2025

12:40 PM Feature #10701: implement support for generative AI code assist
For some time now, I've been expecting that we would write some kind of plugin to integrate with popular gen AI envir... Greg Shah
10:42 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Code Review Task Branch 7180a Revisions 16121 through 16139
This is really good. We are getting close.
1. @ann...
Greg Shah
09:40 AM Bug #10626: DMO names can collide on case-insensitive file-system
Dănuț Filimon wrote:
> I discussed with Octavian and he mentioned I could use @createString2StringMap@ to get a map ...
Dănuț Filimon
07:21 AM Bug #10626: DMO names can collide on case-insensitive file-system
I discussed with Octavian and he mentioned I could use @createString2StringMap@ to get a map across other rules. I ha... Dănuț Filimon
06:14 AM Bug #10626: DMO names can collide on case-insensitive file-system
I thought of using another set of rules to store a case sensitive map that maps the namings, but I don't think this i... Dănuț Filimon
03:44 AM Bug #10626: DMO names can collide on case-insensitive file-system
This bit of code:... Dănuț Filimon
03:20 AM Bug #10626: DMO names can collide on case-insensitive file-system
The issue with menus starts with this piece of code:... Dănuț Filimon
06:09 AM Bug #10469 (Test): incremental conversion when basepath is more than one folder (aka abl/foo) wit...
Branch 6083a was merged to trunk revision 16220 and archived. Dănuț Filimon
06:08 AM Bug #6738 (Test): incremental conversion when deleting program or class files
Branch 6083a was merged to trunk revision 16220 and archived. Dănuț Filimon
06:07 AM Feature #6083 (Test): schema (.df) changes in incremental conversion mode should only reconvert t...
Branch 6083a was merged to trunk revision 16220 and archived. Dănuț Filimon
05:36 AM Feature #6083 (Merge Pending): schema (.df) changes in incremental conversion mode should only re...
You can merge 6083a to trunk now. Alexandru Lungu

10/13/2025

07:32 AM Bug #10626: DMO names can collide on case-insensitive file-system
I setup and tested POJOs on hotel and found no issues, the hotel.p2o ends up using the correct class names (FooBarSom... Dănuț Filimon
05:47 AM Bug #10626: DMO names can collide on case-insensitive file-system
Dănuț Filimon wrote:
> Perfect, I'll just have to implement the contains() method for CaseInsensitiveHashMap in this...
Dănuț Filimon
05:44 AM Bug #10626: DMO names can collide on case-insensitive file-system
Constantin Asofiei wrote:
> Dănuț Filimon wrote:
> > Constantin Asofiei wrote:
> > > We need to generate the same ...
Dănuț Filimon
05:16 AM Bug #10626: DMO names can collide on case-insensitive file-system
Dănuț Filimon wrote:
> Constantin Asofiei wrote:
> > We need to generate the same .java names regardless of OS - so...
Constantin Asofiei
05:15 AM Bug #10626: DMO names can collide on case-insensitive file-system
Constantin Asofiei wrote:
> We need to generate the same .java names regardless of OS - so I think that collection n...
Dănuț Filimon
05:08 AM Bug #10626: DMO names can collide on case-insensitive file-system
We need to generate the same .java names regardless of OS - so I think that collection needs to be case-insensitive, ... Constantin Asofiei
04:50 AM Bug #10626 (WIP): DMO names can collide on case-insensitive file-system
Error from windows:... Dănuț Filimon

10/10/2025

09:32 AM Feature #10701 (New): implement support for generative AI code assist
Greg Shah
09:28 AM Feature #3703: implement TRPL based linting support
Although my initial idea was to implement these as reports, it is likely that the reporting/analytics will migrate in... Greg Shah
09:25 AM Feature #10700: expose analytics features in our IDE support
Maintaining a separate web UI for analytics is extra work for us and inconvenient for our users. A better solution i... Greg Shah
09:18 AM Feature #10700 (New): expose analytics features in our IDE support
Greg Shah
08:36 AM Bug #10626: DMO names can collide on case-insensitive file-system
Good, opsys is out of the question.
I converted the two tables, Foo_BARSomething and Foo_BAR_Something, and got a ...
Dănuț Filimon
07:21 AM Bug #10626: DMO names can collide on case-insensitive file-system
We shouldn't change the output based on the OPSYS setting. The output should be the same always (safe for case-insen... Greg Shah
07:07 AM Bug #10626: DMO names can collide on case-insensitive file-system
We use @opsys@ to determine what OS is being used (default is Unix OS). opsys can be set in @p2j.cfg.xml@, so there's... Dănuț Filimon
06:08 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
Code Review Task Branch 6083a Revision 16224
No objection.
Greg Shah
03:08 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
Committed *6083a/16224*. Fixed file copy and file separator. Dănuț Filimon
06:05 AM Feature #10265: schema-only conversion
Code Review Task Branch 10265a Revision 16215
It looks good.
Greg Shah
06:02 AM Feature #10265 (Internal Test): schema-only conversion
Greg Shah wrote:
> Code Review Task Branch 10265a Revision 16214
>
> This is good. The only change that may be n...
Dănuț Filimon
05:21 AM Feature #10265: schema-only conversion
Code Review Task Branch 10265a Revision 16214
This is good. The only change that may be needed is to output somet...
Greg Shah

10/09/2025

08:31 AM Bug #10626: DMO names can collide on case-insensitive file-system
Dănuț Filimon wrote:
> I've made a similar patch to #10626-2 in #9917, it was for the frames and menus (explained th...
Constantin Asofiei
08:26 AM Bug #10626: DMO names can collide on case-insensitive file-system
I've made a similar patch to #10626-2 in #9917, it was for the frames and menus (explained the issue in #9917-10, the... Dănuț Filimon
06:01 AM Bug #10569: Semicolon is skipped while preprocessing
Radu Apetrii wrote:
> Alex/Danut: if you don't plan on assigning this issue to somebody from your team, can you plea...
Dănuț Filimon
05:58 AM Bug #10569: Semicolon is skipped while preprocessing
Alex/Danut: if you don't plan on assigning this issue to somebody from your team, can you please suggest a place wher... Radu Apetrii
03:50 AM Feature #10265: schema-only conversion
Rebased *10265a* to latest *trunk/16212*, the branch is now at revision *16214*. Dănuț Filimon
03:41 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Dănuț Filimon wrote:
> Octavian, please check #10536-27 - #10536-32 and #10536-38 - #10536-39.
I included that pa...
Octavian Adrian Gavril
03:14 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Octavian, please check #10536-27 - #10536-32 and #10536-38 - #10536-39. Dănuț Filimon

10/08/2025

05:59 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
Greg Shah wrote:
> Code REview Task Branch 6083a Revision 1622
>
> I'm fine with the changes.
>
> Please do en...
Dănuț Filimon
04:58 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
Code Review Task Branch 6083a Revision 1622
I'm fine with the changes.
Please do enough testing to confirm it i...
Greg Shah
03:57 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
Dănuț Filimon wrote:
> Greg Shah wrote:
> > I have reconsidered the @name_map.xml@ changes. It was my mistake to f...
Dănuț Filimon
03:02 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Ovidiu Maxiniuc wrote:
> Review of 10639a/16189.
> The code should work now. But I do not understand the usage of @...
Octavian Adrian Gavril

10/07/2025

02:49 PM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
I can confirm your observation that the _2 and subsequent interfaces are no longer created.
Therefore I studied a ...
Ovidiu Maxiniuc
09:45 AM Bug #10639 (Review): Incremental conversion - unexpected DMO generation for space-only changes
I've committed the last proposed solution in *10639a/16189*. I followed the suggestions from #10639-19 to modify the ... Octavian Adrian Gavril
10:09 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
Greg Shah wrote:
> I have reconsidered the @name_map.xml@ changes. It was my mistake to force that into this task. ...
Dănuț Filimon
10:01 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
I have reconsidered the @name_map.xml@ changes. It was my mistake to force that into this task. Please separate tha... Greg Shah

10/06/2025

07:30 AM Bug #10678: ~u#### escape sequences which have no equivalent in the cpinternal should be not con...
Testcase:
cpinternal = ISO8859-1...
Delia Mitric
07:29 AM Bug #10678 (New): ~u#### escape sequences which have no equivalent in the cpinternal should be n...
Delia Mitric

10/03/2025

06:11 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Indeed, that is a puzzle. Try to remove the @build/@ folder and reconvert/recompile the project again. Some classes m... Ovidiu Maxiniuc
02:30 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Ovidiu Maxiniuc wrote:
> Because @v1@'s definition has an additional @initial "desc"@, FWD decides the tables are no...
Octavian Adrian Gavril
02:20 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Greg Shah wrote:
> We should be converting everything dependent upon the @Tt_1.java@ when it gets reconverted.
Ye...
Octavian Adrian Gavril

10/02/2025

11:44 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Because @v1@'s definition has an additional @initial "desc"@, FWD decides the tables are not compatible. I think this... Ovidiu Maxiniuc
11:07 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
We should be converting everything dependent upon the @Tt_1.java@ when it gets reconverted. If we don't include all ... Greg Shah
08:57 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Does anyone know how could I generate this kind of hierarchy: @Tt_1.java@, @Tt_1_1.java@ and @Tt_1_2.java@?
@start...
Octavian Adrian Gavril

10/01/2025

06:43 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Greg Shah wrote:
> Danut has changes in this area in 6083a.
I tested Danut's changes but the issue is not fixed. ...
Octavian Adrian Gavril
05:03 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Danut has changes in this area in 6083a. Greg Shah
04:42 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Constantin Asofiei wrote:
> I would go a different way: is OK to re-generate all DMOs, but the name should be preser...
Octavian Adrian Gavril
04:36 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
I would go a different way: is OK to re-generate all DMOs, but the name should be preserved *if the key matches*. Ma... Constantin Asofiei
04:11 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
... Octavian Adrian Gavril

09/30/2025

10:02 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Make sure that we aren't duplicating work that was already done in 6083a. Greg Shah
08:42 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
It seems that @pre_tmpTabNames_work@ is the one that doesn't contain @Tt_1.java@, not @pre_tmpTabNames@. Octavian Adrian Gavril
08:17 AM Bug #10639 (WIP): Incremental conversion - unexpected DMO generation for space-only changes
The root cause of not considering @Tt_1.java@ is that when @p2o_pre.xml@ is executed and @pre_tmpTabNames@ is created... Octavian Adrian Gavril
08:12 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
I don't recall exactly when, but this was a known 'limitation' of incremental conversion, from few years back. I thi... Constantin Asofiei
08:11 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Use the following testcase:
@a.p@:...
Octavian Adrian Gavril
08:01 AM Bug #10639 (Review): Incremental conversion - unexpected DMO generation for space-only changes
Octavian Adrian Gavril
 

Also available in: Atom