Project

General

Profile

Activity

From 11/01/2025 to 11/30/2025

11/28/2025

12:53 PM Bug #10919: the source/AST view is broken in the Analytics web UI
Dănuț Filimon wrote:
> Thanks Roger, is there any testing I can do aside from running the report server for Hotel?
... Roger Borrello
08:15 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Thank you, Ovidiu. I asked this because we need to create @helper methods@ that allow us to build the AST directly fr... Paula Păstrăguș
05:47 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
During the transpiling from 4GL to Java, FWD parser and TRPL rules will add these additional nodes. The semantic of t... Ovidiu Maxiniuc
04:15 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
I have a question regarding artificial nodes. These are the nodes that the grammar creates manually, for example usin... Paula Păstrăguș
03:21 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Regarding the shadow nodes: the @left@ and @right@ IDs are used to locate the nearest AST node for each shadow node, ... Paula Păstrăguș
03:16 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Ovidiu Maxiniuc wrote:
> I do not think we should use @left@ and @right@. The resulting tree is not always binary.
... Paula Păstrăguș

11/27/2025

08:39 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
I do not think we should use @left@ and @right@. The resulting tree is not always binary. One node may have multiple ... Ovidiu Maxiniuc
04:51 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Another thing I noticed: I added the shadows nodes to the list after the @left@ and @right@ IDs were populated, which... Paula Păstrăguș
04:24 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
During testing, I realized I forgot to assign the @parent AST@ to the shadow nodes. Right now, they’re orphans:), so ... Paula Păstrăguș
08:25 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...
This @root@ is built in @ProgressParser.oea_annotation(), line 10017@:... Dănuț Filimon
06:36 AM Feature #7851 (WIP): automatically add to conversion list all classes referenced via unit test su...
Dănuț Filimon
05:28 AM Feature #7318: prevent abend during conversion in case of failures when processing TRPL rules
#6889 only has the changes for incremental conversion, making this available for all conversions is easy as it only r... Dănuț Filimon
02:58 AM Bug #10919 (Internal Test): the source/AST view is broken in the Analytics web UI
Thanks Roger, is there any testing I can do aside from running the report server for Hotel? Dănuț Filimon

11/26/2025

10:08 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Thanks, Greg, I had misunderstood that part. I’ve been working on adapting the @TreeLocal@, the @ShadowNode@, and the... Paula Păstrăguș
08:53 AM Bug #10919: the source/AST view is broken in the Analytics web UI
Dănuț Filimon wrote:
> Roger Borrello wrote:
> > So you start the web server as: @./deploy/server/report.sh@?
>
... Roger Borrello
08:46 AM Bug #10919: the source/AST view is broken in the Analytics web UI
Roger Borrello wrote:
> So you start the web server as: @./deploy/server/report.sh@?
No, like this: @~/gcd/branch... Dănuț Filimon
08:44 AM Bug #10919: the source/AST view is broken in the Analytics web UI
So you start the web server as: @./deploy/server/report.sh@? Roger Borrello
07:35 AM Bug #10919: the source/AST view is broken in the Analytics web UI
Roger, this is the final patch:... Dănuț Filimon
07:05 AM Bug #10919: the source/AST view is broken in the Analytics web UI
I'm OK with the idea. Please add comments to make it clear that the @ReportWebServer@ MUST be executed with the proj... Greg Shah
03:49 AM Bug #10919: the source/AST view is broken in the Analytics web UI
I fixed this in the @report.sh@ script:... Dănuț Filimon
03:20 AM Bug #6889 (Review): rollback the files as 'unconverted' if (incremental) conversion fails.
I addressed the review from #6889-11 in *6889a/16269*.
Greg, please review. Dănuț Filimon

11/25/2025

10:11 AM Bug #10919: the source/AST view is broken in the Analytics web UI
Above, I was saying @ReportDriver@ but that was a mistake. I meant @ReportWebServer@.
If the files are being read... Greg Shah
09:09 AM Bug #10919: the source/AST view is broken in the Analytics web UI
Greg Shah wrote:
> > No, it will just remove home from the path. We already have home which is the relative path tha... Dănuț Filimon
08:53 AM Bug #10919: the source/AST view is broken in the Analytics web UI
> No, it will just remove home from the path. We already have home which is the relative path that we need, so I don'... Greg Shah
08:40 AM Bug #10919: the source/AST view is broken in the Analytics web UI
Greg Shah wrote:
> Won't this be a problem when we reach the @if (absolute.startsWith(home))@ code later in that met... Dănuț Filimon
07:41 AM Bug #10919: the source/AST view is broken in the Analytics web UI
Also, assuming @home@ is always the same value, can't @home = new File(home).getCanonicalPath();@ be calculated at st... Greg Shah
07:40 AM Bug #10919: the source/AST view is broken in the Analytics web UI
Won't this be a problem when we reach the @if (absolute.startsWith(home))@ code later in that method? Why not have t... Greg Shah
04:03 AM Bug #10919: the source/AST view is broken in the Analytics web UI
I've got @./abl/fwd-embedded-driver.p@ which is normalized to @./deploy/server/abl/fwd-embedded-driver.p@. My initial... Dănuț Filimon
07:55 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
I think you are conflating parse-time processing with TRPL-processing. During TRPL, the AST *must have* the shadow n... Greg Shah
05:54 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Greg, I reviewed the @hidden@ field, the @ShadowNode@ structure, and the entire @TreeLocal@ mechanism. The conclusion... Paula Păstrăguș
06:00 AM Bug #6889 (WIP): rollback the files as 'unconverted' if (incremental) conversion fails.
Dănuț Filimon
06:00 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.
Greg Shah wrote:
> Code Review Task Branch 6889a Revisions 16267 and 16268
>
> 1. Shouldn't @cleanSources()@ be c... Dănuț Filimon

11/24/2025

10:34 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Aaand this is the output of a @dumpTree(true)@ for this input: @"1 + 2 * 3 + 4 * 5"@
Related java testing code:
<pr... Paula Păstrăguș
10:31 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Greg, I've pushed a new version of @10804a@. You should now be able to see the new classes. I've fully separated the ... Paula Păstrăguș
08:42 AM Bug #10928: Skip some parsing rules from runtime parsing
In #10919, Danut identified some cases where the conversion database was generated at run-time. This was because cert... Alexandru Lungu
08:35 AM Bug #10928 (New): Skip some parsing rules from runtime parsing
Alexandru Lungu
07:23 AM Bug #10919 (WIP): the source/AST view is broken in the Analytics web UI
The solution from #10919-6 is not correct, I tested it a little bit more and I ended up with @/home/ddf/gcd/branches/... Dănuț Filimon
04:10 AM Bug #10919 (Review): the source/AST view is broken in the Analytics web UI
Committed a simple fix to *10919a/16292*. The issue is with normalizeFilename(), the abnormal File is initialized wit... Dănuț Filimon
03:35 AM Bug #10919: the source/AST view is broken in the Analytics web UI
The error is the same one mentioned in #10784-1. Octavian found a workaround for this, but I will see if I can fix it. Dănuț Filimon
02:55 AM Bug #10919 (WIP): the source/AST view is broken in the Analytics web UI
I am investigating. Dănuț Filimon

11/21/2025

03:39 PM Bug #10919: the source/AST view is broken in the Analytics web UI
The @.cache@ and @.p.ast@ files do exist, but they are in @./cvt/@ instead of @./abl/@ which is probably the issue. Greg Shah
03:38 PM Bug #10919: the source/AST view is broken in the Analytics web UI
I suspect this is a bug from our recent #5586 changes.
Running reports in Hotel GUI completes properly. You can l... Greg Shah
03:30 PM Bug #10919 (Test): the source/AST view is broken in the Analytics web UI
Greg Shah
10:20 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Greg, I updated the wiki and pushed the new interface and implementation to 10804a. You should now be able to access ... Paula Păstrăguș
08:06 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Yes, you’re right! I’ll take care of it. Really appreciate the detailed guidance. Paula Păstrăguș
08:03 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Paula Păstrăguș wrote:
> My suggestion is to wait until the end of the day, so I can finish covering most of the met... Greg Shah
07:56 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Paula Păstrăguș wrote:
> I think creating a table will help clarify things for both of us. At this point, I’ve gone ... Greg Shah
05:06 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
My suggestion is to wait until the end of the day, so I can finish covering most of the methods, prepare the comparis... Paula Păstrăguș
04:49 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
I think creating a table will help clarify things for both of us. At this point, I’ve gone through the ascent/descent... Paula Păstrăguș
03:12 AM Feature #10804 (WIP): create replacement AST implementation for use with ANTLR 4
Greg, I attached the ZIP containing the test project. Inside you will find both approaches: the visitor-based impleme... Paula Păstrăguș
10:02 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.
Code Review Task Branch 6889a Revisions 16267 and 16268
1. Shouldn't @cleanSources()@ be called at the end of @pro... Greg Shah
08:47 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.
Committed a null check in *6889a/16268*. Dănuț Filimon
08:36 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.
I got a few questions:
* Considering #7318/#7179, should we remove files from conversion even if we are not running ... Dănuț Filimon
05:56 AM Bug #6889 (Review): rollback the files as 'unconverted' if (incremental) conversion fails.
Committed *6889a/16267*. Rollback source files that failed processing during incremental conversion.
Greg, please ... Dănuț Filimon
08:57 AM Bug #10912: Cannot invoke "java.lang.Class.isAssignableFrom(java.lang.Class)" because "calleeType...
Alex, the fix is this:... Constantin Asofiei
06:53 AM Bug #10912: Cannot invoke "java.lang.Class.isAssignableFrom(java.lang.Class)" because "calleeType...
My change seems to be too old to not be included in 7156e, so I suspect it is a later change.... Șerban Bursuc
06:50 AM Bug #10912: Cannot invoke "java.lang.Class.isAssignableFrom(java.lang.Class)" because "calleeType...
... Alexandru Lungu
06:47 AM Bug #10912 (Test): Cannot invoke "java.lang.Class.isAssignableFrom(java.lang.Class)" because "cal...
Alexandru Lungu
08:13 AM Bug #4867 (Test): Incremental conversion: change detection algorithm ignores .hints and .ext-hint...
Branch 4867a was merged into trunk as rev. 16290 and archived. Dănuț Filimon
07:48 AM Bug #4867 (Merge Pending): Incremental conversion: change detection algorithm ignores .hints and ...
Merge after 10695a. Greg Shah
04:08 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
Tested the customer application, no issues found. *4867a* can be merged. Dănuț Filimon
06:33 AM Feature #7318: prevent abend during conversion in case of failures when processing TRPL rules
Constantin Asofiei wrote:
> Danut, please see some changes from 9457c: @bzr status -r 16245..16270@ - there are eith... Dănuț Filimon
06:28 AM Feature #7318: prevent abend during conversion in case of failures when processing TRPL rules
Danut, please see some changes from 9457c: @bzr status -r 16245..16270@ - there are either some commented code or abe... Constantin Asofiei

11/20/2025

09:12 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
Customer conversion will be complete tomorrow morning, I'll be able to test incremental then and confirm the fix. Dănuț Filimon

11/19/2025

04:56 PM Feature #10804: create replacement AST implementation for use with ANTLR 4
> I’m not sure how this translates to the Progress grammar for example, since the grafting logic there depends much ... Greg Shah
11:06 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Greg, I’m still a bit unclear on how to properly test these changes. I created a small separate project with a simple... Paula Păstrăguș

11/18/2025

06:22 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
Please test at least one of the large customer GUI applications. As Vladimir notes, the @.ext-hints@ are used there ... Greg Shah
05:26 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
Dănuț Filimon wrote:
> I tested ChUI conversion and incremental and found no issues, are there any other projects th... Vladimir Tsichevski
04:28 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
I tested ChUI conversion and incremental and found no issues, are there any other projects that use hint files? Dănuț Filimon
06:20 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.
For the rest of the incremental conversion process, I though of letting the PatternEngine.run() throw and catch error... Dănuț Filimon

11/17/2025

09:40 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
Committed *4867a/16237* to add a comment. Dănuț Filimon
08:52 AM Bug #4867 (Internal Test): Incremental conversion: change detection algorithm ignores .hints and ...
Code Review Task branch 4867a Revision 16236
The changes are good.
In @mustConvertFile()@, before line 818 (@if... Greg Shah

11/13/2025

03:13 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.
If incremental conversion fails during the @Scanning Progress Source (preprocessor, lexer, parser, persist ASTs)@ pha... Dănuț Filimon

11/12/2025

08:49 AM Bug #6889 (WIP): rollback the files as 'unconverted' if (incremental) conversion fails.
Dănuț Filimon
06:17 AM Bug #10850: getAst() usage from TRPL must be read-only
Greg, the idea here is to mark ASTs returned by @getAst@ as read-only but only if this is a @ProgressAst@ - the other... Constantin Asofiei
05:47 AM Bug #10850: getAst() usage from TRPL must be read-only
There's a scenario where @getAst()@ using the id of a tree, then that ast is modified. The ast can be modified, but t... Dănuț Filimon
05:34 AM Bug #10850 (New): getAst() usage from TRPL must be read-only
Dănuț Filimon

11/11/2025

03:03 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Ovidiu Maxiniuc wrote:
> If we 'merge' using a key formed only from @fileId, astId@, this structure will be able to ... Octavian Adrian Gavril

11/10/2025

12:14 PM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Ultimately, @H2Map@ is a @HashMap@, which means it should associate values to keys. Here is the @put()@ method:
<pre... Ovidiu Maxiniuc
07:08 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Ovidiu, is there something left to assess? Alexandru Lungu

11/07/2025

12:27 AM Feature #10190 (Internal Test): Prototype the changes to the build to add ANTLR v4
Code Review Task Branch 10190a Revision 16003
The changes look good. Greg Shah

11/06/2025

09:36 AM Bug #6629 (Review): incremental conversion for OpenClient proxy programs
Committed *6629a/16252*. Added support for deleting program configurations.
Constantin, please review. Dănuț Filimon
09:10 AM Feature #10190 (Review): Prototype the changes to the build to add ANTLR v4
Committed as rev *16003*.
Greg, please review. Paula Păstrăguș
03:29 AM Feature #10190: Prototype the changes to the build to add ANTLR v4
> There seems to be a small typo, when the grammar is not up to date, the log message displays two consecutive 'not' ... Greg Shah
02:48 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
> In ANTLR 4 there’s no @CommonAST@. The parser only produces a @ParseTree@, so if we want an AST-like structure, we’... Greg Shah

11/05/2025

09:37 AM Bug #6629: incremental conversion for OpenClient proxy programs
Dănuț Filimon wrote:
> One issue with deleting a program configuration file is that deleting it will not cause all a... Dănuț Filimon
08:08 AM Bug #6629: incremental conversion for OpenClient proxy programs
One issue with deleting a program configuration file is that deleting it will not cause all associated program files ... Dănuț Filimon
05:02 AM Bug #6629: incremental conversion for OpenClient proxy programs
Committed *6629a/16251*. Initial implementation for incremental conversion of proxy/soap/rest/web program configurati... Dănuț Filimon
05:03 AM Feature #10190: Prototype the changes to the build to add ANTLR v4
I've checked out the branch and I have a few questions regarding the current approach:
* There seems to be a small... Paula Păstrăguș

11/04/2025

12:10 PM Feature #10804: create replacement AST implementation for use with ANTLR 4
Greg, let me summarize to make sure I’ve got the idea right, please let me know if this matches your vision:
* In ... Paula Păstrăguș
07:40 AM Bug #6629: incremental conversion for OpenClient proxy programs
Incremental conversion is working, I plan to cleanup the implementation and see if there are any improvements that I ... Dănuț Filimon

11/03/2025

07:50 AM Bug #6629: incremental conversion for OpenClient proxy programs
Dănuț Filimon wrote:
> I looked over the REST operations, procedures and internal procedures are used and some of th... Dănuț Filimon
07:35 AM Bug #6629: incremental conversion for OpenClient proxy programs
I looked over the REST operations, procedures and internal procedures are used and some of them only have their name ... Dănuț Filimon
07:30 PM Feature #10804: create replacement AST implementation for use with ANTLR 4
We must replace our @AnnotatedAst@ class with a new implementation that does not derive from @antlr.CommonAST@. In A... Greg Shah
07:13 PM Feature #10804 (Review): create replacement AST implementation for use with ANTLR 4
Greg Shah
07:21 PM Feature #1757: update ANTLR to latest version
We will continue to discuss and consider this issue of how we handle the IDE (from the parse tree or the AST...) but ... Greg Shah
07:10 PM Feature #1757: update ANTLR to latest version
> If we compare the two images, we can see that the tree generated by ANTLR v4 is deeper (depth 4) and more detailed ... Greg Shah
07:00 PM Feature #1757: update ANTLR to latest version
Alexandru Lungu wrote:
> > the adapter will simply take the ANTLR 4 parse tree and convert it into the annotated AST... Greg Shah

11/02/2025

06:45 PM Feature #1757: update ANTLR to latest version
Let me provide some additional context about our work here.
1. Our requirements will likely be set by the 4GL pr... Greg Shah
05:10 PM Feature #1757: update ANTLR to latest version
> I had an in-depth discussion with Alex,
I appreciate this, but please note that I am leading this effort directl... Greg Shah
 

Also available in: Atom