Project

General

Profile

Activity

From 04/08/2025 to 05/07/2025

05/07/2025

11:28 AM Support #6860: lexer tests
> Besides making sure it's safe to run many tests in parallel and actually running them with harness test plans, no t... Greg Shah
04:10 AM Support #6860: lexer tests
Marian Edu wrote:
> There are some basic expression 'literals' tests in @tests/expressions/TestLiterals@, quoted v...
Florin Eugen Rotaru
04:01 AM Support #6860: lexer tests
Greg Shah wrote:
> Code Review Task Branch 6860a Revision 15888
>
> The code is good.
>
> The changes are pret...
Florin Eugen Rotaru

05/06/2025

10:45 AM Support #6860: lexer tests
Greg Shah wrote:
> > quoted values aren't allowed for dates
>
> There is an exception to this. In OE (and FWD), ...
Marian Edu
10:29 AM Support #6860 (Internal Test): lexer tests
Code Review Task Branch 6860a Revision 15888
The code is good.
The changes are pretty safe. What testing has b...
Greg Shah
10:26 AM Support #6860: lexer tests
> quoted values aren't allowed for dates
There is an exception to this. In OE (and FWD), the @INITIAL@ clause of ...
Greg Shah
10:21 AM Support #6860: lexer tests
Greg Shah wrote:
> Feedback on the tests:
>
> * The date tests are missing a large number of cases that can be fo...
Marian Edu
10:16 AM Support #6860: lexer tests
Greg Shah wrote:
> Code Review Task Branch 6860a REvision 15887
>
> Please remove @import com.goldencode.p2j.uast...
Florin Eugen Rotaru
09:57 AM Support #6860: lexer tests
Code Review Task Branch 6860a REvision 15887
Please remove @import com.goldencode.p2j.uast.LexerOptions;@ from @Le...
Greg Shah
09:24 AM Support #6860: lexer tests
Greg Shah wrote:
> Code Review Task Branch 6860a Revisions 15884 through 15886
>
> @LexerTestDriver@:
>
> * us...
Florin Eugen Rotaru
08:43 AM Support #6860: lexer tests
Please rename @LexerTestOptions@ to @LexerOptions@ and move it back to the @uast@ package so that we don't have refer... Greg Shah
08:38 AM Support #6860: lexer tests
Code Review Task Branch 6860a Revisions 15884 through 15886
@LexerTestDriver@:
* use wildcard imports
* add ja...
Greg Shah
08:26 AM Support #6860: lexer tests
Feedback on the tests:
* The date tests are missing a large number of cases that can be found in @date.main()@. W...
Greg Shah
06:48 AM Support #6860: lexer tests
For some reason, the previous commit did not push the files. I did another commit (see #1889-12) and it succeeded.
...
Florin Eugen Rotaru
06:46 AM Feature #1889 (WIP): rework the date.java internal tests as real unit tests
Florin Eugen Rotaru
06:46 AM Feature #1889: rework the date.java internal tests as real unit tests
Greg Shah wrote:
> In addition to moving these tests into ABLUnit, please create lexer tests for each of the literal...
Florin Eugen Rotaru

05/05/2025

10:05 AM Feature #1889: rework the date.java internal tests as real unit tests
I commited to @tests/primitive_type/date/@ the classes @MdyDateTests.cls@, @YmdDateTests.cls@ which contain one Test ... Florin Eugen Rotaru

05/03/2025

01:09 PM Feature #1889: rework the date.java internal tests as real unit tests
Additionally, there are several standard non-4GL JUnit5 test classes within the FWD framework, located in the @test/@... Vladimir Tsichevski
12:54 PM Feature #1889: rework the date.java internal tests as real unit tests
There are also a number of 4GL test classes I wrote for @DATE@ type and date @FILL-IN@-related issues. Some are linke... Vladimir Tsichevski
10:12 AM Feature #1889: rework the date.java internal tests as real unit tests
In addition to moving these tests into ABLUnit, please create lexer tests for each of the literal values AND ensure t... Greg Shah

04/30/2025

05:04 AM Support #6860 (Review): lexer tests
Florin Eugen Rotaru wrote:
> I have pushed all the tests we have so far on @testcases/tests/conversion/lexer@. I wil...
Florin Eugen Rotaru

04/25/2025

02:51 AM Support #6860: lexer tests
I have pushed all the tests we have so far on @testcases/tests/conversion/lexer@. I will write harness test plans for... Florin Eugen Rotaru

04/23/2025

05:28 PM Bug #9338 (Closed): Import JUnit test report back into Harness
Greg Shah
05:25 PM Bug #9338: Import JUnit test report back into Harness
Greg Shah wrote:
> This can be closed, right?
Yes please
Tomasz Domin
01:58 PM Bug #9338: Import JUnit test report back into Harness
This can be closed, right? Greg Shah
09:51 AM Bug #9338 (Internal Test): Import JUnit test report back into Harness
Tomasz Domin
09:50 AM Bug #9338: Import JUnit test report back into Harness
Updated [[Harness:Documentation]] to include @junit-import@ test. Tomasz Domin
10:16 AM Support #6860: lexer tests
I tried writing some tests using a different approach. Bottom up, I took small rules and wrote tests for each of thei... Florin Eugen Rotaru
05:21 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Greg Shah wrote:
> > The problem is there is no option to specify expected screen text file encoding.
>
> We shou...
Tomasz Domin

04/22/2025

11:02 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
> The problem is there is no option to specify expected screen text file encoding.
We should add this.
Greg Shah
10:56 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Greg Shah wrote:
> Shouldn't we allow multibyte characters to be matched in screens? Using @?@ isn't a proper test....
Tomasz Domin
10:41 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Shouldn't we allow multibyte characters to be matched in screens? Using @?@ isn't a proper test. Greg Shah
10:38 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Șerban Bursuc wrote:
> > - terminal encoding - you can set a proper terminal encoding with -encoding command line op...
Tomasz Domin
10:30 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
> - terminal encoding - you can set a proper terminal encoding with -encoding command line option - default is ISO_88... Șerban Bursuc
10:24 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Șerban Bursuc wrote:
> Any idea why Harness doesn't correctly read the terminal screen buffer?
>
> !9844_incorrec...
Tomasz Domin
09:58 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Any idea why Harness doesn't correctly read the terminal screen buffer?
!9844_incorrect_screen_buffer.png!
I th...
Șerban Bursuc
09:38 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
I finally found the problem. The @client.cmd@ output is *piped* to a log file in the @hotel_gui@ batch script (note: ... Șerban Bursuc
09:03 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
The Windows @ChUI@ mode was tested in Windows console, not in @PowerShell@. I do not have a experience for using @Pow... Eugenie Lyzenko
08:36 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
But this is not a real fix for @chui_native@, as the Harness needs to use the allocated terminal, so probably will ne... Șerban Bursuc
08:29 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Eugenie, I don't know whether I missed some FWD configuration but there was indeed a problem in @terminal_win.c@.
...
Șerban Bursuc
05:56 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
I debugged the exception and the failing point is somewhere in the native code, the symptom is that the terminal outp... Șerban Bursuc

04/17/2025

10:13 AM Support #6859: preprocessor tests
OK, then open a new task for this additional "quirk". Make sure we have tests that explore these cases. You will ha... Greg Shah
08:31 AM Support #6859: preprocessor tests
Greg Shah wrote:
> It seems this is another special case of #6308. Does this only happen after a string literal?
...
Stefan Vieru
09:51 AM Support #6860: lexer tests
> we can already draw the conclusion that the lexer is right
Not fully. It tells us that the lexer rule that matc...
Greg Shah
09:13 AM Support #6860: lexer tests
Thanks for the review.
Greg Shah wrote:
> These tests seem reasonable. You can check them in.
>
> I think w...
Florin Eugen Rotaru
09:11 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Now it's attached. Șerban Bursuc
09:02 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
I've ran into multiple issues trying to run a Harness ChUI test on Windows but mostly due to FWD related errors. The ... Șerban Bursuc

04/16/2025

01:43 PM Support #6860: lexer tests
These tests seem reasonable. You can check them in.
I think we do need more complex tests, which show that thes...
Greg Shah
10:34 AM Support #6860: lexer tests
I wrote some tests, mainly for the SYMBOL rule (including tests with multi-byte characters). Different encodings can ... Florin Eugen Rotaru
12:42 PM Support #6859: preprocessor tests
It seems this is another special case of #6308. Does this only happen after a string literal? Greg Shah
08:12 AM Support #6859: preprocessor tests
While developing some more tests i have found that:... Stefan Vieru
07:07 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
Sorry you are right, I thought this was an automatic initialization test from Harness but it was a custom test hidden... Șerban Bursuc
06:57 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
Șerban Bursuc wrote:
> Tomasz, I've tried to run a small ChUI Harness test on Windows. I took the script from @testc...
Tomasz Domin
06:10 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
Tomasz, I've tried to run a small ChUI Harness test on Windows. I took the script from @testcases/flushing_and_trigge... Șerban Bursuc

04/14/2025

10:12 AM Support #6859: preprocessor tests
I created 6859b/15856
It was needed due to an issue when running Preprocessor standalone, it wouldn't be able to cre...
Stefan Vieru
04:14 AM Support #6860: lexer tests
Greg Shah wrote:
> Please move ahead with the change to pass the @dict=false@ to the SymbolResolver constructor.
...
Florin Eugen Rotaru

04/11/2025

10:47 AM Support #6860: lexer tests
OK, sorry I didn't think carefully enough about this issue. The problem is the multi-process nature of the testing a... Greg Shah
10:38 AM Support #6860: lexer tests
I see that for the H2 databases accessed in embedded mode, there is the @AUTO_SERVER@ option which allows "multiple p... Florin Eugen Rotaru
08:28 AM Support #6860: lexer tests
Greg Shah wrote:
> Shouldn't we just have separate connections for each SR?
Looking into that.
Florin Eugen Rotaru
08:03 AM Support #6860: lexer tests
Florin Eugen Rotaru wrote:
> Florin Eugen Rotaru wrote:
>
> > One solution would be to have a dedicated cvt folde...
Greg Shah
08:02 AM Support #6860: lexer tests
> One solution would be to have a dedicated cvt folder for each testing conversion.
We must *not* do this.
Greg Shah
07:59 AM Support #6860: lexer tests
Florin Eugen Rotaru wrote:
> One solution would be to have a dedicated cvt folder for each testing conversion.
...
Florin Eugen Rotaru
07:47 AM Support #6860: lexer tests
I have run 10 lexers in parallel and discovered that the issue is because of the @cvtdb.h2.db2@ file which acts like ... Florin Eugen Rotaru
09:13 AM Support #6859: preprocessor tests
Open bugs as needed. Greg Shah
08:54 AM Support #6859: preprocessor tests
Greg Shah wrote:
> Stefan Vieru wrote:
> > I have a question about how to handle the testing of @;'@.
> > In the w...
Stefan Vieru
08:54 AM Support #6859: preprocessor tests
I created the following test:... Stefan Vieru
08:53 AM Support #6859: preprocessor tests
Stefan Vieru wrote:
> I have a question about how to handle the testing of @;'@.
> In the wiki mentioned above, it ...
Greg Shah
08:22 AM Support #6859: preprocessor tests
I have a question about how to handle the testing of @;'@.
In the wiki mentioned above, it is stated that @;'@ conve...
Stefan Vieru
09:08 AM Bug #9891: Open discussion on how to implement performance testing
> I propose having these existing tests adapted for performance testing would be a requirement.
I think this was a...
Alexandru Lungu
08:52 AM Bug #9891: Open discussion on how to implement performance testing
Overall, I agree with most of the above. Some thoughts:
* I like the idea of implementing common code in your man...
Greg Shah
08:20 AM Bug #9891: Open discussion on how to implement performance testing
I opened this task to discuss about various ways of testing the performance of FWD.
h4. Prerequisites
There are...
Alexandru Lungu
07:37 AM Bug #9891 (New): Open discussion on how to implement performance testing
Alexandru Lungu
08:01 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
Tomasz Domin wrote:
> Greg Shah wrote:
> > Let's fix the threading issue(s) in the @LexerTestDriver@ (wherever they...
Greg Shah
07:41 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
Greg Shah wrote:
> Let's fix the threading issue(s) in the @LexerTestDriver@ (wherever they are, the problem may be ...
Tomasz Domin
07:39 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
Let's fix the threading issue(s) in the @LexerTestDriver@ (wherever they are, the problem may be in the lexer, symbol... Greg Shah
04:47 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
Florin Eugen Rotaru wrote:
> Yes, the tests did run OK with @-q 1@ added, I will re-test the LexerTestDriver, thanks...
Tomasz Domin
04:43 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
Yes, the tests did run OK with @-q 1@ added, I will re-test the LexerTestDriver, thanks! Florin Eugen Rotaru
04:23 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
Florin Eugen Rotaru wrote:
> Tomasz, this happens only on Linux. Please take a look in the @testcases/tests/conversi...
Tomasz Domin
03:29 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
Tomasz, this happens only on Linux. Please take a look in the @testcases/tests/conversion/lexer@ folder. The tests ar... Florin Eugen Rotaru
03:26 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
Florin Eugen Rotaru wrote:
> I have this test set:
Florin
I need those specific tests as I cant replicate the is...
Tomasz Domin
04:22 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Good news, the tests run well and correctly in both Linux and Windows if the similarity threshold is high enough. I s... Șerban Bursuc

04/10/2025

11:12 AM Support #6860: lexer tests
I made another commit adding all tests we have so far to the FWD Harness.
There is an issue: when I run the FWD H...
Florin Eugen Rotaru
03:26 AM Support #6860: lexer tests
I have committed the *OE Harness tests* for Lexer. It consists of the @driver.p@ and the @oe_test_plan.xml@ which cal... Florin Eugen Rotaru
10:33 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
> Any row selected is treated the same
This might happen in Linux too but the text issue still remains, I will tes...
Șerban Bursuc
10:31 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Lorian fixed the database import for H2 and I could convert and run testcases in the hotel gui project.
Running S...
Șerban Bursuc
05:46 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
The dll dependency inspector turned out to be handy, it fixed the link error because it showed that the @libffi@ depe... Șerban Bursuc

04/09/2025

11:43 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Șerban Bursuc wrote:
> Java version is confirmed to be 64-bit, so most likely my @p2j.dll@ is 32-bit. Where can I ch...
Hynek Cihlar
11:37 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Șerban Bursuc wrote:
> Java version is confirmed to be 64-bit, so most likely my @p2j.dll@ is 32-bit.
https://gi...
Hynek Cihlar
10:23 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Java version is confirmed to be 64-bit, so most likely my @p2j.dll@ is 32-bit. Where can I change this? Șerban Bursuc
10:13 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Alexandru Lungu wrote:
> Serban, can you check #9730? Please ensure you set-up a VM with Windows 11 for it to work.
...
Șerban Bursuc
10:07 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Serban, can you check #9730? Please ensure you set-up a VM with Windows 11 for it to work. Alexandru Lungu
10:04 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
I'm having issues trying to run FWD on Windows.
There are multiple errors but I think they all stem from the same ...
Șerban Bursuc
09:43 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
I have this test set:... Florin Eugen Rotaru
08:58 AM Support #6859: preprocessor tests
Greg Shah wrote:
> > * Once those old testcases are migrated and working, we would evaluate the following to identif...
Stefan Vieru
08:57 AM Support #6859 (WIP): preprocessor tests
Greg Shah
08:57 AM Support #6859: preprocessor tests
> * Once those old testcases are migrated and working, we would evaluate the following to identify other tests that w... Greg Shah
08:04 AM Support #6859: preprocessor tests
All testcases from old_tescases are migrated with the harness counterpart on testcases/1735. Isn't that all?
Stefan Vieru
07:54 AM Support #6859: preprocessor tests
Have you migrated or created all tests noted in #6859-5? Greg Shah
02:26 AM Support #6859 (Test): preprocessor tests
Branch 6859a was merged to trunk rev 15847 and archived. Stefan Vieru

04/08/2025

06:22 PM Support #6859 (Merge Pending): preprocessor tests
Code Review Task branch 6859a Revision 15847
The changes are good. They are also low risk. You can merge to trun...
Greg Shah
09:43 AM Support #6859 (Review): preprocessor tests
Stefan Vieru
09:43 AM Support #6859: preprocessor tests
I created branch 6859a with revision 15847. Stefan Vieru
08:42 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
> My idea was to have a _test_ which prepares the actual files AND some tests that make the comparisons. These should... Greg Shah
06:49 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
Tomasz Domin wrote:
> You need to add @stream-wait-for@ into @lex_commands@ for scenario to wait for results.
O...
Florin Eugen Rotaru
06:36 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
Florin Eugen Rotaru wrote:
> Thanks. Unfortunately these don't work either...
>
> I attached the files. I tried m...
Tomasz Domin
06:29 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
Thanks. Unfortunately these don't work either...
I attached the files. I tried making a mock for the custom ant ta...
Florin Eugen Rotaru
05:02 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
Florin Eugen Rotaru wrote:
> Tomasz, I am trying to use the @dependency@ attribute for <test> tags in order to make ...
Tomasz Domin
04:53 AM Support #9854: Discussion on how to leverage Harness to test certain drivers of FWD
Tomasz, I am trying to use the @dependency@ attribute for <test> tags in order to make a test execute only after the ... Florin Eugen Rotaru
08:36 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
> If you wish I could direct some effort right now and add a simple Harness test including a script that should work ... Greg Shah
03:59 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
The specific testcase directory was definitely not meant to be ran with the testcases project, without modifying anyt... Șerban Bursuc
08:33 AM Support #6860 (WIP): lexer tests
Code Review Task Branch 6860a Revision 15844
It is good.
Greg Shah
03:50 AM Support #6860: lexer tests
Greg Shah wrote:
> Code Review Task Branch 6860a Revisions 15838 through 15842
>
> It is looking good.
>
> 1. ...
Florin Eugen Rotaru
07:09 AM Support #9270 (Test): design and implement an approach for executing multi-session 4GL testcases
Tomasz Domin
07:08 AM Support #9270: design and implement an approach for executing multi-session 4GL testcases
Tested for regressions twice, no issues found.
Pushed up to revision 36.
Working on an update of a documentation.
Tomasz Domin
 

Also available in: Atom