Project

General

Profile

Activity

From 07/10/2013 to 08/08/2013

08/08/2013

06:14 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Vadim Nebogatov wrote:
> Do we still keep FOR-EACH loop based RecordBuffer.deleteAll implementation?
Yes, it is the...
Eric Faulhaber
06:11 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
I've been thinking about this most of the afternoon here, and actually, after some discussions with Greg, I'm leaning... Eric Faulhaber
05:18 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Eric, could you describe your idea about using table pinned lock for bulk delete in some more detail? I still not goo... Vadim Nebogatov
04:21 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
OK, but if you remove the conditional test, please be sure to add comments so we don't lose information. This condit... Eric Faulhaber
03:59 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Condition on the line RecordBuffer, line 7747... Vadim Nebogatov
10:53 AM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Eric Faulhaber wrote:
> I think the desired effect can be achieved with changes to @RecordLockContext@ and @RecordBu...
Vadim Nebogatov
04:09 PM Database Feature #1911: add runtime support for sequences
In regard to note 26 and note 30, this is a known flaw in our processing for the MESSAGE statement. We don't need to... Greg Shah
04:02 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
Please just add a new task for the remaining work. Do not start work on it. We will schedule it for later. Greg Shah
01:49 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
As far as I observed, 54.1 should already be at the same level as int/in64 and date/datetime.
54.3 must be investiga...
Ovidiu Maxiniuc
09:00 AM Base Language Feature #1884: add some of the v10 data types and core built-ins
Is this work complete? If not, what exactly is left? Greg Shah
03:37 PM Database Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
Code review 20130808a:
This update looks OK, but it is in a very sensitive area of the conversion, and it is hard ...
Eric Faulhaber
01:21 PM Database Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
The first version of the update attached.
I used the disjunction between of-join foreign-key phrase and any existing ...
Ovidiu Maxiniuc
06:42 AM Database Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
My first approach here was to analyze the AST tree to see why the @OF@ node does not get encoded as needed.
I used ...
Ovidiu Maxiniuc
09:04 AM Base Language Feature #2108: event model rationalization
Please post an update on your research findings and your planned approach. Greg Shah
09:03 AM Base Language Feature #1640: implement DOM XML support
Please post the latest code and a summary of the work that is left. Greg Shah
08:59 AM Base Language Feature #1584 (Closed): add conversion and runtime support for INT64 and DATETIME data types
Greg Shah
08:52 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Unless there are significant downsides, I think we should implement chaining of both classloaders as our default appr... Greg Shah
08:34 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
When distributing update I forgot to mention that if someone wants to use dynamic temp tables, @InMemoryClassLoader@ ... Stanislav Lomany
08:22 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
This update adds basic support for dynamic tables. Stanislav Lomany

08/07/2013

05:59 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > Do you plan to support Alternate Buffer Pool (since 10.2B)?
> N...
Vadim Nebogatov
03:31 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > In case of separate TableIdentifier class we will need to use @i...
Vadim Nebogatov
03:21 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Vadim Nebogatov wrote:
> In case of separate TableIdentifier class we will need to use @instanceof TableIdentifier@ ...
Eric Faulhaber
03:16 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Eric Faulhaber wrote:
> It seems it might be best to leave the @LockManager@ interface and @InMemoryLockManager@ cla...
Vadim Nebogatov
02:59 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
It seems it might be best to leave the @LockManager@ interface and @InMemoryLockManager@ class alone after all.
Gi...
Eric Faulhaber
03:17 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Greg Shah wrote:
> Am I correct in my understanding that there is no remaining work in this main task (all remaining...
Ovidiu Maxiniuc

08/06/2013

04:13 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Am I correct in my understanding that there is no remaining work in this main task (all remaining work is in separate... Greg Shah
09:07 PM Database Feature #1911: add runtime support for sequences
Code review 20130801a:
Looks good. There is a TODO comment in the PostgreSQLSequenceHandler c'tor. Is there some...
Eric Faulhaber

08/05/2013

07:43 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Good point. Please see the class @RecordLockContext@, which already deals with this issue (it is a bit more complicat... Eric Faulhaber
10:30 AM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Several records could be locked from one context and require SHARE-LOCK for the same table.
I suggest to add one m...
Vadim Nebogatov
02:27 PM Database Feature #1911: add runtime support for sequences
On Friday, the runtime test failed with an abend in gso_ctrlc_3way, failure in step 11, and about 10 other issues in ... Ovidiu Maxiniuc

08/04/2013

02:23 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
These names will available via an API. The code will look something like this:... Eric Faulhaber
02:00 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Eric, please note that in order to authentically implement @CREATE-LIKE@ and @ADD-LIKE-FIELD@ I need to have original... Stanislav Lomany

08/02/2013

12:39 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
I think it is ok to commit. Eric Faulhaber
10:27 AM Database Feature #2044: implement support for a DELETE statement with a validation expression
Regression 20130802_053132 completed. There are 4 FAILED and 3 FAILED_DEPENDENCY tests in ts_tests.... Vadim Nebogatov
05:00 AM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Yes, that's a good point. The @update@ parameter will need to be passed through from the @lock@ method. Eric Faulhaber

08/01/2013

05:43 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Is the any sense in adding also @boolean update@ parameter like for @lock@ method? Vadim Nebogatov
03:54 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
Regression 20130801_101909 completed. There are 6 FAILED tests in ts_tests.... Vadim Nebogatov
10:11 AM Database Feature #1911: add runtime support for sequences
Near final update. Issues from Eric's review were fixed. The PSQL issues were eliminated.
I am putting this update t...
Ovidiu Maxiniuc
07:28 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Greg Shah wrote:
> ...
> If I understand correctly, neither of these items will cause a problem for the Java-access...
Constantin Asofiei

07/31/2013

05:29 PM Database Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Correction: @lockTable(LockType lockType)@ should actually be @lockTable(String table, LockType lockType)@, where @ta... Eric Faulhaber
05:04 PM Database Feature #1602: support BigDecimal in PLJAVA indexOf() implementation
I have no idea. I'm sure I was just going off our estimate spreadsheet, based on some feedback you provided originally. Greg Shah
05:01 PM Database Feature #1602: support BigDecimal in PLJAVA indexOf() implementation
Greg: I just looked into the Functions class and found we have the following method:... Eric Faulhaber
03:42 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Please summarize the remaining work that is to be done (and the plan for the work).
I think it is just these two i...
Greg Shah
03:23 PM Base Language Feature #1961 (Closed): implement runtime backing for Windows environment/registry access
Greg Shah
03:22 PM Base Language Feature #1649 (Closed): implement Windows environment/registry access
Greg Shah
02:48 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
I forgot: the src/com/goldencode/p2j/ui/client/chui/driver/charva/* has to be removed too. I did that now in bzr rev... Greg Shah
02:45 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
Make sure to list the files that were removed in your distribution email. Greg Shah
02:44 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
I just did it here. It worked fine. The revision number is 10370. I just used bzr remove on the specific files and... Greg Shah
02:38 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
> Don't forget to remove the following files:
>
> lib/charva_cut_down_20100816.zip
> lib/charva_cut_down_20101216...
Eugenie Lyzenko
02:15 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
Don't forget to remove the following files:
lib/charva_cut_down_20100816.zip
lib/charva_cut_down_20101216.zip
li...
Greg Shah
12:36 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
Yes, go ahead and check-in/distribute. Greg Shah
12:35 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
Finally the regression testing has been passed with bzr code base 30368. So I guess it is ready to check in and distr... Eugenie Lyzenko
01:36 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
Update vmn_upd20130731a.zip replaces update vmn_upd20130729a.zip with fixed comments in note 22.
Updated to revision...
Vadim Nebogatov
12:32 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > I have tested DELETE with validation when record is locked. In t...
Vadim Nebogatov
08:38 AM Database Feature #2044: implement support for a DELETE statement with a validation expression
Vadim Nebogatov wrote:
> I have tested DELETE with validation when record is locked. In this case 4GL simply ignores...
Eric Faulhaber
08:21 AM Database Feature #2044: implement support for a DELETE statement with a validation expression
Code review 20130729a:
Code looks fine. However, I would suggest, instead of changing @handle@ and @ControlFlowOps...
Eric Faulhaber
07:27 AM Database Feature #2044: implement support for a DELETE statement with a validation expression
Vadim Nebogatov wrote:
> Do you plan to support Alternate Buffer Pool (since 10.2B)?
Not to my knowledge. There are...
Eric Faulhaber
12:51 PM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support
It is a good start. Keep going. Greg Shah
09:15 AM User Interface Feature #2131: implement the Windows equivalent to the NCURSES/terminal support
The first proposal of the Windows console native implementation for you to review. A lot of comments still left - be ... Eugenie Lyzenko
07:12 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Please go ahead and fix the conversion defect. AFAIK, all the information we have regarding rules about buffers is in... Eric Faulhaber

07/30/2013

05:37 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
@DEFAULT-BUFFER-HANDLE@ will take some more time if I'm going to implement it completely, specifically it is converte... Stanislav Lomany
02:58 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
Be careful with your conclusions here. This result can be heavily affected by the 4GL caching/flushing behavior AND ... Greg Shah
02:47 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
I have tested DELETE with validation when record is locked. In this case 4GL simply ignores this record.
One user...
Vadim Nebogatov
05:12 AM Database Feature #2137 (WIP): runtime support for FIELDS/EXCEPT record phrase options
See #2095 for cases which require support. Eric Faulhaber

07/29/2013

04:21 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
Do you plan to support Alternate Buffer Pool (since 10.2B)?
Vadim Nebogatov
03:36 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
I have attached update vmn_upd20130729a.zip/vmn_upd20130729b.zip
1) Added a boolean asMsg parameter to recordOrThr...
Vadim Nebogatov
11:58 AM Database Feature #2044: implement support for a DELETE statement with a validation expression
I don't see the value in making changes to builtErrorText(). If I understand correctly, we just need to bypass the c... Greg Shah
11:48 AM Database Feature #2044: implement support for a DELETE statement with a validation expression
Greg Shah wrote:
> Before I can answer, I have one more question. In both cases (NO-ERROR and without NO-ERROR), wha...
Vadim Nebogatov
09:33 AM Database Feature #2044: implement support for a DELETE statement with a validation expression
Before I can answer, I have one more question. In both cases (NO-ERROR and without NO-ERROR), what is returned from ... Greg Shah
11:59 AM Database Feature #1588: add conversion and runtime support for embedded SQL
Yes, please commit and distribute. Eric Faulhaber
11:12 AM Database Feature #1588: add conversion and runtime support for embedded SQL
Eric, may I commit this update? Vadim Nebogatov

07/26/2013

03:41 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
What about adding one more parameter to buildErrorText and recordOrThrowError:
boolean withNumber
and do not pr...
Vadim Nebogatov
10:52 AM Database Feature #2044: implement support for a DELETE statement with a validation expression
*Non-Error case*... Vadim Nebogatov
07:21 AM Database Feature #2044: implement support for a DELETE statement with a validation expression
2 things:
1. Are you sure that failing a validation in the 4GL is considered an "ERROR" in the 4GL sense? What do...
Greg Shah
06:17 AM Database Feature #2044: implement support for a DELETE statement with a validation expression
Eric Faulhaber wrote:
> Please propose a change which adjusts for these minor differences with minimal or (if possib...
Vadim Nebogatov
08:22 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
Oh, I believed you, I just found it interesting how inconsistent Progress is. Eric Faulhaber
09:00 AM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
The last drop was replaced with one including manifest changes. The runtime testing has been started. Eugenie Lyzenko
08:38 AM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
> The question: do I need to manually remove charva package in testing directory before start runtime testing? Or thi... Greg Shah
08:30 AM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
The drop with ConsoleDriver.java javadoc change. Going to test in devsrv01.
The question: do I need to manually re...
Eugenie Lyzenko
08:17 AM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
OK, good. Greg Shah
08:16 AM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
> 1. You can remove the javadoc text from ConsoleDriver:
>
> * <p>
> * This replaces CHARVA driver.
>
> We don...
Eugenie Lyzenko
07:59 AM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
Code Review 0725a
1. You can remove the javadoc text from ConsoleDriver:...
Greg Shah
08:05 AM Base Language Feature #1640: implement DOM XML support
> I think I do not need to simulate this scenario.
Yes, I think you are right.
The key question: was that code ...
Greg Shah
05:38 AM Database Feature #1588: add conversion and runtime support for embedded SQL
Regression 20130725_172005 completed in time you pointed. There are less errors: 3 FAILED tests in ts_tests.
1. tc...
Vadim Nebogatov

07/25/2013

06:45 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
Additional files with references to CHARVA included in this drop to modify:
com/goldencode/p2j/ui/client/driver/Scre...
Eugenie Lyzenko
01:31 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
> I can offer to place KeyProcessor.java under com/goldencode/p2j/ui/client/chui/driver/console. Is it OK?
Yes, it...
Greg Shah
11:06 AM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
> When do you think you will be ready to test? It looks pretty close.
OK. I'll clean up the code soon and perform ...
Eugenie Lyzenko
09:06 AM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
To be clear, I want you to get this tested, working and checked in before you do any work on the WIN32 version of the... Greg Shah
09:05 AM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
Code Review 0724a
Overall, this is very good. Some minor things:
1. The copyright notice for ConsoleHelper is ...
Greg Shah
08:48 AM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
I like the overall approach. The changes to make it console/Console* instead of ncurses/Ncurses* is very good. It i... Greg Shah
06:17 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
I have attached screenshots Vadim Nebogatov
05:57 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
Interesting. I have not previously seen a Progress-style error which does not have the leading asterisks and trailing... Eric Faulhaber
05:27 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
I have tested both in P2J and 4GL and also with NO-ERROR and some other examples like ... Vadim Nebogatov
01:46 PM Base Language Feature #1640: implement DOM XML support
I have found error in 4gl on unix server(lindev01)(version oe10.2B) :
after execution of next line:
@hDoc2:initiali...
Evgeny Kiselev
10:27 AM Base Language Feature #1649: implement Windows environment/registry access
Committed in bzr as 10367. Will distribute soon. Eugenie Lyzenko
08:34 AM Base Language Feature #1649: implement Windows environment/registry access
I think the merged changes are safe enough. Go ahead and check it in (and distribute it via email). Good work! Greg Shah

07/24/2013

07:01 PM Base Language Feature #1640: implement DOM XML support
It is a global attribute, but the DOM XML support is one of the first areas of 4GL code where we have found a good re... Greg Shah
02:09 PM Base Language Feature #1640: implement DOM XML support
Dom, Sax and many other objects has @handle@ attribute. I didn't find any implementation for this. Also conversion fo... Evgeny Kiselev
06:29 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
This is the first proposal for native implementation for Linux only. The Windows native part is still missing. But it... Eugenie Lyzenko
05:52 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
For now, that is the best way. Later on, we will start to move our utility classes into separate jars, but let's kee... Greg Shah
03:49 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
I guess we have the same files in both projects.
Greg: can you think of a better way?
Eric Faulhaber
02:00 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Eric, @com.goldencode.compile.*@ classes are from the harness project. They are now required for P2J project too. How... Stanislav Lomany
12:38 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> What is the TODO comment in DMOIndex.classes()
Dynamic table classes are not returned by this function. Since this...
Stanislav Lomany
04:51 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Code review 20130717a/b/c:
Nice work. A very interesting update.
* What is the TODO comment in @DMOIndex.class...
Eric Faulhaber
05:20 PM Database Feature #2046 (WIP): runtime support for DELETE statement with a validation expression
Eric Faulhaber
03:01 PM Database Feature #1588: add conversion and runtime support for embedded SQL
IIRC, some of the "job clock" tests are sensitive to the time of day they are run, so these may be false negatives (o... Eric Faulhaber
02:48 PM Database Feature #1588: add conversion and runtime support for embedded SQL
Regression 20130724_051719 completed. There are 8 FAILED and FAILED_DEPENDENCY tests in ts_tests:
1. tc_job_002 FA...
Vadim Nebogatov

07/23/2013

05:38 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Then I think your suggested approach makes sense. Eric Faulhaber
03:53 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Default buffer for dynamic tables can be used anywhere, i.e. within and outside of @TEMP-TABLE-PREPARE()@ call scope. Stanislav Lomany
02:37 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Stanislav Lomany wrote:
> Eric, I was working on @DEFAULT-BUFFER-HANDLE@ - handle to default buffer which can be use...
Eric Faulhaber
02:21 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Stanislav Lomany wrote:
> ...
> I think we should use "field1", "field2" as Hibernate names and parse queries passe...
Eric Faulhaber
01:54 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Eric, I was working on @DEFAULT-BUFFER-HANDLE@ - handle to default buffer which can be used anywhere in the program a... Stanislav Lomany
03:25 PM Database Feature #1588: add conversion and runtime support for embedded SQL
Code review 20130723a/b:
Code looks good. Please regression test and check it in if successful.
Eric Faulhaber
03:05 PM Database Feature #1588: add conversion and runtime support for embedded SQL
I have attached update vmn_upd20130723a.zip/vmn_upd20130723b.zip with deleteAll based on "converted-style" FOR-EACH l... Vadim Nebogatov
02:48 PM Database Feature #1588: add conversion and runtime support for embedded SQL
Vadim Nebogatov wrote:
> This is file you sent me separately. Bzr version does not contain 023 ECF 20130618
Yes, ...
Eric Faulhaber
09:30 AM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
Another offering is to move the helper class interfacing to JNI - ConsoleHelper to better location for example com/go... Eugenie Lyzenko
07:18 AM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
The drop includes java part of suggested changes for review. The native C code structure will depends on which way we... Eugenie Lyzenko

07/22/2013

07:19 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
After rethink I would offer to rename:
- ncurses/NcursesDriver.java
to
- console/ConsoleDriver.java
and
- ncurse...
Eugenie Lyzenko
06:18 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
Another point to discuss is related to the terminal calls in Windows C code. I can see two options here:
1. Use Cons...
Eugenie Lyzenko
12:13 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
The implementation plan:
1. Create two new classes in com/goldencode/p2j/ui/client/chui/driver:
- ncurses/NcursesDriv...
Eugenie Lyzenko
10:18 AM Base Language Feature #1649: implement Windows environment/registry access
This is the drop merged with recent P2J codebase(10365). Do we need to run runtime-testing again? Or I can check it w... Eugenie Lyzenko
10:18 AM Database Feature #1588: add conversion and runtime support for embedded SQL
> Good. But hibernate-core-4.1.8.jar is file I received from Stas, I am not sure if he will commit (or already commit... Stanislav Lomany
10:05 AM Database Feature #1588: add conversion and runtime support for embedded SQL
Eric Faulhaber wrote:
> * Please put the Hibernate jar in a separate update and put it under the @lib@ directory ins...
Vadim Nebogatov
09:34 AM Database Feature #1588: add conversion and runtime support for embedded SQL
Eric Faulhaber wrote:
> * This version of database_general.rules is the same as the one currently checked into bzr. ...
Vadim Nebogatov
08:33 AM Base Language Feature #1640: implement DOM XML support
Yes, go ahead with this approach. Greg Shah
04:54 AM Base Language Feature #1640: implement DOM XML support
I have found that for most of the DOM methods and attributes exceptions doesn't set @error=true@.
I have tried to us...
Evgeny Kiselev

07/21/2013

06:02 PM Database Feature #1588: add conversion and runtime support for embedded SQL
Code review 20130719a:
* This version of database_general.rules is the same as the one currently checked into bzr....
Eric Faulhaber

07/20/2013

03:31 PM Base Language Feature #1649: implement Windows environment/registry access
Finally the update has passed all regression testing in devsrv01 except known TC-JOB-002(including CTRL-C 3-way tests... Eugenie Lyzenko
10:20 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
The om_upd20130716a.zip has been committed as bzr revision 10365.
The om_upd20130716b.zip has been committed as bz...
Greg Shah

07/19/2013

03:01 PM Database Feature #1588: add conversion and runtime support for embedded SQL
Savepoint based reversible actually could work for other operations, not only for @deleteAll@. I have attached update... Vadim Nebogatov
02:04 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
> I believe that it is best to check in now the changes as this is another big update and delaying this will need add... Greg Shah
01:58 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Strange enough, my tc_job_002.txt has 58K and looks like a weekly table starting with current DoW (each of my previou... Ovidiu Maxiniuc
01:27 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
The tc_job_002 failure is at the expected step (report comparison). I think the unix2dos is only part of the problem... Greg Shah
01:16 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
> tc_job_clock_002: failure in step 20: 'timeout before the specific screen buffer became available (Mismatched data ... Eugenie Lyzenko
12:34 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I ran the update against revision 10364 . The result changed a bit:
* tc_job_002: @failure in step 40: 'Unexpected E...
Ovidiu Maxiniuc
08:33 AM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I just heard from Eric. He is getting on a plane right now and doesn't have the full answer on my question. But we ... Greg Shah
08:25 AM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
My recommendation was spurred by Ovidiu's deprecation of @Functions.getMTime()@ because the database server could pro... Eric Faulhaber
07:42 AM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
> The no-argument variant of the mtime() function in a where clause should not convert to a server-side function, but... Greg Shah
04:14 AM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Code review 20130716a/b:
The database content of this update generally looks good, with a few issues:
* Use of ...
Eric Faulhaber
11:13 AM Runtime Infrastructure Feature #2158 (New): create a minimal jar file suitable for making a remote connection to a P2J s...
Greg Shah
07:53 AM Base Language Feature #1640: implement DOM XML support
2 thoughts:
1. Your test code needs a slight change. Unfortunately, when I pointed you to my memptr test code as e...
Greg Shah

07/18/2013

07:00 PM Base Language Feature #1640: implement DOM XML support
Greg Shah wrote:
> I don't understand. We don't yet have a GUI in P2J, do you mean the ChUI (character UI) in our S...
Evgeny Kiselev
02:37 PM Base Language Feature #1640: implement DOM XML support
> Because in my test hDoc:name="asd" no-error. and I used handle.readOnlyError and I expected do not see error in GUI... Greg Shah
06:17 PM Database Feature #1588: add conversion and runtime support for embedded SQL
I was mistaken, temporary table was created by DefaultDirtyShareManager for track changes Vadim Nebogatov
01:30 PM Base Language Feature #1649: implement Windows environment/registry access
Code Review 0718a
It looks good. Get it runtime regression tested on devsrv01.
Greg Shah
01:14 PM Base Language Feature #1649: implement Windows environment/registry access
OK. The changes for points 1-4 has been uploaded for review. NO-ERROR mode is also working for ErrorManager change. Eugenie Lyzenko
11:20 AM Base Language Feature #1649: implement Windows environment/registry access
Code Review 0717a
Each code review I look deeper in some areas and catch some things I didn't see before. We are ...
Greg Shah
08:16 PM Base Language Feature #1649: implement Windows environment/registry access
The update with removed TODO comments for implemented code. The testcases also refreshed.
The testcase env_test34....
Eugenie Lyzenko
01:09 AM Database Feature #1911: add runtime support for sequences
Code review 20130712a:
Generally looks good; nice work. Some comments below.
* Please add a WARNING to schema co...
Eric Faulhaber
12:23 AM Database Feature #1911: add runtime support for sequences
Ovidiu Maxiniuc wrote:
> +Note 26 continued+.
> ...
Greg: I need your input here.
Ovidiu: since this is an erro...
Eric Faulhaber

07/17/2013

07:56 PM Base Language Feature #1640: implement DOM XML support
May I change in method @handle.readOnlyError@ last line:
@ErrorManager.displayError(4052, err, false);@
to
@ErrorM...
Evgeny Kiselev
06:11 PM Database Feature #1588: add conversion and runtime support for embedded SQL
Savepoint seems more promising and common approach. I have attached very draft @deleteAll@ support based on Savepoin... Vadim Nebogatov
06:07 PM Base Language Feature #1649: implement Windows environment/registry access
> If your testing proves that the implementation is correct and complete, then please remove the TODOs. If something ... Eugenie Lyzenko
05:57 PM Base Language Feature #1649: implement Windows environment/registry access
> I've left them for possible changes reflecting to your notes. Do I need to remove them?
If your testing proves t...
Greg Shah
05:44 PM Base Language Feature #1649: implement Windows environment/registry access
> 1. Do LOAD/UNLOAD/USE really generate a STOP condition (like a CTRL-C) on non-Windows?
Yes, when error is enable...
Eugenie Lyzenko
05:24 PM Base Language Feature #1649: implement Windows environment/registry access
Code Review 0712c
1. Do LOAD/UNLOAD/USE really generate a STOP condition (like a CTRL-C) on non-Windows?
2. Nor...
Greg Shah
04:39 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Code Review 0716b
I am fine with the changes, but Eric needs to review them since many affect the persistence laye...
Greg Shah
04:30 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Code Review 0716a
I am OK with this code being checked in.
> tc_job_002: failure in step 40: 'Unexpected EOF ...
Greg Shah
01:24 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
This second update adds all new stuff about date/datetime/datetime-tz: class hierarchy, literals, new date API, pl, e... Ovidiu Maxiniuc
04:15 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
Some thoughts:
1. I don't see anything in addStringNative() that looks protectible. The entire function can be pu...
Greg Shah
12:22 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
Another word we can use readKey() untouched? May be removing try_again: label which is never used now. Eugenie Lyzenko
12:16 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
The code inside EVL<< .. EVL>> "braces" duplicates the original CHARVA source. The other code outside "braces" - GCD ... Eugenie Lyzenko
07:29 AM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
> 1. The calls detected as never used can be just ignored, we do not need to implement them in charva replacement, co... Greg Shah
01:05 PM Database Feature #1911: add runtime support for sequences
+Note 26 continued+.
From my quick tests, it seems that @message@ is more permissive about errors occurred while eva...
Ovidiu Maxiniuc
09:34 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
All metadata from the _field, _file, _index, _index_field, _user, and _lock tables are being stored in an embedded H2... Eric Faulhaber
09:12 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
About field name validation for dynamic tables.
1. Basically you can create a field with any name, and this field ca...
Stanislav Lomany
08:52 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Update - part 3 (Hibernate changes). Stanislav Lomany
04:07 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Update - part 2. Stanislav Lomany

07/16/2013

06:07 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
The function list used in native NCURSES based code from charva.Toolkit.java(Java end, the JNI names to be implemente... Eugenie Lyzenko
02:30 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Did some research regarding these methods, focusing on @bufferField()@.
My first thought were to 'capture' the mis...
Ovidiu Maxiniuc
01:43 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
My previous update was too big to be manageable so I split it in two chuncks. The first one (attached) does not conta... Ovidiu Maxiniuc
11:14 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Update for review. Allows potentially manipulate DMOs using P2J framework. I'll post remaining parts and make comment... Stanislav Lomany
10:24 AM Database Feature #1588: add conversion and runtime support for embedded SQL
The other option is to look at savepoints sooner rather than later, since this is probably the most correct/supported... Eric Faulhaber
09:50 AM Base Language Feature #1640: implement DOM XML support
What I mean by "compile time" is that it can only be fixed by changing the code and re-compiling.
Yes, this manife...
Greg Shah
09:04 AM Base Language Feature #1640: implement DOM XML support
Greg Shah wrote:
> > I don't like to add empty stub and just specify @readOnlyError@.
>
> The idea is that writi...
Constantin Asofiei
08:44 AM Base Language Feature #1640: implement DOM XML support
> I don't like to add empty stub and just specify @readOnlyError@.
The idea is that writing to such an attribute ...
Greg Shah
03:42 AM Base Language Feature #1640: implement DOM XML support
Evgeny, what rules have you tried and it didn't work? In 10364 rev, adding this rule to @methods_attributes.rules@ (u... Constantin Asofiei

07/15/2013

07:08 PM Base Language Feature #1640: implement DOM XML support
How I can make attribute readonly via rules. I have @kw_chld_num@ attribute, I have tried to find something in common... Evgeny Kiselev
06:33 PM Database Feature #1588: add conversion and runtime support for embedded SQL
Interesting idea.
Please detail your proposed design for bulk delete "undo"-ability (to use the Progress term) for...
Eric Faulhaber
05:24 PM Database Feature #1588: add conversion and runtime support for embedded SQL
Reversible operations for temporary tables are based on multiplex ID value and records are not actually deleted from ... Vadim Nebogatov
05:09 PM User Interface Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
Attached are the versions of the Toolkit.c which are important to review (and the diffs between them).
Some import...
Greg Shah
02:19 PM Database Feature #1911: add runtime support for sequences
I discovered something strange with sequences.
If you define a sequence with negative increment Progress will automa...
Ovidiu Maxiniuc

07/12/2013

07:24 PM Base Language Feature #1649: implement Windows environment/registry access
This is the StanzaIni.java Javadoc adding for more descriptions and little syntax fix for Javadoc in Registry.java. Eugenie Lyzenko
05:36 PM Base Language Feature #1649: implement Windows environment/registry access
This is the final changes for registry access for you to review. Changes comparing to previous update:
1. The native ...
Eugenie Lyzenko
11:56 AM Base Language Feature #1649: implement Windows environment/registry access
The drop includes:
1. Disabling environment related calls and daemon starting for non-Windows environment.
2. Addin...
Eugenie Lyzenko
06:25 PM Database Feature #1588: add conversion and runtime support for embedded SQL
OK, this complicates the implementation.
Based on your findings so far, I think the way we need to handle this is to...
Eric Faulhaber
01:49 PM Database Feature #1588: add conversion and runtime support for embedded SQL
Example undo for DELETE FROM for subtransaction. It works: record exists after bulk delete and undo ... Vadim Nebogatov
02:15 PM Database Feature #1911: add runtime support for sequences
This update package contains a first stage of runtime implementation. Main points:
- fixed name issues (4GL-legacy ...
Ovidiu Maxiniuc
11:59 AM Database Feature #1911: add runtime support for sequences
I am having the following issue.... Ovidiu Maxiniuc

07/11/2013

07:39 PM Base Language Feature #1649: implement Windows environment/registry access
The second drop for today includes Java doc additions for Registry class. Please let me know if this level of details... Eugenie Lyzenko
01:33 PM Base Language Feature #1649: implement Windows environment/registry access
OK.
Greg Shah
12:02 PM Base Language Feature #1649: implement Windows environment/registry access
Finding news for handling registry in Windows 4GL in PUT/GET KEY-VALUE calls.
1. The CHUI and GUI interfaces works t...
Eugenie Lyzenko
08:55 AM Base Language Feature #1649: implement Windows environment/registry access
> 1, 2.
OK, agreed, we need more descriptions here. I'll add detailed javadocs in recent today drop.
> 3.
Th...
Eugenie Lyzenko
06:58 AM Base Language Feature #1649: implement Windows environment/registry access
Code Review 0710a
1. The Registry.java class javadoc needs significant enhancements. The native methods have only...
Greg Shah
08:51 PM Base Language Feature #1649: implement Windows environment/registry access
This drop includes JNI implementation for Windows registry access functions and minor change for JNI signature. Debug... Eugenie Lyzenko
07:14 PM Base Language Feature #1640: implement DOM XML support
Greg Shah wrote:
> > The error comes from method com.goldencode.p2j.util.BinaryData.setMethodSetup() there is a line...
Evgeny Kiselev
06:00 AM Base Language Feature #1640: implement DOM XML support
> The error comes from method com.goldencode.p2j.util.BinaryData.setMethodSetup() there is a line that check if (isAu... Greg Shah
02:40 AM Base Language Feature #1640: implement DOM XML support
Evgeny
> But I have next issue. I have a test:
> @
> set-size(m1) = 10001.
> set-size(m2) = 101.
> d...
Constantin Asofiei
02:37 AM Base Language Feature #1640: implement DOM XML support
Evgeny Kiselev wrote:
> I have one more issue: in the generated code I have: @unwrap(hRoot).readOnlyError("namespace...
Constantin Asofiei
04:58 PM Database Feature #1588: add conversion and runtime support for embedded SQL
Good question. I'm sure a DELETE FROM style bulk delete would be rolled back at a full transaction scope, but we nee... Eric Faulhaber
04:52 PM Database Feature #1588: add conversion and runtime support for embedded SQL
Are there sense of reversible bulk delete for persistent tables? Vadim Nebogatov
03:09 PM Database Feature #1588: add conversion and runtime support for embedded SQL
Vadim Nebogatov wrote:
> Additionally to note 29.
> I have tested @DELETE FOR@ with @WHERE@ clause. I understand i...
Eric Faulhaber
02:01 PM Database Feature #2080: add runtime support for database methods
OK, please check in and distribute this update. Eric Faulhaber
01:58 PM Database Feature #2080: add runtime support for database methods
Regression 20130711_075408 completed with the following results.
Only 2 tests failed: tc_job_002 as expected and ...
Vadim Nebogatov

07/10/2013

07:11 PM Base Language Feature #1640: implement DOM XML support
Greg Shah wrote:
> > It works fine in the 4GL, but in p2j I have next error: ** Can't PUT past the end of the MEMPTR...
Evgeny Kiselev
06:58 PM Base Language Feature #1640: implement DOM XML support
I have one more issue: in the generated code I have: @unwrap(hRoot).readOnlyError("namespace-prefix");@
but I'm expe...
Evgeny Kiselev
04:57 PM Base Language Feature #1640: implement DOM XML support
> It works fine in the 4GL, but in p2j I have next error: ** Can't PUT past the end of the MEMPTR. (4791)
Do you g...
Greg Shah
03:31 PM Base Language Feature #1640: implement DOM XML support
Thanks, it was issue from my side.
But I have next issue. I have a test:
@
set-size(m1) = 10001.
set-siz...
Evgeny Kiselev
02:30 PM Base Language Feature #1640: implement DOM XML support
> IS it issue with my environment ?
Possibly. The code being called is native (JNI) in src/native/memory.c:
JN...
Greg Shah
02:13 PM Base Language Feature #1640: implement DOM XML support
I have found next issue with memptr:
@Caused by: java.lang.NullPointerException
at com.sun.proxy.$Proxy3.is...
Evgeny Kiselev
04:15 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
0708b is committed to bzr revision 10363. Constantin Asofiei
 

Also available in: Atom