Activity

From 12/16/2013 to 01/14/2014

01/15/2014

08:40 PM Base Language Feature #1641: implement SAX XML support: Constantin Asofiei wrote:
> Review for 0112a.zip:
> * all files are missing history entries. When you add history e... Evgeny Kiselev

01/14/2014

06:49 PM User Interface Feature #1787: implement batch mode support: > My concern with your suggested approach is that we would have to find every place that is different when using the ... Eugenie Lyzenko
06:11 PM User Interface Feature #1787: implement batch mode support: > It is important that you make sure you re-run all your tests using the @pro -b@ since our current code may have som... Eugenie Lyzenko
06:03 PM User Interface Feature #1787: implement batch mode support: It is important that you make sure you re-run all your tests using the @pro -b@ since our current code may have some ... Greg Shah
06:02 PM User Interface Feature #1787: implement batch mode support: > Do we need to support both foreground and background mode?
Yes.
> Because the & option is used with -b option... Greg Shah
12:09 PM User Interface Feature #1787: implement batch mode support: > The key question: can we duplicate this behavior using the & directly from the shell?
May be this is not require... Eugenie Lyzenko
09:28 AM User Interface Feature #1787: implement batch mode support: >>> The correct command for batch mode in Linux is bpro, not pro
>>>
>> Is this officially documented somewhere? Be... Greg Shah
09:13 AM User Interface Feature #1787: implement batch mode support: Eugenie Lyzenko wrote:
> > There is a memory leak in the TypeAhead.taBuf list...
>
> Explain what do you mean tellin... Constantin Asofiei
09:04 AM User Interface Feature #1787: implement batch mode support: > There is a memory leak in the TypeAhead.taBuf list...
Explain what do you mean telling "memory leak". Another wo... Eugenie Lyzenko
08:57 AM User Interface Feature #1787: implement batch mode support: > > The correct command for batch mode in Linux is @bpro@, not @pro@
>
> Is this officially documented somewhere? ... Eugenie Lyzenko
08:54 AM User Interface Feature #1787: implement batch mode support: Greg Shah wrote:
> However, I wonder what the 4GL does when you "manually" send it the CTRL-C via @kill -INT <pid>@?... Constantin Asofiei
08:31 AM User Interface Feature #1787: implement batch mode support: > if ran under linux with pro -b -p a.p will output:
> ... Eugenie Lyzenko
08:27 AM User Interface Feature #1787: implement batch mode support: > if batch mode is enabled, then the KeyReader thread should not be started at all (as blocking for user input is imp... Greg Shah
06:05 AM User Interface Feature #1787: implement batch mode support: There is a memory leak in the @TypeAhead.taBuf@ list, when batch mode is activated. On linux, when the @BatchDriver.r... Constantin Asofiei
04:20 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: You're right.. Now I'm trying to implement it (batch-mode support) and I'm getting following problem. CURRENT-WINDOW ... Vadim Gindin
05:44 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Vadim, on note 24 you mentioned that "window is unknown:" in batch mode. You forgot to implement this case in @LT.cur... Constantin Asofiei
12:33 PM User Interface Feature #1811: implement the AJAX client driver: The code changes in 0114a look good. There is some missing javadoc, but otherwise things seem pretty much on target.... Greg Shah
12:07 PM User Interface Feature #1811: implement the AJAX client driver: Today I started to implements the WebSockets protocol for screen management (server -> browser JS)
Please look at th... Marius Gligor
11:13 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): > AFAIK, P2J uses n widget rows for displaying the body of a n-down frame;
Correct.
> assuming that 4GL indeed ... Greg Shah
11:02 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): About the tests at note 10: your conclusions are wrong. If you look at the repeating IDs, you will see that there are... Constantin Asofiei
08:58 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Attached update contains the correct changes applied to rev 10436 (compared to 10434). Constantin Asofiei
03:00 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Error fix. Committed to bzr, rev #10436. Vadim Gindin
07:53 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Status update (related to BufferImpl)
* @findFirst@, @findLast@, @findUnique@ - implemented, testing in progress, ... Ovidiu Maxiniuc

01/13/2014

06:27 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: I'm pretty sure the double quotes around the numeric value represent optional syntax. It is the value itself that is ... Eric Faulhaber
06:20 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Eric Faulhaber wrote:
> > But I did not find so far methods allowing creation BaseDataType instance from a pair of s... Vadim Nebogatov
05:45 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Eric Faulhaber wrote:
> Vadim, in the version of @BufferImpl@ you just checked in (rev 10433), you removed the origi... Vadim Nebogatov
05:42 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Vadim, in the version of @BufferImpl@ you just checked in (rev 10433), you removed the original copyright year of 201... Eric Faulhaber
05:38 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: > But I did not find so far methods allowing creation BaseDataType instance from a pair of strings initialValue and i... Eric Faulhaber
04:49 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: I think for INITIAL attribute we need two string annotations: initialValue and initialType, assigning them from text/... Vadim Nebogatov
01:05 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Yes, agreed. I made internal methods returning LegacyFieldInfo, bit public methods are the same. Vadim Nebogatov
10:13 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: While I do see some value in not repeating the pattern... Eric Faulhaber
05:13 PM User Interface Feature #2226: finish LAST-EVENT support: Please put all discussions into the task history for #1782 so that future readers don't have to look in 2 places for ... Greg Shah
05:10 PM User Interface Feature #2226: finish LAST-EVENT support: Basic behavior is working, but there are a number of special cases that don't yet work exactly like the 4GL. Please ... Greg Shah
05:08 PM User Interface Feature #2226 (Closed): finish LAST-EVENT support: Greg Shah
05:12 PM User Interface Feature #1782 (Closed): implement LAST-EVENT system handle and associated attributes: Greg Shah
04:54 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Here it is. Implementation of basic behavior Vadim Gindin
04:53 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Please post the final update zip here and we will close the task. Greg Shah
04:33 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: committed to bzr rev #10435 Vadim Gindin
03:17 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Ok, then stay with option 1 (constants) but make sure to document this in the javadoc for the fields (i.e. they are p... Constantin Asofiei
03:06 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Constantin Asofiei wrote:
> ..
> Unless the DE_LOWEST and DE_HIGHEST are some codes from 4GL, is there a way to def... Vadim Gindin
03:13 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Vadim Gindin wrote:
> Constantin Asofiei wrote:
> ..
> > * Keyboard - as for note 81 - why can't the initializatio... Constantin Asofiei
05:11 PM User Interface Feature #2020 (Closed): runtime support for LAST-EVENT system handle and associated attributes: Greg Shah
05:04 PM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...: Start by writing cases to investigate this behavior, then propose a solution. Greg Shah
04:59 PM User Interface Feature #1811: implement the AJAX client driver: It looks good (both the code in 0113a and the proposed protocol). Greg Shah
12:33 PM User Interface Feature #1811: implement the AJAX client driver: For a better view. Marius Gligor
12:30 PM User Interface Feature #1811: implement the AJAX client driver: The following classes are used to emulate a terminal:
ChuiWebDriver extends (ChuiScreenDriver implements ScreenDri... Marius Gligor
12:28 PM User Interface Feature #1811: implement the AJAX client driver: I did a lot of improvements inside the JS code:
- I'm using JS sub modules stored on separate script files.
- Scree... Marius Gligor
10:33 AM User Interface Feature #1811: implement the AJAX client driver: Code Review 0110a
I am fine with the general approach and how the code is progressing.
I only have 3 comments:
... Greg Shah
08:26 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only): 0110e.zip was committed to bzr rev 10434. Constantin Asofiei
08:23 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only): Check it in and distribute. Greg Shah
02:42 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only): 0110e.zip has passed runtime testing. Constantin Asofiei
02:59 AM Base Language Feature #1641: implement SAX XML support: Review for 0112a.zip:
* all files are missing history entries. When you add history entries, don't forget to update ... Constantin Asofiei
08:59 PM Base Language Feature #1641: implement SAX XML support: added correct @DELETE@ operation for DOM/SAX. Evgeny Kiselev

01/12/2014

05:55 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: It seems TableMapper needs refactoring if we plan to add some new annotations to LegacyField like now I added format(... Vadim Nebogatov
04:42 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Vadim wrote (in email):
> The question: 'initial' was added in *.p2o as Ast node in contrast to other attributes adde... Eric Faulhaber

01/11/2014

05:53 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: The following also need implementation in BufferImpl:... Vadim Nebogatov
07:10 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Implemented bufferField(character) in BufferImpl. Attached update has not been regression tested, because it affects ... Vadim Nebogatov

01/10/2014

06:30 PM Database Bug #1914: database conversion requires Internet connectivity: Conversion on Windows virtual machine mode without networking causes the error:... Eugenie Lyzenko
04:29 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Constantin Asofiei wrote:
..
> * Keyboard - as for note 81 - why can't the initialization of DE_LOWEST and DE_HIGHEST... Vadim Gindin
10:03 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Vadim, I'm fine with the logic. All comments are about cleanup and javadoc/comment improvement:
* ClientState - you ... Constantin Asofiei
01:15 PM User Interface Feature #1811: implement the AJAX client driver: I designed minimal JS modules for Screen, Screen cursor, Message Beep and WebSocket communication management.
The at... Marius Gligor
01:05 PM Database Feature #2024 (Closed): implement runtime support for database triggers: Base trigger support is finished. Several bugs have been found and are being worked as separate tasks. Eric Faulhaber
10:32 AM Base Language Feature #1645: implement web services support: Greg, I'm fine with how the runtime works with my testing. I'll put this through regression testing once I'm done wit... Constantin Asofiei
09:38 AM Base Language Feature #1645: implement web services support: OK, finish your own testing AND take into account any feedback from Evgeny from his code review of WebServiceHelper.i... Greg Shah
09:13 AM Base Language Feature #1645: implement web services support: Added the TODO.
Evgeny: when you find some time, please take a look into WebServiceHelper.invoke, the core code fo... Constantin Asofiei
08:47 AM Base Language Feature #1645: implement web services support: I have no problem deferring this work. Please add comments to the javadoc to explain that the work is a TODO and the... Greg Shah
08:45 AM Base Language Feature #1645: implement web services support: Greg, all of these are not used by the server code. Also, the gain vs cost of implementing them I don't think is wort... Constantin Asofiei
08:38 AM Base Language Feature #1645: implement web services support: Everything looks good. My only question is related to this (and the related commented-out code):... Greg Shah
07:41 AM Base Language Feature #1645: implement web services support: Greg Shah wrote:
> 2. How safe is the use of IllegalArgumentException in SOAPHeaderImpl.getHeaderNode()/setHeaderNod... Constantin Asofiei
10:30 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only): Attached contains 0109c.zip (with a change in LogicalTerminal too, as TransactionManager no longer needs to be cached... Constantin Asofiei
09:35 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...: I have long been thinking on the details of this work. I will document a range of ideas here.
The ongoing effort ... Greg Shah
09:00 AM Base Language Feature #2225: implement ssl and async realted connection options for web services: The @-maxConnections@, @-connectionLifetime@, @-nosessionreuse@ and @-nohostverify@ options are not yet implemented b... Constantin Asofiei
08:57 AM Base Language Feature #2225 (New): implement ssl and async realted connection options for web services: Constantin Asofiei
04:31 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Go ahead and get it tested. Before committing, fix the tab characters in LT.setProcCurrentWindow:8627. Constantin Asofiei

01/09/2014

06:11 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): Lost new results picture. Vadim Gindin
06:09 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): > I thought that you meant 1-DOWN by the phrase "non-down frame".
Yes, you have it right. Greg Shah
06:06 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): Sorry, I made a simple logical error in my test and this led us to confusion. My error was in a rows number in the ou... Vadim Gindin
05:14 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Next update with last changes. Vadim Gindin
03:54 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Review for 0108a.zip:
* In files where the history entry is from 2014, update the copyright years in the file's head... Constantin Asofiei
07:01 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Here is an update with last changes. I merged it with current revision and checked if it is ok again. If I correctly ... Vadim Gindin
05:09 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Note 25 corrected, added one more error message after comparing with 4GL behavior. Vadim Nebogatov
04:34 PM Base Language Feature #1645: implement web services support: Code Review 0109d
1. SOAPFactory.throwError() needs javadoc.
2. How safe is the use of IllegalArgumentException... Greg Shah
03:09 PM Base Language Feature #1645: implement web services support: Attached update adds:
# runtime implementation for legacy SOAP Header, Header Entry, Fault and Fault Detail resource... Constantin Asofiei
03:54 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only): The changes look fine. Check them in when they pass testing. Greg Shah
02:57 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only): Fixes a couple of problems in appserver agents:
# @ProcedureManager$WorkArea$scopeFinished@ was popping the target-p... Constantin Asofiei
03:49 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Go ahead with the runtime testing. I'll do the review tomorrow. Constantin Asofiei
03:28 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Here is the update. I'm waiting for your permission to start regression testing. Vadim Gindin
03:56 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: > Correct result. I'm going to run regression testing.
Perfect. Post the update here, once you've added javadoc/todo's. Constantin Asofiei
07:33 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: I tested your ENDKEY test.
Progress shows:
PF4 - END-ERROR [KEYPRESS]
Java shows:
F4 - END-ERROR [KEYPRESS]
Cor... Vadim Gindin
03:09 PM Base Language Feature #2022 (Review): runtime support for web services: Constantin Asofiei
03:08 PM Base Language Feature #1995 (Review): runtime support for SOAP: Constantin Asofiei
03:05 PM Base Language Feature #1644: implement SOAP support: All updates and discussions for this task was moved to #1645. Constantin Asofiei
03:03 PM Database Bug #2223: ASSIGN schema triggers without reference to database fields: There are two kinds of ASSIGN schema triggers:
* related to a well known database field (declared using @TRIGGER PRO... Ovidiu Maxiniuc
02:41 PM Database Bug #2223 (New): ASSIGN schema triggers without reference to database fields: Ovidiu Maxiniuc
11:07 AM User Interface Feature #1811: implement the AJAX client driver: > 1. I think that is better to start by designing our custom binary protocol.
OK, good.
> 2. The Dojo toolkit S... Greg Shah
10:22 AM User Interface Feature #1811: implement the AJAX client driver: 1. I think that is better to start by designing our custom binary protocol. This means that we have to define the str... Marius Gligor
03:02 AM Base Language Feature #1641: implement SAX XML support: Evgeny Kiselev wrote:
>After deleting X-DOCUMENT all nodes become uninitialized.
You've checked only the root X-N... Constantin Asofiei
07:50 PM Base Language Feature #1641: implement SAX XML support: After deleting @X-DOCUMENT@ all nodes become uninitialized.... Evgeny Kiselev

01/08/2014

06:10 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Sorry, I forgot about this-procedure:current-window. Here is the test:... Vadim Gindin
04:23 PM User Interface Feature #1811: implement the AJAX client driver: > Maybe a short research on how to use GZIP with embedded jetty could be useful.
> Do you think that a JSON and GZIP... Greg Shah
01:28 PM User Interface Feature #1811: implement the AJAX client driver: 1. WebSockets are full-duplex communication channels over TCP. So we have to implements a communication protocol on s... Marius Gligor
10:51 AM User Interface Feature #1811: implement the AJAX client driver: Ref. #2201 implement the web client process spawning and server redirect.
Passed the regression tests.
Committed re... Marius Gligor
04:19 PM Database Bug #2221 (Closed): indexes not created or being dropped during data import: Eric Faulhaber
04:16 PM Database Bug #2221: indexes not created or being dropped during data import: Index creation after a table's data import (i.e., all non-unique indexes) was happening outside of a transaction, as ... Eric Faulhaber
03:23 PM Database Feature #1666 (Closed): add support for mixed-direction indexes: Eric Faulhaber
07:02 AM Database Feature #1666: add support for mixed-direction indexes: Constant CC_PREFIX - removed.
Also added the modifications into the P2JSQLServer2008Dialect.java, too, but this file... Ovidiu Maxiniuc
02:08 PM Database Bug #2222: WRITE event triggered too early: In some conditions, the WRITE event caused by the flush of the record to database occurs earlier than the correspondi... Ovidiu Maxiniuc
12:41 PM Database Bug #2222 (Hold): WRITE event triggered too early: Ovidiu Maxiniuc
01:46 PM Database Feature #1662: runtime support for table parameters: Code review 20140107a:
* I was a bit confused by the deferred copy error processing in @TemporaryBuffer@, with the... Eric Faulhaber
11:29 AM User Interface Feature #2201 (Closed): implement the web client process spawning and server redirect: Greg Shah
08:36 AM Base Language Feature #1641: implement SAX XML support: Evgeny, we missed something: deletion of the SAX and DOM/XML objects. How I've noticed this: the @XCommonImpl.resourc... Constantin Asofiei
11:50 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Once you are sufficiently comfortable that your @bufferField(character)@ implementation works properly with your test... Eric Faulhaber
07:46 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Vadim: the @bufferField(character)@ implementation looks good to me.
You don't need to implement @bufferField(int)... Eric Faulhaber

01/07/2014

06:46 PM Base Language Feature #1641: implement SAX XML support: Greg Shah wrote:
> Please place them in testcases/uast/xml/dom/ and testcases/uast/xml/sax/ directories.
DOM testca... Evgeny Kiselev
06:02 PM Base Language Feature #1641: implement SAX XML support: Passed the regression testing. Committed at bzr revision 10428.
Evgeny Kiselev
08:24 AM Base Language Feature #1641: implement SAX XML support: I have no objections. We need to get this committed as soon as it passes regression testing.
> BTW, I can't find ... Greg Shah
03:39 AM Base Language Feature #1641: implement SAX XML support: Did this pass testing? If yes, then this is next on queue to be committed, unless Greg has any objections.
BTW, I ... Constantin Asofiei
07:41 PM Base Language Feature #1641: implement SAX XML support: 1) merged with latest revision(removed SAX_ATTRIBUTES and SAX_READER from @IdKind@ enum, because all SAX objects are ... Evgeny Kiselev
06:05 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Just noticed that I needed to start from bufferField(character fieldName). It will reuse bufferField(String fieldName... Vadim Nebogatov
05:59 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: The question about @BufferImpl.bufferField(int fieldNumber@) implementation.
I am going to reuse @bufferField(Str... Vadim Nebogatov
03:12 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Eric Faulhaber wrote:
> Constantin: you left TODOs in the @QueryWrapper@ methods listed above in note 20. Did you de... Constantin Asofiei
01:26 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Implementation note: where new Java annotations are needed on DMOs to implement some of the above attributes, please ... Eric Faulhaber
01:14 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: I realize the previous 3 entries are not necessarily all about dynamic attributes and methods, but I needed to summar... Eric Faulhaber
01:05 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: The following need implementation in @QueryWrapper@:... Eric Faulhaber
01:03 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: The following need implementation in @FieldReference@:... Eric Faulhaber
01:01 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: The following need implementation in @BufferImpl@:... Eric Faulhaber
06:01 PM Base Language Feature #1988 (Review): runtime support for SAX: Evgeny Kiselev
06:00 PM Base Language Feature #1988 (WIP): runtime support for SAX: Evgeny Kiselev
02:51 PM Database Bug #2221: indexes not created or being dropped during data import: We seem to have introduced a regression to the data import process. Recent customer data imports are missing many of ... Eric Faulhaber
02:35 PM Database Bug #2221 (Closed): indexes not created or being dropped during data import: Eric Faulhaber
02:20 PM Database Feature #1669 (Closed): add support for additional database methods: Remaining methods are being coordinated from #1655. Eric Faulhaber
02:18 PM Database Feature #1661 (WIP): support case-sensitive fields in indexes: The remaining portion of this task is not needed for M7; moving to M11. Eric Faulhaber
02:15 PM Database Feature #2117 (Test): add runtime support for _lock metadata table: Eric Faulhaber
02:14 PM Database Feature #1666: add support for mixed-direction indexes: Code review 20131221a:
Looks good. Please remove the commented-out @P2JH2Dialect.CC_PREFIX@ class variable -- no n... Eric Faulhaber
01:47 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Vadim Gindin wrote:
> I mean, what tests do you consider as basic?
Case 8 from the table, @widget and key events@, ... Constantin Asofiei
01:08 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: I mean, what tests do you consider as basic? Vadim Gindin
01:07 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Constantin Asofiei wrote:
> .. just ensure the basic tests work.
I wrote in the table results of all tests I have... Vadim Gindin
09:20 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: After contacting Guy, the conclusion is that the server project does not use the program which reads the LAST-EVENT:L... Constantin Asofiei
08:41 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: > Greg: can ENDKEY label (and last-key) be ever produced by user key press?
I'm not sure. Normally, I would have ... Greg Shah
05:00 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: The server project uses the LAST-EVENT:LABEL in only one place, with a case like (this is an assumption, as I can't f... Constantin Asofiei
01:41 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Review of 0107a.zip:
* please try not to post updates merged with other tasks; if you find it difficult to work more... Constantin Asofiei
01:01 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Sorry I forgot to add the comment about the path. Here is updated archive. Vadim Gindin
12:56 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Here is an update with last changes. Vadim Gindin
12:04 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: I ran the program using @pro -p a.p@; if you run it using @pro -p somefolder/a.p@, then you will have @somefolder/a.p... Constantin Asofiei
12:01 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Yes, I checked it again. My exact message is:
@** /home/vig/winhandles/simple2.p: Unable to evaluate field for assig... Vadim Gindin
11:52 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Vadim Gindin wrote:
> Thank you, but Progress shows full path to procedure file starting from root folder "/". @Envi... Constantin Asofiei
11:32 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Thank you, but Progress shows full path to procedure file starting from root folder "/". @EnvironmentOps.getSourceNam... Vadim Gindin
10:37 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Vadim Gindin wrote:
> Constantin, could you help me. I didn't find in @ErrorManager@ a possibility to include in the... Constantin Asofiei
10:32 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Constantin, could you help me. I didn't find in @ErrorManager@ a possibility to include in the error message the name... Vadim Gindin
07:04 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Great. Please finish the changes I mentioned in note 27 (expect the @current-window = ?@ case) and post the update here. Constantin Asofiei
06:06 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Yes it works and moreover there are no more need to move KW_NO_ERROR manually. Here is the new AST node:... Vadim Gindin
05:08 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: > It seems it because KW_NO_ERROR is inside expression and unfortunately I forced to wrap EXPRESSION inside STATEMENT... Constantin Asofiei
04:54 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: I understand, thank you. Now it produces this Java code:... Vadim Gindin
03:47 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Vadim Gindin wrote:
> I added first change in the frame_scoping.rules to emit KW_NO_ERROR in a some place in the tar... Constantin Asofiei
01:04 PM Database Feature #2024: implement runtime support for database triggers: From Ovidiu's email response:
The @openReadOnlyScope()@ is not needed any more. The OLD buffer is built in Databas... Eric Faulhaber
01:19 AM Database Feature #2024: implement runtime support for database triggers: The following trigger-related methods are present but not implemented in @BufferImpl@:... Eric Faulhaber
01:01 PM Database Feature #1662 (Test): runtime support for table parameters: Eric Faulhaber
02:43 AM Database Feature #1662: runtime support for table parameters: Merged with the latest P2J. Stanislav Lomany
12:45 PM Database Feature #1588 (Closed): add conversion and runtime support for embedded SQL: Eric Faulhaber
12:43 PM Database Feature #2043 (Closed): add runtime support for some embedded SQL features: Eric Faulhaber
12:42 PM Database Feature #2126 (Closed): add support for table-level locking (share and exclusive) for runtime int...: Eric Faulhaber
12:39 PM Database Feature #1653 (Closed): add conversion and runtime support for dynamically prepared queries: Eric Faulhaber
12:35 PM Database Feature #2080 (Closed): add runtime support for database methods: All remaining, database-related methods and attributes are being managed through issue #1655. Eric Faulhaber
12:32 PM Database Feature #1654 (Closed): add conversion and runtime support for dynamic buffer creation and cleanup: Eric Faulhaber
12:31 PM Database Feature #2125 (Closed): add runtime support for dynamic buffer creation and cleanup: Eric Faulhaber
12:29 PM Database Feature #2120 (Closed): add runtime support for dynamically prepared queries: The problematic test cases above have been recorded in #2220, as they are not expected to be needed for M7. Eric Faulhaber
12:27 PM Database Feature #2220: dynamic query methods which require implementation: The following need implementation in @QueryWrapper@:... Eric Faulhaber
12:27 PM Database Feature #2220 (Closed): dynamic query methods which require implementation: Eric Faulhaber
12:25 PM Database Bug #2219: problematic dynamic query test cases: *Originally reported by Stanislav in #2120:*
Variation of the bug above. Testcase:... Eric Faulhaber
12:24 PM Database Bug #2219: problematic dynamic query test cases: *Originally reported by Stanislav in #2120:*
Yet another minor bug. Testcase:... Eric Faulhaber
12:22 PM Database Bug #2219 (Closed): problematic dynamic query test cases: Eric Faulhaber
12:21 PM User Interface Feature #1811: implement the AJAX client driver: Code Review 0107a
I am fine with the changes. When it passes regression testing, please check it in and distribut... Greg Shah
11:42 AM User Interface Feature #1811: implement the AJAX client driver: Here are the latest changes on my local repository after an update from remote repository.
Only two files was merged... Marius Gligor
12:12 PM Database Feature #1668 (Closed): add support for additional (non-dynamic) database attributes: See #1655. Eric Faulhaber
12:11 PM Database Feature #1975 (Closed): add runtime support for (non-dynamic) database attributes: I am closing this issue; the remaining methods and attributes are being managed through issue #1655. Eric Faulhaber

01/06/2014

05:46 PM Base Language Feature #2041 (Closed): implement runtime support for "shared" attributes that are just stubbed: Greg Shah
05:09 PM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed: The final change set attached. Committed at revision 10427. Hynek Cihlar
07:49 AM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed: OK, remove the @ProcedureManager.setInstantiatingProcedure@ (because is no longer used and it will just confuse reade... Constantin Asofiei
07:44 AM Base Language Feature #2041 (Review): implement runtime support for "shared" attributes that are just stubbed: Hynek Cihlar
07:40 AM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed: Fixed and changes attached. Regression tests passed. Hynek Cihlar
05:10 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Yes It will be simpler. But It looks like the last change you propose is a solution of some private task. I added fir... Vadim Gindin
02:29 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: > KW_NO_ERROR probably should not be included inside EXPRESSION. Am I right? The question is how this ast node should... Constantin Asofiei
02:10 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: I corrected the rules block you specified to force it transfer KW_NO_ERROR too and got this ast node (after annotatio... Vadim Gindin
09:11 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Vadim Gindin wrote:
> I can only suspect that the transformation from @assignment@ to @expression@ is going in the a... Constantin Asofiei
09:06 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Thank you Constantin!
I ran the conversion process with @f2+cb@ options and got my first result, but when I ran th... Vadim Gindin
07:58 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Vadim, to identify if the problem is in the parser, then is best to check the AST generated by the FRONT phase, as th... Constantin Asofiei
03:42 PM User Interface Feature #1811: implement the AJAX client driver: Something else to consider with the protocol is that the GUI driver/javascript will have more significant requirement... Greg Shah
03:32 PM User Interface Feature #1811: implement the AJAX client driver: Additional Details on the Protocol
1. The protocol will need to be full-duplex. It must be possible to have both ... Greg Shah
03:06 PM User Interface Feature #1811: implement the AJAX client driver: > We have to design the protocol used by websockets.
> We have two options: JSON or binary payloads. As I remember y... Greg Shah
02:55 PM User Interface Feature #1811: implement the AJAX client driver: Code Review 1223a
I am fine with the changes.
Please merge up to the latest bzr revision (10426) and then run r... Greg Shah
03:36 PM Base Language Feature #2184: create and populate the temp-table on the remote side, based on the received metad...: This comes into play to dynamically create and/or populate an input temp-table (on the appserver side) or an output t... Greg Shah
03:16 PM Base Language Feature #1645: implement web services support: Greg Shah wrote:
> Other than that, my only question is in ControlFlowOps.initializeProxy(), is there any way the Il... Constantin Asofiei
11:43 AM Base Language Feature #1645: implement web services support: Code Review 1224a
I like the improved abstraction of some parts of the runtime (e.g. ServerHelper). It also seems... Greg Shah
02:37 PM Database Feature #1666: add support for mixed-direction indexes: Updated and cleaned-up version of the previous patch.
Some files were removed from the zip as their changes has alr... Ovidiu Maxiniuc
02:36 PM User Interface Feature #1787 (Closed): implement batch mode support: Greg Shah
02:05 PM User Interface Feature #1787: implement batch mode support: evl_upd20131221b.zip did pass the regression testing and committed to bzr as 10426. Eugenie Lyzenko
10:15 AM User Interface Feature #1787: implement batch mode support: Go ahead, commit and distribute it. Greg Shah
09:18 AM User Interface Feature #1787: implement batch mode support: Greg Shah wrote:
> Constantin: do you see any concerns?
I don't see any obvious problems in the logic. My only conc... Constantin Asofiei
08:53 AM User Interface Feature #1787: implement batch mode support: I am OK with the changes.
Constantin: do you see any concerns?
If not, then the check in can proceed. Greg Shah
02:13 PM Database Feature #1662: runtime support for table parameters: TABLE/TABLE-HANDLE parameters work with the following exceptions:
1. extents copying doesn't work;
2. @thparm-inval... Stanislav Lomany
01:22 PM User Interface Feature #2027 (Closed): preliminary runtime support for CREATE_WIDGET and an IN WINDOW clause: Greg Shah
01:20 PM Base Language Feature #2208: create a java application running web services for testing purposes: Some more notes: 4GL seems to alter the received SOAP Envelope by adding i.e. additional XMLNS attributes at the root... Constantin Asofiei
01:16 PM User Interface Feature #2212 (WIP): design websockets protocol for bidirectional communication between the javas...: Marius Gligor
11:12 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Constantin will be the one doing a more detailed review of your latest code.
I have taken a quick look at the code... Greg Shah
10:13 AM Base Language Feature #1995 (WIP): runtime support for SOAP: Constantin Asofiei
09:45 AM User Interface Feature #1801: add some frame options: > Could somebody explain the rationale behind the varying end escape sequences? I.e., why are some colors terminated ... Greg Shah
07:42 AM Base Language Feature #1641: implement SAX XML support: Review for 0104a.zip:
* SaxAttributesImpl.removeAttribute (both versions): javadoc for the parameters is not on dist... Constantin Asofiei

01/05/2014

01:48 PM Database Feature #1662: runtime support for table parameters: Stanislav Lomany wrote:
> [...]
> The ideas that I have:
> 1. Create prioritized finalizables.
> 2. Track all sta... Eric Faulhaber
10:23 AM User Interface Feature #1801: add some frame options: Greg Shah wrote:
> Alright, please do try to resolve the variable end sequences as elegantly as possible. Try to im... Hynek Cihlar
07:03 PM Base Language Feature #1645: implement web services support: Constantin Asofiei wrote:
> LE: Nevermind, there is the @XmlHelper.write@ in P2J.
I've used for SAX writer:... Evgeny Kiselev

01/04/2014

05:04 PM Database Feature #1662: runtime support for table parameters: Eric, please consider OUTPUT TABLE-HANDLE parameters, like this:... Stanislav Lomany
04:44 PM Base Language Feature #1645: implement web services support: LE: Nevermind, there is the @XmlHelper.write@ in P2J. Constantin Asofiei
04:01 PM Base Language Feature #1645: implement web services support: Evgeny: please help me a little with something related to @X-Noderef@ resources. Is there an existing way to serializ... Constantin Asofiei
02:56 PM Base Language Feature #1641: implement SAX XML support: fixed issues from note 90 Evgeny Kiselev
12:45 PM Base Language Feature #1641: implement SAX XML support: Constantin Asofiei wrote:
> Review for 1231a.zip:
> # what are licences for the new jars?
under BSD license. It wa... Evgeny Kiselev
01:23 PM User Interface Feature #1787: implement batch mode support: Well, I've got the CTRL-C tests fully passed in one round. Take a look at 2014 year results from:
10425_ed8b6f3_2014... Eugenie Lyzenko
04:29 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Thank you for the explanation. I wrote an ast node in my previous comment (#28). Vadim Gindin

01/03/2014

01:56 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: First, in regard to your specific problem, I doubt the issue is in the parser. The NO-ERROR should emit as:
ErrorMa... Greg Shah
01:53 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: I'm trying to fix no-error loose during conversion of this statement:
@current-window = h no-error.@
I am viewi... Vadim Gindin
06:05 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Some general notes:
# in the implementations for all @current/default/active-window@ APIs in @LogicalTerminal@, wher... Constantin Asofiei
12:18 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): > Well, the current-iteration is not linked with an iterating block
Yes, this is exactly how we have implemented d... Greg Shah
10:42 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): Vadim Gindin wrote:
> P.S. About numbering. What problem do you see in it? I viewed same values for newly created wi... Constantin Asofiei
08:13 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): Here are widget attrs:
!widget_attrs.png!
In this result we can see values of following attrs (in order of appearing)... Vadim Gindin
05:14 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): Well, the @current-iteration@ is not linked with an iterating block; lets take this case:... Constantin Asofiei
12:10 PM User Interface Feature #1801: add some frame options: Alright, please do try to resolve the variable end sequences as elegantly as possible. Try to implement the simple/s... Greg Shah
07:17 PM User Interface Feature #1801: add some frame options: Greg Shah wrote:
> If I understand you correctly, you are suggesting that for NCurses/Curses we directly use the par... Hynek Cihlar
07:10 AM Base Language Feature #2208: create a java application running web services for testing purposes: Evgeny, please make it a priority to add basic services which work with SOAP Faults and SOAP Headers (response and re... Constantin Asofiei
07:09 AM Base Language Feature #1644: implement SOAP support: I've started working on finishing the SOAP Fault support (part of #1645). The SOAP Header support is highly dependent... Constantin Asofiei
04:34 AM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed: OK, the location is the right one, but you need to do it only if we are starting an external proc; also, remove the @... Constantin Asofiei
04:15 AM Base Language Feature #1641: implement SAX XML support: Review for 1231a.zip:
# what are licences for the new jars?... Constantin Asofiei

01/02/2014

02:39 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): This is somewhat consistent with my theory. On a 5-down frame, you would expect 5 sets of widgets, but it looks like... Greg Shah
01:08 PM User Interface Feature #1801: add some frame options: This is going in the right direction.
If I understand you correctly, you are suggesting that for NCurses/Curses we... Greg Shah
11:33 PM Database Feature #1662: runtime support for table parameters: We already have an annotation like this for #2134, but currently it is only for extent fields which have been expande... Eric Faulhaber

01/01/2014

05:17 PM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed: Calling @ProcedureManager.setInstantiatingProcedure@ from the constructor of @ExternalProgramWrapper@ is too early, a... Hynek Cihlar
08:02 PM Base Language Feature #1641: implement SAX XML support: 1) added DTD validation with specific schema-paths
2) added XSD schema validation
3) added callback resolveEntity pro... Evgeny Kiselev

12/31/2013

06:56 PM User Interface Feature #1801: add some frame options: Here's a proposed sample of the xml format for storing the color mappings. Parsing the escape sequence into a more st... Hynek Cihlar
08:46 PM User Interface Feature #1801: add some frame options: Internally to P2J, a color is represented with the @Color@ class. The @Color@ class holds the (logical) color value a... Hynek Cihlar
09:51 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): I've prepared first test... Vadim Gindin

12/30/2013

11:32 AM Database Feature #1662: runtime support for table parameters: Eric, @TemporaryBuffer.copyAlRows@ which is supposed to perform record copy upon calling a procedure which uses TABLE... Stanislav Lomany

12/29/2013

05:30 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): The objective for this task is to implement the CURRENT-ITERATION attribute for widgets. The documentation is quite ... Greg Shah
05:07 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): From the Progress Language Reference for v11.0:... Greg Shah

12/26/2013

06:21 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...: Metadata problem is found for denormalized fields with extent:
Caused by: org.h2.jdbc.JdbcSQLException: Unique in... Vadim Nebogatov

12/25/2013

06:55 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Here is an update. Sorry that it is merged with 1782 changes. It's not final. In this task there is only @setCurrentW... Vadim Gindin
05:52 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: no-error in the case of current-window errors sets ERROR-STATUS:ERROR flag to true. Vadim Gindin
05:50 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Here are test cases:
> > 1) same.p - testing equality of all t... Vadim Gindin
04:30 PM User Interface Feature #1787: implement batch mode support: Greg,
The runtime regression tests are finally all passed. The results can be found in 10425_ed8b6f3_20131225_evl.... Eugenie Lyzenko
07:33 PM Base Language Feature #1641: implement SAX XML support: This update has passed regression.
But I have found that I forgot implementation of @NONAMESPACE-SCHEMA-LOCATION@ ... Evgeny Kiselev

12/24/2013

05:26 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Here is an update, containing current solutions. Vadim Gindin
08:35 AM User Interface Feature #1787: implement batch mode support: The testing results summary at this time:
1. The main part is OK.
2. The 3-way CTRL-C tests are passed.
3. The 2-w... Eugenie Lyzenko
07:40 AM Base Language Feature #1645: implement web services support: This version adds validation for the header callback proc/context and fixes the soap faults (though some more testing... Constantin Asofiei
06:15 AM Base Language Feature #2215: implement the unwrapped mode of passing parameters to web service requests: OpenEdge's unwrapped mode allows 4GL values and variables as arguments for a web service request; these are automatic... Constantin Asofiei
06:01 AM Base Language Feature #2215 (New): implement the unwrapped mode of passing parameters to web service requests: Constantin Asofiei

12/23/2013

05:59 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Table contains testcases and results for both Progress and Java.
"Progress" column contains expected output. Testca... Vadim Gindin
09:57 AM User Interface Feature #1811: implement the AJAX client driver: Marius Gligor wrote:
> Actually the build does not require sudo permissions. You have to use some command line argum... Constantin Asofiei
09:52 AM User Interface Feature #1811: implement the AJAX client driver: Actually the build does not require sudo permissions.
You have to use some command line arguments to execute the pos... Marius Gligor
09:44 AM User Interface Feature #1811: implement the AJAX client driver: Marius Gligor wrote:
> Constantin: I think that is no need to do that. This issue should be tested only on a local c... Constantin Asofiei
09:38 AM User Interface Feature #1811: implement the AJAX client driver: Constantin: I think that is no need to do that. This issue should be tested only on a local copy of Majic not on devs... Marius Gligor
09:33 AM User Interface Feature #1811: implement the AJAX client driver: Go ahead with regression testing on devsrv01 *without* making changes to enable the web chui. That will allow us to g... Greg Shah
09:30 AM User Interface Feature #1811: implement the AJAX client driver: Marius: I've made the sudo-related changes for your account on devsrv01. After regression testing passes, make sure t... Constantin Asofiei
08:36 AM User Interface Feature #1811: implement the AJAX client driver: On Saturday and today I did a lot of tests on a local copy of Majic project.
Finally I succeeded to configure the di... Marius Gligor
08:13 AM Base Language Feature #1645: implement web services support: I've cleaned up and documented the code for the web services implementation. What major features are missing:
* fini... Constantin Asofiei
03:07 AM Base Language Feature #1641: implement SAX XML support: Evgeny, the logic looks good, I don't have any other comments beside some formatting/javadoc issues and some left-beh... Constantin Asofiei
08:07 PM Base Language Feature #1641: implement SAX XML support: Constantin Asofiei wrote:
> Review for 1215a.zip:
> - MemptrInputStream.read - is it possible to save the mptr.leng... Evgeny Kiselev
02:32 AM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed: 1222a.zip looks good, go ahead and get it regression tested. Constantin Asofiei
07:08 PM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed: Fixed the issues with the INSTANTIATING-PROCEDURE attribute. Also resolved an incoming conflict on the @BufferImpl.ge... Hynek Cihlar
07:16 PM User Interface Feature #2037 (WIP): runtime support for frame options: Hynek Cihlar

12/21/2013

03:57 PM User Interface Feature #1787: implement batch mode support: Merging StandardServer.java with recent code base(10425). Will be used in testing from now. Eugenie Lyzenko
07:52 AM User Interface Feature #1787: implement batch mode support: Merging ErrorManager.java with recent code base(10424). Will be used in testing from now. Eugenie Lyzenko
03:31 AM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: 1220a.zip passed testing, was committed to bzr rev 10424. Constantin Asofiei

12/20/2013

06:41 PM User Interface Feature #1787: implement batch mode support: > That is good. Get this tested.
The testing is on the way. Eugenie Lyzenko
06:39 PM User Interface Feature #1787: implement batch mode support: That is good. Get this tested. Greg Shah
06:23 PM User Interface Feature #1787: implement batch mode support: > After adding the comments, upload that version and start testing.
OK. The comments have been added. Eugenie Lyzenko
06:09 PM User Interface Feature #1787: implement batch mode support: Code Review 1220a
I am fine with the changes.
> The key point here is he have to return some correct values her... Greg Shah
01:18 PM User Interface Feature #1787: implement batch mode support: This update cleans previous notes.
Also I remembered one point under the question. The @BatchPrimitives.java@ clas... Eugenie Lyzenko
11:20 AM User Interface Feature #1787: implement batch mode support: > Normally it should not happen but may be failure in initErrorWriter()? Is this not necessary?
It is good that yo... Greg Shah
10:33 AM User Interface Feature #1787: implement batch mode support: > 1. All EVL** comments need to be removed so that this can be finalized. In general, I prefer if you do not use this... Eugenie Lyzenko
09:14 AM User Interface Feature #1787: implement batch mode support: Code Review 1219a
1. All EVL** comments need to be removed so that this can be finalized. In general, I prefer if... Greg Shah
06:38 PM Base Language Feature #1645: implement web services support: 1. Create new redmine tasks for the unwrapped mode and any error/fault processing that is not being implemented. Put... Greg Shah
02:36 PM Base Language Feature #1645: implement web services support: The wrapped mode is working nicely, async mode is almost done too (only remaining feature is canceling the requests),... Constantin Asofiei
04:44 PM User Interface Feature #1811: implement the AJAX client driver: Related to JS frameworks. I have some experience using jQuery but no experience using other frameworks.
Marius Gligor
02:30 PM User Interface Feature #1811: implement the AJAX client driver: Yes I did that when I tested Admin Console on my local station. So I have to do tests on my local station and after t... Marius Gligor
02:14 PM User Interface Feature #1811: implement the AJAX client driver: Marius Gligor wrote:
> After the local tests you suggest me to repeat the regression tests?
Yes
> What I want to d... Constantin Asofiei
02:03 PM User Interface Feature #1811: implement the AJAX client driver: I did something similar with AdminConsole if you remember.
After the local tests you suggest me to repeat the regres... Marius Gligor
01:54 PM User Interface Feature #1811: implement the AJAX client driver: Marius Gligor wrote:
> Monday I want to do runtime tests first on my workstation and then on devsvr01.
Regression t... Constantin Asofiei
01:48 PM User Interface Feature #1811: implement the AJAX client driver: Here are the latest changes that I made. Monday I want to do runtime tests first on my workstation and then on devsvr... Marius Gligor
01:14 PM User Interface Feature #1811: implement the AJAX client driver: Greg Shah wrote:
> Constantin: can you make the sudoers file changes? See the postbuild.sh for details.
Yes, I can... Constantin Asofiei
01:06 PM User Interface Feature #1811: implement the AJAX client driver: > Also keep in mind that the p2j.jar location detection is done on the server instance and is absolute to the user on... Greg Shah
01:02 PM User Interface Feature #1811: implement the AJAX client driver: Here are some details on our approach in regard to javascript frameworks.
1. Cross-browser compatibility is still ... Greg Shah
12:55 PM User Interface Feature #1811: implement the AJAX client driver: Also keep in mind that the p2j.jar location detection is done on the server instance
and is absolute to the user on ... Marius Gligor
12:45 PM User Interface Feature #1811: implement the AJAX client driver: We can detect the location of p2j.jar as you already mention and I use this method in the previous snapshots but I th... Marius Gligor
12:02 PM User Interface Feature #1811: implement the AJAX client driver: > I think we should be able to determine the library path and the classpath dynamically.
This will work as a defa... Greg Shah
11:59 AM User Interface Feature #1811: implement the AJAX client driver: Actually, I think we should be able to determine the library path and the classpath dynamically. See the code in @App... Constantin Asofiei
11:18 AM User Interface Feature #1811: implement the AJAX client driver: > Keep in mind that each user on devsrv01 has a ~/testing/majic/p2j folder.
This is why I prefer to use relative p... Greg Shah
11:13 AM User Interface Feature #1811: implement the AJAX client driver: > We cannot provide relative paths for this values we have to specify absolute paths.
Most production environments... Greg Shah
10:20 AM User Interface Feature #1811: implement the AJAX client driver: I think the solution for devsrv01 is not about setting relative paths, but computing the full paths dynamically for e... Constantin Asofiei
10:08 AM User Interface Feature #1811: implement the AJAX client driver: Classpath, native libraries path and spawner location should be shared by all web clients.
We cannot provide relativ... Marius Gligor
09:57 AM User Interface Feature #1811: implement the AJAX client driver: I still prefer you to test on devsrv01 with the chui web active. This will make sure that we have a real chui enviro... Greg Shah
09:28 AM User Interface Feature #1811: implement the AJAX client driver: Also I could provide platform specific (Linux/Windows) default values and do only runtime tests with Majic build on m... Marius Gligor
09:23 AM User Interface Feature #1811: implement the AJAX client driver: > If the server standard subject is not added to admin ACL the pool is empty and no client could be spawned.
I'm f... Greg Shah
09:06 AM User Interface Feature #1811: implement the AJAX client driver: I provided default values for all this parameters (see ClientBuilderOptions).
Now the server starts without errors... Marius Gligor
08:45 AM User Interface Feature #1811: implement the AJAX client driver: ... Greg Shah
09:21 AM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: Code Review 1220a
I am fine with the changes. I think that these errors are really things that are generically ra... Greg Shah
06:27 AM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: This version raises the "** Value too large for integer. (78)" if the given value can't be stored in a 64 bit integer... Constantin Asofiei
06:38 AM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed: PS: the @ProcedureManager.getInstantiatingProcedure(Object referent);@ will perform no validation, will return the ha... Constantin Asofiei
06:37 AM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed: Review of 1219a.zip:
# I would prefer to have a @ProcedureManager.setInstantiatingProcedure(Object referent, handle i... Constantin Asofiei

12/19/2013

06:07 PM User Interface Feature #1787: implement batch mode support: The update implements the strange 4GL feature founded during debugging batch mode redirected cases. The @ENABLE@ stat... Eugenie Lyzenko
05:41 PM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed: Changes attached, please review. Regression test is pending. Hynek Cihlar
02:44 PM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: AFAIK, the subtract is correct for the 2s complement, but the code is missing check for value greater than max unsign... Hynek Cihlar
12:27 PM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: OK, one more question about the TWO_64 usage. In @ResourceIdHelper.idFromString@, you have this code (btw, shouldn't ... Constantin Asofiei
11:59 AM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: True, I was looking at the other method. Please ignore the comment about throwing an exception when calling @handle.f... Hynek Cihlar
10:02 AM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: Hynek Cihlar wrote:
> Sorry, I didn't express myself clearly. With your change, when "-1" is passed to @handle.fromS... Constantin Asofiei
09:54 AM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: Constantin Asofiei wrote:
> > Also when you call @handle.fromString()@ with a negative number, an exception is throw... Hynek Cihlar
09:01 AM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: Hynek Cihlar wrote:
> Constantin, I would remove the doc references about treating the long as unsigned number, now ... Constantin Asofiei
08:54 AM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: Constantin, I would remove the doc references about treating the long as unsigned number, now we use it as plain sign... Hynek Cihlar
08:00 AM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: Code Review 1219b
I am OK with the changes. If Hynek is OK with them, then go ahead with testing. Greg Shah
02:40 AM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: This is 1218a.zip merged with latest rev. 1218a.zip passed, 1219a.zip was committed to bzr revision 10423.
1219b.z... Constantin Asofiei
02:37 PM User Interface Feature #1811: implement the AJAX client driver: Code Review 1219b
The changes look good. Greg Shah
01:03 PM User Interface Feature #1811: implement the AJAX client driver: I added a conditional build variable ${have.pam} for Linux / Unix native build targets in build.xml script file.
The... Marius Gligor
12:27 PM User Interface Feature #1811: implement the AJAX client driver: OK. Now the project was successfully build on devsvr01.
Nevertheless I'm going to add the PAM variable for conditio... Marius Gligor
12:19 PM User Interface Feature #1811: implement the AJAX client driver: > Another option is to define a build variable like -Dpam=yes in order to build spawn.c with PAM option.
> By defaul... Greg Shah
12:01 PM User Interface Feature #1811: implement the AJAX client driver: Another option is to define a build variable like -Dpam=yes in order to build spawn.c with PAM option.
By default th... Marius Gligor
11:42 AM User Interface Feature #1811: implement the AJAX client driver: In order to install PAM libraries we need to install this package:
sudo apt-get install libpam0g-dev
Marius Gligor
11:21 AM User Interface Feature #1811: implement the AJAX client driver: I've started to do the regression tests. When I executed this step:
run_regression.sh build && run_regression.sh s... Marius Gligor
08:52 AM User Interface Feature #1811: implement the AJAX client driver: Code Review 1219a
Everything looks good. Please get this regression tested (only runtime testing is needed).
I... Greg Shah
08:07 AM User Interface Feature #1811: implement the AJAX client driver: I did some small changes inside the security package to allow update of user accounts stored in security cache.
1.... Marius Gligor

12/18/2013

05:24 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...: I think your approach is good. If you can cleanly refactor this feature into a stand-alone, top-level class with mini... Eric Faulhaber
05:03 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...: I have created in RecordBuffer... Vadim Nebogatov
05:16 PM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: Constantin Asofiei wrote:
> I should have caught this earlier. Why are negative resource ids ignored in @ResourceIdHe... Hynek Cihlar
05:04 PM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: Constantin Asofiei wrote:
> Fixed signatures of static proxy methods. Added logging to @RemoteObject.registerStaticN... Hynek Cihlar
03:20 PM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: Code Review 1218a
The changes all look good.
The LT will need merging with the one just checked in by VIG.
I... Greg Shah
08:20 AM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: Fixed signatures of static proxy methods. Added logging to @RemoteObject.registerStaticNetworkServer@, to report any ... Constantin Asofiei
06:22 AM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: I should have caught this earlier. Why are negative resource ids ignored in @ResourceIdHelper.idFromString@?... Constantin Asofiei
04:50 AM Base Language Bug #2183: fix resource save/restoration when used with string/handle functions: Some socket-related static proxy methods got bad after the 1118a.zip update, as some signatures are out-of-sync. I'm ... Constantin Asofiei
01:22 PM User Interface Feature #1811: implement the AJAX client driver: Unfortunately I found that changing the TAB characters in makefile results in a make error related to missing separat... Marius Gligor
01:05 PM User Interface Feature #1811: implement the AJAX client driver: Code Review 1218a
Really good improvements. Yes, we are close now.
> 5. For security reasons when an account i... Greg Shah
12:20 PM User Interface Feature #1811: implement the AJAX client driver: I've fixed almost all the issues reported on your code reviews with some remarks:
1. In TemporaryAccountPool, the ... Marius Gligor
09:27 AM User Interface Feature #1811: implement the AJAX client driver: > In my opinion authentication is done relative rarely and isn't used intensively by users.
In comparison to the r... Greg Shah
09:16 AM User Interface Feature #1811: implement the AJAX client driver: According to my tests without a "refresh" the account changes (enable/disable) are not "visible" and when the client ... Marius Gligor
08:41 AM User Interface Feature #1811: implement the AJAX client driver: > in UpdateAccountTask.run, we are calling AdminServerImpl.targetRefresh();. This is a very expensive operation (as i... Greg Shah
03:13 AM User Interface Feature #1811: implement the AJAX client driver: Review for 1217a (beside Greg's notes):
* in @makefile.spawn@, you are using tabs for indenting. More, in @postbuild... Constantin Asofiei
09:12 PM User Interface Feature #1811: implement the AJAX client driver: After #2201, you will next be working on #2212. I will add more details/guidance tomorrow. If you run out of work b... Greg Shah
08:59 PM User Interface Feature #1811: implement the AJAX client driver: Code Review 1217a
1. @if(web)@ in ClientCore should be @if (web)@.
2. In TemporaryAccountPool, the import of Lo... Greg Shah
01:11 PM User Interface Feature #1791: implement dynamic UI support: Here it is. Vadim Gindin
01:07 PM User Interface Feature #1791: implement dynamic UI support: Please post the final changes. Greg Shah
01:02 PM User Interface Feature #1791: implement dynamic UI support: Regression passed, committed to bzr rev #10421. Vadim Gindin
08:20 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Notes about your findings:
# please merge your update and post it here.
# you need to hard code the expected values... Constantin Asofiei
04:32 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: A quick note about the MethodInvoker problems: some static proxies got bad after the handle resource ID changes, I'm ... Constantin Asofiei
04:56 AM Database Feature #1662: runtime support for table parameters: Attached testcases for external procedures. The plan is:
1. Implement/fix all issues for static temp tables (e.g. ad... Stanislav Lomany
01:46 AM Database Feature #2024: implement runtime support for database triggers: I believe this is the listing of the previously attached file. It's the 1st time I have done this, I didn't know this... Ovidiu Maxiniuc
09:09 PM User Interface Feature #2212: design websockets protocol for bidirectional communication between the javascript ...: This task is for time management only. Please put all history into the parent task #1811. Greg Shah
09:09 PM User Interface Feature #2212 (Closed): design websockets protocol for bidirectional communication between the ja...: Greg Shah
07:21 PM User Interface Feature #1787: implement batch mode support: The next update for review. Includes small fixed discovered in test-cases debugging and code to suppress the batch mo... Eugenie Lyzenko

12/17/2013

06:59 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: I've committed all tests for LAST-EVENT I have. rev #1075. Vadim Gindin
06:15 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: 13) Asynchronous calls... Vadim Gindin
07:24 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes: Here are the test cases. I rewrote it to make it simpler and independent of key presses or other events.
1) Read... Vadim Gindin
02:03 PM Base Language Feature #1645: implement web services support: I have reviewed the above findings. The approach seems reasonable. I'll check the licenses for the AXIS2 dependenci... Greg Shah
12:56 PM Base Language Feature #1645: implement web services support: In regard to the CPL 1.0, it is acceptable to use code under that license.
License text:
http://opensource.org/... Greg Shah
01:41 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...: On 12/16/2013 05:28 PM, Vadim wrote:
Eric, Greg,
Are there any examples or manual how to correctly emit KW_SWITC... Vadim Nebogatov
12:18 PM Database Feature #2024: implement runtime support for database triggers: It does appear you are correct in your conclusion that we are validating too early. Did you confirm that P2J is flush... Eric Faulhaber
06:46 AM User Interface Feature #1811: implement the AJAX client driver: Add code to terminate the thread on server shut down some minor changes. Marius Gligor

12/16/2013

03:21 PM Database Feature #2024: implement runtime support for database triggers: I attached a testcase. The expected output (from 4GL) is commented at the end of the file. I only can fire the WRITE ... Ovidiu Maxiniuc
01:38 PM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed: Constantin Asofiei wrote:
> Hynek, changes look good, nice catch with the UNIQUE-ID/ADM-DATA for a procedure resourc... Hynek Cihlar
04:20 AM Base Language Feature #2041: implement runtime support for "shared" attributes that are just stubbed: Hynek, changes look good, nice catch with the UNIQUE-ID/ADM-DATA for a procedure resource (that it should not be save... Constantin Asofiei
01:24 PM User Interface Feature #1811: implement the AJAX client driver: New design. Fixed size for temporary accounts pool. Marius Gligor
12:57 PM User Interface Feature #1811: implement the AJAX client driver: OK. I started to change the design to have a fixed pool of accounts.
Marius Gligor
11:24 AM User Interface Feature #1811: implement the AJAX client driver: Marius Gligor wrote:
> 5. On heavy loaded systems when the pool potentially became empty a new temporary account is ... Constantin Asofiei
11:17 AM User Interface Feature #1811: implement the AJAX client driver: I fixed the enable/disable temporary account using the AssociatedThread class.
Bellow is a short description of temp... Marius Gligor
08:09 AM Base Language Feature #1641: implement SAX XML support: Evgeny Kiselev wrote:
> I've try to find something with files (can't believe that they copy all file in memory). May... Constantin Asofiei
03:25 AM Base Language Feature #1641: implement SAX XML support: Review for 1215a.zip:
@SaxReader/SaxWriter@
- add back the @public final static@ modifiers to the sax constants. I ... Constantin Asofiei
03:57 AM Base Language Feature #2208: create a java application running web services for testing purposes: Some more notes about what should be covered:
# for the various CONNECT statement options, I need more than one WSDL... Constantin Asofiei
03:28 AM Base Language Feature #1645: implement web services support: I don't want to rely on progress or any other freely available services for the testing. Look at the WSDL structure, ... Constantin Asofiei

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development

Activity

Activity

01/15/2014

01/14/2014

01/13/2014

01/12/2014

01/11/2014

01/10/2014

01/09/2014

01/08/2014

01/07/2014

01/06/2014

01/05/2014

01/04/2014

01/03/2014

01/02/2014

01/01/2014

12/31/2013

12/30/2013

12/29/2013

12/26/2013

12/25/2013

12/24/2013

12/23/2013

12/21/2013

12/20/2013

12/19/2013

12/18/2013

12/17/2013

12/16/2013