Activity

From 08/21/2014 to 09/19/2014

09/19/2014

04:18 PM User Interface Feature #2252: implement GUI client support: I made corrections. Have a look please. Vadim Gindin
08:08 AM User Interface Feature #2252: implement GUI client support: Code Review vig_upd20140919c.zip
This is moving in the right direction. Greg Shah
08:07 AM User Interface Feature #2252: implement GUI client support: > > Perhaps it should be kept in a context-local static var so it is shared between all @Window@ instances for this c... Greg Shah
05:32 AM User Interface Feature #2252: implement GUI client support: Next update with the latest corrections except StatusStack move from ThinClient. See below.
Greg Shah wrote (note ... Vadim Gindin
02:43 PM User Interface Feature #1791: implement dynamic UI support: > If 1-3 will work fine I think we do not need any special processing for dynamic widgets on the client side. What do... Greg Shah
01:37 PM User Interface Feature #1791: implement dynamic UI support: >One area I wonder about is whether the client-side WidgetRegistry needs to add/remove dynamic widgets differently.
... Eugenie Lyzenko
11:32 AM User Interface Feature #1791: implement dynamic UI support: OK, go ahead and commit/distribute evl_upd20140919a.zip.
> >No, there is no such thing as a NEW GLOBAL SHARED frame.... Greg Shah
11:16 AM User Interface Feature #1791: implement dynamic UI support: >Let me take one last look first.
OK.
>No, there is no such thing as a NEW GLOBAL SHARED frame. You can only cr... Eugenie Lyzenko
11:06 AM User Interface Feature #1791: implement dynamic UI support: Let me take one last look first. Greg Shah
11:05 AM User Interface Feature #1791: implement dynamic UI support: The CTRL-C testing finished without regressions. I had to run 3-way tests in standalone session and they are OK too.
... Eugenie Lyzenko
09:57 AM User Interface Feature #1791: implement dynamic UI support: The only change in this update is removed TODO from @GenericWidget.resourceDelete()@.
Is it OK to commit and distr... Eugenie Lyzenko
06:24 AM User Interface Feature #1791: implement dynamic UI support: >This memory leak already exists in P2J. So we can go forward with your change anyway. But I do want to fix this some... Eugenie Lyzenko
12:30 PM Base Language Bug #2338 (Closed): fix _MSG function: Greg Shah
10:35 AM Base Language Bug #2338: fix _MSG function: committed to revision 10614 Vadim Gindin
09:47 AM Base Language Bug #2338: fix _MSG function: Vadim Gindin wrote:
> The update vig_upd20140917a.zip has passed regression testing. Can I commit it?
Yes, go ahead... Constantin Asofiei
06:04 AM Base Language Bug #2338: fix _MSG function: The update vig_upd20140917a.zip has passed regression testing. Can I commit it? Vadim Gindin
11:56 AM User Interface Bug #2396: memory leak when using shared frames: In #1791 we found that using shared frames results in a memory leak because we never fully remove shared frames from ... Greg Shah
11:28 AM User Interface Bug #2396 (New): memory leak when using shared frames: Greg Shah
10:30 AM Database Bug #2395: db admin rights requirement for the system table query: In @PostgreSQLSequenceHandler.safeContains@ the query on a system table requires DB admin rights. For development and... Ovidiu Maxiniuc
10:01 AM Database Bug #2395 (New): db admin rights requirement for the system table query: Ovidiu Maxiniuc

09/18/2014

05:32 PM User Interface Feature #2252: implement GUI client support: Code Review vig_upd20140919b.zip
This mostly is moving in the right direction.
1. The @statusStack@, @StatusD... Greg Shah
05:17 PM User Interface Feature #2252: implement GUI client support: > 1. Why it is necessary to hold the stack of statuses even for one-window UI?
Because you can have nested WAIT-FO... Greg Shah
04:50 PM User Interface Feature #2252: implement GUI client support: Fixed 2 files (compile errors) Vadim Gindin
02:34 PM User Interface Feature #2252: implement GUI client support: I've made corrections with status stack, but I have some doubts.
1. Why it is necessary to hold the stack of statu... Vadim Gindin
12:16 PM User Interface Feature #2252: implement GUI client support: Details for #2388:
I have created a test suite that explores the behavior of window move/positioning. #2388 is int... Greg Shah
05:01 PM User Interface Feature #1791: implement dynamic UI support: > On the other hand I think the shared frame in 4GL approach has memory leak bomb initially. We never know at this ti... Greg Shah
01:53 PM User Interface Feature #1791: implement dynamic UI support: >1. The changes to LT bring back that memory leak of shared frames, right? I understand it may be needed to defer the... Eugenie Lyzenko
01:30 PM User Interface Feature #1791: implement dynamic UI support: >2. Can the TODO from @GenericWidget.resourceDelete()@ be removed now?
I think we can remove. This is not my TODO ... Eugenie Lyzenko
12:32 PM User Interface Feature #1791: implement dynamic UI support: Code Review 0918a
I only have the following concerns:
1. The changes to LT bring back that memory leak of share... Greg Shah
11:57 AM User Interface Feature #1791: implement dynamic UI support: >Your top priority is getting the new widget ID implementation through regression testing and checked in.
OK.
>Ho... Eugenie Lyzenko
10:43 AM User Interface Feature #1791: implement dynamic UI support: Your top priority is getting the new widget ID implementation through regression testing and checked in.
However, ... Greg Shah
10:41 AM User Interface Feature #1791: implement dynamic UI support: Yes, it must build upon (add to) that code. Greg Shah
10:39 AM User Interface Feature #1791: implement dynamic UI support: >Get this update prepared and uploaded for review ASAP. Please also test it with a variety of dynamic widget cases to... Eugenie Lyzenko
09:46 AM User Interface Feature #1791: implement dynamic UI support: I am fine with the proposed approach. Some thoughts:
1. The use of reflection (to lookup the constructor) needs s... Greg Shah
08:29 AM User Interface Feature #1791: implement dynamic UI support: Now at least two issues/regressions remain:
- one for NullPointerException.
- other with shared variable missing.
... Eugenie Lyzenko
12:49 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Evgeny Kiselev wrote:
> Constantin Asofiei wrote:
> > update 0917
> for TerminalStream class you've rollback next ... Constantin Asofiei
09:22 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Constantin Asofiei wrote:
> update 0917
for TerminalStream class you've rollback next lines:... Evgeny Kiselev
12:02 PM User Interface Feature #2388: finish GUI window move/position support: This is just for time tracking. Please put all history in the parent task #2252. Greg Shah
12:01 PM User Interface Feature #2388 (Closed): finish GUI window move/position support: Greg Shah

09/17/2014

07:33 PM User Interface Feature #1791: implement dynamic UI support: Code Review 0917a
I am fine with the changes.
Besides the testing, how soon can you make a list of the changes ... Greg Shah
02:58 PM User Interface Feature #1791: implement dynamic UI support: The regression testing has regression. The next update will be tested as fix. What is in the update:
1. Merge with... Eugenie Lyzenko
07:23 PM User Interface Feature #2252: implement GUI client support: > WAIT-FOR always has widget specification. This widget uniquely identify the window it belongs. Assuming we have 2 w... Greg Shah
06:40 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> I think the more important question is how does the @statusStack@ need to be implemented in a mul... Vadim Gindin
02:05 PM User Interface Feature #2252: implement GUI client support: > I am wondering how is the test runner interacting with the application and whether it may cause a different path of... Greg Shah
01:45 PM User Interface Feature #2252: implement GUI client support: Regarding #2323 please advice with runtime regression results. Several test cases fail with an alert box missing butt... Hynek Cihlar
10:45 AM Base Language Bug #2338: fix _MSG function: Yes, I checked all tests. Here is the final update. Vadim Gindin
09:46 AM Base Language Bug #2338: fix _MSG function: Vadim Gindin wrote:
> This is a final update. Can I run regression testing?
If your standalone tests all pass (incl... Constantin Asofiei
09:45 AM Base Language Bug #2338: fix _MSG function: This is a final update. Can I run regression testing? Vadim Gindin
04:10 AM Base Language Bug #2338: fix _MSG function: Vadim Gindin wrote:
> Added implementation for warnings to ErrorManager methods.
>
> Questions.
> 1. There are 2... Constantin Asofiei
10:35 AM User Interface Feature #2333: implement the GUI status line widget: I am keeping this open only because we still have the drawing differences between Windows and Linux. When the #2323 ... Greg Shah
10:17 AM User Interface Feature #2333 (Review): implement the GUI status line widget: Marius Gligor
10:16 AM User Interface Feature #2333: implement the GUI status line widget: 0916a passed regression tests. Committed revision 10613. Marius Gligor
08:54 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: > do you think that adding a row at the bottom of the frame (when output to stream) might be something specific to 4G... Greg Shah
08:17 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Evgeny, this version is merged with the latest P2J. What else needs to be done:
# test all PUT versions (PUT ... AT/... Constantin Asofiei
07:42 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Evgeny Kiselev wrote:
> > 3. The @RedirectedTerminal@ change seems dangerous and incorrect. @box[i]@ will only be t... Constantin Asofiei
07:29 AM User Interface Feature #2334: implement the GUI message line widget: In @OpenEdge@ GUI the message area is a reserved region at the bottom of window above status bar implemented as a scr... Marius Gligor
01:42 AM User Interface Feature #2334 (WIP): implement the GUI message line widget: Marius Gligor

09/16/2014

02:25 PM User Interface Feature #2252: implement GUI client support: > I asked more about popStatus and pushStatus, rather then nesting. Do you mean I should stay these methods in ThinCl... Greg Shah
01:59 PM User Interface Feature #2252: implement GUI client support: I asked more about popStatus and pushStatus, rather then nesting. Do you mean I should stay these methods in ThinClient? Vadim Gindin
01:38 PM User Interface Feature #2252: implement GUI client support: > Recalling, I'm going to move these methods (pop and push) to Window. What window to apply these methods for? May be... Greg Shah
01:15 PM User Interface Feature #2252: implement GUI client support: I have the following question about methods @pushStatus@ and @popStatus@ (ThinClient). They are called from applyChan... Vadim Gindin
10:55 AM User Interface Feature #2252: implement GUI client support: In regard to task #2334 (finish message area support), the following needs to be done:
* create a proper scrollabl... Greg Shah
11:15 AM User Interface Feature #2333: implement the GUI status line widget: OK, the failure is actually on the client side and it is just that our GUI support does not yet handle frames. So wh... Greg Shah
11:12 AM User Interface Feature #2333: implement the GUI status line widget: [09/16/2014 18:11:26 EEST] (StandardServer.invoke:SEVERE) {00000005:00000016:bogus} Abnormal end!
java.lang.reflect.... Marius Gligor
11:10 AM User Interface Feature #2333: implement the GUI status line widget: Please post the full stack trace. Greg Shah
11:09 AM User Interface Feature #2333: implement the GUI status line widget: I found the following error: @Attempt to instantiate classclass com.goldencode.p2j.ui.client.Frame which has no prope... Marius Gligor
11:05 AM User Interface Feature #2333: implement the GUI status line widget: What causes the server-side crash? Greg Shah
11:03 AM User Interface Feature #2333: implement the GUI status line widget: When GUI client starts after authentication the @Ask.p@ is tried to be executed on server side but crash in @Standard... Marius Gligor
10:50 AM User Interface Feature #2333: implement the GUI status line widget: Code Review 0916a
The changes look good. Please go ahead into runtime regression testing.
> In conclusions all... Greg Shah
10:20 AM User Interface Feature #2333: implement the GUI status line widget: 1. Insets could be used by other widgets as well like message area, window title bar.
Even window widgets could ... Marius Gligor

09/15/2014

05:57 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Constantin Asofiei wrote:
> Evgeny Kiselev wrote:
> > P2J output with my patch:
> If you are referring to 0910a.zi... Evgeny Kiselev
04:12 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Evgeny Kiselev wrote:
> P2J output with my patch:
If you are referring to 0910a.zip, try to break it like this:
<p... Constantin Asofiei
01:06 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Constantin Asofiei wrote:
> # about MESSAGE (and maybe other statements, like DISPLAY) when output is not the termin... Evgeny Kiselev
04:39 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Constantin Asofiei wrote:
> # about the box issue:
> - is this a regression from your update or a bug you found?
>... Evgeny Kiselev
04:20 PM User Interface Feature #2252: implement GUI client support: > I'm just recalling that the client-side implementation is not finished yet. Status line does not display a value.
... Greg Shah
03:35 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
>..
> Is there anything else that remains to be done to finish multi-window status support?
I'm... Vadim Gindin
11:38 AM User Interface Feature #2252: implement GUI client support: Code Review vig_upd20140912a.zip
In general, the changes are really good. I do want to make some slight changes t... Greg Shah
10:01 AM User Interface Feature #2252: implement GUI client support: > Considering that if i.e. char metrics are set, the pixel metrics automatically change, I'm inclined to let the clie... Greg Shah
03:17 PM User Interface Feature #2333: implement the GUI status line widget: Code Review 0915a
The changes look very good.
1. Are the @GuiOptions@ insets only useful for the status line? ... Greg Shah
11:47 AM User Interface Feature #2333: implement the GUI status line widget: Here are the changes which I did so far. Some of the changes like color inheritance could be applied to other widget... Marius Gligor
02:42 PM User Interface Feature #1791: implement dynamic UI support: OK, we will keep going with the current plan. Hopefully it will pass testing and get checked in tomorrow. Greg Shah
02:34 PM User Interface Feature #1791: implement dynamic UI support: Greg Shah wrote:
> This update just puts the new ID infrastructure into place. It doesn't solve any of the other dy... Constantin Asofiei
02:31 PM User Interface Feature #1791: implement dynamic UI support: > My goal is to separate the widget's config (and in the end the runtime state) from its concrete implementation, so... Greg Shah
01:49 PM User Interface Feature #1791: implement dynamic UI support: On a side note, do you now how much work is left on this task? I want to integrate this with my changes. Constantin Asofiei
01:33 PM User Interface Feature #1791: implement dynamic UI support: Greg Shah wrote:
> How many of these cases can act like "real" widgets? In other words, many of these are not treat... Constantin Asofiei
12:57 PM User Interface Feature #1791: implement dynamic UI support: How many of these cases can act like "real" widgets? In other words, many of these are not treated as widgets by the... Greg Shah
11:49 AM User Interface Feature #1791: implement dynamic UI support: Greg Shah wrote:
> > there are some widgets created on client-side which don't have a server-side counterpart
>
>... Constantin Asofiei
11:43 AM User Interface Feature #1791: implement dynamic UI support: > there are some widgets created on client-side which don't have a server-side counterpart
Please provide more det... Greg Shah
10:11 AM User Interface Feature #1791: implement dynamic UI support: Greg/Eugenie: there are some widgets created on client-side which don't have a server-side counterpart. Looking at t... Constantin Asofiei
08:19 AM Base Language Bug #2338: fix _MSG function: Added implementation for warnings to ErrorManager methods.
Questions.
1. There are 2 methods @ErrorManager.isSile... Vadim Gindin

09/13/2014

02:52 PM Database Bug #2222 (WIP): WRITE event triggered too early: Eric Faulhaber

09/12/2014

04:34 PM User Interface Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> >I'm sure about all of them except "statusStack". Could you pleas... Vadim Gindin
03:56 PM User Interface Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> // At the moment it is unknown to me whether the coordinate conversion and
> ... Constantin Asofiei
03:20 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> > Should the flag be then somehow cached? The most logical place should probably be the widget in... Hynek Cihlar
01:58 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> The only issue with this is that every call takes a trip down to the client to call @OutputManage... Constantin Asofiei
01:54 PM User Interface Feature #2252: implement GUI client support: > (1) In the change set in the file Coordinate.java - // TODO: #2323 implement GUI coordinate rounding.
> GUI roundi... Greg Shah
01:22 PM User Interface Feature #2252: implement GUI client support: Code Review 0911a
The changes look good. Greg Shah
12:45 PM User Interface Feature #2252: implement GUI client support: I am attaching update to the work in progress of #2323. The change set resolves comments from review, resolves resolv... Hynek Cihlar
04:36 AM User Interface Feature #2252: implement GUI client support: Vadim Gindin wrote:
>I'm sure about all of them except "statusStack". Could you please describe its function and may... Constantin Asofiei
04:08 PM Database Bug #2387: improve compatibility of NO-UNDO temp-tables: The validation of no-undo temp-tables in P2J does not quite match the behavior in Progress. See testcases @uast/flush... Eric Faulhaber
04:03 PM Database Bug #2387 (New): improve compatibility of NO-UNDO temp-tables: Eric Faulhaber
02:04 PM Database Bug #2222: WRITE event triggered too early: Attached update has passed regression testing and is checked into bzr revs. 10609 (all changed/new files) and 10610 (... Eric Faulhaber
12:54 PM Base Language Feature #2385 (Closed): implement environment access on GUI interfaces.: Greg Shah
10:54 AM Base Language Feature #2385: implement environment access on GUI interfaces.: 0911c passed regression tests. Committed revision 10608. Marius Gligor
12:26 PM Database Bug #2382: Improve format string error handling in ADD-NEW-FIELD implementation: Attached draft intermediate update vmn_upd20140912a.zip with some fixes based on previous local changes. Vadim Nebogatov

09/11/2014

07:02 PM User Interface Feature #2252: implement GUI client support: I'm working on status methods implementation. I'm going to move some fields from ThinClient to Window (or TitledWindo... Vadim Gindin
12:13 AM User Interface Feature #2252: implement GUI client support: Committed to revision 10606. Vadim Gindin
02:07 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Evgeny Kiselev wrote:
> testcases:
> uast/no_echo/put_unformatted_bug.p
> uast/no_echo/put_unformtted_bug1.p
# pl... Constantin Asofiei
12:16 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: committed testcases into testcases/uast/no_echo
revision 1199.
testcases:
uast/no_echo/put_unformatted_bug.p
ua... Evgeny Kiselev
07:23 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Evgeny Kiselev wrote:
> > What standalone testcases have you run to confirm your changes are correct?
I think Greg... Constantin Asofiei
01:58 PM Base Language Feature #2385: implement environment access on GUI interfaces.: Code Review 0911c
The changes look good. Please get these runtime regression tested. Greg Shah
01:39 PM Base Language Feature #2385: implement environment access on GUI interfaces.: OK. I understood thanks. Marius Gligor
01:37 PM Base Language Feature #2385: implement environment access on GUI interfaces.: In other words, when you call @DirectoryManager.getInstance()@ on the client, you will get a remote proxy to a server... Greg Shah
01:36 PM Base Language Feature #2385: implement environment access on GUI interfaces.: The @DirectoryServer@ class (which backs the @DirectoryManager.getInstance()@ on the server side) uses @Utils.getDire... Greg Shah
01:34 PM Base Language Feature #2385: implement environment access on GUI interfaces.: Marius Gligor wrote:
> Yes you are right it works in @/server/default/runtime/default/@
> But on note 12 you said:... Constantin Asofiei
01:33 PM Base Language Feature #2385: implement environment access on GUI interfaces.: done. Marius Gligor
01:30 PM Base Language Feature #2385: implement environment access on GUI interfaces.: Yes you are right it works in @/server/default/runtime/default/@
But on note 12 you said: @The lookup should allow ... Marius Gligor
01:24 PM Base Language Feature #2385: implement environment access on GUI interfaces.: I think you need to have it located in @/server/default/runtime/default/@ instead of @/server/default/@. Greg Shah
01:21 PM Base Language Feature #2385: implement environment access on GUI interfaces.: It works only for DirScope.ACCOUNTS Marius Gligor
01:17 PM Base Language Feature #2385: implement environment access on GUI interfaces.: I tried to use @DirectoryManager.getInstance()@ but it doesn't work.
I'm using the following code:... Marius Gligor
12:41 PM Base Language Feature #2385: implement environment access on GUI interfaces.: Code Review 0911b
Instead of adding a @ServerExports@ method to access the read-only flag, please use the @Directo... Greg Shah
11:35 AM Base Language Feature #2385: implement environment access on GUI interfaces.: Fixed 0911a code review. The read only flag is global and read from server node @readOnlyEnvironments@ which should h... Marius Gligor
10:49 AM Base Language Feature #2385: implement environment access on GUI interfaces.: Code Review 0911a
The changes are very good.
> a) The read only flag which change the loading rule from client ... Greg Shah
09:51 AM Base Language Feature #2385 (Review): implement environment access on GUI interfaces.: Marius Gligor
09:26 AM Base Language Feature #2385: implement environment access on GUI interfaces.: 1. I fixed code review issues from 0910a.
2. I integrated the changes from task #2366 related to override default ... Marius Gligor
09:26 AM User Interface Feature #2333 (WIP): implement the GUI status line widget: Marius Gligor

09/10/2014

07:08 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Greg Shah wrote:
> What is the status of your regression testing?
I've just started regression testing with latest ... Evgeny Kiselev
07:04 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Greg Shah wrote:
> Code Review 0910a
>
> I am worried that your changes are just there to fix some very specific ... Evgeny Kiselev
03:06 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: What is the status of your regression testing?
What standalone testcases have you run to confirm your changes are ... Greg Shah
03:01 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Code Review 0910a
I am worried that your changes are just there to fix some very specific behavior in a few testca... Greg Shah
07:44 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: I've added addition comments in code. There is next algorithm.
1) first output is @put unformatted@ (in my case this... Evgeny Kiselev
05:31 PM User Interface Feature #2252: implement GUI client support: Code Review 0905a
I am fine with the changes.
> But there was an exception. See error log (client_vig_26776.log... Greg Shah
05:01 PM User Interface Feature #2252: implement GUI client support: I was running regression testing several times. Made some fix. Here is the latest update. It passes regression testin... Vadim Gindin
12:26 PM User Interface Feature #2252: implement GUI client support: In regard to task #2333 (finish status area support), the following needs to be done:
* proper font/color usage
*... Greg Shah
05:20 PM Base Language Feature #2385: implement environment access on GUI interfaces.: Code Review 0910a
1. Doesn't @StanzaIni@ always get used on the client side? If so, then the jar file reading is ... Greg Shah
11:09 AM Base Language Feature #2385: implement environment access on GUI interfaces.: Here are my changes that I did so far on this task. Please do a code review on these changes and let me know the resu... Marius Gligor

09/09/2014

04:23 PM Base Language Bug #2338: fix _MSG function: Vadim Gindin wrote:
> I ran your test and in both cases (with or without NO-ERROR) it behaved in the same way. _MSG(... Constantin Asofiei
04:07 PM Base Language Bug #2338: fix _MSG function: I ran your test and in both cases (with or without NO-ERROR) it behaved in the same way. _MSG(1) = 74. The error bein... Vadim Gindin
01:21 PM Base Language Bug #2338: fix _MSG function: > > 1. With NO-ERROR the error number wasn't recorded to _MSG array. That is little unexpected.
> Please correct me,... Vadim Gindin
01:02 PM Base Language Bug #2338: fix _MSG function: Vadim Gindin wrote:
> I'm not sure, that I understood correctly. I expected that 0 is the default value that exists ... Constantin Asofiei
12:49 PM Base Language Bug #2338: fix _MSG function: Constantin Asofiei wrote:
> I think it shows that:
> # if a @NO-ERROR@ is added to @DELETE book@, then the ERROR-ST... Vadim Gindin
06:57 AM Base Language Bug #2338: fix _MSG function: Vadim Gindin wrote:
> 2a. format constraint 1-digit number.
> While trying to validate number 10 there are an er... Constantin Asofiei
01:29 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior: The update passed the regression test and was committed to bzr (rev 10599) and distributed by mail on 14 aug 2014. Ovidiu Maxiniuc

09/08/2014

05:07 PM Database Bug #2222: WRITE event triggered too early: Eric,
I reviewed closely your last update. Changes make sense. I did not find any issues except for a few javadoc ... Ovidiu Maxiniuc
02:09 PM Base Language Bug #2338: fix _MSG function: > 1a. size(memptr) < size(file). For exapmle size(memptr) = 5 and size(file) = 23.
> Progress reads all file and dyn... Greg Shah
02:07 PM Base Language Bug #2386: STRING(memptr_var) will render the contents of the memptr as a null terminated string: See uast/memptr/memptr_to_string.p.
In the 4GL, the contents seem to be read from index 1 (1-based indexing) and i... Greg Shah
02:03 PM Base Language Bug #2386 (New): STRING(memptr_var) will render the contents of the memptr as a null terminated s...: Greg Shah
12:55 PM User Interface Feature #2252: implement GUI client support: > 1. In many places in this update, you are moving back to @int@ from @double@. A good example is @src/com/goldencod... Hynek Cihlar
10:34 AM User Interface Feature #2252: implement GUI client support: Code Review hc_upd20140907a.zip
I like the new @Coordinate@ helper class. Use of it makes clear to the reader tha... Greg Shah

09/07/2014

04:31 PM User Interface Feature #2252: implement GUI client support: Attached is the update of hc_upd20140831a. It resolves the issues from review at notes 184 and 188.
The most impo... Hynek Cihlar
02:50 PM Base Language Bug #2338: fix _MSG function: I forgot to add for the case №1 "Stream", that STRING(memptr) in Progress successfully outputs string representation ... Vadim Gindin
02:45 PM Base Language Bug #2338: fix _MSG function: I tried to test these mysterious cases. It is not easy. Here are some findings.
1. @Stream.readBlock()@ method, th... Vadim Gindin

09/06/2014

09:59 PM Database Bug #2222: WRITE event triggered too early: Ovidiu Maxiniuc wrote:
> I have not finished yet reviewing your update 20140903a, only a side-by-side compare with c... Eric Faulhaber

09/05/2014

06:19 PM Database Bug #2222: WRITE event triggered too early: I have not finished yet reviewing your update 20140903a, only a side-by-side compare with current bzr. At first impre... Ovidiu Maxiniuc
12:06 AM Database Bug #2222: WRITE event triggered too early: Ovidiu, would you please review the attached update? It goes way beyond the write trigger fix to deal with the incorr... Eric Faulhaber
02:06 PM Base Language Feature #27: implement a compatible ENCODE built-in function: Here is the Progress 4GL compatible @ENCODE@ algorithm specification.
+Summary+
The function takes a source byt... Greg Shah
11:05 AM Base Language Feature #2385: implement environment access on GUI interfaces.: I agree with your thoughts. If this read-only approach is still going to take a significant amount of time/changes, ... Greg Shah
10:56 AM Base Language Feature #2385: implement environment access on GUI interfaces.: Indeed the big problem with @INI@ files on @P2J@ is the deployment location. Reading or writing @INI@ files on server... Marius Gligor
10:06 AM Base Language Feature #2385: implement environment access on GUI interfaces.: Interesting findings.
> Since we are looking to use INI files in both Linux OS and Windows OS the name of the INI ... Greg Shah
09:36 AM Base Language Feature #2385: implement environment access on GUI interfaces.: I did some tests using @LOAD@ @USE@ and @UNLOAD@ statements to manage user environment on both @OE@ and @P2J@.
Curre... Marius Gligor
08:56 AM User Interface Feature #1791: implement dynamic UI support: > Sorry, that I'm meddling.
You are not meddling. You are CONTRIBUTING. Your questions help us make this project... Greg Shah
08:24 AM User Interface Feature #1791: implement dynamic UI support: Code Review 0904a
I'm fine with the changes. Greg Shah
04:48 AM User Interface Feature #1791: implement dynamic UI support: Sorry, that I'm meddling. Why your updates does not change @handle.getResourceId@ static method (and corresponding @R... Vadim Gindin

09/04/2014

07:49 PM User Interface Feature #1791: implement dynamic UI support: The today update for review includes:
1. Merge with the recent code base.
2. Fix for shared frame importing @Screen... Eugenie Lyzenko
10:31 AM User Interface Feature #2286 (Closed): design and implement basic GUI window widget support: Greg Shah
10:16 AM User Interface Feature #1793 (Closed): improve color support: Greg Shah
10:08 AM User Interface Feature #1793: improve color support: 0904c Passed conversion and regression tests. Committed revision 10605. Marius Gligor
09:46 AM User Interface Feature #1793: improve color support: Code Review 0904c
It is good. Go ahead and check it in/distribute it. Greg Shah
09:31 AM User Interface Feature #1793: improve color support: Done. Marius Gligor
09:03 AM User Interface Feature #1793: improve color support: Code Review 0904b
I am OK with the changes and I do think they are safe enough to avoid further testing.
I have... Greg Shah
08:03 AM User Interface Feature #1793: improve color support: A minor change to log a message whenever colors cannot be mapped and are mapped by default to a 0 RGB value. Marius Gligor
07:44 AM User Interface Feature #1793: improve color support: The changes in 0903b passed both conversion and regression tests. However I didn't do the commits and distributions y... Marius Gligor
04:02 AM Base Language Feature #2385: implement environment access on GUI interfaces.: Ovidiu,
So far I did no changes on current implementation for Windows environment access.
I only added getLegac... Marius Gligor
03:05 AM Base Language Feature #2385 (WIP): implement environment access on GUI interfaces.: Current implementation for @COLOR-TABLE@ and @FONT-TABLE@ statements load the default environment from server directo... Marius Gligor
02:47 AM Base Language Feature #2385: implement environment access on GUI interfaces.: GUI clients are using environment statements LOAD USE and UNLOAD to load colors, fonts and potentially other resource... Marius Gligor
02:06 AM Base Language Feature #2385 (Closed): implement environment access on GUI interfaces.: Marius Gligor

09/03/2014

07:26 PM User Interface Feature #1791: implement dynamic UI support: >My only question is whether the @ScreenBuffer(int frameId, int numWidgets)@ constructor is ever safe to use in the n... Eugenie Lyzenko
07:22 PM User Interface Feature #1791: implement dynamic UI support: Status update.
The next regression I've faced is in PO adding screen. This is the serious issue with shared frames... Eugenie Lyzenko
09:05 AM User Interface Feature #1791: implement dynamic UI support: Code Review 0901b
The changes look good and they do look more correct.
My only question is whether the @ScreenB... Greg Shah
04:54 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review vig_upd20140901a.zip
>
> I am generally fine with this as an interim update.
>
... Vadim Gindin
09:15 AM User Interface Feature #2252: implement GUI client support: > 1. Place a standardized marker in a comment, which can be searched on to find all these places again. Something li... Hynek Cihlar
08:58 AM User Interface Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Greg Shah wrote:
> > Code Review hc_upd20140831a
> >
> > Wow, that is a lot of work! It to... Greg Shah
08:53 AM User Interface Feature #2252: implement GUI client support: > It shows window button on the task bar but does not show the window itself. Testcase window_parenting/pause.p. Bod... Greg Shah
08:48 AM User Interface Feature #2252: implement GUI client support: Code Review vig_upd20140901a.zip
I am generally fine with this as an interim update.
1. Can we make the window ... Greg Shah
03:37 PM Base Language Bug #2367 (Closed): re-connecting an appserver agent after a hard client termination: Greg Shah
06:47 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination: Greg Shah wrote:
> Code Review 0902a
>
> The changes look good.
Committed to rev 10604. Constantin Asofiei
01:14 PM Base Language Feature #27: implement a compatible ENCODE built-in function: New/updated articles have been found:
http://programmers.stackexchange.com/questions/206645/how-can-i-reverse-engi... Greg Shah
12:59 PM Base Language Feature #27: implement a compatible ENCODE built-in function: The following link (see attached for the actual text file that is linked) is a really useful primer on the theory beh... Greg Shah
12:12 PM User Interface Feature #1793: improve color support: > I have no other works to do on this task.
OK, please get this regression tested (both conversion and runtime).
... Greg Shah
11:58 AM User Interface Feature #1793: improve color support: I have no other works to do on this task.
Nevertheless they are other issues to implements like LOAD, USE, UNLOAD, ... Marius Gligor
11:49 AM User Interface Feature #1793: improve color support: Code Review 0903b
The changes look good. I like the more general approach to reading color tables from the server... Greg Shah
11:00 AM User Interface Feature #1793: improve color support: I fixed the issues reported on Code Review 0903a (note 39) Marius Gligor
10:04 AM User Interface Feature #1793: improve color support: Code Review 0903a
The changes look good.
1. WindowConfig is missing a history entry.
2. The call from the cl... Greg Shah
06:01 AM User Interface Feature #1793: improve color support: I did some changes inside @ColorTable@ class to load colors on a per user manner.
I've fixed also some javadoc texts. Marius Gligor
12:07 PM User Interface Feature #2384: implement custom color overrides for ChUI: This task is meant to allow the configuration of custom colors for ChUI as is possible in the 4GL using the protermca... Greg Shah
12:05 PM User Interface Feature #2384 (New): implement custom color overrides for ChUI: Greg Shah

09/02/2014

11:40 AM User Interface Feature #1793 (Review): improve color support: Here are my latest changes on color improvements:
- synchronization state between server and client.
- default syst... Marius Gligor
10:19 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination: Code Review 0902a
The changes look good. Greg Shah
09:59 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination: Constantin Asofiei wrote:
> Ovidiu, attached update should fix the remaining problem. The solution was to make the ... Ovidiu Maxiniuc
06:20 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination: Ovidiu, attached update should fix the remaining problem. The solution was to make the (queue state check, add sessi... Constantin Asofiei
04:53 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination: Ovidiu, you are correct, if the client is killed just before the session listener is registered, we still have proble... Constantin Asofiei
09:59 AM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review hc_upd20140831a
>
> Wow, that is a lot of work! It took me many hours to review th... Hynek Cihlar
09:49 PM User Interface Feature #2252: implement GUI client support: Code Review hc_upd20140831a
Wow, that is a lot of work! It took me many hours to review that update. Generally, I... Greg Shah

09/01/2014

05:04 PM User Interface Feature #1791: implement dynamic UI support: Another update today for review. I've faced another issues with lost @UNINITIALIZED@ state. In this update all constr... Eugenie Lyzenko
02:21 PM User Interface Feature #1791: implement dynamic UI support: Code Review 0829a/b and 0901a
I am fine with the changes. Greg Shah
04:03 AM User Interface Feature #1791: implement dynamic UI support: The next update for your review.
Looks like I've found the issue resolution. We need to initialize the state map f... Eugenie Lyzenko
04:26 PM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination: Constantin,
I tested on Linux/PostgreSQL with bzr rev 10603 and your update 0806b, @initial_agents@, @min_agents@ a... Ovidiu Maxiniuc
10:40 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination: Constantin Asofiei wrote:
>
> Eric: as Ovidiu is away, please do a quick test on the server project, by killing th... Ovidiu Maxiniuc
02:10 PM User Interface Feature #2252: implement GUI client support: I'm trying to test the following update with the last remarks and got strange behavior. It shows window button on the... Vadim Gindin

08/31/2014

06:06 PM User Interface Feature #2252: implement GUI client support: Attached are changes related to #2323 - refactor coordinate system and implement GUI coordinate support.
What's in... Hynek Cihlar
02:29 PM User Interface Feature #2252: implement GUI client support: I retested implicit pause cases and PAUSE BEFORE HIDE statement to research behavior of THIS-PROCEDURE:CURRENT-WINDOW... Vadim Gindin
11:16 PM Database Support #2383: write an SQL script to verify all UDFs for built-in functions work once p2jpl.jar ...: The @p2jpl.jar@ contains a subset of the full P2J runtime classes. We recently found (in #2362) that one of the Progr... Eric Faulhaber
11:08 PM Database Support #2383 (New): write an SQL script to verify all UDFs for built-in functions work once p2jp...: Eric Faulhaber

08/29/2014

06:19 PM Database Bug #2382: Improve format string error handling in ADD-NEW-FIELD implementation: Some additional problems with @date@ type:
1) IllegalStateException at @DynamicTablesHelper:797@ (missed date and ... Vadim Nebogatov
06:09 PM User Interface Feature #1791: implement dynamic UI support: Unfortunately at least one regression I have already found. Consider pressing 'V' from main menu.
The current screen... Eugenie Lyzenko
05:54 PM User Interface Feature #1791: implement dynamic UI support: These two updates for review contain fixed login related classes, including one from timco majic related sources. I m... Eugenie Lyzenko
09:17 AM User Interface Feature #1791: implement dynamic UI support: Code Review 0828a
I am fine with the changes. Greg Shah
09:09 AM User Interface Feature #1791: implement dynamic UI support: > all we need is to properly clean up after finish, correct?
You may also need these widgets to be in the @WidgetR... Greg Shah
08:05 PM User Interface Feature #1791: implement dynamic UI support: Update for review includes:
1. Renaming @ScreenBuffer@ helper method to bitwise AND the state.
2. Adding helper met... Eugenie Lyzenko
12:27 PM User Interface Feature #1793: improve color support: > I think that we have do some changes here in order to accommodate our needs for GUI drivers perhaps on another Redm... Greg Shah
12:18 PM User Interface Feature #1793: improve color support: 1. The P2J implementation for LOAD, USE and UNLOAD statements is conforming with OpenEdge manual.
It works only if ... Marius Gligor
09:01 AM User Interface Feature #2252: implement GUI client support: Code Review 0827a
1. In @GuiOutputManager@ you ask @// TODO added to try. Fix this later. Was WindowConfig.SESSION... Greg Shah

08/28/2014

05:44 PM Database Bug #2382: Improve format string error handling in ADD-NEW-FIELD implementation: Attached tests for different data types reproducing some errors.
@decimal, integer@
errors with different comb... Vadim Nebogatov
12:14 PM Database Bug #2382 (New): Improve format string error handling in ADD-NEW-FIELD implementation: Vadim Nebogatov
05:18 PM User Interface Feature #1791: implement dynamic UI support: > Please check all Authenticator implementations for how the widget IDs are computed.
Except GenericFrame(server s... Eugenie Lyzenko
02:29 PM User Interface Feature #1791: implement dynamic UI support: Eugenie Lyzenko wrote:
> 1. Consider the code @src/aero/timco/majic/security/LoginClient.java@.
Please check all A... Constantin Asofiei
11:48 AM User Interface Feature #1791: implement dynamic UI support: >3. Why do you have buffer.size() < size as a condition in ScreenBuffer.isValidId()?
Yes I had to put the describi... Eugenie Lyzenko
11:19 AM User Interface Feature #1791: implement dynamic UI support: > It has ID assignments completely different from new approach(and moreover it differs from old one too).
LoginCli... Greg Shah
11:03 AM User Interface Feature #1791: implement dynamic UI support: Code Review 0827a
1. In @ScreenBuffer@, you chose to start with an empty state map instead of one populated by UNI... Greg Shah
10:05 PM User Interface Feature #1791: implement dynamic UI support: Found a way to debug login screen locally by tunneling server port @3434@ and using @-i1@ instance to remote connecti... Eugenie Lyzenko
04:19 PM User Interface Feature #2252: implement GUI client support: 6) StatusLineGuiImpl.draw is not called at all and message string is not displayed in the status line of any open win... Vadim Gindin
04:17 PM User Interface Feature #2252: implement GUI client support: I faced with the following problems.
1) We probably do not need to use contsant session window ID everywhere or we... Vadim Gindin
03:48 PM User Interface Feature #1793: improve color support: > Because system colors are not part of 4GL environment I think that system color table should be stored on server di... Greg Shah
03:32 PM User Interface Feature #1793: improve color support: Code Review 0828a
The code is fine. I like the direction it is moving. Greg Shah
12:55 PM User Interface Feature #1793: improve color support: > we need to ensure that .ini files can be specified for normal users, batch processes and appserver agents
Yes.
... Greg Shah
09:08 AM User Interface Feature #1793: improve color support: Here are my latest changes for COLOR-TABLE implementation.

1. The management of COLOR-TABLE is done now on server... Marius Gligor
04:30 AM User Interface Feature #1793: improve color support: Greg Shah wrote:
> As you note, there is no reason we can't use stanza-based INI files on non-Windows platforms. In... Constantin Asofiei

08/27/2014

06:51 PM User Interface Feature #1791: implement dynamic UI support: Some considerations and questions to discuss for inline widget ID calculation in current code. I have found new place... Eugenie Lyzenko
05:40 PM User Interface Feature #1791: implement dynamic UI support: This update for review includes:
1. Several fixes for @ThinClient.(get|set)ScreenBuffer()@ and @GenericFrame.getScre... Eugenie Lyzenko
09:56 AM User Interface Feature #1793: improve color support: Constantin Asofiei wrote:
> Marius Gligor wrote:
> > I found a conversion problem and cannot fix it. Both @COLOR-TA... Marius Gligor
07:06 AM User Interface Feature #1793: improve color support: Marius Gligor wrote:
> I found a conversion problem and cannot fix it. Both @COLOR-TABLE@ and @FONT-TBALE@ have a @N... Constantin Asofiei
06:34 AM User Interface Feature #1793: improve color support: I found a conversion problem and cannot fix it. Both @COLOR-TABLE@ and @FONT-TBALE@ have a @NUM-ENTRIES@ attribute.
... Marius Gligor

08/26/2014

05:52 PM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination: Code Review 0806b
Wow! That is tricky code with lots of subtlety. You documented it well and the approach makes ... Greg Shah
04:47 PM Base Language Bug #2367 (WIP): re-connecting an appserver agent after a hard client termination: This one was tricky to duplicate and even trickier to solve. The cause is this: if the appserver client terminates t... Constantin Asofiei
02:52 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: > In out code, we add extra new line only for MODE_EXPORT, but in this situation we need to add extra line only when ... Greg Shah
02:04 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: I know, that 4gl documentation is not always correct, but there is next paragraph in @put@ statement:
>UNFORMATTED
... Evgeny Kiselev
01:32 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Greg Shah wrote:
> I still don't know the answer to this question from note 87.
>
> And I would like to know your... Evgeny Kiselev
10:34 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Code Review 0820a
I am fine with the changes.
> However, I think the problems 10/11 in #1629 note 17 will NOT b... Greg Shah
09:45 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Evgeny Kiselev wrote:
> Before merge this update have been passed regression testing, but now it not compile because... Constantin Asofiei
08:35 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: fix problem described in note 86
fix issues from note 87
merged with latest revision
Before merge this update ha... Evgeny Kiselev
05:46 AM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> > About ca_upd20140808c.zip: as code touched by this update seems to be affected by other tasks, ... Constantin Asofiei
02:31 AM User Interface Feature #2381: implement PUT-KEY-VALUE COLOR (n | ALL): Marius Gligor wrote:
> PUT-KEY-VALUE COLOR (n | ALL) is used to save COLOR-TABLE of current environment on a persist... Marius Gligor
02:28 AM User Interface Feature #2381 (New): implement PUT-KEY-VALUE COLOR (n | ALL): Marius Gligor

08/25/2014

03:29 PM User Interface Feature #1793: improve color support: > 5. In P2J the COLOR-TABLE management is done on each environment on the client side. That's why all server API for ... Greg Shah
03:16 PM User Interface Feature #1793: improve color support: Code Review 0825a
I'm fine with the changes. Greg Shah
03:05 PM User Interface Feature #1793: improve color support: Code Review 0822b
1. Minor javadoc changes to @getLegacyPlatform()@:
@specify a legacy platform regarding the r... Greg Shah
02:47 PM User Interface Feature #1793: improve color support: If we decide to load and store custom environments also on server side like default environment we could move the cod... Marius Gligor
02:18 PM User Interface Feature #1793: improve color support: > In conclusion I think that we have to follow the same behaviour and implements a mechanism to save COLOR-TABLE some... Greg Shah
10:47 AM User Interface Feature #1793: improve color support: Here are my changes after your code review for 0814a on note 9.
Also I did new tests this time using @LOAD@ @USE@ an... Marius Gligor
10:58 AM User Interface Feature #1791: implement dynamic UI support: > The suggested fix is:
I don't see any reason to enter the @synchronized@ block. Entering it obtains the lock fo... Greg Shah
10:48 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: OK, that makes more sense now. What do you suggest? Greg Shah
10:00 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Here is my stacktrace:... Evgeny Kiselev
09:24 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: > problem with @put unformatted "~n ".@:
> ...
> and in method com.goldencode.p2j.util.Stream#generateFormattedText... Greg Shah
10:25 AM User Interface Feature #2252: implement GUI client support: > any widget resource requiring access to these attributes (from either server or client side) will interrogate the c... Greg Shah
10:09 AM User Interface Feature #2252: implement GUI client support: > About ca_upd20140808c.zip: as code touched by this update seems to be affected by other tasks, I think I should rel... Greg Shah

08/22/2014

04:14 PM User Interface Feature #1791: implement dynamic UI support: Two more issues has been found during testing:
1. NullPointer exception in code @LogicalTerminal.deregisterFrameCont... Eugenie Lyzenko
08:27 AM User Interface Feature #1791: implement dynamic UI support: Code Review 0821a
I'm fine with the changes. Let's get this through testing. You can fix the memory leak in the ... Greg Shah
06:42 AM User Interface Feature #1791: implement dynamic UI support: Greg Shah wrote:
> # @LT.releaseSharedFrame()@ is the only way that shared frames actually "go away" permanently. U... Constantin Asofiei
08:49 PM User Interface Feature #1791: implement dynamic UI support: Looks like I've found the root cause. It really the interference of new ID approach and old one. The method is @Widge... Eugenie Lyzenko
02:28 PM User Interface Feature #2252: implement GUI client support: About ca_upd20140808c.zip: as code touched by this update seems to be affected by other tasks, I think I should relea... Constantin Asofiei
02:26 PM User Interface Feature #2252: implement GUI client support: About note 157/158, the work for #2254 and sync'ing the server and client-side widget states. Unfortunately, there i... Constantin Asofiei
12:43 PM User Interface Feature #1793: improve color support: The attached archive @0822b@ contains implementation of @EnvironmentOps.getLegacyPlatform()@ Marius Gligor
11:03 AM User Interface Feature #1793: improve color support: Digging in the customer's @OE 10.2b@ environment I found the configuration file progress.ini which contains among oth... Marius Gligor
08:53 AM User Interface Feature #1793: improve color support: Code Review 0822a
The changes are fine.
> the code inside ColorSpec class is running only on the server side, ... Greg Shah
07:17 AM User Interface Feature #1793: improve color support: Here are my changes for COLOR phrase implementation as a result of your code review.
1. Regarding platform detecti... Marius Gligor
09:32 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: problem described in note 86 divide into 2 problems:
1) incorrect position for message method with redirected stream ... Evgeny Kiselev

08/21/2014

06:33 PM Database Feature #2220: dynamic query methods which require implementation: Rules from note 41 apply to multi-table queries as well. Stanislav Lomany
01:38 PM User Interface Feature #2252: implement GUI client support: Committed to bzr with rev 10600. Vadim Gindin
01:17 PM User Interface Feature #2252: implement GUI client support: > Previous update passed regression testing. Can I commit it?
Yes, please do. Greg Shah
01:16 PM User Interface Feature #2252: implement GUI client support: Previous update passed regression testing. Can I commit it? Vadim Gindin
08:42 AM User Interface Feature #2252: implement GUI client support: Code Review 0821a
I like the way this is going. Moving the @Window@ functionality from @static@ to non-@static@ i... Greg Shah
04:35 AM User Interface Feature #2252: implement GUI client support: > What happens if CURRENT-WINDOW is unrealized?
DEFAULT-WINDOW is used
I've added some client implementation for ... Vadim Gindin
11:42 AM User Interface Feature #1793: improve color support: Code Review 0821a
I like the result. Some minor feedback:
1. All data members should be at the top of the clas... Greg Shah
11:17 AM User Interface Feature #1793: improve color support: I've created #2379 to capture the work item for adding color support to the native Windows console (ChUI) client. We... Greg Shah
10:58 AM User Interface Feature #1793: improve color support: The attached archive contains my changes which I made to implements COLOR phrase for ChUI interfaces.
The @protermca... Marius Gligor
11:16 AM User Interface Feature #2379 (New): implement color support in the Windows native console (ChUI) client: Greg Shah
11:15 AM User Interface Feature #2378: implements dos-hex-attribute of COLOR phrase: See notes 11 and 12 in #1793 for details of previous research. Greg Shah

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development

Activity

Activity

09/19/2014

09/18/2014

09/17/2014

09/16/2014

09/15/2014

09/13/2014

09/12/2014

09/11/2014

09/10/2014

09/09/2014

09/08/2014

09/07/2014

09/06/2014

09/05/2014

09/04/2014

09/03/2014

09/02/2014

09/01/2014

08/31/2014

08/29/2014

08/28/2014

08/27/2014

08/26/2014

08/25/2014

08/22/2014

08/21/2014