Project

General

Profile

Activity

From 06/11/2020 to 07/10/2020

07/11/2020

09:51 PM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Ovidiu Maxiniuc wrote:
> The @Session@ works with its 'proprietary' @CacheKey@ key. I switched to it (making it pu...
Eric Faulhaber
08:48 PM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Eric Faulhaber wrote:
> Is there a practical problem caused by the temp-table IDs not being re-usable, or is the pro...
Ovidiu Maxiniuc

07/10/2020

06:15 PM Database Support #4702: write temp-table performance test cases
Stanislav Lomany wrote:
> For the case I'm attaching changes I made to 4011b in order to run H2 200 which are:
>
...
Eric Faulhaber
05:18 PM Database Support #4702: write temp-table performance test cases
For the case I'm attaching changes I made to 4011b in order to run H2 200 which are:
# @Constants.getFullVersion()@ ...
Stanislav Lomany
05:13 PM Database Bug #4752: Possible broken sort clause with word indexes
While working on other issues related to WORD indexes I realized something that seems like needing further investigat... Ovidiu Maxiniuc
05:05 PM Database Bug #4752 (New): Possible broken sort clause with word indexes
Ovidiu Maxiniuc
03:55 PM Database Feature #3814: more schema metadata
I'm trying to create an H2 database containing all metatables from a large customer database for a detailed analysis.... Igor Skornyakov
03:03 PM Database Support #4701: try to improve H2 transaction commit performance
Adrian Lungu wrote:
> # A lot of local temp-tables are used concurrently.
This is something in use by customer appl...
Constantin Asofiei
12:49 PM Database Support #4701: try to improve H2 transaction commit performance
Adrian, we will start using this version of H2 (i.e., 1.4.200, patched) as the default with 4011b. Please update the ... Eric Faulhaber
09:49 AM Database Support #4701: try to improve H2 transaction commit performance
The @org.h2.Session.cleanTempTables@ direction was a good starting point. H2 was sequentially checking all local temp... Adrian Lungu
02:56 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Are there really no other cases where the buffer scope can be smaller than the external proc...
Constantin Asofiei
02:16 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Here I considered that @activeScopeDepth@ is the scope depth where the buffer was open...
Eric Faulhaber
01:38 PM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
I left the topic of synchronization pretty open. Could you please tell me what your thoughts are there? Of course, th... Eric Faulhaber
12:43 PM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Ovidiu Maxiniuc wrote:
> More details from 4011c/11554:
> * I added a table/DMO unique ID. This (the Level1key) is ...
Eric Faulhaber

07/09/2020

06:45 PM Database Support #4702: write temp-table performance test cases
Testing results: each test is faster on H2 200 (fwd-h2-1.4.200-20200709) than on H2 197, in average 13% faster.
Test...
Stanislav Lomany
04:44 PM Database Support #4702: write temp-table performance test cases
I made some changes to FWD to make H2 200 run. Starting testing. Stanislav Lomany
02:03 PM Database Support #4702: write temp-table performance test cases
Stanislav, I will try to reproduce the exception and see if it related to @fwd-h2-1.4.200-20200709.jar@.
I remember...
Adrian Lungu
01:08 PM Database Support #4702: write temp-table performance test cases
Results so far:
# Looks like "UPDATE using a query" test goes to infinite cycle in 4011b (H2 197) if the number of r...
Stanislav Lomany
05:16 PM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> Constantin: I have the following questions about @RecordBuffer.worldScope@.
>
> * Is the idea ...
Constantin Asofiei
02:16 PM Database Feature #4011: database/persistence layer performance improvements
Eric, something else to consider. In @Persister.insert@, we use @1 + sum(distinct field's extent)@ INSERT statements... Constantin Asofiei
09:52 AM Database Feature #4011: database/persistence layer performance improvements
I've generated several reports and exports at the @Guests@ tab. The only meaningful hotspot is:... Igor Skornyakov
09:15 AM Database Feature #4011: database/persistence layer performance improvements
The profiling of the Hotel GUI app (switching tabs) did not reveal any hot spots. The only thing which is worth to me... Igor Skornyakov
01:46 AM Database Feature #4011: database/persistence layer performance improvements
After patching directory.xml what I have for freshly imported DB and server start up:... Eugenie Lyzenko
09:26 PM Database Feature #4011: database/persistence layer performance improvements
Constantin: I have the following questions about @RecordBuffer.worldScope@.
* Is the idea that @worldScope == true...
Greg Shah
03:16 PM Database Feature #4055: optimize temp-table output parameter copying
Constantin Asofiei wrote:
> A small note about the reclaimed keys - for the @INSERT INTO SELECT FROM@ approach to wo...
Eric Faulhaber
03:00 PM Database Feature #4055: optimize temp-table output parameter copying
A small note about the reclaimed keys - for the @INSERT INTO SELECT FROM@ approach to work, I need consecutive, incre... Constantin Asofiei
01:12 PM Database Feature #4055: optimize temp-table output parameter copying
Eric Faulhaber wrote:
> What is the exact problem in the @INSERT INTO ... SELECT FROM@ case? Maybe we can disable re...
Constantin Asofiei
12:36 PM Database Feature #4055: optimize temp-table output parameter copying
Constantin Asofiei wrote:
> Eric, a problem @INSERT INTO ... SELECT FROM@ is the primary key. How important is to u...
Eric Faulhaber
12:20 PM Database Feature #4055: optimize temp-table output parameter copying
For the PK generation, I'm using sequences (one per each temp-table) like this:
# before the @INSERT INTO ... SELECT...
Constantin Asofiei
03:06 AM Database Feature #4055: optimize temp-table output parameter copying
Eric, a problem @INSERT INTO ... SELECT FROM@ is the primary key. How important is to use the 'reclaimed keys' featu... Constantin Asofiei
02:44 PM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
More details from 4011c/11554:
* I added a table/DMO unique ID. This (the Level1key) is the only place used, yet. Th...
Ovidiu Maxiniuc

07/08/2020

04:29 PM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Please note I have made some updates to #4033-22 to clarify handling of the "no record found" case. Eric Faulhaber
04:05 PM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Ovidiu wrote (in email):
> I have created the general stubbing for the advanced cache but for the moment I do not ...
Eric Faulhaber
04:00 PM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
FOR FIRST/LAST already is implemented by @RandomAccessQuery@, so we should get that for free.
FIND CURRENT should ...
Eric Faulhaber
08:07 AM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Can we expand this usage beyond @FIND@?
It seems to me that the 4GL uses the same index-based technique for these ...
Greg Shah
07:28 AM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
I've tested this and modified your test case somewhat to stress the caching in different ways, and this definitely se... Eric Faulhaber
03:20 PM Database Feature #4055: optimize temp-table output parameter copying
Eric Faulhaber wrote:
> Constantin, I linked this with issue #3958 because it seems we should apply some of the same...
Constantin Asofiei
02:28 PM Database Feature #4055: optimize temp-table output parameter copying
Constantin, I linked this with issue #3958 because it seems we should apply some of the same ideas to both problems, ... Eric Faulhaber
03:09 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Agreed. Are you working on this, or do you want someone else to pick it up?
The fix was sim...
Constantin Asofiei
02:52 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Does this patch work?
> >
> > [...]
> Well, my patch just...
Eric Faulhaber
12:01 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Does this patch work?
>
> [...]
Well, my patch just returned the correct 'nextStart' by ...
Constantin Asofiei
08:26 AM Database Feature #4011: database/persistence layer performance improvements
There is a bug related to validation/flushing. I have a record like this:... Constantin Asofiei
02:39 PM Database Bug #4057: h2 performance degradation
Stas, when do you think you will have findings, based on the #4702 test cases? Based on the comparison of versions in... Eric Faulhaber
08:57 AM Database Feature #3814: more schema metadata
Can we ask our customers (or at least some of them) to provide an export (.d files) of the meta-tables from their 4GL... Igor Skornyakov
03:57 AM Base Language Bug #4749 (Test): Conversion error for object indeterminate extent output parameter
Marian Edu

07/07/2020

07:34 PM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Eric Faulhaber wrote:
> Ovidiu, please prototype a basic query results cache for use with FIND {FIRST|LAST|unique} q...
Ovidiu Maxiniuc
06:07 PM Database Feature #4011: database/persistence layer performance improvements
Does this patch work?... Eric Faulhaber
05:49 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> What is the layout of the result set you are working with?
There are 3 SELECT being execute...
Constantin Asofiei
05:43 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, my problem is that @props@ for the @MetaField@ DMO has its structure like this:
>...
Eric Faulhaber
05:35 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> A side note: for a @FindQuery.canFindImpl@ call, do we really need to load the full reco...
Eric Faulhaber
05:32 PM Database Feature #4011: database/persistence layer performance improvements
A side note: for a @FindQuery.canFindImpl@ call, do we really need to load the full record in the database? Because t... Constantin Asofiei
05:25 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> And if I switch it to @i = i + seriesSize@, then the @i@ will be wrong, but the return v...
Constantin Asofiei
05:21 PM Database Feature #4011: database/persistence layer performance improvements
Eric, my problem is that @props@ for the @MetaField@ DMO has its structure like this:
# 52 scalar props
# 48 entrie...
Constantin Asofiei
05:14 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Generally speaking, the data should always be laid out as described in the @Loader@ class ...
Eric Faulhaber
05:11 PM Database Feature #4011: database/persistence layer performance improvements
Before you make any changes at this low level, please explain the error you are seeing, which you are trying to solve. Eric Faulhaber
05:09 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric/Ovidiu, someone please document and explain how @Loader.readExtentData@ should work...
Eric Faulhaber
05:03 PM Database Feature #4011: database/persistence layer performance improvements
Looking at the code, the protection against 'bad data' is not OK. The code should attempt to read exactly 'extent' r... Constantin Asofiei
04:02 PM Database Feature #4011: database/persistence layer performance improvements
Eric/Ovidiu, someone please document and explain how @Loader.readExtentData@ should work. My change which increments... Constantin Asofiei
03:37 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> 4011b contains the fix for #4011-730 and other misc - please review.
The changes seem...
Eric Faulhaber
02:56 PM Database Feature #4011: database/persistence layer performance improvements
4011b contains the fix for #4011-730 and other misc - please review. Constantin Asofiei
10:44 AM Database Feature #4011: database/persistence layer performance improvements
There is an issue with the @ProxyAssembler.assembleClass@ code. Here, we want to override all passed methods, and als... Constantin Asofiei
03:31 PM Database Bug #4703 (Hold): investigate whether performance of TempTableDataSourceProvider can be improved
Eric Faulhaber
11:19 AM Database Support #4701: try to improve H2 transaction commit performance
I created a test with 1000 temp-tables and the suggested loop. The transaction is in fact committed after each iterat... Adrian Lungu
09:26 AM Base Language Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
> It can be a @.x@, @.k@, @.tt@
And 4GL doesn't care about the extension, @RUN@ will work - only @.r@ is assumed if...
Constantin Asofiei
09:25 AM Base Language Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Roger Borrello wrote:
> ... but if there is a ".w" and ".p", we may have to enforce a precedence determined by testc...
Constantin Asofiei
09:02 AM Base Language Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Constantin Asofiei wrote:
> Greg, you are correct. We need more testcases to find every case.
>
> For now, can i...
Roger Borrello
06:18 AM Base Language Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Greg, you are correct. We need more testcases to find every case.
For now, can it be enough to check if the last ...
Constantin Asofiei
05:57 AM Base Language Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Relative paths @./@ and @../../something/else/../blah/@ are possible. It is also legal to include @.@ in random part... Greg Shah
08:27 PM Base Language Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Checked in updates to @3821c-11389@ that don't have the @pname.indexOf('.') < 0)@ check. I am open to changing, just ... Roger Borrello
03:26 AM Database Feature #3814: more schema metadata
Igor Skornyakov wrote:
> Fixed the issue with the @null@ @ConnectionListener@ found in automated regression testing ...
Igor Skornyakov
12:27 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Greg Shah wrote:
> Code Review Task Branch 3821c Revision 11358
>
> This seems better. Confirm it with testing.
...
Roger Borrello

07/06/2020

05:17 PM Database Feature #3814: more schema metadata
Fixed the issue with the @null@ @ConnectionListener@ found in automated regression testing by Roger
Committed to 382...
Igor Skornyakov
02:42 PM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
I want to finish the refactoring of the index support from strings to bit sets before we invest time in any conversio... Eric Faulhaber
07:12 AM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
I understand. I just want us to keep in mind that it is easily possible to add a parameter to the query init that is... Greg Shah
06:20 AM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Greg Shah wrote:
> > Storing the index will require we look up the index for all such queries in RAQ.initialize, not...
Eric Faulhaber
06:06 AM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
> Storing the index will require we look up the index for all such queries in RAQ.initialize, not just when we have a... Greg Shah
05:16 AM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Ovidiu, please prototype a basic query results cache for use with FIND {FIRST|LAST|unique} queries. The keys are a un... Eric Faulhaber
02:11 PM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> As part of this work, I've written changes to @ScopedDictionary@ to eliminate the use of the @Lis...
Constantin Asofiei
12:55 PM Database Feature #4011: database/persistence layer performance improvements
I'm still analyzing the @RecordBuffer.pinnedLockTypes@ usage.
As part of this work, I've written changes to @Scope...
Greg Shah
04:32 AM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> *2.* Make @undone@ an instance member of @RecordBuffer@ instead of using the @extra@ object of ...
Eric Faulhaber
12:43 PM Database Support #4701: try to improve H2 transaction commit performance
Constantin Asofiei wrote:
> Adrian, in my profiling, I saw a significant time being spent in @orh.h2.Session.cleanTe...
Constantin Asofiei
12:03 PM Database Support #4701: try to improve H2 transaction commit performance
Adrian, in my profiling, I saw a significant time being spent in @orh.h2.Session.cleanTempTables@. Please create a t... Constantin Asofiei
11:49 AM Database Support #4701: try to improve H2 transaction commit performance
I investigated the H2 sources and eventually tried out some optimizations, but without any considerable performance b... Adrian Lungu
12:27 PM Database Bug #4742: heap usage increase on server startup
3821c rev 11387 contains the changes for this. @hbm_dmo_index.xml@ no longer exists in 4011b, and I'll postpone the ... Constantin Asofiei
10:52 AM Base Language Bug #4734: Invalid string to date conversion for non-"mm/dd/yyyy" format
> Which FWD branch/revision?
I've tested it against trunk rev 11347.
Stanislav Lomany
10:04 AM Base Language Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Is it possible to have @.@ in your path (or filename) that might fail that test? Roger Borrello
09:51 AM Base Language Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Change the test to this: @if (extProg == null && pname.indexOf('.') < 0)@. Constantin Asofiei
09:49 AM Base Language Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Constantin Asofiei wrote:
> Instead, you need to do this:
> # if the exact match of @pname@ is found, use that.
> ...
Roger Borrello
09:16 AM Base Language Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Roger Borrello wrote:
> In the debugger I noticed that the procedure name came into the @convertName@ method first, ...
Constantin Asofiei
09:06 AM Base Language Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
In the debugger I noticed that the procedure name came into the @convertName@ method first, without a path in front o... Roger Borrello
06:44 AM Database Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
Eric Faulhaber wrote:
> I don't think it is really worth it to contrive something in hand-written Java to recreate a...
Igor Skornyakov
06:16 AM Database Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
I don't think it is really worth it to contrive something in hand-written Java to recreate a problem that we haven't ... Eric Faulhaber
06:03 AM Database Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
Eric Faulhaber wrote:
> This is good news, but it suggests that the test did not recreate the condition I thought it...
Igor Skornyakov
05:51 AM Database Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
This is good news, but it suggests that the test did not recreate the condition I thought it would, either because I ... Eric Faulhaber

07/05/2020

07:34 PM Database Bug #4742: heap usage increase on server startup
Eric, after clearing the H2 meta from the heap, a real leak appeared, related to my TRPL changes for incremental conv... Constantin Asofiei
06:04 PM Database Bug #4742: heap usage increase on server startup
Constantin Asofiei wrote:
> Eric, what's the proper way to ensure the Hibernate session is really flushed of cache...
Eric Faulhaber
05:58 PM Database Bug #4742: heap usage increase on server startup
Igor Skornyakov wrote:
> The issue described at #4742-12 is a result of the fact that the login/password for the met...
Eric Faulhaber
03:52 PM Database Bug #4742: heap usage increase on server startup
Igor, thanks for the help. The server heap was reduced with ~300MB, which is the size of the _meta database on disk,... Constantin Asofiei
02:03 PM Database Bug #4742: heap usage increase on server startup
The issue described at #4742-12 is a result of the fact that the login/password for the metadatabase is generated at ... Igor Skornyakov
07:18 AM Database Bug #4742: heap usage increase on server startup
Constantin Asofiei wrote:
> Igor, what URL needs to change so that the H2 meta database is on disk, instead of memor...
Igor Skornyakov
06:03 AM Database Bug #4742: heap usage increase on server startup
Igor, what URL needs to change so that the H2 meta database is on disk, instead of memory?
Please create a patch f...
Constantin Asofiei
06:02 AM Database Bug #4742: heap usage increase on server startup
From Eric:
> If all this data is correct and needed (i.e., there is not a bug/leak), we should take the metadata dat...
Constantin Asofiei
05:46 AM Database Bug #4742: heap usage increase on server startup
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > ... and post here a list of all new fields added plus the...
Igor Skornyakov
04:59 AM Database Bug #4742: heap usage increase on server startup
Constantin Asofiei wrote:
> ... and post here a list of all new fields added plus their extent, in each table.
Look...
Constantin Asofiei
04:55 AM Database Bug #4742: heap usage increase on server startup
Igor, please do this: compare the standard.df we switched to in #3814 with the attached one (which is an old version,... Constantin Asofiei
04:42 AM Database Bug #4742: heap usage increase on server startup
Constantin Asofiei wrote:
> Igor, I have these stats:
> [...]
>
> Do you know if before you made your changes, t...
Igor Skornyakov
04:30 AM Database Bug #4742: heap usage increase on server startup
Igor, I have these stats:... Constantin Asofiei
03:48 AM Database Bug #4742: heap usage increase on server startup
In fact, albeit meta.xml is still parsed on startup, very few records are actually created from it (see the log). It ... Igor Skornyakov
07:29 PM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> *1.* Eliminate the call to @TriggerTracker.resetState()@ from @RecordBuffer.enterBlock()@.
> [...
Eric Faulhaber
04:59 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Greg Shah wrote:
> > Is the primary problem this loop in @beginTx()@ and similar in @en...
Greg Shah

07/04/2020

06:58 PM Database Bug #4742: heap usage increase on server startup
Constantin Asofiei wrote:
> So this allows multiple records for the same file (and if my interpretation of the code ...
Constantin Asofiei
06:28 PM Database Bug #4742: heap usage increase on server startup
In a large customer application, it was noticed a heap usage increase on a freshly started FWD server. The assumptio... Constantin Asofiei
06:07 PM Database Bug #4742 (New): heap usage increase on server startup
Constantin Asofiei
05:59 PM Database Support #4702: write temp-table performance test cases
There is an issue running the update tests with 4011b/11544. Looks like we are getting into an infinite loop based on... Eric Faulhaber
01:00 PM Base Language Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
I forgot to use this task for this...
I asked about the existing code making an assumption that it is rcode. Howev...
Roger Borrello

07/03/2020

06:36 PM Database Feature #4011: database/persistence layer performance improvements
I don't understand how @Loader.readExtentData@ worked before. Shouldn't it increase the @i@ var by the @seriesSize@... Constantin Asofiei
02:49 PM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> Is the primary problem this loop in @beginTx()@ and similar in @endTx()@:
Exactly. The global sc...
Constantin Asofiei
02:47 PM Database Feature #4011: database/persistence layer performance improvements
Is the primary problem this loop in @beginTx()@ and similar in @endTx()@:... Greg Shah
01:26 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> In email, Constantin wrote:
>
> > @BufferManager.beginTx@ and @endTx@ both stand out in t...
Constantin Asofiei
01:05 PM Database Feature #4011: database/persistence layer performance improvements
In email, Constantin wrote:
> @BufferManager.beginTx@ and @endTx@ both stand out in the visualvm sampler. This is...
Eric Faulhaber
04:34 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> I see, then we have a problem. The same API is used for INSERT/UPDATE statements. When a DT...
Constantin Asofiei
05:54 PM Base Language Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
He was talking about @SourceNameMapper.convertName@ at line 1395.
The usage needs to be added to @lookupDirectName...
Roger Borrello
05:52 PM Base Language Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Constantin asked:
Roger, rename @run-noext-victim.p@ to @run-noext-victim.k.p@ and do a @RUN run-noext-victim.k@. ...
Roger Borrello
05:49 PM Base Language Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
There is an issue about finding an external procedure that is not passed to @RUN@ with an extension. I added this tes... Roger Borrello
05:45 PM Base Language Bug #4741 (Closed): RUN statement with a path to a procedure that does not have any extension fai...
Roger Borrello
04:34 PM Database Support #4701: try to improve H2 transaction commit performance
I attached the patch based on @h2_synchronization_transactional_fix_20200703a.patch@, but compatible with the 1.4.200... Adrian Lungu
02:56 PM Database Support #4701: try to improve H2 transaction commit performance
Adrian, please post the clean patches for the 1.4.200 source code base. Unless Stanislav's findings are vastly differ... Eric Faulhaber
02:44 PM Database Support #4701: try to improve H2 transaction commit performance
Stanislav,
I attached the h2 versions I used in testing. I can't attach the already built ones as they are too bi...
Adrian Lungu
09:34 AM Database Support #4701: try to improve H2 transaction commit performance
Adrian, could you share 197 patched and 200 patched? Stanislav Lomany
07:33 AM Database Support #4701 (WIP): try to improve H2 transaction commit performance
Adrian Lungu
07:33 AM Database Support #4701: try to improve H2 transaction commit performance
I have computed the testing results for 1.4.200 and 1.4.200 patched. The spreadsheet is attached and a representative... Adrian Lungu
04:16 PM Database Support #4702: write temp-table performance test cases
FYI, I added some missing EOL markers to @perf-run-all-silent.p@ and committed the fix. Eric Faulhaber
02:00 PM Database Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
I've tested calling one of Stanislav's tests (with minor changes to suppress output) as an external program in loop:
...
Igor Skornyakov
12:56 PM Base Language Bug #4734: Invalid string to date conversion for non-"mm/dd/yyyy" format
Which FWD branch/revision? Eric Faulhaber
12:20 PM Base Language Bug #4734: Invalid string to date conversion for non-"mm/dd/yyyy" format
Testcase:... Stanislav Lomany
12:12 PM Base Language Bug #4734 (Closed): Invalid string to date conversion for non-"mm/dd/yyyy" format
Stanislav Lomany
02:49 AM User Interface Feature #4730 (New): Implement support for custom fonts on individual nodes of a TREEVIEW (and TR...
Hynek Cihlar

07/02/2020

07:36 PM Database Support #4702 (Review): write temp-table performance test cases
I've committed all of the tests, including FOR EACH, FIND and BUFFER-COPY tests. Stanislav Lomany
05:59 PM Database Support #4702: write temp-table performance test cases
Eric Faulhaber wrote:
> Eric Faulhaber wrote:
>
> > I would like at least one test which "thrashes" JDBC connecti...
Igor Skornyakov
06:28 AM Database Support #4702: write temp-table performance test cases
Eric Faulhaber wrote:
> I would like at least one test which "thrashes" JDBC connections. That is, the test should...
Eric Faulhaber
06:12 AM Database Support #4702: write temp-table performance test cases
Stanislav Lomany wrote:
> Igor, I'm not managing connection. I suppose that is a part of your task.
> BTW, I just c...
Igor Skornyakov
05:53 AM Database Support #4702: write temp-table performance test cases
> Which of your tests is supposed to open/close multiple JDBC Connections?
Igor, I'm not managing connection. I su...
Stanislav Lomany
04:21 AM Database Support #4702: write temp-table performance test cases
Stanislav.
Which of your tests is supposed to open/close multiple JDBC Connections?
Thank you.
Igor Skornyakov
04:58 PM Database Support #4701: try to improve H2 transaction commit performance
Just found this in the H2 v1.4.200 change log, as something that was fixed:
* Issue # 1820: Performance problem on...
Eric Faulhaber
04:05 PM Database Support #4701: try to improve H2 transaction commit performance
I shared the findings in #4057. I will go ahead with testing the 1.4.200 version. Need just some syntax changes to th... Adrian Lungu
03:29 PM Database Support #4701: try to improve H2 transaction commit performance
Adrian, this performance data presents an interesting counterpoint to the information posted previously to #4057. Ple... Eric Faulhaber
11:26 AM Database Support #4701: try to improve H2 transaction commit performance
I have done some testing using the Apache JMeter in order to see some differences between H2 versions: 1.4.196, 1.4.1... Adrian Lungu
04:14 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > * @TypeManager.setFwdDatetimetzParameter()@ you decided not ...
Ovidiu Maxiniuc
04:05 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Review for 4011b rev 11537:
> * in which cases in @FqlToSqlConverter.getSqlColumnAlias@, t...
Constantin Asofiei
04:00 PM Database Feature #4011: database/persistence layer performance improvements
Review for 4011b rev 11537:
* in which cases in @FqlToSqlConverter.getSqlColumnAlias@, the @sqlName@ is null col "co...
Ovidiu Maxiniuc
03:36 PM Database Feature #4011: database/persistence layer performance improvements
More blob, clob and datetimetz fixes are in 4011b rev 11537. Constantin Asofiei
03:34 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> They have an id reserved in @ReservedProperty@, indeed.
In the DMO interface, the annotat...
Constantin Asofiei
03:33 PM Database Feature #4011: database/persistence layer performance improvements
They have an id reserved in @ReservedProperty@, indeed.
However, if I remember correctly, they are true fields in d...
Ovidiu Maxiniuc
03:17 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, is it normal for a before-table to explicitly generate the @_error-flag@, @_row-state@ and other related prop... Constantin Asofiei
02:49 PM Database Feature #4011: database/persistence layer performance improvements
I'm getting an NPE when checking in a guest in Hotel GUI:... Eric Faulhaber
01:40 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> 4011b rev 11535 seems fine to me. It's really strange that PSQL dialect has so specials nee...
Constantin Asofiei
01:23 PM Database Feature #4011: database/persistence layer performance improvements
4011b rev 11535 seems fine to me. It's really strange that PSQL dialect has so specials needs.
4011b rev 11536: one ...
Ovidiu Maxiniuc
01:04 PM Database Feature #4011: database/persistence layer performance improvements
4011 rev 11536 has these:
* Ignore DMO properties like _error-flag, _row-state, etc, where only table-defined legacy...
Constantin Asofiei
12:47 PM Database Feature #4011: database/persistence layer performance improvements
4011b rev 11535 completed implementation for blob, clob, comhandle, handle, object and raw field types. Please review. Constantin Asofiei
12:47 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> This code in @TemporaryBuffer$Context.nextPrimaryKey@:
> [...]
OK, yes, I see now....
Eric Faulhaber
12:27 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> So, instead of @lte@, we should emit @tt1.f1 < ?@, and use @PreparedStatement.setTimesta...
Ovidiu Maxiniuc
12:23 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> All our supported dialects have a field type which includes the time zone. However, they de...
Constantin Asofiei
12:17 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Constantin Asofiei wrote:
> > > Ovidiu/Eric: when does a del...
Constantin Asofiei
12:07 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Ovidiu/Eric: when does a deleted record get evicted from ...
Eric Faulhaber
11:57 AM Database Feature #4011: database/persistence layer performance improvements
Committed @DirtyShareSupport@ class missing from last commit, as 4011b rev 11534. Eric Faulhaber
11:35 AM Database Feature #4011: database/persistence layer performance improvements
All our supported dialects have a field type which includes the time zone. However, they decided to support them diff... Ovidiu Maxiniuc
10:47 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, in SQL, do we still need the '_offset' column when comparing a datetime-tz field with another (string represe... Constantin Asofiei
09:02 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Ovidiu/Eric: when does a deleted record get evicted from the @orm.Session.cache@? I can'...
Constantin Asofiei
08:42 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu/Eric: when does a deleted record get evicted from the @orm.Session.cache@? I can't find any place for this... ... Constantin Asofiei
06:36 AM Database Feature #4011: database/persistence layer performance improvements
I have committed 4011a_rebase rev 11533, which fixes the CAN-FIND in the test case from #4011-577 and enables dirty s... Eric Faulhaber
04:01 PM Database Bug #4057: h2 performance degradation
I've done a testing effort in comparing 1.4.196, 1.4.197, 1.4.197 patched, 1.4.198 and 1.4.199. I shared the results ... Adrian Lungu
01:39 PM Database Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
FYI, 4011b is the branch for this work. 4011a and 4011a_rebase are now frozen. Eric Faulhaber

07/01/2020

07:26 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Is it safe to change @getLegacyField2Name()@, to omit these properties?
I do not know e...
Ovidiu Maxiniuc
07:24 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Is it safe to change @getLegacyField2Name()@, to omit these properties?
It seems that o...
Constantin Asofiei
07:18 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Thanks, that solved this. And following is @TableMapper.leg...
Constantin Asofiei
07:13 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Thanks, that solved this. And following is @TableMapper.legacyGettersByProperty@ - this...
Ovidiu Maxiniuc
07:07 PM Database Feature #4011: database/persistence layer performance improvements
Thanks, that solved this. And following is @TableMapper.legacyGettersByProperty@ - this doesn't include the @TempTab... Constantin Asofiei
06:59 PM Database Feature #4011: database/persistence layer performance improvements
The dataset-related fields are added to @DmoMeta@ only if the table has before/after tables declared (see @src/com/go... Ovidiu Maxiniuc
06:40 PM Database Feature #4011: database/persistence layer performance improvements
Thanks, that solve this one. Now moving to more @TempTableRecord@ properties. The failure is this:... Constantin Asofiei
06:35 PM Database Feature #4011: database/persistence layer performance improvements
Use this in @DmoMetadataManager@:375 (method @getExistingFields()@):... Ovidiu Maxiniuc
06:24 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> In my opinion, we should set in @TempTableBuilder@:686:
> [...]
> and get rid of @columnT...
Constantin Asofiei
06:20 PM Database Feature #4011: database/persistence layer performance improvements
I am all for getting rid of multi-layer mappings; they slow things down and complicate code maintenance. But there ar... Eric Faulhaber
06:18 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> What seems to me is that the @P2JIndexCompoent@ can be used with FQL and SQL style index...
Ovidiu Maxiniuc
06:15 PM Database Feature #4011: database/persistence layer performance improvements
I think the problem is the ambiguity of @P2JIndex@. It is a descriptor of an index, which may be either a Progress in... Ovidiu Maxiniuc
06:10 PM Database Feature #4011: database/persistence layer performance improvements
In 4011a_rebase the index component is built from the DMO interface:... Constantin Asofiei
06:07 PM Database Feature #4011: database/persistence layer performance improvements
That suggests to me that the @column@ attribute of the @@Property@ annotation on the DMO interface is wrong, and shou... Eric Faulhaber
05:59 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Either, the column name key (i.e., the post-SQL-keyname-conflict-resolution version with the...
Constantin Asofiei
05:49 PM Database Feature #4011: database/persistence layer performance improvements
Either, the column name key (i.e., the post-SQL-keyname-conflict-resolution version with the trailing underscore) is ... Eric Faulhaber
04:57 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> I have a new case of name mismatch in @TempTableBuilder.getExistingIndexes@.
>
> The ...
Eric Faulhaber
04:45 PM Database Feature #4011: database/persistence layer performance improvements
The recreate is this:... Constantin Asofiei
04:16 PM Database Feature #4011: database/persistence layer performance improvements
I have a new case of name mismatch in @TempTableBuilder.getExistingIndexes@.
The field name is @order@, @P2JIndexC...
Constantin Asofiei
02:04 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> I need to find another way of creating the @PgBlob@ instance...
In the end, PostgreSQL ...
Constantin Asofiei
11:56 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Ovidiu, please check Hotel GUI for any other issues with 4011a_rebase.
OK, I will focus...
Ovidiu Maxiniuc
11:48 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Unless there is something more important I can help with. Please let me know.
Ovidiu, plea...
Constantin Asofiei
10:33 AM Database Feature #4011: database/persistence layer performance improvements
I found a possible issue in @DmoMetadataManager@, when tables from different databases have the same name.
I am not ...
Ovidiu Maxiniuc
09:29 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> And now I'm stuck because we are using c3p0 (which has @com.mchange.v2.c3p0.impl.NewProx...
Constantin Asofiei
09:18 AM Database Feature #4011: database/persistence layer performance improvements
And now I'm stuck because we are using c3p0 (which has @com.mchange.v2.c3p0.impl.NewProxyConnection@ instances for @j... Constantin Asofiei
08:46 AM Database Feature #4011: database/persistence layer performance improvements
@BlobType.readProperty@ is like this:... Constantin Asofiei
07:52 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > Ovidiu, we are still converting LOBs for DMOs (interfaces and im...
Constantin Asofiei
07:27 AM Database Feature #4011: database/persistence layer performance improvements
First time I'm trying to fire up the FWD server with 4011_rebase (rev 11531), in order to run a test case. I get this... Eric Faulhaber
02:47 AM Database Feature #4011: database/persistence layer performance improvements
4011a_rebase r11531 has modified build.gradle to use the fwd-h2 patched in this task, as ver 1.4.197-20200530. Constantin Asofiei
08:12 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Ovidiu, we are still converting LOBs for DMOs (interfaces and implementation classes), it se...
Ovidiu Maxiniuc
08:10 PM Database Feature #4011: database/persistence layer performance improvements
About the 'reWriteBatchedInserts=true' optimization for data import. I think this is just reporting '0' after the in... Constantin Asofiei
08:00 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, we are still converting LOBs for DMOs (interfaces and implementation classes), it seems, same as before. What... Eric Faulhaber
01:47 PM Database Support #4702: write temp-table performance test cases
Looks good so far.
In addition to the OPEN QUERY use you have in the read tests, please add some stressful use of ...
Eric Faulhaber
08:22 AM Database Support #4702: write temp-table performance test cases
I've committed read and update testcases to @testcases/uast/h2_performance@. The remaining testcases will follow. Stanislav Lomany
01:31 PM Database Feature #4723: make it significantly easier to run database import
The database import should be very simple to run, but today it has some "sharp edges" which tend to trip people up. ... Greg Shah
01:21 PM Database Feature #4723 (New): make it significantly easier to run database import
Greg Shah
01:18 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
The current approach has a fragile design which requires that we have a conversion project (or at least parts of it s... Greg Shah
01:15 PM Database Feature #4722 (Test): data import should be able to run with only the converted application jar f...
Greg Shah

06/30/2020

07:58 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Some details about postgresql are here: https://jdbc.postgre...
Constantin Asofiei
07:50 PM Database Feature #4011: database/persistence layer performance improvements
There's a change in 4011a_rebase which breaks @RecordBuffer.initialize@. This was previously done when @getDMOImplem... Constantin Asofiei
07:38 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Some details about postgresql are here: https://jdbc.postgresql.org/documentation/80/bin...
Ovidiu Maxiniuc
07:29 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> blob and clob import is broken now. I'm working on fixing @PropertyMapper@.
The same p...
Constantin Asofiei
07:09 PM Database Feature #4011: database/persistence layer performance improvements
blob and clob import is broken now. I'm working on fixing @PropertyMapper@. Constantin Asofiei
05:05 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> There are some issues in @IndexHelper.getPrimaryIndex@:
> * it was using @dmoClass@ ins...
Constantin Asofiei
04:48 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > * @TemporaryBuffer@
> > ** @makeMutable@ - yes, we need ...
Constantin Asofiei
08:35 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> * @TemporaryBuffer@
> ** @makeMutable@ - yes, we need an interface there, otherwise the...
Constantin Asofiei
05:43 AM Database Feature #4011: database/persistence layer performance improvements
The patch looks ok to me. Eric Faulhaber
08:04 PM Database Feature #4011: database/persistence layer performance improvements
There are some issues in @IndexHelper.getPrimaryIndex@:
* it was using @dmoClass@ instead of @dmoIface@ to get the a...
Constantin Asofiei
04:39 PM Database Feature #3814: more schema metadata
Found a minor issue with @_Field-Trig@ population.
Committing to 3821c revision 11381. ...
Igor Skornyakov
03:57 PM Database Feature #3814: more schema metadata
Roger Borrello wrote:
> Igor Skornyakov wrote:
> > Very strange. Can you please send me your project? I will take a...
Igor Skornyakov
03:24 AM Database Feature #3814: more schema metadata
Roger Borrello wrote:
> Igor Skornyakov wrote:
> > Very strange. Can you please send me your project? I will take a...
Igor Skornyakov
10:34 PM Database Feature #3814: more schema metadata
Igor Skornyakov wrote:
> Very strange. Can you please send me your project? I will take a look tomorrow.
> Thank yo...
Roger Borrello
04:35 PM User Interface Feature #4661: add support for missing formats to image loading
I don't think a testcase is really necessary, in that the customer application is already utilizing @gif@ images on b... Roger Borrello
08:30 AM User Interface Feature #4661: add support for missing formats to image loading
Greg Shah wrote:
> Roger: Prepare some simple 4GL samples that try to load @.gif@, @.png@ and @.svg@ from files. Yo...
Roger Borrello
08:12 AM User Interface Feature #4661: add support for missing formats to image loading
Roger: Prepare some simple 4GL samples that try to load @.gif@, @.png@ and @.svg@ from files. You can test this pure... Greg Shah
08:10 AM User Interface Feature #4661: add support for missing formats to image loading
Can you make a summary of what Roger would have to do (e.g. something like "look at classes X, Y and Z, method A and ... Greg Shah
02:14 PM Database Support #4702: write temp-table performance test cases
It is a common case in which a lot of time is likely to be spent in real applications. Any server-side stuff is goin... Greg Shah
01:09 PM Database Support #4702: write temp-table performance test cases
Greg Shah wrote:
> Perhaps it makes sense to have a test that has some temp-tables with large numbers of columns and...
Eric Faulhaber
01:06 PM Database Support #4702: write temp-table performance test cases
Stanislav Lomany wrote:
> [...]
> Is that good for a start?
Yes.
Eric Faulhaber
08:58 AM Database Support #4702: write temp-table performance test cases
I'm think there will be tables which will have the same set of fields:
# integer
# char
# double
# date
# logica...
Stanislav Lomany
08:17 AM Database Support #4702: write temp-table performance test cases
Perhaps it makes sense to have a test that has some temp-tables with large numbers of columns and uses buffer-copy to... Greg Shah
01:14 PM Database Feature #4055: optimize temp-table output parameter copying
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > * Pre-validation of each record is necessary. If we leave it ...
Eric Faulhaber
06:00 AM Database Feature #4055: optimize temp-table output parameter copying
Eric Faulhaber wrote:
> * Pre-validation of each record is necessary. If we leave it to the database to reject uniqu...
Constantin Asofiei
11:11 AM Base Language Feature #4384: Builtin OO Implementation
Marian, I think this is your change, right?... Constantin Asofiei
06:02 AM Database Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
Igor Skornyakov wrote:
> Is it a top-priority task?
It is next highest priority behind any work needed to complet...
Eric Faulhaber
06:00 AM Database Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
@TempTableDataSourceProvider@ was introduced in branch 4011a to provide database connections to the in-memory H2 data... Eric Faulhaber
05:53 AM Database Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
Is it a top-priority task?
Thank you.
Igor Skornyakov
05:50 AM Database Bug #4703 (Hold): investigate whether performance of TempTableDataSourceProvider can be improved
Eric Faulhaber
08:24 PM Database Support #4701: try to improve H2 transaction commit performance
Eric Faulhaber wrote:
> Start with version 1.4.197 and apply our existing patches before you build. Constantin has a...
Constantin Asofiei
08:22 PM Database Bug #4057: h2 performance degradation
Eric Faulhaber wrote:
> Constantin has a recent patch which is not integrated into the FWD distribution yet; you wil...
Constantin Asofiei

06/29/2020

07:43 PM Database Support #4702: write temp-table performance test cases
We need a set of temp-table related test cases in support of issues #4057 and #4071. The tests need to stress H2 as t... Eric Faulhaber
05:11 PM Database Support #4702 (Closed): write temp-table performance test cases
Eric Faulhaber
07:16 PM Database Bug #4057: h2 performance degradation
Please get the source for the latest version of H2 (1.4.200 at the time of this writing) and port our existing patche... Eric Faulhaber
07:07 PM Database Support #4701: try to improve H2 transaction commit performance
H2's transaction commit code repeatedly shows up as a performance bottleneck when profiling FWD application code. We ... Eric Faulhaber
05:10 PM Database Support #4701 (Closed): try to improve H2 transaction commit performance
Eric Faulhaber
06:33 PM User Interface Feature #4661: add support for missing formats to image loading
Greg Shah wrote:
> Our SVG support can be seen in @com.goldencode.p2j.ui.client.gui.VectorGraphicsHelper@. I see th...
Eugenie Lyzenko
06:26 PM User Interface Feature #4661: add support for missing formats to image loading
Roger Borrello wrote:
> Is this the location to look for additional plug-ins? -> https://github.com/haraldk/TwelveMo...
Eugenie Lyzenko
02:48 PM User Interface Feature #4661: add support for missing formats to image loading
Our SVG support can be seen in @com.goldencode.p2j.ui.client.gui.VectorGraphicsHelper@. I see that we have the abili... Greg Shah
02:12 PM User Interface Feature #4661: add support for missing formats to image loading
Is this the location to look for additional plug-ins? -> https://github.com/haraldk/TwelveMonkeys
It seems @gif@ i...
Roger Borrello
06:02 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, there is a TODO in @TableMapper@:... Eric Faulhaber
02:57 PM Database Feature #4011: database/persistence layer performance improvements
@DmoMetadataManager.getBasePackage@
LE: Sorry, it's actually @DmoMetadataManager.getDmoBasePackage@, and it will i...
Eric Faulhaber
02:52 PM Database Feature #4011: database/persistence layer performance improvements
What is the counterpart of the @DMOIndex.getBasePackage()@ in 4011a?
Thank you.
Igor Skornyakov
12:52 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > Greg Shah wrote:
> > > Is index size a problem for temp-tables?...
Greg Shah
08:54 AM Database Feature #4011: database/persistence layer performance improvements
* @SortCriterion@
** @WHERE_WITH_NULLS@ I think can be removed. I'll need to double-check the customer project, but...
Constantin Asofiei
08:30 AM Database Feature #4011: database/persistence layer performance improvements
@FWDDataObject@ - this class is used outside of the FWD context, by customer code via @LegacyJavaAppserver@. I'm wor... Constantin Asofiei
07:52 AM Database Feature #4011: database/persistence layer performance improvements
Regarding the rebase TODO in @DatabaseManager.getDatabaseDMOs@...
The javadoc for @DatabaseManager.getDatabaseDMOs...
Eric Faulhaber
05:20 PM Database Feature #3814: more schema metadata
Constantin Asofiei wrote:
> Roger, what version of 3821c do you have? Note that trunk had a metadata generation issu...
Roger Borrello
05:17 PM Database Feature #3814: more schema metadata
Roger, what version of 3821c do you have? Note that trunk had a metadata generation issue which was solved in a 3821... Constantin Asofiei
05:08 PM Database Feature #3814: more schema metadata
Roger Borrello wrote:
> Igor Skornyakov wrote:
> > Roger,
> > I'm busy now with some urgent assignment. Was the @m...
Igor Skornyakov
05:03 PM Database Feature #3814: more schema metadata
Igor Skornyakov wrote:
> Roger,
> I'm busy now with some urgent assignment. Was the @meta_table_ddl.sql@ file gener...
Roger Borrello
04:48 PM Database Feature #3814: more schema metadata
Roger Borrello wrote:
> I started receiving this during runtime of my testcase:
> [...]
>
> I made a few updates...
Igor Skornyakov
04:38 PM Database Feature #3814: more schema metadata
I started receiving this during runtime of my testcase:... Roger Borrello
02:30 PM Database Feature #3814: more schema metadata
3821c revision 11377 fixes a regression DMO generation. The VIEW-AS text can have embedded quotes and escape sequenc... Greg Shah
11:40 PM Database Feature #3813: misc DB features part deux
Branch 3821c revision 11374 has the implementation of @BUFFER-FIELD:DEFAULT-VALUE@ as well as the fixes to @date@/@da... Greg Shah

06/27/2020

04:13 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Greg Shah wrote:
> > Is index size a problem for temp-tables? I thought that was a SQLSer...
Eric Faulhaber

06/26/2020

07:33 PM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> Is index size a problem for temp-tables? I thought that was a SQLServer thing.
4GL has its own ...
Ovidiu Maxiniuc
07:27 PM Database Feature #4011: database/persistence layer performance improvements
Is index size a problem for temp-tables? I thought that was a SQLServer thing. Greg Shah
06:55 PM Database Feature #4011: database/persistence layer performance improvements
Note that in the cases where the DMO implementation classes are different, it is not just unique constraints that are... Eric Faulhaber
06:36 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > In @TemporaryBuffer.copyAllRows@, we can skip record validati...
Constantin Asofiei
06:13 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> In @TemporaryBuffer.copyAllRows@, we can skip record validation if:
> [...]
>
> This...
Eric Faulhaber

06/25/2020

04:10 PM Database Feature #3814: more schema metadata
Added _File-Trig and _Field-Trig population
Committing to 3821c revision 11366. ...
Igor Skornyakov
12:51 PM Database Feature #4011: database/persistence layer performance improvements
Regarding the test at #4011-633 - I've created a physical database with the same table structure and indexes, and OE ... Constantin Asofiei
12:49 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I'm not sure what you are asking. Across different DMO implementation classes, two unique in...
Constantin Asofiei
12:44 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> But, does anyone know if we have a way to check if the unique indexes in two DMO impl ma...
Eric Faulhaber
09:55 AM Database Feature #4011: database/persistence layer performance improvements
For temp-tables, FWD has problems with this test:... Constantin Asofiei
09:10 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, an idea about the temp-table flushing. We currently save on every touched field. ...
Constantin Asofiei
09:00 AM Database Feature #4011: database/persistence layer performance improvements
Eric, an idea about the temp-table flushing. We currently save on every touched field. But I think we can defer thi... Constantin Asofiei
06:36 AM Database Feature #4011: database/persistence layer performance improvements
In @TemporaryBuffer.copyAllRows@, we can skip record validation if:... Constantin Asofiei
04:00 AM Base Language Feature #4384: Builtin OO Implementation
We have some issues with OO named events, one of the tests does not pass conversion: @oo/openedge/net/http/filter/aut... Marian Edu

06/24/2020

06:49 PM Database Feature #4011: database/persistence layer performance improvements
The NULLS LAST/FIRST fix is in 4011a rev 11499. Constantin Asofiei
05:50 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> I don't understand what is happening. The same SQL in the standalone H2 server knows to...
Constantin Asofiei
03:29 PM Database Feature #4011: database/persistence layer performance improvements
I don't understand what is happening. The same SQL in the standalone H2 server knows to move the nulls to last posit... Constantin Asofiei
02:35 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Also, H2 is wrong with or without a DESC index for F2 - the NULL must be first.
To be m...
Constantin Asofiei
02:33 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, add an ASC index for F1 and you will see that H2 is wrong - it will place the NULL first.
Also, H2 is wron...
Constantin Asofiei
02:32 PM Database Feature #4011: database/persistence layer performance improvements
... Ovidiu Maxiniuc
02:28 PM Database Feature #4011: database/persistence layer performance improvements
What's the result for @select * from t1 order by f1 desc;@? Constantin Asofiei
02:27 PM Database Feature #4011: database/persistence layer performance improvements
I did a quick test with H2:... Ovidiu Maxiniuc
02:24 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> I have some tests, and OE sorts the nulls always last, regardless of direction.
Sorry, ...
Constantin Asofiei
02:01 PM Database Feature #4011: database/persistence layer performance improvements
I have some tests, and OE sorts the nulls always last, regardless of direction.
H2 has a bug in that it doesn't co...
Constantin Asofiei
01:16 PM Database Feature #4011: database/persistence layer performance improvements
Postgresql states that:
> By default, null values sort as if larger than any non-null value; that is, NULLS FIRST is...
Constantin Asofiei
11:48 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Another issue is that the SUBSELECT doesn't have the @NULLS LAST@. At least we should b...
Constantin Asofiei
11:42 AM Database Feature #4011: database/persistence layer performance improvements
There is a problem in 4011a, where we emit @NULLS LAST@ in the @ORDER BY@ clause. This causes a performance regressi... Constantin Asofiei
03:20 PM Database Feature #3814: more schema metadata
Finished with VIEW-AS field property conversion and population of the @_Field._View-As@.
Tested with a standalone te...
Igor Skornyakov
08:55 AM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Roger Borrello wrote:
> Constantin Asofiei wrote:
> > Roger, the fix is in 3821c rev 11363.
> >
> > Please test ...
Roger Borrello
08:40 AM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Constantin Asofiei wrote:
> Roger, the fix is in 3821c rev 11363.
>
> Please test with the customer scenario.
...
Roger Borrello
07:10 AM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Roger, the fix is in 3821c rev 11363.
Please test with the customer scenario.
Constantin Asofiei
05:58 AM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Eric Faulhaber wrote:
> I am attaching a patch because I didn't have a branch to which to commit. The attached patch...
Constantin Asofiei
05:28 AM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Eric Faulhaber wrote:
> Constantin, please take it from here.
OK, I'm working on it.
Constantin Asofiei
01:33 AM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Roger Borrello wrote:
> That patch alleviated the NPE, and we now result in:
> * "Unable to PREPARE TEMP-TABLE bu...
Eric Faulhaber
07:05 AM Database Support #3871: determine how to change codepages/locales during import
This task is not about the runtime environment. This is only about database import.
What matters is that we must ...
Greg Shah
12:02 AM Database Support #3871: determine how to change codepages/locales during import
Analyzing the task history. The @FWD@ functionality from my understanding is to have tow separate parts, runtime envi... Eugenie Lyzenko

06/23/2020

07:54 PM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Eric Faulhaber wrote:
> Yes and no :-)
>
> I am attaching a patch because I didn't have a branch to which to comm...
Roger Borrello
06:09 PM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Yes and no :-)
I am attaching a patch because I didn't have a branch to which to commit. The attached patch fixes ...
Eric Faulhaber
06:04 PM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Eric Faulhaber wrote:
> Nevermind, got it.
Are you looking at this? Did you see the notes in #4208-736 ?
Roger Borrello
04:55 PM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Nevermind, got it.... Eric Faulhaber
04:49 PM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Stack trace? Eric Faulhaber
04:01 PM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Will there be different code-paths for a temp-table versus a standard table? I am walking through the testcase, tryin... Roger Borrello
01:17 PM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
This code generates a @NPE@ on @trunk-11347@:... Roger Borrello
07:17 PM Database Feature #4011: database/persistence layer performance improvements
I committed revision 11496 to 4011a. It is mainly a FLQ support update:
* added support for DMOs in FROM clause of S...
Ovidiu Maxiniuc
10:35 AM Database Feature #4011: database/persistence layer performance improvements
It is not clear to me why we match @PROPERTY@ in the lexer (as @DOT SYMBOL@). Since there are many possible qualifie... Greg Shah
10:22 AM Database Feature #4011: database/persistence layer performance improvements
Related to parsing of FQL: at this moment FQL2SQL is unable to parse queries like:
@from com.goldencode.appname.dmo....
Ovidiu Maxiniuc
06:06 AM Database Feature #4011: database/persistence layer performance improvements
I've committed revisions 11494 and 11495. 11494 is Ovidiu's import fix. 11495 partially fixes the test case in #4011-... Eric Faulhaber
05:38 PM Database Feature #3814: more schema metadata
After adding checks for @null@ to the @SymbolResolver@ I do not see warning anymore and there is a @KW_VIEW_AS@ note... Igor Skornyakov
05:12 PM Database Feature #3814: more schema metadata
> I do not see KW_VIEW_AS node in the .schema or .dict files. Maybe this is a result of NPE.
Yes, possibly so.
Greg Shah
05:04 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> > however, there is no KW_VIEW_AS node in the AST at all
>
> The @replaceAst()@ rewrites that ...
Igor Skornyakov
04:46 PM Database Feature #3814: more schema metadata
> however, there is no KW_VIEW_AS node in the AST at all
The @replaceAst()@ rewrites that @KW_VIEW_AS@ subtree, th...
Greg Shah
04:42 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Constantin Asofiei wrote:
> > Greg, do you think is safe to set @dict=true@ at the @SymbolResolv...
Igor Skornyakov
04:37 PM Database Feature #3814: more schema metadata
Constantin Asofiei wrote:
> Greg, do you think is safe to set @dict=true@ at the @SymbolResolver@ instance created b...
Greg Shah
04:10 PM Database Feature #3814: more schema metadata
Constantin Asofiei wrote:
> Greg, do you think is safe to set @dict=true@ at the @SymbolResolver@ instance created b...
Igor Skornyakov
03:39 PM Database Feature #3814: more schema metadata
Greg, do you think is safe to set @dict=true@ at the @SymbolResolver@ instance created by @SchemaLoader.postProcessIm... Constantin Asofiei
03:36 PM Database Feature #3814: more schema metadata
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > This is exactly what I did. It seems that not callers are re...
Igor Skornyakov
03:24 PM Database Feature #3814: more schema metadata
Igor Skornyakov wrote:
> This is exactly what I did. It seems that not callers are ready for @null@. But I will try ...
Constantin Asofiei
03:19 PM Database Feature #3814: more schema metadata
Constantin Asofiei wrote:
> > I've tried this. It doesn't help, NPE happens in @SymbolResolver.addWrappedWorker@
> ...
Igor Skornyakov
03:15 PM Database Feature #3814: more schema metadata
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > I think is enough to add a NPE check there for @currentCls@....
Constantin Asofiei
03:13 PM Database Feature #3814: more schema metadata
Constantin Asofiei wrote:
> I think is enough to add a NPE check there for @currentCls@. During schema parser, ther...
Igor Skornyakov
03:08 PM Database Feature #3814: more schema metadata
Igor Skornyakov wrote:
> The conversion of the .df files produces a number of warnings like this:
> [...]
> This h...
Constantin Asofiei
02:59 PM Database Feature #3814: more schema metadata
The conversion of the .df files produces a number of warnings like this:... Igor Skornyakov
03:24 PM Base Language Feature #3753: I18N additions
Some things we've found and tried to fix soo far while implementing OO base classes...
- codepage conversion support...
Marian Edu
02:45 PM Base Language Feature #4384: Builtin OO Implementation
Just making a note so don't forget about it, there is an issue with destructors when there is an error thrown from a ... Marian Edu
02:41 PM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Marian Edu wrote:
> Constantin, do you still need those extra tests for REST? I'm having troubles getting the deploy...
Constantin Asofiei
02:02 PM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Greg Shah wrote:
> Task branch 4231b has been merged to trunk as revision 11347.
Constantin, do you still need th...
Marian Edu
08:01 AM Database Support #3871 (WIP): determine how to change codepages/locales during import
Sergey Ivanovskiy wrote:
> I used the similar diff to the following one in order to setup the UTF-8 database with IN...
Greg Shah

06/22/2020

06:12 PM Database Feature #4011: database/persistence layer performance improvements
Some notes about @fql.g@ from my quick review:
* The overall structure looks ... familiar. :) This is not a compl...
Greg Shah
02:28 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> There are issues in 4011a with the batch deletes:
> * the composite tables need to be d...
Constantin Asofiei
10:00 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> A variation of #4011-549 with the validation:
> [...]
>
> The @CAN-FIND@ sees this r...
Eric Faulhaber
04:30 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Code Review Task Branch 3821c Revision 11358
This seems better. Confirm it with testing.
Greg Shah
10:16 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
This was implemented in @3821c-11358@. Please review, and let me know if there's a way to run an individual test for ... Roger Borrello
08:20 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Roger Borrello wrote:
> If @ConfigHelper.getAssignedRow(frame.config())@ can return @BaseConfig.INV_COORD@ as well, ...
Roger Borrello
08:16 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Greg Shah wrote:
> Code Review Task Branch 3821c Revision 11354
>
> This is incorrect. @ConfigHelper.getAssigned...
Roger Borrello
06:50 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Code Review Task Branch 3821c Revision 11354
This is incorrect. @ConfigHelper.getAssignedColumn(frame.config())@ ...
Greg Shah
09:28 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Greg Shah wrote:
> As part of this task, there were changes to the @ThinClient.getFrameCol()@ method.
>
> I've ba...
Roger Borrello
01:42 PM Database Feature #4692: add sanity check at server startup to compare DMO indices with database indices
Good point. We should add a comparison of legacy "mandatory" fields with database columns marked "not null" as part o... Eric Faulhaber
12:48 PM Database Feature #4692: add sanity check at server startup to compare DMO indices with database indices
Additional indices are OK as they could improve performance (if we spot some series of queries that frequently use a ... Ovidiu Maxiniuc
12:38 PM Database Feature #4692: add sanity check at server startup to compare DMO indices with database indices
Branch 4011a eliminates the collection of index metadata from the database at startup to populate @IndexHelper@ data ... Eric Faulhaber
12:27 PM Database Feature #4692 (New): add sanity check at server startup to compare DMO indices with database indices
Eric Faulhaber
01:37 PM Database Support #4693: check whether our index consolidation adversely affects flushing behavior
During schema conversion, we do some consolidation of the original 4GL indices to eliminate redundant indices. I am w... Eric Faulhaber
01:28 PM Database Support #4693 (New): check whether our index consolidation adversely affects flushing behavior
Eric Faulhaber
11:24 AM Database Feature #3814: more schema metadata
Finished re-working metadata configuration in p2j.cfg.xml.
Now, if there is no <metadata> section on the @p2j.cfg.xm...
Igor Skornyakov
07:04 AM User Interface Feature #4170: add drag and drop support to treeview widget
Is there any remaining work or testing needed for this task? Greg Shah
06:39 AM User Interface Bug #4631 (Test): Widget scoped to wrong frame on hide
Code Review Task Branch 3821c Revision 11353
The changes are good.
Greg Shah
09:26 PM User Interface Bug #4631: Widget scoped to wrong frame on hide
Greg Shah wrote:
> Was this with the version that had removed the @addDictionaryObject()@ which I asked about?
>
...
Roger Borrello

06/21/2020

07:28 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I assume that @ScrollPaneGuiImpl@ needs a change that gives more control over its positioning, sizing or over the dra... Greg Shah
07:26 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I don't think it makes sense to have an enhanced browse menu button inside a scrolling helper class. Greg Shah
07:06 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Can't the scrollbars be sized and positioned so that they don't overlap the space for the gear icon?
Sorry, don'...
Stanislav Lomany
07:00 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
You can subclass it if that is the best way. But it seems like the gear icon will always be there in this mode, so w... Greg Shah
06:55 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> I don't know the answer here, but I wouldn't want a generic helper class to have a browse-specific feature.
If t...
Stanislav Lomany
06:50 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
We should not take up more space than the 4GL compatible version. Instead we "sacrifice" a row.
> X-1 rows, but ...
Greg Shah
10:46 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Greg, I have a question about the "tray" which should appear if there are no scrollbars and we want to find a place f... Stanislav Lomany
06:51 PM Database Feature #3814: more schema metadata
Yes, I think that is fine. Greg Shah
10:54 AM Database Feature #3814: more schema metadata
Do we really need to support @p2j.cf.xml@ w/o a <metadata> section? It requires a lot of changes as in many places it... Igor Skornyakov
05:09 AM Database Feature #3814: more schema metadata
Backport of the @SEQUENCE@ support from 4011a and population of the @_Sequence@ table committed to 3821c rev. 11351. Igor Skornyakov

06/20/2020

01:34 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> 3821c not b
OK, thank you.
Igor Skornyakov
01:33 PM Database Feature #3814: more schema metadata
3821c not b Greg Shah
01:32 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Hynek will open 3821b shortly.
Got it. Thanks!
Igor Skornyakov
01:23 PM Database Feature #3814: more schema metadata
Hynek will open 3821b shortly. Greg Shah
12:45 PM Database Feature #3814: more schema metadata
Greg, which branch should I use for #3814 now?
Thank you.
Igor Skornyakov
12:00 PM Database Feature #3814: more schema metadata
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:11 PM User Interface Bug #4589 (Closed): menu case sensitivity and conversion
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:10 PM Database Bug #4492: database trigger defined with abbreviation should create a new buffer
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:10 PM Base Language Support #4657: memory overhead from preloading classes with LegacySignature
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:06 PM User Interface Bug #4074 (Closed): Mismatching ROW-ENTRY/LEAVE events
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:04 PM User Interface Bug #3690 (Closed): BUTTON widget reaction on SPACEBAR and ENTER keys
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:03 PM User Interface Bug #4624 (Closed): Fill-in: StringIndexOutOfBoundsException and other bugs
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:02 PM User Interface Feature #2683: reverse proxy implementation
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:01 PM Runtime Infrastructure Feature #3819: PROFILER system handle
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:01 PM Database Bug #3471: incremental conversion is regressed
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:00 PM Base Language Feature #4395 (Closed): add support for KEEP-MESSAGES option
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:00 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:00 PM User Interface Feature #4393 (Closed): add TITLE-DCOLOR attribute support
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:00 PM User Interface Feature #4394 (Closed): add some frame options and attributes
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:59 AM Base Language Feature #4162 (Closed): enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:58 AM Base Language Feature #3812 (Closed): additions to SESSION system-handle
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:58 AM Base Language Feature #4381 (Closed): implement LIBRARY() and MEMBER() built-in functions
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:57 AM Database Feature #4397: add database attrs, methods and options
Task branch 4231b has been merged to trunk as revision 11347.
Is there anything left to do in this task?
Greg Shah
11:57 AM Database Feature #3813: misc DB features part deux
Task branch 4231b has been merged to trunk as revision 11347.
> Considering that the WHERE clause work has been mo...
Greg Shah
11:56 AM Database Feature #4375 (Closed): add support for -pf <profile_filename> option for CONNECT statement
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:55 AM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:55 AM Base Language Feature #3854: update appserver support with PASOE features
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:54 AM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:54 AM Base Language Bug #4602: fixes for OO 4GL and structured error handling
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:53 AM Base Language Bug #4355 (Closed): exception member of the CATCH block can be referenced after the block catchin...
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:53 AM Base Language Feature #4354: add GET-CLASS() function support
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:53 AM Base Language Feature #4349 (Closed): add support for 4GL ENUM
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:52 AM User Interface Feature #3876: add support for "direct font control" at the widget level
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:52 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:43 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
The generic (no user version) of the URL should continue to work as well. Greg Shah
11:42 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
The idea is that the user would have the URL bookmarked which would map to the right user name. Then the login form ... Greg Shah
11:08 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Greg Shah wrote:
> Yes, but by doing it this way the local storage would be specific to the user instead of the mach...
Hynek Cihlar
11:05 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Yes, but by doing it this way the local storage would be specific to the user instead of the machine. It isn't secur... Greg Shah
11:01 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Greg Shah wrote:
> Correct.
>
> A variant of this idea: if the initial URL had a user-account component (@https:/...
Hynek Cihlar
10:57 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Correct.
A variant of this idea: if the initial URL had a user-account component (@https://<host>:<port>/gui/<os_u...
Greg Shah
10:41 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Hynek Cihlar wrote:
> Wouldn't the cookie be subject of CORS when it would be read on a different port (not mentioni...
Hynek Cihlar
10:38 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Greg Shah wrote:
> > > Does anyone see a better alternative?
...
Hynek Cihlar
10:34 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Crazy-lazy idea: we could identify the client using the available browser information (agent, resolution, OS, versi... Greg Shah
10:13 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Hynek Cihlar wrote:
> Greg Shah wrote:
> > Does anyone see a better alternative?
>
> Crazy-lazy idea: we could i...
Constantin Asofiei
10:12 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Greg Shah wrote:
> Does anyone see a better alternative?
Crazy-lazy idea: we could identify the client using the ...
Hynek Cihlar
09:08 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> What I see:
> # Start an app and save a configuration. In local storage browser I see tha...
Greg Shah
04:16 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I am using these settings for the web client:... Sergey Ivanovskiy
11:51 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:50 AM User Interface Feature #4170: add drag and drop support to treeview widget
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:50 AM User Interface Bug #4636: Make the Theme API independent on concrete implementation classes
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
10:18 AM User Interface Bug #4631: Widget scoped to wrong frame on hide
Was this with the version that had removed the @addDictionaryObject()@ which I asked about?
If so, does that same ...
Greg Shah

06/19/2020

07:32 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Sure!
I just need to resolve this ports story for my local configuration.
Stanislav Lomany
07:24 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I tested also with saving "All browses, Current User". The result after cold restart was all tables changes backgroun... Sergey Ivanovskiy
07:08 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I built FWD with these changes and applied them to Hotel GUI with @deploy.prepare@. Then cleaned all localStorage and... Sergey Ivanovskiy
07:00 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
What I see:
# Start an app and save a configuration. In local storage browser I see that the configuration is saved ...
Stanislav Lomany
06:56 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Sorry, I forgot to mention it! Please test it while saving configuration for "This Browse, Current User" (or "All bro... Stanislav Lomany
06:51 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> > It seems that now the browse configuration is restored.
>
> For me configuration is ...
Sergey Ivanovskiy
06:49 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
At least the cell's background color, height and font were persisted across the server restarts. Sergey Ivanovskiy
06:49 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> It seems that now the browse configuration is restored.
For me configuration is still not loaded after server r...
Stanislav Lomany
06:43 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
#3880-141 Thank you, I know:) Stanislav Lomany
06:40 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> Well, I don't like new line symbol within a key and double quoting. But I'm not sure if th...
Sergey Ivanovskiy
05:51 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Well, I don't like new line symbol within a key and double quoting. But I'm not sure if that's an issue.
So, sorry, ...
Stanislav Lomany
05:47 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Yes, it looks like an issue. How it can be happened? Sergey Ivanovskiy
05:42 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
The first I checked that the @localStorage@ has the same key and value after the server has been restarted. I observe... Sergey Ivanovskiy
05:34 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Planning to debug what was the issue.
I think I found the bug:...
Stanislav Lomany
05:27 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
User configurations can be "for all users" and user-specific. "For all users" are saved in the directory. User-specif... Stanislav Lomany
05:24 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
It is not obvious for me that the issue is the serialization/deserealization from the web @localStorage@. Planning to... Sergey Ivanovskiy
05:21 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
In this case it seems that the browse configuration doesn't read after the user is logged out and it is saved on the ... Sergey Ivanovskiy
05:15 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Yes, after the server has been restarted the configuration was not retrieved but it is not because of the different... Stanislav Lomany
05:07 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> Sergey, does configurations survive server restart?
Yes, after the server has been restar...
Sergey Ivanovskiy
04:35 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Regarding exception. It is suppressed in @WebClientKeyValueStorage.getChunk@:... Stanislav Lomany
04:32 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Sergey, does configurations survive server restart? It just crossed my mind that a dynamic port is assigned every tim... Stanislav Lomany
04:28 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Also I tried to save the browse configuration with blue background color for the particular user and restore it after... Sergey Ivanovskiy
04:18 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I checked the Hotel Gui with the web client for Firefox. It seems that the enhanced browse configuration is stored. I... Sergey Ivanovskiy
02:57 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I didn't encounter this exception. Could you provide a testcase to reproduce? At the time of my changes the enhanced ... Sergey Ivanovskiy
11:57 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
An enhanced browse configuration cannot be loaded from a web storage. I have to fix it before any other issue. If any... Stanislav Lomany
05:55 PM User Interface Bug #4631: Widget scoped to wrong frame on hide
Greg Shah wrote:
> The ChUI testing is on @devsrv01@.
After the complete conversion testing, there were no artifa...
Roger Borrello
09:33 AM User Interface Bug #4631: Widget scoped to wrong frame on hide
The ChUI testing is on @devsrv01@. Greg Shah
09:19 AM User Interface Bug #4631: Widget scoped to wrong frame on hide
Greg Shah wrote:
> The overall approach seems close. The one thing that looks wrong is line 1884 (@<action>addDicti...
Roger Borrello
05:13 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> The old @cumulativeDirtyProps@ was stored in @ValidationHelper@ and contained the entire se...
Eric Faulhaber
04:49 PM Database Feature #4011: database/persistence layer performance improvements
The old @cumulativeDirtyProps@ was stored in @ValidationHelper@ and contained the entire set of changes at the last (... Ovidiu Maxiniuc
04:37 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, regarding 4011a/11486: @RecordBuffer.cumulativeDirtyProps@ is never modified, only instantiated and used as a... Eric Faulhaber
04:09 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
>
> > the composite tables need to be deleted manually (or is t...
Ovidiu Maxiniuc
04:05 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> the composite tables need to be deleted manually (or is the foreign key 'on cascade de...
Eric Faulhaber
03:18 PM Database Feature #4011: database/persistence layer performance improvements
There are issues in 4011a with the batch deletes:
* the composite tables need to be deleted manually (or is the fore...
Constantin Asofiei
02:17 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> The only issue I have is that @boolean doFlush = !rollback || hasUniqueConstraint;@ wi...
Eric Faulhaber
02:01 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin, would you please carefully review the change? It did go through some regression ...
Constantin Asofiei
01:40 PM Database Feature #4011: database/persistence layer performance improvements
Committed rev 11487, which:
* bypasses database-level unique constraint validation when the backing table has no u...
Eric Faulhaber
07:52 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> some indexes keep their @unique@ attribute. I remember that we were intentionally doing s...
Eric Faulhaber
08:05 PM Database Feature #4011: database/persistence layer performance improvements
Eric,
As I informed by email, I noticed some differences in the generated indexes for our test framework. There are ...
Ovidiu Maxiniuc
06:08 AM Database Feature #3814: more schema metadata
Status summary update (see #3814-100)
# Added @_Sequence@ table population based on the new @SEQUENCE@ support (back...
Igor Skornyakov

06/18/2020

07:34 PM Database Feature #4011: database/persistence layer performance improvements
As part of cleaning up the branch, we should get rid of these ANTLR warnings:... Eric Faulhaber
01:30 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> This is a different issue than that which is addressed by the use of the @ParameterIndices@ ...
Constantin Asofiei
01:04 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > For a WHERE clause which has subscripted fields like @tt1...
Eric Faulhaber
09:25 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> For a WHERE clause which has subscripted fields like @tt1.f1[?]@, I need to inject the @...
Constantin Asofiei
08:34 AM Database Feature #4011: database/persistence layer performance improvements
For a WHERE clause which has subscripted fields like @tt1.f1[?]@, I need to inject the @tt1__10.list__index = ?@ at t... Constantin Asofiei
07:08 PM User Interface Bug #4631: Widget scoped to wrong frame on hide
The overall approach seems close. The one thing that looks wrong is line 1884 (@<action>addDictionaryObject("frame_e... Greg Shah
04:52 PM Database Feature #4690: re-integrate dirty share logic into new persistence implementation
Ovidiu Maxiniuc wrote:
> The choice to use a @null@ context is due the performance. This might not be the most ele...
Eric Faulhaber
03:55 PM Database Feature #4690: re-integrate dirty share logic into new persistence implementation
Eric Faulhaber wrote:
> I'm reading through the changes, and this is not a full review yet, but I have some general ...
Ovidiu Maxiniuc
02:28 PM Database Feature #4690: re-integrate dirty share logic into new persistence implementation
I'm reading through the changes, and this is not a full review yet, but I have some general questions about the 4011a... Eric Faulhaber
02:20 PM Database Feature #4690: re-integrate dirty share logic into new persistence implementation
Some new requirements have arisen for the dirty share feature set. Although we would like to eliminate this feature a... Eric Faulhaber
01:54 PM Database Feature #4690: re-integrate dirty share logic into new persistence implementation
Opening a separate issue for this, as it is a substantial topic on its own...
4011a_dirty is the branch in use for...
Eric Faulhaber
01:53 PM Database Feature #4690 (WIP): re-integrate dirty share logic into new persistence implementation
Eric Faulhaber
11:23 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
In Web client the @gui/driver/web/GuiWebDriver.java@ uses specific @X@ scaling factor for every font in use. This sho... Eugenie Lyzenko
10:32 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Put this under @/server/default/@ or @/server/<server_name>/@:... Stanislav Lomany
10:29 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
What is the "simple" (single boolean flag) directory configuration for enabling enhanced mode? Greg Shah
09:06 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> The scale factor should be different for Web as well as for Swing client. So why does the font chooser always uses ... Stanislav Lomany
07:09 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> > The big concern here is that the web gives different results from Swing. Based on your ...
Hynek Cihlar
09:01 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
As part of this task, there were changes to the @ThinClient.getFrameCol()@ method.
The original code:...
Greg Shah
07:46 AM Base Language Feature #4384: Builtin OO Implementation
> Actually the offending one was org.aspectj.org.eclipse.jdt.internal.formatter.linewrap, if we need to add some extr... Greg Shah
07:29 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> I've merged all the changes from 4384c (revisions 11569 through 11579) into 4231b revision 11606....
Marian Edu
06:39 AM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs
> To modify the Possenet, we'd be creating an offshoot that we would need to document. I believe it's best to utilize... Greg Shah

06/17/2020

07:23 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> The big concern here is that the web gives different results from Swing. Based on your notes, I still don't unders... Stanislav Lomany
04:10 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
The font chooser case is not very important. If that was not working, it would be less of a concern.
The big conc...
Greg Shah
04:02 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> If scaling only happens for Swing, then why are the metrics for web the same (and wrong)?
It's not quite that wa...
Stanislav Lomany
06:40 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs
Greg Shah wrote:
> Yes, but in FWD we have no such thing. I was not suggesting that we implement a "fake" procedure...
Roger Borrello
06:00 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs
Yes, but in FWD we have no such thing. I was not suggesting that we implement a "fake" procedure library result.
...
Greg Shah
05:50 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs
More info related to the 4GL's behavior. It indicates we can proceed.
I was able to position a procedure library i...
Roger Borrello
05:34 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs
Greg Shah wrote:
> For a @.r@ file that is part of the application, there is no procedure library involved. For a p...
Roger Borrello
04:12 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs
For a @.r@ file that is part of the application, there is no procedure library involved. For a procedure that is a m... Greg Shah
04:04 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs
The code in @adm2/containr.p@ does not specifically perform a @LIBRARY@ call, prior to the code snippet that we are a... Roger Borrello
02:12 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> OK, please commit the change to 4231b.
Committed revision 11609.
Igor Skornyakov
02:05 PM Database Feature #3814: more schema metadata
OK, please commit the change to 4231b. Greg Shah
01:58 PM Database Feature #3814: more schema metadata
Some additional fixes were made to run hotel apps w/o @p2j.cf.xml@. See attachment. Igor Skornyakov
12:33 PM Database Feature #3814: more schema metadata
Igor Skornyakov wrote:
> Greg Shah wrote:
> > The change looks good. Please test it with Hotel GUI and Hotel ChUI....
Greg Shah
12:32 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> The change looks good. Please test it with Hotel GUI and Hotel ChUI.
Both apps started OK. Pl...
Igor Skornyakov
12:11 PM Database Feature #3814: more schema metadata
The change looks good. Please test it with Hotel GUI and Hotel ChUI. Greg Shah
12:04 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Why did you remove the @throw@ in the @catch()@ block of @Configuration.createConfiguration()@? ...
Igor Skornyakov
11:55 AM Database Feature #3814: more schema metadata
Why did you remove the @throw@ in the @catch()@ block of @Configuration.createConfiguration()@? This means that the ... Greg Shah
11:48 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Code Review cfg.diff
>
> Please remove the new imports in @Configuration@ and also remove the ...
Igor Skornyakov
11:41 AM Database Feature #3814: more schema metadata
Code Review cfg.diff
Please remove the new imports in @Configuration@ and also remove the change for the @catch()@...
Greg Shah
11:11 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Code Review cfg.diff
>
> 1. At this time, it is intentional that we do not use logging in @Con...
Igor Skornyakov
10:17 AM Database Feature #3814: more schema metadata
Code Review cfg.diff
1. At this time, it is intentional that we do not use logging in @Configuration@. It is used...
Greg Shah
09:02 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Please post the change here in patch format so I can review it. If OK, you will check it in to 4...
Igor Skornyakov
08:06 AM Database Feature #3814: more schema metadata
Please post the change here in patch format so I can review it. If OK, you will check it in to 4231b since this is m... Greg Shah
07:54 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> A safe default configuration (which has nothing enabled) should be present if the file is not ava...
Igor Skornyakov
07:02 AM Database Feature #3814: more schema metadata
A safe default configuration (which has nothing enabled) should be present if the file is not available. No abends. Greg Shah
06:57 AM Database Feature #3814: more schema metadata
I've fixed the situation when there is no <metadata> section on the @p2j.cfg.xml@. However it seems that the applicat... Igor Skornyakov
05:55 AM Database Feature #3814: more schema metadata
Please make both cases safe. Greg Shah
02:55 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> I'm using the ChUI regression test suite. I found that with 4231b, it is now required to have a ...
Igor Skornyakov
11:30 AM User Interface Bug #4631: Widget scoped to wrong frame on hide
I have an update that I'd like reviewed. It correctly converted the testcase, as well as the customer procedure. Are ... Roger Borrello

06/16/2020

07:49 PM Base Language Feature #4162 (WIP): enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
Ready for test. Roger Borrello
07:46 PM User Interface Bug #4631: Widget scoped to wrong frame on hide
Should the @descent-rules@ both add the scope at the appropriate time, and include the rules that had been in place i... Roger Borrello
07:31 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Are the metrics calculated before the scaling? The thing I don't understand is that the Swing browse draws everythin... Greg Shah
06:19 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Do we have accurate metrics that differ between Swing and web?
The metrics are the same, actual text size diff...
Stanislav Lomany
10:23 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Do you have an idea what we're are doing about Graphics2D or something else that could cause this difference? Web v... Greg Shah
05:46 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Regarding the font size: I found that actually may be it's not the case that a web font is larger, it's the case that... Stanislav Lomany
07:00 PM Database Feature #3814: more schema metadata
I'm using the ChUI regression test suite. I found that with 4231b, it is now required to have a @cfg/p2j.cfg.xml@ bu... Greg Shah
04:58 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > A variation of #4011-549 with the validation:
> > [...]
> >...
Constantin Asofiei
04:42 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> A variation of #4011-549 with the validation:
> [...]
>
> The @CAN-FIND@ sees this r...
Eric Faulhaber
11:11 AM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> > issue in AnnotatedAst.iterator(), when walking from an AST with a single child. Need Greg to c...
Constantin Asofiei
10:52 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I've been considering divorcing the cache from the session object to get more advantage from...
Constantin Asofiei
08:05 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > I've seen cases where we have a select like @select tt1.*...
Eric Faulhaber
06:54 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> I've seen cases where we have a select like @select tt1.*, tt2.recid@ where @tt2@ is a s...
Constantin Asofiei
06:28 AM Database Feature #4011: database/persistence layer performance improvements
I've seen cases where we have a select like @select tt1.*, tt2.recid@ where @tt2@ is a standalone table or a composit... Constantin Asofiei
06:07 AM Database Feature #4011: database/persistence layer performance improvements
I've committed revision 11481, which minimizes the number of database savepoints being set for application sub-transa... Eric Faulhaber
12:43 AM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> > issue in AnnotatedAst.iterator(), when walking from an AST with a single child. Need Greg to c...
Eric Faulhaber
11:11 PM Database Feature #4011: database/persistence layer performance improvements
> issue in AnnotatedAst.iterator(), when walking from an AST with a single child. Need Greg to check if I'm missing ... Greg Shah
09:42 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> 4011a rev 11480 refactors SortCriterion to allow indexed properties in the sort clause. ...
Eric Faulhaber
04:43 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs
There is a common pattern in 4GL code that is used for "security". The idea is that the code will use some form of f... Greg Shah
04:34 PM Base Language Bug #4682 (Closed): modify FILE-INFO processing to honor searches for 4GL programs
Greg Shah
04:36 PM Database Feature #4681: prepared statement caching/pooling
I think we can simplify this idea a bit. I don't see the value in making a static cache. A @PreparedStatement@ instan... Eric Faulhaber
01:39 PM Database Feature #4681: prepared statement caching/pooling
My concern is related to multiple session close (they have a short life), which will invalidate the cached statements... Ovidiu Maxiniuc
12:58 PM Database Feature #4681: prepared statement caching/pooling
This issue is to discuss the implementation of @PreparedStatement@ caching/pooling as a potential performance optimiz... Eric Faulhaber
12:56 PM Database Feature #4681 (WIP): prepared statement caching/pooling
Eric Faulhaber

06/15/2020

07:23 PM Database Feature #4011: database/persistence layer performance improvements
4011a rev 11480 refactors SortCriterion to allow indexed properties in the sort clause. FQL2SQL will take care of cr... Constantin Asofiei
07:11 PM Database Feature #4011: database/persistence layer performance improvements
4011a rev 11479 adds the @AnnotatedAst.iterator()@ fix (#4011-574) and refactors rowStructure to allow for self-join. Constantin Asofiei
09:49 AM Database Feature #4011: database/persistence layer performance improvements
A variation of #4011-549 with the validation:... Constantin Asofiei
05:51 AM Database Feature #4011: database/persistence layer performance improvements
4011a rev 11475 fixes ChangeSet.ensureCapacity. Constantin Asofiei
01:03 PM Base Language Feature #4162: enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
Roger Borrello wrote:
> Is #4391 basically additional parsing in the same manner as this task?
Yes.
Greg Shah
10:54 AM Base Language Feature #4162: enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
Is #4391 basically additional parsing in the same manner as this task? Roger Borrello
10:52 AM Base Language Feature #4162: enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
Changes to support @-ininame@ are checked into *4231b-11608* (@LegacyCLI.java@). Testcases indicated there should be ... Roger Borrello
09:53 AM Base Language Feature #4162: enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
Roger Borrello wrote:
> Ovidiu, you had made changes to @ClientCore@ in 2014 to emulate the @-ininame@ command-line ...
Roger Borrello
09:53 AM Base Language Feature #4162: enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
Ovidiu, you had made changes to @ClientCore@ in 2014 to emulate the @-ininame@ command-line parameter. Is there any c... Roger Borrello
08:12 AM User Interface Bug #4631: Widget scoped to wrong frame on hide
#4208-447 starts discussion of this same bug. This should be addressed before merging 4231b to trunk.
Constantin i...
Roger Borrello
09:06 PM Base Language Feature #4384: Builtin OO Implementation
I've merged all the changes from 4384c (revisions 11569 through 11579) into 4231b revision 11606.
I've created a n...
Greg Shah

06/14/2020

11:25 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
3880a has been merged into 4231b as rev 11604. 3880a has been archived. Stanislav Lomany
10:25 AM Database Feature #4011: database/persistence layer performance improvements
> BTW, in FWD (both 4011 and trunk) only the RAQ will consult the dirty database for possible leaking record. The 4GL... Greg Shah

06/13/2020

05:53 PM Database Feature #4011: database/persistence layer performance improvements
> There's nowhere to descend, nor another sibling. When iter.hasNext() is called after the BOOL_TRUE was processed, i... Greg Shah
03:17 PM User Interface Bug #4671: Widget drag doesn't work in web
One can drag a widget once, but not for the second time.
Reproduction: drag the button, then try to drag it again.
Stanislav Lomany
03:08 PM User Interface Bug #4671 (New): Widget drag doesn't work in web
Stanislav Lomany
02:56 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Fix for web issues (web column/row resize) committed into 4231b as rev 11603.
BTW there's one more minor web issue...
Stanislav Lomany

06/12/2020

07:03 PM Database Feature #4011: database/persistence layer performance improvements
Yes, if we can evaluate static sub-expressions during conversion, we roll them up to their result and replace the sub... Eric Faulhaber
07:00 PM Database Feature #4011: database/persistence layer performance improvements
Is it possible that the WHERE node was dropped in this case? Ovidiu Maxiniuc
06:57 PM Database Feature #4011: database/persistence layer performance improvements
AFAIK, we didn't change this in 4011a. I wonder why we are hitting this now. Eric Faulhaber
06:42 PM Database Feature #4011: database/persistence layer performance improvements
There's a bug in @AnnotatedAst.iterator@ when trying to iterate starting from the @BOOL_TRUE@ child (of the @WHERE@ c... Constantin Asofiei
06:20 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > The not closed objects are most likely the reason for the me...
Constantin Asofiei
05:37 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin, I am blocked by this as well. Please commit the fix as soon as it is ready.
See...
Constantin Asofiei
05:25 PM Database Feature #4011: database/persistence layer performance improvements
Constantin, I am blocked by this as well. Please commit the fix as soon as it is ready. Eric Faulhaber
05:17 PM Database Feature #4011: database/persistence layer performance improvements
This was inspired by what I saw Hibernate was generating. The most signifiant 32 bit came naturally and will match th... Ovidiu Maxiniuc
05:02 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Or better yet, why use a hashcode for the FK? Just as a convention? This name needs to...
Eric Faulhaber
05:01 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> There's something wrong in TempTableHelper when the constraint name is computed:
> [......
Constantin Asofiei
04:45 PM Database Feature #4011: database/persistence layer performance improvements
There's something wrong in TempTableHelper when the constraint name is computed:... Constantin Asofiei
03:57 PM Database Feature #4011: database/persistence layer performance improvements
OK, I think this is what Hibernate did as well. We may come back to @PreparedStatement@ caching as a potential optimi... Eric Faulhaber
03:49 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I think we know when we are done with the statement in all cases, but do we cache @PreparedS...
Ovidiu Maxiniuc
03:47 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I think we know when we are done with the statement in all cases, but do we cache @PreparedS...
Constantin Asofiei
03:43 PM Database Feature #4011: database/persistence layer performance improvements
I think we know when we are done with the statement in all cases, but do we cache @PreparedStatement@ instances to pr... Eric Faulhaber
03:42 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> The not closed objects are most likely the reason for the memory issues. I tried to close s...
Constantin Asofiei
03:20 PM Database Feature #4011: database/persistence layer performance improvements
The not closed objects are most likely the reason for the memory issues. I tried to close some of them but it was rea... Ovidiu Maxiniuc
03:18 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> How were we handling cleanup of the Hibernate query resources?
I think Hibernate was taking...
Constantin Asofiei
03:09 PM Database Feature #4011: database/persistence layer performance improvements
@AbstractQuery@ has a @cleanup@ method, however, the use of @SQLQuery@ and even @Query@ is somewhat internal/hidden w... Eric Faulhaber
03:04 PM Database Feature #4011: database/persistence layer performance improvements
Another issue which I don't understand: the @SQLQuery@'s JDBC statement and ResultSet is never closed. Why? Who shou... Constantin Asofiei
03:02 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > I've moved to another test as the current one is blocked ...
Constantin Asofiei
09:05 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> I've moved to another test as the current one is blocked with the flush/mandatory issue....
Constantin Asofiei
08:25 AM Database Feature #4011: database/persistence layer performance improvements
I've moved to another test as the current one is blocked with the flush/mandatory issue. Now I've reached an extent ... Constantin Asofiei
08:13 PM Database Feature #4011: database/persistence layer performance improvements
Not exactly. I will add it, thanks. Eric Faulhaber
11:21 AM Base Language Feature #4162: enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
> The comments in @LegacyCLI.getStartupParameters@ indicate "Returns a character string containing a _comma-separated... Greg Shah
10:55 AM Base Language Feature #4162: enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
The comments in @LegacyCLI.getStartupParameters@ indicate "Returns a character string containing a _comma-separated_ ... Roger Borrello
11:15 AM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat
We sometimes see converted code which causes a fatal javac problem "error: too many parameters". This can happen wit... Greg Shah
03:29 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Is 4384c in a good place to merge the changes into 4231b? If it is OK, tomorrow I want to get th...
Marian Edu
08:40 PM Base Language Feature #4384: Builtin OO Implementation
Is 4384c in a good place to merge the changes into 4231b? If it is OK, tomorrow I want to get the merge done and the... Greg Shah
08:30 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Attached the patch for skeleton changes, in Eclipse and Bazaar format... this might also include...
Greg Shah

06/11/2020

07:57 PM Database Feature #4011: database/persistence layer performance improvements
Eric, do you have this case in your current flush/validation work?... Constantin Asofiei
06:37 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, the NO-UNDO issue is related to passing the temp-table as a parameter, where you e...
Eric Faulhaber
06:06 PM Database Feature #4011: database/persistence layer performance improvements
Eric, the NO-UNDO issue is related to passing the temp-table as a parameter, where you end up with two records like ... Constantin Asofiei
04:56 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> A test related to NO-UNDO temp-tables (not related to STOP, replace it with UNDO, LEAVE ...
Constantin Asofiei
03:39 PM Database Feature #4011: database/persistence layer performance improvements
A test related to NO-UNDO temp-tables (not related to STOP, replace it with UNDO, LEAVE and there is the same behavio... Constantin Asofiei
03:22 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Ovidiu, what's the difference between @FqlType.DECIMAL@ and @FqlType.DOUBLE@? How are th...
Ovidiu Maxiniuc
03:07 PM Database Feature #4011: database/persistence layer performance improvements
11467 contains the ScrollingResults fix, rollback of SqlQuery RSMD usage and another fix in FqlType. Constantin Asofiei
03:06 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Should I call @Persistence$Context.useSession@ for @Scrol...
Eric Faulhaber
02:58 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Should I call @Persistence$Context.useSession@ for @ScrollingResults@, too? I see that w...
Constantin Asofiei
02:48 PM Database Feature #4011: database/persistence layer performance improvements
I've got an infinite loop because this code:... Constantin Asofiei
12:28 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
>
> > That code already has a call for RSMD, @int columnCount =...
Constantin Asofiei
12:26 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> That code already has a call for RSMD, @int columnCount = resultSet.getMetaData().getC...
Eric Faulhaber
12:14 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > The foreign table is mapped by @MetaFile.class@ and by defau...
Constantin Asofiei
12:03 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin, we have biased as much as we can in this implementation toward speed, so we are ...
Constantin Asofiei
11:45 AM Database Feature #4011: database/persistence layer performance improvements
Constantin, we have biased as much as we can in this implementation toward speed, so we are avoiding things like @Res... Eric Faulhaber
10:33 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> The problem is the previous code assumed the SELECT was always retrieving full records. ...
Ovidiu Maxiniuc
10:24 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > 4011a rev 11465 contains my FQL fixes plus misc. Please rev...
Constantin Asofiei
09:38 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> 4011a rev 11465 contains my FQL fixes plus misc. Please review.
I have only a questi...
Ovidiu Maxiniuc
03:21 PM Base Language Feature #4162: enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
See @SessionUtils.getStartupParameters()@ and @LegacyCLI@.
We should add a specific capability for directory confi...
Greg Shah
03:07 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> > Why is the row height static? It should be calculated based on whatever is being used at...
Greg Shah
03:06 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> I mean like this. We can make a tray, but why lose a row? In this case we'll be losing a row only if there are no s... Greg Shah
03:06 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Why is the row height static? It should be calculated based on whatever is being used at the time.
Currently, t...
Stanislav Lomany
03:04 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Code Review Task Branch 3880a Revisions 11347 through 11353
1. I really like the refactoring of the TC dialog proc...
Greg Shah
02:32 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I mean like this. We can make a tray, but why lose a row? In this case we'll be losing a row only if there are no scr... Stanislav Lomany
01:38 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> > Can you see any case which this does not cover?
>
> If there is a vertical scrollbar ...
Greg Shah
01:35 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Can you see any case which this does not cover?
If there is a vertical scrollbar and NO horizontal scrollbar, we...
Stanislav Lomany
06:41 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
We will use the bottom right corner of the browse. In enhanced mode (simple boolean flag), we will always provide th... Greg Shah
06:29 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
!example.png! Stanislav Lomany
06:25 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Please show an example. Greg Shah
06:24 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Yes. Stanislav Lomany
06:21 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Is it possible to have a horizontal scrollbar without a vertical scrollbar? Greg Shah
05:58 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> * Is there always a vertical scrollbar?
It can be turned off.
> * Aren't there cases where there are row marker...
Stanislav Lomany
01:15 PM Base Language Bug #4669 (Test): Conversion error for output stream-handle - protected property.
Marian Edu
08:25 AM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Constantin Asofiei wrote:
> To determine how OE interprets the SOAP envelope, when resolving the arguments, we need ...
Marian Edu
 

Also available in: Atom