FWD » Core Development » Runtime Infrastructure

04/25/2024

04:24 AM Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent

Constantin Asofiei wrote:
> Galya, 8383a/15059 does not compile.
The notorious @gradlew all@ doesn't work, while ... Galya B

04:14 AM Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent

Galya, 8383a/15059 does not compile. Constantin Asofiei

04/23/2024

04:04 PM Feature #6692: move FWD to Java 17

Greg Shah wrote:
> > > Also, a question, since I may have missed a detail... are there changes to be made in the @cl... Tomasz Domin

02:47 PM Feature #6692: move FWD to Java 17

> > Also, a question, since I may have missed a detail... are there changes to be made in the @client.sh@ and/or @ser... Greg Shah

12:30 PM Feature #6692: move FWD to Java 17

Galya B wrote:
> We'll have to revert to cleanup, because the new mechanism of loading will have the default as part... Roger Borrello

11:47 AM Feature #6692: move FWD to Java 17

Roger Borrello wrote:
> Also, a question, since I may have missed a detail... are there changes to be made in the @c... Galya B

11:44 AM Feature #6692: move FWD to Java 17

Galya B wrote:
> But I remembered a few more places that need update. The default @"fwd-slf4j"@ in @ClientBuilderOpt... Roger Borrello

11:30 AM Feature #6692: move FWD to Java 17

It could be an option if needed later on. For now I think it's not necessary. But I remembered a few more places that... Galya B

11:23 AM Feature #6692: move FWD to Java 17

Galya B wrote:
> OK, just one last clarification: Can you override the service loader with an empty property @-Dslf4... Tomasz Domin

10:35 AM Feature #6692: move FWD to Java 17

Galya B wrote:
> OK, just one last clarification: Can you override the service loader with an empty property @-Dslf4... Galya B

10:21 AM Feature #6692: move FWD to Java 17

OK, just one last clarification: Can you override the service loader with an empty property @-Dslf4j.provider=@? Galya B

10:19 AM Feature #6692: move FWD to Java 17

Galya B wrote:
> Tomasz, can you test if the property overwrites the service loader? If it works, it should be fine.... Tomasz Domin

08:57 AM Feature #6692: move FWD to Java 17

Tomasz, can you test if the property overwrites the service loader? If it works, it should be fine.
Also, to make ... Galya B

08:48 AM Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> I've added @CentralSlf4jProvider@ as service and it seems changes to @server.sh@ are not neede... Galya B

07:27 AM Feature #6692: move FWD to Java 17

Updated the patch, I needed to put a correct name into @build.xml@ Tomasz Domin

07:03 AM Feature #6692: move FWD to Java 17

Galya B wrote:
> From https://www.slf4j.org/faq.html#changesInVersion200
> > In SLF4J 2.0.x and later, during its i... Tomasz Domin

02:15 AM Feature #6692: move FWD to Java 17

Greg Shah wrote:
> > Attached a patch to @hotel_gui@ to make slf4j2 logging work (basically following property @-Ds... Galya B

03:08 PM Feature #8651: Centralize inclusion of JS dependencies

> If there is such a case where customers want an embedded mode with a standard front-end, it makes sense to keep the... Greg Shah

02:32 AM Feature #8651: Centralize inclusion of JS dependencies

Greg Shah wrote:
> Nice analysis!
>
> I'm generally OK with the overall recommendations.
>
> > Decouple @hotel... Galya B

04/22/2024

07:23 PM Feature #8651: Centralize inclusion of JS dependencies

Nice analysis!
I'm generally OK with the overall recommendations.
> Decouple @hotel_gui@ from the server depend... Greg Shah

09:01 AM Feature #8651: Centralize inclusion of JS dependencies

There are a few places where js is used in FWD:
* On the default login page for Virtual Desktop and Embedded modes: ... Galya B

06:56 PM Feature #6692: move FWD to Java 17

> Attached a patch to @hotel_gui@ to make slf4j2 logging work (basically following property @-Dslf4j.provider=com.go... Greg Shah

04:38 PM Feature #6692: move FWD to Java 17

* Rebased to @trunk/15157@
* upgraded com.google.gwt/org.gwtproject dependencies
* reverted org.apache.pdfbox to la... Tomasz Domin

03:09 PM Feature #6692: move FWD to Java 17

Greg Shah wrote:
> The logging patch looks reasonable. Tomasz: do you have any objections? If not, this should be ... Tomasz Domin

02:31 PM Feature #6692: move FWD to Java 17

The logging patch looks reasonable. Tomasz: do you have any objections? If not, this should be committed into 6692a... Greg Shah

07:16 AM Feature #6692: move FWD to Java 17

As for the js dependencies, it seems the reporting server uses the resources from the jar, so they should stay, but a... Galya B

06:40 AM Feature #6692: move FWD to Java 17

Find attached the required changes to fix the logging dependencies and migrate slf4j implementation to version 2. Aft... Galya B

02:25 AM Feature #6692: move FWD to Java 17

I've noticed a few issues with the logging dependencies:
* @org.slf4j:jcl-over-slf4j:1.7.36@ is replaced by @org.slf... Galya B

04/19/2024

10:04 AM Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

Dependency @de.intarsys.opensource:jPod@ is used only in @ReportServlet.java@ and can be replaced by @org.apache.pdfb... Galya B

10:01 AM Bug #8656 (Test): Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

Galya B

04/18/2024

06:11 AM Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> Galya B wrote:
> > The libraries in concern in r15171 are used only by custom front-ends in t... Galya B

05:47 AM Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> Galya B wrote:
> > Greg Shah wrote:
> > > Galya: Please review 6692a revision 15171.
> >
... Galya B

05:28 AM Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Code Review Task Branch 6692a Revision 15171
>
> Although I do like managing the dependencies ... Tomasz Domin

04:53 AM Feature #6692: move FWD to Java 17

Galya B wrote:
> I think this is not related to the current upgrade to java 17. Do you mind to create a new task for... Hynek Cihlar

04:38 AM Feature #6692: move FWD to Java 17

Hynek Cihlar wrote:
> Galya B wrote:
> > Hynek Cihlar wrote:
> > > I agree with the comments from Greg and Galya. ... Galya B

04:37 AM Feature #6692: move FWD to Java 17

Galya B wrote:
> Hynek Cihlar wrote:
> > I agree with the comments from Greg and Galya. Still it makes sense to put... Hynek Cihlar

04:23 AM Feature #6692: move FWD to Java 17

Hynek Cihlar wrote:
> I agree with the comments from Greg and Galya. Still it makes sense to put the dependencies th... Galya B

04:15 AM Feature #6692: move FWD to Java 17

I agree with the comments from Greg and Galya. Still it makes sense to put the dependencies that are integral part of... Hynek Cihlar

03:28 AM Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Galya: Please review 6692a revision 15171.
@fwd_sdk.js@ is not the right place to load the lib... Galya B

04:53 AM Feature #8651: Centralize inclusion of JS dependencies

There are specific Java Script dependencies needed for FWD to run in embedded mode. If they are included in a single ... Hynek Cihlar

04:50 AM Feature #8651 (New): Centralize inclusion of JS dependencies

Hynek Cihlar

04/17/2024

05:24 PM Feature #6692: move FWD to Java 17

Galya: Please review 6692a revision 15171. Greg Shah

05:23 PM Feature #6692: move FWD to Java 17

Code Review Task Branch 6692a Revision 15171
Although I do like managing the dependencies explicitly in our JS cod... Greg Shah

03:42 PM Feature #6692: move FWD to Java 17

Roger Borrello wrote:
> Tomasz Domin wrote:
> > I work with separate images for each supported java version if you... Tomasz Domin

03:34 PM Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> I work with separate images for each supported java version if you remember thats why I neede... Roger Borrello

01:02 PM Feature #6692: move FWD to Java 17

Roger Borrello wrote:
> I have some basic questions, since this task is moving steadily towards implementation. Grea... Tomasz Domin

11:38 AM Feature #6692: move FWD to Java 17

Greg Shah wrote:
> > Do we need Docker images based off both
>
> Yes
>
> > or do we make a wholesale changeov... Roger Borrello

10:41 AM Feature #6692: move FWD to Java 17

Greg Shah wrote:
> > OpenJDK or Oracle?
>
> In the code we should not have dependencies on either one.
>
> In ... Roger Borrello

10:23 AM Feature #6692: move FWD to Java 17

> OpenJDK or Oracle?
In the code we should not have dependencies on either one.
In practive, we tend to use Ope... Greg Shah

10:11 AM Feature #6692: move FWD to Java 17

I have some basic questions, since this task is moving steadily towards implementation. Great job! These come from my... Roger Borrello

09:01 AM Feature #6692: move FWD to Java 17

Code review 6692a revision 15171. The changes look good. Hynek Cihlar

05:07 AM Feature #6692: move FWD to Java 17

Hynek Cihlar wrote:
> Greg Shah wrote:
> > Hynek: What would you estimate for the effort?
>
> I would say up to ... Tomasz Domin

02:04 PM Feature #7799: automated vulnerability scanning

A report for FWD @6692a/15172@, there should be less vulnerabilities, but in meantime a new ones has been discovered ... Tomasz Domin

04/16/2024

11:43 AM Feature #6692: move FWD to Java 17

Hynek Cihlar wrote:
> Greg Shah wrote:
> > Hynek: What would you estimate for the effort?
>
> I would say up to ... Tomasz Domin

08:06 AM Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Hynek: What would you estimate for the effort?
I would say up to two days. The JS dependencies... Hynek Cihlar

07:38 AM Feature #6692: move FWD to Java 17

Hynek: What would you estimate for the effort? Greg Shah

07:28 AM Feature #6692: move FWD to Java 17

Greg Shah wrote:
> I prefer not to leave old dependencies in the code. On the other hand, I don't want to delay thi... Tomasz Domin

02:05 AM Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Hynek: What do you think?
I like the idea of having the dependencies in @fwd_sdk.js@. Moving t... Hynek Cihlar

04/15/2024

05:47 PM Feature #6692: move FWD to Java 17

I prefer not to leave old dependencies in the code. On the other hand, I don't want to delay this branch since many ... Greg Shah

03:06 PM Feature #6692: move FWD to Java 17

Rebased 6692a to trunk/15146 and pushed 6692a/15146.
I started to work on JS updates, upgraded with webjars versio... Tomasz Domin

03:45 AM Bug #8383 (Review): Some JsonObject methods create a LOG-MANAGER record in silent

Constantin Asofiei wrote:
> Galya, some notes:
> * we need to be careful with naming FWD internal methods added to ... Galya B

04/12/2024

09:33 AM Bug #8624: Stream should detect whether it is being used from the client or the server

@Stream@ is "dual mode" and is used as a base class for @RemoteStream@ which is used from converted code on the serve... Greg Shah

08:55 AM Bug #8624: Stream should detect whether it is being used from the client or the server

@Stream.java@ is being used by both the server and the client, however some functions are OS dependent and this is no... Șerban Bursuc

08:47 AM Bug #8624 (Closed): Stream should detect whether it is being used from the client or the server

Șerban Bursuc

04/11/2024

08:47 AM Feature #6692: move FWD to Java 17

Rebased to trunk/15136, pushed into repository 6692/15156
Working on JS libraries updates.
Tomasz Domin

04/09/2024

10:26 AM Bug #8607: Incorrect parsing of URI string.

Given the investigation conducted in #8367-15, current implementation of URI parsing should be reconsidered. Eduard Soltan

10:23 AM Bug #8607 (New): Incorrect parsing of URI string.

Eduard Soltan

04/01/2024

08:02 AM Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent

Constantin Asofiei wrote:
> * in OE, SysError is used for internal errors (via ErrorManager for FWD). But, there is... Galya B

05:21 AM Bug #8383 (WIP): Some JsonObject methods create a LOG-MANAGER record in silent

Constantin Asofiei wrote:
> * in OE, SysError is used for internal errors (via ErrorManager for FWD). But, there is... Galya B

05:09 AM Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent

Galya, some notes:
* we need to be careful with naming FWD internal methods added to skeleton classes/interfaces (in... Constantin Asofiei

03/29/2024

07:42 AM Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Did you test both embedded mode and virtual desktop in Hotel GUI?
>
Yes, I did
> Did you test... Tomasz Domin

04:44 AM Feature #6692: move FWD to Java 17

It would be interesting to profile a test case with both Java 8 and Java 17 and see where the times differ. Having mo... Hynek Cihlar

03:16 AM Feature #8544: Move spawner code to JNI

The spawner executable exists as a separate deployment with the sole purpose of providing admin rights only to a stri... Galya B

02:51 AM Feature #8544 (New): Move spawner code to JNI

Galya B

03/28/2024

05:13 PM Feature #6692: move FWD to Java 17

Yes, this can be found in #8208-18. A summary for those that can't access that task:
> * Java 8 is faster than Ja... Greg Shah

04:05 PM Feature #6692: move FWD to Java 17

Guys,
Regarding possible migration I have a question. Will we have performance degradation with @Java 8 -> Java 17... Eugenie Lyzenko

03:46 PM Feature #6692: move FWD to Java 17

Did you test both embedded mode and virtual desktop in Hotel GUI?
Did you test call graph in Hotel GUI?
We need... Greg Shah

02:43 PM Feature #6692: move FWD to Java 17

Greg Shah wrote:
> I know you've been doing some amount of testing on this. As far as I know, we only have testing ... Tomasz Domin

02:07 PM Feature #6692 (Internal Test): move FWD to Java 17

I know you've been doing some amount of testing on this. As far as I know, we only have testing and any fixes that a... Greg Shah