FWD » Core Development » Runtime Infrastructure

04/15/2025

04:06 AM Feature #7080: expose all admin APIs via REST

Please create a branch and put the changes there. Thanks. Constantin Asofiei

04/14/2025

05:22 PM Feature #7080: expose all admin APIs via REST

Constantin,
Is there a branch for the changes you proposed for fixing the context issues reported in #9687 which we... Ovidiu Maxiniuc

09:17 AM Feature #9687: drop support for Java 8 and Java 11

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> * One issue I see is that the implemented methods are @doHandl... Constantin Asofiei

08:56 AM Feature #9687: drop support for Java 8 and Java 11

Constantin Asofiei wrote:
> Ovidiu, please see attached patch - test all REST-admin requests, and admin handler. It... Ovidiu Maxiniuc

06:35 AM Feature #9687: drop support for Java 8 and Java 11

Ovidiu, please see attached patch - test all REST-admin requests, and admin handler. It should work.
The point is... Constantin Asofiei

03:00 AM Feature #9687: drop support for Java 8 and Java 11

Ovidiu Maxiniuc wrote:
> Yes, that was my problem also.
> The problem now is that the @AdminRestHandler@ will att... Tomasz Domin

04/12/2025

03:45 AM Feature #9687: drop support for Java 8 and Java 11

Hynek Cihlar wrote:
> Tomasz Domin wrote:
> > That issue is caused by adding @DefaultHandler@ in sequence to Admini... Tomasz Domin

04/11/2025

06:04 PM Feature #9687: drop support for Java 8 and Java 11

Yes, that was my problem also.
Initially, I did not write code like... Ovidiu Maxiniuc

03:01 PM Feature #9687: drop support for Java 8 and Java 11

I may be completely wrong, but in Jetty, if you have multiple handlers for a path, aren't all of them called, in orde... Constantin Asofiei

12:45 PM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Ovidiu, did you try using admin app after the change ?
> Now its possible to access embedded... Ovidiu Maxiniuc

11:26 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> That issue is caused by adding @DefaultHandler@ in sequence to Administration Console applicat... Hynek Cihlar

09:54 AM Feature #9687: drop support for Java 8 and Java 11

Rebased @9687b@ to @trunk/15850@.
Migrated Ovidiu's changes, but still have issue as described in #9687-98
I guess ... Tomasz Domin

05:30 AM Feature #9687: drop support for Java 8 and Java 11

Ovidiu Maxiniuc wrote:
> Tomasz Domin wrote:
> > I've found related issue - in case @/admin@ API is enabled it is n... Tomasz Domin

04/10/2025

12:05 PM Feature #9687: drop support for Java 8 and Java 11

Hynek Cihlar wrote:
> Tomasz, some new issues.
>
> Navigating to the root path gives a page with 404 error and li... Tomasz Domin

09:25 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz: When you get the chance, please update [[p2j:JVM Requirements]] to add Java 11 and Java 17. Later, when we r... Greg Shah

08:12 AM Feature #9687: drop support for Java 8 and Java 11

Greg Shah wrote:
> What has to be fixed before we can provide this as an early release to a customer? That customer... Tomasz Domin

07:58 AM Feature #9687: drop support for Java 8 and Java 11

What has to be fixed before we can provide this as an early release to a customer? That customer needs to make Jetty... Greg Shah

07:29 AM Feature #9687: drop support for Java 8 and Java 11

Hynek Cihlar wrote:
> Tomasz, some new issues.
I am on it. Tomasz Domin

07:28 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> In order to make regression tests compile I had to make following change to @build.gradle@.
... Tomasz Domin

07:05 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz, some new issues.
Navigating to the root path gives a page with 404 error and list of contexts (admin and _... Hynek Cihlar

11:33 AM Feature #7080: expose all admin APIs via REST

Brett,
Your request is probably correct. Both _sec-auth tables were stuck as R/O. It an issue caused by a failed mer... Ovidiu Maxiniuc

10:45 AM Feature #7080: expose all admin APIs via REST

When trying to add a domain I am getting this
{
"success": false,
"errors": [
"com.goldencode.p... Brett Rexius

04/09/2025

06:46 PM Feature #7080: expose all admin APIs via REST

It is working now, I just needed to change it to the logical db name, not the physical. Thanks! Brett Rexius

06:43 PM Feature #7080: expose all admin APIs via REST

I think this is strange.
The (GET - I assume) for @https://localhost:7443/admin/security/domains/shared@ will try to... Ovidiu Maxiniuc

06:15 PM Feature #7080: expose all admin APIs via REST

When trying to list the domains I am getting this response
{
"errors": [
"Error initializing persist... Brett Rexius

12:31 PM Feature #7080: expose all admin APIs via REST

Brett Rexius wrote:
> Do you have Postman examples for /admin/security/domains?
Sure. See attached. The admin sub... Ovidiu Maxiniuc

11:51 AM Feature #7080: expose all admin APIs via REST

Do you have Postman examples for /admin/security/domains? Brett Rexius

05:59 PM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> I've found related issue - in case @/admin@ API is enabled it is not possible to get @/gui@ or... Ovidiu Maxiniuc

09:08 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> > Sorry, I don't recall what was the reason. What compilation issues do you get?
> I get it w... Hynek Cihlar

07:21 AM Feature #9687: drop support for Java 8 and Java 11

Hynek Cihlar wrote:
> Tomasz Domin wrote:
> > In order to make regression tests compile I had to make following cha... Tomasz Domin

07:14 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> In order to make regression tests compile I had to make following change to @build.gradle@.
... Hynek Cihlar

07:02 AM Feature #9687: drop support for Java 8 and Java 11

In order to make regression tests compile I had to make following change to @build.gradle@.
I am not sure why - pro... Tomasz Domin

04:34 AM Feature #9687: drop support for Java 8 and Java 11

Ovidiu Maxiniuc wrote:
> Tomasz Domin wrote:
> > I've found related issue - in case @/admin@ API is enabled it is n... Tomasz Domin

12:22 PM Feature #9851: hard code the FWD version string in the JNI code at build time

Greg Shah wrote:
> > Got it. Is there a way to find the code for @gradlew native@ ? I looked into @build.gradle@ but... Lorian Sandu

11:14 AM Feature #9851: hard code the FWD version string in the JNI code at build time

> Got it. Is there a way to find the code for @gradlew native@ ? I looked into @build.gradle@ but did not find anythi... Greg Shah

09:59 AM Feature #9851: hard code the FWD version string in the JNI code at build time

Got it. Is there a way to find the code for @gradlew native@ ? I looked into @build.gradle@ but did not find anything.
Lorian Sandu

09:48 AM Feature #9851: hard code the FWD version string in the JNI code at build time

> > In @build.gradle@ you can see we write it into code like @Version.java@.
> >
> Hmm, ok. Should this version be... Greg Shah

09:33 AM Feature #9851: hard code the FWD version string in the JNI code at build time

Greg Shah wrote:
> > How could we get the version at build time?
>
> In @build.gradle@ you can see we write it in... Lorian Sandu

09:17 AM Feature #9851: hard code the FWD version string in the JNI code at build time

> How could we get the version at build time?
In @build.gradle@ you can see we write it into code like @Version.ja... Greg Shah

08:06 AM Feature #9851: hard code the FWD version string in the JNI code at build time

Greg Shah wrote:
>
> The idea here:
>
> * At build time, we should create a static string literal in the native... Lorian Sandu

04/08/2025

07:29 PM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> I've found related issue - in case @/admin@ API is enabled it is not possible to get @/gui@ or... Ovidiu Maxiniuc

11:50 AM Feature #9687: drop support for Java 8 and Java 11

Ovidiu Maxiniuc wrote:
> Let me know if you need additional help.
Thank you, it worked.
I've found related issue -... Tomasz Domin

01:16 PM Bug #9740: Client running in batch mode stops with a crash on Windows

We can't recreate the problem here. The only theory we have is that the @p2j.dll@ is not updated with a later versio... Greg Shah

12:45 PM Bug #9740: Client running in batch mode stops with a crash on Windows

Where does this Redmine stand? It's in 'Test' status, but Kevin can still recreate this. Amy Gakopoulos

04/07/2025

01:26 PM Feature #9687: drop support for Java 8 and Java 11

Hynek Cihlar wrote:
> I would think so.
>
> See @httpConfig.addCustomizer(new SecureRequestCustomizer());@ in @Ge... Tomasz Domin

11:16 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Hynek Cihlar wrote:
> > Tomasz, with 9687a I'm getting @HTTP ERROR 400 Invalid SNI@.
> >
... Hynek Cihlar

11:05 AM Feature #9687: drop support for Java 8 and Java 11

Hynek Cihlar wrote:
> Tomasz, with 9687a I'm getting @HTTP ERROR 400 Invalid SNI@.
>
> For development (where I ... Tomasz Domin

10:54 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz, with 9687a I'm getting @HTTP ERROR 400 Invalid SNI@.
For development (where I don't care about certificat... Hynek Cihlar

09:17 AM Feature #9687: drop support for Java 8 and Java 11

Rebased to trunk/15842.
Resolved minor conflicts.
Pushed up 9687b/15866. Tomasz Domin

10:04 AM Bug #9804 (Test): improve the OpenClient remote calls

Constantin Asofiei

10:03 AM Bug #9804: improve the OpenClient remote calls

Branch 9804a was merged to trunk rev 15845 and archived. Constantin Asofiei

10:01 AM Bug #9804 (Merge Pending): improve the OpenClient remote calls

I've redone tests, I'm merging to trunk and 7156c/e now. Constantin Asofiei

08:23 AM Bug #9804: improve the OpenClient remote calls

Constantin Asofiei wrote:
> Galya, please see 9804a rev 15849 - this address the review.
>
> I've added timeout f... Galya B

08:18 AM Bug #9804: improve the OpenClient remote calls

Galya, please see 9804a rev 15849 - this address the review.
I've added timeout for the remote-side request.
Fo... Constantin Asofiei

07:04 AM Bug #9804: improve the OpenClient remote calls

Galya B wrote:
> Aren't the workers supposed to be reused by the SoapHandler and RestHandler? I mean @worker.getHelp... Constantin Asofiei

06:59 AM Bug #9804: improve the OpenClient remote calls

Constantin Asofiei wrote:
> > * What about synchronizing @LegacyServiceWorker.getHelper@ and @RemoteLegacyServiceWor... Galya B

06:41 AM Bug #9804: improve the OpenClient remote calls

Galya B wrote:
> Review of 9804a r15848:
> * Remove pasoe references in @RemoteLegacyServiceWorker@ and there seems... Constantin Asofiei

06:08 AM Bug #9804: improve the OpenClient remote calls

Review of 9804a r15848:
* Remove pasoe references in @RemoteLegacyServiceWorker@ and there seems to be one reference... Galya B

05:21 AM Bug #9804 (Review): improve the OpenClient remote calls

Rebased 9804a from trunk rev 15842 - new rev 15848.
Galya: please do a final review. Constantin Asofiei

03:32 AM Bug #9804: improve the OpenClient remote calls

Testing went well over the weekend. I only emailed Constantin this morning and forgot to update the task. Dănuț Filimon

05:33 AM Bug #9878: Java client process hangs when -verbose:class is part of jvmargs

I can replicate this in Java 11, 17, 21.
When -verbose:class is part of the client's java argumens the Java client... Hynek Cihlar

05:25 AM Bug #9878 (New): Java client process hangs when -verbose:class is part of jvmargs

Hynek Cihlar

04/04/2025

12:08 PM Feature #9687: drop support for Java 8 and Java 11

Constantin Asofiei wrote:
> I see common code like this:
> [...]
> Please add a worker method.
Thank you. I've ... Tomasz Domin

08:46 AM Feature #9687: drop support for Java 8 and Java 11

I see common code like this:... Constantin Asofiei

08:13 AM Feature #9687: drop support for Java 8 and Java 11

I've removed dependency on @commons-httpclient@ which seems not to be in use since #6692 and migrated *NoHostVerify* ... Tomasz Domin

03:19 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Hynek
> Note that 9687a is a development branch and 9687b is a branch constantly re-based to ... Hynek Cihlar

09:19 AM Support #8922: runtime infrastructure tests

Galya B wrote:
> Greg Shah wrote:
> > Galya B wrote:
> > > Should I write 4GL tests for testcases that work with o... Greg Shah

08:52 AM Support #8922: runtime infrastructure tests

Greg Shah wrote:
> +Testcases Needed+
> * [[p2j:Appserver Tests]]
> ** see #1608, #2124, #3854, #6424, #6488, #641... Marian Edu

08:23 AM Support #8922: runtime infrastructure tests

Greg Shah wrote:
> Galya B wrote:
> > Should I write 4GL tests for testcases that work with only one directory.xml ... Galya B

08:14 AM Support #8922: runtime infrastructure tests

Galya B wrote:
> Should I write 4GL tests for testcases that work with only one directory.xml that is derived from t... Greg Shah

07:59 AM Support #8922: runtime infrastructure tests

Should I write 4GL tests for testcases that work with only one directory.xml that is derived from the template? Galya B

07:50 AM Support #8922: runtime infrastructure tests

Galya B wrote:
> Where is the startup guide on how to write tests, add them to testcases and run them in Harness?
... Greg Shah

07:39 AM Support #8922: runtime infrastructure tests

Where is the startup guide on how to write tests, add them to testcases and run them in Harness? Galya B

04/03/2025

06:04 PM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Ovidiu - do you have any testing tools/scripts/configuration/curl for testing API with 9687b ?... Ovidiu Maxiniuc

04:34 PM Feature #9687: drop support for Java 8 and Java 11

Constantin Asofiei wrote:
> Tomasz, 8976a was merged to trunk, this includes changes to the REST Admin handlers. Pl... Tomasz Domin

08:53 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Galya B wrote:
> > As for the formatting according to the formatting standards the imports sh... Hynek Cihlar

07:21 AM Feature #9687: drop support for Java 8 and Java 11

Galya B wrote:
> Tomasz Domin wrote:
> > I wonder if I'd rather use something similar @super.sendError@ in there to... Tomasz Domin

04/02/2025

02:15 PM Feature #7080: expose all admin APIs via REST

h3. Changes in configuration and runtime of REST APIs
| |_{width:45%}. Before 8976a /
Trunk r15836 |_{width:45%}.... Ovidiu Maxiniuc

12:58 PM Feature #7080: expose all admin APIs via REST

Constantin Asofiei wrote:
> Eric/Greg: if testing is OK with 8976a, we need to release this before #9687, so the jet... Greg Shah

07:30 AM Feature #7080: expose all admin APIs via REST

Constantin Asofiei wrote:
> Ovidiu, I've made some minor edits to the main page.
Thank you.
> For the existing S... Ovidiu Maxiniuc

05:16 AM Feature #7080: expose all admin APIs via REST

Eric/Greg: if testing is OK with 8976a, we need to release this before #9687, so the jetty changes are applied to 897... Constantin Asofiei

03:27 AM Feature #7080: expose all admin APIs via REST

Ovidiu, I've made some minor edits to the main page.
For the existing SESSIONS and TENANT rest APIs, please create... Constantin Asofiei

12:29 PM Feature #8976 (Test): Admin REST API for interacting with tenant authentication tables

Branch 8976a was merged into trunk as rev. 15837 and archived. Ovidiu Maxiniuc

09:09 AM Feature #8976 (Merge Pending): Admin REST API for interacting with tenant authentication tables

Please merge 8976a to trunk now. Eric Faulhaber

08:54 AM Feature #8976 (Internal Test): Admin REST API for interacting with tenant authentication tables

As noted above, the 8976a branch passed the regression tests. I am confident it can be merged into trunk.
I rebased ... Ovidiu Maxiniuc

11:11 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Hynek
> I actually expected you will takeover spreadsheet webapp migration as you've made cha... Hynek Cihlar

11:05 AM Feature #9687: drop support for Java 8 and Java 11

Hynek Cihlar wrote:
> Code review of the SPREADSHEET changes in 9687a.
>
> There are two dependency declarations ... Tomasz Domin

11:00 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz, 8976a was merged to trunk, this includes changes to the REST Admin handlers. Please rebase, as we need to fi... Constantin Asofiei

08:41 AM Feature #9687: drop support for Java 8 and Java 11

Code review of the SPREADSHEET changes in 9687a.
There are two dependency declarations of @jetty-server@ in ext/sh... Hynek Cihlar

07:57 AM Feature #9687: drop support for Java 8 and Java 11

Constantin Asofiei wrote:
> * also, please rebase
Rebased to trunk/15836, created and pushed 9687b/15854, no majo... Tomasz Domin

07:09 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Galya B wrote:
> > Tomasz Domin wrote:
> > > I wonder if maybe Galya should also look at the... Galya B

06:26 AM Feature #9687: drop support for Java 8 and Java 11

Galya B wrote:
> Tomasz Domin wrote:
> > I wonder if maybe Galya should also look at the, as SSO may be impacted by... Tomasz Domin

05:50 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Saying that:
> @javax.servlet-api@ is to be removed as it is also provided by @jetty-servlet-... Constantin Asofiei

05:13 AM Feature #9687: drop support for Java 8 and Java 11

Thank you Constantin
Constantin Asofiei wrote:
> Tomasz, this is for 9687a as of rev 15783
> * @AuthFilter@ - st... Tomasz Domin

03:34 AM Feature #9687: drop support for Java 8 and Java 11

Galya B wrote:
> Tomasz Domin wrote:
> > I wonder if maybe Galya should also look at the, as SSO may be impacted by... Constantin Asofiei

03:00 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> I wonder if maybe Galya should also look at the, as SSO may be impacted by changed.
In @Vir... Galya B

02:33 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz, this is for 9687a as of rev 15783
* @AuthFilter@ - status code was changed from 401 to 404
* @TenantHandler... Constantin Asofiei

04/01/2025

04:21 PM Feature #9687: drop support for Java 8 and Java 11

Re-adding reviewers removed by accident.
Tomasz Domin

04:20 PM Feature #9687: drop support for Java 8 and Java 11

Hynek, Constatin
Please review 9687a/15768-15783
Note that:
- I was trying to minimize interface changes thus in... Tomasz Domin

10:24 AM Feature #9687 (Review): drop support for Java 8 and Java 11

Greg Shah

09:07 AM Feature #9687: drop support for Java 8 and Java 11

Greg Shah wrote:
> We will deliver it to the customer as a branch as soon as your testing is done. That customer do... Tomasz Domin

08:32 AM Feature #9687: drop support for Java 8 and Java 11

We will deliver it to the customer as a branch as soon as your testing is done. That customer does not use the sprea... Greg Shah

08:28 AM Feature #9687: drop support for Java 8 and Java 11

Greg
I am more or less done here - ready for review and for broader testing.
There is still spreadsheet handling u... Tomasz Domin

08:03 AM Feature #9687: drop support for Java 8 and Java 11

> Do we need following dependencies, first two are marked by the customer, but they are only APIs ?
You would know... Greg Shah

07:40 AM Feature #9687: drop support for Java 8 and Java 11

I've updated dependencies to what I think are latest supported versions and did initial testing of 9687a/15783 - hote... Tomasz Domin

03/31/2025

04:27 PM Feature #7080: expose all admin APIs via REST

I think it is done. Please review my changes in:
* [[p2j:Administration_REST_API|Administration of REST API]];
** [... Ovidiu Maxiniuc

08:33 AM Feature #7080: expose all admin APIs via REST

I am preparing the wiki updates. They will be ready soon. I'll let you know. Ovidiu Maxiniuc

07:39 AM Feature #7080: expose all admin APIs via REST

Ovidiu, please go through the points in #7080-108, if you haven't already. Constantin Asofiei

01:38 PM Feature #9687: drop support for Java 8 and Java 11

> should I upgrade all FWD dependencies to latest working versions as I did in #6692 ?
Yes, unless you have a reas... Greg Shah

12:00 PM Feature #9687: drop support for Java 8 and Java 11

Greg Shah wrote:
> > Should I upgrade all items marked in orange ?
>
> Yes, these are all considered a problem.
... Tomasz Domin

10:23 AM Feature #9687: drop support for Java 8 and Java 11

> Should I upgrade all items marked in orange ?
Yes, these are all considered a problem.
> There one thing I do... Greg Shah

10:15 AM Feature #9687: drop support for Java 8 and Java 11

Greg Shah wrote:
> > I also did a small upgrade of dependencies to reduce vulnerabilities. I am checking if I could ... Tomasz Domin

08:01 AM Feature #9687: drop support for Java 8 and Java 11

> I also did a small upgrade of dependencies to reduce vulnerabilities. I am checking if I could update more dependen... Greg Shah

05:16 AM Feature #9687: drop support for Java 8 and Java 11

Constantin Asofiei wrote:
> Please run @./gradlew dependencies@ and look into the dependency tree; for these two whi... Tomasz Domin

04:20 AM Feature #9687: drop support for Java 8 and Java 11

Please run @./gradlew dependencies@ and look into the dependency tree; for these two which are removed, they look to ... Constantin Asofiei

03:57 AM Feature #9687: drop support for Java 8 and Java 11

Constantin Asofiei wrote:
> Tomasz, do you have a list of library versions which have changed (or added/removed)? Co... Tomasz Domin

02:13 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz, do you have a list of library versions which have changed (or added/removed)? Compare the build/lib folder wi... Constantin Asofiei

01:37 AM Feature #9687: drop support for Java 8 and Java 11

Hynek Cihlar wrote:
> >
> > Hynek
> > I've upgraded @sheet@ webapp/project for Jetty 12, it now deploys and start... Tomasz Domin

01:28 AM Feature #9687: drop support for Java 8 and Java 11

Status report 9687a/15782:
Jetty 12 servers:
* StandardServer - *works*
* EmbeddedWebServer - *works* : Embed... Tomasz Domin

03/29/2025

08:02 PM Feature #8976: Admin REST API for interacting with tenant authentication tables

Branch 8976a passed hotel GUI tests, dockered harness smoke tests for a customer application and the unit-tests of an... Ovidiu Maxiniuc

03/28/2025

09:30 AM Bug #9804: improve the OpenClient remote calls

7156c + 8904a patch worked, I'm waiting for some testing from Danut. Constantin Asofiei

09:29 AM Bug #9804 (Internal Test): improve the OpenClient remote calls

Code Review Task branch 9804a Revisions 15816
All good. Greg Shah

06:04 AM Bug #9804: improve the OpenClient remote calls

Greg Shah wrote:
> Please add some text to the @AppServerHelper@ to that effect. Make it clear that the class is no... Constantin Asofiei

09:22 AM Feature #9851: hard code the FWD version string in the JNI code at build time

/In #6662, we inserted code to set the @FWD_VERSION@ environment variable in the environment of a child process when ... Greg Shah

09:08 AM Feature #9851 (Test): hard code the FWD version string in the JNI code at build time

Greg Shah

09:19 AM Bug #9848: Wrong agent startup time reported in logs

Please include in this task also stress-testing the appserver agent startup, i.e. launch 50-100 agents and see if the... Constantin Asofiei

04:56 AM Bug #9740: Client running in batch mode stops with a crash on Windows

This is strange.
I've tested again on my Windows machine and i don't get the crash.
This is how the client is s... Lorian Sandu

03/27/2025

04:14 PM Feature #9687: drop support for Java 8 and Java 11

Status report:
Websockets - works fine for gui client and analytics/reporting, to be checked for spreadsheet app a... Tomasz Domin

08:34 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Hynek Cihlar wrote:
> > I don't think these were added as separate tasks. They were added wit... Hynek Cihlar

08:33 AM Feature #9687: drop support for Java 8 and Java 11

Hynek Cihlar wrote:
> I don't think these were added as separate tasks. They were added with the general implementat... Tomasz Domin

02:47 PM Bug #9740: Client running in batch mode stops with a crash on Windows

I pulled code, cleaned, and refreshed my local environment yesterday morning. The time stamp on the p2j.dll files in... Kevin Baker

02:05 PM Bug #9804: improve the OpenClient remote calls

> > 2. The @AppServerHelper@ is not thread safe for some of its state. I'm especially thinking about the @disconnect... Greg Shah

09:23 AM Bug #9804: improve the OpenClient remote calls

Galya B wrote:
> In @BaseSession@ the change of @LinkedList@ to @LinkedHashSet@ requires to go over all implementati... Constantin Asofiei

09:06 AM Bug #9804: improve the OpenClient remote calls

In @BaseSession@ the change of @LinkedList@ to @LinkedHashSet@ requires to go over all implementations of @SessionLis... Galya B

04:56 AM Bug #9804: improve the OpenClient remote calls

Greg Shah wrote:
> Code Review Task branch 9804a Revisions 15812 and 15813
>
> 1. In @RemoteAppServerConnectionPo... Constantin Asofiei

10:50 AM Bug #9848: Wrong agent startup time reported in logs

At the moment, the calculation for the agent's startup time is slightly incorrect. In @AppServerLauncher.launchFirstA... Andrei Plugaru

10:02 AM Bug #9848 (New): Wrong agent startup time reported in logs

Andrei Plugaru

03/26/2025

07:37 PM Feature #7080 (Internal Test): expose all admin APIs via REST

The branch 8976a was updated and rebased to latest trunk. Current revision is 15830. Ovidiu Maxiniuc

09:38 AM Feature #7080: expose all admin APIs via REST

Ovidiu, I see that you changed SessionsRestHandler to use @DELETE:/admin/sessions/all@ instead of @DELETE:/admin/ses... Constantin Asofiei

04:59 PM Feature #9687: drop support for Java 8 and Java 11

Admin console works :) - I forgot to include it in the list above, its EE8 webapp.
Tomasz Domin

04:12 PM Feature #9687: drop support for Java 8 and Java 11

Greg Shah wrote:
> Do you anticipate any need for the customer to run conversion with this branch (assuming they hav... Tomasz Domin

03:38 PM Feature #9687: drop support for Java 8 and Java 11

Do you anticipate any need for the customer to run conversion with this branch (assuming they have already run conver... Greg Shah

12:17 PM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Tomasz Domin wrote:
> I've updated reporting server for a new Jetty12 WebSockets semantics. I... Tomasz Domin

09:18 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Initial testing report as for today:
>
> Websockets - works fine
>
> Servers:
> * Repor... Tomasz Domin

09:03 AM Feature #9687: drop support for Java 8 and Java 11

Hynek Cihlar wrote:
> Tomasz, do you have any pending changes not checked in? I need to do some Spreadsheet performa... Tomasz Domin

09:00 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Greg
> What about support for modules #9626 ? I guess this can be added here as well ? Or is ... Greg Shah

08:43 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz, do you have any pending changes not checked in? I need to do some Spreadsheet performance tests for #9828 wit... Hynek Cihlar

03:20 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Once I am done with initial testing I will ask for support regarding integration testing for s... Tomasz Domin

01:59 AM Feature #9687: drop support for Java 8 and Java 11

Greg
What about support for modules #9626 ? I guess this can be added here as well ? Or is it a next step ? Tomasz Domin

01:57 AM Feature #9687: drop support for Java 8 and Java 11

Initial testing report as for today:
Websockets - works fine
Servers:
* EmbeddedWebServer - works fine
* Repo... Tomasz Domin

04:12 PM Bug #9740: Client running in batch mode stops with a crash on Windows

Kevin, please double-check that you are not using an old p2j.dll. Constantin Asofiei

04:03 PM Bug #9740: Client running in batch mode stops with a crash on Windows

It has the same stack trace (and failure) as the original report:... Greg Shah

03:45 PM Bug #9740: Client running in batch mode stops with a crash on Windows

Testing with version 15801.
Testing reports has shown that the following error message is written to the rptrun_st... Kevin Baker

03:34 PM Bug #9804: improve the OpenClient remote calls

Code Review Task branch 9804a Revisions 15812 and 15813
1. In @RemoteAppServerConnectionPool.dispatch()@ the javad... Greg Shah

11:28 AM Bug #9804: improve the OpenClient remote calls

Greg, please review, too. Constantin Asofiei

03/25/2025

03:25 PM Feature #7080: expose all admin APIs via REST

Ovidiu Maxiniuc wrote:
> > Have you configured @WebServiceResource@ resource in @directory.xml@, under @resource-plu... Constantin Asofiei

02:25 PM Feature #7080: expose all admin APIs via REST

Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> You have @src/com/goldencode/p2j/security/WebServiceResource.j... Ovidiu Maxiniuc

01:59 PM Feature #7080: expose all admin APIs via REST

Ovidiu Maxiniuc wrote:
> > * @AdminRestHandler@: @authHandler = new WebAuthHandler("admin", "basic", "/admin/login",... Constantin Asofiei

01:52 PM Feature #7080: expose all admin APIs via REST

Constantin Asofiei wrote:
> Review of 8976a rev 15810:
> * please run javadoc with Java 8 and fix any issues in you... Ovidiu Maxiniuc

10:52 AM Feature #7080: expose all admin APIs via REST

Constantin Asofiei wrote:
> I have not given an in-depth look at the persistent changes
Code review 8976a/15809-1... Eric Faulhaber

09:34 AM Feature #7080: expose all admin APIs via REST

Review of 8976a rev 15810:
* please run javadoc with Java 8 and fix any issues in your files, if you haven't already... Constantin Asofiei

09:33 AM Feature #8976: Admin REST API for interacting with tenant authentication tables

Moved review to #7080 Constantin Asofiei

05:40 AM Feature #8976: Admin REST API for interacting with tenant authentication tables

Ovidiu, I see that 8976a has latest changes discussed in #7080. Please make sure the code compiles with Java 8, I wa... Constantin Asofiei

09:15 AM Bug #9804: improve the OpenClient remote calls

Galya: when you have time, please review. Constantin Asofiei

03:09 AM Feature #9687: drop support for Java 8 and Java 11

Regarding Jetty upgrade to version 12 there are three main types of Jetty services to upgrade:
- Jetty HTTP Handlers... Tomasz Domin

03/24/2025

11:47 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> E.g. FWD API is making use of @javax.http.*@ classes in @SsoAuthenticator@, so it relies on lo... Tomasz Domin

09:08 AM Feature #9687: drop support for Java 8 and Java 11

Note there are due to migration there will FWD API changes, which I am not sure what to do with.
E.g. FWD API is mak... Tomasz Domin

11:01 AM Support #9514: assess, recommend and document monitoring tools plan

Some recent observations for using *jstack* in a container. Some settings have to be passed to docker upon building t... Roger Borrello

10:51 AM Feature #7080: expose all admin APIs via REST

Greg Shah wrote:
> Galya B wrote:
> > Greg Shah wrote:
> > > > As for the real value of automation... I don't want... Galya B

10:42 AM Feature #7080: expose all admin APIs via REST

Greg Shah wrote:
> Galya B wrote:
> > I think in FWD we have this notion that automation is not necessarily running... Galya B

10:39 AM Feature #7080: expose all admin APIs via REST

Greg Shah wrote:
> >> The API is defined at development time, not at runtime. You don't need to dynamically generate... Galya B

10:32 AM Feature #7080: expose all admin APIs via REST

>> The API is defined at development time, not at runtime. You don't need to dynamically generate it on a production ... Greg Shah

10:28 AM Feature #7080: expose all admin APIs via REST

Galya B wrote:
> Greg Shah wrote:
> > > As for the real value of automation... I don't want to get there.
> >
> ... Greg Shah

10:13 AM Feature #7080: expose all admin APIs via REST

Greg Shah wrote:
> Banks don't build platforms, they build applications. FWD is not an application, it is a platfor... Galya B

10:06 AM Feature #7080: expose all admin APIs via REST

Greg Shah wrote:
> > > * JSON or Annotations
> > > ** It seems that we can either define the API in JSON and then g... Galya B

09:54 AM Feature #7080: expose all admin APIs via REST

Greg Shah wrote:
> > As for the real value of automation... I don't want to get there.
>
> I never said that. Th... Galya B

09:53 AM Feature #7080: expose all admin APIs via REST

Constantin Asofiei wrote:
> Greg: before committing to use Swagger and Jersey, I'd like to have a simple POC to chec... Greg Shah

09:53 AM Feature #7080: expose all admin APIs via REST

> As for the real value of automation... I don't want to get there.
I never said that. This has nothing to do wit... Greg Shah

09:52 AM Feature #7080: expose all admin APIs via REST

> > * JSON or Annotations
> > ** It seems that we can either define the API in JSON and then generate Java stubs for... Greg Shah

09:33 AM Feature #7080: expose all admin APIs via REST

Greg Shah wrote:
> The issue is that running extra code to dynamically generate and expose the API increases the att... Galya B

09:20 AM Feature #7080: expose all admin APIs via REST

Greg Shah wrote:
> * JSON or Annotations
> ** It seems that we can either define the API in JSON and then generate ... Galya B

09:05 AM Feature #7080: expose all admin APIs via REST

Ovidiu: I like the way your work is moving. The design in #7080-80 is good.
Constantin: We should go ahead with a c... Greg Shah

07:54 AM Feature #7080: expose all admin APIs via REST

Greg: before committing to use Swagger and Jersey, I'd like to have a simple POC to check how it integrates with FWD. Constantin Asofiei

07:35 AM Feature #7080: expose all admin APIs via REST

If the customers don't want to develop tools (API clients), they can have the auto-generated always up-to-date web cl... Galya B

07:32 AM Feature #7080: expose all admin APIs via REST

Galya B wrote:
> In any case it's a matter of configuration.
https://anirtek.github.io/java/jetty/swagger/openapi... Galya B

07:13 AM Feature #7080: expose all admin APIs via REST

Here is a full list of the supported server stubs, client SDKs and doc types it can generate: "swagger-codegen":https... Galya B

07:02 AM Feature #7080: expose all admin APIs via REST

Constantin Asofiei wrote:
> How does Swagger generate the server stubs? With annotations?
The api is declared in ya... Galya B

06:43 AM Feature #7080: expose all admin APIs via REST

Galya B wrote:
> Greg Shah wrote:
> > Yes, we can consider Swagger.
>
> Constantin, does #7080-80 mean we're not... Constantin Asofiei

06:40 AM Feature #7080: expose all admin APIs via REST

Greg Shah wrote:
> Yes, we can consider Swagger.
Constantin, does #7080-80 mean we're not considering Swagger for... Galya B

03:57 AM Bug #9804 (Review): improve the OpenClient remote calls

9804a rev 15813 has:
* Improvements for remote FWD OpenClient connections: ensure that the remote side uses a single... Constantin Asofiei

03/21/2025

05:57 PM Feature #7080 (Review): expose all admin APIs via REST

The changes in 8976a / 15810:
* created @BaseAdminRestHandler@ as base @abstract@ class for all REST handlers:
** w... Ovidiu Maxiniuc

05:22 PM Feature #7080 (WIP): expose all admin APIs via REST

I committed the changes to 8976a / 15810. Ovidiu Maxiniuc

04:04 PM Bug #9804: improve the OpenClient remote calls

Otoh, I don't think we want to reserve dispatcher threads for all apps, even if they don't use remote openclient. Constantin Asofiei

03:49 PM Bug #9804: improve the OpenClient remote calls

Greg Shah wrote:
> Perhaps we should have a safer way to set the number of dispatcher threads. For example, doesn't... Constantin Asofiei

03:44 PM Bug #9804: improve the OpenClient remote calls

Greg Shah wrote:
> > Greg: why is BaseSession.listeners a LinkedList instead of a HashSet? Are the listeners depende... Constantin Asofiei

03:25 PM Bug #9804: improve the OpenClient remote calls

Constantin Asofiei wrote:
> * with its size limited to 80% of the number of Dispatcher threads
>
> I think we nee... Greg Shah

03:22 PM Bug #9804: improve the OpenClient remote calls

> Greg: why is BaseSession.listeners a LinkedList instead of a HashSet? Are the listeners dependent on when their ord... Greg Shah

02:16 PM Bug #9804: improve the OpenClient remote calls

Created task branch 9804a from trunk rev 15811.
In rev 15812, is the initial pass; it includes, on the remote FWD Op... Constantin Asofiei

06:33 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Hynek Cihlar wrote:
> > Tomasz Domin wrote:
> > > Hynek
> > > I have problems porting @Spre... Hynek Cihlar

05:00 AM Feature #9687: drop support for Java 8 and Java 11

Hynek Cihlar wrote:
> Tomasz Domin wrote:
> > Hynek
> > I have problems porting @SpreadsheetWebApp@ from Jetty 9 ... Tomasz Domin

04:40 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Hynek
> I have problems porting @SpreadsheetWebApp@ from Jetty 9 to Jetty 12, as some kind o... Hynek Cihlar

03:20 AM Feature #9687: drop support for Java 8 and Java 11

Hynek
I have problems porting @SpreadsheetWebApp@ from Jetty 9 to Jetty 12, as some kind of internal API was used (... Tomasz Domin

03/20/2025

09:30 AM Bug #9804 (WIP): improve the OpenClient remote calls

Constantin Asofiei

03:19 AM Feature #7080: expose all admin APIs via REST

Greg Shah wrote:
> The only difference is that I think we need to move away from basic auth and design a more approp... Galya B

03/19/2025

04:23 PM Feature #7080: expose all admin APIs via REST

Constantin Asofiei wrote:
> The point is: I see real usage in getting the full details 'up front', and not having to... Ovidiu Maxiniuc

02:23 PM Feature #7080: expose all admin APIs via REST

Ovidiu Maxiniuc wrote:
> #** the @/admin/tenants@ and @/admin/sessions@ should return only the list of resources, no... Constantin Asofiei

02:14 PM Feature #7080: expose all admin APIs via REST

I agree with these ideas.
The only difference is that I think we need to move away from basic auth and design a mo... Greg Shah

01:59 PM Feature #7080: expose all admin APIs via REST

Constantin and I have a discussion on meet and we reach the following conclusions (summarised):
# instead a having... Ovidiu Maxiniuc

01:14 PM Feature #7080: expose all admin APIs via REST

> A question I have is do we expect the framework to ever expose endpoints that are not @/admin@, because to me every... Greg Shah

01:13 PM Feature #7080: expose all admin APIs via REST

I'm not opposed to an explicit versioning in the URL, but this also would suggest that the older versions would be su... Greg Shah

09:46 AM Feature #7080: expose all admin APIs via REST

Versioning is introduced when the team is on the same page about the definition of backwards compatibility. Breaking ... Galya B

09:34 AM Feature #7080: expose all admin APIs via REST

Idea discussed in the daily meeting today:
* As this task is also about (re-)designing the REST API to expose the ... Alexandru Lungu

03/18/2025

11:18 AM Bug #9804: improve the OpenClient remote calls

The remote OpenClient calls are managed in FWD via the @RemoteLegacyJavaAppserverClient@ class, created via @LegacyJa... Constantin Asofiei

10:42 AM Bug #9804 (Test): improve the OpenClient remote calls

Constantin Asofiei

05:39 AM Feature #9687: drop support for Java 8 and Java 11

Constantin Asofiei wrote:
> Tomasz Domin wrote:
> > See : https://javadoc.jetty.org/jetty-12/org/eclipse/jetty/serv... Tomasz Domin

03:47 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> See : https://javadoc.jetty.org/jetty-12/org/eclipse/jetty/server/Request.Handler.html#handle(... Constantin Asofiei

05:19 AM Bug #9740 (Test): Client running in batch mode stops with a crash on Windows

@9740a@ was merged into @trunk / rev 15787@ Lorian Sandu

03/17/2025

06:13 PM Feature #9687: drop support for Java 8 and Java 11

Constantin Asofiei wrote:
> Tomasz Domin wrote:
> > In order to minimize changes I've stayed with @AbstractHandler@... Tomasz Domin

08:12 AM Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> In order to minimize changes I've stayed with @AbstractHandler@ despite its deprecated, as mov... Constantin Asofiei

08:01 AM Feature #9687: drop support for Java 8 and Java 11

Constantin: Please comment on this plan. Do we need to shift to the asynch approach? Greg Shah

03:52 AM Feature #9687: drop support for Java 8 and Java 11

I've started work on porting services to Jetty 12 API. There are differences requiring attention, it will take me 2-3... Tomasz Domin

12:02 PM Bug #9740 (Merge Pending): Client running in batch mode stops with a crash on Windows

Please merge after 9543a. Greg Shah

11:08 AM Bug #9740: Client running in batch mode stops with a crash on Windows

Greg Shah wrote:
> Yes. There are other "interactive" mechanisms that are the equivalent to @OS-COMMAND@: @DOS@ and... Lorian Sandu

11:00 AM Bug #9740: Client running in batch mode stops with a crash on Windows

Lorian Sandu wrote:
> Greg Shah wrote:
> > Code Review Task Branch 9740a Revision 15781
> >
> > The change is go... Greg Shah

10:27 AM Bug #9740: Client running in batch mode stops with a crash on Windows

Greg Shah wrote:
> Code Review Task Branch 9740a Revision 15781
>
> The change is good.
>
> Please confirm tha... Lorian Sandu

10:25 AM Bug #9740 (Internal Test): Client running in batch mode stops with a crash on Windows

Code Review Task Branch 9740a Revision 15781
The change is good.
Please confirm that Windows process launching,... Greg Shah

09:46 AM Bug #9740: Client running in batch mode stops with a crash on Windows

Greg Shah wrote:
> I think there is a latent bug here: the @isSuspended = 0;@ that is done *after* the @generateExce... Lorian Sandu

09:38 AM Bug #9740: Client running in batch mode stops with a crash on Windows

Code Review Task Branch 9740a Revision 15780
The change is good.
I think there is a latent bug here: the @isSus... Greg Shah

09:25 AM Bug #9740 (Review): Client running in batch mode stops with a crash on Windows

Please review. Lorian Sandu

09:25 AM Bug #9740 (WIP): Client running in batch mode stops with a crash on Windows

Greg Shah wrote:
> Good point. OK, move ahead with the @if (isSuspended)@ addition on Windows.
Committed to @974... Lorian Sandu

09:03 AM Bug #9740: Client running in batch mode stops with a crash on Windows

Good point. OK, move ahead with the @if (isSuspended)@ addition on Windows. Greg Shah

08:54 AM Bug #9740: Client running in batch mode stops with a crash on Windows

Greg Shah wrote:
> In the testcase from #9740-10, what happens if the 2nd command runs longer than the 3rd command?
... Lorian Sandu

08:50 AM Bug #9740: Client running in batch mode stops with a crash on Windows

In the testcase from #9740-10, what happens if the 2nd command runs longer than the 3rd command?
Greg Shah

07:35 AM Bug #9740: Client running in batch mode stops with a crash on Windows

Greg Shah wrote:
> Please check that the code @client.suspend(silent);@ on line 276 of @ProcessDaemon@ is executed m... Lorian Sandu