FWD

06/12/2015

06:30 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Fixed EDITOR regression, fixed all issues mentioned in the code review except the FRAME realization (only @VIEW@ and ... Igor Skornyakov

05:13 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Regarding the previous question. Is it OK to add a separate method @setInititialInnerLines()@ for use in compilation ... Igor Skornyakov

04:43 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

I have a problem. P2J compiles
DEFINE VARIABLE sl AS CHARACTER NO-UNDO
VIEW-AS SELECTION-LIST
INNER-LINES ... Igor Skornyakov

09:25 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> Please set it to M12.
Done. Igor Skornyakov

09:23 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Please set it to M12. Greg Shah

09:22 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> You can add watchers later, using the "Watchers (x)" section at the right side-bar of the task pa... Igor Skornyakov

09:19 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

> BTW: I've created another task #2582 as per Constantin request but forgot to add watches at the creation and I do n... Greg Shah

09:09 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> No. Please create a new task in the UI project and set its target version to M12. Also add me a... Igor Skornyakov

08:52 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

> Should I fix this bug in the scope of this task?
No. Please create a new task in the UI project and set its ta... Greg Shah

06:06 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

With P2L FillInWidget.getScreenValue() returns blank if the first read access was when the focus was in the different... Igor Skornyakov

03:41 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> Besides the items requested from the code review, what else still needs to be done for this task?... Igor Skornyakov

04:45 PM User Interface Feature #2563: implement GUI EDITOR widget

>Eugenie, new question: are you sure the button's DEFAULT attribute needs to be checked in @FrameGuiImpl.processDefau... Eugenie Lyzenko

04:09 PM User Interface Feature #2563: implement GUI EDITOR widget

Eugenie, new question: are you sure the button's DEFAULT attribute needs to be checked in @FrameGuiImpl.processDefaul... Constantin Asofiei

04:32 PM User Interface Feature #2252: implement GUI client support

The attached implements ALERT-BOX widget in Swing GUI. As related changes it also adds support for modal windows and ... Hynek Cihlar

09:04 AM User Interface Bug #2586: FillInWidget.getScreenValue() incorretly returns blank

Another minor issue with the @FillInWidget.getScreenValue()@
If you run p2j conversion of this test and type a space... Igor Skornyakov

08:56 AM User Interface Bug #2586: FillInWidget.getScreenValue() incorretly returns blank

ith P2L FillInWidget.getScreenValue() returns blank if the first read access was when the focus was in the different ... Igor Skornyakov

08:55 AM User Interface Bug #2586 (New): FillInWidget.getScreenValue() incorretly returns blank

Igor Skornyakov

06:05 AM User Interface Feature #2546: implement combo-box widget in GUI

Eugenie, first of all, see note 77 and the testcase at this note - the drop-down's coordinates are still incorrect. ... Constantin Asofiei

08:51 PM User Interface Feature #2546: implement combo-box widget in GUI

>That will be a memory leak. Static widgets shouldn't last for the application lifetime. They should only live while ... Eugenie Lyzenko

03:25 AM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> I can check this field @WindowGuiImpl.mousePressedSource@ in @MenuItemGuiImpl.mouseMoved()@ to... Constantin Asofiei

06/11/2015

05:49 PM User Interface Feature #2546: implement combo-box widget in GUI

That will be a memory leak. Static widgets shouldn't last for the application lifetime. They should only live while ... Greg Shah

05:37 PM User Interface Feature #2546: implement combo-box widget in GUI

>My only question is about @WidgetRegistry.addContainer()@. How do those registered widgets get removed when they are... Eugenie Lyzenko

02:36 PM User Interface Feature #2546: implement combo-box widget in GUI

Code Review evl_upd20150610a.zip
I think this is very good. I especially like the new @EntryFieldGuiImpl@.
My ... Greg Shah

09:19 PM User Interface Feature #2546: implement combo-box widget in GUI

Some samples to illustrate @SIMPLE@ mode of the combo-box. Eugenie Lyzenko

08:56 PM User Interface Feature #2546: implement combo-box widget in GUI

The next update for review has the good shape combo-box implementation with all three modes available. Key and mouse ... Eugenie Lyzenko

05:33 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Besides the items requested from the code review, what else still needs to be done for this task? Greg Shah

01:13 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> I think it is realized the first time it is made visible. @ENABLE@ is just one way to make the... Igor Skornyakov

01:11 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

>> 3. Should GenericFrame.validateLayout() be called whenever the frame is realized (not just during ENABLE)?
>
> S... Greg Shah

11:23 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> Code Review ias_upd20150605a.zip
> 3. Should @GenericFrame.validateLayout()@ be called wheneve... Igor Skornyakov

10:29 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Code Review ias_upd20150605a.zip
1. I think we may want to implement a method in @GenericWidget@ for the core vali... Greg Shah

03:34 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> OK, the plan:
>
> 1. You can keep the @DISABLE-AUTO-ZAP@ support in the config and server-side... Igor Skornyakov

01:58 PM Database Bug #2488: replace runtime compilation of dynamic queries

Please commit and distribute 0611a. Thanks. Eric Faulhaber

01:48 PM Database Bug #2488: replace runtime compilation of dynamic queries

The attached update is basically the same as 0610a except for the comment form @build.xml@ removed and a cascading @i... Ovidiu Maxiniuc

12:28 PM Database Bug #2488: replace runtime compilation of dynamic queries

I tested the 0610a update with the full set of search unit tests. I can confirm that it fixed the problematic test an... Eric Faulhaber

01:46 AM Database Bug #2488: replace runtime compilation of dynamic queries

Code review 0610a:
Looks good. Assuming your local testing confirms it fixes the problem, please run conversion re... Eric Faulhaber

01:41 PM Database Bug #2552 (Closed): bad hql caching prevents queries to position on the correct rows

Eric Faulhaber

01:40 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows

The 0608c update passed the regression testing, was committed to bzr as revno 10876 and distributed by mail. Ovidiu Maxiniuc

09:31 AM User Interface Feature #2422: add features to BROWSE

Yes, you should go ahead and implement it. Inserting before the first or after the last seems like something that is... Greg Shah

09:21 AM User Interface Feature #2422: add features to BROWSE

> I would like you to please get the current update through regression testing and checked in. This will free up oth... Stanislav Lomany

09:04 AM User Interface Feature #2422: add features to BROWSE

I would like you to please get the current update through regression testing and checked in. This will free up other... Greg Shah

07:12 AM User Interface Feature #2422: add features to BROWSE

> What else is open in this task?
My checklist:
# Page up/down, home/end doesn't work in editable browse.
# Unin... Stanislav Lomany

02:35 AM User Interface Feature #1790: implement menu support

I'm trying to implement the following behavior. Assume we have menubar. Mouse pointer is located somewhere outside of... Vadim Gindin

06/10/2015

06:13 PM User Interface Feature #2422: add features to BROWSE

> AUTO-ZAP and CURSOR-OFFSET are done
OK.
> except separate task #2576. Let me know if I should work on this t... Greg Shah

12:11 PM User Interface Feature #2422: add features to BROWSE

> In regard to this comment @// Oddly enough, 4GL returns zap state of the FOCUSED fill-in, not necessarily this one@... Stanislav Lomany

11:36 AM User Interface Feature #2422: add features to BROWSE

> When do you expect to have everything 100% complete? Igor's work in #2534 is dependent upon your changes for @AUTO... Stanislav Lomany

10:49 AM User Interface Feature #2422: add features to BROWSE

Code Review svl_upd20150610a.zip
In regard to this comment @// Oddly enough, 4GL returns zap state of the FOCUSED ... Greg Shah

04:52 AM User Interface Feature #2422: add features to BROWSE

Removed excess function @isNewRow@ from the previous update. Stanislav Lomany

06:12 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

OK, the plan:
1. You can keep the @DISABLE-AUTO-ZAP@ support in the config and server-side getters/setters of your... Greg Shah

12:02 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Actually I suggest to retain a DISABLE-AUTO-ZAP support in the config and at the server-side (getters/setters).
Gr... Igor Skornyakov

11:48 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> Not for FILL-IN. But COMBO-BOX support is not part of Stanislav's work.
>
For the COMBO-BOX t... Igor Skornyakov

11:32 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

> Do you think that it makes sense for me to continue working on the AUTO-ZAP?
Not for FILL-IN. But COMBO-BOX sup... Greg Shah

11:19 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg,
As I can see my changes for the FillIn significantly intersect with ones of Stanislav. My first impression is ... Igor Skornyakov

10:44 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> Stanislav has also implemented @CURSOR-OFFSET@ for @FillIn@ in #2422.
Thank you Greg. Igor Skornyakov

10:42 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Stanislav has also implemented @CURSOR-OFFSET@ for @FillIn@ in #2422. Greg Shah

10:36 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Please look at Stanislav's most recent changes in #2422. He is making changes related to @AUTO-ZAP@ in @FillIn@. Sp... Greg Shah

02:53 PM User Interface Feature #1790: implement menu support

> I've found that such fields are exist not in config classes
They would only be put into config classes if the da... Greg Shah

12:01 PM User Interface Feature #1790: implement menu support

I've found that such fields are exist not in config classes, but in GUI widget classes itself. For example @ButtonGui... Vadim Gindin

11:56 AM User Interface Feature #1790: implement menu support

The question about widget (menu-item or sub-menu) state, that could be changed by mouse events: "mouse enter" (mouse ... Vadim Gindin

01:55 PM Database Bug #2488: replace runtime compilation of dynamic queries

I have a fix for the issue. There are 3 important changes:
# the @convert/variable_references.rules@ was added to ru... Ovidiu Maxiniuc

08:26 PM User Interface Feature #2546: implement combo-box widget in GUI

The next update for review has suggested approach for SIMPLE mode implementation. The idea is a bit different that us... Eugenie Lyzenko

06/09/2015

03:52 PM Database Bug #2488: replace runtime compilation of dynamic queries

The P4GL converted query is:... Ovidiu Maxiniuc

03:19 PM Database Bug #2488: replace runtime compilation of dynamic queries

I was able to duplicate the issue. One occurrence is in @test[Entity=|+TNCY_TENANT| TestType=|SEARCH| TestSubType=|SE... Ovidiu Maxiniuc

01:04 PM Database Bug #2536: improve dynamic query parser error handling

The logging level for exceptions was lowered to @FINE@ to keep the @CONFIG@ level free for configuration issues.
Th... Ovidiu Maxiniuc

10:01 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows

Eric Faulhaber wrote:
> I'll test this update tonight against the full set of search unit tests.
The test went well... Eric Faulhaber

06/08/2015

06:23 PM User Interface Bug #2582: Some key labels are not supported by p2j

The attached is the updated @key_code_report.p@ program which outputs additional key labels and its output. Igor Skornyakov

07:57 AM User Interface Bug #2582: Some key labels are not supported by p2j

P2J doesn't support some valid key labels (such as @CTRL-ALT-A@). The 4GL documentation contains misprints and is not... Igor Skornyakov

07:50 AM User Interface Bug #2582 (New): Some key labels are not supported by p2j

Igor Skornyakov

05:11 PM User Interface Feature #2422: add features to BROWSE

Update for review. INSERT-ROW, CURSOR-OFFSET, AUTO-ZAP and CURRENT-ROW-MODIFIED. Stanislav Lomany

02:55 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows

Code review 0608c:
I think the changes are OK. Please post your regression test results when finished. I'll test t... Eric Faulhaber

12:53 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows

This update should handle the main issue of this task: the caching of the hql-s. It will put into cache only the quer... Ovidiu Maxiniuc

02:22 PM Database Bug #2488: replace runtime compilation of dynamic queries

Please investigate the following error from the P2J server.log:... Eric Faulhaber

10:53 AM Base Language Bug #2578 (Closed): incorrect promotion of local defined variables

Nice work, Ovidiu. Eric Faulhaber

10:48 AM Base Language Bug #2578: incorrect promotion of local defined variables

The update passed the regression testing, was committed to bzr as revno 10874 and it was distributed by mail. Ovidiu Maxiniuc

04:27 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Constantin Asofiei wrote:
> Is this something you need for the current task? If not, please create another task unde... Igor Skornyakov

04:25 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor Skornyakov wrote:
> > > @Keyboard.keyCode(event)@ retu... Constantin Asofiei

03:31 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > @Keyboard.keyCode(event)@ returns -1 for some valid key labe... Igor Skornyakov

01:59 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> @Keyboard.keyCode(event)@ returns -1 for some valid key labels (such as @CTRL-ALT-X@). As a... Constantin Asofiei

06/07/2015

11:32 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

I think I understand what's up. Some keycodes in 4GL have different labels and @keylabel@ function returns only one o... Igor Skornyakov

11:07 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> We have something like that already, see @testcases/uast/keyboards/key_code_report.p@
>
> We d... Igor Skornyakov

10:57 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

We have something like that already, see @testcases/uast/keyboards/key_code_report.p@
We did use that (and some ot... Greg Shah

10:49 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> Please post the list of which key labels you have found which are wrong. For each one, please al... Igor Skornyakov

09:49 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Please post the list of which key labels you have found which are wrong. For each one, please also post the key code... Greg Shah

05:48 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

@Keyboard.keyCode(event)@ returns -1 for some valid key labels (such as @CTRL-ALT-X@). As a result (?) the trigger @O... Igor Skornyakov

06/06/2015

12:21 PM Base Language Bug #2578: incorrect promotion of local defined variables

Update 0605a did well with the full group of search unit tests. Eric Faulhaber

06/05/2015

04:28 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Let fi be a FILL-IN widget. According to my tests the AUTO-ZAP and DISABLE-AUTO-ZAP attributes' behavior is as descri... Igor Skornyakov

12:25 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> For now, just put a very clear TODO into the code at that point. The bug is obscure and hopefu... Igor Skornyakov

12:17 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

> At this moment the only way to fix it I can see is to make all descendants of the BaseDataType to be childs of the ... Greg Shah

11:54 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Another solution to the above mentioned issue is to use static immutable constant @BaseDataType.unknown@ (of type Bas... Igor Skornyakov

11:49 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

I've just realized the following. If we assign a value to an attribute via widget handle then 'unknown' literal @?@ i... Igor Skornyakov

09:46 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Please review the current version of the code.
NUM-ITEMS runtime support (combo-box and selection-list)
INNER-LIN... Igor Skornyakov

03:15 PM Database Feature #2581: improve performance of non-preselect, multi-table joins

Currently, when we convert (statically or at runtime) constructs like FOR EACH, EACH, ... or FOR EACH, FIRST, ..., et... Eric Faulhaber

02:58 PM Database Feature #2581 (Closed): improve performance of non-preselect, multi-table joins

Eric Faulhaber

03:03 PM User Interface Feature #2546: implement combo-box widget in GUI

Eugenie Lyzenko wrote:
> >Please use the -Dwidgetbrowser=yes when starting the GUI client to bring up the widget bro... Constantin Asofiei

12:28 PM User Interface Feature #2546: implement combo-box widget in GUI

>Please use the -Dwidgetbrowser=yes when starting the GUI client to bring up the widget browser and see where everyth... Eugenie Lyzenko

12:08 PM User Interface Feature #2546: implement combo-box widget in GUI

>Eugenie: actually I do think this is the time to separate this functionality. As Constantin notes, this is likely to... Eugenie Lyzenko

11:51 AM User Interface Feature #2546: implement combo-box widget in GUI

>> if (inFocus != null && !isChui() && inFocus instanceof ScrollableList &&
>> evt.getEvent().ge... Eugenie Lyzenko

10:43 AM User Interface Feature #2546: implement combo-box widget in GUI

>> ComboBoxGuiImpl and FillInGuiImpl: can you think of a way to sub-class the FillInGuiImpl so that the combo-box rel... Greg Shah

09:28 AM User Interface Feature #2546: implement combo-box widget in GUI

Eugenie Lyzenko wrote:
> >ComboBoxGuiImpl and FillInGuiImpl: can you think of a way to sub-class the FillInGuiImpl s... Constantin Asofiei

09:24 AM User Interface Feature #2546: implement combo-box widget in GUI

Eugenie Lyzenko wrote:
> >the ThinClient change related to focus lost: we already have something done related to thi... Constantin Asofiei

09:14 AM User Interface Feature #2546: implement combo-box widget in GUI

Eugenie Lyzenko wrote:
> >...To me, the drop-down in GUI looks like is dependent on the size and coordinates of the ... Constantin Asofiei

01:10 PM Base Language Bug #2578: incorrect promotion of local defined variables

Code Review om_upd20150605a.zip
I'm good with this approach. You can check it in if it passes testing. Greg Shah

12:21 PM Base Language Bug #2578 (WIP): incorrect promotion of local defined variables

Thanks, Greg, this is exactly my idea. I was sure the @ui_statements@ is not the right place - it is also called too ... Ovidiu Maxiniuc

11:41 AM User Interface Feature #1790: implement menu support

Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > #. Does this scenario work for GUI in the same way? I recall th... Vadim Gindin

04:51 AM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> #. Does this scenario work for GUI in the same way? I recall that for GUI 2 classes are used to... Constantin Asofiei

06/04/2015

03:45 PM User Interface Feature #1790: implement menu support

I wanted to ask some common question about repainting in GUI.
For ChUI I need to post new @PaintEvent@ to event q... Vadim Gindin

03:16 PM Base Language Bug #2578: incorrect promotion of local defined variables

OK, I've dug into this code more deeply. I think I understand better what you are trying to do.
I still believe t... Greg Shah

11:38 AM Database Bug #2552: bad hql caching prevents queries to position on the correct rows

Eric Faulhaber wrote:
> I have posted my full search test results at #1868, note 60 (including the @stdout.log@ this... Ovidiu Maxiniuc

10:37 AM Database Bug #2552: bad hql caching prevents queries to position on the correct rows

I have posted my full search test results at #1868, note 60 (including the @stdout.log@ this time), for your referenc... Eric Faulhaber

07:01 AM Database Bug #2552: bad hql caching prevents queries to position on the correct rows

0603a is an independent update. I intentionally removed any relation to previous updates in order to isolate the issu... Ovidiu Maxiniuc

10:43 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows

Ovidiu, was your 0603a update meant to be applied on top of the 0421a update?
I tested P2J 10871 + 0603a (without ... Eric Faulhaber

06/03/2015

02:47 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows

> Looks good, nice find. Agreed, will look better with the println statements removed. Do you want to leave these beh... Ovidiu Maxiniuc

02:33 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows

Code review 0603a:
Looks good, nice find. Agreed, will look better with the println statements removed. Do you wan... Eric Faulhaber

02:07 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows

Eric,
I found the probable cause for the failures in regression testing of the @?@ relational semantics. I was worki... Ovidiu Maxiniuc

01:54 PM User Interface Feature #2546: implement combo-box widget in GUI

>ComboBoxGuiImpl and FillInGuiImpl: can you think of a way to sub-class the FillInGuiImpl so that the combo-box relat... Eugenie Lyzenko

01:17 PM User Interface Feature #2546: implement combo-box widget in GUI

>the ThinClient change related to focus lost: we already have something done related to this for the popup, via GuiDr... Eugenie Lyzenko

11:56 AM User Interface Feature #2546: implement combo-box widget in GUI

> That's why I need to know this info.
Please put comments in the code to explain this. Greg Shah

10:26 AM User Interface Feature #2546: implement combo-box widget in GUI

>...To me, the drop-down in GUI looks like is dependent on the size and coordinates of the associated combo-box widge... Eugenie Lyzenko

08:27 AM User Interface Feature #2546: implement combo-box widget in GUI

>how did you determine the ScrollBar.visibleRange default value?
The same value as @DefaultList.visibleRows@. Eugenie Lyzenko

07:12 AM User Interface Feature #2546: implement combo-box widget in GUI

Eugenie, this are some notes about evl_upd20150602a.zip:
* @DropDownGuiImpl.setHeightAndPos@: you are assuming that ... Constantin Asofiei

08:31 PM User Interface Feature #2546: implement combo-box widget in GUI

Today update for review has basic implementation of the @DROP-DOWN@ mode. The entry field is editable and until anoth... Eugenie Lyzenko

06/02/2015

05:37 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

To provide the correct implementaion of the REPLACE method for list widgets (COMBO-BOX/SELECTION-LIST/RADIO-SET) a ne... Igor Skornyakov

06:50 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> The FillIn.appVar initial value is not 'unknown'. As a result it is impossible to correctly... Constantin Asofiei

03:30 PM User Interface Feature #1790: implement menu support

You are right and now it works. Thank you very much! Vadim Gindin

03:23 PM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> I've made the following changes:
> #. I've set menu children @physicalLocation@ to relative v... Constantin Asofiei

03:19 PM User Interface Feature #1790: implement menu support

I've made the following changes:
#. I've set menu children @physicalLocation@ to relative value
#. I used relative ... Vadim Gindin

02:57 PM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> If so, what about methods like @GuiDriver.drawString(String, int, int)@, @GuiDriver.drawLine(i... Constantin Asofiei

02:24 PM User Interface Feature #1790: implement menu support

If so, what about methods like @GuiDriver.drawString(String, int, int)@, @GuiDriver.drawLine(int, int, int, int)@ or ... Vadim Gindin

12:48 PM User Interface Feature #1790: implement menu support

> adjust the menu's location to be relative to its parent
This one.
It is important that the @physicalLocation(... Greg Shah

12:35 PM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> I faced with the problem of defining a widget, mouse is clicked over. I have simple menubar wi... Constantin Asofiei

08:32 AM User Interface Feature #1790: implement menu support

I faced with the problem of defining a widget, mouse is clicked over. I have simple menubar with 3 menu-items and one... Vadim Gindin

01:15 PM User Interface Feature #1811: implement the AJAX client driver

> And if the target OS is expected to not provide these fonts, we can define these as "custom fonts" and pass to the... Greg Shah

07:07 AM User Interface Feature #1811: implement the AJAX client driver

Anton Breaur wrote:
> The way I envisioned the flow to work is that we send font information to the web client, like... Constantin Asofiei

08:18 PM User Interface Feature #2546: implement combo-box widget in GUI

The next update for review as current state reflection. This is DROP-DOWN mode first step with @FillInGuiImpl@ integr... Eugenie Lyzenko

06/01/2015

06:38 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

The FillIn.appVar initial value is not 'unknown'. As a result it is impossible to correctly calculate screenValue() w... Igor Skornyakov

05/31/2015

06:47 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

1. SCREEN-VALUE attribute getter returns empty string (at least for the FILL-IN widget).
2. SELECTION-TEXT attribute ... Igor Skornyakov

05/30/2015

09:12 PM User Interface Feature #2546: implement combo-box widget in GUI

The update for review presents the current state of the combo-box. The server side updated to introduce new option - ... Eugenie Lyzenko

05/29/2015

01:40 PM User Interface Feature #1811: implement the AJAX client driver

Please provide more details about exactly what you have tried to do and the results of each of those experiments/effo... Greg Shah

10:02 AM User Interface Feature #1811: implement the AJAX client driver

The way I envisioned the flow to work is that we send font information to the web client, like font name, size and st... Anton Breaur

01:25 PM Database Feature #2580: make field denormalization the default schema conversion for extent fields

For a schema with a lot of tables requiring extent field denormalization, it would be simpler and less error prone to... Eric Faulhaber

01:21 PM Database Feature #2580 (New): make field denormalization the default schema conversion for extent fields

Eric Faulhaber

06:48 AM User Interface Feature #2546: implement combo-box widget in GUI

Constantin Asofiei wrote:
> > What features in @FillInGuiImpl@ are critical and can not be changed in any cases? Ano... Eugenie Lyzenko

01:40 AM User Interface Feature #2546: implement combo-box widget in GUI

Eugenie Lyzenko wrote:
> Are you currently working on fill-in GUI implementation?
No, I'm not working on GUI FILL-... Constantin Asofiei

05:00 AM Base Language Bug #2578: incorrect promotion of local defined variables

Greg Shah wrote:
> Code Review om_upd20150528a.zip
> 1. Are the form header changes are necessary to fix this bug? I... Ovidiu Maxiniuc

05/28/2015

04:50 PM User Interface Feature #2546: implement combo-box widget in GUI

Constantin,
To implement different combo-box modes with editable entry field I'm planning to integrate fill-in GUI... Eugenie Lyzenko

03:45 PM Base Language Bug #2578: incorrect promotion of local defined variables

Code Review om_upd20150528a.zip
1. Are the form header changes are necessary to fix this bug? If I understand cor... Greg Shah

02:08 PM Base Language Bug #2578: incorrect promotion of local defined variables

Eric Faulhaber wrote:
> The changes look correct to me, but I am not expert in this area of the code. Greg will be r... Ovidiu Maxiniuc

01:08 PM Base Language Bug #2578: incorrect promotion of local defined variables

Code review 0527b:
The changes look correct to me, but I am not expert in this area of the code. Greg will be revi... Eric Faulhaber

11:02 AM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Vadim Gindin wrote:
> > > It could print the title on the top ... Vadim Gindin

10:36 AM User Interface Feature #1790: implement menu support

Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > It could print the title on the top left corner when it draws r... Vadim Gindin

07:46 AM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> It could print the title on the top left corner when it draws rectangle but it doesn't happen.... Constantin Asofiei

07:06 AM User Interface Feature #1790: implement menu support

Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > MENU widget does not support coordinate attributes and WIDTH/HE... Vadim Gindin

04:41 AM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> MENU widget does not support coordinate attributes and WIDTH/HEIGHT attributes too..
OK, I di... Constantin Asofiei

05/27/2015

06:13 PM User Interface Feature #2546: implement combo-box widget in GUI

The update for review has two new changes:
1. Implementation for first char search/select in GUI combo-box when drop... Eugenie Lyzenko

08:40 PM User Interface Feature #2546: implement combo-box widget in GUI

The update for review merged with recent code base. In addition it adds tooltip feature to the combo-box and implemen... Eugenie Lyzenko

03:27 PM Base Language Bug #2578: incorrect promotion of local defined variables

This update is not the ideal solution I wanted but it fixes both last issues.
It passed my testcases, as well as the... Ovidiu Maxiniuc

10:55 AM Base Language Bug #2578: incorrect promotion of local defined variables

My candidate has the following flaw I am trying to fix: when a @FORM HEADER@ is defined locally in an internal proced... Ovidiu Maxiniuc

11:51 AM User Interface Feature #1790: implement menu support

Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > I'm trying to draw simple menubar and I have coordinates proble... Vadim Gindin

07:21 AM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> I'm trying to draw simple menubar and I have coordinates problem. I expected that [0,0] point ... Constantin Asofiei

06:25 AM User Interface Feature #1790: implement menu support

I'm trying to draw simple menubar and I have coordinates problem. I expected that [0,0] point will reside under the w... Vadim Gindin

05/26/2015

03:50 PM User Interface Feature #1811: implement the AJAX client driver

> 1. Consider the fonts that are defined in @src/font-metrics.xml@ and @FontTable.standardFontTable@.
From what I ... Anton Breaur

09:55 AM User Interface Feature #1811: implement the AJAX client driver

Code Review fonts_js.zip from note 712
Overall, this is moving in the right direction.
Next steps:
1. Consid... Greg Shah

01:23 PM User Interface Feature #2422: add features to BROWSE

@CURRENT-ROW-MODIFIED@ logic differs from @MODIFIED@ logic. The latter is tricky, while @CURRENT-ROW-MODIFIED@ is str... Stanislav Lomany

01:10 PM Base Language Bug #2578: incorrect promotion of local defined variables

Do you have a new version that I should use for the code review? Greg Shah

10:26 AM User Interface Feature #2546: implement combo-box widget in GUI

Multiple selection investigation results. In ChUI only DROP-DOWN-LIST mode can be active(even if other specified). In... Eugenie Lyzenko

05/25/2015

03:28 PM User Interface Feature #1811: implement the AJAX client driver

Added the @fontMetrics@ module from @p2j.screen.js@ and managed to compute all the metrics described in @com.goldenco... Anton Breaur

03:19 AM User Interface Feature #1794: implement font support

Greg Shah wrote:
> Code Review ca_upd20150520d.zip
>
> It looks good. This is a nice improvement over my previou... Constantin Asofiei

05/23/2015

10:06 AM User Interface Feature #1794: implement font support

Code Review ca_upd20150520d.zip
It looks good. This is a nice improvement over my previous approach (yours is muc... Greg Shah

05/22/2015

03:36 PM User Interface Feature #1811: implement the AJAX client driver

Anton Breaur wrote:
> > I do worry that we won't have access to all the metrics that we need, but I'm happy to avoid... Greg Shah

09:50 AM User Interface Feature #1811: implement the AJAX client driver

> I do worry that we won't have access to all the metrics that we need, but I'm happy to avoid custom font rendering ... Anton Breaur

08:37 AM User Interface Feature #1811: implement the AJAX client driver

> I think the proper way is to use @save()@ to store off the context before drawing the scaled string and then @resto... Anton Breaur

08:31 AM User Interface Feature #1811: implement the AJAX client driver

I'm OK with not using @opentype.js@, so long as we can get everything implemented which we need. I do worry that we ... Greg Shah

07:54 AM User Interface Feature #1811: implement the AJAX client driver

I gave up opentype.js and took a different approach. We can apply a scaling transformation to the canvas context, and... Anton Breaur

02:01 PM Base Language Bug #2578: incorrect promotion of local defined variables

Please ignore my om_upd20150522a.zip. It brings nothing new, I zipped the wrong files. Sorry. Ovidiu Maxiniuc

11:28 AM Base Language Bug #2578: incorrect promotion of local defined variables

I moved the @HandleExprN@ instance variable definitions to same scope as their class. The Majic conversion testing pa... Ovidiu Maxiniuc

11:48 PM Base Language Bug #2578: incorrect promotion of local defined variables

I tested @om_upd20150521a.zip@ with the current project. After conversion, there were a number of compile errors (act... Eric Faulhaber

05/21/2015

01:02 PM Base Language Bug #2578: incorrect promotion of local defined variables

Code review 0521a:
Looks good to me in terms of the persistence-related changes, though I did notice a typo in the... Eric Faulhaber

11:32 AM Base Language Bug #2578: incorrect promotion of local defined variables

I have tested this update with majic conversion and it looks fine to me.
There are a lot of changes in the code: asi... Ovidiu Maxiniuc

10:01 AM User Interface Feature #1811: implement the AJAX client driver

> I have attached a partial implementation for drawString and drawStringScaled methods in javascript. The index.html ... Greg Shah

07:12 AM User Interface Feature #1794: implement font support

0520d.zip has passed runtime testing. Constantin Asofiei

04:18 AM User Interface Bug #2579: Cursor offset is reset after a trigger containing MESSAGE ... UPDATE

Testcase:... Stanislav Lomany

04:13 AM User Interface Bug #2579 (New): Cursor offset is reset after a trigger containing MESSAGE ... UPDATE

Stanislav Lomany

05/20/2015

01:25 PM Base Language Bug #2578: incorrect promotion of local defined variables

Eric Faulhaber wrote:
> See @get_top_level_section_anchor@ in @common-progress.rules@. I use this as a substitute fo... Ovidiu Maxiniuc

12:52 PM Base Language Bug #2578: incorrect promotion of local defined variables

See @get_top_level_section_anchor@ in @common-progress.rules@. I use this as a substitute for @getSectionAnchor@. Eric Faulhaber

12:49 PM Base Language Bug #2578: incorrect promotion of local defined variables

That's exactly what I should do in this regard, too: to move the embedded assignment expressions to a more specific s... Ovidiu Maxiniuc

12:29 PM Base Language Bug #2578: incorrect promotion of local defined variables

Ovidiu Maxiniuc wrote:
> I think that is the correct location/scope of the inner @EmbeddedAssignmentExpr0@ class (li... Eric Faulhaber

09:24 AM Base Language Bug #2578: incorrect promotion of local defined variables

After some local tests with proposed fix I did a first conversion on Majic. There are indeed a lot of changes, 10% th... Ovidiu Maxiniuc

12:42 PM Database Bug #2536: improve dynamic query parser error handling

Code review 0519a:
I'm glad you made this change, I was going to ask for something like it. After you made the err... Eric Faulhaber

07:41 AM User Interface Feature #1794: implement font support

This version is built on top of 0519b.zip and improves the font table and metric loading + some other GUI-related fixes. Constantin Asofiei

05/19/2015

07:06 PM User Interface Feature #1811: implement the AJAX client driver

I have attached a partial implementation for drawString and drawStringScaled methods in javascript. The index.html de... Anton Breaur

12:58 PM User Interface Feature #1811: implement the AJAX client driver

The ab_upd20150518a.zip conflicts with the @FontManager@ changes in ca_upd20150519b.zip. How do we want to sequence ... Greg Shah

12:51 PM User Interface Feature #1811: implement the AJAX client driver

Greg Shah wrote:
> Code Review ab_upd20150518a.zip
>
> I'm good with the changes.
>
> Constantin: any objectio... Constantin Asofiei

12:33 PM User Interface Feature #1811: implement the AJAX client driver

Code Review ab_upd20150518a.zip
I'm good with the changes.
Constantin: any objections? Greg Shah

06:34 PM User Interface Feature #2546: implement combo-box widget in GUI

Addition to GUI combo-box TODO:
8. Investigate and implement different drop-down list modes, particularly if it is... Eugenie Lyzenko

03:07 PM User Interface Feature #2546: implement combo-box widget in GUI

The update fixes the "phantom" drop-down drawing at incorrect position by delaying the first available draw to the mo... Eugenie Lyzenko

04:32 PM Base Language Bug #2578: incorrect promotion of local defined variables

I think here we are over-generalizing for a specific case handled at line 619 of @where_clause_post.rules@, where we ... Eric Faulhaber

03:23 PM Base Language Bug #2578: incorrect promotion of local defined variables

Eric,
As I expected, the variables are generally promoted if they are found to be referenced in a query substitution... Ovidiu Maxiniuc

12:27 PM Base Language Bug #2578: incorrect promotion of local defined variables

Ovidiu Maxiniuc wrote:
> The reason why the variable is promoted is related to the fact that it takes part into the ... Eric Faulhaber

12:02 PM Base Language Bug #2578: incorrect promotion of local defined variables

Please check the @uast/scoping/local-variable-in-query.p@. Ovidiu Maxiniuc

11:30 AM Base Language Bug #2578: incorrect promotion of local defined variables

Please check this 4GL code into the testcases project and post the name here. Eric Faulhaber

10:29 AM Base Language Bug #2578: incorrect promotion of local defined variables

When running some testcases for a customer I encountered cases when they were passing at a first run, then re-running... Ovidiu Maxiniuc

10:03 AM Base Language Bug #2578 (Closed): incorrect promotion of local defined variables

Ovidiu Maxiniuc

01:47 PM User Interface Feature #2252: implement GUI client support

Create a new repo under @~/repo/p2j_repo/@ called @images@. We can keep things like SVG files there, similar to how ... Greg Shah

01:16 PM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> How are you converting the SVG to bitmaps? Do you do this during the P2J build or statically?
... Hynek Cihlar

01:14 PM User Interface Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> As part of #2559 I have created a set of icon files in SVG format. The application jar file wi... Greg Shah

08:17 AM User Interface Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> Hynek, have you had a chance to work on this?
No.
> If not, I'll take it.
Wond... Hynek Cihlar

07:41 AM User Interface Feature #2252: implement GUI client support

Hynek, have you had a chance to work on this? If not, I'll take it.
Hynek Cihlar wrote:
> Still I think the layou... Constantin Asofiei

05:42 AM User Interface Feature #2252: implement GUI client support

As part of #2559 I have created a set of icon files in SVG format. The application jar file will hold rastr exports o... Hynek Cihlar

01:13 PM User Interface Feature #1794: implement font support

Greg Shah wrote:
> Code Review ca_upd20150519b.zip
>
> The changes look good.
>
> 1. In regard to this todo in... Constantin Asofiei

12:53 PM User Interface Feature #1794: implement font support

Code Review ca_upd20150519b.zip
The changes look good.
1. In regard to this todo in @SwingGuiDriver.createFont(... Greg Shah

09:59 AM User Interface Feature #1794: implement font support

This update adds:
* support for custom fonts in the Swing GUI driver
* support for implicit font size used by 4GL
... Constantin Asofiei

09:32 AM User Interface Feature #1794: implement font support

If the font size is missing, 4GL looks like it defaults to these:
# courier new: 12
# segoe ui: 12
# tahoma: 12
#... Constantin Asofiei

03:37 AM Database Bug #2536: improve dynamic query parser error handling

I added a few changes to @DynamicQueryHelper@ that refine the messages printed in console. At this moment the log is ... Ovidiu Maxiniuc

05/18/2015

07:08 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

The @frame.enableUnlessHidden()@ call is generated for @enable unless-hidden all@ statement/Generic but CommonFrame/G... Igor Skornyakov

06:54 PM User Interface Feature #2546: implement combo-box widget in GUI

The update has code merged with @10867@. Eugenie Lyzenko

03:56 PM User Interface Feature #2546: implement combo-box widget in GUI

The next update for review has fixes for both message processing TODO's. Also now the top row in opened drop-down is ... Eugenie Lyzenko

05:11 PM User Interface Feature #1811: implement the AJAX client driver

> Do you have more research to do or are you ready to work on specific javascript code to implement these features?
... Anton Breaur

05:09 PM User Interface Feature #1811: implement the AJAX client driver

> I assume this would not be accepted.
Correct.
So far, your proposal sounds reasonable. Do you have more rese... Greg Shah

04:50 PM User Interface Feature #1811: implement the AJAX client driver

I have executed local testing of all client types, using the IM POC code for the 4 ChUI clients. MAJIC regression te... Greg Shah

04:49 PM User Interface Feature #1811: implement the AJAX client driver

A description of the more rational driver structure is as follows:
com/goldencode/p2j/ui/client/driver/ - Driver c... Greg Shah

04:21 PM User Interface Feature #1811: implement the AJAX client driver

Merged with bzr rev 10866. This only changes @ColorTable@ and @FrameWidget@. Since my changes are just some javadoc... Greg Shah

04:18 PM User Interface Feature #1811: implement the AJAX client driver

No objections to the changes in ges_upd20150518a.zip here. Hynek Cihlar

02:01 PM User Interface Feature #1811: implement the AJAX client driver

>Your task is to propose an approach for how to implement this native porton in javascript. We will have to implement... Anton Breaur

12:10 PM User Interface Feature #1811: implement the AJAX client driver

Attached is the fixed update.
> ThinClient.resume() - shouldn't be the batch mode activated only when already acti... Greg Shah

06:54 AM User Interface Feature #1811: implement the AJAX client driver

Greg Shah wrote:
> Constantin/Hynek: please review this code. I'll check it in unless there are objections.
Beside... Constantin Asofiei

03:53 PM Database Bug #2536: improve dynamic query parser error handling

Is there anything left to do on this issue at this point, or can it be closed? Eric Faulhaber

03:51 PM Database Bug #2577: extent information in meta table

Ovidiu Maxiniuc wrote:
> I've just checked the @custom-extent@ support. As you thought, it doesn't work. The @messag... Eric Faulhaber

03:16 PM Database Bug #2577: extent information in meta table

Committed to bzr as revno 10865.
I've just checked the @custom-extent@ support. As you thought, it doesn't work. T... Ovidiu Maxiniuc

02:10 PM Database Bug #2577: extent information in meta table

Code review 0518b:
The fix looks fine. Please check it in as is, no regression testing needed (it is additive and ... Eric Faulhaber

12:54 PM Database Bug #2577: extent information in meta table

I discovered that the extent information is missing in the field meta table (it's always @0@). This causes some testc... Ovidiu Maxiniuc

12:38 PM Database Bug #2577 (Closed): extent information in meta table

Ovidiu Maxiniuc

03:10 PM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources

The attached update is essentially the same as ecf_upd20150518a, but with the original error logging in @TM.abnormalE... Eric Faulhaber

05:40 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources

Constantin Asofiei wrote:
> There's one more place with a @new WorkArea()@ in @ColorTable.asHandle@. Please fix th... Eric Faulhaber

02:45 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources

Eric Faulhaber wrote:
> Constantin, I included the suggested @handle.removeResource@ fix, and it did indeed solve th... Constantin Asofiei

12:23 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources

Constantin, I included the suggested @handle.removeResource@ fix, and it did indeed solve that problem. Thank you!
... Eric Faulhaber

05/17/2015

05:07 PM User Interface Feature #2559 (WIP): implement ALERT-BOX support

Hynek Cihlar

04:01 PM User Interface Feature #1811: implement the AJAX client driver

Review of ges_upd20150517a.zip.
This is a lot of nice cleanup!

* @ThinClient.resume()@ - shouldn't be the batc... Hynek Cihlar

11:06 AM User Interface Feature #1811: implement the AJAX client driver

This update has the ca_upd20150516a.zip changes merged.
My original @scaleFont()@ implementation did not edit the ... Greg Shah

10:37 AM User Interface Feature #1811: implement the AJAX client driver

Code Review ca_upd20150516a.zip
The changes make sense. I've integrated them with my code, but I've done it a bit... Greg Shah

11:34 AM User Interface Bug #2576: Cursor position in numeric fields (ChUI)

4GL and P2J has different cursor behavior for numeric values. In an @"___12345"@ field 4GL allows to move cursor in u... Stanislav Lomany

11:33 AM User Interface Bug #2576 (New): Cursor position in numeric fields (ChUI)

Stanislav Lomany

11:14 AM User Interface Feature #2422: add features to BROWSE

I agree. Please open a separate task for this. Greg Shah

11:07 AM User Interface Feature #2422: add features to BROWSE

I've implemented @CURSOR-OFFSET@ for fill-in, but there is one issues, which I think deserves a separate task - 4GL a... Stanislav Lomany

05/16/2015

01:57 PM User Interface Feature #1811: implement the AJAX client driver

Greg Shah wrote:
> At this point the only known issue is that the fonts in GUI seem off. I made quite a significant... Constantin Asofiei

12:31 PM User Interface Feature #1811: implement the AJAX client driver

Anton: here is your next task.
Please review the following from my update:... Greg Shah

11:35 AM User Interface Feature #1811: implement the AJAX client driver

Attached is the latest scripts to help review or apply the update. Greg Shah

11:08 AM User Interface Feature #1811: implement the AJAX client driver

Oh, alright. I will keep those standards in mind then. Anton Breaur

11:06 AM User Interface Feature #1811: implement the AJAX client driver

As I mentioned in note 682:
> You do *not* have to fix the current update.
I just added the bold to highlight ... Greg Shah

10:58 AM User Interface Feature #1811: implement the AJAX client driver

I will fix these and upload an update. Anton Breaur

10:51 AM User Interface Feature #1811: implement the AJAX client driver

Code Review ab_upd20150516a.zip
Anton: although I have already merged your changes with my own, I am providing thi... Greg Shah

10:29 AM User Interface Feature #1811: implement the AJAX client driver

0515b passed CTRL-C testing.
The attached is 0515b merged with the changes in ab_upd20150516a.zip. The web ChUI c... Greg Shah

10:01 AM User Interface Feature #1811: implement the AJAX client driver

I'm merging and testing your changes. The important difference is in the @EmbeddedWebServerImpl.startupServer()@. Greg Shah

09:56 AM User Interface Feature #1811: implement the AJAX client driver

The latest patch works fine with revision 10863 merged version.
I still don't understand the web_client.html issue. ... Anton Breaur

09:20 AM User Interface Feature #1811: implement the AJAX client driver

This fixes the web chui failure. It was created on top of the merged with revision 10855 version, and not yet tested ... Anton Breaur

08:37 AM User Interface Feature #1811: implement the AJAX client driver

> The web_client.html is the login page. This works with my 0515b update. It allows the ChUI-specific index.html to... Anton Breaur

08:02 AM User Interface Feature #1811: implement the AJAX client driver

I ran main regression testing on the 0515b update last night. GSO 418 did fail in addition to the expected failure i... Greg Shah

07:36 AM User Interface Feature #1811: implement the AJAX client driver

The web_client.html is the login page. This works with my 0515b update. It allows the ChUI-specific index.html to b... Greg Shah

09:02 PM User Interface Feature #2546: implement combo-box widget in GUI

This is just today changes for review. Scrolling approach changed to reflect 4GL behavior. Also I have found in GUI t... Eugenie Lyzenko

05/15/2015

07:54 PM User Interface Feature #1811: implement the AJAX client driver

Greg, I don't understand the web_client.html issue. The web chui client does not need that resource.
If you applied ... Anton Breaur

02:30 PM User Interface Feature #1811: implement the AJAX client driver

This includes a fix for the batch process launching from Swing clients.
I have also tried to implement the fixes f... Greg Shah

12:22 PM User Interface Feature #1811: implement the AJAX client driver

Merged to bzr 10863. Greg Shah

11:41 AM User Interface Feature #1811: implement the AJAX client driver

Please post your changed versions of my files (only include those files you have changed). Greg Shah

11:26 AM User Interface Feature #1811: implement the AJAX client driver

> Although all the docs and examples point out that wraping a ResourceHandler under a ContextHandler should enable lo... Anton Breaur

05:02 PM User Interface Feature #1794: implement font support

Greg Shah wrote:
> I have an idea what @scaled via DPI@ and @scaled via legacy metrics@ mean. Can you explain what ... Constantin Asofiei

04:51 PM User Interface Feature #1794: implement font support

I have an idea what @scaled via DPI@ and @scaled via legacy metrics@ mean. Can you explain what you did for @scaled ... Greg Shah

04:27 PM User Interface Feature #1794: implement font support

About using the font/text metrics reported by the driver for widget size formulas. I've tested the @Courier New@, @M... Constantin Asofiei

03:28 PM User Interface Feature #1794: implement font support

As we consider font compatibility issues, the following are some useful references:
http://en.wikipedia.org/wiki/C... Greg Shah

08:26 AM User Interface Feature #2546: implement combo-box widget in GUI

Code Review evl_upd20150514b.zip
I'm good with this version. Please just remove the ChUI reference in the @DropDo... Greg Shah

03:43 AM User Interface Feature #2252: implement GUI client support

hc_upd20150513b.zip committed to bzr rev 10862. Hynek Cihlar

02:53 AM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review hc_upd20150513b.zip
>
> I'm OK with it.
>
> Constantin?
The changes look OK. Constantin Asofiei

03:16 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> 3. I don't understand the point about @ShowBars.NEVER@.
There seemed to be a confusion about t... Hynek Cihlar

02:58 AM User Interface Feature #2573: GUI implementation for the "n COLUMNS" frame option

This task is to implement in P2J the "n COLUMNS" option at the frame phrase, in GUI. In ChUI, this kind of layout is ... Constantin Asofiei

02:54 AM User Interface Feature #2573 (New): GUI implementation for the "n COLUMNS" frame option

Constantin Asofiei

05/14/2015

07:11 PM User Interface Feature #2546: implement combo-box widget in GUI

The update has fixes for previous notes and creating new class @DropDownImpl@ to handle ChUI specifics. The @ChuiWidg... Eugenie Lyzenko

06:11 PM User Interface Feature #2546: implement combo-box widget in GUI

> You mean we need to create new class @DropDownImpl@ to concentrate all ChUI specifics?
Yes. Greg Shah

06:05 PM User Interface Feature #2546: implement combo-box widget in GUI

Greg Shah wrote:
>
> 3. Since @DropDown.fixVisibleRows()@ is ChUI specific, it should be in @DropDownImpl@. In th... Eugenie Lyzenko

05:29 PM User Interface Feature #2546: implement combo-box widget in GUI

Code Review evl_upd20150514a.zip
I like the code.
1. The @ComboBox.initEventsSet()@ and @ComboBox.addMouseExitE... Greg Shah

04:47 PM User Interface Feature #2546: implement combo-box widget in GUI

This update accumulates recent changes and fixes for combo-box. What's new:
1. The drop-down can now be left either ... Eugenie Lyzenko

03:58 PM User Interface Feature #2546: implement combo-box widget in GUI

Code Review evl_upd20150512a.zip
I'm OK with the changes so far. @ScrollableSelectionListGuiImpl@, @DropDownGuiIm... Greg Shah

04:23 AM User Interface Feature #2546: implement combo-box widget in GUI

I noticed drop downs are drawn using the same renderer as the parent @Window@. This means they can never be drawn out... Hynek Cihlar

06:33 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> 1. Is there only 1 issue described in those notes or more than one?
I understand that it is a ... Igor Skornyakov

06:29 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> Greg Shah wrote:
>
> > Is another task is needed for the issue in note 67, 71 - 72 and 8... Greg Shah

06:16 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> Is another task is needed for the issue in note 67, 71 - 72 and 84 - 86?
I do not consider t... Igor Skornyakov

06:10 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

I've created a separate task #2572 for work on @realized@.
Is another task is needed for the issue in note 67, 71 ... Greg Shah

05:25 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Eugenie Lyzenko wrote:
> 2. This call worked only for drop-down list and only for the time it exists. No other class... Hynek Cihlar

04:58 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> > Probably due to the following in @DropDownGuiImpl.setHeightAndPos()@?
> >
> > [...]
>
> I... Eugenie Lyzenko

03:59 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Hynek Cihlar wrote:
> Igor Skornyakov wrote:
> > I've noticed the following issue (see attached sample code). With ... Greg Shah

11:26 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Constantin Asofiei wrote:
> I mean, does the frame get realized regardless which widget gets its size read?
I d... Igor Skornyakov

11:19 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> Constantin Asofiei wrote:
>
> > OK, this is interesting; I think reading width/height at... Constantin Asofiei

10:09 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Constantin Asofiei wrote:
> OK, this is interesting; I think reading width/height attributes will make the frame "... Igor Skornyakov

10:03 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> Constantin Asofiei wrote:
>
> > Igor: please post your example for the case you are tryi... Constantin Asofiei

09:59 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Constantin Asofiei wrote:
> Igor: please post your example for the case you are trying to solve.
Constantin. In... Igor Skornyakov

09:44 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Eugenie Lyzenko wrote:
> My suggest: the widget become realized when it become the part of some frame. More specifica... Constantin Asofiei

09:42 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> Is it sufficient to set a 'realized' flag in the widget config?
There already is a @Widget... Constantin Asofiei

09:41 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

My suggest: the widget become realized when it become the part of some frame. More specifically: when it is used in w... Eugenie Lyzenko

09:23 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Eugenie Lyzenko wrote:
> From @4GL 9.1 Progress Programming Handbook@, chapter 16-26, page 614:
>
> [...]
Th... Igor Skornyakov

09:07 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> BTW: I would like to repeat the question I've asked earlier. What is the exact semantics of... Eugenie Lyzenko

07:34 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

BTW: I would like to repeat the question I've asked earlier. What is the exact semantics of the widget 'realization'?... Igor Skornyakov

03:59 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Hynek Cihlar wrote:
>
> Probably due to the following in @DropDownGuiImpl.setHeightAndPos()@?
>
> [...]
Th... Igor Skornyakov

03:56 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> I've noticed the following issue (see attached sample code). With native 4GL one can see a ... Hynek Cihlar

03:37 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Constantin Asofiei wrote:
> Is this something which prevents the 4GL program to run? Basically, our goal is to conve... Igor Skornyakov

01:26 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> Need to add frame validation at the moment of realization to ensure that all widgets fit in... Constantin Asofiei

06:22 PM User Interface Feature #2252: implement GUI client support

Code Review hc_upd20150513b.zip
I'm OK with it.
Constantin? Greg Shah

07:12 AM User Interface Feature #2252: implement GUI client support

The attached update fixes a mismatch in frame size caused by char->pixel conversion. This prevents frame size adjustm... Hynek Cihlar

06:05 PM User Interface Bug #2572: improve realized for widgets

The @realized@ flag for widgets needs to be improved to duplicate the 4GL behavior. Unfortunately, this behavior is ... Greg Shah

06:02 PM User Interface Bug #2572 (New): improve realized for widgets

Greg Shah

07:27 AM User Interface Feature #1811: implement the AJAX client driver

> > After investigating the web Chui issue, I found that the ChuiWebDriver.getWelcomePageUrl method builds the wrong ... Anton Breaur

07:06 AM User Interface Feature #1811: implement the AJAX client driver

> We are not just limited to using this approach.
To be clear, my preference is to use predefined classes from Jet... Greg Shah

07:00 AM User Interface Feature #1811: implement the AJAX client driver

> Adding another subfolder to res folders as such: com/goldencode/p2j/ui/client/chui/driver/web/res/client and com/go... Greg Shah

06:56 AM User Interface Feature #1811: implement the AJAX client driver

> After investigating the web Chui issue, I found that the ChuiWebDriver.getWelcomePageUrl method builds the wrong UR... Greg Shah

06:27 AM User Interface Feature #1811: implement the AJAX client driver

Adding another subfolder to res folders as such: @com/goldencode/p2j/ui/client/chui/driver/web/res/client@ and @com/g... Anton Breaur