Activity
From 05/18/2015 to 06/16/2015
06/17/2015
- 08:51 PM User Interface Feature #2546: implement combo-box widget in GUI
- The today update has small changes to event processing. The new class I have introduced in one previous update - @Com...
06/16/2015
- 11:37 AM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute
- It looks like button's DEFAULT attribute does not need to be checked in @FrameGuiImpl.processDefaultButton()@. Press...
- 11:28 AM User Interface Bug #2588 (Closed): test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTT...
- 11:29 AM User Interface Feature #2563: implement GUI EDITOR widget
- > Looks like the Progress bug or documentation miss. So we have to decide what strategy we will take here.
It does... - 10:48 AM User Interface Feature #2546: implement combo-box widget in GUI
- Greg Shah wrote:
> Code Reviews evl_upd20150611a.zip evl_upd20150613a.zip evl_upd20150614a.zip evl_upd20150615a.z... - 10:36 AM User Interface Feature #2546: implement combo-box widget in GUI
- Code Reviews evl_upd20150611a.zip evl_upd20150613a.zip evl_upd20150614a.zip evl_upd20150615a.zip
I am generally... - 10:17 AM User Interface Feature #1794: implement font support
- There is a very useful discussion and tutorial in #2546 notes 92 and 98. This explains some problems with matching f...
- 09:09 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> > Btw., WindowGuiImpl.resolveTitleFont() allows to override the title font by the value of the wi... - 09:00 AM User Interface Feature #2252: implement GUI client support
- > Btw., WindowGuiImpl.resolveTitleFont() allows to override the title font by the value of the window's BaseConfig.ti...
- 06:08 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> 1. The @AbstractWidget@ parent/ancestor lookup processing is much improved. It is easier to read...
06/15/2015
- 05:08 PM User Interface Feature #2252: implement GUI client support
- Code Review hc_upd20150612b.zip
This is a really nice improvement. I especially like the way you abstracted the a... - 04:37 PM User Interface Feature #2546: implement combo-box widget in GUI
- The metrics for the combo-box widget have already been captured into @uast/combo_box/metrics/@ folder (they are all f...
- 09:38 AM User Interface Feature #2546: implement combo-box widget in GUI
- Clarification about @VALUE-CHANGED@ event generation:
In all three modes mouse click and keyboard @UP@/@DOWN@ caus... - 08:30 AM User Interface Feature #2546: implement combo-box widget in GUI
- Small change to fix entry field selection draw in @DROP-DOWN@ mode when drop-down list become active.
- 11:28 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Code Review ias_upd20150612a.zip
Please go ahead with the merge. Stanislav's changes have been checked in. Here ... - 11:01 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Igor Skornyakov wrote:
> Regarding the previous question. Is it OK to add a separate method @setInititialInnerLines(...
06/14/2015
- 06:04 PM User Interface Feature #2546: implement combo-box widget in GUI
- More features findings for 4GL combo-box.
1. When combo-box is in @SIMPLE@ or @DROP-DOWN@ modes the entry field keep... - 09:10 AM User Interface Feature #2546: implement combo-box widget in GUI
- Merged with recent @10879@ code base.
- 04:41 AM User Interface Feature #2422: add features to BROWSE
- INSERT-ROW, CURSOR-OFFSET, AUTO-ZAP and CURRENT-ROW-MODIFIED. Committed to bzr rev 10879.
06/13/2015
- 05:55 PM User Interface Feature #2546: implement combo-box widget in GUI
- The update for review fixes the drop-down incorrect coordinates setting. The idea is based on the fact the drop-down ...
06/12/2015
- 06:30 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Fixed EDITOR regression, fixed all issues mentioned in the code review except the FRAME realization (only @VIEW@ and ...
- 05:13 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Regarding the previous question. Is it OK to add a separate method @setInititialInnerLines()@ for use in compilation ...
- 04:43 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- I have a problem. P2J compiles
DEFINE VARIABLE sl AS CHARACTER NO-UNDO
VIEW-AS SELECTION-LIST
INNER-LINES ... - 09:25 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Greg Shah wrote:
> Please set it to M12.
Done. - 09:23 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Please set it to M12.
- 09:22 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Greg Shah wrote:
> You can add watchers later, using the "Watchers (x)" section at the right side-bar of the task pa... - 09:19 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- > BTW: I've created another task #2582 as per Constantin request but forgot to add watches at the creation and I do n...
- 09:09 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Greg Shah wrote:
> No. Please create a new task in the UI project and set its target version to M12. Also add me a... - 08:52 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- > Should I fix this bug in the scope of this task?
No. Please create a new task in the UI project and set its ta... - 06:06 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- With P2L FillInWidget.getScreenValue() returns blank if the first read access was when the focus was in the different...
- 03:41 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Greg Shah wrote:
> Besides the items requested from the code review, what else still needs to be done for this task?... - 04:45 PM User Interface Feature #2563: implement GUI EDITOR widget
- >Eugenie, new question: are you sure the button's DEFAULT attribute needs to be checked in @FrameGuiImpl.processDefau...
- 04:09 PM User Interface Feature #2563: implement GUI EDITOR widget
- Eugenie, new question: are you sure the button's DEFAULT attribute needs to be checked in @FrameGuiImpl.processDefaul...
- 04:32 PM User Interface Feature #2252: implement GUI client support
- The attached implements ALERT-BOX widget in Swing GUI. As related changes it also adds support for modal windows and ...
- 09:04 AM User Interface Bug #2586: FillInWidget.getScreenValue() incorretly returns blank
- Another minor issue with the @FillInWidget.getScreenValue()@
If you run p2j conversion of this test and type a space... - 08:56 AM User Interface Bug #2586: FillInWidget.getScreenValue() incorretly returns blank
- ith P2L FillInWidget.getScreenValue() returns blank if the first read access was when the focus was in the different ...
- 08:55 AM User Interface Bug #2586 (New): FillInWidget.getScreenValue() incorretly returns blank
- 06:05 AM User Interface Feature #2546: implement combo-box widget in GUI
- Eugenie, first of all, see note 77 and the testcase at this note - the drop-down's coordinates are still incorrect. ...
- 08:51 PM User Interface Feature #2546: implement combo-box widget in GUI
- >That will be a memory leak. Static widgets shouldn't last for the application lifetime. They should only live while ...
- 03:25 AM User Interface Feature #1790: implement menu support
- Vadim Gindin wrote:
> I can check this field @WindowGuiImpl.mousePressedSource@ in @MenuItemGuiImpl.mouseMoved()@ to...
06/11/2015
- 05:49 PM User Interface Feature #2546: implement combo-box widget in GUI
- That will be a memory leak. Static widgets shouldn't last for the application lifetime. They should only live while ...
- 05:37 PM User Interface Feature #2546: implement combo-box widget in GUI
- >My only question is about @WidgetRegistry.addContainer()@. How do those registered widgets get removed when they are...
- 02:36 PM User Interface Feature #2546: implement combo-box widget in GUI
- Code Review evl_upd20150610a.zip
I think this is very good. I especially like the new @EntryFieldGuiImpl@.
My ... - 09:19 PM User Interface Feature #2546: implement combo-box widget in GUI
- Some samples to illustrate @SIMPLE@ mode of the combo-box.
- 08:56 PM User Interface Feature #2546: implement combo-box widget in GUI
- The next update for review has the good shape combo-box implementation with all three modes available. Key and mouse ...
- 05:33 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Besides the items requested from the code review, what else still needs to be done for this task?
- 01:13 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Greg Shah wrote:
> I think it is realized the first time it is made visible. @ENABLE@ is just one way to make the... - 01:11 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- >> 3. Should GenericFrame.validateLayout() be called whenever the frame is realized (not just during ENABLE)?
>
> S... - 11:23 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Greg Shah wrote:
> Code Review ias_upd20150605a.zip
> 3. Should @GenericFrame.validateLayout()@ be called wheneve... - 10:29 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Code Review ias_upd20150605a.zip
1. I think we may want to implement a method in @GenericWidget@ for the core vali... - 03:34 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Greg Shah wrote:
> OK, the plan:
>
> 1. You can keep the @DISABLE-AUTO-ZAP@ support in the config and server-side... - 01:58 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Please commit and distribute 0611a. Thanks.
- 01:48 PM Database Bug #2488: replace runtime compilation of dynamic queries
- The attached update is basically the same as 0610a except for the comment form @build.xml@ removed and a cascading @i...
- 12:28 PM Database Bug #2488: replace runtime compilation of dynamic queries
- I tested the 0610a update with the full set of search unit tests. I can confirm that it fixed the problematic test an...
- 01:46 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Code review 0610a:
Looks good. Assuming your local testing confirms it fixes the problem, please run conversion re... - 01:41 PM Database Bug #2552 (Closed): bad hql caching prevents queries to position on the correct rows
- 01:40 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows
- The 0608c update passed the regression testing, was committed to bzr as revno 10876 and distributed by mail.
- 09:31 AM User Interface Feature #2422: add features to BROWSE
- Yes, you should go ahead and implement it. Inserting before the first or after the last seems like something that is...
- 09:21 AM User Interface Feature #2422: add features to BROWSE
- > I would like you to please get the current update through regression testing and checked in. This will free up oth...
- 09:04 AM User Interface Feature #2422: add features to BROWSE
- I would like you to please get the current update through regression testing and checked in. This will free up other...
- 07:12 AM User Interface Feature #2422: add features to BROWSE
- > What else is open in this task?
My checklist:
# Page up/down, home/end doesn't work in editable browse.
# Unin... - 02:35 AM User Interface Feature #1790: implement menu support
- I'm trying to implement the following behavior. Assume we have menubar. Mouse pointer is located somewhere outside of...
06/10/2015
- 06:13 PM User Interface Feature #2422: add features to BROWSE
- > AUTO-ZAP and CURSOR-OFFSET are done
OK.
> except separate task #2576. Let me know if I should work on this t... - 12:11 PM User Interface Feature #2422: add features to BROWSE
- > In regard to this comment @// Oddly enough, 4GL returns zap state of the FOCUSED fill-in, not necessarily this one@...
- 11:36 AM User Interface Feature #2422: add features to BROWSE
- > When do you expect to have everything 100% complete? Igor's work in #2534 is dependent upon your changes for @AUTO...
- 10:49 AM User Interface Feature #2422: add features to BROWSE
- Code Review svl_upd20150610a.zip
In regard to this comment @// Oddly enough, 4GL returns zap state of the FOCUSED ... - 04:52 AM User Interface Feature #2422: add features to BROWSE
- Removed excess function @isNewRow@ from the previous update.
- 06:12 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- OK, the plan:
1. You can keep the @DISABLE-AUTO-ZAP@ support in the config and server-side getters/setters of your... - 12:02 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Actually I suggest to retain a DISABLE-AUTO-ZAP support in the config and at the server-side (getters/setters).
Gr... - 11:48 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Greg Shah wrote:
> Not for FILL-IN. But COMBO-BOX support is not part of Stanislav's work.
>
For the COMBO-BOX t... - 11:32 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- > Do you think that it makes sense for me to continue working on the AUTO-ZAP?
Not for FILL-IN. But COMBO-BOX sup... - 11:19 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Greg,
As I can see my changes for the FillIn significantly intersect with ones of Stanislav. My first impression is ... - 10:44 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Greg Shah wrote:
> Stanislav has also implemented @CURSOR-OFFSET@ for @FillIn@ in #2422.
Thank you Greg. - 10:42 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Stanislav has also implemented @CURSOR-OFFSET@ for @FillIn@ in #2422.
- 10:36 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Please look at Stanislav's most recent changes in #2422. He is making changes related to @AUTO-ZAP@ in @FillIn@. Sp...
- 02:53 PM User Interface Feature #1790: implement menu support
- > I've found that such fields are exist not in config classes
They would only be put into config classes if the da... - 12:01 PM User Interface Feature #1790: implement menu support
- I've found that such fields are exist not in config classes, but in GUI widget classes itself. For example @ButtonGui...
- 11:56 AM User Interface Feature #1790: implement menu support
- The question about widget (menu-item or sub-menu) state, that could be changed by mouse events: "mouse enter" (mouse ...
- 01:55 PM Database Bug #2488: replace runtime compilation of dynamic queries
- I have a fix for the issue. There are 3 important changes:
# the @convert/variable_references.rules@ was added to ru... - 08:26 PM User Interface Feature #2546: implement combo-box widget in GUI
- The next update for review has suggested approach for SIMPLE mode implementation. The idea is a bit different that us...
06/09/2015
- 03:52 PM Database Bug #2488: replace runtime compilation of dynamic queries
- The P4GL converted query is:...
- 03:19 PM Database Bug #2488: replace runtime compilation of dynamic queries
- I was able to duplicate the issue. One occurrence is in @test[Entity=|+TNCY_TENANT| TestType=|SEARCH| TestSubType=|SE...
- 01:04 PM Database Bug #2536: improve dynamic query parser error handling
- The logging level for exceptions was lowered to @FINE@ to keep the @CONFIG@ level free for configuration issues.
Th... - 10:01 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows
- Eric Faulhaber wrote:
> I'll test this update tonight against the full set of search unit tests.
The test went well...
06/08/2015
- 06:23 PM User Interface Bug #2582: Some key labels are not supported by p2j
- The attached is the updated @key_code_report.p@ program which outputs additional key labels and its output.
- 07:57 AM User Interface Bug #2582: Some key labels are not supported by p2j
- P2J doesn't support some valid key labels (such as @CTRL-ALT-A@). The 4GL documentation contains misprints and is not...
- 07:50 AM User Interface Bug #2582 (New): Some key labels are not supported by p2j
- 05:11 PM User Interface Feature #2422: add features to BROWSE
- Update for review. INSERT-ROW, CURSOR-OFFSET, AUTO-ZAP and CURRENT-ROW-MODIFIED.
- 02:55 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows
- Code review 0608c:
I think the changes are OK. Please post your regression test results when finished. I'll test t... - 12:53 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows
- This update should handle the main issue of this task: the caching of the hql-s. It will put into cache only the quer...
- 02:22 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Please investigate the following error from the P2J server.log:...
- 10:53 AM Base Language Bug #2578 (Closed): incorrect promotion of local defined variables
- Nice work, Ovidiu.
- 10:48 AM Base Language Bug #2578: incorrect promotion of local defined variables
- The update passed the regression testing, was committed to bzr as revno 10874 and it was distributed by mail.
- 04:27 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Constantin Asofiei wrote:
> Is this something you need for the current task? If not, please create another task unde... - 04:25 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor Skornyakov wrote:
> > > @Keyboard.keyCode(event)@ retu... - 03:31 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > @Keyboard.keyCode(event)@ returns -1 for some valid key labe... - 01:59 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Igor Skornyakov wrote:
> @Keyboard.keyCode(event)@ returns -1 for some valid key labels (such as @CTRL-ALT-X@). As a...
06/07/2015
- 11:32 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- I think I understand what's up. Some keycodes in 4GL have different labels and @keylabel@ function returns only one o...
- 11:07 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Greg Shah wrote:
> We have something like that already, see @testcases/uast/keyboards/key_code_report.p@
>
> We d... - 10:57 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- We have something like that already, see @testcases/uast/keyboards/key_code_report.p@
We did use that (and some ot... - 10:49 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Greg Shah wrote:
> Please post the list of which key labels you have found which are wrong. For each one, please al... - 09:49 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Please post the list of which key labels you have found which are wrong. For each one, please also post the key code...
- 05:48 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- @Keyboard.keyCode(event)@ returns -1 for some valid key labels (such as @CTRL-ALT-X@). As a result (?) the trigger @O...
06/06/2015
- 12:21 PM Base Language Bug #2578: incorrect promotion of local defined variables
- Update 0605a did well with the full group of search unit tests.
06/05/2015
- 04:28 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Let fi be a FILL-IN widget. According to my tests the AUTO-ZAP and DISABLE-AUTO-ZAP attributes' behavior is as descri...
- 12:25 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Greg Shah wrote:
> For now, just put a very clear TODO into the code at that point. The bug is obscure and hopefu... - 12:17 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- > At this moment the only way to fix it I can see is to make all descendants of the BaseDataType to be childs of the ...
- 11:54 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Another solution to the above mentioned issue is to use static immutable constant @BaseDataType.unknown@ (of type Bas...
- 11:49 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- I've just realized the following. If we assign a value to an attribute via widget handle then 'unknown' literal @?@ i...
- 09:46 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Please review the current version of the code.
NUM-ITEMS runtime support (combo-box and selection-list)
INNER-LIN... - 03:15 PM Database Feature #2581: improve performance of non-preselect, multi-table joins
- Currently, when we convert (statically or at runtime) constructs like FOR EACH, EACH, ... or FOR EACH, FIRST, ..., et...
- 02:58 PM Database Feature #2581 (Closed): improve performance of non-preselect, multi-table joins
- 03:03 PM User Interface Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> >Please use the -Dwidgetbrowser=yes when starting the GUI client to bring up the widget bro... - 12:28 PM User Interface Feature #2546: implement combo-box widget in GUI
- >Please use the -Dwidgetbrowser=yes when starting the GUI client to bring up the widget browser and see where everyth...
- 12:08 PM User Interface Feature #2546: implement combo-box widget in GUI
- >Eugenie: actually I do think this is the time to separate this functionality. As Constantin notes, this is likely to...
- 11:51 AM User Interface Feature #2546: implement combo-box widget in GUI
- >> if (inFocus != null && !isChui() && inFocus instanceof ScrollableList &&
>> evt.getEvent().ge... - 10:43 AM User Interface Feature #2546: implement combo-box widget in GUI
- >> ComboBoxGuiImpl and FillInGuiImpl: can you think of a way to sub-class the FillInGuiImpl so that the combo-box rel...
- 09:28 AM User Interface Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> >ComboBoxGuiImpl and FillInGuiImpl: can you think of a way to sub-class the FillInGuiImpl s... - 09:24 AM User Interface Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> >the ThinClient change related to focus lost: we already have something done related to thi... - 09:14 AM User Interface Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> >...To me, the drop-down in GUI looks like is dependent on the size and coordinates of the ... - 01:10 PM Base Language Bug #2578: incorrect promotion of local defined variables
- Code Review om_upd20150605a.zip
I'm good with this approach. You can check it in if it passes testing. - 12:21 PM Base Language Bug #2578 (WIP): incorrect promotion of local defined variables
- Thanks, Greg, this is exactly my idea. I was sure the @ui_statements@ is not the right place - it is also called too ...
- 11:41 AM User Interface Feature #1790: implement menu support
- Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > #. Does this scenario work for GUI in the same way? I recall th... - 04:51 AM User Interface Feature #1790: implement menu support
- Vadim Gindin wrote:
> #. Does this scenario work for GUI in the same way? I recall that for GUI 2 classes are used to...
06/04/2015
- 03:45 PM User Interface Feature #1790: implement menu support
- I wanted to ask some common question about repainting in GUI.
For ChUI I need to post new @PaintEvent@ to event q... - 03:16 PM Base Language Bug #2578: incorrect promotion of local defined variables
- OK, I've dug into this code more deeply. I think I understand better what you are trying to do.
I still believe t... - 11:38 AM Database Bug #2552: bad hql caching prevents queries to position on the correct rows
- Eric Faulhaber wrote:
> I have posted my full search test results at #1868, note 60 (including the @stdout.log@ this... - 10:37 AM Database Bug #2552: bad hql caching prevents queries to position on the correct rows
- I have posted my full search test results at #1868, note 60 (including the @stdout.log@ this time), for your referenc...
- 07:01 AM Database Bug #2552: bad hql caching prevents queries to position on the correct rows
- 0603a is an independent update. I intentionally removed any relation to previous updates in order to isolate the issu...
- 10:43 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows
- Ovidiu, was your 0603a update meant to be applied on top of the 0421a update?
I tested P2J 10871 + 0603a (without ...
06/03/2015
- 02:47 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows
- > Looks good, nice find. Agreed, will look better with the println statements removed. Do you want to leave these beh...
- 02:33 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows
- Code review 0603a:
Looks good, nice find. Agreed, will look better with the println statements removed. Do you wan... - 02:07 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows
- Eric,
I found the probable cause for the failures in regression testing of the @?@ relational semantics. I was worki... - 01:54 PM User Interface Feature #2546: implement combo-box widget in GUI
- >ComboBoxGuiImpl and FillInGuiImpl: can you think of a way to sub-class the FillInGuiImpl so that the combo-box relat...
- 01:17 PM User Interface Feature #2546: implement combo-box widget in GUI
- >the ThinClient change related to focus lost: we already have something done related to this for the popup, via GuiDr...
- 11:56 AM User Interface Feature #2546: implement combo-box widget in GUI
- > That's why I need to know this info.
Please put comments in the code to explain this. - 10:26 AM User Interface Feature #2546: implement combo-box widget in GUI
- >...To me, the drop-down in GUI looks like is dependent on the size and coordinates of the associated combo-box widge...
- 08:27 AM User Interface Feature #2546: implement combo-box widget in GUI
- >how did you determine the ScrollBar.visibleRange default value?
The same value as @DefaultList.visibleRows@. - 07:12 AM User Interface Feature #2546: implement combo-box widget in GUI
- Eugenie, this are some notes about evl_upd20150602a.zip:
* @DropDownGuiImpl.setHeightAndPos@: you are assuming that ... - 08:31 PM User Interface Feature #2546: implement combo-box widget in GUI
- Today update for review has basic implementation of the @DROP-DOWN@ mode. The entry field is editable and until anoth...
06/02/2015
- 05:37 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- To provide the correct implementaion of the REPLACE method for list widgets (COMBO-BOX/SELECTION-LIST/RADIO-SET) a ne...
- 06:50 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- Igor Skornyakov wrote:
> The FillIn.appVar initial value is not 'unknown'. As a result it is impossible to correctly... - 03:30 PM User Interface Feature #1790: implement menu support
- You are right and now it works. Thank you very much!
- 03:23 PM User Interface Feature #1790: implement menu support
- Vadim Gindin wrote:
> I've made the following changes:
> #. I've set menu children @physicalLocation@ to relative v... - 03:19 PM User Interface Feature #1790: implement menu support
- I've made the following changes:
#. I've set menu children @physicalLocation@ to relative value
#. I used relative ... - 02:57 PM User Interface Feature #1790: implement menu support
- Vadim Gindin wrote:
> If so, what about methods like @GuiDriver.drawString(String, int, int)@, @GuiDriver.drawLine(i... - 02:24 PM User Interface Feature #1790: implement menu support
- If so, what about methods like @GuiDriver.drawString(String, int, int)@, @GuiDriver.drawLine(int, int, int, int)@ or ...
- 12:48 PM User Interface Feature #1790: implement menu support
- > adjust the menu's location to be relative to its parent
This one.
It is important that the @physicalLocation(... - 12:35 PM User Interface Feature #1790: implement menu support
- Vadim Gindin wrote:
> I faced with the problem of defining a widget, mouse is clicked over. I have simple menubar wi... - 08:32 AM User Interface Feature #1790: implement menu support
- I faced with the problem of defining a widget, mouse is clicked over. I have simple menubar with 3 menu-items and one...
- 01:15 PM User Interface Feature #1811: implement the AJAX client driver
- > And if the target OS is expected to not provide these fonts, we can define these as "custom fonts" and pass to the...
- 07:07 AM User Interface Feature #1811: implement the AJAX client driver
- Anton Breaur wrote:
> The way I envisioned the flow to work is that we send font information to the web client, like... - 08:18 PM User Interface Feature #2546: implement combo-box widget in GUI
- The next update for review as current state reflection. This is DROP-DOWN mode first step with @FillInGuiImpl@ integr...
06/01/2015
- 06:38 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- The FillIn.appVar initial value is not 'unknown'. As a result it is impossible to correctly calculate screenValue() w...
05/31/2015
- 06:47 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- 1. SCREEN-VALUE attribute getter returns empty string (at least for the FILL-IN widget).
2. SELECTION-TEXT attribute ...
05/30/2015
- 09:12 PM User Interface Feature #2546: implement combo-box widget in GUI
- The update for review presents the current state of the combo-box. The server side updated to introduce new option - ...
05/29/2015
- 01:40 PM User Interface Feature #1811: implement the AJAX client driver
- Please provide more details about exactly what you have tried to do and the results of each of those experiments/effo...
- 10:02 AM User Interface Feature #1811: implement the AJAX client driver
- The way I envisioned the flow to work is that we send font information to the web client, like font name, size and st...
- 01:25 PM Database Feature #2580: make field denormalization the default schema conversion for extent fields
- For a schema with a lot of tables requiring extent field denormalization, it would be simpler and less error prone to...
- 01:21 PM Database Feature #2580 (New): make field denormalization the default schema conversion for extent fields
- 06:48 AM User Interface Feature #2546: implement combo-box widget in GUI
- Constantin Asofiei wrote:
> > What features in @FillInGuiImpl@ are critical and can not be changed in any cases? Ano... - 01:40 AM User Interface Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> Are you currently working on fill-in GUI implementation?
No, I'm not working on GUI FILL-... - 05:00 AM Base Language Bug #2578: incorrect promotion of local defined variables
- Greg Shah wrote:
> Code Review om_upd20150528a.zip
> 1. Are the form header changes are necessary to fix this bug? I...
05/28/2015
- 04:50 PM User Interface Feature #2546: implement combo-box widget in GUI
- Constantin,
To implement different combo-box modes with editable entry field I'm planning to integrate fill-in GUI... - 03:45 PM Base Language Bug #2578: incorrect promotion of local defined variables
- Code Review om_upd20150528a.zip
1. Are the form header changes are necessary to fix this bug? If I understand cor... - 02:08 PM Base Language Bug #2578: incorrect promotion of local defined variables
- Eric Faulhaber wrote:
> The changes look correct to me, but I am not expert in this area of the code. Greg will be r... - 01:08 PM Base Language Bug #2578: incorrect promotion of local defined variables
- Code review 0527b:
The changes look correct to me, but I am not expert in this area of the code. Greg will be revi... - 11:02 AM User Interface Feature #1790: implement menu support
- Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Vadim Gindin wrote:
> > > It could print the title on the top ... - 10:36 AM User Interface Feature #1790: implement menu support
- Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > It could print the title on the top left corner when it draws r... - 07:46 AM User Interface Feature #1790: implement menu support
- Vadim Gindin wrote:
> It could print the title on the top left corner when it draws rectangle but it doesn't happen.... - 07:06 AM User Interface Feature #1790: implement menu support
- Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > MENU widget does not support coordinate attributes and WIDTH/HE... - 04:41 AM User Interface Feature #1790: implement menu support
- Vadim Gindin wrote:
> MENU widget does not support coordinate attributes and WIDTH/HEIGHT attributes too..
OK, I di...
05/27/2015
- 06:13 PM User Interface Feature #2546: implement combo-box widget in GUI
- The update for review has two new changes:
1. Implementation for first char search/select in GUI combo-box when drop... - 08:40 PM User Interface Feature #2546: implement combo-box widget in GUI
- The update for review merged with recent code base. In addition it adds tooltip feature to the combo-box and implemen...
- 03:27 PM Base Language Bug #2578: incorrect promotion of local defined variables
- This update is not the ideal solution I wanted but it fixes both last issues.
It passed my testcases, as well as the... - 10:55 AM Base Language Bug #2578: incorrect promotion of local defined variables
- My candidate has the following flaw I am trying to fix: when a @FORM HEADER@ is defined locally in an internal proced...
- 11:51 AM User Interface Feature #1790: implement menu support
- Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > I'm trying to draw simple menubar and I have coordinates proble... - 07:21 AM User Interface Feature #1790: implement menu support
- Vadim Gindin wrote:
> I'm trying to draw simple menubar and I have coordinates problem. I expected that [0,0] point ... - 06:25 AM User Interface Feature #1790: implement menu support
- I'm trying to draw simple menubar and I have coordinates problem. I expected that [0,0] point will reside under the w...
05/26/2015
- 03:50 PM User Interface Feature #1811: implement the AJAX client driver
- > 1. Consider the fonts that are defined in @src/font-metrics.xml@ and @FontTable.standardFontTable@.
From what I ... - 09:55 AM User Interface Feature #1811: implement the AJAX client driver
- Code Review fonts_js.zip from note 712
Overall, this is moving in the right direction.
Next steps:
1. Consid... - 01:23 PM User Interface Feature #2422: add features to BROWSE
- @CURRENT-ROW-MODIFIED@ logic differs from @MODIFIED@ logic. The latter is tricky, while @CURRENT-ROW-MODIFIED@ is str...
- 01:10 PM Base Language Bug #2578: incorrect promotion of local defined variables
- Do you have a new version that I should use for the code review?
- 10:26 AM User Interface Feature #2546: implement combo-box widget in GUI
- Multiple selection investigation results. In ChUI only DROP-DOWN-LIST mode can be active(even if other specified). In...
05/25/2015
- 03:28 PM User Interface Feature #1811: implement the AJAX client driver
- Added the @fontMetrics@ module from @p2j.screen.js@ and managed to compute all the metrics described in @com.goldenco...
- 03:19 AM User Interface Feature #1794: implement font support
- Greg Shah wrote:
> Code Review ca_upd20150520d.zip
>
> It looks good. This is a nice improvement over my previou...
05/23/2015
- 10:06 AM User Interface Feature #1794: implement font support
- Code Review ca_upd20150520d.zip
It looks good. This is a nice improvement over my previous approach (yours is muc...
05/22/2015
- 03:36 PM User Interface Feature #1811: implement the AJAX client driver
- Anton Breaur wrote:
> > I do worry that we won't have access to all the metrics that we need, but I'm happy to avoid... - 09:50 AM User Interface Feature #1811: implement the AJAX client driver
- > I do worry that we won't have access to all the metrics that we need, but I'm happy to avoid custom font rendering ...
- 08:37 AM User Interface Feature #1811: implement the AJAX client driver
- > I think the proper way is to use @save()@ to store off the context before drawing the scaled string and then @resto...
- 08:31 AM User Interface Feature #1811: implement the AJAX client driver
- I'm OK with not using @opentype.js@, so long as we can get everything implemented which we need. I do worry that we ...
- 07:54 AM User Interface Feature #1811: implement the AJAX client driver
- I gave up opentype.js and took a different approach. We can apply a scaling transformation to the canvas context, and...
- 02:01 PM Base Language Bug #2578: incorrect promotion of local defined variables
- Please ignore my om_upd20150522a.zip. It brings nothing new, I zipped the wrong files. Sorry.
- 11:28 AM Base Language Bug #2578: incorrect promotion of local defined variables
- I moved the @HandleExprN@ instance variable definitions to same scope as their class. The Majic conversion testing pa...
- 11:48 PM Base Language Bug #2578: incorrect promotion of local defined variables
- I tested @om_upd20150521a.zip@ with the current project. After conversion, there were a number of compile errors (act...
05/21/2015
- 01:02 PM Base Language Bug #2578: incorrect promotion of local defined variables
- Code review 0521a:
Looks good to me in terms of the persistence-related changes, though I did notice a typo in the... - 11:32 AM Base Language Bug #2578: incorrect promotion of local defined variables
- I have tested this update with majic conversion and it looks fine to me.
There are a lot of changes in the code: asi... - 10:01 AM User Interface Feature #1811: implement the AJAX client driver
- > I have attached a partial implementation for drawString and drawStringScaled methods in javascript. The index.html ...
- 07:12 AM User Interface Feature #1794: implement font support
- 0520d.zip has passed runtime testing.
- 04:18 AM User Interface Bug #2579: Cursor offset is reset after a trigger containing MESSAGE ... UPDATE
- Testcase:...
- 04:13 AM User Interface Bug #2579 (New): Cursor offset is reset after a trigger containing MESSAGE ... UPDATE
05/20/2015
- 01:25 PM Base Language Bug #2578: incorrect promotion of local defined variables
- Eric Faulhaber wrote:
> See @get_top_level_section_anchor@ in @common-progress.rules@. I use this as a substitute fo... - 12:52 PM Base Language Bug #2578: incorrect promotion of local defined variables
- See @get_top_level_section_anchor@ in @common-progress.rules@. I use this as a substitute for @getSectionAnchor@.
- 12:49 PM Base Language Bug #2578: incorrect promotion of local defined variables
- That's exactly what I should do in this regard, too: to move the embedded assignment expressions to a more specific s...
- 12:29 PM Base Language Bug #2578: incorrect promotion of local defined variables
- Ovidiu Maxiniuc wrote:
> I think that is the correct location/scope of the inner @EmbeddedAssignmentExpr0@ class (li... - 09:24 AM Base Language Bug #2578: incorrect promotion of local defined variables
- After some local tests with proposed fix I did a first conversion on Majic. There are indeed a lot of changes, 10% th...
- 12:42 PM Database Bug #2536: improve dynamic query parser error handling
- Code review 0519a:
I'm glad you made this change, I was going to ask for something like it. After you made the err... - 07:41 AM User Interface Feature #1794: implement font support
- This version is built on top of 0519b.zip and improves the font table and metric loading + some other GUI-related fixes.
05/19/2015
- 07:06 PM User Interface Feature #1811: implement the AJAX client driver
- I have attached a partial implementation for drawString and drawStringScaled methods in javascript. The index.html de...
- 12:58 PM User Interface Feature #1811: implement the AJAX client driver
- The ab_upd20150518a.zip conflicts with the @FontManager@ changes in ca_upd20150519b.zip. How do we want to sequence ...
- 12:51 PM User Interface Feature #1811: implement the AJAX client driver
- Greg Shah wrote:
> Code Review ab_upd20150518a.zip
>
> I'm good with the changes.
>
> Constantin: any objectio... - 12:33 PM User Interface Feature #1811: implement the AJAX client driver
- Code Review ab_upd20150518a.zip
I'm good with the changes.
Constantin: any objections? - 06:34 PM User Interface Feature #2546: implement combo-box widget in GUI
- Addition to GUI combo-box TODO:
8. Investigate and implement different drop-down list modes, particularly if it is... - 03:07 PM User Interface Feature #2546: implement combo-box widget in GUI
- The update fixes the "phantom" drop-down drawing at incorrect position by delaying the first available draw to the mo...
- 04:32 PM Base Language Bug #2578: incorrect promotion of local defined variables
- I think here we are over-generalizing for a specific case handled at line 619 of @where_clause_post.rules@, where we ...
- 03:23 PM Base Language Bug #2578: incorrect promotion of local defined variables
- Eric,
As I expected, the variables are generally promoted if they are found to be referenced in a query substitution... - 12:27 PM Base Language Bug #2578: incorrect promotion of local defined variables
- Ovidiu Maxiniuc wrote:
> The reason why the variable is promoted is related to the fact that it takes part into the ... - 12:02 PM Base Language Bug #2578: incorrect promotion of local defined variables
- Please check the @uast/scoping/local-variable-in-query.p@.
- 11:30 AM Base Language Bug #2578: incorrect promotion of local defined variables
- Please check this 4GL code into the testcases project and post the name here.
- 10:29 AM Base Language Bug #2578: incorrect promotion of local defined variables
- When running some testcases for a customer I encountered cases when they were passing at a first run, then re-running...
- 10:03 AM Base Language Bug #2578 (Closed): incorrect promotion of local defined variables
- 01:47 PM User Interface Feature #2252: implement GUI client support
- Create a new repo under @~/repo/p2j_repo/@ called @images@. We can keep things like SVG files there, similar to how ...
- 01:16 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> How are you converting the SVG to bitmaps? Do you do this during the P2J build or statically?
... - 01:14 PM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> As part of #2559 I have created a set of icon files in SVG format. The application jar file wi... - 08:17 AM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek, have you had a chance to work on this?
No.
> If not, I'll take it.
Wond... - 07:41 AM User Interface Feature #2252: implement GUI client support
- Hynek, have you had a chance to work on this? If not, I'll take it.
Hynek Cihlar wrote:
> Still I think the layou... - 05:42 AM User Interface Feature #2252: implement GUI client support
- As part of #2559 I have created a set of icon files in SVG format. The application jar file will hold rastr exports o...
- 01:13 PM User Interface Feature #1794: implement font support
- Greg Shah wrote:
> Code Review ca_upd20150519b.zip
>
> The changes look good.
>
> 1. In regard to this todo in... - 12:53 PM User Interface Feature #1794: implement font support
- Code Review ca_upd20150519b.zip
The changes look good.
1. In regard to this todo in @SwingGuiDriver.createFont(... - 09:59 AM User Interface Feature #1794: implement font support
- This update adds:
* support for custom fonts in the Swing GUI driver
* support for implicit font size used by 4GL
... - 09:32 AM User Interface Feature #1794: implement font support
- If the font size is missing, 4GL looks like it defaults to these:
# courier new: 12
# segoe ui: 12
# tahoma: 12
#... - 03:37 AM Database Bug #2536: improve dynamic query parser error handling
- I added a few changes to @DynamicQueryHelper@ that refine the messages printed in console. At this moment the log is ...
05/18/2015
- 07:08 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
- The @frame.enableUnlessHidden()@ call is generated for @enable unless-hidden all@ statement/Generic but CommonFrame/G...
- 06:54 PM User Interface Feature #2546: implement combo-box widget in GUI
- The update has code merged with @10867@.
- 03:56 PM User Interface Feature #2546: implement combo-box widget in GUI
- The next update for review has fixes for both message processing TODO's. Also now the top row in opened drop-down is ...
- 05:11 PM User Interface Feature #1811: implement the AJAX client driver
- > Do you have more research to do or are you ready to work on specific javascript code to implement these features?
... - 05:09 PM User Interface Feature #1811: implement the AJAX client driver
- > I assume this would not be accepted.
Correct.
So far, your proposal sounds reasonable. Do you have more rese... - 04:50 PM User Interface Feature #1811: implement the AJAX client driver
- I have executed local testing of all client types, using the IM POC code for the 4 ChUI clients. MAJIC regression te...
- 04:49 PM User Interface Feature #1811: implement the AJAX client driver
- A description of the more rational driver structure is as follows:
com/goldencode/p2j/ui/client/driver/ - Driver c... - 04:21 PM User Interface Feature #1811: implement the AJAX client driver
- Merged with bzr rev 10866. This only changes @ColorTable@ and @FrameWidget@. Since my changes are just some javadoc...
- 04:18 PM User Interface Feature #1811: implement the AJAX client driver
- No objections to the changes in ges_upd20150518a.zip here.
- 02:01 PM User Interface Feature #1811: implement the AJAX client driver
- >Your task is to propose an approach for how to implement this native porton in javascript. We will have to implement...
- 12:10 PM User Interface Feature #1811: implement the AJAX client driver
- Attached is the fixed update.
> ThinClient.resume() - shouldn't be the batch mode activated only when already acti... - 06:54 AM User Interface Feature #1811: implement the AJAX client driver
- Greg Shah wrote:
> Constantin/Hynek: please review this code. I'll check it in unless there are objections.
Beside... - 03:53 PM Database Bug #2536: improve dynamic query parser error handling
- Is there anything left to do on this issue at this point, or can it be closed?
- 03:51 PM Database Bug #2577: extent information in meta table
- Ovidiu Maxiniuc wrote:
> I've just checked the @custom-extent@ support. As you thought, it doesn't work. The @messag... - 03:16 PM Database Bug #2577: extent information in meta table
- Committed to bzr as revno 10865.
I've just checked the @custom-extent@ support. As you thought, it doesn't work. T... - 02:10 PM Database Bug #2577: extent information in meta table
- Code review 0518b:
The fix looks fine. Please check it in as is, no regression testing needed (it is additive and ... - 12:54 PM Database Bug #2577: extent information in meta table
- I discovered that the extent information is missing in the field meta table (it's always @0@). This causes some testc...
- 12:38 PM Database Bug #2577 (Closed): extent information in meta table
- 03:10 PM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
- The attached update is essentially the same as ecf_upd20150518a, but with the original error logging in @TM.abnormalE...
- 05:40 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
- Constantin Asofiei wrote:
> There's one more place with a @new WorkArea()@ in @ColorTable.asHandle@. Please fix th... - 02:45 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
- Eric Faulhaber wrote:
> Constantin, I included the suggested @handle.removeResource@ fix, and it did indeed solve th... - 12:23 AM Bugs Bug #2569: memory leaks of procedure, buffer, handle resources
- Constantin, I included the suggested @handle.removeResource@ fix, and it did indeed solve that problem. Thank you!
...
Also available in: Atom