Activity

From 05/31/2015 to 06/29/2015

06/29/2015

07:01 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute: There is one more place to modify regarding this bug. The GUI button does not display image for default button. So th... Eugenie Lyzenko
06:24 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute: The fix has been committed in bzr as @10890@. Will be distributed shortly. Eugenie Lyzenko
06:12 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute: Eugenie Lyzenko wrote:
> >This should be already covered in branch 2563b @FrameGuiImpl.processDefaultButton@ - pleas... Constantin Asofiei
06:04 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute: >This should be already covered in branch 2563b @FrameGuiImpl.processDefaultButton@ - please double check this branch... Eugenie Lyzenko
05:51 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute: Eugenie Lyzenko wrote:
> The conclusion is only @DEFAULT-BUTTON@ frame option has meaning when defining the button t... Constantin Asofiei
05:32 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute: >Write the following testcases to check behavior:
>
>1. Does @BUTTON:DEFAULT@ without frame's @DEFAULT-BUTTON@ opti... Eugenie Lyzenko
05:39 PM Database Bug #2552 (Closed): bad hql caching prevents queries to position on the correct rows: The change fixed the unit tests I was targeting.
I rebased 2552a to trunk rev. 10888 to pick up Hynek's redirected... Eric Faulhaber
04:24 PM Base Language Bug #2592: improve support for implicit type conversions: The issue for Hynek's earlier work is #2293. Eric Faulhaber
04:18 PM Base Language Bug #2592: improve support for implicit type conversions: As I was reviewing this code, I was wondering why @VariableAssigner@ and @OutputParameterAssigner@ were not in the @c... Eric Faulhaber
02:48 PM Base Language Bug #2592: improve support for implicit type conversions: After running the testcase procedure against P4GL, I was able to detect the cases where the automatic/implicit conver... Ovidiu Maxiniuc
12:54 PM User Interface Feature #1790: implement menu support: Vadim Gindin wrote:
> > Lets change the approach to this: take the menubar's clipping rectangle and, if the ScreenBi... Constantin Asofiei
12:32 PM User Interface Feature #1790: implement menu support: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Constantin Asofiei wrote:
> > > Vadim Gindin wrote:
> > > > >... Vadim Gindin
11:30 AM User Interface Feature #1790: implement menu support: Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Vadim Gindin wrote:
> > > > A solution would be to repaint the... Constantin Asofiei
10:27 AM User Interface Feature #1790: implement menu support: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > > A solution would be to repaint the entire menubar or sub-menu... Vadim Gindin
09:48 AM User Interface Feature #1790: implement menu support: > But when I did this change, the error didn't disappear. Was I wrong? Could you have a look at it?
Your change do... Greg Shah
06:53 AM User Interface Feature #1790: implement menu support: Vadim Gindin wrote:
> > A solution would be to repaint the entire menubar or sub-menu on mouseEnter/Exit. But I th... Constantin Asofiei
06:34 AM User Interface Feature #1790: implement menu support: Constantin Asofiei wrote:
> What I think is happening is this:
> * you are calling a @repaint()@ for a certain menu... Vadim Gindin
06:04 AM User Interface Feature #1790: implement menu support: Constantin, thank you, I'll try.
Greg, I've faced with parsing error with the following procedure:... Vadim Gindin
04:45 AM User Interface Feature #1790: implement menu support: What I think is happening is this:
* you are calling a @repaint()@ for a certain menu-item; this ensures that an inv... Constantin Asofiei
03:31 AM User Interface Feature #1790: implement menu support: Constantin, I have a problem with mouse ENTER and EXIT events processing. When I move mouse pointer from one menu-ite... Vadim Gindin
04:22 AM User Interface Feature #2252: implement GUI client support: Rebased task branch 1796b from P2J trunk revision 10888 (branch revision 10890). Constantin Asofiei
04:21 AM User Interface Feature #2563: implement GUI EDITOR widget: Rebased task branch 2563b from P2J trunk revision 10888 (new branch revision 10892). Constantin Asofiei

06/28/2015

07:58 PM User Interface Feature #2546: implement combo-box widget in GUI: Merge with recent code base for review. In addition the event list chaining in drop-down cycle is now filtering to co... Eugenie Lyzenko
05:37 AM User Interface Bug #2601: Implement gap closing mechanism for browse: When some of the records contained in a browse are deleted in background (by @DELETE@, not @DELETE-*-ROW(S)@), "gaps"... Stanislav Lomany
04:11 AM User Interface Bug #2601 (New): Implement gap closing mechanism for browse: Stanislav Lomany
05:24 AM User Interface Feature #2252: implement GUI client support: Task branch 2559d passed regression testing and was committed to trunk as revision 10888. Hynek Cihlar

06/27/2015

08:14 PM User Interface Feature #2546: implement combo-box widget in GUI: Finally the update merged with the recent code base is ready with all fixes required:
1. Resolution for previous upd... Eugenie Lyzenko
08:12 PM User Interface Bug #2600: Implement proper refresh after deletion if the deleted row is a new row outside of the...: Example of the behavior - @uast/browse/brws-offset5.p@:
down to 10, n, esc-R, up to 1, d - scrolled to 10.
The ... Stanislav Lomany

06/26/2015

07:45 PM User Interface Bug #2600 (New): Implement proper refresh after deletion if the deleted row is a new row outside ...: Stanislav Lomany
07:13 PM User Interface Bug #2599: 4GL makes selection invalid after row deletion: 4GL makes selection invalid if we have deleted a selected row and there was a new row in the set of selected rows.
... Stanislav Lomany
07:08 PM User Interface Bug #2599 (New): 4GL makes selection invalid after row deletion: Stanislav Lomany
04:12 PM User Interface Bug #2598: Adding new row in REPLACE mode causes quirk: Scenario:... Stanislav Lomany
03:55 PM User Interface Bug #2598 (New): Adding new row in REPLACE mode causes quirk: Stanislav Lomany
04:03 PM Base Language Bug #2592: improve support for implicit type conversions: The testcases project was updated with @uast/procedures/conversion-params.p@. It contains the matrix for conversion p... Ovidiu Maxiniuc
12:53 PM Base Language Bug #2592: improve support for implicit type conversions: The branch 2592 has been updated and rebased (main trunk revision 10887). It is not at revision 10892.
It passed my ... Ovidiu Maxiniuc
11:58 AM User Interface Feature #2252: implement GUI client support: Code Review Task Branch 2559d Revision 10888
The changes look good to me. Please get them tested. Greg Shah
11:31 AM User Interface Feature #2252: implement GUI client support: For #2559 I have:
Fixed calculation of workspace size in redirection mode.
Fixed some unhandled exceptions when s... Hynek Cihlar
06:19 AM User Interface Bug #2597: Rows are quirky committed on insert-row() call.: General description:
1. Update some row 1.
2. Leave it by calling INSERT-ROW in a trigger. Row 1 will contain updat... Stanislav Lomany
05:37 AM User Interface Bug #2597 (New): Rows are quirky committed on insert-row() call.: Stanislav Lomany
01:48 AM Database Bug #2552 (WIP): bad hql caching prevents queries to position on the correct rows: I've re-opened this task to address a defect: it is possible for the @HQLPreprocessor@ to create invalid ASTs when th... Eric Faulhaber

06/25/2015

07:47 PM User Interface Feature #2546: implement combo-box widget in GUI: The condition of the application to finish is the pressing @RETURN@ key. It is very strange because it is happening e... Eugenie Lyzenko
06:38 PM User Interface Feature #2422: add features to BROWSE: Code Review svl_upd20150625a.zip
I'm OK with the changes. Please get them regression tested. Greg Shah
04:45 PM User Interface Feature #2422: add features to BROWSE: Update for review. Fixes issue from the checklist in item 178. Stanislav Lomany
07:43 AM User Interface Feature #2422: add features to BROWSE: OK, add this to the quirks list. Greg Shah
06:12 PM User Interface Bug #2596: Implement missing browse quirks.: Parent task for tracking browse quirks. Stanislav Lomany
06:09 PM User Interface Bug #2596 (New): Implement missing browse quirks.: Stanislav Lomany
12:25 PM Base Language Bug #2592: improve support for implicit type conversions: Very good plan and design. Greg Shah
11:50 AM Base Language Bug #2592: improve support for implicit type conversions: Support for variables.
I am thinking of the following changes in code:
* an abstract class @Assigner@ with @BaseDat... Ovidiu Maxiniuc
11:31 AM Base Language Bug #2592: improve support for implicit type conversions: These are very good points (the complete matrix and the support for variables). I think both of these issues need to... Greg Shah
10:10 AM Base Language Bug #2592 (WIP): improve support for implicit type conversions: I updated the code according your reviews. The new revno is 10890.
Constantin: your 2nd question is very good. I n... Ovidiu Maxiniuc
04:26 AM Base Language Bug #2592: improve support for implicit type conversions: Greg Shah wrote:
> Constantin: as the owner of @ControlFlowOps@, do you have any concerns with the update?
The logi... Constantin Asofiei
07:10 AM User Interface Feature #2412: Implement widget browser: The task branch 2412a was committed to trunk revision 10887. Hynek Cihlar

06/24/2015

07:11 PM User Interface Feature #2422: add features to BROWSE: Regarding "Check how addition of new row works in multiple selection mode (last selected row is used?)". Looks like a... Stanislav Lomany
05:34 PM User Interface Feature #2422: add features to BROWSE: Addition to "In 4GL (ChUI) last/first rows has invalid row value." behavior: if the value of the current cell was mod... Stanislav Lomany
11:04 AM User Interface Feature #2422: add features to BROWSE: > LABEL-BGCOLOR, MOVE-COLUMN and MIN-HEIGHT-CHARS are GUI-specific.
OK, I see they are already listed in #2564. ... Greg Shah
10:59 AM User Interface Feature #2422: add features to BROWSE: Yes, but LABEL-BGCOLOR, MOVE-COLUMN and MIN-HEIGHT-CHARS are GUI-specific. Stanislav Lomany
10:53 AM User Interface Feature #2422: add features to BROWSE: SET-REPOSITIONED-ROW - used
MODIFIED - used
LABEL-BGCOLOR - used
MOVE-COLUMN - used
MIN-HEIGHT-CHARS - not sure; ... Greg Shah
06:01 PM User Interface Feature #2412: Implement widget browser: Code Review Task Branch 2412a Revision 10887
The changes are OK. Greg Shah
05:33 PM User Interface Feature #2412: Implement widget browser: I have improved Widget Browser GUI highlight. Restoring the highlighted area was causing artifacts. Also the highligh... Hynek Cihlar
05:31 PM User Interface Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Greg, do we need SPACE in GUI? I was playing with some ChUI tests and GUI doesn't suppor... Greg Shah
05:07 PM User Interface Feature #2252: implement GUI client support: Greg, do we need SPACE in GUI? I was playing with some ChUI tests and GUI doesn't support yet the SPACE clause. Constantin Asofiei
05:04 PM Base Language Bug #2592 (New): improve support for implicit type conversions: Code Review Task Branch 2592 Revision 10889
The core functionality seems good.
1. In @FieldAssigner.assign()@ y... Greg Shah
03:53 PM Base Language Bug #2592: improve support for implicit type conversions: 10889 looks good, thanks, but I still want Greg or Constantin's stamp of approval, particularly on the @ControlFlowOp... Eric Faulhaber
03:48 PM Base Language Bug #2592 (WIP): improve support for implicit type conversions: New changes committed to revision 10889. Ovidiu Maxiniuc
03:29 PM Base Language Bug #2592: improve support for implicit type conversions: Code review 10888:
This looks good to me, with 2 very minor points:
* Please rename @FieldAssigner$Scope.list@ to... Eric Faulhaber
03:01 PM Base Language Bug #2592: improve support for implicit type conversions: The branch has been updated to revision 10888. I already tested with ETF and it passed all +JULIAN_DATE tests that we... Ovidiu Maxiniuc
01:32 PM Base Language Bug #2592: improve support for implicit type conversions: Ovidiu Maxiniuc wrote:
> Looks like my idea from note 7 can be easier implemented thanks to the @List<FieldAssigner>... Eric Faulhaber
12:40 PM Base Language Bug #2592: improve support for implicit type conversions: > Sorry for these incremental status updates.
You have done exactly the right thing in posting these different ide... Greg Shah
12:30 PM Base Language Bug #2592: improve support for implicit type conversions: Looks like my idea from note 7 can be easier implemented thanks to the @List<FieldAssigner>@ from @FieldAssigner@ con... Ovidiu Maxiniuc
11:55 AM Base Language Bug #2592: improve support for implicit type conversions: After further thinking:
what if we allow the internal variable from @FieldAssigner@ to be updated. For example, if t... Ovidiu Maxiniuc
10:47 AM Base Language Bug #2592: improve support for implicit type conversions: I have created branch 2592 from the main trunk (revno 10886). I committed the intermediary changes in @ControlFlowOps... Ovidiu Maxiniuc
10:06 AM Base Language Bug #2592: improve support for implicit type conversions: I started the implementation for the optional conversions in message passing parameters. The forward checking is done... Ovidiu Maxiniuc
12:11 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Please see #2594 - Implement a tracing facility for P2J. Hynek Cihlar
10:55 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> Greg Shah wrote:
> > My point: I'd like this approach to be a "dtrace" for P2J. But as yo... Greg Shah
10:23 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> My point: I'd like this approach to be a "dtrace" for P2J. But as you say, the AspectJ approach ... Igor Skornyakov
10:04 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: > The Aspect-way of monitoring method calls is slow, maybe it would make more sense to use the java.lang.instrument ... Greg Shah
09:57 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150623b.zip
I'm good with the changes. Greg Shah
12:08 PM Runtime Infrastructure Feature #2594: Implement a tracing facility for P2J: When trying to understand internal workings of a complex system like P2J - spanning multiple hosts, processes and thr... Hynek Cihlar
11:04 AM Runtime Infrastructure Feature #2594 (New): Implement a tracing facility for P2J: Hynek Cihlar
09:41 AM User Interface Feature #2546: implement combo-box widget in GUI: Greg Shah wrote:
> In addition to making the processing safer for drop-down, isn't the real problem that the trigger... Eugenie Lyzenko
09:22 AM User Interface Feature #2546: implement combo-box widget in GUI: In addition to making the processing safer for drop-down, isn't the real problem that the trigger processing should b... Greg Shah
09:04 AM User Interface Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Yes, the @DropDown@ doesn't have an ID yet. You can add a v... Constantin Asofiei
08:54 AM User Interface Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Review for 0622a.zip:
> > * @ComboBoxConfig@ - the added im... Constantin Asofiei
08:35 AM User Interface Feature #2546: implement combo-box widget in GUI: Constantin Asofiei wrote:
> Review for 0622a.zip:
> * @ComboBoxConfig@ - the added imports are unused
Please cla... Eugenie Lyzenko
08:30 AM User Interface Feature #2546: implement combo-box widget in GUI: Constantin Asofiei wrote:
> Yes, the @DropDown@ doesn't have an ID yet. You can add a virtual ID to it via @WidgetI... Eugenie Lyzenko
04:10 AM User Interface Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> The root cause for ignoring trigger call has been found. During obtaining the server method... Constantin Asofiei
03:57 AM User Interface Feature #2546: implement combo-box widget in GUI: Review for 0622a.zip:
* @ComboBoxConfig@ - the added imports are unused
* @DropDown@ - the @fixVisibleRows@ abstrac... Constantin Asofiei
08:30 PM User Interface Feature #2546: implement combo-box widget in GUI: The root cause for ignoring trigger call has been found. During obtaining the server method from proxy class the all ... Eugenie Lyzenko
09:24 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods: Greg Shah wrote:
> I don't know the answer, but usually the option is just the static way (compile-time) to define a... Igor Skornyakov
09:18 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods: I don't know the answer, but usually the option is just the static way (compile-time) to define a feature as part of ... Greg Shah
05:07 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods: It looks like there is very much in common between "Options" and "Attributes" sections in this task. Is there any dif... Igor Skornyakov
07:59 AM User Interface Feature #1790: implement menu support: Here is the current update Vadim Gindin
03:27 AM User Interface Feature #1790: implement menu support: Vadim Gindin wrote:
> Please, hepl my with my previous question about duplication. I still didn't find the reason.
... Constantin Asofiei
03:15 AM User Interface Feature #1790: implement menu support: Vadim Gindin wrote:
> Duplication error has gone after the last Hynek's update! Sorry to trouble.
Please post your ... Constantin Asofiei

06/23/2015

05:34 PM User Interface Feature #2422: add features to BROWSE: > Please make a list of browse features (methods, attributes, options) which are stubbed out but which have no runtim... Stanislav Lomany
03:42 PM User Interface Feature #2422: add features to BROWSE: For both of these quirks, can you easily detect that the problem would occur? If so, then let's detect those cases (... Greg Shah
03:28 PM User Interface Feature #2422: add features to BROWSE: > What does the implementation do today when there is an uncommitted update and INSERT-ROW() is called
At that tim... Stanislav Lomany
02:35 PM User Interface Feature #2422: add features to BROWSE: It seems that there are a very large number of postponed browse quirks already. We need a much better approach to tra... Greg Shah
02:31 PM User Interface Feature #2422: add features to BROWSE: > Unless it is the first column, you cannot change copied value (only navigation and trigger keys work) until you re-... Greg Shah
02:29 PM User Interface Feature #2422: add features to BROWSE: > Side note: in multi-selection browse if a new row is selected and DELETE-CURRENT-ROW/DELETE-SELECTED-ROW was called... Greg Shah
02:27 PM User Interface Feature #2422: add features to BROWSE: > Actually rows get to the quirky state. The scenario:
> ...
> Should I reproduce this quirk?
What does the impl... Greg Shah
02:23 PM User Interface Feature #2422: add features to BROWSE: Stanislav Lomany wrote:
> It is not implemented at runtime (@Browse.java@):
>
> [...]
This is not good. I did... Greg Shah
10:11 AM User Interface Feature #2422: add features to BROWSE: Addition to note 180 ("In 4GL (ChUI) last/first rows has invalid row value"). Unless it is the first column, you cann... Stanislav Lomany
07:35 AM User Interface Feature #2422: add features to BROWSE: Greg,
> Check if new/existing rows are undone or committed on insert-row() call.
Actually rows get to the quirk... Stanislav Lomany
05:18 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Fixed based on code review Igor Skornyakov
04:41 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> Hynek Cihlar wrote:
> > Igor, I will not give you an answer to your question but I will at least... Hynek Cihlar
03:38 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150623a.zip
1. @FillIn.isZapActive()@ is missing javadoc and needs a blank line after it.
... Greg Shah
02:47 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: All done. Started regesssion testing. Igor Skornyakov
02:44 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Hynek Cihlar wrote:
> Igor, I will not give you an answer to your question but I will at least share with you a litt... Greg Shah
02:37 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> I found useful to add a method @LogicalTerminal.debug(int widgetId, message)@ and a corresp... Greg Shah
12:50 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> >
> Thank you Hynek,
> What you've mentioned can be very useful indeed. However I had an... Hynek Cihlar
12:38 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Hynek Cihlar wrote:
> Igor, I will not give you an answer to your question but I will at least share with you a litt... Igor Skornyakov
12:28 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor, I will not give you an answer to your question but I will at least share with you a little bit from my kitchen.... Hynek Cihlar
05:01 PM Database Bug #2591: incorrect queries when MATCH operator is involved: Committed to bzr as revno 10886. Ovidiu Maxiniuc
04:17 PM Database Bug #2591: incorrect queries when MATCH operator is involved: Please commit. Eric Faulhaber
03:57 PM Database Bug #2591: incorrect queries when MATCH operator is involved: Taking into account the changes involved, I deem the update passed the regression testing. It looks like it did well ... Ovidiu Maxiniuc
01:40 PM User Interface Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > The task branch 2559b has been... Hynek Cihlar
01:35 PM User Interface Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The task branch 2559b has been merged with trunk. Eugenie, you ... Constantin Asofiei
11:29 AM User Interface Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> The task branch 2559b has been merged with trunk. Eugenie, you can now merge the fixes by upda... Constantin Asofiei
12:53 PM User Interface Feature #2559 (Closed): implement ALERT-BOX support: Greg Shah
11:58 AM User Interface Feature #1790: implement menu support: Duplication error has gone after the last Hynek's update! Sorry to trouble. Vadim Gindin
11:22 AM User Interface Feature #1790: implement menu support: Vadim Gindin wrote:
> Please, help me with my previous question about duplication. I still didn't find the reason.
... Vadim Gindin
11:01 AM User Interface Feature #1790: implement menu support: Please, hepl my with my previous question about duplication. I still didn't find the reason.
Additional question. ... Vadim Gindin
08:44 PM User Interface Feature #2546: implement combo-box widget in GUI: The update contains combo-box changes merged with recent code base without recently distributed @Scrollbar@ changes.
... Eugenie Lyzenko

06/22/2015

06:46 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: I found useful to add a method @LogicalTerminal.debug(int widgetId, message)@ and a corresponding (noop) method @Abst... Igor Skornyakov
04:47 PM User Interface Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> The task branch 2559b has been merged with trunk. Eugenie, you can now merge the fixes by upda... Eugenie Lyzenko
04:14 PM User Interface Feature #2252: implement GUI client support: The task branch 2559b has been merged with trunk. Eugenie, you can now merge the fixes by updating the trunk branch. Hynek Cihlar
10:51 AM User Interface Feature #2252: implement GUI client support: Greg, there is a change that affects ChUI so I would like to finish regression testing first. Hynek Cihlar
10:13 AM User Interface Feature #2252: implement GUI client support: Hynek: I think you should merge task branch 2559b revision 10883 with trunk and commit it. This will allow Eugenie t... Greg Shah
08:54 AM User Interface Feature #2252: implement GUI client support: Eugenie Lyzenko wrote:
> >The main window height was not properly calculated and so the scrollbar was shown when it ... Hynek Cihlar
04:01 PM Database Bug #2591 (WIP): incorrect queries when MATCH operator is involved: The 1st round of testing just ended. There are a lot (17) of failures in @gso_ctrlc_tests@ and some in @tc_tests@ (11... Ovidiu Maxiniuc

06/21/2015

06:02 PM User Interface Feature #2252: implement GUI client support: >The main window height was not properly calculated and so the scrollbar was shown when it should not have. This is a... Eugenie Lyzenko
02:55 PM User Interface Feature #2252: implement GUI client support: Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > For #2559, please review regression fixes committed to task branch... Hynek Cihlar

06/20/2015

01:53 PM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review Task Branch 2559b Revision 10883
>
> I'm fine with the changes.
>
> Am I correc... Hynek Cihlar
10:46 AM User Interface Feature #2252: implement GUI client support: Code Review Task Branch 2559b Revision 10883
I'm fine with the changes.
Am I correct to assume the other items ... Greg Shah
10:29 AM User Interface Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> For #2559, please review regression fixes committed to task branch 2559b. The changes do not a... Eugenie Lyzenko
06:41 AM User Interface Feature #2252: implement GUI client support: For #2559, please review regression fixes committed to task branch 2559b. The changes do not affect ChUI so no Majic ... Hynek Cihlar
12:11 AM Database Bug #2591 (Test): incorrect queries when MATCH operator is involved: Nice work tracking this down quickly and fixing it. 10882 on branch looks good. Please regression test. I'll run unit... Eric Faulhaber

06/19/2015

05:18 PM User Interface Feature #2252: implement GUI client support: Task branch 2559 has been committed to bzr trunk, revision 10882. Hynek Cihlar
09:26 AM User Interface Feature #2252: implement GUI client support: Code Review Task Branch 2559 rev 10881
I'm good with the changes. Please merge to trunk, commit and notify. Greg Shah
09:21 PM User Interface Feature #2252: implement GUI client support: For #2559, I have resolved all the points from the last review, fixed all regressions and other bugs found. The chang... Hynek Cihlar
04:08 PM User Interface Feature #2546: implement combo-box widget in GUI: The update for review has implementation for @ThinClient@ change related to the mouse clicks outside drop-down. The n... Eugenie Lyzenko
10:44 PM User Interface Feature #2546: implement combo-box widget in GUI: The update for review has subtracted @Scrollbar@ related code that distributed separately. Also it contains suggested... Eugenie Lyzenko
10:07 PM User Interface Feature #2546: implement combo-box widget in GUI: Committed in bzr as @10881@. Eugenie Lyzenko
09:52 PM User Interface Feature #2546: implement combo-box widget in GUI: Testing completed, no regressions, had to run 3-way CTRL-C tests in separate session. The results are: @10879_bb2f7ec... Eugenie Lyzenko
08:25 PM User Interface Feature #2546: implement combo-box widget in GUI: Finally the main part of the testing for 0617b completed without regressions. I'm expecting to finish @CTRL-C@ testin... Eugenie Lyzenko
03:41 PM Base Language Bug #2592: improve support for implicit type conversions: I continued by digging into procedure call mechanism. In @ControlFlowOps@, there is @InternalEntryCaller.validate()@ ... Ovidiu Maxiniuc
03:39 PM Base Language Bug #2592: improve support for implicit type conversions: On 06/19/2015 10:04 PM, Constantin Asofiei wrote:
> Eric/Ovidiu,
>
> This is a new discovery. And it looks like i... Ovidiu Maxiniuc
03:38 PM Base Language Bug #2592: improve support for implicit type conversions: I found the following external procedure @caller.p@:... Ovidiu Maxiniuc
03:36 PM Base Language Bug #2592 (Closed): improve support for implicit type conversions: Ovidiu Maxiniuc
01:41 PM User Interface Feature #2563: implement GUI EDITOR widget: Greg Shah wrote:
> My only question is whether you want to go before or after Igor's #2534 changes?
I'd like to go ... Constantin Asofiei
12:34 PM User Interface Feature #2563: implement GUI EDITOR widget: > I have already checked in and distributed the 0617b Scrollbar related update.
Right, sorry.
> It is required... Greg Shah
11:08 AM User Interface Feature #2563: implement GUI EDITOR widget: Greg Shah wrote:
> ... I know you are waiting on Eugenie's to pass and be checked in and then will merge those...
... Eugenie Lyzenko
10:51 AM User Interface Feature #2563: implement GUI EDITOR widget: Code Review Task Branch 2563b revision 10884
I like the changes, nice improvement.
Hynek's changes will need to... Greg Shah
05:54 AM User Interface Feature #2563: implement GUI EDITOR widget: rebased branch 2563b, new revision is 10884 Constantin Asofiei
01:07 PM User Interface Feature #1790: implement menu support: I've fixed it. But now it displays sub-menu twice in 2 different places. Have a look please. Why it can happen? Vadim Gindin
06:46 AM User Interface Feature #1790: implement menu support: Vadim Gindin wrote:
> Here is my current update. Could you review and help me? I can't understand why nested sub-men... Constantin Asofiei
03:58 AM User Interface Feature #1790: implement menu support: Here is my current update. Could you review and help me? I can't understand why nested sub-menu body isn't drawn when... Vadim Gindin
01:01 PM Database Bug #2591: incorrect queries when MATCH operator is involved: For review, this is branch 2591a/, at revision 10882. Ovidiu Maxiniuc
11:22 AM Database Bug #2591: incorrect queries when MATCH operator is involved: One test (CUSTOMER_SITE_7) of in the customer's testing batch was failing (not finding the record) for unknown reason... Ovidiu Maxiniuc
11:06 AM Database Bug #2591 (Closed): incorrect queries when MATCH operator is involved: Ovidiu Maxiniuc

06/18/2015

04:12 PM User Interface Feature #2563: implement GUI EDITOR widget: branch 2563b/rev 10882 passed testing Constantin Asofiei
08:19 AM User Interface Feature #2563: implement GUI EDITOR widget: branch 2563b/rev 10882: Fixed javadoc errors. Added mouse-double-click support. Fixed scrolling by mouse and other ... Constantin Asofiei
01:42 PM User Interface Feature #2546: implement combo-box widget in GUI: One more point to clarify.
I'm trying to make the drop-down list event processing loop more reliable an responsibl... Eugenie Lyzenko
02:30 AM User Interface Feature #2422: add features to BROWSE: It is not implemented at runtime (@Browse.java@):... Stanislav Lomany

06/17/2015

06:39 PM Database Bug #2589: remote request for next primary key gives wrong result when metadata DB is running: Requesting a next primary key for a database controlled by a remote server returns very low id numbers, typically sta... Eric Faulhaber
06:30 PM Database Bug #2589 (New): remote request for next primary key gives wrong result when metadata DB is running: Eric Faulhaber
05:05 PM User Interface Feature #2422: add features to BROWSE: I don't understand. As far as I can see, we already support @SET-REPOSITIONED-ROW@ both at runtime and in conversion... Greg Shah
04:55 PM User Interface Feature #2422: add features to BROWSE: > Doesn't @GET-REPOSITIONED-ROW@ still need to be done?
@GET-REPOSITIONED-ROW@ always returns _1_ unless the row w... Stanislav Lomany
11:37 AM User Interface Feature #2422: add features to BROWSE: >> What else is open in this task?
>
> My checklist:
> ...
Doesn't @GET-REPOSITIONED-ROW@ still need to be done? Greg Shah
03:44 PM User Interface Feature #2563: implement GUI EDITOR widget: Code Review 2563b branch (rev 10881)
This is a really good update. I don't have any concerns. Greg Shah
02:28 PM User Interface Feature #2563: implement GUI EDITOR widget: I've added the EDITOR changes (and some scroll-related changes from #2546 - rev 10880) to the 2563b branch (rev 10881... Constantin Asofiei
02:39 PM User Interface Feature #2546: implement combo-box widget in GUI: Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> > Here it is.
> @ScrollEvent@ class is needed - please add th... Eugenie Lyzenko
01:48 PM User Interface Feature #2546: implement combo-box widget in GUI: Code Review evl_upd20150617a.zip
I'm OK with the changes. Please get them regression tested. Greg Shah
01:42 PM User Interface Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Eugenie, can you extract the changes in the @Scrollbar*@ cla... Constantin Asofiei
10:34 AM User Interface Feature #2546: implement combo-box widget in GUI: Constantin Asofiei wrote:
> Eugenie, can you extract the changes in the @Scrollbar*@ classes in a separate update, s... Eugenie Lyzenko
09:49 AM User Interface Feature #2546: implement combo-box widget in GUI: Eugenie, can you extract the changes in the @Scrollbar*@ classes in a separate update, so they can be released? I thi... Constantin Asofiei
09:12 AM User Interface Feature #2546: implement combo-box widget in GUI: > And I'm inclining to leave the current approach for ChUI only mode and implement completely different approach in G... Greg Shah
09:09 AM User Interface Feature #2546: implement combo-box widget in GUI: Code Review evl_upd20150616a.zip
The code changes are fine. Greg Shah
08:51 PM User Interface Feature #2546: implement combo-box widget in GUI: The today update has small changes to event processing. The new class I have introduced in one previous update - @Com... Eugenie Lyzenko

06/16/2015

11:37 AM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute: It looks like button's DEFAULT attribute does not need to be checked in @FrameGuiImpl.processDefaultButton()@. Press... Greg Shah
11:28 AM User Interface Bug #2588 (Closed): test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTT...: Greg Shah
11:29 AM User Interface Feature #2563: implement GUI EDITOR widget: > Looks like the Progress bug or documentation miss. So we have to decide what strategy we will take here.
It does... Greg Shah
10:48 AM User Interface Feature #2546: implement combo-box widget in GUI: Greg Shah wrote:
> Code Reviews evl_upd20150611a.zip evl_upd20150613a.zip evl_upd20150614a.zip evl_upd20150615a.z... Eugenie Lyzenko
10:36 AM User Interface Feature #2546: implement combo-box widget in GUI: Code Reviews evl_upd20150611a.zip evl_upd20150613a.zip evl_upd20150614a.zip evl_upd20150615a.zip
I am generally... Greg Shah
10:17 AM User Interface Feature #1794: implement font support: There is a very useful discussion and tutorial in #2546 notes 92 and 98. This explains some problems with matching f... Greg Shah
09:09 AM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> > Btw., WindowGuiImpl.resolveTitleFont() allows to override the title font by the value of the wi... Constantin Asofiei
09:00 AM User Interface Feature #2252: implement GUI client support: > Btw., WindowGuiImpl.resolveTitleFont() allows to override the title font by the value of the window's BaseConfig.ti... Greg Shah
06:08 AM User Interface Feature #2252: implement GUI client support: Greg Shah wrote:
> 1. The @AbstractWidget@ parent/ancestor lookup processing is much improved. It is easier to read... Hynek Cihlar

06/15/2015

05:08 PM User Interface Feature #2252: implement GUI client support: Code Review hc_upd20150612b.zip
This is a really nice improvement. I especially like the way you abstracted the a... Greg Shah
04:37 PM User Interface Feature #2546: implement combo-box widget in GUI: The metrics for the combo-box widget have already been captured into @uast/combo_box/metrics/@ folder (they are all f... Constantin Asofiei
09:38 AM User Interface Feature #2546: implement combo-box widget in GUI: Clarification about @VALUE-CHANGED@ event generation:
In all three modes mouse click and keyboard @UP@/@DOWN@ caus... Eugenie Lyzenko
08:30 AM User Interface Feature #2546: implement combo-box widget in GUI: Small change to fix entry field selection draw in @DROP-DOWN@ mode when drop-down list become active. Eugenie Lyzenko
11:28 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150612a.zip
Please go ahead with the merge. Stanislav's changes have been checked in. Here ... Greg Shah
11:01 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> Regarding the previous question. Is it OK to add a separate method @setInititialInnerLines(... Greg Shah

06/14/2015

06:04 PM User Interface Feature #2546: implement combo-box widget in GUI: More features findings for 4GL combo-box.
1. When combo-box is in @SIMPLE@ or @DROP-DOWN@ modes the entry field keep... Eugenie Lyzenko
09:10 AM User Interface Feature #2546: implement combo-box widget in GUI: Merged with recent @10879@ code base. Eugenie Lyzenko
04:41 AM User Interface Feature #2422: add features to BROWSE: INSERT-ROW, CURSOR-OFFSET, AUTO-ZAP and CURRENT-ROW-MODIFIED. Committed to bzr rev 10879. Stanislav Lomany

06/13/2015

05:55 PM User Interface Feature #2546: implement combo-box widget in GUI: The update for review fixes the drop-down incorrect coordinates setting. The idea is based on the fact the drop-down ... Eugenie Lyzenko

06/12/2015

06:30 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Fixed EDITOR regression, fixed all issues mentioned in the code review except the FRAME realization (only @VIEW@ and ... Igor Skornyakov
05:13 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Regarding the previous question. Is it OK to add a separate method @setInititialInnerLines()@ for use in compilation ... Igor Skornyakov
04:43 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: I have a problem. P2J compiles
DEFINE VARIABLE sl AS CHARACTER NO-UNDO
VIEW-AS SELECTION-LIST
INNER-LINES ... Igor Skornyakov
09:25 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> Please set it to M12.
Done. Igor Skornyakov
09:23 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Please set it to M12. Greg Shah
09:22 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> You can add watchers later, using the "Watchers (x)" section at the right side-bar of the task pa... Igor Skornyakov
09:19 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: > BTW: I've created another task #2582 as per Constantin request but forgot to add watches at the creation and I do n... Greg Shah
09:09 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> No. Please create a new task in the UI project and set its target version to M12. Also add me a... Igor Skornyakov
08:52 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: > Should I fix this bug in the scope of this task?
No. Please create a new task in the UI project and set its ta... Greg Shah
06:06 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: With P2L FillInWidget.getScreenValue() returns blank if the first read access was when the focus was in the different... Igor Skornyakov
03:41 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> Besides the items requested from the code review, what else still needs to be done for this task?... Igor Skornyakov
04:45 PM User Interface Feature #2563: implement GUI EDITOR widget: >Eugenie, new question: are you sure the button's DEFAULT attribute needs to be checked in @FrameGuiImpl.processDefau... Eugenie Lyzenko
04:09 PM User Interface Feature #2563: implement GUI EDITOR widget: Eugenie, new question: are you sure the button's DEFAULT attribute needs to be checked in @FrameGuiImpl.processDefaul... Constantin Asofiei
04:32 PM User Interface Feature #2252: implement GUI client support: The attached implements ALERT-BOX widget in Swing GUI. As related changes it also adds support for modal windows and ... Hynek Cihlar
09:04 AM User Interface Bug #2586: FillInWidget.getScreenValue() incorretly returns blank: Another minor issue with the @FillInWidget.getScreenValue()@
If you run p2j conversion of this test and type a space... Igor Skornyakov
08:56 AM User Interface Bug #2586: FillInWidget.getScreenValue() incorretly returns blank: ith P2L FillInWidget.getScreenValue() returns blank if the first read access was when the focus was in the different ... Igor Skornyakov
08:55 AM User Interface Bug #2586 (New): FillInWidget.getScreenValue() incorretly returns blank: Igor Skornyakov
06:05 AM User Interface Feature #2546: implement combo-box widget in GUI: Eugenie, first of all, see note 77 and the testcase at this note - the drop-down's coordinates are still incorrect. ... Constantin Asofiei
08:51 PM User Interface Feature #2546: implement combo-box widget in GUI: >That will be a memory leak. Static widgets shouldn't last for the application lifetime. They should only live while ... Eugenie Lyzenko
03:25 AM User Interface Feature #1790: implement menu support: Vadim Gindin wrote:
> I can check this field @WindowGuiImpl.mousePressedSource@ in @MenuItemGuiImpl.mouseMoved()@ to... Constantin Asofiei

06/11/2015

05:49 PM User Interface Feature #2546: implement combo-box widget in GUI: That will be a memory leak. Static widgets shouldn't last for the application lifetime. They should only live while ... Greg Shah
05:37 PM User Interface Feature #2546: implement combo-box widget in GUI: >My only question is about @WidgetRegistry.addContainer()@. How do those registered widgets get removed when they are... Eugenie Lyzenko
02:36 PM User Interface Feature #2546: implement combo-box widget in GUI: Code Review evl_upd20150610a.zip
I think this is very good. I especially like the new @EntryFieldGuiImpl@.
My ... Greg Shah
09:19 PM User Interface Feature #2546: implement combo-box widget in GUI: Some samples to illustrate @SIMPLE@ mode of the combo-box. Eugenie Lyzenko
08:56 PM User Interface Feature #2546: implement combo-box widget in GUI: The next update for review has the good shape combo-box implementation with all three modes available. Key and mouse ... Eugenie Lyzenko
05:33 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Besides the items requested from the code review, what else still needs to be done for this task? Greg Shah
01:13 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> I think it is realized the first time it is made visible. @ENABLE@ is just one way to make the... Igor Skornyakov
01:11 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: >> 3. Should GenericFrame.validateLayout() be called whenever the frame is realized (not just during ENABLE)?
>
> S... Greg Shah
11:23 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> Code Review ias_upd20150605a.zip
> 3. Should @GenericFrame.validateLayout()@ be called wheneve... Igor Skornyakov
10:29 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150605a.zip
1. I think we may want to implement a method in @GenericWidget@ for the core vali... Greg Shah
03:34 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> OK, the plan:
>
> 1. You can keep the @DISABLE-AUTO-ZAP@ support in the config and server-side... Igor Skornyakov
01:58 PM Database Bug #2488: replace runtime compilation of dynamic queries: Please commit and distribute 0611a. Thanks. Eric Faulhaber
01:48 PM Database Bug #2488: replace runtime compilation of dynamic queries: The attached update is basically the same as 0610a except for the comment form @build.xml@ removed and a cascading @i... Ovidiu Maxiniuc
12:28 PM Database Bug #2488: replace runtime compilation of dynamic queries: I tested the 0610a update with the full set of search unit tests. I can confirm that it fixed the problematic test an... Eric Faulhaber
01:46 AM Database Bug #2488: replace runtime compilation of dynamic queries: Code review 0610a:
Looks good. Assuming your local testing confirms it fixes the problem, please run conversion re... Eric Faulhaber
01:41 PM Database Bug #2552 (Closed): bad hql caching prevents queries to position on the correct rows: Eric Faulhaber
01:40 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows: The 0608c update passed the regression testing, was committed to bzr as revno 10876 and distributed by mail. Ovidiu Maxiniuc
09:31 AM User Interface Feature #2422: add features to BROWSE: Yes, you should go ahead and implement it. Inserting before the first or after the last seems like something that is... Greg Shah
09:21 AM User Interface Feature #2422: add features to BROWSE: > I would like you to please get the current update through regression testing and checked in. This will free up oth... Stanislav Lomany
09:04 AM User Interface Feature #2422: add features to BROWSE: I would like you to please get the current update through regression testing and checked in. This will free up other... Greg Shah
07:12 AM User Interface Feature #2422: add features to BROWSE: > What else is open in this task?
My checklist:
# Page up/down, home/end doesn't work in editable browse.
# Unin... Stanislav Lomany
02:35 AM User Interface Feature #1790: implement menu support: I'm trying to implement the following behavior. Assume we have menubar. Mouse pointer is located somewhere outside of... Vadim Gindin

06/10/2015

06:13 PM User Interface Feature #2422: add features to BROWSE: > AUTO-ZAP and CURSOR-OFFSET are done
OK.
> except separate task #2576. Let me know if I should work on this t... Greg Shah
12:11 PM User Interface Feature #2422: add features to BROWSE: > In regard to this comment @// Oddly enough, 4GL returns zap state of the FOCUSED fill-in, not necessarily this one@... Stanislav Lomany
11:36 AM User Interface Feature #2422: add features to BROWSE: > When do you expect to have everything 100% complete? Igor's work in #2534 is dependent upon your changes for @AUTO... Stanislav Lomany
10:49 AM User Interface Feature #2422: add features to BROWSE: Code Review svl_upd20150610a.zip
In regard to this comment @// Oddly enough, 4GL returns zap state of the FOCUSED ... Greg Shah
04:52 AM User Interface Feature #2422: add features to BROWSE: Removed excess function @isNewRow@ from the previous update. Stanislav Lomany
06:12 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: OK, the plan:
1. You can keep the @DISABLE-AUTO-ZAP@ support in the config and server-side getters/setters of your... Greg Shah
12:02 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Actually I suggest to retain a DISABLE-AUTO-ZAP support in the config and at the server-side (getters/setters).
Gr... Igor Skornyakov
11:48 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> Not for FILL-IN. But COMBO-BOX support is not part of Stanislav's work.
>
For the COMBO-BOX t... Igor Skornyakov
11:32 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: > Do you think that it makes sense for me to continue working on the AUTO-ZAP?
Not for FILL-IN. But COMBO-BOX sup... Greg Shah
11:19 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg,
As I can see my changes for the FillIn significantly intersect with ones of Stanislav. My first impression is ... Igor Skornyakov
10:44 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> Stanislav has also implemented @CURSOR-OFFSET@ for @FillIn@ in #2422.
Thank you Greg. Igor Skornyakov
10:42 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Stanislav has also implemented @CURSOR-OFFSET@ for @FillIn@ in #2422. Greg Shah
10:36 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Please look at Stanislav's most recent changes in #2422. He is making changes related to @AUTO-ZAP@ in @FillIn@. Sp... Greg Shah
02:53 PM User Interface Feature #1790: implement menu support: > I've found that such fields are exist not in config classes
They would only be put into config classes if the da... Greg Shah
12:01 PM User Interface Feature #1790: implement menu support: I've found that such fields are exist not in config classes, but in GUI widget classes itself. For example @ButtonGui... Vadim Gindin
11:56 AM User Interface Feature #1790: implement menu support: The question about widget (menu-item or sub-menu) state, that could be changed by mouse events: "mouse enter" (mouse ... Vadim Gindin
01:55 PM Database Bug #2488: replace runtime compilation of dynamic queries: I have a fix for the issue. There are 3 important changes:
# the @convert/variable_references.rules@ was added to ru... Ovidiu Maxiniuc
08:26 PM User Interface Feature #2546: implement combo-box widget in GUI: The next update for review has suggested approach for SIMPLE mode implementation. The idea is a bit different that us... Eugenie Lyzenko

06/09/2015

03:52 PM Database Bug #2488: replace runtime compilation of dynamic queries: The P4GL converted query is:... Ovidiu Maxiniuc
03:19 PM Database Bug #2488: replace runtime compilation of dynamic queries: I was able to duplicate the issue. One occurrence is in @test[Entity=|+TNCY_TENANT| TestType=|SEARCH| TestSubType=|SE... Ovidiu Maxiniuc
01:04 PM Database Bug #2536: improve dynamic query parser error handling: The logging level for exceptions was lowered to @FINE@ to keep the @CONFIG@ level free for configuration issues.
Th... Ovidiu Maxiniuc
10:01 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows: Eric Faulhaber wrote:
> I'll test this update tonight against the full set of search unit tests.
The test went well... Eric Faulhaber

06/08/2015

06:23 PM User Interface Bug #2582: Some key labels are not supported by p2j: The attached is the updated @key_code_report.p@ program which outputs additional key labels and its output. Igor Skornyakov
07:57 AM User Interface Bug #2582: Some key labels are not supported by p2j: P2J doesn't support some valid key labels (such as @CTRL-ALT-A@). The 4GL documentation contains misprints and is not... Igor Skornyakov
07:50 AM User Interface Bug #2582 (New): Some key labels are not supported by p2j: Igor Skornyakov
05:11 PM User Interface Feature #2422: add features to BROWSE: Update for review. INSERT-ROW, CURSOR-OFFSET, AUTO-ZAP and CURRENT-ROW-MODIFIED. Stanislav Lomany
02:55 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows: Code review 0608c:
I think the changes are OK. Please post your regression test results when finished. I'll test t... Eric Faulhaber
12:53 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows: This update should handle the main issue of this task: the caching of the hql-s. It will put into cache only the quer... Ovidiu Maxiniuc
02:22 PM Database Bug #2488: replace runtime compilation of dynamic queries: Please investigate the following error from the P2J server.log:... Eric Faulhaber
10:53 AM Base Language Bug #2578 (Closed): incorrect promotion of local defined variables: Nice work, Ovidiu. Eric Faulhaber
10:48 AM Base Language Bug #2578: incorrect promotion of local defined variables: The update passed the regression testing, was committed to bzr as revno 10874 and it was distributed by mail. Ovidiu Maxiniuc
04:27 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Constantin Asofiei wrote:
> Is this something you need for the current task? If not, please create another task unde... Igor Skornyakov
04:25 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor Skornyakov wrote:
> > > @Keyboard.keyCode(event)@ retu... Constantin Asofiei
03:31 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > @Keyboard.keyCode(event)@ returns -1 for some valid key labe... Igor Skornyakov
01:59 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> @Keyboard.keyCode(event)@ returns -1 for some valid key labels (such as @CTRL-ALT-X@). As a... Constantin Asofiei

06/07/2015

11:32 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: I think I understand what's up. Some keycodes in 4GL have different labels and @keylabel@ function returns only one o... Igor Skornyakov
11:07 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> We have something like that already, see @testcases/uast/keyboards/key_code_report.p@
>
> We d... Igor Skornyakov
10:57 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: We have something like that already, see @testcases/uast/keyboards/key_code_report.p@
We did use that (and some ot... Greg Shah
10:49 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> Please post the list of which key labels you have found which are wrong. For each one, please al... Igor Skornyakov
09:49 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Please post the list of which key labels you have found which are wrong. For each one, please also post the key code... Greg Shah
05:48 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: @Keyboard.keyCode(event)@ returns -1 for some valid key labels (such as @CTRL-ALT-X@). As a result (?) the trigger @O... Igor Skornyakov

06/06/2015

12:21 PM Base Language Bug #2578: incorrect promotion of local defined variables: Update 0605a did well with the full group of search unit tests. Eric Faulhaber

06/05/2015

04:28 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Let fi be a FILL-IN widget. According to my tests the AUTO-ZAP and DISABLE-AUTO-ZAP attributes' behavior is as descri... Igor Skornyakov
12:25 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> For now, just put a very clear TODO into the code at that point. The bug is obscure and hopefu... Igor Skornyakov
12:17 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: > At this moment the only way to fix it I can see is to make all descendants of the BaseDataType to be childs of the ... Greg Shah
11:54 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Another solution to the above mentioned issue is to use static immutable constant @BaseDataType.unknown@ (of type Bas... Igor Skornyakov
11:49 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: I've just realized the following. If we assign a value to an attribute via widget handle then 'unknown' literal @?@ i... Igor Skornyakov
09:46 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Please review the current version of the code.
NUM-ITEMS runtime support (combo-box and selection-list)
INNER-LIN... Igor Skornyakov
03:15 PM Database Feature #2581: improve performance of non-preselect, multi-table joins: Currently, when we convert (statically or at runtime) constructs like FOR EACH, EACH, ... or FOR EACH, FIRST, ..., et... Eric Faulhaber
02:58 PM Database Feature #2581 (Closed): improve performance of non-preselect, multi-table joins: Eric Faulhaber
03:03 PM User Interface Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> >Please use the -Dwidgetbrowser=yes when starting the GUI client to bring up the widget bro... Constantin Asofiei
12:28 PM User Interface Feature #2546: implement combo-box widget in GUI: >Please use the -Dwidgetbrowser=yes when starting the GUI client to bring up the widget browser and see where everyth... Eugenie Lyzenko
12:08 PM User Interface Feature #2546: implement combo-box widget in GUI: >Eugenie: actually I do think this is the time to separate this functionality. As Constantin notes, this is likely to... Eugenie Lyzenko
11:51 AM User Interface Feature #2546: implement combo-box widget in GUI: >> if (inFocus != null && !isChui() && inFocus instanceof ScrollableList &&
>> evt.getEvent().ge... Eugenie Lyzenko
10:43 AM User Interface Feature #2546: implement combo-box widget in GUI: >> ComboBoxGuiImpl and FillInGuiImpl: can you think of a way to sub-class the FillInGuiImpl so that the combo-box rel... Greg Shah
09:28 AM User Interface Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> >ComboBoxGuiImpl and FillInGuiImpl: can you think of a way to sub-class the FillInGuiImpl s... Constantin Asofiei
09:24 AM User Interface Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> >the ThinClient change related to focus lost: we already have something done related to thi... Constantin Asofiei
09:14 AM User Interface Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> >...To me, the drop-down in GUI looks like is dependent on the size and coordinates of the ... Constantin Asofiei
01:10 PM Base Language Bug #2578: incorrect promotion of local defined variables: Code Review om_upd20150605a.zip
I'm good with this approach. You can check it in if it passes testing. Greg Shah
12:21 PM Base Language Bug #2578 (WIP): incorrect promotion of local defined variables: Thanks, Greg, this is exactly my idea. I was sure the @ui_statements@ is not the right place - it is also called too ... Ovidiu Maxiniuc
11:41 AM User Interface Feature #1790: implement menu support: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > #. Does this scenario work for GUI in the same way? I recall th... Vadim Gindin
04:51 AM User Interface Feature #1790: implement menu support: Vadim Gindin wrote:
> #. Does this scenario work for GUI in the same way? I recall that for GUI 2 classes are used to... Constantin Asofiei

06/04/2015

03:45 PM User Interface Feature #1790: implement menu support: I wanted to ask some common question about repainting in GUI.
For ChUI I need to post new @PaintEvent@ to event q... Vadim Gindin
03:16 PM Base Language Bug #2578: incorrect promotion of local defined variables: OK, I've dug into this code more deeply. I think I understand better what you are trying to do.
I still believe t... Greg Shah
11:38 AM Database Bug #2552: bad hql caching prevents queries to position on the correct rows: Eric Faulhaber wrote:
> I have posted my full search test results at #1868, note 60 (including the @stdout.log@ this... Ovidiu Maxiniuc
10:37 AM Database Bug #2552: bad hql caching prevents queries to position on the correct rows: I have posted my full search test results at #1868, note 60 (including the @stdout.log@ this time), for your referenc... Eric Faulhaber
07:01 AM Database Bug #2552: bad hql caching prevents queries to position on the correct rows: 0603a is an independent update. I intentionally removed any relation to previous updates in order to isolate the issu... Ovidiu Maxiniuc
10:43 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows: Ovidiu, was your 0603a update meant to be applied on top of the 0421a update?
I tested P2J 10871 + 0603a (without ... Eric Faulhaber

06/03/2015

02:47 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows: > Looks good, nice find. Agreed, will look better with the println statements removed. Do you want to leave these beh... Ovidiu Maxiniuc
02:33 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows: Code review 0603a:
Looks good, nice find. Agreed, will look better with the println statements removed. Do you wan... Eric Faulhaber
02:07 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows: Eric,
I found the probable cause for the failures in regression testing of the @?@ relational semantics. I was worki... Ovidiu Maxiniuc
01:54 PM User Interface Feature #2546: implement combo-box widget in GUI: >ComboBoxGuiImpl and FillInGuiImpl: can you think of a way to sub-class the FillInGuiImpl so that the combo-box relat... Eugenie Lyzenko
01:17 PM User Interface Feature #2546: implement combo-box widget in GUI: >the ThinClient change related to focus lost: we already have something done related to this for the popup, via GuiDr... Eugenie Lyzenko
11:56 AM User Interface Feature #2546: implement combo-box widget in GUI: > That's why I need to know this info.
Please put comments in the code to explain this. Greg Shah
10:26 AM User Interface Feature #2546: implement combo-box widget in GUI: >...To me, the drop-down in GUI looks like is dependent on the size and coordinates of the associated combo-box widge... Eugenie Lyzenko
08:27 AM User Interface Feature #2546: implement combo-box widget in GUI: >how did you determine the ScrollBar.visibleRange default value?
The same value as @DefaultList.visibleRows@. Eugenie Lyzenko
07:12 AM User Interface Feature #2546: implement combo-box widget in GUI: Eugenie, this are some notes about evl_upd20150602a.zip:
* @DropDownGuiImpl.setHeightAndPos@: you are assuming that ... Constantin Asofiei
08:31 PM User Interface Feature #2546: implement combo-box widget in GUI: Today update for review has basic implementation of the @DROP-DOWN@ mode. The entry field is editable and until anoth... Eugenie Lyzenko

06/02/2015

05:37 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: To provide the correct implementaion of the REPLACE method for list widgets (COMBO-BOX/SELECTION-LIST/RADIO-SET) a ne... Igor Skornyakov
06:50 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> The FillIn.appVar initial value is not 'unknown'. As a result it is impossible to correctly... Constantin Asofiei
03:30 PM User Interface Feature #1790: implement menu support: You are right and now it works. Thank you very much! Vadim Gindin
03:23 PM User Interface Feature #1790: implement menu support: Vadim Gindin wrote:
> I've made the following changes:
> #. I've set menu children @physicalLocation@ to relative v... Constantin Asofiei
03:19 PM User Interface Feature #1790: implement menu support: I've made the following changes:
#. I've set menu children @physicalLocation@ to relative value
#. I used relative ... Vadim Gindin
02:57 PM User Interface Feature #1790: implement menu support: Vadim Gindin wrote:
> If so, what about methods like @GuiDriver.drawString(String, int, int)@, @GuiDriver.drawLine(i... Constantin Asofiei
02:24 PM User Interface Feature #1790: implement menu support: If so, what about methods like @GuiDriver.drawString(String, int, int)@, @GuiDriver.drawLine(int, int, int, int)@ or ... Vadim Gindin
12:48 PM User Interface Feature #1790: implement menu support: > adjust the menu's location to be relative to its parent
This one.
It is important that the @physicalLocation(... Greg Shah
12:35 PM User Interface Feature #1790: implement menu support: Vadim Gindin wrote:
> I faced with the problem of defining a widget, mouse is clicked over. I have simple menubar wi... Constantin Asofiei
08:32 AM User Interface Feature #1790: implement menu support: I faced with the problem of defining a widget, mouse is clicked over. I have simple menubar with 3 menu-items and one... Vadim Gindin
01:15 PM User Interface Feature #1811: implement the AJAX client driver: > And if the target OS is expected to not provide these fonts, we can define these as "custom fonts" and pass to the... Greg Shah
07:07 AM User Interface Feature #1811: implement the AJAX client driver: Anton Breaur wrote:
> The way I envisioned the flow to work is that we send font information to the web client, like... Constantin Asofiei
08:18 PM User Interface Feature #2546: implement combo-box widget in GUI: The next update for review as current state reflection. This is DROP-DOWN mode first step with @FillInGuiImpl@ integr... Eugenie Lyzenko

06/01/2015

06:38 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: The FillIn.appVar initial value is not 'unknown'. As a result it is impossible to correctly calculate screenValue() w... Igor Skornyakov

05/31/2015

06:47 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: 1. SCREEN-VALUE attribute getter returns empty string (at least for the FILL-IN widget).
2. SELECTION-TEXT attribute ... Igor Skornyakov

« Previous

Also available in: Atom

Project

General

Profile

FWD

Activity

Activity

06/29/2015

06/28/2015

06/27/2015

06/26/2015

06/25/2015

06/24/2015

06/23/2015

06/22/2015

06/21/2015

06/20/2015

06/19/2015

06/18/2015

06/17/2015

06/16/2015

06/15/2015

06/14/2015

06/13/2015

06/12/2015

06/11/2015

06/10/2015

06/09/2015

06/08/2015

06/07/2015

06/06/2015

06/05/2015

06/04/2015

06/03/2015

06/02/2015

06/01/2015

05/31/2015