FWD

07/08/2015

05:46 PM User Interface Feature #2546: implement combo-box widget in GUI

Task branch @2546a@ for review updated to revision @10899@.
The enhancements has been made to mouse event handling... Eugenie Lyzenko

02:18 PM Base Language Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> I guess that if the size is handles in @ControlFlowOps@, there is no need for the additiona... Eric Faulhaber

01:07 PM Base Language Bug #2592: improve support for implicit type conversions

Eric Faulhaber wrote:
> I read through @ControlFlowOps@ a bit more, and I must be misunderstanding your second point... Ovidiu Maxiniuc

11:16 AM Base Language Bug #2592: improve support for implicit type conversions

I read through @ControlFlowOps@ a bit more, and I must be misunderstanding your second point above, because it appear... Eric Faulhaber

11:07 AM Base Language Bug #2592: improve support for implicit type conversions

Ovidiu wrote (in email):
> There are two main issues I would like to discuss and I would appreciate additional help:... Eric Faulhaber

09:44 AM User Interface Feature #2252: implement GUI client support

CUT/COPY/PASTE have alternative key mappings in Windows. I think we need to add those to @GuiKeyboard.standardKeyFun... Greg Shah

07/07/2015

07:54 PM User Interface Feature #2546: implement combo-box widget in GUI

Please review task branch @2546a@, revision @10898@.
This update has new approach that fixes the multiple combo-bo... Eugenie Lyzenko

02:41 PM User Interface Feature #2546: implement combo-box widget in GUI

Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > The only issue I have is with code like this: @if (child != ... Constantin Asofiei

01:56 PM User Interface Feature #2546: implement combo-box widget in GUI

Constantin Asofiei wrote:
> The only issue I have is with code like this: @if (child != null && child instanceof Scr... Eugenie Lyzenko

07:59 AM User Interface Feature #2546: implement combo-box widget in GUI

Eugenie Lyzenko wrote:
> Please review task branch @2546a@, revision @10897@.
The only issue I have is with code li... Constantin Asofiei

10:49 PM User Interface Feature #2546: implement combo-box widget in GUI

Please review task branch @2546a@, revision @10897@.
Adding drop-down press opening fix. The main logic of drop-do... Eugenie Lyzenko

09:30 PM User Interface Feature #2546: implement combo-box widget in GUI

Rebased task branch @2546a@ from P2J trunk revision @10894@. Eugenie Lyzenko

05:16 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> I recommend that you zip up the @p2j/@ directory on devsrv01 and copy it to your local system. M... Igor Skornyakov

04:57 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

I recommend that you zip up the @p2j/@ directory on devsrv01 and copy it to your local system. Make sure to exclude ... Greg Shah

04:51 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

The situation is very strange. On my machine the manual testing is OK (the dynamic header is in place). Igor Skornyakov

04:36 PM User Interface Feature #1807: implement clipboard support

Some things to note:
1. ChUI does support use of the CLIPBOARD system handle (including the VALUE attribute for bo... Greg Shah

04:20 PM User Interface Feature #1811: implement the AJAX client driver

The current clipboard support for the ChUI web client has many of the building blocks that are needed for GUI clipboa... Greg Shah

11:25 AM User Interface Feature #2563: implement GUI EDITOR widget

Rebased task branch 2563b from P2J trunk revision 10894 (new branch revision 10898).
Constantin Asofiei

10:02 AM User Interface Feature #2252: implement GUI client support

Rebased task branch 1796b from P2J trunk revision 10894 (branch revision 10906).
Constantin Asofiei

07/06/2015

07:33 PM User Interface Feature #2252: implement GUI client support

Rebased task branch 2424 from P2J trunk revision 10894 (branch revision 10896). Hynek Cihlar

03:37 PM User Interface Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> Greg, a conversion question; in 4GL, the following frames are equivalent:
> [...]
> In... Greg Shah

10:39 AM User Interface Feature #2252: implement GUI client support

Task branch 2559e committed to trunk as revision 10894. Hynek Cihlar

09:49 AM User Interface Feature #2252: implement GUI client support

> I only didn't expect any ChUI-specific features, hence no ChUI-specific sublass.
I see. Good. Greg Shah

09:43 AM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> I think the best approach is to create GUI and ChUI subclasses of @WindowManager@ that can have m... Hynek Cihlar

09:34 AM User Interface Feature #2252: implement GUI client support

Go ahead and merge 2559e into the trunk.
The next time we have some work in @WindowManager@, we can make some fact... Greg Shah

08:06 AM User Interface Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> Greg Shah wrote:
> > Code Review Task Branch 2559e Revision 10896
> >
> > This is good.
>... Hynek Cihlar

05:03 PM User Interface Feature #2546: implement combo-box widget in GUI

> Should I try to reboot it(not sure if I have enough permissions)?
No, let the customer handle that.
> The exc... Greg Shah

04:42 PM User Interface Feature #2546: implement combo-box widget in GUI

The exception from drop-down dismiss rule is mouse events in combo-box entry field or outside drop-down or combo-box(... Eugenie Lyzenko

04:30 PM User Interface Feature #2546: implement combo-box widget in GUI

Greg Shah wrote:
> Does the 4GL code (actually, it is really the Windows drop-down control) dismiss the drop-down on... Eugenie Lyzenko

09:48 AM User Interface Feature #2546: implement combo-box widget in GUI

> The root cause was too early dismiss the drop-down. I have preferred to use mouse press due to mouse press does imm... Greg Shah

07:46 AM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> Could you help me to find why sub-menu body is truncated and where the truncating is happen?
... Constantin Asofiei

04:42 AM User Interface Feature #1790: implement menu support

Constantin, could you look at my current changes in 1790d?
Here is my testcase:... Vadim Gindin

07/03/2015

07:29 PM User Interface Feature #2546: implement combo-box widget in GUI

Please review task branch @2546a@, revision @10894@.
This is my first usage of the branch upload process. All curr... Eugenie Lyzenko

05:16 PM User Interface Feature #2546: implement combo-box widget in GUI

Created task branch @2546a@ from P2J trunk revision @10893@. Eugenie Lyzenko

06:07 AM User Interface Feature #2546: implement combo-box widget in GUI

>Another issue with this test is some z-order problem: when the drop-down covers one or more widget, currently the co... Eugenie Lyzenko

04:42 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Well, the problem with the screen was reproduced manually. Igor Skornyakov

04:40 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Eugenie Lyzenko wrote:
> Try @CTRL-X@. This should also produce @GO@ function.
Thanks a lot! It works! Igor Skornyakov

04:37 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> Sorry, but I need an advise? I'm trying to execute the test manually, and I have to send V... Hynek Cihlar

04:36 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Try @CTRL-X@. This should also produce @GO@ function. Eugenie Lyzenko

04:28 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Sorry, but I need an advise? I'm trying to execute the test manually, and I have to send VK_F1 at some step, but whe... Igor Skornyakov

02:58 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Constantin Asofiei wrote:
> MAJIC has some built-in "help" triggered by pressing F2 in almost all screens - this wil... Igor Skornyakov

02:35 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> Greg Shah wrote:
> > Did you check this scenario by hand (manually trying the same inputs)... Constantin Asofiei

02:31 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> Did you check this scenario by hand (manually trying the same inputs)?
Actually I tried to fin... Igor Skornyakov

01:55 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Did you check this scenario by hand (manually trying the same inputs)? Greg Shah

10:36 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

The tc_item_stockroom_011 still fails. The mismatching screen is ... Igor Skornyakov

08:19 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

See #2603 for a response on the harness change. Greg Shah

05:22 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

After the second run only the tc_item_stockroom_011 test failed. However the mismatched screen in the report looks id... Igor Skornyakov

01:13 PM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review Task Branch 2559e Revision 10896
>
> This is good.
>
> 1. It is not a big deal,... Hynek Cihlar

12:34 PM User Interface Feature #2252: implement GUI client support

Code Review Task Branch 2559e Revision 10896
This is good.
1. It is not a big deal, but I'd prefer a better way to ... Greg Shah

08:49 AM User Interface Feature #2252: implement GUI client support

Greg, a conversion question; in 4GL, the following frames are equivalent:... Constantin Asofiei

08:21 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods

Please create a task branch for this task (@2567a@) and commit all your current work. All subsequent work should be ... Greg Shah

08:18 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods

I've finished with the WIDGET-ID. Igor Skornyakov

08:00 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods

Greg Shah wrote:
> Basically, yes.
>
> We need to do whatever the 4GL does when the command line parameter @-usew... Igor Skornyakov

07:57 AM User Interface Feature #2567 (WIP): add misc widget support part 2: more options, attributes and methods

Igor said:
> To you mean that we only need to support the conversion of the access to the WIDGET-ID attribute with... Greg Shah

07/02/2015

06:55 PM User Interface Feature #2252: implement GUI client support

For #2559 I have:
Implemented window modality independently on the actual UI driver.
Improved positioning of top-... Hynek Cihlar

06:41 AM User Interface Feature #2252: implement GUI client support

Rebased task branch 1796b from P2J trunk revision 10893 (branch revision 10898).
Constantin Asofiei

05:37 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Well, the situation is much better now. All CTRL-C tests passed. Only one gso_test (gso_269) and two rc_tests (tc_ite... Igor Skornyakov

01:17 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Hynek Cihlar wrote:
> With the workaround, we are losing type information about the serialized field but in this cas... Igor Skornyakov

12:22 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> I suggest the following workaround in the @NativeTypeSerializer@
>
> public static vo... Hynek Cihlar

12:08 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> Fixed serialization for the null string. Regression test restarted
When you have abends li... Constantin Asofiei

12:05 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Fixed serialization for the null string. Regression test restarted Igor Skornyakov

11:57 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> (the visibility of the @mark@ field becomes 'public').
Please leave it protected instead o... Constantin Asofiei

11:44 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

I'm OK with this.
Constantin/Hynek? Greg Shah

11:31 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> Thank you Greg. I'm looking at this now. However NPE in @writeUFT()@ is weird. I've used it... Igor Skornyakov

10:55 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> I guess this has something to do with your changes to the configuration processing or widget conf... Igor Skornyakov

10:47 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

> Here is the stack trace for another common failure.
>
> com.goldencode.p2j.net.SilentUnwindException: Connection ... Greg Shah

10:23 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> I don't understand what this bug has to do with our failure. They state that it is specific to J... Igor Skornyakov

10:17 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

I don't understand what this bug has to do with our failure. They state that it is specific to JDK 9.
Please post... Greg Shah

10:05 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Sorry. I've previously found a wrong reference (it was about @DataOutputStream@). See however this one: https://netbe... Igor Skornyakov

10:01 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

The situation with NPE in @writeUTF()@ seems to be a known issue with OpenJDK. See https://bugs.openjdk.java.net/brow... Igor Skornyakov

09:14 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> I'm fine with the changes. What is the status of testing for this update?
There are still a... Igor Skornyakov

08:58 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Code Review ias_upd20150630a.zip
I'm fine with the changes. What is the status of testing for this update? Greg Shah

04:01 PM User Interface Feature #1790: implement menu support

Created task branch 1790d from P2J trunk revision 10893 Vadim Gindin

07:47 AM User Interface Feature #2422: add features to BROWSE

Stanislav Lomany wrote:
> I can do that after you finish your browse modifications if the issue doesn't bother you a... Constantin Asofiei

07:45 AM User Interface Feature #2422: add features to BROWSE

I can do that after you finish your browse modifications if the issue doesn't bother you at this point. Stanislav Lomany

03:50 AM User Interface Feature #2422: add features to BROWSE

Stanislav Lomany wrote:
> Yes, @queryId@ actually contained browse ID. Didn't know that it can also contain query I... Constantin Asofiei

02:38 AM User Interface Feature #2422: add features to BROWSE

Created task branch 2422b from P2J trunk revision 10893. Stanislav Lomany

07:06 AM User Interface Feature #2563: implement GUI EDITOR widget

Rebased task branch 2563b from P2J trunk revision 10893 (new branch revision 10897).
Constantin Asofiei

05:51 AM User Interface Feature #2546: implement combo-box widget in GUI

Eugenie Lyzenko wrote:
> The next update for review presents the scaling factor implementation to eliminate hardcodi... Constantin Asofiei

09:28 PM User Interface Feature #2546: implement combo-box widget in GUI

The next update for review presents the scaling factor implementation to eliminate hardcoding adjustments. The idea i... Eugenie Lyzenko

05:27 AM Database Feature #2581: improve performance of non-preselect, multi-table joins

Yes, the SQL SERVER has a similar concept for @LIMIT@, named @TOP@. It allows to return only the first @N@ rows from ... Ovidiu Maxiniuc

11:27 PM Database Feature #2581: improve performance of non-preselect, multi-table joins

Ovidiu, can you confirm that something like this SQL works in SQL Server 2012?... Eric Faulhaber

07/01/2015

06:11 PM User Interface Feature #2422: add features to BROWSE

Yes, @queryId@ actually contained browse ID. Didn't know that it can also contain query ID (I know that sounds stran... Stanislav Lomany

04:15 PM User Interface Feature #2422: add features to BROWSE

Stanislav, one more issue: is a little confusing that the query ID at some point is the same as the browse ID... this... Constantin Asofiei

09:00 AM User Interface Feature #2422: add features to BROWSE

Constantin, I have no objections. Stanislav Lomany

07:43 AM User Interface Feature #2422: add features to BROWSE

Stanislav, is there a query-related reason why the browse columns (at the widget level) are linked with the BrowseMod... Constantin Asofiei

03:44 PM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> This testcase defines 2 nested submenus "Insider" is nested in "Submenu".
You have the @buil... Constantin Asofiei

10:57 AM User Interface Feature #1790: implement menu support

Constantin, your approach seems working at first sight. Now I have 2 problems with the testcase:... Vadim Gindin

02:32 PM User Interface Feature #1811: implement the AJAX client driver

Greg Shah wrote:
> Hynek:
>
> The @AbstractGuiDriver.newChildWindowEmulator()@ is only ever called from @GuiOutpu... Hynek Cihlar

01:09 PM User Interface Feature #1811: implement the AJAX client driver

Hynek:
The @AbstractGuiDriver.newChildWindowEmulator()@ is only ever called from @GuiOutputManager.realizeChildWin... Greg Shah

11:56 AM User Interface Feature #1811: implement the AJAX client driver

Created task branch 1811o from P2J trunk revision 10893.
There are 14 previous commits from this task. For this r... Greg Shah

09:48 AM User Interface Feature #2252: implement GUI client support

Rebased task branch 2559e from P2J trunk revision 10894 (branch revision 10893). Hynek Cihlar

04:56 AM User Interface Feature #2563: implement GUI EDITOR widget

Rebased task branch 2563b from P2J trunk revision 10892 (new branch revision 10896).
Constantin Asofiei

06/30/2015

06:46 PM User Interface Feature #2546: implement combo-box widget in GUI

This merged with recent code update for review adds support for current item selection by mouse hovering. The idea is... Eugenie Lyzenko

04:39 PM Database Bug #2602: A record returned twice because of RELEASE

Testcase:... Stanislav Lomany

04:26 PM Database Bug #2602 (New): A record returned twice because of RELEASE

Stanislav Lomany

03:54 PM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> Constantin, could you look at my update?
>
> Is that what you meant?
>
> When I'm movin... Constantin Asofiei

02:59 PM User Interface Feature #1790: implement menu support

Constantin, could you look at my update?
Is that what you meant?
When I'm moving mouse pointer to menu-item in... Vadim Gindin

02:18 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Merged with revno 10892 Igor Skornyakov

01:04 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

I've restarted majic build. Igor Skornyakov

12:48 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

> I'm planning to restart regression with the most recent version right now.
Please post the merged update for re... Greg Shah

12:40 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> What is the status of regression testing for the 0623b update?
>
> Also: I think you need to m... Igor Skornyakov

09:31 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

What is the status of regression testing for the 0623b update?
Also: I think you need to merge to the latest P2J r... Greg Shah

02:11 PM User Interface Feature #2422: add features to BROWSE

The latest update was converted to branch 2422a. Committed to bzr as P2J rev. 10892. Stanislav Lomany

09:25 AM User Interface Bug #2588 (Closed): test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTT...

Greg Shah

06:28 AM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute

Constantin Asofiei wrote:
> I'm OK with the change, go ahead and release it.
Committed in bzr as @10891@. Eugenie Lyzenko

04:33 AM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute

> Please review the change. I can release it because as before no testing is required for GUI code.
I'm OK with the ... Constantin Asofiei

06/29/2015

07:01 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute

There is one more place to modify regarding this bug. The GUI button does not display image for default button. So th... Eugenie Lyzenko

06:24 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute

The fix has been committed in bzr as @10890@. Will be distributed shortly. Eugenie Lyzenko

06:12 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute

Eugenie Lyzenko wrote:
> >This should be already covered in branch 2563b @FrameGuiImpl.processDefaultButton@ - pleas... Constantin Asofiei

06:04 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute

>This should be already covered in branch 2563b @FrameGuiImpl.processDefaultButton@ - please double check this branch... Eugenie Lyzenko

05:51 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute

Eugenie Lyzenko wrote:
> The conclusion is only @DEFAULT-BUTTON@ frame option has meaning when defining the button t... Constantin Asofiei

05:32 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute

>Write the following testcases to check behavior:
>
>1. Does @BUTTON:DEFAULT@ without frame's @DEFAULT-BUTTON@ opti... Eugenie Lyzenko

05:39 PM Database Bug #2552 (Closed): bad hql caching prevents queries to position on the correct rows

The change fixed the unit tests I was targeting.
I rebased 2552a to trunk rev. 10888 to pick up Hynek's redirected... Eric Faulhaber

04:24 PM Base Language Bug #2592: improve support for implicit type conversions

The issue for Hynek's earlier work is #2293. Eric Faulhaber

04:18 PM Base Language Bug #2592: improve support for implicit type conversions

As I was reviewing this code, I was wondering why @VariableAssigner@ and @OutputParameterAssigner@ were not in the @c... Eric Faulhaber

02:48 PM Base Language Bug #2592: improve support for implicit type conversions

After running the testcase procedure against P4GL, I was able to detect the cases where the automatic/implicit conver... Ovidiu Maxiniuc

12:54 PM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> > Lets change the approach to this: take the menubar's clipping rectangle and, if the ScreenBi... Constantin Asofiei

12:32 PM User Interface Feature #1790: implement menu support

Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Constantin Asofiei wrote:
> > > Vadim Gindin wrote:
> > > > >... Vadim Gindin

11:30 AM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Vadim Gindin wrote:
> > > > A solution would be to repaint the... Constantin Asofiei

10:27 AM User Interface Feature #1790: implement menu support

Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > > A solution would be to repaint the entire menubar or sub-menu... Vadim Gindin

09:48 AM User Interface Feature #1790: implement menu support

> But when I did this change, the error didn't disappear. Was I wrong? Could you have a look at it?
Your change do... Greg Shah

06:53 AM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> > A solution would be to repaint the entire menubar or sub-menu on mouseEnter/Exit. But I th... Constantin Asofiei

06:34 AM User Interface Feature #1790: implement menu support

Constantin Asofiei wrote:
> What I think is happening is this:
> * you are calling a @repaint()@ for a certain menu... Vadim Gindin

06:04 AM User Interface Feature #1790: implement menu support

Constantin, thank you, I'll try.
Greg, I've faced with parsing error with the following procedure:... Vadim Gindin

04:45 AM User Interface Feature #1790: implement menu support

What I think is happening is this:
* you are calling a @repaint()@ for a certain menu-item; this ensures that an inv... Constantin Asofiei

03:31 AM User Interface Feature #1790: implement menu support

Constantin, I have a problem with mouse ENTER and EXIT events processing. When I move mouse pointer from one menu-ite... Vadim Gindin

04:22 AM User Interface Feature #2252: implement GUI client support

Rebased task branch 1796b from P2J trunk revision 10888 (branch revision 10890). Constantin Asofiei

04:21 AM User Interface Feature #2563: implement GUI EDITOR widget

Rebased task branch 2563b from P2J trunk revision 10888 (new branch revision 10892). Constantin Asofiei

06/28/2015

07:58 PM User Interface Feature #2546: implement combo-box widget in GUI

Merge with recent code base for review. In addition the event list chaining in drop-down cycle is now filtering to co... Eugenie Lyzenko

05:37 AM User Interface Bug #2601: Implement gap closing mechanism for browse

When some of the records contained in a browse are deleted in background (by @DELETE@, not @DELETE-*-ROW(S)@), "gaps"... Stanislav Lomany

04:11 AM User Interface Bug #2601 (New): Implement gap closing mechanism for browse

Stanislav Lomany

05:24 AM User Interface Feature #2252: implement GUI client support

Task branch 2559d passed regression testing and was committed to trunk as revision 10888. Hynek Cihlar

06/27/2015

08:14 PM User Interface Feature #2546: implement combo-box widget in GUI

Finally the update merged with the recent code base is ready with all fixes required:
1. Resolution for previous upd... Eugenie Lyzenko

08:12 PM User Interface Bug #2600: Implement proper refresh after deletion if the deleted row is a new row outside of the...

Example of the behavior - @uast/browse/brws-offset5.p@:
down to 10, n, esc-R, up to 1, d - scrolled to 10.
The ... Stanislav Lomany

06/26/2015

07:45 PM User Interface Bug #2600 (New): Implement proper refresh after deletion if the deleted row is a new row outside ...

Stanislav Lomany

07:13 PM User Interface Bug #2599: 4GL makes selection invalid after row deletion

4GL makes selection invalid if we have deleted a selected row and there was a new row in the set of selected rows.
... Stanislav Lomany

07:08 PM User Interface Bug #2599 (New): 4GL makes selection invalid after row deletion

Stanislav Lomany

04:12 PM User Interface Bug #2598: Adding new row in REPLACE mode causes quirk

Scenario:... Stanislav Lomany

03:55 PM User Interface Bug #2598 (New): Adding new row in REPLACE mode causes quirk

Stanislav Lomany

04:03 PM Base Language Bug #2592: improve support for implicit type conversions

The testcases project was updated with @uast/procedures/conversion-params.p@. It contains the matrix for conversion p... Ovidiu Maxiniuc

12:53 PM Base Language Bug #2592: improve support for implicit type conversions

The branch 2592 has been updated and rebased (main trunk revision 10887). It is not at revision 10892.
It passed my ... Ovidiu Maxiniuc

11:58 AM User Interface Feature #2252: implement GUI client support

Code Review Task Branch 2559d Revision 10888
The changes look good to me. Please get them tested. Greg Shah

11:31 AM User Interface Feature #2252: implement GUI client support

For #2559 I have:
Fixed calculation of workspace size in redirection mode.
Fixed some unhandled exceptions when s... Hynek Cihlar

06:19 AM User Interface Bug #2597: Rows are quirky committed on insert-row() call.

General description:
1. Update some row 1.
2. Leave it by calling INSERT-ROW in a trigger. Row 1 will contain updat... Stanislav Lomany

05:37 AM User Interface Bug #2597 (New): Rows are quirky committed on insert-row() call.

Stanislav Lomany

01:48 AM Database Bug #2552 (WIP): bad hql caching prevents queries to position on the correct rows

I've re-opened this task to address a defect: it is possible for the @HQLPreprocessor@ to create invalid ASTs when th... Eric Faulhaber

06/25/2015

07:47 PM User Interface Feature #2546: implement combo-box widget in GUI

The condition of the application to finish is the pressing @RETURN@ key. It is very strange because it is happening e... Eugenie Lyzenko

06:38 PM User Interface Feature #2422: add features to BROWSE

Code Review svl_upd20150625a.zip
I'm OK with the changes. Please get them regression tested. Greg Shah

04:45 PM User Interface Feature #2422: add features to BROWSE

Update for review. Fixes issue from the checklist in item 178. Stanislav Lomany

07:43 AM User Interface Feature #2422: add features to BROWSE

OK, add this to the quirks list. Greg Shah

06:12 PM User Interface Bug #2596: Implement missing browse quirks.

Parent task for tracking browse quirks. Stanislav Lomany

06:09 PM User Interface Bug #2596 (New): Implement missing browse quirks.

Stanislav Lomany

12:25 PM Base Language Bug #2592: improve support for implicit type conversions

Very good plan and design. Greg Shah

11:50 AM Base Language Bug #2592: improve support for implicit type conversions

Support for variables.
I am thinking of the following changes in code:
* an abstract class @Assigner@ with @BaseDat... Ovidiu Maxiniuc

11:31 AM Base Language Bug #2592: improve support for implicit type conversions

These are very good points (the complete matrix and the support for variables). I think both of these issues need to... Greg Shah

10:10 AM Base Language Bug #2592 (WIP): improve support for implicit type conversions

I updated the code according your reviews. The new revno is 10890.
Constantin: your 2nd question is very good. I n... Ovidiu Maxiniuc

04:26 AM Base Language Bug #2592: improve support for implicit type conversions

Greg Shah wrote:
> Constantin: as the owner of @ControlFlowOps@, do you have any concerns with the update?
The logi... Constantin Asofiei

07:10 AM User Interface Feature #2412: Implement widget browser

The task branch 2412a was committed to trunk revision 10887. Hynek Cihlar

06/24/2015

07:11 PM User Interface Feature #2422: add features to BROWSE

Regarding "Check how addition of new row works in multiple selection mode (last selected row is used?)". Looks like a... Stanislav Lomany

05:34 PM User Interface Feature #2422: add features to BROWSE

Addition to "In 4GL (ChUI) last/first rows has invalid row value." behavior: if the value of the current cell was mod... Stanislav Lomany

11:04 AM User Interface Feature #2422: add features to BROWSE

> LABEL-BGCOLOR, MOVE-COLUMN and MIN-HEIGHT-CHARS are GUI-specific.
OK, I see they are already listed in #2564. ... Greg Shah

10:59 AM User Interface Feature #2422: add features to BROWSE

Yes, but LABEL-BGCOLOR, MOVE-COLUMN and MIN-HEIGHT-CHARS are GUI-specific. Stanislav Lomany

10:53 AM User Interface Feature #2422: add features to BROWSE

SET-REPOSITIONED-ROW - used
MODIFIED - used
LABEL-BGCOLOR - used
MOVE-COLUMN - used
MIN-HEIGHT-CHARS - not sure; ... Greg Shah

06:01 PM User Interface Feature #2412: Implement widget browser

Code Review Task Branch 2412a Revision 10887
The changes are OK. Greg Shah

05:33 PM User Interface Feature #2412: Implement widget browser

I have improved Widget Browser GUI highlight. Restoring the highlighted area was causing artifacts. Also the highligh... Hynek Cihlar

05:31 PM User Interface Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> Greg, do we need SPACE in GUI? I was playing with some ChUI tests and GUI doesn't suppor... Greg Shah

05:07 PM User Interface Feature #2252: implement GUI client support

Greg, do we need SPACE in GUI? I was playing with some ChUI tests and GUI doesn't support yet the SPACE clause. Constantin Asofiei

05:04 PM Base Language Bug #2592 (New): improve support for implicit type conversions

Code Review Task Branch 2592 Revision 10889
The core functionality seems good.
1. In @FieldAssigner.assign()@ y... Greg Shah

03:53 PM Base Language Bug #2592: improve support for implicit type conversions

10889 looks good, thanks, but I still want Greg or Constantin's stamp of approval, particularly on the @ControlFlowOp... Eric Faulhaber

03:48 PM Base Language Bug #2592 (WIP): improve support for implicit type conversions

New changes committed to revision 10889. Ovidiu Maxiniuc

03:29 PM Base Language Bug #2592: improve support for implicit type conversions

Code review 10888:
This looks good to me, with 2 very minor points:
* Please rename @FieldAssigner$Scope.list@ to... Eric Faulhaber

03:01 PM Base Language Bug #2592: improve support for implicit type conversions

The branch has been updated to revision 10888. I already tested with ETF and it passed all +JULIAN_DATE tests that we... Ovidiu Maxiniuc

01:32 PM Base Language Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> Looks like my idea from note 7 can be easier implemented thanks to the @List<FieldAssigner>... Eric Faulhaber

12:40 PM Base Language Bug #2592: improve support for implicit type conversions

> Sorry for these incremental status updates.
You have done exactly the right thing in posting these different ide... Greg Shah

12:30 PM Base Language Bug #2592: improve support for implicit type conversions

Looks like my idea from note 7 can be easier implemented thanks to the @List<FieldAssigner>@ from @FieldAssigner@ con... Ovidiu Maxiniuc

11:55 AM Base Language Bug #2592: improve support for implicit type conversions

After further thinking:
what if we allow the internal variable from @FieldAssigner@ to be updated. For example, if t... Ovidiu Maxiniuc

10:47 AM Base Language Bug #2592: improve support for implicit type conversions

I have created branch 2592 from the main trunk (revno 10886). I committed the intermediary changes in @ControlFlowOps... Ovidiu Maxiniuc

10:06 AM Base Language Bug #2592: improve support for implicit type conversions

I started the implementation for the optional conversions in message passing parameters. The forward checking is done... Ovidiu Maxiniuc

12:11 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Please see #2594 - Implement a tracing facility for P2J. Hynek Cihlar

10:55 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> Greg Shah wrote:
> > My point: I'd like this approach to be a "dtrace" for P2J. But as yo... Greg Shah

10:23 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> My point: I'd like this approach to be a "dtrace" for P2J. But as you say, the AspectJ approach ... Igor Skornyakov

10:04 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

> The Aspect-way of monitoring method calls is slow, maybe it would make more sense to use the java.lang.instrument ... Greg Shah

09:57 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Code Review ias_upd20150623b.zip
I'm good with the changes. Greg Shah

12:08 PM Runtime Infrastructure Feature #2594: Implement a tracing facility for P2J

When trying to understand internal workings of a complex system like P2J - spanning multiple hosts, processes and thr... Hynek Cihlar

11:04 AM Runtime Infrastructure Feature #2594 (New): Implement a tracing facility for P2J

Hynek Cihlar

09:41 AM User Interface Feature #2546: implement combo-box widget in GUI

Greg Shah wrote:
> In addition to making the processing safer for drop-down, isn't the real problem that the trigger... Eugenie Lyzenko

09:22 AM User Interface Feature #2546: implement combo-box widget in GUI

In addition to making the processing safer for drop-down, isn't the real problem that the trigger processing should b... Greg Shah

09:04 AM User Interface Feature #2546: implement combo-box widget in GUI

Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Yes, the @DropDown@ doesn't have an ID yet. You can add a v... Constantin Asofiei

08:54 AM User Interface Feature #2546: implement combo-box widget in GUI

Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Review for 0622a.zip:
> > * @ComboBoxConfig@ - the added im... Constantin Asofiei

08:35 AM User Interface Feature #2546: implement combo-box widget in GUI

Constantin Asofiei wrote:
> Review for 0622a.zip:
> * @ComboBoxConfig@ - the added imports are unused
Please cla... Eugenie Lyzenko

08:30 AM User Interface Feature #2546: implement combo-box widget in GUI

Constantin Asofiei wrote:
> Yes, the @DropDown@ doesn't have an ID yet. You can add a virtual ID to it via @WidgetI... Eugenie Lyzenko

04:10 AM User Interface Feature #2546: implement combo-box widget in GUI

Eugenie Lyzenko wrote:
> The root cause for ignoring trigger call has been found. During obtaining the server method... Constantin Asofiei

03:57 AM User Interface Feature #2546: implement combo-box widget in GUI

Review for 0622a.zip:
* @ComboBoxConfig@ - the added imports are unused
* @DropDown@ - the @fixVisibleRows@ abstrac... Constantin Asofiei

08:30 PM User Interface Feature #2546: implement combo-box widget in GUI

The root cause for ignoring trigger call has been found. During obtaining the server method from proxy class the all ... Eugenie Lyzenko

09:24 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods

Greg Shah wrote:
> I don't know the answer, but usually the option is just the static way (compile-time) to define a... Igor Skornyakov

09:18 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods

I don't know the answer, but usually the option is just the static way (compile-time) to define a feature as part of ... Greg Shah

05:07 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods

It looks like there is very much in common between "Options" and "Attributes" sections in this task. Is there any dif... Igor Skornyakov

07:59 AM User Interface Feature #1790: implement menu support

Here is the current update Vadim Gindin

03:27 AM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> Please, hepl my with my previous question about duplication. I still didn't find the reason.
... Constantin Asofiei

03:15 AM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> Duplication error has gone after the last Hynek's update! Sorry to trouble.
Please post your ... Constantin Asofiei

06/23/2015

05:34 PM User Interface Feature #2422: add features to BROWSE

> Please make a list of browse features (methods, attributes, options) which are stubbed out but which have no runtim... Stanislav Lomany

03:42 PM User Interface Feature #2422: add features to BROWSE

For both of these quirks, can you easily detect that the problem would occur? If so, then let's detect those cases (... Greg Shah

03:28 PM User Interface Feature #2422: add features to BROWSE

> What does the implementation do today when there is an uncommitted update and INSERT-ROW() is called
At that tim... Stanislav Lomany

02:35 PM User Interface Feature #2422: add features to BROWSE

It seems that there are a very large number of postponed browse quirks already. We need a much better approach to tra... Greg Shah

02:31 PM User Interface Feature #2422: add features to BROWSE

> Unless it is the first column, you cannot change copied value (only navigation and trigger keys work) until you re-... Greg Shah

02:29 PM User Interface Feature #2422: add features to BROWSE

> Side note: in multi-selection browse if a new row is selected and DELETE-CURRENT-ROW/DELETE-SELECTED-ROW was called... Greg Shah

02:27 PM User Interface Feature #2422: add features to BROWSE

> Actually rows get to the quirky state. The scenario:
> ...
> Should I reproduce this quirk?
What does the impl... Greg Shah

02:23 PM User Interface Feature #2422: add features to BROWSE

Stanislav Lomany wrote:
> It is not implemented at runtime (@Browse.java@):
>
> [...]
This is not good. I did... Greg Shah

10:11 AM User Interface Feature #2422: add features to BROWSE

Addition to note 180 ("In 4GL (ChUI) last/first rows has invalid row value"). Unless it is the first column, you cann... Stanislav Lomany

07:35 AM User Interface Feature #2422: add features to BROWSE

Greg,
> Check if new/existing rows are undone or committed on insert-row() call.
Actually rows get to the quirk... Stanislav Lomany

05:18 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Fixed based on code review Igor Skornyakov

04:41 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> Hynek Cihlar wrote:
> > Igor, I will not give you an answer to your question but I will at least... Hynek Cihlar

03:38 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Code Review ias_upd20150623a.zip
1. @FillIn.isZapActive()@ is missing javadoc and needs a blank line after it.
... Greg Shah

02:47 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

All done. Started regesssion testing. Igor Skornyakov

02:44 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Hynek Cihlar wrote:
> Igor, I will not give you an answer to your question but I will at least share with you a litt... Greg Shah

02:37 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> I found useful to add a method @LogicalTerminal.debug(int widgetId, message)@ and a corresp... Greg Shah

12:50 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> >
> Thank you Hynek,
> What you've mentioned can be very useful indeed. However I had an... Hynek Cihlar

12:38 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Hynek Cihlar wrote:
> Igor, I will not give you an answer to your question but I will at least share with you a litt... Igor Skornyakov

12:28 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor, I will not give you an answer to your question but I will at least share with you a little bit from my kitchen.... Hynek Cihlar

05:01 PM Database Bug #2591: incorrect queries when MATCH operator is involved

Committed to bzr as revno 10886. Ovidiu Maxiniuc

04:17 PM Database Bug #2591: incorrect queries when MATCH operator is involved

Please commit. Eric Faulhaber

03:57 PM Database Bug #2591: incorrect queries when MATCH operator is involved

Taking into account the changes involved, I deem the update passed the regression testing. It looks like it did well ... Ovidiu Maxiniuc

01:40 PM User Interface Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > The task branch 2559b has been... Hynek Cihlar

01:35 PM User Interface Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The task branch 2559b has been merged with trunk. Eugenie, you ... Constantin Asofiei

11:29 AM User Interface Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> The task branch 2559b has been merged with trunk. Eugenie, you can now merge the fixes by upda... Constantin Asofiei

12:53 PM User Interface Feature #2559 (Closed): implement ALERT-BOX support

Greg Shah

11:58 AM User Interface Feature #1790: implement menu support

Duplication error has gone after the last Hynek's update! Sorry to trouble. Vadim Gindin

11:22 AM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> Please, help me with my previous question about duplication. I still didn't find the reason.
... Vadim Gindin

11:01 AM User Interface Feature #1790: implement menu support

Please, hepl my with my previous question about duplication. I still didn't find the reason.
Additional question. ... Vadim Gindin

08:44 PM User Interface Feature #2546: implement combo-box widget in GUI

The update contains combo-box changes merged with recent code base without recently distributed @Scrollbar@ changes.
... Eugenie Lyzenko

06/22/2015

06:46 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

I found useful to add a method @LogicalTerminal.debug(int widgetId, message)@ and a corresponding (noop) method @Abst... Igor Skornyakov

04:47 PM User Interface Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> The task branch 2559b has been merged with trunk. Eugenie, you can now merge the fixes by upda... Eugenie Lyzenko

04:14 PM User Interface Feature #2252: implement GUI client support

The task branch 2559b has been merged with trunk. Eugenie, you can now merge the fixes by updating the trunk branch. Hynek Cihlar

10:51 AM User Interface Feature #2252: implement GUI client support

Greg, there is a change that affects ChUI so I would like to finish regression testing first. Hynek Cihlar

10:13 AM User Interface Feature #2252: implement GUI client support

Hynek: I think you should merge task branch 2559b revision 10883 with trunk and commit it. This will allow Eugenie t... Greg Shah

08:54 AM User Interface Feature #2252: implement GUI client support

Eugenie Lyzenko wrote:
> >The main window height was not properly calculated and so the scrollbar was shown when it ... Hynek Cihlar

04:01 PM Database Bug #2591 (WIP): incorrect queries when MATCH operator is involved

The 1st round of testing just ended. There are a lot (17) of failures in @gso_ctrlc_tests@ and some in @tc_tests@ (11... Ovidiu Maxiniuc

06/21/2015

06:02 PM User Interface Feature #2252: implement GUI client support

>The main window height was not properly calculated and so the scrollbar was shown when it should not have. This is a... Eugenie Lyzenko

02:55 PM User Interface Feature #2252: implement GUI client support

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > For #2559, please review regression fixes committed to task branch... Hynek Cihlar

06/20/2015

01:53 PM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review Task Branch 2559b Revision 10883
>
> I'm fine with the changes.
>
> Am I correc... Hynek Cihlar

10:46 AM User Interface Feature #2252: implement GUI client support

Code Review Task Branch 2559b Revision 10883
I'm fine with the changes.
Am I correct to assume the other items ... Greg Shah

10:29 AM User Interface Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> For #2559, please review regression fixes committed to task branch 2559b. The changes do not a... Eugenie Lyzenko

06:41 AM User Interface Feature #2252: implement GUI client support

For #2559, please review regression fixes committed to task branch 2559b. The changes do not affect ChUI so no Majic ... Hynek Cihlar

12:11 AM Database Bug #2591 (Test): incorrect queries when MATCH operator is involved

Nice work tracking this down quickly and fixing it. 10882 on branch looks good. Please regression test. I'll run unit... Eric Faulhaber

06/19/2015

05:18 PM User Interface Feature #2252: implement GUI client support

Task branch 2559 has been committed to bzr trunk, revision 10882. Hynek Cihlar

09:26 AM User Interface Feature #2252: implement GUI client support

Code Review Task Branch 2559 rev 10881
I'm good with the changes. Please merge to trunk, commit and notify. Greg Shah

09:21 PM User Interface Feature #2252: implement GUI client support

For #2559, I have resolved all the points from the last review, fixed all regressions and other bugs found. The chang... Hynek Cihlar

04:08 PM User Interface Feature #2546: implement combo-box widget in GUI

The update for review has implementation for @ThinClient@ change related to the mouse clicks outside drop-down. The n... Eugenie Lyzenko

10:44 PM User Interface Feature #2546: implement combo-box widget in GUI

The update for review has subtracted @Scrollbar@ related code that distributed separately. Also it contains suggested... Eugenie Lyzenko

10:07 PM User Interface Feature #2546: implement combo-box widget in GUI

Committed in bzr as @10881@. Eugenie Lyzenko

09:52 PM User Interface Feature #2546: implement combo-box widget in GUI

Testing completed, no regressions, had to run 3-way CTRL-C tests in separate session. The results are: @10879_bb2f7ec... Eugenie Lyzenko

08:25 PM User Interface Feature #2546: implement combo-box widget in GUI

Finally the main part of the testing for 0617b completed without regressions. I'm expecting to finish @CTRL-C@ testin... Eugenie Lyzenko

03:41 PM Base Language Bug #2592: improve support for implicit type conversions

I continued by digging into procedure call mechanism. In @ControlFlowOps@, there is @InternalEntryCaller.validate()@ ... Ovidiu Maxiniuc

03:39 PM Base Language Bug #2592: improve support for implicit type conversions

On 06/19/2015 10:04 PM, Constantin Asofiei wrote:
> Eric/Ovidiu,
>
> This is a new discovery. And it looks like i... Ovidiu Maxiniuc

03:38 PM Base Language Bug #2592: improve support for implicit type conversions

I found the following external procedure @caller.p@:... Ovidiu Maxiniuc

03:36 PM Base Language Bug #2592 (Closed): improve support for implicit type conversions

Ovidiu Maxiniuc

01:41 PM User Interface Feature #2563: implement GUI EDITOR widget

Greg Shah wrote:
> My only question is whether you want to go before or after Igor's #2534 changes?
I'd like to go ... Constantin Asofiei

12:34 PM User Interface Feature #2563: implement GUI EDITOR widget

> I have already checked in and distributed the 0617b Scrollbar related update.
Right, sorry.
> It is required... Greg Shah

11:08 AM User Interface Feature #2563: implement GUI EDITOR widget

Greg Shah wrote:
> ... I know you are waiting on Eugenie's to pass and be checked in and then will merge those...
... Eugenie Lyzenko

10:51 AM User Interface Feature #2563: implement GUI EDITOR widget

Code Review Task Branch 2563b revision 10884
I like the changes, nice improvement.
Hynek's changes will need to... Greg Shah

05:54 AM User Interface Feature #2563: implement GUI EDITOR widget

rebased branch 2563b, new revision is 10884 Constantin Asofiei

01:07 PM User Interface Feature #1790: implement menu support

I've fixed it. But now it displays sub-menu twice in 2 different places. Have a look please. Why it can happen? Vadim Gindin

06:46 AM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> Here is my current update. Could you review and help me? I can't understand why nested sub-men... Constantin Asofiei

03:58 AM User Interface Feature #1790: implement menu support

Here is my current update. Could you review and help me? I can't understand why nested sub-menu body isn't drawn when... Vadim Gindin

01:01 PM Database Bug #2591: incorrect queries when MATCH operator is involved

For review, this is branch 2591a/, at revision 10882. Ovidiu Maxiniuc

11:22 AM Database Bug #2591: incorrect queries when MATCH operator is involved

One test (CUSTOMER_SITE_7) of in the customer's testing batch was failing (not finding the record) for unknown reason... Ovidiu Maxiniuc

11:06 AM Database Bug #2591 (Closed): incorrect queries when MATCH operator is involved

Ovidiu Maxiniuc

06/18/2015

04:12 PM User Interface Feature #2563: implement GUI EDITOR widget

branch 2563b/rev 10882 passed testing Constantin Asofiei

08:19 AM User Interface Feature #2563: implement GUI EDITOR widget

branch 2563b/rev 10882: Fixed javadoc errors. Added mouse-double-click support. Fixed scrolling by mouse and other ... Constantin Asofiei

01:42 PM User Interface Feature #2546: implement combo-box widget in GUI

One more point to clarify.
I'm trying to make the drop-down list event processing loop more reliable an responsibl... Eugenie Lyzenko

02:30 AM User Interface Feature #2422: add features to BROWSE

It is not implemented at runtime (@Browse.java@):... Stanislav Lomany

06/17/2015

06:39 PM Database Bug #2589: remote request for next primary key gives wrong result when metadata DB is running

Requesting a next primary key for a database controlled by a remote server returns very low id numbers, typically sta... Eric Faulhaber

06:30 PM Database Bug #2589 (New): remote request for next primary key gives wrong result when metadata DB is running

Eric Faulhaber

05:05 PM User Interface Feature #2422: add features to BROWSE

I don't understand. As far as I can see, we already support @SET-REPOSITIONED-ROW@ both at runtime and in conversion... Greg Shah

04:55 PM User Interface Feature #2422: add features to BROWSE

> Doesn't @GET-REPOSITIONED-ROW@ still need to be done?
@GET-REPOSITIONED-ROW@ always returns _1_ unless the row w... Stanislav Lomany

11:37 AM User Interface Feature #2422: add features to BROWSE

>> What else is open in this task?
>
> My checklist:
> ...
Doesn't @GET-REPOSITIONED-ROW@ still need to be done? Greg Shah

03:44 PM User Interface Feature #2563: implement GUI EDITOR widget

Code Review 2563b branch (rev 10881)
This is a really good update. I don't have any concerns. Greg Shah

02:28 PM User Interface Feature #2563: implement GUI EDITOR widget

I've added the EDITOR changes (and some scroll-related changes from #2546 - rev 10880) to the 2563b branch (rev 10881... Constantin Asofiei

02:39 PM User Interface Feature #2546: implement combo-box widget in GUI

Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> > Here it is.
> @ScrollEvent@ class is needed - please add th... Eugenie Lyzenko

01:48 PM User Interface Feature #2546: implement combo-box widget in GUI

Code Review evl_upd20150617a.zip
I'm OK with the changes. Please get them regression tested. Greg Shah

01:42 PM User Interface Feature #2546: implement combo-box widget in GUI

Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Eugenie, can you extract the changes in the @Scrollbar*@ cla... Constantin Asofiei

10:34 AM User Interface Feature #2546: implement combo-box widget in GUI

Constantin Asofiei wrote:
> Eugenie, can you extract the changes in the @Scrollbar*@ classes in a separate update, s... Eugenie Lyzenko

09:49 AM User Interface Feature #2546: implement combo-box widget in GUI

Eugenie, can you extract the changes in the @Scrollbar*@ classes in a separate update, so they can be released? I thi... Constantin Asofiei

09:12 AM User Interface Feature #2546: implement combo-box widget in GUI

> And I'm inclining to leave the current approach for ChUI only mode and implement completely different approach in G... Greg Shah

09:09 AM User Interface Feature #2546: implement combo-box widget in GUI

Code Review evl_upd20150616a.zip
The code changes are fine. Greg Shah

08:51 PM User Interface Feature #2546: implement combo-box widget in GUI

The today update has small changes to event processing. The new class I have introduced in one previous update - @Com... Eugenie Lyzenko

06/16/2015

11:37 AM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute

It looks like button's DEFAULT attribute does not need to be checked in @FrameGuiImpl.processDefaultButton()@. Press... Greg Shah

11:28 AM User Interface Bug #2588 (Closed): test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTT...

Greg Shah

11:29 AM User Interface Feature #2563: implement GUI EDITOR widget

> Looks like the Progress bug or documentation miss. So we have to decide what strategy we will take here.
It does... Greg Shah

10:48 AM User Interface Feature #2546: implement combo-box widget in GUI

Greg Shah wrote:
> Code Reviews evl_upd20150611a.zip evl_upd20150613a.zip evl_upd20150614a.zip evl_upd20150615a.z... Eugenie Lyzenko

10:36 AM User Interface Feature #2546: implement combo-box widget in GUI

Code Reviews evl_upd20150611a.zip evl_upd20150613a.zip evl_upd20150614a.zip evl_upd20150615a.zip
I am generally... Greg Shah

10:17 AM User Interface Feature #1794: implement font support

There is a very useful discussion and tutorial in #2546 notes 92 and 98. This explains some problems with matching f... Greg Shah

09:09 AM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> > Btw., WindowGuiImpl.resolveTitleFont() allows to override the title font by the value of the wi... Constantin Asofiei

09:00 AM User Interface Feature #2252: implement GUI client support

> Btw., WindowGuiImpl.resolveTitleFont() allows to override the title font by the value of the window's BaseConfig.ti... Greg Shah

06:08 AM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> 1. The @AbstractWidget@ parent/ancestor lookup processing is much improved. It is easier to read... Hynek Cihlar

06/15/2015

05:08 PM User Interface Feature #2252: implement GUI client support

Code Review hc_upd20150612b.zip
This is a really nice improvement. I especially like the way you abstracted the a... Greg Shah

04:37 PM User Interface Feature #2546: implement combo-box widget in GUI

The metrics for the combo-box widget have already been captured into @uast/combo_box/metrics/@ folder (they are all f... Constantin Asofiei

09:38 AM User Interface Feature #2546: implement combo-box widget in GUI

Clarification about @VALUE-CHANGED@ event generation:
In all three modes mouse click and keyboard @UP@/@DOWN@ caus... Eugenie Lyzenko

08:30 AM User Interface Feature #2546: implement combo-box widget in GUI

Small change to fix entry field selection draw in @DROP-DOWN@ mode when drop-down list become active. Eugenie Lyzenko

11:28 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Code Review ias_upd20150612a.zip
Please go ahead with the merge. Stanislav's changes have been checked in. Here ... Greg Shah

11:01 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Igor Skornyakov wrote:
> Regarding the previous question. Is it OK to add a separate method @setInititialInnerLines(... Greg Shah

06/14/2015

06:04 PM User Interface Feature #2546: implement combo-box widget in GUI

More features findings for 4GL combo-box.
1. When combo-box is in @SIMPLE@ or @DROP-DOWN@ modes the entry field keep... Eugenie Lyzenko

09:10 AM User Interface Feature #2546: implement combo-box widget in GUI

Merged with recent @10879@ code base. Eugenie Lyzenko

04:41 AM User Interface Feature #2422: add features to BROWSE

INSERT-ROW, CURSOR-OFFSET, AUTO-ZAP and CURRENT-ROW-MODIFIED. Committed to bzr rev 10879. Stanislav Lomany

06/13/2015

05:55 PM User Interface Feature #2546: implement combo-box widget in GUI

The update for review fixes the drop-down incorrect coordinates setting. The idea is based on the fact the drop-down ... Eugenie Lyzenko

06/12/2015

06:30 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Fixed EDITOR regression, fixed all issues mentioned in the code review except the FRAME realization (only @VIEW@ and ... Igor Skornyakov

05:13 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Regarding the previous question. Is it OK to add a separate method @setInititialInnerLines()@ for use in compilation ... Igor Skornyakov

04:43 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

I have a problem. P2J compiles
DEFINE VARIABLE sl AS CHARACTER NO-UNDO
VIEW-AS SELECTION-LIST
INNER-LINES ... Igor Skornyakov

09:25 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> Please set it to M12.
Done. Igor Skornyakov

09:23 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Please set it to M12. Greg Shah

09:22 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> You can add watchers later, using the "Watchers (x)" section at the right side-bar of the task pa... Igor Skornyakov

09:19 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

> BTW: I've created another task #2582 as per Constantin request but forgot to add watches at the creation and I do n... Greg Shah

09:09 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> No. Please create a new task in the UI project and set its target version to M12. Also add me a... Igor Skornyakov

08:52 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

> Should I fix this bug in the scope of this task?
No. Please create a new task in the UI project and set its ta... Greg Shah

06:06 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

With P2L FillInWidget.getScreenValue() returns blank if the first read access was when the focus was in the different... Igor Skornyakov

03:41 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> Besides the items requested from the code review, what else still needs to be done for this task?... Igor Skornyakov

04:45 PM User Interface Feature #2563: implement GUI EDITOR widget

>Eugenie, new question: are you sure the button's DEFAULT attribute needs to be checked in @FrameGuiImpl.processDefau... Eugenie Lyzenko

04:09 PM User Interface Feature #2563: implement GUI EDITOR widget

Eugenie, new question: are you sure the button's DEFAULT attribute needs to be checked in @FrameGuiImpl.processDefaul... Constantin Asofiei

04:32 PM User Interface Feature #2252: implement GUI client support

The attached implements ALERT-BOX widget in Swing GUI. As related changes it also adds support for modal windows and ... Hynek Cihlar

09:04 AM User Interface Bug #2586: FillInWidget.getScreenValue() incorretly returns blank

Another minor issue with the @FillInWidget.getScreenValue()@
If you run p2j conversion of this test and type a space... Igor Skornyakov

08:56 AM User Interface Bug #2586: FillInWidget.getScreenValue() incorretly returns blank

ith P2L FillInWidget.getScreenValue() returns blank if the first read access was when the focus was in the different ... Igor Skornyakov

08:55 AM User Interface Bug #2586 (New): FillInWidget.getScreenValue() incorretly returns blank

Igor Skornyakov

06:05 AM User Interface Feature #2546: implement combo-box widget in GUI

Eugenie, first of all, see note 77 and the testcase at this note - the drop-down's coordinates are still incorrect. ... Constantin Asofiei

08:51 PM User Interface Feature #2546: implement combo-box widget in GUI

>That will be a memory leak. Static widgets shouldn't last for the application lifetime. They should only live while ... Eugenie Lyzenko

03:25 AM User Interface Feature #1790: implement menu support

Vadim Gindin wrote:
> I can check this field @WindowGuiImpl.mousePressedSource@ in @MenuItemGuiImpl.mouseMoved()@ to... Constantin Asofiei

06/11/2015

05:49 PM User Interface Feature #2546: implement combo-box widget in GUI

That will be a memory leak. Static widgets shouldn't last for the application lifetime. They should only live while ... Greg Shah

05:37 PM User Interface Feature #2546: implement combo-box widget in GUI

>My only question is about @WidgetRegistry.addContainer()@. How do those registered widgets get removed when they are... Eugenie Lyzenko

02:36 PM User Interface Feature #2546: implement combo-box widget in GUI

Code Review evl_upd20150610a.zip
I think this is very good. I especially like the new @EntryFieldGuiImpl@.
My ... Greg Shah

09:19 PM User Interface Feature #2546: implement combo-box widget in GUI

Some samples to illustrate @SIMPLE@ mode of the combo-box. Eugenie Lyzenko

08:56 PM User Interface Feature #2546: implement combo-box widget in GUI

The next update for review has the good shape combo-box implementation with all three modes available. Key and mouse ... Eugenie Lyzenko

05:33 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Besides the items requested from the code review, what else still needs to be done for this task? Greg Shah

01:13 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> I think it is realized the first time it is made visible. @ENABLE@ is just one way to make the... Igor Skornyakov

01:11 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

>> 3. Should GenericFrame.validateLayout() be called whenever the frame is realized (not just during ENABLE)?
>
> S... Greg Shah

11:23 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> Code Review ias_upd20150605a.zip
> 3. Should @GenericFrame.validateLayout()@ be called wheneve... Igor Skornyakov

10:29 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Code Review ias_upd20150605a.zip
1. I think we may want to implement a method in @GenericWidget@ for the core vali... Greg Shah

03:34 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> OK, the plan:
>
> 1. You can keep the @DISABLE-AUTO-ZAP@ support in the config and server-side... Igor Skornyakov

01:58 PM Database Bug #2488: replace runtime compilation of dynamic queries

Please commit and distribute 0611a. Thanks. Eric Faulhaber

01:48 PM Database Bug #2488: replace runtime compilation of dynamic queries

The attached update is basically the same as 0610a except for the comment form @build.xml@ removed and a cascading @i... Ovidiu Maxiniuc

12:28 PM Database Bug #2488: replace runtime compilation of dynamic queries

I tested the 0610a update with the full set of search unit tests. I can confirm that it fixed the problematic test an... Eric Faulhaber

01:46 AM Database Bug #2488: replace runtime compilation of dynamic queries

Code review 0610a:
Looks good. Assuming your local testing confirms it fixes the problem, please run conversion re... Eric Faulhaber

01:41 PM Database Bug #2552 (Closed): bad hql caching prevents queries to position on the correct rows

Eric Faulhaber

01:40 PM Database Bug #2552: bad hql caching prevents queries to position on the correct rows

The 0608c update passed the regression testing, was committed to bzr as revno 10876 and distributed by mail. Ovidiu Maxiniuc

09:31 AM User Interface Feature #2422: add features to BROWSE

Yes, you should go ahead and implement it. Inserting before the first or after the last seems like something that is... Greg Shah

09:21 AM User Interface Feature #2422: add features to BROWSE

> I would like you to please get the current update through regression testing and checked in. This will free up oth... Stanislav Lomany

09:04 AM User Interface Feature #2422: add features to BROWSE

I would like you to please get the current update through regression testing and checked in. This will free up other... Greg Shah

07:12 AM User Interface Feature #2422: add features to BROWSE

> What else is open in this task?
My checklist:
# Page up/down, home/end doesn't work in editable browse.
# Unin... Stanislav Lomany

02:35 AM User Interface Feature #1790: implement menu support

I'm trying to implement the following behavior. Assume we have menubar. Mouse pointer is located somewhere outside of... Vadim Gindin

06/10/2015

06:13 PM User Interface Feature #2422: add features to BROWSE

> AUTO-ZAP and CURSOR-OFFSET are done
OK.
> except separate task #2576. Let me know if I should work on this t... Greg Shah

12:11 PM User Interface Feature #2422: add features to BROWSE

> In regard to this comment @// Oddly enough, 4GL returns zap state of the FOCUSED fill-in, not necessarily this one@... Stanislav Lomany

11:36 AM User Interface Feature #2422: add features to BROWSE

> When do you expect to have everything 100% complete? Igor's work in #2534 is dependent upon your changes for @AUTO... Stanislav Lomany

10:49 AM User Interface Feature #2422: add features to BROWSE

Code Review svl_upd20150610a.zip
In regard to this comment @// Oddly enough, 4GL returns zap state of the FOCUSED ... Greg Shah

04:52 AM User Interface Feature #2422: add features to BROWSE

Removed excess function @isNewRow@ from the previous update. Stanislav Lomany

06:12 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

OK, the plan:
1. You can keep the @DISABLE-AUTO-ZAP@ support in the config and server-side getters/setters of your... Greg Shah

12:02 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Actually I suggest to retain a DISABLE-AUTO-ZAP support in the config and at the server-side (getters/setters).
Gr... Igor Skornyakov

11:48 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> Not for FILL-IN. But COMBO-BOX support is not part of Stanislav's work.
>
For the COMBO-BOX t... Igor Skornyakov

11:32 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

> Do you think that it makes sense for me to continue working on the AUTO-ZAP?
Not for FILL-IN. But COMBO-BOX sup... Greg Shah

11:19 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg,
As I can see my changes for the FillIn significantly intersect with ones of Stanislav. My first impression is ... Igor Skornyakov

10:44 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Greg Shah wrote:
> Stanislav has also implemented @CURSOR-OFFSET@ for @FillIn@ in #2422.
Thank you Greg. Igor Skornyakov

10:42 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Stanislav has also implemented @CURSOR-OFFSET@ for @FillIn@ in #2422. Greg Shah

10:36 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX

Please look at Stanislav's most recent changes in #2422. He is making changes related to @AUTO-ZAP@ in @FillIn@. Sp... Greg Shah

02:53 PM User Interface Feature #1790: implement menu support

> I've found that such fields are exist not in config classes
They would only be put into config classes if the da... Greg Shah

12:01 PM User Interface Feature #1790: implement menu support

I've found that such fields are exist not in config classes, but in GUI widget classes itself. For example @ButtonGui... Vadim Gindin

11:56 AM User Interface Feature #1790: implement menu support

The question about widget (menu-item or sub-menu) state, that could be changed by mouse events: "mouse enter" (mouse ... Vadim Gindin

01:55 PM Database Bug #2488: replace runtime compilation of dynamic queries

I have a fix for the issue. There are 3 important changes:
# the @convert/variable_references.rules@ was added to ru... Ovidiu Maxiniuc

08:26 PM User Interface Feature #2546: implement combo-box widget in GUI

The next update for review has suggested approach for SIMPLE mode implementation. The idea is a bit different that us... Eugenie Lyzenko

06/09/2015

03:52 PM Database Bug #2488: replace runtime compilation of dynamic queries

The P4GL converted query is:... Ovidiu Maxiniuc

03:19 PM Database Bug #2488: replace runtime compilation of dynamic queries

I was able to duplicate the issue. One occurrence is in @test[Entity=|+TNCY_TENANT| TestType=|SEARCH| TestSubType=|SE... Ovidiu Maxiniuc

01:04 PM Database Bug #2536: improve dynamic query parser error handling

The logging level for exceptions was lowered to @FINE@ to keep the @CONFIG@ level free for configuration issues.
Th... Ovidiu Maxiniuc