FWD

07/22/2016

04:23 PM Database Feature #3145: implement _File._Template metadata support

Copy/pasted from mail conversation. Please read in timestamp (reverse) order:
# To check meta support, I will add ... Ovidiu Maxiniuc

12:16 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> Why all @WindowActivated@ events have the same id=-1?
This is fine, @WA@ doesn't use the @i... Hynek Cihlar

12:15 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> Here it is.
> !2966_output.txt!
I don't find anything wrong with this output actually. Wou... Hynek Cihlar

11:44 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Here it is.
!2966_output.txt! Vadim Gindin

11:03 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Please post your standard output (just after the problem appears and with my changes). Hynek Cihlar

10:40 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

I was seing the error each time. I've applied your change but id didn't helped: I still see the error each time. Vadim Gindin

09:52 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

I was able to replicate the problem you describe (sub-menu A is hidden when its child sub-menu is closed due to mouse... Hynek Cihlar

09:42 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Why all @WindowActivated@ events have the same id=-1?
Hynek, have you try to debug?
Need advice how to debug it.. Vadim Gindin

08:53 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

It's hard to debug it because when window focus is switched to debugger - that triggers menus closing in itself. Vadim Gindin

08:43 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

It looks that error happen because of @SubMenuGuiImpl.hideBodies(parent(), null)@ call in @MenuItemGuiImpl.onFocusGai... Vadim Gindin

12:10 PM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys

Please review task branch 2894a revision 11073. Stanislav Lomany

09:22 AM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys

Created task branch 2894a from trunk revision 11072. Stanislav Lomany

06:21 AM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys

Never mind, ctrl and shift modifiers can be found in @MouseEvent@.
The functionality is:
* On @ctrl+click@: add/r... Stanislav Lomany

05:16 AM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys

Don't we just need to know if these modifier keys are on at the time the mouse is clicked on a row? I imagine there ... Greg Shah

05:01 AM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys

Stanislav Lomany wrote:
> Guys, as far as I get we don't have a way to figure out if a key is held down (or released... Hynek Cihlar

10:54 AM Bug #3002 (Closed): static code analysis issues

We expect future efforts to run static code analysis and review the results. Whomever does that should encode the re... Greg Shah

07/21/2016

05:35 PM User Interface Feature #2894 (WIP): Implement browse multiple selection with Shift and Ctrl keys

Guys, as far as I get we don't have a way to figure out if a key is held down (or released)? Stanislav Lomany

01:58 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

I've committed my changes with debugging information and rebased the branch. Now current revision is 11081. I recall,... Vadim Gindin

12:39 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Vadim Gindin wrote:
> > > I need some help.
> > >
> > > The probl... Hynek Cihlar

12:09 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > I need some help.
> >
> > The problem is the following. I have 2 n... Vadim Gindin

01:22 PM Base Language Bug #2657 (Closed): appserver agent context reset does not deallocate currently allocated memptr ...

Greg Shah

12:38 PM Database Feature #3145: implement _File._Template metadata support

Ovidiu Maxiniuc wrote:
> I tried to isolate only the simple queries that expressly seek the template record. These q... Eric Faulhaber

12:28 PM Database Feature #3145: implement _File._Template metadata support

Eric Faulhaber wrote:
>
> The changes to @PreselectQuery@ I think need some attention, but not at this time. Note ... Ovidiu Maxiniuc

09:16 AM Database Feature #3145: implement _File._Template metadata support

Code review 3145a/11077:
Sorry I didn't get to this yesterday. From my understanding of the template record featur... Eric Faulhaber

07/20/2016

04:27 PM Database Feature #3145: implement _File._Template metadata support

I implemented support for loading template records in simple @PreselectQuery@. The trick was to intercept the templat... Ovidiu Maxiniuc

11:08 AM User Interface Bug #3142 (Closed): the mouse "hotspot" in the web client is in an unexpected location

The fix for this issue is the same fix for #2893. That change went into the trunk with revision 11072. Greg Shah

10:58 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> Yes. Parent sub-menu should be activated when child sub-menu is closed (deactivated), so I wan... Hynek Cihlar

10:21 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > Hynek Cihlar wrote:
> > > Vadim Gindin wrote:
> > > > How to determ... Vadim Gindin

10:03 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Vadim Gindin wrote:
> > > How to determine ParentSm there?
> >
> ... Hynek Cihlar

08:33 PM User Interface Bug #2893 (Closed): Mouse clicks on rows are not 100% accurate

Greg Shah

07/19/2016

07:37 PM User Interface Bug #2893 (Review): Mouse clicks on rows are not 100% accurate

Stanislav Lomany

07:24 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

2893a was merged into the trunk as bzr revision 11072. Stanislav Lomany

06:11 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

OK, merge it to trunk. Greg Shah

06:11 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

I've checked testcases for widgets and menus and ran some customer GUI app scenarios. Stanislav Lomany

06:07 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

Code Review Task Branch 2893a Revision 11073
I'm fine with the changes.
Have you done enough manual GUI testing... Greg Shah

04:58 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

Task branch 2893a rebased from trunk rev 11071.
I did some GUI testing. Please review. Stanislav Lomany

01:43 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > How to determine ParentSm there?
>
> To get the parent sub menu us... Vadim Gindin

08:32 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> How to determine ParentSm there?
To get the parent sub menu use the @MenuElement.getParentS... Hynek Cihlar

07:50 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > Hynek Cihlar wrote:
> > > > ...
> > > > 3. Parent/Child SUB-MENU's ... Vadim Gindin

07:40 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > > ...
> > > 3. Parent/Child SUB-MENU's windows are always share acti... Hynek Cihlar

07:28 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek Cihlar wrote:
> > ...
> > 3. Parent/Child SUB-MENU's windows are always share activation state (in sense of @... Vadim Gindin

07:20 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> Hynek, I stuck with that. Could you help me..
>
> 1. It seems @WindowManager.processWindowA... Hynek Cihlar

03:44 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek, I stuck with that. Could you help me..
1. It seems @WindowManager.processWindowActivated()@ identifies what... Vadim Gindin

11:58 AM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat

Branch 1735e was created from P2J trunk revision 11071. Greg Shah

11:39 AM Database Feature #3145: implement _File._Template metadata support

Ovidiu Maxiniuc wrote:
> I will review the @setCurrentRecord@ and add supplementary conditionals so that the templat... Eric Faulhaber

11:07 AM Database Feature #3145: implement _File._Template metadata support

Thanks for review, Eric!
Eric Faulhaber wrote:
> Code review 3145a/11072:
>
> Please help me understand the purp... Ovidiu Maxiniuc

10:35 AM Database Feature #3145: implement _File._Template metadata support

Code review 3145a/11072:
Please help me understand the purpose of the @variable_references.rules@ change. Aren't w... Eric Faulhaber

07/18/2016

04:32 PM Database Feature #3145: implement _File._Template metadata support

Eric Faulhaber wrote:
> I think we just have to accept that a FIND by RECID/ROWID is a special case. Do we behave th... Ovidiu Maxiniuc

02:17 PM Database Feature #3145: implement _File._Template metadata support

Ovidiu Maxiniuc wrote:
> I have created the task branch 3145a. The last revision is 11072.
>
> I discovered that ... Eric Faulhaber

02:20 PM User Interface Bug #2528: finish investigation and implemention of INPUT, SCREEN-VALUE and INPUT-VALUE

A simple version of @INPUT-VALUE@ has been implemented. It has been mapped to the getter for each widget, which is t... Greg Shah

01:53 PM User Interface Bug #2767 (Rejected): implement INPUT-VALUE attribute properly for all widget types

This is a duplicate of #2528. Greg Shah

01:27 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

> In the new code the first parameter is not used. Considering that in practice this function always takes this as th... Greg Shah

11:59 AM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

Also, should I skip regression testing because it is GUI-changes only? Stanislav Lomany

11:58 AM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

@translate@ function has two parameters:... Stanislav Lomany

07/15/2016

05:25 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

Greg Shah wrote:
> > The translation of parent's insets should be made only for BorderedPanelGuiImpl, see AbstractWi... Hynek Cihlar

05:13 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

> The translation of parent's insets should be made only for BorderedPanelGuiImpl, see AbstractWidget.screenPhysicalL... Greg Shah

05:02 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

Code Review Task Branch 2893a Revision 11070.
The translation of parent's insets should be made only for @Bordere... Hynek Cihlar

02:31 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

Code Review Task Branch 2893a Revision 11070
I'm OK with the change.
Hynek: please review. Greg Shah

01:35 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

The browse issue I've noted in the daily report is not an issue.
So please review task branch 2893a revision 11070. Stanislav Lomany

10:56 AM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

Created task branch 2893a from trunk revision 11069. Stanislav Lomany

04:14 PM Database Feature #3145: implement _File._Template metadata support

I have created the task branch 3145a. The last revision is 11072.
I discovered that any 'find by rowid/recid' first/... Ovidiu Maxiniuc

02:54 PM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers

2657b was rebased and committed to trunk as revision 11070. Notification email was sent to team. The test results on ... Ovidiu Maxiniuc

02:21 PM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers

As noted in #3109 note 87 the @batchProgramTest@ finished flawlessly. I am rebasing now to 11069 and commit to trunk. Ovidiu Maxiniuc

02:16 PM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers

> If the current ETF test is fine (batch), I intend to merge the update into trunk.
Perfect! Greg Shah

01:03 PM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers

Greg Shah wrote:
> How is testing coming along?
The update PASSED the regression testing on devsrv01. It also had... Ovidiu Maxiniuc

12:54 PM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers

How is testing coming along? Greg Shah

12:35 AM User Interface Bug #3150: A Slider widget doesn't respond to mouse dragging.

During the manual GUI testing I found that the slider doesn't respond to mouse dragging. Only mouse clicking changes ... Sergey Ivanovskiy

12:34 AM User Interface Bug #3150 (New): A Slider widget doesn't respond to mouse dragging.

Sergey Ivanovskiy

07/14/2016

03:53 PM User Interface Bug #3148: UP and DOWN keys don't work with menus

Open a simple menu and try to move the currently selected item using UP and DOWN keys. UP and DOWN keys don't change ... Sergey Ivanovskiy

03:48 PM User Interface Bug #3148 (Feedback): UP and DOWN keys don't work with menus

Sergey Ivanovskiy

03:02 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

This screen illustrates what is the proper hot spot for Java2D and standard Ubuntu cursor. It is +1/+2 relatively to ... Stanislav Lomany

01:35 PM User Interface Bug #3142: the mouse "hotspot" in the web client is in an unexpected location

No, I didn't see this behavior. For the combo box I can observe only that its drop down detects the selected item inc... Sergey Ivanovskiy

12:53 PM User Interface Bug #3142: the mouse "hotspot" in the web client is in an unexpected location

I don't think I am describing the same thing. Actually, I don't understand the problem you are describing.
The "m... Greg Shah

03:44 AM User Interface Bug #3142: the mouse "hotspot" in the web client is in an unexpected location

If we are selecting an entry with the mouse pointer from the "<customer> GUI Simple Test Harness" window , then the c... Sergey Ivanovskiy

10:08 PM Database Feature #3145: implement _File._Template metadata support

Ovidiu Maxiniuc wrote:
> I started the implementation. To correctly identify the searched by RECID/ROWID I adjusted ... Eric Faulhaber

07/13/2016

05:25 PM Database Feature #3145: implement _File._Template metadata support

I started the implementation. To correctly identify the searched by RECID/ROWID I adjusted the @HQLPreprocessor.check... Ovidiu Maxiniuc

04:01 PM Database Feature #3145: implement _File._Template metadata support

Eric Faulhaber wrote:
> > Some additional pieces of information:
> > * the @_template@ seems to be not unknown, but... Ovidiu Maxiniuc

03:44 PM Database Feature #3145: implement _File._Template metadata support

Ovidiu Maxiniuc wrote:
> [...]
> Because of these issues, I think we will stick to '-1' approach.
Agreed, this sho... Eric Faulhaber

01:54 PM Database Feature #3145 (WIP): implement _File._Template metadata support

Probably the correct way to implement this to match P4GL behaviour is at import time. Or maybe an intermediary step i... Ovidiu Maxiniuc

11:27 AM Database Feature #3145: implement _File._Template metadata support

In terms of implementing this feature in P2J, it seems the @_File._Template@ field could always contain -1 for table ... Eric Faulhaber

11:25 AM Database Feature #3145: implement _File._Template metadata support

The @MetaFile@ DMO is converted from the @_File@ metadata table. It is populated at server startup with read-only dat... Eric Faulhaber

11:12 AM Database Feature #3145 (Closed): implement _File._Template metadata support

Eric Faulhaber

04:58 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

Most likely it is. Stanislav Lomany

04:32 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate

Could this be the same problem as described in #3142? Greg Shah

03:26 PM User Interface Bug #2893 (WIP): Mouse clicks on rows are not 100% accurate

That is a general issue with @AbstractWidget.translate(Widget<O>, MouseEvent)@. It also can be seen e.g. in radio set... Stanislav Lomany

07/12/2016

04:01 PM Database Bug #3144: Provide correct legacy name for a RecordBuffer/TemporaryBuffer

Constantin Asofiei wrote:
> The idea behind note 105 in #2645 is this. Use a shared temp-table, in two programs:
>... Igor Skornyakov

03:59 PM Database Bug #3144: Provide correct legacy name for a RecordBuffer/TemporaryBuffer

Igor Skornyakov wrote:
> Constantin,
> Eric suggested that your comments 105,106 for #2645 should be in the scope ... Constantin Asofiei

03:50 PM Database Bug #3144: Provide correct legacy name for a RecordBuffer/TemporaryBuffer

Constantin,
Eric suggested that your comments 105,106 for #2645 should be in the scope of this task as well. Unfort... Igor Skornyakov

03:43 PM Database Bug #3144: Provide correct legacy name for a RecordBuffer/TemporaryBuffer

Before the revision 11067 the legacy names for the temporary tables and buffers was always converted to lower case. I... Igor Skornyakov

03:36 PM Database Bug #3144 (New): Provide correct legacy name for a RecordBuffer/TemporaryBuffer

Igor Skornyakov

03:41 PM User Interface Feature #2628 (WIP): Non-fill-in column support in browse.

FYI, as far as I understand non-fill-in columns are not used in browse in the customer app. Stanislav Lomany

12:12 PM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers

I totally agree with all your changes.
I am going to put this update to full runtime test. Conversion test is not n... Ovidiu Maxiniuc

11:11 AM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers

Code Review Task Branch 2657b Revision 11068
I'm OK with the changes, but I've checked in some additional comments... Greg Shah

12:03 PM Database Feature #2274 (Closed): improve performance of new database features

Eric Faulhaber

12:02 PM Database Feature #2275 (Closed): cache of runtime-converted, dynamic queries and temp-tables

Eric Faulhaber

07:03 AM Database Bug #3130 (WIP): remove p2j_id_generator_sequence from generated index ddl

Task branch 3130a was created from trunk rev 11066.
The fix for the issue was committed as revision 11067. Ovidiu Maxiniuc

07/11/2016

05:59 PM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers

Task Branch 2657b updated. Last revision revision 11068.
I identified the cause of the differences we see because ... Ovidiu Maxiniuc

04:32 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Vadim Gindin wrote:
> > > I need some help.
> > >
> > > The probl... Hynek Cihlar

01:07 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > I need some help.
> >
> > The problem is the following. I have 2 n... Vadim Gindin

07/10/2016

12:39 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> I need some help.
>
> The problem is the following. I have 2 nested opened SUB-MENUs. I'm n... Hynek Cihlar

05:53 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

At first sight I would suppose to exclude sub-menu's windows from this processing especially because of these windows... Vadim Gindin

05:46 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Small additional description. There are possible 2 ways for menus navigation:
# In some cases current sub-menu body... Vadim Gindin

05:42 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

I need some help.
The problem is the following. I have 2 nested opened SUB-MENUs. I'm navigating inside the body o... Vadim Gindin

07/08/2016

11:09 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

I've fixed all exceptions. The only one bug is remained. When navigating inside popup menu: sm -> mi -> (back to) sm ... Vadim Gindin

07/07/2016

04:49 PM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers

Code Review Task Branch 2657b Revision 11067
1. The @SecurityOps.base64Encode()@ changes remove code that I believ... Greg Shah

12:39 PM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers

Greg Shah wrote:
> There is no revision 11067 in 2657b on devsrv01.
I did the commit operation again, this time on ... Ovidiu Maxiniuc

11:48 AM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers

I just retested these on lindev01. They all work as expected, except that I do see @BASE64-ENCODE of an large negati... Greg Shah

11:36 AM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers

There is no revision 11067 in 2657b on devsrv01. Greg Shah

11:04 AM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers

> It looks like those testcases are deprecated. Apparently they were written for an older version of OpenEdge.
> I t... Greg Shah

10:57 AM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers

Greg,
It looks like those testcases are deprecated. Apparently they were written for an older version of OpenEdge.
... Ovidiu Maxiniuc

08:45 AM User Interface Bug #3143: An infinite loop while closing a dialog

With the attached program when I press OK button in the alert box I see the following exception in the client log
<p... Igor Skornyakov

08:42 AM User Interface Bug #3143 (New): An infinite loop while closing a dialog

Igor Skornyakov

05:30 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> Current situation is the following. I'd fixed @lastHoveredWidget.isDisplayed()@. Now it return... Hynek Cihlar

03:25 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Current situation is the following. I'd fixed @lastHoveredWidget.isDisplayed()@. Now it returns @false@ as it must re... Vadim Gindin

07/06/2016

06:38 PM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers

I haven't gotten a chance to review your changes yet. But I did want to mention that I implemented the negative buff... Greg Shah

03:43 PM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers

Task branch 2657b was created from trunk 11066.
Latest revision (11067) contains:
* @memptr.duplicate()@ copies buf... Ovidiu Maxiniuc

05:49 PM User Interface Bug #3142: the mouse "hotspot" in the web client is in an unexpected location

In the web client (using Firefox) I can see that the location of the cursor hotspot seems to be too low. This become... Greg Shah

05:46 PM User Interface Bug #3142 (Closed): the mouse "hotspot" in the web client is in an unexpected location

Greg Shah

07/01/2016

11:49 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Third type of error: ... Vadim Gindin

09:45 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > I need some help. There are 2 exceptions possible. The first of them ... Hynek Cihlar

09:42 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> I need some help. There are 2 exceptions possible. The first of them is described in the note ... Hynek Cihlar

08:48 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Another case:
Will be it correct to remove window from @WindowManager.WorkArea.windows@ list when @AbstractGuiDriver... Vadim Gindin

08:37 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

I need some help. There are 2 exceptions possible. The first of them is described in the note 3. The second one is th... Vadim Gindin

06/30/2016

02:25 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim: please take this, Hynek has other items that are higher priority. Greg Shah

02:24 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

At this moment the problem exists in trunk 11058. Hynek, have a look please. Vadim Gindin

01:57 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> I was checking that several times. As I can see the error appeared first time in the revision ... Hynek Cihlar

01:44 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

I was checking that several times. As I can see the error appeared first time in the revision 11042..
I would sup... Vadim Gindin

06/29/2016

08:31 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

I'll check it. Vadim Gindin

08:26 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

There is no revision 11059. I think you never did a @bzr bind@ before committing your update. Please do a @bzr push... Greg Shah

08:15 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Greg Shah wrote:
> Code Review Task Branch 2966a Revision 11057
>
> 1. Please rebase.
>
> 2. Add history entr... Vadim Gindin

07:58 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Code Review Task Branch 2966a Revision 11057
1. Please rebase.
2. Add history entries. Greg Shah

07:50 AM User Interface Bug #2966 (WIP): NullPointerException is raised when RMB is clicked to show popup menu

Does this also fix the issue described in #2952-33 ?
If not, please fix that ASAP. Greg Shah

07:48 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Greg Shah wrote:
> > I've fixed that. Please review the task. Current revision is 11056.
>
> When you say "that",... Vadim Gindin

07:43 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

> I've fixed that. Please review the task. Current revision is 11056.
When you say "that", do you mean you have fi... Greg Shah

07:33 AM User Interface Bug #2952 (Closed): ui_strings.txt is empty for simple_sm.p

Greg Shah

07:32 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

The branch 2952a is archived. Vadim Gindin

07:21 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Committed to trunk 11056. Vadim Gindin

07:10 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

> I'm not sure about the reason but I think this the same bug. We can also see some blinking during sub-menu navigati... Greg Shah

07:07 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Greg Shah wrote:
> > > > It seems it is not related to my changes.
> > > Is this related to what you found in #2966... Vadim Gindin

07:02 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

> > > It seems it is not related to my changes.
> > Is this related to what you found in #2966?
>
> Yes, it is th... Greg Shah

07:00 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

OK, please merge to trunk. Greg Shah

04:06 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > It seems it is not related to my changes.
> Is this related to... Vadim Gindin

04:02 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Vadim Gindin wrote:
> It seems it is not related to my changes.
Is this related to what you found in #2966?
Constantin Asofiei

03:13 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

I've checked GUI menu cases @simple_sm.p@ and @popup_ext.p@. They are broken. The error happen also in trunk. The exc... Vadim Gindin

02:32 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Conversion and regression testing are PASSED. I'm checking GUI menu testcases. Vadim Gindin

06/28/2016

03:30 PM Database Bug #3138: case-sensitivity propagation

In 4GL the case sensitivity of some character parameters is propagated to the result of the character functions.
... Ovidiu Maxiniuc

03:06 PM Database Bug #3138 (New): case-sensitivity propagation

Ovidiu Maxiniuc

01:11 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

I've fixed that. Please review the task. Current revision is 11056. Vadim Gindin

05:34 AM Conversion Tools Bug #3135: Icorrect conversion of FRAME:SIDE-LABELS in CREATE FRAME

Greg Shah wrote:
> This is expected since we currently have no conversion or runtime support for this attribute (on ... Hynek Cihlar

08:16 PM Conversion Tools Bug #3135: Icorrect conversion of FRAME:SIDE-LABELS in CREATE FRAME

This is expected since we currently have no conversion or runtime support for this attribute (on a create statement o... Greg Shah

08:02 PM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Please check in your changes.
> Should I run also runtime-regression or only conversion-regression is sufficient?
... Greg Shah

06/27/2016

07:44 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

> > Hynek, the test is in the first note. The bug is also happen in trunk.
>
> This seems to be caused by your cha... Greg Shah

03:59 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> Hynek, the test is in the first note. The bug is also happen in trunk.
This seems to be cau... Hynek Cihlar

02:45 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek, the test is in the first note. The bug is also happen in trunk. Vadim Gindin

10:45 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> I've faced new bug, related to new drawing:
> !extra_space.png!
> Sizes of popup and sub-men... Hynek Cihlar

10:44 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> See the change. !window.diff.txt!
Yes, the change is correct. Hynek Cihlar

09:23 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

I've faced new bug, related to new drawing:
!extra_space.png!
Sizes of popup and sub-menu are equal to Progress, bu... Vadim Gindin

05:15 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

See the change. !window.diff.txt!
Vadim Gindin

05:11 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > Can it be related with the latest enhancement when menu implementatio... Vadim Gindin

05:10 PM User Interface Bug #3137: DELETE WIDGET does not hide the frame

When a visible dynamic frame is destroyed with DELETE WIDGET it should be made hidden, in current trunk it stays visi... Hynek Cihlar

05:08 PM User Interface Bug #3137 (New): DELETE WIDGET does not hide the frame

Hynek Cihlar

02:15 PM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

I've renamed @init()@ to @prepare()@. Should I run also runtime-regression or only conversion-regression is sufficient? Vadim Gindin

09:54 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Vadim, the 2952a rev 11057 is OK; the only change in 2952a is what Greg mentioned: rename @MnemonicInfo.init()@ to @M... Constantin Asofiei

07:59 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Code Review Task Branch 2952a Revision 11057
Constantin will be doing a code review, since he wrote the ui_strings... Greg Shah

02:26 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

The work is done. Please review and approve regression testing. I've rebased the branch. Current revision is 11057. Vadim Gindin

01:07 PM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client

It seems that the cause of the issue is @openScope()@ not being generated for a frame when it has no widgets. @openSc... Hynek Cihlar

12:40 PM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client

EDIT: Removed WITH from the sample code.
Running the following converted sample will cause an unexpected @RuntimeExc... Hynek Cihlar

12:37 PM User Interface Bug #3136 (Closed): Unhandled exception after VIEW frame, due to frame widget not registered on t...

Hynek Cihlar

10:57 AM Conversion Tools Bug #3135: Icorrect conversion of FRAME:SIDE-LABELS in CREATE FRAME

"Unsupported method or attribute KW_SIDE_L." is reported when converting the following sample.... Hynek Cihlar

10:55 AM Conversion Tools Bug #3135 (New): Icorrect conversion of FRAME:SIDE-LABELS in CREATE FRAME

Hynek Cihlar

06/24/2016

10:58 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

I've fixed all remarks. Please review. Current branch 2952a revision is 11056. Vadim Gindin

10:54 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > This also doesn't work
> Are you sure you are using the right ... Vadim Gindin

10:44 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Vadim Gindin wrote:
> This also doesn't work
Are you sure you are using the right rules? I've just tested it and it... Constantin Asofiei

10:38 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

This also doesn't work Vadim Gindin

10:36 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Use the folder name, too:... Constantin Asofiei

10:28 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

I've added @<include name="common-convert" />@ in both files menu_generator.xml and frame_generator.xml. For menus it... Vadim Gindin

09:22 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Vadim Gindin wrote:
> This one @rules/convert/common-convert.rules@?
Yes. Constantin Asofiei

09:22 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

This one @rules/convert/common-convert.rules@? Vadim Gindin

09:19 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Vadim Gindin wrote:
> Where should I place noted common function? May be to @rules/include/common-progress.rules@?
... Constantin Asofiei

09:18 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Where should I place noted common function? May be to @rules/include/common-progress.rules@? Vadim Gindin

08:51 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Vadim Gindin wrote:
> # Side-labels follow the same label preparation rules. In other words prepared labels are the ... Constantin Asofiei

08:36 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

# Side-labels follow the same label preparation rules. In other words prepared labels are the same (labels are prepar... Vadim Gindin

07:42 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Vadim, review for 2952a 11054:
# @menu_generator.xml@ - please move this code to the @init-rules@ block (otherwise @... Constantin Asofiei

06:54 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Please review. Current branch revision is 11054 (rebased with current trunk). Should I change also frame_generator.xm... Vadim Gindin

07:20 AM User Interface Bug #2857 (Closed): font differences for toggle box and menu

Greg Shah

06:59 AM User Interface Bug #2857: font differences for toggle box and menu

I've created the task #3134 for CHUI issues. Vadim Gindin

06:13 AM User Interface Bug #2857: font differences for toggle box and menu

Please create a separate task for those. Do not work them right now. I will close this task when the new task is op... Greg Shah

05:12 AM User Interface Bug #2857: font differences for toggle box and menu

The CHUI issues are left in this task. Vadim Gindin

02:00 AM User Interface Bug #2857: font differences for toggle box and menu

The changes passed regression testing and committed to trunk as revision 11053. Vadim Gindin

06:58 AM User Interface Bug #3134: CHUI menu issues when some labels are empty

The following issues was found in #2857 task (note 23):... Vadim Gindin

06:57 AM User Interface Bug #3134 (New): CHUI menu issues when some labels are empty

Vadim Gindin

06:51 AM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat

Branch 1735d has been merged to trunk as revision 11054. 1735d was archived. Greg Shah

06:37 AM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat

Branch 1735d has been rebased from trunk revision 11053. The latest revision is now 11060. Since there are no confl... Greg Shah

06:34 AM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat

Regression testing for 1735d revision 11058 has passed. Greg Shah

06/23/2016

04:25 PM User Interface Bug #2857: font differences for toggle box and menu

Yes, go ahead and merge 2857a to trunk.
Are there any remaining issues left open in this task (e.g. the ChUI issues)? Greg Shah

03:29 PM User Interface Bug #2857: font differences for toggle box and menu

I've rebased the branch just now with the latest trunk revisions (11052). Current revision is 11081. Vadim Gindin

03:21 PM User Interface Bug #2857: font differences for toggle box and menu

The second run has finished and this test has passed and there are no other failed tests. Can I commit the changes? Vadim Gindin

04:53 AM User Interface Bug #2857: font differences for toggle box and menu

I'm not sure, but this one might be dependent on the DB state. Please do one more run. Constantin Asofiei

04:07 AM User Interface Bug #2857: font differences for toggle box and menu

Here is the failing screen: ... Vadim Gindin

02:49 AM User Interface Bug #2857: font differences for toggle box and menu

Regression testing is finished. After single check the only one test remained failed: tc_item_master_007. Is it a kno... Vadim Gindin

04:16 PM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

It is not possible to make a static call from a TRPL ruleset. Today, we either:
1. Hide the call in a worker (e.g... Greg Shah

04:09 PM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Could you recall, how to make a static call that will prepare the label and return a string? In other words there is ... Vadim Gindin

12:26 PM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

> Will it be correct to call this class (from ui.client.gui package) from conversion process?
We normally don't li... Greg Shah

12:06 PM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Oh, really. You're right. Thanks. Another question. We have @com.goldencode.p2j.ui.client.gui.MnemonicInfoGuiImpl@ cl... Vadim Gindin

11:27 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

@ui_strings.txt@ is only used in GUI (to obtain the variable length of each string based on a list of fonts). ChUI i... Greg Shah

11:04 AM User Interface Bug #2952: ui_strings.txt is empty for simple_sm.p

Is there a way to know what the current environment is (CHUI, GUI) during conversion? Vadim Gindin

11:23 AM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...

This picture displays the IE11 web client with ClearType turned off.
!ComboBoxTest_IE11_ClearTypeTurnedOff_4_times_z... Sergey Ivanovskiy

11:04 AM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...

Disabling AppleFontSmoothing... Sergey Ivanovskiy

10:30 AM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...

Anti-aliasing or font smoothing for Mac OS X El Capitan, this command @defaults -currentHost write -globalDomain Appl... Sergey Ivanovskiy

10:18 AM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...

This picture displays the Safari web client with fonts anti-aliasing
!ComboBox_Safari_Antialiasing_Enabled_4_times_zo... Sergey Ivanovskiy

07:42 AM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...

> Yes, agree. To solve this anti-aliasing effect for the Firefox we can try note 93.
Understood. It is a good ide... Greg Shah

07:39 AM User Interface Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...

Although the results are not what we hoped for, the details meet the objectives of note 84.
The last thing to do, ... Greg Shah

09:20 AM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat

Branch 1735d was rebased from trunk 11051. The latest revision is now 11058 (it includes some revisions with changes... Greg Shah

07:44 AM Base Language Bug #2489 (Closed): FileSystemOps.searchPath(String) should return the 4GL procedure name for ext...

Greg Shah

04:07 AM Base Language Bug #2489: FileSystemOps.searchPath(String) should return the 4GL procedure name for external pro...

The task branch 2489a was merged to trunk as revision 11051. The changes in @magic_baseline@ were also committed.
Th... Ovidiu Maxiniuc