Project

General

Profile

Activity

From 07/18/2016 to 08/16/2016

08/16/2016

06:45 PM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
> but their look and feels are different.
OK, please fix this.
Also, please post what the P2J result is for bot...
Greg Shah
05:25 PM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
Committed revision 11081 added comments and a history entry. Sergey Ivanovskiy
05:22 PM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
This testcase ... Sergey Ivanovskiy
04:32 PM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
After some emails to discuss the test results, runtime testing is deemed to have passed.
The code in 3136a needs ...
Greg Shah
03:08 PM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
Also, please don't post MAJIC-specific details in this task which is visible to all customers. Greg Shah
03:07 PM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
These CTRL-C 3-way failures commonly happen on devsrv01. Ignore them. Greg Shah
03:05 PM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
The first part, "Ctrl-C" test suite, is that... Sergey Ivanovskiy
02:32 PM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
Thank you, I don't notice it at the first run. Sergey Ivanovskiy
02:04 PM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
Did you read the "Interpreting the Results" section of that document? Greg Shah
01:49 PM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
I tried to come through these tests @run_regression.sh runtime-regression -Dmajic-built=true@ for 3136a branch, but t... Sergey Ivanovskiy
09:53 AM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
> Found this one <variable name="frameShr" init="'Shared'" />.
This is something that can be used in @frame_scopi...
Greg Shah
09:42 AM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
Found this one <variable name="frameShr" init="'Shared'" />. Sergey Ivanovskiy
09:40 AM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
No, I only looked at the java converted file. These code changes don't distinguish these cases. Is there some attribu... Sergey Ivanovskiy
09:22 AM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
> Don't know the changes are bad or good (correct)?
Did you look at @util/labadj.p.cache@?
It has these referen...
Greg Shah
06:08 AM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
Sergey Ivanovskiy wrote:
> Planning to test MAJIC conversion against the committed revision 11080(3136a).
Regressio...
Sergey Ivanovskiy
03:16 PM Database Bug #1914: database conversion requires Internet connectivity
Fine by me.
I was only concerned about this when it seemed it was a runtime issue too. Conversion can require inte...
Paul E
01:50 PM Database Bug #1914: database conversion requires Internet connectivity
My last conversion of the customer's server project was done offline. There were no errors. I don't think this is a p... Eric Faulhaber
01:22 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Vadim Gindin wrote:
> > > I don't understand. "pressed" state transf...
Vadim Gindin
12:50 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > I don't understand. "pressed" state transferring makes sense only for...
Vadim Gindin
12:28 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> I don't understand. "pressed" state transferring makes sense only for MENUBAR..
To make sur...
Hynek Cihlar
11:51 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > I've committed changes (WindowGuiImpl, SwingMouseHandler). Please rev...
Vadim Gindin
07:45 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> I've committed changes (WindowGuiImpl, SwingMouseHandler). Please review. It works, I'm not su...
Hynek Cihlar
04:10 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > But we must also track clicks outside of the P2J window, that also mu...
Vadim Gindin

08/15/2016

04:33 PM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
Planning to test MAJIC conversion against the committed revision 11080(3136a).... Sergey Ivanovskiy
03:02 PM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
Created a task branch, 3136a. I am trying to find some hints from the original commit.... Sergey Ivanovskiy
01:37 PM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
I don't know for sure. I suspect that it may have been some "safety" code that was put in there because at some poin... Greg Shah
01:19 PM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
Greg, Hynek, do you know why the scope node is removed if the referred frame has no widgets. The source rule is annot... Sergey Ivanovskiy
11:35 AM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
> XML Rules --XSLT--> Java/Kotlin/Scala ---> Debug.
:)
Our plan (to be implemented sometime next year) is to im...
Greg Shah
10:36 AM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
Greg Shah wrote:
> I manually wrote that as documentation. There is no tool or setting to generate that.
XML Rul...
Hynek Cihlar
10:24 AM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
I manually wrote that as documentation. There is no tool or setting to generate that. Greg Shah
10:12 AM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
Thank you, now I can proceed independently. This part of @com/goldencode/p2j/pattern/package.html@... Sergey Ivanovskiy
10:08 AM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
> now I am using simply @<action>printfln("DEBUG: get_named_frame %s, cnt = %s, scope= %s", name, cnt, scope)</action... Greg Shah
10:05 AM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
> It would be helpful to log all applied and processed rules for this small program like it was described by @com/gol... Greg Shah
09:59 AM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
It would be helpful to log all applied and processed rules for this small program like it was described by @com/golde... Sergey Ivanovskiy
09:53 AM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
Greg Shah wrote:
> The problem is that the @VIEW frame@ is not being treated properly in @annotations/frame_scoping....
Sergey Ivanovskiy
09:49 AM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
The problem is that the @VIEW frame@ is not being treated properly in @annotations/frame_scoping.rules@ where we crea... Greg Shah
01:38 AM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
But these AST's are generated finally by CB phase, these nodes have been added ... Sergey Ivanovskiy
01:19 AM User Interface Bug #3136: Unhandled exception after VIEW frame, due to frame widget not registered on the client
If one of these commented lines is used, then the conversion driver generates @openScope()@ for the target frame and ... Sergey Ivanovskiy
02:10 PM Build and Source Control Feature #2699: convert the ant build environment to gradle
As noted above, moving to a modern build environment seems an opportune time to move our dependencies out of version ... Greg Shah
01:45 PM Build and Source Control Feature #2699: convert the ant build environment to gradle
> Kotlin on top of Gradle could be a way to simplify the build scripts, I believe.
I'm OK with this approach, so l...
Greg Shah
11:32 AM Build and Source Control Feature #2699: convert the ant build environment to gradle
Hynek Cihlar wrote:
> Kotlin on top of Gradle could be a way to simplify the build scripts, I believe.
Some links...
Hynek Cihlar
11:00 AM Build and Source Control Feature #2699: convert the ant build environment to gradle
Greg Shah wrote:
> A useful comment from Hynek:
>
> > I used Gradle on one small project. From the short experien...
Hynek Cihlar
10:35 AM Build and Source Control Feature #2699: convert the ant build environment to gradle
A useful comment from Hynek:
> I used Gradle on one small project. From the short experience my only objection was...
Greg Shah
09:44 AM User Interface Feature #2959: Implement search by key in browse
> should I implement SORT-ASCENDING and SORT-NUMBER attributes for displaying sorting direction and sort-level number... Greg Shah
07:49 AM User Interface Feature #2959: Implement search by key in browse
Greg, should I implement SORT-ASCENDING and SORT-NUMBER attributes for displaying sorting direction and sort-level nu... Stanislav Lomany
07:23 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> But we must also track clicks outside of the P2J window, that also must lead to flag reset.
...
Hynek Cihlar
07:10 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > or when focus is moved to a widget not belonging to the menu.
>
> ...
Vadim Gindin
03:26 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> or when focus is moved to a widget not belonging to the menu.
This is a bit tricky. I think...
Hynek Cihlar
03:09 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> # The first one is the scenario, described in the note 117. The mouse pointer is moved from bo...
Hynek Cihlar
12:55 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > P.S.
> > There are also posting FOCUS_GAINED and events in mouseExit...
Vadim Gindin

08/12/2016

01:23 PM Build and Source Control Feature #2699: convert the ant build environment to gradle
The following article has a nice summary of the comparison between ant, maven and gradle.
http://www.drdobbs.com/j...
Greg Shah
01:22 PM Build and Source Control Bug #2746 (Closed): fix javadoc issues as reported by the Oracle JDK
Eugenie solved these issues as of revision 10974 in the trunk. Greg Shah
10:00 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> P.S.
> There are also posting FOCUS_GAINED and events in mouseExited methods, so I can't full...
Hynek Cihlar
09:32 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > Hynek Cihlar wrote:
> > > Vadim Gindin wrote:
> > > > #In mouseEnte...
Vadim Gindin
07:33 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Vadim Gindin wrote:
> > > #In mouseEntered we don't know the widget ...
Hynek Cihlar
06:57 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > #In mouseEntered we don't know the widget we came from. It is also ca...
Vadim Gindin
06:30 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> #In mouseEntered we don't know the widget we came from. It is also cannot be solved using focu...
Hynek Cihlar
06:15 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
#In mouseEntered we don't know the widget we came from. It is also cannot be solved using focusing, because not all w... Vadim Gindin
06:06 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Vadim Gindin wrote:
> > Greg Shah wrote:
> > > Vadim Gindin wrote:
> > > > The only one bug...
Hynek Cihlar
05:50 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Greg Shah wrote:
> > Vadim Gindin wrote:
> > > The only one bug is remained: transferring "p...
Vadim Gindin

08/11/2016

06:02 PM User Interface Bug #3163: 4GL quirk: browse becomes unusable when an incompatible query is assigned
In 4GL functionality that allows to assign another browsed query with other buffers doesn't work for dynamic browses ... Stanislav Lomany
09:54 AM User Interface Bug #3167: The modal windows appearence issues in the case of the virtual desktop has two device ...
The virtual desktop's screen is formed by two rectangles with a common side and the primary device screen resolution ... Sergey Ivanovskiy
09:46 AM User Interface Bug #3167 (New): The modal windows appearence issues in the case of the virtual desktop has two d...
Sergey Ivanovskiy
08:26 AM User Interface Bug #3136 (WIP): Unhandled exception after VIEW frame, due to frame widget not registered on the ...
Hynek will provide guidance as needed. Greg Shah
11:45 PM Database Feature #3011 (Rejected): try H2 internal connection pool instead of UnpooledConnectionProvider
Tried this. It went very badly. We need to maintain the existing mechanism of holding open connections for as long as... Eric Faulhaber
10:00 PM Database Bug #1914: database conversion requires Internet connectivity
The server startup issue was addressed per notes 9-10, so I'm changing the subject back to reflect that this is only ... Eric Faulhaber

08/10/2016

03:12 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> Vadim Gindin wrote:
> > The only one bug is remained: transferring "pressed" state to neighbour ...
Vadim Gindin
10:21 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> The only one bug is remained: transferring "pressed" state to neighbour in the menubar.
Can...
Greg Shah
01:31 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
The only one bug is remained: transferring "pressed" state to neighbour in the menubar. Vadim Gindin

08/09/2016

12:10 PM Base Language Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers
Ovidiu Maxiniuc wrote:
> The strangest is the fact that uninitialized memptrs sent as parameters are at the same tim...
Constantin Asofiei
11:03 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Please document your findings and the plan to resolve the issues. This needs to be closed soon. Greg Shah
09:20 AM Base Language Feature #3164: missing undoable behaviour with global vars and persistent procedures
The remaining issue I was investigating as part of 3109c, regarding shared/extent vars and their undo support, is str... Constantin Asofiei
08:52 AM Base Language Feature #3164 (New): missing undoable behaviour with global vars and persistent procedures
Constantin Asofiei
04:53 AM User Interface Bug #3163: 4GL quirk: browse becomes unusable when an incompatible query is assigned
In 4GL you can re-assign a query which has different kind of DMO classes or even different number of buffers. In most... Stanislav Lomany
04:46 AM User Interface Bug #3163 (New): 4GL quirk: browse becomes unusable when an incompatible query is assigned
Stanislav Lomany

08/05/2016

12:05 PM Runtime Infrastructure Support #3162: JVM crash in native code called from FileStream
As can be seen from the hotspot log, the failure is again coming from @FileStream@ usage of J2SE features and the act... Greg Shah
11:58 AM Runtime Infrastructure Support #3162: JVM crash in native code called from FileStream
Today Constantin reported this:
-------- Forwarded Message --------
Subject: Re: Test questions
Date: Fri, 5 A...
Greg Shah
11:54 AM Runtime Infrastructure Support #3162: JVM crash in native code called from FileStream
In June 2015, a client's automated test suite was encountering appserver agent JVM crashes in native code when called... Greg Shah
08:18 AM Runtime Infrastructure Support #3162 (New): JVM crash in native code called from FileStream
Greg Shah
09:00 AM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat
Please update the testcases repo. I just added @uast/dynamic-queries/p2488-a.p@. It contains 3 cases of queries that ... Ovidiu Maxiniuc
07:39 AM User Interface Bug #2365: ThinClient.trigger() and ThinClient.validate() must send the screen-buffer for all fra...
3051d was merged to trunk as rev 11077. Greg Shah

08/04/2016

06:35 PM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat
Ovidiu:
In 1735e revision 11076, I am currently reworking all use of @WhereExpression@ to replace it with a lambda...
Greg Shah

08/03/2016

03:05 PM User Interface Feature #2894 (Closed): Implement browse multiple selection with Shift and Ctrl keys
Greg Shah
02:25 PM User Interface Feature #2894 (Review): Implement browse multiple selection with Shift and Ctrl keys
Task branch 2894a merged to trunk as revision 11075. Stanislav Lomany
12:52 PM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Go ahead. Greg Shah
11:47 AM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Regression testing passed. Should I commit? Stanislav Lomany

08/02/2016

02:04 PM User Interface Feature #2959: Implement search by key in browse
The app definitely does set @ALLOW-COLUMN-SEARCHING = TRUE@ in multiple places.
I don't see any string literals th...
Greg Shah
11:07 AM User Interface Feature #2959 (WIP): Implement search by key in browse
There are two mechanics about "column searching":
_1. Search mechanics._
Pressing a printable character causes s...
Stanislav Lomany

08/01/2016

12:47 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
> I've probably found a reason: accelerators work only if menus are closed. Strange..
Interesting.
OK, please i...
Greg Shah
12:41 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
I've probably found a reason: accelerators work only if menus are closed. Strange.. Vadim Gindin
12:13 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> > As I can see, accelerators stopped working at all.. Did the customer update OpenEdge last time?...
Vadim Gindin
12:10 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
> As I can see, accelerators stopped working at all.. Did the customer update OpenEdge last time?
No, I don't thi...
Greg Shah
12:02 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> > I have to neighbour sub-menus:
> > [...]
> > Now I've found that 'U' works for menu-item "UUU...
Vadim Gindin
09:58 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
> I have to neighbour sub-menus:
> [...]
> Now I've found that 'U' works for menu-item "UUUUU" and don't work for "...
Greg Shah
09:17 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Eric Faulhaber wrote:
> Vadim Gindin wrote:
> > There was a conflict: dmo_index.xml from p2j.jar didn't contain _te...
Vadim Gindin
12:14 PM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Yes, that adds even more safety. I'll regression test for the case. Stanislav Lomany
10:16 AM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Code Review Task Branch 2894a Revision 11079
Generally the changes look good. My only question:
In @BrowseGuiI...
Greg Shah

07/31/2016

09:19 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> There was a conflict: dmo_index.xml from p2j.jar didn't contain _temp schema description, but ...
Eric Faulhaber
03:59 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Eric Faulhaber wrote:
> > Greg Shah wrote:
> > > Eric: Can you please review the issue in no...
Vadim Gindin
03:24 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> > I don't understand... I'm testing @simple_sm.p@ on windev01 and faced that for menubar sub-menu...
Vadim Gindin
02:31 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Eric Faulhaber wrote:
> Greg Shah wrote:
> > Eric: Can you please review the issue in notes 90 through 92 and tell ...
Vadim Gindin
08:19 AM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Please review task branch 2894a revision 11079. Stanislav Lomany
08:03 AM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Task brank 2894a rebased to trunk revision 11074. Stanislav Lomany

07/29/2016

11:39 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> Eric: Can you please review the issue in notes 90 through 92 and tell us if you have any ideas?
...
Eric Faulhaber
11:16 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
> I don't understand... I'm testing @simple_sm.p@ on windev01 and faced that for menubar sub-menus "SM2 Submenu" and ... Greg Shah
11:13 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Eric: Can you please review the issue in notes 90 through 92 and tell us if you have any ideas? Greg Shah
11:10 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Your environment seems to be broken. I don't think it is worth trying to diagnose it.
Just remove everything insi...
Greg Shah
09:33 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Check the client logs; I get this:
> > [...]
> >
> > Did yo...
Vadim Gindin
09:30 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > I couldn't reproduce the @NullPointerException@.
> >
> > > I've fa...
Vadim Gindin
09:03 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> I couldn't reproduce the @NullPointerException@.
>
> > I've faced with NullPointerException...
Hynek Cihlar
08:10 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
I couldn't reproduce the @NullPointerException@.
> I've faced with NullPointerException at some moment but I could...
Vadim Gindin
09:42 AM User Interface Bug #2365 (Closed): ThinClient.trigger() and ThinClient.validate() must send the screen-buffer fo...
The issues described in this task are completely resolved by the changes in task branch 3051d revision 11086. Those ... Greg Shah

07/28/2016

03:55 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
I don't understand... I'm testing @simple_sm.p@ on windev01 and faced that for menubar sub-menus "SM2 Submenu" and "S... Vadim Gindin
03:19 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> > Probably some misconfiguration.
>
> Yes. Your testcases directory.xml probably doesn't have...
Vadim Gindin
10:46 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
> Probably some misconfiguration.
Yes. Your testcases directory.xml probably doesn't have the _temp database acti...
Greg Shah
10:30 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Check the client logs; I get this:
> > [...]
> >
> > Did yo...
Vadim Gindin
08:30 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Constantin Asofiei wrote:
> Check the client logs; I get this:
> [...]
>
> Did you build P2J manually? This shou...
Vadim Gindin
08:24 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Check the client logs; I get this:... Constantin Asofiei
08:22 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> Delete all your previously converted code. Then convert all testcases that need to be converted,...
Vadim Gindin

07/27/2016

01:03 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Delete all your previously converted code. Then convert all testcases that need to be converted, in one batch. You ... Greg Shah
12:09 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
I got compile error when building converted code for the test @browse/gui/brws-hscoll-col1.p@:... Vadim Gindin
09:12 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Vadim Gindin wrote:
> > Hynek Cihlar wrote:
> > > Vadim Gindin wrote:
> > > > I've faced wi...
Hynek Cihlar
09:08 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Vadim Gindin wrote:
> > > I've faced with conversion error during co...
Vadim Gindin
08:58 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > I've faced with conversion error during conversion standalone GUI tes...
Vadim Gindin
08:08 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> I've faced with conversion error during conversion standalone GUI tests:
> !conversion_err.t...
Hynek Cihlar
07:50 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
I've faced with conversion error during conversion standalone GUI tests:
!conversion_err.txt!
Is it known bug?
Vadim Gindin
04:57 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Greg Shah wrote:
> > Code Review Task Branch 2966a Revision 11086
> >
> > It looks good.
...
Hynek Cihlar
01:11 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> Code Review Task Branch 2966a Revision 11086
>
> It looks good.
>
> Please test it:
>
> ...
Vadim Gindin
01:29 AM User Interface Bug #3157: Menu layout bugs for CHUI
Fix Menu layout bugs from #2557 task. See notes: 1, 14-18, 20 (also PUT SCREEN case) Vadim Gindin
01:21 AM User Interface Bug #3157 (New): Menu layout bugs for CHUI
Vadim Gindin
01:29 AM User Interface Bug #2557: Fix MENUBAR layouting in a window
Greg Shah wrote:
> > May be I should add these bugs to that task?
>
> No. Please create a separate task and link...
Vadim Gindin

07/26/2016

06:32 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Code Review Task Branch 2966a Revision 11086
It looks good.
Please test it:
1. Using MAJIC runtime regressio...
Greg Shah
01:02 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Done. Current branch revision is 11086 (rebased and containing code cleanup).
Vadim Gindin
12:12 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Code Review Task Branch 2966a Revision 11084
The changes look good. Some minor things:
1. Please rebase.
2....
Greg Shah
09:24 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
I've fixed mousePressed bug. Current revision is 11084. I'm switching to other task. Hynek, thank's for help! Vadim Gindin
06:20 PM User Interface Bug #2557: Fix MENUBAR layouting in a window
> May be I should add these bugs to that task?
No. Please create a separate task and link to it here as a related...
Greg Shah
12:43 PM User Interface Bug #2557: Fix MENUBAR layouting in a window
Greg Shah wrote:
> Vadim: did you ever create another task for the remaining ChUI items from this task?
It seems ...
Vadim Gindin
12:20 PM User Interface Bug #2557: Fix MENUBAR layouting in a window
Vadim: did you ever create another task for the remaining ChUI items from this task? Greg Shah
12:15 PM User Interface Bug #2910 (Closed): artifacts (traces) of closed pop-up menu and menubar is stayed in the workspace
Greg Shah
12:01 PM User Interface Bug #2910: artifacts (traces) of closed pop-up menu and menubar is stayed in the workspace
This bug is also not recreated after menus refactoring. Trunk contain 2 other bugs: @NullPointerException@ during nav... Vadim Gindin
11:39 AM Database Feature #3145 (Closed): implement _File._Template metadata support
Eric Faulhaber
11:33 AM Database Feature #3145: implement _File._Template metadata support
The task branch was merged to trunk as revision 11074.
The test results and branch were archived and notification wa...
Ovidiu Maxiniuc
10:54 AM Database Feature #3145: implement _File._Template metadata support
Great! Please merge to trunk. Eric Faulhaber
10:43 AM Database Feature #3145: implement _File._Template metadata support
The revision 11082 has passed all test (devsrv01 and ETF). The only issue was gso231 because my test framework was no... Ovidiu Maxiniuc
11:02 AM User Interface Bug #2911 (Closed): Fix extra background shown for popup_ext.p
Greg Shah
10:35 AM User Interface Bug #2911: Fix extra background shown for popup_ext.p
This bug is not recreated for trunk revision 11073 (after menus refactoring). Vadim Gindin
06:05 AM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Browse scrolling was implemented at the time when there was no ability to click between the thumb and a scrollbar but... Stanislav Lomany

07/25/2016

04:55 PM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Awesome! I see it too. Stanislav Lomany
04:52 PM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
I can reproduce it. It needs to move the thumb button down and then click on the scroll bar between the upper scroll ... Sergey Ivanovskiy
04:47 PM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
I can't reproduce it now. It seems that it is not a regular exception. Sergey Ivanovskiy
04:44 PM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Thank you! Ctrl and Shift events work properly. I'll look into @ArrayIndexOutOfBoundsException@. Stanislav Lomany
04:42 PM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Modified: Checked @./browse/gui/browse-gui-stat1.p@ against the Web client (2894a) and encountered this exception cli... Sergey Ivanovskiy
04:26 PM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Stanislav, please apply and review this diff. @patch -p0 < modifiers_diff.txt@ Sergey Ivanovskiy
03:11 PM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Stanislav Lomany wrote:
> It doesn't work in web client.
>
> Sergey, can you update @MouseEvent.modifiers@ when C...
Sergey Ivanovskiy
02:44 PM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
It doesn't work in web client.
Sergey, can you update @MouseEvent.modifiers@ when Ctrl or Shift is held? My experi...
Stanislav Lomany
04:34 PM Database Feature #3145: implement _File._Template metadata support
Ovidiu Maxiniuc wrote:
> The reason for this method is not to synchronize access to internal but rather to check if ...
Eric Faulhaber
03:51 PM Database Feature #3145: implement _File._Template metadata support
Eric Faulhaber wrote:
> Code review 3145a/11081:
Thanks for the review. I will do the required changes. I am in the...
Ovidiu Maxiniuc
03:26 PM Database Feature #3145: implement _File._Template metadata support
Code review 3145a/11081:
@HQLHelper.isFindTemplate@ should be package private and be moved to the appropriate loca...
Eric Faulhaber
03:18 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Should I commit the your changes and debugging code?
No, no need to. Actually you can remov...
Hynek Cihlar
02:54 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Should I commit the your changes and debugging code? Vadim Gindin
01:23 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > Hynek Cihlar wrote:
> > >
> > > So it doesn't solve it for the sub...
Hynek Cihlar
01:22 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> >
> > So it doesn't solve it for the sub-menu issue you posted in the...
Hynek Cihlar
01:12 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
>
> So it doesn't solve it for the sub-menu issue you posted in the gif?
The last change *s...
Vadim Gindin
01:07 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Vadim Gindin wrote:
> > > Here it is !err_moveToTop.log!
> >
> > ...
Hynek Cihlar
01:00 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > Here it is !err_moveToTop.log!
>
> Please apply the attached diff ...
Vadim Gindin
12:38 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Here it is !err_moveToTop.log!
Please apply the attached diff and retest.
Hynek Cihlar
12:12 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Here it is !err_moveToTop.log! Vadim Gindin
12:05 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Vadim Gindin wrote:
> > > I've made a gif and error log with time st...
Hynek Cihlar
08:02 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > I've made a gif and error log with time stamp added to debugging info...
Vadim Gindin
07:39 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> I've made a gif and error log with time stamp added to debugging information. Have a look
D...
Hynek Cihlar
06:13 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
I've made a gif and error log with time stamp added to debugging information. Have a look Vadim Gindin
01:20 PM User Interface Bug #3156: Frame is replaced in the target window incorrectly.
The issue appeared in the 3139 task.
#3139-101
#3139-102
https://proj.goldencode.com/redmine/attachments/5187/fra...
Sergey Ivanovskiy
01:18 PM User Interface Bug #3156: Frame is replaced in the target window incorrectly.
This test case explores the frame placement issue. The frame "f1" is placed in the target window incorrectly. If it i... Sergey Ivanovskiy
01:14 PM User Interface Bug #3156 (New): Frame is replaced in the target window incorrectly.
Sergey Ivanovskiy

07/24/2016

08:53 AM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Code Review Task Branch 2894a Revision 11073
The changes are fine.
Did you test this on both the web client and...
Greg Shah

07/22/2016

04:23 PM Database Feature #3145: implement _File._Template metadata support
Copy/pasted from mail conversation. Please read in timestamp (reverse) order:
# To check meta support, I will add ...
Ovidiu Maxiniuc
12:16 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Why all @WindowActivated@ events have the same id=-1?
This is fine, @WA@ doesn't use the @i...
Hynek Cihlar
12:15 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Here it is.
> !2966_output.txt!
I don't find anything wrong with this output actually. Wou...
Hynek Cihlar
11:44 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Here it is.
!2966_output.txt!
Vadim Gindin
11:03 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Please post your standard output (just after the problem appears and with my changes). Hynek Cihlar
10:40 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
I was seing the error each time. I've applied your change but id didn't helped: I still see the error each time. Vadim Gindin
09:52 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
I was able to replicate the problem you describe (sub-menu A is hidden when its child sub-menu is closed due to mouse... Hynek Cihlar
09:42 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Why all @WindowActivated@ events have the same id=-1?
Hynek, have you try to debug?
Need advice how to debug it..
Vadim Gindin
08:53 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
It's hard to debug it because when window focus is switched to debugger - that triggers menus closing in itself. Vadim Gindin
08:43 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
It looks that error happen because of @SubMenuGuiImpl.hideBodies(parent(), null)@ call in @MenuItemGuiImpl.onFocusGai... Vadim Gindin
12:10 PM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Please review task branch 2894a revision 11073. Stanislav Lomany
09:22 AM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Created task branch 2894a from trunk revision 11072. Stanislav Lomany
06:21 AM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Never mind, ctrl and shift modifiers can be found in @MouseEvent@.
The functionality is:
* On @ctrl+click@: add/r...
Stanislav Lomany
05:16 AM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Don't we just need to know if these modifier keys are on at the time the mouse is clicked on a row? I imagine there ... Greg Shah
05:01 AM User Interface Feature #2894: Implement browse multiple selection with Shift and Ctrl keys
Stanislav Lomany wrote:
> Guys, as far as I get we don't have a way to figure out if a key is held down (or released...
Hynek Cihlar
10:54 AM Bug #3002 (Closed): static code analysis issues
We expect future efforts to run static code analysis and review the results. Whomever does that should encode the re... Greg Shah

07/21/2016

05:35 PM User Interface Feature #2894 (WIP): Implement browse multiple selection with Shift and Ctrl keys
Guys, as far as I get we don't have a way to figure out if a key is held down (or released)? Stanislav Lomany
01:58 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
I've committed my changes with debugging information and rebased the branch. Now current revision is 11081. I recall,... Vadim Gindin
12:39 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Vadim Gindin wrote:
> > > I need some help.
> > >
> > > The probl...
Hynek Cihlar
12:09 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > I need some help.
> >
> > The problem is the following. I have 2 n...
Vadim Gindin
01:22 PM Base Language Bug #2657 (Closed): appserver agent context reset does not deallocate currently allocated memptr ...
Greg Shah
12:38 PM Database Feature #3145: implement _File._Template metadata support
Ovidiu Maxiniuc wrote:
> I tried to isolate only the simple queries that expressly seek the template record. These q...
Eric Faulhaber
12:28 PM Database Feature #3145: implement _File._Template metadata support
Eric Faulhaber wrote:
>
> The changes to @PreselectQuery@ I think need some attention, but not at this time. Note ...
Ovidiu Maxiniuc
09:16 AM Database Feature #3145: implement _File._Template metadata support
Code review 3145a/11077:
Sorry I didn't get to this yesterday. From my understanding of the template record featur...
Eric Faulhaber

07/20/2016

04:27 PM Database Feature #3145: implement _File._Template metadata support
I implemented support for loading template records in simple @PreselectQuery@. The trick was to intercept the templat... Ovidiu Maxiniuc
11:08 AM User Interface Bug #3142 (Closed): the mouse "hotspot" in the web client is in an unexpected location
The fix for this issue is the same fix for #2893. That change went into the trunk with revision 11072. Greg Shah
10:58 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Yes. Parent sub-menu should be activated when child sub-menu is closed (deactivated), so I wan...
Hynek Cihlar
10:21 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > Hynek Cihlar wrote:
> > > Vadim Gindin wrote:
> > > > How to determ...
Vadim Gindin
10:03 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Vadim Gindin wrote:
> > > How to determine ParentSm there?
> >
> ...
Hynek Cihlar
08:33 PM User Interface Bug #2893 (Closed): Mouse clicks on rows are not 100% accurate
Greg Shah

07/19/2016

07:37 PM User Interface Bug #2893 (Review): Mouse clicks on rows are not 100% accurate
Stanislav Lomany
07:24 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate
2893a was merged into the trunk as bzr revision 11072. Stanislav Lomany
06:11 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate
OK, merge it to trunk. Greg Shah
06:11 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate
I've checked testcases for widgets and menus and ran some customer GUI app scenarios. Stanislav Lomany
06:07 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate
Code Review Task Branch 2893a Revision 11073
I'm fine with the changes.
Have you done enough manual GUI testing...
Greg Shah
04:58 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate
Task branch 2893a rebased from trunk rev 11071.
I did some GUI testing. Please review.
Stanislav Lomany
01:43 PM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > How to determine ParentSm there?
>
> To get the parent sub menu us...
Vadim Gindin
08:32 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> How to determine ParentSm there?
To get the parent sub menu use the @MenuElement.getParentS...
Hynek Cihlar
07:50 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > Hynek Cihlar wrote:
> > > > ...
> > > > 3. Parent/Child SUB-MENU's ...
Vadim Gindin
07:40 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > > ...
> > > 3. Parent/Child SUB-MENU's windows are always share acti...
Hynek Cihlar
07:28 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> > ...
> > 3. Parent/Child SUB-MENU's windows are always share activation state (in sense of @...
Vadim Gindin
07:20 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Hynek, I stuck with that. Could you help me..
>
> 1. It seems @WindowManager.processWindowA...
Hynek Cihlar
03:44 AM User Interface Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek, I stuck with that. Could you help me..
1. It seems @WindowManager.processWindowActivated()@ identifies what...
Vadim Gindin
11:58 AM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat
Branch 1735e was created from P2J trunk revision 11071. Greg Shah
11:39 AM Database Feature #3145: implement _File._Template metadata support
Ovidiu Maxiniuc wrote:
> I will review the @setCurrentRecord@ and add supplementary conditionals so that the templat...
Eric Faulhaber
11:07 AM Database Feature #3145: implement _File._Template metadata support
Thanks for review, Eric!
Eric Faulhaber wrote:
> Code review 3145a/11072:
>
> Please help me understand the purp...
Ovidiu Maxiniuc
10:35 AM Database Feature #3145: implement _File._Template metadata support
Code review 3145a/11072:
Please help me understand the purpose of the @variable_references.rules@ change. Aren't w...
Eric Faulhaber

07/18/2016

04:32 PM Database Feature #3145: implement _File._Template metadata support
Eric Faulhaber wrote:
> I think we just have to accept that a FIND by RECID/ROWID is a special case. Do we behave th...
Ovidiu Maxiniuc
02:17 PM Database Feature #3145: implement _File._Template metadata support
Ovidiu Maxiniuc wrote:
> I have created the task branch 3145a. The last revision is 11072.
>
> I discovered that ...
Eric Faulhaber
02:20 PM User Interface Bug #2528: finish investigation and implemention of INPUT, SCREEN-VALUE and INPUT-VALUE
A simple version of @INPUT-VALUE@ has been implemented. It has been mapped to the getter for each widget, which is t... Greg Shah
01:53 PM User Interface Bug #2767 (Rejected): implement INPUT-VALUE attribute properly for all widget types
This is a duplicate of #2528. Greg Shah
01:27 PM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate
> In the new code the first parameter is not used. Considering that in practice this function always takes this as th... Greg Shah
11:59 AM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate
Also, should I skip regression testing because it is GUI-changes only? Stanislav Lomany
11:58 AM User Interface Bug #2893: Mouse clicks on rows are not 100% accurate
@translate@ function has two parameters:... Stanislav Lomany
 

Also available in: Atom