Activity
From 03/09/2020 to 04/07/2020
04/07/2020
- 05:19 PM Database Feature #4011: database/persistence layer performance improvements
- While working with the @hotel_gui@ and in particular with embedded client I feel that FWD is non-deterministically un...
- 04:46 PM Database Feature #3813: misc DB features part deux
- The runtime support for the @DEFAULT-STRING@ (modulo the issue with EXTENT fields (see #3813-99) is finished.
Commit... - 04:27 PM Database Feature #3813: misc DB features part deux
- Greg Shah wrote:
> Most likely, the initial value for these problem cases should be the unknown value. Please check... - 04:24 PM Database Feature #3813: misc DB features part deux
- > I've implemented preventive pre-check in the getDefaultString and do not try to vet the values for the problematic ...
- 04:01 PM Database Feature #3813: misc DB features part deux
- Greg Shah wrote:
> > Formally this issue is not related to #3813 and does not prevent tesing.
>
> We still should... - 03:59 PM Database Feature #3813: misc DB features part deux
- Greg Shah wrote:
> > I've found that current INITIAL attribute support generates exceptions for other data types (su... - 03:48 PM Database Feature #3813: misc DB features part deux
- > Formally this issue is not related to #3813 and does not prevent tesing.
We still should probably fix this now. ... - 03:37 PM Database Feature #3813: misc DB features part deux
- Greg Shah wrote:
> Igor Skornyakov wrote:
> > On the conversion of the field definition
> > [...]
> > the time pa... - 03:31 PM Database Feature #3813: misc DB features part deux
- Another issue:
The converted statement @SessionUtils.setDateFormat(new character("ydm"))@ causes runtime exception:
... - 03:30 PM Database Feature #3813: misc DB features part deux
- > I've found that current INITIAL attribute support generates exceptions for other data types (such as raw or even ch...
- 03:27 PM Database Feature #3813: misc DB features part deux
- Igor Skornyakov wrote:
> On the conversion of the field definition
> [...]
> the time part is lost.
Please show... - 03:23 PM Database Feature #3813: misc DB features part deux
- Eric Faulhaber wrote:
> I don't think that was intentional. Please add it if you need it. My advice about @getPrecis... - 03:21 PM Database Feature #3813: misc DB features part deux
- In addition to the #3813-95, I've found that current @INITIAL@ attribute support generates exceptions for other data ...
- 03:09 PM Database Feature #3813: misc DB features part deux
- On the conversion of the field definition...
- 02:56 PM Database Feature #3813: misc DB features part deux
- Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > Where @foo@ represents a DMO and @bar@ is a @decimal@ property, ... - 01:33 PM Database Feature #3813: misc DB features part deux
- @DEFAULT-STRING@ uses only decimal separator when rendering @DECIMAL@ values. The value of the group separator is not...
- 11:04 AM Database Feature #3813: misc DB features part deux
- Greg Shah wrote:
> No. A format string is not the same thing as the @DATE-FORMAT@. A format string for @date@ migh... - 10:45 AM Database Feature #3813: misc DB features part deux
- > DEFAULT-STRING renders its dates and numeric values in LOCAL format, subject to the DATE-FORMAT and NUMERIC-FORMAT ...
- 08:23 AM Database Feature #3813: misc DB features part deux
- Greg Shah wrote:
> The @date@, @datetime@, @datetime-tz@, @integer@, @int64@ and @decimal@ classes all are designed ... - 08:14 AM Database Feature #3813: misc DB features part deux
- The @date@, @datetime@, @datetime-tz@, @integer@, @int64@ and @decimal@ classes all are designed to format their stat...
- 07:51 AM Database Feature #3813: misc DB features part deux
- Greg Shah wrote:
> Igor Skornyakov wrote:
> > Do we have methods for rendering date/numeric data using @SESSION:DAT... - 07:46 AM Database Feature #3813: misc DB features part deux
- Greg Shah wrote:
> > We need to correctly distinguish between datetime literal and valid expression as NOW. The firs... - 07:39 AM Database Feature #3813: misc DB features part deux
- > We need to correctly distinguish between datetime literal and valid expression as NOW. The first question is what c...
- 07:36 AM Database Feature #3813: misc DB features part deux
- Igor Skornyakov wrote:
> Do we have methods for rendering date/numeric data using @SESSION:DATE-FORMAT@ and @SESSION... - 05:45 AM Database Feature #3813: misc DB features part deux
- Do we have methods for rendering date/numeric data using @SESSION:DATE-FORMAT@ and @SESSION:NUMERIC-FORMAT@ attribute...
- 05:39 AM Database Feature #3813: misc DB features part deux
- Eric Faulhaber wrote:
> Where @foo@ represents a DMO and @bar@ is a @decimal@ property, the following will return th... - 04:40 AM Database Feature #3813: misc DB features part deux
- The issue described in the #3813-97 was a result of the following. I've compiled two tests. The TEMP-TABLE @source-da...
- 03:35 AM Database Feature #3813: misc DB features part deux
- Eric Faulhaber wrote:
> Where @foo@ represents a DMO and @bar@ is a @decimal@ property, the following will return th... - 01:51 PM Base Language Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> FYI, I have updated @https://proj.goldencode.com/downloads/skeletons/repo@ to rev 89 earlier toda... - 01:43 PM Base Language Feature #4384: Builtin OO Implementation
- > Sounds simple enough, how do we know when we need to incorporate changes from 4231b, will someone notify us or we s...
- 01:39 PM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Marian Edu wrote:
> > Constantin Asofiei wrote:
> > > I think is related to using a skeleton c... - 12:58 PM Base Language Feature #4384: Builtin OO Implementation
- The fix is in 4231b rev 11427 on xfer. I should have added it to 4384a, sorry.
You can try the rebase now :) - 12:53 PM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Constantin Asofiei wrote:
> > I think is related to using a skeleton class. For example, at lea... - 12:42 PM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> I think is related to using a skeleton class. For example, at least the skeleton methods... - 12:40 PM Base Language Feature #4384: Builtin OO Implementation
- I think is related to using a skeleton class. For example, at least the skeleton methods are missing the @extent@ for...
- 12:39 PM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian Edu wrote:
> > > @Constantin, the code generated still do... - 12:26 PM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > @Constantin, the code generated still doesn't work for us when in... - 12:16 PM Base Language Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> In fact, you can always rebase an unbound 4384a branch from the latest 4231b on xfer and then @... - 12:15 PM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> @Constantin, the code generated still doesn't work for us when indeterminate extents are used. T... - 12:08 PM Base Language Feature #4384: Builtin OO Implementation
- > OK, we will continue to work with our local git repository and only I will push changes to bazaar to keep it simple...
- 11:49 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > There was no cast in the conversion rule and we didn't changed th... - 11:18 AM Base Language Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> Created branch 4384a, branched from 4231b revision 11425.
>
> Access it:
>
> @bzr co sftp:/... - 12:11 PM Base Language Bug #4602: fixes for OO 4GL and structured error handling
- Another case to cover: simple statements with @NO-ERROR@, like @ch = h:name NO-ERROR.@ and @input from os-dir("missin...
04/06/2020
- 07:29 PM Database Feature #3813: misc DB features part deux
- Where @foo@ represents a DMO and @bar@ is a @decimal@ property, the following will return the value of DECIMAL from t...
- 05:43 PM Database Feature #3813: misc DB features part deux
- Igor Skornyakov wrote:
> I cannot find where the value of the DECIMAL option of the field definition is located in t... - 05:38 PM Database Feature #3813: misc DB features part deux
- I cannot find where the value of the DECIMAL option of the field definition is located in the conversion artifacts.
... - 01:35 PM Database Feature #3813: misc DB features part deux
- Ovidiu Maxiniuc wrote:
> I will schedule working on this issue. 4011a is not yet stable enough, but we'll see whethe... - 01:29 PM Database Feature #3813: misc DB features part deux
- > BTW: do I understand correctly that more complicated expressions cannot be used in the @INITIAL@ clause?
TBH, befo... - 12:40 PM Database Feature #3813: misc DB features part deux
- Ovidiu Maxiniuc wrote:
> I am working on 4011a branch, where the field's attributes (including the default value) ar... - 12:29 PM Database Feature #3813: misc DB features part deux
- The following field definition...
- 12:26 PM Database Feature #3813: misc DB features part deux
- I am working on 4011a branch, where the field's attributes (including the default value) are defined as DMO interface...
- 11:40 AM Database Feature #3813: misc DB features part deux
- At the moment FWD runtime support if the INITIAL attribute for fields like @FIELD s-datetime AS DATETIME INITIAL NOW@...
- 09:57 AM Database Feature #3813: misc DB features part deux
- Greg Shah wrote:
> Doesn't the @DEFAULT-VALUE@ of the DMO map more closely to @BUFFER-FIELD:DEFAULT-VALUE@ instead o... - 09:50 AM Database Feature #3813: misc DB features part deux
- Doesn't the @DEFAULT-VALUE@ of the DMO map more closely to @BUFFER-FIELD:DEFAULT-VALUE@ instead of using the @DEFAULT...
- 09:42 AM Database Feature #3813: misc DB features part deux
- We have no support for the BUFFER-FIELD:DEFAULT-VALUE (even conversion is not supported). This can be a little bit tr...
- 04:33 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Greg Shah wrote:
> Make a list of the problems here and fix them.
>1. What do these return before the frame is real... - 03:31 PM Base Language Feature #4384: Builtin OO Implementation
- Created branch 4384a, branched from 4231b revision 11425.
Access it:
@bzr co sftp://<userid>@xfer.goldencode.co... - 07:34 AM Database Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Which revision of hotel_gui are you using with 4011a/11404?
I found r202 of hotel_gui is wh...
04/05/2020
- 06:08 PM Database Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> I have committed my latest changes to 4011a as r11404.
> The standalone hotel_gui is start... - 07:52 AM Database Feature #4011: database/persistence layer performance improvements
- I have committed my latest changes to 4011a as r11404.
The standalone hotel_gui is starting up and tabs can be navig... - 07:37 AM Database Feature #4011: database/persistence layer performance improvements
- > This is a non-orthodox workaround.
You're being kind. Let us call it what it is: an ugly solution. Unfortunate...
04/04/2020
- 06:24 PM Database Feature #4011: database/persistence layer performance improvements
- Greg, thanks for suggestion. This is a non-orthodox workaround. Here is what I've done.
I altered @NUM_LITERAL@ in l...
04/03/2020
- 06:33 PM Database Feature #3813: misc DB features part deux
- By the end of the weekend, please report the list of open items remaining in this task. We can push the #3813-81 it...
- 06:31 PM Database Feature #4011: database/persistence layer performance improvements
- Is the column name version of @order@ always "qualified" (e.g. @tt1.order@)? If so, then you can easily differentiat...
- 05:29 PM Database Feature #4011: database/persistence layer performance improvements
- In fact, @by@ does not suffer from this inconvenient as it is already a Progress reserved keyword and cannot be the n...
- 04:59 PM Database Feature #4011: database/persistence layer performance improvements
- I encountered the following issue and I see no easy trick to work around. It is a antlr issue I think. Suppose we hav...
- 01:00 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Make a list of the problems here and fix them.
- 12:33 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- I'll update, now that I (finally) understand. I do have some initial items, some not related to this testcase, but be...
- 11:19 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- I think you should check the @FRAME-ROW(frame)@ builtin for all of the same case.
Make sure to test:
* What do ... - 10:38 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Greg Shah wrote:
> > That is not really correct, because the attribute is off the widget, in this case i.
>
> Pl... - 10:16 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- > That is not really correct, because the attribute is off the widget, in this case i.
Please read #4164-1 more c... - 09:54 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Greg Shah wrote:
> All you care about is positioning the frame in different locations.
That is not really corre... - 09:34 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- I had a testcase:...
- 08:53 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- All you care about is positioning the frame in different locations. This is trivial to do in the AT phrase of the fr...
- 09:54 AM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> There was no cast in the conversion rule and we didn't changed the rules simply modified the gen... - 09:49 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian, there's a FWD conversion bug for this extent assign case. I'll fix it.
>
> W... - 09:38 AM Base Language Feature #4384: Builtin OO Implementation
- Marian, there's a FWD conversion bug for this extent assign case. I'll fix it.
What's the signature for @assignMu... - 09:25 AM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> fixes the reference but the uncheck cast is ugly to say at least :(
Changing the @assignMulti... - 09:15 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian, what's the use case for the extent problem? Can you modify it so that it uses a ...
04/02/2020
- 05:40 PM User Interface Bug #4604: DCOLOR on FRAME or BROWSE TITLE phrase results in title not being displayed
- Using @4231b-11418@:
Testcase @./uast/frame_title_color_default_values.p@ shows that @define frame@ with a title p... - 09:04 AM User Interface Bug #4604: DCOLOR on FRAME or BROWSE TITLE phrase results in title not being displayed
- Please document the testcase and the trunk revision in which this can be recreated.
- 08:22 AM Database Feature #3813: misc DB features part deux
- Contrary to what is said in the Progress documentation the @DEFAULT-STRING@ attribute is read-only. This is logical a...
04/01/2020
- 06:54 PM User Interface Bug #4604 (New): DCOLOR on FRAME or BROWSE TITLE phrase results in title not being displayed
- 01:58 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Yes, it could be a version difference. Run the testcases on both 10.x and 11.x and record the differences only. The...
- 12:22 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- I was re-running @frame_title_color_attributes.p@ to try to close this task down, and I was running on OE release 10....
- 10:53 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- h2. Browse TITLE Attribute Defaults (before/after realization)
|_. |_. ChUI (bef) |_. ChUI (aft) |_. GUI (... - 08:09 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- > Should I remove the comment: "For the browse options phrase, only the TITLE DCOLOR <num> "title" form can be used.....
- 01:13 PM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > Tried various combinations, none seems to work. Anything else we ... - 12:59 PM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Tried various combinations, none seems to work. Anything else we need to do apart from @gradle j... - 12:44 PM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> The error fixes mentioned in #4384-121 are in 4231b rev 11406 - xfer was updated.
@Co... - 12:43 PM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > OK, so the one that already exist we do not 'refactor' but we nee... - 12:01 PM Base Language Feature #4384: Builtin OO Implementation
- OK
- 11:34 AM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> OK, so the one that already exist we do not 'refactor' but we need to add them as exceptions.
... - 11:30 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> This one, and maybe others, I think were added early on, and were written 'by hand', wit... - 11:17 AM Base Language Feature #4384: Builtin OO Implementation
- > One way would be to find the p2j.oo equivalent automatically (searching for the LegacyResource annotation), and use...
- 11:11 AM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> That's exactly what we did and observed the pattern we described, problem is for instance @IHttp... - 11:09 AM Base Language Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> > Greg: for the skeleton classes, the Java equivalent is the one returned by our NameConverter ru... - 11:07 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Greg: for the skeleton classes, the Java equivalent is the one returned by our @NameConv... - 11:05 AM Base Language Feature #4384: Builtin OO Implementation
- > Greg: for the skeleton classes, the Java equivalent is the one returned by our NameConverter rules - a IWebHandler ...
- 11:02 AM Base Language Feature #4384: Builtin OO Implementation
- Greg: for the skeleton classes, the Java equivalent is the one returned by our @NameConverter@ rules - a @IWebHandler...
- 11:01 AM Base Language Feature #4384: Builtin OO Implementation
- >> Yes, but in Java we use "camel cased" names.
>
> camel case for variables, class names are still pascal case it ... - 09:57 AM Base Language Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
>
> Yes, but in Java we use "camel cased" names.
camel case for variables, class names are still... - 09:46 AM Base Language Feature #4384: Builtin OO Implementation
- > it seems the conversion translate the OE names to all lower for the package name
Yes. Except the @Progress@ and... - 08:56 AM Base Language Feature #4384: Builtin OO Implementation
- Quick question on naming convention, for interfaces it seems the conversion translate the OE names to all lower for t...
- 11:47 AM Database Feature #4011: database/persistence layer performance improvements
- Greg Shah wrote:
> > There is another issue which I have in mind: when creating a savepoint, shouldn't we also sav... - 11:36 AM Database Feature #4011: database/persistence layer performance improvements
- Greg Shah wrote:
> What happens if in the meantime between the roll-forward and the original execution of a statem... - 07:39 AM Database Feature #4011: database/persistence layer performance improvements
- > maybe, instead of trying to track NO-UNDO DMOs as POJOs, I need to track the SQL statements that were rolled back a...
- 07:21 AM Database Feature #4011: database/persistence layer performance improvements
- Eric, this FFD replay is the same though I had in mind. I don't think we can keep the database in good condition and ...
03/31/2020
- 07:00 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Made updates in Rev11413. I was attempting to get the title to appear when @DCOLOR@ was part of the title phrase. Thi...
- 05:05 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> No, looking back on things they are all possible. I didn't update the comment in @frame_generato... - 04:02 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- No, looking back on things they are all possible. I didn't update the comment in @frame_generator.xml@ but the notes...
- 03:45 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> See the @gen_color@ in @frame_generator.xml@. It should only be generating code for @TITLE DCOLO... - 03:18 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Not sure the @realized@ flag is correct.
See the @gen_color@ in @frame_generator.xml@. It should only be generati... - 03:13 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> I guess you are referencing @testcases/uast/browse_title_color_options.p@. Options are not attri... - 03:12 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> What testcase are you using? The code in @testcases/uast/browse_title_color_attributes.p@ doesn'... - 03:11 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- I guess you are referencing @testcases/uast/browse_title_color_options.p@. Options are not attributes. The text abo...
- 02:46 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- What testcase are you using? The code in @testcases/uast/browse_title_color_attributes.p@ doesn't look anything like...
- 02:16 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Another issue I am looking at. The browse title is missing, if @DCOLOR@ is part of the options:
!GUI_browse_title_... - 01:45 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> Be more specific. In which testscase and for which lines of code is this happening? GUI, ChUI? ... - 01:11 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- > I see the testcase in FWD displays 4052 in a popup for every browse widget.
Be more specific. In which testsca... - 12:42 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Done, but in my testing, I see the testcase in FWD displays 4052 in a popup for every browse widget. Either I need to...
- 12:22 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- So @setTitleColor(ColorSpec)@ was just missing. My changes fixed the conversion, but you will need to add the runtim...
- 12:14 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> What happens in trunk?... - 12:07 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- > It looks like setTitleColor needs to be implemented. I have added it to BrowseWidget and I believe the interface is...
- 11:55 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Compilation of the testcase:...
- 11:52 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Roger Borrello wrote:
> Converting the @browse_title_color_options.p@ testcase, @setTitleColor@ is unresolved. Did t... - 11:43 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Converting the @browse_title_color_options.p@ testcase, @setTitleColor@ is unresolved. Did that method ne get overloo...
- 11:31 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Code Review updates made:...
- 10:55 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> For now, I'm just suggesting that you create a helper for @BrowseWidget@, so make common code ins... - 10:14 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- For now, I'm just suggesting that you create a helper for @BrowseWidget@, so make common code instead of the duplicat...
- 10:12 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> Anytime you are writing the same code over and over, you can make a helper. It is ALWAYS better ... - 09:52 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Anytime you are writing the same code over and over, you can make a helper. It is ALWAYS better than copying the cod...
- 09:45 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> Code Review Task Branch 4231b Revision 11407
> 4. In @BrowseWidget@, you would have much less co... - 09:06 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- > Just to be sure... you want comments removed?
Yes.
> Isn't there any usefulness to tieing the keyword to the... - 09:03 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> Code Review Task Branch 4231b Revision 11407
>
> 1. In @gaps/expressions.rules@, the @kw_tit*@... - 08:39 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Code Review Task Branch 4231b Revision 11407
1. In @gaps/expressions.rules@, the @kw_tit*@ comments should be remo... - 06:25 PM Database Feature #4011: database/persistence layer performance improvements
- I've been struggling with how to fit a bulk delete (i.e., @delete from <table> [ where <condition> ]@) which operates...
- 11:00 AM User Interface Feature #4394: add some frame options and attributes
- @SCROLL@ and @NO-ATTR-SPACE@ will be finished in #4164. The only thing needed for this task is @FRAME-NAME@.
- 10:14 AM Database Feature #3813: misc DB features part deux
- Working on @BUFFER-FIELD:DEFAULT-STRING@ and @BUFFER-DECIMALS@ attributes support.
- 03:16 AM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> But didn't you mentioned c'tors are already treated differently in FWD? Not sure if we have that... - 02:45 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> The error fixes mentioned in #4384-121 are in 4231b rev 11406 - xfer was updated.
OK,... - 02:41 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> I have FWD fixes for cases of 'nested' calls (for ctors, methods, internal procedures, d... - 02:31 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian, what's the use case for the extent problem? Can you modify it so that it uses a ...
03/30/2020
- 04:14 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Committed updates:...
- 03:59 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Roger Borrello wrote:
> Currently looking at why the @./uast/menu/menu_title_color_attributes.p@ testcase fails in *... - 03:21 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Currently looking at why the @./uast/menu/menu_title_color_attributes.p@ testcase fails in *Core Code Conversion*:
<... - 02:17 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Same issues occur with @trunk@. I'll focus on implementation, but these will prevent validation of the implementation...
- 02:10 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> What do you mean by "build"? It parsed fine.
When I tried to convert the @./uast/browse_title... - 02:04 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- What do you mean by "build"? It parsed fine.
- 02:03 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Suddenly that implementation seems secondary to an issue that came up when I tried to build @./uast/browse_title_colo...
- 02:00 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- The frame definitions will use @setTitle*(long)@. It is possible for the attribute usage to convert this way too, un...
- 01:51 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Doesn't the @int64@ interface to the converted 4GL? Perhaps that's what is confusing me. Is there a @long@ interface ...
- 12:52 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- No.
> Just reverse the logic. The long version calls the wrapper version.
This means that @setTitleFgColor(... - 12:25 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- I see the missing "new" in there.
- 12:20 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> You did not reverse the logic.
Like this?... - 11:37 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- You did not reverse the logic.
- 11:23 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> Just reverse the logic. The @long@ version calls the wrapper version.
Can you review this imp... - 11:19 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Just reverse the logic. The @long@ version calls the wrapper version.
- 10:49 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- The previous convention for the setters had the @int64@ versions calling the @long@ versions:...
- 10:24 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- > For the cases where menu TITLE- attributes are actually handled (TITLE-BGCOLOR, TITLE-FGCOLOR and TITLE-FONT), but ...
- 10:07 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- For the cases where @menu TITLE-@ attributes are actually handled (TITLE-BGCOLOR, TITLE-FGCOLOR and TITLE-FONT), but ...
- 09:20 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Yes.
- 09:20 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- In @MenuWidget@, is it adequate to utilize @config.popupOnly@ to determine between popup and non-popup menus for the ...
- 03:51 PM Database Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> OTOH, in case of the TEMP-TABLEs, there is the case when two independent tables are defin... - 11:38 AM Database Feature #4011: database/persistence layer performance improvements
- My concerns on different @extent@ fields were related to @shared@ tables. However, re-reading #2942 notes I see that ...
- 09:53 AM Database Feature #4011: database/persistence layer performance improvements
- I really like your proposal as well. It seems "more correct" and it reads better.
In regard to the question "whic... - 09:47 AM Database Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Ovidiu, I like the chaining approach. This is an approach I have adopted with other new APIs... - 09:42 AM Database Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> I think your solution can limit the legacy annotations to only schema-related informatio... - 02:39 PM Base Language Bug #4602: fixes for OO 4GL and structured error handling
- From #4384-121:
> I have FWD fixes for cases of 'nested' calls (for ctors, methods, internal procedures, dynamic f... - 02:32 PM Base Language Bug #4602 (Review): fixes for OO 4GL and structured error handling
- 02:31 PM Base Language Feature #4384: Builtin OO Implementation
- Marian, what's the use case for the extent problem? Can you modify it so that it uses a fixed extent? Or to execute ...
- 02:02 PM Base Language Feature #4384: Builtin OO Implementation
- > From these, I think only the last two may need explicit fixing - as it looks like the ERROR can be 'eaten' by a par...
- 01:08 PM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> We have an issue with the 'extent' variables here, we get at NPE on @ArrayAssigner.registerDynam... - 12:55 PM Base Language Feature #4384: Builtin OO Implementation
- I have FWD fixes for cases of 'nested' calls (for ctors, methods, internal procedures, dynamic functions), which cove...
- 04:51 AM Base Language Feature #4384: Builtin OO Implementation
- We have an issue with the 'extent' variables here, we get at NPE on @ArrayAssigner.registerDynamicArray@ because as t...
03/28/2020
- 04:54 PM Database Feature #4011: database/persistence layer performance improvements
- Ovidiu, I like the chaining approach. This is an approach I have adopted with other new APIs which have lots of possi...
- 09:57 AM Database Feature #4011: database/persistence layer performance improvements
- Ovidiu, your idea of setting these non-schema settings for a temp-table at the program where it is defined is interes...
- 12:17 PM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > Maybe this is the issue, we're using an @internalProcedure@ block...
03/27/2020
- 07:44 PM Database Feature #4011: database/persistence layer performance improvements
- We are talking about two different types of 'attributes' of the temp-tables:
* structural (actual data structure, m... - 01:59 PM Database Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> If we were generating different DMO types for differences in certain [temp-]table attributes... - 01:34 PM Database Feature #4011: database/persistence layer performance improvements
- I'm pretty sure we were never generating more than one DMO implementation class per DMO interface. These were designe...
- 01:30 PM Database Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> Constantin, you are right, one of the @xml-node-name@ s will be lost in this case.
This wa... - 01:22 PM Database Feature #4011: database/persistence layer performance improvements
- Constantin, you are right, one of the @xml-node-name@ s will be lost in this case.
However, this is a bug (I can say... - 01:06 PM Database Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric/Ovidiu: maybe you've already considered, but please keep... - 01:01 PM Database Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Eric/Ovidiu: maybe you've already considered, but please keep in mind also the 'resource... - 11:47 AM Database Feature #4011: database/persistence layer performance improvements
- Eric/Ovidiu: maybe you've already considered, but please keep in mind also the 'resource' behavior for temp-tables (w...
- 11:23 AM Database Feature #4011: database/persistence layer performance improvements
- Less is more. I see no reason a customer would want the same structure duplicated just to get the affect of setting ...
- 11:20 AM Database Feature #4011: database/persistence layer performance improvements
- Greg Shah wrote:
> > I suppose an alternative is to include NO-UNDO among the criteria which differentiates DMO inte... - 11:12 AM Database Feature #4011: database/persistence layer performance improvements
- > I suppose an alternative is to include NO-UNDO among the criteria which differentiates DMO interfaces during conver...
- 10:55 AM Database Feature #4011: database/persistence layer performance improvements
- So, what I understand from your comment is that the NO-UNDO state is a property of the table the record belongs to (i...
- 10:40 AM Database Feature #4011: database/persistence layer performance improvements
- How can we test that? The only way is to use @buffer-copy@, but this will copy field by field, not the whole record.
... - 10:30 AM Database Feature #4011: database/persistence layer performance improvements
- I guess the better question is whether it is possible for the same data record to be used by such temp-tables (i.e., ...
- 09:09 AM Database Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Ovidiu, if two temp-tables are defined identically, except that one is declared NO-UNDO and ... - 04:28 AM Database Feature #4011: database/persistence layer performance improvements
- Ovidiu, if two temp-tables are defined identically, except that one is declared NO-UNDO and the other is not, do we g...
- 06:53 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Cleaned up and checked in:...
- 05:48 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- > All the ChUI tests passed side-by-side, except for the fact that the color schemes seemed different. There were oft...
- 05:44 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Remove all getters. Remove the @int64@ setters. Only the @long@ setters should be in either @CommonFrame@ or @Gener...
- 05:43 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Roger Borrello wrote:
> Greg Shah wrote:
>
> > We need the @setTitle*(long)@ methods in @CommonFrame@. That is i... - 05:42 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> We need the @setTitle*(long)@ methods in @CommonFrame@. That is it. Don't add the full @Title... - 05:22 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- I will go back and update per your last note. I was writing the below while you made your update:
All the ChUI tes... - 05:19 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- > Menus and Browse don't have the same complexity of the class structure, do they?
No, they don't.
> All the fr... - 04:39 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Roger Borrello wrote:
> The frames are CommonFrame, and trying to access the methods which aren't in that interface.... - 03:57 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- The frames are CommonFrame, and trying to access the methods which aren't in that interface....
- 03:45 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Roger Borrello wrote:
> Updates for frames in *4231b-11400*.
Hold on... a couple more frame testcases to validate... - 03:41 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Updates for frames in *4231b-11400*.
- 03:26 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> Try @frame df:title-dcolor = 1@ instead of @3@ on line 208 of @testcases/uast/frame_title_color_a... - 03:22 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Try @frame df:title-dcolor = 1@ instead of @3@ on line 208 of @testcases/uast/frame_title_color_attributes.p@. You s...
- 03:11 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- My previous note was stating the "current" state, so thank you for clarifying.
With respect to the ChUI testing, I... - 02:17 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- > TitiledElement - leave alone
Yes
> CommonFrame - currently an inteface that extends TitledElement. No getters... - 01:51 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> Yes, I'm thinking that we leave the frame options in @CommonFrame@/@GenericFrame@. These are jus... - 09:56 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Yes, I'm thinking that we leave the frame options in @CommonFrame@/@GenericFrame@. These are just the setters (@setT...
- 09:52 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> > Or, do you mean to convert frame f1:<widget/method> differently, and access the asWidget() meth... - 09:48 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- > Or, do you mean to convert frame f1:<widget/method> differently, and access the asWidget() method directly?
Yes,... - 09:46 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> I was thinking about the dual nature, but I guess I got part of it backwards. If not present in ... - 09:39 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- I was thinking about the dual nature, but I guess I got part of it backwards. If not present in @widget_references.r...
- 09:25 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> Roger: If I'm right, then you would remove all the changes from @FrameWidget@ and just put them i... - 09:12 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Roger: If I'm right, then you would remove all the changes from @FrameWidget@ and just put them in @GenericFrame@.
- 09:12 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Code Review Task Branch 4231b Revision 11399
OK, you are close here.
Looking deeper at the changes in @widget_r... - 11:15 AM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Maybe this is the issue, we're using an @internalProcedure@ block for constructors so it should ... - 10:00 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> A @RETUNR ERROR "foo"@ sets the @RETURN-VALUE@ in some cases. And if there is no @BLOCK... - 09:35 AM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> - there is no real difference between return error, return error new AppError (I think this stat... - 09:26 AM Base Language Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> OK, that is fair. We need to handle all cases with compatibility before implementing any optimiz... - 09:14 AM Base Language Feature #4384: Builtin OO Implementation
- OK, that is fair. We need to handle all cases with compatibility before implementing any optimizations.
- 09:03 AM Base Language Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> In regard to 4231b rev 11398, do we need to loop through the enclosing blocks in @BlockManager.pr... - 08:54 AM Base Language Feature #4384: Builtin OO Implementation
- In regard to 4231b rev 11398, do we need to loop through the enclosing blocks in @BlockManager.processLegacyError()@ ...
- 07:19 AM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Marian Edu wrote:
> > Will try to change the test to see if that is still the case, right now t... - 05:45 AM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Will try to change the test to see if that is still the case, right now the errors are not being... - 05:33 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
...
03/26/2020
- 07:34 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Roger Borrello wrote:
> Right now, the error message is being displayed, but the client is cycling in a loop, and no... - 07:06 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Look at the Hotel ChUI @p2j.cfg.xml@ for clues. You can also add things to that project to test, though the regular ...
- 06:43 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- For the ChUI, what is the key to building it as-if using ChUI development, so that @"{&window-system}" ...
- 05:08 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- I have the @frame_title_color_attributes.p@ testcase working on GUI. There are some differences, between FWD and 4GL,...
- 04:48 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Correct.
- 04:34 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- In @common-progress.rules:read_only_attribute@ is included @prog.kw_titl_bgc@. I am going to remove this, since we ca...
- 03:52 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Nevermind. Found the sources to our @readOnlyError@.
- 03:43 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> Figure out why the @getTitleFont()@ is converting differently than @getTitleBgColor()@. The font... - 02:59 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Figure out why the @getTitleFont()@ is converting differently than @getTitleBgColor()@. The font is not converting t...
- 02:57 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- No, I don't think so.
- 02:56 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> Why would we want it to be @extends@?
I don't want to do that. I believe I need to add our get... - 02:38 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Why would we want it to be @extends@?
- 02:23 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> Did you add it to @FrameWidget@?
ahh... @TitledElement@ is in there as @implements@, but not @... - 02:21 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Did you add it to @FrameWidget@?
- 02:16 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> Remove it from @CommonFrame@.
When @extends TitledElement@ is removed from @CommonFrame@, the ... - 01:47 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> Feel free to fix your bugs.
LOL... nowhere did I add a 4052 warning... I'll find and fix, whoeve... - 01:06 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Remove it from @CommonFrame@.
> Proceeding with the testcase, with all getters/setters in both GenericFrame and Fr... - 12:46 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> @GenericFrame@ should not implement @TitledElement@, only implement in @FrameWidget@. You can st... - 12:04 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- @GenericFrame@ should not implement @TitledElement@, only implement in @FrameWidget@. You can still leave the setter...
- 11:23 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> > Where are the frame-options methods?
>
> That is the @setTitleColor(ColorSpec)@ (which you k... - 11:11 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- > Where are the frame-options methods?
That is the @setTitleColor(ColorSpec)@ (which you keep complaining about) w... - 11:01 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> I forgot that we emit attributes using the @FrameWidget@ instead of direct access to the @Generic... - 10:48 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- I forgot that we emit attributes using the @FrameWidget@ instead of direct access to the @GenericFrame@ instance. Th...
- 10:38 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Using this to ef with @titleDColor@:...
- 09:05 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- > In setTitleColor(ColorSpec titleColor) on line 6860? That wasn't me... I mentioned how odd that method looked. Did ...
- 08:55 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> Code Review Task Branch 4231b Revision 11395
>
> The changes are moving the right direction.
... - 07:29 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Code Review Task Branch 4231b Revision 11395
The changes are moving the right direction.
1. You've messed with ... - 06:53 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- > Does this mean titleDColor is stored outside GenericFrame?
Yes.
As I said in #4393-20:
> Thus, only @conf... - 09:45 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Updates are buildable in revision 11395. Right now @GenericFrame@ is the only update without stubs. Please review... ...
- 09:34 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- The documentation for Attributes:Frames for writing/assignment says...
_in ChUI:_
_before realization, all ... - 05:21 PM Database Feature #4011: database/persistence layer performance improvements
- If the directory has a flag to force everything to be treated as @NO-UNDO@, then I don't see the need for a conversio...
- 05:04 PM Database Feature #4011: database/persistence layer performance improvements
- Greg Shah wrote:
> > The only value I see is that of pointing out which temp-tables are NOT marked NO-UNDO in the 4G... - 04:29 PM Database Feature #4011: database/persistence layer performance improvements
- > The only value I see is that of pointing out which temp-tables are NOT marked NO-UNDO in the 4GL code, which might ...
- 04:04 PM Database Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Greg Shah wrote:
>
> > He mentioned that he believes his team never knowingly uses UNDOab... - 03:43 PM Database Feature #4011: database/persistence layer performance improvements
- Eric,
IIRC, the @UndoStateProvider@ is used for two reasons:
* to allow the @undo@ property to be lazily set (in s... - 03:10 PM Database Feature #4011: database/persistence layer performance improvements
- Ovidiu, I am implementing the forced NO-UNDO override idea Greg mentioned above, and I have come across @UndoStatePro...
- 03:02 PM Base Language Feature #4384: Builtin OO Implementation
- Eugenie Lyzenko wrote:
> I do not need to restart conversion for this change, right?
Reconversion is not needed.
- 02:54 PM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
... - 02:43 PM Base Language Feature #4384: Builtin OO Implementation
- I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
The reason: I was processi... - 01:55 PM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Creating an empty @hosts.txt@ file in working folder solved the issue though so we're all good n... - 01:06 PM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> While writing this thought to regenerate the code for the tests and try again, it now seems the ... - 12:35 PM Base Language Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@.
Did eventually made a pu... - 10:17 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Branch 4231b revision 11395 includes @GenericFrame@ changes that complete @next-tab-item@ and @prev-tab-item@ per #41...
03/25/2020
- 03:42 PM User Interface Bug #4589: menu case sensitivity and conversion
- > The current changes were checked with testcases/uast/menu tests that passed except 4 known cases:
Roger is worki... - 03:33 PM User Interface Bug #4589: menu case sensitivity and conversion
- The current changes were checked with @testcases/uast/menu@ tests that passed except 4 known cases:...
- 03:21 PM User Interface Bug #4589: menu case sensitivity and conversion
- If everything is working so far and there are no regressions, then I am OK with it.
- 02:32 PM User Interface Bug #4589: menu case sensitivity and conversion
- Greg, I compared the previous version and the current changes and found that this map used @submenu = names.convert(...
- 10:36 AM User Interface Bug #4589: menu case sensitivity and conversion
- Code Review Task Branch 4231b Revision 11387
It seems wrong to use the javaname (even a lowercased one) as a key t... - 08:13 AM User Interface Bug #4589: menu case sensitivity and conversion
- Greg Shah wrote:
> This is not a problem with menu conversion. The skeletons should never be converted. They are s... - 08:13 AM User Interface Bug #4589: menu case sensitivity and conversion
- Hynek Cihlar wrote:
> Sergey, I think I stepped on another error during <large_app> conversion caused by the menu ch... - 08:04 AM User Interface Bug #4589: menu case sensitivity and conversion
- This is not a problem with menu conversion. The skeletons should never be converted. They are supposed to be exclud...
- 07:53 AM User Interface Bug #4589: menu case sensitivity and conversion
- Sergey, I think I stepped on another error during <large_app> conversion caused by the menu changes....
- 03:20 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Consider the following facts:
* The reason we store state in a separate config class (e.g. @BaseConfig@) is to hav... - 02:41 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Are @titleBGgColor@ and @titleFgColor@ attributes to be kept with @titleDColor@ and @titleFont@ in @BaseConfig@?
- 01:45 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- > Yes I did, but in that method, it is setting frame.config.titleDColor instead of frame.config.titleColor.
There ... - 01:34 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> Did you see this part in #4393-6:
>
> > @GenericFrame@: Add @getTitleDColor()@, @setTitleDColo... - 12:59 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Did you see this part in #4393-6:
> @GenericFrame@: Add @getTitleDColor()@, @setTitleDColor(int64 dcolor)@, @setTi... - 12:52 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- @GenericFrame@ had a method that looks a little broken:...
- 11:45 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Just implement what is in @TitledElement@. The @ColorSpec@ stuff is not related.
- 11:44 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Should there be setters for *FG*, *BG*, and *D* which receive @(ColorSpec color)@? Or just @int64@ and @long@?
- 11:21 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Greg Shah wrote:
> It is recommended anytime you are:
>
> * implementing a method from an interface (which you ar... - 11:17 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- It is recommended anytime you are:
* implementing a method from an interface (which you are doing, right?) OR
* o... - 10:58 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- I'm in @BrowseWidget@ and I see some methods with @@Override@ annotation, and some without. What determines wheth...
- 09:49 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Just re-enable the warnings suppression.
03/24/2020
- 05:48 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Is the below caused by commented out @options { generateAmbigWarnings = false; }@ ? Was that just for debug?...
- 05:06 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
- Attached are my incomplete changes for this task. The intention is to *finish the implementation of all the options ...
- 03:47 PM Base Language Feature #4384: Builtin OO Implementation
- @bzr send@ would maintain the revision history. An alternative is to zip up only your changed files and send those. ...
- 03:44 PM Base Language Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@.
Thanks Greg, quick quest... - 03:28 PM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> is the issue with error throwing from two or more level deep method call fixed already?
Yes, ev... - 03:24 PM Base Language Feature #4384: Builtin OO Implementation
- I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@.
- 03:23 PM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian, the changes are in 4231b rev 11389
>
> Some parts were a little tricky to fix... - 03:19 PM Base Language Feature #4384: Builtin OO Implementation
- Marian, the changes are in 4231b rev 11389
Some parts were a little tricky to fix... sorry it took so long. If yo... - 04:09 AM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> So, should we change Assert as it should using internalProcedure block and loadClass with static... - 02:57 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > Let me know if you have questions or need more test cases for thi... - 07:18 AM User Interface Bug #4589: menu case sensitivity and conversion
- Sergey Ivanovskiy wrote:
> The AST of menu item in the assignment expression #4589-41 missed @<annotation datatype="... - 06:07 AM User Interface Bug #4589: menu case sensitivity and conversion
- The AST of menu item in the assignment expression #4589-41 missed @<annotation datatype="java.lang.String" key="in_wi...
- 05:37 AM User Interface Bug #4589: menu case sensitivity and conversion
- This code...
- 05:12 AM User Interface Bug #4589: menu case sensitivity and conversion
- The code is still needed to fix ACCELERATOR assignments for menu. I added new test case @test-accelerator-1.p@ into @...
03/23/2020
- 06:29 PM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Let me know if you have questions or need more test cases for this one.
Thanks Marian, I still ... - 03:58 PM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > I don't understand this part - do you have an explicit te... - 09:30 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> I don't understand this part - do you have an explicit test?
I see it now... a two or m... - 08:51 AM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> All assert methods in there are static, some use internalProcedure blocks but others don't and s... - 08:17 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Can you isolate this in a simple example? Or point me to an existing test?
>
Since... - 06:12 AM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Say one methodA needs to call another methodB with some default parameters, the parameters sent ... - 04:32 AM Base Language Feature #4384: Builtin OO Implementation
- We somehow still have some issues with the error handling there.
Say one methodA needs to call another methodB wit... - 03:01 PM Database Feature #4011: database/persistence layer performance improvements
- Greg Shah wrote:
> He mentioned that he believes his team never knowingly uses UNDOable temp-tables. In other wor... - 02:58 PM Database Feature #4011: database/persistence layer performance improvements
- Greg Shah wrote:
> [...]
> This would mean that the rollback for temp-tables would actually commit when this flag i... - 02:25 PM Database Feature #4011: database/persistence layer performance improvements
- I have fixed the issue in entry 157, please disregard it.
The problem was in annotations' path: in the paths were in... - 01:40 PM Database Feature #4011: database/persistence layer performance improvements
- I've was discussing (with a customer) the UNDO/transaction and sub-transaction rework that is happening in this task....
- 12:52 PM Database Feature #4011: database/persistence layer performance improvements
- While working on dynamic temp-tables I encountered the following issue: the @AsmClassLoader@ loads the dynamically ge...
- 10:06 AM User Interface Bug #4598: define shared menu statement is converted using new name to reference the shared menu
- This issue can be reproduced with @./menu/shared_new.p@ and @./menu/shared_use.p@ from the old @testcases/uast@ proje...
- 09:54 AM User Interface Bug #4598 (New): define shared menu statement is converted using new name to reference the shared...
- 09:03 AM User Interface Bug #4589: menu case sensitivity and conversion
- As long as the regression in the other customer's application is also fixed, then any remaining issues can be moved i...
- 08:53 AM User Interface Bug #4589: menu case sensitivity and conversion
- I saw the Redmine entries about the regression, and I am grateful you found a better solution. The customer code stil...
- 07:51 AM User Interface Bug #4589: menu case sensitivity and conversion
- Roger Borrello wrote:
> I converted/compiled the customer code with your @4589_6.patch@ updates. Excellent! Did you ... - 05:19 AM User Interface Bug #4589: menu case sensitivity and conversion
- Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > where @SharedUseMmMenu.class@ should be @SharedNewMmMenu.class@.... - 03:55 AM User Interface Bug #4589: menu case sensitivity and conversion
- Sergey Ivanovskiy wrote:
> where @SharedUseMmMenu.class@ should be @SharedNewMmMenu.class@. @SharedUseMmMenu.java@ i...
03/20/2020
- 05:17 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Please read the 4GL docs to see what the @FRAME-COL@ function is meant to do. It is the counterpart of @FRAME-ROW@ a...
- 11:10 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- This test is promising:
!frame_loc_attributes_get.png!
Code below. What else can I do to validate?... - 09:01 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Stanislav Lomany wrote:
> Review rev 11377: Roger, you forgot to remove the array need for @eventDrawingBracket@. Yo... - 04:32 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Review rev 11377: Roger, you forgot to remove the array need for @eventDrawingBracket@. You can just write @return br...
- 03:50 PM User Interface Bug #4589: menu case sensitivity and conversion
- I converted/compiled the customer code with your @4589_6.patch@ updates. Excellent! Did you remove all your debug @pr...
- 03:30 PM User Interface Bug #4589: menu case sensitivity and conversion
- Roger Borrello wrote:
> Are you getting a conversion error or runtime?
This is the menu generation issue for shared... - 03:21 PM User Interface Bug #4589: menu case sensitivity and conversion
- Committed revision 11381 (4231b) fixed case-insensitive issue for menu identifiers but the shared menu and labels iss...
- 03:01 PM User Interface Bug #4589: menu case sensitivity and conversion
- Are you getting a conversion error or runtime?
I've made a change to the @shared_new.p@ to make is easier to run o... - 02:09 PM User Interface Bug #4589: menu case sensitivity and conversion
- This diff @4589_6.patch@ fixed these tests (see #4589-28)...
- 01:44 PM User Interface Bug #4589: menu case sensitivity and conversion
- I encountered a strange annotation generated for menu item...
- 11:10 AM User Interface Bug #4589: menu case sensitivity and conversion
- These files...
- 09:20 AM User Interface Bug #4589: menu case sensitivity and conversion
- It seems like you are getting close. Keep up the good work. If you need a hand on anything, please post.
- 07:01 AM User Interface Bug #4589: menu case sensitivity and conversion
- The following 3 types of exceptions were encountered with the last attached diff.
These tests... - 01:57 AM User Interface Bug #4589: menu case sensitivity and conversion
- Roger, the last changes fixed your test case but these changes to use low case identifier are not correct. There is a...
03/19/2020
- 07:13 PM Database Feature #4011: database/persistence layer performance improvements
- Greg, never mind.
This seems to have something to do with my registration mechanism. It works with other test case... - 06:55 PM Database Feature #4011: database/persistence layer performance improvements
- Greg, could you please double-check the @entry@ hook logic for this test case?...
- 03:51 PM Database Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> The actual cause of NPW was the fact that the @activeOffset@ was accessed for the @snapshot... - 03:26 PM Database Feature #4011: database/persistence layer performance improvements
- The actual cause of NPW was the fact that the @activeOffset@ was accessed for the @snapshot@ of the @dmo@ of the @Rec...
- 02:33 PM Database Feature #4011: database/persistence layer performance improvements
- Ovidiu, those places we are seeing the NPE on @BaseRecord.activeBuffer@ seem to be old code where we are calling a se...
- 06:16 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Updated per suggestions. Thanks!...
- 05:27 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- I don't see any value in @BrowseWidget.getBrowseCacheSize()@ when @getNumEntries()@ can call @LogicalTerminal.getBrow...
- 05:22 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- > * @ClientExports: public int getBrowseCacheSize(int browseId);@
> * @BrowseWidget: private int getBrowseCacheSize(... - 05:04 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Stanislav Lomany wrote:
> Consider you have a browse:
>
> [...]
>
> DOWN is 5, cache size is 2.
Thanks.
... - 03:32 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Consider you have a browse:...
- 03:28 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Greg Shah wrote:
> Yes, except you will only have the @browseId@ parameter and you must return an @int@.
What's t... - 02:33 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Yes, except you will only have the @browseId@ parameter and you must return an @int@.
- 02:24 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Stanislav Lomany wrote:
> > Do we already have an API for this? If not, do we store this value on the client?
>
... - 09:33 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- As Stanislav noted above, FWD returning 11 is a BUG. So you don't need to analyze how 11 relates to anything.
> 4... - 09:16 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- FWD returning 11 leads me to believe there are still 11 rows in the view. Evidence is the slider on the scrollbar has...
- 08:39 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Read the comments in @browse_num_entries.p@ and look carefully at the current FWD implementation/comments. Make sure...
- 05:38 PM User Interface Bug #4589: menu case sensitivity and conversion
- Sergey Ivanovskiy wrote:
> It is interesting what tests from @testcases/uast/menu/@ should be passed with the trunc... - 04:03 PM User Interface Bug #4589: menu case sensitivity and conversion
- It is interesting what tests from @testcases/uast/menu/@ should be passed with the trunc version now. I found that m...
- 09:22 AM User Interface Bug #4589: menu case sensitivity and conversion
* 4GL names are always case-insensitive. Java names are always case-sensitive. So we must handle this at conver...- 09:02 AM User Interface Bug #4589: menu case sensitivity and conversion
- Yes, I have similar questions.
I have only this way to collect all @"javaname"@ annotations created for menus, sub... - 08:54 AM User Interface Bug #4589: menu case sensitivity and conversion
- Sergey Ivanovskiy wrote:
> I am investigating logs from my changes in @rules/annotations/menu_scoping.rules@ because... - 05:25 AM User Interface Bug #4589: menu case sensitivity and conversion
- I am investigating logs from my changes in @rules/annotations/menu_scoping.rules@ because the rules are not clear for...
- 03:04 AM User Interface Bug #4589: menu case sensitivity and conversion
- It seems that the sub menu name from its definition should be here, but the converted name can use lower and upper ca...
- 09:27 AM Base Language Feature #4384: Builtin OO Implementation
- FYI, the named enum instances will be @final static@ and will have no mutable state. I agree that we don't need @Con...
- 03:05 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > ... what does ContextLocal does?
> In FWD, all clients are on th...
03/18/2020
- 07:01 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- > What is @NUM-ENTRIES@ attribute hold? Is it the number of entries left?
It is the number of data rows in the vie... - 06:51 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Greg Shah wrote:
> Stanislav Lomany wrote:
> > > Stanislav: Please review.
> >
> > The approach in @getNumEntrie... - 05:12 PM User Interface Bug #4589: menu case sensitivity and conversion
- I updated the testcase to get the new failure:...
- 04:46 PM User Interface Bug #4589: menu case sensitivity and conversion
- I don't think it fixes the issue. The Javaname is now lowercase, but not found. Shouldn't it be a converted name?
... - 04:06 PM User Interface Bug #4589: menu case sensitivity and conversion
- Is this a complete fix for all known issues seen in this task?
- 03:58 PM User Interface Bug #4589: menu case sensitivity and conversion
- Sergey Ivanovskiy wrote:
> Thank you. Please use this patch. It seems that it fixed @menu-item@ according to my test... - 03:41 PM User Interface Bug #4589: menu case sensitivity and conversion
- Thank you. Please use this patch. It seems that it fixed @menu-item@ according to my test.
- 03:39 PM User Interface Bug #4589: menu case sensitivity and conversion
- Sergey Ivanovskiy wrote:
> Roger, I tested this diff with 4231b patched. It couldn't convert @menu-item quititem:SEN... - 03:21 PM User Interface Bug #4589: menu case sensitivity and conversion
- Roger, I tested this diff with 4231b patched. It couldn't convert @menu-item quititem:SENSITIVE = false.@ properly bu...
- 11:49 AM User Interface Bug #4589: menu case sensitivity and conversion
- Sergey Ivanovskiy wrote:
> I think that frame scoping is not connected with this issue because this example 4GL GUI ... - 11:41 AM User Interface Bug #4589: menu case sensitivity and conversion
- I cannot think of ANY names in the 4GL that are case-sensitive. Our conversion needs to treat all menu, sub-menu and...
- 11:31 AM User Interface Bug #4589: menu case sensitivity and conversion
- I think that frame scoping is not connected with this issue because this example 4GL GUI works similarly on the nativ...
- 11:27 AM User Interface Bug #4589: menu case sensitivity and conversion
- There isn't a @frame@ scoping the menu in the new case. That is what the customer's code is doing, so we need to unde...
- 11:23 AM User Interface Bug #4589: menu case sensitivity and conversion
- According to this 4GL UI test:...
- 10:39 AM User Interface Bug #4589: menu case sensitivity and conversion
- Thank you, I see it now.
- 10:16 AM User Interface Bug #4589: menu case sensitivity and conversion
- If you change @thissubmenu:SENSITIVE@ to @ThisSUBMENU:SENSITIVE@ it will generate the correct results.
- 10:13 AM User Interface Bug #4589: menu case sensitivity and conversion
- Compiling of @testcases/uast/submenu_case-sensitive.p@ with 4231b (rev 11376) failed...
- 10:07 AM User Interface Bug #4589 (Closed): menu case sensitivity and conversion
- 04:30 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
- > Help me understand what you see as the advantage of separating things.
I think you're right that it is a single ... - 09:24 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
- I assume that the layout parameters for use in both the screen/display and the reports.
Why do we want to keep thi... - 02:34 PM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> ... what does ContextLocal does?
In FWD, all clients are on the same Java process. And the Jav... - 08:44 AM Base Language Feature #4384: Builtin OO Implementation
- FYI, my work on enums (#4349) is in process. I will have generic conversion and runtime support for enums when I am ...
- 07:45 AM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Constantin, while the conversion now seems to work we again don't see the client window status b... - 07:24 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian, how did you define the static members? This needs to be something like this:
> ... - 07:18 AM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Constantin Asofiei wrote:
> > There's something weird - the code you posted in the stacktrace s... - 07:15 AM Base Language Feature #4384: Builtin OO Implementation
- Marian, how did you define the static members? This needs to be something like this:...
- 05:49 AM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Constantin Asofiei wrote:
> > There's something weird - the code you posted in the stacktrace s... - 04:28 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> There's something weird - the code you posted in the stacktrace should never execute dur... - 03:58 AM Base Language Feature #4384: Builtin OO Implementation
- There's something weird - the code you posted in the stacktrace should never execute during conversion. Did you add ...
- 03:35 AM Base Language Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> @xfer.goldencode.com:/opt/fwd/4231b@ is now available. FYI, @xfer.goldencode.com:/opt/fwd/4335a@...
03/17/2020
- 05:42 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
- All kinds of colors and fonts, column width, order and visibility, row height.
- 05:39 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
- What are examples of "layout parameters"?
- 05:29 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
- Greg, I have some conceptual questions about report-related enhanced parameters. Enhanced parameters can be divided i...
- 03:44 PM User Interface Feature #2683: reverse proxy implementation
- > > It is used only to generate mapping on the fly for new connected broker client.
>
> Is it used for anything ex... - 03:31 PM User Interface Feature #2683: reverse proxy implementation
- > It is used only to generate mapping on the fly for new connected broker client.
Is it used for anything external... - 03:22 PM User Interface Feature #2683: reverse proxy implementation
- I rechecked if Jetty implements the reverse proxy support for wss connections and found that https://webtide.com/http...
- 02:29 PM User Interface Feature #2683: reverse proxy implementation
- This hosts file is related only to the network configuration. It is used only to generate mapping on the fly for new ...
- 01:45 PM User Interface Feature #2683: reverse proxy implementation
- > Should I change it to use the directory?
Is there any advantage to leaving it as a separate file? - 01:02 PM User Interface Feature #2683: reverse proxy implementation
- Committed revision 11374 (4231b) fixed 1), 2), 4) and 5). The hosts file is used for mapping unique pairs of host and...
- 08:37 AM User Interface Feature #2683: reverse proxy implementation
- Code Review Task Branch 4231b Revision 11372
Overall, it is a nicer implementation to have the @HostsManager@.
... - 07:51 AM User Interface Feature #2683: reverse proxy implementation
- Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > Yes, it looks like the old issue documented in @WebClientP... - 11:43 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
- It seems the changes in 4231b Revision 11372 are good.
- 11:11 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
- Code Review Task Branch 4231b Revision 11372
The changes seem good to me.
Sergey: Any objections? - 10:54 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
- Committed fix in 4231b/rev. 11373. The changes were minimal - only the space-bar generates additional released events.
- 06:11 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
- After checking the @GUIKeyboardReader@, I see there is the following code which triggers that additional @keyups@:
<... - 05:16 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
- Now I see that this behavior can't be reproduced on Chrome. Maybe it is a bug in Firefox regarding long key presses?
- 05:10 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
- Greg Shah wrote:
> I don't want to send a large number of additional events up to Java if we only need a very small ... - 11:39 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
- The custom format is implemented exactly according to this documentations https://docs.oracle.com/javase/tutorial/i18...
- 11:16 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
- I think the @VALUE-CHANGED@ event and the custom beginning day of week will be needed.
> but the custom format the... - 10:46 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
- Working to improve the documentation of calendar. The current version of @Calendar@ can convert @DateTimeValue@ value...
- 09:29 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
- I see that there is a good start on the documentation. Thank you!
I sent the link to some customers for review. ... - 06:25 AM Base Language Feature #4384: Builtin OO Implementation
- > None of those files in conflict were changed by us locally so I would say I can just pick the 'other' version and r...
- 06:23 AM Base Language Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> I assume that you have not changed the files in the merge conflict list?
>
> The new 4231b bra... - 06:20 AM Base Language Feature #4384: Builtin OO Implementation
- I assume that you have not changed the files in the merge conflict list?
The new 4231b branch is a "superset" of 4... - 06:04 AM Base Language Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> @xfer.goldencode.com:/opt/fwd/4231b@ is now available. FYI, @xfer.goldencode.com:/opt/fwd/4335a@...
03/16/2020
- 06:33 PM Database Feature #4011: database/persistence layer performance improvements
- In 4011a revision 11402, I have added @Finalizable.entry()@ which is called during @TransactionManager.blockSetup()@ ...
- 07:11 AM Database Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Greg, how hard would it be to add a hook for the savepoint processing which is called at the... - 04:14 AM Database Feature #4011: database/persistence layer performance improvements
- Greg, how hard would it be to add a hook for the savepoint processing which is called at the same point in the cycle ...
- 12:17 AM Database Feature #4011: database/persistence layer performance improvements
- Ovidiu, I need a few more days to work through the UNDO code. Some of the features I expected to see (e.g., the track...
- 01:15 PM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
- >> Even though the KEY_RELEASED event is not a progress event, it should be generated in order to properly reproduce ...
- 12:29 PM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
- Adrian Lungu wrote:
> Yet, I am not sure how the key events are handled in the web driver. But from this slim invest... - 12:12 PM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
- It seems that @keyup@ browser's event means that a key is released. Is it correct to change this part of the js web c...
- 10:39 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
- Adrian Lungu wrote:
> I recently found a bug related to the issue here - regarding the web interface. The web driver... - 10:32 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
- Whatever solution is created, please minimize the number of events forwarded to the FWD client (Java side). Optimall...
- 10:21 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
- I recently found a bug related to the issue here - regarding the web interface. The web driver doesn't emit release e...
- 01:14 PM Database Feature #3813: misc DB features part deux
- A fixed @CONNECT@ statement rework was committed to the branch 4231b revision 11368.
- 04:04 AM Database Feature #3813: misc DB features part deux
- Greg Shah wrote:
> If it does not depend on 4335a, you can put it in 4231b. If 4335a is needed first, then wait for... - 08:35 AM Base Language Feature #4384: Builtin OO Implementation
- @xfer.goldencode.com:/opt/fwd/4231b@ is now available. FYI, @xfer.goldencode.com:/opt/fwd/4335a@ has been removed.
- 07:24 AM Base Language Feature #4384: Builtin OO Implementation
- > Can we try to modify other classes - like longchar or CopyLob ( of course - only if we can do it ) ?
Yes, please... - 06:19 AM Base Language Feature #4384: Builtin OO Implementation
- The email patches are in 4231b ref 11364
* Fixed an issue with method call's argument annotation in case of chained ... - 04:59 AM Base Language Feature #4384: Builtin OO Implementation
- When testing ByteBucket methods we have found that is need for improvement in other classes who is used by ByteBucket...
03/15/2020
- 06:07 PM Database Feature #3813: misc DB features part deux
- If it does not depend on 4335a, you can put it in 4231b. If 4335a is needed first, then wait for the 4231b rebase fr...
03/14/2020
- 01:42 PM Database Feature #3813: misc DB features part deux
- I've found the fix for the CONNECT conversion (see #3813-84).
To which branch should I commit it?
Thank you. - 06:38 AM Database Feature #3813: misc DB features part deux
- Igor Skornyakov wrote:
> It seems that the CONNECT statement which caused the @gso_241@ fail is incorrect.
> I've ...
03/13/2020
- 06:57 PM Database Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Thinking over some of the issues you've been having, I expect the implicit transaction code ... - 06:52 PM Database Feature #4011: database/persistence layer performance improvements
- I am checking out 4011a2 now...
Thinking over some of the issues you've been having, I expect the implicit transac... - 06:46 PM Database Feature #4011: database/persistence layer performance improvements
- I have committed my changes to temporary branch 4011a2. Important things:
* @SavepointReversible@ - dead code;
* @C... - 05:54 PM Database Feature #3813: misc DB features part deux
- It seems that the CONNECT statement which caused the @gso_241@ fail is incorrect.
I've added logging and the argume... - 03:45 PM Database Feature #3813: misc DB features part deux
- Task branch 4335a was merged to trunk as revision 11345.
The @ConnectionManager@ change was removed before it was ... - 03:46 PM Base Language Feature #3810: SECURITY-POLICY and other security features
- Task branch 4335a was merged to trunk as revision 11345.
- 03:45 PM Base Language Feature #3254: add support for running 4GL on multiple threads in a single session
- Task branch 4335a was merged to trunk as revision 11345.
- 03:45 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
- Task branch 4335a was merged to trunk as revision 11345.
- 03:43 PM User Interface Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...
- Task branch 4335a was merged to trunk as revision 11345.
- 03:42 PM User Interface Feature #4472 (Closed): Allow pause for a fraction of a second
- Task branch 4335a was merged to trunk as revision 11345.
- 03:41 PM User Interface Feature #4170: add drag and drop support to treeview widget
- Task branch 4335a was merged to trunk as revision 11345.
See #4170-21 for the remaining work. - 03:39 PM Base Language Feature #3867: direct java class access from 4GL code
- Task branch 4335a was merged to trunk as revision 11345.
- 03:37 PM Base Language Feature #3867 (Closed): direct java class access from 4GL code
- 03:38 PM Runtime Infrastructure Bug #4122: spawner segmentation fault when OS user has no password set
- Task branch 4335a was merged to trunk as revision 11345.
- 03:38 PM Runtime Infrastructure Bug #4122 (Closed): spawner segmentation fault when OS user has no password set
- 10:58 AM Base Language Feature #3868: customer servlet integration/support
- Greg Shah wrote:
> 1. What can we do to make it simple to configure/load these servlets? I want to avoid a huge amo...
03/12/2020
- 09:28 AM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
- Do you have a simple example for this? Conversion rules should choose the @putBytes_1@ if the argument is @Memptr@.
- 09:25 AM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
- Constantin Asofiei wrote:
> See #3751-492 for a comprehensive list of overload rules. We need support for method ov...
03/11/2020
- 04:05 PM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
- Sergey: Please write up the documentation for this widget in "CALENDAR Widget and OCX Replacement":/projects/p2j/wiki...
- 04:00 PM Base Language Feature #4384: Builtin OO Implementation
- > Greg, do we have some guildelines how the converted 4GL ENUMs should look? I think we need to add HashAlgorithmEnum...
- 02:54 PM User Interface Feature #2683: reverse proxy implementation
- We don't have documentation yet. External widget support is only needed in special cases where the code cannot be pl...
- 02:25 PM User Interface Feature #2683: reverse proxy implementation
- Greg, please could you provide me with information about external widget support? Are there ready examples?
- 02:18 PM User Interface Feature #2683: reverse proxy implementation
- Although it should be safe, I prefer to avoid changes in 4335a. Please put your changes into 4231b after it is rebas...
03/10/2020
- 09:42 AM Base Language Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> The issue was due to the fact that @GetEnum@ methods in skeleton class for Enum were not static,... - 09:37 AM Base Language Feature #4384: Builtin OO Implementation
- On 3/10/20 12:20 PM, Mihai Tiganea wrote:
> Getting deeper with tests for openedge.core.bytebucket I discover commen... - 04:22 AM Base Language Feature #4384: Builtin OO Implementation
- It turns out returning an object<> that has a reference that was not 'registered' with @ObjectOps@ will fail anyway w...
- 03:58 AM Base Language Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> > * Gradlew.bat deploy.all for oo/openedge/core/memptr/test_method_get_hash_algorithm.p ... - 09:10 AM User Interface Feature #2683: reverse proxy implementation
- Sergey Ivanovskiy wrote:
> I can't use 4231b for #2683-73 changes because these code exist only in 4335a. These chan... - 08:42 AM User Interface Feature #2683: reverse proxy implementation
- I can't use 4231b for #2683-73 changes because these code exist only in 4335a. These changes are only to remove logs ...
- 04:34 AM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- Roger Borrello wrote:
> Constantin Asofiei wrote:
> > Roger, I was missing the .ext-hints. After this, your sleep t... - 03:56 AM User Interface Feature #4170: add drag and drop support to treeview widget
- Roger Borrello wrote:
> I see many new keywords added related to @node@ and @nodes@. Were they a result of this issu... - 03:31 AM Database Feature #4011: database/persistence layer performance improvements
- Rev 11397 changes the @BaseRecord@ methods @getId()@ and @setId(Long)@ to @primaryKey()@ and @primaryKey(Long)@, resp...
03/09/2020
- 06:24 PM User Interface Feature #2683: reverse proxy implementation
- Sergey Ivanovskiy wrote:
> Yes, it looks like the old issue documented in @WebClientProtocol@
OK, please add javado... - 06:23 PM User Interface Feature #2683: reverse proxy implementation
- Greg Shah wrote:
> I don't have a problem with the patch, but Constantin should review.
I'm OK with the patch.
>... - 05:38 PM User Interface Feature #2683: reverse proxy implementation
- Yes, it looks like the old issue documented in @WebClientProtocol@...
- 04:59 PM User Interface Feature #2683: reverse proxy implementation
- It is interesting if we should remove logs here in @ThinClient.initializePost@ because it would block the web client?...
- 04:31 PM User Interface Feature #2683: reverse proxy implementation
- It seems that this hanging issue is reproduced only when I tried to connect @https://localhost/gui@ and the Apache pr...
- 04:04 PM User Interface Feature #2683: reverse proxy implementation
- The hanging issue has this thread context:
1) @KeyReader@ thread is in this state... - 03:41 PM User Interface Feature #2683: reverse proxy implementation
- No, the broker manager patch is related to the case when the broker manager is not used but clients to ports map is r...
- 03:28 PM User Interface Feature #2683: reverse proxy implementation
- I don't have a problem with the patch, but Constantin should review.
> It requires to set up a broker configuratio... - 03:14 PM User Interface Feature #2683: reverse proxy implementation
- I tested this Apache Reverse proxy configuration with this branch 4335a using Hotel Gui application. The current code...
- 05:15 PM User Interface Feature #4170: add drag and drop support to treeview widget
- I see many new keywords added related to @node@ and @nodes@. Were they a result of this issue? I noticed that @node-e...
- 04:55 PM Base Language Support #4032: block/transaction processing context-local and other performance improvements
- I've documented some ideas related to Constantin's CFS reflection optimization task (#1970).
- 04:55 PM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection
- I've been thinking about how we could cache method instances in @ControlFlowOps@ recently. I started to document my ...
- 03:49 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- Constantin Asofiei wrote:
> Roger, I was missing the .ext-hints. After this, your sleep testcase in #4182-6 works fi... - 03:41 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- Roger, I was missing the .ext-hints. After this, your sleep testcase in #4182-6 works fine.
Please check your clas... - 03:27 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- Roger, sorry, I can't make anything to work (@gethostbyname@, @GetComputerNameA@). I don't recall how this was suppo...
- 02:52 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- Eric Faulhaber wrote:
> Sorry, no. If this test case is one of mine, I don't remember it.
>
> Are you getting a p... - 02:48 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- Sorry, no. If this test case is one of mine, I don't remember it.
Are you getting a particular error, or just no r... - 02:39 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- Eric, did you ever test the @myconn1.p@ testcase under FWD and Windows? I'm trying to get my @Kernel32:Sleep@ functio...
- 02:35 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- I made a simplified version of @uast/myconn1.p@:...
- 02:12 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- I made sure my pathing was correct by validating that @directory.xml@ contains:...
- 01:26 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- @./src/com/goldencode/testcases/name_map.xml@ looks good... although perhaps the pathing is misconfigured?...
- 01:21 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- Roger Borrello wrote:
> When @getAbsoluteName(Object referent)@ is called, @jname="com.goldencode.testcases.windows_... - 01:16 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- When @getAbsoluteName(Object referent)@ is called, @jname="com.goldencode.testcases.windows_emulation.Kernel32Sleep"@...
- 12:50 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- Constantin Asofiei wrote:
> Roger Borrello wrote:
> > I hit a breakpoint in @Kernel32Sleep.lambda$execute$1@ so I'l... - 12:27 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- Roger Borrello wrote:
> I hit a breakpoint in @Kernel32Sleep.lambda$execute$1@ so I'll try to find my way from here.... - 12:25 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- Constantin Asofiei wrote:
> Roger Borrello wrote:
> > I was expecting to hit my breakpoint, but I must be missing s... - 12:19 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- Roger Borrello wrote:
> I was expecting to hit my breakpoint, but I must be missing something.
You need to attach t... - 12:17 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
- I've been trying to catch this in the debugger, but since this is my first rodeo debugging client or server runtime, ...
- 08:16 AM Base Language Feature #4384: Builtin OO Implementation
- On 3/9/20 1:36 PM, Mihai Tiganea wrote:
>
> After create tests in progress for ByteBucket and Memptr constructors, ...
Also available in: Atom