Project

General

Profile

Activity

From 10/30/2021 to 11/28/2021

11/25/2021

08:59 AM Conversion Tools Feature #4105: improve flexibility of schema loading
Just name the @.df@ files differently (even if they have the same logical db names) and they can all be placed at once. Greg Shah

11/24/2021

09:25 AM Conversion Tools Feature #4105: improve flexibility of schema loading
Greg Shah wrote:
> I don't understand why the @.df@ files have to be in sub-directories. You are only laying down t...
Roger Borrello
08:34 AM Conversion Tools Feature #4105: improve flexibility of schema loading
I don't understand why the @.df@ files have to be in sub-directories. You are only laying down the @.df@ files neede... Greg Shah
08:32 AM Conversion Tools Feature #4105: improve flexibility of schema loading
Why do you need 2 @p2j.cfg.xml@ files? Greg Shah
08:16 AM Conversion Tools Feature #4105: improve flexibility of schema loading
Greg Shah wrote:
> I think we may have some hard coded assumptions that everything is in the @data/@ directory. You...
Roger Borrello
05:10 AM User Interface Bug #5118: TREELIST widget issues
Vladimir Tsichevski wrote:
> Done in 3821c Revision 13186 as part of the fix for #5823.
Code review 3821c revisio...
Hynek Cihlar

11/23/2021

05:06 PM User Interface Bug #5118: TREELIST widget issues
Hynek Cihlar wrote:
> Vladimir Tsichevski wrote:
> > Hynek Cihlar wrote:
> > > Vladimir Tsichevski wrote:
> > > >...
Vladimir Tsichevski
09:24 AM Conversion Tools Feature #4105: improve flexibility of schema loading
I think we may have some hard coded assumptions that everything is in the @data/@ directory. You should move away fr... Greg Shah
08:48 AM Conversion Tools Feature #4105: improve flexibility of schema loading
Greg Shah wrote:
> > I do not have a solution for the directory hints. AFAIK, their name is fixed.
>
> We have no...
Roger Borrello
08:19 AM Conversion Tools Feature #4105 (Review): improve flexibility of schema loading
Code Review Task branch 3821c Revision 13194
It looks good.
Eric: Please review.
Greg Shah

11/22/2021

06:51 PM Conversion Tools Feature #4105: improve flexibility of schema loading
I have just committed revision 13194.
It contains support for 'unloading' a schema/database for a source-file or ...
Ovidiu Maxiniuc
06:40 PM Conversion Tools Feature #4105: improve flexibility of schema loading
> I do not have a solution for the directory hints. AFAIK, their name is fixed.
We have no solution for this. For...
Greg Shah
06:30 PM Conversion Tools Feature #4105: improve flexibility of schema loading
Roger,
The truth is: the project is quite complex.
For the different file lists, I think you can create one for e...
Ovidiu Maxiniuc
05:57 PM Conversion Tools Feature #4105: improve flexibility of schema loading
Made minor edit to the directory names, which were wrong. Roger Borrello
05:54 PM Conversion Tools Feature #4105: improve flexibility of schema loading
I had tried to add Ovidiu as a watcher to #4212 so I could pose a configuration question in there, but I can ask here... Roger Borrello
02:24 PM Runtime Infrastructure Bug #5388 (Closed): handshake failure while testing customer app
Greg Shah
12:11 PM Runtime Infrastructure Bug #5388: handshake failure while testing customer app
Greg Shah wrote:
> Igor: What is the status of this task?
I understand that it is fixed.
Igor Skornyakov
11:55 AM Runtime Infrastructure Bug #5388: handshake failure while testing customer app
Igor: What is the status of this task? Greg Shah

11/20/2021

08:08 PM Conversion Tools Feature #4105: improve flexibility of schema loading
I could not finish the management of banned schemas. Things are a bit complicated because the @SchemaDictionary$Scope... Ovidiu Maxiniuc

11/19/2021

07:29 AM Conversion Tools Feature #4105: improve flexibility of schema loading
I like the idea. Greg Shah
09:42 PM Conversion Tools Feature #4105: improve flexibility of schema loading
Greg Shah wrote:
> Ovidiu: Did you ever finish making a plan to address item 3 in #4105-1? We need that last featur...
Ovidiu Maxiniuc

11/18/2021

11:27 AM Conversion Tools Feature #4105: improve flexibility of schema loading
Ovidiu: Did you ever finish making a plan to address item 3 in #4105-1? We need that last feature to implement #4212... Greg Shah
10:31 AM User Interface Bug #5825: Enhance WidgetBrowser ContainerTree to evaluate methods from the Widget interface
An approach would be to evaluate all methods which:
* return a @Point@, @NativePoint@, @Rectangle@, etc (a dimension...
Constantin Asofiei
09:21 AM User Interface Bug #5825: Enhance WidgetBrowser ContainerTree to evaluate methods from the Widget interface
The code which resolves the widget property table on the right-side of the widget browser is in @ContainerTree.getWid... Roger Borrello
09:20 AM User Interface Bug #5825 (New): Enhance WidgetBrowser ContainerTree to evaluate methods from the Widget interface

Roger Borrello
10:23 AM User Interface Bug #4557: radio-set deviations from the 4GL GUI
Results from #4557-3, #4557-4, and #4557-5 were found using @3821c_13187@ Roger Borrello
10:22 AM User Interface Bug #4557: radio-set deviations from the 4GL GUI
+Test uast/radio_set/rs_test8.p+
This test:...
Roger Borrello
10:04 AM User Interface Bug #4557: radio-set deviations from the 4GL GUI
+Test uast/radio_set/rs_test4_5.p+
This test results in formatting issues, which may, or may not, be related to ra...
Roger Borrello
09:51 AM User Interface Bug #4557: radio-set deviations from the 4GL GUI
+Test uast/radio_set/rs_test7_1.p+
This test:...
Roger Borrello

11/17/2021

02:48 PM User Interface Bug #5118: TREELIST widget issues
Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Vladimir Tsichevski wrote:
> > > Indeed, there is no such eve...
Hynek Cihlar
02:44 PM User Interface Bug #5118: TREELIST widget issues
Hynek Cihlar wrote:
> Vladimir Tsichevski wrote:
> > Indeed, there is no such event in original OCX by obvious reas...
Vladimir Tsichevski
02:30 PM User Interface Bug #5118: TREELIST widget issues
Vladimir Tsichevski wrote:
> Indeed, there is no such event in original OCX by obvious reason: unlike the @OnExpandi...
Hynek Cihlar
01:49 PM User Interface Bug #5118: TREELIST widget issues
@OnCollapsing@ trigger implementation: in FWD there is an incomplete support for this event: corresponding event ID c... Vladimir Tsichevski

11/16/2021

11:10 AM User Interface Bug #5809: Setting sizing attributes for WINDOW and FRAME widgets issues
h4. Issue 7
Automatic frame placement along the Y axis at the client side works incorrectly.
In the example @st...
Vladimir Tsichevski

11/15/2021

02:19 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...
>< did you mean the Ant target(s) should be added to the build file of an application project, like Hotel GUI?
Yes...
Greg Shah
12:32 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...
Greg Shah wrote:
> 4. I think that some standardized changes are needed to our project configuration (the ant @build...
Hynek Cihlar
11:52 AM User Interface Bug #5809: Setting sizing attributes for WINDOW and FRAME widgets issues
Greg Shah wrote:
> Code Review Task Branch 3821c Revision 13160
>
> Please put a comment above the @setScrollable...
Vladimir Tsichevski
10:58 AM User Interface Bug #5809: Setting sizing attributes for WINDOW and FRAME widgets issues
Code Review Task Branch 3821c Revision 13160
Please put a comment above the @setScrollable@ lines that "scrollable...
Greg Shah
09:28 AM User Interface Bug #5809: Setting sizing attributes for WINDOW and FRAME widgets issues
Vladimir Tsichevski wrote:
> h4. Issue 5
>
> Scrollable frame conversion issue. The following frame declaration:
...
Vladimir Tsichevski

11/12/2021

03:07 PM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
3821c/13156 adds fixes for SOAP and REST support:
* fixed differences between PASOE and classic appserver, when erro...
Constantin Asofiei
01:50 PM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
The @java_override_oo_names@ map is used from:
* @common-progress.rules:resolve_class_name@ - uses pkg.classname low...
Constantin Asofiei
12:20 PM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Consider:... Greg Shah

11/11/2021

03:10 PM Conversion Tools Feature #5819: update standard project build.xml to provide targets for backup/restore
We should have build targets for the backup that creates the master and the restore from the master. Greg Shah
03:10 PM Conversion Tools Feature #5819: update standard project build.xml to provide targets for backup/restore
From Eric:
> I know it takes a very long time to import large databases, like @<large_customer_application>@. Thi...
Greg Shah
03:07 PM Conversion Tools Feature #5819 (New): update standard project build.xml to provide targets for backup/restore
Greg Shah
11:21 AM Conversion Tools Feature #4105: improve flexibility of schema loading
The patch was committed to 3821c in rev.13151. Ovidiu Maxiniuc
11:11 AM Conversion Tools Feature #4105: improve flexibility of schema loading
Ovidiu Maxiniuc wrote:
> I discovered recently that the configuration processing may be affected by the current clas...
Roger Borrello
05:41 AM User Interface Bug #5809: Setting sizing attributes for WINDOW and FRAME widgets issues
Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > With one caveat. When the virtual size is already greater than...
Hynek Cihlar
05:23 AM User Interface Bug #5809: Setting sizing attributes for WINDOW and FRAME widgets issues
Hynek Cihlar wrote:
> Vladimir Tsichevski wrote:
> > Hynek Cihlar wrote:
> > > Vladimir Tsichevski wrote:
> > > >...
Vladimir Tsichevski
03:55 AM User Interface Bug #5809: Setting sizing attributes for WINDOW and FRAME widgets issues
Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Vladimir Tsichevski wrote:
> > > Hynek Cihlar wrote:
> > > >...
Hynek Cihlar

11/10/2021

06:17 PM User Interface Bug #5809: Setting sizing attributes for WINDOW and FRAME widgets issues
Hynek Cihlar wrote:
> Vladimir Tsichevski wrote:
> > Hynek Cihlar wrote:
> > > Vladimir Tsichevski wrote:
> > > >...
Vladimir Tsichevski
05:13 PM User Interface Bug #5809: Setting sizing attributes for WINDOW and FRAME widgets issues
Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Vladimir Tsichevski wrote:
> > >
> > > The problem here is ...
Hynek Cihlar
04:59 PM User Interface Bug #5809: Setting sizing attributes for WINDOW and FRAME widgets issues
Hynek Cihlar wrote:
> Vladimir Tsichevski wrote:
> >
> > The problem here is that at the moment @setWidthPixels@ ...
Vladimir Tsichevski
04:24 PM User Interface Bug #5809: Setting sizing attributes for WINDOW and FRAME widgets issues
Vladimir Tsichevski wrote:
>
> The problem here is that at the moment @setWidthPixels@ is called, the frame is *no...
Hynek Cihlar
03:48 PM User Interface Bug #5809 (WIP): Setting sizing attributes for WINDOW and FRAME widgets issues
Vladimir Tsichevski
03:48 PM User Interface Bug #5809: Setting sizing attributes for WINDOW and FRAME widgets issues
h4. Issue 6
In FWD frame virtual width is reset when set equal to frame width. 4gl does not show this behavior.
...
Vladimir Tsichevski
02:05 PM User Interface Bug #5809: Setting sizing attributes for WINDOW and FRAME widgets issues
Vladimir Tsichevski wrote:
> h4. Issue 5
> The problem here is that at the moment @setWidthPixels@ is called, the...
Vladimir Tsichevski
01:14 PM User Interface Bug #5809: Setting sizing attributes for WINDOW and FRAME widgets issues
h4. Issue 5 (fixed)
Scrollable frame conversion issue. The following frame declaration:...
Vladimir Tsichevski

11/09/2021

05:36 PM Conversion Tools Feature #4105: improve flexibility of schema loading
Roger Borrello wrote:
> I updated the @p2j.cfg.xml@ and @server.sh@ and received the below in @server.log@:
> ...
Ovidiu Maxiniuc
03:57 PM Conversion Tools Feature #4105: improve flexibility of schema loading
> Maybe there's more, but this is much cleaner!
Nice!
Greg Shah
03:53 PM Conversion Tools Feature #4105: improve flexibility of schema loading
Ovidiu Maxiniuc wrote:
> Using different profiles (I.e. tables in different namespaces) leads the DMOs to be found i...
Roger Borrello
03:17 PM Conversion Tools Feature #4105: improve flexibility of schema loading
Roger Borrello wrote:
> We will in the future, but for now there is only 1 [profile]. All the databases have been me...
Ovidiu Maxiniuc
06:47 AM Conversion Tools Feature #4105: improve flexibility of schema loading
Roger: Some elements can be removed from the namespace section because of improvements in this task. See item 4 in #... Greg Shah
09:57 PM Conversion Tools Feature #4105: improve flexibility of schema loading
Ovidiu Maxiniuc wrote:
> Roger Borrello wrote:
> > What config changes are there?
> These are related to profile s...
Roger Borrello
07:46 PM Conversion Tools Feature #4105: improve flexibility of schema loading
Roger Borrello wrote:
> What config changes are there?
These are related to profile selection/configuration. Do you...
Ovidiu Maxiniuc
07:31 PM Conversion Tools Feature #4105: improve flexibility of schema loading
Ovidiu Maxiniuc wrote:
> Roger, please update to r13146.
> The profile selection events are now properly logged.
...
Roger Borrello
04:25 PM User Interface Bug #5809: Setting sizing attributes for WINDOW and FRAME widgets issues
h4. Issue 4
At the time frame is realized, its @VIRTUAL-WIDTH@, if unset, should be assigned from its @WIDTH@. See...
Vladimir Tsichevski
02:11 PM User Interface Bug #5809: Setting sizing attributes for WINDOW and FRAME widgets issues
h4. Issue 1.
Setting @FRAME@ @VIRTUAL-WIDTH-PIXELS@ attribute to zero:
in 4gl:
A warning is displayed:
<p...
Vladimir Tsichevski
02:02 PM User Interface Bug #5809 (WIP): Setting sizing attributes for WINDOW and FRAME widgets issues
Vladimir Tsichevski
12:14 PM Database Bug #5802: a date temp-table field gets assigned to incorrect date
If @LocalDate@ handled historical dates properly, then we would certainly need to consider moving to it. Without tha... Greg Shah
07:40 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...
I've exposed the download of the extended version of the TM in [[p2j:Downloads#Translation-Manager-Extended-Export-Ve... Greg Shah
06:56 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...
> Please move the page.
Done.
Greg Shah
03:10 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...
Greg Shah wrote:
> Documentation Review
>
> It is very good.
>
> 1. I moved this into our Conversion Handbook,...
Hynek Cihlar

11/08/2021

06:35 PM Conversion Tools Feature #4105: improve flexibility of schema loading
Roger, please update to r13146.
The profile selection events are now properly logged.
Ovidiu Maxiniuc
03:45 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...
Documentation Review
It is very good.
1. I moved this into our Conversion Handbook, in the existing [[p2j:Inter...
Greg Shah
06:35 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...
Greg Shah wrote:
> > I deliberately let the exception propagate up so that the conversion fails early. But if you th...
Hynek Cihlar

11/07/2021

01:07 PM Base Language Feature #3817 (Review): create resource bundles from string literals and implement optional suppo...
Hynek Cihlar
01:07 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...
Please review the documenation at [[p2j:Translations]]. Hynek Cihlar

11/06/2021

10:34 PM Database Bug #5802: a date temp-table field gets assigned to incorrect date
I did some small scale tests/investigations. The @LocalDate@ might be the utility @date@ needs. There are methods for... Ovidiu Maxiniuc

11/05/2021

01:34 PM Database Bug #5802: a date temp-table field gets assigned to incorrect date
I believe it may be possible that we are doing some over-calculations with the @date@. From my experience with this B... Ovidiu Maxiniuc
01:33 PM Database Bug #5802: a date temp-table field gets assigned to incorrect date
Greg Shah wrote:
> At the time I wrote this code, the use of @Date@ with the day, month, year was already deprecated...
Constantin Asofiei
01:21 PM Database Bug #5802: a date temp-table field gets assigned to incorrect date
> But a potential problem may be: when working with pure dates, maybe FWD should not depend on/use the time part at a... Greg Shah
01:17 PM Database Bug #5802: a date temp-table field gets assigned to incorrect date
Ovidiu Maxiniuc wrote:
> Same Java version here.
> Greg, please try with @ABL_11_NOV_1900 = 2430137@ (05/21/1941).
...
Greg Shah
12:48 PM Database Bug #5802: a date temp-table field gets assigned to incorrect date
Constantin Asofiei wrote:
> Ovidiu: I don't think this is specific on a user's machine (as long as @TimeZone.getDefa...
Ovidiu Maxiniuc
12:47 PM Database Bug #5802: a date temp-table field gets assigned to incorrect date
Constantin Asofiei wrote:
> Ovidiu, is this only with this specific @1900-11-11@ date? Can you run all dates from 1...
Ovidiu Maxiniuc
12:46 PM Database Bug #5802: a date temp-table field gets assigned to incorrect date
Greg, what does @TimeZone.getDefault();@ show for you?
Ovidiu: I don't think this is specific on a user's machine ...
Constantin Asofiei
12:41 PM Database Bug #5802: a date temp-table field gets assigned to incorrect date
Same Java version here.
Greg, please try with @ABL_11_NOV_1900 = 2430137@ (05/21/1941).
Ovidiu Maxiniuc
12:36 PM Database Bug #5802: a date temp-table field gets assigned to incorrect date
If I'm using @TimeZone.getTimeZone("Europe/Bucharest")@, the program shows:... Constantin Asofiei
12:24 PM Database Bug #5802: a date temp-table field gets assigned to incorrect date
I don't see the issue on my system:... Greg Shah
12:20 PM Database Bug #5802: a date temp-table field gets assigned to incorrect date
Ovidiu, is this only with this specific @1900-11-11@ date? Can you run all dates from 1900 to 2030 in a loop, a log ... Constantin Asofiei
12:13 PM Database Bug #5802: a date temp-table field gets assigned to incorrect date
I used Constantin's test case. I added traces (@System.out.format()@) in @date.neutralMillisToCalendar(long millis, T... Ovidiu Maxiniuc
12:29 PM Conversion Tools Feature #4105: improve flexibility of schema loading
Ovidiu Maxiniuc wrote:
> Roger, please do not do anything, yet.
> I forgot to remove implementation of profile sel...
Roger Borrello
12:21 PM Conversion Tools Feature #4105: improve flexibility of schema loading
Roger, please do not do anything, yet.
I forgot to remove implementation of profile selection from @fwd.profile.def...
Ovidiu Maxiniuc

11/04/2021

05:19 PM Conversion Tools Feature #4105: improve flexibility of schema loading
I am getting a warning:... Roger Borrello
11:09 AM Database Bug #5802: a date temp-table field gets assigned to incorrect date
Do you have a simple Java recreate for this? I assume we can recreate this with simple Java code with a @main()@ tha... Greg Shah
08:05 PM Database Bug #5802: a date temp-table field gets assigned to incorrect date
I continued investigations on this issue. The problem seems to be at the moment when the timezone of the @GregorianCa... Ovidiu Maxiniuc

11/03/2021

01:22 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...
> I deliberately let the exception propagate up so that the conversion fails early. But if you think a warning is eno... Greg Shah
01:01 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...
Greg Shah wrote:
> Code Review Task branch 3821c Revision 13125
>
> Overall, this is very good.
>
> 1. In @set...
Hynek Cihlar
09:50 AM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...
Code Review Task branch 3821c Revision 13125
Overall, this is very good.
1. In @set_attr_ex_ex@ we have this co...
Greg Shah
09:10 AM Database Bug #5802: a date temp-table field gets assigned to incorrect date
> It seems like the first setup is somewhat incorrect. Since the default timezone is unlikely to change, only the ve... Greg Shah
09:03 PM Database Bug #5802: a date temp-table field gets assigned to incorrect date
I did a bit of investigations. Here is the stack downstream from @_setDate@:... Ovidiu Maxiniuc
04:57 AM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Constantin, logs were checked, corrected and committed in bzr with revision nr 1166. The error was throwed because fe... Mihai Popescu-Tiganea

11/02/2021

07:42 PM Database Bug #5799 (Feedback): write-xml doesn't serialize the prods:id attributes and the deleted fields ...
As you noted, there were two issues here:
* WRITE-XML was not serializing the @prods:id@ and @prods:rowState@ attrib...
Ovidiu Maxiniuc
11:13 AM Database Bug #5799: write-xml doesn't serialize the prods:id attributes and the deleted fields for before-...
This program:... Constantin Asofiei
11:11 AM Database Bug #5799 (Feedback): write-xml doesn't serialize the prods:id attributes and the deleted fields ...
Constantin Asofiei
07:03 PM Database Bug #5801 (Feedback): write-xml is not using XML-NODE-NAME for the temp-table
The issue was fixed and revision in 13126. Ovidiu Maxiniuc
11:24 AM Database Bug #5801: write-xml is not using XML-NODE-NAME for the temp-table
This test:... Constantin Asofiei
11:23 AM Database Bug #5801 (Feedback): write-xml is not using XML-NODE-NAME for the temp-table
Constantin Asofiei
06:21 PM Base Language Feature #3817: create resource bundles from string literals and implement optional support for se...
3821c revision 13125 implements i18n string expansion and also contains other related changes.
The calculation of ...
Hynek Cihlar
12:11 PM Database Bug #5800: Conversion issue with CAN-FIND
Eric Faulhaber wrote:
> The conversion has gone quite wrong. I don't think we've come across a case before which com...
Igor Skornyakov
11:57 AM Database Bug #5800: Conversion issue with CAN-FIND
The conversion has gone quite wrong. I don't think we've come across a case before which compares the results of two ... Eric Faulhaber
11:14 AM Database Bug #5800: Conversion issue with CAN-FIND
The conversion of the following program... Igor Skornyakov
11:13 AM Database Bug #5800 (New): Conversion issue with CAN-FIND
Igor Skornyakov
11:45 AM Database Bug #5802: a date temp-table field gets assigned to incorrect date
This test will assign @tt1.f1@ to @1900-11-10@, only on the first iteration. I saw this when working with #3310 SOAP... Constantin Asofiei
11:43 AM Database Bug #5802 (New): a date temp-table field gets assigned to incorrect date
Constantin Asofiei
11:31 AM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Marian: from SOAP's PASOE logs, the response for @pipe_dataset_handle@ is:... Constantin Asofiei
11:14 AM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
A bug which affects dataset_bt_out is logged as #5799. Constantin Asofiei
11:00 AM User Interface Bug #5797: Drawing with null widget
This is a cleanup issue that has no negative affect on the user. See #4829 for details. Greg Shah
10:59 AM User Interface Bug #5797 (New): Drawing with null widget
Greg Shah
04:59 AM Runtime Infrastructure Bug #5734 (Closed): datetimetz.toStringMessage() incorrect output: the time zone spec is duplicated
Greg Shah

11/01/2021

08:47 AM Runtime Infrastructure Bug #5734 (Test): datetimetz.toStringMessage() incorrect output: the time zone spec is duplicated
Code Review Task Branch 3821c Revision 13119
No objections.
Greg Shah
 

Also available in: Atom