Greg Shah's activity
From 04/27/2025 to 05/26/2025
05/26/2025
- 09:26 AM User Interface Bug #4135 (Merge Pending): high dpi screens display in low dpi
- Please merge to trunk now.
- 07:49 AM Conversion Tools Feature #6256: improved profile support
- Although I added some notes in #6256-45, those are wider requirements for app-by-app conversion. We won't work those...
- 07:30 AM User Interface Bug #9929 (Test): FILL-IN: Incorrect APPLY statement behavior
- 05:53 AM User Interface Bug #9929 (Merge Pending): FILL-IN: Incorrect APPLY statement behavior
- You can merge to trunk now.
05/23/2025
- 11:15 AM Database Feature #7020: always use "expanded" extent fields
- Alexandru Lungu wrote:
> > Does 7020d remove normalized extent support completely? If so, then we have to resolve #7... - 09:07 AM Database Feature #7020: always use "expanded" extent fields
- > I think such process should be documented and create a task per customer (for us to test).
Agreed.
It is my u... - 09:54 AM User Interface Bug #10045: The embedded Hotel Gui application is broken
- I have just tested the following:
1. Build trunk rev 15932 using @./gradlew core sheet:war@.
2. @bzr co ~/secur...
05/22/2025
- 09:30 AM Runtime Infrastructure Feature #10040: add a "Report a Problem" button to the virtual desktop popup menu to allow a user...
- Users are trying to do their job when something breaks like an application hang or failure. They naturally don't sto...
- 09:22 AM Runtime Infrastructure Feature #10040 (New): add a "Report a Problem" button to the virtual desktop popup menu to allow ...
- 06:52 AM Conversion Tools Bug #10028: FWD needs full support for unicode/octal escape sequences
- Agreed.
- 06:51 AM Base Language Feature #9447: XML support feature improvements and testing
- Teodor Gorghe wrote:
> Regarding to the @X-DOCUMENT:LOAD@ method, for the *longchar* mode, on 4GL implementation, th...
05/21/2025
- 11:28 AM Testing Support #6859: preprocessor tests
- Sounds like an OE bug which we won't reproduce. We should keep some record of this, but the OE tests will have to be...
- 11:10 AM Testing Support #6859: preprocessor tests
- Are you talking about OE or FWD?
- 10:38 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
- You can post in #7823 for help on that test suite.
05/20/2025
- 01:19 PM Runtime Infrastructure Bug #9740: Client running in batch mode stops with a crash on Windows
- We'll get you changes that allow the building of the @p2j.dll@ with embedded version info.
Lorian: Please make #... - 01:18 PM Runtime Infrastructure Feature #9851 (WIP): hard code the FWD version string in the JNI code at build time
- 01:18 PM Runtime Infrastructure Feature #9851: hard code the FWD version string in the JNI code at build time
- > > > In @build.gradle@ you can see we write it into code like @Version.java@.
> > >
> > Hmm, ok. Should this vers...
05/19/2025
- 12:05 PM Conversion Tools Bug #9886: Double slashes should produce a new line during preprocessing
- > I have rebased and tested this with a customer application. The "deploy" step passed.
Was this an application th... - 12:03 PM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
- Have you re-tested Hotel GUI (including analytics and callgraph)?
Please make sure to test conversion of the ChUI ... - 12:02 PM Conversion Tools Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
- Code Review Task Branch 6308a Revision 15903
I'm a little nervous about this change.
Please add preprocessor te... - 11:31 AM Testing Support #6860: lexer tests
- Code Review Task Branch 6860a Revisions 15889 through 15991
Overall, the changes are good.
1. I'm not sure abou... - 09:31 AM Database Feature #7504: Export data tool from FWD into .d files
- Create a new task for the import bug.
- 07:55 AM Base Language Bug #10004: NativeInvoker fails if an argument is of type integerConstant
- The @library_calls/@ tests in [[p2j:Testcases]] should be executed. These are not yet reworked as ABLUnit tests. Se...
- 07:52 AM Runtime Infrastructure Feature #9989: security plugin for appserver/REST/SOAP/web API access
- I understand, but that is not enough to properly implement the FWD security model.
05/16/2025
- 10:37 AM Testing Support #6860: lexer tests
- OK, that is reasonable.
- 10:23 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- Octavian Adrian Gavril wrote:
> Some context-local implementations are a bit problematic in scenarios where threads ... - 09:03 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Dănuț Filimon wrote:
> Greg Shah wrote:
> > > I plan to get rid of plain ".ast" or ".dict" usages and turn them int... - 08:13 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- > I plan to get rid of plain ".ast" or ".dict" usages and turn them into ArtifactManager variables to be used in my n...
- 08:31 AM Database Feature #7504: Export data tool from FWD into .d files
- > After import, the stored value in the database was @1919-12-31@ (disregarding the formatting), which indicates the ...
- 06:33 AM Database Bug #9969 (Merge Pending): Parsing query string error with \r character.
- Please merge to trunk after 9834a.
05/15/2025
- 09:20 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- Octavian Adrian Gavril wrote:
> Do you think it would be better to safely share the @PatternEngine@ instance and the... - 09:00 AM Database Bug #9969 (Internal Test): Parsing query string error with \r character.
- Yes, you're right.
- 08:16 AM Database Bug #9969 (Merge Pending): Parsing query string error with \r character.
- You can merge to trunk now.
- 08:05 AM Database Bug #9969: Parsing query string error with \r character.
- > I used this testcase to see if the behavior is as expected:
> [...]
>
> Converted code with @unixEscapes@ on @t...
05/14/2025
- 03:20 PM User Interface Feature #9055 (WIP): server-side processing of client platform dependencies in the UI
- Hynek: Please update the %Done and summarize any recent headway.
- 02:19 PM Database Feature #7504: Export data tool from FWD into .d files
- The export isn't converted code and does not need to be executed using the FWD client. Writing the dump on the serv...
- 11:06 AM Database Feature #7504: Export data tool from FWD into .d files
- > In OE the .d file stores the name of the *.blb file
At a minimum we should use @blb@ and @clb@ instead of @null@... - 08:57 AM Runtime Infrastructure Feature #9989: security plugin for appserver/REST/SOAP/web API access
- In [[p2j:Calling_4GL_Code_via_the_Appserver_API#Replacing-the-Open-Client-for-Java|Replacing the Open Client for Java...
- 08:54 AM Runtime Infrastructure Feature #9989 (New): security plugin for appserver/REST/SOAP/web API access
- 07:17 AM Testing Support #6860: lexer tests
- This would require that we run the parser for lexer tests. We can do that, but seems a bit complicated. Why not jus...
05/13/2025
- 02:57 PM Testing Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
- > * _"While the Harness has decent documentation, we have no documentation, standards or examples for things outside ...
- 08:12 AM Conversion Tools Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
- > As a summary, in text.g I added this to now match @& @ and consume it since that's the behavior in 4GL.
Please s... - 07:20 AM Database Bug #9969: Parsing query string error with \r character.
- This affects all string processing in the lexer in a profound way. Full conversion testing is needed.
- 06:51 AM Database Bug #9969 (Internal Test): Parsing query string error with \r character.
- Code Review Task Branch 9969a Revisions 15901 through 15903
I'm OK with the changes. Let's get it tested across a... - 06:38 AM Conversion Tools Feature #5586 (Internal Test): move all conversion artifacts/outputs into the cvtdb or into a ded...
- Code Review Task Branch 5586a Revisions 15899 through 15901
The changes are good. - 06:29 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- Octavian Adrian Gavril wrote:
> Octavian Adrian Gavril wrote:
> > OK. So, processing each AST (or walk call graph) ... - 06:29 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- Yes, but there is also the 2nd phase:...
- 05:57 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- > I understand that PatternEngine should be thread-safe, but where exactly should the thread work be split? Perhaps ...
- 06:12 AM Testing Support #6860: lexer tests
- > Branch 6860a passed the regression tests on ChUI and Hotel conversions, but I'm thinking we could delay the merge s...
05/12/2025
- 07:21 PM Database Feature #9976: eliminating DMO usage in inter-program linkage
- > For parameters, the buffers should not construct their own @BaseRecord@, but use the 'pointer' to one already creat...
- 08:52 AM Database Feature #9976: eliminating DMO usage in inter-program linkage
- In the 4GL, there is no concept of a DMO. From the beginning (in the 1980s), the 4GL has always directly mapped comp...
- 07:26 AM Database Feature #7020: always use "expanded" extent fields
- We don't want to leave behind any traces of the old modes.
05/10/2025
- 06:05 PM Runtime Infrastructure Feature #8863 (Closed): Add tenantName logic related to sec_authentication_domain in FWD
05/09/2025
- 05:06 PM Database Feature #9976 (New): eliminating DMO usage in inter-program linkage
05/08/2025
- 05:56 AM TRPL Feature #1752: eliminate statics/singleton patterns in all TRPL worker classes and other dependen...
- There is nothing intrinsically unsafe with static methods. Any state they access will need to be context local OR sy...
05/07/2025
- 11:51 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
- Stefan Vieru wrote:
> Question about @.jast@ files: should they be moved aswell into artifact directory,
Yes. Be... - 11:47 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
- Stefan Vieru wrote:
> Addressing this @.p2o@ issue, in the hopes that I understood correctly, my changes to @visitAs... - 11:28 AM Testing Support #6860: lexer tests
- > Besides making sure it's safe to run many tests in parallel and actually running them with harness test plans, no t...
- 08:43 AM Database Bug #9969: Parsing query string error with \r character.
- Our preprocessor/lexer strips @'\r'@ characters in a naive way that needs to be refined.
05/06/2025
- 10:29 AM Testing Support #6860 (Internal Test): lexer tests
- Code Review Task Branch 6860a Revision 15888
The code is good.
The changes are pretty safe. What testing has b... - 10:26 AM Testing Support #6860: lexer tests
- > quoted values aren't allowed for dates
There is an exception to this. In OE (and FWD), the @INITIAL@ clause of ... - 09:57 AM Testing Support #6860: lexer tests
- Code Review Task Branch 6860a REvision 15887
Please remove @import com.goldencode.p2j.uast.LexerOptions;@ from @Le... - 08:43 AM Testing Support #6860: lexer tests
- Please rename @LexerTestOptions@ to @LexerOptions@ and move it back to the @uast@ package so that we don't have refer...
- 08:38 AM Testing Support #6860: lexer tests
- Code Review Task Branch 6860a Revisions 15884 through 15886
@LexerTestDriver@:
* use wildcard imports
* add ja... - 08:26 AM Testing Support #6860: lexer tests
- Feedback on the tests:
* The date tests are missing a large number of cases that can be found in @date.main()@. W... - 09:41 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- > Constantin: I know you started work on this some time ago. What task had those results and are there any other note...
- 09:40 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- There is an early version of a multi-threaded pattern engine rewrite in @com.goldencode.trpl.*@. It is fairly clean ...
05/05/2025
- 08:19 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
- > check if the current AST is a p2o AST and avoid calling loadTemporarySchema for it.
This would work, though:
... - 08:02 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
- The @hotel.p2o@ is the persistent database and should not be loaded by @loadTemporarySchema()@ because that code is s...
- 06:57 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
- > At @Generate Data Model Objects (database DMOs)@ step, inside @loadTemporarySchema@ when the filename is @./cvt/dat...
- 06:45 AM TRPL Feature #1745 (Hold): review, decide upon and document the 1.0 features which will be retained in...
- Yes, it is safe to pause.
05/03/2025
- 10:12 AM Testing Feature #1889: rework the date.java internal tests as real unit tests
- In addition to moving these tests into ABLUnit, please create lexer tests for each of the literal values AND ensure t...
- 10:08 AM Base Language Bug #9963: Date literal issues
- Florin: Please add these cases to the lexer tests.
05/01/2025
- 07:15 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
- For details on how we properly document the licensing of the ADE code, see [[p2j:Inclusion of Apache 2 Licensed ADE C...
- 07:15 AM Base Language Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4
- For details on how we properly document the licensing of the ADE code, see [[p2j:Inclusion of Apache 2 Licensed ADE C...
04/30/2025
- 12:10 PM Conversion Tools Support #9919: discuss and define the MVP for the first pass at IDE support
- > Indeed, PDS accepts any extension for include files, but only the @i@, @w@, @p@, @cls@ are subject to syntax checki...
- 07:17 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- > getPersistenceFilename() existed before, but I removed it because I thought it wasn't used.
It is used as @persi... - 06:26 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- > Added getPersistenceFilename() - for conversion, I need to remove it. Maybe using an artifact method ~ getPersisten...
04/29/2025
- 01:51 PM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- Currently, TRPL runs in a single thread. It is well understood that enabling multi-threading would allow TRPL to lev...
- 01:46 PM TRPL Feature #1754 (Rejected): resolve any performance issues with new multi-threaded pattern engine i...
- 10:18 AM Base Language Feature #9436: add built-in OO classes
- > At the moment resolving the proversion at conversion time is broken as it tries to use EnviromentOps.getVersion tha...
- 08:57 AM Conversion Tools Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
- Post this as a diff, please.
- 08:32 AM Conversion Tools Support #9919: discuss and define the MVP for the first pass at IDE support
- In OE, include files do not have to be named @.i@ and procedures do not have to be named @.p@. In fact, it is common...
04/28/2025
- 09:15 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Dănuț Filimon wrote:
> I also have a question, where should fwd_sheet.war be built? It seems that it's missing from ... - 09:14 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- > This doesn't look right.
Correct. We should not use the filesystem during import. - 08:31 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- At runtime, artifacts only should come from the application jar file. We should never be looking in the filesystem.
- 08:28 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Also, make sure we take into consideration that this location can be relative to the main project or to the conversio...
Also available in: Atom