Project

General

Profile

Support #8547

Fix documentation for Non-Standard Save Cache Implementation

Added by Tijs Wickardt about 1 month ago. Updated 4 days ago.

Status:
Review
Priority:
Normal
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:

History

#1 Updated by Tijs Wickardt about 1 month ago

This task is about Non-Standard Save Cache Implementation .
Tijs will do the required changes, Eric needs to check/correct.

#8437-56: Greg Shah wrote:

Tijs Wickardt wrote:

I suggest to do the edits myself, and notify Eric to review the changes.

OK

todo:

Document requested change to Eric F at #3912-55

We changed it to:
save cache complete mscdata to save_cache_mscdata_dummy_output.txt.
which I predict will convert to:
SchemaCheck.run(new character("mscdata"));

Noticed by Ovidiu at #8434-26:

UDFs (generic functions used by FWD queries, also support for WORD indices)

#2 Updated by Tijs Wickardt about 1 month ago

  • Assignee set to Tijs Wickardt
  • Status changed from New to WIP

#3 Updated by Tijs Wickardt about 1 month ago

  • Assignee changed from Tijs Wickardt to Eric Faulhaber
  • % Done changed from 0 to 100
  • Status changed from WIP to Review

Changes to wiki completed.
Eric, please review.

#5 Updated by Eric Faulhaber 11 days ago

Tijs, while I was in the doc for #8653, I reviewed your changes. I updated the UDFs section to point to the existing documentation about these. I also gave some examples of the recommended, "simple" installation approach. I left all of your other examples in place. I assumed they are correct and tested.

As to the SAVE CACHE syntax example, note that in the intro section of the doc, it mentions that the parameters after the logical database name are ignored. The feature was implemented to convert existing instances of SAVE CACHE statements where those last parameters would already be there, but they serve no purpose in FWD's implementation.

That being said, I haven't tested this feature in a while and I'm not set up to easily test it now; however, if one is adding SAVE CACHE statements only for FWD's benefit (as you are within the preprocessor conditional in your example), I think you can safely omit those additional parameters. This merits testing before you change the syntax example in the doc, though.

#6 Updated by Tijs Wickardt 11 days ago

Thank you Eric, I added a small addition to the initial value section. Please review.

#7 Updated by Tijs Wickardt 4 days ago

Eric, the wiki mentions "Such a scan is also done of all mutable databases at server startup" . Reading Ovidiu's release notes, I believe this is no longer true.

Also available in: Atom PDF