FWD

05/03/2024

05:41 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

> > Are you saying code changes are needed? I don't think we expose @com.goldencode.p2j.persist.Record@ in converted... Greg Shah

05:12 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> Greg Shah wrote:
> > Are you saying code changes are needed? I don't think we expose @com.go... Eugenie Lyzenko

04:00 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Are you saying code changes are needed? I don't think we expose @com.goldencode.p2j.persist.Reco... Tomasz Domin

07:58 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> Tomasz Domin wrote:
> > * test customer applications for regression - the most important appl... Eugenie Lyzenko

06:03 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

> A remark - I don't think any of customer application would be ready for Java 17 right away - they most probably nee... Greg Shah

04:52 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> * test customer applications for regression - the most important applications - I guess we nee... Tomasz Domin

05:34 PM User Interface Bug #8673: Deduce the logic behind OE focus management and implement in FWD

I edited it. It should have been @RETURN NO-APPLY <expression>.@. Greg Shah

04:00 PM User Interface Bug #8673: Deduce the logic behind OE focus management and implement in FWD

Thanks, Greg.
One question:
The following two @RETURN <expression>.@ statements look the same:
> * A @RETURN... Vladimir Tsichevski

02:03 PM User Interface Bug #8673: Deduce the logic behind OE focus management and implement in FWD

First, I want to record some of our older documentation:
https://proj.goldencode.com/artifacts/javadoc/latest/api/... Greg Shah

12:21 PM User Interface Bug #8673: Deduce the logic behind OE focus management and implement in FWD

Question to gurus:
A Progress trigger can return a value. If the @NO-APPLY@ is returned, the further event process... Vladimir Tsichevski

10:55 AM Runtime Infrastructure Bug #8206: Logging manager issues

Galya B wrote:
> Vladimir Tsichevski wrote:
> > Log manager initialization fixed in 8206a rev. 15197. Please, revie... Vladimir Tsichevski

09:44 AM Runtime Infrastructure Bug #8206: Logging manager issues

Vladimir Tsichevski wrote:
> Log manager initialization fixed in 8206a rev. 15197. Please, review.
I'm not sure i... Galya B

09:21 AM Runtime Infrastructure Bug #8206 (Review): Logging manager issues

Log manager initialization fixed in 8206a rev. 15197. Please, review. Vladimir Tsichevski

06:29 AM Runtime Infrastructure Bug #8206 (WIP): Logging manager issues

OK, I'll rebase the branch and add the missing change. Vladimir Tsichevski

01:21 AM Runtime Infrastructure Bug #8206: Logging manager issues

Actually Vladimir is better familiar with these issues and has more insight on what needs to be achieved.
Vladimir... Galya B

07:40 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)

Galya B wrote:
> There are some failing tests. Is it the deployment or it's fine?
The failing tests are known failu... Constantin Asofiei

07:28 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces

Marian Edu wrote:
> We have tests for `ParameterList` that are failing for extent parameters used as output/input-ou... Constantin Asofiei

02:13 AM Support #8547: Fix documentation for Non-Standard Save Cache Implementation

Ovidiu Maxiniuc wrote:
> Tijs,
> I do not think that is correct. The phrase from wiki is correct: a full scan is pe... Tijs Wickardt

05/02/2024

07:11 PM Support #8547: Fix documentation for Non-Standard Save Cache Implementation

Tijs,
I do not think that is correct. The phrase from wiki is correct: a full scan is performed at server startup an... Ovidiu Maxiniuc

03:56 PM Database Bug #8593 (Test): H2 performance improvement for table 'truncate by multiplex'

Branch 8593b was merged to trunk rev 15189 and archived. Constantin Asofiei

03:33 PM Database Bug #8593 (Merge Pending): H2 performance improvement for table 'truncate by multiplex'

You can merge to trunk. Greg Shah

03:30 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

8593b passed ETF testing. Constantin Asofiei

01:49 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Code Review Task Branch 8593b.
I do not see anything wrong with the code (r15187-). Ovidiu Maxiniuc

12:47 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Code Review Task Branch 8593b Revision 15179
The @LowLevelSocketImpl@ changes look good.
Eric/Ovidiu: Please lo... Greg Shah

10:49 AM Database Bug #8593 (Internal Test): H2 performance improvement for table 'truncate by multiplex'

Created task branch 8593b from trunk rev 15186. Contains regression fixes (mixed):
* revno: 15190 - Fixed regressi... Constantin Asofiei

03:51 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

You bring up a very good point about using a vt220/320 terminal. They techincally do not support Unicode characters a... Robert Jensen

03:13 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

> 1. The first things to do is to have proper building environment to make correct linking with @NCURSES@ libraries, ... Greg Shah

02:33 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Also I've found Java doc issue:... Eugenie Lyzenko

03:10 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

From Tomasz via email:
You need to add -Djava.locale.providers=SPI,CLDR,COMPAT instead of and put fwdcpi.jar on a ... Constantin Asofiei

01:24 PM Runtime Infrastructure Bug #8206: Logging manager issues

Greg Shah wrote:
> Code Review Task Branch 8206a Revisions 14987 through 14992
> Vladimir/Galya: I understand tha... Vladimir Tsichevski

10:54 AM Runtime Infrastructure Bug #8206: Logging manager issues

With Theodoros gone, this will need to be rebased, tested and merged by someone else. Greg Shah

10:53 AM Runtime Infrastructure Bug #8206 (Internal Test): Logging manager issues

Code Review Task Branch 8206a Revisions 14987 through 14992
I have no objections to the changes.
As far as I kn... Greg Shah

07:55 AM Runtime Infrastructure Bug #7589 (Closed): org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat

Greg Shah

07:52 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat

This can be closed. We've delivered a way to disable the FWD's slf4j impl what was the issue. Galya B

07:48 AM User Interface Bug #8074 (Closed): Preferred UI Theme not selected in web with auto-login and forked sessions

Greg Shah

07:46 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

This can be closed. Galya B

06:32 AM Runtime Infrastructure Feature #8708 (Closed): cleanup of SLF4J

All the reported issues are resolved. Nice! Greg Shah

03:20 AM Runtime Infrastructure Feature #8708 (Test): cleanup of SLF4J

8708a was merged to trunk as rev. 15185 and archived. Galya B

02:27 AM Runtime Infrastructure Feature #8708: cleanup of SLF4J

Galya B wrote:
> Hynek Cihlar wrote:
> > Tested, it looks OK.
>
> Did you find any slf4j message from tika in th... Hynek Cihlar

02:01 AM Runtime Infrastructure Feature #8708: cleanup of SLF4J

Hynek Cihlar wrote:
> Tested, it looks OK.
Did you find any slf4j message from tika in the client log? Galya B

02:53 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces

We have tests for `ParameterList` that are failing for extent parameters used as output/input-output. As it is now th... Marian Edu

05/01/2024

06:55 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

The first results for using Java 17 with big GUI application.
1. Conversion was completed. Build compiled.
2. The... Eugenie Lyzenko

09:27 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Yes, Hotel GUI in SSO mode works in trunk. Embedded mode does have a bug (see #8253) but it is not related to SSO. Greg Shah

09:24 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Galya B wrote:
> Eugenie Lyzenko wrote:
> > Do you have worked @SSO@ enabled @Hotel GUI@ for *Web* client with curr... Eugenie Lyzenko

09:17 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

P.S.S. I use SSO with trunk and testcases every week. Galya B

09:16 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

P.S. SSO is working only for *Web*. And embedded doesn't work without SSO. Galya B

09:15 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Eugenie Lyzenko wrote:
> Do you have worked @SSO@ enabled @Hotel GUI@ for *Web* client with current @FWD@ trunk?
I'... Galya B

09:13 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Galya B wrote:
> Eugenie Lyzenko wrote:
> > This was due to not configured SSO for hotel GUI. I disabled SSO and it... Eugenie Lyzenko

09:05 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Eugenie Lyzenko wrote:
> This was due to not configured SSO for hotel GUI. I disabled SSO and it works now.
Intrigu... Galya B

06:07 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Eugenie Lyzenko wrote:
> > Eugenie Lyzenko wrote:
> > > Roger Borrello wrote:
> > > > Eugenie ... Eugenie Lyzenko

03:43 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Eugenie Lyzenko wrote:
> Eugenie Lyzenko wrote:
> > Roger Borrello wrote:
> > > Eugenie Lyzenko wrote:
> > > > Ha... Greg Shah

10:11 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Eugenie Lyzenko wrote:
> Roger Borrello wrote:
> > Eugenie Lyzenko wrote:
> > > Have you tested @hotel_gui@ with w... Eugenie Lyzenko

08:46 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

OK. To start application with Java 8 we need to add at least the following into @build.gradle@:... Eugenie Lyzenko

08:45 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Roger Borrello wrote:
> Eugenie Lyzenko wrote:
> > Have you tested @hotel_gui@ with web client and Java 8? In my ca... Eugenie Lyzenko

08:41 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Eugenie Lyzenko wrote:
> Have you tested @hotel_gui@ with web client and Java 8? In my case the client session can n... Roger Borrello

05:43 PM User Interface Bug #8673: Deduce the logic behind OE focus management and implement in FWD

h3. Focus data model
*Focus state* consists of the following data:
# @Window.focus@
*Field-level* focused wi... Vladimir Tsichevski

03:44 PM Runtime Infrastructure Feature #8708 (Merge Pending): cleanup of SLF4J

It can merge to trunk. Greg Shah

03:37 PM Runtime Infrastructure Feature #8708: cleanup of SLF4J

Hynek Cihlar wrote:
> There are vulnerabilities in all the previous versions. We should stick to 2.9.x. I'll test if... Hynek Cihlar

03:17 PM Runtime Infrastructure Feature #8708: cleanup of SLF4J

Galya B wrote:
> Greg Shah wrote:
> > What do you mean? Jetty is working on those systems.
>
> The logging is b... Hynek Cihlar

02:28 PM Runtime Infrastructure Feature #8708: cleanup of SLF4J

Greg Shah wrote:
> What do you mean? Jetty is working on those systems.
The logging is broken.
Another way to... Galya B

02:14 PM Runtime Infrastructure Feature #8708: cleanup of SLF4J

What do you mean? Jetty is working on those systems. Greg Shah

02:13 PM Runtime Infrastructure Feature #8708: cleanup of SLF4J

Greg Shah wrote:
> If this breaks the tika code, then we can't merge it because we have a customer using it in real ... Galya B

02:12 PM Runtime Infrastructure Feature #8708: cleanup of SLF4J

If 6692a resolves this, then we may have to wait for it. We are literally trying to get Java 17 into trunk next week... Greg Shah

02:11 PM Runtime Infrastructure Feature #8708: cleanup of SLF4J

If this breaks the tika code, then we can't merge it because we have a customer using it in real life. Greg Shah

01:59 PM Runtime Infrastructure Feature #8708: cleanup of SLF4J

Greg Shah wrote:
> We're sure that the tika parser code we are using doesn't require slf4j?
It uses a new version... Galya B

01:48 PM Runtime Infrastructure Feature #8708: cleanup of SLF4J

We're sure that the tika parser code we are using doesn't require slf4j? Greg Shah

01:38 PM Runtime Infrastructure Feature #8708: cleanup of SLF4J

Can we merge this soon, because it's too annoying? Galya B

10:07 AM Runtime Infrastructure Feature #8708 (Review): cleanup of SLF4J

Galya B

10:07 AM Runtime Infrastructure Feature #8708: cleanup of SLF4J

8708a r15183 based on trunk r15182: remove the transitive dependency of @slf4j-api:2.0.10@ from @tika-core@.
Diff ... Galya B

09:48 AM Runtime Infrastructure Feature #8708 (WIP): cleanup of SLF4J

... Galya B

08:52 AM Runtime Infrastructure Feature #8708: cleanup of SLF4J

Someone did something... wasn't me and this should have never appeared.
This warnings @Class path contains SLF4J b... Galya B

07:56 AM Runtime Infrastructure Feature #8708: cleanup of SLF4J

As of trunk rev 15182, you can see the following.
1. During FWD build, there is this:... Greg Shah

07:43 AM Runtime Infrastructure Feature #8708 (Closed): cleanup of SLF4J

Greg Shah

01:31 PM User Interface Bug #8711: TAB-STOP attribute wrong implementation for RECTANGLE, IMAGE and TEXT widgets

In OE the @TEXT@ widget has the @TAB-STOP@ attribute (despite the official docs say otherwise), and @RECTANGLE@ and @... Vladimir Tsichevski

01:11 PM User Interface Bug #8711 (New): TAB-STOP attribute wrong implementation for RECTANGLE, IMAGE and TEXT widgets

Vladimir Tsichevski

10:42 AM Runtime Infrastructure Bug #8656 (Test): Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

8656a was merged to trunk as rev. 15183 and archived. Galya B

10:29 AM Runtime Infrastructure Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

You can merge to trunk now. Greg Shah

10:11 AM Runtime Infrastructure Bug #8656 (Merge Pending): Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pd...

Hynek Cihlar

09:53 AM Runtime Infrastructure Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

I did a comparison of the original behavior and output and the new one and shared the results in #8656-8. I can do mo... Galya B

09:50 AM Runtime Infrastructure Bug #8656 (Internal Test): Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pd...

Galya B wrote:
> Hynek Cihlar wrote:
> > The code changes remove the zipping part for the split pdfs. Was this part... Hynek Cihlar

08:44 AM Runtime Infrastructure Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

Hynek Cihlar wrote:
> The code changes remove the zipping part for the split pdfs. Was this part of the requirements... Galya B

06:25 AM Runtime Infrastructure Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

Code review 8656a revisions 15156..15159.
The code changes remove the zipping part for the split pdfs. Was this pa... Hynek Cihlar

04:18 AM Runtime Infrastructure Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

Sergey/Hynek: Please review. Greg Shah

01:24 AM Runtime Infrastructure Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

Sergey Ivanovskiy wrote:
> Galya B wrote:
> > A side observation is that the server struggles with such big data wh... Galya B

04/30/2024

07:29 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> Branch @6692a@ has been tested with @hotel_gui@, @hotel_chui@ and standard regression testing ... Eugenie Lyzenko

04:56 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Seems like I have new issue:... Eugenie Lyzenko

03:03 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

I've tried ETF, but a suite gets into an infinite loop, while one passes. This was with Java 8 conversion and Java 1... Constantin Asofiei

01:43 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Branch @6692a@ has been tested with @hotel_gui@, @hotel_chui@ and standard regression testing suite. But it seems tha... Tomasz Domin

01:22 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> Eugenie Lyzenko wrote:
>
> > I'm going to check Java 17 now. Is the code converted with Jav... Eugenie Lyzenko

12:18 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Eugenie Lyzenko wrote:
> I'm going to check Java 17 now. Is the code converted with Java 8 compatible with Java 17... Tomasz Domin

12:15 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> Eugenie Lyzenko wrote:
> > Attempting to use @6692a@ with Java 8 causes exceptions:
> >
> ... Eugenie Lyzenko

12:12 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Eugenie Lyzenko wrote:
> Attempting to use @6692a@ with Java 8 causes exceptions:
>
> [...]
>
> Is it expected... Tomasz Domin

12:01 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Attempting to use @6692a@ with Java 8 causes exceptions:... Eugenie Lyzenko

03:32 PM Runtime Infrastructure Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

Galya B wrote:
> A side observation is that the server struggles with such big data when generating the report (@Rep... Sergey Ivanovskiy

02:29 PM Runtime Infrastructure Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

A side observation is that the server struggles with such big data when generating the report (@ReportsManager.buildR... Galya B

02:24 PM Runtime Infrastructure Bug #8656 (Review): Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pd...

8656a r15159 based on trunk r15156 ready for review.
@jPod@ was originally used only for merging big pdf documents... Galya B

02:15 PM Runtime Infrastructure Bug #8656 (WIP): Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

Galya B

07:57 AM Runtime Infrastructure Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

The @ant report_server@ is related to FWD Analytics and is not related to @ReportServlet@ from our admin console. Th... Greg Shah

07:50 AM Runtime Infrastructure Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

@ant report_server@ gives a lot of errors and eventually fails. Ends up with:... Galya B

05:16 AM Runtime Infrastructure Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

But ReportServlet is from FWD Admin console - for that try admin/test123. Constantin Asofiei

05:15 AM Runtime Infrastructure Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

I assume you've ran the report tasks? The default user is admin and the default password is the app's name as config... Constantin Asofiei

05:04 AM Runtime Infrastructure Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

What is the user / pass for the reporting login in testcases? I tried admin/admin, but I get @socket closed (1011) - ... Galya B

01:49 PM User Interface Bug #8673 (WIP): Deduce the logic behind OE focus management and implement in FWD

When the target is a frame, and there is no focus hint set in this frame (something roughly similar to the @AbstractC... Vladimir Tsichevski

09:12 AM Base Language Feature #6424 (WIP): fill gaps in Java Open Client replacement (appserver client support)

There is one point in @AppServerConnectionPool@ that is bothering me. It's used only by @LegacyJavaAppserverClient@ a... Galya B

08:19 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)

I think we're doing a partial review of the Java client in #8456 and #8661. At least I'm getting familiar with the cl... Galya B

08:49 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Marian, do you have any idea why this test executed as batch in 4GL gives the following result:
> ... Marian Edu

08:24 AM Base Language Feature #6417: cleanup some known items in appserver support

Marian, do you have any idea why this test executed as batch in 4GL gives the following result:... Galya B

08:45 AM Base Language Feature #6407 (Test): name_map.xml improvements

6407a was merged to trunk as rev. 15180 and archived.
Support for reading mappings from multiple name_map.xml file... Galya B

08:27 AM Base Language Feature #6407 (Merge Pending): name_map.xml improvements

6407a can be merged after 8486a. Greg Shah

08:12 AM Base Language Feature #6407: name_map.xml improvements

Greg Shah wrote:
> Constantin: Are there any reasons why this can't be merged to trunk?
No, it can be merged. Constantin Asofiei

08:12 AM Base Language Feature #6407: name_map.xml improvements

Constantin: Are there any reasons why this can't be merged to trunk?
Greg Shah

03:17 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces

Constantin, I'm trying to rerun all tests for method invoke and parameter list but those fails to convert now because... Marian Edu

04/29/2024

04:39 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

The only thing pending for this ticket is #6422-65 Theodoros Theodorou

04:33 PM Runtime Infrastructure Bug #8206 (Review): Logging manager issues

Theodoros Theodorou

03:16 PM Database Bug #8703: NO-UNDO option at DMO must be removed

Super cool if it works.
As I wrote in #8703-6 I agree that "the attribute must be removed from the DMO". Luckily, ... Ovidiu Maxiniuc

02:34 PM Database Bug #8703: NO-UNDO option at DMO must be removed

Ovidiu Maxiniuc wrote:
> Note that this method already exists. We only need to emit the right parameter. And test wh... Constantin Asofiei

02:32 PM Database Bug #8703: NO-UNDO option at DMO must be removed

Constantin Asofiei wrote:
> The @DmoMeta.noUndo@ option needs to be refactored so that it uses the actual temp-table... Ovidiu Maxiniuc

10:59 AM Database Bug #8703: NO-UNDO option at DMO must be removed

Assume you have this test:... Constantin Asofiei

10:51 AM Database Bug #8703 (New): NO-UNDO option at DMO must be removed

Constantin Asofiei

04:56 AM Base Language Feature #6407: name_map.xml improvements

6407a rebased on trunk r15171.
Constantin Asofiei wrote:
> Otherwise, if some testing with customers app works, ... Galya B

02:50 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces

Constantin Asofiei wrote:
> Marian Edu wrote:
> > The code in `p2j.oo` almost exclusively use `returnNormal` and ex... Marian Edu

04/26/2024

11:27 AM Base Language Feature #6407: name_map.xml improvements

Greg Shah wrote:
> Constantin: Are we good to go?
My main concern with Windows was that jar file separator which ne... Constantin Asofiei

11:17 AM Base Language Feature #6407 (Internal Test): name_map.xml improvements

> do I need to make hotel_gui or testcases run on Windows as part of this task
No. The Windows situation will not... Greg Shah

10:38 AM Base Language Feature #6407: name_map.xml improvements

I don't know what's going on now, but the client doesn't even spawn and I can't stop it in the cmd prompt. No errors ... Galya B

08:29 AM Base Language Feature #6407: name_map.xml improvements

OK, the java command for the task @create.db.h2@ exceeds @8191@ chars (the max length of commands in windows) due to ... Galya B

08:00 AM Base Language Feature #6407: name_map.xml improvements

There is an issue with the file separators indeed. It's @\@ on Windows for the jars on the file system, but the resou... Galya B

06:26 AM Base Language Feature #6407: name_map.xml improvements

Galya B wrote:
> Not sure what else to test in Win.
Try the Swing client for Hotel GUI on Windows. Constantin Asofiei

06:25 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> Regarding the @Utils.packageToPath@ change - please check runtime on Windows for i.e. Ho... Galya B

02:37 AM Base Language Feature #6407: name_map.xml improvements

Galya B wrote:
> With or without 6407a I get:
> [...]
>
> Not sure what it means.
There is ambiguity between th... Constantin Asofiei

02:34 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> Galya B wrote:
> > Actually if a dir with name map file is in the classpath the name ma... Galya B

08:55 AM Support #8547: Fix documentation for Non-Standard Save Cache Implementation

Eric, the wiki mentions "Such a scan is also done of all mutable databases at server startup" . Reading Ovidiu's rele... Tijs Wickardt

07:52 AM Database Bug #8593 (Test): H2 performance improvement for table 'truncate by multiplex'

8593a was merged to trunk rev 15169 and archived.
8593a_h2 was merged to fwd-h2 rev 46 and archived. Constantin Asofiei

07:39 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

You can go ahead with the merge of 8593a and 8636g. Greg Shah

02:37 AM Database Bug #8593 (Merge Pending): H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei

02:06 AM Database Bug #8593 (Internal Test): H2 performance improvement for table 'truncate by multiplex'

Yes. I had to upgrade to latest 6667i (after recent rebase), reconvert are set a new baseline. After, I patched @(859... Alexandru Lungu

07:12 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces

Marian Edu wrote:
> The code in `p2j.oo` almost exclusively use `returnNormal` and expect the execution to end there... Constantin Asofiei

07:04 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces

The code in `p2j.oo` almost exclusively use `returnNormal` and expect the execution to end there instead of the `stor... Marian Edu

06:49 AM Base Language Feature #6410 (WIP): implement additional built-in OO classes/interfaces

I have a question on how is the proper way to return a value out of a OO method (really a function block), we've used... Marian Edu

04:40 AM Base Language Feature #8676: ABLUnit assert error messages are different in different OE versions

A quick search on testcases project shows we have 500 asserts on 'not null' error messages, for some tests of #6410 w... Marian Edu

03:57 AM Base Language Feature #8676: ABLUnit assert error messages are different in different OE versions

Greg Shah wrote:
> Marian: Please provide some more details on the specific changes that need to be made. Also, ple... Marian Edu

04/25/2024

07:17 PM Database Bug #8683: SQL operations not saved when session is closed

In a customer application we encountered a case when SQL statements which apparently were executed were not actually ... Ovidiu Maxiniuc

07:04 PM Database Bug #8683 (New): SQL operations not saved when session is closed

Ovidiu Maxiniuc

06:48 PM Database Bug #6492: problems with dynamic queries for meta tables

This particular issue was fixed in 8437b/15175, by qualifying the table name with its database (except for temporary ... Ovidiu Maxiniuc

04:27 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru, please let me know if you managed to run ChUI - I'd like to merge these tomorrow. Constantin Asofiei

05:30 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

You can test them both (8593a + 8636g). I've uploaded fwd-h2 1.46 and 8593a rev 15161 has the change in build.gradle... Constantin Asofiei

05:00 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

> ETF testing passed. Alexandru, if you can run a ChUI regression testing with this and 8363g, please let me know.
... Alexandru Lungu

03:18 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei wrote:
> Alexandru, please review 8593a_h2 rev 49/50 and 8593a rev 15158. I'll need to re-test t... Constantin Asofiei

02:24 PM Base Language Feature #6407: name_map.xml improvements

Galya B wrote:
> Actually if a dir with name map file is in the classpath the name map should have been found in the... Constantin Asofiei

07:53 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> You are correct, at this point, unless the current folder is in the classpath, @ClassLoa... Galya B

07:51 AM Base Language Feature #6407: name_map.xml improvements

With the @classNameExists@ in mind, these changes don't affect conversion. Constantin Asofiei

07:22 AM Base Language Feature #6407: name_map.xml improvements

You are correct, at this point, unless the current folder is in the classpath, @ClassLoader.getSystemResource(sb.toSt... Constantin Asofiei

06:16 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> Galya B wrote:
> > > * @SourceNameMapper@ - @convertJavaProg@ is used during conversion... Galya B

05:32 AM Base Language Feature #6407: name_map.xml improvements

Galya B wrote:
> > * @SourceNameMapper@ - @convertJavaProg@ is used during conversion via @NameMappingWorker.classNa... Constantin Asofiei

05:13 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> Review for 6407a rev 15157:
> * @WebServer@ - please add a history entry
Fixed.
> * @... Galya B

04:01 AM Base Language Feature #6407: name_map.xml improvements

Review for 6407a rev 15157:
* @WebServer@ - please add a history entry
* @Utils.packageToPath@ - this replaces all ... Constantin Asofiei

10:51 AM User Interface Bug #7657: 8-bit character entry problem in ChUI

The @7657a@ updated for review to revision @15163@. Rebased with recent trunk. New revision is @15165@.
This is th... Eugenie Lyzenko

09:21 AM User Interface Bug #7657: 8-bit character entry problem in ChUI

UTF-8 encoding has a variable number of bytes per character. By the way, Java actually uses UTF-16 internally. It can... Robert Jensen

04:24 AM Runtime Infrastructure Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent

Constantin Asofiei wrote:
> Galya, 8383a/15059 does not compile.
The notorious @gradlew all@ doesn't work, while ... Galya B

04:14 AM Runtime Infrastructure Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent

Galya, 8383a/15059 does not compile. Constantin Asofiei

04/24/2024

05:51 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

Created task branch @7657a@ from trunk revision @15162@. Eugenie Lyzenko

04:42 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

Making required code changes to add @ChUI@ terminal support with optional @UTF-8@ characters for input/output.
1. ... Eugenie Lyzenko

05:12 PM Base Language Feature #8676: ABLUnit assert error messages are different in different OE versions

Marian's team has written a large number of ABLUnit tests which relied upon OE (12.x?) error messages from the assert... Greg Shah

05:03 PM Base Language Feature #8676 (New): ABLUnit assert error messages are different in different OE versions

Greg Shah

10:51 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru, please review 8593a_h2 rev 49/50 and 8593a rev 15158. I'll need to re-test these changes. Constantin Asofiei

08:36 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru Lungu wrote:
> This is a huge thing. Removing a batch will make the @MultiplexScanIndex@ quite unstable. I... Constantin Asofiei

08:30 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei wrote:
> I need to double-check for undoable temp-tables. The case I'm thinking is a @empty-temp... Alexandru Lungu

07:45 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru Lungu wrote:
> Oh, the invariant I was talking about is @removed.cardinality == 0@ when killing a multiple... Constantin Asofiei

04:24 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Do you mean that the invariant was broken and now it was fix... Alexandru Lungu

04:10 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru Lungu wrote:
> Do you mean that the invariant was broken and now it was fixed by @clearPrimaryKey@? I unde... Constantin Asofiei

03:46 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei wrote:
> > * @rowCount -= removed.cardinality;@ is something that is theoretical irrelevant. The ... Alexandru Lungu

02:19 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru Lungu wrote:
> The FWD direct-access changes are OK!
> Also, getting rid of the @forceDelete@ is good, bu... Constantin Asofiei

08:56 AM User Interface Bug #8673: Deduce the logic behind OE focus management and implement in FWD

There is a feature related to how OE manages focus I cannot understand.
I wrote the @8376-with-focusable.p@ exampl... Vladimir Tsichevski

08:00 AM User Interface Bug #8673 (WIP): Deduce the logic behind OE focus management and implement in FWD

Vladimir Tsichevski

08:34 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

> To replicate this in Java, we need all *converted* statements to check if there was a time-out or not, so it can ra... Greg Shah

04:30 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Alexandru, the STOP AFTER needs to use a similar mechanism we have for CTRL-C support (which actually raises a STOP c... Constantin Asofiei

04:19 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Eduard and I had a chat yesterday on this task an I took some "thinking" time on my own on this matter:
#4347-6 is... Alexandru Lungu

04/23/2024

04:04 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> > > Also, a question, since I may have missed a detail... are there changes to be made in the @cl... Tomasz Domin

02:47 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

> > Also, a question, since I may have missed a detail... are there changes to be made in the @client.sh@ and/or @ser... Greg Shah

12:30 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Galya B wrote:
> We'll have to revert to cleanup, because the new mechanism of loading will have the default as part... Roger Borrello

11:47 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Roger Borrello wrote:
> Also, a question, since I may have missed a detail... are there changes to be made in the @c... Galya B

11:44 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Galya B wrote:
> But I remembered a few more places that need update. The default @"fwd-slf4j"@ in @ClientBuilderOpt... Roger Borrello

11:30 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

It could be an option if needed later on. For now I think it's not necessary. But I remembered a few more places that... Galya B

11:23 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Galya B wrote:
> OK, just one last clarification: Can you override the service loader with an empty property @-Dslf4... Tomasz Domin

10:35 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Galya B wrote:
> OK, just one last clarification: Can you override the service loader with an empty property @-Dslf4... Galya B

10:21 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

OK, just one last clarification: Can you override the service loader with an empty property @-Dslf4j.provider=@? Galya B

10:19 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Galya B wrote:
> Tomasz, can you test if the property overwrites the service loader? If it works, it should be fine.... Tomasz Domin

08:57 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz, can you test if the property overwrites the service loader? If it works, it should be fine.
Also, to make ... Galya B

08:48 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> I've added @CentralSlf4jProvider@ as service and it seems changes to @server.sh@ are not neede... Galya B

07:27 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Updated the patch, I needed to put a correct name into @build.xml@ Tomasz Domin

07:03 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Galya B wrote:
> From https://www.slf4j.org/faq.html#changesInVersion200
> > In SLF4J 2.0.x and later, during its i... Tomasz Domin

02:15 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> > Attached a patch to @hotel_gui@ to make slf4j2 logging work (basically following property @-Ds... Galya B

03:08 PM Runtime Infrastructure Feature #8651: Centralize inclusion of JS dependencies

> If there is such a case where customers want an embedded mode with a standard front-end, it makes sense to keep the... Greg Shah

02:32 AM Runtime Infrastructure Feature #8651: Centralize inclusion of JS dependencies

Greg Shah wrote:
> Nice analysis!
>
> I'm generally OK with the overall recommendations.
>
> > Decouple @hotel... Galya B

10:47 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

The FWD direct-access changes are OK!
Also, getting rid of the @forceDelete@ is good, but requires extensive testing... Alexandru Lungu

09:11 AM Database Feature #7960: Allow query logs to be collected in a H2 database

Changes are now on branch 7960a, rev 15157.
Regarding your concern: *Make sure that this kind of logging is not happ... Ioana-Cristina Prioteasa

06:28 AM Database Feature #7960: Allow query logs to be collected in a H2 database

Review of 7960a:
* For @P2JLoggingDatabaseHelper@ construct:
** Separate the connection from statement execution:... Alexandru Lungu

06:05 AM Database Feature #7960 (Review): Allow query logs to be collected in a H2 database

Ioana-Cristina Prioteasa

06:05 AM Database Feature #7960 (WIP): Allow query logs to be collected in a H2 database

Ioana-Cristina Prioteasa

06:04 AM Database Feature #7960: Allow query logs to be collected in a H2 database

I added the necessary modifications to support this feature, changes are now on branch 7960a, rev 15156. Ioana-Cristina Prioteasa

04:25 AM Database Feature #7366: improve performance of buffer.fill

Ovidiu Maxiniuc wrote:
> I think I understand the idea: if the same query can be reused for a child buffer, it does ... Constantin Asofiei

04/22/2024

07:23 PM Runtime Infrastructure Feature #8651: Centralize inclusion of JS dependencies

Nice analysis!
I'm generally OK with the overall recommendations.
> Decouple @hotel_gui@ from the server depend... Greg Shah

09:01 AM Runtime Infrastructure Feature #8651: Centralize inclusion of JS dependencies

There are a few places where js is used in FWD:
* On the default login page for Virtual Desktop and Embedded modes: ... Galya B

06:56 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

> Attached a patch to @hotel_gui@ to make slf4j2 logging work (basically following property @-Dslf4j.provider=com.go... Greg Shah

04:38 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

* Rebased to @trunk/15157@
* upgraded com.google.gwt/org.gwtproject dependencies
* reverted org.apache.pdfbox to la... Tomasz Domin

03:09 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> The logging patch looks reasonable. Tomasz: do you have any objections? If not, this should be ... Tomasz Domin

02:31 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

The logging patch looks reasonable. Tomasz: do you have any objections? If not, this should be committed into 6692a... Greg Shah

07:16 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

As for the js dependencies, it seems the reporting server uses the resources from the jar, so they should stay, but a... Galya B

06:40 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Find attached the required changes to fix the logging dependencies and migrate slf4j implementation to version 2. Aft... Galya B

02:25 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

I've noticed a few issues with the logging dependencies:
* @org.slf4j:jcl-over-slf4j:1.7.36@ is replaced by @org.slf... Galya B

03:12 PM Base Language Feature #4347 (WIP): add runtime support for STOP-AFTER block option

Greg Shah

12:48 PM Testing Support #6858 (Closed): rework existing testcases to use ABLUnit

Greg Shah

02:36 AM Testing Support #6858 (Review): rework existing testcases to use ABLUnit

This can be probably closed since all the conversion is actually done, it's just we do not have all the different dat... Marian Edu

12:36 PM Database Feature #7366: improve performance of buffer.fill

Review of 8363g, r15157/8.
I think I understand the idea: if the same query can be reused for a child buffer, it d... Ovidiu Maxiniuc

09:20 AM Database Feature #7366: improve performance of buffer.fill

Eric/Ovidiu: please review 8363g rev 15158. Constantin Asofiei

08:03 AM Database Feature #7366: improve performance of buffer.fill

Changes related to this are in 8363g rev 15158: Allow the query to be reset to its initialization state, so the same ... Constantin Asofiei

09:01 AM Database Bug #7473 (Review): rewrite toString() implementation for Dataset, StaticTempTable and TempTableB...

I modified the code following your advices and managed to implement "getDataAsJson" method for "DataSet" as well.
... Eduard Baciu

02:44 AM Database Bug #8593 (Review): H2 performance improvement for table 'truncate by multiplex'

Created task branch 8593a from trunk rev 15157, with:
* For a NEW temp record which was not flushed and is being del... Constantin Asofiei

04/21/2024

03:50 PM User Interface Bug #8659: FWD has no button click animations

In FWD in Windows 10 theme buttons doesn't react to mouse clicks at all. In 4GL clicking may include color change and... Stanislav Lomany

02:43 PM User Interface Bug #8659 (New): FWD has no button click animations

Stanislav Lomany

04/20/2024

03:32 PM Testing Support #7850: questions and answers about ABLUnit support in FWD

Roger Borrello wrote:
> The @LOAD@ of the ini is supposed to take place on the client. I am getting an NPE reporte... Vladimir Tsichevski

02:48 PM Testing Support #7850: questions and answers about ABLUnit support in FWD

Roger Borrello wrote:
> I get this when the converted test suite (1 test) tries to compile:
> [...]
> The 4GL for ... Vladimir Tsichevski

10:52 AM Testing Support #7850: questions and answers about ABLUnit support in FWD

> Note: there is probably no need to run the client in debug mode, since all unit test code is executed on the server... Greg Shah

11:01 AM User Interface Bug #8353: Fully support stanza INI LOAD/USE/UNLOAD scenarios

> Actually, the fact that @baseKey@ is null should be OK on the client side. It just needs to be a little more protec... Greg Shah

12:11 AM User Interface Bug #8353: Fully support stanza INI LOAD/USE/UNLOAD scenarios

Actually, the fact that @baseKey@ is null should be OK on the client side. It just needs to be a little more protecte... Roger Borrello

05:31 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Previously we used the @UPDATE ... SET _MULTIPLEX = ?@ paired with a @ReversibleBulkDelete@, which was meant to resto... Constantin Asofiei

04/19/2024

07:51 PM User Interface Bug #8353 (WIP): Fully support stanza INI LOAD/USE/UNLOAD scenarios

By changing my test to a procedure, I was able to get it running.
I am finding that @LOAD gIniName DIR gDir.@ resu... Roger Borrello

07:42 PM Testing Support #7850: questions and answers about ABLUnit support in FWD

I was finally able to figure out how to get a test for @stanza_ini@ to run under ABL Unit. I have a single test in th... Roger Borrello

11:27 AM Testing Support #7850: questions and answers about ABLUnit support in FWD

I was attempting to build ABL unit for FWD using @ant -Dtests.module=base_language ablunit-tests-gui@. Is that correc... Roger Borrello

05:31 PM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

Yes, I think this what we need. Some advices:
* do not involve @ErrorManager@ in @toString()@: even if you use it in... Ovidiu Maxiniuc

09:48 AM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

I rewrote toString function for StaticTempTable and TempTableBuilder using a StringBuilder in which i added elements(... Eduard Baciu

10:04 AM Runtime Infrastructure Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

Dependency @de.intarsys.opensource:jPod@ is used only in @ReportServlet.java@ and can be replaced by @org.apache.pdfb... Galya B

10:01 AM Runtime Infrastructure Bug #8656 (Test): Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox

Galya B

07:55 AM Database Bug #8593 (WIP): H2 performance improvement for table 'truncate by multiplex'

Greg Shah

01:49 AM Support #8547: Fix documentation for Non-Standard Save Cache Implementation

Thank you Eric, I added a small addition to the initial value section. Please review. Tijs Wickardt

04/18/2024

06:07 PM Support #8547: Fix documentation for Non-Standard Save Cache Implementation

Tijs, while I was in the doc for #8653, I reviewed your changes. I updated the UDFs section to point to the existing ... Eric Faulhaber

06:44 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)

This is the server log of errors. Galya B

06:11 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> Galya B wrote:
> > The libraries in concern in r15171 are used only by custom front-ends in t... Galya B

05:47 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> Galya B wrote:
> > Greg Shah wrote:
> > > Galya: Please review 6692a revision 15171.
> >
... Galya B

05:28 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Code Review Task Branch 6692a Revision 15171
>
> Although I do like managing the dependencies ... Tomasz Domin

04:53 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Galya B wrote:
> I think this is not related to the current upgrade to java 17. Do you mind to create a new task for... Hynek Cihlar

04:38 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Hynek Cihlar wrote:
> Galya B wrote:
> > Hynek Cihlar wrote:
> > > I agree with the comments from Greg and Galya. ... Galya B

04:37 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Galya B wrote:
> Hynek Cihlar wrote:
> > I agree with the comments from Greg and Galya. Still it makes sense to put... Hynek Cihlar

04:23 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Hynek Cihlar wrote:
> I agree with the comments from Greg and Galya. Still it makes sense to put the dependencies th... Galya B

04:15 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

I agree with the comments from Greg and Galya. Still it makes sense to put the dependencies that are integral part of... Hynek Cihlar

03:28 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Galya: Please review 6692a revision 15171.
@fwd_sdk.js@ is not the right place to load the lib... Galya B

04:53 AM Runtime Infrastructure Feature #8651: Centralize inclusion of JS dependencies

There are specific Java Script dependencies needed for FWD to run in embedded mode. If they are included in a single ... Hynek Cihlar

04:50 AM Runtime Infrastructure Feature #8651 (New): Centralize inclusion of JS dependencies

Hynek Cihlar

04/17/2024

05:24 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Galya: Please review 6692a revision 15171. Greg Shah

05:23 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Code Review Task Branch 6692a Revision 15171
Although I do like managing the dependencies explicitly in our JS cod... Greg Shah

03:42 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Roger Borrello wrote:
> Tomasz Domin wrote:
> > I work with separate images for each supported java version if you... Tomasz Domin

03:34 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> I work with separate images for each supported java version if you remember thats why I neede... Roger Borrello

01:02 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Roger Borrello wrote:
> I have some basic questions, since this task is moving steadily towards implementation. Grea... Tomasz Domin

11:38 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> > Do we need Docker images based off both
>
> Yes
>
> > or do we make a wholesale changeov... Roger Borrello

10:41 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> > OpenJDK or Oracle?
>
> In the code we should not have dependencies on either one.
>
> In ... Roger Borrello

10:23 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

> OpenJDK or Oracle?
In the code we should not have dependencies on either one.
In practive, we tend to use Ope... Greg Shah

10:11 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

I have some basic questions, since this task is moving steadily towards implementation. Great job! These come from my... Roger Borrello

09:01 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Code review 6692a revision 15171. The changes look good. Hynek Cihlar

05:07 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Hynek Cihlar wrote:
> Greg Shah wrote:
> > Hynek: What would you estimate for the effort?
>
> I would say up to ... Tomasz Domin

02:04 PM Runtime Infrastructure Feature #7799: automated vulnerability scanning

A report for FWD @6692a/15172@, there should be less vulnerabilities, but in meantime a new ones has been discovered ... Tomasz Domin

01:49 PM Database Bug #8648: Recheck ACTIVATE and DEACTIVATE procedures on appserver calls

This task is a continuation of 8444d (merged to trunk as rev. 15153) to investigate all @invoke*@ methods from the @A... Alexandru Lungu

01:48 PM Database Bug #8648 (Closed): Recheck ACTIVATE and DEACTIVATE procedures on appserver calls

Alexandru Lungu

09:36 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)

There are some failing tests. Is it the deployment or it's fine? Galya B

09:00 AM Base Language Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

This issue is a continuation of #8614 that involves two problems that need to be solved. I've attached 4 files:
* ra... Dănuț Filimon

08:54 AM Base Language Bug #8643 (Test): ErrorManager not handling caught errors and error-status:error attribute properly

Dănuț Filimon

04/16/2024

11:43 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Hynek Cihlar wrote:
> Greg Shah wrote:
> > Hynek: What would you estimate for the effort?
>
> I would say up to ... Tomasz Domin

08:06 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Hynek: What would you estimate for the effort?
I would say up to two days. The JS dependencies... Hynek Cihlar

07:38 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Hynek: What would you estimate for the effort? Greg Shah

07:28 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> I prefer not to leave old dependencies in the code. On the other hand, I don't want to delay thi... Tomasz Domin

02:05 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Hynek: What do you think?
I like the idea of having the dependencies in @fwd_sdk.js@. Moving t... Hynek Cihlar

04/15/2024

05:47 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

I prefer not to leave old dependencies in the code. On the other hand, I don't want to delay this branch since many ... Greg Shah

03:06 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Rebased 6692a to trunk/15146 and pushed 6692a/15146.
I started to work on JS updates, upgraded with webjars versio... Tomasz Domin

07:03 AM Base Language Feature #6407: name_map.xml improvements

6407a rebased on trunk r15146.
New r15156 with a minor fix for #8166-151. Galya B

02:19 AM Base Language Feature #6407: name_map.xml improvements

Reminder: The branch needs a review (at r15110). It also has minor changes for #8166-145 and #8166-150. Galya B

03:45 AM Runtime Infrastructure Bug #8383 (Review): Some JsonObject methods create a LOG-MANAGER record in silent

Constantin Asofiei wrote:
> Galya, some notes:
> * we need to be careful with naming FWD internal methods added to ... Galya B

04/12/2024

01:51 PM Testing Support #7850: questions and answers about ABLUnit support in FWD

I get this when the converted test suite (1 test) tries to compile:... Roger Borrello

01:45 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

Greg Shah wrote:
> Good work!
>
> Some thoughts:
>
> * We should add a build-time option to control whether th... Eugenie Lyzenko

06:47 AM User Interface Bug #7657: 8-bit character entry problem in ChUI

Good work!
Some thoughts:
* We should add a build-time option to control whether the native module will use wid... Greg Shah

09:33 AM Runtime Infrastructure Bug #8624: Stream should detect whether it is being used from the client or the server

@Stream@ is "dual mode" and is used as a base class for @RemoteStream@ which is used from converted code on the serve... Greg Shah

08:55 AM Runtime Infrastructure Bug #8624: Stream should detect whether it is being used from the client or the server

@Stream.java@ is being used by both the server and the client, however some functions are OS dependent and this is no... Șerban Bursuc

08:47 AM Runtime Infrastructure Bug #8624 (Closed): Stream should detect whether it is being used from the client or the server

Șerban Bursuc

04/11/2024

04:46 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

The news so far.
After experimenting I would like to share some finding at this time. For minimal usage we need to... Eugenie Lyzenko

01:06 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

Greg Shah wrote:
> It must be something pulled over from the Hotel GUI directory. In October 2023, Galya implemente... Eugenie Lyzenko

12:23 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

It must be something pulled over from the Hotel GUI directory. In October 2023, Galya implemented single signon for ... Greg Shah

12:16 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

Guys,
During testing Hotel ChUI with wide chars environment I'm getting the following warning when starting server... Eugenie Lyzenko

03:56 PM Database Bug #8621: better resolution of ambiguous constructors/methods in RuntimeJastInterpreter

The caching mechanism is in place since the early implementation. Since the structure of the JAST in which the constr... Ovidiu Maxiniuc

01:07 PM Database Bug #8621: better resolution of ambiguous constructors/methods in RuntimeJastInterpreter

What we need to implement for method/constructor matching is actually the Java compiler's algorithm for linking the c... Constantin Asofiei

12:59 PM Database Bug #8621: better resolution of ambiguous constructors/methods in RuntimeJastInterpreter

@RuntimeJastInterpreter.findMatchingConstructor@ currently returns @null@ when it finds more than one c'tor whose sig... Eric Faulhaber

12:26 PM Database Bug #8621 (New): better resolution of ambiguous constructors/methods in RuntimeJastInterpreter

Eric Faulhaber

08:47 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Rebased to trunk/15136, pushed into repository 6692/15156
Working on JS libraries updates.
Tomasz Domin

04/10/2024

02:38 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Just a thing that was on my mind and wanted to have it here as well:
For NO-UNDO cases, we used to rollback (trans... Alexandru Lungu

01:25 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru Lungu wrote:
> Eric, even for a sub-transaction. We can simply delete and rollback to savepoint, right?
... Eric Faulhaber

12:04 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Eric, even for a sub-transaction. We can simply delete and rollback to savepoint, right? Alexandru Lungu

11:29 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Greg Shah wrote:
> Seems like a long-standing leak of records. If that built up to a large number, it might be both... Eric Faulhaber

08:52 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Seems like a long-standing leak of records. If that built up to a large number, it might be both a memory leak and a... Greg Shah

07:59 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru Lungu wrote:
> Still, why are we updating with a @<delete-multiplex>@ instead of actually deleting them? I... Eric Faulhaber

07:30 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

> For MultiplexedScanIndex, the target batch in setRow(key, row) is calculated from the record's key (which is not ch... Alexandru Lungu

06:46 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

No, the @empty-temp-table@ is the problem, while executing in a transaction, for an undoable temp-table - this does n... Constantin Asofiei

06:41 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei wrote:
> For an undoable temp-table, a @EMPTY-TEMP-TABLE@ results in a @UPDATE tt1 SET _multiplex... Alexandru Lungu

05:11 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

The recreate is this:
* @mpid1.p@... Constantin Asofiei

03:59 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei wrote:
> Alexandru, the assumption was that the @MultiplexedBatchIndex$Batch@ holds data *only fo... Alexandru Lungu

04/09/2024

01:07 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru, the assumption was that the @MultiplexedBatchIndex$Batch@ holds data *only for a certain multiplex*. This... Constantin Asofiei

10:26 AM Runtime Infrastructure Bug #8607: Incorrect parsing of URI string.

Given the investigation conducted in #8367-15, current implementation of URI parsing should be reconsidered. Eduard Soltan

10:23 AM Runtime Infrastructure Bug #8607 (New): Incorrect parsing of URI string.

Eduard Soltan

04/08/2024

03:40 PM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

@WRITE-JSON@ will always leave the current/working buffer empty when it is finished, causing it content to be eventua... Ovidiu Maxiniuc

02:48 PM Database Bug #7473 (WIP): rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuil...

Ovidiu, are you aware if the @WRITE-JSON@ was finally rewritten without side-effects? Otherwise, Eduard B. can pick i... Alexandru Lungu

10:04 AM User Interface Bug #8598: Frame has no scrollbars

Example:... Vladimir Tsichevski

10:02 AM User Interface Bug #8598 (New): Frame has no scrollbars

Vladimir Tsichevski

05:19 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei wrote:
> You mean the Row.key is not the same as the internal PK?
I mean Row.key to be the same ... Constantin Asofiei

05:15 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

You mean the Row.key is not the same as the internal PK?
Also, there is 'recid' index (with just this column) in H... Constantin Asofiei

04:45 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

> Created task branch 8593a_h2 which improves the @DELETE FROM tt1 WHERE tt1._multiplex = ?@. The reasoning is this:... Alexandru Lungu

03:08 AM Database Bug #8593 (Review): H2 performance improvement for table 'truncate by multiplex'

Created task branch 8593a_h2 which improves the @DELETE FROM tt1 WHERE tt1._multiplex = ?@. The reasoning is this:
... Constantin Asofiei

02:56 AM Database Bug #8593 (Test): H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei

08:34 PM Database Bug #8554 (Test): resolving temp-tables in a class hierarchy

Greg Shah

04/06/2024

01:41 PM Database Bug #8554: resolving temp-tables in a class hierarchy

Branch 8554a was merged into trunk as rev. 15125 and archived. Constantin Asofiei

12:40 PM Database Bug #8554: resolving temp-tables in a class hierarchy

You can merge to trunk now.
Hynek: 8152a can merge after 8554a. Greg Shah

03:15 AM Database Bug #8554 (Merge Pending): resolving temp-tables in a class hierarchy

Ovidiu, I've fixed the visibility in rev 15127 (after rebase).
ETF testing passed. It can be merged to trunk. Constantin Asofiei

04/05/2024

06:11 PM Database Bug #8589: Deprecate the shared temporary database completely

Unless there is a _significant_ memory savings or some other substantial advantage of shared mode, I think we should ... Eric Faulhaber

03:45 AM Database Bug #8589: Deprecate the shared temporary database completely

In the original support for _temp database, one single in-memory database was created. All sessions used that single ... Alexandru Lungu

03:05 AM Database Bug #8589 (New): Deprecate the shared temporary database completely

Alexandru Lungu

04/04/2024

06:39 PM Database Bug #8554: resolving temp-tables in a class hierarchy

Review of 8554a, r15120-15122.
I am OK with the code. I'm sorry I made a mess with condition codes which do and do... Ovidiu Maxiniuc

04:21 PM Database Bug #8554: resolving temp-tables in a class hierarchy

Ovidiu, please review this, I'll get ETF testing tomorrow and if is OK, I'd like to merge this tomorrow. Constantin Asofiei

07:41 AM Database Bug #8554 (Review): resolving temp-tables in a class hierarchy

15122 fixes some issues, javadocs and some errors which must not set ERROR-STATUS:ERROR. This can be reviewed.
I'... Constantin Asofiei

05:31 AM Database Bug #8554 (WIP): resolving temp-tables in a class hierarchy

Created task branch 8554a from trunk rev 15119.
15120 and 15121 has a rough fix for this - need to validate it. Constantin Asofiei

05:26 PM Base Language Bug #8579 (Test): Unit and OEUnit conversion: ignore annotations from other framework

Greg Shah

05:21 PM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework

Greg Shah wrote:
> You can merge 8579a to trunk now.
Done. Rev. 15123. Vladimir Tsichevski

04:23 PM Base Language Bug #8579 (Merge Pending): Unit and OEUnit conversion: ignore annotations from other framework

You can merge 8579a to trunk now. Greg Shah

01:14 PM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework

Greg Shah wrote:
> Code Review Task Branch 8579a Revision 15121
>
> The change is good.
>
> What additional te... Vladimir Tsichevski

12:58 PM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework

Code Review Task Branch 8579a Revision 15121
The change is good.
What additional testing is needed? Greg Shah

11:20 AM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework

Greg Shah wrote:
> Code Review Task Branch 8579a Revision 15120
>
> I think the code would be simpler and easier ... Vladimir Tsichevski

12:12 PM Base Language Feature #6407: name_map.xml improvements

I did replace the @Set@ with @List@ in r15108.
Tomorrow I'm testing again in testcases. A good list of different p... Galya B

11:45 AM Base Language Feature #6407: name_map.xml improvements

@MultiClassLoader@:... Galya B

11:43 AM Base Language Feature #6407: name_map.xml improvements

So what I'm saying is that there is no classpath order in my humble opinion. Iterating HashMap is not ordered. Galya B

11:39 AM Base Language Feature #6407: name_map.xml improvements

Greg Shah wrote:
> > > @MultiClassLoader@ finds the class by iterating @HashSet@.
> > Actually it's a collection, ... Galya B

11:32 AM Base Language Feature #6407: name_map.xml improvements

> > @MultiClassLoader@ finds the class by iterating @HashSet@.
> Actually it's a collection, backed by the @HashMap... Greg Shah

11:20 AM Base Language Feature #6407 (Review): name_map.xml improvements

6407a r15107 based on trunk r15101 ready for review: adds support for reading mappings from multiple name_map.xml fil... Galya B

09:57 AM Base Language Feature #6407: name_map.xml improvements

Galya B wrote:
> @MultiClassLoader@ finds the class by iterating @HashSet@.
Actually it's a collection, backed by ... Galya B

09:42 AM Base Language Feature #6407: name_map.xml improvements

We can rework it to iterate jars alphabetically. Galya B

09:39 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> My understanding is that JVM keeps the same order of jars as defined in classpath (it do... Galya B

09:37 AM Base Language Feature #6407: name_map.xml improvements

Galya B wrote:
> Greg Shah wrote:
> > Do we really need an explicit list of precedence order? Why not implicitly t... Constantin Asofiei

09:29 AM Base Language Feature #6407: name_map.xml improvements

Greg Shah wrote:
> Do we really need an explicit list of precedence order? Why not implicitly take it from the clas... Galya B

09:28 AM Base Language Feature #6407: name_map.xml improvements

Do we really need an explicit list of precedence order? Why not implicitly take it from the classpath and honor the ... Greg Shah

09:21 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> From what you posted in #6407-56, only one concern: the granularity for the precedence o... Galya B

05:45 AM Base Language Feature #6407: name_map.xml improvements

From what you posted in #6407-56, only one concern: the granularity for the precedence order I think needs to be "thi... Constantin Asofiei

04:39 AM Base Language Feature #6407: name_map.xml improvements

P.S. The previous comment got updated. Galya B

04:36 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> And I think I understand now Greg's point about the .r and folder deploy in OpenEdge:
>... Galya B

09:09 AM User Interface Bug #8586: Fields are not in FIELD-GROUP until they are enabled

The program:... Vladimir Tsichevski

09:02 AM User Interface Bug #8586 (Test): Fields are not in FIELD-GROUP until they are enabled

Vladimir Tsichevski