Project

General

Profile

Activity

From 03/28/2024 to 04/26/2024

04/26/2024

11:27 AM Base Language Feature #6407: name_map.xml improvements
Greg Shah wrote:
> Constantin: Are we good to go?
My main concern with Windows was that jar file separator which ne...
Constantin Asofiei
11:17 AM Base Language Feature #6407 (Internal Test): name_map.xml improvements
> do I need to make hotel_gui or testcases run on Windows as part of this task
No. The Windows situation will not...
Greg Shah
10:38 AM Base Language Feature #6407: name_map.xml improvements
I don't know what's going on now, but the client doesn't even spawn and I can't stop it in the cmd prompt. No errors ... Galya B
08:29 AM Base Language Feature #6407: name_map.xml improvements
OK, the java command for the task @create.db.h2@ exceeds @8191@ chars (the max length of commands in windows) due to ... Galya B
08:00 AM Base Language Feature #6407: name_map.xml improvements
There is an issue with the file separators indeed. It's @\@ on Windows for the jars on the file system, but the resou... Galya B
06:26 AM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> Not sure what else to test in Win.
Try the Swing client for Hotel GUI on Windows.
Constantin Asofiei
06:25 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> Regarding the @Utils.packageToPath@ change - please check runtime on Windows for i.e. Ho...
Galya B
02:37 AM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> With or without 6407a I get:
> [...]
>
> Not sure what it means.
There is ambiguity between th...
Constantin Asofiei
02:34 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> Galya B wrote:
> > Actually if a dir with name map file is in the classpath the name ma...
Galya B
08:55 AM Support #8547: Fix documentation for Non-Standard Save Cache Implementation
Eric, the wiki mentions "Such a scan is also done of all mutable databases at server startup" . Reading Ovidiu's rele... Tijs Wickardt
07:52 AM Database Bug #8593 (Test): H2 performance improvement for table 'truncate by multiplex'
8593a was merged to trunk rev 15169 and archived.
8593a_h2 was merged to fwd-h2 rev 46 and archived.
Constantin Asofiei
07:39 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
You can go ahead with the merge of 8593a and 8636g. Greg Shah
02:37 AM Database Bug #8593 (Merge Pending): H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei
02:06 AM Database Bug #8593 (Internal Test): H2 performance improvement for table 'truncate by multiplex'
Yes. I had to upgrade to latest 6667i (after recent rebase), reconvert are set a new baseline. After, I patched @(859... Alexandru Lungu
07:12 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Marian Edu wrote:
> The code in `p2j.oo` almost exclusively use `returnNormal` and expect the execution to end there...
Constantin Asofiei
07:04 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
The code in `p2j.oo` almost exclusively use `returnNormal` and expect the execution to end there instead of the `stor... Marian Edu
06:49 AM Base Language Feature #6410 (WIP): implement additional built-in OO classes/interfaces
I have a question on how is the proper way to return a value out of a OO method (really a function block), we've used... Marian Edu
04:40 AM Base Language Feature #8676: ABLUnit assert error messages are different in different OE versions
A quick search on testcases project shows we have 500 asserts on 'not null' error messages, for some tests of #6410 w... Marian Edu
03:57 AM Base Language Feature #8676: ABLUnit assert error messages are different in different OE versions
Greg Shah wrote:
> Marian: Please provide some more details on the specific changes that need to be made. Also, ple...
Marian Edu

04/25/2024

07:17 PM Database Bug #8683: SQL operations not saved when session is closed
In a customer application we encountered a case when SQL statements which apparently were executed were not actually ... Ovidiu Maxiniuc
07:04 PM Database Bug #8683 (New): SQL operations not saved when session is closed
Ovidiu Maxiniuc
06:48 PM Database Bug #6492: problems with dynamic queries for meta tables
This particular issue was fixed in 8437b/15175, by qualifying the table name with its database (except for temporary ... Ovidiu Maxiniuc
04:27 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru, please let me know if you managed to run ChUI - I'd like to merge these tomorrow. Constantin Asofiei
05:30 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
You can test them both (8593a + 8636g). I've uploaded fwd-h2 1.46 and 8593a rev 15161 has the change in build.gradle... Constantin Asofiei
05:00 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
> ETF testing passed. Alexandru, if you can run a ChUI regression testing with this and 8363g, please let me know.
...
Alexandru Lungu
03:18 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei wrote:
> Alexandru, please review 8593a_h2 rev 49/50 and 8593a rev 15158. I'll need to re-test t...
Constantin Asofiei
02:24 PM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> Actually if a dir with name map file is in the classpath the name map should have been found in the...
Constantin Asofiei
07:53 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> You are correct, at this point, unless the current folder is in the classpath, @ClassLoa...
Galya B
07:51 AM Base Language Feature #6407: name_map.xml improvements
With the @classNameExists@ in mind, these changes don't affect conversion. Constantin Asofiei
07:22 AM Base Language Feature #6407: name_map.xml improvements
You are correct, at this point, unless the current folder is in the classpath, @ClassLoader.getSystemResource(sb.toSt... Constantin Asofiei
06:16 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> Galya B wrote:
> > > * @SourceNameMapper@ - @convertJavaProg@ is used during conversion...
Galya B
05:32 AM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> > * @SourceNameMapper@ - @convertJavaProg@ is used during conversion via @NameMappingWorker.classNa...
Constantin Asofiei
05:13 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> Review for 6407a rev 15157:
> * @WebServer@ - please add a history entry
Fixed.
> * @...
Galya B
04:01 AM Base Language Feature #6407: name_map.xml improvements
Review for 6407a rev 15157:
* @WebServer@ - please add a history entry
* @Utils.packageToPath@ - this replaces all ...
Constantin Asofiei
10:51 AM User Interface Bug #7657: 8-bit character entry problem in ChUI
The @7657a@ updated for review to revision @15163@. Rebased with recent trunk. New revision is @15165@.
This is th...
Eugenie Lyzenko
09:21 AM User Interface Bug #7657: 8-bit character entry problem in ChUI
UTF-8 encoding has a variable number of bytes per character. By the way, Java actually uses UTF-16 internally. It can... Robert Jensen
04:24 AM Runtime Infrastructure Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent
Constantin Asofiei wrote:
> Galya, 8383a/15059 does not compile.
The notorious @gradlew all@ doesn't work, while ...
Galya B
04:14 AM Runtime Infrastructure Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent
Galya, 8383a/15059 does not compile. Constantin Asofiei

04/24/2024

05:51 PM User Interface Bug #7657: 8-bit character entry problem in ChUI
Created task branch @7657a@ from trunk revision @15162@. Eugenie Lyzenko
04:42 PM User Interface Bug #7657: 8-bit character entry problem in ChUI
Making required code changes to add @ChUI@ terminal support with optional @UTF-8@ characters for input/output.
1. ...
Eugenie Lyzenko
05:12 PM Base Language Feature #8676: ABLUnit assert error messages are different in different OE versions
Marian's team has written a large number of ABLUnit tests which relied upon OE (12.x?) error messages from the assert... Greg Shah
05:03 PM Base Language Feature #8676 (New): ABLUnit assert error messages are different in different OE versions
Greg Shah
10:51 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru, please review 8593a_h2 rev 49/50 and 8593a rev 15158. I'll need to re-test these changes. Constantin Asofiei
08:36 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru Lungu wrote:
> This is a huge thing. Removing a batch will make the @MultiplexScanIndex@ quite unstable. I...
Constantin Asofiei
08:30 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei wrote:
> I need to double-check for undoable temp-tables. The case I'm thinking is a @empty-temp...
Alexandru Lungu
07:45 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru Lungu wrote:
> Oh, the invariant I was talking about is @removed.cardinality == 0@ when killing a multiple...
Constantin Asofiei
04:24 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Do you mean that the invariant was broken and now it was fix...
Alexandru Lungu
04:10 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru Lungu wrote:
> Do you mean that the invariant was broken and now it was fixed by @clearPrimaryKey@? I unde...
Constantin Asofiei
03:46 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei wrote:
> > * @rowCount -= removed.cardinality;@ is something that is theoretical irrelevant. The ...
Alexandru Lungu
02:19 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru Lungu wrote:
> The FWD direct-access changes are OK!
> Also, getting rid of the @forceDelete@ is good, bu...
Constantin Asofiei
08:56 AM User Interface Bug #8673: Deduce the logic behind OE focus management and implement in FWD
There is a feature related to how OE manages focus I cannot understand.
I wrote the @8376-with-focusable.p@ exampl...
Vladimir Tsichevski
08:00 AM User Interface Bug #8673 (WIP): Deduce the logic behind OE focus management and implement in FWD
Vladimir Tsichevski
08:34 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option
> To replicate this in Java, we need all *converted* statements to check if there was a time-out or not, so it can ra... Greg Shah
04:30 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option
Alexandru, the STOP AFTER needs to use a similar mechanism we have for CTRL-C support (which actually raises a STOP c... Constantin Asofiei
04:19 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option
Eduard and I had a chat yesterday on this task an I took some "thinking" time on my own on this matter:
#4347-6 is...
Alexandru Lungu

04/23/2024

04:04 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Greg Shah wrote:
> > > Also, a question, since I may have missed a detail... are there changes to be made in the @cl...
Tomasz Domin
02:47 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
> > Also, a question, since I may have missed a detail... are there changes to be made in the @client.sh@ and/or @ser... Greg Shah
12:30 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Galya B wrote:
> We'll have to revert to cleanup, because the new mechanism of loading will have the default as part...
Roger Borrello
11:47 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Roger Borrello wrote:
> Also, a question, since I may have missed a detail... are there changes to be made in the @c...
Galya B
11:44 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Galya B wrote:
> But I remembered a few more places that need update. The default @"fwd-slf4j"@ in @ClientBuilderOpt...
Roger Borrello
11:30 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
It could be an option if needed later on. For now I think it's not necessary. But I remembered a few more places that... Galya B
11:23 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Galya B wrote:
> OK, just one last clarification: Can you override the service loader with an empty property @-Dslf4...
Tomasz Domin
10:35 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Galya B wrote:
> OK, just one last clarification: Can you override the service loader with an empty property @-Dslf4...
Galya B
10:21 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
OK, just one last clarification: Can you override the service loader with an empty property @-Dslf4j.provider=@? Galya B
10:19 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Galya B wrote:
> Tomasz, can you test if the property overwrites the service loader? If it works, it should be fine....
Tomasz Domin
08:57 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Tomasz, can you test if the property overwrites the service loader? If it works, it should be fine.
Also, to make ...
Galya B
08:48 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> I've added @CentralSlf4jProvider@ as service and it seems changes to @server.sh@ are not neede...
Galya B
07:27 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Updated the patch, I needed to put a correct name into @build.xml@ Tomasz Domin
07:03 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Galya B wrote:
> From https://www.slf4j.org/faq.html#changesInVersion200
> > In SLF4J 2.0.x and later, during its i...
Tomasz Domin
02:15 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Greg Shah wrote:
> > Attached a patch to @hotel_gui@ to make slf4j2 logging work (basically following property @-Ds...
Galya B
03:08 PM Runtime Infrastructure Feature #8651: Centralize inclusion of JS dependencies
> If there is such a case where customers want an embedded mode with a standard front-end, it makes sense to keep the... Greg Shah
02:32 AM Runtime Infrastructure Feature #8651: Centralize inclusion of JS dependencies
Greg Shah wrote:
> Nice analysis!
>
> I'm generally OK with the overall recommendations.
>
> > Decouple @hotel...
Galya B
10:47 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
The FWD direct-access changes are OK!
Also, getting rid of the @forceDelete@ is good, but requires extensive testing...
Alexandru Lungu
09:11 AM Database Feature #7960: Allow query logs to be collected in a H2 database
Changes are now on branch 7960a, rev 15157.
Regarding your concern: *Make sure that this kind of logging is not happ...
Ioana-Cristina Prioteasa
06:28 AM Database Feature #7960: Allow query logs to be collected in a H2 database
Review of 7960a:
* For @P2JLoggingDatabaseHelper@ construct:
** Separate the connection from statement execution:...
Alexandru Lungu
06:05 AM Database Feature #7960 (Review): Allow query logs to be collected in a H2 database
Ioana-Cristina Prioteasa
06:05 AM Database Feature #7960 (WIP): Allow query logs to be collected in a H2 database
Ioana-Cristina Prioteasa
06:04 AM Database Feature #7960: Allow query logs to be collected in a H2 database
I added the necessary modifications to support this feature, changes are now on branch 7960a, rev 15156. Ioana-Cristina Prioteasa
04:25 AM Database Feature #7366: improve performance of buffer.fill
Ovidiu Maxiniuc wrote:
> I think I understand the idea: if the same query can be reused for a child buffer, it does ...
Constantin Asofiei

04/22/2024

07:23 PM Runtime Infrastructure Feature #8651: Centralize inclusion of JS dependencies
Nice analysis!
I'm generally OK with the overall recommendations.
> Decouple @hotel_gui@ from the server depend...
Greg Shah
09:01 AM Runtime Infrastructure Feature #8651: Centralize inclusion of JS dependencies
There are a few places where js is used in FWD:
* On the default login page for Virtual Desktop and Embedded modes: ...
Galya B
06:56 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
> Attached a patch to @hotel_gui@ to make slf4j2 logging work (basically following property @-Dslf4j.provider=com.go... Greg Shah
04:38 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
* Rebased to @trunk/15157@
* upgraded com.google.gwt/org.gwtproject dependencies
* reverted org.apache.pdfbox to la...
Tomasz Domin
03:09 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Greg Shah wrote:
> The logging patch looks reasonable. Tomasz: do you have any objections? If not, this should be ...
Tomasz Domin
02:31 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
The logging patch looks reasonable. Tomasz: do you have any objections? If not, this should be committed into 6692a... Greg Shah
07:16 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
As for the js dependencies, it seems the reporting server uses the resources from the jar, so they should stay, but a... Galya B
06:40 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Find attached the required changes to fix the logging dependencies and migrate slf4j implementation to version 2. Aft... Galya B
02:25 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
I've noticed a few issues with the logging dependencies:
* @org.slf4j:jcl-over-slf4j:1.7.36@ is replaced by @org.slf...
Galya B
03:12 PM Base Language Feature #4347 (WIP): add runtime support for STOP-AFTER block option
Greg Shah
12:48 PM Testing Support #6858 (Closed): rework existing testcases to use ABLUnit
Greg Shah
02:36 AM Testing Support #6858 (Review): rework existing testcases to use ABLUnit
This can be probably closed since all the conversion is actually done, it's just we do not have all the different dat... Marian Edu
12:36 PM Database Feature #7366: improve performance of buffer.fill
Review of 8363g, r15157/8.
I think I understand the idea: if the same query can be reused for a child buffer, it d...
Ovidiu Maxiniuc
09:20 AM Database Feature #7366: improve performance of buffer.fill
Eric/Ovidiu: please review 8363g rev 15158. Constantin Asofiei
08:03 AM Database Feature #7366: improve performance of buffer.fill
Changes related to this are in 8363g rev 15158: Allow the query to be reset to its initialization state, so the same ... Constantin Asofiei
09:01 AM Database Bug #7473 (Review): rewrite toString() implementation for Dataset, StaticTempTable and TempTableB...
I modified the code following your advices and managed to implement "getDataAsJson" method for "DataSet" as well.
...
Eduard Baciu
02:44 AM Database Bug #8593 (Review): H2 performance improvement for table 'truncate by multiplex'
Created task branch 8593a from trunk rev 15157, with:
* For a NEW temp record which was not flushed and is being del...
Constantin Asofiei

04/21/2024

03:50 PM User Interface Bug #8659: FWD has no button click animations
In FWD in Windows 10 theme buttons doesn't react to mouse clicks at all. In 4GL clicking may include color change and... Stanislav Lomany
02:43 PM User Interface Bug #8659 (New): FWD has no button click animations
Stanislav Lomany

04/20/2024

03:32 PM Testing Support #7850: questions and answers about ABLUnit support in FWD
Roger Borrello wrote:
> The @LOAD@ of the ini is supposed to take place on the client. I am getting an NPE reporte...
Vladimir Tsichevski
02:48 PM Testing Support #7850: questions and answers about ABLUnit support in FWD
Roger Borrello wrote:
> I get this when the converted test suite (1 test) tries to compile:
> [...]
> The 4GL for ...
Vladimir Tsichevski
10:52 AM Testing Support #7850: questions and answers about ABLUnit support in FWD
> Note: there is probably no need to run the client in debug mode, since all unit test code is executed on the server... Greg Shah
11:01 AM User Interface Bug #8353: Fully support stanza INI LOAD/USE/UNLOAD scenarios
> Actually, the fact that @baseKey@ is null should be OK on the client side. It just needs to be a little more protec... Greg Shah
12:11 AM User Interface Bug #8353: Fully support stanza INI LOAD/USE/UNLOAD scenarios
Actually, the fact that @baseKey@ is null should be OK on the client side. It just needs to be a little more protecte... Roger Borrello
05:31 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Previously we used the @UPDATE ... SET _MULTIPLEX = ?@ paired with a @ReversibleBulkDelete@, which was meant to resto... Constantin Asofiei

04/19/2024

07:51 PM User Interface Bug #8353 (WIP): Fully support stanza INI LOAD/USE/UNLOAD scenarios
By changing my test to a procedure, I was able to get it running.
I am finding that @LOAD gIniName DIR gDir.@ resu...
Roger Borrello
07:42 PM Testing Support #7850: questions and answers about ABLUnit support in FWD
I was finally able to figure out how to get a test for @stanza_ini@ to run under ABL Unit. I have a single test in th... Roger Borrello
11:27 AM Testing Support #7850: questions and answers about ABLUnit support in FWD
I was attempting to build ABL unit for FWD using @ant -Dtests.module=base_language ablunit-tests-gui@. Is that correc... Roger Borrello
05:31 PM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...
Yes, I think this what we need. Some advices:
* do not involve @ErrorManager@ in @toString()@: even if you use it in...
Ovidiu Maxiniuc
09:48 AM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...
I rewrote toString function for StaticTempTable and TempTableBuilder using a StringBuilder in which i added elements(... Eduard Baciu
10:04 AM Runtime Infrastructure Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
Dependency @de.intarsys.opensource:jPod@ is used only in @ReportServlet.java@ and can be replaced by @org.apache.pdfb... Galya B
10:01 AM Runtime Infrastructure Bug #8656 (Test): Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
Galya B
07:55 AM Database Bug #8593 (WIP): H2 performance improvement for table 'truncate by multiplex'
Greg Shah
01:49 AM Support #8547: Fix documentation for Non-Standard Save Cache Implementation
Thank you Eric, I added a small addition to the initial value section. Please review. Tijs Wickardt

04/18/2024

06:07 PM Support #8547: Fix documentation for Non-Standard Save Cache Implementation
Tijs, while I was in the doc for #8653, I reviewed your changes. I updated the UDFs section to point to the existing ... Eric Faulhaber
06:44 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)
This is the server log of errors. Galya B
06:11 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> Galya B wrote:
> > The libraries in concern in r15171 are used only by custom front-ends in t...
Galya B
05:47 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> Galya B wrote:
> > Greg Shah wrote:
> > > Galya: Please review 6692a revision 15171.
> >
...
Galya B
05:28 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Greg Shah wrote:
> Code Review Task Branch 6692a Revision 15171
>
> Although I do like managing the dependencies ...
Tomasz Domin
04:53 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Galya B wrote:
> I think this is not related to the current upgrade to java 17. Do you mind to create a new task for...
Hynek Cihlar
04:38 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Hynek Cihlar wrote:
> Galya B wrote:
> > Hynek Cihlar wrote:
> > > I agree with the comments from Greg and Galya. ...
Galya B
04:37 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Galya B wrote:
> Hynek Cihlar wrote:
> > I agree with the comments from Greg and Galya. Still it makes sense to put...
Hynek Cihlar
04:23 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Hynek Cihlar wrote:
> I agree with the comments from Greg and Galya. Still it makes sense to put the dependencies th...
Galya B
04:15 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
I agree with the comments from Greg and Galya. Still it makes sense to put the dependencies that are integral part of... Hynek Cihlar
03:28 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Greg Shah wrote:
> Galya: Please review 6692a revision 15171.
@fwd_sdk.js@ is not the right place to load the lib...
Galya B
04:53 AM Runtime Infrastructure Feature #8651: Centralize inclusion of JS dependencies
There are specific Java Script dependencies needed for FWD to run in embedded mode. If they are included in a single ... Hynek Cihlar
04:50 AM Runtime Infrastructure Feature #8651 (New): Centralize inclusion of JS dependencies
Hynek Cihlar

04/17/2024

05:24 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Galya: Please review 6692a revision 15171. Greg Shah
05:23 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Code Review Task Branch 6692a Revision 15171
Although I do like managing the dependencies explicitly in our JS cod...
Greg Shah
03:42 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Roger Borrello wrote:
> Tomasz Domin wrote:
> > I work with separate images for each supported java version if you...
Tomasz Domin
03:34 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> I work with separate images for each supported java version if you remember thats why I neede...
Roger Borrello
01:02 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Roger Borrello wrote:
> I have some basic questions, since this task is moving steadily towards implementation. Grea...
Tomasz Domin
11:38 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Greg Shah wrote:
> > Do we need Docker images based off both
>
> Yes
>
> > or do we make a wholesale changeov...
Roger Borrello
10:41 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Greg Shah wrote:
> > OpenJDK or Oracle?
>
> In the code we should not have dependencies on either one.
>
> In ...
Roger Borrello
10:23 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
> OpenJDK or Oracle?
In the code we should not have dependencies on either one.
In practive, we tend to use Ope...
Greg Shah
10:11 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
I have some basic questions, since this task is moving steadily towards implementation. Great job! These come from my... Roger Borrello
09:01 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Code review 6692a revision 15171. The changes look good. Hynek Cihlar
05:07 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Hynek Cihlar wrote:
> Greg Shah wrote:
> > Hynek: What would you estimate for the effort?
>
> I would say up to ...
Tomasz Domin
02:04 PM Runtime Infrastructure Feature #7799: automated vulnerability scanning
A report for FWD @6692a/15172@, there should be less vulnerabilities, but in meantime a new ones has been discovered ... Tomasz Domin
01:49 PM Database Bug #8648: Recheck ACTIVATE and DEACTIVATE procedures on appserver calls
This task is a continuation of 8444d (merged to trunk as rev. 15153) to investigate all @invoke*@ methods from the @A... Alexandru Lungu
01:48 PM Database Bug #8648 (Closed): Recheck ACTIVATE and DEACTIVATE procedures on appserver calls
Alexandru Lungu
09:36 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)
There are some failing tests. Is it the deployment or it's fine? Galya B
09:00 AM Base Language Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly
This issue is a continuation of #8614 that involves two problems that need to be solved. I've attached 4 files:
* ra...
Dănuț Filimon
08:54 AM Base Language Bug #8643 (Test): ErrorManager not handling caught errors and error-status:error attribute properly
Dănuț Filimon

04/16/2024

11:43 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Hynek Cihlar wrote:
> Greg Shah wrote:
> > Hynek: What would you estimate for the effort?
>
> I would say up to ...
Tomasz Domin
08:06 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Greg Shah wrote:
> Hynek: What would you estimate for the effort?
I would say up to two days. The JS dependencies...
Hynek Cihlar
07:38 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Hynek: What would you estimate for the effort? Greg Shah
07:28 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Greg Shah wrote:
> I prefer not to leave old dependencies in the code. On the other hand, I don't want to delay thi...
Tomasz Domin
02:05 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Greg Shah wrote:
> Hynek: What do you think?
I like the idea of having the dependencies in @fwd_sdk.js@. Moving t...
Hynek Cihlar

04/15/2024

05:47 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
I prefer not to leave old dependencies in the code. On the other hand, I don't want to delay this branch since many ... Greg Shah
03:06 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Rebased 6692a to trunk/15146 and pushed 6692a/15146.
I started to work on JS updates, upgraded with webjars versio...
Tomasz Domin
07:03 AM Base Language Feature #6407: name_map.xml improvements
6407a rebased on trunk r15146.
New r15156 with a minor fix for #8166-151.
Galya B
02:19 AM Base Language Feature #6407: name_map.xml improvements
Reminder: The branch needs a review (at r15110). It also has minor changes for #8166-145 and #8166-150. Galya B
03:45 AM Runtime Infrastructure Bug #8383 (Review): Some JsonObject methods create a LOG-MANAGER record in silent
Constantin Asofiei wrote:
> Galya, some notes:
> * we need to be careful with naming FWD internal methods added to ...
Galya B

04/12/2024

01:51 PM Testing Support #7850: questions and answers about ABLUnit support in FWD
I get this when the converted test suite (1 test) tries to compile:... Roger Borrello
01:45 PM User Interface Bug #7657: 8-bit character entry problem in ChUI
Greg Shah wrote:
> Good work!
>
> Some thoughts:
>
> * We should add a build-time option to control whether th...
Eugenie Lyzenko
06:47 AM User Interface Bug #7657: 8-bit character entry problem in ChUI
Good work!
Some thoughts:
* We should add a build-time option to control whether the native module will use wid...
Greg Shah
09:33 AM Runtime Infrastructure Bug #8624: Stream should detect whether it is being used from the client or the server
@Stream@ is "dual mode" and is used as a base class for @RemoteStream@ which is used from converted code on the serve... Greg Shah
08:55 AM Runtime Infrastructure Bug #8624: Stream should detect whether it is being used from the client or the server
@Stream.java@ is being used by both the server and the client, however some functions are OS dependent and this is no... Șerban Bursuc
08:47 AM Runtime Infrastructure Bug #8624 (Closed): Stream should detect whether it is being used from the client or the server
Șerban Bursuc

04/11/2024

04:46 PM User Interface Bug #7657: 8-bit character entry problem in ChUI
The news so far.
After experimenting I would like to share some finding at this time. For minimal usage we need to...
Eugenie Lyzenko
01:06 PM User Interface Bug #7657: 8-bit character entry problem in ChUI
Greg Shah wrote:
> It must be something pulled over from the Hotel GUI directory. In October 2023, Galya implemente...
Eugenie Lyzenko
12:23 PM User Interface Bug #7657: 8-bit character entry problem in ChUI
It must be something pulled over from the Hotel GUI directory. In October 2023, Galya implemented single signon for ... Greg Shah
12:16 PM User Interface Bug #7657: 8-bit character entry problem in ChUI
Guys,
During testing Hotel ChUI with wide chars environment I'm getting the following warning when starting server...
Eugenie Lyzenko
03:56 PM Database Bug #8621: better resolution of ambiguous constructors/methods in RuntimeJastInterpreter
The caching mechanism is in place since the early implementation. Since the structure of the JAST in which the constr... Ovidiu Maxiniuc
01:07 PM Database Bug #8621: better resolution of ambiguous constructors/methods in RuntimeJastInterpreter
What we need to implement for method/constructor matching is actually the Java compiler's algorithm for linking the c... Constantin Asofiei
12:59 PM Database Bug #8621: better resolution of ambiguous constructors/methods in RuntimeJastInterpreter
@RuntimeJastInterpreter.findMatchingConstructor@ currently returns @null@ when it finds more than one c'tor whose sig... Eric Faulhaber
12:26 PM Database Bug #8621 (New): better resolution of ambiguous constructors/methods in RuntimeJastInterpreter
Eric Faulhaber
08:47 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Rebased to trunk/15136, pushed into repository 6692/15156
Working on JS libraries updates.
Tomasz Domin

04/10/2024

02:38 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Just a thing that was on my mind and wanted to have it here as well:
For NO-UNDO cases, we used to rollback (trans...
Alexandru Lungu
01:25 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru Lungu wrote:
> Eric, even for a sub-transaction. We can simply delete and rollback to savepoint, right?
...
Eric Faulhaber
12:04 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Eric, even for a sub-transaction. We can simply delete and rollback to savepoint, right? Alexandru Lungu
11:29 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Greg Shah wrote:
> Seems like a long-standing leak of records. If that built up to a large number, it might be both...
Eric Faulhaber
08:52 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Seems like a long-standing leak of records. If that built up to a large number, it might be both a memory leak and a... Greg Shah
07:59 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru Lungu wrote:
> Still, why are we updating with a @<delete-multiplex>@ instead of actually deleting them? I...
Eric Faulhaber
07:30 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
> For MultiplexedScanIndex, the target batch in setRow(key, row) is calculated from the record's key (which is not ch... Alexandru Lungu
06:46 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
No, the @empty-temp-table@ is the problem, while executing in a transaction, for an undoable temp-table - this does n... Constantin Asofiei
06:41 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei wrote:
> For an undoable temp-table, a @EMPTY-TEMP-TABLE@ results in a @UPDATE tt1 SET _multiplex...
Alexandru Lungu
05:11 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
The recreate is this:
* @mpid1.p@...
Constantin Asofiei
03:59 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei wrote:
> Alexandru, the assumption was that the @MultiplexedBatchIndex$Batch@ holds data *only fo...
Alexandru Lungu

04/09/2024

01:07 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru, the assumption was that the @MultiplexedBatchIndex$Batch@ holds data *only for a certain multiplex*. This... Constantin Asofiei
10:26 AM Runtime Infrastructure Bug #8607: Incorrect parsing of URI string.
Given the investigation conducted in #8367-15, current implementation of URI parsing should be reconsidered. Eduard Soltan
10:23 AM Runtime Infrastructure Bug #8607 (New): Incorrect parsing of URI string.
Eduard Soltan

04/08/2024

03:40 PM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...
@WRITE-JSON@ will always leave the current/working buffer empty when it is finished, causing it content to be eventua... Ovidiu Maxiniuc
02:48 PM Database Bug #7473 (WIP): rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuil...
Ovidiu, are you aware if the @WRITE-JSON@ was finally rewritten without side-effects? Otherwise, Eduard B. can pick i... Alexandru Lungu
10:04 AM User Interface Bug #8598: Frame has no scrollbars
Example:... Vladimir Tsichevski
10:02 AM User Interface Bug #8598 (New): Frame has no scrollbars
Vladimir Tsichevski
05:19 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei wrote:
> You mean the Row.key is not the same as the internal PK?
I mean Row.key to be the same ...
Constantin Asofiei
05:15 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
You mean the Row.key is not the same as the internal PK?
Also, there is 'recid' index (with just this column) in H...
Constantin Asofiei
04:45 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'
> Created task branch 8593a_h2 which improves the @DELETE FROM tt1 WHERE tt1._multiplex = ?@. The reasoning is this:... Alexandru Lungu
03:08 AM Database Bug #8593 (Review): H2 performance improvement for table 'truncate by multiplex'
Created task branch 8593a_h2 which improves the @DELETE FROM tt1 WHERE tt1._multiplex = ?@. The reasoning is this:
...
Constantin Asofiei
02:56 AM Database Bug #8593 (Test): H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei
08:34 PM Database Bug #8554 (Test): resolving temp-tables in a class hierarchy
Greg Shah

04/06/2024

01:41 PM Database Bug #8554: resolving temp-tables in a class hierarchy
Branch 8554a was merged into trunk as rev. 15125 and archived. Constantin Asofiei
12:40 PM Database Bug #8554: resolving temp-tables in a class hierarchy
You can merge to trunk now.
Hynek: 8152a can merge after 8554a.
Greg Shah
03:15 AM Database Bug #8554 (Merge Pending): resolving temp-tables in a class hierarchy
Ovidiu, I've fixed the visibility in rev 15127 (after rebase).
ETF testing passed. It can be merged to trunk.
Constantin Asofiei

04/05/2024

06:11 PM Database Bug #8589: Deprecate the shared temporary database completely
Unless there is a _significant_ memory savings or some other substantial advantage of shared mode, I think we should ... Eric Faulhaber
03:45 AM Database Bug #8589: Deprecate the shared temporary database completely
In the original support for _temp database, one single in-memory database was created. All sessions used that single ... Alexandru Lungu
03:05 AM Database Bug #8589 (New): Deprecate the shared temporary database completely
Alexandru Lungu

04/04/2024

06:39 PM Database Bug #8554: resolving temp-tables in a class hierarchy
Review of 8554a, r15120-15122.
I am OK with the code. I'm sorry I made a mess with condition codes which do and do...
Ovidiu Maxiniuc
04:21 PM Database Bug #8554: resolving temp-tables in a class hierarchy
Ovidiu, please review this, I'll get ETF testing tomorrow and if is OK, I'd like to merge this tomorrow. Constantin Asofiei
07:41 AM Database Bug #8554 (Review): resolving temp-tables in a class hierarchy
15122 fixes some issues, javadocs and some errors which must not set ERROR-STATUS:ERROR. This can be reviewed.
I'...
Constantin Asofiei
05:31 AM Database Bug #8554 (WIP): resolving temp-tables in a class hierarchy
Created task branch 8554a from trunk rev 15119.
15120 and 15121 has a rough fix for this - need to validate it.
Constantin Asofiei
05:26 PM Base Language Bug #8579 (Test): Unit and OEUnit conversion: ignore annotations from other framework
Greg Shah
05:21 PM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework
Greg Shah wrote:
> You can merge 8579a to trunk now.
Done. Rev. 15123.
Vladimir Tsichevski
04:23 PM Base Language Bug #8579 (Merge Pending): Unit and OEUnit conversion: ignore annotations from other framework
You can merge 8579a to trunk now. Greg Shah
01:14 PM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework
Greg Shah wrote:
> Code Review Task Branch 8579a Revision 15121
>
> The change is good.
>
> What additional te...
Vladimir Tsichevski
12:58 PM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework
Code Review Task Branch 8579a Revision 15121
The change is good.
What additional testing is needed?
Greg Shah
11:20 AM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework
Greg Shah wrote:
> Code Review Task Branch 8579a Revision 15120
>
> I think the code would be simpler and easier ...
Vladimir Tsichevski
12:12 PM Base Language Feature #6407: name_map.xml improvements
I did replace the @Set@ with @List@ in r15108.
Tomorrow I'm testing again in testcases. A good list of different p...
Galya B
11:45 AM Base Language Feature #6407: name_map.xml improvements
@MultiClassLoader@:... Galya B
11:43 AM Base Language Feature #6407: name_map.xml improvements
So what I'm saying is that there is no classpath order in my humble opinion. Iterating HashMap is not ordered. Galya B
11:39 AM Base Language Feature #6407: name_map.xml improvements
Greg Shah wrote:
> > > @MultiClassLoader@ finds the class by iterating @HashSet@.
> > Actually it's a collection, ...
Galya B
11:32 AM Base Language Feature #6407: name_map.xml improvements
> > @MultiClassLoader@ finds the class by iterating @HashSet@.
> Actually it's a collection, backed by the @HashMap...
Greg Shah
11:20 AM Base Language Feature #6407 (Review): name_map.xml improvements
6407a r15107 based on trunk r15101 ready for review: adds support for reading mappings from multiple name_map.xml fil... Galya B
09:57 AM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> @MultiClassLoader@ finds the class by iterating @HashSet@.
Actually it's a collection, backed by ...
Galya B
09:42 AM Base Language Feature #6407: name_map.xml improvements
We can rework it to iterate jars alphabetically. Galya B
09:39 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> My understanding is that JVM keeps the same order of jars as defined in classpath (it do...
Galya B
09:37 AM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> Greg Shah wrote:
> > Do we really need an explicit list of precedence order? Why not implicitly t...
Constantin Asofiei
09:29 AM Base Language Feature #6407: name_map.xml improvements
Greg Shah wrote:
> Do we really need an explicit list of precedence order? Why not implicitly take it from the clas...
Galya B
09:28 AM Base Language Feature #6407: name_map.xml improvements
Do we really need an explicit list of precedence order? Why not implicitly take it from the classpath and honor the ... Greg Shah
09:21 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> From what you posted in #6407-56, only one concern: the granularity for the precedence o...
Galya B
05:45 AM Base Language Feature #6407: name_map.xml improvements
From what you posted in #6407-56, only one concern: the granularity for the precedence order I think needs to be "thi... Constantin Asofiei
04:39 AM Base Language Feature #6407: name_map.xml improvements
P.S. The previous comment got updated. Galya B
04:36 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> And I think I understand now Greg's point about the .r and folder deploy in OpenEdge:
>...
Galya B
09:09 AM User Interface Bug #8586: Fields are not in FIELD-GROUP until they are enabled
The program:... Vladimir Tsichevski
09:02 AM User Interface Bug #8586 (Test): Fields are not in FIELD-GROUP until they are enabled
Vladimir Tsichevski

04/03/2024

06:05 PM Base Language Bug #8579 (Internal Test): Unit and OEUnit conversion: ignore annotations from other framework
Code Review Task Branch 8579a Revision 15120
I think the code would be simpler and easier to read if you create a ...
Greg Shah
03:11 PM Base Language Bug #8579 (Review): Unit and OEUnit conversion: ignore annotations from other framework
Fixed in 8579a rev. 15120. Please, review. Vladimir Tsichevski
03:10 PM Base Language Bug #8579 (WIP): Unit and OEUnit conversion: ignore annotations from other framework
Vladimir Tsichevski
02:51 PM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework
Currently, if a test 4gl source includes both ABLUnit annotations and OEUnit annotations, all these annotations are c... Vladimir Tsichevski
02:46 PM Base Language Bug #8579 (Test): Unit and OEUnit conversion: ignore annotations from other framework
Vladimir Tsichevski
04:52 PM User Interface Bug #8353: Fully support stanza INI LOAD/USE/UNLOAD scenarios
The failure was because I didn't include @support/test/AssertExt.cls@ in the conversion file. Now I get:... Roger Borrello
03:08 PM Base Language Feature #6407: name_map.xml improvements
And I think I understand now Greg's point about the .r and folder deploy in OpenEdge:
* in FWD, you would convert th...
Constantin Asofiei
02:34 PM Base Language Feature #6407: name_map.xml improvements
Greg Shah wrote:
> > But, in practice, I think .pl archives are used more - and depending on the PROPATH, runtime co...
Constantin Asofiei
02:29 PM Base Language Feature #6407: name_map.xml improvements
> But, in practice, I think .pl archives are used more - and depending on the PROPATH, runtime could use a .p from di... Greg Shah
02:26 PM Base Language Feature #6407: name_map.xml improvements
We had cases of the same OE qualified class name used in different modules. The qualified legacy name can't be chang... Constantin Asofiei
01:28 PM Base Language Feature #6407: name_map.xml improvements
To solve case 2. we need the precedence order to be fed to the jmv via startup args, so that the classloader can take... Galya B
01:09 PM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> I speak about case 3: different maps for different files with different attributes. Obviously if yo...
Galya B
01:08 PM Base Language Feature #6407: name_map.xml improvements
I speak about case 3: different maps for different files with different attributes, but same path. Obviously if you l... Galya B
01:02 PM Base Language Feature #6407: name_map.xml improvements
> This is not something we can decide even with configs and Constantin was right that it is a major issue.
Case 1 ...
Greg Shah
12:58 PM Base Language Feature #6407: name_map.xml improvements
One pname corresponds to only one jname, because that's how conversion seems to work. The question is if the other at... Galya B
11:36 AM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> Other than that the jar can have a completely different package for the actual classes.
Actually n...
Galya B
11:34 AM Base Language Feature #6407: name_map.xml improvements
If we need to load the jars in a specific order, we'll need explicit instructions, probably new config in directory. Galya B
11:32 AM Base Language Feature #6407: name_map.xml improvements
Case 2 is the same as java and can cause malfunctioning programs like in java, this is what I meant.
Case 1 is fine ...
Galya B
11:20 AM Base Language Feature #6407: name_map.xml improvements
> In java this is the same as having multiple versions of the same dependency in the classpath.
Not exactly. In...
Greg Shah
11:14 AM Base Language Feature #6407: name_map.xml improvements
> If you are saying that module M1 has a program foo/bar/F.p and module M2 has a program foo/bar/F.p. which are compl... Greg Shah
11:12 AM Base Language Feature #6407: name_map.xml improvements
This is actually more complicated than it looked at first. We're trying to combine different apps coming possibly fro... Galya B
11:03 AM Base Language Feature #6407: name_map.xml improvements
Greg Shah wrote:
> Let's consider this from the perspective of how it works for this multi-app case in OE. If both ...
Constantin Asofiei
10:55 AM Base Language Feature #6407: name_map.xml improvements
Originally (currently) if multiple paths are found for the same filename when resolving the name map, the paths end u... Galya B
10:45 AM Base Language Feature #6407: name_map.xml improvements
> The 'pname' in @class-mapping@ is the full path relative to the @abl/@ folder
Yes, this is why I called them rel...
Greg Shah
10:30 AM Base Language Feature #6407: name_map.xml improvements
Greg Shah wrote:
> > > And all of this just for a warning log? I would say it's more reasonable to log the warning a...
Constantin Asofiei
10:26 AM Base Language Feature #6407: name_map.xml improvements
I don't have an actual example though. Not sure if the path is supposed to be the same in two different jars. Galya B
10:25 AM Base Language Feature #6407: name_map.xml improvements
Greg Shah wrote:
> > > And all of this just for a warning log? I would say it's more reasonable to log the warning a...
Galya B
10:23 AM Base Language Feature #6407: name_map.xml improvements
> > And all of this just for a warning log? I would say it's more reasonable to log the warning always when a second ... Greg Shah
06:16 AM Base Language Feature #6407: name_map.xml improvements
> REST services written directly in Java can be configured via the 'rest-service' element.
So these nodes are not ...
Constantin Asofiei
06:06 AM Base Language Feature #6407: name_map.xml improvements
OK, then I need one more clarification. Since there is a separate container @rest-service@, where programs get resolv... Galya B
06:00 AM Base Language Feature #6407: name_map.xml improvements
Yes. Constantin Asofiei
05:57 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> Galya B wrote:
> > And all of this just for a warning log? I would say it's more reason...
Galya B
05:57 AM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> And all of this just for a warning log? I would say it's more reasonable to log the warning always ...
Constantin Asofiei
05:53 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> Galya B wrote:
> > Constantin, maybe you've missed why I'm assigned to the task, that i...
Galya B
05:49 AM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> Constantin, maybe you've missed why I'm assigned to the task, that is in #6407-4.
OK, thanks for t...
Constantin Asofiei
05:49 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> The point was to move to annotations/other structures inside the .java
Constantin, ...
Galya B
05:43 AM Base Language Feature #6407: name_map.xml improvements
The point was to move to annotations/other structures inside the .java, here I mean all info from name_map.xml; ideal... Constantin Asofiei
05:33 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> I don't mean the annotations in the .class - I mean the state from name_map.xml must mat...
Galya B
05:22 AM Base Language Feature #6407: name_map.xml improvements
I don't mean the annotations in the .class - I mean the state from name_map.xml must match if there is an existing en... Constantin Asofiei
03:55 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> * load them into @SourceNameMapper@, one by one, and address conflicts - if there are co...
Galya B
05:26 AM Base Language Bug #8510: replace all 'new logical' in FWD runtime with logical.of or logical.UNKNOWN
8150a was merged to trunk rev 15116 and archived. Constantin Asofiei
05:26 AM Base Language Bug #8510: replace all 'new logical' in FWD runtime with logical.of or logical.UNKNOWN
Created task branch 8510a from trunk rev 15115. In rev 15116 I removed the @logical.of@ and @logical.UNKNOWN@ from R... Constantin Asofiei

04/02/2024

05:15 PM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result
Șerban Bursuc wrote:
> As for issue 2, I don't understand whether OE just refuses to sort the column, or it doesn'...
Vladimir Tsichevski
10:30 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result
Sorry for the random assignment, it was **not** intentional. Șerban Bursuc
10:27 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result
Vladimir Tsichevski wrote:
> As I see this:
>
> # If a string tree column has non-empty values, empty string valu...
Șerban Bursuc
10:11 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result
As I see this:
# If a string tree column has non-empty values, empty string values and unknown values, when expect...
Vladimir Tsichevski
09:57 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result
Vladimir Tsichevski wrote:
> Șerban Bursuc wrote:
>
> > As for what's different, it's a bit more apparent from th...
Șerban Bursuc
09:56 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result
Șerban Bursuc wrote:
> As for what's different, it's a bit more apparent from the screenshots in #8039-39
There i...
Vladimir Tsichevski
09:28 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result
Vladimir Tsichevski wrote:
> I reproduced the situation using @5084.p@, and I found no difference between OE and FWD...
Șerban Bursuc
08:23 AM User Interface Bug #8260 (Feedback): treelist sorting column with null and empty string values does not produce ...
I reproduced the situation using @5084.p@, and I found no difference between OE and FWD. What is wrong with FWD? Vladimir Tsichevski

04/01/2024

06:41 PM Base Language Bug #8154: refactor scopeable stacks
Code Review Task Branch 8154a Revision 15109
The changes look promising. There is clearly quite a bit more that c...
Greg Shah
12:51 PM Base Language Bug #8154 (WIP): refactor scopeable stacks
Created task branch 8154a from trunk rev 15108.
Rev 15109 contains first pass at moving scoped stacks into (TopLev...
Constantin Asofiei
06:41 PM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result
Șerban Bursuc wrote:
> Using the @TreeList@ testcase:
>
> We add nodes with the following cell values
>
> [......
Vladimir Tsichevski
01:46 PM User Interface Bug #8556: Incorrect frame layout
The issue exists at least since the trunk rev. 14857, so it is not a recent regression. Vladimir Tsichevski
01:26 PM User Interface Bug #8556: Incorrect frame layout
The following example:... Vladimir Tsichevski
01:21 PM User Interface Bug #8556 (New): Incorrect frame layout
Vladimir Tsichevski
08:49 AM Database Bug #8554: resolving temp-tables in a class hierarchy
@DATASET:CREATE-LIKE("<dataset-name>")@ needs to be checked, too. Constantin Asofiei
08:02 AM Runtime Infrastructure Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent
Constantin Asofiei wrote:
> * in OE, SysError is used for internal errors (via ErrorManager for FWD). But, there is...
Galya B
05:21 AM Runtime Infrastructure Bug #8383 (WIP): Some JsonObject methods create a LOG-MANAGER record in silent
Constantin Asofiei wrote:
> * in OE, SysError is used for internal errors (via ErrorManager for FWD). But, there is...
Galya B
05:09 AM Runtime Infrastructure Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent
Galya, some notes:
* we need to be careful with naming FWD internal methods added to skeleton classes/interfaces (in...
Constantin Asofiei
04:00 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)
Galya, I've placed the project under @devsrv01:/tmp/open_client_example.zip@. There is a small readme.txt in the pro... Constantin Asofiei

03/31/2024

10:35 AM Database Bug #8554: resolving temp-tables in a class hierarchy
There are some problems when resolving temp-tables in a hierarchy.
* @oo.Test1@:...
Constantin Asofiei
10:28 AM Database Bug #8554 (Test): resolving temp-tables in a class hierarchy
Constantin Asofiei

03/29/2024

01:23 PM User Interface Bug #7657: 8-bit character entry problem in ChUI
I am open to trying out and testing any FWD changes here on my end. Let me know if I can help in any way. I have work... Robert Jensen
06:39 AM User Interface Bug #7657: 8-bit character entry problem in ChUI
Robert Jensen wrote:
> The comand line is actually:
> ./client-terminal.sh client:cmd-line-option:startup-procedure...
Greg Shah
06:26 AM User Interface Bug #7657: 8-bit character entry problem in ChUI
> I may have missed a step here. I am running from Intellij, which I did restart after the changes to .bashrd But may... Greg Shah
06:17 AM User Interface Bug #7657: 8-bit character entry problem in ChUI
In #7657-5, I mentioned some changes that were needed. Let me make it more clear: these changes that are needed are ... Greg Shah
10:57 AM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> @SourceNameMapper.initMappingData@ seems to be executed only once for the lifespan of the runtime m...
Constantin Asofiei
10:20 AM Base Language Feature #6407 (WIP): name_map.xml improvements
6407a created from trunk r15101. Galya B
10:03 AM Base Language Feature #6407: name_map.xml improvements
@SourceNameMapper.initMappingData@ seems to be executed only once for the lifespan of the runtime machine with a serv... Galya B
09:46 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> Also, SourceNameMapper will not load the .class and annotations when the entry in @name_...
Galya B
09:45 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> Java has tools to read an archive.
If you mean the custom FWD's @JarClassLoader@, then ...
Galya B
09:38 AM Base Language Feature #6407: name_map.xml improvements
You don't need to unzip the jar - Java has tools to read an archive. This just means we can't rely on @Class.getReso... Constantin Asofiei
09:37 AM Base Language Feature #6407: name_map.xml improvements
Why can't we use the same technique from @Utils.searchResourceJars()@? We don't need the propath part but we definit... Greg Shah
09:29 AM Base Language Feature #6407: name_map.xml improvements
That is of course if the check for the file listed by @jar tvf filename.jar@ gives positive. Galya B
09:27 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> Galya, what package would you use for looking into multiple jars? Look everywhere? The ...
Galya B
08:41 AM Base Language Feature #6407: name_map.xml improvements
Galya, what package would you use for looking into multiple jars? Look everywhere? The problem with @name_map.xml@ i... Constantin Asofiei
08:31 AM Base Language Feature #6407: name_map.xml improvements
> @MultiClassLoader@ has a list of all jars in the classpath. It can look for @name_map.xml@ in each jar (with @jar t... Greg Shah
07:08 AM Base Language Feature #6407: name_map.xml improvements
@MultiClassLoader@ has a list of all jars in the classpath. It can look for @name_map.xml@ in each jar (with @jar tvf... Galya B
08:50 AM Support #8547 (Review): Fix documentation for Non-Standard Save Cache Implementation
Changes to wiki completed.
Eric, please review.
Tijs Wickardt
08:16 AM Support #8547 (WIP): Fix documentation for Non-Standard Save Cache Implementation
Tijs Wickardt
08:16 AM Support #8547: Fix documentation for Non-Standard Save Cache Implementation
This task is about [[p2j:Non-Standard Save Cache Implementation]] .
Tijs will do the required changes, Eric needs to...
Tijs Wickardt
08:13 AM Support #8547 (Review): Fix documentation for Non-Standard Save Cache Implementation
Tijs Wickardt
07:42 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Greg Shah wrote:
> Did you test both embedded mode and virtual desktop in Hotel GUI?
>
Yes, I did
> Did you test...
Tomasz Domin
04:44 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
It would be interesting to profile a test case with both Java 8 and Java 17 and see where the times differ. Having mo... Hynek Cihlar
06:16 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
I know some work has happened to explore I18N testcases. Having proper testcases will be very important.
I want t...
Greg Shah
03:16 AM Runtime Infrastructure Feature #8544: Move spawner code to JNI
The spawner executable exists as a separate deployment with the sole purpose of providing admin rights only to a stri... Galya B
02:51 AM Runtime Infrastructure Feature #8544 (New): Move spawner code to JNI
Galya B

03/28/2024

06:49 PM User Interface Bug #7657: 8-bit character entry problem in ChUI
The comand line is actually:
./client-terminal.sh client:cmd-line-option:startup-procedure=com/<app_path>/ClientBoot...
Robert Jensen
05:45 PM User Interface Bug #7657: 8-bit character entry problem in ChUI
I fianally got around to trying the ncurses update. No change. The setup_ncurses6x.sh script did appear to work corre... Robert Jensen
05:13 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Yes, this can be found in #8208-18. A summary for those that can't access that task:
> * Java 8 is faster than Ja...
Greg Shah
04:05 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Guys,
Regarding possible migration I have a question. Will we have performance degradation with @Java 8 -> Java 17...
Eugenie Lyzenko
03:46 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Did you test both embedded mode and virtual desktop in Hotel GUI?
Did you test call graph in Hotel GUI?
We need...
Greg Shah
02:43 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Greg Shah wrote:
> I know you've been doing some amount of testing on this. As far as I know, we only have testing ...
Tomasz Domin
02:07 PM Runtime Infrastructure Feature #6692 (Internal Test): move FWD to Java 17
I know you've been doing some amount of testing on this. As far as I know, we only have testing and any fixes that a... Greg Shah
05:09 PM Base Language Feature #6407: name_map.xml improvements
> We had this discussion before - moving *everything* to annotations will mean the entire converted .class code needs... Greg Shah
03:58 PM Base Language Feature #6407: name_map.xml improvements
Greg Shah wrote:
> > another improvement would be to emit some kind of special constructs for the virtual functions/...
Constantin Asofiei
03:50 PM Base Language Feature #6407: name_map.xml improvements
> another improvement would be to emit some kind of special constructs for the virtual functions/internal procedures ... Greg Shah
01:47 PM User Interface Feature #4517 (Closed): optionally back the 4GL features for Registry access with the user-specif...
Greg Shah
11:29 AM User Interface Bug #8541: Fill-In widget incorrectly resets cursor position to 0 when DISPLAY is in VALUE-CHANGE...
Updated previous message to hide customer info. Eugenie Lyzenko
11:27 AM User Interface Bug #8541: Fill-In widget incorrectly resets cursor position to 0 when DISPLAY is in VALUE-CHANGE...
The branch @8508a@ already created to accept the fixes. It has some fix candidate to review/test.
The samples to r...
Eugenie Lyzenko
11:23 AM User Interface Bug #8541 (New): Fill-In widget incorrectly resets cursor position to 0 when DISPLAY is in VALUE-...
Eugenie Lyzenko
09:49 AM Base Language Feature #6417 (WIP): cleanup some known items in appserver support
Galya B
09:44 AM Base Language Feature #6417: cleanup some known items in appserver support
Test in OE for client type:
Procedure running in batch client:...
Galya B
 

Also available in: Atom