Project

General

Profile

Activity

From 02/15/2013 to 03/16/2013

03/14/2013

05:07 PM Feature #2089: INPUT function returning string value
... Greg Shah
09:55 PM Feature #2089: INPUT function returning string value
I have an update posted in #2053. It is in testing, but hopefully you can use it to test your changes. Greg Shah
12:04 PM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Committed to bzr revision 10285. Constantin Asofiei
10:27 AM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
The update looks good. You can check it in and distribute it. Greg Shah
09:56 AM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Correct, good letter, wrong date. Attached is the good one. Constantin Asofiei
08:13 AM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
I think the wrong update is posted here. Greg Shah

03/13/2013

06:14 PM Feature #2089: INPUT function returning string value
About note 8: no.
You can do the following:
1. Determine the type (wrapper classname: like "integer") of the va...
Greg Shah
06:00 PM Feature #2089: INPUT function returning string value
Yes, you should work on item 2 and my changes will enable item 1. Please note that I don't want to transform all val... Greg Shah
04:42 PM Feature #2089: INPUT function returning string value
In regards to #2: should I parent all occurrences of a validated value with FUNC_POLY node as a solution? Stanislav Lomany
02:12 PM Feature #2089: INPUT function returning string value
OK, I missed that. So your question remains. Constantin Asofiei
02:11 PM Feature #2089: INPUT function returning string value
Greg was saying that "I am currently working to extend that facility to be more robust, including detecting the case ... Stanislav Lomany
01:53 PM Feature #2089: INPUT function returning string value
Stanislav Lomany wrote:
> So, am I correct that except checking the runtime part we have two problems:
> 1. It is n...
Constantin Asofiei
01:47 PM Feature #2089: INPUT function returning string value
So, am I correct that except checking the runtime part we have two problems:
1. It is not properly recognized that a...
Stanislav Lomany
03:15 PM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
The update has passed conversion regression testing. Constantin Asofiei
02:33 PM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
The only remaining problem was with char field initializers, which were not handled (it was parsers fault). The notes... Constantin Asofiei

03/12/2013

04:05 PM Feature #2089: INPUT function returning string value
As Constantin notes, the INPUT function in the 4GL can return either the actual data type of the widget OR it can ret... Greg Shah
03:46 PM Feature #2089: INPUT function returning string value
Greg, how should correctly converted validation code look like for the following example?... Stanislav Lomany
03:12 PM Feature #2089: INPUT function returning string value
Copied from #2068:
*CA*
Another problem found in at least rtb/ folder:...
Stanislav Lomany
03:09 PM Feature #2089 (Closed): INPUT function returning string value
Stanislav Lomany

03/11/2013

11:09 AM Feature #1640: implement DOM XML support
Added more missing APIs. Committed to bzr revision 10276 Constantin Asofiei
11:05 AM Feature #1884: add some of the v10 data types and core built-ins
-Added more missing APIs. Committed to bzr revision 10276- was for task #1640 Constantin Asofiei

03/09/2013

03:57 PM Bug #2076: DMO setter fails when parameter is BaseDataType
A simple change to ECW fixes this. I am making some other changes to the ECW as well. Then I will conversion test t... Greg Shah
11:25 AM Bug #2076: DMO setter fails when parameter is BaseDataType
There is a regression related to this update:... Constantin Asofiei
03:56 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Yes, I'm thinking about what is the right solution here. I wonder if I should make the previous solution (the extra ... Greg Shah
03:52 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Hmm... on a second thought, this is similar to the DMO setter case... it should wrap the _POLY/DB_NON_REF in a logica... Constantin Asofiei
03:34 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
I'm not sure the problem is in the ECW. Actually, there is never any attempt to call the ECW for these cases. If I ... Greg Shah
11:13 AM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
The strange thing is that I already put in support for all of these cases. I guess it is not working properly. I wi... Greg Shah
07:28 AM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
The ExpressionConversion worker needs to treat the cases when a _POLY is used in a logical test, as in:... Constantin Asofiei
11:11 AM Feature #2087 (Closed): add support for extent vars/fields used with a PUT statement (stream-only...
Checked in as bzr revision 10273. Greg Shah
04:44 AM Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
The ges_upd20130308g.zip update has passed conversion regression testing. Constantin Asofiei
03:01 AM Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
Thanks, that did the trick. I'm putting it through conversion regression testing. Constantin Asofiei
11:06 AM Bug #2065 (Closed): ambiguity in date/decimal literals that is not handled properly by the Progre...
Greg Shah
11:06 AM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Passed conversion testing and checked in as bzr revision 10272. Greg Shah
02:55 AM Feature #1640: implement DOM XML support
Adds two missing APIs in XmlFactory, related to WIDGET-POOL clause. Committed to bzr revision 10271. Constantin Asofiei

03/08/2013

05:25 PM Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
Take a look at this. I think this should do the same thing. Greg Shah
03:59 PM Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
The good news is that 0308h.zip has passed conversion regression testing - no changes. Constantin Asofiei
03:47 PM Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
I had a feeling there was another file where this was done already for some other cases, but my brain chose to ignore... Constantin Asofiei
03:41 PM Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
Code Review:
Could we have added this as an additional case in annotations/array_expansion.rules?
Greg Shah
02:58 PM Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
Had a regression (didn't handle the case when the PUT used a subscripted field). Back in regression testing. Constantin Asofiei
01:31 PM Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
4GL allows extent vars/fields to be used in a PUT statement:... Constantin Asofiei
01:27 PM Feature #2087 (Closed): add support for extent vars/fields used with a PUT statement (stream-only...
Constantin Asofiei
05:05 PM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Fix for empty string used as a date var initializer. It is being conversion tested now. Greg Shah
04:30 PM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Passed conversion testing and checked in as revision 10269.
I'll handle the date from an empty string next.
Greg Shah
03:38 PM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Another issue related to dates:... Constantin Asofiei
03:28 PM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Final version going through conversion testing now. There was an issue with removal of zeros from the year portion o... Greg Shah
02:05 PM Bug #2065 (WIP): ambiguity in date/decimal literals that is not handled properly by the ProgressL...
How many times am I going to be wrong today? Majic compiled fine with the c update but there are still many unwanted... Greg Shah
12:12 PM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Another silly mistake, I didn't properly exclude num literals from the trailing zero removal. This updated version i... Greg Shah
10:56 AM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Fixed a stupid indexing error. Going back into conversion testing. Greg Shah
10:48 AM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Updated version of the testcase plus the prepared fixes which are going into conversion testing now.
The core solu...
Greg Shah
10:35 AM Feature #1640: implement DOM XML support
Committed to bzr revision 10267 Constantin Asofiei
10:02 AM Feature #1640: implement DOM XML support
I'm fine with the change. Commit and distribute it. Greg Shah
09:45 AM Feature #1640: implement DOM XML support
ca_upd20130308d.zip has passed conversion regression testing. Constantin Asofiei
08:15 AM Feature #1640: implement DOM XML support
Fixed conversion of CREATE statements related to XML support. The correct approach is to pass the handle instance as ... Constantin Asofiei

03/07/2013

05:00 PM Bug #2076 (Closed): DMO setter fails when parameter is BaseDataType
Greg Shah
04:58 PM Bug #2076: DMO setter fails when parameter is BaseDataType
Passes conversion testing and is checked into bzr as revision 10264.
Greg Shah
04:46 PM Bug #2076: DMO setter fails when parameter is BaseDataType
No, that is alright. The difference is not significant at runtime. Thanks.
I will check this in and distribute it.
Greg Shah
04:41 PM Bug #2076: DMO setter fails when parameter is BaseDataType
> Constantin: what do you think?
The result will not affect runtime, is just some small overhead. I think this is be...
Constantin Asofiei
04:32 PM Bug #2076: DMO setter fails when parameter is BaseDataType
Conversion testing has finished. There is this one unexpected change:... Greg Shah
02:25 PM Bug #2076: DMO setter fails when parameter is BaseDataType
This update is fine. I will conversion regression test it.
> Sorry I missed the "rule" directory , what I do when...
Greg Shah
01:14 PM Bug #2076: DMO setter fails when parameter is BaseDataType
Added proposed update.
Sorry I missed the "rule" directory , what I do when adding an update: I manually create the...
Costin Savin
12:20 PM Bug #2076: DMO setter fails when parameter is BaseDataType
Code Feedback:
1. Your zip still has the wrong directory name "rule" instead of "rules". How is that even getting...
Greg Shah
06:06 AM Bug #2076: DMO setter fails when parameter is BaseDataType
Added proposed update (uploaded it first by mistake to #2070) Costin Savin
12:42 PM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Greg Shah wrote:
> I'm not sure why you switched from a Set to a Map in fixups/variable_definitions.rules (did you p...
Constantin Asofiei
12:29 PM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
I'm not sure why you switched from a Set to a Map in fixups/variable_definitions.rules (did you plan to use it and th... Greg Shah
12:13 PM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
The edited file is in task #2085.
This update has passed conversion regression testing (there are changes in two f...
Constantin Asofiei
09:51 AM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
MAJIC has the case at note 14 in only one file. I've checked the history of this file and this change was introduced ... Constantin Asofiei
08:59 AM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Fixed a problem (I was using varDict.getSymbol instead of varDict.getSymbolAtScope(name, 0) to search only in the cur... Constantin Asofiei
08:45 AM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
This has regressions, one of them relaed to this, as 4GL (v9-only I think) allowed this:... Constantin Asofiei
06:27 AM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
So the problem was that the parser was adding tempidx to the dupped vars too. The sollution was to not register the d... Constantin Asofiei
05:49 AM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
I need to rewrite this at the parser side, as the duped var gets ref'ed by the parser:... Constantin Asofiei
05:13 AM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Fixed multiple calls like:... Constantin Asofiei
12:02 PM Bug #2069: Accumulator temp table field disambiguation
Committed to bzr revision 10262. Constantin Asofiei
11:56 AM Bug #2069: Accumulator temp table field disambiguation
The change looks fine. Check it in and distribute it. Greg Shah
05:51 AM Bug #2069: Accumulator temp table field disambiguation
This has passed conversion regression testing. Constantin Asofiei
04:53 AM Bug #2069: Accumulator temp table field disambiguation
I think the sollution was to mark the tables which are weak reference as preferred, when abbreviations are encountere... Constantin Asofiei
03:51 AM Bug #2069: Accumulator temp table field disambiguation
Another creature of the rabbit hole found at #1985, 120. This fails:... Constantin Asofiei
05:28 AM Bug #2070: BlockManager Action disambiguation
Added update to wrong task deleting it Costin Savin

03/06/2013

01:50 PM Feature #1884: add some of the v10 data types and core built-ins
Committed to bzr revision 10259. Constantin Asofiei
01:45 PM Feature #1884: add some of the v10 data types and core built-ins
I agree. The code is fine. Check it in and distribute it. Greg Shah
01:30 PM Feature #1884: add some of the v10 data types and core built-ins
Added missing TextOps.numEntries(String, String). I don't see a reason to put this through conversion regression test... Constantin Asofiei
01:25 PM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
The following testcase shows the limits of this ambiguity.
From the header:...
Greg Shah
01:20 PM Bug #2076: DMO setter fails when parameter is BaseDataType
That crossed my mind too and started in that direction in the morning, but thought about the copy Ast with null paren... Costin Savin
01:09 PM Bug #2076: DMO setter fails when parameter is BaseDataType
The best thing to do here is to move the current logic for ECW.expressionType(Aast) to a new public worker method ECW... Greg Shah
12:44 PM Bug #2076: DMO setter fails when parameter is BaseDataType
The AST... Costin Savin
12:39 PM Bug #2076: DMO setter fails when parameter is BaseDataType
Please post the AST here for the @assign test.int-field = h:BUFFER-FIELD("dsc"):BUFFER-VALUE(2).@. Greg Shah
12:16 PM Bug #2076: DMO setter fails when parameter is BaseDataType
I'll use this example to explain.... Costin Savin
11:45 AM Bug #2076: DMO setter fails when parameter is BaseDataType
Code Review:
> I first tried to use ExpresionConversionWorker.expressionType with an ast copy without a parent (be...
Greg Shah
11:24 AM Bug #2076: DMO setter fails when parameter is BaseDataType
Added proposed update
NOTE
I first tried to use ExpresionConversionWorker.expressionType with an ast copy without...
Costin Savin
12:54 PM Feature #1920: implement persistent procedures
Added merged update, which was committed to bzr revision 10258. Constantin Asofiei
12:44 PM Feature #1920: implement persistent procedures
Passed conversion regression testing, no changes in generated sources.
I'll merge the file with latest version and...
Constantin Asofiei
11:35 AM Feature #1920: implement persistent procedures
Fixed attribute access when there are extent widgets, like:... Constantin Asofiei
11:10 AM Feature #2082 (Closed): add conversion support for 4GL's duplicate variable "feature"
Greg Shah
10:59 AM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Committed to bzr revision 10255. Constantin Asofiei
10:54 AM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Check it in and distribute it. Greg Shah
10:33 AM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
The update has passed conversion regression testing. Note that even MAJIC had two cases of duplicated vars, in two fi... Constantin Asofiei
09:10 AM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Added comment and fixed the proc/function case. I'm putting it back into conversion regression testing. Constantin Asofiei
09:05 AM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Please put a comment into the variable_definitions.rules about the order of the definitions and that we deliberately ... Greg Shah
09:03 AM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
> 1. Is there any difference in behavior when the non-global define variable is inside a nested scope (e.g. an intern... Constantin Asofiei
08:58 AM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
The code looks good. I only have 2 questions:
1. Is there any difference in behavior when the non-global define v...
Greg Shah
08:42 AM Feature #2082 (Review): add conversion support for 4GL's duplicate variable "feature"
Attached update hides all duplicate var defs, only if the first one is DEF NEW GLOBAL SHARED. I'm putting this throug... Constantin Asofiei
08:19 AM Feature #2082: add conversion support for 4GL's duplicate variable "feature"
4GL allows two vars with the same name, if this construct is encountered:... Constantin Asofiei
08:18 AM Feature #2082 (Closed): add conversion support for 4GL's duplicate variable "feature"
Constantin Asofiei
08:57 AM Bug #2070: BlockManager Action disambiguation
Commited to bzr as revision number 10254. Costin Savin
08:35 AM Bug #2070: BlockManager Action disambiguation
The update has passed conversion regression testing, go ahead and distribute it. Constantin Asofiei
07:36 AM Bug #2070: BlockManager Action disambiguation
Added update Costin Savin
07:35 AM Bug #2070: BlockManager Action disambiguation
Please remove the dangling text from the 421 and the other edits I mentioned, and re-upload. I'm putting it through c... Constantin Asofiei
07:11 AM Bug #2070: BlockManager Action disambiguation
Added fix update Costin Savin
06:50 AM Bug #2070: BlockManager Action disambiguation
0305d.zip doesn't fully solve the issue, as the package name is computed wrong. It uses the package from the nearest ... Constantin Asofiei
08:47 AM Bug #2069 (Closed): Accumulator temp table field disambiguation
Greg Shah
08:27 AM Feature #2079 (Closed): add missing conversion support for format string
Greg Shah
08:08 AM Feature #2078 (Closed): provide support for malformed label names
Greg Shah
01:52 AM Feature #2078: provide support for malformed label names
Committed to bzr revision 10247. Constantin Asofiei
07:14 AM Feature #1885: fix and add necessary format string support
0306a.zip was Committed to bzr revision 10252. Constantin Asofiei
04:45 AM Feature #1885: fix and add necessary format string support
0306a.zip has passed conversion regression testing (no changes in generated sources). Constantin Asofiei
02:32 AM Feature #1885: fix and add necessary format string support
Correct version of progress.g Constantin Asofiei
02:16 AM Feature #1885: fix and add necessary format string support
This version emits the toStringMessage in case the format is a complex expression, for PUT field. Also, adds a TODO i... Constantin Asofiei

03/05/2013

06:02 PM Feature #2078: provide support for malformed label names
I'm OK with the code. You can check it in and distribute. Greg Shah
05:15 PM Feature #2078: provide support for malformed label names
Passed conversion regression testing. Constantin Asofiei
04:18 PM Feature #2078: provide support for malformed label names
I'm putting this through conversion regression testing. Constantin Asofiei
04:09 PM Feature #2078: provide support for malformed label names
In 4GL, it is possible to support malformed label names, as in:... Constantin Asofiei
04:03 PM Feature #2078 (Hold): provide support for malformed label names
Constantin Asofiei
05:24 PM Feature #1885: fix and add necessary format string support
Yes, using toStringMessage() is a great idea. Greg Shah
05:04 PM Feature #1885: fix and add necessary format string support
This fixes the conversion problem, still need to expand PutField c'tors to accept character for the format... or, can... Constantin Asofiei
04:38 PM Feature #1885: fix and add necessary format string support
There is at least one format string problem in the server. Looks like PUT fields can have a dynamic format, and any e... Constantin Asofiei
04:41 PM Feature #2079: add missing conversion support for format string
This is for tracking the time for adding conversion support. All comments to be added in the parent #1885 task. Constantin Asofiei
04:40 PM Feature #2079 (Closed): add missing conversion support for format string
Constantin Asofiei
04:35 PM Bug #2070 (Closed): BlockManager Action disambiguation
Passed conversion testing and checked into bzr as revision 10244. Greg Shah
03:05 PM Bug #2070: BlockManager Action disambiguation
I'm conversion testing this now. Greg Shah
02:56 PM Bug #2070: BlockManager Action disambiguation
Added cs_upd20130305d.zip only with changes from previous update Costin Savin
02:55 PM Bug #2070: BlockManager Action disambiguation
Commited cs_upd20130305c.zip to bzr as revision number 10243.
Costin Savin
02:34 PM Bug #2070: BlockManager Action disambiguation
In cs_upd20130305d.zip, please remove the unchanged files from cs_upd20130305c.zip and add a history entry to control... Greg Shah
02:32 PM Bug #2070: BlockManager Action disambiguation
cs_upd20130305c.zip has passed conversion testing. Check it in and distribute it. I will look at cs_upd20130305d.zi... Greg Shah
02:05 PM Bug #2070: BlockManager Action disambiguation
Added proposed update Costin Savin
01:11 PM Bug #2070: BlockManager Action disambiguation
This is a problem indeed, the solution would be to explicitly import the DMO class. Costin Savin
12:23 PM Bug #2070: BlockManager Action disambiguation
Costin, please double check this, because I think we need to disambiguate this in the opposite direction too, as I th... Constantin Asofiei
11:41 AM Bug #2070: BlockManager Action disambiguation
I'm conversion testing this now. Greg Shah
11:32 AM Bug #2070: BlockManager Action disambiguation
Copied a wrong update deleted wrong file and uploaded the correct one Costin Savin
11:27 AM Bug #2070: BlockManager Action disambiguation
merge Costin Savin
11:08 AM Bug #2070: BlockManager Action disambiguation
The code looks good. Constantin will be checking in 1 more version of common-progress. Merge with that and we will ... Greg Shah
09:37 AM Bug #2070: BlockManager Action disambiguation
merge Costin Savin
05:07 AM Bug #2070: BlockManager Action disambiguation
Added proposed update Costin Savin
07:12 PM Bug #2070: BlockManager Action disambiguation
Code Review:
1. Please merge up to the latest bzr level.
2. This method:...
Greg Shah
03:34 PM Bug #2076: DMO setter fails when parameter is BaseDataType
ExpressionConversionWorker never returns the int type (e.g. ATTR_POLY) but instead will return the wrapper class name... Greg Shah
02:36 PM Bug #2076: DMO setter fails when parameter is BaseDataType
Trying to get the rules to create a new variable with the same field type to apply only for expression type ATTR_POLY... Costin Savin
11:12 AM Bug #2069: Accumulator temp table field disambiguation
Greg Shah wrote:
> Check it in and distribute.
Committed to bzr revision 10242.

> Should we still test ca_upd20...
Constantin Asofiei
11:02 AM Bug #2069: Accumulator temp table field disambiguation
Check it in and distribute.
Should we still test ca_upd20130304b.zip by itself or should we include these other ch...
Greg Shah
10:03 AM Bug #2069: Accumulator temp table field disambiguation
0305b.zip has passed conversion regression testing. Constantin Asofiei
09:17 AM Bug #2069: Accumulator temp table field disambiguation
Another side-note for this task: we should identify all missing no-reference cases and code them in common-progress.r... Constantin Asofiei
08:47 AM Bug #2069: Accumulator temp table field disambiguation
I've fixed the history entry in common-progress.rules. Constantin Asofiei
08:39 AM Bug #2069: Accumulator temp table field disambiguation
Greg Shah wrote:
> Go ahead and check these in and distribute them. If Eric has concerns we will address them in a ...
Constantin Asofiei
08:29 AM Bug #2069: Accumulator temp table field disambiguation
Another case of no-reference is:... Constantin Asofiei
08:18 AM Bug #2069: Accumulator temp table field disambiguation
Go ahead and check these in and distribute them. If Eric has concerns we will address them in a separate distributio... Greg Shah
05:14 AM Bug #2069: Accumulator temp table field disambiguation
In the end, I ended up testing (using 10237 as baseline, but this should make no difference):
# 05a (INPUT function ...
Constantin Asofiei
11:41 PM Bug #2069: Accumulator temp table field disambiguation
This makes the INPUT function to produce no-references. About 04c.zip: my test was without 04b.zip update, to better ... Constantin Asofiei
10:48 PM Bug #2069: Accumulator temp table field disambiguation
With these changes, pmcli/ converts fully. Also, MAJIC converts fully, but there is a CAN-FIND change in a single fil... Constantin Asofiei
07:01 PM Bug #2069: Accumulator temp table field disambiguation
Does this resolve #1985 note 64 or is this just more fixes on the way to the Mad Hatter's tea party? Greg Shah

03/04/2013

06:46 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Passed conversion testing and checked in to bzr as revision 10239. Greg Shah
05:04 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
New version of the update with another change to the parser that fixes a problem found in testing the server code. I... Greg Shah
03:32 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
#1985 note 96 shows a new problem: DB_REF_NON_STATIC needs to be supported. I have added it to the ECW. It uses con... Greg Shah
04:38 PM Bug #2069: Accumulator temp table field disambiguation
This fix attempt does the following:
# fixes #2059 's ecf_upd20130303b.zip, to include temp-tables too
# fixes a bu...
Constantin Asofiei
03:59 PM Bug #2069: Accumulator temp table field disambiguation
Constantin Asofiei wrote:
> This code tests only for BUFFER nodes, and excludes tables, temp-tables, work-tables. Wa...
Eric Faulhaber
03:39 PM Bug #2069: Accumulator temp table field disambiguation
Some news about the field name disambiguation issue. In SchemaDictionary.promoteEntry, there is this test:... Constantin Asofiei
03:17 PM Bug #2069: Accumulator temp table field disambiguation
Committed to bzr revision 10238.
These files have changes which are not limitted to just buffer scope:...
Constantin Asofiei
03:01 PM Bug #2069: Accumulator temp table field disambiguation
Check it it and distribute it. I will make sure runtime regression testing is run separately. What programs should ... Greg Shah
02:48 PM Bug #2069: Accumulator temp table field disambiguation
Conversion regression testing has finished, the note about runtime regression testing still stands, with the addition... Constantin Asofiei
01:52 PM Bug #2069: Accumulator temp table field disambiguation
The code looks good.
It also fixes all remaining issues in #1985 notes 93, 104-109 and 111. These programs all co...
Greg Shah
01:27 PM Bug #2069: Accumulator temp table field disambiguation
Looks like the matching in accumulators needs to be done using the bufname too, attached update does this. I'm puttin... Constantin Asofiei
12:25 PM Bug #2069: Accumulator temp table field disambiguation
> In my example, both fields have a schemaname of "tt.num" but the bufname will differ ("b1" vs "b2"). Actually, the... Constantin Asofiei
12:18 PM Bug #2069: Accumulator temp table field disambiguation
I don't think schemaname alone will work.
In my example, both fields have a schemaname of "tt.num" but the bufname...
Greg Shah
12:09 PM Bug #2069: Accumulator temp table field disambiguation
The 0304a.zip passed conversion regression testing, but there are lots of buffer scope-related changes, as the accum ... Constantin Asofiei
11:41 AM Bug #2069: Accumulator temp table field disambiguation
If the parser gets the schemaname right, in case of unqualified field and compilable 4GL code, I don't think we will ... Constantin Asofiei
11:15 AM Bug #2069: Accumulator temp table field disambiguation
The changes look good, though we may have to work off something different than only schemaname.... Greg Shah
10:06 AM Bug #2069: Accumulator temp table field disambiguation
This update:
* makes the field in accum function to be a no-reference.
* fixes CAN-FIND function, when its WHERE cl...
Constantin Asofiei
09:57 AM Bug #2069: Accumulator temp table field disambiguation
About the ACCUM no_reference: after I let this be a no_reference, then the "refid" annotation will not be emitted for... Constantin Asofiei
09:41 AM Bug #2069: Accumulator temp table field disambiguation
Please prepare the ACCUM no_reference and CAN-FIND changes and upload the update ASAP. Both of these seem to be corr... Greg Shah
12:38 PM Bug #2076: DMO setter fails when parameter is BaseDataType
Example:... Costin Savin
12:34 PM Bug #2076 (Closed): DMO setter fails when parameter is BaseDataType
Costin Savin
11:32 AM Bug #2070: BlockManager Action disambiguation
Added the proposed update Costin Savin
10:53 AM Bug #2075: unknown literals in nested expressions
See #2053 where we are creating a parameter type lookup facility for builtin funcs and methods. Greg Shah
10:20 AM Bug #2075: unknown literals in nested expressions
> One of the things I was interested in using the signature data for was during expression typing (we could know exac... Constantin Asofiei
09:52 AM Bug #2075: unknown literals in nested expressions
> Go ahead and commit the change and distribute it.
Committed to bzr revision 10237.
> If I understand properly, ...
Constantin Asofiei
09:46 AM Bug #2075: unknown literals in nested expressions
Go ahead and commit the change and distribute it.
If I understand properly, we are about to have compile issues wi...
Greg Shah
09:28 AM Bug #2075: unknown literals in nested expressions
> The question: how much code do we have that is dependent upon this unintended result? I prefer to cleanup the pars... Constantin Asofiei
09:07 AM Bug #2075: unknown literals in nested expressions
Actually, I am worried that the problem is really in how the parser leaves the tree. A pretty important rule about t... Greg Shah

03/03/2013

03:40 PM Bug #2069: Accumulator temp table field disambiguation
Some final notes for today:
# the @CREATE real@ statement produces a free reference, same as a @FIND FIRST real@. If...
Constantin Asofiei
12:32 PM Bug #2069: Accumulator temp table field disambiguation
Good information in note 3.
1. You have proven that the ACCUM() function parameters are not free references, they ...
Greg Shah
06:40 AM Bug #2069: Accumulator temp table field disambiguation
First of all, looks like ACCUM function should not produce free-references, because if it did produce, then the code ... Constantin Asofiei
11:46 AM Bug #2075: unknown literals in nested expressions
The fix has passed conversion regression testing. Constantin Asofiei
08:06 AM Bug #2075: unknown literals in nested expressions
P2J fails to convert this case:... Constantin Asofiei
07:22 AM Bug #2075 (WIP): unknown literals in nested expressions
Constantin Asofiei

03/02/2013

06:11 PM Feature #2074: add CAN-QUERY() and CAN-SET() support
The ges_upd20130302b.zip passed conversion testing and checked in as bzr revision 10233. Greg Shah
05:40 PM Feature #2074: add CAN-QUERY() and CAN-SET() support
This code provides the conversion support for these builtin functions. It also stubs out the methods in HandleOps. ... Greg Shah
05:38 PM Feature #2074 (Closed): add CAN-QUERY() and CAN-SET() support
Greg Shah
08:15 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Passed conversion testing and checked in as bzr revision 10230. Greg Shah

03/01/2013

05:17 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
This passed testing, but in further processing of the customer code, another (virtually identical) NPE was encountere... Greg Shah
03:29 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Attached is the fix (and testcase updates) for this case. Based on testing in the 4GL, one can indeed have the retur... Greg Shah
02:10 PM Bug #2070: BlockManager Action disambiguation
Code Feedback:
In regard to the converted class names, there are several problems that have to be addressed:
1....
Greg Shah
12:20 PM Bug #2070: BlockManager Action disambiguation
I haven't reviewed your update, but yes, that approach is OK. I was responding to Constantin's idea about maintainin... Eric Faulhaber
12:14 PM Bug #2070: BlockManager Action disambiguation
I used isDMOInterface(String) in the defined function usedClassName (core_conversion.xml) from the proposed update to... Costin Savin
12:09 PM Bug #2070: BlockManager Action disambiguation
BTW, if this is called more than once, we will want to optimize it, because it copies large sets of strings. Eric Faulhaber
12:07 PM Bug #2070: BlockManager Action disambiguation
...and the attachment. Eric Faulhaber
12:06 PM Bug #2070: BlockManager Action disambiguation
Here, give this a try. Register P2OAccessWorker in TRPL and call @getAllDMOInterfaceNames()@ to return a set of all ... Eric Faulhaber
11:58 AM Bug #2070: BlockManager Action disambiguation
Added proposed update Costin Savin
11:31 AM Bug #2070: BlockManager Action disambiguation
Greg, do we have a way of knowing if a certain name is for a converted class name (associated with the external progr... Constantin Asofiei
11:26 AM Bug #2070: BlockManager Action disambiguation
Please look at the com.goldencode.p2j.schema.P2OAccessWorker as a better solution than manually parsing the dmo_index... Greg Shah
11:22 AM Bug #2070: BlockManager Action disambiguation
Please do the following and re-upload:
# rename dmoUsedNames to usedClassNames (idea is, to save all generated class...
Constantin Asofiei
11:07 AM Bug #2070: BlockManager Action disambiguation
Added proposed update. Solution was to parse the dmo_index.xml file and retrieve the existing dmo names in a global H... Costin Savin

02/28/2013

06:48 PM Bug #2056 (Closed): null value for an annotation while persisting the AST
Greg Shah
06:47 PM Bug #2056: null value for an annotation while persisting the AST
Passed conversion testing and is checked into bzr as revision 10226. Greg Shah
05:31 PM Bug #2056: null value for an annotation while persisting the AST
OK, some findings:
1. Generally, @@@ base-field can only be used in a DISPLAY stmt and in the column_spec of a DEF...
Greg Shah
06:10 PM Feature #2063: Support negative numbers defined with the "-" on the right side
The lexer cannot easily change its behavior in response to feedback from the parser. This is a core limitation of AN... Greg Shah
04:30 PM Feature #2063: Support negative numbers defined with the "-" on the right side
We have a case where the @999.99-@ literal is converted to @new date("999.99-")@ instead of decimal:... Constantin Asofiei
02:51 PM Bug #2070: BlockManager Action disambiguation
Keep in mind that BUFFER_SCOPE is for DMOs beeing used by the current program, and not all the existing DMOs. I think... Constantin Asofiei
02:35 PM Bug #2070: BlockManager Action disambiguation
Can the "classname" annotation of BUFFER_SCOPE be used safely to get that checked? Costin Savin
02:12 PM Bug #2070: BlockManager Action disambiguation
Costin, looks like we need another check: if there is a DMO class with the Action name, then qualify Action with Bloc... Constantin Asofiei
11:47 AM Bug #2070: BlockManager Action disambiguation
This is fine for now. Ultimately, we will need to do this on a more global scale for all names. Please get it conver... Greg Shah
11:39 AM Bug #2070: BlockManager Action disambiguation
Added proposed update Costin Savin
10:43 AM Bug #2070: BlockManager Action disambiguation
Do you think it's better to replace Action.<enum_val> with BlockManager.Action.<enum_val> allways or check file name ... Costin Savin
10:40 AM Bug #2070: BlockManager Action disambiguation
When we have a progress file named action and it contains a block which will emit a reference to the Action enum of t... Costin Savin
10:35 AM Bug #2070 (Closed): BlockManager Action disambiguation
Costin Savin
11:02 AM Bug #2069: Accumulator temp table field disambiguation
After the note 75 in the 1985, looks like this is a true buffer disambiguation problem, which can be duplicated using... Constantin Asofiei
06:09 AM Bug #2069: Accumulator temp table field disambiguation
For the following testcase we define a temp table fit a field name that already exists in a permanent table and use i... Costin Savin
05:58 AM Bug #2069 (Closed): Accumulator temp table field disambiguation
If we create a temp table with a field name that coincides with a field from an existent permanent table and use accu... Costin Savin

02/27/2013

06:13 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
A new context analysis problem has been found in #1985 (see note 63). The 2nd operand of the PLUS is a FIELD_DEC typ... Greg Shah
05:43 PM Bug #2056: null value for an annotation while persisting the AST
One other point: I think if we get the parser right, the downstream processing may be much simpler. Today, we have t... Greg Shah
05:41 PM Bug #2056: null value for an annotation while persisting the AST
After looking at this in detail, it is clear that this is something that I need to work on. Both of you should work ... Greg Shah
10:32 AM Bug #2056: null value for an annotation while persisting the AST
This code works in P2J:... Greg Shah
09:47 AM Bug #2056: null value for an annotation while persisting the AST
I was trying to force the rules to see the var definition hidden in the format_phrase node, and emit widget + var for... Constantin Asofiei
09:36 AM Bug #2056: null value for an annotation while persisting the AST
I can help with this.
Constantin: do you have any other findings to report?
We do support @-base fields alrea...
Greg Shah
12:14 PM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
For details, please see notes 6 and 7 of #2063. Greg Shah
12:13 PM Bug #2065 (Closed): ambiguity in date/decimal literals that is not handled properly by the Progre...
Greg Shah
12:12 PM Feature #2063 (Closed): Support negative numbers defined with the "-" on the right side
Greg Shah
11:39 AM Feature #2063: Support negative numbers defined with the "-" on the right side
Commited to bzr as revision number 10220. Costin Savin
11:17 AM Feature #2063: Support negative numbers defined with the "-" on the right side
Has passed conversion regression testing (no changes in generated sources), please check in and distribute. Constantin Asofiei
09:30 AM Feature #2063: Support negative numbers defined with the "-" on the right side
I'm OK with it. Put it through conversion testing. Greg Shah
09:28 AM Feature #2063: Support negative numbers defined with the "-" on the right side
Added proposed update Costin Savin
09:08 AM Feature #2063: Support negative numbers defined with the "-" on the right side
The coding changes look OK. Moving the sign to the left was what I was going to propose. Make sure you remove the e... Greg Shah
09:06 AM Feature #2063: Support negative numbers defined with the "-" on the right side
We must be very careful here.... Greg Shah
08:18 AM Feature #2063: Support negative numbers defined with the "-" on the right side
Please test with these cases too:... Constantin Asofiei
08:02 AM Feature #2063: Support negative numbers defined with the "-" on the right side
Added proposed update which corrects the assignment. Costin Savin
06:44 AM Feature #2063: Support negative numbers defined with the "-" on the right side
Update looks good, this is going through conversion regression testing now. Constantin Asofiei
06:13 AM Feature #2063: Support negative numbers defined with the "-" on the right side
This update fixes conversion side but there is still work to do to have the correct value set. Costin Savin
04:37 AM Feature #2063: Support negative numbers defined with the "-" on the right side
Statements like: ... Costin Savin
04:31 AM Feature #2063 (Closed): Support negative numbers defined with the "-" on the right side
Costin Savin
10:35 AM Bug #2061: unreachable code is too aggressive when shared vars are used
Greg Shah wrote:
> Everything looks good here, except the copyright dates in the new ruleset. You can check in a fi...
Constantin Asofiei
09:09 AM Bug #2061 (Closed): unreachable code is too aggressive when shared vars are used
Everything looks good here, except the copyright dates in the new ruleset. You can check in a fix without any furthe... Greg Shah
08:00 AM Bug #2061 (Review): unreachable code is too aggressive when shared vars are used
This has passed conversion regression testing on MAJIC, no resurfaced dead-code.
Committed to bzr revision 10218.
Constantin Asofiei
06:28 AM Bug #2061: unreachable code is too aggressive when shared vars are used
I'm reposting cause I had a left behind printfln. Constantin Asofiei
06:11 AM Bug #2061: unreachable code is too aggressive when shared vars are used
My reachable processing was too aggressive, I'm putting this into conversion regression testing. Constantin Asofiei
08:09 PM Bug #2061: unreachable code is too aggressive when shared vars are used
I've checked converted sources, there is some resurrected dead-code in MAJIC that should not affect runtime; MAJIC di... Constantin Asofiei
07:02 PM Bug #2061: unreachable code is too aggressive when shared vars are used
renamed to not conflict... Constantin Asofiei
07:00 PM Bug #2061: unreachable code is too aggressive when shared vars are used
This code fixes this testcase, I will test the server file and regression conversion testing. Constantin Asofiei
08:00 PM Bug #2060 (Closed): forward function definitions that include a parameter name can "fixup" missin...
Greg Shah
08:00 PM Bug #2060: forward function definitions that include a parameter name can "fixup" missing paramet...
Passed conversion and is checked into bzr as revision 10216. Greg Shah

02/26/2013

06:37 PM Bug #2061: unreachable code is too aggressive when shared vars are used
I think the solution is to not remove vars/buffers/etc marked as unreachable if there are reachable nodes with a refi... Constantin Asofiei
06:00 PM Bug #2061: unreachable code is too aggressive when shared vars are used
unreachable code is removed and with it defined vars. following conversion fails:... Constantin Asofiei
05:58 PM Bug #2061 (Closed): unreachable code is too aggressive when shared vars are used
Constantin Asofiei
05:01 PM Feature #1884: add some of the v10 data types and core built-ins
Passed conversion regression testing, committed to bzr revision 10215. Constantin Asofiei
03:25 PM Feature #1884: add some of the v10 data types and core built-ins
The server project has a case of:... Constantin Asofiei
04:15 PM Bug #2060: forward function definitions that include a parameter name can "fixup" missing paramet...
Attached is the update that resolves this issue. It will duplicate the non-forward function definition's buffer para... Greg Shah
02:58 PM Bug #2060: forward function definitions that include a parameter name can "fixup" missing paramet...
I tested various combinations of other parameter types:
- the regular AS "primitive" types (CHAR, INT, LOGICAL...)...
Greg Shah
12:55 PM Bug #2060: forward function definitions that include a parameter name can "fixup" missing paramet...
In #1985 (see notes 29, 36 - 43 in that task) we found that forward function definitions that include a parameter nam... Greg Shah
12:52 PM Bug #2060 (Closed): forward function definitions that include a parameter name can "fixup" missin...
Greg Shah
02:36 PM Bug #2056: null value for an annotation while persisting the AST
The NPE is thrown because the function "copy_as_widget" attempts to duplicate an incomplete (missing "getter" annotat... Ovidiu Maxiniuc
10:13 AM Bug #2056: null value for an annotation while persisting the AST
Ovidiu, for now try and fix the "display c @ b as datatype" case, leave that for later. Constantin Asofiei
10:12 AM Bug #2056: null value for an annotation while persisting the AST
I looked into manuals about the @base-field specification, but they only describe how data is displayed into the resp... Ovidiu Maxiniuc
08:25 AM Bug #2056: null value for an annotation while persisting the AST
Note that the following case is converted correctly by P2J:... Constantin Asofiei
08:17 AM Bug #2056: null value for an annotation while persisting the AST
This is a task that tracks the issues reported by Eric in #1985, note 19.
I tried to eliminate the issue by pinpoint...
Ovidiu Maxiniuc
08:05 AM Bug #2056 (Closed): null value for an annotation while persisting the AST
Ovidiu Maxiniuc
12:13 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Passed conversion testing and is checked in as bzr revision 10211. Runtime recursion testing is deferred. Greg Shah
10:57 AM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
The issue is caused by the over-simplistic recursion protection in our context analysis. In addition, even in the ca... Greg Shah
10:53 AM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
From #1985:
ra/ folder fails with:...
Greg Shah
03:42 AM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
> Somehow, the improved expression typing changes the INPUT FUNC_POLY processing. As far as I know, these are equiva... Constantin Asofiei
08:52 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
I believe this is passing conversion testing.
The following diffs are present:...
Greg Shah
07:50 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Yes, it does seem to resolve the problem in raam/. Now we get a different error (see #1985). Greg Shah
07:48 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
I have implemented major changes to ExpressionConversionWorker.expressionType() to do the following:
1. Add suppor...
Greg Shah
10:40 AM Feature #1920: implement persistent procedures
Conversion regression testing has passed, committed to bzr revision 10210. Constantin Asofiei
09:05 AM Feature #1920: implement persistent procedures
It looks good. Greg Shah
08:58 AM Feature #1920: implement persistent procedures
The removeQuotes change, I'm running regression conversion testing again. Constantin Asofiei
08:55 AM Feature #1920: implement persistent procedures
OK, so I'm dropping the functions.rules change and I'll change CommonAstSupport.removeQuotes. Note that removeQuotes ... Constantin Asofiei
08:44 AM Feature #1920: implement persistent procedures
OK. You can use the same approach as progressToJavaString() for dropping the quotes (and any following options):
<...
Greg Shah
08:41 AM Feature #1920: implement persistent procedures
About issue 1: I don't think is OK to convert the string to Java, as currently I need to match with a Progress legacy... Constantin Asofiei
08:35 AM Feature #1920: implement persistent procedures
Code Feedback:
1. Strings can be qualified with more than just the @:U@. Your code assumes there can only be 1 qu...
Greg Shah
07:33 AM Feature #1920: implement persistent procedures
No changes in generated MAJIC sources. Greg, if the update looks good to you, I will release it. Constantin Asofiei
05:55 AM Feature #1920: implement persistent procedures
Handle the case of single quotes used with function names and others (removeQuotes was improved to remove enclosing s... Constantin Asofiei
05:44 AM Feature #1920: implement persistent procedures
This update fixes a bug in dynamic-function's func name resolution, for cases like:... Constantin Asofiei
08:21 AM Feature #2048 (Closed): BUFFER parameters without name in forward function definitions
Greg Shah
06:17 AM Feature #2048: BUFFER parameters without name in forward function definitions
Commited to bazaar as revision number 10209. Costin Savin
05:44 AM Feature #2048: BUFFER parameters without name in forward function definitions
Update has passed conversion regression testing, please check in and distribute. Constantin Asofiei
04:46 AM Feature #2048: BUFFER parameters without name in forward function definitions
The update looks OK, is going through conversion regression testing now. Constantin Asofiei
04:44 AM Feature #2048: BUFFER parameters without name in forward function definitions
Added proposed update Costin Savin
07:58 PM Feature #2051 (Closed): conversion support for ATTR_POLY/METH_POLY used as rvalue or in expression
Greg Shah

02/25/2013

02:36 PM Feature #1647: implement an option for SETUSERID and USERID to be backed by a replacement for the...
Committed in bzr as 10203. Eugenie Lyzenko
02:27 PM Feature #1647: implement an option for SETUSERID and USERID to be backed by a replacement for the...
Conversion testing passed. Please check this in and distribute it. Greg Shah
12:49 PM Feature #1647: implement an option for SETUSERID and USERID to be backed by a replacement for the...
This looks good. I will put it into conversion testing now. Greg Shah
12:41 PM Feature #1647: implement an option for SETUSERID and USERID to be backed by a replacement for the...
The suggested update has been uploaded. Also I have appended simple test and conversion result. The code drop merged ... Eugenie Lyzenko
09:49 AM Feature #1647: implement an option for SETUSERID and USERID to be backed by a replacement for the...
I should have provided more information previously, sorry.
For now, all that needs to be done is to add support fo...
Greg Shah
09:42 AM Feature #1647: implement an option for SETUSERID and USERID to be backed by a replacement for the...
Let me clarify some points.
1. Is the _USER table already implemented in P2J?
2. My work is to add conversion suppo...
Eugenie Lyzenko
02:27 PM Bug #2049 (Closed): SET statement and NO-ERROR clause
Greg Shah
02:25 PM Bug #2049: SET statement and NO-ERROR clause
Conversion testing has passed. I have checked it in as bzr revision 10102. Greg Shah
12:11 PM Bug #2049: SET statement and NO-ERROR clause
But since I haven't tested that assumption (that no-error always will appear at the end), I think it is best to go wi... Greg Shah
12:09 PM Bug #2049: SET statement and NO-ERROR clause
Added the new archive, I will remove the older, unneeded one.
I believe that @isWidget@ is used as a flag when sca...
Ovidiu Maxiniuc
11:37 AM Bug #2049: SET statement and NO-ERROR clause
It is not clear to me whether we should have a section like this:... Greg Shah
11:15 AM Bug #2049 (Review): SET statement and NO-ERROR clause
Looks like the @N0-ERROR@ clause was treated as an widget in the list of parameters of the statements (@SET@, @ASSIGN... Ovidiu Maxiniuc
11:04 AM Bug #2049 (WIP): SET statement and NO-ERROR clause
Ovidiu Maxiniuc
08:58 AM Bug #2049: SET statement and NO-ERROR clause
Conversion fails in a case like... Constantin Asofiei
08:57 AM Bug #2049 (Closed): SET statement and NO-ERROR clause
Constantin Asofiei
02:20 PM Feature #2048: BUFFER parameters without name in forward function definitions
Keep in mind that the FORWARD declaration should not be changing buffer scoping at all. My guess is that somewhere w... Greg Shah
02:19 PM Feature #2048: BUFFER parameters without name in forward function definitions
Actually, both results look wrong. doubler2() gets an openScope() with the same buffer name passed twice. That may ... Greg Shah
01:59 PM Feature #2048: BUFFER parameters without name in forward function definitions
The conversion fails because of code in record_scoping_prep.rules which assumes the buffer annotation is in the copy.... Costin Savin
08:56 AM Feature #2048: BUFFER parameters without name in forward function definitions
Conversion fails in this case:... Constantin Asofiei
08:53 AM Feature #2048 (Closed): BUFFER parameters without name in forward function definitions
Constantin Asofiei
11:21 AM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
The issue only occurs for those ATTR_POLY/FUNC_POLY/METH_POLY cases where we cannot detect the type based on the chil... Greg Shah
10:20 AM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
I wonder if ExpressionConversionWorker should ignore these _POLY cases ? And determine the expression type based on t... Constantin Asofiei
10:16 AM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
The problem I was working (in #1655) is the same problem. I "fixed" it by eliminating the use of expressionType() in... Greg Shah
10:02 AM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Conversion for ATTR_POLY used in complex expressions fails, as the ExpressionConversionWorker can't determine the typ... Constantin Asofiei
09:56 AM Feature #2050 (Closed): ATTR_POLY/METH_POLY used as rvalue or in expressions
Constantin Asofiei
09:57 AM Feature #2051: conversion support for ATTR_POLY/METH_POLY used as rvalue or in expression
This is for milestone 4 time tracking only. All comments must be added in parent task #2050 Constantin Asofiei
09:57 AM Feature #2051 (Closed): conversion support for ATTR_POLY/METH_POLY used as rvalue or in expression
Constantin Asofiei

02/24/2013

03:52 PM Feature #1627 (Closed): support for empty EXPORT statements
Greg Shah
03:43 PM Feature #1627: support for empty EXPORT statements
The evl_upd20130224a.zip has been committed in bzr as 10197. Eugenie Lyzenko
03:32 PM Feature #1627: support for empty EXPORT statements
This has passed conversion testing. Go ahead and check it in and distribute it. Greg Shah
02:33 PM Feature #1627: support for empty EXPORT statements
The code looks good. I will run conversion testing now. Greg Shah
01:43 PM Feature #1627: support for empty EXPORT statements
The modified post_parse_fixups.xml and new rule have been uploaded to eliminate empty export. Also the converted code... Eugenie Lyzenko
06:16 AM Feature #2013: implement the SELF system handle
Committed to bzr revision 10194, passed runtime regression testing. Constantin Asofiei

02/23/2013

05:43 PM Feature #2013: implement the SELF system handle
The change looks fine. This is being conversion tested now. Greg Shah
01:30 PM Feature #2013: implement the SELF system handle
Fixed initialization of context-local data in SelfManager. Constantin Asofiei
10:14 PM Feature #2013: implement the SELF system handle
Passed conversion testing. Checked into bzr as 10189. Greg Shah
05:27 PM Feature #2021 (Closed): conversion support for web services
Greg Shah
05:26 PM Feature #1645: implement web services support
With this change, testing passed. Checked into bzr as 10193. Greg Shah
04:19 PM Feature #1645: implement web services support
This update causes a problem with many (all?) RUN statements. Here is a common example diff (this is broken througho... Greg Shah
12:21 PM Feature #1645: implement web services support
This is in testing now. Greg Shah
11:54 AM Feature #1645: implement web services support
It looks good. This will go into conversion testing next. Greg Shah
11:46 AM Feature #1645: implement web services support
Attached update fixes the refAsync issue and refSet.move (which should move to copy not refAsync) Constantin Asofiei
11:39 AM Feature #1645: implement web services support
Everything else looks OK with the code. Greg Shah
11:38 AM Feature #1645: implement web services support
In fixups/control_flow.rules refAsync is never assigned, but it is relied upon in the ASYNCH ON case and in the SET h... Greg Shah
11:26 AM Feature #1645: implement web services support
Built on top of #1782 23d.zip update. Fixed support for @RUN ... SET hPortType ON hWebServ@ statement. Added support ... Constantin Asofiei
08:39 AM Feature #1645: implement web services support
More info about RUN ... SET ... ON SERVER. Something like this works:... Constantin Asofiei
05:28 AM Feature #1645: implement web services support
Another later edit: it is possible to use the @SET hPortType@ specification even with the @TRANSACTION DISTINCT@ and ... Constantin Asofiei
04:51 AM Feature #1645: implement web services support
> fix the @RUN SET ... ON SERVER@ statement
Look like the ASYNC clause is supported (at least at compile-time) for th...
Constantin Asofiei
04:28 AM Feature #1645: implement web services support
For the Server object handle, all documented attributes/methods are supported except these:
# REQUEST-INFO, RESPONSE...
Constantin Asofiei
11:51 AM Feature #2041 (Closed): implement runtime support for "shared" attributes that are just stubbed
Greg Shah
11:50 AM Feature #2002 (Closed): refactor some "shared" attributes
Greg Shah
10:14 PM Feature #2014 (Closed): conversion support for SELF system handle
Greg Shah

02/22/2013

04:31 PM Feature #2013: implement the SELF system handle
Here is the right version. Greg Shah
04:27 PM Feature #2013: implement the SELF system handle
This is the latest version merged up to bzr 10188. It will go into testing next. Greg Shah
02:17 PM Feature #2013: implement the SELF system handle
> I think it might be more correct to say that the rule-set only handles the resource reference for handle types. In... Constantin Asofiei
01:46 PM Feature #2013: implement the SELF system handle
The code looks good.... Greg Shah
01:33 PM Feature #2013: implement the SELF system handle
> 1. refName is a dead variable and can be removed from methods_attributes.rules.
OK, removed
> 2. How do we emit t...
Constantin Asofiei
12:34 PM Feature #2013: implement the SELF system handle
Code Feedback:
1. refName is a dead variable and can be removed from methods_attributes.rules.
2. How do we emi...
Greg Shah
12:14 PM Feature #2013: implement the SELF system handle
Conversion regression testing has passed - compilation was OK, all changes are expected. Constantin Asofiei
06:39 AM Feature #2013: implement the SELF system handle
Conversion has finished, there was a APPLY ... TO SELF problem, fixed in attached update. All other changes look good... Constantin Asofiei
03:22 AM Feature #2013: implement the SELF system handle
Added testcases (previous were for session handle) Constantin Asofiei
03:20 AM Feature #2013: implement the SELF system handle
-Added testcases.- they are for session handle, I've deleted it from here. Constantin Asofiei
03:18 AM Feature #2013: implement the SELF system handle
Fixed a conversion error, I'm running conversion again. Constantin Asofiei
01:21 PM Feature #2003 (Closed): conversion support for SESSION handle
Greg Shah
01:16 PM Feature #1612: finish SESSION system handle support
Committed to bzr revision 10187. Constantin Asofiei
01:03 PM Feature #1612: finish SESSION system handle support
Conversion testing has passed. Please check in and distribute. Greg Shah
12:02 PM Feature #1612: finish SESSION system handle support
The update looks good. I'm testing it now. Greg Shah
11:43 AM Feature #1612: finish SESSION system handle support
Merged with revision 10186. Constantin Asofiei
11:10 AM Feature #1612: finish SESSION system handle support
The code looks fine. I'll re-check after the merge. Greg Shah
03:22 AM Feature #1612: finish SESSION system handle support
Added tests. Constantin Asofiei
03:19 AM Feature #1612: finish SESSION system handle support
Merged with 10183, fixed some runtime errors too (ERROR-STATUS handle could not initialize its static proxy). Constantin Asofiei
11:53 AM Feature #2009 (Closed): conversion support for LANDSCAPE/PORTRAIT I/O option
Greg Shah
11:49 AM Feature #2011 (Closed): conversion support for _MSG() built-in
Greg Shah
11:46 AM Feature #1632: implement _MSG() undocumented built-in function
Conversion tests passed , commited to bazaar as revision 10186 Costin Savin
09:03 AM Feature #1632: implement _MSG() undocumented built-in function
The update looks good. I will start testing it shortly. Greg Shah
11:27 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
Conversion test passed, commited to bazaar as revision 10185 Costin Savin
09:10 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
The update looks good. I will start testing it shortly. I am deleting the update that is not matching, so that ther... Greg Shah
09:07 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
Attached it Costin Savin
09:06 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
This is the wrong update (it is for the _MSG work). Please post the correct one. Greg Shah
04:26 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
Added merged update Costin Savin
11:14 AM Feature #1979 (Closed): conversion support for DOM XML processing
Greg Shah
11:10 AM Feature #1640: implement DOM XML support
The update evl_upd20130222a.zip passed the conversion test and committed in bzr as 10184. Eugenie Lyzenko
09:02 AM Feature #1640: implement DOM XML support
The update looks good. I will start testing it shortly. Greg Shah
05:56 AM Feature #1640: implement DOM XML support
The merged code has been uploaded for testing. The setSubType methods unified with name syntax of the SubTypeAttribut... Eugenie Lyzenko
03:02 AM Feature #2002: refactor some "shared" attributes
Committed to bzr revision 10182. Constantin Asofiei

02/21/2013

02:55 PM Feature #2002: refactor some "shared" attributes
FYI:... Greg Shah
01:33 PM Feature #2002: refactor some "shared" attributes
Fixed issues 1 to 4, merged with 10181. Constantin Asofiei
01:24 PM Feature #2002: refactor some "shared" attributes
Greg Shah wrote:
> 6. Wasn't the idea behind the BufferField design was to avoid get/set methods that could conflict...
Eric Faulhaber
01:13 PM Feature #2002: refactor some "shared" attributes
> 1. Please put a TODO comment into BrowseColumnWidget that it should not always return "FILL-IN" as its type. From ... Constantin Asofiei
12:50 PM Feature #2002: refactor some "shared" attributes
Code Review Feedback:
1. Please put a TODO comment into BrowseColumnWidget that it should not always return "FILL-...
Greg Shah
12:11 PM Feature #2002: refactor some "shared" attributes
> Also, please prepare any Majic changes that need to be made.
See #2023
Constantin Asofiei
12:07 PM Feature #2002: refactor some "shared" attributes
There are 2 check-ins that will occur shortly. Be prepared to merge up to the lastest level. Also, please prepare a... Greg Shah
10:45 AM Feature #2002: refactor some "shared" attributes
There is one MAJIC-side change needed, as GenericWidget.getFormat now returns character instead of String (I chose to... Constantin Asofiei
10:40 AM Feature #2002: refactor some "shared" attributes
The only change in generated code is the one related to label: now it unwraps using @handle.unwrapCommonField@, inste... Constantin Asofiei
05:40 AM Feature #2002 (WIP): refactor some "shared" attributes
Constantin Asofiei
05:33 AM Feature #2002: refactor some "shared" attributes
This update cleans #1668 errors + refactors attributes. I'm running conversion now, I'll let you know how it goes.
L...
Constantin Asofiei
12:12 PM Feature #1640: implement DOM XML support
I have looked into current bzr. There is one point need to be discussed. The attribute SUBTYPE has implemented as sta... Eugenie Lyzenko
12:10 PM Feature #2013: implement the SELF system handle
I'm leaving a conversion to run over night, hopefully all SELF-handle usage will convert nicely. Constantin Asofiei
10:20 AM Feature #2013: implement the SELF system handle
I like it. Greg Shah
06:23 AM Feature #2013 (WIP): implement the SELF system handle
Attached update with proposed solution (built on top of revision 10179). With this approach, all attribute/method acc... Constantin Asofiei
05:58 AM Feature #2013: implement the SELF system handle
How I see this working: we have a SelfManager class which manages a stack of "self" handles. Each event responsible ... Constantin Asofiei
11:47 AM Feature #1612: finish SESSION system handle support
Added support for the high-priority stuff (built on top of revision 10179, was easier that way) plus stubs for some a... Constantin Asofiei
07:12 AM Feature #1612: finish SESSION system handle support
List of not supported attributes:
* progress.g parser errors:...
Constantin Asofiei
08:00 AM Feature #1632: implement _MSG() undocumented built-in function
Looks good. I will let you know when we can test. Only conversion regression testing will be needed. Be prepared t... Greg Shah
04:45 AM Feature #1632: implement _MSG() undocumented built-in function
Corrected javadoc, was meant to say first: greater or equal 1, then I though greater than 0 to be better as descripti... Costin Savin
06:35 AM Feature #2003 (WIP): conversion support for SESSION handle
Constantin Asofiei
06:34 AM Feature #2014 (WIP): conversion support for SELF system handle
Constantin Asofiei
07:20 PM Feature #2022: runtime support for web services
This task is only for time tracking and association with the milestone. All history goes in parent task #1645. Greg Shah
07:20 PM Feature #2022 (Closed): runtime support for web services
Greg Shah
07:20 PM Feature #2021: conversion support for web services
This task is only for time tracking and association with the milestone. All history goes in parent task #1645. Greg Shah
07:19 PM Feature #2021 (Closed): conversion support for web services
Greg Shah

02/20/2013

06:57 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function
After a quick review of the handle.java class and the builtin_functions.rules, I can see the following:
1. WIDGET-...
Greg Shah
06:20 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function
The use cases (and even the description of the function) seem to be identical to the HANDLE() builtin function. A te... Greg Shah
02:09 PM Feature #1990 (Closed): conversion support for appserver
Greg Shah
02:00 PM Feature #1608: implement full appserver support (from 4GL clients only)
Committed to bzr revision 10179. Constantin Asofiei
01:44 PM Feature #1608: implement full appserver support (from 4GL clients only)
The changes passed regression testing. Please check them into bzr and distribute the update. Greg Shah
01:43 PM Feature #1632: implement _MSG() undocumented built-in function
The code looks good. I only have 1 question. The javadoc says this:... Greg Shah
10:26 AM Feature #1632: implement _MSG() undocumented built-in function
Added proposed update Costin Savin
10:07 AM Feature #1632: implement _MSG() undocumented built-in function
OK, this is more clear.
As far as the negative numbers are concerned, we won't duplicate that behavior right now. ...
Greg Shah
09:26 AM Feature #1632: implement _MSG() undocumented built-in function
I realized the 0 index difference happened because I mistakenly rerun the program in some cases using the character e... Costin Savin
09:03 AM Feature #1632: implement _MSG() undocumented built-in function
Please upload the msg_test.txt and msg_test2.txt output files so that I can better understand what is going on.
> ...
Greg Shah
08:37 AM Feature #1632: implement _MSG() undocumented built-in function
Done more testing and got a better understanding of how msg working.
It seems the _msg(int) will return the error num...
Costin Savin
12:02 PM Feature #2011 (Review): conversion support for _MSG() built-in
Costin Savin
08:28 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
It is good to go. I will let you know when we can schedule it. Because there are some updates in front, please be r... Greg Shah
03:04 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
Added proposed update. Costin Savin

02/19/2013

05:21 PM Feature #2015: runtime support for SELF system handle
This is just for time tracking and association with milestone 4. All history goes in parent task #2013. Greg Shah
05:21 PM Feature #2015 (Closed): runtime support for SELF system handle
Greg Shah
05:21 PM Feature #2014: conversion support for SELF system handle
This is just for time tracking and association with milestone 4. All history goes in parent task #2013. Greg Shah
05:20 PM Feature #2014 (Closed): conversion support for SELF system handle
Greg Shah
05:19 PM Feature #2013: implement the SELF system handle
The SELF system handle returns the handle to the resource currently being processed in a trigger or other callback pr... Greg Shah
05:15 PM Feature #2013 (Closed): implement the SELF system handle
Greg Shah
05:03 PM Feature #1640: implement DOM XML support
The update looks good. We will try to get it scheduled soon, but you will probably have to merge up to the bzr head ... Greg Shah
09:02 PM Feature #1640: implement DOM XML support
The update for new attributes/methods has been uploaded for review. Eugenie Lyzenko
04:57 PM Feature #1608: implement full appserver support (from 4GL clients only)
We don't need to handle the Asynchronous request handle object for milestone 4. We will probably go ahead and implem... Greg Shah
08:59 AM Feature #1608: implement full appserver support (from 4GL clients only)
This code fixes the unsuscribe_stmt clause (I've tested will all proc-related events tests and they passed). Conversi... Constantin Asofiei
06:21 AM Feature #1608: implement full appserver support (from 4GL clients only)
I don't see the Asynchronous request object handle mentioned in this task, but please let me know if this is necessar... Constantin Asofiei
04:33 PM Feature #2002: refactor some "shared" attributes
Please go ahead with this task in combination with #1974 (#1668). Prepare a single update that cleans all of this up. Greg Shah
01:32 PM Feature #2002: refactor some "shared" attributes
I think the best grouping should be this:
# COLUMN-LABEL (BUFFER-FIELD), DATA-TYPE(BUFFER-FIELD, WIDGET), FORMAT(BUF...
Constantin Asofiei
08:51 AM Feature #2002: refactor some "shared" attributes
Except DATA-TYPE and FORMAT (which are common for BUFFER-FIELD and widgets), I don't see any way of grouping these at... Constantin Asofiei
03:34 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
Feedback:
Please fix the code formatting issues in Stream.java (there are several):
1. Header # is wrong.
2. W...
Greg Shah
12:08 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
Added proposed update Costin Savin
07:07 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
The following is an example of the option in use:... Greg Shah
02:20 PM Feature #1632: implement _MSG() undocumented built-in function
From your status report:
> Tested the _msg function , results seems to not be consistent for the same value.
P...
Greg Shah
07:12 PM Feature #1632: implement _MSG() undocumented built-in function
This is an undocumented built-in function. We need to determine what it does. at a high level it is used to create ... Greg Shah
12:09 PM Feature #2011 (WIP): conversion support for _MSG() built-in
Costin Savin
07:13 PM Feature #2011: conversion support for _MSG() built-in
This task is only for time tracking and association with milestone 4. All history should be placed in the parent tas... Greg Shah
07:13 PM Feature #2011 (Closed): conversion support for _MSG() built-in
Greg Shah
05:03 AM Feature #2009 (WIP): conversion support for LANDSCAPE/PORTRAIT I/O option
Costin Savin
07:01 PM Feature #2009: conversion support for LANDSCAPE/PORTRAIT I/O option
This task is only for time tracking and association with milestone 4. All history should be placed in the parent tas... Greg Shah
07:01 PM Feature #2009 (Closed): conversion support for LANDSCAPE/PORTRAIT I/O option
Greg Shah
07:14 PM Feature #2012: runtime support for _MSG() built-in
This task is only for time tracking and association with milestone 4. All history should be placed in the parent tas... Greg Shah
07:14 PM Feature #2012 (Closed): runtime support for _MSG() built-in
Greg Shah
07:02 PM Feature #2010: runtime support for LANDSCAPE/PORTRAIT I/O options
This task is only for time tracking and association with milestone 4. All history should be placed in the parent tas... Greg Shah
07:02 PM Feature #2010 (Closed): runtime support for LANDSCAPE/PORTRAIT I/O options
Greg Shah

02/18/2013

06:39 PM Feature #1627: support for empty EXPORT statements
Good. Then the solution is to do the following:
1. In post_parse_fixups.rules, you should add a new rule-set like...
Greg Shah
05:35 PM Feature #1627: support for empty EXPORT statements
> Let me make sure I understand. In export_test[1-3].p, if you remove the empty EXPORT statement from those files, do... Eugenie Lyzenko
05:20 PM Feature #1627: support for empty EXPORT statements
> This redirects output to the file and produces non-empty file with real values of the variable like printing to the... Greg Shah
04:29 PM Feature #1627: support for empty EXPORT statements
> When a stream is not explicitly used (e.g. EXPORT STREAM my-stream...) then you must first redirect the terminal li... Eugenie Lyzenko
04:15 PM Feature #1627: support for empty EXPORT statements
> EXPORT cannot be used with output to the screen. (1105)
When a stream is not explicitly used (e.g. EXPORT STREAM...
Greg Shah
02:55 PM Feature #1627: support for empty EXPORT statements
The statements
EXPORT var1 (some-var2 + 54) var3.
EXPORT database-table.
both have run-time error in 4GL:
...
E...
Eugenie Lyzenko
09:59 AM Feature #1627: support for empty EXPORT statements
It is possible to have an "empty" EXPORT statement in the 4GL, as in:... Greg Shah
06:19 PM Feature #1979 (WIP): conversion support for DOM XML processing
Greg Shah
06:19 PM Feature #1640: implement DOM XML support
I have found that the following are actually in use in the application and need to be added for milestone 4:
Attri...
Greg Shah
05:46 PM Feature #2004: runtime support for SESSION handle
This task is just for time tracking and association with milestone 4. Put all history into the parent task #1612. Greg Shah
05:46 PM Feature #2004 (Closed): runtime support for SESSION handle
Greg Shah
05:45 PM Feature #2003: conversion support for SESSION handle
This task is just for time tracking and association with milestone 4. Put all history into the parent task #1612. Greg Shah
05:45 PM Feature #2003 (Closed): conversion support for SESSION handle
Greg Shah
05:43 PM Feature #1612: finish SESSION system handle support
The following are high priority:
Attributes:
CLIENT-TYPE
FIRST-BUFFER
NUMERIC-SEPARATOR
NUMERIC-DECIMAL-POIN...
Greg Shah
05:14 PM Feature #1608: implement full appserver support (from 4GL clients only)
I have reviewed the code, the only problem is that the unsubscribe_stmt still cannot match on the event name after th... Greg Shah
04:25 PM Feature #1608: implement full appserver support (from 4GL clients only)
Attached update with the mentioned issues fixed. Constantin Asofiei
04:19 PM Feature #1608: implement full appserver support (from 4GL clients only)
> OK, so the idea the front phase should leave the ASTs as unchaged as possible.
Yes, that's right.
> Please le...
Greg Shah
04:10 PM Feature #1608: implement full appserver support (from 4GL clients only)
> I'm in the middle of the code review, but there is at least 1 major issue. The subscribe_stmt and unsubscribe_stmt... Constantin Asofiei
03:46 PM Feature #1608: implement full appserver support (from 4GL clients only)
More Feedback:
1. handle.java is missing the "--JPRM--" in the header.
2. Is HandleChain.setType() always going...
Greg Shah
03:25 PM Feature #1608: implement full appserver support (from 4GL clients only)
Code Review Feedback:
I'm in the middle of the code review, but there is at least 1 major issue. The subscribe_st...
Greg Shah
02:32 PM Feature #1608: implement full appserver support (from 4GL clients only)
Merged with revision 10178. Constantin Asofiei
02:01 PM Feature #1608: implement full appserver support (from 4GL clients only)
Attached update provides conversion support for app-server related statements and attributes/methods. Fixes progress.... Constantin Asofiei
12:00 PM Feature #1608: implement full appserver support (from 4GL clients only)
Greg Shah wrote:
> You will have to remove the expr option from that rule.
Yes, expr from widget_qualifier is no lo...
Constantin Asofiei
10:44 AM Feature #1608: implement full appserver support (from 4GL clients only)
I don't have a problem with your approach. I think it may work, but I do suspect there will be lookahead issues. Yo... Greg Shah
08:28 AM Feature #1608: implement full appserver support (from 4GL clients only)
I think the final solution is to get rid of the allowInProc quirk and call the widget_qualifier rule (in lvalue) only... Constantin Asofiei
04:20 PM Feature #1994 (Closed): conversion support for SOAP
Greg Shah
03:13 PM Feature #2002: refactor some "shared" attributes
Please implement appropriate interfaces for the following attributes which are shared between multiple resources:
...
Greg Shah
03:04 PM Feature #2002 (Closed): refactor some "shared" attributes
Greg Shah
02:25 PM Feature #1644: implement SOAP support
No changes in generated MAJIC sources, committed to bzr revision 10178. Constantin Asofiei
09:37 AM Feature #1644: implement SOAP support
And the latest update... Constantin Asofiei
09:37 AM Feature #1644: implement SOAP support
I've removed the trailing quotes. The conversion has been started on staging (with previous generated sources backedup). Constantin Asofiei
09:24 AM Feature #1644: implement SOAP support
I am OK with the update. The only thing I suggest is that the new javadoc entries have an unmatched trailing double ... Greg Shah
09:14 AM Feature #1644: implement SOAP support
Added update merged with bzr revision 10177. Constantin Asofiei
07:58 AM Feature #1644: implement SOAP support
> For these, 4GL allows only integer and int64 values (confirmed by testing).
OK. Please use long instead of int ...
Greg Shah
03:37 AM Feature #1644: implement SOAP support
> 1. The ErrorManager.WorkArea.soapFault member needs javadoc.
OK
> 2. For int parameters to methods like getHeader...
Constantin Asofiei
09:26 AM Feature #1987 (Closed): conversion support for SAX
Greg Shah
09:21 AM Feature #1620: implement EXTENT parameter support
Added testcases, for reference (they are in bzr too). Constantin Asofiei
08:29 AM Feature #1620: implement EXTENT parameter support
ca_upd20130218a.zip has been committed as 10175 (has passed regression testing). Constantin Asofiei
03:59 AM Feature #1620: implement EXTENT parameter support
This update fixes the following issues discovered on Saturday, during regression testing:
* ControlFlowOps NPE
* Bl...
Constantin Asofiei
09:18 AM Feature #1641: implement SAX XML support
The following attributes(SAX XML support) not yet implemented according to your note(a means SaxAttr, r means SaxRead... Eugenie Lyzenko
09:05 AM Feature #1641: implement SAX XML support
I have not cross-referenced your final code with the list of all possible features. Can you please make a list of al... Greg Shah
08:28 AM Feature #1641: implement SAX XML support
evl_upd20130215b.zip has been committed as 10176. Eugenie Lyzenko

02/17/2013

12:05 PM Feature #1644: implement SOAP support
Code Review Feedback:
1. The ErrorManager.WorkArea.soapFault member needs javadoc.
2. For int parameters to met...
Greg Shah
11:25 AM Feature #1644: implement SOAP support
OK, I understand now. Yes, this is an unfortunate side effect of our implementation. But at least the duplicate imp... Greg Shah
11:17 AM Feature #1608: implement full appserver support (from 4GL clients only)
> Do you want us to get into the high-level design of the appserver's dispatcher/thread pool, startup/shutdown/connec... Greg Shah

02/16/2013

05:15 PM Feature #1608: implement full appserver support (from 4GL clients only)
Greg: as a side-note, at this time, how much of the runtime do you want to be stubbed out ? Do you want us to get int... Constantin Asofiei
11:53 AM Feature #1608: implement full appserver support (from 4GL clients only)
> do we have handle fields in the project?
Yes. I think they may only be supported in temp-tables in the 4GL. We...
Greg Shah
10:04 AM Feature #1608: implement full appserver support (from 4GL clients only)
> 1. Determine the limits of what can be matched from the following "IN handle" cases:
For all cases, the @handle@ ca...
Constantin Asofiei
09:19 AM Feature #1608: implement full appserver support (from 4GL clients only)
> (thus the current approach of converting TRANSACTION DISTINCT to a KW_TRANS_DS token will not be correct).
You c...
Greg Shah
09:04 AM Feature #1608: implement full appserver support (from 4GL clients only)
> I assume that you don't need to change the looping of the parser. Instead you are referring to using fixups to for... Constantin Asofiei
08:32 AM Feature #1608: implement full appserver support (from 4GL clients only)
Some thoughts:
> The RUN statement's clauses can be "switched" to some extent and produce valid code in 4GL, and t...
Greg Shah
07:35 AM Feature #1608: implement full appserver support (from 4GL clients only)
And another PS: the SET clause for the ASYNCHRONOUS case behaves interesting:
* SET clause can be used without the A...
Constantin Asofiei
07:24 AM Feature #1608: implement full appserver support (from 4GL clients only)
PS: there is one syntax which can't be fixed that easy. Is related to RUN ... IN, as:... Constantin Asofiei
07:20 AM Feature #1608: implement full appserver support (from 4GL clients only)
The RUN statement's clauses can be "switched" to some extent and produce valid code in 4GL, and the conclusion is the... Constantin Asofiei
12:40 PM Feature #1644: implement SOAP support
> In each case where we are doing something different that the 4GL documentation, please make a statement like this:
...
Constantin Asofiei
12:26 PM Feature #1644: implement SOAP support
I will review it later today. Be prepared to merge it Monday morning with the pending 10174-10176 that is currently ... Greg Shah
12:07 PM Feature #1644: implement SOAP support
Attached update adds conversion support for SOAP-related attributes/methods and statements. Everything is stubbed, un... Constantin Asofiei
09:08 AM Feature #1644: implement SOAP support
I like the plan.
In regard to the "common" attributes (UNIQUE-ID, INSTANTIATING-PROCEDURE, LOCALNAME, NAMESPACE-UR...
Greg Shah
02:42 AM Feature #1620: implement EXTENT parameter support
This update:
- fixes decimals clause for 1-extent fields.
- fixes javadoc
- adds a TODO in decimal.setPrecision, f...
Constantin Asofiei
07:44 PM Feature #1620: implement EXTENT parameter support
FYI, there are some javadoc errors. You can fix them later (in a different check in).... Greg Shah
07:07 PM Feature #1641: implement SAX XML support
This is merged on top of ca_upd20130215d.zip (#1608) and ca_upd20130215e.zip (#1620 and #1621). It MUST be applied A... Greg Shah

02/15/2013

05:47 PM Feature #1641: implement SAX XML support
It looks good. I will merge it on top of Constantin's update and upload the result here. Greg Shah
05:21 PM Feature #1641: implement SAX XML support
The update merged with bzr 10173 has been uploaded. Eugenie Lyzenko
02:06 PM Feature #1641: implement SAX XML support
I appreciate it, but there are 3 of us that need to merge and it will be easier to use bzr. Greg Shah
02:00 PM Feature #1641: implement SAX XML support
> Normally, we only check in after everything is passed in regression testing. For today only, I have asked Eric to c... Eugenie Lyzenko
01:46 PM Feature #1641: implement SAX XML support
Normally, we only check in after everything is passed in regression testing. For today only, I have asked Eric to ch... Greg Shah
01:21 PM Feature #1641: implement SAX XML support
> ...
> 2. Merge with the bzr check-ins that should happen from the updates being tested in staging.
> ...
Does ...
Eugenie Lyzenko
12:35 PM Feature #1641: implement SAX XML support
Code Review Feedback:
1. Change the Abstract and class Javadoc in XmlFactory and XEntity so that they mention both...
Greg Shah
03:22 PM Feature #1620: implement EXTENT parameter support
Attached update merged with bzr revision 10173. Constantin Asofiei
12:09 PM Feature #1620: implement EXTENT parameter support
Unfortunately the conversion on the linux box crashed when it was almost at the end, so I will not have a conclusion ... Constantin Asofiei
11:32 AM Feature #1620: implement EXTENT parameter support
OK, I've checked again and looks like I've been miss-interpreting the diff result, this update actually solves the is... Constantin Asofiei
11:26 AM Feature #1620: implement EXTENT parameter support
Do these problems already exist in Majic today? Greg Shah
11:20 AM Feature #1620: implement EXTENT parameter support
What I'm currently reconverting doesn't fix the dead-vars emitted in validateExpression and validateMessage methods. ... Constantin Asofiei
11:12 AM Feature #1620: implement EXTENT parameter support
The code looks good. Assuming your tests show that it needs no further changes, the plan is as follows:
1. As soo...
Greg Shah
07:02 AM Feature #1620: implement EXTENT parameter support
After checking the converted sources, the following issues were fixed/found:
# in some programs, the validation expr...
Constantin Asofiei
12:52 PM Feature #1608: implement full appserver support (from 4GL clients only)
The delete widget changes look good. We will keep it separate from the rest of the appserver update and instead incl... Greg Shah
12:19 PM Feature #1608: implement full appserver support (from 4GL clients only)
PS: I suggest to test and release this together with the #1620 changes, as we will be able to integrate the Deletable... Constantin Asofiei
12:12 PM Feature #1608: implement full appserver support (from 4GL clients only)
This update adds the Deletable interface and DELETE WIDGET support (note that with DELETE WIDGET any kind of resource... Constantin Asofiei
09:37 AM Feature #1608: implement full appserver support (from 4GL clients only)
Interesting finding. The permutations never seem to end. This also has implications about our runtime implementatio... Greg Shah
09:17 AM Feature #1608: implement full appserver support (from 4GL clients only)
OK, I will work on this. I will not push this change to all resources yet, only to what we are currently working.
...
Constantin Asofiei
09:11 AM Feature #1608: implement full appserver support (from 4GL clients only)
Good idea. Please go with the Deletable approach.
Also: please add support for DELETE WIDGET, which is the equiva...
Greg Shah
08:55 AM Feature #1608: implement full appserver support (from 4GL clients only)
A note about delete: currently, each deletable resource must be registered in HandleOps.delete and call its dedicated... Constantin Asofiei
11:17 AM Feature #1994 (WIP): conversion support for SOAP
Constantin Asofiei
11:02 AM Feature #1644: implement SOAP support
Implementation details:
* SOAPFactory - class with APIs for CREATE SOAP-HEADER and CREATE SOAP-HEADER-ENTRYREF state...
Constantin Asofiei
 

Also available in: Atom