Activity

From 04/14/2014 to 05/13/2014

05/13/2014

08:03 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: The client code will have to be looked at closely in regard to flushing. There are other times when flushing occurs ... Greg Shah

05/12/2014

06:21 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Everything is correct, except one:
>C: this line outputs the default (unnamed) frame to the unnamed stream which is ... Evgeny Kiselev
02:58 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: > Behaviour of display and stream functionality is more complicated than I thought before.
Yes, it is very tricky.... Greg Shah
03:53 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Code Review 0512b
Looks good. Get it regression tested. Both conversion and runtime testing are necessary. The ... Greg Shah
03:33 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Greg Shah wrote:
> Code Review 0512a
>
> The code looks fine. My only question is about this:
>
> [...]
>
... Hynek Cihlar
02:14 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Code Review 0512a
The code looks fine. My only question is about this:... Greg Shah
12:52 PM Feature #1600 (Review): provide a conversion option to emit decimal literals using a string liter...: Hynek Cihlar
12:46 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...: Please review the attached changes. The related test cases are committed as uast/decimal_literal_precision.p.
Hynek Cihlar
09:34 PM Feature #1600 (WIP): provide a conversion option to emit decimal literals using a string literal ...: Hynek Cihlar
02:16 PM Feature #1630: implement support for UNBUFFERED in I/O statements: Check all uses (not just OUTPUT). I would hope that it just means that we flush with every write (synchronously). Greg Shah
11:52 AM Bug #2133 (Closed): fix precision for decimal, dynamic-extent variables: Greg Shah
11:14 AM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: Hynek, the changes on 0511a.zip look good. How was the regression testing? Constantin Asofiei

05/11/2014

05:02 PM Bug #2294 (Review): In Progress the variable initializer ignores the declared decimal precision: Hynek Cihlar
04:41 PM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: Please review the attached change set. It passes the companion uast/testcases which include cases for @setTempPrecisi... Hynek Cihlar

05/09/2014

06:42 PM Feature #1630: implement support for UNBUFFERED in I/O statements: Do I need to test only @output@ or all places there can be used @unbuffered@ ? (like input, input-output and etc) Evgeny Kiselev
03:58 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Behaviour of display and stream functionality is more complicated than I thought before.
Some @display@ call can ref... Evgeny Kiselev
08:19 AM Bug #2300: :: operator used in UI statements: It was a standalone case I used for investigation of some other issue.
The temporary fix was the cause of the regre... Ovidiu Maxiniuc
08:10 AM Bug #2300: :: operator used in UI statements: Was this found in standalone testcases or does this actually occur in customer code? Greg Shah
04:15 AM Bug #2300: :: operator used in UI statements: The conversion error is revealed by the following simple testcase:... Ovidiu Maxiniuc
03:41 AM Bug #2300 (New): :: operator used in UI statements: Ovidiu Maxiniuc

05/08/2014

12:38 PM Bug #2133: fix precision for decimal, dynamic-extent variables: 0505a passed regression test and was committed to bzr revision 10524. Hynek Cihlar
07:24 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...: Stanislav Lomany wrote:
> Merged with the latest revision.
Stanislav, the logic looks good to me. Constantin Asofiei
07:09 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...: Merged with the latest revision. Stanislav Lomany
10:01 PM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...: Stas, I apologize it has taken so long for me to review this. Because of this delay, it is no longer in sync with the... Eric Faulhaber

05/07/2014

05:22 PM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > In the converted code the only use case for setPrecision seems ... Hynek Cihlar
02:23 AM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: Hynek Cihlar wrote:
> In the converted code the only use case for setPrecision seems to be the variable definition. ... Constantin Asofiei

05/06/2014

02:22 PM Bug #2147 (Closed): fix any runtime issues with format strings (server project): Greg Shah
02:16 PM Feature #1885 (Closed): fix and add necessary format string support: Greg Shah
12:46 PM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: The only occurrence of @setPrecision@ is in srcnew/java/aero/timco/majic/item/Toolissu.java. There it is used the sam... Hynek Cihlar
12:37 PM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: Constantin Asofiei wrote:
> I don't think is worth having both @decimal.setPrecision@ and @decimal.setLazyPrecision@... Hynek Cihlar
09:56 AM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: I don't think is worth having both @decimal.setPrecision@ and @decimal.setLazyPrecision@, because there is no case wh... Constantin Asofiei
12:25 PM Bug #2133: fix precision for decimal, dynamic-extent variables: Constantin Asofiei wrote:
> As a side note, when building testcases, instead of using this:
> [...]
> you might fi... Hynek Cihlar
09:41 AM Bug #2133: fix precision for decimal, dynamic-extent variables: The changes look good.
As a side note, when building testcases, instead of using this:... Constantin Asofiei
09:38 AM Feature #2138: finish SEARCH-TARGET support: Greg Shah wrote:
> Great! Please check it in and distribute it.
Committed to bzr rev 10518. Constantin Asofiei
09:13 AM Feature #2138: finish SEARCH-TARGET support: Great! Please check it in and distribute it. Greg Shah
09:10 AM Feature #2138: finish SEARCH-TARGET support: Greg Shah wrote:
> 1. What is the reasoning behind the elimination of the @pushSuperProcedure()@ and @popSuperProced... Constantin Asofiei
08:42 AM Feature #2138: finish SEARCH-TARGET support: Code Review 0505a
1. What is the reasoning behind the elimination of the @pushSuperProcedure()@ and @popSuperProce... Greg Shah
04:27 AM Feature #2138: finish SEARCH-TARGET support: After the case found in #2266, the SUPER and RUN SUPER calls were re-investigated and these rules were found, for @SE... Constantin Asofiei
09:49 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Greg Shah wrote:
> Code Review 0502a
>
> 1. Is the @GenericFrame@ change intentionally meant to only modify the c... Evgeny Kiselev

05/05/2014

01:22 PM Bug #2294: In Progress the variable initializer ignores the declared decimal precision: Please see the attached changes and provide feedback.
The solution seems to be functionally correct, however it i... Hynek Cihlar
12:54 PM Bug #2133: fix precision for decimal, dynamic-extent variables: Attached are the fixed formatting issues. Also, the related testcases are committed in the file @testcases/uast/exten... Hynek Cihlar
11:47 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Code Review 0502a
1. Is the @GenericFrame@ change intentionally meant to only modify the case where @DISPLAY@ is u... Greg Shah

05/02/2014

07:47 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: This is pre review update, without doc headers.
1) @DirStream.java@ there is unnecessary new line. I'm not sure if t... Evgeny Kiselev
03:21 AM Bug #2133: fix precision for decimal, dynamic-extent variables: Hynek, the logic looks good, but there are some formatting issues:
* assignments.rules:
- line 229 is too long
* d... Constantin Asofiei

05/01/2014

01:16 AM Bug #2294 (WIP): In Progress the variable initializer ignores the declared decimal precision: Hynek Cihlar

04/30/2014

12:15 PM Bug #2133 (Review): fix precision for decimal, dynamic-extent variables: The attached code fixes decimal precision for extent variables and extent-to-extent assignment when rvalue is a param... Hynek Cihlar

04/25/2014

05:54 PM Bug #2293 (WIP): Fixing an unfixed extent output parameter causes an error: Hynek Cihlar
05:49 PM Bug #2293: Fixing an unfixed extent output parameter causes an error: Constantin Asofiei wrote:
> Hynek, this one is a little tricky: with output parameters, I think 4GL assumes nothing ... Hynek Cihlar
01:50 PM Bug #2293: Fixing an unfixed extent output parameter causes an error: Hynek, this one is a little tricky: with output parameters, I think 4GL assumes nothing is received from the original... Constantin Asofiei
01:44 PM Bug #2293: Fixing an unfixed extent output parameter causes an error: The code sample in note 1 is missing parameter qualifier. Below is the corrected version.... Hynek Cihlar
03:40 AM Bug #2293: Fixing an unfixed extent output parameter causes an error: Please post how the converted code for the program on note 1. Constantin Asofiei
03:09 PM Bug #2291 (Closed): Could not resolve closest legacy method for function returning an extent: Greg Shah
01:12 PM Bug #2291: Could not resolve closest legacy method for function returning an extent: Attached is the final change with the fixed code formatting. Committed into bzr revision 10516. No regression test run. Hynek Cihlar
03:39 AM Bug #2291: Could not resolve closest legacy method for function returning an extent: The change is OK, no regression testing is required. But before releasing it, make sure the code respects the 98-char... Constantin Asofiei
03:25 AM Bug #2292: Fix error handling when unfixed extent passed to fixed extent input parameter: Some notes here:
# the @/home/hc/p34141_Untitled8.ped@ is the actual program name, not some special string (i.e. if ... Constantin Asofiei

04/24/2014

05:29 PM Bug #2293: Fixing an unfixed extent output parameter causes an error: The following code causes the error _Indeterminate extent is already fixed to a dimension of 2_ in P2J but works with... Hynek Cihlar
05:21 PM Bug #2293 (Closed): Fixing an unfixed extent output parameter causes an error: Hynek Cihlar
05:09 PM Bug #2133: fix precision for decimal, dynamic-extent variables: I created new issue for the error handling of input fixed extent parameters (as of the note 23), the issue number is ... Hynek Cihlar
11:37 AM Bug #2133: fix precision for decimal, dynamic-extent variables: Yes, there is. I have an implementation in place, but because of the few secondary issues I found (which some of them... Hynek Cihlar
11:00 AM Bug #2133: fix precision for decimal, dynamic-extent variables: Is there anything left to do on this task? Greg Shah
05:00 PM Bug #2291 (Feedback): Could not resolve closest legacy method for function returning an extent: Hynek Cihlar
03:02 PM Bug #2291: Could not resolve closest legacy method for function returning an extent: Please review. Hynek Cihlar
02:25 PM Bug #2291: Could not resolve closest legacy method for function returning an extent: Hynek Cihlar wrote:
> I am attaching a fix which seems to work ok.
OK, leave only the function related change, the ... Constantin Asofiei
02:22 PM Bug #2291: Could not resolve closest legacy method for function returning an extent: Calling a function of extent return type is causing the error "Could not resolve closest legacy method for class XYZ"... Hynek Cihlar
02:10 PM Bug #2291 (Closed): Could not resolve closest legacy method for function returning an extent: Hynek Cihlar
04:59 PM Bug #2292: Fix error handling when unfixed extent passed to fixed extent input parameter: The following code sample causes the error message _Calling procedure /home/hc/p34141_Untitled8.ped cannot input an i... Hynek Cihlar
04:54 PM Bug #2292 (Closed): Fix error handling when unfixed extent passed to fixed extent input parameter: Hynek Cihlar
01:32 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Interesting.
It seems to me that all 4 DISPLAY statements are being output in the same "default" (unnamed) frame... Greg Shah
11:11 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Greg Shah wrote:
> > 3) but if try to display after stream is closed, then all data will shown. I think it's redraw ... Evgeny Kiselev
08:36 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: > 3) but if try to display after stream is closed, then all data will shown. I think it's redraw (refresh) all data i... Greg Shah
10:56 AM Bug #2284 (Closed): Fix parameter initialization: Greg Shah
10:44 AM Bug #2284 (Review): Fix parameter initialization: Hynek Cihlar
10:42 AM Bug #2284: Fix parameter initialization: 0417a passed regression testing and was committed to bzr revision 10513. Hynek Cihlar

04/23/2014

07:14 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: After investigation about problem in @display@ while stream is opened, I've found next problem:
1) if output stream ... Evgeny Kiselev

04/22/2014

11:53 AM Bug #2288: incorrect conversion and results for unknown value comparisons: The 0421a update has passed conversion regression testing. Now performing runtime testing. Eric Faulhaber
10:06 PM Bug #2288: incorrect conversion and results for unknown value comparisons: Regression testing again showed an unwanted change with the 0420a update. Previously,... Eric Faulhaber

04/21/2014

01:31 PM Bug #2288: incorrect conversion and results for unknown value comparisons: It probably makes sense to note the status of this task in #18 and to move that task into the Database project. It ma... Greg Shah
01:13 PM Bug #2288: incorrect conversion and results for unknown value comparisons: Greg Shah wrote:
> Not that you were asking, but I am fine with the changes.
OK, the feedback is helpful, particula... Eric Faulhaber
12:49 PM Bug #2288: incorrect conversion and results for unknown value comparisons: Code Review 0420a
Not that you were asking, but I am fine with the changes.
Are the remaining portions of #18 o... Greg Shah
11:20 AM Bug #2288: incorrect conversion and results for unknown value comparisons: Regression testing indicated that this change had the useful side effect of fixing some queries that were selecting t... Eric Faulhaber

04/19/2014

10:27 PM Bug #2288: incorrect conversion and results for unknown value comparisons: The attached update, based on some of Vadim's findings documented in #18 (note 9), resolves the issue. Eric Faulhaber

04/18/2014

02:28 PM Bug #2288: incorrect conversion and results for unknown value comparisons: Seems it started off that way, though in the history, #18 only describes the inequality comparisons with true/false, ... Eric Faulhaber
02:10 PM Bug #2288: incorrect conversion and results for unknown value comparisons: Is this the same as #18? Greg Shah
12:57 AM Bug #2288: incorrect conversion and results for unknown value comparisons: Consider the following 4GL test (testcases/uast/unknown-comparison2.p):... Eric Faulhaber
12:30 AM Bug #2288 (Closed): incorrect conversion and results for unknown value comparisons: Eric Faulhaber
03:06 AM Bug #2284: Fix parameter initialization: Hynek Cihlar wrote:
> Attached is the fix for the above two initialization issues, *please review*. Regression test ... Constantin Asofiei

04/17/2014

04:05 PM Bug #2284: Fix parameter initialization: It turns out I was running the P2J conversion without the proper version defined, i.e. with the default 9.0C as Const... Hynek Cihlar
10:15 AM Support #2234 (Closed): test and fix native API support on Windows: Greg Shah
08:48 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method: There are polymorphic functions (FUNC_POLY), attributes (ATTR_POLY) and methods (METH_POLY) in the 4GL. These are bu... Greg Shah

04/16/2014

06:59 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method: Several data type wrapper implementations have TODOs in @assign(BaseDataType value, boolean force)@, as in the follow... Eric Faulhaber
06:47 PM Feature #2287 (Closed): implement missing type conversion for POLY cases in data type wrapper ass...: Eric Faulhaber

04/15/2014

09:36 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...: Update for review. Stanislav Lomany

04/14/2014

03:15 PM Bug #2284: Fix parameter initialization: The original source suggests that Progress 9.0C version behaves differently in respect to the parameter initializatio... Hynek Cihlar
01:41 AM Bug #2284: Fix parameter initialization: Hynek Cihlar wrote:
> Note that the file @variable_definitions.rules@ contained logic of Progress V9.0C. I removed t... Constantin Asofiei
05:12 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...: Stanislav Lomany wrote:
> Constantin, is there a simple way do determine that the specific context is run using an a... Constantin Asofiei
04:59 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...: Constantin, is there a simple way do determine that the specific context is run using an agent? Stanislav Lomany
02:20 AM Bug #2283: Appserver persistence-related abend on subsequent connect: Stanislav, if you look into the @TM.resettables@ list, there are two @BufferManager@ instances, when it should have b... Constantin Asofiei

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Base Language

Activity

Activity

05/13/2014

05/12/2014

05/11/2014

05/09/2014

05/08/2014

05/07/2014

05/06/2014

05/05/2014

05/02/2014

05/01/2014

04/30/2014

04/29/2014

04/28/2014

04/26/2014

04/25/2014

04/24/2014

04/23/2014

04/22/2014

04/21/2014

04/19/2014

04/18/2014

04/17/2014

04/16/2014

04/15/2014

04/14/2014