Project

General

Profile

Activity

From 10/19/2018 to 11/17/2018

11/15/2018

01:27 PM Feature #3751: implement support for OO 4GL and structured error handling
+Class Members Access Summary+
|_. Resource |_. Data Member |_. Default Access Mode |_. PUBLIC |_. PROTECTED |_. P...
Greg Shah

11/14/2018

04:02 PM Feature #3751: implement support for OO 4GL and structured error handling
Comments from a customer 4GL developer:
* ABL garbage collection is based on reference counting.
* The ABL (at le...
Greg Shah
03:49 PM Feature #3751: implement support for OO 4GL and structured error handling
Some of the built-in classes provided by OpenEdge are not documented in the 4GL reference PDF. This online doc is a ... Greg Shah

11/13/2018

04:22 PM Feature #3754 (Closed): TRANSACTION resource support
Greg Shah
04:13 PM Feature #3754: TRANSACTION resource support
Branch 3754a was merged to trunk rev 11291 and archived. Constantin Asofiei
04:08 PM Feature #3754: TRANSACTION resource support
Eric Faulhaber wrote:
> ETF runtime testing passed (full search and dev tests).
Great! I'll release it shortly.
...
Constantin Asofiei
04:00 PM Feature #3754: TRANSACTION resource support
Constantin Asofiei wrote:
> Eric: please help me with runtime testing - I don't think full runtime is required, just...
Eric Faulhaber
03:40 PM Feature #3754: TRANSACTION resource support
If Eric's tests pass please merge to trunk. Greg Shah
03:40 PM Feature #3754: TRANSACTION resource support
Code Review Task Branch 3754a Revision 11293
The changes are good.
Greg Shah
02:43 PM Feature #3754: TRANSACTION resource support
Greg Shah wrote:
> Do we have sufficient checks to ensure this same limitation is forced?
Now we do - see 3754a rev...
Constantin Asofiei
02:01 PM Feature #3754: TRANSACTION resource support
> there is no way for TRANSACTION-MODE AUTOMATIC or TRANS-INIT-PROCEDURE invoked entries to automatically start a fu... Greg Shah
01:53 PM Feature #3754: TRANSACTION resource support
Greg Shah wrote:
> The part I don't understand is how this is supposed to act when it is called while a full transac...
Constantin Asofiei
11:34 PM Feature #3754: TRANSACTION resource support
Code Review Task Branch 3754a Revision 11292
I've reviewed everything, it is very good.
The part I don't unders...
Greg Shah
03:48 PM Feature #3752: CLIENT-PRINCIPAL resource and other security features
All of these are classified as "global builtin variables" since they don't take parenthesis. Even though the 4GL doc... Greg Shah
03:28 PM Feature #3752: CLIENT-PRINCIPAL resource and other security features
Greg, why are these marked as VAR_RAW (and registered as global variables) instead of builtin functions, in progress.... Constantin Asofiei
02:55 PM Feature #3752: CLIENT-PRINCIPAL resource and other security features
Greg Shah wrote:
> * ENCRYPT
> * DECRYPT
> * GENERATE-RANDOM-KEY()
These are dependent on @SECURITY-POLICY:SYMMET...
Constantin Asofiei
07:13 PM Feature #3752: CLIENT-PRINCIPAL resource and other security features
> @EXPORT/IMPORT-PRINCIPAL@ creates a byte representation of the @CLIENT-PRINCIPAL@ resource, returned as a @raw@ ins... Greg Shah

11/12/2018

05:06 PM Feature #3752: CLIENT-PRINCIPAL resource and other security features
@EXPORT/IMPORT-PRINCIPAL@ creates a byte representation of the @CLIENT-PRINCIPAL@ resource, returned as a @raw@ insta... Constantin Asofiei
05:01 PM Feature #3752 (WIP): CLIENT-PRINCIPAL resource and other security features
Constantin Asofiei
04:47 PM Feature #3754: TRANSACTION resource support
Greg, 3754a rev 11292 adds:
* full conversion support
* runtime is almost done, I need to do some more manual testi...
Constantin Asofiei

11/08/2018

04:15 PM Feature #3741 (Closed): implement complete support for the CALL object handle and related attribu...
Greg Shah
04:14 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Branch 3741a was merged to trunk rev 11290 and archived. Constantin Asofiei
04:03 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Greg Shah wrote:
> Code Review Task Branch 3741a Revision 11300
>
> I'm good with the changes. You can merge to ...
Constantin Asofiei
04:00 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Code Review Task Branch 3741a Revision 11300
I'm good with the changes. You can merge to trunk when ready.
Greg Shah
12:04 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Greg, thanks for the idea - I've implemented this in 3741a rev 11300. Constantin Asofiei

11/07/2018

06:29 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Greg Shah wrote:
> Can you use a local @int64@ or @decimal@ subclass for the conversion and then assign back the kno...
Constantin Asofiei
04:23 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Can you use a local @int64@ or @decimal@ subclass for the conversion and then assign back the known-valid value to th... Greg Shah
01:29 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Greg Shah wrote:
> I think the only remaining issue is the @BDT.assignDirect@. It is used for such a limited requir...
Constantin Asofiei
12:31 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Sorry, I see you already did this with #3789. Nice! Greg Shah
12:30 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
In regard to #3741-57, I agree it is worth looking into this performance case. Please open another task for this. Greg Shah
12:29 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Code Review Task Branch 3741a Revision 11299
The changes are good.
I think the only remaining issue is the @BDT...
Greg Shah
11:29 AM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Note that I couldn't find a way to get rid of the @BaseDataType.assignDirect@ flag - this is still in use. Constantin Asofiei
10:17 AM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Rebased 3471a from trunk rev 11289 - new rev 11299. Constantin Asofiei
07:34 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Greg, 3741a rev 11298 contains the final changes related to CALL. I've not included the changes I mentioned in #3741... Constantin Asofiei
06:26 PM Feature #3754: TRANSACTION resource support
Created task branch 3754a from trunk rev 11289.
Rev 11290 adds full conversion support for @TRANSACTION@ handle an...
Constantin Asofiei
02:59 PM Feature #3754: TRANSACTION resource support
There is something interesting related to the TRANSACTION handle:
* this is accessed via @procedure:TRANSACTION@, an...
Constantin Asofiei
02:37 PM Feature #3754: TRANSACTION resource support
Yes, that is fine. Greg Shah
02:30 PM Feature #3754: TRANSACTION resource support
Constantin Asofiei wrote:
> Is it OK to use @TransactionManager.transactionModeAuto()@ for @TRANSACTION-MODE AUTO@ s...
Constantin Asofiei
02:18 PM Feature #3754: TRANSACTION resource support
Is it OK to use @TransactionManager.transactionModeAuto()@ for @TRANSACTION-MODE AUTO@ statement? Constantin Asofiei
11:13 AM Feature #3754: TRANSACTION resource support
Go ahead and add these other features.
> And another note about RUN ... TRANSACTION DISTINCT - can you check the r...
Greg Shah
10:32 AM Feature #3754: TRANSACTION resource support
Further reading shows that @RUN ... TRANSACTION DISTINCT@ is used as a fail-safe if 4GL decides to propagate the clie... Constantin Asofiei
10:12 AM Feature #3754: TRANSACTION resource support
Greg, let me know if I should add these attributes (to allow complete TRANSACTION handle support):
* @IS-OPEN@ attri...
Constantin Asofiei
10:05 AM Feature #3754: TRANSACTION resource support
According to this https://documentation.progress.com/output/ua/OpenEdge_latest/index.html#page/pasoe-migrate-develop/... Constantin Asofiei
08:39 AM Feature #3754 (WIP): TRANSACTION resource support
Greg Shah

11/01/2018

07:12 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
I have a heavy duty test which uses lots of PUT statements - and what 4GL does in 1-2 seconds FWD does in 10 to 30. ... Constantin Asofiei
05:14 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Using @getBytes().length@ makes sense. Greg Shah
04:49 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Eric, thanks!
Greg: I have another issue, this time in @BinaryData.setString@ - this assumes the number of bytes i...
Constantin Asofiei
04:43 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
3741a/11295 has passed all ETF testing. Eric Faulhaber
03:39 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Greg Shah wrote:
> If this really creates too much overhead to be included in BDT, then can we pass a wrapper for th...
Constantin Asofiei
03:32 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
No, this will create a huge mess and much confusion.
If this really creates too much overhead to be included in BD...
Greg Shah
03:27 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Eric Faulhaber wrote:
> Eric Faulhaber wrote:
> > ...all temp-tables, and any records held in the JDBC driver...
>...
Constantin Asofiei
03:16 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Eric Faulhaber wrote:
> ...all temp-tables, and any records held in the JDBC driver...
Actually, temp-table recor...
Eric Faulhaber
03:05 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Greg Shah wrote:
> The @assignDirect@ and @variable@ members of BDT should probably be marked @transient@ so it is c...
Eric Faulhaber
02:59 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
I'm running the last round (batch) now. The other two have passed. Eric Faulhaber
02:39 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Eric, the diffs are OK, please go ahead with runtime testing (if you haven't already). Constantin Asofiei
02:42 AM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Constantin Asofiei wrote:
> please send me the diffs (or the baseline and converted sources) once you have the conve...
Eric Faulhaber

10/31/2018

03:10 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Greg Shah wrote:
> 1. The @assignDirect@ and @variable@ members of BDT should probably be marked @transient@ so it i...
Constantin Asofiei
12:51 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Code Review Task Branch 3741a Revision 11295
Wow! That is a massive code drop. It took me all morning to review ...
Greg Shah
12:41 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
OK, converting now. Eric Faulhaber
11:46 AM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
3741a rev 11295 fixes some regressions and it passed MAJIC main and conversion testing.
Eric: please go ahead with...
Constantin Asofiei
08:02 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Constantin Asofiei wrote:
> Eric: please let me know if you can help me with ETF testing; you will need to reconvert...
Eric Faulhaber

10/30/2018

07:39 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
3741a rev 11293 is under MAJIC testing now.
What is left are to finish the conversion of output parameters and jav...
Constantin Asofiei
05:28 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Indeed, there is one way out before the new block is processed: the @ControlFlowOps.invokeImpl()@ ~ line 3350. Here, ... Ovidiu Maxiniuc
04:43 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
I'm getting this:... Constantin Asofiei
04:34 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
The @TM.deregisterOutputParameterAssigner()@ is called before the call of an procedure/function and native API routin... Ovidiu Maxiniuc
03:37 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Ovidiu, please help me with something: shouldn't @TM.deregisterOutputParameterAssigner@ be called in case the i.e. RU... Constantin Asofiei
01:14 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Applications can't depend upon behavior that abends in the 4GL. It is safe to let it assign. Put notes in the Javad... Greg Shah
01:01 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Greg, documentation states that if the OUTPUT/INPUT-OUTPUT variable is out of scope, then terminate with an error con... Constantin Asofiei

10/29/2018

07:43 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Constantin Asofiei wrote:
> Ovidiu, please confirm another possible bug: @BaseDataType.generateDefault@ now generate...
Constantin Asofiei
04:39 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Ovidiu, please confirm another possible bug: @BaseDataType.generateDefault@ now generates an unknown value, as the BD... Constantin Asofiei
03:39 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Some other weird things related to @DLL-CALL-TYPE@: if the @LIBRARY@ attribute is not set BEFORE the @SET-PARAMETER@,... Constantin Asofiei
02:28 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Forgot about runtime/conversion of:
* extent arguments
* field reference arguments
* by-reference and append argum...
Constantin Asofiei
06:35 AM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Constantin Asofiei wrote:
> Ovidiu, I think there is a bug in @date.assign(BaseDataType)@ - if the current date inst...
Ovidiu Maxiniuc
04:07 AM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
An ETA for what is left:
* the @dll-call-type@ - I'll finish this and have a cleaned up version by tomorrow, to put ...
Constantin Asofiei

10/26/2018

04:38 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
Ovidiu, I think there is a bug in @date.assign(BaseDataType)@ - if the current date instance is unknown and the argum... Constantin Asofiei

10/25/2018

05:23 PM Feature #3741: implement complete support for the CALL object handle and related attributes and m...
A dec-char-char case (var data type, set-parameter data type, procedure parameter data type), shows some interesting ... Constantin Asofiei

10/20/2018

09:52 AM Feature #3756: minor modifications for SESSION system handle support
The following improvements for the SESSION system handle are needed:
* V6DISPLAY attribute (we do not need to supp...
Greg Shah
09:50 AM Feature #3756 (WIP): minor modifications for SESSION system handle support
Greg Shah
09:48 AM Feature #3755: DEBUGGER system handle stubs
Implement complete conversion support for the DEBUGGER system handle and all attributes/methods. The runtime should ... Greg Shah
09:40 AM Feature #3755 (Closed): DEBUGGER system handle stubs
Greg Shah
09:36 AM Feature #3754: TRANSACTION resource support
Implement the following:
* TRANSACTION handle-based resource
* SET-COMMIT() method
* SET-ROLLBACK() method
* TR...
Greg Shah
09:15 AM Feature #3754 (Closed): TRANSACTION resource support
Greg Shah
09:14 AM Feature #3753: I18N additions
Implement the following I18N features for Phase 1 (POC):
* FIX-CODEPAGE statement
* CODEPAGE-CONVERT() (runtime)
...
Greg Shah
09:11 AM Feature #3753 (Closed): I18N additions
Greg Shah
09:09 AM Feature #2135: implement COPY-LOB language statement
As phase 2 of development, please add basic support for this set of source/target pairs:... Greg Shah
09:05 AM Feature #2135: implement COPY-LOB language statement
At this time, the following source/target pairs have basic support (see @com.goldencode.p2j.util.LargeObjectOps@):
...
Greg Shah

10/19/2018

05:01 PM Feature #3752: CLIENT-PRINCIPAL resource and other security features
Implement support for the following:
+CLIENT-PRINCIPAL resource+
* CREATE CLIENT-PRINCIPAL statement
* CLIENT-...
Greg Shah
04:36 PM Feature #3752 (Closed): CLIENT-PRINCIPAL resource and other security features
Greg Shah
04:32 PM Feature #3751 (WIP): implement support for OO 4GL and structured error handling
Greg Shah
02:22 PM Feature #3751: implement support for OO 4GL and structured error handling
In #3308-252, Constantin found that the OO 4GL supports "duck typing". Greg Shah
02:19 PM Feature #3751: implement support for OO 4GL and structured error handling
Some comments from people at PSC:
# Methods act like internal procedures when there is no return value and act lik...
Greg Shah
02:16 PM Feature #3751: implement support for OO 4GL and structured error handling
Implement complete support for both OO 4GL and structured error handling.
+Object Oriented (OO) 4GL+
* -CLASS- ...
Greg Shah
02:09 PM Feature #3751 (Closed): implement support for OO 4GL and structured error handling
Greg Shah
 

Also available in: Atom