FWD » Core Development » Base Language

12/21/2018

03:52 PM Feature #3751: implement support for OO 4GL and structured error handling

> Try arithmetic expressions, not just passing vars. In FWD, our MathOps.plus(int64,in64) returns an int64 - passing ... Greg Shah

03:36 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Constantin: can you provide specific examples of these cases failing in method parameter wrapping... Constantin Asofiei

03:30 PM Feature #3751: implement support for OO 4GL and structured error handling

I've been working on testcases for hours. I'm finding that there are fewer wrapping cases than we thought.
For ex... Greg Shah

12:44 PM Feature #3751: implement support for OO 4GL and structured error handling

> > this needs to be checked under the target's context, and not the current AST..
>
> You're right. However, I t... Greg Shah

12:42 PM Feature #3751: implement support for OO 4GL and structured error handling

> this needs to be checked under the target's context, and not the current AST..
You're right. However, I think t... Greg Shah

12:38 PM Feature #3751: implement support for OO 4GL and structured error handling

While I am writing the method matching/lookup logic I needed to check if the 4GL uses return type as part of a method... Greg Shah

12:31 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg, please review this function:... Constantin Asofiei

11:12 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> 1. In @annotations_prep.xml@, the two calls to @convert_member_name@ pass @mnode@ which is an @Xm... Ovidiu Maxiniuc

10:56 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg, there are errors like this:... Constantin Asofiei

10:19 AM Feature #3751: implement support for OO 4GL and structured error handling

> More, promoting local vars in static methods should never happen (or at least this must keep the static modifier fo... Constantin Asofiei

08:09 AM Feature #3751: implement support for OO 4GL and structured error handling

Yes, you're right.
However, we need to wait to implement this until after we have everything compiling in the curr... Greg Shah

03:33 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg, static state in 4GL is not the same as static state in Java. This is because in 4GL there are no multiple clie... Constantin Asofiei

02:30 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Constantin Asofiei wrote:
> > Another OO issue: you have an @integer@ property and do something ... Constantin Asofiei

08:56 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Another OO issue: you have an @integer@ property and do something like @pi = pi + 1@. T... Greg Shah

07:06 PM Feature #3751: implement support for OO 4GL and structured error handling

*GES: SOLVED*
There are still issue with wrapping the parameters for method calls. Also, this wrapping must not w... Constantin Asofiei

07:03 PM Feature #3751: implement support for OO 4GL and structured error handling

*GES: SOLVED*
Another OO issue: you have an @integer@ property and do something like @pi = pi + 1@. This gets con... Constantin Asofiei

08:32 AM Feature #2135: implement COPY-LOB language statement

Constantin Asofiei wrote:
> Eric, is this @copy-lob from v1 to v2 overlay at idx.@ version of @COPY-LOB@ supported?
... Eric Faulhaber

04:23 AM Feature #2135: implement COPY-LOB language statement

Eric, is this @copy-lob from v1 to v2 overlay at idx.@ version of @COPY-LOB@ supported? Constantin Asofiei

12/20/2018

06:45 PM Feature #3751: implement support for OO 4GL and structured error handling

> Greg, I think you forgot to commit @_BaseObject_@
Sorry. Rev 11412 fixes that. Greg Shah

06:42 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg, I think you forgot to commit @_BaseObject_@ Constantin Asofiei

04:58 PM Feature #3751: implement support for OO 4GL and structured error handling

> There is another issue here: the @refid@ annotation (which gets computed from @tempidx@) must refer the correct met... Greg Shah

04:55 PM Feature #3751: implement support for OO 4GL and structured error handling

Revision 11411:
Rework of converted interfaces and converted classes to ultimately inherit both from _BaseObject_ ... Greg Shah

04:04 PM Feature #3751: implement support for OO 4GL and structured error handling

Code Review Task Branch 3750a Revision 11408
There are 2 things I don't understand:
1. In @annotations_prep.xml... Greg Shah

02:36 PM Feature #3751: implement support for OO 4GL and structured error handling

Finished testing 3751-270 (Added method overloading support).
I tested with variables, properties and method.
There... Ovidiu Maxiniuc

01:27 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Greg Shah wrote:
> > I didn't see the @inMethod@ since it was in the caller instead of ... Greg Shah

01:26 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> I didn't see the @inMethod@ since it was in the caller instead of the pre/post actions of the rul... Constantin Asofiei

01:25 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Constantin Asofiei wrote:
> > New issue: FWD can't compile a OO var declaration having as a type... Constantin Asofiei

01:24 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> New issue: FWD can't compile a OO var declaration having as a type an interface.
If t... Greg Shah

12:08 PM Feature #3751: implement support for OO 4GL and structured error handling

I didn't see the @inMethod@ since it was in the caller instead of the pre/post actions of the rule it affected. I al... Greg Shah

12:01 PM Feature #3751: implement support for OO 4GL and structured error handling

Yes, I added it in 11390. The getter_setter issue is just a copy/paste error. At the end it should be set to false. Greg Shah

11:59 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg, did you add the @inMethodDef@ flag to @progress.g@ recently? Because I previously added @inMethod@ flag... with... Constantin Asofiei

11:42 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> I suspect what the static or access modes control is access to the default buffer created for tha... Constantin Asofiei

11:01 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> New issue: FWD doesn't emit properly static temp tables (and maybe access modifiers).
>... Greg Shah

10:55 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Greg Shah wrote:
> > > I think we need to emit the legacy Progress.Lang.Object APIs as ... Greg Shah

10:16 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Ovidiu: In regard to #3751-270, what is your status? I was going to work on this a few days ago ... Ovidiu Maxiniuc

10:11 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> > I think we need to emit the legacy Progress.Lang.Object APIs as an interface (with their implem... Constantin Asofiei

10:09 AM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu: In regard to #3751-270, what is your status? I was going to work on this a few days ago but shifted to work ... Greg Shah

10:04 AM Feature #3751: implement support for OO 4GL and structured error handling

I think I described something similar in #3751-269.
* @_BaseObject_@ interface
* @BaseObject@ implements @_BaseOb... Greg Shah

09:28 AM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > New issue: FWD can't compile a OO var declaration having as ... Constantin Asofiei

09:18 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> New issue: FWD can't compile a OO var declaration having as a type an interface.
A disc... Ovidiu Maxiniuc

09:09 AM Feature #3751: implement support for OO 4GL and structured error handling

*CA WIP*
New issue: FWD doesn't emit properly static temp tables (and maybe access modifiers).
*STILL OPEN*
Also... Constantin Asofiei

09:05 AM Feature #3751: implement support for OO 4GL and structured error handling

*GES: SOLVED*
New issue: FWD can't compile a OO var declaration having as a type an interface. Constantin Asofiei

04:36 AM Feature #3751: implement support for OO 4GL and structured error handling

There is at least another case of @staticField:privateMethodCall("param")@ which gets converted to @staticField.ref()... Constantin Asofiei

03:46 AM Feature #3751: implement support for OO 4GL and structured error handling

*GES: SOLVED*
Ovidiu Maxiniuc wrote:
> OK, mark it as *OM WIP*
There is another issue here: the @refid@ annotati... Constantin Asofiei

03:35 AM Feature #3751: implement support for OO 4GL and structured error handling

OK, mark it as *OM WIP* Ovidiu Maxiniuc

03:33 AM Feature #3751: implement support for OO 4GL and structured error handling

*OM SOLVED*
Ovidiu, please work on this one: overloaded methods in 4GL classes must keep their names.... Constantin Asofiei

12/19/2018

01:31 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> We have a problem with defining interface-typed variables. For example:
> [...]
>
> wil... Greg Shah

08:58 AM Feature #3751: implement support for OO 4GL and structured error handling

Revision 11391 fixes multi-assignments for extent object variables and adds support for initialization of indetermina... Ovidiu Maxiniuc

08:52 AM Feature #3751: implement support for OO 4GL and structured error handling

Revision 11390 resolves access mode processing for deeply chained/nested member de-references and remove vars defined... Greg Shah

07:14 AM Feature #3751: implement support for OO 4GL and structured error handling

More, because of the @access-mode@ annotation, the cast is emitted for the public chained members... Constantin Asofiei

07:14 AM Feature #3751: implement support for OO 4GL and structured error handling

> Greg, can you take a look?
Yes, I'll look at it. Greg Shah

07:11 AM Feature #3751: implement support for OO 4GL and structured error handling

*GES: SOLVED*
I'm getting lots of @null@ casts for chains like @x:pv2:pv2:pv1.@, where @x@ is a OO local var (not ... Constantin Asofiei

05:38 AM Feature #3751: implement support for OO 4GL and structured error handling

We have a problem with defining interface-typed variables. For example:... Ovidiu Maxiniuc

12:17 AM Feature #3751: implement support for OO 4GL and structured error handling

Revision 11386 completes the stubs of all necessary built-in classes. I believe this resolves all requires listed in... Greg Shah

01:25 PM Bug #3835: broken multi-assigner

For the moment (r11391/3750a), I enforced that this assign back to be generated only when @vv@ above is an _indetermi... Ovidiu Maxiniuc

07:15 AM Bug #3835: broken multi-assigner

Currently the multi-assigner is broken. Example:... Ovidiu Maxiniuc

07:09 AM Bug #3835 (New): broken multi-assigner

Ovidiu Maxiniuc

12/18/2018

04:52 PM Feature #3751: implement support for OO 4GL and structured error handling

FYI, this also eliminates the cases where that extra casting broke the converted code so it is good from that perspec... Greg Shah

04:51 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> Greg Shah wrote:
> > Revision 11380 has this change in @oo_calls.rules@:
> > [...]
> > I... Greg Shah

03:55 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Revision 11380 has this change in @oo_calls.rules@:
> [...]
> It definitely breaks some of my t... Ovidiu Maxiniuc

03:50 PM Feature #3751: implement support for OO 4GL and structured error handling

Revision 11380 has this change in @oo_calls.rules@:... Greg Shah

01:05 PM Feature #3751: implement support for OO 4GL and structured error handling

Revision 11376:
Fix for OBJECT_INVOCATION that has a first child of OO_METH_*. This is an unqualified method refer... Greg Shah

11:03 AM Feature #3751: implement support for OO 4GL and structured error handling

Revision 11371:
Fixes to have access mode and static qualifier emit properly for properties. The backing var for ... Greg Shah

08:24 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Greg, if you manage to decouple the dependency on "filenames_to_java_classnames" (which ... Greg Shah

08:23 AM Feature #3751: implement support for OO 4GL and structured error handling

*GES: Solved*
Right now I'm still working on the wrapping of method call parms. I can put that on hold to work on... Greg Shah

08:20 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Ovidiu, these legacy classes are used in our project and we need Java equivalents:
OK, ... Ovidiu Maxiniuc

08:16 AM Feature #3751: implement support for OO 4GL and structured error handling

Responding here instead of #3750 because it is OO related.
> if we are in an ASSIGN statement and a property with ... Greg Shah

08:06 AM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu, these legacy classes are used in our project and we need Java equivalents:... Constantin Asofiei

12/17/2018

05:44 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Constantin Asofiei wrote:
> > 3750a rev 11369 fixes some var/class-event reference problems when... Constantin Asofiei

05:30 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg, if you manage to decouple the dependency on "filenames_to_java_classnames" (which prohibits CB to be ran on a s... Constantin Asofiei

05:24 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> 3750a rev 11369 fixes some var/class-event reference problems when the definition is in ... Greg Shah

05:12 PM Feature #3751: implement support for OO 4GL and structured error handling

3750a rev 11369 fixes some var/class-event reference problems when the definition is in a super-class. Please review... Constantin Asofiei

04:24 PM Feature #3751: implement support for OO 4GL and structured error handling

There are some issues with incorrect @tempidx@ for non-local var/class-event access, if the definition is in a super-... Constantin Asofiei

03:55 PM Feature #3751: implement support for OO 4GL and structured error handling

Revision 11368 includes fixes for:
* length-of contents in extent properties
* indexed getter return type
Ther... Greg Shah

03:51 PM Feature #3751: implement support for OO 4GL and structured error handling

You're right, that is the issue. Thanks! Greg Shah

03:48 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> The code for extent property getters is failing with:
>
> [...]
>
> The converted code:
> ... Constantin Asofiei

03:18 PM Feature #3751: implement support for OO 4GL and structured error handling

The code for extent property getters is failing with:... Greg Shah

02:50 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Constantin: Could you please review this change? The @HERE?@ comments are the places that I chan... Constantin Asofiei

02:20 PM Feature #3751: implement support for OO 4GL and structured error handling

Revision 11366:
Fix for initializers created and stored in the depot on one program which are then pulled out of t... Greg Shah

02:18 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > ((F3757)instance.ref()).v3.assign(new integer(456));
> I as... Ovidiu Maxiniuc

01:33 PM Feature #3751: implement support for OO 4GL and structured error handling

I'm working on the following issues:
1. The unexpected/unrelated var initializers that appear in @oo/ComplexInterf... Greg Shah

12:53 PM Feature #3751: implement support for OO 4GL and structured error handling

The @CB@ phase failed with a access-mode problem for class events after ~150 minutes, in the code conversion part.
... Constantin Asofiei

10:58 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > I'm looking into @oldtype@, is a parser problem, as I men... Ovidiu Maxiniuc

10:55 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > The conversion stops in @assignments.rules@ while attempting... Constantin Asofiei

10:37 AM Feature #3751: implement support for OO 4GL and structured error handling

Other issues:
* @Instance = new TestClass().@ is not compiling
* if you have a member @v@ and do a @Instance:v = 0@... Constantin Asofiei

10:23 AM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> I have 2 alternatives that work:
> ((F3757)instance.ref()).v3.assign(new integer(456));
I... Constantin Asofiei

10:19 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> This and other issues are fixed in 11358 and 11360.
Not purposely, I tested the code ge... Ovidiu Maxiniuc

09:14 AM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> The conversion stops in @assignments.rules@ while attempting to convert to long/int the @ol... Constantin Asofiei

09:12 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Where is this code located? In a class method/c'tor? If so then yes, local static membe... Ovidiu Maxiniuc

08:56 AM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> The generation of setters is fixed. Committed revision 11361.
>
> However, I added some ... Constantin Asofiei

08:41 AM Feature #3751: implement support for OO 4GL and structured error handling

The generation of setters is fixed. Committed revision 11361.
However, I added some code to that from note-222 and... Ovidiu Maxiniuc

07:56 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> I'm looking into the conversion abend related to @ // Instance:v3 = 456.@ commented line... Constantin Asofiei

06:33 AM Feature #3751: implement support for OO 4GL and structured error handling

I'm looking into the conversion abend related to @ // Instance:v3 = 456.@ commented line. Constantin Asofiei

06:32 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> The getter/setter for properties having as type an OO class must have the proper generic... Ovidiu Maxiniuc

06:11 AM Feature #3751: implement support for OO 4GL and structured error handling

Committed revision 11359.
Fixed covariance of generics for OO methods. Now the signature for ... Ovidiu Maxiniuc

06:04 AM Feature #3751: implement support for OO 4GL and structured error handling

The getter/setter for properties having as type an OO class must have the proper generic set. Currently they are emi... Constantin Asofiei

01:07 AM Feature #3751: implement support for OO 4GL and structured error handling

In revision 11357, I've added the rewriting of the references (local and non-local) to properly call the 4 different ... Greg Shah

07:51 PM Feature #3751: implement support for OO 4GL and structured error handling

So I finally was able to make the local chaining for class events work, too. Now it converts OK - what is not workin... Constantin Asofiei

08:12 PM Feature #2135: implement COPY-LOB language statement

Branch 3750a/11356 adds conversion support for DB_REF_NON_STATIC and POLY on either side of the copy, in combination ... Eric Faulhaber

12/16/2018

06:50 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> I will keep working on this, but I'm worried that the @getAst()@ support is not working for non-l... Constantin Asofiei

06:37 PM Feature #3751: implement support for OO 4GL and structured error handling

With r11353 the code changes as follows (see previous in note-124 and 193):... Ovidiu Maxiniuc

06:23 PM Feature #3751: implement support for OO 4GL and structured error handling

I did a quick check for non-local properties and although the refid is there, it fails to lookup the javaname. Have ... Greg Shah

06:03 PM Feature #3751: implement support for OO 4GL and structured error handling

Revision 11352 adds the extra methods for extent properties length-of and the indeterminate resize.
I think proper... Greg Shah

05:47 PM Feature #3751: implement support for OO 4GL and structured error handling

Having something like this inside a OO method def:... Constantin Asofiei

05:29 PM Feature #3751: implement support for OO 4GL and structured error handling

This the refid is needed for non-local events, too - otherwise I can't find the event's javaname to be able to genera... Constantin Asofiei

04:58 PM Feature #3751: implement support for OO 4GL and structured error handling

> If you want it to be a static method call, then you need to emit the qualified class name and the method name toget... Greg Shah

04:57 PM Feature #3751: implement support for OO 4GL and structured error handling

The tree looks correct.
The object chaining always matches the leftmost referent first (the @primary_expr@ in @cha... Greg Shah

04:54 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> This is a "standalone" method call (no qualifier). I think the @upPath("ASSIGNMENT/EXPRESSION")@... Constantin Asofiei

04:48 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> I don't have a problem relying upon the refid approach for final resolution of the names by refer... Constantin Asofiei

04:45 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg, does this AST look right to you, for a @x:e1@ access for the class event @e1@?... Constantin Asofiei

03:06 PM Feature #3751: implement support for OO 4GL and structured error handling

In @oo_calls.rules@:... Greg Shah

02:00 PM Feature #3751: implement support for OO 4GL and structured error handling

I don't have a problem relying upon the refid approach for final resolution of the names by references. This is the ... Greg Shah

01:40 PM Feature #3751: implement support for OO 4GL and structured error handling

> The emitted methods for DEFINE EVENT will be:
The publish method when implemented, must be private.
For abst... Greg Shah

01:36 PM Feature #3751: implement support for OO 4GL and structured error handling

Revision 11350 has the following changes:
* Separated variables and methods into separate legacy name maps.
* M... Greg Shah

01:12 PM Feature #3751: implement support for OO 4GL and structured error handling

The emitted methods for @DEFINE EVENT@ will be:
* For interfaces:... Constantin Asofiei

01:09 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> We could add this to the data stored in @ConvertedClassName@ to allow resolving the temp-idx late... Constantin Asofiei

01:03 PM Feature #3751: implement support for OO 4GL and structured error handling

We could add this to the data stored in @ConvertedClassName@ to allow resolving the temp-idx later.
I am deep into... Greg Shah

12:48 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu, In the end your per-folder failure can't be solved easily, as the non-local method call is from a different f... Constantin Asofiei

11:44 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Constantin Asofiei wrote:
> > @static@ mode is not working now - can you look at it, please?
> ... Constantin Asofiei

11:41 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> @static@ mode is not working now - can you look at it, please?
I guess you mean @stat... Greg Shah

11:31 AM Feature #3751: implement support for OO 4GL and structured error handling

@static@ mode is not working now - can you look at it, please? Constantin Asofiei

11:24 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> I don't think the @new object<BaseObject>()@ is needed here. Shouldn't we just define @ObjectOps... Ovidiu Maxiniuc

11:22 AM Feature #3751: implement support for OO 4GL and structured error handling

Looking closer @legacy2java@ is already reset in a while loop just after a new class is loaded. It is already OK. S... Greg Shah

11:20 AM Feature #3751: implement support for OO 4GL and structured error handling

>> There is something else I don't understand about legacy2java. The map is global for the system, but I think it sho... Greg Shah

11:14 AM Feature #3751: implement support for OO 4GL and structured error handling

... Greg Shah

11:08 AM Feature #3751: implement support for OO 4GL and structured error handling

With r11343, the branch 3750a should be able to handle FIELD_CLASS tokens.
Constructs like ... Ovidiu Maxiniuc

11:04 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> In the usage of @convert_member_name@ during @annotations_prep@, shouldn't we use a different @le... Constantin Asofiei

10:46 AM Feature #3751: implement support for OO 4GL and structured error handling

There is something else I don't understand about @legacy2java@. The map is global for the system, but I think it sho... Greg Shah

10:43 AM Feature #3751: implement support for OO 4GL and structured error handling

In the usage of @convert_member_name@ during @annotations_prep@, shouldn't we use a different @legacy2java@ map for v... Greg Shah

10:18 AM Feature #3751: implement support for OO 4GL and structured error handling

The primary benefit I see is that it keeps intact the design approach of the original application. Future developmen... Greg Shah

10:10 AM Feature #3751: implement support for OO 4GL and structured error handling

OTOH, a problem with method approach is the signature: the @PUBLISH@ can have POLY arguments, and this complicates th... Constantin Asofiei

10:06 AM Feature #3751: implement support for OO 4GL and structured error handling

> I understand, but this is enforced by 4GL at compile time - so the override event must match the abstract version f... Greg Shah

09:50 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Events can be abstract. This "feature" of 4GL event support suggests we need to move to a purely ... Constantin Asofiei

09:37 AM Feature #3751: implement support for OO 4GL and structured error handling

We need to confirm this, but the 4GL docs say that the publish can only ever be called from within the same defining ... Greg Shah

09:24 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> The proposed conversion is:
> * 4GL
> [...]
> * FWD:
> [...]
It is the most close... Greg Shah

09:01 AM Feature #3751: implement support for OO 4GL and structured error handling

The proposed conversion is:
* 4GL... Constantin Asofiei

06:46 AM Feature #3751: implement support for OO 4GL and structured error handling

3750a rev 11348 adds USING conversion support.
I'm taking @- DEFINE EVENT and the related features@ next. Constantin Asofiei

06:05 AM Feature #3751: implement support for OO 4GL and structured error handling

3750a rev 11347 adds conversion support for the CATCH statement. In the end there was no need for a @CATCH_BLOCK/BLO... Constantin Asofiei

03:33 AM Feature #3751: implement support for OO 4GL and structured error handling

3750a rev 11345 added ON ... THROW support, 'UNDO, THROW' and BLOCK-LEVEL and ROUTINE-LEVEL stmts.
Now I'm working... Constantin Asofiei

12/15/2018

06:47 PM Feature #3751: implement support for OO 4GL and structured error handling

I committed the small change related to FIELD_CLASS. Revision 11343. Ovidiu Maxiniuc

05:58 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > You might have caught a bad revision. Please update again, ... Constantin Asofiei

05:57 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> You might have caught a bad revision. Please update again, your test works for me.
Wel... Ovidiu Maxiniuc

05:52 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Questions about the new early name conversion approach:
>
> * How do I move the method_def and... Constantin Asofiei

05:38 PM Feature #3751: implement support for OO 4GL and structured error handling

Revision 11342 fixes the extent getter/setters. I still need to add the other extent helpers. I plan to postpone th... Greg Shah

05:33 PM Feature #3751: implement support for OO 4GL and structured error handling

Questions about the new early name conversion approach:
* How do I move the method_def and property getter/setter ... Greg Shah

05:31 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> So if an @extent@ annotation exists at all, it is always an extent, even if set to 0 or 1?
Actua... Constantin Asofiei

05:30 PM Feature #3751: implement support for OO 4GL and structured error handling

@oo.ComplexImplements@ has regressed recently. It now generates @obj@ and @num@ references even though the class is ... Greg Shah

05:28 PM Feature #3751: implement support for OO 4GL and structured error handling

So if an @extent@ annotation exists at all, it is always an extent, even if set to 0 or 1? Greg Shah

05:25 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> I see the issue, I'm not handling -1 as the extent annotation.
Exactly, @-1@ is for indetermin... Constantin Asofiei

05:23 PM Feature #3751: implement support for OO 4GL and structured error handling

I see the issue, I'm not handling -1 as the extent annotation. If I see 0 or 1, can I assume it is scalar? Greg Shah

05:16 PM Feature #3751: implement support for OO 4GL and structured error handling

When I remove that file, the conversion completes. I can see that the @PropertyHolderExtents.cls@ has proper subscri... Greg Shah

05:14 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Please try cleaning your project first - your registry.xml might be obsolete.
Nevermind... Constantin Asofiei

05:07 PM Feature #3751: implement support for OO 4GL and structured error handling

Please try cleaning your project first - your registry.xml might be obsolete. Constantin Asofiei

05:03 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> My previous code was successfully emitting the subscript for the fixed case. I can't check the c... Constantin Asofiei

05:02 PM Feature #3751: implement support for OO 4GL and structured error handling

My previous code was successfully emitting the subscript for the fixed case. I can't check the current code because ... Greg Shah

04:59 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> I commented out all code except:
> [...]
> This fails with:
> [...]
You might have caug... Constantin Asofiei

04:56 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> > I don't understand why the indexed getter returns an array for flag - shouldn't this return jus... Constantin Asofiei

04:52 PM Feature #3751: implement support for OO 4GL and structured error handling

As I noted in #3751-132, I'm planning to add: @lengthOf<property_name>()@ and @resize<property_name>()@ methods to ha... Greg Shah

04:52 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > There is not much of a difference. I have both @builtin_clas... Ovidiu Maxiniuc

04:48 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> There is not much of a difference. I have both @builtin_classes.xml@ and @filenames_to_java... Constantin Asofiei

04:45 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> I'm also having an issue with the indeterminate extent properties in @oo/PropertyHolderExtents.cl... Constantin Asofiei

04:39 PM Feature #3751: implement support for OO 4GL and structured error handling

The TRPL problem and the tempidx issues are fixed in 11340. Constantin Asofiei

04:38 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> TRPL has a 'var leak' where the var defined in current scope is visible in a function ca... Greg Shah

04:30 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Also, please use rev 11336 of 3750a - this separates the fr... Ovidiu Maxiniuc

04:28 PM Feature #3751: implement support for OO 4GL and structured error handling

TRPL has a 'var leak' where the var defined in current scope is visible in a function call, in some cases - see @hasT... Constantin Asofiei

04:17 PM Feature #3751: implement support for OO 4GL and structured error handling

There is some "weirdness" going on in @convert/variable_definitions.rules@. There is a location where we create a @r... Greg Shah

03:51 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> After integrating your recent changes, property conversion is broken again. The @classname@ anno... Constantin Asofiei

03:49 PM Feature #3751: implement support for OO 4GL and structured error handling

Rev 11338 provides support for property getters and setters. It was a major PITA.
After integrating your recent c... Greg Shah

03:04 PM Feature #3751: implement support for OO 4GL and structured error handling

3750a rev 11337 fixes refid annotations for OO variables references outside of defining class. Constantin Asofiei

02:07 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > I need a bit of help configuring (I guess) my isolation work... Ovidiu Maxiniuc

01:57 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> I need a bit of help configuring (I guess) my isolation workspace with ABL OO class support... Constantin Asofiei

01:54 PM Feature #3751: implement support for OO 4GL and structured error handling

I need a bit of help configuring (I guess) my isolation workspace with ABL OO class support. My @SymbolResolver@ can... Ovidiu Maxiniuc

12:06 PM Feature #3751: implement support for OO 4GL and structured error handling

The current phase of class var access and chaining is in 3750a rev 11335. I need to rework this to use the 'refid' a... Constantin Asofiei

11:26 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> 3. Later, when we use a refid to obtain the node for a given var def, we need a helper that will ... Constantin Asofiei

10:41 AM Feature #3751: implement support for OO 4GL and structured error handling

OK, I'll work on that next. What showed the refid problem was the extent class var references, outside of the defini... Constantin Asofiei

10:39 AM Feature #3751: implement support for OO 4GL and structured error handling

The refid is unique across the project. It can be used between files without an issue. However, I think to make thi... Greg Shah

10:29 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg, references to variables outside of the defining class should not be annotated with 'refid' (and this annotation... Constantin Asofiei

08:10 AM Feature #3751: implement support for OO 4GL and structured error handling

The class var access and chaining works; I need to finish the extent function and subscript dereferencing before comm... Constantin Asofiei

03:36 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> > We need to fix the access modifiers for all class data members (variables, resources, etc) - ar... Constantin Asofiei

01:03 AM Feature #3751: implement support for OO 4GL and structured error handling

> We need to fix the access modifiers for all class data members (variables, resources, etc) - are you taking care of... Greg Shah

01:03 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Greg, there is some confusion (at least for me) regarding the @qualified@ annotation.
>... Greg Shah

12:59 AM Feature #3751: implement support for OO 4GL and structured error handling

Revision 11332 is the first part of the define property support. It is not done yet. Greg Shah

08:32 PM Feature #3751: implement support for OO 4GL and structured error handling

An important note: at least for OO, the CB phase depends on some state determined by the F0 phase (class definitions/... Constantin Asofiei

08:27 PM Feature #3751: implement support for OO 4GL and structured error handling

I've managed to go around the @qualified@ annotation, but this still confuses me.
3750a rev 11331 has a mostly wor... Constantin Asofiei

08:13 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg, there is some confusion (at least for me) regarding the @qualified@ annotation.
* In some parts, for example a... Constantin Asofiei

07:05 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> ** Get the converted name (I hope to leverage your work there).
See the changes in 3750a rev 113... Constantin Asofiei

03:58 AM Feature #2135 (WIP): implement COPY-LOB language statement

Task branch 3750a/11334 includes basic support for copying between all combinations of @CLOB@, @BLOB@, @longchar@, an... Eric Faulhaber

12/14/2018

05:10 PM Feature #3751: implement support for OO 4GL and structured error handling

The following testcases show the behavior of properties (except for the access control options):... Greg Shah

05:02 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> I agree your approach makes sense. I had to do this for the class names but didn't get to the re... Constantin Asofiei

04:57 PM Feature #3751: implement support for OO 4GL and structured error handling

I'm not working on it. I'm writing up my plan for properties right now. As you will see shortly, I've got my hands ... Greg Shah

04:43 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg, are you working on annotating the ASTs which access methods or other members with their converted java name? B... Constantin Asofiei

04:20 PM Feature #3751: implement support for OO 4GL and structured error handling

> I will do it tomorrow.
Thank you! Greg Shah

04:15 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Code Review Task branch 3750a Revision 11328
>
> Nice work! I think you have the M0 part in a... Ovidiu Maxiniuc

04:11 PM Feature #3751: implement support for OO 4GL and structured error handling

Code Review Task branch 3750a Revision 11328
Nice work! I think you have the M0 part in a good place. Do you fee... Greg Shah

04:10 PM Feature #3751: implement support for OO 4GL and structured error handling

Code Review Task branch 3750a Revision 11327
It is good.
In line 705 of @buffer_definitions.rules@, there is th... Greg Shah

03:57 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> One thing to consider is that our @object@ wrapper is a generic. When one considers that @FIELD_... Ovidiu Maxiniuc

03:24 PM Feature #3751: implement support for OO 4GL and structured error handling

3750a rev 11327 :
* finishes the constructor/destructor support
* implicit initialization c'tor - our 'execute' met... Constantin Asofiei

01:52 PM Feature #3751: implement support for OO 4GL and structured error handling

> > If I understand it correctly, it should be the same as we define now except we don't need any buffers.
> The b... Greg Shah

01:46 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> If I understand it correctly, it should be the same as we define now except we don't need any buf... Constantin Asofiei

01:15 PM Feature #3751: implement support for OO 4GL and structured error handling

If I understand it correctly, it should be the same as we define now except we don't need any buffers. The define st... Greg Shah

01:12 PM Feature #3751: implement support for OO 4GL and structured error handling

I'm not removing the promotion, the thing here is that our var defs rules were dependent upon some values initializin... Greg Shah

01:10 PM Feature #3751: implement support for OO 4GL and structured error handling

How do we treat the @temp-table@ defined at an interface? Constantin Asofiei

12:54 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> For example, I had to make up for the lack of an @execute()@ method in classes by "faking" some i... Constantin Asofiei

12:52 PM Feature #3751: implement support for OO 4GL and structured error handling

> part of object creation there will be a call to a __p1_Bar_execute__ method, which emulates an empty external progr... Greg Shah

12:47 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> A part with resource data members is code like @frame.openScope()@ - this needs to be em... Constantin Asofiei

12:26 PM Feature #3751: implement support for OO 4GL and structured error handling

> but not sure about the default ? value
Object instances default to unknown value so this is consistent. Consid... Greg Shah

12:24 PM Feature #3751: implement support for OO 4GL and structured error handling

I'm responding to #3750-69 here so that all the @FIELD_CLASS@ information is in one place. See #3751-48 for some use... Greg Shah

12:21 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Revision 11326 provides fixes to make interface definitions work properly.
> Ovidiu: Is the @FIE... Ovidiu Maxiniuc

11:51 AM Feature #3751: implement support for OO 4GL and structured error handling

I'm taking SUPER and THIS-OBJECT, too. Constantin Asofiei

11:05 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Constantin: What are you working on right now? I think it is time to handle conversion of @OBJEC... Constantin Asofiei

10:39 AM Feature #3751: implement support for OO 4GL and structured error handling

Revision 11326 provides fixes to make interface definitions work properly.
Ovidiu: Is the @FIELD_CLASS@ support co... Greg Shah

05:35 AM Feature #3751: implement support for OO 4GL and structured error handling

The constructor and destructor conversion is in 3750a rev 11323:
What's left here:
* implicit initialization c'tor ... Constantin Asofiei

05:00 AM Feature #3751: implement support for OO 4GL and structured error handling

I'm working on what you mentioned in #3751-106. Note that the vars defined within a method are not scoped to it - I'... Constantin Asofiei

11:33 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin: Everything I've been working on is checked in. Some thoughts:
1. To work on the non-var members, I re... Greg Shah

10:58 PM Feature #3751: implement support for OO 4GL and structured error handling

Revision 11322 provides fully functional method definition support. Greg Shah

12/13/2018

05:40 PM Feature #3751: implement support for OO 4GL and structured error handling

Rev 11321 adds more method def support. It is almost working now. Method parameters are broken. I'm working on it. Greg Shah

05:06 PM Feature #3751: implement support for OO 4GL and structured error handling

A part with resource data members is code like @frame.openScope()@ - this needs to be emitted I think in 'legacy defa... Constantin Asofiei

04:29 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> In the interim, can you please look at data members that are not vars (buffers, frames...) in cla... Constantin Asofiei

03:22 PM Feature #3751: implement support for OO 4GL and structured error handling

I'm about to have an implementation of methods pretty soon (at least in classes). At that time we can figure out the... Greg Shah

03:12 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> @isTopLevel@ excludes the class or interface body but @isTopLevelOrOO@ does not.
>
> Revision ... Constantin Asofiei

02:38 PM Feature #3751: implement support for OO 4GL and structured error handling

I guess I should have said: we are deliberately excluding those in @isTopLevel@ because the places where it is being ... Greg Shah

02:37 PM Feature #3751: implement support for OO 4GL and structured error handling

@isTopLevel@ excludes the class or interface body but @isTopLevelOrOO@ does not.
Revision 11319 adds more enableme... Greg Shah

02:33 PM Feature #3751: implement support for OO 4GL and structured error handling

What was the purpose to add @isTopLevelOrOO@ instead of just changing @isTopLevel@ to handle OO blocks, too? Constantin Asofiei

02:15 PM Feature #3751: implement support for OO 4GL and structured error handling

3750a ref 11318 contains:
* Added CAST, DYNAMIC-CAST, DYNAMIC-NEW, NEW, TYPE-OF, VALID-OBJECT.
* Emit .class Java ... Constantin Asofiei

02:08 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> However, I agree that @CAST@ needs to return an @object@.
>
> But why not emit this for chaini... Constantin Asofiei

02:03 PM Feature #3751: implement support for OO 4GL and structured error handling

However, I agree that @CAST@ needs to return an @object@.
But why not emit this for chaining: @ObjectOps.cast(o, c... Greg Shah

02:02 PM Feature #3751: implement support for OO 4GL and structured error handling

> OTOH, it can be emitted like @ObjectOps.cast(o, com.goldencode.testcases.p1.O1.class).m1();@ if its signature is @p... Greg Shah

01:59 PM Feature #3751: implement support for OO 4GL and structured error handling

@CAST@ allows a construct like @cast(o, p1.O1):m1().@.
This needs to be converted to something like:... Constantin Asofiei

01:30 PM Feature #3751: implement support for OO 4GL and structured error handling

We are excluding support for duck typing as a permanent restriction, so we don't need strings there.
@DYNAMIC-CA... Greg Shah

01:16 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Greg Shah wrote:
> > Can you think of any other case for indirect invocation?
> 4GL ha... Constantin Asofiei

01:11 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Constantin Asofiei wrote:
> > @CLASS_NAME@ literals will emit as string literals with the legacy... Constantin Asofiei

01:11 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> @CLASS_NAME@ literals will emit as string literals with the legacy qualified class name ... Greg Shah

01:01 PM Feature #3751: implement support for OO 4GL and structured error handling

@CLASS_NAME@ literals will emit as string literals with the legacy qualified class name or Java full qualified name? Constantin Asofiei

12:50 PM Feature #3751: implement support for OO 4GL and structured error handling

> I think Progress.Lang.Class should be LegacyClass or something.
I like it. Greg Shah

12:48 PM Feature #3751: implement support for OO 4GL and structured error handling

Plus @CLASS_NAME@ literals. Constantin Asofiei

12:48 PM Feature #3751: implement support for OO 4GL and structured error handling

I'm adding these to my list:... Constantin Asofiei

12:20 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Can you think of any other case for indirect invocation?
4GL has reflection support via @Progres... Constantin Asofiei

12:19 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Constantin Asofiei wrote:
> > Do you still want to use @BaseObject@ name for @Progress.Lang.Obje... Constantin Asofiei

12:17 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Do you still want to use @BaseObject@ name for @Progress.Lang.Object@ class?
I wanted... Greg Shah

12:16 PM Feature #3751: implement support for OO 4GL and structured error handling

3750a rev 11317:
* added DELETE OBJECT obj, SESSION:LAST/FIRST-OBJECT conversion support.
* reworked builtin clas... Constantin Asofiei

11:56 AM Feature #3751: implement support for OO 4GL and structured error handling

Do you still want to use @BaseObject@ name for @Progress.Lang.Object@ class? Constantin Asofiei

11:37 AM Feature #3751: implement support for OO 4GL and structured error handling

> Also, I assume only stubs will be added for i.e. delete, nextSibling(), etc
Yes, this is OK. Greg Shah

11:36 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > A minor thing, but... is there a reason this needs to be a su... Greg Shah

11:36 AM Feature #3751: implement support for OO 4GL and structured error handling

For normal expressions processing (object and class dereferencing), we are planning to use a direct method invocation... Greg Shah

11:35 AM Feature #3751: implement support for OO 4GL and structured error handling

OO method calls and attribute access is not there yet, correct?
Also, I assume only stubs will be added for i.e. @... Constantin Asofiei

11:34 AM Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> A minor thing, but... is there a reason this needs to be a sub-package of @util@? How about ... Constantin Asofiei

11:32 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> I'd just get rid of this package and use something like @com.goldencode.p2j.util.oo.lang... Eric Faulhaber

11:16 AM Feature #3751: implement support for OO 4GL and structured error handling

3750a rev 11316 is some intermediate changes for method definitions. They are not working yet, but I don't want our ... Greg Shah

11:15 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Can we automate the @annotations_prep.rules@ step of registering the built-in classes?
... Greg Shah

11:11 AM Feature #3751: implement support for OO 4GL and structured error handling

Can we automate the @annotations_prep.rules@ step of registering the built-in classes?... Constantin Asofiei

11:01 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Is @Progress.Lang.Object@ skeleton required to be in the conversion list? I get this for... Greg Shah

11:00 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Is @Progress.Lang.Object@ skeleton required to be in the conversion list? I get this for... Constantin Asofiei

10:58 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Do we already have a OO ops helper class? For @new@, @delete@, etc.
>
> If not, I'll ... Greg Shah

10:57 AM Feature #3751: implement support for OO 4GL and structured error handling

Is @Progress.Lang.Object@ skeleton required to be in the conversion list? I get this for a @def var o as Progress.Lan... Constantin Asofiei

10:50 AM Feature #3751: implement support for OO 4GL and structured error handling

Do we already have a OO ops helper class? For @new@, @delete@, etc.
If not, I'll add ObjectOps. Constantin Asofiei

10:44 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> This seems reasonable. One question: why is the package part needed? I'd rather decorate it wit... Constantin Asofiei

10:43 AM Feature #3751: implement support for OO 4GL and structured error handling

> the constructors will not be Java constructors, but object initialization methods
Yes, this is my understanding ... Greg Shah

10:39 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> I'm working on getting data members to emit properly. Then I am going to take method definitions... Constantin Asofiei

07:25 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Functions even share the same namespace as internal procedures.
>
> Why do we need to disamb... Constantin Asofiei

07:03 PM Feature #3751: implement support for OO 4GL and structured error handling

Since methods can't be in the same compilation unit with functions or procedures, there cannot be any naming conflict... Greg Shah

12/12/2018

06:49 PM Feature #3751: implement support for OO 4GL and structured error handling

I also did confirm that internal procedures and user defined functions cannot be defined inside a class definition.
... Greg Shah

06:46 PM Feature #3751: implement support for OO 4GL and structured error handling

Triggers can be defined inside a class as shown by this example:... Greg Shah

10:52 PM Feature #3751: implement support for OO 4GL and structured error handling

3750a rev 11313 provides support for variables as data members in classes or interfaces. Greg Shah

12/11/2018

04:21 PM Feature #3751: implement support for OO 4GL and structured error handling

I'm working on getting data members to emit properly. Then I am going to take method definitions.
Constantin: Aft... Greg Shah

04:18 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> > Is anyone working on the conversion of FIELD_CLASS right now?
>
> I'm not.
>
> Constantin... Constantin Asofiei

04:16 PM Feature #3751: implement support for OO 4GL and structured error handling

> Is anyone working on the conversion of FIELD_CLASS right now?
I'm not.
Constantin ? Greg Shah

04:14 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> * Is there any reason to believe that the OO 4GL object instances are a kind of handle (other tha... Constantin Asofiei

04:07 PM Feature #3751: implement support for OO 4GL and structured error handling

3750a rev 11312 provides variable and parameter definition support for AS CLASS, LIKE VAR_CLASS and LIKE FIELD_CLASS.... Greg Shah

03:25 PM Feature #3751: implement support for OO 4GL and structured error handling

I'm working on var/parm defs right now. I've just checked in 3750a rev 11311 which is an early version of the @objec... Greg Shah

02:28 PM Feature #3751: implement support for OO 4GL and structured error handling

Eric suggests using @object@ instead of @ObjectRef@. It is shorter and is in the same kind of lowercase format as th... Greg Shah

11:55 AM Feature #3751: implement support for OO 4GL and structured error handling

I've been writing some testcases to explore unknown value, assignment and undo. In all of these areas, the behavior ... Greg Shah

12/10/2018

05:00 PM Feature #3751: implement support for OO 4GL and structured error handling

The 4GL documentation for FIELD_CLASS states that it is only possible to make it @Progress.Lang.Object@. It turns ou... Greg Shah

10:04 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> I'm talking about the creation of the widget pool itself, not the registration of handle resource... Constantin Asofiei

09:36 AM Feature #3751: implement support for OO 4GL and structured error handling

>> For the instance case, we can create it in the "constructor worker" method. For the class case, in a static intial... Greg Shah

12/09/2018

05:47 PM Feature #3751: implement support for OO 4GL and structured error handling

3750a revision 11307 adds support for @IMPLEMENTS@. Greg Shah

01:56 PM Feature #3751: implement support for OO 4GL and structured error handling

3750a revision 11306 is the first phase of conversion support for OO 4GL. This revision can properly convert empty c... Greg Shah

12/08/2018

02:54 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Is there a different widget pool for each instance or is there a single widget pool for the class... Constantin Asofiei

12:36 PM Feature #3751: implement support for OO 4GL and structured error handling

> Same, I think this is some compile-time augmentation for CREATE statements using static members.
Is there a dif... Greg Shah

12/07/2018

06:22 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> > And @USE-WIDGET-POOL@ - is this currently used?
>
> Sorry, it took some time to run the sear... Constantin Asofiei

04:46 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> * I assume that statics are not affected, only instance members. The 4GL doesn't allow accessing... Constantin Asofiei

04:28 PM Feature #3751: implement support for OO 4GL and structured error handling

> Greg, we need to determine how we handle the same stuff with unknown object references, for normal var case. 4GL gi... Greg Shah

03:45 PM Feature #3751: implement support for OO 4GL and structured error handling

> And @USE-WIDGET-POOL@ - is this currently used?
Sorry, it took some time to run the search across both projects.... Greg Shah

03:29 PM Feature #3751: implement support for OO 4GL and structured error handling

Direct field reference like @where tt.obj = ?@ or @where tt.obj <> ?@ does work.
But there is something interestin... Constantin Asofiei

02:55 PM Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> If so, how is tt.obj.foo dereferenced? Is this the equivalent of a user-defined function, wh... Constantin Asofiei

02:18 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin, are there any limitations as to how a field of data type @class@ can be used in a WHERE clause? For insta... Eric Faulhaber

02:10 PM Feature #3751: implement support for OO 4GL and structured error handling

Something about widget definitions in a class (like @DEF BUTTON btn@) - in documentation there is a statement like 'C... Constantin Asofiei

12/06/2018

02:33 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> * how do you plan to emit the 4GL c'tors? As a Java constructor, right?
And I just real... Constantin Asofiei

02:28 PM Feature #3751: implement support for OO 4GL and structured error handling

About constructors and destructors:
* how do you plan to emit the 4GL c'tors? As a Java constructor, right?
* destr... Constantin Asofiei

01:06 PM Feature #3751: implement support for OO 4GL and structured error handling

I think we can calculate this if I just add the fully qualified OO name to the @class-mapping@ node as an @ooname@ at... Greg Shah

12:41 PM Feature #3751: implement support for OO 4GL and structured error handling

I've been assuming that we will need the conversion name mapping anyway for things like @DYNAMIC-NEW@. I was thinkin... Greg Shah

12:34 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> My idea is that at parsing time, we have resolved the 4GL fully qualified names to some actual un... Constantin Asofiei

10:36 AM Feature #3751: implement support for OO 4GL and structured error handling

I'm working on the resolution of the converted Java class name information (simple class name, package name and fully... Greg Shah

10:00 AM Feature #3751: implement support for OO 4GL and structured error handling

Branch 3750a revision 11302 includes these changes:
* Added reports for constructors, destructors and duplicate fu... Greg Shah

12/05/2018

06:03 PM Feature #3751: implement support for OO 4GL and structured error handling

Good results so far. Please check in your testcases to @testcases/uast/oo/@.
Next questions:
5. Please conside... Greg Shah

05:15 PM Feature #3751: implement support for OO 4GL and structured error handling

Leaving duck typing aside, and looking through the JVM specs, I can't find other issues at this time.
This comment... Constantin Asofiei

03:58 PM Feature #3751: implement support for OO 4GL and structured error handling

> JVM specs don't guarantee which tread will execute the finalize() method - and if the DESTRUCTOR contains 4GL logic... Greg Shah

03:39 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> I think so. You aren't supposed to be able to execute it directly and it only gets executed when... Constantin Asofiei

03:33 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> > in Java you can't hide an instance method via a static method, but you can in 4GL.
>
> Did y... Constantin Asofiei

03:32 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Another issue with using Java inheritance: in Java, you can't reduce the visibility of a... Constantin Asofiei

03:29 PM Feature #3751: implement support for OO 4GL and structured error handling

> You mean without using a dynamic proxy? The problem I can think of is the EXTENT parameters - there is some validat... Greg Shah

03:26 PM Feature #3751: implement support for OO 4GL and structured error handling

> in Java you can't hide an instance method via a static method, but you can in 4GL.
Did you find this via testing... Greg Shah

03:26 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Is there any reason that a method call with non-POLY arguments can't be directly dispatched?
You... Constantin Asofiei

03:20 PM Feature #3751: implement support for OO 4GL and structured error handling

And there is this "gem" (from the 4GL docs):
"On a state-reset AppServer, a given AppServer agent begins a fresh A... Greg Shah

03:01 PM Feature #3751: implement support for OO 4GL and structured error handling

Also in Java you can't hide an instance method via a static method, but you can in 4GL.
LE: this was tested incorr... Constantin Asofiei

02:55 PM Feature #3751: implement support for OO 4GL and structured error handling

Another issue with using Java inheritance: in Java, you can't reduce the visibility of a member, just upgrade it. In... Constantin Asofiei

02:42 PM Feature #3751: implement support for OO 4GL and structured error handling

> I was thinking we could do a mode where, if a project is not using duck-typing, we rely on Java inheritance for con... Greg Shah

02:31 PM Feature #3751: implement support for OO 4GL and structured error handling

I was thinking we could do a mode where, if a project is not using duck-typing, we rely on Java inheritance for conve... Constantin Asofiei

01:58 PM Feature #3751: implement support for OO 4GL and structured error handling

Use @string(THIS-OBJECT)@ (or @string(ooVar)@) to determine the handle ID (this is suffixed to the class name, like @... Constantin Asofiei

01:41 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> > the limitations introduced by duck typing I think will not allow us to use Java inheritance, wh... Constantin Asofiei

01:36 PM Feature #3751: implement support for OO 4GL and structured error handling

> the limitations introduced by duck typing I think will not allow us to use Java inheritance, when emulating the 4GL... Greg Shah

01:24 PM Feature #3751: implement support for OO 4GL and structured error handling

4. About @static@ constructors. 4GL states:
> STATIC specifies a static constructor that executes exactly once in an... Constantin Asofiei

01:17 PM Feature #3751: implement support for OO 4GL and structured error handling

I'm posting our duck typing example here so that readers can see the full context of the discussion.
@duck_typing.... Greg Shah

12/04/2018

05:12 PM Feature #3755 (Closed): DEBUGGER system handle stubs

Code Review Task Branch 3750a Revision 11300
I'm good with the changes.
In the future, I would like to avoid th... Greg Shah

01:51 PM Feature #3755 (Review): DEBUGGER system handle stubs

Constantin Asofiei

01:51 PM Feature #3755 (WIP): DEBUGGER system handle stubs

DEBUGGER support - full conversion and stubbed runtime - is in 3750a rev 11294. Constantin Asofiei

03:13 PM Feature #3753: I18N additions

A note to check: editor with LONGCHAR value, having a non-default codepage. Constantin Asofiei

02:35 PM Feature #3753: I18N additions

The conversion issues for this task (phase 1) are solved in 3750a rev 11297. Constantin Asofiei

02:07 PM Feature #3756 (WIP): minor modifications for SESSION system handle support

The conversion problems in this task are solved in 3750a rev 11295: adds SESSION:V6DISPLAY conversion and get/set run... Constantin Asofiei

12/03/2018

09:08 AM Feature #3752 (Closed): CLIENT-PRINCIPAL resource and other security features

The remainder of the CLIENT-PRINCIPAL support will be implemented in #3810. Greg Shah

08:53 AM Feature #3752: CLIENT-PRINCIPAL resource and other security features

3752a was merged to trunk rev 11293 and archived.
> Added runtime/conversion support for SET-DB-CLIENT, GET-DB-CLI... Constantin Asofiei

12/01/2018

07:50 AM Feature #3752: CLIENT-PRINCIPAL resource and other security features

Please merge to trunk. Greg Shah

11/30/2018

04:23 PM Feature #3752: CLIENT-PRINCIPAL resource and other security features

Conversion testing of 3752a rev 11297 passed. Constantin Asofiei

02:05 PM Feature #3752: CLIENT-PRINCIPAL resource and other security features

3752a rev 11297 fixes the review issues.
I'm doing conversion testing next. Constantin Asofiei

01:49 PM Feature #3752: CLIENT-PRINCIPAL resource and other security features

Greg Shah wrote:
> > If the name is invalid, I'll throw an exception, as we can't use the default DB.
>
> OK, as ... Constantin Asofiei

01:45 PM Feature #3752: CLIENT-PRINCIPAL resource and other security features

> If the name is invalid, I'll throw an exception, as we can't use the default DB.
OK, as long as the NPE does not... Greg Shah

01:43 PM Feature #3752: CLIENT-PRINCIPAL resource and other security features

Greg Shah wrote:
> 1. In @ConnectionManager.getDbClient()/setDbClient()@, the use of @cm.getLDBName(dbName).toLowerC... Constantin Asofiei

11:15 AM Feature #3752: CLIENT-PRINCIPAL resource and other security features

I don't think this needs runtime testing. If it passes conversion testing for ChUI, it can be merged to trunk. Greg Shah

11:14 AM Feature #3752: CLIENT-PRINCIPAL resource and other security features

Code Review Task Branch 3752a Revision 11295
The result is very good. I've only found some minor issues:
1. In... Greg Shah

11/29/2018

02:36 PM Feature #3753 (WIP): I18N additions

Constantin Asofiei

11/28/2018

12:46 PM Feature #3752: CLIENT-PRINCIPAL resource and other security features

Please review 3752a rev 11295 - it contains the changes required for the current POC. Constantin Asofiei

11/26/2018

12:58 PM Feature #3817: create resource bundles from string literals and implement optional support for se...

This is meant to be a Java-native replacement for the ability to swap translated string literals at runtime.
+Back... Greg Shah

12:21 PM Feature #3817 (Closed): create resource bundles from string literals and implement optional suppo...

Greg Shah

11/25/2018

11:05 AM Feature #3753: I18N additions

Implement these for Phase 2 (main project):
* generalized CONVERT option support (e.g. not just INPUT but also use... Greg Shah

10:36 AM Feature #2135: implement COPY-LOB language statement

As phase 3 of development, the following will all be needed:... Greg Shah

09:23 AM Feature #3812: additions to SESSION system-handle

+Attributes+
* CURRENT-REQUEST-INFO
* LOCAL-VERSION-INFO
* SERVER-CONNECTION-BOUND-REQUEST
* ICFPARAMETER
* CO... Greg Shah

09:19 AM Feature #3812 (Closed): additions to SESSION system-handle

Greg Shah

08:21 AM Feature #3810: SECURITY-POLICY and other security features

Implement support for the following:
+SECURITY-POLICY resource+
* SECURITY-POLICY system handle
* attributes
... Greg Shah

07:41 AM Feature #3810 (Closed): SECURITY-POLICY and other security features

Greg Shah