FWD » Core Development » Base Language

02/16/2021

04:42 PM Feature #4384: Builtin OO Implementation

I've added wiki documentation that lists our currently "supported built-in OO classes":/projects/p2j/wiki/Object_Orie... Greg Shah

01:58 PM Bug #5029 (Test): OO constructor with array input parameter

Greg Shah

01:12 PM Bug #5029: OO constructor with array input parameter

Constantin Asofiei wrote:
> OK, that's because my tests always had the INPUT modifier. I'll fix this.
>
> For no... Constantin Asofiei

02/15/2021

08:20 AM Feature #4384: Builtin OO Implementation

Please use this patch. It will be in 3821c in the next couple of days.... Constantin Asofiei

08:04 AM Feature #4384: Builtin OO Implementation

Marian, the root cause is because the reference is incremented when the INPUT parameter is initialized in the propert... Constantin Asofiei

02:37 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> As long as you use @TypeFactory.object@ or @UndoableFactory.object@ to initialize a prop... Marian Edu

02/14/2021

10:51 AM Feature #4384: Builtin OO Implementation

As long as you use @TypeFactory.object@ or @UndoableFactory.object@ to initialize a property/var, then reference coun... Constantin Asofiei

10:47 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Marian, I had to revert your @object.setUnknown@ change which decremented the reference ... Marian Edu

02/13/2021

05:51 PM Feature #4384: Builtin OO Implementation

Marian, I had to revert your @object.setUnknown@ change which decremented the reference - only @ObjectVar@ is allowed... Constantin Asofiei

02/12/2021

10:41 AM Feature #5146: record additional legacy class and method data in annotations

* We should be able to record (in an annotation) whether the converted class was a @CLASS@, @INTERFACE@ or @ENUM@ in ... Greg Shah

10:40 AM Feature #5146 (New): record additional legacy class and method data in annotations

Greg Shah

02/11/2021

08:32 AM Bug #5029: OO constructor with array input parameter

My current work touches how 4GL moves the data from the arguments to the parameters, via the stack, for the integer/i... Constantin Asofiei

08:24 AM Bug #5029: OO constructor with array input parameter

There is another thing with indeterminate extent output parameters, in 4GL it doesn't matter if the extent was alread... Marian Edu

08:20 AM Bug #5029: OO constructor with array input parameter

OK, that's because my tests always had the INPUT modifier. I'll fix this.
For now, change it like @INPUT cInExt@ ... Constantin Asofiei

08:14 AM Bug #5029: OO constructor with array input parameter

Constantin Asofiei wrote:
> What are you using exactly as argument? A OO property? A class variable? Something else?... Marian Edu

08:11 AM Bug #5029: OO constructor with array input parameter

What are you using exactly as argument? A OO property? A class variable? Something else? Constantin Asofiei

08:07 AM Bug #5029: OO constructor with array input parameter

Constantin, conversion is not using @InputOutputExtentParameter@ anymore but it's missing the cast to Object so it st... Marian Edu

02/10/2021

09:07 AM Feature #4384: Builtin OO Implementation

Marian, @LegacyClass@ is missing legacy constructor method(s). Please add them.
If you debug into the @newInstanc... Constantin Asofiei

08:51 AM Feature #4384: Builtin OO Implementation

Constantin, another thing that we've found is when using any instance level methods in @LegacyClass@ we get a nice NP... Marian Edu

02/08/2021

09:24 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Marian, the root cause is @REGISTRY.set(registry);@ instead of @REGISTRY.get().assign(r... Marian Edu

09:14 AM Feature #4384: Builtin OO Implementation

Marian, the root cause is @REGISTRY.set(registry);@ instead of @REGISTRY.get().assign(registry);@ in @HttpHeaderBuil... Constantin Asofiei

08:52 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> What test do you use? Can you isolate this in something simple?
This is the simplest o... Marian Edu

07:21 AM Feature #4384: Builtin OO Implementation

Marian Edu wrote:
> Right, but for an object this means the reference is the same... two objects pointing to the sam... Constantin Asofiei

07:19 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Marian, please give me an example where you need equals/hashCode in the collection imple... Marian Edu

06:29 AM Feature #4384: Builtin OO Implementation

Marian, please give me an example where you need equals/hashCode in the collection implementations.
As a rule of t... Constantin Asofiei

02:47 AM Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> Branch 4384h was created from branch 3821c revision 11992. Please note that some changes from 43... Marian Edu

02/05/2021

08:23 AM Bug #4824 (Closed): Conversion error for property with indeterminate extent

Greg Shah

07:28 AM Bug #4824: Conversion error for property with indeterminate extent

This seems to work on 4384h, at least for @oo/Discovery/OpenEdge/Core/IObjectArrayHolder.cls@. Marian Edu

08:22 AM Bug #4827 (Closed): OO Conversion issue with method resolve (erasure)

Greg Shah

07:23 AM Bug #4827: OO Conversion issue with method resolve (erasure)

Greg, just tried that on 4384h and the conversion on those erasure quirks tests seems to work now, if I find anything... Marian Edu

06:01 AM Feature #4384: Builtin OO Implementation

Branch 4384h was created from branch 3821c revision 11992. Please note that some changes from 4384g were modified to... Greg Shah

02/04/2021

05:27 AM Bug #5029: OO constructor with array input parameter

Constantin Asofiei wrote:
> Marian, many issues related to extent parameters and others are fixed in 3821c 11984. T... Marian Edu

05:16 AM Bug #5029: OO constructor with array input parameter

Marian, many issues related to extent parameters and others are fixed in 3821c 11984. This will be in the 4384h.
... Constantin Asofiei

02/03/2021

04:52 PM Feature #4384: Builtin OO Implementation

I have merged the 4384g changes as 3821c revision 11982.
I will create task branch 4384h from 3821c tomorrow, when... Greg Shah

02/02/2021

05:59 PM Feature #4378: properly handle clob/lonchar assignment, especially the implicit codepage conversion

I guess so. I have not yet investigated how the @FIX-CODEPAGE@ function works, just spotted the compile-time error an... Ovidiu Maxiniuc

04:58 PM Feature #4378: properly handle clob/lonchar assignment, especially the implicit codepage conversion

Can I assume that @FIX-CODEPAGE(hHandle::longCharFiled) = 'utf-8' NO-ERROR.@ will alter the codepage of @longCharFile... Constantin Asofiei

04:47 PM Feature #4378: properly handle clob/lonchar assignment, especially the implicit codepage conversion

I encountered a conversion issue which I think is really related to this tracker.
If we have a @fixedLongchar@ var... Ovidiu Maxiniuc

11:42 AM Bug #5123: Remove sessionFree AppServer configuration parameter

FWD has undocumented @sessionFree@ AppServer configuration parameter. The only thing it does, it defines if session-f... Stanislav Lomany

11:40 AM Bug #5123 (New): Remove sessionFree AppServer configuration parameter

Stanislav Lomany

02/01/2021

08:26 AM Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> To be clear: if we merge the recent changes from 3821c into 4384g, then the revision history of 4... Marian Edu

08:23 AM Feature #4384: Builtin OO Implementation

To be clear: if we merge the recent changes from 3821c into 4384g, then the revision history of 4384g changes would b... Greg Shah

08:20 AM Feature #4384: Builtin OO Implementation

This is the 3821c changes being put on top of 4384g. I'm looking to see the opposite patch. The idea is to start wi... Greg Shah

03:13 AM Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> Use @bzr send@ to package up the revision(s) in the new local branch of 3821c. Post the output h... Marian Edu

01/31/2021

03:08 PM Feature #4384: Builtin OO Implementation

Use @bzr send@ to package up the revision(s) in the new local branch of 3821c. Post the output here and I will apply... Greg Shah

11:26 AM Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> I've pushed 3821c revision 11969 to xfer. We have merged 4397a (TT serialization and dataset fix... Marian Edu

01/30/2021

08:28 PM Support #5111: TempTableSchema & BufferField

The stack trace:... Eugenie Lyzenko

07:33 PM Support #5111: TempTableSchema & BufferField

Greg Shah wrote:
> OK, unless Eric objects, please go ahead with the merge today. This will allow 2 things:
>
> ... Eugenie Lyzenko

01/29/2021

06:48 PM Feature #4384: Builtin OO Implementation

I've pushed 3821c revision 11969 to xfer. We have merged 4397a (TT serialization and dataset fixes) and 1587b (CONTA... Greg Shah

09:59 AM Support #5120: Date/Datetime - from iso

Ovidiu, the reason for @date.parseIsoDate@ having fallback approaches is because a @2020-01-01@ string can be parsed ... Constantin Asofiei

08:46 AM Support #5120: Date/Datetime - from iso

Constantin Asofiei wrote:
> Marian, the @date.parseIsoDate@ usage in JsonArray (and maybe others) I don't think is e... Marian Edu

08:37 AM Support #5120: Date/Datetime - from iso

Constantin Asofiei wrote:
> Ovidiu: for read-json, in case of invalid string, I get this error (as an example):
> [... Ovidiu Maxiniuc

07:56 AM Support #5120: Date/Datetime - from iso

Marian, the @date.parseIsoDate@ usage in JsonArray (and maybe others) I don't think is enoubht (at least what I have ... Constantin Asofiei

07:35 AM Support #5120 (WIP): Date/Datetime - from iso

Marian, you are right, FWd is too lenient. I'm looking at it. Constantin Asofiei

07:27 AM Support #5120: Date/Datetime - from iso

From Marian:
> Working on Json getDate/Datetime the @date.parseIsoDate@ method is being used to parse the ISO form... Constantin Asofiei

06:00 AM Support #5120 (Closed): Date/Datetime - from iso

Marian Edu

01/28/2021

12:42 PM Support #5111: TempTableSchema & BufferField

I will do a code review of the latest changes in 4397a. Eric Faulhaber

11:33 AM Support #5111: TempTableSchema & BufferField

OK, unless Eric objects, please go ahead with the merge today. This will allow 2 things:
1. Eugenie can do a full... Greg Shah

11:20 AM Support #5111: TempTableSchema & BufferField

No, although I never converted and ran a large customer application I do not think merging 4397a will worsen 3821c. I... Ovidiu Maxiniuc

11:04 AM Support #5111: TempTableSchema & BufferField

Are these known issues something that will make 3821c worse? Or are they also broken already in 3821c? Greg Shah

10:12 AM Support #5111: TempTableSchema & BufferField

There is a typo. Actually the task is #4397 and branch 4397a. The current revision 11986 is generally stable. There a... Ovidiu Maxiniuc

09:03 AM Support #5111: TempTableSchema & BufferField

> maybe it's time for a new branch, it looks like there could potentially be some merge conflicts anyway :(
Yes.
... Greg Shah

01:45 AM Support #5111: TempTableSchema & BufferField

Ovidiu Maxiniuc wrote:
> However, this method is already used in @JsonExport.writeRecord()@ for the exact goal:
... Marian Edu

11:14 AM Bug #5104: Cannot cast integer input parameter to dynamic function character parameter

You're probably correct about the "wrap" annotation, since I get the same error with this testcase:... Roger Borrello

11:02 AM Bug #5104: Cannot cast integer input parameter to dynamic function character parameter

That won't be the solution for the larger issue. It just highlights that the @MESSAGE@ statement uses wrapping to ma... Greg Shah

10:32 AM Bug #5104: Cannot cast integer input parameter to dynamic function character parameter

The culprit is @convert/expressions.rules@:... Roger Borrello

06:52 AM Bug #5104: Cannot cast integer input parameter to dynamic function character parameter

Roger, I agree, the literal should be wrapped to @integer@ BDT class.
Add the @ -Drules.tracing=true@ JVM argument... Constantin Asofiei

07:01 PM Bug #5104: Cannot cast integer input parameter to dynamic function character parameter

What is the @wrap@ annotation used for? It looks like it is used in may rules. Roger Borrello

01/27/2021

06:48 PM Bug #5104: Cannot cast integer input parameter to dynamic function character parameter

Comparing the AST files, the version that doesn't work has this annotation in the @dynamic-function@ node:... Roger Borrello

06:26 PM Bug #5104: Cannot cast integer input parameter to dynamic function character parameter

Here is the broken Java:... Roger Borrello

06:18 PM Bug #5104: Cannot cast integer input parameter to dynamic function character parameter

Strangely enough, when I change the code from:... Roger Borrello

05:26 PM Bug #5104: Cannot cast integer input parameter to dynamic function character parameter

Constantin Asofiei wrote:
> I see what you mean now. I read the last argument as 'l' and not value '1', for some re... Roger Borrello

01:55 PM Bug #5104: Cannot cast integer input parameter to dynamic function character parameter

From Constantin: To see the validation of the parameters occur, set a breakpoint in @ControlFlowOps.valid@ at 8365 (@... Roger Borrello

12:16 PM Bug #5104: Cannot cast integer input parameter to dynamic function character parameter

Sorry, I had some changes in, the line is 8808 for 11955. Constantin Asofiei

11:27 AM Bug #5104: Cannot cast integer input parameter to dynamic function character parameter

Are you referring to line number 8746 of @3821c_11955@ version?
That version's line is:... Roger Borrello

05:16 PM Support #5111: TempTableSchema & BufferField

The @TempTableSchema.Column@ has a method @isChanged(BaseDataType)@. If you pass the current value of the field to th... Ovidiu Maxiniuc

04:47 PM Support #5111: TempTableSchema & BufferField

Ovidiu/Eric: Please advise. Greg Shah

04:47 PM Support #5111: TempTableSchema & BufferField

From Marian:
> This might be an easy one but damn if I can figure out what the connection is between those dmo tem... Greg Shah

12:17 PM Support #5111 (New): TempTableSchema & BufferField

Marian Edu

04:42 PM Feature #5113: implement c'tor overloading for cases where type erasure is an issue

Marian asks:
> How do you plan to handle the erasure issue with ctor's - normally a @JsonArray@ should have ctor w... Greg Shah

04:40 PM Feature #5113 (Rejected): implement c'tor overloading for cases where type erasure is an issue

Greg Shah

01:18 PM Bug #5035: Temp-Table index on P.L.O field

This would mean that these instances will need an 'always incrementing' ID, instead of our current random approach. ... Constantin Asofiei

10:53 AM Bug #5035: Temp-Table index on P.L.O field

It seems this is a deviation that is not just a "quirk". It is really an issue, especially when you consider the col... Greg Shah

06:02 AM Bug #5035: Temp-Table index on P.L.O field

Constantin Asofiei wrote:
> Marian Edu wrote:
> > I'm not saying this should be fixed, simply that with a random re... Marian Edu

01:17 PM Bug #5025 (Closed): syserror, jsonerror...

Greg Shah

01:06 PM Bug #5025: syserror, jsonerror...

I'm OK with closing it. Constantin Asofiei

10:44 AM Bug #5025: syserror, jsonerror...

Constantin: I will close this unless you think there is some remaining cleanup item or feature/optimization to pursue. Greg Shah

05:52 AM Bug #5025: syserror, jsonerror...

@SysError@ and all others extending it keeps the 4gl style ctor's and instances are created the usual. No 4GL code th... Marian Edu

12:56 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> But I think this is not implemented yet.
Yes, is not implemented yet.

> Constantin: Do we ne... Constantin Asofiei

12:54 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

> Just a word on access rights, those doesn't always have to match... while one can't make a method access more restr... Greg Shah

02:59 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> Started rework of fuzzy matching to implement missing features. This first pass refactors the fu... Marian Edu

07:58 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Started rework of fuzzy matching to implement missing features. This first pass refactors the fuzzyMethodLookup() pr... Greg Shah

01/26/2021

03:23 PM Bug #5104: Cannot cast integer input parameter to dynamic function character parameter

Greg wants me to triage the other high priority tasks related to the customer's application, so I won't get to this u... Roger Borrello

03:16 PM Bug #5104: Cannot cast integer input parameter to dynamic function character parameter

I see what you mean now. I read the last argument as 'l' and not value '1', for some reason.
You are correct - th... Constantin Asofiei

03:10 PM Bug #5104: Cannot cast integer input parameter to dynamic function character parameter

This testcase can duplicate the problem:... Roger Borrello

02:29 PM Bug #5104 (New): Cannot cast integer input parameter to dynamic function character parameter

Roger Borrello

01/20/2021

10:24 AM Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> Are you still blocked by bugs in our OO 4GL implementation? If not, should we merge 4384g into 3... Constantin Asofiei

02:56 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Marian, something is confusing - isn't a @IWebRequest@ instance for @HandleGet@ and such... Marian Edu

02:13 AM Feature #4384: Builtin OO Implementation

Marian, something is confusing - isn't a @IWebRequest@ instance for @HandleGet@ and such methods in @WebHandler@ auto... Constantin Asofiei

01:45 AM Feature #4384: Builtin OO Implementation

Constantin, the class must be annotated as as far as I know this is the only way to get access to the request inside ... Marian Edu

08:26 AM Bug #5029: OO constructor with array input parameter

Hmm, finding the right ctor is not the only problem, now the exception say "The extent parameter reference was not se... Marian Edu

08:15 AM Bug #5029: OO constructor with array input parameter

Constantin Asofiei wrote:
> Marian Edu wrote:
> > However the 4GL converted code seems to use an InputOutput parame... Marian Edu

01/19/2021

04:21 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Hmm... can you instantiate the legacy @RemoteRequest@ outside of the web handler environ... Marian Edu

03:40 AM Feature #4384: Builtin OO Implementation

Marian Edu wrote:
> Constantin, I have a question about WebRequest implementation in FWD. First that seems to be nam... Constantin Asofiei

01:56 AM Feature #4384: Builtin OO Implementation

Constantin, I have a question about WebRequest implementation in FWD. First that seems to be named RemoteWebRequest b... Marian Edu