FWD » Core Development » Base Language

01/06/2024

10:29 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

It seems like you code is a bit different than the trunk. But it still should work:
In @putConnected()@, there is ... Ovidiu Maxiniuc

01/05/2024

03:09 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

I did some debugging and I found that the lookup is happening inside @ConnectionManager.java@ at @Map<String, String>... Theodoros Theodorou

02:48 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Ovidiu Maxiniuc wrote:
> Please check whether the @hotel@ database is connected at the moment @USERID()@ function is... Theodoros Theodorou

12:56 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

I remember we have full support here. IIRC, there were some differences between Linux and Windows and whether the @_U... Ovidiu Maxiniuc

10:18 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Ovidiu: Do you recall the status of our @userid@ implementation? What should be happening here? Greg Shah

08:06 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Greg Shah wrote:
> > Ok. There is @/security/accounts/osusers/osuser@ and @webClient/defaultOsUser@ in @hotel_gui@. ... Theodoros Theodorou

08:56 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Import these in SoapUI and see if these work. There is also a @file-cvt-list.txt.rest_a... Galya B

08:03 AM Feature #6417: cleanup some known items in appserver support

> * versioninfo fields are read-only, but writing them is a runtime error and not compile error in FWD.
Solved in ... Galya B

04:14 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> * a QUIT on the remote side quits the client
Solved in r14910. @appsrv/test/test_raise_quit.p@... Galya B

01/03/2024

10:55 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> It won't help with #6417-5 that is to make clear the requirement (do we want a runtime or compile e... Constantin Asofiei

09:30 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Import these in SoapUI and see if these work. There is also a @file-cvt-list.txt.rest_a... Galya B

09:11 AM Feature #6417: cleanup some known items in appserver support

> * some errors throw by SERVER:CONNECT are not the same
Tests in @testcases/appsrv/test/connect_errors/@ are now ... Galya B

06:47 AM Feature #6417: cleanup some known items in appserver support

Galya, these are the steps to run the web tests from xfer testcases; some info is at [[p2j:Testcases#Running-Web-test... Constantin Asofiei

03:00 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Theodoros Theodorou wrote:
> > * @AuditDbOps@
> > ** is @meta_aud_audit_data@ hard-coded SQL name valid for all sup... Constantin Asofiei

01/02/2024

08:52 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

> Ok. There is @/security/accounts/osusers/osuser@ and @webClient/defaultOsUser@ in @hotel_gui@. Which one should I u... Greg Shah

08:28 AM Bug #8119 (Closed): JavaDoc build task produces more warnings in Windows in comparison to Linux

Greg Shah

08:23 AM Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux

New param @javadoc.verbose@ added to [[p2j:Building_FWD_From_Source#Build-Properties]]. Galya B

08:11 AM Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux

Please add this new property to "Build Properties":/projects/p2j:Building_FWD_From_Source#Build-Properties. Greg Shah

08:05 AM Bug #8119 (Test): JavaDoc build task produces more warnings in Windows in comparison to Linux

8119a was merged to trunk as rev. 14907 and archived. Galya B

07:56 AM Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux

You can merge now. Greg Shah

01/01/2024

05:55 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

> * @AuditDbOps@
> ** is @meta_aud_audit_data@ hard-coded SQL name valid for all supported dialects? *Eric:* here I ... Theodoros Theodorou

09:09 AM Feature #4392: add -pf support for appserver CONNECT() method

Constantin Asofiei wrote:
> Review of 4392a rev 14868:
> * ConnectHelper - is it possible to go into an infinite re... Galya B

04:09 AM Feature #4392: add -pf support for appserver CONNECT() method

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > * FileStream - *Ovidiu*: I understand the purpose of 'hasDup... Galya B

04:05 AM Feature #4392: add -pf support for appserver CONNECT() method

Constantin Asofiei wrote:
> * we need to fix the ConnectionManager part where it uses 'new File'
It sounds a relate... Galya B

03:00 AM Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux

Greg Shah wrote:
> Code Review Task Branch 8119a Revisions 14874 and 14875
>
> The changes are good.
>
> Pleas... Galya B

12/28/2023

05:59 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Constantin Asofiei wrote:
> Review of 6422a rev 14906 (the entire code):
> * @AuditControlManager@
> ** we don't/... Theodoros Theodorou

12/23/2023

02:34 PM Feature #6649: improve the performance or SourceNameMapper runtime

6649c was merged to trunk rev 14906 and archived. Constantin Asofiei

08:04 PM Feature #6649: improve the performance or SourceNameMapper runtime

Created task branch 6649c from trunk rev 14905
6649c rev 14906 fixes a race condition in SourceNameMapper propath ... Constantin Asofiei

10:40 PM Feature #4392: add -pf support for appserver CONNECT() method

Constantin Asofiei wrote:
> * FileStream - *Ovidiu*: I understand the purpose of 'hasDuplicatedLastLine' flag, but a... Ovidiu Maxiniuc

12/22/2023

12:52 PM Feature #6422 (WIP): implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Wow, I missed a lot.
Theodoros: Please address these concerns/notes. Greg Shah

12:47 PM Feature #6422 (Review): implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Review of 6422a rev 14906 (the entire code):
* @AuditControlManager@
** we don't/can't use @volatile@ for context-... Constantin Asofiei

12:47 PM Feature #6422 (Internal Test): implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Eric Faulhaber wrote:
> Some minor coding standards or format issues in @DirectoryServiceHelper@:
> * Lines 7-8 sho... Theodoros Theodorou

12:11 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Code Review Task Branch 6422a Revisions 14889 through 14906
I'm OK with the changes. Greg Shah

11:48 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Theodoros: Please rebase this to the latest trunk revision 14903.
Constantin: Please review after this is rebased. Greg Shah

11:29 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Code review 6422a/14902-14906 (after rebase):
The changes look good to me.
Some minor coding standards or forma... Eric Faulhaber

12:35 PM Bug #8119 (Merge Pending): JavaDoc build task produces more warnings in Windows in comparison to ...

Code Review Task Branch 8119a Revisions 14874 and 14875
The changes are good.
Please rebase and we will schedul... Greg Shah

12:16 PM Feature #4392: add -pf support for appserver CONNECT() method

Review of 4392a rev 14868:
* ConnectHelper - is it possible to go into an infinite recursion in 4GL, if -pf is used ... Constantin Asofiei

04:24 AM Feature #7045 (Test): re-implement "normal" (non-abend) stack unwinding to avoid throwing an exce...

Branch 7045b was merged into trunk revision 14899 and archived. Alexandru Lungu

12/21/2023

03:07 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

7045b is at the front of the queue now, go ahead and merge. Greg Shah

02:33 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

You can merge 7045b to trunk after 3303a. Greg Shah

02:27 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

7045b passed ETF testing. Constantin Asofiei

09:30 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Constantin, do you feel like it is better to get *everything* in trunk and then run ETF against all, instead of "micr... Alexandru Lungu

09:03 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Alexandru Lungu wrote:
> Constantin, ETF tests are the only ones that were not run. I rebased 7045b to latest trunk ... Constantin Asofiei

07:15 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Nice catches, Eduard! Please do a second iteration of the changes - I really want to make sure we don't missed someth... Alexandru Lungu

06:17 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Looked at 7045b after rebase, it looks fine.
Done some minor fixes at history entry.
In @forBlockWorker@, changed i... Eduard Soltan

02:43 PM Bug #8154: refactor scopeable stacks

Constantin Asofiei wrote:
> I need to digest this more; for scoped dictionaries, in my mind I have something like th... Eric Faulhaber

01:51 PM Bug #8154: refactor scopeable stacks

Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > [...]
> > Why I mention this: all this stack push/pop, my fe... Constantin Asofiei

01:19 PM Bug #8154: refactor scopeable stacks

Constantin Asofiei wrote:
> [...]
> Why I mention this: all this stack push/pop, my feeling is that is expensive; o... Eric Faulhaber

12:46 PM Bug #8154: refactor scopeable stacks

From #7026-296:
> Constantin Asofiei wrote:
> > On a side note: all scope support is managed in various stacks (o... Constantin Asofiei

12:45 PM Bug #8154 (WIP): refactor scopeable stacks

Constantin Asofiei

02:39 PM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications

Branch 7026f was merged into trunk revision 14897 and archived. Constantin Asofiei

10:34 AM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications

7026f rev 14903 fixes some regressions in WidgetPool support.
Constantin Asofiei

06:14 AM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications

7026f rev 14902 includes:
* Refactored the WidgetPool scopeable support to register for processing as needed.
* Obj... Constantin Asofiei

01:34 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Eric Faulhaber wrote:
> Code review 6422a/14649-14653:
> > * I think the bind/unbind is not needed because I think ... Theodoros Theodorou

12/20/2023

06:55 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Hold off on the merge. 8056a and 8127a need to go first. Greg Shah

11:44 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Just rebased 7045b to latest trunk, but the process was a bit slow due to the large number of changes to be introduce... Alexandru Lungu

11:38 AM Feature #7045 (Merge Pending): re-implement "normal" (non-abend) stack unwinding to avoid throwin...

Please merge to trunk after 8007a. Greg Shah

10:36 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Quick final look at 7045b/14838...
It looks like we still need a rebase to current trunk before merge. Also, some ... Eric Faulhaber

09:48 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Completely finished the testing of 7045b. Pending for merge. Alexandru Lungu

09:25 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Removed hard tabs from the previous commit. Committed on 7045b, revision 14838.
I do not think there is anything els... Eduard Soltan

04:26 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Code review 6422a/14649-14653:
*Please note again that I am not familiar with the legacy audit feature set, so I a... Eric Faulhaber

10:41 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Kind reminder for a review Theodoros Theodorou

01:21 PM Feature #8138: ABLUnit configuration using environment variables

I agree, we should add the ability to configure the bootstrap cfg file name (and only the bootstrap cfg file name) vi... Greg Shah

08:27 AM Feature #8138: ABLUnit configuration using environment variables

Vladimir Tsichevski wrote:
> Using Java properties for client configuration will allow to run with no configuration ... Marian Edu

06:53 AM Feature #8138: ABLUnit configuration using environment variables

Marian Edu wrote:
> Vladimir Tsichevski wrote:
> > IMO this will add another layer of complexity and mixed technolo... Vladimir Tsichevski

06:49 AM Feature #8138: ABLUnit configuration using environment variables

Vladimir Tsichevski wrote:
> IMO this will add another layer of complexity and mixed technology. Besides, using OS e... Marian Edu

06:02 AM Feature #8138: ABLUnit configuration using environment variables

IMO this will add another layer of complexity and mixed technology. Besides, using OS environment variables with Java... Vladimir Tsichevski

04:13 AM Feature #8138: ABLUnit configuration using environment variables

I'm extracting that from another unrelated issue just so it doesn't get lost.
Vladimir, we're running ABLUnit from... Marian Edu

04:08 AM Feature #8138 (Internal Test): ABLUnit configuration using environment variables

Marian Edu

12:18 PM Feature #6649: improve the performance or SourceNameMapper runtime

6649a has been dead-archived. Greg Shah

02:06 AM Feature #6649: improve the performance or SourceNameMapper runtime

Greg Shah wrote:
> Is 6649a a live branch?
It should not be, all the work I've done was in 6649b. Dănuț Filimon

05:30 AM Feature #8140: Client PID

Is there a way to get the 'client' process identifier in FWD? We use that for sikuli to identify the process window t... Marian Edu

05:24 AM Feature #8140 (New): Client PID

Marian Edu

05:12 AM Bug #8139: OS-COMMAND fails on windows if not in "batch mode"

For what it's worth forcing the @SwingGuiDriver@ to take into account the @background@ option does solve the issue an... Marian Edu

04:48 AM Bug #8139: OS-COMMAND fails on windows if not in "batch mode"

We're trying to start a 'ui simulator' based on sikuli using @OS-COMMAND@ and this is always failing if the client is... Marian Edu

04:16 AM Bug #8139 (New): OS-COMMAND fails on windows if not in "batch mode"

Marian Edu

12/19/2023

10:18 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

7045b passes a large set of regression tests from a customer application. I tested without the changes in rev. 14837.... Alexandru Lungu

10:13 AM Feature #6649: improve the performance or SourceNameMapper runtime

Is 6649a a live branch? Greg Shah

03:39 AM Feature #6649: improve the performance or SourceNameMapper runtime

Alexandru, I remember you also mentioned it in #6815. But at that time you asked Constantin for feedback on the idea.... Dănuț Filimon

03:32 AM Feature #6649: improve the performance or SourceNameMapper runtime

I agree with Eric. Fine tuning cache-sizes is a common pattern when deploying. I would also like a mechanism that can... Alexandru Lungu

09:38 AM Feature #6497: add equivalent support for the -T command line option

6497a was dead-archived. Greg Shah

12/18/2023

02:13 PM Feature #6649: improve the performance or SourceNameMapper runtime

Dănuț Filimon wrote:
> [[p2j:Database Configuration#Cache-Sizes]] was updated with the necessary information for con... Eric Faulhaber

10:44 AM Feature #8124: rework conversion and runtime support for BLOCK-LEVEL and ROUTINE-LEVEL statements

Some notes about this: ROUTINE/BLOCK-LEVEL affect the 'file' and not the 'instance'. So, for OO, each top-level call... Constantin Asofiei

06:29 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Eduard, please mind that there are still some hard-tabs in the last 2 commits. (@BlockManager@). Alexandru Lungu

12/15/2023

07:04 AM Feature #6417: cleanup some known items in appserver support

@WebSpeed@ used to be OE app in the browser (in some script) running on the WebSpeed agent. So the client knew it is ... Galya B

04:39 AM Feature #6417: cleanup some known items in appserver support

> * VersionInfo:clientType supports only 4GLCLIENT and APPSERVER at this time
Access to @clientType@ via:
* @SESS... Galya B

02:51 AM Feature #6649: improve the performance or SourceNameMapper runtime

[[p2j:Database Configuration#Cache-Sizes]] was updated with the necessary information for configuring the cache size ... Dănuț Filimon

12/14/2023

12:24 PM Feature #8124: rework conversion and runtime support for BLOCK-LEVEL and ROUTINE-LEVEL statements

Instead of emitting @onBlockLevel(Condition.ERROR, Action.THROW);@ or @onRoutineLevel(Condition.ERROR, Action.THROW);... Greg Shah

12:22 PM Feature #8124 (New): rework conversion and runtime support for BLOCK-LEVEL and ROUTINE-LEVEL stat...

Greg Shah

12:18 PM Bug #8084 (Test): refactor the 'execute' method for legacy classes

Greg Shah

11:56 AM Bug #8084: refactor the 'execute' method for legacy classes

Branch 8084a was merged to trunk rev 14876 and archived. Constantin Asofiei

11:38 AM Bug #8084: refactor the 'execute' method for legacy classes

If you've done enough, you can merge. Greg Shah

11:34 AM Bug #8084: refactor the 'execute' method for legacy classes

Greg Shah wrote:
> Yes, if you are complete with testing.
I haven't converted all apps, but I think the conversion ... Constantin Asofiei

09:47 AM Bug #8084 (Internal Test): refactor the 'execute' method for legacy classes

Yes, if you are complete with testing. Greg Shah

09:32 AM Bug #8084: refactor the 'execute' method for legacy classes

Greg Shah wrote:
> As an additional improvement, I wonder if we should change how @BLOCK-LEVEL@ and @ROUTINE-LEVEL@ ... Constantin Asofiei

07:10 PM Bug #8084: refactor the 'execute' method for legacy classes

Code Review Task Branch 8084a Revisions 14870 through 14873
The changes are good.
As an additional improvement,... Greg Shah

11:19 AM Feature #6649 (Test): improve the performance or SourceNameMapper runtime

Branch 6649b was merged to trunk rev 14874 and archived. Alexandru Lungu

11:08 AM Feature #6649: improve the performance or SourceNameMapper runtime

Yes, please merge now. Greg Shah

11:01 AM Feature #6649: improve the performance or SourceNameMapper runtime

As this was the last testing required for #6649, I am preparing to merge 6649b. Alexandru Lungu

10:58 AM Feature #6649: improve the performance or SourceNameMapper runtime

Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Constantin, if 6649b passes ETF, we can merge it to trunk. P... Constantin Asofiei

10:32 AM Feature #6649: improve the performance or SourceNameMapper runtime

Alexandru Lungu wrote:
> Constantin, if 6649b passes ETF, we can merge it to trunk. Please let me know when to proce... Constantin Asofiei

09:43 AM Feature #6649: improve the performance or SourceNameMapper runtime

Constantin, if 6649b passes ETF, we can merge it to trunk. Please let me know when to proceed. Alexandru Lungu

08:49 AM Feature #6649: improve the performance or SourceNameMapper runtime

Together with Alexandru we've managed to find a cause and solution for the trunk regression. I'm working on running ... Constantin Asofiei

05:37 AM Feature #6649: improve the performance or SourceNameMapper runtime

Great news! I've ran the regression tests and all tests passed successfully. Dănuț Filimon

10:30 AM Bug #8119 (Review): JavaDoc build task produces more warnings in Windows in comparison to Linux

Galya B

10:30 AM Bug #8119 (WIP): JavaDoc build task produces more warnings in Windows in comparison to Linux

8119a r14874,14875: Option added to javadoc task to show all warnings. Galya B

09:15 AM Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux

@ant@ automatically picks up any @-D@ options on the command line and turns them into properties that can be referenc... Greg Shah

09:08 AM Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux

Once upon a time I got a project with configured linter that wasn't used. I enabled a test plan in the CI/CD for each... Galya B

08:57 AM Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux

> So do we want to open the Pandora box?
No, but I do want to have a @-D@ option that we can use to enable it. Ma... Greg Shah

02:12 AM Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux

Here it is: The same output with @-Xdoclint:all@. So do we want to open the Pandora box?
Galya B

09:29 AM Bug #8116: SEARCH vs FILE-INFO

I like the idea. Greg Shah

07:13 AM Bug #8116: SEARCH vs FILE-INFO

Vladimir Tsichevski wrote:
> The only difference I can recall is that the client configuration cannot be set from co... Marian Edu

06:46 AM Bug #8116: SEARCH vs FILE-INFO

Eugenie Lyzenko wrote:
> From application point of view the @PROPATH/SEARACHPATH@ should be @,@ separated. But in a ... Marian Edu

12/13/2023

10:49 AM Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux

I don't know of a way to make OpenJDK show them. I'd be glad to see them (as long as it was optional) because to fin... Greg Shah

10:30 AM Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux

Yes, it's Oracle. This explains it.
But the Oracle ones are valid issues. Can we somehow make Open JDK show them, ... Galya B

10:15 AM Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux

Could you be building on Windows using the Oracle JDK? The Oracle JDK generates a ver long list of javadoc errors as... Greg Shah

09:19 AM Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux

@./gradlew ant-javadoc@ build task produces more warnings in Windows in comparison to Linux. Galya B

09:16 AM Bug #8119 (Closed): JavaDoc build task produces more warnings in Windows in comparison to Linux

Galya B

10:08 AM Feature #6649: improve the performance or SourceNameMapper runtime

Alexandru Lungu wrote:
> It is normal to have 18-21 tests failed on that regression tests.
>
> As of my understan... Greg Shah

09:52 AM Feature #6649: improve the performance or SourceNameMapper runtime

I ran the #7669-1 test and one of the users failed during the run 75 due to a @StaleRecordException@. I am running 71... Dănuț Filimon

09:06 AM Feature #6649: improve the performance or SourceNameMapper runtime

It is normal to have 18-21 tests failed on that regression tests.
As of my understanding: if ETF passes, only ChUI... Alexandru Lungu

09:01 AM Feature #6649: improve the performance or SourceNameMapper runtime

I finished testing a customer application with 7156b and 6649b and got between 18 (first run) and 21 (seconds run) te... Dănuț Filimon

08:02 AM Feature #6649: improve the performance or SourceNameMapper runtime

Rebased 6649b to latest trunk. It is now at rev. 14886.
Constantin, you can start the ETF tests. These tests are n... Alexandru Lungu

07:46 AM Feature #6649: improve the performance or SourceNameMapper runtime

Danut, I am planning to do rebase of 6649b to the latest trunk now. Alexandru Lungu

06:48 AM Feature #6649: improve the performance or SourceNameMapper runtime

Alexandru Lungu wrote:
> Danut, lets focus merging this by EOD. What testing is left?
Currently fixed the import.db... Dănuț Filimon

06:46 AM Feature #6649: improve the performance or SourceNameMapper runtime

Alexandru Lungu wrote:
> Danut, lets focus merging this by EOD. What testing is left?
Are all changes in 6649? I ca... Constantin Asofiei

06:45 AM Feature #6649: improve the performance or SourceNameMapper runtime

Danut, lets focus merging this by EOD. What testing is left? Alexandru Lungu

09:38 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Committed on 7045b, revision 14837.
This change requires reconversion. 4gl constructs like @for tt@, should be con... Eduard Soltan

08:27 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

I discussed with Eduard and it seems that the problem is that we have @forBlock(P2JQuery, int, String, Block)@, but w... Alexandru Lungu

09:03 AM Bug #8116: SEARCH vs FILE-INFO

Greg Shah wrote:
> Vladimir can also help here regarding the specifics of our ABLUnit support. It is slightly diffe... Vladimir Tsichevski

08:58 AM Bug #8116: SEARCH vs FILE-INFO

From application point of view the @PROPATH/SEARACHPATH@ should be @,@ separated. But in a real application the separ... Eugenie Lyzenko

08:53 AM Bug #8116: SEARCH vs FILE-INFO

Vladimir can also help here regarding the specifics of our ABLUnit support. It is slightly different because of the ... Greg Shah

08:51 AM Bug #8116: SEARCH vs FILE-INFO

I'll make a couple of quick points and then Eugenie will take it from there.
1. Your use case should be supported ... Greg Shah

08:53 AM Feature #4392: add -pf support for appserver CONNECT() method

4392a r14868 Ready for review. Fixing the remote @FileStream@ by adding a flag to determine if the file is supposed t... Galya B

06:11 AM Feature #4392: add -pf support for appserver CONNECT() method

A note: Even with @StreamFactory@ it's not always the client filesystem, but depends on the directory config @server-... Galya B

01:39 AM Feature #4392: add -pf support for appserver CONNECT() method

I'll add a flag to handle both cases. By default it will be the old logic, since we can't pinpoint where it's used. A... Galya B

08:26 PM Feature #4392: add -pf support for appserver CONNECT() method

Constantin Asofiei wrote:
> Ovidiu, please see previous note - do you recall why that was added?
I remember the mom... Ovidiu Maxiniuc

06:40 AM Bug #8084 (Review): refactor the 'execute' method for legacy classes

The changes for this and #8069 are in 8084a rev 14873. Please review. Constantin Asofiei

12/12/2023

02:31 PM Feature #6649: improve the performance or SourceNameMapper runtime

Alexandru Lungu wrote:
> Danut, is it possible to test 6649b without reconverting? This should theoretically run wit... Dănuț Filimon

11:18 AM Feature #6649: improve the performance or SourceNameMapper runtime

Danut, is it possible to test 6649b without reconverting? This should theoretically run with no problem and build up ... Alexandru Lungu

07:04 AM Feature #6649: improve the performance or SourceNameMapper runtime

The results of the POC test are in :)
|_. |_. Baseline (4 cold tests avg) |_. 7156b + 66... Dănuț Filimon

05:07 AM Feature #6649: improve the performance or SourceNameMapper runtime

I smoke tested a large customer application with 6649b and everything worked well. Currently running POC tests. Dănuț Filimon

04:44 AM Feature #6649: improve the performance or SourceNameMapper runtime

Dănuț Filimon wrote:
> I addressed the review from Hynek in *6649b.rev.14879*
Code review. The changes are good.
Hynek Cihlar

03:33 AM Feature #6649 (Internal Test): improve the performance or SourceNameMapper runtime

Dănuț Filimon

03:32 AM Feature #6649: improve the performance or SourceNameMapper runtime

I addressed the review from Hynek in *6649b.rev.14879* where I added a @removeIdentifier@ method and changed the logg... Dănuț Filimon

02:55 AM Feature #6649: improve the performance or SourceNameMapper runtime

Alexandru Lungu wrote:
> Constantin, can you run the ETF tests with 6649b once ready? Thank you.
Will do.
Constantin Asofiei

02:54 AM Feature #6649: improve the performance or SourceNameMapper runtime

Danut, please mark this as Urgent; we need to test it asap.
Thus, address the review from Hynek and lets move on w... Alexandru Lungu

11:07 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Eduard, there is an API issue we have on BlockManager. I think the rewriting of the BlockManager API to include the q... Alexandru Lungu

03:55 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Committed on 7045b, revision 14836.
- removed @handleQueryOffEnd@ method from QueryWrapper and all of its usage.
- ... Eduard Soltan

02:58 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Eduard, please address the latest suggestions and commit to 7045b.
Lets redo the whole testing process with this l... Alexandru Lungu

09:09 AM Feature #4392: add -pf support for appserver CONNECT() method

> By the way @-pf@ for DB connect uses @new File()@. Is it acceptable there?
No. That is not OK there either. Greg Shah

02:37 AM Feature #4392: add -pf support for appserver CONNECT() method

Constantin Asofiei wrote:
> Galya B wrote:
> > By the way @-pf@ for DB connect uses @new File()@. Is it acceptable ... Galya B

02:17 AM Feature #4392: add -pf support for appserver CONNECT() method

Galya B wrote:
> By the way @-pf@ for DB connect uses @new File()@. Is it acceptable there?
You mean the code in @C... Constantin Asofiei

01:48 AM Feature #4392: add -pf support for appserver CONNECT() method

Ovidiu, please see previous note - do you recall why that was added? Constantin Asofiei

01:44 AM Feature #4392: add -pf support for appserver CONNECT() method

I've found the issue with the remote stream:
@FileStream@:... Galya B

12:47 AM Feature #4392: add -pf support for appserver CONNECT() method

Greg Shah wrote:
> Code Review Task Branch 4392a Revisions 14865 and 14866
>
> I did a quick review. The primary... Galya B

12:45 AM Feature #4392: add -pf support for appserver CONNECT() method

Greg Shah wrote:
> Code Review Task Branch 4392a Revisions 14865 and 14866
>
> I did a quick review. The primary... Galya B

08:16 AM Bug #8116: SEARCH vs FILE-INFO

Although there is this slight difference in FWD implementation my issue seems to come from invalid @PROPATH@ settings... Marian Edu

04:19 AM Bug #8116: SEARCH vs FILE-INFO

When using @SEARCH@ using relative path in 4GL the file is looked-up in all @PROPATH@ entries and if found the full-p... Marian Edu

04:19 AM Bug #8116 (New): SEARCH vs FILE-INFO

Marian Edu

12/11/2023

03:56 PM Feature #4392: add -pf support for appserver CONNECT() method

Some other notes, beside what Greg mentioned:
# does @-pf@ overwrite only the preceding options (the one which appea... Constantin Asofiei

03:10 PM Feature #4392: add -pf support for appserver CONNECT() method

Constantin: Please review. Greg Shah

03:10 PM Feature #4392: add -pf support for appserver CONNECT() method

Code Review Task Branch 4392a Revisions 14865 and 14866
I did a quick review. The primary issue I see is that the... Greg Shah

10:12 AM Feature #4392: add -pf support for appserver CONNECT() method

...and r14866 for the file header. Galya B

10:07 AM Feature #4392 (Review): add -pf support for appserver CONNECT() method

4392a r14865 ready for review.
Fixes the connect param "-pf" for servers. The code wasn't completed and was throwi... Galya B

01:19 PM Feature #6649: improve the performance or SourceNameMapper runtime

Code review 6649b revision 14878.
@MonitorRunnable.identifiers@ are never cleared. Shouldn't an entry be removed, ... Hynek Cihlar

03:15 AM Feature #6417: cleanup some known items in appserver support

> * versioninfo fields are read-only, but writing them is a runtime error and not compile error in FWD.
This one see... Galya B

12/08/2023

08:38 AM Feature #6649: improve the performance or SourceNameMapper runtime

Rebased 6649b to latest trunk. 6649b is now at rev. 14878. Alexandru Lungu

05:54 AM Feature #6649: improve the performance or SourceNameMapper runtime

*Committed 6649b/rev.14849* where I made the following changes:
- Created @MonitorRunnable@ which allows identifying... Dănuț Filimon

06:40 AM Feature #6417: cleanup some known items in appserver support

> * argument translation to remote definition type I think is done the same as the CALL statement does it...
What do... Galya B

12/07/2023

08:53 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Alexandru Lungu wrote:
> Regarding your last comment: it depends upon the delegate right? If the delegate is not len... Eduard Soltan

08:40 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Eduard, I started converting a really large application with 7045b (on top of 7156b). You have 3 days left to do the ... Alexandru Lungu

08:34 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

I think is not needed, as @QueryWrapper@ is used in conversion of @open query@ statement. And in this case QQE is not... Eduard Soltan

08:04 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Alexandru, I haven't looked at the full code, but is the @QueryWrapper.handleQueryOffEnd@ still needed? Constantin Asofiei

07:08 AM Feature #6417 (WIP): cleanup some known items in appserver support

Galya B