Activity
From 03/09/2024 to 04/07/2024
04/04/2024
- 05:26 PM Bug #8579 (Test): Unit and OEUnit conversion: ignore annotations from other framework
- 05:21 PM Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework
- Greg Shah wrote:
> You can merge 8579a to trunk now.
Done. Rev. 15123. - 04:23 PM Bug #8579 (Merge Pending): Unit and OEUnit conversion: ignore annotations from other framework
- You can merge 8579a to trunk now.
- 01:14 PM Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework
- Greg Shah wrote:
> Code Review Task Branch 8579a Revision 15121
>
> The change is good.
>
> What additional te... - 12:58 PM Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework
- Code Review Task Branch 8579a Revision 15121
The change is good.
What additional testing is needed? - 11:20 AM Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework
- Greg Shah wrote:
> Code Review Task Branch 8579a Revision 15120
>
> I think the code would be simpler and easier ... - 12:12 PM Feature #6407: name_map.xml improvements
- I did replace the @Set@ with @List@ in r15108.
Tomorrow I'm testing again in testcases. A good list of different p... - 11:45 AM Feature #6407: name_map.xml improvements
- @MultiClassLoader@:...
- 11:43 AM Feature #6407: name_map.xml improvements
- So what I'm saying is that there is no classpath order in my humble opinion. Iterating HashMap is not ordered.
- 11:39 AM Feature #6407: name_map.xml improvements
- Greg Shah wrote:
> > > @MultiClassLoader@ finds the class by iterating @HashSet@.
> > Actually it's a collection, ... - 11:32 AM Feature #6407: name_map.xml improvements
- > > @MultiClassLoader@ finds the class by iterating @HashSet@.
> Actually it's a collection, backed by the @HashMap... - 11:20 AM Feature #6407 (Review): name_map.xml improvements
- 6407a r15107 based on trunk r15101 ready for review: adds support for reading mappings from multiple name_map.xml fil...
- 09:57 AM Feature #6407: name_map.xml improvements
- Galya B wrote:
> @MultiClassLoader@ finds the class by iterating @HashSet@.
Actually it's a collection, backed by ... - 09:42 AM Feature #6407: name_map.xml improvements
- We can rework it to iterate jars alphabetically.
- 09:39 AM Feature #6407: name_map.xml improvements
- Constantin Asofiei wrote:
> My understanding is that JVM keeps the same order of jars as defined in classpath (it do... - 09:37 AM Feature #6407: name_map.xml improvements
- Galya B wrote:
> Greg Shah wrote:
> > Do we really need an explicit list of precedence order? Why not implicitly t... - 09:29 AM Feature #6407: name_map.xml improvements
- Greg Shah wrote:
> Do we really need an explicit list of precedence order? Why not implicitly take it from the clas... - 09:28 AM Feature #6407: name_map.xml improvements
- Do we really need an explicit list of precedence order? Why not implicitly take it from the classpath and honor the ...
- 09:21 AM Feature #6407: name_map.xml improvements
- Constantin Asofiei wrote:
> From what you posted in #6407-56, only one concern: the granularity for the precedence o... - 05:45 AM Feature #6407: name_map.xml improvements
- From what you posted in #6407-56, only one concern: the granularity for the precedence order I think needs to be "thi...
- 04:39 AM Feature #6407: name_map.xml improvements
- P.S. The previous comment got updated.
- 04:36 AM Feature #6407: name_map.xml improvements
- Constantin Asofiei wrote:
> And I think I understand now Greg's point about the .r and folder deploy in OpenEdge:
>...
04/03/2024
- 06:05 PM Bug #8579 (Internal Test): Unit and OEUnit conversion: ignore annotations from other framework
- Code Review Task Branch 8579a Revision 15120
I think the code would be simpler and easier to read if you create a ... - 03:11 PM Bug #8579 (Review): Unit and OEUnit conversion: ignore annotations from other framework
- Fixed in 8579a rev. 15120. Please, review.
- 03:10 PM Bug #8579 (WIP): Unit and OEUnit conversion: ignore annotations from other framework
- 02:51 PM Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework
- Currently, if a test 4gl source includes both ABLUnit annotations and OEUnit annotations, all these annotations are c...
- 02:46 PM Bug #8579 (Test): Unit and OEUnit conversion: ignore annotations from other framework
- 03:08 PM Feature #6407: name_map.xml improvements
- And I think I understand now Greg's point about the .r and folder deploy in OpenEdge:
* in FWD, you would convert th... - 02:34 PM Feature #6407: name_map.xml improvements
- Greg Shah wrote:
> > But, in practice, I think .pl archives are used more - and depending on the PROPATH, runtime co... - 02:29 PM Feature #6407: name_map.xml improvements
- > But, in practice, I think .pl archives are used more - and depending on the PROPATH, runtime could use a .p from di...
- 02:26 PM Feature #6407: name_map.xml improvements
- We had cases of the same OE qualified class name used in different modules. The qualified legacy name can't be chang...
- 01:28 PM Feature #6407: name_map.xml improvements
- To solve case 2. we need the precedence order to be fed to the jmv via startup args, so that the classloader can take...
- 01:09 PM Feature #6407: name_map.xml improvements
- Galya B wrote:
> I speak about case 3: different maps for different files with different attributes. Obviously if yo... - 01:08 PM Feature #6407: name_map.xml improvements
- I speak about case 3: different maps for different files with different attributes, but same path. Obviously if you l...
- 01:02 PM Feature #6407: name_map.xml improvements
- > This is not something we can decide even with configs and Constantin was right that it is a major issue.
Case 1 ... - 12:58 PM Feature #6407: name_map.xml improvements
- One pname corresponds to only one jname, because that's how conversion seems to work. The question is if the other at...
- 11:36 AM Feature #6407: name_map.xml improvements
- Galya B wrote:
> Other than that the jar can have a completely different package for the actual classes.
Actually n... - 11:34 AM Feature #6407: name_map.xml improvements
- If we need to load the jars in a specific order, we'll need explicit instructions, probably new config in directory.
- 11:32 AM Feature #6407: name_map.xml improvements
- Case 2 is the same as java and can cause malfunctioning programs like in java, this is what I meant.
Case 1 is fine ... - 11:20 AM Feature #6407: name_map.xml improvements
- > In java this is the same as having multiple versions of the same dependency in the classpath.
Not exactly. In... - 11:14 AM Feature #6407: name_map.xml improvements
- > If you are saying that module M1 has a program foo/bar/F.p and module M2 has a program foo/bar/F.p. which are compl...
- 11:12 AM Feature #6407: name_map.xml improvements
- This is actually more complicated than it looked at first. We're trying to combine different apps coming possibly fro...
- 11:03 AM Feature #6407: name_map.xml improvements
- Greg Shah wrote:
> Let's consider this from the perspective of how it works for this multi-app case in OE. If both ... - 10:55 AM Feature #6407: name_map.xml improvements
- Originally (currently) if multiple paths are found for the same filename when resolving the name map, the paths end u...
- 10:45 AM Feature #6407: name_map.xml improvements
- > The 'pname' in @class-mapping@ is the full path relative to the @abl/@ folder
Yes, this is why I called them rel... - 10:30 AM Feature #6407: name_map.xml improvements
- Greg Shah wrote:
> > > And all of this just for a warning log? I would say it's more reasonable to log the warning a... - 10:26 AM Feature #6407: name_map.xml improvements
- I don't have an actual example though. Not sure if the path is supposed to be the same in two different jars.
- 10:25 AM Feature #6407: name_map.xml improvements
- Greg Shah wrote:
> > > And all of this just for a warning log? I would say it's more reasonable to log the warning a... - 10:23 AM Feature #6407: name_map.xml improvements
- > > And all of this just for a warning log? I would say it's more reasonable to log the warning always when a second ...
- 06:16 AM Feature #6407: name_map.xml improvements
- > REST services written directly in Java can be configured via the 'rest-service' element.
So these nodes are not ... - 06:06 AM Feature #6407: name_map.xml improvements
- OK, then I need one more clarification. Since there is a separate container @rest-service@, where programs get resolv...
- 06:00 AM Feature #6407: name_map.xml improvements
- Yes.
- 05:57 AM Feature #6407: name_map.xml improvements
- Constantin Asofiei wrote:
> Galya B wrote:
> > And all of this just for a warning log? I would say it's more reason... - 05:57 AM Feature #6407: name_map.xml improvements
- Galya B wrote:
> And all of this just for a warning log? I would say it's more reasonable to log the warning always ... - 05:53 AM Feature #6407: name_map.xml improvements
- Constantin Asofiei wrote:
> Galya B wrote:
> > Constantin, maybe you've missed why I'm assigned to the task, that i... - 05:49 AM Feature #6407: name_map.xml improvements
- Galya B wrote:
> Constantin, maybe you've missed why I'm assigned to the task, that is in #6407-4.
OK, thanks for t... - 05:49 AM Feature #6407: name_map.xml improvements
- Constantin Asofiei wrote:
> The point was to move to annotations/other structures inside the .java
Constantin, ... - 05:43 AM Feature #6407: name_map.xml improvements
- The point was to move to annotations/other structures inside the .java, here I mean all info from name_map.xml; ideal...
- 05:33 AM Feature #6407: name_map.xml improvements
- Constantin Asofiei wrote:
> I don't mean the annotations in the .class - I mean the state from name_map.xml must mat... - 05:22 AM Feature #6407: name_map.xml improvements
- I don't mean the annotations in the .class - I mean the state from name_map.xml must match if there is an existing en...
- 03:55 AM Feature #6407: name_map.xml improvements
- Constantin Asofiei wrote:
> * load them into @SourceNameMapper@, one by one, and address conflicts - if there are co... - 05:26 AM Bug #8510: replace all 'new logical' in FWD runtime with logical.of or logical.UNKNOWN
- 8150a was merged to trunk rev 15116 and archived.
- 05:26 AM Bug #8510: replace all 'new logical' in FWD runtime with logical.of or logical.UNKNOWN
- Created task branch 8510a from trunk rev 15115. In rev 15116 I removed the @logical.of@ and @logical.UNKNOWN@ from R...
04/01/2024
- 06:41 PM Bug #8154: refactor scopeable stacks
- Code Review Task Branch 8154a Revision 15109
The changes look promising. There is clearly quite a bit more that c... - 12:51 PM Bug #8154 (WIP): refactor scopeable stacks
- Created task branch 8154a from trunk rev 15108.
Rev 15109 contains first pass at moving scoped stacks into (TopLev... - 04:00 AM Feature #6424: fill gaps in Java Open Client replacement (appserver client support)
- Galya, I've placed the project under @devsrv01:/tmp/open_client_example.zip@. There is a small readme.txt in the pro...
03/29/2024
- 10:57 AM Feature #6407: name_map.xml improvements
- Galya B wrote:
> @SourceNameMapper.initMappingData@ seems to be executed only once for the lifespan of the runtime m... - 10:20 AM Feature #6407 (WIP): name_map.xml improvements
- 6407a created from trunk r15101.
- 10:03 AM Feature #6407: name_map.xml improvements
- @SourceNameMapper.initMappingData@ seems to be executed only once for the lifespan of the runtime machine with a serv...
- 09:46 AM Feature #6407: name_map.xml improvements
- Constantin Asofiei wrote:
> Also, SourceNameMapper will not load the .class and annotations when the entry in @name_... - 09:45 AM Feature #6407: name_map.xml improvements
- Constantin Asofiei wrote:
> Java has tools to read an archive.
If you mean the custom FWD's @JarClassLoader@, then ... - 09:38 AM Feature #6407: name_map.xml improvements
- You don't need to unzip the jar - Java has tools to read an archive. This just means we can't rely on @Class.getReso...
- 09:37 AM Feature #6407: name_map.xml improvements
- Why can't we use the same technique from @Utils.searchResourceJars()@? We don't need the propath part but we definit...
- 09:29 AM Feature #6407: name_map.xml improvements
- That is of course if the check for the file listed by @jar tvf filename.jar@ gives positive.
- 09:27 AM Feature #6407: name_map.xml improvements
- Constantin Asofiei wrote:
> Galya, what package would you use for looking into multiple jars? Look everywhere? The ... - 08:41 AM Feature #6407: name_map.xml improvements
- Galya, what package would you use for looking into multiple jars? Look everywhere? The problem with @name_map.xml@ i...
- 08:31 AM Feature #6407: name_map.xml improvements
- > @MultiClassLoader@ has a list of all jars in the classpath. It can look for @name_map.xml@ in each jar (with @jar t...
- 07:08 AM Feature #6407: name_map.xml improvements
- @MultiClassLoader@ has a list of all jars in the classpath. It can look for @name_map.xml@ in each jar (with @jar tvf...
- 06:16 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
- I know some work has happened to explore I18N testcases. Having proper testcases will be very important.
I want t...
03/28/2024
- 05:09 PM Feature #6407: name_map.xml improvements
- > We had this discussion before - moving *everything* to annotations will mean the entire converted .class code needs...
- 03:58 PM Feature #6407: name_map.xml improvements
- Greg Shah wrote:
> > another improvement would be to emit some kind of special constructs for the virtual functions/... - 03:50 PM Feature #6407: name_map.xml improvements
- > another improvement would be to emit some kind of special constructs for the virtual functions/internal procedures ...
- 09:49 AM Feature #6417 (WIP): cleanup some known items in appserver support
- 09:44 AM Feature #6417: cleanup some known items in appserver support
- Test in OE for client type:
Procedure running in batch client:...
03/27/2024
- 07:46 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- How can I access @TxWrapper$TransactionHelper.maybeActivateTxWrapper@? I currently have the following code (branch 64...
- 05:07 PM Feature #6410: implement additional built-in OO classes/interfaces
- > It's probably useless to implement that as I don't expect those to be extended in the first place but the possibili...
- 05:06 PM Feature #6410: implement additional built-in OO classes/interfaces
- Some notes from Marian:
> We had constantly issues with conversion when classes extended/implemented built-in cla...
03/26/2024
- 04:09 AM Feature #6410: implement additional built-in OO classes/interfaces
- @Constantin, are there any changes in trunk pertaining conversion especially for classes extending/implementing skele...
03/25/2024
- 09:05 AM Feature #6417: cleanup some known items in appserver support
- > I'm not sure if my reasoning is correct, but it looks like the same appserver agent can execute all types of appser...
- 06:40 AM Feature #6417: cleanup some known items in appserver support
- Actually there several places where appserver tasks are executed in a different way. I've found these:
* @Agent.Agen... - 06:32 AM Feature #6417: cleanup some known items in appserver support
- I'm not sure if my reasoning is correct, but it looks like the same appserver agent can execute all types of appserve...
- 08:37 AM Feature #6826: reduce the BDT usage in FWD runtime
- There are many cases where a BDT is used as a short-lived constant value. The most of case are @logical@ and @interge...
03/24/2024
- 05:17 AM Bug #8510 (New): replace all 'new logical' in FWD runtime with logical.of or logical.UNKNOWN
03/22/2024
- 09:37 AM Feature #6424: fill gaps in Java Open Client replacement (appserver client support)
- This will need a guide - how to use gradle cache to run and debug a Java client project.
- 09:24 AM Feature #6424: fill gaps in Java Open Client replacement (appserver client support)
- Nevermind, it was on devsrv01: @scp devsrv01:/tmp/gradle-skylab.zip .@ .
- 09:22 AM Feature #6424: fill gaps in Java Open Client replacement (appserver client support)
- Constantin, where is the project on the shared drives? I remember you gave me a path, I can't find now.
03/21/2024
- 04:26 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Branch 7045f was created from trunk rev 15077 - in rev 15078 re-fixed the regression in 7045d/e. Merged to trunk rev...
03/20/2024
- 01:00 PM Feature #7045 (Test): re-implement "normal" (non-abend) stack unwinding to avoid throwing an exce...
- Branch 7045e was merged into trunk as rev. 15077 and archived.
- 12:45 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- If you are confident it is safe, it can be merged now.
- 12:44 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Greg, can this be merged? It affects a customer's app.
- 07:34 AM Feature #7045 (Internal Test): re-implement "normal" (non-abend) stack unwinding to avoid throwin...
- Code Review Task Branch 7045e Revision 15074
I'm OK with the change. - 02:54 AM Feature #7045 (Review): re-implement "normal" (non-abend) stack unwinding to avoid throwing an ex...
- Created task branch 7045e from trunk rev 15073. In rev 15074 fixes "RETURN statements from within a CASE statement a...
03/19/2024
- 11:04 AM Feature #7045 (Test): re-implement "normal" (non-abend) stack unwinding to avoid throwing an exce...
Branch 7045d was merged into trunk as rev. 15068 and archived.- 11:02 AM Feature #7045 (Merge Pending): re-implement "normal" (non-abend) stack unwinding to avoid throwin...
- Merging this now.
03/18/2024
- 09:08 AM Feature #6417 (Review): cleanup some known items in appserver support
- > * versioninfo fields are read-only, but writing them is a runtime error and not compile error in FWD.
* @session/l...
03/14/2024
- 03:41 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Sounds good.
- 03:03 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Greg Shah wrote:
> Code Review Task Branch 7045d Revision 15042
>
> In @return_stmts.rules@, the @type == prog.pr... - 02:58 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Code Review Task Branch 7045d Revision 15042
In @return_stmts.rules@, the @type == prog.procedure ... - 02:46 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Greg, please review 7045d - I'd like to get this into trunk, it doesn't hurt.
- 03:17 PM Feature #7122: convert default getter/setter as plain Java methods
- In 8363d, a property getter with only a 'return <literal>.' body will convert to a Java return which will wrap the li...
03/13/2024
- 05:08 AM Bug #8427 (Closed): LOG-MANAER:CLOSE-LOG does not reset the enabled state
- 8237a was merged to trunk revision 15044 and archived.
03/12/2024
- 05:41 PM Feature #6407: name_map.xml improvements
- We need to implement something soon due to some customer deadlines. I don't think we have time to implement the full...
03/11/2024
- 03:46 AM Bug #8427 (Merge Pending): LOG-MANAER:CLOSE-LOG does not reset the enabled state
- This is fixed in 8237a rev 15043.
- 03:31 AM Bug #8427: LOG-MANAER:CLOSE-LOG does not reset the enabled state
- You're right, put it after that.
- 03:28 AM Bug #8427: LOG-MANAER:CLOSE-LOG does not reset the enabled state
- I think @isEnabled.set(false);@ needs to be after @if (isAppserver && isProcedureCall)@, correct? I'll use 8237a.
- 03:21 AM Bug #8427: LOG-MANAER:CLOSE-LOG does not reset the enabled state
- I've tested it and it works fine with the change.
- 03:21 AM Bug #8427: LOG-MANAER:CLOSE-LOG does not reset the enabled state
- I've missed that @close@ modifies @logFile@ and @isEnabled@ should be updated. Can you add this new line @isEnabled.s...
03/10/2024
- 01:41 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Constantin Asofiei wrote:
> Alexandru, is 7045c still needed after we refactored the query management to be inside B... - 07:29 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Alexandru, is 7045c still needed after we refactored the query management to be inside BlockManager? If not, please a...
Also available in: Atom