FWD » Core Development » Base Language

11/28/2024

08:39 AM Support #9398: Incomplete SESSION:DATE-FORMAT implementation in FWD and setting session date form...

In FWD, the command line options that can be specified in OE are handled using our @com.goldencode.p2j.main.StartupPa... Greg Shah

08:12 AM Support #9398: Incomplete SESSION:DATE-FORMAT implementation in FWD and setting session date form...

Progress allows to set the @SESSION:DATE-FORMAT@ from command-line using the @Date Format@ (@-d@) option.
Does FWD... Vladimir Tsichevski

08:09 AM Support #9398 (Test): Incomplete SESSION:DATE-FORMAT implementation in FWD and setting session da...

Vladimir Tsichevski

07:08 AM Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

*Committed 9396a/15583*. This commit fixes all of my testcases related to #9396-2 table (except the 3rd bullet point)... Dănuț Filimon

06:42 AM Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

The third bullet point is a regression added in trunk/15456, @recordOrShowError@ throws a @DeferredLegacyErrorExcepti... Dănuț Filimon

06:10 AM Bug #9396 (WIP): Improve Incompatible data types in expression or assignment. (223) error handling

From #9377-8:
I've created unit tests for testing the behavior of *temp-tables* fields and literals:
|_. Field ty... Dănuț Filimon

06:04 AM Bug #9396 (WIP): Improve Incompatible data types in expression or assignment. (223) error handling

Dănuț Filimon

04:38 AM Bug #8643 (Test): ErrorManager not handling caught errors and error-status:error attribute properly

Eduard Soltan

04:38 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Branch 8643a was merged into trunk 15582 and archived. Eduard Soltan

11/27/2024

01:18 PM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Greg Shah wrote:
> > Does this mean we shall make FWD runtime honor the version returned by @EnvironmentOps@?
>
>... Vladimir Tsichevski

12:37 PM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

> Does this mean we shall make FWD runtime honor the version returned by @EnvironmentOps@?
Yes, exactly this. Luc... Greg Shah

12:35 PM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Greg Shah wrote:
> I know it isn't nice to write, but in the 4GL code we can use @PROVERSION@ and have conditional m... Vladimir Tsichevski

12:32 PM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Greg Shah wrote:
> I know it isn't nice to write, but in the 4GL code we can use @PROVERSION@ and have conditional m... Vladimir Tsichevski

10:59 AM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

I know it isn't nice to write, but in the 4GL code we can use @PROVERSION@ and have conditional matching code. On th... Greg Shah

08:55 AM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Greg Shah wrote:
> Marian's team currently writes everything for 12.2 since that is what they have. That doesn't me... Marian Edu

08:46 AM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Marian's team currently writes everything for 12.2 since that is what they have. That doesn't meant that that is the... Greg Shah

08:29 AM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Greg Shah wrote:
> We MUST support both. Please add runtime version checking using the @EnvironmentOps@ "Progress" ... Vladimir Tsichevski

08:22 AM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

We MUST support both. Please add runtime version checking using the @EnvironmentOps@ "Progress" version helpers. Greg Shah

07:42 AM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Some implication found:
The @INDEX/R-INDEX@ tests now existing in the testcases assume the error message is:
<p... Vladimir Tsichevski

05:53 AM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Alexandru Lungu wrote:
> When updating I get:
> [...]
>
> The revisions you are mentioning look newer; maybe you... Vladimir Tsichevski

02:58 AM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

When updating I get:... Alexandru Lungu

11:31 AM Bug #8643 (Merge Pending): ErrorManager not handling caught errors and error-status:error attribu...

You can merge after 9342a. Greg Shah

09:46 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Greg, can I merge 8643a? Eduard Soltan

07:50 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Run CHUI regression tests, and they are passing. Eduard Soltan

11/26/2024

02:28 PM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Greg Shah wrote:
> > > * there are many places where @final@ was added to the method parameters. This remembered me ... Vladimir Tsichevski

02:23 PM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

> > * there are many places where @final@ was added to the method parameters. This remembered me of the "Overuse-of-f... Greg Shah

11:23 AM Bug #8309 (Review): Do the error handling for r-index and extend implementation to INDEX and LONG...

Alexandru Lungu wrote:
> Review of 8309a/rev. 15573:
>
> * I am OK with the functionality of the changes and the ... Vladimir Tsichevski

08:53 AM Bug #8309 (WIP): Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Alexandru Lungu

08:00 AM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Review of 8309a/rev. 15573:
* I am OK with the functionality of the changes and the overall refactoring!
* minor ... Alexandru Lungu

09:15 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

I have run again *one by one* the fwd tests that failed only with @8643a@ and they passed. Andrei Plugaru

07:51 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Andrei Plugaru wrote:
> *The testing I have done yesterday was probably flawed.*
>
> The problem was that I didn'... Andrei Plugaru

06:23 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Constatin wrote:
> Did you restore the database before running the tests?
yes, a couple of times.
Andrei Plu... Eduard Soltan

06:09 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

*The testing I have done yesterday was probably flawed.*
The problem was that I didn't reimport the DB before runn... Andrei Plugaru

05:56 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

ETF testing passed Constantin Asofiei

04:11 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Eduard Soltan wrote:
> But the baseline result for fwd tests that I obtained it is a bit worse that the result Andre... Constantin Asofiei

11/25/2024

02:13 PM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Andrei Plugaru wrote:
> I have run the fwdtests and, unfortunately, *it seems there are 5 regressions*. I would want... Eduard Soltan

01:53 PM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Andrei Plugaru wrote:
> I have run the fwdtests and, unfortunately, *it seems there are 5 regressions*. I would want... Eric Faulhaber

10:28 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

I have run the fwdtests and, unfortunately, *it seems there are 5 regressions*. I would want, however, to make anothe... Andrei Plugaru

08:48 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Andrei Plugaru wrote:
> Constantin Asofiei wrote:
> > Andrei: did you run both fwdtests and unittests?
>
> No, I... Constantin Asofiei

08:30 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Constantin Asofiei wrote:
> Andrei: did you run both fwdtests and unittests?
No, I have only run the exact test t... Andrei Plugaru

08:29 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

I run unitest for a large application.
Also run unittest of a large GUI app, and harness of a big rest app. Eduard Soltan

08:28 AM Bug #8643 (Internal Test): ErrorManager not handling caught errors and error-status:error attribu...

Review is OK. I can run ETF - what other testing is needed?
Andrei: did you run both fwdtests and unittests? Constantin Asofiei

03:27 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

*Eduard*, I retested #9353 with @8643a rev. 15530@ and the exception is still handled right. ✅ Andrei Plugaru

03:24 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Constantin Asofiei wrote:
> Eduard, so there are no changes required for the branch?
No, there should be a change... Eduard Soltan

03:21 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Eduard, so there are no changes required for the branch? Constantin Asofiei

02:59 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

I run the example from #9298-38 using command line, and got the same result as if running from OE.
Got the excepti... Eduard Soltan

10:04 AM Bug #6389: LENGTH function with COLUMN option

My understanding from that time is the 'column' length is to align the text for i.e. printing. So this can not depen... Constantin Asofiei

10:02 AM Bug #6389: LENGTH function with COLUMN option

Maybe there is one more thing we can try, I was thinking that the @column@ length is determined by the width of the c... Artur Școlnic

11/22/2024

10:22 AM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Please coordinate with Marian to check these into the [[p2j:Testcases]] project. Greg Shah

06:17 AM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Attached are unit tests for testing case-sensitivity. Vladimir Tsichevski

04:10 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Actully I think that the problematic line in this code from #8643-38.... Eduard Soltan

11/21/2024

03:10 PM Bug #8309 (Review): Do the error handling for r-index and extend implementation to INDEX and LONG...

Issue fixed in rev. 15573. Review, please. Vladimir Tsichevski

01:31 PM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Vladimir Tsichevski wrote:
> Another issue discovered: the @R-INDEX@ implementation does not support @CHARACTER@ cas... Vladimir Tsichevski

07:28 AM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Another issue discovered: the @R-INDEX@ implementation does not support @CHARACTER@ case sensitivity, the comparison ... Vladimir Tsichevski

10:13 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Constantin Asofiei wrote:
> But a question: does this test still work in FWD with 8643a?
Well, not really. I cha... Eduard Soltan

03:41 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

The changes make sense, we've seen weird behavior for db-related errors in other places.
But a question: does this... Constantin Asofiei

11/20/2024

05:37 PM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Branch 8309a rev. 15571 now handles invalid index argument for @R-INDEX@ correctly.
ABLUnit tests attached for the @... Vladimir Tsichevski

12:14 PM Bug #8309 (WIP): Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

I've created the 8309a branch for this. Vladimir Tsichevski

09:55 AM Bug #6389: LENGTH function with COLUMN option

I am sorry, I forgot to add the 'destination' parameter for @chr@ function. I updated the procedures above. It turn o... Ovidiu Maxiniuc

09:19 AM Bug #6389: LENGTH function with COLUMN option

Constantin Asofiei wrote:
> But: are we sure characters in a certain string are not 'merged' into i.e. 3 columns eve... Artur Școlnic

09:10 AM Bug #6389: LENGTH function with COLUMN option

I extended the extractor to:... Ovidiu Maxiniuc

09:07 AM Bug #6389: LENGTH function with COLUMN option

We can keep this data in a file (or an array) directly, no need to complicate things with intervals.
But: are we s... Constantin Asofiei

09:02 AM Bug #6389: LENGTH function with COLUMN option

Correct me if I am wrong, but the main problem with an approach like this is the fact that we can't rely on intervals... Artur Școlnic

08:49 AM Bug #6389: LENGTH function with COLUMN option

To extract the column lengths for all 64Ki Unicode characters we can use the following procedure (do not forget to st... Ovidiu Maxiniuc

07:59 AM Bug #6389: LENGTH function with COLUMN option

Artur Școlnic wrote:
> Ovidiu, won't manually scanning the Unicode planes for any type of characters limit the funct... Ovidiu Maxiniuc

07:08 AM Bug #6389: LENGTH function with COLUMN option

Yes, the results are from OE. In FWD the @length@ function does not work with any of the parameters if multi byte cha... Artur Școlnic

07:03 AM Bug #6389: LENGTH function with COLUMN option

Are these results from OE? Greg Shah

06:12 AM Bug #6389: LENGTH function with COLUMN option

I was operating under the assumption that @chr(, "utf-8")@ encodes a character using utf-8 and 4gl will calculate the... Artur Școlnic

11/19/2024

12:51 PM Bug #6389: LENGTH function with COLUMN option

Eugenie Lyzenko wrote:
> However the main question here I think is to detect what is the output of the @LENGTH@ in 4... Ovidiu Maxiniuc

12:44 PM Bug #6389: LENGTH function with COLUMN option

+Review of 6389a/15563+
The solution seems close, but there are some issues we need to discuss:
* your sample in ... Ovidiu Maxiniuc

12:07 PM Bug #6389: LENGTH function with COLUMN option

The approach used in @15563@ should work for 16-bit Java characters. If 4GL @LENGTH@ function always return number of... Eugenie Lyzenko

08:04 AM Bug #6389: LENGTH function with COLUMN option

Ovidiu and Eugenie: Please review. Greg Shah

07:19 AM Bug #6389 (Review): LENGTH function with COLUMN option

The length of wide chars seems to be @2@ regardless of the mode the program is ran in (gui, chui, batch), of the outp... Artur Școlnic

09:15 AM Bug #9037 (Review): Two timers problem: only one fires

Branch 8393b on rev. 15573 fixes the problem. I (re)tested it with the @8393.p@ and the big customer application.
I ... Vladimir Tsichevski

09:01 AM Bug #9354: Invalid handle (3135) error is thrown insted of the 10068 error.

This issue is derived from #9271-11. Artur Școlnic

09:00 AM Bug #9354: Invalid handle (3135) error is thrown insted of the 10068 error.

start.p... Artur Școlnic

08:54 AM Bug #9354 (WIP): Invalid handle (3135) error is thrown insted of the 10068 error.

Artur Școlnic

11/18/2024

09:38 AM Bug #6389: LENGTH function with COLUMN option

I am using tests like the one in #6389-21. Artur Școlnic

09:36 AM Bug #6389: LENGTH function with COLUMN option

Did you test in both ChUI, GUI and batch process? Constantin Asofiei

09:19 AM Bug #6389: LENGTH function with COLUMN option

Should I commit the fix for the "Column" parameter, or fix the other ones too? Artur Școlnic

08:50 AM Bug #6389: LENGTH function with COLUMN option

I have a fix for the @COLUMN@ parameter, but it looks like the same method could be used for all the parameters. Artur Școlnic

08:49 AM Bug #6389: LENGTH function with COLUMN option

... Artur Școlnic

07:41 AM Bug #6389: LENGTH function with COLUMN option

I was not aware we already have it :), thank you. Artur Școlnic

07:32 AM Bug #6389: LENGTH function with COLUMN option

The same class exists in FWD as @p2j/build/lib/jline-2.14.6.jar:jline.console.WCWidth@. I'm confused why you need th... Constantin Asofiei

07:29 AM Bug #6389: LENGTH function with COLUMN option

Constantin Asofiei wrote:
> Artur, you mean this project? https://github.com/jline/jline3
No, it it a class in the ... Artur Școlnic

07:23 AM Bug #6389: LENGTH function with COLUMN option

Artur, you mean this project? https://github.com/jline/jline3
Greg: please comment about BSD. Constantin Asofiei

07:21 AM Bug #6389: LENGTH function with COLUMN option

I wrote an implementation for the @columnLength@ method, but it relies on the @jdk.internal.org.jline.utils.WCWidth@ ... Artur Școlnic

05:57 AM Bug #6389 (WIP): LENGTH function with COLUMN option

Artur Școlnic

08:11 AM Bug #9350: gap marking for LOG-MANAGER attributes and methods is probably wrong

We have analytics tooling that allows us to evaluate the level of support for each 4GL language feature. This is rep... Greg Shah

08:10 AM Bug #9350: gap marking for LOG-MANAGER attributes and methods is probably wrong

Greg Shah wrote:
> See [[p2j:Gap Analysis]].
Where is the gap marking for @LOG-MANAGER@? Galya B

08:06 AM Bug #9350: gap marking for LOG-MANAGER attributes and methods is probably wrong

How is this task different from #3853? Galya B

08:06 AM Bug #9350: gap marking for LOG-MANAGER attributes and methods is probably wrong

See [[p2j:Gap Analysis]]. Greg Shah

08:05 AM Bug #9350: gap marking for LOG-MANAGER attributes and methods is probably wrong

These are some items in reports for an application being evaluated.
* attributes
** @LOGGING-LEVEL@ (conversion f... Greg Shah

08:02 AM Bug #9350: gap marking for LOG-MANAGER attributes and methods is probably wrong

What is the concern? I tested what I implemented, when I implemented it. Galya B

07:55 AM Bug #9350 (Internal Test): gap marking for LOG-MANAGER attributes and methods is probably wrong

Greg Shah

11/08/2024

08:26 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Note to self, review/explore the following things:
* How Java 17 affects lambda/method handle usage.
* Investigat... Greg Shah

11/01/2024

08:33 AM Bug #8944: FINALLY block transaction processing

Constantin Asofiei wrote:
> So, are all cases being 'faulty' or just the @popScope@ one?
I have seen issues only ... Artur Școlnic

08:19 AM Bug #8944: FINALLY block transaction processing

We have FINALLY being processed in FWD, in:
* @iterateWorker@ when the block is iterating
* @processRetry@ in case ... Constantin Asofiei

10/31/2024

03:15 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Constantin, please review. Dănuț Filimon

10/30/2024

10:35 AM Bug #8643 (Review): ErrorManager not handling caught errors and error-status:error attribute prop...

Rebased 8643a, to latest trunk. And fixed some history entries in revision 15528.
Committed on 8643a, revision 155... Eduard Soltan

10:33 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Looking a bit more closely at the example from #8643-30, and the implementation of @BlockManager.processLegacyError@.... Eduard Soltan

07:34 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Tested unittests with the changes from 8643a. It indeed solves a lot of tests in @service@ and some other modules. Bu... Eduard Soltan