Project

General

Profile

Activity

From 02/19/2013 to 03/20/2013

03/20/2013

06:05 PM Feature #1668: add support for additional (non-dynamic) database attributes
Code review 20130320a:
All looks good except QueryWrapper: the new @numBuffers@ method implementation should dele...
Eric Faulhaber
05:38 PM Feature #1668: add support for additional (non-dynamic) database attributes
Update vmn_upd20130320a.zip (vmn_upd20130320b.zip - conversion test) contains correction of NUM-BUFFERS()(KW_NUM_BUFF... Vadim Nebogatov
02:07 PM Feature #1668: add support for additional (non-dynamic) database attributes
Costin Savin wrote:
> Tested this case, The result is a runtime error message: @"Third argument to ADD-INDEX-FIELD m...
Eric Faulhaber
02:05 PM Feature #1668: add support for additional (non-dynamic) database attributes
> Write a test case and see what happens if you pass in something other than "asc" or "desc" as the last parameter. D... Costin Savin
01:07 PM Feature #1668: add support for additional (non-dynamic) database attributes
Costin Savin wrote:
> there are only these methods defined in the TempTable interface:
> public logical addFieldTo...
Eric Faulhaber
12:37 PM Feature #1668: add support for additional (non-dynamic) database attributes
For:... Costin Savin
02:38 PM Feature #2092: add server-side database support for several builtin functions
Update cs_upd20130320a1.zip has passed conversion regression testing and is committed to bzr rev. 10301. Eric Faulhaber
01:29 PM Feature #2092: add server-side database support for several builtin functions
Code review 20130320a:
This one is mostly correct, except for the following:
* @Functions.minimum(Date var1, Date...
Eric Faulhaber
11:55 AM Feature #2092: add server-side database support for several builtin functions
Added proposed update, for the testcase it seems you can't define a field as rowid in 4gl so I modified that part.
W...
Costin Savin
05:35 AM Feature #2092: add server-side database support for several builtin functions
Costin: the test you've uploaded doesn't work with the repository p2j_test.df schema definition. When modifying the p... Constantin Asofiei

03/19/2013

04:29 PM Feature #2092: add server-side database support for several builtin functions
Code review 20130319a:
* common-progress.rules: changes look good, but see comment below about max/min.
* where-...
Eric Faulhaber
02:29 PM Feature #2092: add server-side database support for several builtin functions
Re-arranged the code , solved the reviewed problems and merged with latest updates.
Testcase used to check convers...
Costin Savin
01:29 AM Feature #2092: add server-side database support for several builtin functions
Costin Savin wrote:
> Added merged update.
> Are there any other functions that need to be added? I saw DATETIME an...
Eric Faulhaber
01:11 PM Feature #1668: add support for additional (non-dynamic) database attributes
Constantin Asofiei wrote:
> For this, I think we should add a @P2JQuery.tableCount@ API which returns @integer@ and ...
Eric Faulhaber
07:30 AM Feature #1668: add support for additional (non-dynamic) database attributes
Eric,
> * num-buffers [KW_NUM_BUFF] (seems buggy) (I think this should map to P2JQuery.getTableCount, which already ...
Constantin Asofiei
07:57 AM Bug #2093: VALEXP support in P2J
The AST is slightly different with last revision from bzr:... Ovidiu Maxiniuc
07:20 AM Bug #2093: VALEXP support in P2J
Please check the failed case in the previous note with the latest #1620 fix, if you haven't done already so. Constantin Asofiei
07:09 AM Bug #2093: VALEXP support in P2J
Everything seems to work smooth, validation is only generated in @schema-validation@:... Ovidiu Maxiniuc
04:03 AM Bug #2093: VALEXP support in P2J
Ovidiu: with the #1620 changes, I can't see any more schema VALEXP problems in the logs (I think P2J was too aggressi... Constantin Asofiei

03/18/2013

03:39 PM Feature #2080: add runtime support for database methods
Update vmn_upd20130318a.zip (vmn_upd20130318b.zip - tests) contains runtime support for BUFFER-COMPARE and some prepa... Vadim Nebogatov
11:36 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
This issue stems from note 127 in #2068.
The following code:...
Eric Faulhaber
11:16 AM Bug #2097 (Closed): FOR EACH with multiple, nested CAN-FINDs converts badly
Eric Faulhaber
08:23 AM Feature #2092: add server-side database support for several builtin functions
Added merged update.
Are there any other functions that need to be added? I saw DATETIME and DATETIME-TZ which fit t...
Costin Savin
06:34 AM Feature #2092: add server-side database support for several builtin functions
After some tests it seems that min and max can be applied also to character and date variables, not only numeric valu... Costin Savin
04:31 AM Feature #2092 (Review): add server-side database support for several builtin functions
Costin Savin
04:31 AM Feature #2092 (WIP): add server-side database support for several builtin functions
Costin Savin
12:12 AM Bug #2059 (Closed): CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a...
Eric Faulhaber

03/17/2013

03:42 PM Bug #2077 (Closed): fix converted table and field name collisions
Eric Faulhaber
03:32 PM Bug #2084 (Review): Conversion misplaced parameter for can-find statement
Eric Faulhaber
03:31 PM Bug #2084: Conversion misplaced parameter for can-find statement
The net effect of the cs_upd20130314a.zip update is that the correct Java output is produced, but the change still le... Eric Faulhaber

03/16/2013

10:24 AM Feature #2092: add server-side database support for several builtin functions
Added proposed update,
For ROWID I didn't knew how a ROWID data type it's represented in the database so I assumed ...
Costin Savin

03/15/2013

05:13 PM Feature #2080: add runtime support for database methods
Constantin's advice has gotten you past the immediate handle problem, but please re-read note 9. The runtime impleme... Eric Faulhaber
05:11 PM Feature #2080: add runtime support for database methods
Yes, it works, thank you Vadim Nebogatov
04:53 PM Feature #2080: add runtime support for database methods
Vadim, I don't think the runtime for the CREATE BUFFER statement is implemented. Try this instead:... Constantin Asofiei
04:41 PM Feature #2080: add runtime support for database methods
It seems, ... Vadim Nebogatov
12:09 PM Feature #2080: add runtime support for database methods
update [vmn_upd20130314a.zip]
Refs #2080, checked in as bzr revision 10291.
Corrected runtime for BUFFER-COPY (KW_B...
Vadim Nebogatov
11:52 AM Feature #2080: add runtime support for database methods
> Constantin: can you just pick up common-progress.rules from bzr and merge your quoter changes in?
OK, I'll wait f...
Constantin Asofiei
11:49 AM Feature #2080: add runtime support for database methods
Vadim: the 20130314a update looks good. Please go ahead and commit it to bzr.
Constantin: can you just pick up ...
Eric Faulhaber
11:39 AM Feature #2080: add runtime support for database methods
Constantin Asofiei wrote:
> Vadim, have you done the changes at notes #29? If yes, please upload just the common-pro...
Vadim Nebogatov
11:37 AM Feature #2080: add runtime support for database methods
Vadim, have you done the changes at notes #29? If yes, please upload just the common-progress.rules file. If not, I c... Constantin Asofiei
11:08 AM Feature #2080: add runtime support for database methods
Yes, the pairs parameter is in use. Eric Faulhaber
11:00 AM Feature #2080: add runtime support for database methods
What about pairs in RecordBuffer.compare()? Should it be supported? Vadim Nebogatov
10:39 AM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> I am implementing now RecordBuffer.compare(Buffer buffer, character mode, character except,...
Eric Faulhaber
08:46 AM Feature #2080: add runtime support for database methods
I am implementing now RecordBuffer.compare(Buffer buffer, character mode, character except, character pairs) similar... Vadim Nebogatov
01:27 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
BTW, since multi-table queries also implement P2JQuery indirectly, they should throw UnsupportedOperationException fo... Eric Faulhaber
01:20 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
The runtime API will look like:... Eric Faulhaber
12:41 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
The use cases we must support:... Eric Faulhaber
12:16 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
Paraphrased from #2068:
Looks like P2J doesn't like the FIELDS clause, because with it, the fields get emitted as ...
Eric Faulhaber
12:12 PM Bug #2095 (Closed): FIELDS/EXCEPT record phrase options not honored
Eric Faulhaber
12:30 PM Bug #2084: Conversion misplaced parameter for can-find statement
Eric: I've put this through conversion regression testing (which has passed) plus server folder conversion, and I don... Constantin Asofiei
12:11 PM Bug #2094 (Closed): OUTER-JOIN record phrase option not honored
Eric Faulhaber
12:06 PM Bug #2093: VALEXP support in P2J
This issue is dedicated to note 80 from Issue #2068.
> There is this validation expression for the @dvofrsts.dvofr...
Ovidiu Maxiniuc
11:57 AM Bug #2093 (Closed): VALEXP support in P2J
Ovidiu Maxiniuc
02:06 AM Feature #2092: add server-side database support for several builtin functions
The following builtin functions are used within where clauses in queries and thus need to be supported as database se... Eric Faulhaber
01:14 AM Feature #2092 (Closed): add server-side database support for several builtin functions
Eric Faulhaber

03/14/2013

05:44 PM Feature #2080: add runtime support for database methods
What methods are priority for now? Vadim Nebogatov
05:43 PM Feature #2080: add runtime support for database methods
Attached update vmn_upd20130314a.zip (vmn_upd20130314b.zip - tests).
This update is replacement vmn_upd20130312a.z...
Vadim Nebogatov
03:12 PM Feature #2080: add runtime support for database methods
for note 22:
> Constantin: you didn't already do this, right?
No, I have not changed the @Buffer.findXXXX@ APIs
for ...
Constantin Asofiei
03:46 PM Bug #2084: Conversion misplaced parameter for can-find statement
Went back and searched for another solution, since the last one started from the wrong premise that can-find BUFFER_S... Costin Savin
03:35 PM Bug #2084: Conversion misplaced parameter for can-find statement
Costin, please provide a detailed update of what you have found/done on this today. Eric Faulhaber

03/13/2013

06:06 PM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Will be ast processing with rules also required with wrapping String to character?
Const...
Eric Faulhaber
04:49 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> With your next update, please replace the predicate data type of @String@ in all the @Buff...
Vadim Nebogatov
03:23 PM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > One question: why not just implement @AbstractQuery.queryReposi...
Eric Faulhaber
03:18 PM Feature #2080: add runtime support for database methods
Low priority: related to my last note, we are using the wrong data type for the NO-LOBS parameter in our bufferCopy/... Eric Faulhaber
03:16 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> One question: why not just implement @AbstractQuery.queryReposition(NumberType n)@ as
> [....
Vadim Nebogatov
02:07 PM Feature #2080: add runtime support for database methods
The current project never uses the NO-LOBS parameter of BUFFER-COPY and BUFFER-COMPARE, so the variants of @BufferImp... Eric Faulhaber
01:46 PM Feature #2080: add runtime support for database methods
Code review 20130312a:
Update looks fine.
Good catch on the @queryReposition@ method. One question: why not j...
Eric Faulhaber
11:10 AM Feature #2080: add runtime support for database methods
I suspect that much of the use we will see of this feature will involve expressions resolving to character values (si... Eric Faulhaber
05:40 AM Feature #2080: add runtime support for database methods
The FIND-FIRST/LAST/UNIQUE methods can receive a character for the first parameter. Currently, the Buffer.find* imple... Constantin Asofiei
03:13 PM Bug #2084: Conversion misplaced parameter for can-find statement
Tried to replicate the test which failed on update cs_upd20130312a.zip (-where- before I moved the logic from post-ru... Costin Savin
11:09 AM Bug #2084: Conversion misplaced parameter for can-find statement
The testcase from note 11 passed, there was another file from conversion regression tests that failed (with the remap... Costin Savin
10:53 AM Bug #2084: Conversion misplaced parameter for can-find statement
I haven't looked at this issue in detail nor tried to reproduce the problem yet, but the last update you sent looks w... Eric Faulhaber
08:11 AM Bug #2084: Conversion misplaced parameter for can-find statement
There seems to be a problem with some buffers being used in different db schemas,
after the change it seems the buff...
Costin Savin
05:25 AM Bug #2084: Conversion misplaced parameter for can-find statement
There are changes in two files with this update, I think they are expected, but Costin is checking them now. Constantin Asofiei
02:14 AM Bug #2090 (Closed): correct sorting of DMO properties during schema conversion
Eric Faulhaber

03/12/2013

05:20 PM Feature #2080: add runtime support for database methods
Current status of methods from ref 1947
Implemented:
GET-CURRENT (KW_GET_CUR)
FIND-LAST (KW_FIND_LST)
FIND-FIRST ...
Vadim Nebogatov
05:19 PM Feature #2080: add runtime support for database methods
Attached update vmn_upd20130312a.zip.
Corrected runtime for BUFFER-COPY (KW_BUF_COPY) and BUFFER-COMPARE (KW_BUF_CO...
Vadim Nebogatov
04:40 PM Feature #2080: add runtime support for database methods
Yes, I handed my changes off to Constantin a few days ago, based on an older version, to integrate with some other ch... Eric Faulhaber
04:26 PM Feature #2080: add runtime support for database methods
Eric, I corrected BufferImpl.bufferCompare according #12, but noticed that you replaced function body with ... Unsupp... Vadim Nebogatov
06:22 AM Feature #2080: add runtime support for database methods
Tests
uast/find-with-locks.p
uast/get-with-locks.p
committed revision 991.
Vadim Nebogatov
05:01 AM Feature #2080: add runtime support for database methods
vmn_upd20130311c.zip checked in as bzr revision 10278. Vadim Nebogatov
08:58 PM Feature #2080: add runtime support for database methods
Update vmn_upd20130311c.zip has passed conversion regression testing. Please commit it to bzr and distribute. Note ... Eric Faulhaber
03:37 PM Bug #2083: client-side where-clause leak in FindQuery
This fix looks good to me. I have merged it with the latest bzr revision, re-run conversion regression testing with ... Eric Faulhaber
01:36 PM Bug #2083: client-side where-clause leak in FindQuery
I see you found another solution.
I also found one simple and straightforward solution by refining the condition f...
Ovidiu Maxiniuc
12:19 PM Bug #2083: client-side where-clause leak in FindQuery
Ovidiu, I was having many similar issues with client-side query substitution parameters and CAN-FIND while fixing #20... Eric Faulhaber
02:33 PM Bug #2084: Conversion misplaced parameter for can-find statement
Added proposed update
It seems the problem is in some situation the remap scope is deleted before we get into the <p...
Costin Savin
11:28 AM Bug #2084: Conversion misplaced parameter for can-find statement
It seems there are still some weird cases where it fails. Working on reproducing and fixing it Costin Savin
04:54 AM Bug #2084: Conversion misplaced parameter for can-find statement
I'm sorry about that, it seems I forgot to save after doing the clean-up, and created the archive with some unwanted ... Costin Savin
09:54 PM Bug #2084: Conversion misplaced parameter for can-find statement
Code review 20130311a:
* Do you have a test case that illustrates the problem described by Constantin in notes 5 a...
Eric Faulhaber
01:17 PM Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
Update has passed conversion regression testing and is committed to bzr rev. 10280. Eric Faulhaber
12:14 PM Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
Fix candidate is attached. I am conversion regression testing this now. Eric Faulhaber
10:15 PM Feature #2000: add conversion support for table and table handle parameters
Code looks good, AFAICT, but without test cases and being able to look at the ASTs, the changes were hard to follow, ... Eric Faulhaber

03/11/2013

06:30 PM Feature #2080: add runtime support for database methods
Code review 20130311c:
The merge looks fine. The implementation of @BufferImpl.bufferCompare@ doesn't look right. ...
Eric Faulhaber
05:00 PM Feature #2080: add runtime support for database methods
Attached update
vmn_upd20130311c.zip
vmn_upd20130311d.zip (corresponding test cases)
is next replacement of vm...
Vadim Nebogatov
04:26 PM Feature #2080: add runtime support for database methods
P2JQuery,
** 040 CA 20130311 Added bufferHandle(integer).
It seems wrong number
Vadim Nebogatov
03:08 PM Feature #2080: add runtime support for database methods
Code review 20130311a:
The changes all look good.
I noticed on this second review that even the no-arg versions...
Eric Faulhaber
10:01 AM Feature #2080: add runtime support for database methods
Attached update
vmn_upd20130311a.zip
vmn_upd20130311b.zip (corresponding test cases)
is replacement of vmn_upd2013...
Vadim Nebogatov
06:20 PM Feature #2000: add conversion support for table and table handle parameters
Regression conversion completed without errors. Stanislav Lomany
03:42 PM Feature #2000: add conversion support for table and table handle parameters
> Is this merged up to the latest bzr revision?
Yes, it is merged.
Stanislav Lomany
02:59 PM Feature #2000: add conversion support for table and table handle parameters
Is this merged up to the latest bzr revision?
If so, please do run conversion regression testing. Eric will do a ...
Greg Shah
02:32 PM Feature #2000: add conversion support for table and table handle parameters
Update for TABLE-HANDLE FOR case. Should I regression-test it? Stanislav Lomany
03:32 PM Bug #2083: client-side where-clause leak in FindQuery
The @<action>sibref.setHidden(true)</action>@ from @where_clause_post.rules@ at line 438 from my previous update seem... Ovidiu Maxiniuc
11:24 AM Bug #2083: client-side where-clause leak in FindQuery
After some more tests, it seems like this update does not fix the issue, in fact it is too restrictive, it will cut m... Ovidiu Maxiniuc
06:07 AM Bug #2083: client-side where-clause leak in FindQuery
With help from Constantin, the missing @setHidden@ is now in place. Ovidiu Maxiniuc
01:46 PM Bug #2084: Conversion misplaced parameter for can-find statement
Added proposed update which checks if the javaname is marked for remap but not as a generated increment name. Costin Savin
11:05 AM Feature #1947: add conversion support for database methods
Added missing API bufferHandle(integer). Committed to bzr revision -10276- 10277. Constantin Asofiei

03/10/2013

03:29 PM Feature #1668: add support for additional (non-dynamic) database attributes
Update ecf_upd20130308a.zip has passed conversion regression testing and is committed as bzr rev. 10274. Eric Faulhaber

03/09/2013

09:11 AM Bug #2083: client-side where-clause leak in FindQuery
I couldn't get my mind of client_taint and I took a quick look where is used. In where_clause_post.rules, at line 413... Constantin Asofiei

03/08/2013

04:40 PM Feature #1668: add support for additional (non-dynamic) database attributes
Fix candidate attached. I'll push this through conversion regression testing.
Vadim: please take note of this up...
Eric Faulhaber
03:56 PM Feature #1668: add support for additional (non-dynamic) database attributes
Eric, we've hit this on another occasion (? literal). For now, just handle both cases. The parser changes related to ... Constantin Asofiei
03:43 PM Feature #1668: add support for additional (non-dynamic) database attributes
Interesting...outside of the message statement, the NO_LOCK_LITERAL is the child of an intermediate EXPRESSION node, ... Eric Faulhaber
03:24 PM Feature #1668: add support for additional (non-dynamic) database attributes
The update doesn't handle this case:... Constantin Asofiei
01:59 PM Bug #2084: Conversion misplaced parameter for can-find statement
Sorry, I should have been more explicit. The failures are caused by the fact that, when you have a table named @prodc... Constantin Asofiei
01:53 PM Bug #2084: Conversion misplaced parameter for can-find statement
Constantin Asofiei wrote:
> Conversion regression testing has failed, as the tests above have passed because the jav...
Eric Faulhaber
06:53 AM Bug #2084: Conversion misplaced parameter for can-find statement
Conversion regression testing has failed, as the tests above have passed because the javaname in these cases is the s... Constantin Asofiei
04:51 AM Bug #2084: Conversion misplaced parameter for can-find statement
The changes looks good, also solves other compile errors where wrong buf name was used, in cases like:... Constantin Asofiei
04:01 AM Bug #2084: Conversion misplaced parameter for can-find statement
Added proposed update,
In previous comment I didn't understood exactly the process so I assumed there's an addition...
Costin Savin
12:20 PM Feature #2000: add conversion support for table and table handle parameters
About the state of work: I changed the parser so TABLE-HANDLE FOR is recognized as a variable reference rather than a... Stanislav Lomany
12:19 PM Bug #2083: client-side where-clause leak in FindQuery
At this moment, I use the following simplified testcase:... Ovidiu Maxiniuc
12:09 PM Bug #2083: client-side where-clause leak in FindQuery
I'm getting closer. Here what I found:
The extra node (@f1 [FUNC_LOGICAL]@) should be made hidden so it will not b...
Ovidiu Maxiniuc
09:09 AM Bug #2083: client-side where-clause leak in FindQuery
In my previous note there the and operator from where clause contains a reference to a buffer other than the one that... Ovidiu Maxiniuc
10:35 AM Feature #2086 (Closed): add support for the VALIDATE clause, for the temp-table's fiels defined u...
Greg Shah
10:34 AM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
Committed to bzr 10266. Constantin Asofiei
09:58 AM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
OK, this change looks fine. Commit and distribute it. Greg Shah
09:48 AM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
The update has passed conversion regression testing. There is one additional change in MAJIC, from a @DEFINE TEMP-TAB... Constantin Asofiei
08:37 AM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
Sorry, when you say "VALIDATE clause", I thought you are referring to the option for a TEMP-TABLE (not for a specific... Greg Shah
07:27 AM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
New version of the update, which solves the VALIDATE when used with @DEFINE TEMP-TABLE tt1 LIKE source VALIDATE@. Als... Constantin Asofiei
03:09 AM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
This fix removes the extent annotation from the source field reference in the VALEXP. What is still needed to do:
# ...
Constantin Asofiei
01:41 AM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
Greg, the VALIDATE clause is used in the server project with a field definition. See file pmcon/cjcotdo0.w. There are... Constantin Asofiei

03/07/2013

06:12 PM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
VALIDATE is NOT used in the server project (in a TEMP-TABLE or WORK-TABLE definition). Only NO-UNDO and RCODE-INFORM... Greg Shah
05:41 PM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
MAJIC has finished conversion and there are changes, expected: validation clauses are dropped for temp-table fields d... Constantin Asofiei
04:55 PM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
The server project exposed a problem with the temp-table fields defined using the LIKE clause, when the target field ... Constantin Asofiei
04:43 PM Feature #2086 (Closed): add support for the VALIDATE clause, for the temp-table's fiels defined u...
Constantin Asofiei
03:12 PM Feature #2080: add runtime support for database methods
Code review 20130307a:
* There is no implementation for @QueryWrapper.getNext(LockType)@. The other @getXXX(LockT...
Eric Faulhaber
11:10 AM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Does P2J have common module responsible for 4GL errors processing? (I found actually ErrorM...
Eric Faulhaber
11:01 AM Feature #2080: add runtime support for database methods
Attached update vmn_upd20130307a.zip. Added runtime support for queryClose, queryForward, queryReposition, queryRepos... Vadim Nebogatov
05:11 AM Feature #2080: add runtime support for database methods
Does P2J have common module responsible for 4GL errors processing? (I found actually ErrorManager.recordOrThrowError(... Vadim Nebogatov
02:10 PM Bug #2084: Conversion misplaced parameter for can-find statement
The problem seems to be happening in the annotation phase in the following way:
The BUFFER_SCOPE with a bufname" va...
Costin Savin
07:46 AM Bug #2084: Conversion misplaced parameter for can-find statement
Example:... Costin Savin
07:44 AM Bug #2084 (Closed): Conversion misplaced parameter for can-find statement
Costin Savin
09:57 AM Bug #2083: client-side where-clause leak in FindQuery
I did some patch (removing the extra expression from where node after generating the anonymous inner class needed by ... Ovidiu Maxiniuc
05:33 AM Bug #2083: client-side where-clause leak in FindQuery
Another can-find leak:... Constantin Asofiei
08:48 AM Feature #2000: add conversion support for table and table handle parameters
> When will the solution be ready for review?
Hopefully will finish it today.
Stanislav Lomany
08:46 AM Feature #2000: add conversion support for table and table handle parameters
When will the solution be ready for review? Greg Shah
04:44 AM Feature #2000: add conversion support for table and table handle parameters
About @DEF PARAMETER TABLE-HANDLE FOR th@ where @th@ is a regular variable:
1. OUTPUT case will produce compile-ti...
Stanislav Lomany

03/06/2013

05:13 PM Feature #2080: add runtime support for database methods
Please implement all the methods you can, which do not require dynamic database support. For example, FIND-FIRST wit... Eric Faulhaber
02:02 PM Bug #2083: client-side where-clause leak in FindQuery
Ovidiu Maxiniuc wrote:
> The parameter is in fact an echo of the content of the client-side WhereExpression: @f1(cus...
Eric Faulhaber
01:59 PM Bug #2083: client-side where-clause leak in FindQuery
Here are the converted code for two cases (which attempt to call two new constructors), with and without another join... Ovidiu Maxiniuc
01:50 PM Bug #2083: client-side where-clause leak in FindQuery
I tried to simplify the sample. Suppose we have a simple function:... Ovidiu Maxiniuc
01:25 PM Bug #2083 (Closed): client-side where-clause leak in FindQuery
Ovidiu Maxiniuc
01:37 PM Feature #1947 (Closed): add conversion support for database methods
Vadim committed this update to bzr as revision number 10256. Eric Faulhaber
11:21 AM Feature #1947: add conversion support for database methods
I made a minor change to the database_general.rules header. Please check in and distribute the attached version of y... Eric Faulhaber
10:58 AM Feature #1947: add conversion support for database methods
I have attached one more variant of the same update, but merged manually Vadim Nebogatov
10:29 AM Feature #1947: add conversion support for database methods
Code review 20130306a:
Other than the literal.rules merge issue noted above (which I do think was my mistake), eve...
Eric Faulhaber
09:35 AM Feature #1947: add conversion support for database methods
I will merge everything manually and resubmit Vadim Nebogatov
09:25 AM Feature #1947: add conversion support for database methods
As I see, update from Eric was not merged with revision you pointed. Maybe I am wrong with time calculation? Vadim Nebogatov
09:21 AM Feature #1947: add conversion support for database methods
Update #134 from Eric was attached at 2013-03-05 11:38PM, so I supposed that it was merged with revision 10245 that w... Vadim Nebogatov
08:54 AM Feature #1947: add conversion support for database methods
Vadim, literals.rules is not merged with 10245 (evl_upd20130305a.zip). I'll let Eric review the rest of the update. Constantin Asofiei
08:49 AM Feature #1947: add conversion support for database methods
Attached update
vmn_upd20130306a.zip / vmn_upd20130306a_test_cases.zip (start/final revisions 10245/10253)
The follow...
Vadim Nebogatov
11:46 PM Feature #1947: add conversion support for database methods
Vadim, please note that Ovidiu soon will be committing to bzr some changes to files which will overlap with your upda... Eric Faulhaber
12:42 PM Bug #2077: fix converted table and field name collisions
Committed to bzr revision 10257. Constantin Asofiei
11:54 AM Bug #2077: fix converted table and field name collisions
Check it in and distribute it. Greg Shah
11:40 AM Bug #2077: fix converted table and field name collisions
Update has passed conversion regression testing - no changes in generated code. Constantin Asofiei
10:46 AM Bug #2077: fix converted table and field name collisions
This solves the collision cases for good. Also, I've added support for buffer names collision check. I'm putting this... Constantin Asofiei
09:12 AM Bug #2077: fix converted table and field name collisions
Yes, the fix is pretty simple. I'll provide an update today. Constantin Asofiei
09:00 AM Bug #2077: fix converted table and field name collisions
If this is easy enough to fix, please go ahead and put the fix in. That way we don't have to remember there is a pro... Greg Shah
07:38 AM Bug #2077: fix converted table and field name collisions
Ovidiu, sorry I hijacked this from you last night. Anyway, this case I don't think is encountered in the server proje... Constantin Asofiei
07:26 AM Bug #2077: fix converted table and field name collisions
By chance I prepared a sample test-case for this issue which at this moment is not converted correctly by p2j:... Ovidiu Maxiniuc
01:50 AM Bug #2077: fix converted table and field name collisions
Committed to bzr revision 10246. Constantin Asofiei
07:14 AM Feature #1967: rework DMO class/interface hierarchy
0306b.zip was committed to bzr revision 10253. Constantin Asofiei
04:46 AM Feature #1967: rework DMO class/interface hierarchy
ca_upd20130306b.zip has passed conversion regression testing (no changes in generated sources). Constantin Asofiei
02:25 AM Feature #1967: rework DMO class/interface hierarchy
Attached update fixes the problem for my 0305d.zip. It brackets the deleteAll with a block only if it's parent is not... Constantin Asofiei
11:36 PM Feature #1967: rework DMO class/interface hierarchy
The om_upd20130304b.zip and ecf_upd20130305a.zip updates have gotten through conversion regression testing. However,... Eric Faulhaber
09:50 PM Feature #1967: rework DMO class/interface hierarchy
Code review -20130304a- 20130304b:
The code looks fine. The attached update corrects some cut-and-paste errors in t...
Eric Faulhaber
03:03 AM Feature #1953: add conversion support for CREATE BUFFER statement
Committed revision 10248. Ovidiu Maxiniuc
09:07 PM Feature #1953: add conversion support for CREATE BUFFER statement
Update 20130303a looks fine, except that the zip file is based at the com directory instead of src. Please fix this,... Eric Faulhaber
11:41 PM Feature #1933: add conversion support for certain metadata constructs
Conversion regression testing was successful. Please commit and distribute the 20130305b update. Eric Faulhaber
10:15 PM Feature #1933: add conversion support for certain metadata constructs
Code review 20130305a:
Changes look good.
Code review 20130305b:
The change is fine, but a slightly tighter ...
Eric Faulhaber
11:39 PM Feature #1668: add support for additional (non-dynamic) database attributes
Update 20130304c has passed conversion regression testing. Please correct the FieldReference header as noted above, ... Eric Faulhaber
09:58 PM Feature #1668: add support for additional (non-dynamic) database attributes
Code review 20130304c:
Code changes look fine, but please correct the file header numbering for the last 2 entries...
Eric Faulhaber

03/05/2013

06:20 PM Bug #2077: fix converted table and field name collisions
It looks fine. Check it in and distribute it. Greg Shah
05:16 PM Bug #2077: fix converted table and field name collisions
Passed conversion regression testing. Constantin Asofiei
04:18 PM Bug #2077: fix converted table and field name collisions
I'm putting this through conversion regression testing. Constantin Asofiei
02:39 PM Bug #2077: fix converted table and field name collisions
This update solves collisions for dmo, table, property and column names. It adds a numeric suffix, similar to how tem... Constantin Asofiei
02:05 PM Bug #2077: fix converted table and field name collisions
In 4GL, it is possible to have two tables names named @p2j_test@ and @p2j-test@. Also, these field names can be in th... Constantin Asofiei
02:02 PM Bug #2077 (Closed): fix converted table and field name collisions
Constantin Asofiei
05:50 PM Feature #2080: add runtime support for database methods
The following static methods should be removed from AbstractQuery:... Eric Faulhaber
05:44 PM Feature #2080: add runtime support for database methods
This issue is for adding runtime support for all the database methods added in issue #1947. For the most part, we on... Eric Faulhaber
05:40 PM Feature #2080 (Closed): add runtime support for database methods
Eric Faulhaber
05:30 PM Feature #1947: add conversion support for database methods
Update 20130305b hit a snag in conversion regression testing. It did not cause a regression per se, because the chan... Eric Faulhaber
03:55 PM Feature #1947: add conversion support for database methods
I tried to update code from bzr now (I did not make any changes since the time I sent update).
Please see result - ...
Vadim Nebogatov
03:49 PM Feature #1947: add conversion support for database methods
I made fresh check out today morning and merged manually from updates with adding only my changes. Maybe I missed som... Vadim Nebogatov
03:44 PM Feature #1947: add conversion support for database methods
Eric, sorry, but I updated code today from bzr minimum 5 times during the day with bzr update command. Last time imme... Vadim Nebogatov
03:38 PM Feature #1947: add conversion support for database methods
Code review 20130305a:
The changes all look good, but rules/convert/literals.rules was out of date with bzr (confl...
Eric Faulhaber
09:41 AM Feature #1947: add conversion support for database methods
Updated test cases with expressions Vadim Nebogatov
09:31 AM Feature #1947: add conversion support for database methods
Yes, it is true. Tests passed in this case too with the results like
query1.getNext(LockType.LT_EXCLUSIVE, plus(7,...
Vadim Nebogatov
07:43 AM Feature #1947: add conversion support for database methods
Vadim,
> are even not compilable.
the correct syntax for you tests is this:...
Constantin Asofiei
07:40 AM Feature #1947: add conversion support for database methods
Attached update
vmn_upd20130305a.zip / vmn_upd20130305a_test_cases.zip
is next replacement of update vmn_upd20130...
Vadim Nebogatov
05:16 PM Feature #1967: rework DMO class/interface hierarchy
I'm taking this back, wrong task: this has some regressions in terms that is too aggressive when bracketing the delet... Constantin Asofiei
05:15 PM Feature #1967: rework DMO class/interface hierarchy
-Passed conversion regression testing.- Constantin Asofiei
04:18 PM Feature #1967: rework DMO class/interface hierarchy
I'm putting this through conversion regression testing. Constantin Asofiei
01:48 PM Feature #1967: rework DMO class/interface hierarchy
Fix cases of a FOR EACH block converted to a tt.delete call, in case the FOR EACH is enclosed in a statement - in thi... Constantin Asofiei
10:56 AM Feature #1933: add conversion support for certain metadata constructs
This update adds a message to standard console when a duplicate dmo name is detected. Ovidiu Maxiniuc
10:11 AM Feature #1933: add conversion support for certain metadata constructs
I only want you to add this feature if it is very fast to implement, since this is not in the critical path. Otherwi... Eric Faulhaber
10:04 AM Feature #1933: add conversion support for certain metadata constructs
Should I add the verification? What kind should it be? Just a @System.err/out.print()@ or persisted to logging file ?... Ovidiu Maxiniuc
09:13 AM Feature #1933: add conversion support for certain metadata constructs
Ovidiu Maxiniuc wrote:
> Shouldn't we use an automated postfixed name change if some name is already taken? Or at le...
Eric Faulhaber
07:52 AM Feature #1933: add conversion support for certain metadata constructs
Fixed java package for metadata tables.
Just a question. I know that the problem is solvable by using hints but if...
Ovidiu Maxiniuc

03/04/2013

04:03 PM Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
Good point. Actually, the best is probably just to get rid of the @schemaScope@ variable altogether and use the @glo... Eric Faulhaber
03:53 PM Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
LE: actually, I think the correct test is:... Constantin Asofiei
03:45 PM Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
Eric, your fix in SchemaDictionary I don't think it works for temp-tables, as the following code:... Constantin Asofiei
03:12 PM Feature #1933: add conversion support for certain metadata constructs
Ovidiu Maxiniuc wrote:
> You mean that we should use @P2OLookup@ instead of the current @SymbolResolver@ calls ?
...
Eric Faulhaber
01:04 PM Feature #1933: add conversion support for certain metadata constructs
> I think this is probably best done in P2OLookup (in the schema package), such that P2OLookup.javaPackage(String his... Ovidiu Maxiniuc
11:07 AM Feature #1933: add conversion support for certain metadata constructs
Ovidiu Maxiniuc wrote:
> 4GL has a meta set of tables associated with each database and from the user point of view ...
Eric Faulhaber
01:19 PM Feature #1947: add conversion support for database methods
Vadim Nebogatove wrote (in email):
> I tried to make tests today with literal constants. Possible I implemented chan...
Eric Faulhaber
09:44 AM Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> I have analyzed one more time. Solution you wrote is useful if both parameters are literals...
Eric Faulhaber
04:05 AM Feature #1947: add conversion support for database methods
I have analyzed one more time. Solution you wrote is useful if both parameters are literals. But many combined cases ... Vadim Nebogatov
03:04 AM Feature #1947: add conversion support for database methods
I did not notice that Ubuntu Nautilus does not show backup files by default... Vadim Nebogatov
09:48 PM Feature #1947: add conversion support for database methods
Code review 20130303a:
* As I noted earlier, please don't include backup files (e.g., @QueryWrapper.java~@) in you...
Eric Faulhaber
10:54 AM Feature #1668: add support for additional (non-dynamic) database attributes
Added @FieldInterface@/@FieldReference.value(NumberType)@. This is related to #2068, note 18.1.
This update must be...
Ovidiu Maxiniuc
10:47 AM Feature #1967: rework DMO class/interface hierarchy
Unfortunately, at some point we might have to rename the APIs in these interfaces too, which are extended by Buffer i... Constantin Asofiei
10:33 AM Feature #1967: rework DMO class/interface hierarchy
This update fixes eventual collisions in dmo interfaces because of @WrappedResource@ interface (@isValid()@ & @isUnkn... Ovidiu Maxiniuc
09:37 AM Feature #2000: add conversion support for table and table handle parameters
Got it. I was mis-reading the meaning of the syntax. Greg Shah
09:33 AM Feature #2000: add conversion support for table and table handle parameters
> Is there any difference in behavior if you switch the order of the DEF SHARED VAR and DEF PARAMETER (if the DEF SHA... Stanislav Lomany
09:31 AM Feature #2000: add conversion support for table and table handle parameters
Is there any difference in behavior if you switch the order of the DEF SHARED VAR and DEF PARAMETER (if the DEF SHARE... Greg Shah
05:39 AM Feature #2000: add conversion support for table and table handle parameters
I found that @DEF PARAMETER TABLE-HANDLE FOR th@ where @th@ is a [new] shared variable is handled differently that if... Stanislav Lomany
05:15 AM Feature #1953: add conversion support for CREATE BUFFER statement
Added missing create() overloads.
Also reformatted and sorted so that they are more visible/countable.
Fixes compil...
Ovidiu Maxiniuc

03/03/2013

03:28 PM Feature #1947: add conversion support for database methods
Attached update vmn_upd20130303a.zip with tests vmn_upd20130303a_test_cases.zip is next replacement of update vmn_upd... Vadim Nebogatov
03:22 PM Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
The attached update is an interim workaround to protect against the NPE so we can get further into conversion. Still... Eric Faulhaber

03/02/2013

06:11 PM Feature #1947: add conversion support for database methods
The ges_upd20130302a.zip passed conversion testing and checked in as bzr revision 10232. Greg Shah
04:52 PM Feature #1947: add conversion support for database methods
As found in #1985 (and documented in note 3 of #1655), the DELETE-RESULT-LIST-ENTRY() method should have been added p... Greg Shah
09:34 AM Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > In convert/literals.rules, rewrite the rules regarding lock type...
Eric Faulhaber
05:23 AM Feature #1947: add conversion support for database methods
Eric Faulhaber wrote:
> In convert/literals.rules, rewrite the rules regarding lock type literals (added in the last...
Vadim Nebogatov
12:42 PM Feature #1933: add conversion support for certain metadata constructs
For identifying the correct package to be imported I went back on the annotation paths for @pkgname@, @bufname@, @sch... Ovidiu Maxiniuc
02:39 AM Bug #2071 (Closed): conversion fails to find attach point for QueryWrapper instance variable decl...
Eric Faulhaber
02:36 AM Bug #2071: conversion fails to find attach point for QueryWrapper instance variable declaration
A non-promoted OPEN QUERY in an IF-THEN construct fails to find an attach point to which to graft its QueryWrapper de... Eric Faulhaber
01:25 AM Bug #2071 (Closed): conversion fails to find attach point for QueryWrapper instance variable decl...
Eric Faulhaber

03/01/2013

04:05 PM Feature #1947: add conversion support for database methods
Attached update vmn_upd20130301c.zip with tests vmn_upd20130301c_test_cases.zip is replacement of update vmn_upd20130... Vadim Nebogatov
12:15 PM Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> Yes, I hope
If not, please post what you have at the end of the day so we have the optio...
Eric Faulhaber
11:42 AM Feature #1947: add conversion support for database methods
Yes, I hope Vadim Nebogatov
11:22 AM Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> Changes in *.rules files. OK, will correct. My impression was that it will be needed for ru...
Eric Faulhaber
10:55 AM Feature #1947: add conversion support for database methods
Changes in *.rules files. OK, will correct. My impression was that it will be needed for runtime.
Static queryC...
Vadim Nebogatov
09:40 AM Feature #1947: add conversion support for database methods
Code review 20130301a:
* The update is incomplete. I provided detailed instructions on the needed changes to rule...
Eric Faulhaber
09:05 AM Feature #1947: add conversion support for database methods
Attached update vmn_upd20130301b.zip with tests vmn_upd20130301b_test_cases.zip
containing fixes for # 1947/ #102: ...
Vadim Nebogatov
08:58 AM Feature #1947: add conversion support for database methods
Sorry I have not specified, it was Ovidiu's update. Constantin Asofiei
08:57 AM Feature #1947: add conversion support for database methods
I think he means 104. I'm reviewing 103 now. It is not ready; I'll provide detail shortly. Eric Faulhaber
08:50 AM Feature #1947: add conversion support for database methods
Constantin Asofiei wrote:
> It passed conversion regression testing, please go ahead and checkin/ distribute.
Do ...
Vadim Nebogatov
08:49 AM Feature #1947: add conversion support for database methods
It passed conversion regression testing, please go ahead and checkin/ distribute. Constantin Asofiei
07:16 AM Feature #1947: add conversion support for database methods
The code looks good, I'm putting this through conversion regression testing. Constantin Asofiei
07:03 AM Feature #1947: add conversion support for database methods
This update removes the unneeded @handle:@ token from the chaining like:... Ovidiu Maxiniuc
03:46 AM Feature #1947: add conversion support for database methods
Attached update vmn_upd20130301a.zip with tests vmn_upd20130301a_test_cases.zip containing
1) the conversion and runt...
Vadim Nebogatov
03:14 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Update has passed conversion regression test and is committed to bzr rev. 10228. Eric Faulhaber
08:03 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
@defaultBufferHandle@ is pushed up from @TempTable@ to @Buffer@ interface. Ovidiu Maxiniuc
03:04 PM Feature #1949: add conversion support for database triggers
This update looks good and has passed conversion regression testing. Please check it into bzr and distribute. Eric Faulhaber
08:31 AM Feature #1949: add conversion support for database triggers
Constantin's point is a good one. It looks to me like the parser is fine (of course I like saying that :)).
Can w...
Greg Shah
08:16 AM Feature #1949: add conversion support for database triggers
2.1 would be OK only if the ON WRITE statement would work only with table names, but looks like it works with buffer ... Constantin Asofiei
07:59 AM Feature #1949: add conversion support for database triggers
Option 2.1 seems most correct to me, because it makes the tree accurately reflect the meaning of the code from the be... Eric Faulhaber
03:29 AM Feature #1949: add conversion support for database triggers
... Stanislav Lomany
10:13 AM Feature #1933: add conversion support for certain metadata constructs
I will go on with this issue, as I am now able to see what's wrong using my project. Ovidiu Maxiniuc
07:50 AM Feature #1933: add conversion support for certain metadata constructs
Ovidiu Maxiniuc wrote:
> I exported a sample @_File@ structure (.df) and data (.d) from my test database ...
I ca...
Eric Faulhaber
03:28 AM Feature #1933: add conversion support for certain metadata constructs
Eric,
I exported a sample @_File@ structure (.df) and data (.d) from my test database but, for some unknown (to me)...
Ovidiu Maxiniuc
01:01 AM Feature #1668: add support for additional (non-dynamic) database attributes
FieldReference.value is missing the value(NumberType) version (subscript can be more than int literals).
PS: and Fie...
Constantin Asofiei

02/28/2013

04:41 PM Feature #1947: add conversion support for database methods
I'm posting these here too, from #2068:
More errors related to database methods:...
Constantin Asofiei
04:02 PM Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> It works with 0 without errors too; - as far as I understood
>
> ...
Eric Faulhaber
03:11 PM Feature #1947: add conversion support for database methods
I tested in 4GL the following... Vadim Nebogatov
02:22 PM Feature #1947: add conversion support for database methods
One correction to my last posting:
In the case where the first argument is NOT one of the lock literals, AND we ha...
Eric Faulhaber
02:05 PM Feature #1947: add conversion support for database methods
OK, then we must emulate this error handling at runtime, which means we need the following APIs:... Eric Faulhaber
01:13 PM Feature #1947: add conversion support for database methods
I have tested in 4GL the following... Vadim Nebogatov
11:59 AM Feature #1947: add conversion support for database methods
Constantin Asofiei wrote:
> > Again, if the literals don't match the well-known compiler constants, Progress must de...
Eric Faulhaber
11:36 AM Feature #1947: add conversion support for database methods
> Again, if the literals don't match the well-known compiler constants, Progress must default to some lock behavior d... Constantin Asofiei
11:34 AM Feature #1947: add conversion support for database methods
Constantin Asofiei wrote:
> You forgot these:
> ...
Eric Faulhaber
11:14 AM Feature #1947: add conversion support for database methods
Eric Faulhaber wrote:
> Yes, please hold this update for the moment.
>
> I think we can cover all cases with:
> ...
Constantin Asofiei
11:08 AM Feature #1947: add conversion support for database methods
Yes, please hold this update for the moment.
I think we can cover all cases with:...
Eric Faulhaber
10:45 AM Feature #1947: add conversion support for database methods
Variant with 100+ methods (integer, int64, long, LockType) is ready
GET-NEXT (KW_GET_NEXT)
GET-PREV (KW_GET_PREV...
Vadim Nebogatov
10:41 AM Feature #1947: add conversion support for database methods
> OK, but wouldn't the @i + 1@ expression be converted to @plus(i, 1)@ (which returns an integer wrapper instance), s... Constantin Asofiei
10:36 AM Feature #1947: add conversion support for database methods
Constantin Asofiei wrote:
> > Am I missing something?
> yes, you can pass vars/expressions to these parameters, not...
Eric Faulhaber
10:22 AM Feature #1947: add conversion support for database methods
> Am I missing something?
yes, you can pass vars/expressions to these parameters, not just literals:...
Constantin Asofiei
10:19 AM Feature #1947: add conversion support for database methods
Constantin Asofiei wrote:
> Vadim Nebogatov wrote:
> > If we want to reuse current(LockType lockType) we will need ...
Eric Faulhaber
10:07 AM Feature #1947: add conversion support for database methods
Eric Faulhaber wrote:
> I don't understand this. Why can't we use NumberType to reduce the explosion of APIs? We a...
Constantin Asofiei
10:05 AM Feature #1947: add conversion support for database methods
Constantin Asofiei wrote:
> where both parameters are optional, and nowait appears only if first is set. We can redu...
Eric Faulhaber
08:51 AM Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> If we want to reuse current(LockType lockType) we will need to create LockType from other ty...
Constantin Asofiei
08:49 AM Feature #1947: add conversion support for database methods
If we want to reuse current(LockType lockType) we will need to create LockType from other types including long Vadim Nebogatov
08:40 AM Feature #1947: add conversion support for database methods
If you set the parameter to java native long, then all native int values will be accepted, so no casting is needed. I... Constantin Asofiei
08:39 AM Feature #1947: add conversion support for database methods
Will we cast long to int before using LockType.fromInt(int type)? Vadim Nebogatov
08:33 AM Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> LockType aggregates lock and wait statuses, what is the sense of using it with other parame...
Constantin Asofiei
08:26 AM Feature #1947: add conversion support for database methods
LockType aggregates lock and wait statuses, what is the sense of using it with other parameters, especially with one ... Vadim Nebogatov
08:14 AM Feature #1947: add conversion support for database methods
The syntax for this method would be (example for GET-NEXT):... Constantin Asofiei
08:03 AM Feature #1947: add conversion support for database methods
Constantin Asofiei wrote:
> Vadim Nebogatov wrote:
> > OK, good. What do you think about #68 (getNext(LockType lock...
Vadim Nebogatov
07:35 AM Feature #1947: add conversion support for database methods
LE: when I say no work needed, I refer to the lock types. You will still need getNext(LockType) version to be added. Constantin Asofiei
07:34 AM Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> OK, good. What do you think about #68 (getNext(LockType lockType))?
Actually, NO-LOCK and ...
Constantin Asofiei
06:38 AM Feature #1947: add conversion support for database methods
OK, good. What do you think about #68 (getNext(LockType lockType))? Vadim Nebogatov
06:11 AM Feature #1947: add conversion support for database methods
> According doc, lock is mandatory, no-wait is optional:
>
> GET-NEXT ( NO-LOCK| SHARE-LOCK [, NO-WAIT] | EXCLUSIV...
Constantin Asofiei
06:00 AM Feature #1947: add conversion support for database methods
Eric Faulhaber wrote:
> Ignore my last post; I mis-read the documentation. NO-LOCK is the default if not specified...
Vadim Nebogatov
03:51 AM Feature #1947: add conversion support for database methods
I don't understand... stupid chrome or redmine ? Ovidiu Maxiniuc
03:50 AM Feature #1947: add conversion support for database methods
I think ... Ovidiu Maxiniuc
03:47 AM Feature #1947: add conversion support for database methods
The same question concerning getNext parameters. Do we really need method with signature using P2J type LockType?
...
Vadim Nebogatov
03:40 AM Feature #1947: add conversion support for database methods
The question: BUFFER-COMPARE/ BUFFER-COPY support also should be corrected. May I do this in the same update?
BUF...
Vadim Nebogatov
03:33 PM Feature #1933: add conversion support for certain metadata constructs
Correct, we need the import.
Ovidiu was looking at this at the end of the day today, I guess he will continue tomo...
Constantin Asofiei
02:49 PM Feature #1933: add conversion support for certain metadata constructs
Ah, good point. So, we need to emit an import statement for ...dmo._meta.*, right? Are you taking this, or do you w... Eric Faulhaber
02:43 PM Feature #1933: add conversion support for certain metadata constructs
The metadata tables are emitted to the dmo._meta package, but all buffers referring meta tables are still converted t... Constantin Asofiei
03:31 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Note that the defaultBufferHandle API I think it needs to be added to the Buffer interface too, because there are com... Constantin Asofiei
09:06 AM Feature #1949: add conversion support for database triggers
> do you have any idea why this happens ? Is this intentional ?
No. No. I'll take it as my top priority.
Stanislav Lomany
08:25 AM Feature #1949: add conversion support for database triggers
During the investigations for #1985, note 69, resulted that a possible bug is in the parser.
The following code:
<p...
Ovidiu Maxiniuc
01:48 AM Feature #1588: add conversion and runtime support for embedded SQL
20130227a update has passed regression testing and is committed to bzr rev. 10225. Eric Faulhaber
12:40 AM Feature #1588: add conversion and runtime support for embedded SQL
Attached update fixes a defect during annotations processing. Eric Faulhaber

02/27/2013

05:17 PM Feature #2000: add conversion support for table and table handle parameters
I uncommited my last commit. Stanislav Lomany
05:13 PM Feature #2000: add conversion support for table and table handle parameters
> Please distribute the Config change as a separate update zip file BUT at the SAME TIME as the svl_upd20130226a.zip.... Stanislav Lomany
05:04 PM Feature #2000: add conversion support for table and table handle parameters
Please distribute the Config change as a separate update zip file BUT at the SAME TIME as the svl_upd20130226a.zip. ... Greg Shah
04:37 PM Feature #2000: add conversion support for table and table handle parameters
Actually, I think we're OK here. All the failures are in the Config class, which is hand-written and will need to be... Eric Faulhaber
03:47 PM Feature #2000: add conversion support for table and table handle parameters
Majic did not compile after this update. Please see #2067 for the results. Eric Faulhaber
03:08 PM Feature #2000: add conversion support for table and table handle parameters
> I'll do it here. Do you expect any differences? If I find anything unusual, I'll ask.
TABLE parameters should us...
Stanislav Lomany
02:29 PM Feature #2000: add conversion support for table and table handle parameters
I'll do it here. Do you expect any differences? If I find anything unusual, I'll ask. Eric Faulhaber
02:17 PM Feature #2000: add conversion support for table and table handle parameters
> Have you run conversion on Majic with this to check for unexpected changes?
No. I can run, but it will take 2.5 h.
Stanislav Lomany
02:10 PM Feature #2000: add conversion support for table and table handle parameters
Have you run conversion on Majic with this to check for unexpected changes? Eric Faulhaber
02:07 PM Feature #2000: add conversion support for table and table handle parameters
Everything except SHARED variables for TABLE-HANDLE FOR. I recommend to distribute the remaining part later as a sepa... Stanislav Lomany
12:11 AM Feature #2000: add conversion support for table and table handle parameters
Stanislav Lomany wrote:
> Heh, it look like BUFFER parameter is misconverted, but not because of me:
>
> [...]
...
Eric Faulhaber
07:23 PM Feature #2000: add conversion support for table and table handle parameters
Fix for #2. Stanislav Lomany
03:53 PM Feature #1947: add conversion support for database methods
om_upd20130227c.zip has passed conversion testing and is checked into bzr as revision 10223. Greg Shah
02:17 PM Feature #1947: add conversion support for database methods
The om_upd20130227b.zip is close, but I have made a couple of changes to the code. The post-rules section is moved t... Greg Shah
01:29 PM Feature #1947: add conversion support for database methods
Ignore my last post; I mis-read the documentation. NO-LOCK is the default if not specified. So, it seems we will n... Eric Faulhaber
01:25 PM Feature #1947: add conversion support for database methods
Correction: I don't think we'll need @P2JQuery.getNext()@ (only @P2JQuery.getNext(LockType lockType)@); seems the 4... Eric Faulhaber
01:14 PM Feature #1947: add conversion support for database methods
Vadim, please fix the query handle GET-* return type problem, as described in #1985, note 61 (repeated below for conv... Eric Faulhaber
12:37 PM Feature #1947: add conversion support for database methods
This update fixes generation of @LockType@ literals into converted java source.
Ovidiu Maxiniuc
12:04 PM Feature #1947 (WIP): add conversion support for database methods
Needed to re-open this for some conversion corrections to query methods GET-NEXT, GET-FIRST, etc. Please see note 61... Eric Faulhaber
01:48 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Passed runtime regression testing and is checked into bzr as revision 10222. Greg Shah
01:45 PM Feature #1949: add conversion support for database triggers
Passed conversion testing and is checked in as bzr revision 10221. Greg Shah
12:16 PM Feature #1949: add conversion support for database triggers
Conversion testing passed. Please check in the update and distribute it. Greg Shah
09:45 AM Feature #1949: add conversion support for database triggers
I have started conversion testing. Greg Shah
09:41 AM Feature #1949: add conversion support for database triggers
The code looks OK. We need to conversion test it. Greg Shah
09:40 AM Feature #1949: add conversion support for database triggers
Indeed, the annotations are not set unless some variables are first declared. And, because in our sample the block is... Ovidiu Maxiniuc
09:19 AM Feature #1949: add conversion support for database triggers
Looks like for trigger blocks, the undoable counter are not initialized (written as annotation).
The attached propos...
Ovidiu Maxiniuc
05:24 AM Feature #1949: add conversion support for database triggers
Problem with DB triggers in server project:... Constantin Asofiei
11:53 AM Feature #1668: add support for additional (non-dynamic) database attributes
Discussion moved from emails.
---
Eric,
As far as I understood, Ovidiu is already busy with BUFFER-VALUE r...
Vadim Nebogatov
12:07 AM Bug #2062 (Closed): buffer parameter names doubled up, not included in RecordBuffer.openScope() call
The following test:... Eric Faulhaber
12:01 AM Bug #2062 (Closed): buffer parameter names doubled up, not included in RecordBuffer.openScope() call
Eric Faulhaber

02/26/2013

06:53 PM Feature #2000: add conversion support for table and table handle parameters
> In regards to issue number 4, can you explain what the code in th-proc.p is supposed to do?
> This code seems like...
Stanislav Lomany
06:08 PM Feature #2000: add conversion support for table and table handle parameters
Heh, it look like BUFFER parameter is misconverted, but not because of me:... Stanislav Lomany
05:33 PM Feature #2000: add conversion support for table and table handle parameters
> Hm...actually, a BUFFER parameter on a temp-table won't cause a call to TemporaryBuffer.associate. Is there still ... Stanislav Lomany
05:28 PM Feature #2000: add conversion support for table and table handle parameters
Stanislav Lomany wrote:
> > What about BUFFER parameters on temp-tables?
>
> Yes, I missed this type of parameter...
Eric Faulhaber
04:58 PM Feature #2000: add conversion support for table and table handle parameters
> What about BUFFER parameters on temp-tables?
Yes, I missed this type of parameters when I was analyzing the impa...
Stanislav Lomany
04:56 PM Feature #2000: add conversion support for table and table handle parameters
Stanislav Lomany wrote:
> >In record_scoping.rules, you changed the bufclassname annotation to TableParameter from T...
Eric Faulhaber
04:47 PM Feature #2000: add conversion support for table and table handle parameters
In regards to issue number 4, can you explain what the code in th-proc.p is supposed to do?... Greg Shah
04:43 PM Feature #2000: add conversion support for table and table handle parameters
>In record_scoping.rules, you changed the bufclassname annotation to TableParameter from Temporary. Isn't that going ... Stanislav Lomany
04:37 PM Feature #2000: add conversion support for table and table handle parameters
In record_scoping.rules, you changed the bufclassname annotation to TableParameter from Temporary. Isn't that going ... Eric Faulhaber
04:12 PM Feature #2000: add conversion support for table and table handle parameters
> Did you intend to remove this from the define_stmt rule in progress.g?
Yes. I don't know why it was there, proba...
Stanislav Lomany
04:09 PM Feature #2000: add conversion support for table and table handle parameters
Did you intend to remove this from the define_stmt rule in progress.g?... Eric Faulhaber
04:08 PM Feature #2000: add conversion support for table and table handle parameters
#1 - yes, working on it
#2 - emit TableParameter when calling a function, working on it
#3 - yes, it works fine
#4...
Stanislav Lomany
04:00 PM Feature #2000: add conversion support for table and table handle parameters
Stanislav Lomany wrote:
> What remains is:
> 1. procedure TABLE-HANDLE calls using TableParameters, calling side - ...
Eric Faulhaber
03:44 PM Feature #2000: add conversion support for table and table handle parameters
I'll add javadocs later. Stanislav Lomany
01:19 PM Feature #2000: add conversion support for table and table handle parameters
Attached is the parser change to accept the APPEND syntax on a function call. Greg Shah
05:55 PM Bug #2057 (Closed): buffer unique name disambiguation (separator problems)
Eric Faulhaber
02:16 PM Bug #2057: buffer unique name disambiguation (separator problems)
Passed conversion regression testing, committed to bzr revision 10213. Constantin Asofiei
02:13 PM Bug #2057: buffer unique name disambiguation (separator problems)
attached correct update, previous one was for another task (will delete it) Constantin Asofiei
02:08 PM Bug #2057: buffer unique name disambiguation (separator problems)
The conversion regression testing has passed, the only diffs were related to instance field order (RecordBuffer.defin... Constantin Asofiei
12:15 PM Bug #2057: buffer unique name disambiguation (separator problems)
Constantin Asofiei wrote:
> Eric, one more question: if you can, please explain why BufferScopeWorker.getBuffer atte...
Eric Faulhaber
11:45 AM Bug #2057: buffer unique name disambiguation (separator problems)
Update: with the BuffescScopeWorker.getBuffer changed I mentioned earlier, conversion of app folder goes through all ... Constantin Asofiei
11:20 AM Bug #2057: buffer unique name disambiguation (separator problems)
Eric, one more question: if you can, please explain why BufferScopeWorker.getBuffer attempts to match the buffer usin... Constantin Asofiei
11:00 AM Bug #2057: buffer unique name disambiguation (separator problems)
Eric, the code converts because our test db is named "p2j_test", with an underscore... I had to change the DB name to... Constantin Asofiei
10:59 AM Bug #2057: buffer unique name disambiguation (separator problems)
I realize you're the assignee for this, but it looked like it might be related to what I fixed last night, so I conve... Eric Faulhaber
10:10 AM Bug #2057: buffer unique name disambiguation (separator problems)
We have a case where an existing buffer defined for a table, like:... Constantin Asofiei
10:00 AM Bug #2057 (Closed): buffer unique name disambiguation (separator problems)
Constantin Asofiei
05:54 PM Feature #2055 (Closed): RECID AND ROWID IN WHERE CLAUSE
Eric Faulhaber
12:37 PM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
Commited to bzr as revision 10212. Costin Savin
12:26 PM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
Conversion regression testing has passed, please check in and distribute update. Constantin Asofiei
11:08 AM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
Eliminated the problems from previous update Costin Savin
10:17 AM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
Beside the header in RecidExpression (where you reference RowidExpression), I don't see any problems. I'm putting thi... Constantin Asofiei
10:14 AM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
I'm reviewing this now. Constantin Asofiei
09:59 AM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
Derived a case from that for recid
Added proposed update.
Costin Savin
09:11 AM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
Costin, use this test:... Constantin Asofiei
08:53 AM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
Is there any case for RECID I can use?
For ROWID I testedn the changes with something like @FIND FIRST book WHERE TO...
Costin Savin
05:01 AM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
Next error is in .../vcpl/daqueau0.p:... Costin Savin
04:59 AM Feature #2055 (Closed): RECID AND ROWID IN WHERE CLAUSE
Costin Savin
05:53 PM Bug #2052 (Closed): conversion error resolving master temp-table buffer
Eric Faulhaber
07:48 PM Bug #2052: conversion error resolving master temp-table buffer
This update has passed conversion regression testing and is checked into bzr revision 10205. Eric Faulhaber
12:45 PM Bug #2059 (WIP): CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FO...
The following code fails at conversion time:... Constantin Asofiei
12:43 PM Bug #2059 (Closed): CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a...
Constantin Asofiei
12:14 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I have updated the p2jpl.ddr and have applied it to staging. It has no conversion impact, only runtime. Runtime regr... Greg Shah
04:05 AM Feature #1668: add support for additional (non-dynamic) database attributes
Added conversion support for EMPTY-TEMP-TABLE and BUFFER-DELETE (see ecf_upd20130226a.zip at #1985). This update pas... Eric Faulhaber
02:34 AM Bug #2054 (Closed): conversion errors with complex buffer parameters and definitions
The fix has passed conversion regression testing. It is checked into bzr revision 10207. Eric Faulhaber
02:08 AM Bug #2054: conversion errors with complex buffer parameters and definitions
The following testcases produce buffers and fields with the incorrect schemaname annotation, such that downstream pro... Eric Faulhaber
01:59 AM Bug #2054 (Closed): conversion errors with complex buffer parameters and definitions
Eric Faulhaber

02/25/2013

04:51 PM Bug #2052: conversion error resolving master temp-table buffer
Turns out the previous update fixed the symptom rather than the root cause. Turns out we were not handling empty int... Eric Faulhaber
03:40 PM Bug #2052: conversion error resolving master temp-table buffer
Constantin Asofiei wrote:
> This testcase is related to this issue:
> [...]
>
> The buffers get reordered, but n...
Eric Faulhaber
03:08 PM Bug #2052: conversion error resolving master temp-table buffer
This testcase is related to this issue:... Constantin Asofiei
02:59 PM Bug #2052: conversion error resolving master temp-table buffer
OK, I'll try postponing the DEFINE BUFFER lookups until all the DEFINE TEMP-TABLE statements in a file have been visi... Eric Faulhaber
02:56 PM Bug #2052: conversion error resolving master temp-table buffer
I think this is related to annotations/record_scoping_post.rules H008. Constantin Asofiei
02:49 PM Bug #2052: conversion error resolving master temp-table buffer
The error occurs because there is an expectation of a DEFINE TEMP-TABLE xyz statement appearing earlier in the AST th... Eric Faulhaber
02:18 PM Bug #2052 (Closed): conversion error resolving master temp-table buffer
Eric Faulhaber
03:37 PM Feature #2047 (Closed): field references in procedures without explicit buffer scope
Greg Shah
03:15 PM Feature #2047: field references in procedures without explicit buffer scope
Committed to bzr revision 10204. Constantin Asofiei
03:02 PM Feature #2047: field references in procedures without explicit buffer scope
Check it in and distribute it. Greg Shah
02:42 PM Feature #2047: field references in procedures without explicit buffer scope
The conversion has finished and the generated sources look good to me (only some reordering in openScope and buffer i... Constantin Asofiei
01:32 PM Feature #2047: field references in procedures without explicit buffer scope
I had a copy-paste error in SymbolResolver, I saved bufname instead of dbname in the "dbname" annotation. I'm running... Constantin Asofiei
11:40 AM Feature #2047: field references in procedures without explicit buffer scope
I'm a little nervous about the change BUT I think it should be OK. I'm going to put it into conversion testing now. Greg Shah
11:01 AM Feature #2047: field references in procedures without explicit buffer scope
Fix attempt for scope computation for fields in procedures/functions without explicit buffer scope created by other s... Constantin Asofiei
09:39 AM Feature #2047: field references in procedures without explicit buffer scope
This one is related to #1706. Looking at the perm buffer scoping from some compile listings from 4GL v9 and new ones ... Constantin Asofiei
08:53 AM Feature #2047: field references in procedures without explicit buffer scope
Looks like 4GL allows a buffer reference in a procedure, without having its scope set, as it inherits the buffer scop... Constantin Asofiei
08:51 AM Feature #2047 (Closed): field references in procedures without explicit buffer scope
Constantin Asofiei
01:01 PM Feature #1992 (Closed): add support for double-colon (::) syntax
Eric Faulhaber
12:35 PM Feature #1992: add support for double-colon (::) syntax
I have chosen not to alter in any way the update that have passed the testing (om_upd20130225a.zip) and committed it ... Ovidiu Maxiniuc
11:38 AM Feature #1992: add support for double-colon (::) syntax
Your update (including my change to progress.g) has passed conversion regression testing. I am attaching my updated ... Eric Faulhaber
10:55 AM Feature #1992: add support for double-colon (::) syntax
> There was one change to progress.g that seemed unnecessary: after discussion with Greg, I removed the actions in t... Ovidiu Maxiniuc
10:43 AM Feature #1992: add support for double-colon (::) syntax
Code review 20130225a:
Nice work! I am running it through conversion regression testing now.
There was one cha...
Eric Faulhaber
06:19 AM Feature #1992: add support for double-colon (::) syntax
Latest :: conversion merged with bzr revision 10199 and updated testcase. Ovidiu Maxiniuc
11:47 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Greg Shah wrote:
> Final conversion testing passed. This is checked into bzr as 10200.
This will fail runtime reg...
Eric Faulhaber
10:21 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Final conversion testing passed. This is checked into bzr as 10200. Greg Shah
09:15 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Initial conversion testing passed. Attached is the update merged up to bzr 10199. This is going back into conversio... Greg Shah
02:43 AM Feature #1975: add runtime support for (non-dynamic) database attributes
Log all history in parent task. Eric Faulhaber
02:37 AM Feature #2042 (Closed): add conversion support for some embedded SQL features
Eric Faulhaber
02:34 AM Feature #1588: add conversion and runtime support for embedded SQL
Added support for the simple, single table (and column) constructs listed above. These convert to methods in Buffer.... Eric Faulhaber

02/24/2013

05:29 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
A problem has occurred in the use of the ATTR_POLY BUFFER-VALUE (KW_BUF_VAL) as a parameter to an INTEGER() built-in ... Greg Shah
05:08 PM Feature #2045 (Closed): conversion support for a DELETE statement with a validation expression
Greg Shah
03:18 PM Feature #2045: conversion support for a DELETE statement with a validation expression
This is for time tracking and milestone association only. All history should be in the parent task #2044. Greg Shah
03:17 PM Feature #2045 (Closed): conversion support for a DELETE statement with a validation expression
Greg Shah
05:08 PM Feature #2044: implement support for a DELETE statement with a validation expression
It passed conversion testing and is committed to bzr as revision 10198. Greg Shah
04:08 PM Feature #2044: implement support for a DELETE statement with a validation expression
And now the update... Greg Shah
04:08 PM Feature #2044: implement support for a DELETE statement with a validation expression
I fixed the header and have re-attached the update. This is going into conversion regression testing now. Greg Shah
04:04 PM Feature #2044: implement support for a DELETE statement with a validation expression
Code review 20130224a:
Changes look OK to me. Note that database_access.rules needs a header entry for your changes.
Eric Faulhaber
03:31 PM Feature #2044: implement support for a DELETE statement with a validation expression
Add support to the conversion and runtime for a DELETE statement with a validation expression. We already support DE... Greg Shah
03:17 PM Feature #2044 (Closed): implement support for a DELETE statement with a validation expression
Greg Shah
03:19 PM Feature #2046: runtime support for DELETE statement with a validation expression
This is for time tracking and milestone association only. All history should be in the parent task #2044. Greg Shah
03:19 PM Feature #2046 (Closed): runtime support for DELETE statement with a validation expression
Greg Shah

02/23/2013

04:39 PM Feature #2042: add conversion support for some embedded SQL features
Log history in parent issue. Eric Faulhaber
03:27 PM Feature #2042 (Closed): add conversion support for some embedded SQL features
Eric Faulhaber
04:39 PM Feature #2043: add runtime support for some embedded SQL features
Log history in parent issue. Eric Faulhaber
04:38 PM Feature #2043 (Closed): add runtime support for some embedded SQL features
Eric Faulhaber
11:11 AM Feature #1992: add support for double-colon (::) syntax
OK, please add a suitable task to the Base Language project and target it to milestone 7. Please put all the relevan... Greg Shah
10:55 AM Feature #1992: add support for double-colon (::) syntax
For milestone 4, I don't think there is anything we need to do about the *_POLY rvalues, all -will- can be in the run... Constantin Asofiei
10:48 AM Feature #1992: add support for double-colon (::) syntax
> Idea is, if we have the ATTR/METH_POLY in an expression or as a rvalue, then 4GL does some automatic conversion of ... Greg Shah
03:49 AM Feature #2000: add conversion support for table and table handle parameters
I'm sending the update in its current state: INPUT/OUTPUT parameters and APPEND option are not handled, createDynamic... Stanislav Lomany
03:00 AM Feature #2000: add conversion support for table and table handle parameters
Stanislav, OK now I understand what you mean. APPEND clause used with OUTPUT/INPUT-OUTPUT table at the caller affects... Constantin Asofiei
10:47 PM Feature #2000: add conversion support for table and table handle parameters
Stas: please provide an update for all the other functionality discussed above ASAP, even if you don't yet have an a... Eric Faulhaber
01:42 AM Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
Vadim Nebogatov wrote:
> ... but conversion of
> ...
Eric Faulhaber
12:38 AM Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
I have created environment for tests and made some first conversion tests. Will try to make more tests on Monday.
...
Vadim Nebogatov

02/22/2013

03:09 PM Feature #1992: add support for double-colon (::) syntax
All the specified cases work nicely.
> I'm not sure I understand what is being asked here. By definition, the ATTR...
Constantin Asofiei
03:00 PM Feature #1992: add support for double-colon (::) syntax
> in assignment case, when the rvalue is a ATTR/METH_POLY, are there cases when the lvalue is of a different type tha... Greg Shah
02:57 PM Feature #1992: add support for double-colon (::) syntax
> are there any ATTR_POLY/METH_POLY used directly in a frame-related statement?
In regard to the FUNC_POLY/ATTR_PO...
Greg Shah
01:55 PM Feature #2000: add conversion support for table and table handle parameters
> Please fill out this matrix:
When you specify APPEND in the calling procedure it logically applies to the table ...
Stanislav Lomany
12:44 PM Feature #2000: add conversion support for table and table handle parameters
> Progress documentation tells that "You can only use the APPEND option for an INPUT parameter in the calling procedu... Greg Shah
12:36 PM Feature #2000: add conversion support for table and table handle parameters
Leave it as Temporary if you don't have a need to change it. Less runtime change. If we find we need it to be Buffe... Eric Faulhaber
12:34 PM Feature #2000: add conversion support for table and table handle parameters
So, Eric, do you prefer to leave Temporary or switch to Buffer?
Constantin, Greg, how do you prefer to pass APPEND...
Stanislav Lomany
12:02 PM Feature #1974 (Closed): add conversion support for (non-dynamic) database attributes
Eric Faulhaber
11:15 PM Feature #1999 (Closed): add conversion support for builtin functions in a WHERE clause
I am closing this issue. While it brought up some interesting issues with our CAN-FIND support (which are now docume... Eric Faulhaber
10:28 PM Feature #1999: add conversion support for builtin functions in a WHERE clause
Vadim Nebogatov wrote:
> CAN-FIND(): SHARE-LOCK and NO-WAIT
> Yes, you are right, it is supported. I did not notic...
Eric Faulhaber
08:30 PM Feature #1999: add conversion support for builtin functions in a WHERE clause
CAN-FIND(): SHARE-LOCK and NO-WAIT
Yes, you are right, it is supported. I did not notice that WHERE clause is gener...
Vadim Nebogatov
07:19 PM Feature #1999: add conversion support for builtin functions in a WHERE clause
Vadim Nebogatov wrote:
> Briefly, all functions are supported with all options excepting
>
> 1) can-find() - work...
Eric Faulhaber
11:09 PM Feature #2035: optimize conversion of CAN-FIND([FIRST|LAST] temp-table-record ... {SHARE-LOCK|EXC...
Currently, we convert this construct to use a WhereExpression, which does a client-side lock test for the found recor... Eric Faulhaber
11:02 PM Feature #2035 (New): optimize conversion of CAN-FIND([FIRST|LAST] temp-table-record ... {SHARE-LO...
Eric Faulhaber
10:59 PM Bug #2034: correct conversion of CAN-FIND({FIRST|LAST} ... {SHARE-LOCK|EXCLUSIVE_LOCK} [NO-WAIT])
Currently, we convert @CAN-FIND({FIRST|LAST} ...)@ with a lock the same as we do as if it doesn't have a lock; that ... Eric Faulhaber
10:54 PM Bug #2034 (New): correct conversion of CAN-FIND({FIRST|LAST} ... {SHARE-LOCK|EXCLUSIVE_LOCK} [NO-...
Eric Faulhaber
10:50 PM Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
The construct @record OF table@ in a 4gl query signifies a join between two tables (see "Record phrase" documentation... Eric Faulhaber

02/21/2013

03:36 PM Feature #2000: add conversion support for table and table handle parameters
> From my testing, I don't remember finding any parameter validation based on APPEND clause for temp-tables. This is ... Stanislav Lomany
03:20 PM Feature #2000: add conversion support for table and table handle parameters
> Maybe I misunderstood your original comment "@Temporary@ should be at least @Buffer@". I thought you meant the par... Stanislav Lomany
03:00 PM Feature #2000: add conversion support for table and table handle parameters
> > 2. We must make a decision on how APPEND parameter should be passed from the calling side.
> I think we need Con...
Constantin Asofiei
02:35 PM Feature #2000: add conversion support for table and table handle parameters
Stanislav Lomany wrote:
> 1.
> > OK, in that case I think we can have Temporary extend Buffer.
> Hmm, it seems tha...
Eric Faulhaber
02:16 PM Feature #2000: add conversion support for table and table handle parameters
1.
> OK, in that case I think we can have Temporary extend Buffer.
Hmm, it seems that it makes *.Buf classes obsole...
Stanislav Lomany
07:04 PM Feature #2000: add conversion support for table and table handle parameters
> I'm pretty sure we already support the APPEND option, even though it's not used in Majic.
APPEND option can be s...
Stanislav Lomany
01:41 PM Feature #1949 (Closed): add conversion support for database triggers
Eric Faulhaber
01:30 PM Feature #1949 (Review): add conversion support for database triggers
Stanislav Lomany
01:39 PM Feature #2024 (Closed): implement runtime support for database triggers
Eric Faulhaber
12:39 PM Feature #1999: add conversion support for builtin functions in a WHERE clause
Briefly, all functions are supported with all options excepting
1) can-find() - works in general, but at least FIR...
Vadim Nebogatov
12:34 PM Feature #1999: add conversion support for builtin functions in a WHERE clause
Spreadsheet with testing results is attached.
Vadim Nebogatov
11:49 AM Feature #1668: add support for additional (non-dynamic) database attributes
The update is added for review at #2002. Constantin Asofiei
09:57 AM Feature #1992: add support for double-colon (::) syntax
Yes, this is the case for the @::@, too, as the final attribute in the rewritten form is buffer-value() attribute whe... Ovidiu Maxiniuc
09:51 AM Feature #1992: add support for double-colon (::) syntax
Greg, Ovidiu found an interesting case of BUFFER-VALUE usage (which applies to any ATTR_POLY or METH_POLY). If is use... Constantin Asofiei

02/20/2013

06:41 PM Feature #2000: add conversion support for table and table handle parameters
Stanislav Lomany wrote:
> Conversion for TABLE-HANDLE parameters should probably look in the similar way:
> [...]
...
Eric Faulhaber
06:37 PM Feature #2000: add conversion support for table and table handle parameters
Stanislav Lomany wrote:
> Notes: 1. @Temporary@ should be at least @Buffer@
OK, in that case I think we can have ...
Eric Faulhaber
05:56 PM Feature #2000: add conversion support for table and table handle parameters
Conversion for TABLE-HANDLE parameters should probably look in the similar way:... Stanislav Lomany
05:48 PM Feature #2000: add conversion support for table and table handle parameters
Heh, I didn't expected it to be converted...
It is converted to:...
Stanislav Lomany
05:30 PM Feature #2000: add conversion support for table and table handle parameters
We already support it today, as far as I understand. Remember that you implemented all the deep copy of temp-tables ... Greg Shah
05:02 PM Feature #2000: add conversion support for table and table handle parameters
How do we convert this today? I vaguely remember dealing with this issue in the past, but I don't recall whether we ... Eric Faulhaber
03:55 PM Feature #2000: add conversion support for table and table handle parameters
About TABLE parameters.
We must pass to the called function information that identifies the table and information ...
Stanislav Lomany
02:55 PM Feature #1949: add conversion support for database triggers
h2. TODO
This update doesn't handle the case if an UI trigger is 1. nested into DB trigger and 2. references DB tr...
Stanislav Lomany
01:59 PM Feature #1992: add support for double-colon (::) syntax
Here is the implementation and some testcase.
I'm afraid this is not built on the last source-code, I will work on t...
Ovidiu Maxiniuc
01:50 PM Feature #1992: add support for double-colon (::) syntax
> This could be one of the hardest things to implement. If the field name has changed during the conversion process i... Greg Shah
12:39 PM Feature #1992: add support for double-colon (::) syntax
Greg Shah wrote:
> Some thoughts:
>
> 1. Queries are explicitly mentioned as supported by @::@ in the 4GL languag...
Ovidiu Maxiniuc
12:13 PM Feature #1992: add support for double-colon (::) syntax
Some thoughts:
1. Queries are explicitly mentioned as supported by @::@ in the 4GL language reference. It wouldn'...
Greg Shah
11:19 AM Feature #1992: add support for double-colon (::) syntax
I already have an implementation here but, reading your previous note, made me turn back to OE installation.
The rea...
Ovidiu Maxiniuc
10:28 AM Feature #1992: add support for double-colon (::) syntax
OK, so without chaining, the scope of this feature should be much smaller. As you suggested earlier, let's go with a... Eric Faulhaber
10:41 AM Feature #1999: add conversion support for builtin functions in a WHERE clause
Please provide a summary of which functions are supported by conversion already and which need work. We need to get ... Eric Faulhaber
09:29 AM Feature #1668: add support for additional (non-dynamic) database attributes
Constantin Asofiei wrote:
> > Yes, you are correct.
> Please provide an example of read-only private-data attribute...
Vadim Nebogatov
09:09 AM Feature #1668: add support for additional (non-dynamic) database attributes
> Yes, you are correct.
Please provide an example of read-only private-data attribute.
Constantin Asofiei
09:08 AM Feature #1668: add support for additional (non-dynamic) database attributes
Constantin Asofiei wrote:
> Also #2 - I see that PRIVATE-DATA has an unwrap case of WriteablePrivateData - are there...
Vadim Nebogatov

02/19/2013

04:20 PM Feature #1668: add support for additional (non-dynamic) database attributes
CORRECTION: vmn_upd20130218b.zip is what we tested; it should be overlaid with vmn_upd20130219b.zip. Eric Faulhaber
04:18 PM Feature #1668: add support for additional (non-dynamic) database attributes
Constantin,
We had a regression in staging for a browse column widget handle which used to do @handle.unwrapWidget...
Eric Faulhaber
01:25 PM Feature #1668: add support for additional (non-dynamic) database attributes
> Greg, Constantin: thoughts on how to properly support this? I added the WidthCharable (I know, lame name) interfa... Constantin Asofiei
01:10 PM Feature #1668: add support for additional (non-dynamic) database attributes
Update above is resubmitted Vadim Nebogatov
12:54 PM Feature #1668: add support for additional (non-dynamic) database attributes
Vadim Nebogatov wrote:
> IS-OPEN
> POSITION
> TABLE-HANDLE
> SESSION:FIRST-BUFFER
> (DBNAME was already supporte...
Eric Faulhaber
12:36 PM Feature #1668: add support for additional (non-dynamic) database attributes
IS-OPEN
POSITION
TABLE-HANDLE
SESSION:FIRST-BUFFER
(DBNAME was already supported )
Update vmn_20130219a.zip co...
Vadim Nebogatov
01:23 PM Feature #1992: add support for double-colon (::) syntax
>First, as I wrote above in notes 4 and 7, the second operand can be almost anything (as it is the name of a field fr... Greg Shah
12:58 PM Feature #1992: add support for double-colon (::) syntax
First, as I wrote above in notes 4 and 7, the second operand can be almost anything (as it is the name of a field fro... Ovidiu Maxiniuc
12:20 PM Feature #2000: add conversion support for table and table handle parameters
Yes, that's correct. Eric Faulhaber
12:07 PM Feature #2000 (WIP): add conversion support for table and table handle parameters
Am I correct that the scope of this task is
DEFINE PARAMETER TABLE
DEFINE PARAMETER TABLE-HANDLE
TABLE functio...
Stanislav Lomany
 

Also available in: Atom