Project

General

Profile

Activity

From 03/22/2013 to 04/20/2013

04/20/2013

06:54 PM Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130420a.zip/vmn_upd20130420b.zip as replacement of vmn_upd20130416a.zip/vmn_upd201304... Vadim Nebogatov

04/19/2013

05:55 PM Feature #2080: add runtime support for database methods
Current status of BUFFER-COMPARE/BUFFER-COPY runtime support.
My estimation for changes related with fixing notes 1...
Vadim Nebogatov
04:45 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
>In RecordBuffer.createSimpleFieldsMap, you have the following:
>if (operationType == Opera...
Vadim Nebogatov
02:54 PM Feature #2080: add runtime support for database methods
But BUFFER-COPY method does not create record. There are no mentions about this in
documentation and example below a...
Vadim Nebogatov
01:40 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > Maybe I am wrong, during testing I understood that statement wor...
Vadim Nebogatov
09:50 PM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Maybe I am wrong, during testing I understood that statement works but does nothing in this...
Eric Faulhaber
09:33 AM Feature #2122 (WIP): add runtime support for dynamically prepared temp-tables
Eric Faulhaber
11:12 PM Feature #1580: upgrade Hibernate to latest level
Code review 20130410a:
Wow! Quite a bit of change. Looks good overall; some comments/questions below:
* Plea...
Eric Faulhaber

04/18/2013

06:32 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
>
> In RecordBuffer.setCompareMode(BaseDataType, character), why are you turning on case sen...
Vadim Nebogatov
06:25 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
>
> In @RecordBuffer.copy(DataModelObject, String[], boolean, DataModelObject, boolean)@, yo...
Vadim Nebogatov
03:48 PM Feature #2080: add runtime support for database methods
Sorry, I don't know how to disable this, and what I found online suggested there is not a simple way to just turn off... Eric Faulhaber
03:09 PM Feature #2080: add runtime support for database methods
The reason of some formatting errors is unpleasant Ubuntu's feature: paste on middle mouse click.
Sometimes it happ...
Vadim Nebogatov
02:44 PM Feature #2080: add runtime support for database methods
Code review 20130416a:
Along with your changes, you have introduced some formatting and javadoc issues in BufferIm...
Eric Faulhaber
04:46 PM Feature #1580: upgrade Hibernate to latest level
Stanislav Lomany wrote:
> I did source comparison because I applied the patch for Hibernate and built it from source...
Eric Faulhaber
04:45 PM Feature #1580: upgrade Hibernate to latest level
> The name discrepancy is confusing. Did you do a source or binary comparison?
>
> Let's use the standard, final,...
Stanislav Lomany
04:31 PM Feature #1580: upgrade Hibernate to latest level
Did you do an import (e.g., p2j_test database) to test the ImportWorker changes? Eric Faulhaber
04:25 PM Feature #1580: upgrade Hibernate to latest level
The name discrepancy is confusing. Did you do a source or binary comparison?
Let's use the standard, final, binar...
Eric Faulhaber
04:11 PM Feature #1580: upgrade Hibernate to latest level
I checked this version out of git. I don't know why version in build.gradle is called "4.1.9-SNAPSHOT", but the code ... Stanislav Lomany
03:56 PM Feature #1580: upgrade Hibernate to latest level
Are all the Hibernate-related jars whose names have the word SNAPSHOT in them the most recent, _stable_ releases? Us... Eric Faulhaber
11:07 AM Feature #2120 (WIP): add runtime support for dynamically prepared queries
Eric Faulhaber
11:05 AM Feature #2127: complete runtime support for dynamically prepared queries
This task includes:
* complex WHERE clauses using natural joins (i.e., the OF keyword) or dynamic temp-tables;
* op...
Eric Faulhaber
11:04 AM Feature #2127 (Closed): complete runtime support for dynamically prepared queries
Eric Faulhaber
10:40 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
This feature is needed for permanent tables to enable bulk delete with embedded SQL and with delete loops optimized b... Eric Faulhaber
10:27 PM Feature #2126 (Closed): add support for table-level locking (share and exclusive) for runtime int...
Eric Faulhaber
10:22 PM Bug #2083 (Closed): client-side where-clause leak in FindQuery
Eric Faulhaber
10:08 PM Feature #2125: add runtime support for dynamic buffer creation and cleanup
Please post hours here but post history in the parent issue. Eric Faulhaber
10:07 PM Feature #2125 (Closed): add runtime support for dynamic buffer creation and cleanup
Eric Faulhaber

04/17/2013

06:21 PM Feature #1668: add support for additional (non-dynamic) database attributes
The attached update fixes conversion of the INITIAL buffer field attribute (was converting to operate on BUFFER handl... Eric Faulhaber
04:27 PM Feature #1580: upgrade Hibernate to latest level
> Hm...I'm not crazy about this as a solution.
I agree, I just needed to run regression testing ASAP.
I have ...
Stanislav Lomany
11:29 AM Feature #1580: upgrade Hibernate to latest level
Stanislav Lomany wrote:
> OK, I've added all P2J classes into p2jpl.jar. It seems that the problem has disappeared.
...
Eric Faulhaber
03:15 PM Feature #2115: add runtime support for _file and _field metadata tables
Proposed development approach:
* perform testing in note 5 to determine whether assumptions are correct;
* implemen...
Eric Faulhaber
02:53 PM Feature #2115: add runtime support for _file and _field metadata tables
As alluded to above, it appears that the metadata tables are the backing data store for many of the handle-based attr... Eric Faulhaber
02:11 PM Feature #2115: add runtime support for _file and _field metadata tables
We need a runtime facility to map between legacy (4GL) file/field names and converted (P2J) file/field names, for thi... Eric Faulhaber
01:57 PM Feature #2115: add runtime support for _file and _field metadata tables
Minimum fields we need to support in @_Field@ table due to customer use:
* _field-name
* _file-recid
* _label
* _...
Eric Faulhaber
01:04 PM Feature #2115: add runtime support for _file and _field metadata tables
Minimum fields we need to support in @_File@ table due to customer use:
* _file-name
* _dump-name
* _file-label
*...
Eric Faulhaber
07:41 AM Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130416a.zip/vmn_upd20130416b.zip as replacement of vmn_upd20130413a.zip/ vmn_upd20130... Vadim Nebogatov

04/16/2013

05:55 PM Feature #1580: upgrade Hibernate to latest level
OK, I've added all P2J classes into p2jpl.jar. It seems that the problem has disappeared. Stanislav Lomany
05:29 PM Feature #1580: upgrade Hibernate to latest level
Sorry, as the result the message changed to ... Stanislav Lomany
05:20 PM Feature #1580: upgrade Hibernate to latest level
I've reinstalled jar for the database on lightning I'm using - no result. Stanislav Lomany
04:50 PM Feature #1580: upgrade Hibernate to latest level
When you run dangerous_db_restore.sh to prepare for a new regression harness run, it installs p2jpl.jar in the new da... Eric Faulhaber
04:33 PM Feature #1580: upgrade Hibernate to latest level
Eric, "java.lang.NoClassDefFoundError: com/goldencode/p2j/net/SilentUnwindException" error occurs only on lightning s... Stanislav Lomany
09:15 PM Feature #1580: upgrade Hibernate to latest level
Stanislav Lomany wrote:
> ...
Eric Faulhaber
08:08 AM Bug #2083: client-side where-clause leak in FindQuery
Yes, my testcases converts fine. They are attached.
You can close the issue.
Ovidiu Maxiniuc
09:35 PM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> BTW, I have fixed one more problem with wrong field order in result (not included to last u...
Eric Faulhaber

04/15/2013

07:08 PM Feature #1580: upgrade Hibernate to latest level
Issue 0:
The first issue to fix, the log full of it: ...
Stanislav Lomany
06:03 PM Feature #1580: upgrade Hibernate to latest level
Issue 2:
Reproduction:
4 - C - Y - A
Enter data:
I
1029
Stacktrace:...
Stanislav Lomany
04:00 PM Feature #1580: upgrade Hibernate to latest level
Issue 1:
Reproduction:
V - O - 1 - W - 2
_Data to enter:_
283338
3.1.5
3.2.2
34000
35000
Stacktrace:
<pre...
Stanislav Lomany

04/13/2013

06:47 AM Feature #2080: add runtime support for database methods
BTW, I have fixed one more problem with wrong field order in result (not included to last update I sent). Now fields ... Vadim Nebogatov
06:38 AM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> I still think the field names are handled incorrectly. It happens to work in this case, beca...
Vadim Nebogatov

04/12/2013

06:39 PM Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130413a.zip/vmn_upd20130413b.zip as replacement of vmn_upd20130328a.zip/ vmn_upd20130... Vadim Nebogatov

04/11/2013

06:17 PM Feature #2080: add runtime support for database methods
vmn_upd20130411a.zip is fine. You can check it in and distribute it. It should have no risk to the conversion and s... Greg Shah
05:57 PM Feature #2080: add runtime support for database methods
Attached update vmn_upd20130411a.zip is replacement of vmn_upd20130409a.zip, merged with revision 10336
Vadim Nebogatov
05:50 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> I assume the appropriate @tt1@ record has to be referenced from a previous lookup, like FIND...
Vadim Nebogatov
05:44 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> Yes, it seems this is converting wrong. We should have another variant of @RecordBuffer.com...
Eric Faulhaber
05:26 PM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > Vadim Nebogatov wrote:
> > > Will P2J support @SAVE RESULT IN@ ...
Eric Faulhaber
02:50 PM Feature #2080: add runtime support for database methods
Greg Shah wrote:
> Code Review for vmn_upd20130409a.zip:
>
> 1. Please remove the recordOrDisplayError() variants...
Vadim Nebogatov
02:20 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > Will P2J support @SAVE RESULT IN@ option in @BUFFER-COMPARE@?
>...
Vadim Nebogatov
01:18 PM Feature #2080: add runtime support for database methods
Code Review for vmn_upd20130409a.zip:
1. Please remove the recordOrDisplayError() variants. It is too confusing t...
Greg Shah
10:07 AM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Will P2J support @SAVE RESULT IN@ option in @BUFFER-COMPARE@?
Yes, we need to support th...
Eric Faulhaber
02:43 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
In addition to the requirements in note 1, we will have to deal with the following:
* name conversion, to ensure tab...
Eric Faulhaber
01:11 PM Feature #2122: add runtime support for dynamically prepared temp-tables
This issue is meant to track hours for implementing runtime support. All history/discussion should be posted to the ... Eric Faulhaber
01:10 PM Feature #2122 (Closed): add runtime support for dynamically prepared temp-tables
Eric Faulhaber
12:47 PM Feature #1580: upgrade Hibernate to latest level
SO creation error was related to already solved boolean literal rendering issue, it turned out that one file was merg... Stanislav Lomany

04/10/2013

05:57 PM Feature #2080: add runtime support for database methods
Will P2J support @SAVE RESULT IN@ option in @BUFFER-COMPARE@? Vadim Nebogatov
03:34 PM Feature #1658: improve database trigger support
My estimates:
1. 3 h - Allow registration for WRITE and FIND schema triggers.
2. 16 h, need to find these proper ...
Stanislav Lomany
02:55 PM Feature #1658: improve database trigger support
What needs to be done:
1. Allow registration for WRITE and FIND schema triggers.
2. Fire WRITE and FIND triggers ...
Stanislav Lomany

04/09/2013

05:29 PM Feature #1580: upgrade Hibernate to latest level
@lib/hibernate3.jar@ and @lib/ehcache-1.1.jar@ should be removed. Stanislav Lomany
01:29 PM Feature #2120: add runtime support for dynamically prepared queries
A prototype will integrate limited conversion support into the runtime environment, such that given a set of buffers ... Eric Faulhaber
01:18 PM Feature #2120 (Closed): add runtime support for dynamically prepared queries
Eric Faulhaber
11:56 AM Bug #2034: correct conversion of CAN-FIND({FIRST|LAST} ... {SHARE-LOCK|EXCLUSIVE_LOCK} [NO-WAIT])
On second thought, as long as the sort phrase is correct, @hasAny@ will find the correct first or last record. So, r... Eric Faulhaber
10:58 AM Bug #2083: client-side where-clause leak in FindQuery
Ovidiu, I would like to close out this issue. Please confirm that the test case(s) you were using work correctly wit... Eric Faulhaber
05:11 AM Feature #2080: add runtime support for database methods
Greg, please check attached update vmn_upd20130409a.zip merged with revision 10336
I added method recordOrDisplayEr...
Vadim Nebogatov
10:36 PM Feature #2118 (Closed): add runtime support for _index and _index-field metadata tables
Eric Faulhaber
10:35 PM Feature #2117 (Closed): add runtime support for _lock metadata table
Eric Faulhaber
10:34 PM Feature #2116 (Closed): add runtime support for _user metadata table
Eric Faulhaber
10:33 PM Feature #2115 (Closed): add runtime support for _file and _field metadata tables
Eric Faulhaber

04/08/2013

06:21 PM Feature #2080: add runtime support for database methods
Vadim: please prepare a separate update with the ErrorManager related changes. I know you have ongoing work on the b... Greg Shah
09:53 AM Feature #2080: add runtime support for database methods
Constantin: I think that Vadim is trying to create an alternate version of ErrorManager.recordOrShowError() that does... Greg Shah
05:10 PM Feature #1580: upgrade Hibernate to latest level
Please post an update including your work so far, so I can begin reviewing. Eric Faulhaber
03:19 PM Feature #1580: upgrade Hibernate to latest level
At this point I'm aware of the single issue which occurs on SO creation. I'll run regression testing in order to reve... Stanislav Lomany
01:30 PM Feature #2092: add server-side database support for several builtin functions
commited to bzr as revision 10336 Costin Savin
01:22 PM Feature #2092: add server-side database support for several builtin functions
updated file header comments
Costin Savin
11:41 AM Feature #2092: add server-side database support for several builtin functions
The changes in cs_upd20130405b.zip (a superset of 0405a) look good. Please update the file header comments to reflec... Eric Faulhaber

04/06/2013

10:51 AM Feature #2080: add runtime support for database methods
To display a message, use the @LogicalTerminal.message@ API from the business logic (note that each message gets wrap... Constantin Asofiei

04/05/2013

06:08 PM Feature #2080: add runtime support for database methods
Constantin Asofiei wrote:
> For cases when ERROR condition is not raised but messages are still shown, the new @di...
Vadim Nebogatov
05:03 AM Feature #2080: add runtime support for database methods
> You described how to implement runtime behavior similar to 4GL in each concrete case. But my question was actually ... Constantin Asofiei
06:04 AM Feature #2092: add server-side database support for several builtin functions
chr also exist in postgress , renamed it to toChr, didn't find anything for the others. Costin Savin
04:47 AM Feature #2092: add server-side database support for several builtin functions
Added update Costin Savin
04:13 AM Feature #2092: add server-side database support for several builtin functions
It seems "replace" already is a function name in PostgreSql. I will replace "replace" with "replaceText" and search f... Costin Savin

04/04/2013

05:59 PM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> I have attached update vmn_upd20130401a.zip/vmn_upd20130401b.zip
> It contains @FETCH-SELE...
Eric Faulhaber
04:46 PM Feature #2080: add runtime support for database methods
You described how to implement runtime behavior similar to 4GL in each concrete case. But my question was actually no... Vadim Nebogatov
03:18 PM Feature #2080: add runtime support for database methods
> I still don't understand how ErrorManager will recognize what mode (silent or not) should be used. From examples I ... Constantin Asofiei
02:38 PM Feature #2080: add runtime support for database methods
Constantin Asofiei wrote:
> # add the new @ErrorManager.displayOrLogError@ API now, so you can use it for error mess...
Vadim Nebogatov

04/03/2013

01:16 PM Feature #2080: add runtime support for database methods
The Text.setTemporaryCaseSensitive (actually the entire class) is extracted from the character.java class. I don't th... Constantin Asofiei
08:23 AM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> * Please re-read the JavaDoc for @Text.setTemporaryCaseSensitive@. I'm not sure it was meant...
Vadim Nebogatov
07:17 AM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Constantin Asofiei wrote:
>
> > Again, the testcase does not help us in determining the ...
Constantin Asofiei
06:13 AM Feature #2080: add runtime support for database methods
Constantin Asofiei wrote:
> Again, the testcase does not help us in determining the NO-ERROR behavior, as a runtime ...
Vadim Nebogatov

04/02/2013

12:48 PM Feature #2080: add runtime support for database methods
> > *class Date, line 1435* - note 70
> Should I fix it directly in CVS without sending special update and regressio...
Constantin Asofiei
12:19 PM Feature #2080: add runtime support for database methods
Constantin Asofiei wrote:
> Please edit each case and add the value of the ERROR:NUM-MESSAGES attribute (you can add ...
Vadim Nebogatov

04/01/2013

05:58 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> Code review 20130328a:
>
> * Why have you commented out the re-throwing of the @reason@ T...
Vadim Nebogatov
04:41 PM Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130401a.zip/vmn_upd20130401b.zip
It contains @FETCH-SELECTED-ROW()@ conversion, usin...
Vadim Nebogatov
11:46 AM Feature #2080: add runtime support for database methods
Please edit each case and add the value of the ERROR:NUM-MESSAGES attribute (you can add it in the same MESSAGE line ... Constantin Asofiei

03/31/2013

05:36 PM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Duding testing I have found out that @FETCH-SELECTED-ROW()@ conversion requires @BrowseWidg...
Eric Faulhaber
05:35 PM Feature #2080: add runtime support for database methods
Code review 20130328a:
* Why have you commented out the re-throwing of the @reason@ Throwable in @BlockManager.pro...
Eric Faulhaber

03/30/2013

06:45 AM Feature #2080: add runtime support for database methods

*class <Not found in code>*
Example:...
Vadim Nebogatov
06:42 AM Feature #2080: add runtime support for database methods
*class <Not found in code>*
Example:...
Vadim Nebogatov
06:40 AM Feature #2080: add runtime support for database methods
*class <Not found in code>*
Example:...
Vadim Nebogatov
06:37 AM Feature #2080: add runtime support for database methods
*class ControlFlowOps, line 3519*
Example:...
Vadim Nebogatov
05:57 AM Feature #2080: add runtime support for database methods
Moved to #2106, note 2
*class <Not found in code>*
Example:...
Vadim Nebogatov
05:43 AM Feature #2080: add runtime support for database methods
Moved to #2106, note 1
*class <Not found in code>*
Example:...
Vadim Nebogatov
05:29 AM Feature #2080: add runtime support for database methods
this note should be ignored according note 85
*class HandleOps, line 67*
Example:...
Vadim Nebogatov
05:24 AM Feature #2080: add runtime support for database methods
*class handle, line 254*
Example:...
Vadim Nebogatov
05:18 AM Feature #2080: add runtime support for database methods
Moved from #2080, notes 3,4
*class BrowseWidget, line 751*
Example:...
Vadim Nebogatov
04:59 AM Feature #2080: add runtime support for database methods
*class NumberType, line 3189*
Example:...
Vadim Nebogatov
04:55 AM Feature #2080: add runtime support for database methods
*class ControlFlowOps, line 3577*
Example:...
Vadim Nebogatov
04:36 AM Feature #2080: add runtime support for database methods
*class ControlFlowOps, line 2991*
Example:...
Vadim Nebogatov

03/29/2013

05:32 PM Feature #2080: add runtime support for database methods
*class Date, line 1435*
Example:...
Vadim Nebogatov
04:48 PM Feature #2080: add runtime support for database methods
In regard to the use of an .odt document for reporting information about the errors, I prefer that you put the inform... Greg Shah
01:44 PM Feature #2080: add runtime support for database methods
I have found also that @SESSION:TIMEZONE@ is not supported (but mentioned in code).
Example is ...
Vadim Nebogatov
12:43 PM Bug #2093 (Closed): VALEXP support in P2J
Eric Faulhaber
12:42 PM Bug #2093: VALEXP support in P2J
At this moment, with the exception of the cases where the expression from the string condition is not valid, I don't ... Ovidiu Maxiniuc
10:36 AM Bug #2093: VALEXP support in P2J
Is there anything left to do on this issue or can it be closed? Eric Faulhaber
10:26 AM Bug #2095 (Closed): FIELDS/EXCEPT record phrase options not honored
Eric Faulhaber
09:43 AM Bug #2097 (Closed): FOR EACH with multiple, nested CAN-FINDs converts badly
The fix has addressed the original problem and does not appear to have regressed anything else in the customer's serv... Eric Faulhaber
09:19 AM Bug #2094 (Closed): OUTER-JOIN record phrase option not honored
Eric Faulhaber

03/28/2013

06:59 PM Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130328a.zip/vmn_upd20130328b.zip as replacement of vmn_upd20130326a.zip/ vmn_upd20130... Vadim Nebogatov
06:23 PM Feature #2080: add runtime support for database methods
Eric, sorry for so dangerous RecordBuffer.java. I think it was wrong bazaar merge with latest bzr revision. I do not ... Vadim Nebogatov
05:10 PM Feature #2080: add runtime support for database methods
Document with tests is updated Vadim Nebogatov
03:56 PM Feature #2080: add runtime support for database methods
Regarding vmn_upd20130326a.zip: there are hundreds of unnecessary/unwanted format changes in RecordBuffer, which mak... Eric Faulhaber
01:07 PM Feature #2080: add runtime support for database methods
Duding testing I have found out that @FETCH-SELECTED-ROW()@ conversion requires @BrowseWidget.fetchSelectedRow()@ wit... Vadim Nebogatov

03/27/2013

06:22 PM Feature #2080: add runtime support for database methods
I have attached some first test cases. Is such format would be ok?
Please notice that I found also some cases that ...
Vadim Nebogatov
03:17 PM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
The update has passed conversion regression testing and is committed to bzr rev. 10333. Eric Faulhaber
02:20 PM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
A fix candidate is attached. Currently running it through conversion regression testing. Eric Faulhaber

03/26/2013

05:22 PM Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130326a.zip/ vmn_upd20130326b.zip
with current state of BUFFER-COPY() and BUFFER-COM...
Vadim Nebogatov
09:58 AM Feature #2080: add runtime support for database methods
I want to resolve this properly as part of this work. This includes any cases of ErrorManager.displayError() that sh... Greg Shah
03:23 PM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Ovidiu Maxiniuc wrote:
> ...but I wonder if we shouldn't treat the first @each person@ the same like @each w-person@...
Eric Faulhaber
09:57 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
I understand. The algorithm is working in fact if you analyze the first clause that works.
And starting from here, I...
Ovidiu Maxiniuc
09:31 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Ovidiu Maxiniuc wrote:
> The reason why the where clause filtered to client-side is probably the @where_clause_prep2...
Eric Faulhaber
04:44 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
The reason why the where clause filtered to client-side is probably the @where_clause_prep2.rules@. You can read in i... Ovidiu Maxiniuc
02:53 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
I have isolated the #2068 note 272 regression like this:... Constantin Asofiei

03/25/2013

04:31 PM Bug #2097 (Review): FOR EACH with multiple, nested CAN-FINDs converts badly
The ecf_upd20130325e.zip update (finally) has passed conversion regression testing; there are some differences in th... Eric Faulhaber
03:56 PM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Hopefully the final candidate; conversion regression testing it now. Eric Faulhaber
01:39 PM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Another candidate, in conversion regression testing now. Eric Faulhaber
09:49 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
While there are a number of expected differences, there are also still some regressions, though far fewer than the la... Eric Faulhaber
05:37 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Fix candidate for regressions. Testing now. Eric Faulhaber
04:53 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
This update regresses many files in Majic; cannot check it in. Eric Faulhaber
03:59 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Missed a bit of cleanup in one of the files. Eric Faulhaber
03:48 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
A fix candidate and test cases are attached. I am currently putting the fix through conversion regression testing. ... Eric Faulhaber
03:58 PM Feature #2080: add runtime support for database methods
OK, I forgot that the ERROR attribute is set for error conditions raised when the NO-ERROR clause is used (this expla... Constantin Asofiei
03:30 PM Feature #2080: add runtime support for database methods
Constantin,
I have removed @SESSION:SUPPRESS-WARNINGS = YES.@ and started from command line. But it did not affect ...
Vadim Nebogatov
05:42 AM Feature #2080: add runtime support for database methods
I do not understand which line of code generates the 9039 and 12860 messages. Please remove the @SESSION:SUPPRESS-WAR... Constantin Asofiei
01:01 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
The current fix doesn't work for all cases, e.g.:
1. REPEAT PRESELECT.
2. DEFINE QUERY.
Note that FIELDS/EXCEP...
Stanislav Lomany
11:42 PM Bug #2095 (Review): FIELDS/EXCEPT record phrase options not honored
The update has passed conversion regression testing and I have committed it to bzr rev. 10329. Eric Faulhaber
10:43 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
The update looks good to me. I am running conversion regression testing on it now. Eric Faulhaber
08:00 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
Fixes the cases specified in note #2. Probably fixes all other cases too. Stanislav Lomany

03/24/2013

05:33 PM Bug #2101 (Closed): multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not c...
I've compared conversions of the customer's server project with and without this fix and it seems correct in all the ... Eric Faulhaber
09:46 PM Bug #2101 (Review): multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not c...
Update ecf_upd20130323a.zip has passed conversion regression testing and is committed to bzr rev. 10325. Eric Faulhaber
08:23 PM Bug #2101: multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not converting...
Although I'm not the assignee, in having to think through the problem for the above post, I took a quick look at the ... Eric Faulhaber
05:27 PM Bug #2094: OUTER-JOIN record phrase option not honored
BTW, location of the original problem is pmplan/gapptfn5.p.cache, line 700. Eric Faulhaber
05:25 PM Bug #2094 (Review): OUTER-JOIN record phrase option not honored
Passed conversion regression testing, committed to bzr revision 10328. I'll do a separate server folder conversion wi... Constantin Asofiei
05:03 PM Bug #2094: OUTER-JOIN record phrase option not honored
Change looks good to me. Please check in and distribute if/when it passes conversion regression testing. Eric Faulhaber
04:04 PM Bug #2094 (WIP): OUTER-JOIN record phrase option not honored
Constantin Asofiei
03:47 PM Bug #2094: OUTER-JOIN record phrase option not honored
Properly handles the @OUTER-JOIN@ and @LEFT OUTER-JOIN@ to convert the same. Constantin Asofiei
03:37 PM Bug #2094: OUTER-JOIN record phrase option not honored
This update adds support for the OUTER-JOIN clause for a record phrase. -The LEFT OUTER-JOIN will not emit anything.-... Constantin Asofiei
10:09 PM Bug #2094: OUTER-JOIN record phrase option not honored
The following:... Eric Faulhaber
05:10 PM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
I'm working toward what I think the correct conversion would be:... Eric Faulhaber
04:29 PM Feature #2080: add runtime support for database methods
Constantin, I use ErrorManager.recordOrThrowError.
In my example above, 4GL meets errors 9039 and 12860 with differ...
Vadim Nebogatov
07:29 AM Feature #2080: add runtime support for database methods
PS: about @SESSION:SUPPRESS-WARNINGS = YES.@. Note that in the 4GL editor, if you run a program which doesn't set the... Constantin Asofiei
07:26 AM Feature #2080: add runtime support for database methods
> Another observation. Not all 4GL errors throw “exceptions”, some of them look like not critical errors or warnings,... Constantin Asofiei
07:20 AM Feature #2080: add runtime support for database methods
Another observation. Not all 4GL errors throw “exceptions”, some of them look like not critical errors or warnings, e... Vadim Nebogatov
03:53 AM Feature #2080: add runtime support for database methods
> Conversion code should also support this option, returning value if ON-ERROR is set (current behaviour) and propaga... Constantin Asofiei
03:51 AM Feature #2080: add runtime support for database methods
Constantin: yes, it is just switch in behavior I was looking.
Conversion code should also support this option, retur...
Vadim Nebogatov
03:07 AM Feature #2080: add runtime support for database methods
Eric/Vadim: there is another way to supress the 4GL's errors, the @NO-ERROR@ clause. When trying to understand when a... Constantin Asofiei
02:02 AM Feature #2080: add runtime support for database methods
Yes, I also think so. Return value has no sense if 4gl propagates its "exceptions". I only thought that maybe this pr... Vadim Nebogatov
09:26 PM Feature #2080: add runtime support for database methods
This indicates that the idiom of:... Eric Faulhaber
10:11 PM Bug #2084 (Closed): Conversion misplaced parameter for can-find statement
Eric Faulhaber
10:10 PM Feature #2000 (Closed): add conversion support for table and table handle parameters
Eric Faulhaber
09:49 PM Feature #2092 (Closed): add server-side database support for several builtin functions
Eric Faulhaber

03/23/2013

06:54 PM Feature #1668: add support for additional (non-dynamic) database attributes
This update has passed conversion regression testing (CA 0323d used deleteRecord for the "quick_delete" loops, instea... Constantin Asofiei
12:58 PM Feature #1668: add support for additional (non-dynamic) database attributes
ca_upd20130323d.zip update looks good to me. If it passes conversion regression testing (expect some changes to Maji... Eric Faulhaber
12:52 PM Feature #1668: add support for additional (non-dynamic) database attributes
Replaces ca_upd2013023a.zip, and has the changes from note 105. Constantin Asofiei
12:33 PM Feature #1668: add support for additional (non-dynamic) database attributes
You are not missing anything, this is the first time I touch embedded sqls, so that's why the questions. Now I have a... Constantin Asofiei
12:30 PM Feature #1668: add support for additional (non-dynamic) database attributes
This refers to:... Eric Faulhaber
12:23 PM Feature #1668: add support for additional (non-dynamic) database attributes
For embedded SQL, I was referring to this rule in convert/database_access:... Constantin Asofiei
12:19 PM Feature #1668: add support for additional (non-dynamic) database attributes
Let's use:... Eric Faulhaber
11:38 AM Feature #1668: add support for additional (non-dynamic) database attributes
Eric: the ca_upd20130323a.zip has regressions. I see that the Buffer.delete API is used by other cases, like DELETE s... Constantin Asofiei
10:23 AM Feature #1668: add support for additional (non-dynamic) database attributes
This update changes the API for BUFFER-DELETE to deleteRecord, because else will collide with the resource's delete()... Constantin Asofiei
06:53 PM Feature #2080: add runtime support for database methods
Also I have noticed the difference in behavior of 4GL and converted code.
I am comparing a lot of tests in the form...
Vadim Nebogatov
06:50 PM Bug #2101: multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not converting...
This issue was first reported in note 192 of #2068.
The following converts badly:...
Eric Faulhaber
06:34 PM Bug #2101 (Closed): multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not c...
Eric Faulhaber

03/22/2013

05:38 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
> I still think the include/exclude call should directly follow the associated addComponent call. I think it is easie... Stanislav Lomany
05:31 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
I guess there's one more option; chain the call, as in:... Eric Faulhaber
05:04 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
So if the full list of options is:
1. Add the list of fields to query c'tor / addComponent
2. include(String ...) -...
Stanislav Lomany
04:34 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
Stanislav Lomany wrote:
> For a multi-table query the buffer should be specified, but as an option we can have quali...
Eric Faulhaber
04:28 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
For a multi-table query the buffer should be specified, but as an option we can have qualified field names:... Stanislav Lomany
03:32 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
OK, but please emit this method immediately after the associated @addComponent@ call.
> ...
Eric Faulhaber
03:07 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
Unless someone has objections, for multi-component queries, I'll make include/exclude methods of the parent query:
<...
Stanislav Lomany
11:42 AM Bug #2095: FIELDS/EXCEPT record phrase options not honored
> Removes FIELDS/EXCEPT nodes.
Thanks, I'm starting server folder conversion, hope nothing new will appear.
Constantin Asofiei
11:36 AM Bug #2095: FIELDS/EXCEPT record phrase options not honored
Removes FIELDS/EXCEPT nodes. Stanislav Lomany
10:38 AM Bug #2095: FIELDS/EXCEPT record phrase options not honored
OK Stanislav Lomany
10:14 AM Bug #2095: FIELDS/EXCEPT record phrase options not honored
Stanislav: if it doesn't take you long to build some rules which just drop/hide the FIELDS/EXCEPT nodes (so they will... Constantin Asofiei
02:32 PM Feature #1668: add support for additional (non-dynamic) database attributes
Costin Savin wrote:
> Well theoreticaly it is already there because both Buffer and TempTable extend it, but probabl...
Constantin Asofiei
02:32 PM Feature #1668: add support for additional (non-dynamic) database attributes
Well theoreticaly it is already there because both Buffer and TempTable extend it, but probably it's good to see it i... Costin Savin
02:12 PM Feature #1668: add support for additional (non-dynamic) database attributes
Costin, regarding cs_upd20130322b.zip - you forgot to add the new interface to HandleCommon. Please put it right afte... Constantin Asofiei
01:43 PM Feature #1668: add support for additional (non-dynamic) database attributes
Commited as revision number 10317 Costin Savin
01:07 PM Feature #1668: add support for additional (non-dynamic) database attributes
cs_upd20130322b.zip has passed conversion regression testing. Please check it in and distribute. Eric Faulhaber
10:54 AM Feature #1668: add support for additional (non-dynamic) database attributes
cs_upd20130322b.zip looks good. I am putting it through conversion regression testing.
It does look like we still...
Eric Faulhaber
08:21 AM Feature #1668: add support for additional (non-dynamic) database attributes
Added proposed update for missing addFieldToIndex methods. Moved the defaultBufferHandle() method form the Buffer int... Costin Savin
05:06 AM Feature #1668: add support for additional (non-dynamic) database attributes
This class evolved a little. The @defaultBufferHandle()@ (implementation of @DEFAULT-BUFFER-HANDLE@) was at the begin... Ovidiu Maxiniuc
04:35 AM Feature #1668: add support for additional (non-dynamic) database attributes
> ADMData was my mistake (should have not added it, as I don't see the ADM-DATA attribute defined for the temp-table ... Constantin Asofiei
02:15 PM Feature #2080: add runtime support for database methods
I have noticed from testing in 4GL that error message... Vadim Nebogatov
10:46 AM Feature #1947: add conversion support for database methods
CA 0322c.zip was committed to bzr revision 10315 and CA 0322e.zip to 10316. Constantin Asofiei
10:40 AM Feature #1947: add conversion support for database methods
Both updates look good, please check them in. Eric Faulhaber
09:30 AM Feature #1947: add conversion support for database methods
Both 0322c.zip and 0322e.zip have passed conversion regression testing. Constantin Asofiei
07:42 AM Feature #1947: add conversion support for database methods
Adds missing @queryRows(integer)@ API. Constantin Asofiei
06:49 AM Feature #1947: add conversion support for database methods
Solved note 151 by always expanding array vars passed to the REPOSITION-TO-ROWID method. This avoids adding an @query... Constantin Asofiei
06:06 AM Feature #1947: add conversion support for database methods
I'm working on note 151. Constantin Asofiei
05:23 AM Feature #1947: add conversion support for database methods
See note 202 from #2068, which documents a server failure. Note that the @REPOSITION-TO-ROWID@ can accept mixed exten... Constantin Asofiei
10:24 AM Feature #2000: add conversion support for table and table handle parameters
ca_upd20130322g.zip committed to bzr revision 10214. Constantin Asofiei
09:15 AM Feature #2000: add conversion support for table and table handle parameters
The code looks fine. If it passes testing, check it in and distribute it. Greg Shah
09:11 AM Feature #2000: add conversion support for table and table handle parameters
Fixes a regression in the TABLE-HANDLE parameter conversion, introduced by 10293. Constantin Asofiei
08:55 AM Feature #2000: add conversion support for table and table handle parameters
OK, I'll look at it. Constantin Asofiei
08:15 AM Feature #2000: add conversion support for table and table handle parameters
It has been regressed since revision 10279.
Correct output is:...
Stanislav Lomany
07:38 AM Feature #2000: add conversion support for table and table handle parameters
Stanislav: did this convert properly after you added TABLE-HANDLE parameter support?... Constantin Asofiei
08:18 AM Feature #2092: add server-side database support for several builtin functions
Go ahead and check this in immediately (and distribute it). It has no effect on conversion and it is already being r... Greg Shah
07:07 AM Feature #2092: add server-side database support for several builtin functions
Removed the extra ' character from p2jpl.ddr at line 699 Costin Savin
 

Also available in: Atom