Activity
From 11/22/2020 to 12/21/2020
12/21/2020
- 02:30 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Igor, is there a way I can test this new word index implementation, without having to re-con... - 02:14 PM Feature #1587: implement full support for word indexes
- Igor, is there a way I can test this new word index implementation, without having to re-convert a large application?...
- 08:13 AM Feature #1587: implement full support for word indexes
- Branch 1587b was rebased to 3831c revision 11884. Pushed up to revision 11898.
- 11:43 AM Support #3871: determine how to change codepages/locales during import
- Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Constantin, do you remember what was going wrong with this se... - 11:37 AM Support #3871: determine how to change codepages/locales during import
- Eric Faulhaber wrote:
> Constantin, do you remember what was going wrong with this setting? I recall that you report... - 11:31 AM Support #3871: determine how to change codepages/locales during import
- Igor Skornyakov wrote:
> BTW: I think we can speed up the import if we will use @PreparedStatement.addBatch@ and @... - 07:59 AM Support #3871: determine how to change codepages/locales during import
- Greg Shah wrote:
> OK, I understand. We need Eric to complete the code review of #1587 first.
Got it, thank you. - 07:57 AM Support #3871: determine how to change codepages/locales during import
- OK, I understand. We need Eric to complete the code review of #1587 first.
- 07:44 AM Support #3871: determine how to change codepages/locales during import
- Greg Shah wrote:
> I prefer for these changes to go into 3821c directly. Is there a reason they need to be build on... - 07:22 AM Support #3871: determine how to change codepages/locales during import
- I prefer for these changes to go into 3821c directly. Is there a reason they need to be build on top of 1587b?
12/20/2020
- 12:14 PM Support #3871: determine how to change codepages/locales during import
- Implemented @CPSTREAM@ support on import.
Committed to 1587b rev 11873.
Re-working of the word tables' import is st...
12/18/2020
- 01:14 PM Support #3871: determine how to change codepages/locales during import
- Yes, go ahead.
- 10:59 AM Support #3871: determine how to change codepages/locales during import
- Since I have to get familiar with import, maybe be I will add the population of the word tables with postponed creati...
12/17/2020
- 04:07 PM Support #3871: determine how to change codepages/locales during import
- > I think I've seen that for some .d files the import reports that the footer was not found. In this case we can eith...
- 03:57 PM Support #3871: determine how to change codepages/locales during import
- Greg Shah wrote:
> I think that honoring that value is the easist way to implement my approach. We have to have tha... - 03:47 PM Support #3871: determine how to change codepages/locales during import
- I think that honoring that value is the easist way to implement my approach. We have to have that value as input. W...
- 03:38 PM Support #3871: determine how to change codepages/locales during import
- Greg Shah wrote:
> > However, at this moment I do not see how the CPSTRIM value is used in the ImportWorker. It is u... - 03:31 PM Support #3871: determine how to change codepages/locales during import
- > However, at this moment I do not see how the CPSTRIM value is used in the ImportWorker. It is used in the creation ...
- 02:38 PM Support #3871: determine how to change codepages/locales during import
- Greg Shah wrote:
> * We use our 4GL compatible stream processing to read the encoded @.d@ files during import. Thes... - 02:10 PM Support #3871: determine how to change codepages/locales during import
- * We use our 4GL compatible stream processing to read the encoded @.d@ files during import. These are the @com.golde...
- 01:20 PM Support #3871: determine how to change codepages/locales during import
- Sorry, I'm confused. In my understanding, all we need is to use @CODEPAGE-CONVERT@ with @UTF-8@ as the target codepag...
12/16/2020
- 02:37 PM Feature #4055: optimize temp-table output parameter copying
- Committed in 3821c/rev. 11881 support for fast loose-copy. Done some testing and it seems that loose-copy-mode now se...
12/15/2020
- 01:57 PM Feature #4055: optimize temp-table output parameter copying
- Ovidiu Maxiniuc wrote:
> Yes, this is exactly the scenario where I encountered the issue. However, I am not familiar... - 12:24 PM Feature #4055: optimize temp-table output parameter copying
- Please note: currently, the work of record initialization to default values is done in @BaseRecord.initialize@, which...
- 09:54 AM Feature #4055: optimize temp-table output parameter copying
- Adrian Lungu wrote:
> Ovidiu, I see the problem. This can be appear only when @loose-copy-mode@ is on (so we have a ... - 05:58 AM Feature #4055: optimize temp-table output parameter copying
- Ovidiu, I see the problem. This can be appear only when @loose-copy-mode@ is on (so we have a possible restricted fie...
- 08:54 PM Feature #4055: optimize temp-table output parameter copying
- There is a flaw in @FastCopyHelper.java@: when a copy operation is executed using a restricted field mapping, the unm...
12/10/2020
- 01:37 PM Feature #1587: implement full support for word indexes
- I've finally decided to augment @MetadataManager@ with word tables support. So the implementation for PostgreSQL is e...
- 05:53 AM Feature #1587: implement full support for word indexes
- Branch 1587b was rebased to 3821c revision 11860.
Pushed up to revision 11870. - 05:47 AM Feature #1587: implement full support for word indexes
- Short names' generation committed to 1587b revision 11849.
Working on using generated names in @FqlToSqlConverter@ - 12:57 PM Bug #5030: xfer dataset test issues
- Ovidiu Maxiniuc wrote:
> > [[https://documentation.progress.com/output/ua/OpenEdge_latest]]
> Yes, that's it. I t... - 12:16 PM Bug #5030: xfer dataset test issues
- Marian Edu wrote:
> > BTW, is there a public documentation on OE 12.X? I could not find it, I am always redirected t... - 08:53 AM Bug #5030: xfer dataset test issues
- > I am a pit puzzled now. What is our OE version target to match? Will we support multiple versions? I know there was...
- 02:46 AM Bug #5030: xfer dataset test issues
- Ovidiu Maxiniuc wrote:
> Marian Edu wrote:
> > Well, nothing is perfect... in practice no one it doing that though ... - 11:13 AM Feature #3958: BUFFER-COPY optimization
- I committed 3821c/rev. 11862 changes to @DMOSignatureHelper@ which can now compute explicit signatures. The modificat...
12/09/2020
- 06:39 PM Bug #5030 (WIP): xfer dataset test issues
- I have another issue. In @dataset/dynamic/methods/copy_dataset.p@ we have:...
- 06:09 PM Bug #5030: xfer dataset test issues
- Marian Edu wrote:
> Well, nothing is perfect... in practice no one it doing that though so I wouldn't make it such a... - 03:48 AM Bug #5030: xfer dataset test issues
- Ovidiu Maxiniuc wrote:
> Here is one example I used for observing the @REPOSITION@ attribute:
> [...]
>
> This w... - 07:40 PM Bug #5030: xfer dataset test issues
- Marian Edu wrote:
> The @AUTO-DELETE@ attribute only has a role when a dynamic dataset is deleted, nothing to do wit... - 07:37 PM Bug #5030: xfer dataset test issues
- Here is one example I used for observing the @REPOSITION@ attribute:...
- 03:24 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> What about the Java annotation in the DMO interface? My point is, I just want one name store... - 03:21 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > Please do make the change. Even if we don't simplify the logic m... - 03:05 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Please do make the change. Even if we don't simplify the logic much, we want to keep the con... - 03:01 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> If I understand correctly, you need to map the DMOs (@DmoMeta@ most likely) using SQL names... - 02:59 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> At this moment I do not use the _least-common-denominator approach for the names_, but it c... - 02:56 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> I thought we use the _least-common-denominator approach for the names_ (see Eric's entry #1... - 02:41 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> Well, I think I've found a 'right' place to add information about word table names (there c... - 02:32 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> I see the following problem with this approach. I understand that @NameConverterWorker@ is ... - 02:20 PM Feature #1587: implement full support for word indexes
- Well, I think I've found a 'right' place to add information about word table names (there can be different names for ...
- 05:29 AM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> Yes, the information is mainly correct. I would look back one step, looking for the @name.c... - 04:15 AM Feature #3958: BUFFER-COPY optimization
- Added a new signature for each @DmoMeta@ - see #4055-80, #4055-81. The first one I will refer to as "quick signature"...
12/08/2020
- 05:10 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> Yes, the information is mainly correct. I would look back one step, looking for the @name.c... - 05:01 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Ovidiu: please reality check my statements and file references above, in case my recollectio... - 04:58 AM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> OK, I think this is the place the Java annotations are actually written into the Java AST wh... - 02:44 AM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > See the @createCompileUnit@ TRPL function in @rules/schema/dmo_c... - 02:35 AM Bug #5030: xfer dataset test issues
- Ovidiu Maxiniuc wrote:
> A second issue is related to recently added @AUTO-DELETE@ attribute. I am see why is an aut... - 02:17 AM Bug #5030: xfer dataset test issues
- Ovidiu Maxiniuc wrote:
> A first question is about the dataset relations. Normally, there can be at most @n - 1@ ins... - 07:42 PM Feature #4397: add database attrs, methods and options
- I encountered two more issues which were probably added with 4011 and slipped unnoticed until now.
* the first is ...
12/07/2020
- 05:21 PM Bug #5030: xfer dataset test issues
- A second issue is related to recently added @AUTO-DELETE@ attribute. I am see why is an auto-delete dynamic buffer no...
- 04:40 PM Bug #5030: xfer dataset test issues
- A first question is about the dataset relations. Normally, there can be at most @n - 1@ instances of them, but if som...
- 04:23 PM Bug #5030: xfer dataset test issues
- I have started recently to run the testsets stored on xref repository in order to fine-tune the dataset-related attri...
- 04:00 PM Bug #5030 (WIP): xfer dataset test issues
- 04:58 PM Bug #5013 (Test): Collision of java names with SQL keywords
- 03:35 PM Bug #5013: Collision of java names with SQL keywords
- This issue should be fixed in r11866/4397a (11/26/20).
- 02:35 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> See the @createCompileUnit@ TRPL function in @rules/schema/dmo_common.rules@ for examples of... - 02:33 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> The problem is that at this moment I do not understand how to add annotation from the @DDLG... - 01:49 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Ovidiu, please look at @dmo_common.rules@. Based on Igor's change, it looks like we were omi... - 02:42 AM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> For things like this, we usually compute the value at schema conversion time and write it as... - 11:36 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> I've re-worked the code to address Eric's comments (#1587-128).
> There is a problem with ...
12/06/2020
- 03:38 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> I've re-worked the code to address Eric's comments (#1587-128).
Committed to 1587b revisio... - 03:37 PM Feature #1587: implement full support for word indexes
- I've re-worked the code to address Eric's comments (#1587-128).
There is a problem with renaming word tables - we n... - 02:58 AM Feature #1587: implement full support for word indexes
- Sorry, I forgot to add. At this moment for the dialects other than PostgreSQL the @CONTIANS@ UDF will be still used.
- 02:51 AM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> * I am a bit confused by the @words@ UDF. It is added as a PL/Java function in @Functions@ a...
12/05/2020
- 05:26 PM Feature #1587: implement full support for word indexes
- Overall, 1587b seems to be nice addition to the project! This is not a full code review, but I do have a few concerns...
12/04/2020
- 02:20 PM Feature #1665 (Closed): automate import process
- This issue has been superseded by #4723.
- 02:17 PM Feature #1664: data import improvements
- Note that as of FWD trunk rev 11348, Hibernate is no longer used. As such, the Hibernate-specific issues noted above ...
- 02:09 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
- IIRC, the @data/namespace@ dependency was just for access to the application's generated @*.p2o@ XML file, which alre...
12/03/2020
- 04:29 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> Maybe it makes sense to add an import option to control when to create these indexes?
Why... - 04:20 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> True. Since this worked well with Hibernate I kept it with new proprietary solution. Also, ... - 03:59 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> The reason we create the primary keys and the foreign keys before import is primarily histor... - 03:49 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Yes, and all unique indices as well. Non-unique indices are created after the import of a ta... - 03:46 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> BTW: If I understand correctly, we create primary keys and foreign key indexes (for extent ... - 03:14 PM Feature #1587: implement full support for word indexes
- BTW: If I understand correctly, we create primary keys and foreign key indexes (for extent tables) before the import....
- 03:09 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Other than working out the name length issue discussed in the previous posting, are there an... - 02:20 PM Feature #1587: implement full support for word indexes
- Igor, I'm beginning to look over 1587b/11847.
Other than working out the name length issue discussed in the previo... - 08:14 AM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> My point is that we should not require manual intervention in order to convert something that jus... - 08:05 AM Feature #1587: implement full support for word indexes
- My point is that we should not require manual intervention in order to convert something that just happens to exceed ...
- 07:56 AM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> > Please note that the generated objects' renaming via hints is not yet implemented. Working on i... - 07:50 AM Feature #1587: implement full support for word indexes
- > Please note that the generated objects' renaming via hints is not yet implemented. Working on it now. We really nee...
- 07:36 AM Feature #1587: implement full support for word indexes
- Finished generation of the database objects for the word indexes' support for the PostgreSQL dialect.
Committed to 1... - 03:03 PM Bug #4173: BUFFER-COPY/BUFFER-COMPARE compares table fields by name rather than data type and order
- This seems related to your current work. It may make sense to implement any changes needed to resolve this task alon...
- 11:40 AM Feature #4055: optimize temp-table output parameter copying
- I committed the changes proposed in #4055-82 regarding append mode support as 3821c/rev. 11851. These were build over...
11/30/2020
- 04:15 PM Feature #4397: add database attrs, methods and options
- I encountered the following issue with conversion. It is not mandatory related to datasets but I encountered it while...
- 08:03 AM Feature #1587: implement full support for word indexes
- Here is another point to consider.
We must avoid adding extra files to the deployment requirements for the FWD ser...
11/27/2020
- 05:37 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Are there real cases of the converted names exceeding the PostgreSQL-imposed limits, or do l... - 04:53 PM Feature #1587: implement full support for word indexes
- Are there real cases of the converted names exceeding the PostgreSQL-imposed limits, or do limits also exist in the 4...
- 03:47 PM Feature #1587: implement full support for word indexes
- As we discussed before (#1587-65) we may have to use hints for the names of the database objects associated with word...
- 03:10 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> I see another problem with this. Because of the *synchronized* block in the @Persistence.Co... - 11:32 AM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> Review of 1587b/r11844.
>
> General note: I like the amount of effort put in obtaining t... - 09:46 AM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> Review of 1587b/r11844.
>
> General note: I like the amount of effort put in obtaining t... - 09:40 AM Feature #1587: implement full support for word indexes
- Review of 1587b/r11844.
General note: I like the amount of effort put in obtaining the conjunctive form of the fin... - 11:45 AM Feature #4055: optimize temp-table output parameter copying
- I am planning to tackle the @append@ mode for @copy-temp-table@ with fast-copy. Right now, the fast-copy implementati...
11/26/2020
- 02:18 PM Feature #1587: implement full support for word indexes
- Branch 1587b was rebased to 3821c revision 11839.
Committed revision 11844.
- 02:07 PM Feature #1587: implement full support for word indexes
- I've implemented the fix that doesn't allow re-use of cached but re-written queries. This fixes the issue with the qu...
- 01:25 PM Feature #1587: implement full support for word indexes
- Well, the re-written query parameters are overridden in the @Persistence.getQuery()@. The query is retrieved from the...
- 12:29 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> At first look the queries look OK to me, nice work!
>
> The queries will try to fetch ro... - 12:20 PM Feature #1587: implement full support for word indexes
- At first look the queries look OK to me, nice work!
The queries will try to fetch rows incrementally, in increasin... - 10:08 AM Feature #1587: implement full support for word indexes
- One more example.
Consider the 4GL program:... - 08:46 AM Feature #1587: implement full support for word indexes
- In addition to the previous note. Without @CONTAINS@ re-writing the PostgreSQL log looks like the following:...
- 08:17 AM Feature #1587: implement full support for word indexes
- I've finished the @CONTAINS@ UDF call re-writing as per Ovidiu's advice.
Committed to 1587b revision 11835.
However... - 12:26 PM Feature #4055: optimize temp-table output parameter copying
- I committed some changes for signature building and matching to 3821c/rev. 11839:
* *Enhanced unique constraints c...
11/25/2020
- 08:24 AM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> I understand. But we are optimizing performance here and we will spend extra development time an... - 08:18 AM Feature #1587: implement full support for word indexes
- I understand. But we are optimizing performance here and we will spend extra development time and make conversion le...
- 07:12 AM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> > Well, since we decided do not to touch conversion at this moment
>
> I think you've already ... - 07:01 AM Feature #1587: implement full support for word indexes
- > Well, since we decided do not to touch conversion at this moment
I think you've already resolved this. But I wa... - 06:21 AM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> Igor,
> if you work at AST level, you do not need to parse the full SQL query as it is al... - 06:13 AM Feature #1587: implement full support for word indexes
- Igor,
if you work at AST level, you do not need to parse the full SQL query as it is already represented as a tree.... - 02:20 AM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> The way @containsQuery@ extracts the @tblName@ does not seem sound to me. The @"__impl"@ mi... - 07:14 AM Feature #3958 (WIP): BUFFER-COPY optimization
- 07:11 AM Feature #4055: optimize temp-table output parameter copying
- I committed the current implementation of DMO signature to 3821c/rev. 11835, as I reached a stable implementation, wh...
11/24/2020
- 06:17 PM Feature #1587: implement full support for word indexes
- The way @containsQuery@ extracts the @tblName@ does not seem sound to me. The @"__impl"@ might not be part of the @tb...
- 05:54 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> Indeed, intercepting the @contains@ function with regular expressions is not the best solut... - 04:29 PM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> I see. Yes, that is weird. Do you get the same result with @some_other_word_index_field contain... - 04:18 PM Feature #1587: implement full support for word indexes
- I see. Yes, that is weird. Do you get the same result with @some_other_word_index_field contains if1@? In other wor...
- 04:00 PM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> This is the documented limitation in the 4GL. @CONTAINS@ can only search word indexes. It canno... - 03:57 PM Feature #1587: implement full support for word indexes
- > In addition, if I use a field name as the CONTAINS argument, 4GL reports a syntax error, although a little bit stra...
- 03:49 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> Probably this is possible but I do not think it is justified. If the function node is repla... - 03:22 PM Feature #1587: implement full support for word indexes
- Igor, I did a quick review of 1587b/11834.
Igor Skornyakov wrote:
> Implemented SQL re-write for @CONTAINS@. Acco... - 02:11 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> It may also be helpful to review the specific diffs in:
>
> * rev 10173: this added the i... - 02:09 PM Feature #1587: implement full support for word indexes
- It may also be helpful to review the specific diffs in:
* rev 10173: this added the initial conversion infrastruct... - 01:50 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > At this moment I do not understand the details of the @CONTA... - 01:39 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> At this moment I do not understand the details of the @CONTAINS@ operator conversion. Whe... - 10:27 AM Feature #1587: implement full support for word indexes
- Implemented SQL re-write for @CONTAINS@. According to Ovidiu, this is done not in the right place, but it should work...
- 05:39 AM Feature #4055: optimize temp-table output parameter copying
- Eric Faulhaber wrote:
> Agreed. Note that for temp-tables, the MANDATORY attribute can be dropped from the signature...
11/23/2020
- 03:41 PM Feature #4055: optimize temp-table output parameter copying
- Adrian Lungu wrote:
> These are the first steps in introducing the DMO structure signature according to #4011-774. I... - 01:19 PM Feature #4055: optimize temp-table output parameter copying
- These are the first steps in introducing the DMO structure signature according to #4011-774. I posted a diff containi...
- 03:12 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> No, it is probably OK, too. My idea was keep FqlToSql converter cleaner (only to do convers... - 03:01 PM Feature #1587: implement full support for word indexes
- No, it is probably OK, too. My idea was keep FqlToSql converter cleaner (only to do conversion, not enhancements of c...
- 02:41 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> (continued, I pressed Submit instead of Preview)
> If this is done at this stage, you real... - 02:31 PM Feature #1587: implement full support for word indexes
- (continued, I pressed Submit instead of Preview)
If this is done at this stage, you really do not care about the suf... - 02:25 PM Feature #1587: implement full support for word indexes
- I think the best moment to intercept the @contain@ function and replace it with a subtree is in @HQLPreprocessor@. At...
- 02:04 PM Feature #1587: implement full support for word indexes
- From the mails:
Igor:
> BTW: what is the rule for generating the aliases? I would like to avoid parsing the FROM cl... - 10:51 AM Bug #5013 (WIP): Collision of java names with SQL keywords
- I have fixed the issue by filtering through @NameConverter.resolvePossibleKeywordConflict()@ the result of @P2OAccess...
11/22/2020
- 05:11 AM Feature #1587: implement full support for word indexes
- Well, the last section of #1587-71 regarding SQL re-writing is wrong, It works only for some simple queries and does ...
Also available in: Atom