FWD » Core Development » Database

08/24/2022

05:19 PM Feature #6700: refactor prodataset conversion to generate a separate/common class which can be re...

Similar to how we convert temp-tables, the idea is to refactor the code to have datasets convert as a separate class ... Greg Shah

05:11 PM Feature #6700 (New): refactor prodataset conversion to generate a separate/common class which can...

Greg Shah

03:38 PM Bug #6699: TemporaryBuffer$Multiplexer memory leak in global block

Constantin Asofiei wrote:
> Eric: do you recall if the @global@ parameter at the @TemporaryBuffer.define@ is used ... Eric Faulhaber

02:14 PM Bug #6699: TemporaryBuffer$Multiplexer memory leak in global block

For a very long-running FWD context, there is an accumulation of @TemporaryBuffer$Multiplexer@ instances in the @fina... Constantin Asofiei

02:11 PM Bug #6699 (WIP): TemporaryBuffer$Multiplexer memory leak in global block

Constantin Asofiei

03:36 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Ported the following UDFs: ... Igor Skornyakov

03:01 PM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching

Alexandru, I had missed your description of the tracing in #6695-11 when I posted my note.
If the hit/miss counts ... Eric Faulhaber

02:50 PM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching

Alexandru Lungu wrote:
> I locally added JMX beans for cache hits and misses and I get the same results (@4.99@ on @... Eric Faulhaber

10:24 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching

Greg Shah wrote:
> Make sure that the 4GL code is compiled before you run it. Otherwise the compilation cost in the... Alexandru Lungu

09:52 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching

Greg Shah wrote:
> > I locally added JMX beans for cache hits and misses and I get the same results (4.99 on PRESELE... Alexandru Lungu

09:50 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching

Yes, no problem. Greg Shah

09:45 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching

Greg Shah wrote:
> Igor: Please add details to [[p2j:JMX Instrumentation]] to allow the rest of the team to easily f... Igor Skornyakov

09:41 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching

> I locally added JMX beans for cache hits and misses and I get the same results (4.99 on PRESELECT NO-UNDO, 0.0 on @... Greg Shah

09:28 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching

I locally added JMX beans for cache hits and misses and I get the same results (@4.99@ on @PRESELECT NO-UNDO@, @0.0 o... Alexandru Lungu

06:47 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching

> > I also instrumented FWD with the attached patch (based on 3821c/14190),
>
> Forgot to attach the patch. This m... Greg Shah

05:33 AM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching

These are some very insightful results!
@0.499@ rate for @PRESELECT NO-UNDO@ is exactly what I expected: only the ... Alexandru Lungu

10:46 AM Support #6679: H2 general performance tuning

Dănuț Filimon wrote:
> I ran a test on the sql statements obtained from the Hotel GUI application.
>
> The prepar... Eric Faulhaber

08:32 AM Support #6679: H2 general performance tuning

I ran a test on the sql statements obtained from the Hotel GUI application.
The prepared statements obtained from ... Dănuț Filimon

10:24 AM Feature #6348: implement support for MariaDB

The Hotel GUI project is broken, when running @./prepare_hotel.sh@ on a fresh checkout (interestingly, running again ... Constantin Asofiei

08/23/2022

06:32 PM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching

Eric Faulhaber wrote:
> I also instrumented FWD with the attached patch (based on 3821c/14190),
Forgot to attac... Eric Faulhaber

06:25 PM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching

I wanted to see where the time was being spent in both the @PreselectQuery@ case and the @CompoundQuery@ case. I also... Eric Faulhaber

12:25 PM Feature #6695: Multi-table preselect query may underperform due to repetitive fetching

There is a case in which the multi-table @PreselectQuery@ works slower than a @CompoundQuery@:... Alexandru Lungu

12:18 PM Feature #6695 (Review): Multi-table preselect query may underperform due to repetitive fetching

Alexandru Lungu

02:30 PM Bug #6275: SKIP-DELETED-RECORD implementation

> A single question: calls to @stopOnSkippedRecord@ occur on @first@, @next@, and @previous@ navigation. Shouldn't th... Greg Shah

01:55 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Ported the following UDFs: ... Igor Skornyakov

12:34 PM Feature #6582: implement multi-table AdaptiveQuery

> I should note that in a real application, it would be very unusual to have a wide open cross join like this, which ... Alexandru Lungu

11:10 AM Feature #6582: implement multi-table AdaptiveQuery

Alexandru Lungu wrote:
> > I am facing a three times slower query in @AdaptiveQuery@ comparing to @CompoundQuery@ (a... Eric Faulhaber

04:45 AM Support #6679: H2 general performance tuning

Committed 3821c/rev.14187 where I replaced @.nextvalue@ with @next value for@ in order to prepare for the 2.1.210 H2 ... Dănuț Filimon

03:52 AM Support #6679: H2 general performance tuning

Eric Faulhaber wrote:
> What is currently calling .nextval?
@P2JH2Dialect.getSequencePrefetchString()@, @FastCopy... Dănuț Filimon

08/22/2022

03:42 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Ported matches, matcheslist, lookup.
Committed to 3821c/14184. Igor Skornyakov

11:22 AM Support #6679: H2 general performance tuning

Dănuț Filimon wrote:
> Regarding the syntax difference about nextval in #6679-11.
>
> Since we can't use @.nextva... Eric Faulhaber

10:09 AM Support #6679: H2 general performance tuning

Regarding the syntax difference about nextval in #6679-11.
Since we can't use @.nextval@ in version 2.1.210 of H2,... Dănuț Filimon

10:38 AM Feature #6582: implement multi-table AdaptiveQuery

> I am facing a three times slower query in @AdaptiveQuery@ comparing to @CompoundQuery@ (a read-only example). This ... Alexandru Lungu

08:40 AM Feature #6348: implement support for MariaDB

> The dialect generates now string columns as varchar(100). I did not push the system intentionally, but with the scr... Greg Shah

08/20/2022

07:45 AM Feature #6582: implement multi-table AdaptiveQuery

Eric Faulhaber wrote:
> Alexandru Lungu wrote:
>> Initially, I expect to see the AdaptiveQuery working out-of-the-b... Alexandru Lungu

06:42 AM Support #6679: H2 general performance tuning

> OTOH, I am a bit concerned that the performance drops off again in versions >210. Does the H2 history log suggest t... Alexandru Lungu

09:22 PM Feature #6348: implement support for MariaDB

Committed revision 14182.
Eric Faulhaber wrote:
> Any update on the status of running Hotel GUI with MariaDB?
Th... Ovidiu Maxiniuc

08/19/2022

03:47 PM Support #6679: H2 general performance tuning

Alexandru, I'll leave it to you to set the assignee. If both gentlemen are working on this task, you can leave it bla... Eric Faulhaber

03:39 PM Support #6679 (WIP): H2 general performance tuning

The fact that there are so many transactions being executed in the tests actually is encouraging to me. Since transac... Eric Faulhaber

03:17 PM Support #6679: H2 general performance tuning

Around 20 transactions are done by one user per iteration. There are 200 users per tests (except one test with 10 use... Alexandru Lungu

10:58 AM Support #6679: H2 general performance tuning

Just curious: do the tests use a lot of transactions? This is where we have seen a serious bottleneck in the past. Eric Faulhaber

10:13 AM Support #6679: H2 general performance tuning

I tested version 210 patched with the Hotel_GUI application and there were no major problems, except a syntax differe... Dănuț Filimon

08:28 AM Support #6679: H2 general performance tuning

> Yes, the tests for 1.4.200 patched use PageStore and the later versions use MVStore.
Fantastic! I think it is f... Greg Shah

05:26 AM Support #6679: H2 general performance tuning

Greg Shah wrote:
> Are the above comparisons using 1.4.200 patched in PageStore mode versus the later versions in mv... Dănuț Filimon

03:00 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> According to https://dev.mysql.com/doc/refman/8.0/en/signal.html, using SIGNAL with a SQLSTA... Igor Skornyakov

02:54 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

According to https://dev.mysql.com/doc/refman/8.0/en/signal.html, using SIGNAL with a SQLSTATE which begins with @01@... Eric Faulhaber

01:58 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Does anybody know a replacement of PostgreSQL @RAISE NOTICE@ statement for MariaDB?
I've used it for debugging compl... Igor Skornyakov

11:40 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Update.
Here is the complete list of MariaDB UDFs to be implemented:... Igor Skornyakov

11:27 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> What is the revised total number of UDFs for this dialect, and how many currently have a fir... Igor Skornyakov

09:58 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

What is the revised total number of UDFs for this dialect, and how many currently have a first pass implementation? I... Eric Faulhaber

03:00 PM Feature #6348: implement support for MariaDB

Ovidiu Maxiniuc wrote:
> My attempt to add a new guest caused a @Guest Accommodation Report@ with 225 entries (eve... Eric Faulhaber

11:37 AM Feature #6348: implement support for MariaDB

Now that you are working with Hotel GUI (i.e., something that, while not a "real" application, is more than a simple ... Eric Faulhaber

09:49 AM Feature #6348: implement support for MariaDB

Ovidiu Maxiniuc wrote:
> With hotel_gui/r248 and 3821c/14168, I am able to start the client and authenticate. The @G... Eric Faulhaber

10:36 AM Feature #6582: implement multi-table AdaptiveQuery

Alexandru Lungu wrote:
> Initially, I expect to see the @AdaptiveQuery@ working out-of-the-box with the current im... Eric Faulhaber

07:55 AM Bug #6688: ASSIGN trigger conversion when field has DECIMALS clause

Ovidiu Maxiniuc wrote:
> With 3821c your testcases correctly converts to
> [...]
>
> This was fixed recently r1... Constantin Asofiei

07:54 AM Bug #6688: ASSIGN trigger conversion when field has DECIMALS clause

With 3821c your testcases correctly converts to ... Ovidiu Maxiniuc

03:33 AM Bug #6688: ASSIGN trigger conversion when field has DECIMALS clause

There is a problem when converting a runtime ASSIGN database trigger, with a field having DECIMALS and/or INITIAL cla... Constantin Asofiei

03:31 AM Bug #6688 (Closed): ASSIGN trigger conversion when field has DECIMALS clause

Constantin Asofiei

08/18/2022

05:25 PM Support #6679: H2 general performance tuning

Dănuț Filimon wrote:
> The tests have 200 threads with 5/10 loops. The full tests have 200-2000 randomly generated... Eric Faulhaber

05:18 PM Support #6679: H2 general performance tuning

Greg Shah wrote:
> This sounds quite exciting.
>
> Are the above comparisons using 1.4.200 patched in PageStore m... Eric Faulhaber

03:23 PM Support #6679: H2 general performance tuning

This sounds quite exciting.
Are the above comparisons using 1.4.200 patched in PageStore mode versus the later ver... Greg Shah

10:01 AM Support #6679: H2 general performance tuning

Using the resources available in [[p2j:Performance Testing the H2 Database]] I have done tests using Apache JMeter an... Dănuț Filimon

08/17/2022

04:06 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Ovidiu Maxiniuc wrote:
> Please expand to see {{collapse(the full list of expected UDF in FWD)
> [...]
> }}
>
>... Igor Skornyakov

04:04 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Please expand to see {{collapse(the full list of expected UDF in FWD)... Ovidiu Maxiniuc

01:57 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Ovidiu Maxiniuc wrote:
> I used @meld@ to compare two text captions:
> # as the 'file name' suggests, I executed a ... Igor Skornyakov

01:53 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Ovidiu Maxiniuc wrote:
> Now, as I wrote the text above, I noticed that the UDFs are defined once for *ALL* database... Igor Skornyakov

01:46 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Greg Shah wrote:
> > I think it would be better to decide on a name casing (all lowercase maybe?)
>
> +1 for all ... Igor Skornyakov

01:45 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> Added placeholder for the error handling UDFs in 3821c/14169.
>
> Please note that some ... Ovidiu Maxiniuc

01:40 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Ovidiu Maxiniuc wrote:
> > Anyway, I think that it is a little late to change the approach.
> I am not sure what yo... Igor Skornyakov

01:26 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> Well, this is a possible option. It is a natural choice since UDFs a 4GL functions' counter... Ovidiu Maxiniuc

12:11 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Ovidiu Maxiniuc wrote:
> I think the best would be to scan for @@HQLFunction@ annotation in the list of @public st... Igor Skornyakov

12:03 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

> I think it would be better to decide on a name casing (all lowercase maybe?)
+1 for all lowercase names. Greg Shah

11:59 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Greg Shah wrote:
> Why would this emit into the converted code? Our converted code should not be dialect-specific t... Ovidiu Maxiniuc

11:53 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> I've generated templates for MariaDB UDFs from PostgreSQL ones. This is why we have no e.g.... Ovidiu Maxiniuc

11:16 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

> Devil's advocate point: there already are significant differences in syntax and builtin function names across datab... Greg Shah

11:12 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Please note however, that adding "signature" suffix to the UDF names increases their total number by ~50%.
For examp... Igor Skornyakov

11:09 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> Please note also that I decided do not add underscore to the names of UDFs w/o argument. So... Eric Faulhaber

11:05 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Devil's advocate point: there already are significant differences in syntax and builtin function names across databas... Eric Faulhaber

09:12 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Greg Shah wrote:
> If I understand correctly, different database "dialects" (in FWD) will have different function na... Igor Skornyakov

08:19 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

If I understand correctly, different database "dialects" (in FWD) will have different function names for the same 4GL... Greg Shah

06:54 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Added additional UDFs' signatures in 3821c/14171.
@fwdsession@ UDF does not exist for PostgreSQL. Actually I do no... Igor Skornyakov

03:40 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Please note also that I decided do not add underscore to the names of UDFs w/o argument. So it should be @getfwdversi... Igor Skornyakov

02:48 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Added placeholder for the error handling UDFs in 3821c/14169.
Please note that some native UDFs (such as @totimest... Igor Skornyakov

01:30 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Ovidiu Maxiniuc wrote:
> Igor,
>
> I implemented the decoration of the UDFs as described in note-31. I encountere... Igor Skornyakov

10:57 AM Support #6679 (Internal Test): H2 general performance tuning

Alexandru Lungu

03:45 AM Feature #6582: implement multi-table AdaptiveQuery

Committed 6582a/rev. 14160 including some fixes for order by clause and iteration type in multi-table @AdaptiveQuery@... Alexandru Lungu

08:14 PM Feature #6348: implement support for MariaDB

With hotel_gui/r248 and 3821c/14168, I am able to start the client and authenticate. The @Guests@, @Rates@ and @Rooms... Ovidiu Maxiniuc

08/16/2022

07:39 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor,
I implemented the decoration of the UDFs as described in note-31. I encountered some differences. I know you... Ovidiu Maxiniuc

01:20 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Refactored @ScriptRunner@ moving dialect-specific logic into the corresponding subclasses. Added support for MariaDB ... Igor Skornyakov

01:10 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> No, I do not work on this. In fact I've planned to finish with porting UDFs first.
Ovi... Eric Faulhaber

12:17 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > OK. Switching to the @ScriptRunner@ and most commonly used UDFs... Igor Skornyakov

10:42 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> OK. Switching to the @ScriptRunner@ and most commonly used UDFs.
> Please note however tha... Ovidiu Maxiniuc

02:41 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Changed @build.gradle@ to add MariaDB @udfs.sql@ to the p2j.jar in 3821c/14165. Igor Skornyakov

01:31 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

OK. Switching to the @ScriptRunner@ and most commonly used UDFs.
Please note however that we also need UDFs names re... Igor Skornyakov

11:22 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Ovidiu Maxiniuc wrote:
> Igor,
> Please do a check-out of the hotel_gui project (@~/secure/code/p2j_repo/samples/ho... Eric Faulhaber

11:17 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

The following is a list of 4GL builtin functions used within WHERE clauses, based on their presence in the applicatio... Eric Faulhaber

10:50 AM Feature #6348: implement support for MariaDB

Ovidiu Maxiniuc wrote:
> I can confirm the char r-trimming is provided out-of-the-box and char-indexes seems to wo... Eric Faulhaber

08:17 PM Feature #6348: implement support for MariaDB

Please upgrade to FWD r14164 if you want to convert, import and start the hotel_gui test application. However, connec... Ovidiu Maxiniuc

08/15/2022

07:21 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor,
Please do a check-out of the hotel_gui project (@~/secure/code/p2j_repo/samples/hotel_gui/@). Use the latest F... Ovidiu Maxiniuc

01:28 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> But if I understand now, the functions work with Julian day values, just not those that wo... Igor Skornyakov

01:20 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

I initially was confused by the statement:
> So at this moment FWD @todate(integer)@ and @toint(date)@ UDFs work o... Eric Faulhaber

01:10 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> The parameter passed to @todate(integer)@ is the number of days since 12/31/-4714 (the Julia... Igor Skornyakov

01:03 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> According to the MariaDB documentation its date functions do not work correctly with non-gr... Eric Faulhaber

01:11 PM Bug #6599: minimal mode conversion problem with DMO name collision

Ovidiu, this is related to 6129a branch, where DMO annotations are registered in NameConverter. Constantin Asofiei

12:52 PM Bug #6599: minimal mode conversion problem with DMO name collision

Sorry, I was focused on the very last entry here. I just saw the solution I proposed after clicking submit. However, ... Ovidiu Maxiniuc

12:50 PM Bug #6599: minimal mode conversion problem with DMO name collision

Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Constantin Asofiei wrote:
> > > I think the correct way is... Ovidiu Maxiniuc

12:00 PM Bug #6599: minimal mode conversion problem with DMO name collision

Eric Faulhaber wrote:
> Constantin Asofiei wrote:
>
> > I think the correct way is to not link the DMO name with ... Constantin Asofiei

11:34 AM Bug #6599: minimal mode conversion problem with DMO name collision

Constantin Asofiei wrote:
> I think the correct way is to not link the DMO name with the SQL table name, for minim... Eric Faulhaber

10:09 AM Feature #6582: implement multi-table AdaptiveQuery

I created 6582a as a branch of 3821c. I committed (rev. 14159) some conversion related work and minimal runtime chang... Alexandru Lungu

08/14/2022

11:55 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

According to the MariaDB documentation its date functions do not work correctly with non-gregorian dates (before Octo... Igor Skornyakov

11:40 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

In 3821c/14154. *174* of *219* UDFs are ported from PostrgreSQL to MariaDB.
Started working on format-driven conve... Igor Skornyakov

08/13/2022

09:31 PM Feature #6348: implement support for MariaDB

The revision 14156 brings several improvements for the dialect:
* I noticed they released a new GA JDBC driver (3.0.... Ovidiu Maxiniuc

08/12/2022

04:22 PM Feature #6450: buffer/buffer-field features

I did not work with 6129a lately so I had to update the branch and review those changes. Constantin did the rebase ag... Ovidiu Maxiniuc

10:47 AM Feature #6450: buffer/buffer-field features

Ovidiu, I see there was a review cycle in #6502 and a commit of your changes to 6129a. Given that, is there anything ... Eric Faulhaber

03:19 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

In 3821c/14153. *157* of *219* UDFs are ported from PostrgreSQL to MariaDB.
So, all 'simple' UDFs have been ported... Igor Skornyakov

01:49 PM Feature #6348: implement support for MariaDB

How to configure your test project to work with @MariaDb@:
* update your @cfg/p2j.cfg.xml@ to add generation of DDL ... Ovidiu Maxiniuc

01:33 PM Feature #6348: implement support for MariaDB

I did a basic write/read from database test. It seems to be working, but I did not use any fancy queries.
I used t... Ovidiu Maxiniuc

08/11/2022

02:32 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > Exactly. Any objections?
>
> No, seems like a good approa... Igor Skornyakov

02:27 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> Exactly. Any objections?
No, seems like a good approach.
I would like to get the in... Eric Faulhaber

02:19 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> If I understand your process correctly, it looks like you are doing an automated port of the... Igor Skornyakov

02:17 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

If I understand your process correctly, it looks like you are doing an automated port of the "scaffolding" from the P... Eric Faulhaber

02:13 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > It appears that we should use @DECIMAL(65, 38)@ instead of @NUME... Igor Skornyakov

02:05 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> It appears that we should use @DECIMAL(65, 38)@ instead of @NUMERIC@ in UDFs.
Shouldn't ... Eric Faulhaber

01:59 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

In 3821c/14150. *55* of *219* UDFs are ported from PostrgreSQL to MariaDB.
Please do not be too optimistic. The po... Igor Skornyakov

12:45 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

It appears that we should use @DECIMAL(65, 38)@ instead of @NUMERIC@ in UDFs. Igor Skornyakov

03:13 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> I just looked at this again and noticed that some of the mappings ... Igor Skornyakov

01:14 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> [...]
> In fact the MariaDB data types a not very different from PostgreSQL ones. See the ... Eric Faulhaber

08/10/2022

05:24 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> > I'm ok with your naming convention, though where the mapped data types differ in name for... Ovidiu Maxiniuc

03:12 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Created MariaDB UDFs templates.
Committed to 3821c/14145. Igor Skornyakov

02:39 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> We had a similar issue with H2 and we resolved it by prepending an underscore followed by a ... Igor Skornyakov

02:06 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

We had a similar issue with H2 and we resolved it by prepending an underscore followed by a unique integer (for that ... Eric Faulhaber

01:38 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> I've realized that in MariaDB we cannot have two UDFs with the same name but different sign... Igor Skornyakov

01:24 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

I've realized that in MariaDB we cannot have two UDFs with the same name but different signatures.
This requires cha... Igor Skornyakov

08:01 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

At this moment I see the following plan
# Create an @AWK@ script for automatic conversion of the udfs.sql script for... Igor Skornyakov

05:10 PM Feature #6371: implement SAVE CACHE statement

Pushed revision 6371a/14096 with JavaDoc and indexes. Boris Schegolev

01:14 PM Feature #6371: implement SAVE CACHE statement

If the cost is not high, making an implicit @SAVE CACHE@ call at server startup will make the system more resilient/s... Greg Shah

01:11 PM Feature #6371: implement SAVE CACHE statement

The persistence of the DMOs is a good point. We would want these to load like any other DMOs, if no schema changes ha... Eric Faulhaber

12:49 PM Feature #6371: implement SAVE CACHE statement

Also, I wonder if we should even do this persisting for generated DMOs for dynamic temp-tables (at least if they are ... Greg Shah

12:47 PM Feature #6371: implement SAVE CACHE statement

Another difference from dynamic temp-tables: the generated DMOs must survive server restarts (or must be recreated on... Greg Shah

12:35 PM Feature #6371: implement SAVE CACHE statement

After detecting schema differences, we need to inspect/apply/walk these to generate the correct DMO interfaces. DMO i... Eric Faulhaber

11:19 AM Feature #6371: implement SAVE CACHE statement

Let's go with XML for persisting each "snapshot" state, which will be used for later comparisons. TBD: do we need to ... Eric Faulhaber

08/09/2022

05:45 PM Feature #6371: implement SAVE CACHE statement

XML is more consistent with the rest of the configuration in FWD. Greg Shah

04:59 PM Feature #6371: implement SAVE CACHE statement

I pushed revision 6371a/14095 with code to support comparison for tables and columns. Also, extended the javadoc on t... Boris Schegolev

11:20 AM Feature #6371: implement SAVE CACHE statement

Eric Faulhaber wrote:
> Boris Schegolev wrote:
> > Saved state will consist of tables, columns and index lists. Thi... Tijs Wickardt

11:02 AM Feature #6371: implement SAVE CACHE statement

Eric Faulhaber wrote:
> Boris, please commit all your updates to 6371a. You are the only one changing this branch, s... Eric Faulhaber

10:56 AM Feature #6371: implement SAVE CACHE statement

Boris Schegolev wrote:
> Saved state will consist of tables, columns and index lists. This object can be serialized ... Eric Faulhaber

10:47 AM Feature #6371: implement SAVE CACHE statement

Boris, please commit all your updates to 6371a. You are the only one changing this branch, so it is safe. This will m... Eric Faulhaber

11:55 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

If the JSON array approach seems to be the only viable option, I think we have to use it for now. Another alternative... Eric Faulhaber

08/05/2022

02:35 PM Feature #6371: implement SAVE CACHE statement

Implemented @DatabaseState@ object, @Difference@ object and loading / comparison for tables. Please, review. Boris Schegolev

12:04 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

There is a about a couple of dozens of PostgreSQL native UDFs (~10%) that heavily use arrays and/or user-defined data... Igor Skornyakov

08/04/2022

06:18 AM Feature #6348: implement support for MariaDB

Greg Shah wrote:
> > However supporing word indexes for non-normalized extent fields can be not strightforward.
>
... Igor Skornyakov

05:50 AM Feature #6348: implement support for MariaDB

> However supporing word indexes for non-normalized extent fields can be not strightforward.
Is it possible to use... Greg Shah

12:38 AM Feature #6348: implement support for MariaDB

Eric Faulhaber wrote:
> Agreed, we should not have logic that begins @if (dialect instanceof *Dialect) ...@.
>
I'... Igor Skornyakov

10:59 PM Feature #6348: implement support for MariaDB

Ovidiu Maxiniuc wrote:
> Yes, I noticed that @WordTable@ class and some methods of @DDLGeneratorWorker@ are not full... Eric Faulhaber

08/03/2022

04:39 PM Feature #6371: implement SAVE CACHE statement

Saved state will consist of tables, columns and index lists. This object can be serialized using common methods (YAML... Boris Schegolev

12:41 AM Feature #6371: implement SAVE CACHE statement

Boris Schegolev wrote:
> I am attaching a proposal for Schema Comparator service. It would be invoked like:
>
> [... Eric Faulhaber

03:52 PM Feature #6348: implement support for MariaDB

Yes, I noticed that @WordTable@ class and some methods of @DDLGeneratorWorker@ are not fully dialect independent. The... Ovidiu Maxiniuc

02:56 PM Feature #6348: implement support for MariaDB

Please note that @CONTAINS@ (word tables') support for MariaDB will also need some some efforts (we need MariaDB-spec... Igor Skornyakov

01:10 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> Please see #6348-7. In fact, it would be good to review that whole task.
Thank you, revie... Igor Skornyakov

12:52 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Please see #6348-7. In fact, it would be good to review that whole task. Eric Faulhaber

12:11 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Have we already made a decision about datatypes' mapping for MariaDB?
At this moment the most important for me are s... Igor Skornyakov

08/01/2022

03:42 PM Feature #6371: implement SAVE CACHE statement

I am attaching a proposal for Schema Comparator service. It would be invoked like:... Boris Schegolev

02:32 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Ovidiu Maxiniuc wrote:
> I used the following command:
> [...]
>
> That installed for me:
> [...]
>
> I do n... Igor Skornyakov

02:22 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

I used the following command:... Ovidiu Maxiniuc

01:27 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Working with version 10.8.3 Igor Skornyakov

12:45 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> Which version of MariaDB should I work with?
The most recent production build (10.8, AFA... Eric Faulhaber

04:14 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Which version of MariaDB should I work with?
Thank you. Igor Skornyakov

07/31/2022

03:41 PM Feature #6628 (WIP): port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov

07/29/2022

01:25 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> I understand that MariaDB does not have arrays
Not as a first class data type, no, but p... Eric Faulhaber

07/27/2022

04:02 PM Bug #6599: minimal mode conversion problem with DMO name collision

Eric, minimal mode conversion was added after I my @NameConverter.java@ change - and conversion was fine, until the r... Constantin Asofiei

03:43 PM Bug #6599: minimal mode conversion problem with DMO name collision

Constantin, it looks like you made this change very early in 6129a (rev 13815), apparently to address cases of confli... Eric Faulhaber

06:15 AM Bug #6599: minimal mode conversion problem with DMO name collision

Eric, can this be fixed? Although is not a problem when running the converted code, this is a problem when executing... Constantin Asofiei

03:33 AM Support #4701: try to improve H2 transaction commit performance

I just noticed that H2 is moving kinda fast with no more than 5 releases in the last couple of months. I can't tell i... Alexandru Lungu