FWD » Core Development » Database

12/13/2022

06:48 PM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> BTW: it looks that @FILL@ for recursive dataset can be very expensive since it can require ... Ovidiu Maxiniuc

11:56 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2

I think @Session.log@ is responsible for logging the sub(tx) details needed for savepoints or rollback. This is enab... Constantin Asofiei

11:13 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2

I guess a simple first step is to profile typical flows in real applications and see if we can associate any bottlene... Eric Faulhaber

11:08 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2

NO-UNDO temp-tables are used heavily in many 4GL applications. Typically, regular temp-tables are used as well, such ... Eric Faulhaber

10:41 AM Feature #6995 (Closed): possibly support NO-UNDO temporary tables directly in H2

Eric Faulhaber

10:37 AM Feature #6582: implement multi-table AdaptiveQuery

Greg Shah wrote:
> > consider way stronger optimizations directly in the H2 engine: this involves some extended work... Eric Faulhaber

07:47 AM Feature #6928: H2 UPDATE performance improvement

Alexandru Lungu wrote:
> As a side question, I see some changes from for-each structure into index based iteration: ... Constantin Asofiei

06:58 AM Feature #6928: H2 UPDATE performance improvement

I got deep in most of the changes in rev. 8 - they seem reasonable. As a side question, I see some changes from for-e... Alexandru Lungu

12/12/2022

02:29 PM Feature #6444: dataset improvements

Based on my tests the @FILL@ for recursive DATA-RELATION add records which are not in the DATA-SOURCE QUERY only if b... Igor Skornyakov

12:19 PM Feature #6928 (Review): H2 UPDATE performance improvement

The changes are in fwd-h2 project rev 8.
Alexandru: please review. Constantin Asofiei

08:17 AM Support #6709: track nested FIND inside a related FOR loop

I've uncommitted 3821c rev 14436. It causes the following regression in conversion for a large customer application.... Greg Shah

04:29 AM Support #6709: track nested FIND inside a related FOR loop

Greg Shah wrote:
> You can just do this:
> ... Dănuț Filimon

12/10/2022

11:52 PM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...

Dănuț,
I am sorry for the delay, somehow the notification emails got lost at the bottom of the list and I only saw... Ovidiu Maxiniuc

12/09/2022

10:30 AM Bug #6767: Possible name clashes in DMO classes

Eric: This is still waiting for review. Greg Shah

08:39 AM Feature #6444: dataset improvements

Marian Edu wrote:
> Igor Skornyakov wrote:
> > What puzzles me is the logic for 'relaxing' the @qEmp@ conditions to... Igor Skornyakov

08:19 AM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> What puzzles me is the logic for 'relaxing' the @qEmp@ conditions to find the parent record... Marian Edu

07:45 AM Feature #6444: dataset improvements

Marian Edu wrote:
> Please not that while the recursive relation does load the FK parent in the parent temp-table (s... Igor Skornyakov

05:32 AM Feature #6444: dataset improvements

The @data_relation/recursive_relation_fill.p@ test fails with FWD with @Cannot run GET methods on query qEmp until it... Igor Skornyakov

04:51 AM Feature #6444: dataset improvements

Marian Edu wrote:
> Ovidiu Maxiniuc wrote:
> >
> > > Marian,
> > > Is it correct that the DATA-SOURCE query shou... Igor Skornyakov

04:46 AM Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
>
> > Marian,
> > Is it correct that the DATA-SOURCE query should select a subset of a sin... Marian Edu

08:16 AM Feature #6371: implement SAVE CACHE statement

Regression is fixed, current revision number is 14434. Boris Schegolev

12/08/2022

04:40 PM Support #6709: track nested FIND inside a related FOR loop

> > 1. I don't think we should limit the for each processing to only match temp-tables and buffers. All record phrase... Greg Shah

04:32 PM Support #6709: track nested FIND inside a related FOR loop

I think @FieldReference@ is less clean looking and it will be slower. In #4928, we do have some ideas to improve it ... Greg Shah

08:45 AM Support #6709: track nested FIND inside a related FOR loop

... Dănuț Filimon

03:24 AM Support #6709: track nested FIND inside a related FOR loop

Greg Shah wrote:
> 1. I don't think we should limit the for each processing to only match temp-tables and buffers. A... Dănuț Filimon

04:33 PM Feature #6371: implement SAVE CACHE statement

Boris, if you have a fix for the conversion regression, please commit it. Eric Faulhaber

01:06 PM Feature #6371: implement SAVE CACHE statement

Revision 6371a/14431 fixes some issues, including the following with the DMO interface assembly:
* a package path ... Eric Faulhaber

03:45 PM Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
>More than that, I understand that you aim for a 'fast-copy' mechanism where the rows are cop... Igor Skornyakov

03:27 PM Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > > Oh, I see. Indeed, in this case we cannot be sure which versi... Igor Skornyakov

03:02 PM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> > Oh, I see. Indeed, in this case we cannot be sure which version of the CTE syntax to use.... Ovidiu Maxiniuc

05:59 AM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> Oh, I see. Indeed, in this case we cannot be sure which version of the CTE syntax to use.
... Igor Skornyakov

01:31 AM Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > It appears that DATASET:FILL() is not working at all for RECURS... Igor Skornyakov

05:57 AM Support #6708 (Review): track/report at runtime when AdaptiveQuery shifts into dynamic mode

Committed 3821c/rev.14425. Small fix. The number of invalidated queries displayed in the Overview was wrong when @OUT... Dănuț Filimon

12/07/2022

04:42 PM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> It appears that DATASET:FILL() is not working at all for RECURSIVE DATA-RELATION (the @Data... Ovidiu Maxiniuc

11:56 AM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> I'm thinking about adding support for a RECURSIVE DATA-RELATION by re-writing the DATA-SOUR... Igor Skornyakov

10:45 AM Feature #6444: dataset improvements

The @BufferImpl.fill()@ method is pretty long (400 lines of code) and complicated.
I'm thinking about adding support... Igor Skornyakov

12/05/2022

03:01 PM Feature #6444: dataset improvements

It appears that DATASET:FILL() is not working at all for RECURSIVE DATA-RELATION (the @DataSet.getTopBufferList()@ re... Igor Skornyakov

07:34 AM Support #6709: track nested FIND inside a related FOR loop

Code Review 6709-rpt-20221205.diff
Good, it is getting closer.
1. I don't think we should limit the for each pr... Greg Shah

03:51 AM Support #6709: track nested FIND inside a related FOR loop

Greg Shah wrote:
> 1. Please switch out the use of a @Stack@ for the @ScopedSymbolDictionary@.
I made the @FOR EACH... Dănuț Filimon

06:07 AM Feature #6371: implement SAVE CACHE statement

My suspicion is the logical change in @XmlHelper.setAttribute()@ - I added a check for @value.isEmpty()@ and it proba... Boris Schegolev

12:51 AM Feature #6371: implement SAVE CACHE statement

Eric Faulhaber wrote:
> I found that I was unable to convert test cases using 6371a/14119, with an error during anno... Eric Faulhaber

02:50 AM Feature #6816: improve PreselectQuery.assembleHQL

After I did some investigation upon the @PreselectQuery.assembleHQL@ function, two types of optimization occurred to ... Radu Apetrii

02:13 AM Feature #6928: H2 UPDATE performance improvement

|_. version |_. server run |_. client run |_. indexed (ms) |_. unindexed(ms) |
|h2-1.4.200.jar | 1... Alexandru Lungu

12/02/2022

04:52 PM Feature #6928: H2 UPDATE performance improvement

Here are the results for two server runs, each with 5 client connection:
|\3=. First Run |/9. |\3=. Second Run |
|_... Ovidiu Maxiniuc

02:32 PM Feature #6928: H2 UPDATE performance improvement

Alexandru/Ovidiu: previously I uploaded the wrong jar (it was the rev 7 one, not the patched one). Please try with t... Constantin Asofiei

09:09 AM Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode

Committed 3821c/rev.14409. Made a change in order to display the parent methods in the 4GL code by the number of call... Dănuț Filimon

08:44 AM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> However, FWD in this case generates no row data at all.
It appears that this is the prob... Igor Skornyakov

12/01/2022

10:46 AM Feature #6444: dataset improvements

When PK and a FK are specified in an incorrect order in the @relation-fields@ clause (see #6444-23), 4GL does not com... Igor Skornyakov

10:30 AM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> I've noticed an intersting thing. In the absense of the @nsPrefix@ 4GL @WRITE-XML@ creates ... Igor Skornyakov

05:29 AM Feature #6444: dataset improvements

I've noticed an intersting thing. In the absense of the @nsPrefix@ 4GL @WRITE-XML@ creates "html-style" output. See a... Igor Skornyakov

04:46 AM Feature #6444: dataset improvements

Marian Edu wrote:
> Igor Skornyakov wrote:
> > What about navigation& I mean the following statement:
> > [...]
>... Igor Skornyakov

04:44 AM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> What about navigation& I mean the following statement:
> [...]
> How @a recursive ABL pro... Marian Edu

04:35 AM Feature #6444: dataset improvements

Marian Edu wrote:
> Igor Skornyakov wrote:
> > What I'm doing wrong?
> By looking at the records created the 'cE' ... Igor Skornyakov

04:34 AM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> What I'm doing wrong?
By looking at the records created the 'cE' is the PK and 'cM' is the... Marian Edu

04:27 AM Feature #6444: dataset improvements

Marian Edu wrote:
> This is mostly used by the 'tree-like' .NET UI components, as far as 4GL is concerned the effec... Igor Skornyakov

04:09 AM Feature #6444: dataset improvements

Marian Edu wrote:
> Eric Faulhaber wrote:
> > Marian, can you shed any light on the RECURSIVE feature?
>
> This ... Igor Skornyakov

03:34 AM Feature #6444: dataset improvements

Eric Faulhaber wrote:
> Marian, can you shed any light on the RECURSIVE feature?
This is mostly used by the 'tree... Marian Edu

02:54 AM Feature #6444: dataset improvements

Found a number of incompatibilities in @(READ|WRITE)-XML(SCHEMA)?@ support for RECURSIVE DATASET.
Fixing them in 6129b. Igor Skornyakov

01:00 AM Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> Igor,
>
> You cannot have the same table to be both the source and destination for a @fi... Igor Skornyakov

01:10 AM Feature #6371 (WIP): implement SAVE CACHE statement

I found that I was unable to convert test cases using 6371a/14119, with an error during annotations:... Eric Faulhaber

11/30/2022

06:31 PM Feature #6444: dataset improvements

Igor,
You cannot have the same table to be both the source and destination for a @fill@ operation (we do not suppo... Ovidiu Maxiniuc

12:28 PM Feature #6444: dataset improvements

Another problem with @RECURSIVE@.
I'm trying to write a test for @FILL@ (see the attachment).
When I run it I get... Igor Skornyakov

12:23 PM Feature #6444: dataset improvements

Marian, can you shed any light on the RECURSIVE feature? Eric Faulhaber

11:20 AM Feature #6444: dataset improvements

The OE documentation about @RECURSIVE@ Data-Relation object I see the following statement about such realtions:
<pre... Igor Skornyakov

04:07 PM Feature #6371 (Review): implement SAVE CACHE statement

Boris Schegolev

02:18 AM Feature #6454 (Review): database informational features

Eric Faulhaber wrote:
> Igor, other than requiring review for the patch in #6454-11 and for 6129b/14335, is this tas... Igor Skornyakov

02:04 AM Feature #6454: database informational features

Igor, other than requiring review for the patch in #6454-11 and for 6129b/14335, is this task finished from your poin... Eric Faulhaber

11/29/2022

01:06 PM Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> I assume you talk about the recent serialization updates for temp-tables and FOREIGN-KEY-HI... Igor Skornyakov

12:37 PM Feature #6444: dataset improvements

I assume you talk about the recent serialization updates for temp-tables and FOREIGN-KEY-HIDDEN attribute. I do not t... Ovidiu Maxiniuc

10:16 AM Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > Ovidiu, thank you for the summary of status. I am reassigning to... Igor Skornyakov

07:50 AM Feature #6454: database informational features

Greg Shah wrote:
> > I understand that this is because we do not have even stubs for RCODE-INFO:CRC-VALUE and RCODE-... Igor Skornyakov

04:24 AM Feature #6454: database informational features

Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > Strangely enough I have found no @@DatabaseReferences@ annot... Igor Skornyakov

03:09 AM Feature #6454: database informational features

Igor Skornyakov wrote:
> Strangely enough I have found no @@DatabaseReferences@ annotation in a converted large cust... Constantin Asofiei

05:59 AM Feature #6928: H2 UPDATE performance improvement

|_. version |_. server run |_. client run |_. indexed (ms) |_. unindexed(ms) |
|fwd-h2-1.4.200-6.jar| 1... Alexandru Lungu

05:34 AM Feature #6928: H2 UPDATE performance improvement

I am doing the stress tests right now.
> I've been running the H2 unit tests, too, and this showed some problems w... Alexandru Lungu

04:16 AM Feature #6928: H2 UPDATE performance improvement

Thanks, Ovidiu, I'll profile some more and see what happens. Constantin Asofiei

11/28/2022

06:42 PM Bug #6919 (Review): fix ErrorManager.displayError in TempTableBuilder

Ovidiu Maxiniuc wrote:
> I see you added static import for @ErrorManager@. There are very few places where this is d... Boris Schegolev

04:15 PM Feature #6444: dataset improvements

Eric Faulhaber wrote:
> Ovidiu, thank you for the summary of status. I am reassigning to Igor for implementation. Pl... Ovidiu Maxiniuc

04:01 PM Feature #6444: dataset improvements

Greg Shah wrote:
> > Greg, Constantin, 3821c or 6129b for these changes? They most likely will be needed in 6129b fi... Igor Skornyakov

03:52 PM Feature #6444: dataset improvements

> Greg, Constantin, 3821c or 6129b for these changes? They most likely will be needed in 6129b first, but we should d... Greg Shah

01:29 PM Feature #6444 (WIP): dataset improvements

Igor Skornyakov

01:25 PM Feature #6444: dataset improvements

Ovidiu, thank you for the summary of status. I am reassigning to Igor for implementation. Please assist him if he has... Eric Faulhaber

03:15 PM Feature #6928: H2 UPDATE performance improvement

With attached @h2-1.4.200.jar@, 1st run:
|_. n |_. indexed |_. non-indexed |
| 1 | 799 ms | 453 ms |
| 2 | 302 ms ... Ovidiu Maxiniuc

10:18 AM Feature #6928: H2 UPDATE performance improvement

Attached is the second version of the patch and a stress-test for the UPDATE statement (10k field setters). The 'in-... Constantin Asofiei

09:51 AM Feature #6928 (WIP): H2 UPDATE performance improvement

Constantin Asofiei

02:52 PM Feature #6454: database informational features

Greg Shah wrote:
> > I understand that this is because we do not have even stubs for RCODE-INFO:CRC-VALUE and RCODE-... Igor Skornyakov

02:50 PM Feature #6454: database informational features

> I understand that this is because we do not have even stubs for RCODE-INFO:CRC-VALUE and RCODE-INFO:LANGUAGES.
> D... Greg Shah

02:30 PM Feature #6454: database informational features

As far as I can see, @RCODE-INFO:TABLE-LIST@ inplementation in FWD uses the value of the @tables@ attribute of the @@... Igor Skornyakov

12:23 PM Feature #6454: database informational features

I've noticed the following problem.
The statement... Igor Skornyakov

11:37 AM Feature #6454: database informational features

Igor Skornyakov wrote:
> * It looks that the only database restriction we have to support is @READ-ONLY@. Should be ... Igor Skornyakov

10:04 AM Feature #6454: database informational features

Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > Constantin Asofiei wrote:
> > > Igor, RCODE-INFO:TABLE-LIST... Igor Skornyakov

09:59 AM Feature #6454: database informational features

Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor, RCODE-INFO:TABLE-LIST is already added in 6129b.
>
... Constantin Asofiei

09:18 AM Feature #6454: database informational features

Constantin Asofiei wrote:
> Igor, RCODE-INFO:TABLE-LIST is already added in 6129b.
Constantin,
I see only @Rcode... Igor Skornyakov

02:49 AM Feature #6454: database informational features

Igor, RCODE-INFO:TABLE-LIST is already added in 6129b. Constantin Asofiei

04:47 AM Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode

Committed 3821c/rev.14395. Made the changes mentioned in #6708-12 and fixed a problem where preselect and dynamic cal... Dănuț Filimon

11/27/2022

01:06 PM Feature #6454: database informational features

* As I can see from the code @DBPARAM@ reports *all* parameters supported by FWD for @CONNECT@
* It looks that the o... Igor Skornyakov

11/26/2022

02:09 AM Feature #6448: make location of LOB files configurable for import

Ovidiu Maxiniuc wrote:
> Review of @lobs.diff@:
>
> Good job! Implemented as requested in #6448-2.
> Please do t... Igor Skornyakov

10:21 PM Feature #6448: make location of LOB files configurable for import

Review of @lobs.diff@:
Good job! Implemented as requested in #6448-2.
Please do the cleanup (fix indentation of l... Ovidiu Maxiniuc

11/25/2022

05:40 PM Feature #6459: query features

Eric Faulhaber wrote:
> Igor, I'm looking into the history of this part of the code. I don't think it's as simple as... Greg Shah

01:35 PM Feature #6459: query features

Eric Faulhaber wrote:
> Igor, I'm looking into the history of this part of the code. I don't think it's as simple as... Igor Skornyakov

11:08 AM Feature #6459: query features

Igor, I'm looking into the history of this part of the code. I don't think it's as simple as releasing the record unc... Eric Faulhaber

05:59 AM Feature #6459: query features

Constantin Asofiei wrote:
> What's the stacktrace where #6459-5 calls @throwOffend()@?
Here it is:... Igor Skornyakov

05:24 AM Feature #6459: query features

Igor Skornyakov wrote:
> According to my tests, both forms of @FIRST-OF@/@LAST-OF@ are fully supported.
>
> I've... Constantin Asofiei

05:31 PM Support #6709: track nested FIND inside a related FOR loop

OK, this is close to correct.
1. Please switch out the use of a @Stack@ for the @ScopedSymbolDictionary@. The i... Greg Shah

07:11 AM Support #6709: track nested FIND inside a related FOR loop

I made the changes for the report. Now, it can track FIND statements that reference the same buffer as the FOR EACH i... Dănuț Filimon

05:30 PM Bug #6919: fix ErrorManager.displayError in TempTableBuilder

Review of @6919.diff@.
Good job! There were a lot of methods to check.
Interesting findings. I was not expectin... Ovidiu Maxiniuc

12:51 PM Feature #6454 (WIP): database informational features

Igor Skornyakov

12:50 PM Feature #6448: make location of LOB files configurable for import

Implemented as described in #6448-2.
The attached .diff file is for 6129b/14333.
Please review.
Thank you.
Igor Skornyakov

10:19 AM Feature #6448: make location of LOB files configurable for import

Igor Skornyakov wrote:
> I've got the following exception on the database import with 6129b/14333.
> [...]
> Is it... Igor Skornyakov

10:01 AM Feature #6448: make location of LOB files configurable for import

I've got the following exception on the database import with 6129b/14333.... Igor Skornyakov

08:04 AM Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode

Nice work! I could generate insightful reports using customer applications. I will suggest only some fine tuning here... Alexandru Lungu

11/24/2022

10:57 AM Feature #6582: implement multi-table AdaptiveQuery

> consider way stronger optimizations directly in the H2 engine: this involves some extended work into the H2 optimiz... Greg Shah

10:56 AM Feature #6582: implement multi-table AdaptiveQuery

*CHECKPOINT*
I am pending the work here as I can't find any more consistent optimizations to motivate that multi-t... Alexandru Lungu

10:24 AM Support #6709: track nested FIND inside a related FOR loop

> This is my intent, but I wanted to share my work until now.
Understood. No worries.
> Also, I guess you mean... Greg Shah

05:00 AM Support #6709: track nested FIND inside a related FOR loop

Greg Shah wrote:
> Neither annotations/annotations.xml and annotations/annotations_prep.xml can't be used for the ne... Dănuț Filimon

10:05 AM Feature #6453: temp-table features

> Eric, what should we do: remove this list or expose this as a enhanced feature with a method in SESSION handle?
... Greg Shah

01:15 AM Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> > Actually, if we replace throwing @XmlStreamException@ with @return false@ this will resul... Igor Skornyakov

08:13 PM Feature #6453: temp-table features

Igor Skornyakov wrote:
> In fact, I do not understand why we add @TempTableBuilder@ to the @HandleChain@. I have not... Ovidiu Maxiniuc

09:43 AM Feature #6448 (WIP): make location of LOB files configurable for import

Igor Skornyakov

09:42 AM Feature #6459: query features

I do not see how we can reliably figure out how the @CACHE@ attribute value affects the performance. Such things usua... Igor Skornyakov

09:39 AM Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode

Committed 3821c/rev.14384. I applied all the suggestions mentioned by Alexandru in #6708-7 and moved all the changes ... Dănuț Filimon

09:06 AM Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode

I rebased 6708a with 3821c. Danut, you can now move the changes from 6708a to 3821c. Alexandru Lungu

11/23/2022

01:39 PM Feature #6453: temp-table features

Igor Skornyakov wrote:
> In fact, the caller of this method just returns @false@ on @XmlStreamException@. Since this... Igor Skornyakov

06:52 AM Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> This class is unique in the fact that we have control of the short lifetime of the @TempTab... Igor Skornyakov

11:16 AM Support #6709: track nested FIND inside a related FOR loop

Code Review 6709-rpt.diff
Neither @annotations/annotations.xml@ and @annotations/annotations_prep.xml@ can't be us... Greg Shah

07:40 AM Support #6709: track nested FIND inside a related FOR loop

I took a different approach after taking a look at #3194 and modified how the report is made. I created a new rule se... Dănuț Filimon

06:20 AM Bug #6923: inner transaction block reverts too much

I attached a patch with some changes that, in my opinion, make more sense than the current implementation. Mainly, th... Radu Apetrii

11/22/2022

01:52 PM Feature #6453: temp-table features

Igor Skornyakov wrote:
> Sorry, but I'm confused. We create a new @TempTableBuilder@ instance e.g. in the @readTable... Ovidiu Maxiniuc

12:41 PM Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> The problem is that @TempTableBuilder@ -s are @HandleChain@ objects which are kept in a lin... Igor Skornyakov

08:41 AM Feature #6459: query features

According to my tests, both forms of @FIRST-OF@/@LAST-OF@ are fully supported.
I've also fixed the problem with @... Igor Skornyakov

11/21/2022

05:58 PM Bug #6919 (WIP): fix ErrorManager.displayError in TempTableBuilder

I am attaching my changes for review. This should be the complete implementation, I will do more testing tomorrow. Boris Schegolev

02:57 PM Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> Related to 6129b/14329: after @ErrorManager.recordOrShowError@ do not @throw@ a new excepti... Igor Skornyakov

02:21 PM Feature #6453: temp-table features

Igor,
Related to 6129b/14329: after @ErrorManager.recordOrShowError@ do not @throw@ a new exception. After the 4GL... Ovidiu Maxiniuc

09:52 AM Feature #6453: temp-table features

Greg Shah wrote:
> >> how safe is to abend here?
> > I think that it is safe because actually, it should never happ... Igor Skornyakov

07:30 AM Feature #6453: temp-table features

>> how safe is to abend here?
> I think that it is safe because actually, it should never happen if the schema is co... Greg Shah

07:40 AM Bug #6940 (Test): unqualified field name resolution when there is an explicit buffer defined in a...

Code Review Task Branch 6129b Revision 14327
The concept of the change is sound. Combined with the fact that it d... Greg Shah

07:38 AM Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...

In the end there was no information in email, @testcases/uast/@, Redmine or @bzr@ that could lead be back to the orig... Greg Shah

11/19/2022

08:16 AM Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...

There is no change in the application used for task #346. In the customer's app, all changes look 'expected', the pa... Constantin Asofiei

08:00 AM Feature #6453: temp-table features

Constantin Asofiei wrote:
> Review for 6129b/14326:
> * how safe is to abend here?
> [...]
I think that it is saf... Igor Skornyakov

07:41 AM Feature #6453: temp-table features

Review for 6129b/14326:
* how safe is to abend here?... Constantin Asofiei

11/18/2022

05:51 PM Feature #6450 (Closed): buffer/buffer-field features

Eric Faulhaber

01:59 PM Feature #6450: buffer/buffer-field features

Yes, I think so.
Note that, unlike #6444 (where the changes were committed to 3821c), this task uses 6129a/b. Ovidiu Maxiniuc

10:50 AM Feature #6450: buffer/buffer-field features

Can this be closed? Eric Faulhaber

01:50 PM Feature #6444: dataset improvements

Eric Faulhaber wrote:
> Ovidiu, could you please review the list above and indicate what the actual support is curre... Ovidiu Maxiniuc

01:14 PM Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...

The change was introduced in trunk revision 4785:... Greg Shah

12:56 PM Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...

I think the intent was to promote the parameter buffer, and not the 'source' for the parameter buffer. For example, ... Constantin Asofiei

12:13 PM Feature #6459: query features

Greg Shah wrote:
> There are 2 forms of these: built-in function and handle-based method.
>
> Built-In Function f... Igor Skornyakov

11:42 AM Feature #6459: query features

There are 2 forms of these: built-in function and handle-based method.
Built-In Function form:... Greg Shah

10:21 AM Feature #6459: query features

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > In 6129b both @FIRST-OF@ and @LAST-OF@ are set to @rw.cvt_l... Igor Skornyakov

10:20 AM Feature #6459: query features

The @convert/methods_attributes.rules@ has support for both methods. Subclasses of @P2JQuery@ like @Persorter@ have ... Greg Shah

10:05 AM Feature #6459: query features

Igor Skornyakov wrote:
> In 6129b both @FIRST-OF@ and @LAST-OF@ are set to @rw.cvt_lvl_full | rw.rt_lvl_full@
... Eric Faulhaber

09:42 AM Feature #6459: query features

Greg Shah wrote:
> > As far as I can see from my test, @FIRST-OF@, @LAST-OF@ methods are fully supported.
>
> At ... Igor Skornyakov

09:17 AM Feature #6459: query features

> As far as I can see from my test, @FIRST-OF@, @LAST-OF@ methods are fully supported.
At a minimum, the gap marki... Greg Shah

08:37 AM Feature #6459: query features

As far as I can see from my test, @FIRST-OF@, @LAST-OF@ methods are fully supported.
However, I see the following is... Igor Skornyakov

09:56 AM Feature #6453 (Closed): temp-table features

Eric Faulhaber

01:36 AM Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> Only one change before the commit, please: in @XmlImport.java@, instead of [...]use[...]
>... Igor Skornyakov

08:24 AM Bug #6923: inner transaction block reverts too much

Thank you for the explanations!
I've taken them on board and I have seen that the bug is in fact about the restorati... Radu Apetrii

08:01 AM Support #6709: track nested FIND inside a related FOR loop

Nice! Please post the diff so I can review the approach. It can be tricky to do this kind of static analysis becaus... Greg Shah

05:51 AM Support #6709: track nested FIND inside a related FOR loop

Greg Shah wrote:
> We are trying to evaluate how often in real 4GL code does this condition occur? Getting a measure... Dănuț Filimon

11/17/2022

06:39 PM Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...

FYI, I'm digging back through the history on this one. I'll pick it back up in the morning. Greg Shah

08:02 AM Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...

The patch is built on top of 6129b/14324. Constantin Asofiei

08:01 AM Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...

Greg, the problem is that for a @DEF PARAM BUFFER ... FOR some-buf@ statement, @some-buf@ gets promoted because @def_... Constantin Asofiei

02:52 AM Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...

The problem is when a buffer is defined explicitly as a parameter - FWD doesn't resolve the unqualified field properl... Constantin Asofiei

02:46 AM Bug #6940 (Test): unqualified field name resolution when there is an explicit buffer defined in a...

Constantin Asofiei

03:18 PM Feature #6453: temp-table features

Only one change before the commit, please: in @XmlImport.java@, instead of ... Ovidiu Maxiniuc

02:20 PM Feature #6453 (Review): temp-table features

Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
> > Review of @read-xmlschema.diff@:
> [...]
> Can I commit the c... Eric Faulhaber

05:03 AM Feature #6453: temp-table features

Tests used for this task committed to @xfer.goldencode.com/opt/testcases/temp-table-marshal@. rev. 1300.
Igor Skornyakov

01:58 AM Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> Review of @read-xmlschema.diff@:
> * @AbstractTempTable@: the new method lacks the javadoc... Igor Skornyakov

02:32 PM Feature #6371: implement SAVE CACHE statement

FYI, I am re-working the class unloading, which will not work currently in "real" use scenarios. When we create a DMO... Eric Faulhaber

02:02 PM Bug #6923: inner transaction block reverts too much

Eric Faulhaber wrote:
> ...the fact that the results are different in your first test case between temp-table and pe... Eric Faulhaber

01:52 PM Bug #6923: inner transaction block reverts too much

When you nest transactions like:... Eric Faulhaber

06:50 AM Bug #6923 (WIP): inner transaction block reverts too much

An update to this issue:
I narrowed down the code, in order to describe what I have found until this moment. This is... Radu Apetrii

12:02 PM Feature #6418: represent extent fields as arrays

Alexandru Lungu wrote:
> Eric, is there any prior partial implementation/discussion into the array fields?
There ... Eric Faulhaber

03:29 AM Feature #6418: represent extent fields as arrays

Eric, is there any prior partial implementation/discussion into the array fields? If no, this task can be the lead ef... Alexandru Lungu

07:35 AM Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

The @2137_20221114a.patch@ patch was committed to 3821c/14369, with these notes:
* only NO-LOCK records are loaded a... Constantin Asofiei

07:34 AM Bug #6941: conversion issue when using undo in do transaction

There is a problem when converting examples that contain an @undo@ statement inside a @do transaction@.
For example,... Radu Apetrii

07:20 AM Bug #6941 (Rejected): conversion issue when using undo in do transaction

Radu Apetrii

05:40 AM Feature #6816: improve PreselectQuery.assembleHQL

For an initial check, I recommend implementing a very small suite of performance tests (~6) for @PreselectQuery@ to t... Alexandru Lungu

03:33 AM Feature #6816 (WIP): improve PreselectQuery.assembleHQL

Alexandru Lungu

11/16/2022

03:54 PM Feature #6453: temp-table features

Review of @read-xmlschema.diff@:
* @AbstractTempTable@: the new method lacks the javadoc;
* @XmlImport@:
** method... Ovidiu Maxiniuc

11:59 AM Feature #6453: temp-table features

Finished with fixing @READ-XMLSCHEMA@ support for DATASET.
Please review.
Thank you.
I understand that the tas... Igor Skornyakov

01:01 PM Feature #6459: query features

Igor, please focus only on the first bullet point (i.e., @QUERY@ handle) items. Eric Faulhaber

12:28 PM Feature #6448: make location of LOB files configurable for import

Eric Faulhaber wrote:
> Currently, the location is hard-coded to a @lobs@ sub-directory of the directory containing ... Eric Faulhaber

10:16 AM Feature #6938: XML seriliazation improvement

At this moment the @XMLExport@ class uses manual formatting of the document based on @indent()@/@leneBreak()@ calls (... Igor Skornyakov

10:08 AM Feature #6938 (New): XML seriliazation improvement

Igor Skornyakov

10:14 AM Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode

3821c is fine. Thanks. Eric Faulhaber

09:04 AM Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode

I have no objection.
Eric: Where should the changes go? I'd prefer 3821c. Greg Shah

06:27 AM Support #6708 (WIP): track/report at runtime when AdaptiveQuery shifts into dynamic mode

Greg, can we consider moving this change to 3821c or 6129b? It does not change the FWD core behavior; it only augment... Alexandru Lungu

06:34 AM Support #6709: track nested FIND inside a related FOR loop

This is a good analysis. It certainly highlights the differences in control flow and danger of refactoring such code... Greg Shah

05:57 AM Support #6709 (WIP): track nested FIND inside a related FOR loop

Dănuț Filimon

05:36 AM Support #6709: track nested FIND inside a related FOR loop

From what I understood, we want to test if either nested find or joined approach is better. After a few tests using t... Dănuț Filimon

05:56 AM Feature #5355 (WIP): _Usertablestat metadata improvements

Alexandru Lungu

05:47 AM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...

Any news about the review? Dănuț Filimon

11/15/2022

09:33 AM Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Right. I failed to notice the @field@ is updated in inner loop. Ovidiu Maxiniuc

08:07 AM Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Ovidiu Maxiniuc wrote:
> Review of @2137_20221114a.patch@:
> I have a single issue in the new patch, in @AbstractQu... Constantin Asofiei

06:45 AM Feature #6928: H2 UPDATE performance improvement

In H2, when doing an UPDATE statement,the approach is to:
* create a new row
* assign all columns not part of the U... Constantin Asofiei

03:49 AM Feature #6928 (Closed): H2 UPDATE performance improvement

Constantin Asofiei

11/14/2022

06:37 PM Feature #6371: implement SAVE CACHE statement

Pushed revision 6371a/14121. Based on testing, added more mappings for column types and moved mapping to @Dialect@ pl... Boris Schegolev

02:03 PM Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Constantin Asofiei wrote:
> Ovidiu, please review attached. This adds denormalized extent for FIELDS/EXCEPT. norma... Ovidiu Maxiniuc

10:31 AM Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Ovidiu, please review attached. This adds denormalized extent for FIELDS/EXCEPT. normalized extent is still not sup... Constantin Asofiei

01:24 PM Feature #6453: temp-table features

It appears that @READ-XMLSCHEMA@ for the @DATASET@ is broken even in the situation of a single namespace (w/o externa... Igor Skornyakov

11:01 AM Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> Certainly, the patch is clearly an improvement over the current revision on bzr. Please c... Igor Skornyakov

10:44 AM Feature #6453: temp-table features

Igor Skornyakov wrote:
> > What I meant was that a @ClassCastException@ could be thrown if code inside FWD will ca... Ovidiu Maxiniuc

10:42 AM Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > Why not extend @XMLStreamWriter@ so that it will care about ind... Igor Skornyakov

10:37 AM Feature #6453: temp-table features

Igor Skornyakov wrote:
> Why not extend @XMLStreamWriter@ so that it will care about indentation itself? [...] What ... Ovidiu Maxiniuc

12:28 PM Bug #6887: improve performance of dataset/table[-handle] parameters

I've edited previous note to add @delete object hds1.@ to @dstest.p@ - with this, OE is in the 200ms range, while FWD... Constantin Asofiei

12:04 PM Bug #6887: improve performance of dataset/table[-handle] parameters

A starting point for a test to check the performance is this, made of two programs:
# @dstest.p@ which defines inter... Constantin Asofiei

09:07 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

Alexandru, I have in a heap dump @UnclosablePreparedStatement@ instances with ~90KB retained heap. But in at least a... Constantin Asofiei

06:23 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

I've done some simple debugging in Hotel GUI with @UnclosablePreparedStatement@. The @psCache@ structure is an @Expir... Alexandru Lungu

07:46 AM Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode

Committed 6708a/rev.14328. Made improvements to AdaptiveQuery method tracing.
I made changes and now it is possibl... Dănuț Filimon