Activity

From 01/16/2023 to 02/14/2023

02/14/2023

06:29 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Review of @ffCache-20230214.patch@.
Nice detective work. Indeed, there seems to be a key collision which causes th... Ovidiu Maxiniuc
06:18 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: I've done some changes to how strings are compared in H2. I included a @rtrim@ parameter that, if set to true (by def... Dănuț Filimon
04:08 PM Bug #7120 (WIP): NO-UNDO dynamic temp-table does not set the NO-UNDO at the .schema: Good analysis!
Actually, the value of the @undo@ table attribute is not copied from the source table. It is by defau... Ovidiu Maxiniuc
07:00 AM Bug #7120: NO-UNDO dynamic temp-table does not set the NO-UNDO at the .schema: This test:... Constantin Asofiei
06:58 AM Bug #7120 (Test): NO-UNDO dynamic temp-table does not set the NO-UNDO at the .schema: Constantin Asofiei
12:28 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB: Igor Skornyakov wrote:
> Finished with error Handler support for MariaDB.
> Because of #7113 it was tested with a s... Igor Skornyakov
08:12 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: Dănuț Filimon wrote:
> Committed 6829a_h2/rev.7. Stopped forced re-parsing for prepared statements.
>
> Each SELE... Alexandru Lungu
07:10 AM Support #7058: get the FWD fork of the H2 code base under version control: Will pre-built FWD-H2 revisions jars be uploaded into GCD repository ?
Tomasz Domin
07:00 AM Support #7058: get the FWD fork of the H2 code base under version control: *UPDATE*: regression testing passed; merged 6928a_h2 to FWD-H2 trunk including performance improvements for UPDATE st... Alexandru Lungu
07:01 AM Feature #6928 (Test): H2 UPDATE performance improvement: Merged 6928a_h2 to FWD-H2 trunk including performance improvements for UPDATE statement, with in-memory and PageStore... Alexandru Lungu
06:52 AM Feature #6928: H2 UPDATE performance improvement: Thanks, the change is OK. It can be merged to trunk. Constantin Asofiei
06:26 AM Feature #6928: H2 UPDATE performance improvement: Constantin Asofiei wrote:
> Was the branch bound? I don't see rev 11 for 6928a_h2.
What a quick response! My bzr ... Alexandru Lungu
06:23 AM Feature #6928: H2 UPDATE performance improvement: Alexandru Lungu wrote:
> Tested 6928a_h2/rev. 10 and found a regression: the old-row stored by @deltaChangeCollector... Constantin Asofiei
06:20 AM Feature #6928: H2 UPDATE performance improvement: Tested 6928a_h2/rev. 10 and found a regression: the old-row stored by @deltaChangeCollector@ inside the H2 update sta... Alexandru Lungu
06:48 AM Feature #7061: Enable the use of lazy result sets in H2: I've added the option to execute queries in a lazy manner. Alongside this change, @AdaptiveQuery@ now uses only @Scro... Radu Apetrii
01:22 AM Bug #7113: Problem with nested CAN-FIND conversion: Ovidiu Maxiniuc wrote:
> The nested CAN-FIND is an old issue. There were some fixes in time (see #3040, #3465, #3771... Igor Skornyakov
09:22 PM Feature #7037: remove dirty share manager: Review of @7037b.diff@.
A clean implementation. Nice job. The patch should work as described in note #7037-35.
Pl... Ovidiu Maxiniuc

02/13/2023

06:17 PM Feature #6371: implement SAVE CACHE statement: Attaching a working version of sequences support in @SchemaCheck@ and @SchemaValidator@ for review. Boris Schegolev
05:20 PM Bug #7113: Problem with nested CAN-FIND conversion: The nested CAN-FIND is an old issue. There were some fixes in time (see #3040, #3465, #3771, and others) and the issu... Ovidiu Maxiniuc
09:13 AM Bug #7113 (WIP): Problem with nested CAN-FIND conversion: Igor Skornyakov
05:19 AM Bug #7113: Problem with nested CAN-FIND conversion: Thank you for checking, you can continue with your normal tasks. Constantin Asofiei
05:03 AM Bug #7113: Problem with nested CAN-FIND conversion: Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > One more thing: is this a regression in 6129c compared to tr... Igor Skornyakov
05:02 AM Bug #7113: Problem with nested CAN-FIND conversion: Constantin Asofiei wrote:
> One more thing: is this a regression in 6129c compared to trunk?
No, I get the same e... Igor Skornyakov
04:54 AM Bug #7113: Problem with nested CAN-FIND conversion: One more thing: is this a regression in 6129c compared to trunk? Constantin Asofiei
04:52 AM Bug #7113: Problem with nested CAN-FIND conversion: Constantin Asofiei wrote:
> So instead of @?@ it should be @Order.OrderNum@ and @OrderLine.ItemNum@, respectively? I... Igor Skornyakov
04:25 AM Bug #7113: Problem with nested CAN-FIND conversion: Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > What's the problem with the query? What would be the correct... Constantin Asofiei
04:23 AM Bug #7113: Problem with nested CAN-FIND conversion: Constantin Asofiei wrote:
> What's the problem with the query? What would be the correct variant? If you change the ... Igor Skornyakov
04:16 AM Bug #7113: Problem with nested CAN-FIND conversion: What's the problem with the query? What would be the correct variant? If you change the FQL manually to the correct v... Constantin Asofiei
03:02 AM Bug #7113: Problem with nested CAN-FIND conversion: The problem is at the program conversion (not only runtime).
The query from the previous noye is converted to... Igor Skornyakov
09:14 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB: Greg Shah wrote:
> > Because of #7113 it was tested with a simple test only
>
> Go ahead and fix this now.
OK... Igor Skornyakov
08:48 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB: > Because of #7113 it was tested with a simple test only
Go ahead and fix this now. Greg Shah

02/12/2023

11:03 AM Feature #6628 (Review): port PostgreSQL native user defined functions to MariaDB: Igor Skornyakov
11:03 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB: Finished with error Handler support for MariaDB.
Because of #7113 it was tested with a simple test only
Please rev... Igor Skornyakov
07:45 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB: Igor Skornyakov wrote:
> I've encoutered a weird problem with MariaDB that makes the error handling based on @initEr... Igor Skornyakov
07:01 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB: I've encoutered a weird problem with MariaDB that makes the error handling based on @initError@/@checkError@ impossib... Igor Skornyakov
04:25 AM Bug #7113: Problem with nested CAN-FIND conversion: Consider the following statement:... Igor Skornyakov
04:18 AM Bug #7113 (Review): Problem with nested CAN-FIND conversion: Igor Skornyakov

02/11/2023

10:59 AM Feature #6928: H2 UPDATE performance improvement: Rebased 6928a_h2 rev 8 from fwd-h2.trunk rev 8 - new rev 10. Constantin Asofiei
09:38 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB: I tried using the call stack you provided but it seems different from 6129c/14808. The code at @FqlToSqlConverter.jav... Ovidiu Maxiniuc

02/10/2023

10:56 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB: I've experienced problem with CAN-FIND (6129c/14808).
When creating the query from the attached test I get the follo... Igor Skornyakov
09:54 AM Feature #7062: Direct access to H2 internals to solve basic queries: I committed 7062a_h2/rev. 9 the changes to H2 to allow direct access.
There is a patch here on the changes required ... Alexandru Lungu
08:22 AM Feature #7062: Direct access to H2 internals to solve basic queries: I've redone the tests with direct access:
* Computed columns are now marked as invisible in H2.
* Before returning ... Alexandru Lungu
05:08 AM Feature #7037: remove dirty share manager: Ovidiu: Please review. Greg Shah

02/09/2023

12:53 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Please test how the right-padding spaces are handled. An important element in the expressions above is the @rtrim@ fu... Ovidiu Maxiniuc
10:49 AM Bug #7108 (WIP): Simulate upper/rtrim directly in H2 using case specific columns: Consider supporting case specific operators directly in H2 for character fields. For case-insensitive character field... Alexandru Lungu
10:42 AM Bug #7108 (Closed): Simulate upper/rtrim directly in H2 using case specific columns: Alexandru Lungu
10:54 AM Feature #6995 (Review): possibly support NO-UNDO temporary tables directly in H2: Rebased from trunk and merged 6995a_h2 to FWD-H2 trunk: includes the addition of a NO-UNDO keyword being natively sup... Alexandru Lungu
10:53 AM Support #7058: get the FWD fork of the H2 code base under version control: *UPDATE*: regression testing passed; merged 6995a_h2 to FWD-H2 trunk including the addition of a NO-UNDO keyword bein... Alexandru Lungu
10:42 AM Feature #7062: Direct access to H2 internals to solve basic queries: Alexandru Lungu wrote:
> > In the absence of a SQL option to SELECT * EXCEPT __ifield1, __sfield2 FROM... I think we... Alexandru Lungu
06:55 AM Bug #7035: Extract query parameters from statically converted FQL: Alexandru Lungu wrote:
> I get a NPE in com.goldencode.p2j.persist.ParameterDiff.getSubstParameters(ParameterDiff.ja... Dănuț Filimon

02/08/2023

10:56 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: Eric Faulhaber wrote:
> Has anyone who has looked inside H2 gotten a sense of how that cache interacts with our prep... Alexandru Lungu
10:09 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: Dănuț Filimon wrote:
> Committed 6829a_h2/rev.7. Stopped forced re-parsing for prepared statements.
>
> Each SELE... Alexandru Lungu
09:46 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2: Alexandru Lungu wrote:
> Radu, please redo the FWD patch considering my first comment in #6995-16 regarding @getCrea... Radu Apetrii
03:41 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2: Code review @6995-6129b.patch@ and @fwd-h2-6995.patch@:
Nice work, Radu!
I agree with Alexandru's comments in #... Eric Faulhaber
08:48 AM Support #7058: get the FWD fork of the H2 code base under version control: Alexandru Lungu wrote:
> I am planning to merge 7046_h2 to the FWD-H2 trunk after handling #7085-3 (test suite segre... Alexandru Lungu
04:00 AM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it: Ovidiu Maxiniuc wrote:
> Unless this can be configured somewhere else. Or if there is another data type for this?
... Eric Faulhaber

02/07/2023

06:44 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: Committed 6829a_h2/rev.7. Stopped forced re-parsing for prepared statements.
Each SELECT/DELETE/UPDATE/INSERT quer... Dănuț Filimon
06:34 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2: Radu, please redo the FWD patch considering my first comment in #6995-16 regarding @getCreateTemporaryTablePostfix@ o... Alexandru Lungu
06:33 AM Support #7058: get the FWD fork of the H2 code base under version control: I am planning to merge 7046_h2 to the FWD-H2 trunk after handling #7085-3 (test suite segregation). There are still s... Alexandru Lungu

02/06/2023

06:45 PM Feature #7037: remove dirty share manager: Please review the diff (for the trunk 14478) which adds the following directory configuration parameters:
# In addit... Stanislav Lomany
03:50 PM Feature #6371: implement SAVE CACHE statement: Boris Schegolev wrote:
> Currently, my best option is adding SQLs to retrieve sequence information into individual... Eric Faulhaber
02:50 PM Feature #6371: implement SAVE CACHE statement: I am working on support for sequences in @SchemaCheck@ for use in validations and I wanted to have a confirmation tha... Boris Schegolev
04:43 AM Feature #7062: Direct access to H2 internals to solve basic queries: > Actually the prefixes for the computed columns in H2 dialect are __i and __s (for i gnore casing and case- s ensiti... Alexandru Lungu

02/04/2023

07:32 PM Feature #7062: Direct access to H2 internals to solve basic queries: Eric Faulhaber wrote:
> Ultimately, we create the SQL forms of the column names. So, we can use whatever we want as ... Ovidiu Maxiniuc

02/03/2023

06:53 PM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it: Thank you. I tried it now and it worked. I was able to create a table and execute a quick select statement over a cou... Ovidiu Maxiniuc
06:17 PM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it: I'm pretty sure @citext@ existed as an extension before PostgreSQL 11. I thought it was one of the core data types af... Eric Faulhaber
05:25 PM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it: The changes are necessary only if/when we decide to switch from case-sensitive character data types to case-insensiti... Ovidiu Maxiniuc
10:51 AM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it: It seems like note 11 is suggesting some changes to encode the logic in the dialects and fix the DDL generation. Greg Shah
10:49 AM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it: It sounds like this task can be closed, then, correct? Eric Faulhaber
05:17 PM Feature #7062: Direct access to H2 internals to solve basic queries: Ultimately, we create the SQL forms of the column names. So, we can use whatever we want as an identifier, if we find... Eric Faulhaber
04:20 PM Feature #7062: Direct access to H2 internals to solve basic queries: Actually the prefixes for the computed columns in H2 dialect are @__i@ and @__s@ (for *i* gnore casing and case- *s* ... Ovidiu Maxiniuc
10:34 AM Feature #7062: Direct access to H2 internals to solve basic queries: I extended my solution to cover all unique indexes. Most of the processing is done in @FQLPreprocessor@ to identify w... Alexandru Lungu
10:50 AM Feature #6348: implement support for MariaDB: Ovidiu Maxiniuc wrote:
> Committed revision 14396 / 6129b.
The change looks good. Can we close this task? Eric Faulhaber

02/02/2023

03:47 PM Feature #7062: Direct access to H2 internals to solve basic queries: Greg Shah wrote:
> You're saying that in the 4GL these have separate @recid@ values when a temp-table is passed as a... Ovidiu Maxiniuc
11:56 AM Feature #7062: Direct access to H2 internals to solve basic queries: Alexandru Lungu wrote:
> I may have misinterpreted FWD's behavior. I have seen multiple fields like "some_field" a... Eric Faulhaber
11:46 AM Feature #7062: Direct access to H2 internals to solve basic queries: Greg Shah wrote:
> > I only consider tables without computed-columns (date-time, extent or case-insensitive char fie... Alexandru Lungu
09:54 AM Feature #7062: Direct access to H2 internals to solve basic queries: > I only consider tables without computed-columns (date-time, extent or case-insensitive char fields)
In regard to... Greg Shah
05:51 AM Feature #7062: Direct access to H2 internals to solve basic queries: > Please also consider #6720; I don't yet know if lazy hydration should be applied to H2 embedded databases. I have t... Alexandru Lungu
03:26 PM Feature #7037: remove dirty share manager: Stanislav Lomany wrote:
> FYI I've found @uast/shared-dirty-records/p*.p@ and @uast/shared-dirty-records/leaking*.p@... Tomasz Domin
03:24 PM Feature #7037: remove dirty share manager: FYI I've found @uast/shared-dirty-records/p*.p@ and @uast/shared-dirty-records/leaking*.p@ testcases which "demonstra... Stanislav Lomany
01:18 PM Feature #6371: implement SAVE CACHE statement: Boris Schegolev wrote:
> Branch 6129b is frozen for now, so, let's take a look at what we know was not implemented b... Eric Faulhaber
08:27 AM Feature #6371: implement SAVE CACHE statement: > EXTENT support (currently, expanded mode only...
I think we only need expanded mode support. The old "denormali... Greg Shah
06:40 AM Bug #7088: Lazily initialize activeBundle inside RandomAccessQuery: I've done a slim test with ~40,000 find queries. ~13.000 of them used @ffCache@. The total time spent on activation w... Alexandru Lungu

02/01/2023

06:11 PM Feature #6371: implement SAVE CACHE statement: Branch 6129b is frozen for now, so, let's take a look at what we know was not implemented by now:
* more validatio... Boris Schegolev
04:28 PM Feature #6348: implement support for MariaDB: The update I was talking in #6348-54 was committed the next day in revision 14308 (see @MariaDbSequenceHandler.java@)... Ovidiu Maxiniuc
01:29 PM Feature #7062: Direct access to H2 internals to solve basic queries: > A copy in a separate logical or physical temp-table should have a distinct primary key (recid) value. This is the i... Greg Shah
01:26 PM Feature #7062: Direct access to H2 internals to solve basic queries: Eric Faulhaber wrote:
> Alexandru, one other thing to consider, which I suppose you've already noticed: we don't act... Eric Faulhaber
01:25 PM Feature #7062: Direct access to H2 internals to solve basic queries: Greg Shah wrote:
> > I empirically discovered that (recid) is always the primary key of our temp-tables in H2; multi... Eric Faulhaber
01:15 PM Feature #7062: Direct access to H2 internals to solve basic queries: Alexandru, one other thing to consider, which I suppose you've already noticed: we don't actually create unique indic... Eric Faulhaber
01:09 PM Feature #7062: Direct access to H2 internals to solve basic queries: > I empirically discovered that (recid) is always the primary key of our temp-tables in H2; multiplex is irrelevant. ... Greg Shah
12:54 PM Feature #7062: Direct access to H2 internals to solve basic queries: Alexandru Lungu wrote:
> I've finished implementing a simple mean of H2 direct access for @RAQ@ with simple @recid@ ... Eric Faulhaber
10:54 AM Feature #7062: Direct access to H2 internals to solve basic queries: I've finished implementing a simple mean of H2 direct access for @RAQ@ with simple @recid@ look-up. The results are f... Alexandru Lungu
01:00 PM Bug #7088: Lazily initialize activeBundle inside RandomAccessQuery: This makes sense. Although the cost currently is mitigated to some degree by caching in @FQLHelper@, there is still w... Eric Faulhaber
04:23 AM Bug #7088: Lazily initialize activeBundle inside RandomAccessQuery: There is relevant activity when building an @activeBundle@ in general, mostly related to FQL composition (@createBund... Alexandru Lungu
04:09 AM Bug #7088 (New): Lazily initialize activeBundle inside RandomAccessQuery: Alexandru Lungu
10:11 AM Feature #6444: dataset improvements: Rebased task branch 6444a to the trunk rev.14483.
Suspended working on this task while the trunk and 6129b are frozen. Igor Skornyakov
09:49 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2: Eric Faulhaber wrote:
> I have not yet reviewed the changes in detail, but my opinion is that removing all SQL redo ... Alexandru Lungu
09:40 AM Support #7058: get the FWD fork of the H2 code base under version control: Greg Shah wrote:
> See if you can just do some limited edits to Source Code Management to explain branching for FWD ... Alexandru Lungu
09:38 AM Bug #7035: Extract query parameters from statically converted FQL: *Review for patch #7035-9*
There is consistent work going on with this extraction and I am pleased with this new @Pa... Alexandru Lungu
04:23 AM Bug #7035: Extract query parameters from statically converted FQL: Eric Faulhaber wrote:
> Please add a test with such an extent field reference, and make sure it still works, both in... Dănuț Filimon

01/31/2023

05:11 PM Feature #6348: implement support for MariaDB: Ovidiu, are all the sequence features working now? Based on #6348-54 and the entries leading up to it, it seemed this... Eric Faulhaber
04:12 PM Feature #6348: implement support for MariaDB: Committed revision 14396 / 6129b. Ovidiu Maxiniuc
01:35 AM Feature #6348: implement support for MariaDB: Ovidiu Maxiniuc wrote:
> ... there are a few methods which still use @UnimplementedFeature@ to report missing featur... Eric Faulhaber
03:59 PM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it: The current implementation injects the upper/rtrim into FQLs of the queries at conversion time because it assumes at ... Ovidiu Maxiniuc
01:59 AM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it: What is left to do on the MariaDB side for:
* lenient mode?
* strict mode? Eric Faulhaber
03:55 PM Feature #6371: implement SAVE CACHE statement: I pushed revision 6129b/14395 with comment cleaning procedure and some JavaDoc that was missing. Boris Schegolev
02:13 AM Feature #6371: implement SAVE CACHE statement: Boris, please continue implementing the remaining items in #6371-119.
I've also noticed in the code that the colum... Eric Faulhaber
11:25 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2: I have not yet reviewed the changes in detail, but my opinion is that removing all SQL redo code from FWD is OK as lo... Eric Faulhaber
08:59 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2: > I am not necessarily sensitive with huge chunks of code being removed (less is faster), but should we keep some of ... Greg Shah
08:36 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2: Eric, I added you as a watcher now. Alexandru Lungu
08:27 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2: I tested 6995a_h2 with your FWD patch against a large customer application and there was no regression.
The performa... Alexandru Lungu
05:06 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2: I committed to 6995a_h2, rev.7 the changes that you asked for.
Also, when running @build.sh test@, the errors were ... Radu Apetrii
03:49 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2: Radu, based on our new FWD-H2 branching system #7058, I've created 6995a_h2 to hold your patch from #6995-13. However... Alexandru Lungu
09:08 AM Support #7058: get the FWD fork of the H2 code base under version control: See if you can just do some limited edits to Source Code Management to explain branching for FWD vs H2. Greg Shah
05:09 AM Support #7058: get the FWD fork of the H2 code base under version control: Greg, I've done only one documentation change to "Patching and Building Customized 3rd Party Libraries":/projects/p2j... Alexandru Lungu
08:25 AM Feature #7037: remove dirty share manager: Greg Shah wrote:
> > Cross-session use for the small set of tables (currently, only one I know of) which needs it.
... Tomasz Domin
05:38 AM Feature #7037: remove dirty share manager: > Cross-session use for the small set of tables (currently, only one I know of) which needs it.
Tomasz may have fo... Greg Shah
01:56 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB: Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > I think that error handling can be finished in 2-3 days.
>... Igor Skornyakov
01:32 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB: Igor Skornyakov wrote:
> I think that error handling can be finished in 2-3 days.
Please finish this when you ... Eric Faulhaber

01/30/2023

05:43 PM Feature #7037: remove dirty share manager: AFAICT, your assessment of how @DirtyShareSupport@ works currently is correct.
It seems we need to support the fol... Eric Faulhaber
03:03 PM Feature #7037: remove dirty share manager: In @DirtyShareSupport@ we effectively have @forceDirtyShare@ always enabled, and, correct me if I'm wrong, no convert... Stanislav Lomany
01:01 PM Feature #7037: remove dirty share manager: Stas, I'm sorry I did not remember this existing implementation. How does this overlap/conflict/differ with your rece... Eric Faulhaber
12:58 PM Feature #7037: remove dirty share manager: Stanislav Lomany wrote:
> As far as I understand, the following should happen when dirty sharing is disabled in the ... Eric Faulhaber
11:10 AM Feature #7037: remove dirty share manager: One more thing: what cases that should be tested to make sure then remain working after cross-session dirty sharing h... Stanislav Lomany
09:52 AM Feature #7061 (WIP): Enable the use of lazy result sets in H2: Alexandru Lungu
09:42 AM Feature #6371: implement SAVE CACHE statement: The documentation for this task is in [[p2j:Non-Standard Save Cache Implementation]]. Greg Shah
09:11 AM Support #7058: get the FWD fork of the H2 code base under version control: I'm glad the existing scripts worked. Greg Shah
08:33 AM Support #7058 (WIP): get the FWD fork of the H2 code base under version control: Added version control for our H2 fork:
* redesigned @code/p2j_repo/fwd-h2@ to honor the @active/dead/merged/trunk@ p... Alexandru Lungu
06:52 AM Support #7058: get the FWD fork of the H2 code base under version control: Greg Shah wrote:
> > Should we use the same branch naming convention (task number + ascending letters) as we use in ... Alexandru Lungu
07:03 AM Bug #6829 (WIP): H2 forces re-parse of all prepared statements when metadata is changed: Danut, please strictly refer to #6829-1 for the moment: consider the H2 performance of reparsing prepared statements ... Alexandru Lungu
03:17 AM Feature #6444: dataset improvements: Marian Edu wrote:
> Igor Skornyakov wrote:
> > Marian,
> > The description of the @SYNCHRONIZE@ method semantics i... Igor Skornyakov
03:12 AM Feature #6444: dataset improvements: Igor Skornyakov wrote:
> Marian,
> The description of the @SYNCHRONIZE@ method semantics in the OE documentation lo... Marian Edu

01/28/2023

03:54 AM Feature #6444: dataset improvements: Marian,
The description of the @SYNCHRONIZE@ method semantics in the OE documentation looks not very clear for me.
... Igor Skornyakov
03:35 AM Feature #6444: dataset improvements: > > And generally, please place the @{@ on a new line (FWD coding standard). I forgot to add this in my previous revi... Igor Skornyakov
02:56 AM Feature #6444: dataset improvements: Ovidiu Maxiniuc wrote:
> I looked in the log of FWD repository and, indeed it shows I added some implementation for ... Igor Skornyakov
08:22 PM Feature #6444: dataset improvements: I looked in the log of FWD repository and, indeed it shows I added some implementation for @synchronize@ method (and ... Ovidiu Maxiniuc
11:51 PM Feature #6371: implement SAVE CACHE statement: Rev 6129b/14392 fixes issues with setting initial values in the DMO interface. It also pulls in a newer MariaDB JDBC ... Eric Faulhaber

01/27/2023

12:08 PM Feature #6444: dataset improvements: Retrofitted Ovidio's changes for the @DynamicQueryHelper@ from 6129b to 6444a.
This resolves #6444-115. Reworked @Bu... Igor Skornyakov
09:57 AM Feature #6444: dataset improvements: Indeed, #6444-115 does not manifest itself in 6129b.
However, there are a lot of differences between this branch and... Igor Skornyakov
07:30 AM Feature #6444: dataset improvements: Ovidiu Maxiniuc wrote:
> I did a quick review of your commits up to 14485/6444a since 14480:
> AbstractQuery, Compo... Igor Skornyakov
02:24 AM Feature #6444: dataset improvements: Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > I've encountered a strange problem. Consider the following prog... Igor Skornyakov
10:44 AM Feature #6371: implement SAVE CACHE statement: I added same filtering for columns and indexes, it should save some CPU time. Also, MariaDB returns @boolean@ as @bit... Boris Schegolev
10:17 AM Feature #6371: implement SAVE CACHE statement: Filtering is resolved - see revision 6129b/14389. It also removes the TODO I had there. Boris Schegolev
07:21 AM Feature #6371: implement SAVE CACHE statement: Boris Schegolev wrote:
> I pushed 2 commits into 6129b - 14385 and 14386. Now our save-cache test programs operate o... Eric Faulhaber
09:16 AM Feature #7064: Analyze the performance impact of the implicit meta schema in H2: > org.h2.engine.Database.meta only stores information from non-temporary sessions, which we do not use
Although we... Greg Shah
08:34 AM Feature #7064 (WIP): Analyze the performance impact of the implicit meta schema in H2: Alexandru Lungu wrote:
> * H2 generates an implicit @INFORMATION_SCHEMA@ schema on database creation. This schema co... Radu Apetrii
07:58 AM Feature #7062 (WIP): Direct access to H2 internals to solve basic queries: I've done some consistent implementation for the @FIND tt WHERE recid(tt) = 2@ use-case. However, I am facing some li... Alexandru Lungu
10:58 PM Feature #6348: implement support for MariaDB: Indeed, there were several updates to the dialects. But there are some unfinished features:
* what I know for sure i... Ovidiu Maxiniuc

01/26/2023

06:20 PM Feature #6444: dataset improvements: Igor Skornyakov wrote:
> I've encountered a strange problem. Consider the following program:
> [...]
> It works fi... Ovidiu Maxiniuc
01:45 PM Feature #6444: dataset improvements: Finished support for the @SYNCHRONIZE@ method, albeit not in a very efficient way (see #6444-115, #6444-116).
Comm... Igor Skornyakov
11:53 AM Feature #6444: dataset improvements: Igor Skornyakov wrote:
> What is the right way to retrieve the value of the primary key from the @BufferImpl@ instan... Igor Skornyakov
10:02 AM Feature #6444: dataset improvements: What is the right way to retrieve the value of the primary key from the @BufferImpl@ instance.
Thank you. Igor Skornyakov
07:23 AM Feature #6444: dataset improvements: The @HQLPrepocessor.getFindByRowid@ method looks strange
# It checks only the first parameter. In my test the @rowid... Igor Skornyakov
05:40 AM Feature #6444: dataset improvements: I've found a workarount for #6444-115, but at the cost of more complicated (and expensive) query:... Igor Skornyakov
04:35 AM Feature #6444: dataset improvements: I've encountered a strange problem.
Consider the following program:... Igor Skornyakov
05:20 PM Feature #6371: implement SAVE CACHE statement: I pushed 2 commits into 6129b - 14385 and 14386. Now our save-cache test programs operate on PostgreSQL and MariaDB e... Boris Schegolev
06:28 AM Feature #6371: implement SAVE CACHE statement: I've manually ported the SAVE CACHE feature from trunk rev 14483 to 6129b and committed that as 6129b/14383. I have d... Eric Faulhaber
03:53 AM Feature #6371: implement SAVE CACHE statement: Boris, we were discussing the @datetime-tz@ implementation yesterday, but there is still a TODO in the code for the I... Eric Faulhaber
03:48 AM Feature #6371: implement SAVE CACHE statement: I committed 6371a/14458, which:
* implements thread safety to prevent concurrent schema checking and DMO generatio... Eric Faulhaber
02:09 PM Feature #7037: remove dirty share manager: As far as I understand, the following should happen when dirty sharing is disabled in the directory:
# Dirty databa... Stanislav Lomany
10:13 AM Bug #7035: Extract query parameters from statically converted FQL: Dănuț Filimon wrote:
> What is the purpose of @inlineSubstitutionParameter@? The modifications I made for extracting... Alexandru Lungu
08:21 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2: I've included in H2 a flag for temporary tables that shows whether or not a table is defined with @no-undo@. The main... Radu Apetrii
04:12 AM Feature #7076: make CAN-FIND avoid hydration: I found Ovidiu's comment in #5453-2 relevant for this task. Alexandru Lungu

01/25/2023

05:17 PM Feature #7076: make CAN-FIND avoid hydration: Let's go for the quick win. Greg Shah
04:43 PM Feature #7076: make CAN-FIND avoid hydration: It does, if we implement it as a sub-select (i.e., when it is a nested CAN-FIND in another query's WHERE clause).
... Eric Faulhaber
02:59 PM Feature #7076: make CAN-FIND avoid hydration: I assume we already do this, but just in case, does CAN-FIND avoid hydration? Greg Shah
02:58 PM Feature #7076 (Closed): make CAN-FIND avoid hydration: Greg Shah
04:07 PM Feature #6371: implement SAVE CACHE statement: Implemented validation "except for the implicit primary key index, the primary key may only appear at the end of a no... Boris Schegolev
02:28 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: > > For example, the @lvalue@ rule will be doing constant lookups of a wide range of possible matches while the actua... Greg Shah
02:10 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: In regard to writing things to disk for persistence between server runs, we could write the generated DMOs (bytecode)... Greg Shah
01:47 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Greg Shah wrote:
> I suspect there is still some significant improvement that can be made to the performance. The c... Ovidiu Maxiniuc
01:37 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Greg Shah wrote:
> I have another idea, which I think should be a "game changer". Let's write out the generated cla... Ovidiu Maxiniuc
10:25 AM Feature #6928: H2 UPDATE performance improvement: I added a patch that fixes the problem that I found earlier (and another one that I found while testing). Long story ... Radu Apetrii
05:36 AM Feature #6928: H2 UPDATE performance improvement: Radu, please debug this and fix it. Constantin Asofiei
05:34 AM Feature #6928: H2 UPDATE performance improvement: While working on another task, I stumbled upon an issue. With fwd-h2 rev.7 it worked fine, *but in rev.8 there seems ... Radu Apetrii
06:11 AM Feature #7061: Enable the use of lazy result sets in H2: Eric Faulhaber wrote:
> Alexandru Lungu wrote:
>
> > Adopting this idea means replacing @ProgressiveResults@ with... Alexandru Lungu
05:35 AM Feature #7061: Enable the use of lazy result sets in H2: Alexandru Lungu wrote:
> Adopting this idea means replacing @ProgressiveResults@ with @ScrollingResults@ backed by... Eric Faulhaber
06:09 AM Bug #7035: Extract query parameters from statically converted FQL: Dănuț Filimon wrote:
> Are there any cases where @NUM_LITERAL, DEC_LITERAL, STRING@ should not be substituted?
... Eric Faulhaber
05:59 AM Bug #7035: Extract query parameters from statically converted FQL: I wrote an implementation for that makes use of the @FQLPreprocessor.mainWalk@ method to parse the where clause AST a... Dănuț Filimon
05:38 AM Feature #7063: Support FIRST/LAST join directly in H2: Eric Faulhaber wrote:
> When converting FIND/FIRST LAST, whether as a joined query component (i.e., @RandomAccessQue... Alexandru Lungu

01/24/2023

05:32 PM Feature #7063: Support FIRST/LAST join directly in H2: Alexandru Lungu wrote:
> An alternative to this technique would be to introduce a @FIRST JOIN@ or @LAST JOIN@ into... Eric Faulhaber
11:10 AM Feature #6444: dataset improvements: Eric Faulhaber wrote:
> Igor, have you ported the changes needed from 6129b into 6444a? Where do you feel we now sta... Igor Skornyakov
10:53 AM Feature #6444: dataset improvements: Igor, have you ported the changes needed from 6129b into 6444a? Where do you feel we now stand on % Done for this iss... Eric Faulhaber
10:49 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB: Eric Faulhaber wrote:
> Igor, is this task finished, other than implementing your idea for error handling? How much ... Igor Skornyakov
10:44 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB: Igor, is this task finished, other than implementing your idea for error handling? How much effort do you think it is... Eric Faulhaber
10:40 AM Feature #6348: implement support for MariaDB: Ovidiu, as of 3821c/14182, we have this issue marked as 60% done. Many changes have been made since then, including l... Eric Faulhaber
06:17 AM Feature #7064: Analyze the performance impact of the implicit meta schema in H2: Alexandru Lungu wrote:
> Now that I am reading #7064-1 again, it needs some rephrasing indeed.
> I am mostly referr... Igor Skornyakov
05:48 AM Feature #7064: Analyze the performance impact of the implicit meta schema in H2: Igor Skornyakov wrote:
> Sorry, I do not understand what you mean. As far as I remember the META database contains i... Alexandru Lungu
06:13 AM Feature #7066: Implement multi-table indexed query in H2: You can simply check @prg.h2.result.SortOrder.sort@. This holds the @ORDER BY@ clause and is triggered only when H2 n... Alexandru Lungu
02:31 AM Feature #7066: Implement multi-table indexed query in H2: Alexandru, what H2 methods are responsible for this re-sorting of the rows? I want to check in the profiler. Constantin Asofiei
05:16 AM Feature #7062: Direct access to H2 internals to solve basic queries: Greg Shah wrote:
> This is really interesting. For temp-tables (and using H2 for a permanent database), it is conce... Alexandru Lungu
07:42 PM Feature #7020: always use "expanded" extent fields: Thank you Constantin for the link to wiki. I was able to identify the cause of the NPE. When retrieving meta informat... Ovidiu Maxiniuc

01/23/2023

06:57 PM Feature #6371: implement SAVE CACHE statement: I pushed a fix for the issue with removing columns. Also fixed another minor thing. See revision 14456. Boris Schegolev
04:50 PM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: Alexandru Lungu wrote:
> Constantin Asofiei wrote:
> > Alexandru, I've uncommited 6129b rev 14378. The changes in t... Eric Faulhaber
04:38 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: I created #7060 to target exactly the issue of wildcard usage, as a performance/memory management standalone improvem... Alexandru Lungu
04:14 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: Eric Faulhaber wrote:
> Alexandru Lungu wrote:
>
> > Committed 6129b/rev. 14378. This includes no alias columns f... Alexandru Lungu
03:17 PM Support #7058: get the FWD fork of the H2 code base under version control: > Should we use the same branch naming convention (task number + ascending letters) as we use in FWD? It probably mak... Greg Shah
03:11 PM Feature #7064: Analyze the performance impact of the implicit meta schema in H2: Sorry, I do not understand what you mean. As far as I remember the META database contains information about permanent... Igor Skornyakov
07:22 AM Feature #7064: Analyze the performance impact of the implicit meta schema in H2: There is a so called @INFORMATION_SCHEMA@ in H2 which is implicitly built: once for a shared temp-database and multip... Alexandru Lungu
07:02 AM Feature #7064 (Rejected): Analyze the performance impact of the implicit meta schema in H2: Alexandru Lungu
02:52 PM Feature #7062: Direct access to H2 internals to solve basic queries: This is really interesting. For temp-tables (and using H2 for a permanent database), it is conceptually close to the... Greg Shah
06:23 AM Feature #7062: Direct access to H2 internals to solve basic queries: I've done slim experiments with the H2 internals to understand how easy/fast is to interface directly with H2. I have... Alexandru Lungu
05:38 AM Feature #7062 (Closed): Direct access to H2 internals to solve basic queries: Alexandru Lungu
12:33 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: I have another idea, which I think should be a "game changer". Let's write out the generated classes (and any critic... Greg Shah
12:28 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: I suspect there is still some significant improvement that can be made to the performance. The core parsing might be... Greg Shah
09:25 AM Feature #7066: Implement multi-table indexed query in H2: As far as I could investigate H2, it seems like multi-table queries are severely lacking indexed traversal of joined ... Alexandru Lungu
09:08 AM Feature #7066 (WIP): Implement multi-table indexed query in H2: Alexandru Lungu
06:47 AM Feature #7063: Support FIRST/LAST join directly in H2: I recall spending some time in #6196 to identify a clean and short way to encode the 4GL FIRST/LAST semantics using S... Alexandru Lungu
06:24 AM Feature #7063 (New): Support FIRST/LAST join directly in H2: Alexandru Lungu
05:36 AM Feature #7061: Enable the use of lazy result sets in H2: *Prerequisites*
FWD converts most of the index-sorted single-table @FOR@ queries into @AdaptiveQuery@. With the effo... Alexandru Lungu
04:40 AM Feature #7061 (Closed): Enable the use of lazy result sets in H2: Alexandru Lungu
04:50 AM Feature #7060: Consider using wildcard selection to reduce SQL size: Please note that this change may require extensive testing and changes in some non-obvious places.
For example in m... Igor Skornyakov
04:35 AM Feature #7060: Consider using wildcard selection to reduce SQL size: There is initial work in #6829 on introducing wildcard selection (using @*@ symbol). This can reduce the size of an S... Alexandru Lungu
04:17 AM Feature #7060 (Closed): Consider using wildcard selection to reduce SQL size: Alexandru Lungu
02:53 AM Feature #6816: improve PreselectQuery.assembleHQL: Alexandru Lungu wrote:
> Looks good, no concerns.
Done. Committed to 6129b, rev. 14379. Radu Apetrii

01/20/2023

05:49 PM Feature #6371: implement SAVE CACHE statement: I found the root cause for the error you described. Luckily, it's not caching or so, but just a logical mistake (Sche... Boris Schegolev
02:27 PM Feature #7020: always use "expanded" extent fields: Thank you for doing the tests.
May I have some details on this abend? An error message or a stack trace / log file?
... Ovidiu Maxiniuc
03:41 AM Feature #7020: always use "expanded" extent fields: I've tested 7020a/14377 and there is an abend with a customer's application.
Constantin Asofiei
12:19 AM Feature #7020: always use "expanded" extent fields: Eric Faulhaber wrote:
> On the dynamic index issue, we will have the variable's value at runtime. Isn't this enough ... Ovidiu Maxiniuc
01:31 PM Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.: The original issue was #7043-4. Copied from there:... Stanislav Lomany
01:29 PM Bug #7059 (WIP): FWD shouldn't raise errors for non-numeric extent indexes.: Stanislav Lomany
12:57 PM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: Alexandru, I've uncommited 6129b rev 14378. The changes in this rev are in the attached patch. Constantin Asofiei
12:42 PM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: Alexandru Lungu wrote:
> Committed 6129b/rev. 14378. This includes no alias columns for all SELECT queries and wil... Eric Faulhaber
10:54 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: Alexandru Lungu wrote:
> Greg Shah wrote:
> > > However, we CAN do an inspection before the FQL->SQL conversion and... Constantin Asofiei
10:46 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: Greg Shah wrote:
> > However, we CAN do an inspection before the FQL->SQL conversion and, if there are none of these... Alexandru Lungu
12:37 PM Support #7058: get the FWD fork of the H2 code base under version control: We have entered a new phase of H2 performance improvement work, and there is already a set of changes we have been ma... Eric Faulhaber
12:31 PM Support #7058 (Closed): get the FWD fork of the H2 code base under version control: Eric Faulhaber
12:29 PM Feature #6928: H2 UPDATE performance improvement: Alexandru Lungu wrote:
> H2 rev. 7 is mostly targeting progressively fetched (using LIMIT) multi-table @AdaptiveQuer... Eric Faulhaber
11:37 AM Feature #6928: H2 UPDATE performance improvement: H2 rev. 7 is mostly targeting progressively fetched (using LIMIT) multi-table @AdaptiveQuery@. This is not yet part o... Alexandru Lungu
09:28 AM Feature #6928: H2 UPDATE performance improvement: H2's UPDATE command was profiled and improved to avoid object allocations and unnecessary iterations. This is in fwd... Constantin Asofiei
10:38 AM Feature #6816: improve PreselectQuery.assembleHQL: Looks good, no concerns. Alexandru Lungu
09:33 AM Feature #6816: improve PreselectQuery.assembleHQL: I think this can be committed to 6129b. Alexandru, any concerns? Constantin Asofiei
06:52 AM Feature #6816: improve PreselectQuery.assembleHQL: With Alex's help, I've managed to find an example that results in that error. The problem was my misinterpretation of... Radu Apetrii
03:11 AM Feature #6816: improve PreselectQuery.assembleHQL: I've tried the patch with a customer application and there is an abend:... Constantin Asofiei
10:34 AM Support #6714 (Review): check if there is an optimization opportunity when copying temp-tables ba...: Alexandru Lungu
09:53 AM Feature #6825: improve table meta runtime (TableMapper and other): The approach in #6825-4 improved the TableMapper memory and CPU footprint, but the access to these is still done in a... Constantin Asofiei
09:51 AM Feature #2137: runtime support for FIELDS/EXCEPT record phrase options: Current changes work, although normalized extent fields are always loaded. Otherwise, #6720 may touch this area again. Constantin Asofiei
07:11 AM Feature #2137: runtime support for FIELDS/EXCEPT record phrase options: 6129b/14377 has the EXCEPT/FIELDS support ported from trunk - this includes some work done by Sergey in #5731 Constantin Asofiei
04:55 AM Feature #6720: lazy hydration: Thanks for the second set of eyes, Alexandru! I was staring at this too long and completely missed that the second ca... Eric Faulhaber
04:08 AM Feature #6720: lazy hydration: Eric Faulhaber wrote:
> In the first conditional block, we check the session cache for a DMO with the primary key re... Alexandru Lungu
03:33 AM Feature #6720: lazy hydration: Ovidiu, Constantin, Alexandru, can you please help me understand this snippet of code in @SQLQuery.hydrateRecordImpl@... Eric Faulhaber
03:41 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Constantin Asofiei wrote:
> Ovidiu, did you meant to rebase 6813a on top of 7020a? See commits 14375 and 14376
I c... Constantin Asofiei
03:32 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Ovidiu, did you meant to rebase 6813a on top of 7020a? See commits 14375 and 14376 Constantin Asofiei
08:38 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: I have done the final clean-up and local tests and then rebased from @6129b@ and pushed to @../p2j/active/6813a/@. Th... Ovidiu Maxiniuc

01/19/2023

03:35 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > A NPE, OTOH, will immediately pinpoint to the source of the ... Constantin Asofiei
02:43 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Ovidiu Maxiniuc wrote:
> A NPE, OTOH, will immediately pinpoint to the source of the error.
Ovidiu, we need this in... Constantin Asofiei
02:40 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Sorry, I was not aware of this @Automatic Null Checking@ feature. My bad. I experimented the exact situation referred... Ovidiu Maxiniuc
02:06 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Ovidiu Maxiniuc wrote:
> Since @node@ is @null@, the original code will evaluate to @false@ without throwing NPE.
... Eric Faulhaber
01:49 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: > Since node is null, the original code will evaluate to false without throwing NPE. The upPath now will execute the ... Greg Shah
12:54 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: I understand. What is the appropriate action to do when @node@ is @null@ when replacing:... Ovidiu Maxiniuc
08:50 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: > I will investigate in-depth later tomorrow/today, but it looks to me like out JIT is not working correctly. Instead... Greg Shah
12:33 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Committed r14365 of 6813a. All occurrences have been processed and upgraded, including those from Java code and @prog... Ovidiu Maxiniuc
10:48 AM Feature #7037: remove dirty share manager: We have multiple applications which are dependent upon the record nursery (item 3 in #7037-6) but which do not (as fa... Greg Shah
08:02 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: > However, we CAN do an inspection before the FQL->SQL conversion and, if there are none of these special columns, th... Greg Shah
05:05 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: > You are right. However, we CAN do an inspection before the FQL->SQL conversion and, if there are none of these spec... Alexandru Lungu
07:51 PM Feature #7020: always use "expanded" extent fields: Ovidiu Maxiniuc wrote:
> I would like to keep it this way for a little, until the conversion is "expanded"-aware. ... Eric Faulhaber
07:36 PM Feature #7020: always use "expanded" extent fields: Eric Faulhaber wrote:
> Code review 7020a/14361-14362:
> Nice work! Thank you for turning it around in such a short... Ovidiu Maxiniuc
07:39 PM Feature #6371: implement SAVE CACHE statement: Boris, I agree that the messiness of the data type processing is not nice. If you have a way to simplify this while s... Eric Faulhaber

01/18/2023

05:29 PM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: Note that we also use H2's query cache (the default size is 8; we set it to 1024 in @H2Helper.setCommonInMemoryProper... Eric Faulhaber
05:13 PM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: I applaud efforts to make the SQL more compact and thereby reduce the memory consumption, and I agree we should pursu... Eric Faulhaber
04:29 PM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: Alexandru Lungu wrote:
> I agree that on a general case, this is not feasible. However, I have many examples of very... Ovidiu Maxiniuc
07:36 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: I've analyzed a heap dump without any alias generated for the columns. I got an ~8k chars long SQL string stored in a... Alexandru Lungu
06:19 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: Ovidiu Maxiniuc wrote:
> We cannot rely on H2 or any other SQL server to provide the right order of columns for our ... Alexandru Lungu
04:22 PM Feature #7020: always use "expanded" extent fields: Code review 7020a/14361-14362:
Nice work! Thank you for turning it around in such a short time.
TBH, it is hard... Eric Faulhaber
11:48 AM Feature #7020: always use "expanded" extent fields: Don't we already deal with this case in the current implementation of expanded extent fields? I may be misremembering... Eric Faulhaber
02:45 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > It seems that they never end :(. My IDE stops counting at 10... Eric Faulhaber
01:18 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Code Review Task Branch 6129b Revision 14360
The @DynamicConversionHelper@ and @DynamicQueryHelper@ need history e... Greg Shah
02:46 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Ovidiu Maxiniuc wrote:
> It seems that they never end :(. My IDE stops counting at 100+ occurrences. The vast majori... Constantin Asofiei
11:18 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: A new set of changes were committed to 6813a (r14364).
It seems that they never end :(. My IDE stops counting at 1... Ovidiu Maxiniuc
11:23 AM Feature #6444: dataset improvements: OK, then if Constantin has no objection, let's go with the manual retrofit approach. Eric Faulhaber
11:20 AM Feature #6444: dataset improvements: Eric Faulhaber wrote:
> Igor, which approach do you think requires the least amount of effort, both for you now, and... Igor Skornyakov
11:13 AM Feature #6444: dataset improvements: Igor, which approach do you think requires the least amount of effort, both for you now, and for merging 6129b to tru... Eric Faulhaber
10:21 AM Feature #6444: dataset improvements: Igor Skornyakov wrote:
> Greg Shah wrote:
> > We would like to do so, but it will not happen for at least 3 weeks.
... Igor Skornyakov
10:08 AM Feature #6444: dataset improvements: Greg Shah wrote:
> We would like to do so, but it will not happen for at least 3 weeks.
I see. In this case, mayb... Igor Skornyakov
10:06 AM Feature #6444: dataset improvements: We would like to do so, but it will not happen for at least 3 weeks. Greg Shah
05:25 AM Feature #6444: dataset improvements: As mentioned in #6444-83 DATA-SET serialization features should better be tested/fixed on top of changes made for #64... Igor Skornyakov
04:41 AM Feature #6444: dataset improvements: Rebased the task branch 6444a to the trunk/14480.
Pushed up to revision 14484.
Igor Skornyakov
06:11 AM Bug #7035: Extract query parameters from statically converted FQL: Eric Faulhaber wrote:
> Dănuț Filimon wrote:
> Note that there are other cases where we have to do some inlining ou... Alexandru Lungu
11:11 PM Bug #7035: Extract query parameters from statically converted FQL: Dănuț Filimon wrote:
> What is the purpose of @inlineSubstitutionParameter@? The modifications I made for extracti... Eric Faulhaber
04:06 AM Bug #7047: Problem with AdaptiveQuery and ScrollableResults: Added attachements Igor Skornyakov
04:04 AM Bug #7047: Problem with AdaptiveQuery and ScrollableResults: It looks like we have problems either with @AdaptiveQuery@ or @ScrollingResults@ (or both).
Consider the attached pr... Igor Skornyakov
04:03 AM Bug #7047 (New): Problem with AdaptiveQuery and ScrollableResults: Igor Skornyakov
07:42 PM Feature #6371: implement SAVE CACHE statement: OK, I pushed proper translation of datatypes for Postgres - rev 14454.
I have to say that I don't really like the ... Boris Schegolev

01/17/2023

05:53 PM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: We cannot rely on H2 or any other SQL server to provide the right order of columns for our properties. There are a lo... Ovidiu Maxiniuc
05:58 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: Alexandru Lungu wrote:
> * As a risky statement, the "*" wildcard can be used in many situations to reduce SQL size.... Alexandru Lungu
04:52 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: > Alexandru, I have in a heap dump UnclosablePreparedStatement instances with ~90KB retained heap. But in at least a ... Alexandru Lungu
03:38 PM Support #4701: try to improve H2 transaction commit performance: We can wait. I just noticed this and it is not a critical change, just a preference. I think it is more intuitive to ... Eric Faulhaber
03:40 AM Support #4701: try to improve H2 transaction commit performance: Eric Faulhaber wrote:
> Greg Shah wrote:
> > Alexandru:
> >
> > Is #4701-72 still the correct way to enable priv... Alexandru Lungu
03:24 PM Feature #6444: dataset improvements: Igor Skornyakov wrote:
> So I suggest creating a separate task for #6444-99 and switching to the remaining items i... Eric Faulhaber
02:13 PM Feature #6444: dataset improvements: Igor Skornyakov wrote:
> If I add an explicit ordering to the query in the #6444-99 test, the test passes. So the pr... Igor Skornyakov
01:18 PM Feature #6444: dataset improvements: Igor Skornyakov wrote:
> Regarding #6444-99:
>
> The situation is a little confusing.
> The @AdaptiveQuery.execu... Igor Skornyakov
11:24 AM Feature #6444: dataset improvements: Regarding #6444-99:
The situation is a little confusing.
The @AdaptiveQuery.executeQuery()@ instead of creating @... Igor Skornyakov
09:30 AM Feature #6444: dataset improvements: I believe that FILL support for recursive DATA-RELATIONs is done.
Committed to 6444a/14476.
Working on #6444-99 (... Igor Skornyakov
05:17 AM Feature #6444: dataset improvements: I've got a strange exception.
A very simple test... Igor Skornyakov
04:57 AM Feature #6444: dataset improvements: I've noticed a problem with DDL generation.
If the list of dialects in @p2j.cfg.xml@ contains @mariadb@ then in the... Igor Skornyakov
10:18 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Constantin,
I started with @relativePath()@ since I counted the most occurrences in @rules/@ folder. It make sense ... Ovidiu Maxiniuc
11:16 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Ovidiu Maxiniuc wrote:
> The Java support should be done (I left some scaffolding in there) but the TRPL is not full... Constantin Asofiei
10:05 AM Bug #7035: Extract query parameters from statically converted FQL: I've experimented with the testcase provided and found out a lot about how FQLPreprocessor works. I wrote an implemen... Dănuț Filimon
01:28 AM Feature #6371: implement SAVE CACHE statement: To determine the permissible data types, please refer to the static initializers for the @fwd2sql@ maps in the respec... Eric Faulhaber

01/16/2023

06:45 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: I have created branch 6813a and committed revision 14363.
It is not final.
The Java support should be done (I left... Ovidiu Maxiniuc
02:14 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Eric Faulhaber wrote:
> Ovidiu, did you get the varargs working? If it doesn't work directly with @Aast@, try it wit... Ovidiu Maxiniuc
02:07 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Ovidiu, did you get the varargs working? If it doesn't work directly with @Aast@, try it with @CommonAstSupport@, as ... Eric Faulhaber
06:40 PM Feature #7020: always use "expanded" extent fields: I committed r14362.
I have a problem which I did not solved: the dynamic extent indices.
For example, for the ab... Ovidiu Maxiniuc
03:28 PM Support #4701: try to improve H2 transaction commit performance: Greg Shah wrote:
> Alexandru:
>
> Is #4701-72 still the correct way to enable private temp-table databases?
>
... Eric Faulhaber
02:38 PM Support #4701: try to improve H2 transaction commit performance: Alexandru:
Is #4701-72 still the correct way to enable private temp-table databases?
How to we enable LOCK_MODE=0? Greg Shah
12:42 PM Feature #7037: remove dirty share manager: 7037a has been merged into the trunk as bzr revision 14478. Stanislav Lomany
09:41 AM Feature #7037: remove dirty share manager: Created task branch 7037a from FWD trunk revision 14477. Stanislav Lomany
08:00 AM Feature #7037: remove dirty share manager: Constantin Asofiei wrote:
> Eric, doesn't this disable the @FIND for non-temp-table records in the record nursery@ c... Greg Shah
01:59 AM Feature #7037: remove dirty share manager: Eric, doesn't this disable the @FIND for non-temp-table records in the record nursery@ case Greg mentioned? I ask bec... Constantin Asofiei
01:07 AM Feature #7037: remove dirty share manager: > This seems safe to commit this in both trunk and in 6129b.
Committed as 6129b rev 14362... Stanislav Lomany
12:06 PM Feature #6444: dataset improvements: Ovidiu Maxiniuc wrote:
> I was writing a pretty equivalent response. That is correct. The values for paging are not ... Igor Skornyakov
12:04 PM Feature #6444: dataset improvements: I was writing a pretty equivalent response. That is correct. The values for paging are not really used per-se, only t... Ovidiu Maxiniuc
12:00 PM Feature #6444: dataset improvements: Igor Skornyakov wrote:
> What is the reason to use @maxResults@ and @startOffset@ in the @QueryKey@ for the @Persist... Eric Faulhaber
04:48 AM Feature #6444: dataset improvements: What is the reason to use @maxResults@ and @startOffset@ in the @QueryKey@ for the @Persistence.staticQueryCache@?
I... Igor Skornyakov
08:03 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed: Constantin Asofiei wrote:
> Alexandru, I think a first pass would be to change the FQL generation to use @c1@, @c2@,... Alexandru Lungu
07:08 AM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...: Constantin Asofiei wrote:
> Some concerns on moving the source records to the destination table just by updating the... Alexandru Lungu

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Database

Activity

Activity

02/14/2023

02/13/2023

02/12/2023

02/11/2023

02/10/2023

02/09/2023

02/08/2023

02/07/2023

02/06/2023

02/04/2023

02/03/2023

02/02/2023

02/01/2023

01/31/2023

01/30/2023

01/28/2023

01/27/2023

01/26/2023

01/25/2023

01/24/2023

01/23/2023

01/20/2023

01/19/2023

01/18/2023

01/17/2023

01/16/2023