FWD » Core Development » Database

03/03/2023

09:18 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Regarding @CompareModeDefault.compareString@, I found some neat means of short-circuiting. Note that neither @RuleBas... Alexandru Lungu

07:45 AM Bug #7167: Associating records from opened buffers to new sessions is slow

There are several moments when @Persistence$Context.getSession@ is used (usually by query execution, persistence reco... Alexandru Lungu

07:21 AM Bug #7167 (Closed): Associating records from opened buffers to new sessions is slow

Alexandru Lungu

05:40 AM Bug #7165: Close multiplex scope using prepared statement

We should also address the use of prepared statements when using @FastCopyHelper@. Most of the statements executed th... Alexandru Lungu

03/02/2023

02:11 PM Feature #6444: dataset improvements

I'm working now on the only remaining subtask - the @DATA-RELATION:FOREIGN-KEY-HIDDEN@ attribute support which can be... Igor Skornyakov

02:38 AM Feature #6444: dataset improvements

Rebased 6444a to the trunk/14486.
Pushed up to revision 14501. Igor Skornyakov

09:45 AM Feature #7061: Enable the use of lazy result sets in H2

Alexandru Lungu wrote:
> Radu, please confirm that your @lazy@ solution is eligible for the scrolling queries as wel... Radu Apetrii

05:13 AM Feature #7061: Enable the use of lazy result sets in H2

I've done some tests with another large customer application and I have the following statistics:
|_. Type |_. Tem... Alexandru Lungu

08:34 AM Bug #7165: Close multiplex scope using prepared statement

@TemporaryBuffer.removeRecords@ is widely used when closing a multiplex scope, but not only - e.g it is also used wit... Alexandru Lungu

08:22 AM Bug #7165 (Closed): Close multiplex scope using prepared statement

Alexandru Lungu

05:13 AM Feature #6995 (Review): possibly support NO-UNDO temporary tables directly in H2

Alexandru Lungu

05:12 AM Feature #6995 (WIP): possibly support NO-UNDO temporary tables directly in H2

_- deleted -_
Wrong post, it was meant to be for #7061. Alexandru Lungu

04:49 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2

Alexandru Lungu wrote:
> * Can't we have both @transactional@ and @no-undo@ create table statements? I see that "tra... Radu Apetrii

03/01/2023

01:31 PM Feature #6444: dataset improvements

Added support for the RESTART-ROW attribute.
Committed to 6444a/14499. Igor Skornyakov

05:19 AM Feature #7061: Enable the use of lazy result sets in H2

This is not the way to do it. @AdaptiveQuery.open@ is called only by explicit queries, usually dynamic (@QUERY-OPEN@ ... Alexandru Lungu

03:46 AM Feature #7061: Enable the use of lazy result sets in H2

Alexandru Lungu wrote:
> Further in my tests, I've got a crash when checking the dialect of the buffer in @AdaptiveQ... Radu Apetrii

02:12 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

Thanks, I was thinking of something else and I recalled in the wrong way; in a customer app, buffer names are generat... Constantin Asofiei

02/28/2023

06:50 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

Constantin, we are already doing this. After the query is parsed, the constants are extracted as variables. Each time... Ovidiu Maxiniuc

05:33 PM Feature #6371: implement SAVE CACHE statement

Pushed initial implementation of @DTTZ@ support in @SchemaCheck@ as revision 6371b/14486. I am just not sure where th... Boris Schegolev

07:23 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

> One of the problems I have right now is that the rows are missing parameters when comparing in H2 and I am looking ... Dănuț Filimon

02:49 AM Feature #7062: Direct access to H2 internals to solve basic queries

Committed 7026a/14507 removing some tracing variables - missed them on my first check. Alexandru Lungu

02/27/2023

05:05 PM Feature #6371: implement SAVE CACHE statement

Tested and pushed Sequences and validations as revision 6371b/14485. Proceeding with timezone support. Boris Schegolev

09:24 AM Feature #7062: Direct access to H2 internals to solve basic queries

Done, committed 7026a/rev. 14506. Alexandru Lungu

08:04 AM Feature #7062: Direct access to H2 internals to solve basic queries

Alexandru Lungu wrote:
> [...]
> I will also allow such optimization for queries without client-where, joins and ex... Constantin Asofiei

08:01 AM Feature #7062: Direct access to H2 internals to solve basic queries

... Alexandru Lungu

07:58 AM Feature #7062: Direct access to H2 internals to solve basic queries

This was a last minute modification and the @LOCK_MODE 0@ from H2 was stuck in my head. It struck me at some point th... Alexandru Lungu

07:47 AM Feature #7062: Direct access to H2 internals to solve basic queries

Alexandru, the changes in RandomAccessQuery will not set the lock properly on a record found in the cache:... Constantin Asofiei

08:53 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2

Integrated the patch into 7062a. Also, the H2 changes made it to trunk.
I've reviewed the changes again and I have... Alexandru Lungu

08:45 AM Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code

Done several testing iterations with 7132a_h2/rev. 15 and the issue is solved. The bad news are that I couldn't notic... Alexandru Lungu

04:58 AM Feature #6444: dataset improvements

Tested the (de)serialization of recursive data relation for the remote calls.
Works OK. Igor Skornyakov

03:56 AM Feature #6582: implement multi-table AdaptiveQuery

#7061 is mostly finished and now we have a @lazy@ keyword in FWD-H2 which works as a H2 database-cursor allowing us t... Alexandru Lungu

03:15 AM Feature #7061: Enable the use of lazy result sets in H2

Radu, I merged your changes from 7061a to 7026a. Note that 7026a is frozen right now.
First of all, I moved @suppo... Alexandru Lungu

02/25/2023

07:16 AM Feature #6444: dataset improvements

Finished re-testing fixes for this task and #6453 after rebasing 6444a branch to the new trunk is finished.
Committe... Igor Skornyakov

02/24/2023

03:12 PM Bug #6812 (WIP): fix FastFindCache to use a shared instance per persistent database

I converted the code to use @Database@ object directly and reverted changes I made initially to visibility modifiers.... Boris Schegolev

09:18 AM Bug #6812: fix FastFindCache to use a shared instance per persistent database

I pushed the patch as revision 6812a/14485, working on better implementation (@Database@ object as key, cleanup, etc.) Boris Schegolev

11:06 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

Another point related to #6813-9 with query predicates which differ just with inlined literals. After the predicate ... Constantin Asofiei

06:58 AM Feature #7062: Direct access to H2 internals to solve basic queries

I merged the changes from 7062a into 7026a - the branch names are quite confusing :)
I have good results, similar ... Alexandru Lungu

06:02 AM Feature #7061: Enable the use of lazy result sets in H2

> I'll wait for a final decision on this.
Well, it definitely looks like it really depends on the converted code. I ... Alexandru Lungu

05:46 AM Feature #7061: Enable the use of lazy result sets in H2

Alexandru Lungu wrote:
> Alexandru Lungu wrote:
> > ** Count how many actual lazy queries are there in a large appl... Radu Apetrii

04:21 AM Feature #7061: Enable the use of lazy result sets in H2

Alexandru Lungu wrote:
> ** Count how many actual lazy queries are there in a large application: static vs dynamic, ... Alexandru Lungu

04:42 AM Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code

Alexandru Lungu wrote:
> Please make a new commit which reverts the changes for that less used classes. I would like... Radu Apetrii

02/23/2023

05:17 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database

Please create a 6812a branch from trunk and apply the diff. This will make it easier to review in context.
I've on... Eric Faulhaber

04:40 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database

I am attaching a suggested solution. It's somewhat raw (I had to make some elements public), but I can fix that for t... Boris Schegolev

12:35 PM Feature #6444: dataset improvements

I'm re-testing temp-table ans data-set changes from #6453 and this task with 6444a rebased to the trunk.
After fixin... Igor Skornyakov

11:08 AM Bug #7132 (WIP): Eliminate for-each loops and lambda in FWD-H2 code

*This is a review for 7132a_h2, rev. 14*
There are many changes in several files, so I've done a skim review of th... Alexandru Lungu

09:24 AM Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code

Alexandru Lungu wrote:
> Lastly, I think there may be an overhead by using @synchronized@ even in single-user H2 ins... Radu Apetrii

09:39 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2

I recall a scenario in which some records were updated in a for-loop and their new values were the same as the old va... Alexandru Lungu

08:13 PM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2

These should not occur since we create the @SET@ part of statement based only on changed properties (@BaseRecord.dirt... Ovidiu Maxiniuc

04:53 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Ovidiu Maxiniuc wrote:
> I altered your tests and remove the index for both tables: in this case we have the more lo... Dănuț Filimon

02/22/2023

04:34 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

I am really puzzled about this fact. I found the article in a parallel investigation. It really shocked my understand... Ovidiu Maxiniuc

07:00 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Alexandru Lungu wrote:
> Danut, please extract this into a separate 4GL test: CI database field with CS query parame... Dănuț Filimon

03:33 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Ovidiu Maxiniuc wrote:
> Yes, this could be an improvement if the strings are really different at their beginning. T... Alexandru Lungu

11:23 AM Feature #7061: Enable the use of lazy result sets in H2

I reverted your latest changes to H2 because I wanted to merge a tested, profiled version (rev. 15).
* The null che... Alexandru Lungu

03:44 AM Feature #7061: Enable the use of lazy result sets in H2

Alexandru Lungu wrote:
> > If the dependency is the H2 dialect on its own, then I think the condition should be some... Radu Apetrii

08:57 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2

I encountered several fake-updates in large customer applications. A fake-update is something like @UPDATE tt SET f1 ... Alexandru Lungu

08:50 AM Bug #7138 (Closed): Short circuit fake-update (update with a new value eqaul to the old value) in H2

Alexandru Lungu

02/21/2023

03:40 PM Feature #6371: implement SAVE CACHE statement

Please create a 6371b branch from trunk for this patch and the other remaining features. Thanks. Eric Faulhaber

02:36 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Alexandru Lungu wrote:
> I agree that we still need to use the @Collator@, but maybe we could have done something li... Ovidiu Maxiniuc

05:17 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Ovidiu Maxiniuc wrote:
> I looked again at your results in #7108-8. They do not seem alright. There are several case... Alexandru Lungu

05:04 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Ovidiu Maxiniuc wrote:
> Yes, I think we need that. I do not have an exact example (when I was working with these I ... Alexandru Lungu

12:26 PM Bug #7113 (Review): Problem with nested CAN-FIND conversion

Fixed SQL generation.
Committed to 7113a/14896.
Please review.
Thank you. Igor Skornyakov

11:57 AM Bug #7047: Problem with AdaptiveQuery and ScrollableResults

Alexandru Lungu wrote:
> I can't say why PostgreSQL behaves differently, but logically all non-scrolling 4GL queri... Eric Faulhaber

09:34 AM Bug #7047: Problem with AdaptiveQuery and ScrollableResults

As a side investigation which may help here:
@AdaptiveQuery@ is not considering @recid@ index as a sorting index. ... Alexandru Lungu

10:00 AM Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code

Committed rev. 13 finishing replacements from for-each loops to classical for loops. I've done some tests, but there ... Alexandru Lungu

07:14 AM Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code

Created 7132a_h2 from trunk rev. 11. Committed rev. 12 including lots of replacements from for-each loops to classica... Alexandru Lungu

08:26 PM Feature #7020 (Review): always use "expanded" extent fields

I attempted to rebase 7020a to trunk, but that proved to be a very time consuming task, practically duplicating Const... Ovidiu Maxiniuc

02/20/2023

03:45 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Alexandru Lungu wrote:
> I am facing a hot-spot in my profiling that may actual affect #7108 effort as well. It is r... Ovidiu Maxiniuc

02:24 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Dănuț Filimon wrote:
> The tests from #7108-8 were done *without any patch applied*. I retested with the patch appli... Ovidiu Maxiniuc

08:48 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Ovidiu, I recall that you had done some work with locale at some point. Please let me know if you can help me on this... Alexandru Lungu

02:28 PM Bug #7113: Problem with nested CAN-FIND conversion

The only remaining issue is that generated SQL statement contains extra closing brackets @)@ at the end of the WHERE ... Igor Skornyakov

11:20 AM Bug #7113: Problem with nested CAN-FIND conversion

Committed fix for the nested CAN-FIND to 7113a/14485. Igor Skornyakov

10:55 AM Bug #7113: Problem with nested CAN-FIND conversion

Created task branch 7113a. Igor Skornyakov

09:48 AM Bug #7113: Problem with nested CAN-FIND conversion

Igor Skornyakov wrote:
> Igor Skornyakov wrote:
> > Fixed nested CAN-FIND conversion (see attached .diff).
> > Ple... Igor Skornyakov

08:52 AM Bug #7113: Problem with nested CAN-FIND conversion

Igor Skornyakov wrote:
> Fixed nested CAN-FIND conversion (see attached .diff).
> Please review.
> Thank you.
>
... Igor Skornyakov

08:40 AM Bug #7113: Problem with nested CAN-FIND conversion

Fixed nested CAN-FIND conversion (see attached .diff).
Please review.
Thank you.
Working on runtime issue (#7113... Igor Skornyakov

08:56 AM Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code

Alexandru Lungu wrote:
> Second, there is an overhead with using lambdas, especially the ones which reference local ... Radu Apetrii

04:10 AM Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code

There is an overhead in using foreach loops: @for (Object obj : objs)@. This is because an iterator object is generat... Alexandru Lungu

03:47 AM Bug #7132 (WIP): Eliminate for-each loops and lambda in FWD-H2 code

Alexandru Lungu

03:32 AM Feature #7061: Enable the use of lazy result sets in H2

Radu:
* I've created 7061a branched from trunk to commit your changes to.
* Please notify me once you address the r... Alexandru Lungu

02/17/2023

09:49 AM Feature #7061: Enable the use of lazy result sets in H2

Alexandru Lungu wrote:
> As the patch and H2 modifications are mostly complete, in the sense that I have no obvious ... Alexandru Lungu

02/16/2023

05:36 PM Bug #6887: improve performance of dataset/table[-handle] parameters

The methods/attributes implemented by #6444 are not related to parameters. They perform the same regardless the datas... Ovidiu Maxiniuc

04:31 PM Bug #6887: improve performance of dataset/table[-handle] parameters

I didn't make any changes for this task. Not sure if there are any relevant changes coming from #6444. Boris Schegolev

03:23 PM Bug #6887: improve performance of dataset/table[-handle] parameters

Has any of this implementation been touched by the recent waves of performance work in 3821c and 6129c, or are we ess... Eric Faulhaber

03:26 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database

Boris, please look at the @FastFindCache@ implementation and ask any questions you may have as it pertains to this task. Eric Faulhaber

03:19 PM Bug #6919: fix ErrorManager.displayError in TempTableBuilder

Is there anything left to do on this task, or can we close it? Eric Faulhaber

09:34 AM Feature #7061: Enable the use of lazy result sets in H2

Eric Faulhaber wrote:
> One clarification to this point. It is not so much the fact that the new lazy mode should be... Alexandru Lungu

09:11 AM Support #7058: get the FWD fork of the H2 code base under version control

*UPDATE*: regression testing passed; merged 7062a_h2 to FWD-H2 trunk including support for direct access to internal ... Alexandru Lungu

06:18 AM Support #7058: get the FWD fork of the H2 code base under version control

Eric Faulhaber wrote:
> Alexandru, if there is any change to the build process, beyond just checking out the trunk F... Alexandru Lungu

09:07 AM Feature #7062 (Review): Direct access to H2 internals to solve basic queries

Merged 7062a_h2 into trunk after adding support for some extra data-types from FWD (object as resourceId and decimal ... Alexandru Lungu

07:48 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

The tests from #7108-8 were done *without any patch applied*. I retested with the patch applied and there is no diffe... Dănuț Filimon

02/15/2023

03:01 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Alexandru Lungu wrote:
> Do you mean the case where the field is case-insensitive and the field is case-sensitive, b... Ovidiu Maxiniuc

09:04 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

I found several mismatched between FWD and 4GL. All of the tests are done in the following manner:... Dănuț Filimon

03:53 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Danut, please make a complete set of independent *4GL tests* for each of these cases - or *search the testcases proje... Alexandru Lungu

03:28 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Ovidiu Maxiniuc wrote:
> The problem is I do not think forcing the character substitutions to be case-sensitive is t... Alexandru Lungu

01:54 PM Feature #7061: Enable the use of lazy result sets in H2

Radu Apetrii wrote:

> I modified the patch from the last post a bit, because the change with the removal of @Prog... Eric Faulhaber

08:51 AM Feature #7061: Enable the use of lazy result sets in H2

Update: I've committed a fix to 7061a_h2, rev. 12. *I no longer have issues when testing a large customer application... Radu Apetrii

12:58 PM Support #7058: get the FWD fork of the H2 code base under version control

Alexandru Lungu wrote:
> Once we have the pending branches merged into the FWD-H2 trunk, we will have a new build ... Eric Faulhaber

06:08 AM Support #7058: get the FWD fork of the H2 code base under version control

For H2, Eric will push this when it is ready. Greg Shah

03:56 AM Support #7058: get the FWD fork of the H2 code base under version control

*UPDATE*: regression testing passed; merged 6829a_h2 to FWD-H2 trunk including performance improvements regarding les... Alexandru Lungu

12:01 PM Feature #7037: remove dirty share manager

Guys, I want to commit the dirty sharing changes, but I want to know what dirty share state should be for the existin... Stanislav Lomany

10:52 AM Feature #6444: dataset improvements

Branch 6444a was rebased to the trunk rev. 14484.
Pushed up to revision 14493. Igor Skornyakov

09:13 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Error handler support for MariaDB committed to 6628a/14485
See also #6628-175.
Please review.
Thank you. Igor Skornyakov

08:24 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Created task branch 6628a from the trunk rev.14484 Igor Skornyakov

06:53 AM Feature #7062: Direct access to H2 internals to solve basic queries

Alexandru Lungu wrote:
> I am planning to make some final changes to 7062a (javadoc and small performance changes), ... Alexandru Lungu

03:59 AM Bug #6829 (Review): H2 forces re-parse of all prepared statements when metadata is changed

Merged 6829a_h2 to FWD-H2 trunk including performance improvements regarding less recompiling of prepared statements ... Alexandru Lungu

03:35 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

There are no problems with rev.11. I checked @psCache@ hit/miss with rev.6 and rev.11 and didn't get very different r... Dănuț Filimon

03:58 AM Bug #7120 (Test): NO-UNDO dynamic temp-table does not set the NO-UNDO at the .schema

Changes look good. Thanks. Constantin Asofiei

02/14/2023

06:29 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Review of @ffCache-20230214.patch@.
Nice detective work. Indeed, there seems to be a key collision which causes th... Ovidiu Maxiniuc

06:18 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

I've done some changes to how strings are compared in H2. I included a @rtrim@ parameter that, if set to true (by def... Dănuț Filimon

04:08 PM Bug #7120 (WIP): NO-UNDO dynamic temp-table does not set the NO-UNDO at the .schema

Good analysis!
Actually, the value of the @undo@ table attribute is not copied from the source table. It is by defau... Ovidiu Maxiniuc

07:00 AM Bug #7120: NO-UNDO dynamic temp-table does not set the NO-UNDO at the .schema

This test:... Constantin Asofiei

06:58 AM Bug #7120 (Test): NO-UNDO dynamic temp-table does not set the NO-UNDO at the .schema

Constantin Asofiei

12:28 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> Finished with error Handler support for MariaDB.
> Because of #7113 it was tested with a s... Igor Skornyakov

08:12 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

Dănuț Filimon wrote:
> Committed 6829a_h2/rev.7. Stopped forced re-parsing for prepared statements.
>
> Each SELE... Alexandru Lungu

07:10 AM Support #7058: get the FWD fork of the H2 code base under version control

Will pre-built FWD-H2 revisions jars be uploaded into GCD repository ?
Tomasz Domin

07:00 AM Support #7058: get the FWD fork of the H2 code base under version control

*UPDATE*: regression testing passed; merged 6928a_h2 to FWD-H2 trunk including performance improvements for UPDATE st... Alexandru Lungu

07:01 AM Feature #6928 (Test): H2 UPDATE performance improvement

Merged 6928a_h2 to FWD-H2 trunk including performance improvements for UPDATE statement, with in-memory and PageStore... Alexandru Lungu

06:52 AM Feature #6928: H2 UPDATE performance improvement

Thanks, the change is OK. It can be merged to trunk. Constantin Asofiei

06:26 AM Feature #6928: H2 UPDATE performance improvement

Constantin Asofiei wrote:
> Was the branch bound? I don't see rev 11 for 6928a_h2.
What a quick response! My bzr ... Alexandru Lungu

06:23 AM Feature #6928: H2 UPDATE performance improvement

Alexandru Lungu wrote:
> Tested 6928a_h2/rev. 10 and found a regression: the old-row stored by @deltaChangeCollector... Constantin Asofiei

06:20 AM Feature #6928: H2 UPDATE performance improvement

Tested 6928a_h2/rev. 10 and found a regression: the old-row stored by @deltaChangeCollector@ inside the H2 update sta... Alexandru Lungu

06:48 AM Feature #7061: Enable the use of lazy result sets in H2

I've added the option to execute queries in a lazy manner. Alongside this change, @AdaptiveQuery@ now uses only @Scro... Radu Apetrii

01:22 AM Bug #7113: Problem with nested CAN-FIND conversion

Ovidiu Maxiniuc wrote:
> The nested CAN-FIND is an old issue. There were some fixes in time (see #3040, #3465, #3771... Igor Skornyakov

09:22 PM Feature #7037: remove dirty share manager

Review of @7037b.diff@.
A clean implementation. Nice job. The patch should work as described in note #7037-35.
Pl... Ovidiu Maxiniuc

02/13/2023

06:17 PM Feature #6371: implement SAVE CACHE statement

Attaching a working version of sequences support in @SchemaCheck@ and @SchemaValidator@ for review. Boris Schegolev

05:20 PM Bug #7113: Problem with nested CAN-FIND conversion

The nested CAN-FIND is an old issue. There were some fixes in time (see #3040, #3465, #3771, and others) and the issu... Ovidiu Maxiniuc

09:13 AM Bug #7113 (WIP): Problem with nested CAN-FIND conversion

Igor Skornyakov

05:19 AM Bug #7113: Problem with nested CAN-FIND conversion

Thank you for checking, you can continue with your normal tasks. Constantin Asofiei

05:03 AM Bug #7113: Problem with nested CAN-FIND conversion

Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > One more thing: is this a regression in 6129c compared to tr... Igor Skornyakov

05:02 AM Bug #7113: Problem with nested CAN-FIND conversion

Constantin Asofiei wrote:
> One more thing: is this a regression in 6129c compared to trunk?
No, I get the same e... Igor Skornyakov

04:54 AM Bug #7113: Problem with nested CAN-FIND conversion

One more thing: is this a regression in 6129c compared to trunk? Constantin Asofiei

04:52 AM Bug #7113: Problem with nested CAN-FIND conversion

Constantin Asofiei wrote:
> So instead of @?@ it should be @Order.OrderNum@ and @OrderLine.ItemNum@, respectively? I... Igor Skornyakov

04:25 AM Bug #7113: Problem with nested CAN-FIND conversion

Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > What's the problem with the query? What would be the correct... Constantin Asofiei

04:23 AM Bug #7113: Problem with nested CAN-FIND conversion

Constantin Asofiei wrote:
> What's the problem with the query? What would be the correct variant? If you change the ... Igor Skornyakov

04:16 AM Bug #7113: Problem with nested CAN-FIND conversion

What's the problem with the query? What would be the correct variant? If you change the FQL manually to the correct v... Constantin Asofiei

03:02 AM Bug #7113: Problem with nested CAN-FIND conversion

The problem is at the program conversion (not only runtime).
The query from the previous noye is converted to... Igor Skornyakov

09:14 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Greg Shah wrote:
> > Because of #7113 it was tested with a simple test only
>
> Go ahead and fix this now.
OK... Igor Skornyakov

08:48 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

> Because of #7113 it was tested with a simple test only
Go ahead and fix this now. Greg Shah

02/12/2023

11:03 AM Feature #6628 (Review): port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov

11:03 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Finished with error Handler support for MariaDB.
Because of #7113 it was tested with a simple test only
Please rev... Igor Skornyakov

07:45 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> I've encoutered a weird problem with MariaDB that makes the error handling based on @initEr... Igor Skornyakov

07:01 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

I've encoutered a weird problem with MariaDB that makes the error handling based on @initError@/@checkError@ impossib... Igor Skornyakov

04:25 AM Bug #7113: Problem with nested CAN-FIND conversion

Consider the following statement:... Igor Skornyakov

04:18 AM Bug #7113 (Review): Problem with nested CAN-FIND conversion

Igor Skornyakov

02/11/2023

10:59 AM Feature #6928: H2 UPDATE performance improvement

Rebased 6928a_h2 rev 8 from fwd-h2.trunk rev 8 - new rev 10. Constantin Asofiei

09:38 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

I tried using the call stack you provided but it seems different from 6129c/14808. The code at @FqlToSqlConverter.jav... Ovidiu Maxiniuc

02/10/2023

10:56 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

I've experienced problem with CAN-FIND (6129c/14808).
When creating the query from the attached test I get the follo... Igor Skornyakov

09:54 AM Feature #7062: Direct access to H2 internals to solve basic queries

I committed 7062a_h2/rev. 9 the changes to H2 to allow direct access.
There is a patch here on the changes required ... Alexandru Lungu

08:22 AM Feature #7062: Direct access to H2 internals to solve basic queries

I've redone the tests with direct access:
* Computed columns are now marked as invisible in H2.
* Before returning ... Alexandru Lungu

05:08 AM Feature #7037: remove dirty share manager

Ovidiu: Please review. Greg Shah

02/09/2023

12:53 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Please test how the right-padding spaces are handled. An important element in the expressions above is the @rtrim@ fu... Ovidiu Maxiniuc

10:49 AM Bug #7108 (WIP): Simulate upper/rtrim directly in H2 using case specific columns

Consider supporting case specific operators directly in H2 for character fields. For case-insensitive character field... Alexandru Lungu

10:42 AM Bug #7108 (Closed): Simulate upper/rtrim directly in H2 using case specific columns

Alexandru Lungu

10:54 AM Feature #6995 (Review): possibly support NO-UNDO temporary tables directly in H2

Rebased from trunk and merged 6995a_h2 to FWD-H2 trunk: includes the addition of a NO-UNDO keyword being natively sup... Alexandru Lungu

10:53 AM Support #7058: get the FWD fork of the H2 code base under version control

*UPDATE*: regression testing passed; merged 6995a_h2 to FWD-H2 trunk including the addition of a NO-UNDO keyword bein... Alexandru Lungu

10:42 AM Feature #7062: Direct access to H2 internals to solve basic queries

Alexandru Lungu wrote:
> > In the absence of a SQL option to SELECT * EXCEPT __ifield1, __sfield2 FROM... I think we... Alexandru Lungu

06:55 AM Bug #7035: Extract query parameters from statically converted FQL

Alexandru Lungu wrote:
> I get a NPE in com.goldencode.p2j.persist.ParameterDiff.getSubstParameters(ParameterDiff.ja... Dănuț Filimon

02/08/2023

10:56 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

Eric Faulhaber wrote:
> Has anyone who has looked inside H2 gotten a sense of how that cache interacts with our prep... Alexandru Lungu

10:09 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

Dănuț Filimon wrote:
> Committed 6829a_h2/rev.7. Stopped forced re-parsing for prepared statements.
>
> Each SELE... Alexandru Lungu

09:46 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2

Alexandru Lungu wrote:
> Radu, please redo the FWD patch considering my first comment in #6995-16 regarding @getCrea... Radu Apetrii

03:41 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2

Code review @6995-6129b.patch@ and @fwd-h2-6995.patch@:
Nice work, Radu!
I agree with Alexandru's comments in #... Eric Faulhaber

08:48 AM Support #7058: get the FWD fork of the H2 code base under version control

Alexandru Lungu wrote:
> I am planning to merge 7046_h2 to the FWD-H2 trunk after handling #7085-3 (test suite segre... Alexandru Lungu

04:00 AM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it

Ovidiu Maxiniuc wrote:
> Unless this can be configured somewhere else. Or if there is another data type for this?
... Eric Faulhaber

02/07/2023

06:44 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

Committed 6829a_h2/rev.7. Stopped forced re-parsing for prepared statements.
Each SELECT/DELETE/UPDATE/INSERT quer... Dănuț Filimon

06:34 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2

Radu, please redo the FWD patch considering my first comment in #6995-16 regarding @getCreateTemporaryTablePostfix@ o... Alexandru Lungu

06:33 AM Support #7058: get the FWD fork of the H2 code base under version control

I am planning to merge 7046_h2 to the FWD-H2 trunk after handling #7085-3 (test suite segregation). There are still s... Alexandru Lungu

02/06/2023

06:45 PM Feature #7037: remove dirty share manager

Please review the diff (for the trunk 14478) which adds the following directory configuration parameters:
# In addit... Stanislav Lomany

03:50 PM Feature #6371: implement SAVE CACHE statement

Boris Schegolev wrote:
> Currently, my best option is adding SQLs to retrieve sequence information into individual... Eric Faulhaber

02:50 PM Feature #6371: implement SAVE CACHE statement

I am working on support for sequences in @SchemaCheck@ for use in validations and I wanted to have a confirmation tha... Boris Schegolev

04:43 AM Feature #7062: Direct access to H2 internals to solve basic queries

> Actually the prefixes for the computed columns in H2 dialect are __i and __s (for i gnore casing and case- s ensiti... Alexandru Lungu

02/04/2023

07:32 PM Feature #7062: Direct access to H2 internals to solve basic queries

Eric Faulhaber wrote:
> Ultimately, we create the SQL forms of the column names. So, we can use whatever we want as ... Ovidiu Maxiniuc

02/03/2023

06:53 PM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it

Thank you. I tried it now and it worked. I was able to create a table and execute a quick select statement over a cou... Ovidiu Maxiniuc

06:17 PM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it

I'm pretty sure @citext@ existed as an extension before PostgreSQL 11. I thought it was one of the core data types af... Eric Faulhaber

05:25 PM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it

The changes are necessary only if/when we decide to switch from case-sensitive character data types to case-insensiti... Ovidiu Maxiniuc

10:51 AM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it

It seems like note 11 is suggesting some changes to encode the logic in the dialects and fix the DDL generation. Greg Shah

10:49 AM Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it

It sounds like this task can be closed, then, correct? Eric Faulhaber

05:17 PM Feature #7062: Direct access to H2 internals to solve basic queries

Ultimately, we create the SQL forms of the column names. So, we can use whatever we want as an identifier, if we find... Eric Faulhaber

04:20 PM Feature #7062: Direct access to H2 internals to solve basic queries

Actually the prefixes for the computed columns in H2 dialect are @__i@ and @__s@ (for *i* gnore casing and case- *s* ... Ovidiu Maxiniuc

10:34 AM Feature #7062: Direct access to H2 internals to solve basic queries

I extended my solution to cover all unique indexes. Most of the processing is done in @FQLPreprocessor@ to identify w... Alexandru Lungu

10:50 AM Feature #6348: implement support for MariaDB

Ovidiu Maxiniuc wrote:
> Committed revision 14396 / 6129b.
The change looks good. Can we close this task? Eric Faulhaber

02/02/2023

03:47 PM Feature #7062: Direct access to H2 internals to solve basic queries

Greg Shah wrote:
> You're saying that in the 4GL these have separate @recid@ values when a temp-table is passed as a... Ovidiu Maxiniuc

11:56 AM Feature #7062: Direct access to H2 internals to solve basic queries

Alexandru Lungu wrote:
> I may have misinterpreted FWD's behavior. I have seen multiple fields like "some_field" a... Eric Faulhaber

11:46 AM Feature #7062: Direct access to H2 internals to solve basic queries

Greg Shah wrote:
> > I only consider tables without computed-columns (date-time, extent or case-insensitive char fie... Alexandru Lungu

09:54 AM Feature #7062: Direct access to H2 internals to solve basic queries

> I only consider tables without computed-columns (date-time, extent or case-insensitive char fields)
In regard to... Greg Shah

05:51 AM Feature #7062: Direct access to H2 internals to solve basic queries

> Please also consider #6720; I don't yet know if lazy hydration should be applied to H2 embedded databases. I have t... Alexandru Lungu

03:26 PM Feature #7037: remove dirty share manager

Stanislav Lomany wrote:
> FYI I've found @uast/shared-dirty-records/p*.p@ and @uast/shared-dirty-records/leaking*.p@... Tomasz Domin

03:24 PM Feature #7037: remove dirty share manager

FYI I've found @uast/shared-dirty-records/p*.p@ and @uast/shared-dirty-records/leaking*.p@ testcases which "demonstra... Stanislav Lomany

01:18 PM Feature #6371: implement SAVE CACHE statement

Boris Schegolev wrote:
> Branch 6129b is frozen for now, so, let's take a look at what we know was not implemented b... Eric Faulhaber

08:27 AM Feature #6371: implement SAVE CACHE statement

> EXTENT support (currently, expanded mode only...
I think we only need expanded mode support. The old "denormali... Greg Shah

06:40 AM Bug #7088: Lazily initialize activeBundle inside RandomAccessQuery

I've done a slim test with ~40,000 find queries. ~13.000 of them used @ffCache@. The total time spent on activation w... Alexandru Lungu