FWD » Core Development » Database

03/14/2023

02:11 PM Feature #6444: dataset improvements

Added FOREIGN-KEY-HIDDEN support for WRITE-XML,(READ|WRITE)-XMLSCHEMA.
Committed to 6444a/14524
The remaining thi... Igor Skornyakov

04:59 AM Feature #6444: dataset improvements

Rebased 6444a to the trunk/14503.
Pushed up to revision 14523.
Igor Skornyakov

04:51 AM Feature #6444: dataset improvements

Fixed @READ-XML(SCHEMA)?@ support for DATA-SETs with NESTED DATA-RELATIONs and multiple namespaces.
It works correct... Igor Skornyakov

12:30 PM Bug #7174: Resolve simple CAN-FIND statements faster

This semantic is why we have the @has{Any|One}@ nomenclature in @FindQuery@.
* @CAN-FIND({FIRST|LAST} ...)@ is con... Eric Faulhaber

09:35 AM Bug #7174: Resolve simple CAN-FIND statements faster

These are the expected results, where ONE is @CAN-FIND(tt)@, ANY is @CAN-FIND(FIRST tt)@.
|_. Number of records |_... Alexandru Lungu

09:23 AM Bug #7174: Resolve simple CAN-FIND statements faster

In OE, will a CAN-FIND ONE result return true if there is more than one match? In other words, is CAN-FIND ONE meant... Greg Shah

05:29 AM Bug #7174: Resolve simple CAN-FIND statements faster

I created tests that use simple queries, those tests consist of executing CAN-FIND for each record in a temporary/per... Dănuț Filimon

10:50 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2

Ovidiu Maxiniuc wrote:
> Alexandru Lungu wrote:
> > Right now, I am still dragged back by @String.hashCode@:
> > [... Alexandru Lungu

10:32 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2

Alexandru Lungu wrote:
> Right now, I am still dragged back by @String.hashCode@:
> [...]
Why is that? It seems li... Ovidiu Maxiniuc

09:42 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2

Ovidiu Maxiniuc wrote:
> Apparently, the hash short-circuit is not used. The @length@ of the strings are compared, b... Alexandru Lungu

08:46 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2

H2 database engine is built in Java. My first reaction to your hash suggestion was that it unneeded since Java has th... Ovidiu Maxiniuc

05:10 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2

... Alexandru Lungu

10:02 AM Feature #7194: Avoid generating an ORDER-BY clause if not required

This task targets the following scenario:... Alexandru Lungu

09:49 AM Feature #7194 (Closed): Avoid generating an ORDER-BY clause if not required

Alexandru Lungu

08:03 AM Feature #7062: Direct access to H2 internals to solve basic queries

Moved the @isFindByRowid@ short-circuit from #7062-30 to @RAQ.execute@. This is because @isSimpleQuery@ was always re... Alexandru Lungu

07:33 AM Bug #7185: H2 in-memory lazy hydration

Danut, please focus on implementing a demo for point 5 - we should have a fast mock to test its performance. Therefor... Alexandru Lungu

07:15 AM Bug #7185 (WIP): H2 in-memory lazy hydration

Alexandru Lungu

04:47 AM Bug #7165: Close multiplex scope using prepared statement

Alexandru Lungu wrote:
> Radu, please move 7061a, rev. 14487 to 7026b.
> I will review, test and profile it once th... Radu Apetrii

04:03 AM Bug #7165 (Review): Close multiplex scope using prepared statement

Radu, please move 7061a, rev. 14487 to 7026b.
I will review, test and profile it once there. Alexandru Lungu

03/13/2023

06:47 PM Bug #6887 (WIP): improve performance of dataset/table[-handle] parameters

I did more testing on provided code. The INPUT-OUTPUT DATASET-HANDLE is slightly slower in FWD, but it's definitely n... Boris Schegolev

03:44 PM Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> The main difference between @ds.xsd@ and the deserialied @hds.xsd@ is that the namespace, t... Igor Skornyakov

03:21 PM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> I've noticed a strange thing. Consider the attached test @nested-test.p@.
> It defines a D... Ovidiu Maxiniuc

09:55 AM Feature #6444: dataset improvements

Radu Apetrii wrote:
> Igor Skornyakov wrote:
> > The problem is with 'lazyMode'. After applying the attached path t... Igor Skornyakov

09:32 AM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> The problem is with 'lazyMode'. After applying the attached path the regression has gone.
... Radu Apetrii

05:28 AM Feature #6444: dataset improvements

Fixed minor issues with @WRITE-XML(SCHEMA)?@ for tables.
Committed to 6444a/14519. Igor Skornyakov

03:59 AM Feature #6444: dataset improvements

Eric Faulhaber wrote:
> Please post the test case, explain the regression to Radu, and let him fix it.
I'm workin... Radu Apetrii

03:09 AM Feature #6444: dataset improvements

Sorry, I've attached a wrong file. Igor Skornyakov

02:51 AM Feature #6444: dataset improvements

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > Igor Skornyakov wrote:
> > > After rebasing I see a regression ... Igor Skornyakov

02:14 AM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> Igor Skornyakov wrote:
> > After rebasing I see a regression in the FILL test for temporar... Eric Faulhaber

10:32 AM Bug #5306 (WIP): AdaptiveQuery sets a found record into the buffer twice in dynamic mode

Alexandru Lungu

07:37 AM Bug #7185: H2 in-memory lazy hydration

There is already some effort into lazy hydration as a general topic:
* supporting FIELDS/EXCEPT clause, so we can fe... Alexandru Lungu

03/12/2023

12:40 PM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> After rebasing I see a regression in the FILL test for temporary source tables and recursiv... Igor Skornyakov

10:28 AM Feature #6444: dataset improvements

After rebasing I see a regression in the FILL test for temporary source tables and recursive DATA-RELATION. Igor Skornyakov

10:13 AM Feature #6444: dataset improvements

Rebased 6444a to the trunk/14500.
Pushed up to revision 14517. Igor Skornyakov

09:26 AM Feature #6444: dataset improvements

Fixed WRITE-XML(SCHEMA) for multiple namespaces and NESTED relations.
Committed to 6444a/14508. Igor Skornyakov

03/10/2023

02:09 PM Feature #6444: dataset improvements

Igor Skornyakov wrote:
> [...]
> This looks incorrect. As far as I understand which tables are missed depends on t... Eric Faulhaber

04:22 AM Feature #7061: Enable the use of lazy result sets in H2

Alexandru Lungu wrote:
> Radu, please review and test with your adaptive test cases (scrolling and non-scrolling).
... Radu Apetrii

03/09/2023

03:03 PM Bug #6919: fix ErrorManager.displayError in TempTableBuilder

My understanding is that we can close it. Boris Schegolev

01:20 PM Feature #6444: dataset improvements

More about the situation described in #6444-141.
Although in the Progress Developer Studio debugger @hds@ after im... Igor Skornyakov

08:39 AM Feature #6444: dataset improvements

I've noticed a strange thing. Consider the attached test @nested-test.p@.
It defines a DATA-SET with 5 tables (tt1... Igor Skornyakov

09:03 AM Bug #7185 (Test): H2 in-memory lazy hydration

Alexandru Lungu

07:54 AM Feature #7061: Enable the use of lazy result sets in H2

Constantin Asofiei wrote:
> Alexandru, is this patch meant to solve regressions? Because we are getting close to fin... Alexandru Lungu

07:48 AM Feature #7061: Enable the use of lazy result sets in H2

Alexandru, is this patch meant to solve regressions? Because we are getting close to finish testing 7026a, and unless... Constantin Asofiei

07:46 AM Feature #7061: Enable the use of lazy result sets in H2

After a self-review of the patch, I see that we still register the change broker for @AdaptiveQuery.open@ and there i... Alexandru Lungu

05:52 AM Feature #7061: Enable the use of lazy result sets in H2

Radu, this is the patch I am planning to integrate into 7026a to wrap-up the effort from #7061 and have a complete im... Alexandru Lungu

05:38 AM Feature #7061 (Review): Enable the use of lazy result sets in H2

Rebased 7061a to trunk (rev. 14497). Planning to merge your latest changes to 7026a as they target a temporary fix fr... Alexandru Lungu

05:00 AM Feature #7061: Enable the use of lazy result sets in H2

Alexandru Lungu wrote:
> Radu, is the multi-table @AdaptiveQuery@ considered for your implementation? I understood t... Radu Apetrii

07:39 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Alexandru Lungu wrote:
> * Note that you apply @s.replace(CASE_TYPE_TOK, "");@ to any type. You can do a check befor... Dănuț Filimon

03/08/2023

08:16 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Alexandru Lungu wrote:
> * testFWD shows regressions. I can't tell if they are false positives, but you should look ... Alexandru Lungu

07:43 AM Bug #7108 (Review): Simulate upper/rtrim directly in H2 using case specific columns

First thing to notice: the application always requires reconversion due to the new DDL for the H2 meta database (even... Alexandru Lungu

03/07/2023

09:43 AM Feature #7066 (WIP): Implement multi-table indexed query in H2

The purpose of this task too wide, especially after the implementation of the @lazy@ keyword. We should address some ... Alexandru Lungu

09:28 AM Feature #7062: Direct access to H2 internals to solve basic queries

The results were obtained using 7026a/rev. 14518. I don't have some results for 7026a/rev. 14503 for this specific ap... Alexandru Lungu

09:10 AM Feature #7062: Direct access to H2 internals to solve basic queries

Do these results differ from 7026a rev 14503? Greg Shah

08:44 AM Feature #7062: Direct access to H2 internals to solve basic queries

I've done the performance test on another large customer application. I've added more details to cover temp vs persis... Alexandru Lungu

08:59 AM Feature #7061: Enable the use of lazy result sets in H2

Radu, is the multi-table @AdaptiveQuery@ considered for your implementation? I understood that @lazy@ keyword works o... Alexandru Lungu

07:23 AM Feature #6444: dataset improvements

I've created a more advanced test with five tables, multiple namespaces and multiple nested data-reltions.
It appear... Igor Skornyakov

05:08 AM Bug #7174: Resolve simple CAN-FIND statements faster

Please note that we have a task regarding CAN-FIND (#7113) waiting for the code review.
Maybe it makes sense to wait... Igor Skornyakov

04:59 AM Bug #7174 (WIP): Resolve simple CAN-FIND statements faster

There are some opportunities to short-circuit the CAN-FIND query in FWD. A CAN-FIND statement is relaxed, in the sens... Alexandru Lungu

04:40 AM Bug #7174 (Closed): Resolve simple CAN-FIND statements faster

Alexandru Lungu

03:47 AM Bug #7165: Close multiplex scope using prepared statement

Alexandru Lungu wrote:
> @TemporaryBuffer.removeRecords@ is widely used when closing a multiplex scope, but not only... Radu Apetrii

03/06/2023

05:10 PM Bug #6812 (Review): fix FastFindCache to use a shared instance per persistent database

I prepared a change for the last missing bit (@SavepointManager@) - see revision 6812a/14487. It needs more testing, ... Boris Schegolev

06:52 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Alexandru Lungu wrote:
> We should integrate the first two for now to benefit from the "free meal". Danut, please co... Dănuț Filimon

03/03/2023

09:18 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Regarding @CompareModeDefault.compareString@, I found some neat means of short-circuiting. Note that neither @RuleBas... Alexandru Lungu

07:45 AM Bug #7167: Associating records from opened buffers to new sessions is slow

There are several moments when @Persistence$Context.getSession@ is used (usually by query execution, persistence reco... Alexandru Lungu

07:21 AM Bug #7167 (Closed): Associating records from opened buffers to new sessions is slow

Alexandru Lungu

05:40 AM Bug #7165: Close multiplex scope using prepared statement

We should also address the use of prepared statements when using @FastCopyHelper@. Most of the statements executed th... Alexandru Lungu

03/02/2023

02:11 PM Feature #6444: dataset improvements

I'm working now on the only remaining subtask - the @DATA-RELATION:FOREIGN-KEY-HIDDEN@ attribute support which can be... Igor Skornyakov

02:38 AM Feature #6444: dataset improvements

Rebased 6444a to the trunk/14486.
Pushed up to revision 14501. Igor Skornyakov

09:45 AM Feature #7061: Enable the use of lazy result sets in H2

Alexandru Lungu wrote:
> Radu, please confirm that your @lazy@ solution is eligible for the scrolling queries as wel... Radu Apetrii

05:13 AM Feature #7061: Enable the use of lazy result sets in H2

I've done some tests with another large customer application and I have the following statistics:
|_. Type |_. Tem... Alexandru Lungu

08:34 AM Bug #7165: Close multiplex scope using prepared statement

@TemporaryBuffer.removeRecords@ is widely used when closing a multiplex scope, but not only - e.g it is also used wit... Alexandru Lungu

08:22 AM Bug #7165 (Closed): Close multiplex scope using prepared statement

Alexandru Lungu

05:13 AM Feature #6995 (Review): possibly support NO-UNDO temporary tables directly in H2

Alexandru Lungu

05:12 AM Feature #6995 (WIP): possibly support NO-UNDO temporary tables directly in H2

_- deleted -_
Wrong post, it was meant to be for #7061. Alexandru Lungu

04:49 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2

Alexandru Lungu wrote:
> * Can't we have both @transactional@ and @no-undo@ create table statements? I see that "tra... Radu Apetrii

03/01/2023

01:31 PM Feature #6444: dataset improvements

Added support for the RESTART-ROW attribute.
Committed to 6444a/14499. Igor Skornyakov

05:19 AM Feature #7061: Enable the use of lazy result sets in H2

This is not the way to do it. @AdaptiveQuery.open@ is called only by explicit queries, usually dynamic (@QUERY-OPEN@ ... Alexandru Lungu

03:46 AM Feature #7061: Enable the use of lazy result sets in H2

Alexandru Lungu wrote:
> Further in my tests, I've got a crash when checking the dialect of the buffer in @AdaptiveQ... Radu Apetrii

02:12 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

Thanks, I was thinking of something else and I recalled in the wrong way; in a customer app, buffer names are generat... Constantin Asofiei

02/28/2023

06:50 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

Constantin, we are already doing this. After the query is parsed, the constants are extracted as variables. Each time... Ovidiu Maxiniuc

05:33 PM Feature #6371: implement SAVE CACHE statement

Pushed initial implementation of @DTTZ@ support in @SchemaCheck@ as revision 6371b/14486. I am just not sure where th... Boris Schegolev

07:23 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

> One of the problems I have right now is that the rows are missing parameters when comparing in H2 and I am looking ... Dănuț Filimon

02:49 AM Feature #7062: Direct access to H2 internals to solve basic queries

Committed 7026a/14507 removing some tracing variables - missed them on my first check. Alexandru Lungu

02/27/2023

05:05 PM Feature #6371: implement SAVE CACHE statement

Tested and pushed Sequences and validations as revision 6371b/14485. Proceeding with timezone support. Boris Schegolev

09:24 AM Feature #7062: Direct access to H2 internals to solve basic queries

Done, committed 7026a/rev. 14506. Alexandru Lungu

08:04 AM Feature #7062: Direct access to H2 internals to solve basic queries

Alexandru Lungu wrote:
> [...]
> I will also allow such optimization for queries without client-where, joins and ex... Constantin Asofiei

08:01 AM Feature #7062: Direct access to H2 internals to solve basic queries

... Alexandru Lungu

07:58 AM Feature #7062: Direct access to H2 internals to solve basic queries

This was a last minute modification and the @LOCK_MODE 0@ from H2 was stuck in my head. It struck me at some point th... Alexandru Lungu

07:47 AM Feature #7062: Direct access to H2 internals to solve basic queries

Alexandru, the changes in RandomAccessQuery will not set the lock properly on a record found in the cache:... Constantin Asofiei

08:53 AM Feature #6995: possibly support NO-UNDO temporary tables directly in H2

Integrated the patch into 7062a. Also, the H2 changes made it to trunk.
I've reviewed the changes again and I have... Alexandru Lungu

08:45 AM Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code

Done several testing iterations with 7132a_h2/rev. 15 and the issue is solved. The bad news are that I couldn't notic... Alexandru Lungu

04:58 AM Feature #6444: dataset improvements

Tested the (de)serialization of recursive data relation for the remote calls.
Works OK. Igor Skornyakov

03:56 AM Feature #6582: implement multi-table AdaptiveQuery

#7061 is mostly finished and now we have a @lazy@ keyword in FWD-H2 which works as a H2 database-cursor allowing us t... Alexandru Lungu

03:15 AM Feature #7061: Enable the use of lazy result sets in H2

Radu, I merged your changes from 7061a to 7026a. Note that 7026a is frozen right now.
First of all, I moved @suppo... Alexandru Lungu

02/25/2023

07:16 AM Feature #6444: dataset improvements

Finished re-testing fixes for this task and #6453 after rebasing 6444a branch to the new trunk is finished.
Committe... Igor Skornyakov

02/24/2023

03:12 PM Bug #6812 (WIP): fix FastFindCache to use a shared instance per persistent database

I converted the code to use @Database@ object directly and reverted changes I made initially to visibility modifiers.... Boris Schegolev

09:18 AM Bug #6812: fix FastFindCache to use a shared instance per persistent database

I pushed the patch as revision 6812a/14485, working on better implementation (@Database@ object as key, cleanup, etc.) Boris Schegolev

11:06 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries

Another point related to #6813-9 with query predicates which differ just with inlined literals. After the predicate ... Constantin Asofiei

06:58 AM Feature #7062: Direct access to H2 internals to solve basic queries

I merged the changes from 7062a into 7026a - the branch names are quite confusing :)
I have good results, similar ... Alexandru Lungu

06:02 AM Feature #7061: Enable the use of lazy result sets in H2

> I'll wait for a final decision on this.
Well, it definitely looks like it really depends on the converted code. I ... Alexandru Lungu

05:46 AM Feature #7061: Enable the use of lazy result sets in H2

Alexandru Lungu wrote:
> Alexandru Lungu wrote:
> > ** Count how many actual lazy queries are there in a large appl... Radu Apetrii

04:21 AM Feature #7061: Enable the use of lazy result sets in H2

Alexandru Lungu wrote:
> ** Count how many actual lazy queries are there in a large application: static vs dynamic, ... Alexandru Lungu

04:42 AM Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code

Alexandru Lungu wrote:
> Please make a new commit which reverts the changes for that less used classes. I would like... Radu Apetrii

02/23/2023

05:17 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database

Please create a 6812a branch from trunk and apply the diff. This will make it easier to review in context.
I've on... Eric Faulhaber

04:40 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database

I am attaching a suggested solution. It's somewhat raw (I had to make some elements public), but I can fix that for t... Boris Schegolev

12:35 PM Feature #6444: dataset improvements

I'm re-testing temp-table ans data-set changes from #6453 and this task with 6444a rebased to the trunk.
After fixin... Igor Skornyakov

11:08 AM Bug #7132 (WIP): Eliminate for-each loops and lambda in FWD-H2 code

*This is a review for 7132a_h2, rev. 14*
There are many changes in several files, so I've done a skim review of th... Alexandru Lungu

09:24 AM Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code

Alexandru Lungu wrote:
> Lastly, I think there may be an overhead by using @synchronized@ even in single-user H2 ins... Radu Apetrii

09:39 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2

I recall a scenario in which some records were updated in a for-loop and their new values were the same as the old va... Alexandru Lungu

08:13 PM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2

These should not occur since we create the @SET@ part of statement based only on changed properties (@BaseRecord.dirt... Ovidiu Maxiniuc

04:53 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Ovidiu Maxiniuc wrote:
> I altered your tests and remove the index for both tables: in this case we have the more lo... Dănuț Filimon

02/22/2023

04:34 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

I am really puzzled about this fact. I found the article in a parallel investigation. It really shocked my understand... Ovidiu Maxiniuc

07:00 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Alexandru Lungu wrote:
> Danut, please extract this into a separate 4GL test: CI database field with CS query parame... Dănuț Filimon

03:33 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Ovidiu Maxiniuc wrote:
> Yes, this could be an improvement if the strings are really different at their beginning. T... Alexandru Lungu

11:23 AM Feature #7061: Enable the use of lazy result sets in H2

I reverted your latest changes to H2 because I wanted to merge a tested, profiled version (rev. 15).
* The null che... Alexandru Lungu

03:44 AM Feature #7061: Enable the use of lazy result sets in H2

Alexandru Lungu wrote:
> > If the dependency is the H2 dialect on its own, then I think the condition should be some... Radu Apetrii

08:57 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2

I encountered several fake-updates in large customer applications. A fake-update is something like @UPDATE tt SET f1 ... Alexandru Lungu

08:50 AM Bug #7138 (Closed): Short circuit fake-update (update with a new value eqaul to the old value) in H2

Alexandru Lungu

02/21/2023

03:40 PM Feature #6371: implement SAVE CACHE statement

Please create a 6371b branch from trunk for this patch and the other remaining features. Thanks. Eric Faulhaber

02:36 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Alexandru Lungu wrote:
> I agree that we still need to use the @Collator@, but maybe we could have done something li... Ovidiu Maxiniuc

05:17 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Ovidiu Maxiniuc wrote:
> I looked again at your results in #7108-8. They do not seem alright. There are several case... Alexandru Lungu

05:04 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Ovidiu Maxiniuc wrote:
> Yes, I think we need that. I do not have an exact example (when I was working with these I ... Alexandru Lungu

12:26 PM Bug #7113 (Review): Problem with nested CAN-FIND conversion

Fixed SQL generation.
Committed to 7113a/14896.
Please review.
Thank you. Igor Skornyakov

11:57 AM Bug #7047: Problem with AdaptiveQuery and ScrollableResults

Alexandru Lungu wrote:
> I can't say why PostgreSQL behaves differently, but logically all non-scrolling 4GL queri... Eric Faulhaber

09:34 AM Bug #7047: Problem with AdaptiveQuery and ScrollableResults

As a side investigation which may help here:
@AdaptiveQuery@ is not considering @recid@ index as a sorting index. ... Alexandru Lungu

10:00 AM Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code

Committed rev. 13 finishing replacements from for-each loops to classical for loops. I've done some tests, but there ... Alexandru Lungu

07:14 AM Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code

Created 7132a_h2 from trunk rev. 11. Committed rev. 12 including lots of replacements from for-each loops to classica... Alexandru Lungu

08:26 PM Feature #7020 (Review): always use "expanded" extent fields

I attempted to rebase 7020a to trunk, but that proved to be a very time consuming task, practically duplicating Const... Ovidiu Maxiniuc

02/20/2023

03:45 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Alexandru Lungu wrote:
> I am facing a hot-spot in my profiling that may actual affect #7108 effort as well. It is r... Ovidiu Maxiniuc

02:24 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Dănuț Filimon wrote:
> The tests from #7108-8 were done *without any patch applied*. I retested with the patch appli... Ovidiu Maxiniuc

08:48 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Ovidiu, I recall that you had done some work with locale at some point. Please let me know if you can help me on this... Alexandru Lungu

02:28 PM Bug #7113: Problem with nested CAN-FIND conversion

The only remaining issue is that generated SQL statement contains extra closing brackets @)@ at the end of the WHERE ... Igor Skornyakov

11:20 AM Bug #7113: Problem with nested CAN-FIND conversion

Committed fix for the nested CAN-FIND to 7113a/14485. Igor Skornyakov

10:55 AM Bug #7113: Problem with nested CAN-FIND conversion

Created task branch 7113a. Igor Skornyakov

09:48 AM Bug #7113: Problem with nested CAN-FIND conversion

Igor Skornyakov wrote:
> Igor Skornyakov wrote:
> > Fixed nested CAN-FIND conversion (see attached .diff).
> > Ple... Igor Skornyakov

08:52 AM Bug #7113: Problem with nested CAN-FIND conversion

Igor Skornyakov wrote:
> Fixed nested CAN-FIND conversion (see attached .diff).
> Please review.
> Thank you.
>
... Igor Skornyakov

08:40 AM Bug #7113: Problem with nested CAN-FIND conversion

Fixed nested CAN-FIND conversion (see attached .diff).
Please review.
Thank you.
Working on runtime issue (#7113... Igor Skornyakov

08:56 AM Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code

Alexandru Lungu wrote:
> Second, there is an overhead with using lambdas, especially the ones which reference local ... Radu Apetrii

04:10 AM Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code

There is an overhead in using foreach loops: @for (Object obj : objs)@. This is because an iterator object is generat... Alexandru Lungu

03:47 AM Bug #7132 (WIP): Eliminate for-each loops and lambda in FWD-H2 code

Alexandru Lungu

03:32 AM Feature #7061: Enable the use of lazy result sets in H2

Radu:
* I've created 7061a branched from trunk to commit your changes to.
* Please notify me once you address the r... Alexandru Lungu

02/17/2023

09:49 AM Feature #7061: Enable the use of lazy result sets in H2

Alexandru Lungu wrote:
> As the patch and H2 modifications are mostly complete, in the sense that I have no obvious ... Alexandru Lungu

02/16/2023

05:36 PM Bug #6887: improve performance of dataset/table[-handle] parameters

The methods/attributes implemented by #6444 are not related to parameters. They perform the same regardless the datas... Ovidiu Maxiniuc

04:31 PM Bug #6887: improve performance of dataset/table[-handle] parameters

I didn't make any changes for this task. Not sure if there are any relevant changes coming from #6444. Boris Schegolev

03:23 PM Bug #6887: improve performance of dataset/table[-handle] parameters

Has any of this implementation been touched by the recent waves of performance work in 3821c and 6129c, or are we ess... Eric Faulhaber

03:26 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database

Boris, please look at the @FastFindCache@ implementation and ask any questions you may have as it pertains to this task. Eric Faulhaber

03:19 PM Bug #6919: fix ErrorManager.displayError in TempTableBuilder

Is there anything left to do on this task, or can we close it? Eric Faulhaber

09:34 AM Feature #7061: Enable the use of lazy result sets in H2

Eric Faulhaber wrote:
> One clarification to this point. It is not so much the fact that the new lazy mode should be... Alexandru Lungu

09:11 AM Support #7058: get the FWD fork of the H2 code base under version control

*UPDATE*: regression testing passed; merged 7062a_h2 to FWD-H2 trunk including support for direct access to internal ... Alexandru Lungu

06:18 AM Support #7058: get the FWD fork of the H2 code base under version control

Eric Faulhaber wrote:
> Alexandru, if there is any change to the build process, beyond just checking out the trunk F... Alexandru Lungu

09:07 AM Feature #7062 (Review): Direct access to H2 internals to solve basic queries

Merged 7062a_h2 into trunk after adding support for some extra data-types from FWD (object as resourceId and decimal ... Alexandru Lungu

07:48 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

The tests from #7108-8 were done *without any patch applied*. I retested with the patch applied and there is no diffe... Dănuț Filimon

02/15/2023

03:01 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Alexandru Lungu wrote:
> Do you mean the case where the field is case-insensitive and the field is case-sensitive, b... Ovidiu Maxiniuc

09:04 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

I found several mismatched between FWD and 4GL. All of the tests are done in the following manner:... Dănuț Filimon

03:53 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Danut, please make a complete set of independent *4GL tests* for each of these cases - or *search the testcases proje... Alexandru Lungu

03:28 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Ovidiu Maxiniuc wrote:
> The problem is I do not think forcing the character substitutions to be case-sensitive is t... Alexandru Lungu

01:54 PM Feature #7061: Enable the use of lazy result sets in H2

Radu Apetrii wrote:

> I modified the patch from the last post a bit, because the change with the removal of @Prog... Eric Faulhaber

08:51 AM Feature #7061: Enable the use of lazy result sets in H2

Update: I've committed a fix to 7061a_h2, rev. 12. *I no longer have issues when testing a large customer application... Radu Apetrii

12:58 PM Support #7058: get the FWD fork of the H2 code base under version control

Alexandru Lungu wrote:
> Once we have the pending branches merged into the FWD-H2 trunk, we will have a new build ... Eric Faulhaber

06:08 AM Support #7058: get the FWD fork of the H2 code base under version control

For H2, Eric will push this when it is ready. Greg Shah

03:56 AM Support #7058: get the FWD fork of the H2 code base under version control

*UPDATE*: regression testing passed; merged 6829a_h2 to FWD-H2 trunk including performance improvements regarding les... Alexandru Lungu

12:01 PM Feature #7037: remove dirty share manager

Guys, I want to commit the dirty sharing changes, but I want to know what dirty share state should be for the existin... Stanislav Lomany

10:52 AM Feature #6444: dataset improvements

Branch 6444a was rebased to the trunk rev. 14484.
Pushed up to revision 14493. Igor Skornyakov

09:13 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Error handler support for MariaDB committed to 6628a/14485
See also #6628-175.
Please review.
Thank you. Igor Skornyakov

08:24 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Created task branch 6628a from the trunk rev.14484 Igor Skornyakov

06:53 AM Feature #7062: Direct access to H2 internals to solve basic queries

Alexandru Lungu wrote:
> I am planning to make some final changes to 7062a (javadoc and small performance changes), ... Alexandru Lungu

03:59 AM Bug #6829 (Review): H2 forces re-parse of all prepared statements when metadata is changed

Merged 6829a_h2 to FWD-H2 trunk including performance improvements regarding less recompiling of prepared statements ... Alexandru Lungu

03:35 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

There are no problems with rev.11. I checked @psCache@ hit/miss with rev.6 and rev.11 and didn't get very different r... Dănuț Filimon

03:58 AM Bug #7120 (Test): NO-UNDO dynamic temp-table does not set the NO-UNDO at the .schema

Changes look good. Thanks. Constantin Asofiei

02/14/2023

06:29 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

Review of @ffCache-20230214.patch@.
Nice detective work. Indeed, there seems to be a key collision which causes th... Ovidiu Maxiniuc

06:18 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns

I've done some changes to how strings are compared in H2. I included a @rtrim@ parameter that, if set to true (by def... Dănuț Filimon

04:08 PM Bug #7120 (WIP): NO-UNDO dynamic temp-table does not set the NO-UNDO at the .schema

Good analysis!
Actually, the value of the @undo@ table attribute is not copied from the source table. It is by defau... Ovidiu Maxiniuc

07:00 AM Bug #7120: NO-UNDO dynamic temp-table does not set the NO-UNDO at the .schema

This test:... Constantin Asofiei

06:58 AM Bug #7120 (Test): NO-UNDO dynamic temp-table does not set the NO-UNDO at the .schema

Constantin Asofiei

12:28 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> Finished with error Handler support for MariaDB.
> Because of #7113 it was tested with a s... Igor Skornyakov

08:12 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

Dănuț Filimon wrote:
> Committed 6829a_h2/rev.7. Stopped forced re-parsing for prepared statements.
>
> Each SELE... Alexandru Lungu

07:10 AM Support #7058: get the FWD fork of the H2 code base under version control

Will pre-built FWD-H2 revisions jars be uploaded into GCD repository ?
Tomasz Domin

07:00 AM Support #7058: get the FWD fork of the H2 code base under version control

*UPDATE*: regression testing passed; merged 6928a_h2 to FWD-H2 trunk including performance improvements for UPDATE st... Alexandru Lungu

07:01 AM Feature #6928 (Test): H2 UPDATE performance improvement

Merged 6928a_h2 to FWD-H2 trunk including performance improvements for UPDATE statement, with in-memory and PageStore... Alexandru Lungu

06:52 AM Feature #6928: H2 UPDATE performance improvement

Thanks, the change is OK. It can be merged to trunk. Constantin Asofiei

06:26 AM Feature #6928: H2 UPDATE performance improvement

Constantin Asofiei wrote:
> Was the branch bound? I don't see rev 11 for 6928a_h2.
What a quick response! My bzr ... Alexandru Lungu

06:23 AM Feature #6928: H2 UPDATE performance improvement

Alexandru Lungu wrote:
> Tested 6928a_h2/rev. 10 and found a regression: the old-row stored by @deltaChangeCollector... Constantin Asofiei

06:20 AM Feature #6928: H2 UPDATE performance improvement

Tested 6928a_h2/rev. 10 and found a regression: the old-row stored by @deltaChangeCollector@ inside the H2 update sta... Alexandru Lungu

06:48 AM Feature #7061: Enable the use of lazy result sets in H2

I've added the option to execute queries in a lazy manner. Alongside this change, @AdaptiveQuery@ now uses only @Scro... Radu Apetrii

01:22 AM Bug #7113: Problem with nested CAN-FIND conversion

Ovidiu Maxiniuc wrote:
> The nested CAN-FIND is an old issue. There were some fixes in time (see #3040, #3465, #3771... Igor Skornyakov

09:22 PM Feature #7037: remove dirty share manager

Review of @7037b.diff@.
A clean implementation. Nice job. The patch should work as described in note #7037-35.
Pl... Ovidiu Maxiniuc

02/13/2023

06:17 PM Feature #6371: implement SAVE CACHE statement

Attaching a working version of sequences support in @SchemaCheck@ and @SchemaValidator@ for review. Boris Schegolev

05:20 PM Bug #7113: Problem with nested CAN-FIND conversion

The nested CAN-FIND is an old issue. There were some fixes in time (see #3040, #3465, #3771, and others) and the issu... Ovidiu Maxiniuc

09:13 AM Bug #7113 (WIP): Problem with nested CAN-FIND conversion

Igor Skornyakov

05:19 AM Bug #7113: Problem with nested CAN-FIND conversion

Thank you for checking, you can continue with your normal tasks. Constantin Asofiei

05:03 AM Bug #7113: Problem with nested CAN-FIND conversion

Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > One more thing: is this a regression in 6129c compared to tr... Igor Skornyakov

05:02 AM Bug #7113: Problem with nested CAN-FIND conversion

Constantin Asofiei wrote:
> One more thing: is this a regression in 6129c compared to trunk?
No, I get the same e... Igor Skornyakov

04:54 AM Bug #7113: Problem with nested CAN-FIND conversion

One more thing: is this a regression in 6129c compared to trunk? Constantin Asofiei

04:52 AM Bug #7113: Problem with nested CAN-FIND conversion

Constantin Asofiei wrote:
> So instead of @?@ it should be @Order.OrderNum@ and @OrderLine.ItemNum@, respectively? I... Igor Skornyakov

04:25 AM Bug #7113: Problem with nested CAN-FIND conversion

Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > What's the problem with the query? What would be the correct... Constantin Asofiei

04:23 AM Bug #7113: Problem with nested CAN-FIND conversion

Constantin Asofiei wrote:
> What's the problem with the query? What would be the correct variant? If you change the ... Igor Skornyakov

04:16 AM Bug #7113: Problem with nested CAN-FIND conversion

What's the problem with the query? What would be the correct variant? If you change the FQL manually to the correct v... Constantin Asofiei

03:02 AM Bug #7113: Problem with nested CAN-FIND conversion

The problem is at the program conversion (not only runtime).
The query from the previous noye is converted to... Igor Skornyakov

09:14 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Greg Shah wrote:
> > Because of #7113 it was tested with a simple test only
>
> Go ahead and fix this now.
OK... Igor Skornyakov

08:48 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

> Because of #7113 it was tested with a simple test only
Go ahead and fix this now. Greg Shah