Activity

From 04/10/2023 to 05/09/2023

05/10/2023

10:50 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Constantin Asofiei wrote:
> Ovidiu, what is the state of the 6813a branch? I'd like to complete this.
6813a was b... Ovidiu Maxiniuc

05/09/2023

06:46 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Marian Edu wrote:
> Ovidiu Maxiniuc wrote:
> > IIRC, this is how 4GL works. Probably there are two values in the so... Ovidiu Maxiniuc
10:19 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: attaching the procedure i mentioned :) Maciej Zieniuk
10:16 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Vladimir Tsichevski wrote:
> Ovidiu Maxiniuc wrote:
> > Vladimir Tsichevski wrote:
> > > Maciej Zieniuk wrote:
> ... Maciej Zieniuk
09:02 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Ovidiu Maxiniuc wrote:
> IIRC, this is how 4GL works. Probably there are two values in the source which would brea... Marian Edu
07:32 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Ovidiu Maxiniuc wrote:
> Maciej Zieniuk wrote:
> > I don't think it's a coincidence that just after this test... Maciej Zieniuk
07:25 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Vladimir Tsichevski wrote:
> There is something wrong with error propagation in FWD when a persistent procedure is c... Maciej Zieniuk
02:47 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: I've used this to validate the tokens used in @upPath@, @relativePath@, @downPath@ and @absolutePath@ (btw, this is n... Constantin Asofiei
02:31 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: I think the change is OK. I had to read it a few times, but your comments helped. Greg Shah
11:19 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: As an addendum: the point of this change is to have method definition for i.e. @upPath@ with 1, 2, 3 and 4 arguments.... Constantin Asofiei
11:17 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: I'm counting the arguments for the @relativePath@, @upPath@ and @downPath@ from @rules/@; the result is this:... Constantin Asofiei
11:15 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: What is the list of remaining issues to be addressed here? We have multiple customers starting to deploy and requiri... Greg Shah
10:18 AM Bug #7336 (Closed): optimize DmoMeta.byLegacyName: Alexandru Lungu
06:35 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors: I've applied the suggested comments. The changes are on 7026d, rev. 14563.
I haven't tested yet with a large custome... Radu Apetrii
04:28 AM Bug #7329 (WIP): improve FieldReference resolution of getter/setter/extent accessors: Radu, please fix this in 7026d. Alexandru Lungu
04:01 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors: Constantin Asofiei wrote:
> * index
Here I meant 'getExtent'
Constantin Asofiei
06:32 AM Bug #7330: Increase psCache size: Constantin Asofiei wrote:
> And something else thing to consider: any PreparedStatement instance is linked to a JDBC... Constantin Asofiei
06:31 AM Bug #7330: Increase psCache size: Alexandru, for example, in an application, I saw ~8k JDBC prepared statements being created. If the actual used cach... Constantin Asofiei
04:45 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses: Alexandru Lungu wrote:
> Radu Apetrii wrote:
> > Also, I've left two TODOs which will be taken care of as soon as t... Radu Apetrii
04:01 AM Feature #7194: Avoid generating an ORDER-BY clause if not required: I have modified @RandomAccessQuery@ so that an ORDER BY clause will not be added to the FQL if a unique finding is en... Radu Apetrii
03:53 AM Bug #7334: Reclaim used sessions to improve performance: Alexandru Lungu wrote:
> Basically, allow each session to be reclaimed, but only within a limited time threshold.
... Alexandru Lungu
02:56 AM Bug #7321: Improve FWD-H2 wildcard projection: *Committed 7321a_h2/rev.18.* Improved wildcard projection by doing a fast copy of the current search row.
This imp... Dănuț Filimon

05/08/2023

05:59 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: There is something wrong with error propagation in FWD when a persistent procedure is concerned.
The procedure @pe... Vladimir Tsichevski
04:16 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> I don't fully understan this test @tests.dataset.TestFillMode@ method @withPkCorrectBufferAs... Ovidiu Maxiniuc
04:11 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> Another commit i have added to @4514a@ p2j branch. That fixes the @TestFill@ test.
> [...]
... Ovidiu Maxiniuc
03:59 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> I don't think it's a coincidence that just after this test and exception, other tests are un... Ovidiu Maxiniuc
03:42 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Ovidiu Maxiniuc wrote:
> Vladimir Tsichevski wrote:
> > Maciej Zieniuk wrote:
> > > I found this exception from th... Vladimir Tsichevski
03:33 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Vladimir Tsichevski wrote:
> Another conversion issue: @dataset.TestAcceptChanges@ legacy class converts to:
> [...... Ovidiu Maxiniuc
02:16 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Vladimir Tsichevski wrote:
> Maciej Zieniuk wrote:
> > I found this exception from the server's logs, that happens ... Ovidiu Maxiniuc
09:41 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I don't fully understan this test @tests.dataset.TestFillMode@ method @withPkCorrectBufferAsign@, specifically this p... Maciej Zieniuk
03:30 PM Feature #7323: Implement soft unique index in FWD-H2: Alexandru Lungu wrote:
> *Eric, Constantin, Ovidiu*: is the lack of H2 unique indexes for temporary tables out of ... Eric Faulhaber
02:59 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Ovidiu, what is the state of the 6813a branch? I'd like to complete this. Constantin Asofiei
09:44 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: The example is good, I understand what you mean: the problem are not the literals, but the fact that different buffer... Ovidiu Maxiniuc
02:30 PM Bug #4071: FWD server stops allowing new web client logins after abend: I think the testcase in #7193-62 is another example of this same issue. Context cleanup should never run on the read... Greg Shah
10:25 AM Bug #7334 (WIP): Reclaim used sessions to improve performance: This task is meant to solve #7167, #6820, and #4021 at once.
Please refer to #7167 for the initial problem. Here w... Alexandru Lungu
10:12 AM Bug #7334 (Closed): Reclaim used sessions to improve performance: Alexandru Lungu
10:08 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses: Radu Apetrii wrote:
> Also, I've left two TODOs which will be taken care of as soon as the changes from #7066 will b... Alexandru Lungu
06:31 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses: I've committed to 7252a, rev.14562 and 7252a_h2, rev.18 a few changes that allow the use of direct-accessing when ret... Radu Apetrii
06:05 AM Bug #7330: Increase psCache size: Consider extending the @psCache@ size from 2048 to 65535. This was attempted before in #6829, but the memory consumpt... Alexandru Lungu
05:05 AM Bug #7330 (Closed): Increase psCache size: Alexandru Lungu
04:51 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: *Committed 7138a_h2/rev.22.* Allowed @ValueNull@ values to be compared. Dănuț Filimon
04:32 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: Dănuț Filimon wrote:
> After looking at the code, I remember that I excluded @Value.NULL@ because I was using @compa... Alexandru Lungu
04:31 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: I retested the application and counted updates that use null, from a total of *1352885* I obtained the following:
|_... Dănuț Filimon
04:25 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors: Refactor FieldReference to lazily initialize the fields which are now in the constructor; this includes:
* getter
*... Constantin Asofiei
04:22 AM Bug #7329 (Closed): improve FieldReference resolution of getter/setter/extent accessors: Constantin Asofiei
03:22 AM Bug #5452 (WIP): eliminate use of ResultSet.CONCUR_UPDATABLE?: I am OK with the current changes.
However, you still need to extend your removal of @readOnly@. More exactly, ther... Alexandru Lungu

05/07/2023

08:08 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Another commit i have added to @4514a@ p2j branch. That fixes the @TestFill@ test.... Maciej Zieniuk
06:00 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I can create it. So essentially, we take out the content of the @passWrongDefinition@ test as a standalone procedure ... Maciej Zieniuk

05/06/2023

01:40 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> I did run @TestOutputDynamicDsInDynamicProc@ against 4GL 11.6 and it was green (all test met... Vladimir Tsichevski
01:34 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Also just pushed a commit to @4514a@ p2j branch that fixes the @TestDataSourceModified@ test - error 4083 as warning:... Maciej Zieniuk
01:28 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I did run @TestOutputDynamicDsInDynamicProc@ against 4GL 11.6 and it was green (all test methods passing) Maciej Zieniuk
01:25 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> I don't think it's a coincidence that just after this test and exception, other tests are un... Vladimir Tsichevski
12:58 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I don't think it's a coincidence that just after this test and exception, other tests are unable to run correctly.
... Maciej Zieniuk
12:17 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Vladimir Tsichevski wrote:
> Maciej Zieniuk wrote:
> > I found this exception from the server's logs, that happens ... Vladimir Tsichevski
12:15 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> I found this exception from the server's logs, that happens inside the @passWrongDefinition@... Vladimir Tsichevski
10:30 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I found this exception from the server's logs, that happens inside the @passWrongDefinition@. I am guessing they are ... Maciej Zieniuk
04:42 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Vladimir, the @setUpBeforeClass@ runs fine on it's own. But let the @passWrongDefinition@ test run and then any other... Maciej Zieniuk

05/05/2023

04:38 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> There is one more issue which i tried to debug. The @tests.dataset.parameter.output.TestOu... Vladimir Tsichevski
08:50 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Another conversion issue: @dataset.TestAcceptChanges@ legacy class converts to:... Vladimir Tsichevski
07:33 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Did pushed a new revision on testcases #1405 that includes some changes in the dataset tests, mainly clean-up after e... Marian Edu
07:26 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Greg Shah wrote:
> We might as well fix it here, now.
>
> It is weird syntax.
It just looks like that, however @... Marian Edu
10:19 AM Feature #7323: Implement soft unique index in FWD-H2: Alexandru Lungu wrote:
> prior simple SELECT is faster than a SAVEPOINT to avoid partial inserts in case of constrai... Alexandru Lungu
10:11 AM Feature #7323: Implement soft unique index in FWD-H2: I just realized that direct-access is not necessarily an option because these validation statements are prepared only... Alexandru Lungu
09:47 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: Tested with a large customer application and I get similar results: between -0.1% and +0.1%. I will retest on a newer... Alexandru Lungu
05:30 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: Alexandru Lungu wrote:
> * you can do a quick reconversion of Hotel GUI and use H2 persistent database just to check... Dănuț Filimon
09:31 AM Bug #5452 (Review): eliminate use of ResultSet.CONCUR_UPDATABLE?: Removed readOnly flag from SQLQuery, checked with HotelGUI and everything works fine.
Commited to 5452a revision 14561. Ștefan Roman
06:39 AM Bug #5452 (WIP): eliminate use of ResultSet.CONCUR_UPDATABLE?: Ștefan Roman
05:50 AM Bug #5452: eliminate use of ResultSet.CONCUR_UPDATABLE?: Created 5452a from trunk/rev. 14560. Alexandru Lungu
05:43 AM Bug #7321: Improve FWD-H2 wildcard projection: On a large customer application, I checked how much time this scenario (wildcard expansion and search row projection)... Alexandru Lungu
05:41 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...: Boris, first, run conversion with @-Drules.tracing=true@. Use this for both the OO and non-OO tests.
You can look... Constantin Asofiei
05:37 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...: Gentlemen, I couldn't figure out details of the conversion procedure. So, anyone who has time and knowledge is more t... Boris Schegolev
05:32 AM Feature #7320: Extend H2 tester from Hotel GUI: Some of our recent work on FWD-H2 performance can be captured with tests like the following. Please make sure you inc... Alexandru Lungu

05/04/2023

06:11 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: We might as well fix it here, now.
It is weird syntax. Normally you would call @valid-handle(dsMasterDynamic)@ to... Greg Shah
05:41 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> In my testcases branch i changed this code to assign the handle to some other handle, as it ... Vladimir Tsichevski
05:25 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: In my testcases branch i changed this code to assign the handle to some other handle, as it did not compile for me.
... Maciej Zieniuk
05:16 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I have an issue compiling the @TestHandle.cls@ test: statements like... Vladimir Tsichevski
09:30 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> I identified the issue, thhat the @run support/dataset/create/dsMaster.p@ does not propagate... Ovidiu Maxiniuc
03:53 PM Bug #6812 (WIP): fix FastFindCache to use a shared instance per persistent database: Boris Schegolev
06:05 AM Bug #7319: Fix adaptive query test suite from testcases: Alexandru Lungu wrote:
> Are these the issues for the persistent database?
Yes, I forgot to mention. These issues ... Radu Apetrii
05:59 AM Bug #7319: Fix adaptive query test suite from testcases: Are these the issues for the persistent database? Are they the same as for temporary database? Alexandru Lungu
05:52 AM Bug #7319: Fix adaptive query test suite from testcases: It is done. Inside @adaptive_scrolling/persistent-adaptive_tests@ there are 2 folders (one for no-scrolling tests and... Radu Apetrii
04:08 AM Bug #7319: Fix adaptive query test suite from testcases: Radu Apetrii wrote:
> Alexandru Lungu wrote:
> > AFAIK, Radu, you already have such work already done. Please commi... Alexandru Lungu
04:02 AM Bug #7319: Fix adaptive query test suite from testcases: Alexandru Lungu wrote:
> AFAIK, Radu, you already have such work already done. Please commit to testcases the adapti... Radu Apetrii
04:15 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: *Committed 7138a_h2/rev.21*. Fixed a concurrency problem. @inMemUpdate@ and @notInMemUpdate@ need to be set to *null*... Dănuț Filimon
03:24 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: From the testing POV, we already covered several large applications for in-memory H2.
Danut:
* you can do a quick r... Alexandru Lungu

05/03/2023

04:30 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Greg Shah wrote:
> > I identified the issue, thhat the @run support/dataset/create/dsMaster.p@ does not propagate th... Vladimir Tsichevski
03:01 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: > I identified the issue, thhat the @run support/dataset/create/dsMaster.p@ does not propagate the assigned handle @o... Greg Shah
02:48 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: This test which had error propagation issues is working with the 3827b branch :)
I will rebase my changes on top o... Maciej Zieniuk
11:44 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Vladimir has some error propagation changes in task branch 3827b. Can you try those to see if the issue is resolved? Greg Shah
02:33 PM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: Dănuț Filimon wrote:
> Should I do similar tests for persistent tables?
As a lower priority, yes, just to make ... Eric Faulhaber
11:30 AM Feature #7323: Implement soft unique index in FWD-H2: I've done some logging with FWD-H2 on a large customer application and identified the following for a POC run. Out of... Alexandru Lungu
10:48 AM Feature #7323 (Closed): Implement soft unique index in FWD-H2: Alexandru Lungu
09:51 AM Feature #6630: optimize return of table parameter: I recreated a similar scenario where @TemporaryBuffer.loopDelete@ is called using a class field that has a destructor... Dănuț Filimon

05/02/2023

04:28 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I just pushed a potential fix to 4514a p2j branch, for the @tests.dataset.parameter.input.TestInputDynamicDsInDynamic... Maciej Zieniuk
03:00 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Attached @file-cvt-list.txt@ Maciej Zieniuk
01:26 PM Bug #7113: Problem with nested CAN-FIND conversion: > Sorry, but I do not understand. The conversion w/o my patch was incorrect and, AFAIR, you agreed with this. The fac... Ovidiu Maxiniuc
10:03 AM Bug #7321 (WIP): Improve FWD-H2 wildcard projection: Alexandru Lungu
09:56 AM Bug #7321: Improve FWD-H2 wildcard projection: Recently, queries over the temporary database use the wildcard syntax: @tt.*@ to select all the columns. If there are... Alexandru Lungu
09:28 AM Bug #7321 (Closed): Improve FWD-H2 wildcard projection: Alexandru Lungu
09:27 AM Feature #7320: Extend H2 tester from Hotel GUI: This task is related to the H2 tester from Hotel GUI, used to track performance of FWD-H2 in certain scenarios. We sh... Alexandru Lungu
08:50 AM Feature #7320 (WIP): Extend H2 tester from Hotel GUI: Alexandru Lungu
07:35 AM Bug #7319: Fix adaptive query test suite from testcases: The @testcases/adaptive-scrolling@ test-suite is a reference point for our implementation of @AdaptiveQuery@. It incl... Alexandru Lungu
07:21 AM Bug #7319 (New): Fix adaptive query test suite from testcases: Alexandru Lungu
07:26 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: I've tested fake-update performance for larger tables and extent fields, results of each test are measured in millise... Dănuț Filimon
07:21 AM Bug #7267 (Test): CompoundQuery FOR FIRST, EACH only retrieves the first record found: This can be closed/rejected. Alexandru Lungu
07:20 AM Bug #7267 (Review): CompoundQuery FOR FIRST, EACH only retrieves the first record found: Alexandru Lungu
07:20 AM Bug #7267 (WIP): CompoundQuery FOR FIRST, EACH only retrieves the first record found: Alexandru Lungu
07:16 AM Bug #7235 (Test): Avoid selecting all fields for an CAN-FIND sub-select: Merged 7026c to trunk as rev. 14553. Alexandru Lungu
04:15 AM Feature #7066: Implement multi-table indexed query in H2: While doing some work on #7252, I noticed that there might be some (other) stuff that is unnecessary computed when an... Radu Apetrii
04:02 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses: After doing some testing, I managed to form the following table:
|_. Scenario |_. Normal statements |_. Direct-a... Radu Apetrii

05/01/2023

03:43 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej, can you provide me and other with the @file-cvt-list.txt@ you use to convert tests for this issue, please. Th... Vladimir Tsichevski

04/29/2023

04:02 AM Bug #7113: Problem with nested CAN-FIND conversion: Ovidiu Maxiniuc wrote:
> Igor,
> I have fixed the extra closing parenthesis as part of another task. Please do not... Igor Skornyakov
08:34 PM Bug #7113: Problem with nested CAN-FIND conversion: Igor,
I have fixed the extra closing parenthesis as part of another task. Please do not put additional effort in th... Ovidiu Maxiniuc
03:38 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> The expectation is that the @for each ttOrderCustomer:@ will fail with @Progress.Lang.Error@... Marian Edu
09:56 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> The expectation is that the @for each ttOrderCustomer:@ will fail with @Progress.Lang.Error@... Ovidiu Maxiniuc

04/28/2023

04:15 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I am not sure what to do with the @tests.dataset.parameter.input.TestDatasetBind@ class test @referenceOnlyNotValid@.... Maciej Zieniuk
09:09 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Correct. ... Greg Shah
09:00 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Greg Shah wrote:
> > Aka, this doesn't convert because of the use of @no-error@:
>
> What is the error? Is it du... Marian Edu
08:04 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: > Aka, this doesn't convert because of the use of @no-error@:
What is the error? Is it during parsing or during l... Greg Shah
04:18 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Pushed a few changes, the conversion issue with @create dataset/data-source@ was due to the fact that @no-error@ opti... Marian Edu
04:06 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> You are right. I initially though this is about @dsInit@ being unknown, not initialized, b... Marian Edu
02:27 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: > This sounds good to me, but then why the handle is invalid? I would check the converted code, from what we've seen ... Maciej Zieniuk
01:49 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> - @tests.dataset.parameter.inout.TestInputOutputDynamicDsInDynamicProc@ method @passDatase... Marian Edu
04:12 AM Feature #7194: Avoid generating an ORDER-BY clause if not required: Alexandru Lungu wrote:
> ** What if the uniquely found record is changed? The query should invalidate (or not?) and ... Radu Apetrii

04/27/2023

09:30 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej: Please do fix all of these conversion issues. I don't want to leave behind any latent problems.
So we nee... Greg Shah
09:19 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> Marian, i don't think the @support/test/HandleFactory.cls@ is converting in newest testcases... Marian Edu
07:49 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Marian, i don't think the @support/test/HandleFactory.cls@ is converting in newest testcases revision, because of the... Maciej Zieniuk
05:32 AM Feature #7076: make CAN-FIND avoid hydration: I've tested both temporary and persistent tables with CAN-FIND and nested CAN-FIND. CAN-FIND no longer hydrates with ... Dănuț Filimon
03:50 AM Feature #6630: optimize return of table parameter: Danut, I recall I changed the @AdaptiveQuery@ from @TemporaryBuffer.loopDelete@ into a @PreselectQuery@. Basically, t... Alexandru Lungu
03:00 AM Bug #7235 (Review): Avoid selecting all fields for an CAN-FIND sub-select: Added this patch to 7026c.
Tested this. I got a -0.24% performance improvement with a 7026c profile run.
Just rebas... Alexandru Lungu

04/26/2023

05:04 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Thanks Marian, that helped.
Few findings:
- @tests.dataset.parameter.inout.TestInputOutputDynamicDsInDynamicProc@... Maciej Zieniuk
02:09 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> Oh i almost forgot, i have this weird issue, that i cannot run @ant dist@ on the testcases r... Marian Edu
10:21 AM Feature #7194 (WIP): Avoid generating an ORDER-BY clause if not required: I will move this back to 50% to allow the handling of other ORDER BY clauses (from RandomAccessQuery especially). Alexandru Lungu
10:18 AM Feature #7194 (Review): Avoid generating an ORDER-BY clause if not required: Tested this. I got a -0.24% performance improvement with a 7026c profile run.
Just rebased 7026c with trunk.
Fu... Alexandru Lungu
10:06 AM Feature #7076 (WIP): make CAN-FIND avoid hydration: Danut, please investigate this.
I am not sure if CAN-FIND still hydrates in the latest versions of FWD-H2 trunk (>1... Alexandru Lungu
09:16 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: I've tested #6928-3 and also made my own set of performance tests (results are measured in milliseconds). The results... Dănuț Filimon
05:57 AM Bug #7138 (Review): Short circuit fake-update (update with a new value eqaul to the old value) in H2: Fixed a regression in 7138a_h2 regarding updating indexed computed columns in inMemUpdate mode. If you have (f1, __if... Alexandru Lungu
08:05 AM Bug #7185: H2 in-memory lazy hydration: Merged 7185a_h2 into FWD-H2 trunk as rev. 17.
This doesn't require any FWD changes; it just optimizes the direct-ac... Alexandru Lungu
04:35 AM Bug #7185: H2 in-memory lazy hydration: Review 7185a_h2. The changes are good to go, you can proceed with the merge. Dănuț Filimon

04/25/2023

06:36 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Oh i almost forgot, i have this weird issue, that i cannot run @ant dist@ on the testcases repo, because it fails wit... Maciej Zieniuk
06:26 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I wanted to make sure that the dataset testcases actually works fine in 4GL ABLUnit.
With 4GL 11.6 version i was abl... Maciej Zieniuk
12:34 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> > Running all tests in a suite seems to make some of those tests to fail even if ran individ... Vladimir Tsichevski
10:45 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: > Running all tests in a suite seems to make some of those tests to fail even if ran individually they pass... curren... Maciej Zieniuk
07:41 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> Yes by "push" i meant bound branch to a remote repo with bzr commit.
> I will have to reba... Greg Shah
02:51 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Yes by "push" i meant bound branch to a remote repo with bzr commit.
I will have to rebase too once in a while, to ... Maciej Zieniuk
10:34 AM Feature #7194: Avoid generating an ORDER-BY clause if not required: My initial thought when I created #7194 was to optimize UNIQUE FIND/CAN-FIND for persistent databases. For temp datab... Alexandru Lungu
10:20 AM Bug #7185: H2 in-memory lazy hydration: I updated #7185-30 with the times regarding the FWD changes (lazy hydration). While the FWD-H2 changes provides a con... Alexandru Lungu
09:44 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: I tested Hotel_GUI and found no problems, but I found a regression in a customer application which I didn't manage to... Dănuț Filimon
05:51 AM Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select: Alexandru Lungu wrote:
> ... Please check that the SELECT keyword is placed correctly (as a left sibling of the num ... Dănuț Filimon
05:47 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Branch 7108a_h2 has been merged to FWD-H2 trunk at revision 16. Alexandru Lungu
05:47 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Branch 7108a has been merged to trunk at revision 14550 Alexandru Lungu
05:11 AM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries: Branch 7258a has been merged to trunk at revision 14549. Alexandru Lungu

04/24/2023

05:30 PM Feature #6371: implement SAVE CACHE statement: Code review 6371d/14544:
One *very minor* change: please fix the open curly brace at @SchemaComparator.java@:149 t... Eric Faulhaber
06:50 AM Feature #6371: implement SAVE CACHE statement: I was asked to test this statement. I will not be able to have a look at this soon, probably not even before summer v... Jurjen Dijkstra
01:42 PM Bug #7258 (Test): Optimize INDEX-INFORMATION with closed dynamic queries: @7258a.patch@ looks fine. The code in @DynamicQueryHelper@ looks much cleaner now. Good job! Ovidiu Maxiniuc
04:25 AM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries: Ovidiu, I am planning to merge 7258a today. Move this to Test after you check #7158-7: these are the same changes as ... Alexandru Lungu
09:00 AM Bug #7035: Extract query parameters from statically converted FQL: I created the temporary *JMX* and added counters for meta, temp, dirty and persistent database hits/misses. The count... Dănuț Filimon
06:46 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: *Review to 7138a_h2/rev.17* : I am OK with the changes.
Danut, please re-test 7138a_h2 (own test-cases, large cust... Alexandru Lungu
05:47 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: > I have pushed that change to @~/secure/code/p2j_repo/p2j/active/4514a@. If i find anything i will push more to the ... Greg Shah
05:34 AM Feature #7194: Avoid generating an ORDER-BY clause if not required: Radu, let the intended changes for #7194 reside in 7026c. I am thinking of merging 7026c independently from 7066a, as... Alexandru Lungu
05:30 AM Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select: *Review of #7235 patch in #7235-3.*
* When you append the NUM_LITERAL, you also append SELECT (which is OK). You u... Alexandru Lungu

04/22/2023

02:18 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I have pushed that change to @~/secure/code/p2j_repo/p2j/active/4514a@. If i find anything i will push more to the br... Maciej Zieniuk

04/21/2023

04:28 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Greg Shah wrote:
> > I am thinking about making a change to the FWD code, to something like:
> That seems reasonabl... Ovidiu Maxiniuc
08:00 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Greg Shah wrote:
> > I am thinking about making a change to the FWD code, to something like:
>
> That seems reaso... Marian Edu
07:55 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: > I am thinking about making a change to the FWD code, to something like:
That seems reasonable if the @unableToAs... Greg Shah
07:23 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I've pushed a bunch of changes in @testcases@, we took out @tests@, @support@ from @PROPATH@ and added missing 'stand... Marian Edu
06:47 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: The @TestNamespaceUri.cls@ method @TestSetInvalid@ is outdated and needs to be corrected.
Below procedure result i... Maciej Zieniuk
10:23 AM Bug #7185: H2 in-memory lazy hydration: Rebased 7185a_h2 to trunk rev. 15. Not it is at rev. 20.
Committed 7185a_h2/rev. 21 including some extra optimizatio... Alexandru Lungu

04/20/2023

07:42 AM Bug #7258 (Review): Optimize INDEX-INFORMATION with closed dynamic queries: Committed fix to 7258a/rev. 14544. It is ready to merge.
I've run some regression tests and everything looks right.
... Alexandru Lungu
07:35 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses: Radu, can you please make a statistic in a dummy Java project for:
* 10,000 JDBC statements doing @select tt.* from ... Alexandru Lungu
07:14 AM Bug #7174 (Test): Resolve simple CAN-FIND statements faster: This was merged in trunk as rev. 14523 and can be closed. Alexandru Lungu
07:13 AM Bug #7165: Close multiplex scope using prepared statement: This was merged in trunk as rev. 14523 and can be closed. Alexandru Lungu
07:13 AM Bug #5306 (Test): AdaptiveQuery sets a found record into the buffer twice in dynamic mode: This was merged in trunk as rev. 14523 and can be closed. Alexandru Lungu
07:12 AM Feature #7060 (Test): Consider using wildcard selection to reduce SQL size: This was merged in trunk as rev. 14523 and can be closed. Alexandru Lungu
07:12 AM Feature #7062 (Test): Direct access to H2 internals to solve basic queries: This was merged in trunk as rev. 14523 and can be closed. Alexandru Lungu
04:56 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Constantin Asofiei wrote:
> ETF testing is OK with 7108a rev 14543 and fwd-h2-1.20-7108a.jar
Good.
Greg, Eric:... Alexandru Lungu
04:35 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> The @tests/dataset/TestXmlNodeType.cls@ have a line during the setup, which runs some other ... Marian Edu

04/19/2023

04:00 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database: Code review 6812a/14487:
Sorry for the delay in reviewing. A lot of changes have gone in to trunk in the meantime;... Eric Faulhaber
03:27 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Thanks Marian.
But I think i am doing something wrong.
The @tests/dataset/TestXmlNodeType.cls@ have a line during... Maciej Zieniuk
06:27 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Marian Edu wrote:
> That one was moved in a different location under support folder only forgot to push the changes ... Marian Edu
05:12 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> I have few tests passing, but there are few which will definitively not run.
> As an exampl... Marian Edu
12:49 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: ETF testing is OK with 7108a rev 14543 and fwd-h2-1.20-7108a.jar Constantin Asofiei
09:43 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: Alexandru Lungu wrote:
> Please address this review on *7138a_h2/rev.16* asap. Some of the points here are crucial f... Dănuț Filimon
07:09 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: Please address this review on *7138a_h2/rev.16* asap. Some of the points here are crucial for the performance tests t... Alexandru Lungu
06:41 AM Bug #7252 (WIP): Use direct-access to support for-each queries without WHERE and BY clauses: Alexandru Lungu
06:34 AM Feature #7066: Implement multi-table indexed query in H2: I've committed to 7066a. rev. 14528 the following things:
* @use_index@ is now used only in multi-table scenarios an... Radu Apetrii
05:22 AM Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select: I've attached a patch for the current issue.
When using the function *exists* and the first child is of type @SUBSEL... Dănuț Filimon

04/18/2023

04:43 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I have few tests passing, but there are few which will definitively not run.
As an example, the @tests/dataset/TestA... Maciej Zieniuk
10:06 AM Bug #7185: H2 in-memory lazy hydration: Committed 7185a_h2/rev. 19.
It includes optimization for @FWDDirectAccess.retrieveResponse@:
* If no record is ... Alexandru Lungu
08:29 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Constantin, can you run the ETF tests with 7108a?
> OK, I'... Alexandru Lungu
07:20 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Alexandru Lungu wrote:
> Constantin, can you run the ETF tests with 7108a?
OK, I'll do this. Is this for performa... Constantin Asofiei
06:51 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Constantin, can you run the ETF tests with 7108a?
I rebased 7108a with trunk rev. 14537.
I rebased 7108a_h2 with F... Alexandru Lungu
04:51 AM Bug #7035 (WIP): Extract query parameters from statically converted FQL: Eric Faulhaber wrote:
> Are we testing/profiling these changes only with H2, or with other database dialects as well... Alexandru Lungu

04/17/2023

10:43 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: At this time we have a limitation in our conversion approach, such that we must list the entire referenced object gra... Greg Shah
10:31 AM Feature #4514 (WIP): run ProDataSet test suite in FWD and resolve any issues such that it works t...: I have issues with conversion on @tests/dataset/@ and @dataset/@ - latest trunk on testcases and p2j repos.
The @fil... Maciej Zieniuk

04/14/2023

07:24 AM Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...: Marian: What work is needed to complete these tests? What is the status of the existing tests for table/table-handle... Greg Shah
07:21 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: The tests are in [[p2j:Testcases]] under the @tests/dataset/@ directory (for the ones already migrated to ABLUnit) an... Greg Shah

04/13/2023

11:54 AM Bug #7035: Extract query parameters from statically converted FQL: Are we testing/profiling these changes only with H2, or with other database dialects as well? I am concerned that wha... Eric Faulhaber
05:06 AM Bug #7035: Extract query parameters from statically converted FQL: Alexandru Lungu wrote:
> Danut, please constrain the changes to target only a specific sub-set of query parameters f... Dănuț Filimon
08:00 AM Feature #7066: Implement multi-table indexed query in H2: Alexandru Lungu wrote:
> * In @Select.queryFlat@, I think it is best to rename @nonReversedOrder@ to @reversedOrder@... Radu Apetrii
06:49 AM Bug #7185: H2 in-memory lazy hydration: Committed 7185a/rev. 14533:
* Optimized @TempRecord.fallback@ usage. Redone the profile and got to +0.25% performa... Alexandru Lungu

04/12/2023

11:01 AM Bug #7185 (WIP): H2 in-memory lazy hydration: My profiling session shown a +0.7% performance decrease. This is bad.
* My first concern here is the @extractCurre... Alexandru Lungu
06:30 AM Bug #7185: H2 in-memory lazy hydration: Alexandru Lungu wrote:
> Danut please review. I will start the profiling session asap. I would like to know the perf... Dănuț Filimon
05:56 AM Bug #7185 (Review): H2 in-memory lazy hydration: *Fixed regressions in 7185a_h2/rev. 18 and 7185a/rev. 14532*
* In H2, the cursors were not properly initialized to... Alexandru Lungu
10:33 AM Bug #7035: Extract query parameters from statically converted FQL: I am OK with the fix. However, my last profile session shown a +0.2% performance decrease with 7035a. I don't think i... Alexandru Lungu
10:23 AM Feature #7066: Implement multi-table indexed query in H2: Radu, please make an update on #7066. AFAIK, you are planning to integrate the #7194 changes into 7066a and deliver b... Alexandru Lungu

04/11/2023

01:36 PM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries: I have reviewed @fix_7258.patch@. I think it works exactly how was described in previous notes.
As an optimization... Ovidiu Maxiniuc
07:37 AM Bug #7258 (WIP): Optimize INDEX-INFORMATION with closed dynamic queries: Attached the fix. I used a flag to mark that the query was executed already. This flag is reset on query close. Pleas... Alexandru Lungu
10:13 AM Bug #7185: H2 in-memory lazy hydration: Alexandru Lungu wrote:
> Committed 7185a/rev. 14531: small fixes. Danut, please review.
> I am close to finding th... Dănuț Filimon
09:59 AM Bug #7185: H2 in-memory lazy hydration: Committed 7185a/rev. 14531: small fixes. Danut, please review.
I am close to finding the regression we are chasing f... Alexandru Lungu
09:55 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: I am OK with the current implementation. This should be tested and merged into trunk. Alexandru Lungu
08:10 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Alexandru Lungu wrote:
> In @FQLPreprocessor@, please keep the @simplifyCiProperties@ guard. Otherwise, we risk a fu... Dănuț Filimon
04:40 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: *Review to 7108a/rev.14528*
The changes are good. Last note to address before attempting to do a full test round a... Alexandru Lungu
07:56 AM Bug #7267: CompoundQuery FOR FIRST, EACH only retrieves the first record found: Constantin Asofiei wrote:
> Danut: the patch would be this, please test it, in CompoundQuery$Optimizer.isServerJoinP... Dănuț Filimon
07:43 AM Bug #7267: CompoundQuery FOR FIRST, EACH only retrieves the first record found: Danut: the patch would be this, please test it, in @CompoundQuery$Optimizer.isServerJoinPossible@ - the point is, a N... Constantin Asofiei
07:43 AM Bug #7267: CompoundQuery FOR FIRST, EACH only retrieves the first record found: Eric: this looks like the same #7229 problem. Constantin Asofiei
07:41 AM Bug #7267: CompoundQuery FOR FIRST, EACH only retrieves the first record found: There is a problem with CompoundQuery where using FOR FIRST, EACH will only return the first record available, ignori... Dănuț Filimon
07:30 AM Bug #7267 (Test): CompoundQuery FOR FIRST, EACH only retrieves the first record found: Dănuț Filimon
07:17 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: *Committed 7138a_h2/rev.16*. Made changes to should-circuit fake-updates. @TestCompatibility@ change is related to #7... Dănuț Filimon
07:17 AM Feature #6444: dataset improvements: Eric Faulhaber wrote:
> Code review 6444b/14528:
>
> Only the "old" @Persistence.scroll@ and @Persistence.list@ m... Igor Skornyakov
05:53 AM Feature #6444: dataset improvements: Code review 6444b/14528:
Only the "old" @Persistence.scroll@ and @Persistence.list@ methods with the @public@ acce... Eric Faulhaber

04/10/2023

08:31 AM Feature #6444 (Review): dataset improvements: Greg Shah wrote:
> The application Sergey is talking about has no datasets, no data relations. I would expect that ... Igor Skornyakov
07:09 AM Feature #6444: dataset improvements: Greg Shah wrote:
> The application Sergey is talking about has no datasets, no data relations. I would expect that ... Igor Skornyakov
07:05 AM Feature #6444: dataset improvements: The application Sergey is talking about has no datasets, no data relations. I would expect that usage of those APIs ... Greg Shah
07:03 AM Feature #6444: dataset improvements: From Igor:
> An additional DataRelation parameter is used only for the second pass of the FILL operation. In all o... Greg Shah
07:02 AM Feature #6444: dataset improvements: From Sergey, in regard to the merged changes from 6444a:
> It seems @<customer_application_with_hand_coded_persist... Greg Shah

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Database

Activity

Activity

05/10/2023

05/09/2023

05/08/2023

05/07/2023

05/06/2023

05/05/2023

05/04/2023

05/03/2023

05/02/2023

05/01/2023

04/29/2023

04/28/2023

04/27/2023

04/26/2023

04/25/2023

04/24/2023

04/22/2023

04/21/2023

04/20/2023

04/19/2023

04/18/2023

04/17/2023

04/14/2023

04/13/2023

04/12/2023

04/11/2023

04/10/2023