Activity
From 04/15/2023 to 05/14/2023
05/15/2023
- 09:02 PM Feature #7037: remove dirty share manager
- Please create a task branch and apply your changes. We are going to test this with various customer projects and wit...
05/12/2023
- 05:52 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> attaching the procedure i mentioned :)
This procedure (the assertion in the end of it) fa... - 05:10 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
- Eric Faulhaber wrote:
> Since trunk has moved ahead today, another rebase is needed.
Rebased, conflicts resolved,... - 01:49 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
- Code review 6812a/14567:
Looks good. I did a little format cleanup and committed to rev 14568. I did not update th... - 01:13 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
- Greg Shah wrote:
> I'll let Eric review this. In the future, please do not create a new branch instead of rebasing.... - 08:09 AM Bug #6812: fix FastFindCache to use a shared instance per persistent database
- I'll let Eric review this. In the future, please do not create a new branch instead of rebasing. That typically los...
- 11:16 AM Bug #7330: Increase psCache size
- Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Committed 7026d/rev. 14566 Set default to 8196. Configuratio... - 09:52 AM Bug #7330: Increase psCache size
- Greg Shah wrote:
> Why 8196 instead of 8192?
I don't have a proper excuse for that :) Fixed it now in 7026d/rev. ... - 09:41 AM Bug #7330: Increase psCache size
- Why 8196 instead of 8192?
- 09:33 AM Bug #7330: Increase psCache size
- Alexandru Lungu wrote:
> Committed 7026d/rev. 14566 Set default to 8196. Configuration option: @persistence/ps-cache... - 09:33 AM Bug #7330 (Review): Increase psCache size
- Committed 7026d/rev. 14566 Set default to 8196. Configuration option: @persistence/ps-cache-size@ as integer.
- 09:02 AM Bug #7330: Increase psCache size
- Please default to 8192. If memory is an issue, customers can reduce it and take the performance hit. I prefer faste...
- 09:00 AM Bug #7330: Increase psCache size
- Alexandru Lungu wrote:
> Constantin, I am ready to commit the "ps-cache-size" option support. Shall I set a default ... - 08:58 AM Bug #7330: Increase psCache size
- Constantin, I am ready to commit the "ps-cache-size" option support. Shall I set a default of 2048 (as it was now) an...
- 08:21 AM Bug #7330: Increase psCache size
- Alexandru Lungu wrote:
> As a conclusion here, I think it is optimal to either extend the cache to 4096 (and expire ... - 06:10 AM Bug #7330: Increase psCache size
- As a conclusion here, I think it is optimal to either extend the cache to 4096 (and expire 400 entries and lose some ...
- 06:02 AM Bug #7330: Increase psCache size
- Retested with a @psCache@ of capacity 65535.
I get a @psCache@ size with only @4470@ statements, so according to #... - 04:57 AM Bug #7330: Increase psCache size
- I've got a memory dump to check the status on the @psCache@ on a large customer application.
Before doing a client r... - 09:28 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors
- *Review of 7026d 14563-14564:*
* Extent can be @null@! Don't use @null@ as a marker to check if it was computed or... - 08:37 AM Bug #7336: optimize DmoMeta.byLegacyName
- Committed the switch to @CaseInsensitiveHashMap@ in @DmoMeta.byLegacyName@ with 7026d/rev. 14565.
- 06:51 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- I've removed the @System.out.println("Deprecated API: @ calls in 6813b rev 14569.
Greg: this can be merged to trunk. - 06:32 AM Bug #6887: improve performance of dataset/table[-handle] parameters
- Boris, did you run the tests in OpenEdge and in FWD? What is the difference in time?
In FWD, what does a trace pro... - 04:45 AM Bug #7334: Reclaim used sessions to improve performance
- *Committed 7334a/rev.14567.* Added the initial implementation for reclaimable sessions.
Alexandru Lungu wrote:
> ... - 03:44 AM Bug #7334: Reclaim used sessions to improve performance
- I will test/profile this as it is now. However, I am further on interested in:
* a multi-user environment test. Do y... - 03:38 AM Bug #7321: Improve FWD-H2 wildcard projection
- *Committed 7321a_h2/rev.19.* Removed @TableFilter.getCurrentRow()@, used @TableFilter.get()@ instead.
Instead of u...
05/11/2023
- 07:05 PM Bug #6812 (Review): fix FastFindCache to use a shared instance per persistent database
- I pushed the requested changes as revision 6812b/14567. This is a new branch based on current @trunk@, I'll drop @681...
- 06:12 PM Bug #6887: improve performance of dataset/table[-handle] parameters
- Eric Faulhaber wrote:
> Boris, did you take a final pass at this?
I just did and I don't see any difference from ... - 06:06 PM Bug #6887: improve performance of dataset/table[-handle] parameters
- Constantin Asofiei wrote:
> We should profile and check how #6887-3 test behaves now with FWD first.
Boris, did y... - 05:51 PM Bug #6887: improve performance of dataset/table[-handle] parameters
- I think we should close this task. I just didn't find a more appropriate status :)
- 05:48 PM Bug #6887: improve performance of dataset/table[-handle] parameters
- Boris, what is there to review?
- 05:29 PM Bug #6887 (Review): improve performance of dataset/table[-handle] parameters
- 05:27 PM Bug #6458 (WIP): ensure that OO expressions resolve to query substitution parameters, like handle...
- 10:38 AM Bug #7321: Improve FWD-H2 wildcard projection
- *Review of 7321a_h2/rev.18*
* I am not sure if you actually need @currentSearchRow@ or @current@. Anyway, your @T... - 10:18 AM Bug #7336 (Review): optimize DmoMeta.byLegacyName
- h2. Right trimming
I found it accessible to add rtrim in some structures:
* For @CaseInsensitiveMap@ I stop compu... - 10:16 AM Bug #7334: Reclaim used sessions to improve performance
- I created a @SessionFactory@ which allows a @Session@ to be reclaimed. I did a round of testing which mimic the speci...
- 09:20 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses
- Ok, I guess we can go ahead with integrating it without the @fullIndexName@ (for now). However, I am concerned of the...
- 02:49 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Ovidiu, I understand your reasoning about the deprecated @String@ APIs, but please remove @System.out.println("Deprec...
05/10/2023
- 04:35 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Review of 6813b/14567.
* @SymbolResolver.java@, @matchTargetMethod()@ method. There is another case of ambiguity whe... - 02:38 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- 6813b rev 14567 fixes another typo.
I've reviewed rules/ changes (95% automatically, 5% manually). Considering th... - 12:59 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- 6813b rev 14566 fixes what I think is a debug added in @common-progress.rules:oo_call_type@ function, there was a @pr...
- 07:12 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- 6813b rev 14565 fixes history numbers, some javadocs and also adds the CommonAstSupport versions of upPath/downPath/r...
- 02:30 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- 6813a was dead-archived. 6813b was created from trunk rev 14563.
I've fixed the conflicts and all changes are in ... - 10:50 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Constantin Asofiei wrote:
> Ovidiu, what is the state of the 6813a branch? I'd like to complete this.
6813a was b... - 09:21 AM Bug #7336: optimize DmoMeta.byLegacyName
- Done multiple runs of a customer POC. I got:
*Original*: 50ms spent on map look-up, 200ms spent on lowering, right... - 05:27 AM Bug #7336 (WIP): optimize DmoMeta.byLegacyName
- The effort for this task is related to the @DmoMeta.byLegacyName@ hotspot, caused by lots of calls to @TextOps.rightT...
- 09:21 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors
- Radu Apetrii wrote:
> > I haven't tested yet with a large customer application, but I will get this done.
> I have ... - 08:15 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors
- Radu Apetrii wrote:
> I haven't tested yet with a large customer application, but I will get this done.
I have iden... - 05:42 AM Bug #5452 (Review): eliminate use of ResultSet.CONCUR_UPDATABLE?
- Removed readOnly flag and fixed persistence.list() and getQuery() new signatures, checked with a large project and it...
- 02:59 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Ovidiu Maxiniuc wrote:
> Thank you. Seems logical. I was not remembering correctly :(.
> I was thinking of some o...
05/09/2023
- 06:46 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Marian Edu wrote:
> Ovidiu Maxiniuc wrote:
> > IIRC, this is how 4GL works. Probably there are two values in the so... - 10:19 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- attaching the procedure i mentioned :)
- 10:16 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Vladimir Tsichevski wrote:
> Ovidiu Maxiniuc wrote:
> > Vladimir Tsichevski wrote:
> > > Maciej Zieniuk wrote:
> ... - 09:02 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Ovidiu Maxiniuc wrote:
> IIRC, this is how 4GL works. Probably there are two values in the source which would brea... - 07:32 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
Ovidiu Maxiniuc wrote:
> Maciej Zieniuk wrote:
> > I don't think it's a coincidence that just after this test...- 07:25 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Vladimir Tsichevski wrote:
> There is something wrong with error propagation in FWD when a persistent procedure is c... - 02:47 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- I've used this to validate the tokens used in @upPath@, @relativePath@, @downPath@ and @absolutePath@ (btw, this is n...
- 02:31 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- I think the change is OK. I had to read it a few times, but your comments helped.
- 11:19 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- As an addendum: the point of this change is to have method definition for i.e. @upPath@ with 1, 2, 3 and 4 arguments....
- 11:17 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- I'm counting the arguments for the @relativePath@, @upPath@ and @downPath@ from @rules/@; the result is this:...
- 11:15 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
- What is the list of remaining issues to be addressed here? We have multiple customers starting to deploy and requiri...
- 10:18 AM Bug #7336 (Closed): optimize DmoMeta.byLegacyName
- 06:35 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors
- I've applied the suggested comments. The changes are on 7026d, rev. 14563.
I haven't tested yet with a large custome... - 04:28 AM Bug #7329 (WIP): improve FieldReference resolution of getter/setter/extent accessors
- Radu, please fix this in 7026d.
- 04:01 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors
- Constantin Asofiei wrote:
> * index
Here I meant 'getExtent'
- 06:32 AM Bug #7330: Increase psCache size
- Constantin Asofiei wrote:
> And something else thing to consider: any PreparedStatement instance is linked to a JDBC... - 06:31 AM Bug #7330: Increase psCache size
- Alexandru, for example, in an application, I saw ~8k JDBC prepared statements being created. If the actual used cach...
- 04:45 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses
- Alexandru Lungu wrote:
> Radu Apetrii wrote:
> > Also, I've left two TODOs which will be taken care of as soon as t... - 04:01 AM Feature #7194: Avoid generating an ORDER-BY clause if not required
- I have modified @RandomAccessQuery@ so that an ORDER BY clause will not be added to the FQL if a unique finding is en...
- 03:53 AM Bug #7334: Reclaim used sessions to improve performance
- Alexandru Lungu wrote:
> Basically, allow each session to be reclaimed, but only within a limited time threshold.
... - 02:56 AM Bug #7321: Improve FWD-H2 wildcard projection
- *Committed 7321a_h2/rev.18.* Improved wildcard projection by doing a fast copy of the current search row.
This imp...
05/08/2023
- 05:59 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- There is something wrong with error propagation in FWD when a persistent procedure is concerned.
The procedure @pe... - 04:16 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> I don't fully understan this test @tests.dataset.TestFillMode@ method @withPkCorrectBufferAs... - 04:11 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> Another commit i have added to @4514a@ p2j branch. That fixes the @TestFill@ test.
> [...]
... - 03:59 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> I don't think it's a coincidence that just after this test and exception, other tests are un... - 03:42 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Ovidiu Maxiniuc wrote:
> Vladimir Tsichevski wrote:
> > Maciej Zieniuk wrote:
> > > I found this exception from th... - 03:33 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Vladimir Tsichevski wrote:
> Another conversion issue: @dataset.TestAcceptChanges@ legacy class converts to:
> [...... - 02:16 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Vladimir Tsichevski wrote:
> Maciej Zieniuk wrote:
> > I found this exception from the server's logs, that happens ... - 09:41 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I don't fully understan this test @tests.dataset.TestFillMode@ method @withPkCorrectBufferAsign@, specifically this p...
- 03:30 PM Feature #7323: Implement soft unique index in FWD-H2
- Alexandru Lungu wrote:
> *Eric, Constantin, Ovidiu*: is the lack of H2 unique indexes for temporary tables out of ... - 02:59 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Ovidiu, what is the state of the 6813a branch? I'd like to complete this.
- 09:44 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- The example is good, I understand what you mean: the problem are not the literals, but the fact that different buffer...
- 02:30 PM Bug #4071: FWD server stops allowing new web client logins after abend
- I think the testcase in #7193-62 is another example of this same issue. Context cleanup should never run on the read...
- 10:25 AM Bug #7334 (WIP): Reclaim used sessions to improve performance
- This task is meant to solve #7167, #6820, and #4021 at once.
Please refer to #7167 for the initial problem. Here w... - 10:12 AM Bug #7334 (Closed): Reclaim used sessions to improve performance
- 10:08 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses
- Radu Apetrii wrote:
> Also, I've left two TODOs which will be taken care of as soon as the changes from #7066 will b... - 06:31 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses
- I've committed to 7252a, rev.14562 and 7252a_h2, rev.18 a few changes that allow the use of direct-accessing when ret...
- 06:05 AM Bug #7330: Increase psCache size
- Consider extending the @psCache@ size from 2048 to 65535. This was attempted before in #6829, but the memory consumpt...
- 05:05 AM Bug #7330 (Closed): Increase psCache size
- 04:51 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- *Committed 7138a_h2/rev.22.* Allowed @ValueNull@ values to be compared.
- 04:32 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Dănuț Filimon wrote:
> After looking at the code, I remember that I excluded @Value.NULL@ because I was using @compa... - 04:31 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- I retested the application and counted updates that use null, from a total of *1352885* I obtained the following:
|_... - 04:25 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors
- Refactor FieldReference to lazily initialize the fields which are now in the constructor; this includes:
* getter
*... - 04:22 AM Bug #7329 (Closed): improve FieldReference resolution of getter/setter/extent accessors
- 03:22 AM Bug #5452 (WIP): eliminate use of ResultSet.CONCUR_UPDATABLE?
- I am OK with the current changes.
However, you still need to extend your removal of @readOnly@. More exactly, ther...
05/07/2023
- 08:08 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Another commit i have added to @4514a@ p2j branch. That fixes the @TestFill@ test....
- 06:00 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I can create it. So essentially, we take out the content of the @passWrongDefinition@ test as a standalone procedure ...
05/06/2023
- 01:40 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> I did run @TestOutputDynamicDsInDynamicProc@ against 4GL 11.6 and it was green (all test met... - 01:34 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Also just pushed a commit to @4514a@ p2j branch that fixes the @TestDataSourceModified@ test - error 4083 as warning:...
- 01:28 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I did run @TestOutputDynamicDsInDynamicProc@ against 4GL 11.6 and it was green (all test methods passing)
- 01:25 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> I don't think it's a coincidence that just after this test and exception, other tests are un... - 12:58 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I don't think it's a coincidence that just after this test and exception, other tests are unable to run correctly.
... - 12:17 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Vladimir Tsichevski wrote:
> Maciej Zieniuk wrote:
> > I found this exception from the server's logs, that happens ... - 12:15 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> I found this exception from the server's logs, that happens inside the @passWrongDefinition@... - 10:30 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I found this exception from the server's logs, that happens inside the @passWrongDefinition@. I am guessing they are ...
- 04:42 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Vladimir, the @setUpBeforeClass@ runs fine on it's own. But let the @passWrongDefinition@ test run and then any other...
05/05/2023
- 04:38 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> There is one more issue which i tried to debug. The @tests.dataset.parameter.output.TestOu... - 08:50 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Another conversion issue: @dataset.TestAcceptChanges@ legacy class converts to:...
- 07:33 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Did pushed a new revision on testcases #1405 that includes some changes in the dataset tests, mainly clean-up after e...
- 07:26 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Greg Shah wrote:
> We might as well fix it here, now.
>
> It is weird syntax.
It just looks like that, however @... - 10:19 AM Feature #7323: Implement soft unique index in FWD-H2
- Alexandru Lungu wrote:
> prior simple SELECT is faster than a SAVEPOINT to avoid partial inserts in case of constrai... - 10:11 AM Feature #7323: Implement soft unique index in FWD-H2
- I just realized that direct-access is not necessarily an option because these validation statements are prepared only...
- 09:47 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Tested with a large customer application and I get similar results: between -0.1% and +0.1%. I will retest on a newer...
- 05:30 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Alexandru Lungu wrote:
> * you can do a quick reconversion of Hotel GUI and use H2 persistent database just to check... - 09:31 AM Bug #5452 (Review): eliminate use of ResultSet.CONCUR_UPDATABLE?
- Removed readOnly flag from SQLQuery, checked with HotelGUI and everything works fine.
Commited to 5452a revision 14561. - 06:39 AM Bug #5452 (WIP): eliminate use of ResultSet.CONCUR_UPDATABLE?
- 05:50 AM Bug #5452: eliminate use of ResultSet.CONCUR_UPDATABLE?
- Created 5452a from trunk/rev. 14560.
- 05:43 AM Bug #7321: Improve FWD-H2 wildcard projection
- On a large customer application, I checked how much time this scenario (wildcard expansion and search row projection)...
- 05:41 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- Boris, first, run conversion with @-Drules.tracing=true@. Use this for both the OO and non-OO tests.
You can look... - 05:37 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- Gentlemen, I couldn't figure out details of the conversion procedure. So, anyone who has time and knowledge is more t...
- 05:32 AM Feature #7320: Extend H2 tester from Hotel GUI
- Some of our recent work on FWD-H2 performance can be captured with tests like the following. Please make sure you inc...
05/04/2023
- 06:11 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- We might as well fix it here, now.
It is weird syntax. Normally you would call @valid-handle(dsMasterDynamic)@ to... - 05:41 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> In my testcases branch i changed this code to assign the handle to some other handle, as it ... - 05:25 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- In my testcases branch i changed this code to assign the handle to some other handle, as it did not compile for me.
... - 05:16 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have an issue compiling the @TestHandle.cls@ test: statements like...
- 09:30 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> I identified the issue, thhat the @run support/dataset/create/dsMaster.p@ does not propagate... - 03:53 PM Bug #6812 (WIP): fix FastFindCache to use a shared instance per persistent database
- 06:05 AM Bug #7319: Fix adaptive query test suite from testcases
- Alexandru Lungu wrote:
> Are these the issues for the persistent database?
Yes, I forgot to mention. These issues ... - 05:59 AM Bug #7319: Fix adaptive query test suite from testcases
- Are these the issues for the persistent database? Are they the same as for temporary database?
- 05:52 AM Bug #7319: Fix adaptive query test suite from testcases
- It is done. Inside @adaptive_scrolling/persistent-adaptive_tests@ there are 2 folders (one for no-scrolling tests and...
- 04:08 AM Bug #7319: Fix adaptive query test suite from testcases
- Radu Apetrii wrote:
> Alexandru Lungu wrote:
> > AFAIK, Radu, you already have such work already done. Please commi... - 04:02 AM Bug #7319: Fix adaptive query test suite from testcases
- Alexandru Lungu wrote:
> AFAIK, Radu, you already have such work already done. Please commit to testcases the adapti... - 04:15 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- *Committed 7138a_h2/rev.21*. Fixed a concurrency problem. @inMemUpdate@ and @notInMemUpdate@ need to be set to *null*...
- 03:24 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- From the testing POV, we already covered several large applications for in-memory H2.
Danut:
* you can do a quick r...
05/03/2023
- 04:30 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Greg Shah wrote:
> > I identified the issue, thhat the @run support/dataset/create/dsMaster.p@ does not propagate th... - 03:01 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > I identified the issue, thhat the @run support/dataset/create/dsMaster.p@ does not propagate the assigned handle @o...
- 02:48 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- This test which had error propagation issues is working with the 3827b branch :)
I will rebase my changes on top o... - 11:44 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Vladimir has some error propagation changes in task branch 3827b. Can you try those to see if the issue is resolved?
- 02:33 PM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Dănuț Filimon wrote:
> Should I do similar tests for persistent tables?
As a lower priority, yes, just to make ... - 11:30 AM Feature #7323: Implement soft unique index in FWD-H2
- I've done some logging with FWD-H2 on a large customer application and identified the following for a POC run. Out of...
- 10:48 AM Feature #7323 (Closed): Implement soft unique index in FWD-H2
- 09:51 AM Feature #6630: optimize return of table parameter
- I recreated a similar scenario where @TemporaryBuffer.loopDelete@ is called using a class field that has a destructor...
05/02/2023
- 04:28 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I just pushed a potential fix to 4514a p2j branch, for the @tests.dataset.parameter.input.TestInputDynamicDsInDynamic...
- 03:00 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Attached @file-cvt-list.txt@
- 01:26 PM Bug #7113: Problem with nested CAN-FIND conversion
- > Sorry, but I do not understand. The conversion w/o my patch was incorrect and, AFAIR, you agreed with this. The fac...
- 10:03 AM Bug #7321 (WIP): Improve FWD-H2 wildcard projection
- 09:56 AM Bug #7321: Improve FWD-H2 wildcard projection
- Recently, queries over the temporary database use the wildcard syntax: @tt.*@ to select all the columns. If there are...
- 09:28 AM Bug #7321 (Closed): Improve FWD-H2 wildcard projection
- 09:27 AM Feature #7320: Extend H2 tester from Hotel GUI
- This task is related to the H2 tester from Hotel GUI, used to track performance of FWD-H2 in certain scenarios. We sh...
- 08:50 AM Feature #7320 (WIP): Extend H2 tester from Hotel GUI
- 07:35 AM Bug #7319: Fix adaptive query test suite from testcases
- The @testcases/adaptive-scrolling@ test-suite is a reference point for our implementation of @AdaptiveQuery@. It incl...
- 07:21 AM Bug #7319 (New): Fix adaptive query test suite from testcases
- 07:26 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- I've tested fake-update performance for larger tables and extent fields, results of each test are measured in millise...
- 07:21 AM Bug #7267 (Test): CompoundQuery FOR FIRST, EACH only retrieves the first record found
- This can be closed/rejected.
- 07:20 AM Bug #7267 (Review): CompoundQuery FOR FIRST, EACH only retrieves the first record found
- 07:20 AM Bug #7267 (WIP): CompoundQuery FOR FIRST, EACH only retrieves the first record found
- 07:16 AM Bug #7235 (Test): Avoid selecting all fields for an CAN-FIND sub-select
- Merged 7026c to trunk as rev. 14553.
- 04:15 AM Feature #7066: Implement multi-table indexed query in H2
- While doing some work on #7252, I noticed that there might be some (other) stuff that is unnecessary computed when an...
- 04:02 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses
- After doing some testing, I managed to form the following table:
|_. Scenario |_. Normal statements |_. Direct-a...
05/01/2023
- 03:43 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej, can you provide me and other with the @file-cvt-list.txt@ you use to convert tests for this issue, please. Th...
04/29/2023
- 04:02 AM Bug #7113: Problem with nested CAN-FIND conversion
- Ovidiu Maxiniuc wrote:
> Igor,
> I have fixed the extra closing parenthesis as part of another task. Please do not... - 08:34 PM Bug #7113: Problem with nested CAN-FIND conversion
- Igor,
I have fixed the extra closing parenthesis as part of another task. Please do not put additional effort in th... - 03:38 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> The expectation is that the @for each ttOrderCustomer:@ will fail with @Progress.Lang.Error@... - 09:56 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> The expectation is that the @for each ttOrderCustomer:@ will fail with @Progress.Lang.Error@...
04/28/2023
- 04:15 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I am not sure what to do with the @tests.dataset.parameter.input.TestDatasetBind@ class test @referenceOnlyNotValid@....
- 09:09 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Correct. ...
- 09:00 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Greg Shah wrote:
> > Aka, this doesn't convert because of the use of @no-error@:
>
> What is the error? Is it du... - 08:04 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > Aka, this doesn't convert because of the use of @no-error@:
What is the error? Is it during parsing or during l... - 04:18 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Pushed a few changes, the conversion issue with @create dataset/data-source@ was due to the fact that @no-error@ opti...
- 04:06 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> You are right. I initially though this is about @dsInit@ being unknown, not initialized, b... - 02:27 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > This sounds good to me, but then why the handle is invalid? I would check the converted code, from what we've seen ...
- 01:49 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> - @tests.dataset.parameter.inout.TestInputOutputDynamicDsInDynamicProc@ method @passDatase... - 04:12 AM Feature #7194: Avoid generating an ORDER-BY clause if not required
- Alexandru Lungu wrote:
> ** What if the uniquely found record is changed? The query should invalidate (or not?) and ...
04/27/2023
- 09:30 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej: Please do fix all of these conversion issues. I don't want to leave behind any latent problems.
So we nee... - 09:19 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> Marian, i don't think the @support/test/HandleFactory.cls@ is converting in newest testcases... - 07:49 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Marian, i don't think the @support/test/HandleFactory.cls@ is converting in newest testcases revision, because of the...
- 05:32 AM Feature #7076: make CAN-FIND avoid hydration
- I've tested both temporary and persistent tables with CAN-FIND and nested CAN-FIND. CAN-FIND no longer hydrates with ...
- 03:50 AM Feature #6630: optimize return of table parameter
- Danut, I recall I changed the @AdaptiveQuery@ from @TemporaryBuffer.loopDelete@ into a @PreselectQuery@. Basically, t...
- 03:00 AM Bug #7235 (Review): Avoid selecting all fields for an CAN-FIND sub-select
- Added this patch to 7026c.
Tested this. I got a -0.24% performance improvement with a 7026c profile run.
Just rebas...
04/26/2023
- 05:04 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Thanks Marian, that helped.
Few findings:
- @tests.dataset.parameter.inout.TestInputOutputDynamicDsInDynamicProc@... - 02:09 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> Oh i almost forgot, i have this weird issue, that i cannot run @ant dist@ on the testcases r... - 10:21 AM Feature #7194 (WIP): Avoid generating an ORDER-BY clause if not required
- I will move this back to 50% to allow the handling of other ORDER BY clauses (from RandomAccessQuery especially).
- 10:18 AM Feature #7194 (Review): Avoid generating an ORDER-BY clause if not required
- Tested this. I got a -0.24% performance improvement with a 7026c profile run.
Just rebased 7026c with trunk.
Fu... - 10:06 AM Feature #7076 (WIP): make CAN-FIND avoid hydration
- Danut, please investigate this.
I am not sure if CAN-FIND still hydrates in the latest versions of FWD-H2 trunk (>1... - 09:16 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- I've tested #6928-3 and also made my own set of performance tests (results are measured in milliseconds). The results...
- 05:57 AM Bug #7138 (Review): Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Fixed a regression in 7138a_h2 regarding updating indexed computed columns in inMemUpdate mode. If you have (f1, __if...
- 08:05 AM Bug #7185: H2 in-memory lazy hydration
- Merged 7185a_h2 into FWD-H2 trunk as rev. 17.
This doesn't require any FWD changes; it just optimizes the direct-ac... - 04:35 AM Bug #7185: H2 in-memory lazy hydration
- Review 7185a_h2. The changes are good to go, you can proceed with the merge.
04/25/2023
- 06:36 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Oh i almost forgot, i have this weird issue, that i cannot run @ant dist@ on the testcases repo, because it fails wit...
- 06:26 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I wanted to make sure that the dataset testcases actually works fine in 4GL ABLUnit.
With 4GL 11.6 version i was abl... - 12:34 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> > Running all tests in a suite seems to make some of those tests to fail even if ran individ... - 10:45 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > Running all tests in a suite seems to make some of those tests to fail even if ran individually they pass... curren...
- 07:41 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> Yes by "push" i meant bound branch to a remote repo with bzr commit.
> I will have to reba... - 02:51 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Yes by "push" i meant bound branch to a remote repo with bzr commit.
I will have to rebase too once in a while, to ... - 10:34 AM Feature #7194: Avoid generating an ORDER-BY clause if not required
- My initial thought when I created #7194 was to optimize UNIQUE FIND/CAN-FIND for persistent databases. For temp datab...
- 10:20 AM Bug #7185: H2 in-memory lazy hydration
- I updated #7185-30 with the times regarding the FWD changes (lazy hydration). While the FWD-H2 changes provides a con...
- 09:44 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- I tested Hotel_GUI and found no problems, but I found a regression in a customer application which I didn't manage to...
- 05:51 AM Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select
- Alexandru Lungu wrote:
> ... Please check that the SELECT keyword is placed correctly (as a left sibling of the num ... - 05:47 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Branch 7108a_h2 has been merged to FWD-H2 trunk at revision 16.
- 05:47 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Branch 7108a has been merged to trunk at revision 14550
- 05:11 AM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries
- Branch 7258a has been merged to trunk at revision 14549.
04/24/2023
- 05:30 PM Feature #6371: implement SAVE CACHE statement
- Code review 6371d/14544:
One *very minor* change: please fix the open curly brace at @SchemaComparator.java@:149 t... - 06:50 AM Feature #6371: implement SAVE CACHE statement
- I was asked to test this statement. I will not be able to have a look at this soon, probably not even before summer v...
- 01:42 PM Bug #7258 (Test): Optimize INDEX-INFORMATION with closed dynamic queries
- @7258a.patch@ looks fine. The code in @DynamicQueryHelper@ looks much cleaner now. Good job!
- 04:25 AM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries
- Ovidiu, I am planning to merge 7258a today. Move this to Test after you check #7158-7: these are the same changes as ...
- 09:00 AM Bug #7035: Extract query parameters from statically converted FQL
- I created the temporary *JMX* and added counters for meta, temp, dirty and persistent database hits/misses. The count...
- 06:46 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- *Review to 7138a_h2/rev.17* : I am OK with the changes.
Danut, please re-test 7138a_h2 (own test-cases, large cust... - 05:47 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > I have pushed that change to @~/secure/code/p2j_repo/p2j/active/4514a@. If i find anything i will push more to the ...
- 05:34 AM Feature #7194: Avoid generating an ORDER-BY clause if not required
- Radu, let the intended changes for #7194 reside in 7026c. I am thinking of merging 7026c independently from 7066a, as...
- 05:30 AM Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select
- *Review of #7235 patch in #7235-3.*
* When you append the NUM_LITERAL, you also append SELECT (which is OK). You u...
04/22/2023
- 02:18 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have pushed that change to @~/secure/code/p2j_repo/p2j/active/4514a@. If i find anything i will push more to the br...
04/21/2023
- 04:28 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Greg Shah wrote:
> > I am thinking about making a change to the FWD code, to something like:
> That seems reasonabl... - 08:00 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Greg Shah wrote:
> > I am thinking about making a change to the FWD code, to something like:
>
> That seems reaso... - 07:55 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > I am thinking about making a change to the FWD code, to something like:
That seems reasonable if the @unableToAs... - 07:23 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I've pushed a bunch of changes in @testcases@, we took out @tests@, @support@ from @PROPATH@ and added missing 'stand...
- 06:47 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- The @TestNamespaceUri.cls@ method @TestSetInvalid@ is outdated and needs to be corrected.
Below procedure result i... - 10:23 AM Bug #7185: H2 in-memory lazy hydration
- Rebased 7185a_h2 to trunk rev. 15. Not it is at rev. 20.
Committed 7185a_h2/rev. 21 including some extra optimizatio...
04/20/2023
- 07:42 AM Bug #7258 (Review): Optimize INDEX-INFORMATION with closed dynamic queries
- Committed fix to 7258a/rev. 14544. It is ready to merge.
I've run some regression tests and everything looks right.
... - 07:35 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses
- Radu, can you please make a statistic in a dummy Java project for:
* 10,000 JDBC statements doing @select tt.* from ... - 07:14 AM Bug #7174 (Test): Resolve simple CAN-FIND statements faster
- This was merged in trunk as rev. 14523 and can be closed.
- 07:13 AM Bug #7165: Close multiplex scope using prepared statement
- This was merged in trunk as rev. 14523 and can be closed.
- 07:13 AM Bug #5306 (Test): AdaptiveQuery sets a found record into the buffer twice in dynamic mode
- This was merged in trunk as rev. 14523 and can be closed.
- 07:12 AM Feature #7060 (Test): Consider using wildcard selection to reduce SQL size
- This was merged in trunk as rev. 14523 and can be closed.
- 07:12 AM Feature #7062 (Test): Direct access to H2 internals to solve basic queries
- This was merged in trunk as rev. 14523 and can be closed.
- 04:56 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Constantin Asofiei wrote:
> ETF testing is OK with 7108a rev 14543 and fwd-h2-1.20-7108a.jar
Good.
Greg, Eric:... - 04:35 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> The @tests/dataset/TestXmlNodeType.cls@ have a line during the setup, which runs some other ...
04/19/2023
- 04:00 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
- Code review 6812a/14487:
Sorry for the delay in reviewing. A lot of changes have gone in to trunk in the meantime;... - 03:27 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Thanks Marian.
But I think i am doing something wrong.
The @tests/dataset/TestXmlNodeType.cls@ have a line during... - 06:27 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Marian Edu wrote:
> That one was moved in a different location under support folder only forgot to push the changes ... - 05:12 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> I have few tests passing, but there are few which will definitively not run.
> As an exampl... - 12:49 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- ETF testing is OK with 7108a rev 14543 and fwd-h2-1.20-7108a.jar
- 09:43 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Alexandru Lungu wrote:
> Please address this review on *7138a_h2/rev.16* asap. Some of the points here are crucial f... - 07:09 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Please address this review on *7138a_h2/rev.16* asap. Some of the points here are crucial for the performance tests t...
- 06:41 AM Bug #7252 (WIP): Use direct-access to support for-each queries without WHERE and BY clauses
- 06:34 AM Feature #7066: Implement multi-table indexed query in H2
- I've committed to 7066a. rev. 14528 the following things:
* @use_index@ is now used only in multi-table scenarios an... - 05:22 AM Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select
- I've attached a patch for the current issue.
When using the function *exists* and the first child is of type @SUBSEL...
04/18/2023
- 04:43 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have few tests passing, but there are few which will definitively not run.
As an example, the @tests/dataset/TestA... - 10:06 AM Bug #7185: H2 in-memory lazy hydration
- Committed 7185a_h2/rev. 19.
It includes optimization for @FWDDirectAccess.retrieveResponse@:
* If no record is ... - 08:29 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Constantin, can you run the ETF tests with 7108a?
> OK, I'... - 07:20 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Alexandru Lungu wrote:
> Constantin, can you run the ETF tests with 7108a?
OK, I'll do this. Is this for performa... - 06:51 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Constantin, can you run the ETF tests with 7108a?
I rebased 7108a with trunk rev. 14537.
I rebased 7108a_h2 with F... - 04:51 AM Bug #7035 (WIP): Extract query parameters from statically converted FQL
- Eric Faulhaber wrote:
> Are we testing/profiling these changes only with H2, or with other database dialects as well...
04/17/2023
- 10:43 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- At this time we have a limitation in our conversion approach, such that we must list the entire referenced object gra...
- 10:31 AM Feature #4514 (WIP): run ProDataSet test suite in FWD and resolve any issues such that it works t...
- I have issues with conversion on @tests/dataset/@ and @dataset/@ - latest trunk on testcases and p2j repos.
The @fil...
Also available in: Atom