Activity

From 04/23/2023 to 05/22/2023

05/22/2023

06:29 PM Feature #7037: remove dirty share manager: Roger Borrello wrote:
> Stanislav Lomany wrote:
> > Dirty sharing has been disabled in the directory for Hotel GUI ... Eric Faulhaber
06:09 PM Feature #7037: remove dirty share manager: Code review 7037b, revs 14573-14574:
Everything looks good, but I have some questions, to make sure I understand s... Eric Faulhaber
05:49 PM Feature #7037: remove dirty share manager: Stanislav Lomany wrote:
> Dirty sharing has been disabled in the directory for Hotel GUI (rev 264) and Hotel ChUI (r... Roger Borrello
03:38 PM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...: It is parsed because it is referenced elsewhere. As I've noted previously via email, just because it is parsed doesn... Greg Shah
03:15 PM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...: Constantin Asofiei wrote:
> You must include @Foo.cls@ in your conversion list.
But it's already reported as bein... Boris Schegolev
03:10 PM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...: You must include @Foo.cls@ in your conversion list. Constantin Asofiei
03:08 PM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...: I am running a simple conversion for OO mode. The class itself is simple:... Boris Schegolev
10:14 AM Bug #7367: disable TriggerTracker for TemporaryBuffer: Alexandru Lungu wrote:
> Hmm, I edited my comment to use @== null@ seconds after posting :)
That make sense. I rev... Ovidiu Maxiniuc
09:47 AM Bug #7367: disable TriggerTracker for TemporaryBuffer: Ovidiu Maxiniuc wrote:
> Sorry, you are right, I did not see you changed the @!=@ into @==@, not only @&&@ into @||@... Alexandru Lungu
09:45 AM Bug #7367: disable TriggerTracker for TemporaryBuffer: Ovidiu Maxiniuc wrote:
> Alex,
> I do not think that is the good condition. If @targetBuffer.getTriggerTracker()@ ... Ovidiu Maxiniuc
09:43 AM Bug #7367: disable TriggerTracker for TemporaryBuffer: Alex,
I do not think that is the good condition. If @targetBuffer.getTriggerTracker()@ is null then the second oper... Ovidiu Maxiniuc
09:27 AM Bug #7367: disable TriggerTracker for TemporaryBuffer: In @setCurrentRecord@, there is the following condition (line 11422):... Alexandru Lungu
05:01 AM Bug #7367: disable TriggerTracker for TemporaryBuffer: I recall seeing @ASSIGN@ trigger checks for when we were executing copy-temp-table (fast or not). I don't know if the... Alexandru Lungu
09:03 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors: *Review of 7026d, rev. 14570*
The changes are functionally good. I have only some minor suggestions
* In @set@, c... Alexandru Lungu
07:19 AM Bug #7371: proper handling of exception case in cacheExpired: This task is about incorrect handling of the @PersistenceException@ in @orm/Session.cacheExpired()@.
Eric Faulhab... Ovidiu Maxiniuc
07:15 AM Bug #7371 (New): proper handling of exception case in cacheExpired: Ovidiu Maxiniuc
06:25 AM Feature #7365 (WIP): Avoid using reflection in generating BDT: Alexandru Lungu
06:21 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: Merged 7355a to trunk as rev. 14577. Archived 7355a. Alexandru Lungu
06:12 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: Doing the rebase now. Planning to merge asap. Alexandru Lungu
06:11 AM Bug #7334: Reclaim used sessions to improve performance: Rebased 7334 to latest trunk. 7334a is now at rev. 14578. Alexandru Lungu
03:13 AM Bug #7334: Reclaim used sessions to improve performance: *Review of 7334a*
* Place the opening brace of @PersistenceConsumer@ on the next line.
* I think you can make the... Alexandru Lungu
02:37 AM Bug #7334: Reclaim used sessions to improve performance: I think we should insist on the multi-user test-case. We should see why we don't have performance improvements there.... Alexandru Lungu
03:54 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM: > At the moment, I only modified FastCopyHelper.copyTable to generate such statement. I still need to test append and... Alexandru Lungu
03:00 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM: Alexandru Lungu wrote:
> * compare on a dummy FWD-H2 the time difference between dropping a table and deleting all o... Dănuț Filimon

05/20/2023

09:45 AM Bug #7367: disable TriggerTracker for TemporaryBuffer: A session trigger can't be registered for a temp-table (I also double-checked in OE). This means that @RecordBuffer.... Constantin Asofiei
09:40 AM Bug #7367 (Closed): disable TriggerTracker for TemporaryBuffer: Constantin Asofiei
09:08 PM Bug #7358: Optimize Session.invalidateRecords: I have reviewed revision 14571 of 7026d. I totally agree with the code. Good job!
If there is space for more impro... Ovidiu Maxiniuc

05/19/2023

03:01 PM Feature #7366: improve performance of buffer.fill: Created branch 7366a from trunk rev 14573.
7366a/14574 contains a first attempt at improving performance of @Buffe... Constantin Asofiei
02:36 PM Feature #7366 (WIP): improve performance of buffer.fill: Constantin Asofiei
02:33 PM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: OK, it can go after 7241a. Greg Shah
02:28 PM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: Greg Shah wrote:
> Can we merge this to trunk?
Is OK from my part. Constantin Asofiei
02:02 PM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: Can we merge this to trunk? Greg Shah
06:59 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: Alexandru Lungu wrote:
> Constantin, can you confirm that your scenario which caused #7355-1 is fixed now?
Confirme... Constantin Asofiei
06:35 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: I've run the changes across customer applications and the individual set of tests (without issues). The core of the c... Alexandru Lungu
06:22 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: Do we need any additional review or testing before merging to trunk? Greg Shah
03:00 AM Bug #7355 (Test): regression in row structure calculation for DATETIME-TZ when join is used on te...: Done. Committed as 7156a/rev. 14567. Alexandru Lungu
02:22 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: Alexandru Lungu wrote:
> This is good; I don't have to rebase it myself now :) As the tests are OK and customer appl... Constantin Asofiei
02:21 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: Ovidiu Maxiniuc wrote:
> Then just reconvert and you'll get the DMO using expanded fields.
Got it! The changes ar... Alexandru Lungu
09:02 PM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: Alexandru,
I mistaken the 7355a with another branch and I have just rebased it to latest trunk. Since I am doing the... Ovidiu Maxiniuc
09:41 AM Feature #7365: Avoid using reflection in generating BDT: @TextOps.instantiate@ is a hot-spot in our profiling. This is because it uses @getDeclaredConstructor().newInstance()... Alexandru Lungu
09:38 AM Feature #7365 (Closed): Avoid using reflection in generating BDT: Alexandru Lungu
09:36 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM: Danut, I think I have a better idea.
My concern is that dropping tables like @MASTER__PK__MAPPING_1@ will make th... Alexandru Lungu
02:59 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM: Danut, if you already do modifications to the @FastCopyHelper@, I will request more things here:
* Fix the javadoc a... Alexandru Lungu
09:08 AM Feature #7363: Improve H2 Value caching, hashing and equals: One last comment here. If you already plan to do some changes to @ValueStringIgnoreCase@, also consider optimizing @V... Alexandru Lungu
03:14 AM Feature #7363: Improve H2 Value caching, hashing and equals: The same issue we have in FWD, @P2JField.computeHash@. Please use @hashCodeCaseInsensitive@ there, instead of @.toLow... Alexandru Lungu
02:33 AM Feature #7363: Improve H2 Value caching, hashing and equals: Recently we enabled support for case-insensitive character values in H2 using @ValueStringIgnoreCase@.
However, @... Alexandru Lungu
02:24 AM Feature #7363 (Closed): Improve H2 Value caching, hashing and equals: Alexandru Lungu
06:22 AM Feature #7066: Implement multi-table indexed query in H2: While working with #7252, I found a much easier way to obtain the index name, which is done automatically instead of ... Radu Apetrii
05:43 AM Bug #7358 (Review): Optimize Session.invalidateRecords: Committed implementation of the idea from #7358-1 to 7026d as rev. 14571.
The total time improvement is of *-5.2%* o... Alexandru Lungu
05:34 AM Bug #7364: Build a full test-suite for fast copy-temp-table: There were many recent changes for @FastCopyHelper@ and some are still pending. However, we don't have such a complet... Alexandru Lungu
03:57 AM Bug #7364 (New): Build a full test-suite for fast copy-temp-table: Alexandru Lungu
05:21 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors: I've refactored the code as you suggested. The changes are on 7026d, rev. 14570.
I found no issues while testing (w... Radu Apetrii

05/18/2023

04:00 PM Feature #7037: remove dirty share manager: Dirty sharing has been disabled in the directory for Hotel GUI (rev 264) and Hotel ChUI (rev 86). Stanislav Lomany
10:44 AM Feature #7037 (Review): remove dirty share manager: Greg Shah
10:43 AM Feature #7037: remove dirty share manager: Eric: Please review. Greg Shah
10:43 AM Feature #7037: remove dirty share manager: Yes, it's safe. Stanislav Lomany
10:42 AM Feature #7037: remove dirty share manager: Does it default to the current approach? In other words, it won't cause changes in behavior for existing application... Greg Shah
10:41 AM Feature #7037: remove dirty share manager: Yes, it is ready. Stanislav Lomany
10:37 AM Feature #7037: remove dirty share manager: Is this ready for review?
What is the %Done for this task? Greg Shah
10:33 AM Feature #7037: remove dirty share manager: Rebased task branch 7037b from FWD trunk revision 14572. Stanislav Lomany
10:03 AM Feature #6442: missing encoding/collation features: Just a quick question about design: are collation/codepage available as some database config (like in @ConnectionMana... Boris Schegolev
10:02 AM Bug #7334: Reclaim used sessions to improve performance: *Committed 7334a.rev14569.* I applied the changes mentioned in #7334-11.
I misunderstood your question and reteste... Dănuț Filimon
07:03 AM Bug #7334: Reclaim used sessions to improve performance: What about multiple client? I suspect your test was done with only one client? Alexandru Lungu
05:54 AM Bug #7334: Reclaim used sessions to improve performance: Alexandru Lungu wrote:
> Danut, can you retrieve the same statistics as in #7334-8 without any pause?
After retes... Dănuț Filimon
03:42 AM Bug #7334: Reclaim used sessions to improve performance: Danut, can you retrieve the same statistics as in #7334-8 without any pause? I am curios how fast is using a single s... Alexandru Lungu
09:36 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: There is something else, that caught my attention. In the @tests/dataset/TestReadXmlFileNoPkReadGenerated.cls@ test, ... Maciej Zieniuk
09:12 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> Just wondering that maybe for better clarity, we only prepare temp-table, when the temp-tabl... Igor Skornyakov
09:08 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Just wondering that maybe for better clarity, we only prepare temp-table, when the temp-table is in the CLEAR state ?... Maciej Zieniuk
08:28 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: > This change fixed 4 tests and i think it make sense, any comments on this ?
Igor: I think this is for you. Greg Shah
08:16 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Yeah i agree, set name for dynamic temp-table is equivalent to prepared state - i will revert my change from the bran... Maciej Zieniuk
06:24 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Ovidiu Maxiniuc wrote:
> I am pretty sure the name of static temp-tables cannot be set/changed dynamically.
> In th... Marian Edu
05:47 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I just rebased 4514a on top of newest 3827b (which includes some fixes for ABLUnit that i need), which is based on to... Maciej Zieniuk
08:51 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> I have analyzed the failure in the @tests/dataset/TestReadXmlFileNoPkReadGenerated.cls@ test... Ovidiu Maxiniuc

05/17/2023

05:09 PM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: The denormalization of dynamic temp-tables is governed by @persistence/denormalize-dynamic-temp-tables@ directory key... Ovidiu Maxiniuc
07:43 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: I tested with a complex example using extents and datetime-tz, but only normalized (which was ok). I am trying to tes... Alexandru Lungu
06:00 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: We need some tests with datetime-tz extent fields (I think is enough to have @tt1.f0@ as extent in the example). Tes... Constantin Asofiei
05:25 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: If I am going to use this is the c'tor and use @propertySize@, I can do:... Alexandru Lungu
05:01 PM Feature #6442: missing encoding/collation features: I pushed the latest version as revision 6442a/14572:
* fixed the rules so that the conversion works with the new key... Boris Schegolev
11:28 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: The prepared flag did not fix the test, mostly because the temp-tables are prepared already when @run support/dataset... Maciej Zieniuk
08:52 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: > the name is a parameter what can be set or changed at any time and it have nothing to do with the prepared state
... Greg Shah
08:32 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Adding to the name, it looks like during the xml file load, the name is set on the temp-table when it encounters this... Maciej Zieniuk
08:29 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I have analyzed the failure in the @tests/dataset/TestReadXmlFileNoPkReadGenerated.cls@ test @createFilesForDsmaster@... Maciej Zieniuk
07:43 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Greg Shah wrote:
> @SEARCH@ can work. We also could provide some kind of configuration value that could be the "roo... Marian Edu
07:36 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: @SEARCH@ can work. We also could provide some kind of configuration value that could be the "root" path for relative... Greg Shah
07:18 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Greg Shah wrote:
> We should change the code to make it operate more naturally. I prefer not to copy lots of files ... Marian Edu
06:50 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: We should change the code to make it operate more naturally. I prefer not to copy lots of files around when running ... Greg Shah
10:42 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: When running any converted 4GL application, the resource files can be either in jar, but usually, like in this case, ... Ovidiu Maxiniuc
10:06 AM Bug #7334: Reclaim used sessions to improve performance: *Review of 7334a.rev14568*
* Make @initialize()@ method synchronized to avoid concurrent initalization of the thre... Alexandru Lungu
08:53 AM Bug #7334: Reclaim used sessions to improve performance: *Committed 7334a.rev14568*. This update allows managing of expired session across all @SessionFactory@ instances usin... Dănuț Filimon
08:14 AM Bug #7334: Reclaim used sessions to improve performance: Danut, please commit your latest changes to 7334a. I will do a quick review. Alexandru Lungu
07:31 AM Bug #7334: Reclaim used sessions to improve performance: I added the Daemon thread for closing session based on a lifespan value. I also tested different lifespan values as s... Dănuț Filimon
05:41 AM Bug #7351 (WIP): Reduce SQL query string size of an INSERT INTO SELECT FROM: Please check @FastCopyHelper@ and if the field list can be compressed with a simple @tt.*@ syntax. Note that this is ... Alexandru Lungu
05:24 AM Bug #7358: Optimize Session.invalidateRecords: I see @Session.invalidateRecords@ as a constant bottle-neck in my profiling. Most of the times, @TemporaryBuffer@ tri... Alexandru Lungu
03:43 AM Bug #7358 (Closed): Optimize Session.invalidateRecords: Alexandru Lungu

05/16/2023

05:34 PM Feature #6442 (WIP): missing encoding/collation features: Boris Schegolev
03:38 PM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: I am OK with the code from rev. 14572. It will clearly bring more performance than my initial solution. An alternativ... Ovidiu Maxiniuc
02:04 PM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: Alexandru, there is @PropertyReader.propertySize()@ which gives the number of SQL columns for a DMO property. Is it ... Constantin Asofiei
09:15 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: Ovidiu: Please review. Greg Shah
09:07 AM Bug #7355 (Review): regression in row structure calculation for DATETIME-TZ when join is used on ...: Created 7355a and committed rev. 14572. @DmoMeta@ computes the total number of SQL fields only once and uses it in @F... Alexandru Lungu
03:44 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: Alexandru, please create a 7355a branch and cache the total number of SQL fields in a table at DmoMeta (so not just d... Constantin Asofiei
02:23 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: Nice catch, this makes sense. At some point @canUseWildcard@ was denying the use of wildcard for @datetime-tz@ fields... Alexandru Lungu
08:32 PM Bug #7355 (WIP): regression in row structure calculation for DATETIME-TZ when join is used on tem...: Your analysis is correct. Here is the patch for fixing the issue:... Ovidiu Maxiniuc
03:09 PM Bug #6887: improve performance of dataset/table[-handle] parameters: Constantin Asofiei wrote:
> Boris, did you run the tests in OpenEdge and in FWD? What is the difference in time?
... Boris Schegolev

05/15/2023

12:43 PM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: Denormalized datetime-tz extent fields need to be checked, too. Constantin Asofiei
12:40 PM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables: I'm not sure when this was introduced (I suspect when @tt.*@ or something like this). In FWD, DATETIME-TZ type uses ... Constantin Asofiei
12:37 PM Bug #7355 (Closed): regression in row structure calculation for DATETIME-TZ when join is used on ...: Constantin Asofiei
12:29 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Marian Edu wrote:
> Maciej Zieniuk wrote:
> > The @tests/dataset/TestXmlNodeType.cls@ have a line during the setup,... Maciej Zieniuk
05:58 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Vladimir Tsichevski wrote:
> Maciej Zieniuk wrote:
> > attaching the procedure i mentioned :)
>
> This procedure... Maciej Zieniuk
10:06 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses: I have mixed feelings about the cache on the second thought.
My concern is that the cache is unbound, so we may en... Alexandru Lungu
07:07 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses: I've committed to 7252a, rev. 14563 and to 7252a_h2, rev. 19 some changes that target the remaining points from the l... Radu Apetrii
09:47 AM Bug #7352: Mismatching results when comparing case-insensitive/case-sensitive values between 4GL ...: There were several different results when comparing case-insensitive and case-sensitive values from where clauses, fo... Dănuț Filimon
09:32 AM Bug #7352 (WIP): Mismatching results when comparing case-insensitive/case-sensitive values betwee...: Dănuț Filimon
09:23 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Dănuț Filimon wrote:
> I found several mismatched between FWD and 4GL. All of the tests are done in the following ma... Alexandru Lungu
09:05 AM Bug #7334: Reclaim used sessions to improve performance: I remodeled the profiling test to fit a multi-user case. I never detailed what the contents of test are, only that it... Dănuț Filimon
08:59 AM Feature #7037: remove dirty share manager: Created task branch 7037b from FWD trunk revision 14571. Stanislav Lomany
09:02 PM Feature #7037: remove dirty share manager: Please create a task branch and apply your changes. We are going to test this with various customer projects and wit... Greg Shah
08:29 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: 6813b/14569 was rebased from trunk rev 14570 - new rev 14576.
6813b/14576 was merged to trunk rev 14571 and archived. Constantin Asofiei
08:12 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Greg Shah wrote:
> 6813b can be merged to trunk now.
OK, working on it. Constantin Asofiei
08:02 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: 6813b can be merged to trunk now. Greg Shah
07:10 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM: The @COPY-TEMP-TABLE@ statement sometimes uses a "fast" approach if possible. It analyses table signatures (field typ... Alexandru Lungu
07:06 AM Bug #7351 (Closed): Reduce SQL query string size of an INSERT INTO SELECT FROM: Alexandru Lungu
05:23 AM Feature #7323: Implement soft unique index in FWD-H2: Eric Faulhaber wrote:
> The lack of H2 unique indices for temp-tables exists so that we can mimic the behavior of th... Alexandru Lungu

05/12/2023

05:52 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> attaching the procedure i mentioned :)
This procedure (the assertion in the end of it) fa... Vladimir Tsichevski
05:10 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database: Eric Faulhaber wrote:
> Since trunk has moved ahead today, another rebase is needed.
Rebased, conflicts resolved,... Boris Schegolev
01:49 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database: Code review 6812a/14567:
Looks good. I did a little format cleanup and committed to rev 14568. I did not update th... Eric Faulhaber
01:13 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database: Greg Shah wrote:
> I'll let Eric review this. In the future, please do not create a new branch instead of rebasing.... Boris Schegolev
08:09 AM Bug #6812: fix FastFindCache to use a shared instance per persistent database: I'll let Eric review this. In the future, please do not create a new branch instead of rebasing. That typically los... Greg Shah
11:16 AM Bug #7330: Increase psCache size: Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Committed 7026d/rev. 14566 Set default to 8196. Configuratio... Eric Faulhaber
09:52 AM Bug #7330: Increase psCache size: Greg Shah wrote:
> Why 8196 instead of 8192?
I don't have a proper excuse for that :) Fixed it now in 7026d/rev. ... Alexandru Lungu
09:41 AM Bug #7330: Increase psCache size: Why 8196 instead of 8192? Greg Shah
09:33 AM Bug #7330: Increase psCache size: Alexandru Lungu wrote:
> Committed 7026d/rev. 14566 Set default to 8196. Configuration option: @persistence/ps-cache... Constantin Asofiei
09:33 AM Bug #7330 (Review): Increase psCache size: Committed 7026d/rev. 14566 Set default to 8196. Configuration option: @persistence/ps-cache-size@ as integer. Alexandru Lungu
09:02 AM Bug #7330: Increase psCache size: Please default to 8192. If memory is an issue, customers can reduce it and take the performance hit. I prefer faste... Greg Shah
09:00 AM Bug #7330: Increase psCache size: Alexandru Lungu wrote:
> Constantin, I am ready to commit the "ps-cache-size" option support. Shall I set a default ... Constantin Asofiei
08:58 AM Bug #7330: Increase psCache size: Constantin, I am ready to commit the "ps-cache-size" option support. Shall I set a default of 2048 (as it was now) an... Alexandru Lungu
08:21 AM Bug #7330: Increase psCache size: Alexandru Lungu wrote:
> As a conclusion here, I think it is optimal to either extend the cache to 4096 (and expire ... Eric Faulhaber
06:10 AM Bug #7330: Increase psCache size: As a conclusion here, I think it is optimal to either extend the cache to 4096 (and expire 400 entries and lose some ... Alexandru Lungu
06:02 AM Bug #7330: Increase psCache size: Retested with a @psCache@ of capacity 65535.
I get a @psCache@ size with only @4470@ statements, so according to #... Alexandru Lungu
04:57 AM Bug #7330: Increase psCache size: I've got a memory dump to check the status on the @psCache@ on a large customer application.
Before doing a client r... Alexandru Lungu
09:28 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors: *Review of 7026d 14563-14564:*
* Extent can be @null@! Don't use @null@ as a marker to check if it was computed or... Alexandru Lungu
08:37 AM Bug #7336: optimize DmoMeta.byLegacyName: Committed the switch to @CaseInsensitiveHashMap@ in @DmoMeta.byLegacyName@ with 7026d/rev. 14565. Alexandru Lungu
06:51 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: I've removed the @System.out.println("Deprecated API: @ calls in 6813b rev 14569.
Greg: this can be merged to trunk. Constantin Asofiei
06:32 AM Bug #6887: improve performance of dataset/table[-handle] parameters: Boris, did you run the tests in OpenEdge and in FWD? What is the difference in time?
In FWD, what does a trace pro... Constantin Asofiei
04:45 AM Bug #7334: Reclaim used sessions to improve performance: *Committed 7334a/rev.14567.* Added the initial implementation for reclaimable sessions.
Alexandru Lungu wrote:
> ... Dănuț Filimon
03:44 AM Bug #7334: Reclaim used sessions to improve performance: I will test/profile this as it is now. However, I am further on interested in:
* a multi-user environment test. Do y... Alexandru Lungu
03:38 AM Bug #7321: Improve FWD-H2 wildcard projection: *Committed 7321a_h2/rev.19.* Removed @TableFilter.getCurrentRow()@, used @TableFilter.get()@ instead.
Instead of u... Dănuț Filimon

05/11/2023

07:05 PM Bug #6812 (Review): fix FastFindCache to use a shared instance per persistent database: I pushed the requested changes as revision 6812b/14567. This is a new branch based on current @trunk@, I'll drop @681... Boris Schegolev
06:12 PM Bug #6887: improve performance of dataset/table[-handle] parameters: Eric Faulhaber wrote:
> Boris, did you take a final pass at this?
I just did and I don't see any difference from ... Boris Schegolev
06:06 PM Bug #6887: improve performance of dataset/table[-handle] parameters: Constantin Asofiei wrote:
> We should profile and check how #6887-3 test behaves now with FWD first.
Boris, did y... Eric Faulhaber
05:51 PM Bug #6887: improve performance of dataset/table[-handle] parameters: I think we should close this task. I just didn't find a more appropriate status :) Boris Schegolev
05:48 PM Bug #6887: improve performance of dataset/table[-handle] parameters: Boris, what is there to review? Eric Faulhaber
05:29 PM Bug #6887 (Review): improve performance of dataset/table[-handle] parameters: Boris Schegolev
05:27 PM Bug #6458 (WIP): ensure that OO expressions resolve to query substitution parameters, like handle...: Boris Schegolev
10:38 AM Bug #7321: Improve FWD-H2 wildcard projection: *Review of 7321a_h2/rev.18*
* I am not sure if you actually need @currentSearchRow@ or @current@. Anyway, your @T... Alexandru Lungu
10:18 AM Bug #7336 (Review): optimize DmoMeta.byLegacyName: h2. Right trimming
I found it accessible to add rtrim in some structures:
* For @CaseInsensitiveMap@ I stop compu... Alexandru Lungu
10:16 AM Bug #7334: Reclaim used sessions to improve performance: I created a @SessionFactory@ which allows a @Session@ to be reclaimed. I did a round of testing which mimic the speci... Dănuț Filimon
09:20 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses: Ok, I guess we can go ahead with integrating it without the @fullIndexName@ (for now). However, I am concerned of the... Alexandru Lungu
02:49 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Ovidiu, I understand your reasoning about the deprecated @String@ APIs, but please remove @System.out.println("Deprec... Constantin Asofiei

05/10/2023

04:35 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Review of 6813b/14567.
* @SymbolResolver.java@, @matchTargetMethod()@ method. There is another case of ambiguity whe... Ovidiu Maxiniuc
02:38 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: 6813b rev 14567 fixes another typo.
I've reviewed rules/ changes (95% automatically, 5% manually). Considering th... Constantin Asofiei
12:59 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: 6813b rev 14566 fixes what I think is a debug added in @common-progress.rules:oo_call_type@ function, there was a @pr... Constantin Asofiei
07:12 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: 6813b rev 14565 fixes history numbers, some javadocs and also adds the CommonAstSupport versions of upPath/downPath/r... Constantin Asofiei
02:30 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: 6813a was dead-archived. 6813b was created from trunk rev 14563.
I've fixed the conflicts and all changes are in ... Constantin Asofiei
10:50 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Constantin Asofiei wrote:
> Ovidiu, what is the state of the 6813a branch? I'd like to complete this.
6813a was b... Ovidiu Maxiniuc
09:21 AM Bug #7336: optimize DmoMeta.byLegacyName: Done multiple runs of a customer POC. I got:
*Original*: 50ms spent on map look-up, 200ms spent on lowering, right... Alexandru Lungu
05:27 AM Bug #7336 (WIP): optimize DmoMeta.byLegacyName: The effort for this task is related to the @DmoMeta.byLegacyName@ hotspot, caused by lots of calls to @TextOps.rightT... Alexandru Lungu
09:21 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors: Radu Apetrii wrote:
> > I haven't tested yet with a large customer application, but I will get this done.
> I have ... Radu Apetrii
08:15 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors: Radu Apetrii wrote:
> I haven't tested yet with a large customer application, but I will get this done.
I have iden... Radu Apetrii
05:42 AM Bug #5452 (Review): eliminate use of ResultSet.CONCUR_UPDATABLE?: Removed readOnly flag and fixed persistence.list() and getQuery() new signatures, checked with a large project and it... Ștefan Roman
02:59 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Ovidiu Maxiniuc wrote:
> Thank you. Seems logical. I was not remembering correctly :(.
> I was thinking of some o... Marian Edu

05/09/2023

06:46 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Marian Edu wrote:
> Ovidiu Maxiniuc wrote:
> > IIRC, this is how 4GL works. Probably there are two values in the so... Ovidiu Maxiniuc
10:19 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: attaching the procedure i mentioned :) Maciej Zieniuk
10:16 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Vladimir Tsichevski wrote:
> Ovidiu Maxiniuc wrote:
> > Vladimir Tsichevski wrote:
> > > Maciej Zieniuk wrote:
> ... Maciej Zieniuk
09:02 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Ovidiu Maxiniuc wrote:
> IIRC, this is how 4GL works. Probably there are two values in the source which would brea... Marian Edu
07:32 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Ovidiu Maxiniuc wrote:
> Maciej Zieniuk wrote:
> > I don't think it's a coincidence that just after this test... Maciej Zieniuk
07:25 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Vladimir Tsichevski wrote:
> There is something wrong with error propagation in FWD when a persistent procedure is c... Maciej Zieniuk
02:47 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: I've used this to validate the tokens used in @upPath@, @relativePath@, @downPath@ and @absolutePath@ (btw, this is n... Constantin Asofiei
02:31 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: I think the change is OK. I had to read it a few times, but your comments helped. Greg Shah
11:19 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: As an addendum: the point of this change is to have method definition for i.e. @upPath@ with 1, 2, 3 and 4 arguments.... Constantin Asofiei
11:17 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: I'm counting the arguments for the @relativePath@, @upPath@ and @downPath@ from @rules/@; the result is this:... Constantin Asofiei
11:15 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: What is the list of remaining issues to be addressed here? We have multiple customers starting to deploy and requiri... Greg Shah
10:18 AM Bug #7336 (Closed): optimize DmoMeta.byLegacyName: Alexandru Lungu
06:35 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors: I've applied the suggested comments. The changes are on 7026d, rev. 14563.
I haven't tested yet with a large custome... Radu Apetrii
04:28 AM Bug #7329 (WIP): improve FieldReference resolution of getter/setter/extent accessors: Radu, please fix this in 7026d. Alexandru Lungu
04:01 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors: Constantin Asofiei wrote:
> * index
Here I meant 'getExtent'
Constantin Asofiei
06:32 AM Bug #7330: Increase psCache size: Constantin Asofiei wrote:
> And something else thing to consider: any PreparedStatement instance is linked to a JDBC... Constantin Asofiei
06:31 AM Bug #7330: Increase psCache size: Alexandru, for example, in an application, I saw ~8k JDBC prepared statements being created. If the actual used cach... Constantin Asofiei
04:45 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses: Alexandru Lungu wrote:
> Radu Apetrii wrote:
> > Also, I've left two TODOs which will be taken care of as soon as t... Radu Apetrii
04:01 AM Feature #7194: Avoid generating an ORDER-BY clause if not required: I have modified @RandomAccessQuery@ so that an ORDER BY clause will not be added to the FQL if a unique finding is en... Radu Apetrii
03:53 AM Bug #7334: Reclaim used sessions to improve performance: Alexandru Lungu wrote:
> Basically, allow each session to be reclaimed, but only within a limited time threshold.
... Alexandru Lungu
02:56 AM Bug #7321: Improve FWD-H2 wildcard projection: *Committed 7321a_h2/rev.18.* Improved wildcard projection by doing a fast copy of the current search row.
This imp... Dănuț Filimon

05/08/2023

05:59 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: There is something wrong with error propagation in FWD when a persistent procedure is concerned.
The procedure @pe... Vladimir Tsichevski
04:16 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> I don't fully understan this test @tests.dataset.TestFillMode@ method @withPkCorrectBufferAs... Ovidiu Maxiniuc
04:11 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> Another commit i have added to @4514a@ p2j branch. That fixes the @TestFill@ test.
> [...]
... Ovidiu Maxiniuc
03:59 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> I don't think it's a coincidence that just after this test and exception, other tests are un... Ovidiu Maxiniuc
03:42 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Ovidiu Maxiniuc wrote:
> Vladimir Tsichevski wrote:
> > Maciej Zieniuk wrote:
> > > I found this exception from th... Vladimir Tsichevski
03:33 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Vladimir Tsichevski wrote:
> Another conversion issue: @dataset.TestAcceptChanges@ legacy class converts to:
> [...... Ovidiu Maxiniuc
02:16 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Vladimir Tsichevski wrote:
> Maciej Zieniuk wrote:
> > I found this exception from the server's logs, that happens ... Ovidiu Maxiniuc
09:41 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I don't fully understan this test @tests.dataset.TestFillMode@ method @withPkCorrectBufferAsign@, specifically this p... Maciej Zieniuk
03:30 PM Feature #7323: Implement soft unique index in FWD-H2: Alexandru Lungu wrote:
> *Eric, Constantin, Ovidiu*: is the lack of H2 unique indexes for temporary tables out of ... Eric Faulhaber
02:59 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: Ovidiu, what is the state of the 6813a branch? I'd like to complete this. Constantin Asofiei
09:44 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries: The example is good, I understand what you mean: the problem are not the literals, but the fact that different buffer... Ovidiu Maxiniuc
02:30 PM Bug #4071: FWD server stops allowing new web client logins after abend: I think the testcase in #7193-62 is another example of this same issue. Context cleanup should never run on the read... Greg Shah
10:25 AM Bug #7334 (WIP): Reclaim used sessions to improve performance: This task is meant to solve #7167, #6820, and #4021 at once.
Please refer to #7167 for the initial problem. Here w... Alexandru Lungu
10:12 AM Bug #7334 (Closed): Reclaim used sessions to improve performance: Alexandru Lungu
10:08 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses: Radu Apetrii wrote:
> Also, I've left two TODOs which will be taken care of as soon as the changes from #7066 will b... Alexandru Lungu
06:31 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses: I've committed to 7252a, rev.14562 and 7252a_h2, rev.18 a few changes that allow the use of direct-accessing when ret... Radu Apetrii
06:05 AM Bug #7330: Increase psCache size: Consider extending the @psCache@ size from 2048 to 65535. This was attempted before in #6829, but the memory consumpt... Alexandru Lungu
05:05 AM Bug #7330 (Closed): Increase psCache size: Alexandru Lungu
04:51 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: *Committed 7138a_h2/rev.22.* Allowed @ValueNull@ values to be compared. Dănuț Filimon
04:32 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: Dănuț Filimon wrote:
> After looking at the code, I remember that I excluded @Value.NULL@ because I was using @compa... Alexandru Lungu
04:31 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: I retested the application and counted updates that use null, from a total of *1352885* I obtained the following:
|_... Dănuț Filimon
04:25 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors: Refactor FieldReference to lazily initialize the fields which are now in the constructor; this includes:
* getter
*... Constantin Asofiei
04:22 AM Bug #7329 (Closed): improve FieldReference resolution of getter/setter/extent accessors: Constantin Asofiei
03:22 AM Bug #5452 (WIP): eliminate use of ResultSet.CONCUR_UPDATABLE?: I am OK with the current changes.
However, you still need to extend your removal of @readOnly@. More exactly, ther... Alexandru Lungu

05/07/2023

08:08 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Another commit i have added to @4514a@ p2j branch. That fixes the @TestFill@ test.... Maciej Zieniuk
06:00 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I can create it. So essentially, we take out the content of the @passWrongDefinition@ test as a standalone procedure ... Maciej Zieniuk

05/06/2023

01:40 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> I did run @TestOutputDynamicDsInDynamicProc@ against 4GL 11.6 and it was green (all test met... Vladimir Tsichevski
01:34 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Also just pushed a commit to @4514a@ p2j branch that fixes the @TestDataSourceModified@ test - error 4083 as warning:... Maciej Zieniuk
01:28 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I did run @TestOutputDynamicDsInDynamicProc@ against 4GL 11.6 and it was green (all test methods passing) Maciej Zieniuk
01:25 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> I don't think it's a coincidence that just after this test and exception, other tests are un... Vladimir Tsichevski
12:58 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I don't think it's a coincidence that just after this test and exception, other tests are unable to run correctly.
... Maciej Zieniuk
12:17 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Vladimir Tsichevski wrote:
> Maciej Zieniuk wrote:
> > I found this exception from the server's logs, that happens ... Vladimir Tsichevski
12:15 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> I found this exception from the server's logs, that happens inside the @passWrongDefinition@... Vladimir Tsichevski
10:30 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I found this exception from the server's logs, that happens inside the @passWrongDefinition@. I am guessing they are ... Maciej Zieniuk
04:42 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Vladimir, the @setUpBeforeClass@ runs fine on it's own. But let the @passWrongDefinition@ test run and then any other... Maciej Zieniuk

05/05/2023

04:38 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> There is one more issue which i tried to debug. The @tests.dataset.parameter.output.TestOu... Vladimir Tsichevski
08:50 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Another conversion issue: @dataset.TestAcceptChanges@ legacy class converts to:... Vladimir Tsichevski
07:33 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Did pushed a new revision on testcases #1405 that includes some changes in the dataset tests, mainly clean-up after e... Marian Edu
07:26 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Greg Shah wrote:
> We might as well fix it here, now.
>
> It is weird syntax.
It just looks like that, however @... Marian Edu
10:19 AM Feature #7323: Implement soft unique index in FWD-H2: Alexandru Lungu wrote:
> prior simple SELECT is faster than a SAVEPOINT to avoid partial inserts in case of constrai... Alexandru Lungu
10:11 AM Feature #7323: Implement soft unique index in FWD-H2: I just realized that direct-access is not necessarily an option because these validation statements are prepared only... Alexandru Lungu
09:47 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: Tested with a large customer application and I get similar results: between -0.1% and +0.1%. I will retest on a newer... Alexandru Lungu
05:30 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: Alexandru Lungu wrote:
> * you can do a quick reconversion of Hotel GUI and use H2 persistent database just to check... Dănuț Filimon
09:31 AM Bug #5452 (Review): eliminate use of ResultSet.CONCUR_UPDATABLE?: Removed readOnly flag from SQLQuery, checked with HotelGUI and everything works fine.
Commited to 5452a revision 14561. Ștefan Roman
06:39 AM Bug #5452 (WIP): eliminate use of ResultSet.CONCUR_UPDATABLE?: Ștefan Roman
05:50 AM Bug #5452: eliminate use of ResultSet.CONCUR_UPDATABLE?: Created 5452a from trunk/rev. 14560. Alexandru Lungu
05:43 AM Bug #7321: Improve FWD-H2 wildcard projection: On a large customer application, I checked how much time this scenario (wildcard expansion and search row projection)... Alexandru Lungu
05:41 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...: Boris, first, run conversion with @-Drules.tracing=true@. Use this for both the OO and non-OO tests.
You can look... Constantin Asofiei
05:37 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...: Gentlemen, I couldn't figure out details of the conversion procedure. So, anyone who has time and knowledge is more t... Boris Schegolev
05:32 AM Feature #7320: Extend H2 tester from Hotel GUI: Some of our recent work on FWD-H2 performance can be captured with tests like the following. Please make sure you inc... Alexandru Lungu

05/04/2023

06:11 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: We might as well fix it here, now.
It is weird syntax. Normally you would call @valid-handle(dsMasterDynamic)@ to... Greg Shah
05:41 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> In my testcases branch i changed this code to assign the handle to some other handle, as it ... Vladimir Tsichevski
05:25 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: In my testcases branch i changed this code to assign the handle to some other handle, as it did not compile for me.
... Maciej Zieniuk
05:16 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I have an issue compiling the @TestHandle.cls@ test: statements like... Vladimir Tsichevski
09:30 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> I identified the issue, thhat the @run support/dataset/create/dsMaster.p@ does not propagate... Ovidiu Maxiniuc
03:53 PM Bug #6812 (WIP): fix FastFindCache to use a shared instance per persistent database: Boris Schegolev
06:05 AM Bug #7319: Fix adaptive query test suite from testcases: Alexandru Lungu wrote:
> Are these the issues for the persistent database?
Yes, I forgot to mention. These issues ... Radu Apetrii
05:59 AM Bug #7319: Fix adaptive query test suite from testcases: Are these the issues for the persistent database? Are they the same as for temporary database? Alexandru Lungu
05:52 AM Bug #7319: Fix adaptive query test suite from testcases: It is done. Inside @adaptive_scrolling/persistent-adaptive_tests@ there are 2 folders (one for no-scrolling tests and... Radu Apetrii
04:08 AM Bug #7319: Fix adaptive query test suite from testcases: Radu Apetrii wrote:
> Alexandru Lungu wrote:
> > AFAIK, Radu, you already have such work already done. Please commi... Alexandru Lungu
04:02 AM Bug #7319: Fix adaptive query test suite from testcases: Alexandru Lungu wrote:
> AFAIK, Radu, you already have such work already done. Please commit to testcases the adapti... Radu Apetrii
04:15 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: *Committed 7138a_h2/rev.21*. Fixed a concurrency problem. @inMemUpdate@ and @notInMemUpdate@ need to be set to *null*... Dănuț Filimon
03:24 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: From the testing POV, we already covered several large applications for in-memory H2.
Danut:
* you can do a quick r... Alexandru Lungu

05/03/2023

04:30 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Greg Shah wrote:
> > I identified the issue, thhat the @run support/dataset/create/dsMaster.p@ does not propagate th... Vladimir Tsichevski
03:01 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: > I identified the issue, thhat the @run support/dataset/create/dsMaster.p@ does not propagate the assigned handle @o... Greg Shah
02:48 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: This test which had error propagation issues is working with the 3827b branch :)
I will rebase my changes on top o... Maciej Zieniuk
11:44 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Vladimir has some error propagation changes in task branch 3827b. Can you try those to see if the issue is resolved? Greg Shah
02:33 PM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: Dănuț Filimon wrote:
> Should I do similar tests for persistent tables?
As a lower priority, yes, just to make ... Eric Faulhaber
11:30 AM Feature #7323: Implement soft unique index in FWD-H2: I've done some logging with FWD-H2 on a large customer application and identified the following for a POC run. Out of... Alexandru Lungu
10:48 AM Feature #7323 (Closed): Implement soft unique index in FWD-H2: Alexandru Lungu
09:51 AM Feature #6630: optimize return of table parameter: I recreated a similar scenario where @TemporaryBuffer.loopDelete@ is called using a class field that has a destructor... Dănuț Filimon

05/02/2023

04:28 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I just pushed a potential fix to 4514a p2j branch, for the @tests.dataset.parameter.input.TestInputDynamicDsInDynamic... Maciej Zieniuk
03:00 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Attached @file-cvt-list.txt@ Maciej Zieniuk
01:26 PM Bug #7113: Problem with nested CAN-FIND conversion: > Sorry, but I do not understand. The conversion w/o my patch was incorrect and, AFAIR, you agreed with this. The fac... Ovidiu Maxiniuc
10:03 AM Bug #7321 (WIP): Improve FWD-H2 wildcard projection: Alexandru Lungu
09:56 AM Bug #7321: Improve FWD-H2 wildcard projection: Recently, queries over the temporary database use the wildcard syntax: @tt.*@ to select all the columns. If there are... Alexandru Lungu
09:28 AM Bug #7321 (Closed): Improve FWD-H2 wildcard projection: Alexandru Lungu
09:27 AM Feature #7320: Extend H2 tester from Hotel GUI: This task is related to the H2 tester from Hotel GUI, used to track performance of FWD-H2 in certain scenarios. We sh... Alexandru Lungu
08:50 AM Feature #7320 (WIP): Extend H2 tester from Hotel GUI: Alexandru Lungu
07:35 AM Bug #7319: Fix adaptive query test suite from testcases: The @testcases/adaptive-scrolling@ test-suite is a reference point for our implementation of @AdaptiveQuery@. It incl... Alexandru Lungu
07:21 AM Bug #7319 (New): Fix adaptive query test suite from testcases: Alexandru Lungu
07:26 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: I've tested fake-update performance for larger tables and extent fields, results of each test are measured in millise... Dănuț Filimon
07:21 AM Bug #7267 (Test): CompoundQuery FOR FIRST, EACH only retrieves the first record found: This can be closed/rejected. Alexandru Lungu
07:20 AM Bug #7267 (Review): CompoundQuery FOR FIRST, EACH only retrieves the first record found: Alexandru Lungu
07:20 AM Bug #7267 (WIP): CompoundQuery FOR FIRST, EACH only retrieves the first record found: Alexandru Lungu
07:16 AM Bug #7235 (Test): Avoid selecting all fields for an CAN-FIND sub-select: Merged 7026c to trunk as rev. 14553. Alexandru Lungu
04:15 AM Feature #7066: Implement multi-table indexed query in H2: While doing some work on #7252, I noticed that there might be some (other) stuff that is unnecessary computed when an... Radu Apetrii
04:02 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses: After doing some testing, I managed to form the following table:
|_. Scenario |_. Normal statements |_. Direct-a... Radu Apetrii

05/01/2023

03:43 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej, can you provide me and other with the @file-cvt-list.txt@ you use to convert tests for this issue, please. Th... Vladimir Tsichevski

04/29/2023

04:02 AM Bug #7113: Problem with nested CAN-FIND conversion: Ovidiu Maxiniuc wrote:
> Igor,
> I have fixed the extra closing parenthesis as part of another task. Please do not... Igor Skornyakov
08:34 PM Bug #7113: Problem with nested CAN-FIND conversion: Igor,
I have fixed the extra closing parenthesis as part of another task. Please do not put additional effort in th... Ovidiu Maxiniuc
03:38 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> The expectation is that the @for each ttOrderCustomer:@ will fail with @Progress.Lang.Error@... Marian Edu
09:56 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> The expectation is that the @for each ttOrderCustomer:@ will fail with @Progress.Lang.Error@... Ovidiu Maxiniuc

04/28/2023

04:15 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I am not sure what to do with the @tests.dataset.parameter.input.TestDatasetBind@ class test @referenceOnlyNotValid@.... Maciej Zieniuk
09:09 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Correct. ... Greg Shah
09:00 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Greg Shah wrote:
> > Aka, this doesn't convert because of the use of @no-error@:
>
> What is the error? Is it du... Marian Edu
08:04 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: > Aka, this doesn't convert because of the use of @no-error@:
What is the error? Is it during parsing or during l... Greg Shah
04:18 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Pushed a few changes, the conversion issue with @create dataset/data-source@ was due to the fact that @no-error@ opti... Marian Edu
04:06 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> You are right. I initially though this is about @dsInit@ being unknown, not initialized, b... Marian Edu
02:27 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: > This sounds good to me, but then why the handle is invalid? I would check the converted code, from what we've seen ... Maciej Zieniuk
01:49 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> - @tests.dataset.parameter.inout.TestInputOutputDynamicDsInDynamicProc@ method @passDatase... Marian Edu
04:12 AM Feature #7194: Avoid generating an ORDER-BY clause if not required: Alexandru Lungu wrote:
> ** What if the uniquely found record is changed? The query should invalidate (or not?) and ... Radu Apetrii

04/27/2023

09:30 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej: Please do fix all of these conversion issues. I don't want to leave behind any latent problems.
So we nee... Greg Shah
09:19 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> Marian, i don't think the @support/test/HandleFactory.cls@ is converting in newest testcases... Marian Edu
07:49 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Marian, i don't think the @support/test/HandleFactory.cls@ is converting in newest testcases revision, because of the... Maciej Zieniuk
05:32 AM Feature #7076: make CAN-FIND avoid hydration: I've tested both temporary and persistent tables with CAN-FIND and nested CAN-FIND. CAN-FIND no longer hydrates with ... Dănuț Filimon
03:50 AM Feature #6630: optimize return of table parameter: Danut, I recall I changed the @AdaptiveQuery@ from @TemporaryBuffer.loopDelete@ into a @PreselectQuery@. Basically, t... Alexandru Lungu
03:00 AM Bug #7235 (Review): Avoid selecting all fields for an CAN-FIND sub-select: Added this patch to 7026c.
Tested this. I got a -0.24% performance improvement with a 7026c profile run.
Just rebas... Alexandru Lungu

04/26/2023

05:04 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Thanks Marian, that helped.
Few findings:
- @tests.dataset.parameter.inout.TestInputOutputDynamicDsInDynamicProc@... Maciej Zieniuk
02:09 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> Oh i almost forgot, i have this weird issue, that i cannot run @ant dist@ on the testcases r... Marian Edu
10:21 AM Feature #7194 (WIP): Avoid generating an ORDER-BY clause if not required: I will move this back to 50% to allow the handling of other ORDER BY clauses (from RandomAccessQuery especially). Alexandru Lungu
10:18 AM Feature #7194 (Review): Avoid generating an ORDER-BY clause if not required: Tested this. I got a -0.24% performance improvement with a 7026c profile run.
Just rebased 7026c with trunk.
Fu... Alexandru Lungu
10:06 AM Feature #7076 (WIP): make CAN-FIND avoid hydration: Danut, please investigate this.
I am not sure if CAN-FIND still hydrates in the latest versions of FWD-H2 trunk (>1... Alexandru Lungu
09:16 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: I've tested #6928-3 and also made my own set of performance tests (results are measured in milliseconds). The results... Dănuț Filimon
05:57 AM Bug #7138 (Review): Short circuit fake-update (update with a new value eqaul to the old value) in H2: Fixed a regression in 7138a_h2 regarding updating indexed computed columns in inMemUpdate mode. If you have (f1, __if... Alexandru Lungu
08:05 AM Bug #7185: H2 in-memory lazy hydration: Merged 7185a_h2 into FWD-H2 trunk as rev. 17.
This doesn't require any FWD changes; it just optimizes the direct-ac... Alexandru Lungu
04:35 AM Bug #7185: H2 in-memory lazy hydration: Review 7185a_h2. The changes are good to go, you can proceed with the merge. Dănuț Filimon

04/25/2023

06:36 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Oh i almost forgot, i have this weird issue, that i cannot run @ant dist@ on the testcases repo, because it fails wit... Maciej Zieniuk
06:26 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I wanted to make sure that the dataset testcases actually works fine in 4GL ABLUnit.
With 4GL 11.6 version i was abl... Maciej Zieniuk
12:34 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> > Running all tests in a suite seems to make some of those tests to fail even if ran individ... Vladimir Tsichevski
10:45 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: > Running all tests in a suite seems to make some of those tests to fail even if ran individually they pass... curren... Maciej Zieniuk
07:41 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> Yes by "push" i meant bound branch to a remote repo with bzr commit.
> I will have to reba... Greg Shah
02:51 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Yes by "push" i meant bound branch to a remote repo with bzr commit.
I will have to rebase too once in a while, to ... Maciej Zieniuk
10:34 AM Feature #7194: Avoid generating an ORDER-BY clause if not required: My initial thought when I created #7194 was to optimize UNIQUE FIND/CAN-FIND for persistent databases. For temp datab... Alexandru Lungu
10:20 AM Bug #7185: H2 in-memory lazy hydration: I updated #7185-30 with the times regarding the FWD changes (lazy hydration). While the FWD-H2 changes provides a con... Alexandru Lungu
09:44 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: I tested Hotel_GUI and found no problems, but I found a regression in a customer application which I didn't manage to... Dănuț Filimon
05:51 AM Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select: Alexandru Lungu wrote:
> ... Please check that the SELECT keyword is placed correctly (as a left sibling of the num ... Dănuț Filimon
05:47 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Branch 7108a_h2 has been merged to FWD-H2 trunk at revision 16. Alexandru Lungu
05:47 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Branch 7108a has been merged to trunk at revision 14550 Alexandru Lungu
05:11 AM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries: Branch 7258a has been merged to trunk at revision 14549. Alexandru Lungu

04/24/2023

05:30 PM Feature #6371: implement SAVE CACHE statement: Code review 6371d/14544:
One *very minor* change: please fix the open curly brace at @SchemaComparator.java@:149 t... Eric Faulhaber
06:50 AM Feature #6371: implement SAVE CACHE statement: I was asked to test this statement. I will not be able to have a look at this soon, probably not even before summer v... Jurjen Dijkstra
01:42 PM Bug #7258 (Test): Optimize INDEX-INFORMATION with closed dynamic queries: @7258a.patch@ looks fine. The code in @DynamicQueryHelper@ looks much cleaner now. Good job! Ovidiu Maxiniuc
04:25 AM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries: Ovidiu, I am planning to merge 7258a today. Move this to Test after you check #7158-7: these are the same changes as ... Alexandru Lungu
09:00 AM Bug #7035: Extract query parameters from statically converted FQL: I created the temporary *JMX* and added counters for meta, temp, dirty and persistent database hits/misses. The count... Dănuț Filimon
06:46 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: *Review to 7138a_h2/rev.17* : I am OK with the changes.
Danut, please re-test 7138a_h2 (own test-cases, large cust... Alexandru Lungu
05:47 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: > I have pushed that change to @~/secure/code/p2j_repo/p2j/active/4514a@. If i find anything i will push more to the ... Greg Shah
05:34 AM Feature #7194: Avoid generating an ORDER-BY clause if not required: Radu, let the intended changes for #7194 reside in 7026c. I am thinking of merging 7026c independently from 7066a, as... Alexandru Lungu
05:30 AM Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select: *Review of #7235 patch in #7235-3.*
* When you append the NUM_LITERAL, you also append SELECT (which is OK). You u... Alexandru Lungu

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Database

Activity

Activity

05/22/2023

05/20/2023

05/19/2023

05/18/2023

05/17/2023

05/16/2023

05/15/2023

05/12/2023

05/11/2023

05/10/2023

05/09/2023

05/08/2023

05/07/2023

05/06/2023

05/05/2023

05/04/2023

05/03/2023

05/02/2023

05/01/2023

04/29/2023

04/28/2023

04/27/2023

04/26/2023

04/25/2023

04/24/2023