Activity
From 05/18/2023 to 06/16/2023
06/16/2023
- 09:12 AM Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...
- > Marian: What work is needed to complete these tests? What is the status of the existing tests for table/table-hand...
- 04:17 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Committed 7416a to trunk as rev. 14626.
- 04:08 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have a potential fix for the remaining issues of the @TestWriteXmlFile.cls@, but are probably wrong:
- @BaseDataTy...
06/15/2023
- 04:49 PM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Code Review Task Branch 7416a Revision 14626
No objections. You can merge to trunk. - 10:40 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Greg Shah wrote:
> > Add a sensible flag to the configuration.
>
> Please use @sensitive@ instead of @sensible@.
... - 10:08 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- This sounds good to me. There are cases in which a query from a stack trace is basically a dynamic query. Therefore, ...
- 09:54 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- I've done two more changes that can be found on 7416a, rev. 14633:
* I've increased the number of characters printed... - 07:44 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Greg Shah wrote:
> > Add a sensible flag to the configuration.
>
> Please use @sensitive@ instead of @sensible@.
... - 07:34 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- > Add a sensible flag to the configuration.
Please use @sensitive@ instead of @sensible@. - 07:29 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Alexandru Lungu wrote:
> Add a @sensible@ flag to the configuration. If this is set, output only: @sql.substring(0, ... - 04:46 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Radu Apetrii wrote:
> If any ideas come to my mind, I will post updates.
I think we can adopt a naive way of cens... - 04:41 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Radu, please make sure you don't miss out the dirty databases as part of the SQL logging / query logging. I think the...
- 04:21 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Alexandru Lungu wrote:
> 1. For H2, we always proxy the statements through @TempTableDataSourceProvider@, so all...- 11:24 AM Bug #7412: PresortQuery ORDER BY has to many clauses
- Committed to 7026e, revision 14603.
- 10:44 AM Bug #7420: Optimize Cursor for scrolling AdaptiveQuery
- I wonder if our LTW is spoiled somehow by the GC. I mean, for a simple @setScrolling@, it is hard to believe that 750...
- 09:52 AM Bug #7420: Optimize Cursor for scrolling AdaptiveQuery
- I tested a customer application using @AdaptiveQueryTraceAspect@. My results for @setScrolling@ were ~5.5k calls with...
- 07:57 AM Bug #7420: Optimize Cursor for scrolling AdaptiveQuery
- Danut, can you take a look into this one?
It is quite bad that @AdaptiveQuery.setScrolling()@ works that slow. Ple... - 07:48 AM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
- I created a test using a temporary table with 50 fields, all being part of unique/non unique indexes. It consisted of...
- 05:18 AM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
- Eric Faulhaber wrote:
> @BaseRecord.getDirtyIndices@ already is invoked in several places in @Validation@. Can we re... - 05:29 AM Feature #7365: Avoid using reflection in generating BDT
- I added in @BaseDataTypeFactory@ a function @instantiate@ that also takes as a parameter the initial value that is to...
- 03:03 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Greg Shah wrote:
> Marian: Any idea why this reports as unserializable when the class itself is marked serializable?...
06/14/2023
- 02:44 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- @progress.lang.object@ fields are not serializable. This test:...
- 02:21 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > I have problems understanding the other failures in the @TestWriteXmlFile.cls@ method @writeFileInvalid@.
> This p... - 09:33 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have problems understanding the other failures in the @TestWriteXmlFile.cls@ method @writeFileInvalid@.
This porti... - 10:11 AM Feature #7363: Improve H2 Value caching, hashing and equals
- I added the changes.
Committed to 7363b_h2 revision 22. - 08:02 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
- Fixed an error and committed again on 7404a revision 14627.
- 05:48 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
- Committed to 7404a revision 14626.
- 04:43 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
- Created 7404a.
- 04:52 AM Bug #7412: PresortQuery ORDER BY has to many clauses
- The clause is added firstly at initialization which is correct since there can be multiple clauses that may need to b...
- 04:24 AM Bug #7412: PresortQuery ORDER BY has to many clauses
- -Danut, please prioritize this if you think it can be fixed by the end of this week. From my POV, there shouldn't be ...
- 04:42 AM Bug #7403 (WIP): Copy-temp-table with replace-mode should replace already inserted records
- 04:36 AM Feature #7365: Avoid using reflection in generating BDT
- Radu, if it doesn't take much time, please do a quick round-check of this issue and try to get this change in 7026e b...
06/13/2023
- 01:04 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Having this:...
- 11:16 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have implemented the changes, under rev 14621 on 4514a branch. There are still some other errors that the @TestWrit...
- 07:49 AM Bug #7421 (WIP): Check only the indexes that were changed when using Validation.checkMaxIndexSize
- 07:17 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Created 7416a.
- 06:07 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- I have two ideas here:
1. For H2, we always proxy the statements through @TempTableDataSourceProvider@, so all sta... - 06:31 AM Bug #7388: Create server configuration container for cache sizes
- *Committed 7388a.rev14619.* Added @CacheManager@ that reads the configuration cache sizes of classes and can be used ...
- 06:14 AM Feature #7323: Implement soft unique index in FWD-H2
- Radu, please focus on this after you finish the recent performance logging changes. I will like to give it a performa...
- 03:13 AM Feature #7363: Improve H2 Value caching, hashing and equals
- *Review of 7363b_h2 revision 21*
* @ValueByte.lowLevelEquals@ should use @((Byte) obj).byteValue()@ to stay consis...
06/12/2023
- 11:34 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Good.
Maciej: Please move ahead on this basis. - 11:27 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Greg Shah wrote:
> Rather than processing the error manager logging on the client, why not add the needed handling t... - 11:03 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Rather than processing the error manager logging on the client, why not add the needed handling to @DeferredLegacyErr...
- 10:56 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- @DeferredLegacyErrorException@ is missing the case for when is thrown from the FWD client. Originally this was meant...
- 10:36 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- We already catch @DeferredLegacyErrorException@ in @BlockManager.processBody()@ and we call @BlockManager.processLega...
- 10:25 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I am not exactly sure how to handle the @DeferredLegacyErrorException@ exception, when the client throws @302@ or @46...
- 10:17 AM Feature #7363: Improve H2 Value caching, hashing and equals
- I added the changes.
Commited to 7363b_h2 revision 21. - 05:39 AM Feature #7363: Improve H2 Value caching, hashing and equals
- *Review of 7363b_h2 revision 20.*
* Use space after @if@ keyword to separate from @(@ (according to H2 standard)
... - 09:57 AM Bug #7389 (Review): Make fast-copy statements cachable
- This is good. I am extracting your changes and add them to my profiling branch. I am curious of the improvement. Howe...
- 09:53 AM Bug #7389: Make fast-copy statements cachable
- Here is an update of the test from #7389-3:
|_. Type |_. Total |_. No append or loose mode |_. Append m... - 08:53 AM Bug #7389: Make fast-copy statements cachable
- *Committed 7389a.rev14594.* Fixed the problem mentioned in #7389-6. It was caused by missing records that were not co...
- 06:03 AM Bug #7389: Make fast-copy statements cachable
- *Review of 7389a.rev14593*
* I am OK with the changes.
* Please also consider @srcRecId@ when ruling our pk mapp... - 09:41 AM Feature #6371 (Test): implement SAVE CACHE statement
- 07:45 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Alexandru Lungu wrote:
> * *Ensure that no sensible data is logged (query parameters) in neither profiler*
I have b... - 04:38 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Radu, please make the documentation of #6970 sql profiler and #7416 query profiler (leveraging @DatabaseStatistics@) ...
- 03:13 AM Bug #7388: Create server configuration container for cache sizes
- Eric Faulhaber wrote:
> That being said, my experience with using @SoftReference@ is from several JVM generations ag...
06/09/2023
- 11:07 AM Bug #7388: Create server configuration container for cache sizes
- There may be some specific use cases where they make sense, but in general, I am not a huge fan of soft references, f...
- 10:48 AM Bug #7388: Create server configuration container for cache sizes
- Eric Faulhaber wrote:
> I don't think *every* setting should be configurable. Generally speaking, the developer will... - 10:15 AM Bug #7388: Create server configuration container for cache sizes
- Alexandru Lungu wrote:
> I am thinking bigger than only setting the size :)
Thinking beyond the current problem... - 02:55 AM Bug #7388: Create server configuration container for cache sizes
- Eric Faulhaber wrote:
> Routing this through a factory seems messy
I think it is easier to convey that a @CacheMa... - 10:52 AM Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
- We could do something similar for the dump name during conversion, if there is a unique constraint violation, so conv...
- 10:42 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > Is this intended that server does not see any information about the error when the error is thrown in the client ?
... - 06:16 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have hard time implementing the @302@ and @463@ errors in FWD, as expected by 4GL in case of @tests/dataset/TestWri...
- 10:01 AM Feature #7363: Improve H2 Value caching, hashing and equals
- Committed to 7363b_h2 revision 20.
- 06:58 AM Feature #7363: Improve H2 Value caching, hashing and equals
- I made a profiler to test the new caching method.
I updated the table with the average time of 5 runs for each value... - 09:11 AM Feature #5130 (Rejected): improve management of p2jpl.jar in deployment scripts
- I'm closing this as unneeded. We are moving all customers to the native UDFs and PL/Java is deprecated at this time....
- 03:31 AM Feature #7062: Direct access to H2 internals to solve basic queries
- Merged 7062c_h2 into FWD-H2 trunk as rev. 21.
The fix will be available with the next FWD-H2 upgrade.
06/08/2023
- 11:34 AM Bug #7388: Create server configuration container for cache sizes
- Alexandru Lungu wrote:
> Constantin Asofiei wrote:
> > Yes, reading this at server startup will solve this.
> >
... - 10:19 AM Bug #7388: Create server configuration container for cache sizes
- Alexandru Lungu wrote:
> This is strange ...
A hard reload of the browser page before adding a task history entry... - 06:58 AM Bug #7388: Create server configuration container for cache sizes
- This is strange ...
- 06:57 AM Bug #7388: Create server configuration container for cache sizes
- Constantin Asofiei wrote:
> Yes, reading this at server startup will solve this.
>
> The problem is that director... - 05:26 AM Bug #7388: Create server configuration container for cache sizes
- I already committed 7388a.rev14618, but will make the changes to read the cache size values at runtime.
- 04:55 AM Bug #7388: Create server configuration container for cache sizes
- Yes, reading this at server startup will solve this.
The problem is that directory is being read while another cod... - 04:26 AM Bug #7388: Create server configuration container for cache sizes
- Constantin Asofiei wrote:
> Please see #7398 for issues we have with the admin console, related to these static cons... - 04:02 AM Bug #7388: Create server configuration container for cache sizes
- Please see #7398 for issues we have with the admin console, related to these static constructors which read from dire...
- 03:47 AM Bug #7388 (WIP): Create server configuration container for cache sizes
- I created 7388a. Please commit your changes there. If everything is alright, I will do the merge.
- 03:44 AM Bug #7388: Create server configuration container for cache sizes
- I did a few changes as you suggested:
* Changed the name of a few cache nodes;
* Simplified the directory-reading c... - 11:12 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
- Ștefan, I will put you up-to-date with the FWD implementation of @copy-temp-table@:
*4GL logic*
@copy-temp-table@... - 08:01 AM Feature #7404 (WIP): Trasform replace-mode into append-mode when target table is empty
- 11:09 AM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
- Good idea. @BaseRecord.getDirtyIndices@ already is invoked in several places in @Validation@. Can we re-use the value...
- 08:46 AM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
- @Validation.checkMaxIndexSize@ is checking all indexes to detect if the maximum size was exceeded. This happens only ...
- 08:42 AM Bug #7421 (WIP): Check only the indexes that were changed when using Validation.checkMaxIndexSize
- 09:43 AM Feature #7363: Improve H2 Value caching, hashing and equals
- Ștefan, please prepare a commit on 7363b_h2 with your latest changes. Make sure you update #7363-11 accordingly. Also...
- 08:40 AM Bug #7420 (WIP): Optimize Cursor for scrolling AdaptiveQuery
- This is a task in regard to a hot-spot in @AdaptiveQuery.setScrolling()@. It is called 7506, but it takes 795ms own t...
- 08:13 AM Bug #7420 (Closed): Optimize Cursor for scrolling AdaptiveQuery
- 06:36 AM Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
- Greg Shah wrote:
> Why would the dump-name itself be the cause of a collision?
Well, the index is unique, and I ass... - 06:32 AM Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
- Why would the dump-name itself be the cause of a collision?
What happens in OE when this same @.df@ is processed? - 06:09 AM Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
- There is an unique index on the @_field._dump-name@, in the meta schema:...
- 06:07 AM Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
- If the 4GL doesn't care that the @DUMP-NAME@ is unique, why do we care? It seems like there is no compatibility requ...
- 05:13 AM Support #4550 (Closed): eliminate the need to place the p2jspi.jar in the JVM extension directory
- 05:08 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- @DatabaseStatistics@ is a good solution for query profiling on the FWD part. This was implemented before Hibernate an...
- 05:05 AM Feature #7416 (Closed): Reiterate DatabaseStatistics and leverage to other database profling tools
- 03:49 AM Bug #7412 (WIP): PresortQuery ORDER BY has to many clauses
- Danut, please investigate. The change should go to 7026e when ready.
06/07/2023
- 03:35 PM Bug #7388: Create server configuration container for cache sizes
- Dănuț Filimon wrote:
> I found the following to be configurable:
> * @BufferManager.convertedNames@, size is 10000;... - 09:07 AM Bug #7388: Create server configuration container for cache sizes
- I found the following to be configurable:
* @BufferManager.convertedNames@, size is 10000;
* @DynamicTablesHelper.c... - 03:13 AM Bug #7388: Create server configuration container for cache sizes
- Danut, please take time to navigate through the persistence / orm package of FWD and search for any cache which can h...
- 02:37 PM Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
- Constantin Asofiei wrote:
> If two tables have the same DUMP-NAME in the .df, the FWD can not start, as it enforces ... - 12:22 PM Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
- If two tables have the same DUMP-NAME in the .df, the FWD can not start, as it enforces an unique index in the meta t...
- 12:20 PM Bug #7413 (New): DUMP-NAME is not guaranteed to be unique in the .df
- 08:25 AM Feature #7365 (WIP): Avoid using reflection in generating BDT
- Radu, please check @BufferFieldImpl.changeValue@. Consider extending @BaseDataTypeFactory@ with a new method to handl...
- 08:24 AM Bug #7412: PresortQuery ORDER BY has to many clauses
- I have the following SQL generated in H2 for a @PresortQuery@:...
- 06:56 AM Bug #7412 (Closed): PresortQuery ORDER BY has to many clauses
- 08:24 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- The test failure @tests/dataset/TestTopNavQuery.cls@ method @TestSetInvalid@, throws 3 errors instead of 2.
The unex... - 04:04 AM Bug #7035 (Review): Extract query parameters from statically converted FQL
- Considering the JMX results of hit/miss before/after static query parameter extraction, I think this effort can be dr...
06/06/2023
- 11:17 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > I'm trying to re-test error handler suppoprt for MariaDB, but ca... - 10:29 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Igor Skornyakov wrote:
> I'm trying to re-test error handler suppoprt for MariaDB, but cannot create a database, get... - 09:55 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- I'm trying to re-test error handler suppoprt for MariaDB, but cannot create a database, getting the following errors ...
- 07:59 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Greg Shah wrote:
> It still adds the cost of UUID generation to the query. This still seems costly. Why not use a ... - 07:56 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- It still adds the cost of UUID generation to the query. This still seems costly. Why not use a sequence if you need...
- 07:45 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Greg Shah wrote:
> Are you saying that every guarded UDF execution requires a UUID to be generated? That seems expe... - 07:30 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Are you saying that every guarded UDF execution requires a UUID to be generated? That seems expensive.
- 05:05 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Eric Faulhaber wrote:
> Igor, as the Maria UDF implementation of the nested CAN-FIND error-handling is quite differe... - 03:12 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Rebased 6628a to the trunk rev.14613
Pushed up to revision 14614. - 09:43 AM Bug #7035: Extract query parameters from statically converted FQL
- I retested the changes on a customer application as you said and the results are almost the same.
|_. JMX ... - 05:36 AM Bug #7035: Extract query parameters from statically converted FQL
- I've redone the tests with your JMX. I get the following results in Cold/Warm runs on a customer application.
|_. ... - 08:41 AM Feature #7323: Implement soft unique index in FWD-H2
- *Review to 7323a, rev. 14587*
* I don't think we should always allow @soft_unique@ right from @Dialect@. Better exte... - 07:55 AM Feature #7323: Implement soft unique index in FWD-H2
- I am checking out this right now.
I will run some tests/profiling on my own and keep you updated.
Anyway, I fe... - 05:39 AM Bug #7389: Make fast-copy statements cachable
- *Committed 7389a.rev14593.* Added @FastCopyHelper.safeTableCopyNoMapping@ that doesn't use mapping.
At the moment, t...
06/05/2023
- 03:50 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Eric Faulhaber wrote:
> Igor, as the Maria UDF implementation of the nested CAN-FIND error-handling is quite differe... - 03:43 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Igor, as the Maria UDF implementation of the nested CAN-FIND error-handling is quite different than the PostgreSQL im...
06/02/2023
- 04:21 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Hi Ovidiu, yes that will work. Thanks
06/01/2023
- 06:12 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- What do you mean by _"we probably do not want to record the 14457 error at all?"_.
This is a normal error conditio... - 05:03 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- For the @tests/dataset/TestSetCallback.cls@ test @wrongRoutineNameClass@ and @wrightRoutineNameButWrongMethodDefiniti...
- 12:35 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- 6813c was merged to trunk rev 14596 and archived.
- 11:54 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- You can merge to trunk.
- 09:12 AM Feature #7365: Avoid using reflection in generating BDT
- I've added a check for @ObjectVar@ in @BaseDataTypeFactory@. The commit is on 7026e, rev. 14596.
- 08:30 AM Bug #7211: Several H2 connections for one single session
- I might be wrong on this, but I am not seeing tens of messages any more.
I navigated a large customer application ... - 08:30 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
- In FWD, @copy-temp-table@ append mode is faster as it can be resolved using fast-copy (INSERT INTO SELECT FROM).
T... - 08:11 AM Feature #7404 (Closed): Trasform replace-mode into append-mode when target table is empty
- 08:10 AM Bug #7403: Copy-temp-table with replace-mode should replace already inserted records
- This is quite a weird use-case:...
- 07:38 AM Bug #7403 (Closed): Copy-temp-table with replace-mode should replace already inserted records
- 07:37 AM Bug #7389: Make fast-copy statements cachable
- I have the following quite nice test-case. Please make sure the final answer is still @1 2@. -I am a bit surprised th...
- 07:08 AM Feature #7323: Implement soft unique index in FWD-H2
- *I've committed to 7323a, rev. 14587, and 7323a_h2, rev. 21.*
These changes target the addition of @VALIDATE@ and @S... - 04:47 AM Feature #7323: Implement soft unique index in FWD-H2
- Radu, please commit this changes to 7323a. I would like to do a second test on a customer application. Also, please l...
- 04:45 AM Feature #6630 (Review): optimize return of table parameter
- Usually, temp-tables won't hold 10.000 records from what I have seen. We should rely on the 100/1000 tests with 5/10 ...
- 04:35 AM Bug #7334 (Review): Reclaim used sessions to improve performance
- I am quite pleased with your results and my performance tests (-2.7%).
However, as this is quite a change on the s... - 04:03 AM Bug #7334: Reclaim used sessions to improve performance
- Alexandru Lungu wrote:
> Danut, please focus on finishing the tests here. I will like to do some last checks and mer...
05/31/2023
- 03:24 PM Feature #7037 (Test): remove dirty share manager
- 03:20 PM Feature #7037: remove dirty share manager
- 7037b has been merged into the trunk as bzr revision 14593.
- 02:43 PM Feature #7037: remove dirty share manager
- Rebased task branch 7037b from FWD trunk revision 14592.
- 02:11 PM Feature #7037: remove dirty share manager
- Go ahead and merge now.
- 02:08 PM Feature #7037: remove dirty share manager
- From my point of view, yes.
- 01:51 PM Feature #7037: remove dirty share manager
- Should I rebase and commit?
- 01:48 PM Feature #7037: remove dirty share manager
- Greg Shah wrote:
> Eric: We are blocked on your code review.
How so? My code review was done in #7037-50. Everyth... - 10:13 AM Feature #7037: remove dirty share manager
- Eric: We are blocked on your code review.
- 12:38 PM Feature #7365: Avoid using reflection in generating BDT
- I think a type is missing, I get this in a customer app:...
- 11:09 AM Bug #7334: Reclaim used sessions to improve performance
- The changes are really good, providing a -2.7% performance increase. I didn't found any issues while testing.
Danut,... - 03:53 AM Bug #7334: Reclaim used sessions to improve performance
- Rebased 7334a to trunk / rev. 14592 7334a is now at rev. 14596
I am doing a test/profiling round with the current ... - 10:37 AM Feature #7363: Improve H2 Value caching, hashing and equals
- I updated the table according to the new changes.
I changed @get@ method in @ValueBytes@ and @ValueString@, @fromNan... - 08:59 AM Feature #7363: Improve H2 Value caching, hashing and equals
- Some remarks:
* @Bytes@, @String@ and @Date@ as I understand are still WIP
* @Date@ has an interesting static AP... - 07:12 AM Feature #7363: Improve H2 Value caching, hashing and equals
- I started with the @ValueStringIgnoreCase@ and everything worked like you suggested. @Value.cache(int type, Object lo...
- 08:36 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Greg Shah wrote:
> Are you still trying to get 6813c into trunk?
I've made the cleanup changes and rebased from tru... - 07:27 AM Feature #7323: Implement soft unique index in FWD-H2
- This looks OK to me, go ahead with the implementation.
Please do a second check for the @flush@ method. Is there any... - 07:17 AM Feature #7323: Implement soft unique index in FWD-H2
- I've added the @SOFT_UNIQUE@ and @VALIDATE@ keywords to both FWD and FWD-H2 without affecting the current behavior.
... - 07:26 AM Feature #7194: Avoid generating an ORDER-BY clause if not required
Alexandru Lungu wrote:
> Radu, please post your attempt on #7194-16 here (the test-case). AFAIK, you couldn't ge...- 02:47 AM Feature #7194: Avoid generating an ORDER-BY clause if not required
- Radu, please post your attempt on #7194-16 here (the test-case). AFAIK, you couldn't generate two records with the sa...
- 07:01 AM Feature #6630: optimize return of table parameter
- I redesigned my test case and profiled both @AdaptiveQuery@ and @PreselectQuery@. I used a temp-table with 100 fields...
- 06:48 AM Bug #7389 (WIP): Make fast-copy statements cachable
- This basically means that we should focus on the append mode: this is the one that usually triggers @MASTER_PK_MAPPIN...
- 05:22 AM Bug #7389: Make fast-copy statements cachable
- I tested a large customer application (~30 minutes) and managed to gather the following data about the number and typ...
- 03:17 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- override the @NAME@ attribute and you will see that it differs. I did this testing in 4GL and FWD code in the getter ...
05/30/2023
- 11:28 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Sorry, I used the fields, but this is also valid for datasets. Consider the following lines appended to my previous t...
- 11:24 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Not sure that is the right thing to do. I remember writing that intentionally. Here is the testcase:...
- 10:20 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have just committed a change to @4514a@ FWD branch, which fixes the @tests/dataset/TestSerializeName.cls@ failure.
... - 07:56 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Noted. I will leave the TestReadXml* tests for now and continue with the rest of failures.
- 07:42 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> Fine, but that does not change the fact that the xfer testcases fail in FWD and does not in ... - 07:36 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Fine, but that does not change the fact that the xfer testcases fail in FWD and does not in 4GL 11.6. I will confirm ...
- 05:20 AM Feature #7076 (Review): make CAN-FIND avoid hydration
- I guess this can be rejected now?
Eric, AFAIK you are handling lazy hydration. @CAN-FIND@ doesn't do any kind of ... - 05:17 AM Feature #6630 (WIP): optimize return of table parameter
- This makes sense to me. @TemporaryBuffer.loopDelete@ can't ever interact with other business logic that trigger recor...
- 04:49 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables
- This can be closed.
- 03:57 AM Feature #7363: Improve H2 Value caching, hashing and equals
- Ștefan, please provide a (comprehensive) report on your progress here. Include what have been implemented and what is...
- 02:41 AM Feature #6442: missing encoding/collation features
- Ovidiu Maxiniuc wrote:
> * @for each t1 where t1.f1 > 'a'@
Just realised @>@ is used for where so both @a@ and @b... - 02:39 AM Feature #6442: missing encoding/collation features
- Ovidiu Maxiniuc wrote:
> Marian,
>
> Let's assume we have a field @t1.f1@ in a permanent table/database with a co...
05/29/2023
- 06:43 PM Feature #6442: missing encoding/collation features
- Thank you. I committed the gap markings for CODEPAGE-related options/functions as revision 14593.
- 04:42 PM Feature #6442: missing encoding/collation features
- Ovidiu Maxiniuc wrote:
> Boris, is there a branch for this task where I could update the gap markings?
There's a ... - 11:13 AM Feature #6442: missing encoding/collation features
- Marian,
Let's assume we have a field @t1.f1@ in a permanent table/database with a configuration where @b@ sorts hi... - 02:31 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej,
IIRC, when I added dataset and schema reading support I handled the errors as they occurred form my testcase... - 01:59 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- For the @Unable to convert XML to native data type for field '<field>' in table '<table>'. (13052)@ i am thinking abo...
- 01:35 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- The @tests/dataset/TestReadXmlFile.cls@ method @invalidFileIncompleteTags@ should fail with @13064@ instead of @13055...
- 12:57 PM Bug #7351 (Closed): Reduce SQL query string size of an INSERT INTO SELECT FROM
- 05:20 AM Bug #7351 (Test): Reduce SQL query string size of an INSERT INTO SELECT FROM
- Merged 7026d to trunk as rev. 14587.
Side-issues can be discussed in #7382 and #7389.
This can be closed. - 11:58 AM Feature #7062: Direct access to H2 internals to solve basic queries
- Alexandru Lungu wrote:
> Created 7062c_h2 and fixed the NPE.
> I didn't expect to have a direct-access on a table ... - 09:40 AM Feature #7062: Direct access to H2 internals to solve basic queries
- Created 7062c_h2 and fixed the NPE.
I didn't expect to have a direct-access on a table with invalid name. This is s... - 08:41 AM Feature #7062: Direct access to H2 internals to solve basic queries
- Alexandru, we need NPE protection here:...
- 11:53 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Greg Shah wrote:
> I agree this is a good idea. Please open a task for it.
Created #7390 - 09:34 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- I agree this is a good idea. Please open a task for it.
- 10:31 AM Bug #7367: disable TriggerTracker for TemporaryBuffer
- Alexandru Lungu wrote:
> Merged 7026d to trunk as rev. 14587.
That makes sense. I attempted to do a review of the 7... - 09:46 AM Bug #7367 (Test): disable TriggerTracker for TemporaryBuffer
- Merged 7026d to trunk as rev. 14587.
- 09:58 AM Bug #7330 (Closed): Increase psCache size
- 03:27 AM Bug #7330 (Test): Increase psCache size
- Merged 7026d to trunk as rev. 14587.
Created #7388 for further work on cache size configurations.
This can be closed. - 09:51 AM Bug #7336 (Closed): optimize DmoMeta.byLegacyName
- 02:40 AM Bug #7336 (Test): optimize DmoMeta.byLegacyName
- 7026d was merged to trunk as rev. 14587. This can be closed.
- 09:43 AM Bug #7329 (Test): improve FieldReference resolution of getter/setter/extent accessors
- Merged 7026d to trunk as rev. 14587.
This can be closed. - 05:31 AM Bug #7358 (Test): Optimize Session.invalidateRecords
- Merged 7026d to trunk as rev. 14587.
Eric Faulhaber wrote:
> Ovidiu, you are right: I don't want to use @Class<?>... - 05:19 AM Bug #7389: Make fast-copy statements cachable
- Fast copy statements (INSERT INTO [...] SELECT FROM [...]) are quite often, especially as we have multiplex on tables...
- 04:54 AM Bug #7389 (Closed): Make fast-copy statements cachable
- 03:25 AM Bug #7388: Create server configuration container for cache sizes
- Make FWD caches configurable in size. As a place to start, consider only persistent related caches by adding a @persi...
- 03:17 AM Bug #7388 (Test): Create server configuration container for cache sizes
- 03:03 AM Feature #7194: Avoid generating an ORDER-BY clause if not required
- There is an idea of a test-case that troubled my mind for a while :)
Can you check if we can make @FQLPreprocessor... - 02:41 AM Bug #7321 (Test): Improve FWD-H2 wildcard projection
05/27/2023
- 08:52 AM Feature #6442: missing encoding/collation features
- Greg Shah wrote:
> The AVM @-cpcoll@ sets the 4GL language runtime collation. It may affect temp-tables but not the... - 05:23 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Constantin Asofiei wrote:
> A simple code using @XmlStreamReader@ to just read the 90MB .ast file takes ~35% less th... - 05:19 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Greg, another thought, which probably should be in its own task: it takes ~1.3 seconds to load a 90MB .ast file on my...
05/26/2023
- 06:18 PM Feature #6442: missing encoding/collation features
- Eric Faulhaber wrote:
> As I dug into the code to see how we would implement the temp-table @COLUMN-CODEPAGE@ opti... - 04:58 PM Feature #6442: missing encoding/collation features
- The AVM @-cpcoll@ sets the 4GL language runtime collation. It may affect temp-tables but not the database.
My und... - 04:15 PM Feature #6442: missing encoding/collation features
- AFAIK, in OE, collation tables are referenced from a configuration file, @convmap.dat@, which the DBA sets up (I don'...
- 02:32 PM Feature #6442: missing encoding/collation features
- That's doable. I will look into that.
But maybe first a more general question: where does the collation informatio... - 01:56 PM Feature #6442: missing encoding/collation features
- Ovidiu Maxiniuc wrote:
> There is currently no method to extract these information from SQL. The problem is that e... - 04:38 PM Bug #6475: double-check and fix any read/write-xml/json issues at table and dataset
- Before refactoring the xfer tests to use ABLUnit, there were @dataset/[static|dynamic]/methods/[write|read]_[xml|json...
- 02:15 PM Bug #6475: double-check and fix any read/write-xml/json issues at table and dataset
- Constantin Asofiei wrote:
> This task is to confirm all serialization options at dataset, table and fields (like @se... - 03:34 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Greg Shah wrote:
> Are you still trying to get 6813c into trunk?
Not yet, next week probably. - 03:33 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Are you still trying to get 6813c into trunk?
- 01:39 PM Feature #6444 (Closed): dataset improvements
- 10:57 AM Feature #7379 (Test): cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- Branch 7379a was merged to trunk rev 14588 and archived. All changes intended in current task are in the branch. If...
- 10:56 AM Feature #7366: improve performance of buffer.fill
- Branch 7366a was merged to trunk rev 14589 and archived. What's left is a possible improvement for extent fields.
- 06:24 AM Feature #7194: Avoid generating an ORDER-BY clause if not required
- Alexandru Lungu wrote:
> Can you profile some dummy testcases with/without the change?
To be honest, the differenc... - 06:21 AM Feature #7323: Implement soft unique index in FWD-H2
- Radu, I created 7323a_h2 and 7323a.
Please implement SOFT_UNIQUE and VALIDATE keywords. Focus first on:
* Syntact... - 04:11 AM Bug #7351 (Review): Reduce SQL query string size of an INSERT INTO SELECT FROM
- 7026d was rebased and merged into 7156a as patch. ETF tests passed; everything looks right.
For the @uid@ of fast ... - 03:54 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- I took a look at @UnclosablePreparedStatement@ and gathered the following data:
|_. ... - 03:20 AM Bug #7367 (Review): disable TriggerTracker for TemporaryBuffer
- 03:20 AM Bug #7367 (WIP): disable TriggerTracker for TemporaryBuffer
- This reached 7156a. 7026d was rebased. Testing passed.
05/25/2023
- 02:47 PM Feature #6720: lazy hydration
- Eric,
Maybe a bit of history here helps. The code from @SQLQuery.hydrateRecord()@ (now @SQLQuery.hydrateRecordImpl()... - 11:57 AM Feature #6720: lazy hydration
- OK, thank you. I've been reworking that method a lot and this didn't look right to me. I just wanted to know that the...
- 11:36 AM Feature #6720: lazy hydration
- Eric, I don't recall exactly which one, but this case of having a PK in @hydrateImpl@ is originating from a kind of A...
- 11:03 AM Feature #6720: lazy hydration
- Constantin: in @SQLQuery.hydrateRecordImpl@ (line 834 in trunk rev 14585), we are checking if the current result set ...
- 02:03 PM Bug #6458 (Closed): ensure that OO expressions resolve to query substitution parameters, like han...
- 01:20 PM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- Merged as revision 14586.
- 11:37 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- Go ahead with the merge.
- 11:37 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- Thanks, looks good to merge to trunk.
- 11:14 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- Seems to work just as well:...
- 10:47 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- Please do some tests with an instance function instead of static, parameters (simple vars, more complex like a functi...
- 10:40 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- The 4GL code was simple like:...
- 08:38 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- I'd like to get this merged to trunk, today if possible.
After posting as requested by Constantin, please rebase f... - 02:54 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- The change looks good. Please post a sample of the 4GL and generated code where the OO method is involved.
- 11:03 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
- I do not think we should guess. The build script should know whether it has added the @ddl/@ folder into (a) applicat...
- 09:28 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
- Greg Shah wrote:
> > The latter is done using @psql@ utility and it requires the content of @ddl/@ to be accessible ... - 08:52 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
- > The latter is done using @psql@ utility and it requires the content of @ddl/@ to be accessible from file system.
... - 09:11 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
- Task branch 4722a contains a couple of changes which allows the import process to use less (if any) external resource...
- 09:13 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- Danut, note that 7026d was rebased with latest trunk. Please update.
- 09:11 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- *Committed 7026d/rev.14580*. Added a flag that enables uid, it's usage is now disabled by default.
After doing a m... - 05:21 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- *Review of 7351a_h2/rev.18*
I am OK with the changes.
Rebased and merged to FWD-H2 trunk as rev. 20. 7351a_h2 was... - 04:17 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- Please do a memory check on @psCache@. That is, please check if the memory is less now than before on a large custome...
- 08:34 AM Feature #7194: Avoid generating an ORDER-BY clause if not required
- The changes are tested and OK to me.
However, I can't isolate a performance increase for this change (it is either... - 08:11 AM Feature #7382 (WIP): Check performance of delete from vs drop table in H2
- This task targets a huge performance difference between @DROP TABLE@ and @DELETE FROM@ in H2 (#7351-6).
The point he... - 08:05 AM Feature #7382 (Closed): Check performance of delete from vs drop table in H2
- 08:05 AM Feature #7365 (Review): Avoid using reflection in generating BDT
- I included this change with my FWD-H2 bump to version 1.20-trunk.
Therefore, I committed 7026d/rev. 14579 addressi... - 07:45 AM Feature #7365: Avoid using reflection in generating BDT
- Radu, I've looked at BaseDataTypeFactory and:
* please sort all the conditions alphabetically by the class name
* ... - 04:24 AM Feature #7365: Avoid using reflection in generating BDT
- Done, I moved the changes. They are on 7026d, rev. 14577.
- 04:22 AM Feature #7365: Avoid using reflection in generating BDT
- Radu, I will review the changes once on 7026d.
- 05:17 AM Bug #7367: disable TriggerTracker for TemporaryBuffer
- I've done some in-depth testing with a large customer application and I could not find any regression(s).
Since the ... - 04:25 AM Bug #7367: disable TriggerTracker for TemporaryBuffer
- Alexandru Lungu wrote:
> Radu, can you do the changes from #7367-1 and #7367-3 over 7026d and do an in-depth testing... - 04:24 AM Bug #7367: disable TriggerTracker for TemporaryBuffer
- Radu, can you do the changes from #7367-1 and #7367-3 over 7026d and do an in-depth testing of a large customer appli...
- 04:52 AM Bug #7334: Reclaim used sessions to improve performance
- Danut, as discussed, your tests may be spoiled by the fact that each user is doing lots of small transactions on the ...
- 04:45 AM Bug #7211 (WIP): Several H2 connections for one single session
- 08:57 PM Feature #6442: missing encoding/collation features
- Me either.
Currently the customer is free to pick the encoding/collation he desires for SQL database, based on the...
05/24/2023
- 05:58 PM Bug #6458 (Review): ensure that OO expressions resolve to query substitution parameters, like han...
- Finally resolved and pushed as revision 6458a/14553. Please, review.
Thank you all for help with this one! - 05:15 PM Feature #7365: Avoid using reflection in generating BDT
- Alexandru Lungu wrote:
> Radu. I know we've discussed this today, but I think is for the best to move this to 7026d.... - 08:53 AM Feature #7365: Avoid using reflection in generating BDT
- Radu. I know we've discussed this today, but I think is for the best to move this to 7026d. I intent to have one sing...
- 05:59 AM Feature #7365: Avoid using reflection in generating BDT
- As suggested, I created @BaseDataTypeFactory@ and I replaced all the occurrences that resolve to a @BaseDataType@ ins...
- 03:23 PM Feature #6442: missing encoding/collation features
- Boris Schegolev wrote:
> Just a quick question about design: are collation/codepage available as some database confi... - 01:43 PM Feature #7379: cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- Eric, my current changes which -affect- rely on direct record access are in #7366, not in this task.
- 01:24 PM Feature #7379: cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- The setter is this:...
- 01:23 PM Feature #7379: cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- Eric Faulhaber wrote:
> Constantin, the only place I see @OrmUtils.getField@ used currently is in 3 locations in @Re... - 01:20 PM Feature #7379: cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- Constantin, the only place I see @OrmUtils.getField@ used currently is in 3 locations in @RecordBuffer.copy@. Are you...
- 12:54 PM Feature #7379: cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- Constantin Asofiei wrote:
> Eric, I'm using @OrmUtils.setField@ and @OrmUtils.getField@, not direct @data@ array acc... - 12:20 PM Feature #7379: cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- 7379a rev 14586 adds cache for @propertyIndexes@. @TableMapper@ now is called only when there is a cache miss; so, e...
- 12:02 PM Feature #7379: cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- Eric, I'm using @OrmUtils.setField@ and @OrmUtils.getField@, not direct @data@ array access. Is this of concern?
A... - 11:22 AM Feature #7379: cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- Please note that directly accessing the @BaseRecord.data@ buffer is going to go badly in cases of the FIELDS clause a...
- 09:39 AM Feature #7379: cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- Ovidiu Maxiniuc wrote:
> My solution will not require translation at all: the @buffer1@ from my diagram will access ... - 09:35 AM Feature #7379: cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- My solution will not require translation at all: the @buffer1@ from my diagram will access the data of @buffer2@ usin...
- 08:26 AM Feature #7379: cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- Ovidiu, the binding maps is not only for accessing the record datum. This info is used when translating queries, too...
- 12:12 PM Feature #7366: improve performance of buffer.fill
- rebased branch 7366a from trunk rev 14584 - new rev 14586.
- 10:28 AM Feature #7366: improve performance of buffer.fill
- I was pretty sure if you use ...
- 01:37 AM Feature #7366: improve performance of buffer.fill
- Ovidiu, BEFORE-TABLE is not involved during FILL, as TRACKING-CHANGES is not allowed for FILL. So there is no need m...
- 10:07 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- Dănuț Filimon wrote:
> I had no problems testing a customer application for ~20 minutes with 7026d/rev.14576 and NEV... - 09:57 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- I had no problems testing a customer application for ~20 minutes with 7026d/rev.14576 and NEVER_RECOMPILE property.
- 09:20 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- *Committed 7026d/rev.14576*. Added the changes from 7351a rev. 14576 & 14577 without the NEVER_RECOMPILE property.
- 08:47 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- In fact, please commit everything there except the NEVER_RECOMPILE flag in FWD for temp tables. You will commit that ...
- 08:45 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- Danut, can you port this changes to 7026d and do the tests with it? 7026d isn't rebased yet to use the latest logging...
- 07:25 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- *Committed 7351a_h2/rev.18*. Added @NEVER_RECOMPILE@ property.
*Committed 7351a/rev.14577*. Fixed uid usage, replace... - 04:21 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- *Review of 7351a/rev.14576*
* I don't think we need to lazily initialize @uid@. It is ok to have it only once as i... - 08:55 AM Feature #7363: Improve H2 Value caching, hashing and equals
- I changed @toLowerCase().hashCode()@ into @StringHelper.hashCodeCaseInsensitive()@ in @P2JField.computeHash()@.
Co... - 05:56 AM Feature #7363 (WIP): Improve H2 Value caching, hashing and equals
- > I also changed P2JField.computeHash to use hashCodeCaseInsensitive.
Stefan, where did you committed this change?
... - 03:28 AM Feature #7363 (Review): Improve H2 Value caching, hashing and equals
- *Review of 7363a_h2 revision 18*
I am OK with the changes.
Profiled and got a -0.6% improvement on a customer app... - 03:10 AM Feature #7363 (WIP): Improve H2 Value caching, hashing and equals
- I added @hashCodeCaseInsensitive@ in StringUtils and used it in @ValueStringIgnoreCase.hashCode@.
I also changed @P2... - 05:40 AM Bug #7321 (Review): Improve FWD-H2 wildcard projection
- I am OK with the changes.
I also included some improvements on calling @Select.isEverything@ faster (iterate the exp... - 04:08 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors
- Alexandru Lungu wrote:
> Review of 7026d/rev. 14574
> I am OK with the changes. Have you tested the latest version ... - 03:40 AM Bug #7329 (Review): improve FieldReference resolution of getter/setter/extent accessors
- Review of 7026d/rev. 14574
I am OK with the changes. Have you tested the latest version (rev. 14574) of 7026d with a...
05/23/2023
- 07:30 PM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Code Review Task Branch 6813c Revision 14584
It's good. - 10:32 AM Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Created task branch 6813c from trunk rev 14583 . This contains:
* avoid recursion in @AnnotatedAst.duplicate@
* in... - 06:08 PM Feature #7379: cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- Constantin Asofiei wrote:
> Is @dmoInfo.getFields(false)@ using the same order as @getAllLegacyFieldInfo@?
Actually... - 03:51 PM Feature #7379: cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- And there is also @propertyIndexes@ used in @ReferenceProxy.bind@, which can be cached.
- 03:47 PM Feature #7379: cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- Thanks, Ovidiu. I just noticed that @TableMapper.getAllLegacyFieldInfo@ is still unconditionally executed.
Is @dm... - 03:40 PM Feature #7379: cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- I think we already have (at least the BOUND_PROPERTIES). The method to call is @defBuffer/boundBuffer.dmoInfo.getFiel...
- 10:40 AM Feature #7379: cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- Created task branch 7379a from trunk rev 14584.
Rev 14585 adds a cache for the DMO property info required by @Temp... - 10:31 AM Feature #7379 (Test): cache the def and bound DMO property info in TemporaryBuffer$ReferenceProxy
- 04:46 PM Feature #7366: improve performance of buffer.fill
- Constantin Asofiei wrote:
> Created branch 7366a from trunk rev 14573.
>
> 7366a/14574 contains a first attempt a... - 10:15 AM Feature #7366: improve performance of buffer.fill
- 7366a rev 14575 contains the changes for FILL performance improvements. Extent is not added yet.
- 12:37 PM Feature #7037: remove dirty share manager
- > Will you be rebasing this branch soon?
Rebased task branch 7037b from FWD trunk revision 14584. - 12:06 PM Feature #7037: remove dirty share manager
- > Why are we not initializing dirtyContext to null in this method? Is it because we need to differentiate for the cro...
- 10:06 AM Feature #7037: remove dirty share manager
- Roger Borrello wrote:
> Thanks, Stanislav. My application loaded up fine, but I don't think the latest revision of 7... - 09:09 AM Feature #7037: remove dirty share manager
- Thanks, Stanislav. My application loaded up fine, but I don't think the latest revision of 7037b contains the 7277a m...
- 05:29 AM Feature #7037: remove dirty share manager
- > Is the change to the directory ...
Roger, you can add these five parameters under @persistence@ section:... - 10:31 AM Bug #7358: Optimize Session.invalidateRecords
- Ovidiu, you are right: I don't want to use @Class<?>@ instead of @String@ with @RecordIdentifier@. We need to elimina...
- 09:45 AM Feature #7365: Avoid using reflection in generating BDT
- Radu, please mark this your top priority. The bottle-neck is visible here, so we may want to see it finished asap. Th...
- 08:42 AM Bug #7367: disable TriggerTracker for TemporaryBuffer
- Ovidiu Maxiniuc wrote:
> Back to our code. The change looks fine, but the two conditionals must be adapted. The @doF... - 07:56 AM Bug #7334: Reclaim used sessions to improve performance
- *Committed 7334a/rev.14579*. Applied the changes mentioned in #7334-17.
- 06:22 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors
- Alexandru Lungu wrote:
> The changes are functionally good. I have only some minor suggestions
> * In @set@, can yo... - 06:11 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- *Committed 7351a/rev.14576*. Reduced sql size of the @INSERT INTO [...] SELECT FROM [...]@ statement by using wildcar...
- 05:59 AM Bug #7319: Fix adaptive query test suite from testcases
- Alexandru Lungu wrote:
> Radu, can you post a patch here of the multi-table lazy fix? Maybe some of the tests are st... - 05:53 AM Bug #7319: Fix adaptive query test suite from testcases
- Radu, can you post a patch here of the multi-table lazy fix? Maybe some of the tests are still failing because we dis...
05/22/2023
- 06:29 PM Feature #7037: remove dirty share manager
- Roger Borrello wrote:
> Stanislav Lomany wrote:
> > Dirty sharing has been disabled in the directory for Hotel GUI ... - 06:09 PM Feature #7037: remove dirty share manager
- Code review 7037b, revs 14573-14574:
Everything looks good, but I have some questions, to make sure I understand s... - 05:49 PM Feature #7037: remove dirty share manager
- Stanislav Lomany wrote:
> Dirty sharing has been disabled in the directory for Hotel GUI (rev 264) and Hotel ChUI (r... - 03:38 PM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- It is parsed because it is referenced elsewhere. As I've noted previously via email, just because it is parsed doesn...
- 03:15 PM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- Constantin Asofiei wrote:
> You must include @Foo.cls@ in your conversion list.
But it's already reported as bein... - 03:10 PM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- You must include @Foo.cls@ in your conversion list.
- 03:08 PM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- I am running a simple conversion for OO mode. The class itself is simple:...
- 10:14 AM Bug #7367: disable TriggerTracker for TemporaryBuffer
- Alexandru Lungu wrote:
> Hmm, I edited my comment to use @== null@ seconds after posting :)
That make sense. I rev... - 09:47 AM Bug #7367: disable TriggerTracker for TemporaryBuffer
- Ovidiu Maxiniuc wrote:
> Sorry, you are right, I did not see you changed the @!=@ into @==@, not only @&&@ into @||@... - 09:45 AM Bug #7367: disable TriggerTracker for TemporaryBuffer
- Ovidiu Maxiniuc wrote:
> Alex,
> I do not think that is the good condition. If @targetBuffer.getTriggerTracker()@ ... - 09:43 AM Bug #7367: disable TriggerTracker for TemporaryBuffer
- Alex,
I do not think that is the good condition. If @targetBuffer.getTriggerTracker()@ is null then the second oper... - 09:27 AM Bug #7367: disable TriggerTracker for TemporaryBuffer
- In @setCurrentRecord@, there is the following condition (line 11422):...
- 05:01 AM Bug #7367: disable TriggerTracker for TemporaryBuffer
- I recall seeing @ASSIGN@ trigger checks for when we were executing copy-temp-table (fast or not). I don't know if the...
- 09:03 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors
- *Review of 7026d, rev. 14570*
The changes are functionally good. I have only some minor suggestions
* In @set@, c... - 07:19 AM Bug #7371: proper handling of exception case in cacheExpired
- This task is about incorrect handling of the @PersistenceException@ in @orm/Session.cacheExpired()@.
Eric Faulhab... - 07:15 AM Bug #7371 (New): proper handling of exception case in cacheExpired
- 06:25 AM Feature #7365 (WIP): Avoid using reflection in generating BDT
- 06:21 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables
- Merged 7355a to trunk as rev. 14577. Archived 7355a.
- 06:12 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables
- Doing the rebase now. Planning to merge asap.
- 06:11 AM Bug #7334: Reclaim used sessions to improve performance
- Rebased 7334 to latest trunk. 7334a is now at rev. 14578.
- 03:13 AM Bug #7334: Reclaim used sessions to improve performance
- *Review of 7334a*
* Place the opening brace of @PersistenceConsumer@ on the next line.
* I think you can make the... - 02:37 AM Bug #7334: Reclaim used sessions to improve performance
- I think we should insist on the multi-user test-case. We should see why we don't have performance improvements there....
- 03:54 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- > At the moment, I only modified FastCopyHelper.copyTable to generate such statement. I still need to test append and...
- 03:00 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- Alexandru Lungu wrote:
> * compare on a dummy FWD-H2 the time difference between dropping a table and deleting all o...
05/20/2023
- 09:45 AM Bug #7367: disable TriggerTracker for TemporaryBuffer
- A session trigger can't be registered for a temp-table (I also double-checked in OE). This means that @RecordBuffer....
- 09:40 AM Bug #7367 (Closed): disable TriggerTracker for TemporaryBuffer
- 09:08 PM Bug #7358: Optimize Session.invalidateRecords
- I have reviewed revision 14571 of 7026d. I totally agree with the code. Good job!
If there is space for more impro...
05/19/2023
- 03:01 PM Feature #7366: improve performance of buffer.fill
- Created branch 7366a from trunk rev 14573.
7366a/14574 contains a first attempt at improving performance of @Buffe... - 02:36 PM Feature #7366 (WIP): improve performance of buffer.fill
- 02:33 PM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables
- OK, it can go after 7241a.
- 02:28 PM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables
- Greg Shah wrote:
> Can we merge this to trunk?
Is OK from my part. - 02:02 PM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables
- Can we merge this to trunk?
- 06:59 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables
- Alexandru Lungu wrote:
> Constantin, can you confirm that your scenario which caused #7355-1 is fixed now?
Confirme... - 06:35 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables
- I've run the changes across customer applications and the individual set of tests (without issues). The core of the c...
- 06:22 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables
- Do we need any additional review or testing before merging to trunk?
- 03:00 AM Bug #7355 (Test): regression in row structure calculation for DATETIME-TZ when join is used on te...
- Done. Committed as 7156a/rev. 14567.
- 02:22 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables
- Alexandru Lungu wrote:
> This is good; I don't have to rebase it myself now :) As the tests are OK and customer appl... - 02:21 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables
- Ovidiu Maxiniuc wrote:
> Then just reconvert and you'll get the DMO using expanded fields.
Got it! The changes ar... - 09:02 PM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables
- Alexandru,
I mistaken the 7355a with another branch and I have just rebased it to latest trunk. Since I am doing the... - 09:41 AM Feature #7365: Avoid using reflection in generating BDT
- @TextOps.instantiate@ is a hot-spot in our profiling. This is because it uses @getDeclaredConstructor().newInstance()...
- 09:38 AM Feature #7365 (Closed): Avoid using reflection in generating BDT
- 09:36 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- Danut, I think I have a better idea.
My concern is that dropping tables like @MASTER__PK__MAPPING_1@ will make th... - 02:59 AM Bug #7351: Reduce SQL query string size of an INSERT INTO SELECT FROM
- Danut, if you already do modifications to the @FastCopyHelper@, I will request more things here:
* Fix the javadoc a... - 09:08 AM Feature #7363: Improve H2 Value caching, hashing and equals
- One last comment here. If you already plan to do some changes to @ValueStringIgnoreCase@, also consider optimizing @V...
- 03:14 AM Feature #7363: Improve H2 Value caching, hashing and equals
- The same issue we have in FWD, @P2JField.computeHash@. Please use @hashCodeCaseInsensitive@ there, instead of @.toLow...
- 02:33 AM Feature #7363: Improve H2 Value caching, hashing and equals
- Recently we enabled support for case-insensitive character values in H2 using @ValueStringIgnoreCase@.
However, @... - 02:24 AM Feature #7363 (Closed): Improve H2 Value caching, hashing and equals
- 06:22 AM Feature #7066: Implement multi-table indexed query in H2
- While working with #7252, I found a much easier way to obtain the index name, which is done automatically instead of ...
- 05:43 AM Bug #7358 (Review): Optimize Session.invalidateRecords
- Committed implementation of the idea from #7358-1 to 7026d as rev. 14571.
The total time improvement is of *-5.2%* o... - 05:34 AM Bug #7364: Build a full test-suite for fast copy-temp-table
- There were many recent changes for @FastCopyHelper@ and some are still pending. However, we don't have such a complet...
- 03:57 AM Bug #7364 (New): Build a full test-suite for fast copy-temp-table
- 05:21 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors
- I've refactored the code as you suggested. The changes are on 7026d, rev. 14570.
I found no issues while testing (w...
05/18/2023
- 04:00 PM Feature #7037: remove dirty share manager
- Dirty sharing has been disabled in the directory for Hotel GUI (rev 264) and Hotel ChUI (rev 86).
- 10:44 AM Feature #7037 (Review): remove dirty share manager
- 10:43 AM Feature #7037: remove dirty share manager
- Eric: Please review.
- 10:43 AM Feature #7037: remove dirty share manager
- Yes, it's safe.
- 10:42 AM Feature #7037: remove dirty share manager
- Does it default to the current approach? In other words, it won't cause changes in behavior for existing application...
- 10:41 AM Feature #7037: remove dirty share manager
- Yes, it is ready.
- 10:37 AM Feature #7037: remove dirty share manager
- Is this ready for review?
What is the %Done for this task? - 10:33 AM Feature #7037: remove dirty share manager
- Rebased task branch 7037b from FWD trunk revision 14572.
- 10:03 AM Feature #6442: missing encoding/collation features
- Just a quick question about design: are collation/codepage available as some database config (like in @ConnectionMana...
- 10:02 AM Bug #7334: Reclaim used sessions to improve performance
- *Committed 7334a.rev14569.* I applied the changes mentioned in #7334-11.
I misunderstood your question and reteste... - 07:03 AM Bug #7334: Reclaim used sessions to improve performance
- What about multiple client? I suspect your test was done with only one client?
- 05:54 AM Bug #7334: Reclaim used sessions to improve performance
- Alexandru Lungu wrote:
> Danut, can you retrieve the same statistics as in #7334-8 without any pause?
After retes... - 03:42 AM Bug #7334: Reclaim used sessions to improve performance
- Danut, can you retrieve the same statistics as in #7334-8 without any pause? I am curios how fast is using a single s...
- 09:36 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- There is something else, that caught my attention. In the @tests/dataset/TestReadXmlFileNoPkReadGenerated.cls@ test, ...
- 09:12 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> Just wondering that maybe for better clarity, we only prepare temp-table, when the temp-tabl... - 09:08 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Just wondering that maybe for better clarity, we only prepare temp-table, when the temp-table is in the CLEAR state ?...
- 08:28 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > This change fixed 4 tests and i think it make sense, any comments on this ?
Igor: I think this is for you. - 08:16 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Yeah i agree, set name for dynamic temp-table is equivalent to prepared state - i will revert my change from the bran...
- 06:24 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Ovidiu Maxiniuc wrote:
> I am pretty sure the name of static temp-tables cannot be set/changed dynamically.
> In th... - 05:47 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I just rebased 4514a on top of newest 3827b (which includes some fixes for ABLUnit that i need), which is based on to...
Also available in: Atom