Activity

From 10/31/2023 to 11/29/2023

11/30/2023

10:21 PM Feature #6720: lazy hydration: I grabbed 6720c and looked at the latest changes. Indeed, I do not see a reason for a change in performance. The hydr... Ovidiu Maxiniuc

11/29/2023

11:56 AM Bug #7113: Problem with nested CAN-FIND conversion: Eric Faulhaber wrote:
> Ovidiu, 7259a was merged to trunk some time ago. Did it fix this issue?
7259a contained cha... Ovidiu Maxiniuc
11:10 AM Bug #7113: Problem with nested CAN-FIND conversion: Ovidiu, 7259a was merged to trunk some time ago. Did it fix this issue? If not, are the changes in 7113a needed? Eric Faulhaber
10:59 AM Bug #6812 (Internal Test): fix FastFindCache to use a shared instance per persistent database: Constantin, does it make sense to regression test this with the large POC? Eric Faulhaber
07:45 AM Feature #6720: lazy hydration: Ovidiu, I finished the implementation completely and tested it over a large POC. However, I created a separate branch... Alexandru Lungu
05:37 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: After running a large POC with *7156b/rev.14846* (which uses *FWD-H2/rev.33*) and the changes from *7138a_h2/rev.24 -... Dănuț Filimon
03:31 AM Bug #8030 (Test): unique index violation when creating a record in two sessions: Alexandru Lungu
12:36 AM Bug #8030: unique index violation when creating a record in two sessions: Code review 8030a/14829-14830:
The logic changes look fine to me. For clarity, I did change the name of the method... Eric Faulhaber

11/28/2023

04:29 PM Feature #6496: add equivalent support for -trig command line option: The (schema-)triggers are context specific because the @propath@ is context specific (@EnvironmentOps.getSearchPath()... Ovidiu Maxiniuc
08:54 AM Feature #6496: add equivalent support for -trig command line option: Are the trigger defs already context-specific? If so, let's avoid the map lookup. Greg Shah
12:15 PM Bug #8030: unique index violation when creating a record in two sessions: Eric Faulhaber wrote:
> Yes, please do.
Sorry, I misread your note. I'll review... Eric Faulhaber
11:31 AM Bug #8030: unique index violation when creating a record in two sessions: Yes, please do. Eric Faulhaber
11:21 AM Bug #8030: unique index violation when creating a record in two sessions: AFAIK, everything is done on 8030a (including MariaDB - I discussed with Danut and the issue in #8030-1 is no longer ... Alexandru Lungu
11:16 AM Bug #8030: unique index violation when creating a record in two sessions: Dănuț Filimon wrote:
> *Committed 8030a/rev.14830*. Modified @RecordBuffer.reportValidationException@.
>
> Alexan... Eric Faulhaber
03:11 AM Bug #8030 (Review): unique index violation when creating a record in two sessions: *Committed 8030a/rev.14830*. Modified @RecordBuffer.reportValidationException@.
Alexandru, the example provided di... Dănuț Filimon
10:19 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: Yes, please go ahead. Alexandru Lungu
08:35 AM Bug #7138 (Review): Short circuit fake-update (update with a new value eqaul to the old value) in H2: Branch 7454a was previously merged into trunk as rev. 14833. Alexandru, should I run the POC tests for this task befo... Dănuț Filimon
09:43 AM Bug #7731: performance improvements for FQLPreprocessor: [[p2j:Database Configuration#Cache-Sizes]] was updated with the necessary information for configuring the cache size ... Dănuț Filimon
09:37 AM Bug #7731 (Test): performance improvements for FQLPreprocessor: Branch 7731a was merged into trunk as rev. 14844 and archived. Alexandru Lungu
09:14 AM Bug #7731: performance improvements for FQLPreprocessor: You can merge now. Greg Shah
08:02 AM Feature #7323: Implement soft unique index in FWD-H2: Alexandru Lungu wrote:
> Radu, can you check if we are still hitting @validateUniqueByQuery@ for _temp? If so, how m... Radu Apetrii
06:46 AM Feature #7323: Implement soft unique index in FWD-H2: Radu, can you check if we are still hitting @validateUniqueByQuery@ for _temp? If so, how many times do we actually b... Alexandru Lungu
06:38 AM Feature #7323: Implement soft unique index in FWD-H2: I finished running the performance tests and the results are not very encouraging:
* 7323a rev. 14801 (*before* the ... Radu Apetrii

11/27/2023

04:50 PM Feature #6496: add equivalent support for -trig command line option: Most likely, not. A context-level map should do it. The only think that is missing is the invalidate event, when the ... Ovidiu Maxiniuc
08:08 AM Feature #6496: add equivalent support for -trig command line option: Ovidiu: Is it difficult for us to cache the results at the trigger definition? If not, I'd prefer that over the idea... Greg Shah
04:39 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: My last commit does not change business code in @ImportWorker@, just the logs are more verbose.
I had a look at th... Ovidiu Maxiniuc
11:12 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Roger Borrello wrote:
> This does not happen with trunk, so something in this branch is causing H2 word tables to be... Roger Borrello
10:59 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Roger Borrello wrote:
> Ovidiu, when I run @ant import.db@ using the H2 database, it is trying to import into the *r... Roger Borrello
10:42 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Ovidiu, when I run @ant import.db@ using the H2 database, it is trying to import into the *reservation__guest* table.... Roger Borrello
11:52 AM Bug #7731 (Merge Pending): performance improvements for FQLPreprocessor: This can merge to trunk after 7669a. Greg Shah
07:35 AM Bug #7731: performance improvements for FQLPreprocessor: I think the changes are OK. I've tested with a large POC performance run, and there was a visible improvement. Constantin Asofiei
10:15 AM Bug #8030: unique index violation when creating a record in two sessions: Danut, please move this into Review once you finish the implementation so we can move on with the review part. There ... Alexandru Lungu
09:23 AM Bug #8030: unique index violation when creating a record in two sessions: I can't recall exactly. We have some changes in #7323 that was doing the cause unwrapping for FWD-H2 *exactly* becaus... Alexandru Lungu
09:20 AM Bug #8030: unique index violation when creating a record in two sessions: Alexandru, in what case is required to unwrap the cause for P2JH2Dialect? I'll need a bit more context to adjust the ... Dănuț Filimon
09:04 AM Bug #8030: unique index violation when creating a record in two sessions: I committed the fix for #8030-3 in *8030a/rev.14829*, currently investigating @RecordBuffer.reportValidationException@. Dănuț Filimon
05:56 AM Bug #8030: unique index violation when creating a record in two sessions: I managed to reproduce the issue after fixing a configuration issue in @build_db.xml@. Working on it right now. Dănuț Filimon
04:43 AM Bug #8030: unique index violation when creating a record in two sessions: Danut, can you re-attempt to recreate this and fix? Please do some debugging to see where you are failing into recrea... Alexandru Lungu
10:14 AM Feature #7323: Implement soft unique index in FWD-H2: Theoretically yes. Practically, the flag will only take affect if there are violations. We need to check on our large... Alexandru Lungu
10:04 AM Feature #7323: Implement soft unique index in FWD-H2: I've addressed the review points and committed to 7323a rev. 14802-14803. Right now I'm running the performance tests... Radu Apetrii

11/26/2023

08:31 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Branch 4722b was rebased to trunk_14841 and is at revision 14845. Roger Borrello

11/24/2023

12:42 AM Feature #6496: add equivalent support for -trig command line option: #6649 already has a cache implementation which not only stores the results from @convertNametoClass()@, but also @con... Dănuț Filimon
09:03 PM Feature #6496: add equivalent support for -trig command line option: Greg Shah wrote:
> If we implement the solution in #6649, we still have to do a minimal cache lookup for each trigge... Ovidiu Maxiniuc
07:37 PM Feature #6720: lazy hydration: That is an interesting approach. I did not realized that level of specialization would be necessary. This class was a... Ovidiu Maxiniuc

11/23/2023

10:02 AM Feature #6720: lazy hydration: *Status update:*
Ovidiu, I followed your suggestion on having a @BitSet@ to store the selected fields. However, I ... Alexandru Lungu
09:09 AM Bug #7167: Associating records from opened buffers to new sessions is slow: Alexandru Lungu wrote:
> Danut, please re-test the large POC and see if why we are still having spikes on @BufferMan... Dănuț Filimon
08:54 AM Feature #6496: add equivalent support for -trig command line option: My point here is that by doing something in the database trigger manager itself, we can get an even better level of o... Greg Shah
08:52 AM Feature #6496: add equivalent support for -trig command line option: > However, it searches the root directory even after I seem to have removed it from propath (I even printed the propa... Greg Shah
07:54 AM Feature #6496: add equivalent support for -trig command line option: Small observation.
I had tried in progress developer studio to remove all from propath (right click on project, proj... Alexandru Donica
04:57 AM Feature #6496 (WIP): add equivalent support for -trig command line option: Alexandru Donica wrote:
> So in 4GL it definitely tries to append the trig location to every propath folder, because... Alexandru Lungu
04:49 AM Feature #6496: add equivalent support for -trig command line option: So in 4GL it definitely tries to append the trig location to every propath folder, because when I reordered the propa... Alexandru Donica
03:05 AM Feature #6496: add equivalent support for -trig command line option: Greg, what you are saying is a side-effect of #6649. Every @convertName@ (or @fastConvertName@) is added to one of th... Alexandru Lungu
06:03 AM Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks: I have not went further with this. The report I used is this:... Constantin Asofiei
05:20 AM Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks: Constantin, what kind of queries did you consider. FOR EACH loops with BREAK BY shouldn't be counted (or maybe can be... Alexandru Lungu
04:37 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: I've committed to 7416b rev. 14773 the changes suggested in #7416-41 with two exceptions: the two points related to @... Radu Apetrii

11/22/2023

11:06 AM Feature #6496: add equivalent support for -trig command line option: We should consider an approach similar to #1970, where we changed @ControlFlowOps@ and the converted code to cache th... Greg Shah
10:59 AM Feature #6496: add equivalent support for -trig command line option: > However I see now that in 4GL, it searches for the trigger location in every folder in propath, and uses the first ... Greg Shah
10:18 AM Feature #6496: add equivalent support for -trig command line option: Alexandru Donica wrote:
> I did some more tests in 4GL with the propath now that I may not have done a while ago, or... Alexandru Lungu
10:00 AM Feature #6496: add equivalent support for -trig command line option: I did some more tests in 4GL with the propath now that I may not have done a while ago, or I did not complete them pr... Alexandru Donica
09:55 AM Feature #6496: add equivalent support for -trig command line option: * Another question: the prefixes (@String[] prefixes = new String[] {"./", ".\\", "../", "..\\"};@) should be checked... Alexandru Lungu
07:42 AM Feature #6496: add equivalent support for -trig command line option: Alexandru [ad], just a notice. Is is possible to state a @-trig@ relative to the propath? Thus, if you have a trigger... Alexandru Lungu
04:08 AM Feature #6496: add equivalent support for -trig command line option: I am giving it a shot with some performance tests now - if everything is OK, I will merge it. Alexandru Lungu
05:13 AM Feature #7323: Implement soft unique index in FWD-H2: Also, please attempt to retest the POC for performance after the changes. Make a baseline with 7156b / an intermediar... Alexandru Lungu
05:09 AM Bug #7167: Associating records from opened buffers to new sessions is slow: Also, please remake the statistic on #7167-1 now with 1s of lifespan vs 10s of lifespan. Alexandru Lungu
05:08 AM Bug #7167: Associating records from opened buffers to new sessions is slow: Danut, please re-test the large POC and see if why we are still having spikes on @BufferManager.activeBuffers@. Pleas... Alexandru Lungu

11/21/2023

05:33 PM Feature #6496: add equivalent support for -trig command line option: Greg Shah wrote:
> Is there more testing needed for this branch?
I haven't tested this branch. Please let me know i... Theodoros Theodorou
05:23 PM Feature #6496: add equivalent support for -trig command line option: Is there more testing needed for this branch?
Theodoros: Is anything in 6496a dependent on the changes in 7732a? Greg Shah
05:20 PM Feature #6496: add equivalent support for -trig command line option: Greg Shah wrote:
> Theodoros: Please review.
The changes look good.
> All: We are trying to merge 7732a before... Theodoros Theodorou
08:09 AM Feature #6496: add equivalent support for -trig command line option: Theodoros: Please review.
All: We are trying to merge 7732a before 6496a since it has changes related to the start... Greg Shah
03:59 AM Feature #6496 (Review): add equivalent support for -trig command line option: I moved the trigger location parameter to @StartupParameters@ as adviced. I also removed the map that cached the trig... Alexandru Donica
02:22 PM Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks: A crude report on the .ast of a large POC app results in ~13% (18k from 141k) of the FOR EACH blocks which can be imp... Constantin Asofiei
02:07 PM Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks: Good point. Greg Shah
01:16 PM Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks: Greg Shah wrote:
> That is why I was suggesting bypassing that case.
I agree, but this would exclude all temp-table... Constantin Asofiei
01:09 PM Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks: That is why I was suggesting bypassing that case. Greg Shah
12:56 PM Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks: Greg Shah wrote:
> One important contraint to include is that the buffer must be scoped to the @FOR@ loop. If the s... Constantin Asofiei
12:26 PM Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks: Let's move ahead with this. Note that we should do this analysis *after* record scoping is finished in annotations. ... Greg Shah
09:51 AM Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks: Greg Shah wrote:
> We can certainly use TRPL to analyze field usage and generate an implicit @FIELDS@ clause if cert... Constantin Asofiei
09:47 AM Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks: We can certainly use TRPL to analyze field usage and generate an implicit @FIELDS@ clause if certain constraints are ... Greg Shah
09:31 AM Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks: In a customer application, we noticed patterns like @for each tt1: do something with a few fields. end.@ where althou... Constantin Asofiei
09:28 AM Feature #8067 (WIP): investigate adding automatically adding a FIELDS clause for simple record bl...: Constantin Asofiei
09:17 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Ovidiu... I must have really missed something for H2 regarding the use of DDL in the application jar file. I hadn't s... Roger Borrello
07:05 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Ovidiu, I am using this branch, and getting an error finding the ddl, when it is in the @hotel.jar@ file. When I unzi... Roger Borrello

11/20/2023

05:10 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: I fixed the minor typo and checked in revision 14837. Roger Borrello
04:11 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Ovidiu Maxiniuc wrote:
> I committed my 4722b changes as r14836.
> Nothing fancy, just more verbose logs and allowe... Roger Borrello
03:35 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: I committed my 4722b changes as r14836.
Nothing fancy, just more verbose logs and allowed loading of FS resources if... Ovidiu Maxiniuc
08:48 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Ovidiu: Do you still have changes to put into 4722b? Greg Shah
08:45 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Branch 4722b was rebased to trunk_14834 and is at revision 14835. Roger Borrello
10:08 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: Okay then, please continue working on the review. Andrei, disregard my comment. Alexandru Lungu
09:49 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: Alexandru Lungu wrote:
> As the review is quite detailed, Andrei [ai], can you manage clearing as many as the minor ... Radu Apetrii
09:46 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: As the review is quite detailed, Andrei [ai], can you manage clearing as many as the minor points above? If there are... Alexandru Lungu

11/17/2023

06:31 PM Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries: Review of 7999a, r14833.
Good job. The goal of the task was reached. But I have some things to note, mainly becaus... Ovidiu Maxiniuc
12:49 PM Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries: Ovidiu: Please review. Greg Shah
12:43 PM Bug #7999 (Review): FWD does not honor FIELDS/EXCEPT at dynamic queries: Alexandru Lungu
10:05 AM Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries: Committed on 7999a, revision 14833.
- @DynamicQueryHelper@, added methods to traverse @fields@ and @except@ phrases... Eduard Soltan
09:09 AM Bug #7454 (Test): Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: Branch 7454a was merged into trunk as rev. 14833 and archived. Alexandru Lungu
08:17 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: You can merge now. Greg Shah
07:51 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: Regression tests passed successfully. *7454a can be merged - Greg, waiting for your call* Alexandru Lungu
07:50 AM Feature #6496: add equivalent support for -trig command line option: I have been working on this little by little between other high priority tasks. I intent to put more focus on this ta... Alexandru Donica
07:48 AM Feature #6496: add equivalent support for -trig command line option: Any progress here? Mind that we need a major performance drop for the upcoming week, and the addition of @-trig@ may ... Alexandru Lungu
05:24 AM Feature #7382: Check performance of delete from vs drop table in H2: Alexandru Lungu wrote:
> Radu, please let me know if you managed to handle this to some extent. Otherwise, Eduard wi... Radu Apetrii
05:23 AM Feature #7382: Check performance of delete from vs drop table in H2: Radu, please let me know if you managed to handle this to some extent. Otherwise, Eduard will continue working on this. Alexandru Lungu
04:05 AM Bug #8044 (Review): Fix "Failed direct-access due to Error direct accessing for finding record by...: *Committed 8044a/rev.14830* Normalized unknown value, date and datetime arguments. In the end, I used @dateValue()@ t... Dănuț Filimon

11/16/2023

10:33 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: Alexandru Lungu wrote:
> Profiled 7454a now and got -0.6% improvement. This was on-spot with the expectancy (or even... Dănuț Filimon
09:36 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Greg Shah wrote:
> Does this branch only have the script change?
I believe Ovidiu had something for this branch:
... Roger Borrello
05:37 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Does this branch only have the script change? Greg Shah
08:03 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Branch 4722b was rebased to trunk_14829 and is at revision 14830. Roger Borrello
06:04 AM Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...: While I was testing a large application, there were not a lot of instances where the unknown value is normalized to n... Dănuț Filimon
04:34 AM Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...: Please check the @DateType.setParameter@ function. It should do the same. Alexandru Lungu
04:32 AM Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...: Alexandru Lungu wrote:
> Not quite; I was just seeing this pop up thousand of times.
>
> Please also mind handli... Dănuț Filimon
04:21 AM Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...: Not quite; I was just seeing this pop up thousand of times.
Please also mind handling:
* the unknown value as we... Alexandru Lungu
03:53 AM Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...: *Committed 8044a/rev.14829* Normalized @rowid@ and @longchar@ arguments.
Alexandru, can you provide a reproduction c... Dănuț Filimon

11/15/2023

09:51 AM Bug #7454 (Internal Test): Make ValueStringIgnoreCase the default generated value for setString i...: Profiled 7454a now and got -0.6% improvement. This was on-spot with the expectancy (or even quite better).
I will mo... Alexandru Lungu
09:41 AM Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...: I am still getting the same error but in a different process now, there is another object aside from @rowid@ that is ... Dănuț Filimon
09:21 AM Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...: I have multiple warning where this direct access exception is logged in a customer application: @23/11/15 16:08:27.39... Dănuț Filimon
09:12 AM Bug #8044 (WIP): Fix "Failed direct-access due to Error direct accessing for finding record by un...: Alexandru Lungu
09:37 AM Bug #7731: performance improvements for FQLPreprocessor: Alexandru Lungu wrote:
> What internal tests should be done here, Danut? Are you able to do some smoke tests on larg... Dănuț Filimon
09:32 AM Bug #7731: performance improvements for FQLPreprocessor: What internal tests should be done here, Danut? Are you able to do some smoke tests on large applications?
I can t... Alexandru Lungu
08:23 AM Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible: If only we completed #7782, we could remove this useless @id@ workaround code. Problems like the above are just extr... Greg Shah
08:15 AM Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible: Here are the current scenarios that I tested with Hotel_GUI:
* 7567a without changes - @primaryKeyName="recid"@ and ... Dănuț Filimon
05:18 AM Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible: It seems that the "recid" is hard coded in @SchemaConfig@ and is used by the meta database, this causes the server to... Dănuț Filimon
03:35 AM Bug #7999 (WIP): FWD does not honor FIELDS/EXCEPT at dynamic queries: Alexandru Lungu

11/14/2023

03:01 PM Feature #6414: ERROR attribute for buffer, dataset and temp-table: I think there are very few places in customer projects which are affected by the changes in this branch. The fwdtests... Ovidiu Maxiniuc
02:42 PM Feature #6414 (Internal Test): ERROR attribute for buffer, dataset and temp-table: Ovidiu Maxiniuc wrote:
> Branch 6414a updated, rebased and pushed as r14827.
Thanks for addressing the code revie... Eric Faulhaber
08:02 AM Feature #7323: Implement soft unique index in FWD-H2: I have found only some points:
* Remove @hasDirectAccess@ entirely and let @startValidate@ and @stopValidate@ simply... Alexandru Lungu
06:45 AM Feature #7323: Implement soft unique index in FWD-H2: Unfortunately, I still have the same results as in #7323-49 :/ We are adding to much overhead somewhere. Maybe after... Alexandru Lungu
04:39 AM Feature #7323: Implement soft unique index in FWD-H2: I committed to 7323a, rev. 14801 the following changes:
* Reverted @TempTableHelper@ to its original state.
* Repla... Radu Apetrii
04:07 AM Feature #7323: Implement soft unique index in FWD-H2: Alexandru Lungu wrote:
> I will start testing in ~30mins. If you have time to get them committed, it is ideal. If no... Radu Apetrii
03:39 AM Feature #7323: Implement soft unique index in FWD-H2: I will start testing in ~30mins. If you have time to get them committed, it is ideal. If not, the changes are minor a... Alexandru Lungu
02:18 AM Feature #7323: Implement soft unique index in FWD-H2: Is it OK to commit those changes now or will it interfere with your testing? Radu Apetrii
07:53 AM Feature #6815: configure all cache sizes in the directory, and create documentation for them: > OTOH, for this specific case, it may just be that the parsed predicate is 'one of a kind', in that it uses some uni... Alexandru Lungu
07:42 AM Feature #6815: configure all cache sizes in the directory, and create documentation for them: Alexandru Lungu wrote:
> Danut, please point out to the documentation in this task and mark it as Review when finish... Dănuț Filimon
07:13 AM Bug #7924 (Review): add support for creating an empty database: I attached a patch that solves the issue. Ovidiu, can you retest MariaDB and tell me if there are any more problems w... Dănuț Filimon
06:23 AM Bug #7924: add support for creating an empty database: Ovidiu Maxiniuc wrote:
> As noted in my previous note, this is the cause of the failure: the indices attempts to use... Dănuț Filimon
05:03 AM Bug #8044 (WIP): Fix "Failed direct-access due to Error direct accessing for finding record by un...: Alexandru Lungu
04:53 AM Bug #8030: unique index violation when creating a record in two sessions: I retested with *7156b/rev.14846* but I couldn't reproduce the error with this branch too. Dănuț Filimon
04:37 AM Bug #8030: unique index violation when creating a record in two sessions: Alexandru Lungu wrote:
> Danut, also make sure you use the right schema (having unique indexes on book-id / isbn).
... Dănuț Filimon
04:35 AM Bug #8030: unique index violation when creating a record in two sessions: Danut, also make sure you use the right schema (having unique indexes on book-id / isbn). Alexandru Lungu
04:06 AM Bug #8030: unique index violation when creating a record in two sessions: Dănuț Filimon wrote:
> Constantin Asofiei wrote:
> > Don't use parallel clients, run the same client twice. Also y... Constantin Asofiei
04:05 AM Bug #8030: unique index violation when creating a record in two sessions: Constantin Asofiei wrote:
> Don't use parallel clients, run the same client twice. Also you need to use MariaDB for... Dănuț Filimon
04:02 AM Bug #8030: unique index violation when creating a record in two sessions: Dănuț Filimon wrote:
> I was not able to reproduce the scenario with *trunk/rev.14828*, especially make it to reach ... Constantin Asofiei
04:00 AM Bug #8030: unique index violation when creating a record in two sessions: I was not able to reproduce the scenario with *trunk/rev.14828*, especially make it to reach the catch from @orm.Pers... Dănuț Filimon

11/13/2023

11:22 AM Feature #7323 (Internal Test): Implement soft unique index in FWD-H2: *Review of 7323a*
* I don't think the cast to @P2JH2Dialect@ is needed anymore in @TempTableHelper@. The methods a... Alexandru Lungu
10:38 AM Bug #8030 (WIP): unique index violation when creating a record in two sessions: Constantin Asofiei wrote:
> The @java.sql.SQLIntegrityConstraintViolationException.cause@ field is null for MariaDB.... Alexandru Lungu
04:37 AM Bug #8030: unique index violation when creating a record in two sessions: The @java.sql.SQLIntegrityConstraintViolationException.cause@ field is null for MariaDB.
Constantin Asofiei
03:46 AM Bug #8030: unique index violation when creating a record in two sessions: I added Radu as a watcher; he is the author of 7323a. Alexandru Lungu
03:45 AM Bug #8030: unique index violation when creating a record in two sessions: Constantin, just a further notice on #8030-3. In H2, the first SQLException is an internal H2 exception that has anot... Alexandru Lungu
03:12 AM Bug #8030: unique index violation when creating a record in two sessions: Constantin Asofiei wrote:
> There is a case for #7669, which I don't have yet a complete standalone recreate; it loo... Tomasz Domin
08:02 AM Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible: Alexandru Lungu wrote:
> Danut, please double check: @searchPath@ and @propath@ in directory.xml and propath in p2j.... Dănuț Filimon
07:55 AM Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible: Danut, please double check: @searchPath@ and @propath@ in directory.xml and propath in p2j.cfg.xml. Is smart.p at lea... Alexandru Lungu
07:53 AM Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible: I had to make a few small changes to @DirectAccessHelper@ to fit the changes made in H2. When I tried to test Hotel_G... Dănuț Filimon
05:43 AM Feature #6496 (WIP): add equivalent support for -trig command line option: Alexandru Lungu
05:42 AM Feature #6496: add equivalent support for -trig command line option: I am moving this to High priority as it may grant us some performance improvement that we really need now. Alexandru ... Alexandru Lungu
04:06 AM Bug #8032 (WIP): Deleted records are returned by a preselect query: This is already handled in #5768. There are multiple attempts to fix this (the last one is 5768c). This will be fixed... Alexandru Lungu

11/12/2023

10:51 AM Bug #8032: Deleted records are returned by a preselect query: Here's a testcase. A record was preselected by a query and then deleted in the same session. It is still returned by ... Stanislav Lomany
08:08 AM Bug #8032 (Closed): Deleted records are returned by a preselect query: Stanislav Lomany

11/11/2023

02:51 PM Bug #8030: unique index violation when creating a record in two sessions: OK, this message seems to be a red herring: is just logged when this test is executed twice in a row:... Constantin Asofiei
03:43 AM Bug #8030: unique index violation when creating a record in two sessions: There is a case for #7669, which I don't have yet a complete standalone recreate; it looks like this, ran from two cl... Constantin Asofiei
03:30 AM Bug #8030 (Closed): unique index violation when creating a record in two sessions: Constantin Asofiei

11/10/2023

11:38 AM Feature #6815: configure all cache sizes in the directory, and create documentation for them: Alexandru, in #7669, I start seeing @DynamicQueryHelper cache level #1 is full. Dumped 1 old entries@ - (some 750k m... Constantin Asofiei
10:57 AM Feature #6815 (WIP): configure all cache sizes in the directory, and create documentation for them: Danut, please point out to the documentation in this task and mark it as Review when finished. Alexandru Lungu
11:02 AM Bug #7167 (Internal Test): Associating records from opened buffers to new sessions is slow: With some slim analysis, I still see @BufferManager.activeBuffers@ in top 50 performance items (being called ~100 tim... Alexandru Lungu
10:37 AM Feature #6720: lazy hydration: I run some regression testing and they passed. I also got them a second round to extract some insights.
|_. JMX |_... Alexandru Lungu
09:37 AM Bug #8025: Persistence API improvements: Constantin Asofiei wrote:
> Eric, customers need to access the result set metadata for the @ ScrollableResults<?> re... Alexandru Lungu
09:10 AM Bug #8025: Persistence API improvements: Another part which is requested by customers to be improved: @executeSQLBatch@ to return an @int[]@ array with the re... Constantin Asofiei
07:44 AM Bug #8025: Persistence API improvements: Eric, customers need to access the result set metadata for the @ ScrollableResults<?> resultSet = connection.executeS... Constantin Asofiei
07:43 AM Bug #8025 (New): Persistence API improvements: Constantin Asofiei

11/09/2023

11:11 AM Feature #6720: lazy hydration: > If incremental processing of the properties in BitSet is not possible, the i_rs(k) can be computed at first access ... Alexandru Lungu
09:23 PM Feature #6720: lazy hydration: Alexandru Lungu wrote:
> Indeed! The "difficulty" here was that we can't compute the proper offset on random access ... Ovidiu Maxiniuc
04:05 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: Rebased 7454a to latest trunk. It is now at rev. 14825. Alexandru Lungu
03:32 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: Yes! I was caught up with #6720 by now and I didn't want to spoil my profiling test with it. I will attempt to check ... Alexandru Lungu
01:44 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: Eric Faulhaber wrote:
> Can this issue be closed?
7454a was not merged, but 7454a_h2 was. If I remember correctly, ... Dănuț Filimon
03:58 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: Radu, please address the review as soon as you have the chance. Alexandru Lungu

11/08/2023

10:48 AM Feature #6720: lazy hydration: h4. Unique result
I improved the solution for unique result. It uses a LRUCache per session to "delay" the closing... Alexandru Lungu
04:00 AM Feature #6720: lazy hydration: Ovidiu Maxiniuc wrote:
> The hydration works now by iterating the columns of the @ResultSet@. The @DataHandler@ s fr... Alexandru Lungu
04:05 AM Feature #6895: improve performance of BufferReference methods buffer() and definition(): Eric / Constantin: this task is related to #6819, but it seems that it addresses a more particular scenario (@.buffer... Alexandru Lungu
03:51 AM Feature #5003 (WIP): Enhance performance of H2 sequences: In the past months, while heavenly profiling FWD-H2, I removed the flushing of sequences to disk for _temp database. ... Alexandru Lungu
03:46 AM Bug #7167: Associating records from opened buffers to new sessions is slow: Eric, in theory, this can be closed. However, I am waiting for some performance tests to check that @BufferManager.ac... Alexandru Lungu

11/07/2023

05:27 PM Feature #7076 (Closed): make CAN-FIND avoid hydration: Eric Faulhaber
05:15 PM Feature #5003: Enhance performance of H2 sequences: What is the true "% Done" value of this task? It seems the improvements discussed in #5003-2 made it into trunk via 3... Eric Faulhaber
05:06 PM Bug #7167: Associating records from opened buffers to new sessions is slow: Can this task be closed? Eric Faulhaber
04:58 PM Feature #6414: ERROR attribute for buffer, dataset and temp-table: Eric Faulhaber wrote:
> Code review 6414a/14806-7:
Thank you for the review. A second pair of eyes are always bette... Ovidiu Maxiniuc
01:59 PM Feature #6720: lazy hydration: The hydration works now by iterating the columns of the @ResultSet@. The @DataHandler@ s from @com.goldencode.p2j.per... Ovidiu Maxiniuc
01:02 PM Feature #6720: lazy hydration: > I am not sure I understand why dtz are a problem for (partial|lazy) hydration. The name/type is available for each ... Alexandru Lungu
12:17 PM Feature #6720: lazy hydration: Alexandru Lungu wrote:
> *Fix datetime-tz and extent cases*
> Next on my list is to fix the the datetimze-tz and ex... Ovidiu Maxiniuc
10:03 AM Feature #6720: lazy hydration: h4. Avoid lazily hydrating from H2
Tested and had only -0.8% time improvement comparing to baseline. This means th... Alexandru Lungu
03:05 AM Bug #7535 (Test): Temporary tables require trailing recid component even for unique indexes: Alexandru Lungu
03:05 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Yes, the changes in 7535c were included already in a separate task branch that was merged to trunk. Alexandru Lungu
08:21 PM Bug #7535: Temporary tables require trailing recid component even for unique indexes: Can this issue be closed? Eric Faulhaber
08:17 PM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2: Can this issue be closed? Eric Faulhaber

11/06/2023

10:58 AM Feature #6628 (Internal Test): port PostgreSQL native user defined functions to MariaDB: Code review 6628a/14615:
The changes look good. I don't know whether Igor ever was able to test these changes, giv... Eric Faulhaber
10:43 AM Feature #6414: ERROR attribute for buffer, dataset and temp-table: Code review 6414a/14806-7:
The changes to the @DataSet*@ classes look fine. I am not as familiar to the functional... Eric Faulhaber
10:15 AM Feature #6720: lazy hydration: *Optimization 1: Refresh only fields that weren't hydrated already*
*Optimization 2: Discard the hydrator if we hydr... Alexandru Lungu
08:15 AM Feature #7382: Check performance of delete from vs drop table in H2: Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > The difference is that TRUNCATE is closing an open transacti... Alexandru Lungu
07:49 AM Feature #7382: Check performance of delete from vs drop table in H2: Alexandru Lungu wrote:
> The difference is that TRUNCATE is closing an open transaction. But this can be solved by a... Constantin Asofiei
07:46 AM Feature #7382: Check performance of delete from vs drop table in H2: I put myself up to date with the discussion here and I created 7382a. I'll start working on this now. Radu Apetrii
02:19 AM Feature #7323 (Review): Implement soft unique index in FWD-H2: I've committed to 7323a rev. 14800 the following changes:
* Removed the @validateDriver@ caching.
* Moved @startVal... Radu Apetrii

11/04/2023

08:00 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Branch 4722b was rebased to trunk_14819 and is at revision 14820. Roger Borrello

11/03/2023

10:54 AM Feature #6720: lazy hydration: Committed 6720b/rev. 14769:
* Added JMX to do some tracking for lazy hydration. Hopefully they aren't slowing the pr... Alexandru Lungu
07:42 AM Feature #6720: lazy hydration: Greg Shah wrote:
> > I applied lazy hydration only to tables where we know that the SQL number of columns matches th... Alexandru Lungu
12:13 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Branch 4722b was rebased to trunk_14815 and is at revision 14816. Roger Borrello
10:52 PM Bug #7993: Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING) only onc...: Eugenie reported in #7143-463 an issue related to 7993a.
There are three issues I can see:
* the DDL being executed... Ovidiu Maxiniuc
10:32 PM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: Wow, this a much larger change-set that I expected. Things seem more structured now. Good job.
Here are my notes:... Ovidiu Maxiniuc

11/02/2023

04:59 PM Feature #6496: add equivalent support for -trig command line option: Eric Faulhaber wrote:
> In speaking with Greg about this, I also realized that I was not considering session trigger... Ovidiu Maxiniuc
01:21 PM Feature #6496: add equivalent support for -trig command line option: Greg Shah wrote:
> The problem is that there are some customers who definitely will have *per client* (or likely *pe... Theodoros Theodorou
10:49 AM Feature #6496: add equivalent support for -trig command line option: In speaking with Greg about this, I also realized that I was not considering session triggers during my review. The O... Eric Faulhaber
10:39 AM Feature #6496: add equivalent support for -trig command line option: BTW, it doesn't seem like this setting in OE has any relationship to a given schema or database instance. It is just... Greg Shah
10:34 AM Feature #6496: add equivalent support for -trig command line option: We definitely cannot set this *per database*. In most cases, customers have a single propath for all clients and wou... Greg Shah
10:14 AM Feature #6496: add equivalent support for -trig command line option: OK, so then other than fixing the typo/coding standard issues, the only thing left to decide is the scope we want to ... Eric Faulhaber
05:54 AM Feature #6496: add equivalent support for -trig command line option: Eric Faulhaber wrote:
> There are many changes to @SourceNameMapper@. Alexandru (Lungu) or Danut: can you please con... Dănuț Filimon
01:23 AM Feature #6496: add equivalent support for -trig command line option: Code review 6496a/14743-14744:
The configuration is causing me some confusion, in that it can be specified for eac... Eric Faulhaber
03:48 PM Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries: Consider this test:... Constantin Asofiei
03:44 PM Bug #7999 (Review): FWD does not honor FIELDS/EXCEPT at dynamic queries: Constantin Asofiei
03:36 PM Bug #7731 (Internal Test): performance improvements for FQLPreprocessor: Review of 7731a/14811-2.
A straightforward implementation. I am OK with the code. Good job!
Ovidiu Maxiniuc
12:12 PM Bug #7731: performance improvements for FQLPreprocessor: Ovidiu/Constantin: Please review. Greg Shah
11:33 AM Bug #7731 (Review): performance improvements for FQLPreprocessor: It seems Danut has stepped away from "events" and "triggers" for a while :) Alexandru Lungu
11:30 AM Bug #7731: performance improvements for FQLPreprocessor: Please set the status and %Done accordingly. That is the "event" that triggers a code review. Greg Shah
10:17 AM Bug #7731: performance improvements for FQLPreprocessor: Greg Shah wrote:
> Is this ready for review?
Yes. Dănuț Filimon
09:46 AM Bug #7731: performance improvements for FQLPreprocessor: Is this ready for review? Greg Shah
12:11 PM Feature #6720: lazy hydration: > I applied lazy hydration only to tables where we know that the SQL number of columns matches the number of properti... Greg Shah
11:33 AM Feature #6720: lazy hydration: Committed 6720b/rev. 14768:
* *FIX* Made @toString@ ignore the hydrator and simply show what is in the current @da... Alexandru Lungu
11:34 AM Bug #7993 (Test): Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING) o...: Branch 7993a was merged to trunk as rev. 14814 and archived. Alexandru Lungu
11:22 AM Bug #7993: Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING) only onc...: You can merge to trunk. Greg Shah
09:19 AM Bug #7993: Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING) only onc...: Wow! This is major :)
I tested with a large customer's regression testing suite and got no problems. I also did so... Alexandru Lungu
08:55 AM Bug #7993 (Internal Test): Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_M...: Added. :) Greg Shah
08:36 AM Bug #7993 (WIP): Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING) on...: We probably need a different status code for "internal testing before being released to customer". Anyway, let me kn... Greg Shah
11:07 PM Bug #7993 (Test): Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING) o...: Review of c14813/7993a.
I am OK with the code. As described above, it should offer a bit of performance boost if t... Ovidiu Maxiniuc

11/01/2023

03:25 PM Bug #7731: performance improvements for FQLPreprocessor: Constantin Asofiei wrote:
> Is the cache configurable via directory.xml? I would leave it to 8192 as default and tu... Dănuț Filimon
09:02 AM Bug #7731: performance improvements for FQLPreprocessor: Dănuț Filimon wrote:
> Constantin Asofiei wrote:
> > OK, please set the cache size to 512k, run the test, look via ... Constantin Asofiei
08:58 AM Bug #7731: performance improvements for FQLPreprocessor: Constantin Asofiei wrote:
> OK, please set the cache size to 512k, run the test, look via the debugger and see what ... Dănuț Filimon
07:43 AM Bug #7731: performance improvements for FQLPreprocessor: Rebased 7731a to latest trunk. It is now at rev. 14811. Alexandru Lungu
06:37 AM Bug #7731: performance improvements for FQLPreprocessor: OK, please set the cache size to 512k, run the test, look via the debugger and see what the actual cache size is afte... Constantin Asofiei
06:35 AM Bug #7731: performance improvements for FQLPreprocessor: Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Dănuț Filimon wrote:
> > > So I should leave the cache s... Dănuț Filimon
06:28 AM Bug #7731: performance improvements for FQLPreprocessor: Constantin Asofiei wrote:
> Dănuț Filimon wrote:
> > So I should leave the cache size to *512k* instead of *8192* a... Constantin Asofiei
11:38 AM Bug #7993 (Review): Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING)...: The fast-copy process uses two intermediary tables (BEFORE__PK__MAPPING and MASTER__PK__MAPPING) to fulfill more comp... Alexandru Lungu
11:01 AM Bug #7993 (Test): Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING) o...: Alexandru Lungu
11:29 AM Bug #7420 (Test): Optimize Cursor for scrolling AdaptiveQuery: Alexandru Lungu
10:45 AM Feature #7382: Check performance of delete from vs drop table in H2: Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Just found out @TRUNCATE TABLE tt@ in H2.
> Isn't this the ... Alexandru Lungu
10:40 AM Feature #7382: Check performance of delete from vs drop table in H2: Alexandru Lungu wrote:
> Just found out @TRUNCATE TABLE tt@ in H2.
Isn't this the same as @DELETE FROM tt@ without ... Constantin Asofiei
10:31 AM Feature #7382: Check performance of delete from vs drop table in H2: Just found out @TRUNCATE TABLE tt@ in H2. I was suspecting that such command should have existed, but now it is confi... Alexandru Lungu
08:53 AM Feature #7382: Check performance of delete from vs drop table in H2: With the new fwd-h2-1.33-trunk, FWD temp-tables have a special scan index that is able to distinguish between multipl... Alexandru Lungu
08:20 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: Profiled and the change has a reasonable time (it fits the time boundaries). It is neither faster nor slower.
*Eri... Alexandru Lungu
06:19 AM Feature #7323: Implement soft unique index in FWD-H2: Alexandru Lungu wrote:
> Radu, please queue this task and mark it with higher priority.
On it. I also noticed some ... Radu Apetrii
01:30 AM Feature #6414 (Review): ERROR attribute for buffer, dataset and temp-table: Task branch was rebased to trunk/14805 updated to r14807.
The latest update contains the handling of ERROR attribute... Ovidiu Maxiniuc

10/31/2023

06:20 PM Feature #4722: data import should be able to run with only the converted application jar file (an...: Branch 4722b was rebased to trunk_14805 and is at revision 14806. Roger Borrello
09:17 AM Feature #4722: data import should be able to run with only the converted application jar file (an...: Branch 4722b was rebased to trunk_14798 and is at revision 14799. Roger Borrello
04:49 PM Feature #6347: change the name conversion to provide a configurable option to not emit "snake case": Can this be closed? Is there something remaining to do? Greg Shah

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Database

Activity

Activity

11/30/2023

11/29/2023

11/28/2023

11/27/2023

11/26/2023

11/24/2023

11/23/2023

11/22/2023

11/21/2023

11/20/2023

11/17/2023

11/16/2023

11/15/2023

11/14/2023

11/13/2023

11/12/2023

11/11/2023

11/10/2023

11/09/2023

11/08/2023

11/07/2023

11/06/2023

11/04/2023

11/03/2023

11/02/2023

11/01/2023

10/31/2023