FWD » Core Development » Database

02/15/2024

04:23 AM Feature #6628 (WIP): port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> OK, please go ahead and implement my suggestions. That is:
>
> * augment @FQLPreprocessor... Dănuț Filimon

02/14/2024

07:30 AM Feature #6720: lazy hydration

I changed @BaseRecord.copy@, to set @hydrator@ and @liveProps@ of the new record ... Eduard Soltan

04:02 AM Feature #6720: lazy hydration

Lets go ahead with some statistics. From where is @getData@ called and how many times. Please find the back traces of... Alexandru Lungu

02:09 AM Feature #6720: lazy hydration

On delete of a temporary buffer and a deleted buffer is placed in before table.
But to make this copy a snapshot o... Eduard Soltan

02/13/2024

02:22 PM Feature #6720: lazy hydration

Short update from a live discussion with Eduard: the regression seems to be related with the @BaseRecord.getData@ cal... Alexandru Lungu

02/12/2024

02:39 AM Bug #7496: finish support for query:forward-only attribute

Rebased *7496a* with *trunk/rev.14981*. *7496a* is now at revision *14991*. Dănuț Filimon

02:29 AM Bug #7334 (Test): Reclaim used sessions to improve performance

Dănuț Filimon

02:29 AM Bug #7334 (Internal Test): Reclaim used sessions to improve performance

Alexandru Lungu wrote:
> This reached trunk a while ago. Is there anything left on this task? If not, please move it... Dănuț Filimon

02:26 AM Bug #7334: Reclaim used sessions to improve performance

This reached trunk a while ago. Is there anything left on this task? If not, please move it to test. Alexandru Lungu

02/09/2024

10:36 AM Bug #7924: add support for creating an empty database

Issue has been fixed in *7924a.rev.14794*. All field types can be augmented with @__null@ for @MariaDbDialect@ when t... Dănuț Filimon

04:57 AM Bug #8259: Reduce the work done by PreselectQuery.coreFetch

Alexandru Lungu wrote:
> Eduard Soltan wrote:
> > For now in we assign to @updateLock@ the following expression: @u... Eduard Soltan

04:04 AM Bug #8259: Reduce the work done by PreselectQuery.coreFetch

Eduard Soltan wrote:
> For now in we assign to @updateLock@ the following expression: @updateLock = (lt != LockType.... Alexandru Lungu

03:58 AM Bug #8259: Reduce the work done by PreselectQuery.coreFetch

For now in we assign to @updateLock@ the following expression: @updateLock = (lt != LockType.NONE);@.
I think that... Eduard Soltan

03:59 AM Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries

Ovidiu Maxiniuc wrote:
> ** line 1368: @byLegacyName()@ requires that the argument to be normalized (lowercase). Yo... Eduard Soltan

02/08/2024

02:14 PM Bug #8249: Introduce a fast fill method to optimize Dataset.fill

I discussed with Alexandru [ad] and there is a reasonable observation that the fill queries are usual @AdaptiveQuery@... Alexandru Lungu

09:20 AM Bug #8249: Introduce a fast fill method to optimize Dataset.fill

A little note:
@DataSet.fill@ calls @BufferImpl.fill@ which calls @FillWorker.fill@ (class inside @BufferImpl@), whi... Alexandru Donica

11:00 AM Bug #7924: add support for creating an empty database

Dănuț,
@sql_only_user__null@ must be generated.
This thing seemed familiar to me. I did a bit of research and ... Ovidiu Maxiniuc

10:12 AM Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries

Review of 7999a/14954-14958.
The code looks promising, most of the issues below are low priority. but there are a co... Ovidiu Maxiniuc

09:08 AM Bug #8259: Reduce the work done by PreselectQuery.coreFetch

Eduard, this basically means that the condition in #8259-2 is incorrect.
Please post here a cut-out to the problem... Alexandru Lungu

08:49 AM Bug #8259: Reduce the work done by PreselectQuery.coreFetch

Alexandru Lungu wrote:
> I wonder if NO-LOCK to SHARE-LOCK is considered an lock update.
It is. Any change in loc... Eric Faulhaber

08:03 AM Bug #8259: Reduce the work done by PreselectQuery.coreFetch

I wonder if NO-LOCK to SHARE-LOCK is considered an lock update. Alexandru Lungu

07:20 AM Bug #8259: Reduce the work done by PreselectQuery.coreFetch

Alexandru Lungu wrote:
> My whole concern here is that we do an extra session cache look-up for almost any record ... Eduard Soltan

05:55 AM Bug #8259: Reduce the work done by PreselectQuery.coreFetch

Eduard detected recently that there is some work being done in @PreselectQuery.coreFetch@ regarding an extra fetch.
... Alexandru Lungu

04:29 AM Bug #8259 (New): Reduce the work done by PreselectQuery.coreFetch

Alexandru Lungu

09:01 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses

In terms of JMX, results look promising. Out of a million of "Select all" type of queries, the @DirectAccess@ method ... Radu Apetrii

06:42 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses

Radu, if the solution is stable. Lets get some profiling results asap.
Please go in-depth with some JMX to check the... Alexandru Lungu

06:35 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses

Alexandru Lungu wrote:
> You can have compound queries. A component can be instantiated as an @AdaptiveQuery@. See @... Radu Apetrii

05:24 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses

You can have compound queries. A component can be instantiated as an @AdaptiveQuery@. See @for each tt, each tt2@, as... Alexandru Lungu

05:09 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses

Alex/Greg: Are there any other ways of generating a "Select all" type of *static* query that turns into an @AdaptiveQ... Radu Apetrii

07:19 PM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses

I've committed to:
* *7252b rev. 14934* a change for better handling of index choosing in @AdaptiveQuery.getAllLazyD... Radu Apetrii

02/07/2024

11:53 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses

Greg Shah wrote:
> It seems better to "remember" this information than to calculate it at runtime.
I'll add this id... Radu Apetrii

04:46 AM Bug #8251: Fine tune CompoundQuery optimization when contains clauses are used

This is a follow up of #8246.
Compound queries using @contains@ clause are no longer optimized:
* Check if this c... Alexandru Lungu

04:43 AM Bug #8251 (New): Fine tune CompoundQuery optimization when contains clauses are used

Alexandru Lungu

02/06/2024

10:34 AM Bug #8249: Introduce a fast fill method to optimize Dataset.fill

This task is aimed to optimize the @Dataset.fill@ implementation as it represents a bottle-neck in a large customer a... Alexandru Lungu

10:00 AM Bug #8249 (New): Introduce a fast fill method to optimize Dataset.fill

Alexandru Lungu

08:49 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses

For static queries, we know the 4GL name of the selected index at conversion time. We can easily pass that to the qu... Greg Shah

07:26 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses

For reference, if one were to assume that an index called @idx2@ would be created for table @tt@, then the following ... Radu Apetrii

11:02 PM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses

I've finally managed to isolate that NPE issue I encountered. Long story short (I say "short" because I had a really ... Radu Apetrii

03:21 AM Bug #7924: add support for creating an empty database

Ovidiu, the problem does not start from the index, but from the table field. If you take a look at @DDLGeneratorWorke... Dănuț Filimon

01:07 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

OK, please go ahead and implement my suggestions. That is:
* augment @FQLPreprocessor@ to detect and expose whethe... Eric Faulhaber

02/05/2024

02:35 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

It sounds like these suuggested changes are simple and low risk. I don't think we have to quantify the benefit in th... Greg Shah

11:56 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

OK, thanks. The change seems to make logical sense, but it got me looking at this part of the code again, and I am a ... Eric Faulhaber

10:59 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> Dănuț Filimon wrote:
> > There's a single change in @SQLQuery.resetErrorHandler@ that shoul... Dănuț Filimon

10:53 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Dănuț Filimon wrote:
> There's a single change in @SQLQuery.resetErrorHandler@ that should be mentioned. Instead of ... Eric Faulhaber

03:18 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

There's a single change in @SQLQuery.resetErrorHandler@ that should be mentioned. Instead of calling the dialect spec... Dănuț Filimon

03:14 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

6628b is already in trunk and reached 7156b, so functionally we are OK in 7156b. 6628c can go in trunk without confli... Alexandru Lungu

03:10 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric, do you still want 6628c to be merged? Dănuț Filimon

02:10 PM Bug #7924: add support for creating an empty database

Review of 7924a/rev.14793.
The code seems fine, except two issues:
1. In case of nullable fields, why injection o... Ovidiu Maxiniuc

11:10 AM Bug #7924 (Review): add support for creating an empty database

*Committed 7924a/rev.14793*.
Based on the error from #7924-14 I noticed that the column does not exist because it ... Dănuț Filimon

03:56 AM Bug #7924: add support for creating an empty database

The changes work well, I tested conversion with hotel_gui and compared the index ddls for mariadb (before and after).... Dănuț Filimon

02/02/2024

12:04 PM Feature #7382: Check performance of delete from vs drop table in H2

Done Alexandru Lungu

12:02 PM Feature #7382: Check performance of delete from vs drop table in H2

Alexandru Lungu wrote:
> Right, it does! I uploaded @devsrv01:/tmp/fwd-h2-1.40-trunk.jar@. Please upload to public r... Constantin Asofiei

11:59 AM Feature #7382: Check performance of delete from vs drop table in H2

Right, it does! I uploaded @devsrv01:/tmp/fwd-h2-1.40-trunk.jar@. Please upload to public repository.
We can then up... Alexandru Lungu

11:55 AM Feature #7382: Check performance of delete from vs drop table in H2

Alexandru Lungu wrote:
> Branch 7382a was merged into trunk as rev 14966 and archived.
Doesn't this require update ... Constantin Asofiei

11:52 AM Feature #7382: Check performance of delete from vs drop table in H2

Branch 7382a was merged into trunk as rev 14966 and archived. Alexandru Lungu

09:29 AM Feature #7382: Check performance of delete from vs drop table in H2

Don't we need to get 7382a into trunk to take advantage of the improvements? Greg Shah

11:36 AM Feature #6496 (Test): add equivalent support for -trig command line option

Branch 6496b was merged into trunk as rev 14965 and archived. Alexandru Lungu

09:17 AM Feature #6496 (Merge Pending): add equivalent support for -trig command line option

Constantin Asofiei

02:29 AM Bug #7924: add support for creating an empty database

Ovidiu Maxiniuc wrote:
> I think you can access the @not-null@ annotation when configuring the index components.
> ... Dănuț Filimon

12:22 AM Bug #7924: add support for creating an empty database

I think you can access the @not-null@ annotation when configuring the index components.
* in index components are ... Ovidiu Maxiniuc

02:15 AM Bug #7496: finish support for query:forward-only attribute

After taking the minimal test case and looking into it, I noted the following:
* with no changes, the cursor already... Dănuț Filimon

01:02 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

The fix for #6628-214 and my mentions from #6628-215 were committed to *6628c/rev.14964*. Dănuț Filimon

02/01/2024

05:04 PM Feature #7382 (Test): Check performance of delete from vs drop table in H2

That is great. These changes are already in the H2 trunk - I will move this into Test. Alexandru Lungu

08:47 AM Feature #7382: Check performance of delete from vs drop table in H2

I ran the tests, and there were no more tests that failed compared to the baseline. Alexandru Donica

05:03 PM Feature #6496: add equivalent support for -trig command line option

AFAIK, these were tested on a large customer application regression tests and POC by actually setting the flag and de... Alexandru Lungu

09:26 AM Feature #6496 (Internal Test): add equivalent support for -trig command line option

What testing remains? Greg Shah

01:28 PM Bug #7924: add support for creating an empty database

The order in the ruleset does not matter too much (in this case), but the structure of the tree will drive the rules ... Greg Shah

05:25 AM Bug #7924: add support for creating an empty database

I've looked into @DDLGeneratorWorker@ and how we can make use of the @mandatory@ and while debugging the conversion I... Dănuț Filimon

11:47 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Dănuț Filimon wrote:
> POC regression testing is ok with those changes.
Danut, in which branch are these fixes? C... Eric Faulhaber

04:49 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

POC regression testing is ok with those changes. Dănuț Filimon

03:07 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

I've looked into #6628-214 and fixed all the problems except the renamed file. I also looked in detail at all classes... Dănuț Filimon

07:46 AM Bug #8196 (Test): Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.act...

Branch 8196a was merged into trunk as rev.14961 and archived. Dănuț Filimon

07:28 AM Bug #8196 (Merge Pending): Reduce number of AbstractTempTable._hasRecords calls to avoid BufferMa...

8196a can merge after 8107a. Greg Shah

03:29 AM Bug #8196: Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.activeBuffers

This is good news. The changes are quite safe from my POV.
This is ready for merge. Greg, this is a performance im... Alexandru Lungu

01/31/2024

04:09 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

There are still some things to fix in r14958:
* both @FWDPostgreSQLConnectionCustomizer@ and @FWDMariaDBConnectionCu... Ovidiu Maxiniuc

10:34 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Branch 6628b was merged to trunk as rev.14958 and archived. Dănuț Filimon

09:45 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

> Create 6628b, hotfix and merge it?
Yes, go ahead now. Greg Shah

08:48 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

I've made a mistake while rebasing 6628a and changed @int rowSize = rowStructures.size();@ to @int rowSize = rowStruc... Dănuț Filimon

06:53 AM Feature #6628 (Test): port PostgreSQL native user defined functions to MariaDB

Branch 6628a was merged to trunk as rev.14956 and archived. Dănuț Filimon

06:30 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

You can merge now. Greg Shah

02:25 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

@guarded.sql@ is the latest version obtained after executing the command mentioned in #6628-202.
Greg, let me know... Dănuț Filimon

11:20 AM Feature #6496: add equivalent support for -trig command line option

Sorry for mistaking the files.
Commited change to branch 6496b rev 14945. Alexandru Donica

09:58 AM Feature #6496: add equivalent support for -trig command line option

Code review 6496b. The @SourceNameMapper@ changes look good. Just please update the copyright year in @StartupParamet... Hynek Cihlar

06:34 AM Feature #6496: add equivalent support for -trig command line option

Ovidiu Maxiniuc wrote:
> +Review of 6496b rev 14943.+
> * @DatabaseTriggerManager.java@
> ** line 270: if the co... Alexandru Donica

06:32 AM Feature #6496: add equivalent support for -trig command line option

Hynek: Please review the @SourceNameMapper@ changes. Greg Shah

04:38 AM Feature #6496: add equivalent support for -trig command line option

Alexandru [ad], please address the review. We need to get this merged asap. Alexandru Lungu

07:07 AM Bug #8196: Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.activeBuffers

POC regression tests passed and the results of the performance tests showed an improvement of *5.27%* for the average... Dănuț Filimon

04:37 AM Feature #7382 (Internal Test): Check performance of delete from vs drop table in H2

I am OK with the changes; merged 7382a_h2 to FWD-H2 trunk as rev. 40. Archived 7382a_h2.
Alexandru [ad], please pi... Alexandru Lungu

01/30/2024

05:59 PM Feature #6496: add equivalent support for -trig command line option

+Review of 6496b rev 14943.+
* the copyright year must be updated (and the branch rebased) in each altered file;
... Ovidiu Maxiniuc

03:50 PM Feature #6496: add equivalent support for -trig command line option

Alexandru Donica wrote:
> Commited to branch 6496b rev 14943.
Ovidiu, please review, at least the trigger impleme... Eric Faulhaber

05:39 PM Feature #6628 (Merge Pending): port PostgreSQL native user defined functions to MariaDB

If @guarded.sql@ was manually committed before, please do the same with the latest version generated from @udfs.sql@ ... Eric Faulhaber

12:50 PM Feature #6825: improve table meta runtime (TableMapper and other)

Alexandru [ad], AFAIK, you already have some changes on @TableMapper@ to improve @BufferFieldImpl.asP2JField@. This i... Alexandru Lungu

11:12 AM Bug #8214: Split Persister into SQLPersister and InMemoryPersister

I attempted to test my changes on 8214a and 8214a_h2 but got no viable improvement. Interestingly, 80% of the updates... Alexandru Lungu

10:01 AM Bug #7167 (Closed): Associating records from opened buffers to new sessions is slow

I understand the work begun here is being continued in #8196. Eric Faulhaber

08:31 AM Bug #8196: Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.activeBuffers

Alexandru Lungu wrote:
> The changes look good to me!
> Danut, you can inline @isActiveBuffer@ by doing @return <la... Dănuț Filimon

08:19 AM Bug #8196 (Internal Test): Reduce number of AbstractTempTable._hasRecords calls to avoid BufferMa...

The changes look good to me!
Danut, you can inline @isActiveBuffer@ by doing @return <large-if-condition> && buffer.... Alexandru Lungu

07:06 AM Bug #8196: Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.activeBuffers

*Committed 8196a/rev.14937*. I've created a separate method to check each buffer individually and it can be used dire... Dănuț Filimon

06:26 AM Bug #8196: Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.activeBuffers

Note that @activeBuffers@ iterates @RecordBuffer@ while we want to iterate @Buffer@ instances, so those need to be ca... Dănuț Filimon

05:38 AM Bug #8196: Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.activeBuffers

I suspect the code duplicate to be quite bad architecturally.
Lets overload @activeBuffers(Persistence, boolean)@ ... Alexandru Lungu

04:55 AM Bug #7496: finish support for query:forward-only attribute

Alexandru Lungu wrote:
> Danut, can you cut-out it even more.
>
> 1. Please check if this can be reproduced with... Dănuț Filimon

04:14 AM Bug #7496: finish support for query:forward-only attribute

Danut, can you cut-out it even more.
1. Please check if this can be reproduced with temp-tables - it is a bit eas... Alexandru Lungu

03:48 AM Bug #7496: finish support for query:forward-only attribute

*Rebased 7496a* with *trunk/rev.14950*. *7496a* is not at revision *14959*. I also committed the adjustments which fi... Dănuț Filimon

04:43 AM Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries

Alexandru Lungu wrote:
> I see changes in @database_access.rules@. Are these mandatory and require reconversion?
... Eduard Soltan

04:37 AM Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries

Eduard, I rebased 7999a to latest trunk. It is now at rev. 14958. Please do the testing of it with POC and a large cu... Alexandru Lungu

04:19 AM Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries

Committed on 7999a, revision 14837.
Addressed review in #7999-7. Also for second case in #7999-1, with @DEFINE QUE... Eduard Soltan

02:31 AM Bug #7924 (WIP): add support for creating an empty database

Ovidiu Maxiniuc wrote:
> Indeed, the @addr_id integer not null@ column should not create @(addr_id_null, addr_id)@ p... Dănuț Filimon

01/29/2024

05:09 PM Bug #7924: add support for creating an empty database

Dănuț Filimon wrote:
> Ovidiu Maxiniuc wrote:
> > As noted in my previous note, this is the cause of the failure: t... Ovidiu Maxiniuc

05:05 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Alexandru Lungu wrote:
> Danut, any other testing required?
There is no testing left that I can do. Currently ChUI ... Dănuț Filimon

04:58 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Danut, any other testing required?
Beside the history entry fixes, what about the @guarded.sql@ - was it generated... Alexandru Lungu

01/26/2024

10:50 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Can we merge this to trunk? Greg Shah

10:06 AM Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries

Eduard, please address the review to get this done. Alexandru Lungu

05:38 AM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...

I retested the changes (the patch from #6714-14) but had to make two small adjustments:
* The usage of the @Procedur... Dănuț Filimon

01/25/2024

03:36 PM Bug #8214: Split Persister into SQLPersister and InMemoryPersister

Eric Faulhaber wrote:
> In the absence of the @force-no-undo-temp-tables@ configuration option being set to @true@, ... Alexandru Lungu

01:23 PM Bug #8214: Split Persister into SQLPersister and InMemoryPersister

In the absence of the @force-no-undo-temp-tables@ configuration option being set to @true@, any transaction on the @_... Eric Faulhaber

06:39 AM Bug #8214 (WIP): Split Persister into SQLPersister and InMemoryPersister

Comitted 8214a_h2 the changes in FWD-H2 to do update on a single column using direct-access.
I also have the FWD cha... Alexandru Lungu

07:51 AM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...

Eric Faulhaber wrote:
> Can this be closed? Is there anything to be reviewed and used from this task, or has it been... Dănuț Filimon

05:54 AM Feature #7382 (Review): Check performance of delete from vs drop table in H2

With the changes you mentioned, the amount of time spent iterating in 100 runs of the performance tests went down fro... Alexandru Donica

05:10 AM Bug #7252 (WIP): Use direct-access to support for-each queries without WHERE and BY clauses

I'll move this back to WIP because I encounter a NPE in @DataSetSDOHelper.getDataObjects@ in a test. I'm looking into... Radu Apetrii

04:06 AM Feature #6496 (Review): add equivalent support for -trig command line option

Commited to branch 6496b rev 14943. Alexandru Donica

09:28 PM Feature #7020: always use "expanded" extent fields

Constantin, besides me taking forever to review 7020b, we still have the issue with the Client Proxy generation block... Eric Faulhaber

01/24/2024

10:07 AM Bug #8214: Split Persister into SQLPersister and InMemoryPersister

I agree with you Greg, @.batch@ itself is a very useful construct if you want to update a single record on multiple f... Alexandru Lungu

09:12 AM Bug #8214: Split Persister into SQLPersister and InMemoryPersister

Long ago, the 4GL was changed to implement the @ASSIGN@ statement. One important reason (maybe *the* important reaso... Greg Shah

02:22 AM Bug #8214: Split Persister into SQLPersister and InMemoryPersister

I constantly see @Proxy.set...@ in the top bottlenecks we have in the FWD API. This is not because they are really sl... Alexandru Lungu

02:12 AM Bug #8214 (WIP): Split Persister into SQLPersister and InMemoryPersister

Alexandru Lungu

02:06 AM Support #6679 (Internal Test): H2 general performance tuning

This task didn't have quite a well-define purpose. It was mostly "do your best improving H2". I can't appreciate a pr... Alexandru Lungu

01/23/2024

04:44 PM Bug #6829 (Closed): H2 forces re-parse of all prepared statements when metadata is changed

There is no customer-specific testing for this improvement; any bugs will be dealt with separately. Accordingly, I'm ... Eric Faulhaber

04:38 PM Feature #6830 (Closed): find and fix all SQL SELECT statements with inlined literal arguments, an...

Eric Faulhaber

04:36 PM Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...

Can this be closed? Is there anything to be reviewed and used from this task, or has it been absorbed/superseded by s... Eric Faulhaber

04:33 PM Support #4702 (Closed): write temp-table performance test cases

I think this task has served its purpose in guiding our performance work with H2. Eric Faulhaber

04:31 PM Bug #4057: h2 performance degradation

Can we close this task? Eric Faulhaber

04:29 PM Support #6679: H2 general performance tuning

We have long since decided not to move ahead with MVStore, and we have made a significant investment in improving H2 ... Eric Faulhaber

02:08 PM Bug #8212: FILL operations do not work correctly with active dataset relations

While working on #8178 I noticed some differences in the way FWD populates the database when there are active dataset... Ovidiu Maxiniuc

01:59 PM Bug #8212 (New): FILL operations do not work correctly with active dataset relations

Ovidiu Maxiniuc

12:28 PM Feature #4722 (Test): data import should be able to run with only the converted application jar f...

Roger Borrello

09:16 AM Feature #4722: data import should be able to run with only the converted application jar file (an...

Branch 4722c was merged to trunk at revision 14942 and was archived. Roger Borrello

09:01 AM Feature #4722: data import should be able to run with only the converted application jar file (an...

You can merge to trunk now. Greg Shah

08:56 AM Feature #4722: data import should be able to run with only the converted application jar file (an...

Branch 4722c was rebased to trunk_14941 and is at revision 14942.
I believe this is ready for merge. Roger Borrello

12:22 PM Bug #7448 (Rejected): Optimize FWD-H2 ValueTimestampTimeZone and maybe avoid caching

Greg Shah

08:32 AM Bug #7448: Optimize FWD-H2 ValueTimestampTimeZone and maybe avoid caching

I am ok with rejecting this task. Alexandru Donica

03:59 AM Bug #7448: Optimize FWD-H2 ValueTimestampTimeZone and maybe avoid caching

According to your findings, I think we can reject this task. The improvement is too small to tackle this. T
If Ale... Alexandru Lungu

10:43 AM Feature #6496: add equivalent support for -trig command line option

Alexandru [ad], 7156b is mostly like a fast-paced trunk. We periodically rebase it. We only commit hot patches there.... Alexandru Lungu

09:32 AM Feature #6496: add equivalent support for -trig command line option

I tested large app and performance tests with and without changes. The performance tests did not seem to have many tr... Alexandru Donica

10:03 AM Bug #7252 (Review): Use direct-access to support for-each queries without WHERE and BY clauses

I've committed to both 7252b and 7252b_h2 the following things:
* 7252b *rev. 14933* - Added attempt to solve a Sele... Radu Apetrii

09:22 AM Feature #7382: Check performance of delete from vs drop table in H2

7382a is branched for trunk, ready to be merged. If you want to test, you need to manually port the changes to 7156b.... Alexandru Lungu

08:36 AM Feature #7382: Check performance of delete from vs drop table in H2

Very well I will try to improve @Update@, but before that, should the branch 7382a be a copy of the trunk, or of bran... Alexandru Donica

06:29 AM Feature #7382: Check performance of delete from vs drop table in H2

Alexandru [ad], I also notices a slight performance improvement possibility in @Update@. There is a @setClauseCols@ b... Alexandru Lungu

03:58 AM Feature #7382: Check performance of delete from vs drop table in H2

I think we can go ahead with this improvement. Even if it is small, it looks like it is quite risk free and easy to i... Alexandru Lungu

03:35 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

I fixed the history entries in *6628a/rev.14937*. Dănuț Filimon

03:19 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

I've looked at 6628a rev 14936 and I think we need to solve this before merging into 7156b/trunk:
* @FWDPostgreSQLCo... Constantin Asofiei

03:00 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

There is no difference. Dănuț Filimon

02:06 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Danut, can you make a diff between the DDL without 6628a and the ones with 6628a? Alexandru Lungu

02:05 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Constantin Asofiei wrote:
> Danut, did you re-generate the DDLs for the #7156 POC app, when you did the tests?
I on... Dănuț Filimon

02:04 AM Feature #7020: always use "expanded" extent fields

Ovidiu, can you rebase 7020b? I will like to pick it up and do some review / tests / profiling with it. Alexandru Lungu

01/22/2024

10:35 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Danut, did you re-generate the DDLs for the #7156 POC app, when you did the tests? Constantin Asofiei

03:01 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Rebased *6628a* with *trunk/rev.14934*. *6628a* is now at revision *14936*. Dănuț Filimon

09:05 AM Bug #6829 (Test): H2 forces re-parse of all prepared statements when metadata is changed

*6829a* was merged intro trunk as revision *14939* and archived. Dănuț Filimon

08:54 AM Bug #6829 (Merge Pending): H2 forces re-parse of all prepared statements when metadata is changed

OK Greg Shah

08:52 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

I am merging 6829a right now. Dănuț Filimon

08:46 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

It can be merged quickly if the testing is complete. Greg Shah

08:44 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

I am OK with the changes. As long as they are well-tested, we can do the merge. Alexandru Lungu

06:57 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

Alexandru Lungu wrote:
> Lets go ahead with the change. Please create a FWD branch and commit the change only for te... Dănuț Filimon

05:59 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

Lets go ahead with the change. Please create a FWD branch and commit the change only for temporary H2 database. Alexandru Lungu

05:49 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

I ran POC regression tests, smoke tested a large customer application and also ran ChUI regression tests. There are n... Dănuț Filimon

08:50 AM Bug #8196 (Review): Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.a...

*Committed 8196a/rev.14936*. Removed the call to @activeBuffers@ from @AbstractTempTable._hasRecords@ and integrated ... Dănuț Filimon

07:21 AM Bug #8196: Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.activeBuffers

Created 8196a. Dănuț Filimon

01/19/2024

06:54 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

The Docker implementation is the most stringent user of this data import feature, so while this is partially docker r... Roger Borrello

06:54 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Greg Shah wrote:
> Please test in a non-Docker environment.
It works in a normal environment. Roger Borrello

05:46 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Please test in a non-Docker environment. Greg Shah

05:36 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

My testing is complete. There is now a multi-container configuration (server/client and postgres) for hotel_gui. Ther... Roger Borrello

04:52 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Greg Shah wrote:
> What testing is needed?
I've built some docker images using the branch, and I'm working on the... Roger Borrello

04:13 PM Feature #4722 (Internal Test): data import should be able to run with only the converted applicat...

Code Review Task Branch 4722c Revision 14935
The changes seem fine. What testing is needed? Greg Shah

03:50 PM Feature #4722 (Review): data import should be able to run with only the converted application jar...

Revision 14935 is ready for review. This holds up the ability to use a multi-container environment. Roger Borrello

03:41 PM Feature #4722 (WIP): data import should be able to run with only the converted application jar fi...

I created a new branch *4722c* due to an issue when attempting to run @import.sh@ in a container. The *createdb* is n... Roger Borrello

10:49 AM Support #4701 (Closed): try to improve H2 transaction commit performance

Eric Faulhaber

03:22 AM Support #4701: try to improve H2 transaction commit performance

This can be closed. Alexandru Lungu

01:23 AM Support #4701: try to improve H2 transaction commit performance

Is there anything left to do on this task, or can we consider the goals met? Eric Faulhaber

10:10 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Thank you! Please rebase 6628a or port over the latest trunk, whichever is easier. We will need to regression test th... Eric Faulhaber

05:26 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Added the changes from *6628a/rev.14614-14615* on top of *7156b/rev.14933*. I ran the regression tests and got betwee... Dănuț Filimon

02:07 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Alexandru Lungu wrote:
> Danut already has the large application set-up with MariaDB lenient and can do the regressi... Dănuț Filimon

02:04 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

There are runtime changes and SQL UDF changes in this branch. Since the UDFs have changed, they need to be (re-)insta... Eric Faulhaber

02:00 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Sure!
Danut already has the large application set-up with MariaDB lenient and can do the regression tests. Priorit... Alexandru Lungu

01:54 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Alexandru, can you please assign this to someone on your team who has set up (or can) the large application environme... Eric Faulhaber

09:53 AM Feature #6496: add equivalent support for -trig command line option

I made a copy of 7156b and put my changes there, merged the changes to @SourceNameMapper@ that interfered with my cha... Alexandru Donica

02:11 AM Feature #6496 (Internal Test): add equivalent support for -trig command line option

Alexandru, please test the large application with this parameter you introduced:
* check there are no regressions wi... Alexandru Lungu

01:13 AM Feature #6496: add equivalent support for -trig command line option

Alexandru [either one ;)]: what is left to do to push this task over the finish line? Eric Faulhaber

09:02 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses

I've created branches 7252b and 7252b_h2 for the experiment with the @SelectAll@ class. Radu Apetrii

07:58 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

These are great news. Please do extensive testing: focus on smoke testing another customer application and regression... Alexandru Lungu

07:51 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

Alexandru Lungu wrote:
> Danut, please analyze performance with NEVER_RECOMPILE. I don't recall if we have something... Dănuț Filimon

02:14 AM Bug #6829 (Internal Test): H2 forces re-parse of all prepared statements when metadata is changed

Recently, we done some changes that prevented us from using a "NEVER_RECOMPILE" kind of option. Back in #6829-1, it w... Alexandru Lungu

01:22 AM Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

Can this task be closed? Eric Faulhaber

05:15 AM Feature #6816 (Internal Test): improve PreselectQuery.assembleHQL

Alexandru Lungu

05:15 AM Feature #6816: improve PreselectQuery.assembleHQL

I am dumping some statistics with LTW right now. I will let you know if I continue seeing something obvious here. Alexandru Lungu

05:05 AM Feature #6816: improve PreselectQuery.assembleHQL

Give me a bit of time to check @PreselectQuery.assembleFQL@, maybe I can notice something else. I'm not sure if Alex ... Radu Apetrii

01:37 AM Feature #6816: improve PreselectQuery.assembleHQL

The changes implemented for this task have long since made their way into trunk. It is still marked 40% done. Is ther... Eric Faulhaber

03:21 AM Feature #6720: lazy hydration

On the POC, it regresses and crashes. I didn't attempt the tests on the new test suite. Alexandru Lungu

01:29 AM Feature #6720: lazy hydration

Is this far enough along that we can measure performance, or are the regressions blocking testing? We need to underst... Eric Faulhaber

02:43 AM Bug #6887: improve performance of dataset/table[-handle] parameters

Constantin, does it makes sense to do one more pass with JMX to see what the 3 cases which stood out earlier look lik... Eric Faulhaber

02:06 AM Feature #6414 (Closed): ERROR attribute for buffer, dataset and temp-table

Eric Faulhaber

01:43 AM Bug #7138 (Closed): Short circuit fake-update (update with a new value eqaul to the old value) in H2

I am closing this. Let me know if there is a reason it should remain open. We have done our internal testing and ther... Eric Faulhaber

01:26 AM Feature #6928 (Closed): H2 UPDATE performance improvement

I am closing this. I think 11 months of testing is probably sufficient :) Eric Faulhaber

01/18/2024

09:32 AM Feature #7382: Check performance of delete from vs drop table in H2

1. @8591 ms@ for @939_203@ deletes (classic execution, all deletes)
5. @7672 ms@ for @935_965@ deletes (optimized ex... Alexandru Donica

04:05 AM Feature #7382: Check performance of delete from vs drop table in H2

well 5 = 4 + 3. and 1 = 2 + 3.
(don't read this out of context) Alexandru Donica

03:40 AM Feature #7382: Check performance of delete from vs drop table in H2

Lets presume that A is the set of *all* deletes and C is the set of "candidate" deletes (the ones that *can* be optim... Alexandru Lungu

03:25 AM Feature #7382: Check performance of delete from vs drop table in H2

Alexandru Lungu wrote:
> * Total and Avg. time for classic deletes
> * Total and Avg. time for fast deletes
> * To... Alexandru Donica