Activity
From 03/05/2024 to 04/03/2024
04/01/2024
- 08:49 AM Bug #8554: resolving temp-tables in a class hierarchy
- @DATASET:CREATE-LIKE("<dataset-name>")@ needs to be checked, too.
03/31/2024
- 10:35 AM Bug #8554: resolving temp-tables in a class hierarchy
- There are some problems when resolving temp-tables in a hierarchy.
* @oo.Test1@:... - 10:28 AM Bug #8554 (Test): resolving temp-tables in a class hierarchy
03/27/2024
- 11:39 AM Bug #8249: Introduce a fast fill method to optimize Dataset.fill
- With 8363f where @DATASET:FILL@ is optimized to use @hintFullResults@, this test fails if @AdaptiveQuery.hintFullResu...
03/25/2024
- 02:53 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- There should be a distinction between equality check when updating/inserting and the equality check when querying. We...
03/22/2024
- 01:36 PM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Well, this is pretty bad in my opinion. I don't really have a solution for this, I need to think this through a bit m...
- 05:07 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Radu Apetrii wrote:
> Constantin Asofiei wrote:
> > The problem is this happens only when we do a unique validation... - 04:22 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Alexandru Lungu wrote:
> Merged to trunk as rev. 15085.
Please post to #7847 also. - 04:16 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Constantin Asofiei wrote:
> The problem is this happens only when we do a unique validation using SELECT, and not on... - 04:10 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Merged to trunk as rev. 15085.
- 04:04 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Created 8459b and committed the disable for USE_NULL_EQUALITY.
Preparing for merge with trunk. - 03:55 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- ...
- 03:52 AM Bug #8459 (WIP): investigate changing H2 to allow NULL to equal NULL (and the impact on the other...
- There is a regression in #7143-784 related to the NULL changes in H2. If I comment @use_null_equality=true;@, then t...
- 09:37 AM Bug #8496: investigate if a 'batch insert with deactivated index' in H2 is possible
- Constantin Asofiei wrote:
> The idea is to have a mode in H2 where indexes are not *updated(?) after each insert*. ... - 07:44 AM Bug #8496: investigate if a 'batch insert with deactivated index' in H2 is possible
- Constantin, for FILL we do 50k independent inserts. Can we maybe bulk them? Or do we actually need the intermediate s...
- 09:27 AM Bug #8500 (Test): dataset:set-buffers must use default-buffer-handle if a temp-table handle is used
- 09:27 AM Bug #8500: dataset:set-buffers must use default-buffer-handle if a temp-table handle is used
- Branch 8500a was merged into trunk as rev. 15086 and archived.
- 09:23 AM Bug #8500: dataset:set-buffers must use default-buffer-handle if a temp-table handle is used
- Cor, please use this archive.
- 09:19 AM Bug #8500 (Merge Pending): dataset:set-buffers must use default-buffer-handle if a temp-table han...
- Created task branch 8500a from trunk rev 15085.
Ref 15086 fixes:
* @SET-BUFFERS(handle...)@ must use the DEFAULT... - 09:13 AM Bug #8500 (Test): dataset:set-buffers must use default-buffer-handle if a temp-table handle is used
03/21/2024
- 03:32 PM Feature #7366: improve performance of buffer.fill
- Idea of improvements:
* the data-source query may or may not use all record fields, depending on the mapping. We ca... - 02:55 PM Bug #8496: investigate if a 'batch insert with deactivated index' in H2 is possible
- Above 're-balance' actually means re-building the index... so this may be expensive on its own.
- 02:52 PM Bug #8496: investigate if a 'batch insert with deactivated index' in H2 is possible
- There are operations where we do lots of inserts. In some case, in a FILL operation, some 50k temp-table records are...
- 02:43 PM Bug #8496 (New): investigate if a 'batch insert with deactivated index' in H2 is possible
- 02:47 PM Bug #8451 (Test): improve performance of H2 String column comparison
- 02:23 PM Bug #8451: improve performance of H2 String column comparison
- Branch 8451a was created from trunk rev 15082. Rev 15083 contains the FWD-H2 build.gradle upgrade to rev 1.43.
Br... - 02:13 PM Bug #8451 (Merge Pending): improve performance of H2 String column comparison
- ETF testing passed, starting merge.
- 07:58 AM Bug #8451: improve performance of H2 String column comparison
- Greg Shah wrote:
> Is more testing needed?
I'm doing ETF testing with it. - 02:27 PM Bug #8488 (Test): improve performance of WRITE-JSON
- Branch 8488a was merged into trunk as rev. 15084 and archived.
- 02:24 PM Bug #8488 (Merge Pending): improve performance of WRITE-JSON
- Merging now.
- 12:42 PM Bug #8488: improve performance of WRITE-JSON
- I have re-review the 8488a up to r15080 and I am OK with the changes.
The branch can be merged to trunk. - 11:08 AM Bug #8488: improve performance of WRITE-JSON
- I'm good with that plan.
- 10:59 AM Bug #8488 (Internal Test): improve performance of WRITE-JSON
- There are regressions related to AdaptiveFind (from #8490), otherwise 8488a and #8451 passed.
I'm testing #8459 ne... - 07:57 AM Bug #8488 (Review): improve performance of WRITE-JSON
- 07:42 AM Bug #8488: improve performance of WRITE-JSON
- Ovidiu, in rev 15080 I have the review fixes. See bellow for notes:
> * In @P2JQuery.java@, you added @public defau... - 02:12 PM Bug #8459 (Test): investigate changing H2 to allow NULL to equal NULL (and the impact on the othe...
- Branch 8459a was merged into trunk as rev. 15082 and archived.
- 02:04 PM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- I've started merge of 8459a.
- 06:29 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- fwd-h2 1.42 is on projsrv01.
- 05:42 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Constantin Asofiei wrote:
> Alexandru, I'm good.
>
> Radu: if unit tests/standalone tests are OK, please build fw... - 05:20 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Alexandru, I'm good.
Radu: if unit tests/standalone tests are OK, please build fwd-h2 and upload it to @devsrv01:/... - 03:48 AM Bug #8459 (Internal Test): investigate changing H2 to allow NULL to equal NULL (and the impact on...
- The unit tests in H2 suffice. I think you are good to go with the merge of 8459a_h2.
Constantin, anything to add h... - 03:43 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Alexandru Lungu wrote:
> What about simple comparison with @EQUAL@ (instead of 0) and @NON_EQUAL@ (instead of 5)? Am... - 03:35 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- What about simple comparison with @EQUAL@ (instead of 0) and @NON_EQUAL@ (instead of 5)? Am I missing something?
- 09:30 AM Feature #8494: rework XmlExport with the performance improvements from JsonExport
- Implement the same performance improvements as were done in #8488.
- 09:29 AM Feature #8494 (New): rework XmlExport with the performance improvements from JsonExport
- 08:43 AM Feature #7323 (Test): Implement soft unique index in FWD-H2
- Got it!
- 08:43 AM Feature #7323: Implement soft unique index in FWD-H2
- Branch 7323b was merged into trunk as rev. 15075 and archived.
- 08:41 AM Feature #7323: Implement soft unique index in FWD-H2
- Constantin, unless you started the process, I will prepare for merge in ~10 mins.
03/20/2024
- 06:51 PM Bug #8488: improve performance of WRITE-JSON
- Constantin Asofiei wrote:
> Ovidiu, an early review is appreciated - I still need to regression test in standalone t... - 03:52 PM Bug #8488 (WIP): improve performance of WRITE-JSON
- Created branch 8488a from trunk rev 15077. In rev 15088 there are performance improvements for WRITE-JSON:
* Avoid ... - 12:25 PM Bug #8488 (Test): improve performance of WRITE-JSON
- 04:54 PM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Alexandru Lungu wrote:
> Can we replace these with something more suggestive. Are these EQUAL and NON_EQUAL, or some... - 03:24 PM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- I am OK with 8459a_h2 changes. Good addition with the unit test!
The @getValue@ looks right to me. The only concer... - 11:05 AM Feature #7323 (Merge Pending): Implement soft unique index in FWD-H2
- You can merge to trunk now.
- 10:50 AM Feature #7323: Implement soft unique index in FWD-H2
- Greg Shah wrote:
> What testing is needed?
I've tested with the #8363 app and there is no regression in performance... - 07:36 AM Feature #7323 (Internal Test): Implement soft unique index in FWD-H2
- What testing is needed?
- 06:47 AM Feature #7323: Implement soft unique index in FWD-H2
- Alexandru, I agree, the change is in 7323b rev 15075.
- 05:30 AM Feature #7323: Implement soft unique index in FWD-H2
- Then I agree with Constantin's changes. Before, the 7323a changes, the flush (so the DB validation0 was done only if ...
- 04:48 AM Feature #7323: Implement soft unique index in FWD-H2
- Alexandru Lungu wrote:
> Radu/Constantin: can you share how the condition looked like before the 7323a changes?
Thi... - 04:40 AM Feature #7323: Implement soft unique index in FWD-H2
- AFAIK, the condition there was rewritten to consider DBUniqueCheck, but remain equivalent to what was before. I prefe...
- 02:58 AM Feature #7323 (Review): Implement soft unique index in FWD-H2
- Created task 7323b from trunk rev 15073. The fix in previous note is in rev 15074. Please review.
- 08:52 AM Bug #8451 (Internal Test): improve performance of H2 String column comparison
- Is more testing needed?
- 07:53 AM Bug #8451: improve performance of H2 String column comparison
- The changes are good:
* Good job in leveraging the @collationKeys@ caches with this @ValueString@ ci/cs keys.
* I... - 07:43 AM Bug #8451: improve performance of H2 String column comparison
- Checking out now.
- 07:15 AM Bug #8451: improve performance of H2 String column comparison
- Alexandru: can you review this today?
Greg: if review is OK, I'd like to get this merged. - 08:43 PM Bug #7645: Simplify _meta database initialization by removing <schema>.meta.xml resource
- The hotel project built without any issues, without any additional changes. The @.meta.xml@ files had been generated ...
03/19/2024
- 06:58 PM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- I've committed to 8459a_h2 rev. 43 changes that include:
* Added a case for handling equality between a null compone... - 04:03 PM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Also, one more thing. In @Comparison.getValue@, depending on the @compareType@ value, things should be treated for bo...
- 03:11 PM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- I am OK with the changes in 8459a (FWD branch).
For FWD-H2:
* In @compare@, you need to also explicitly handle th... - 01:19 PM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Radu Apetrii wrote:
> Constantin Asofiei wrote:
> > Please rebase both 8459a_h2 and 8459a.
> On it.
Done. 8459a r... - 01:16 PM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Who should be doing the review?
- 12:57 PM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Constantin Asofiei wrote:
> Please rebase both 8459a_h2 and 8459a.
On it.
- 12:56 PM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Please rebase both 8459a_h2 and 8459a.
- 12:50 PM Bug #8459 (Review): investigate changing H2 to allow NULL to equal NULL (and the impact on the ot...
- Constantin Asofiei wrote:
> Radu, do you have the FWD and H2 changes, for some early testing?
Yes, sorry for the de... - 12:20 PM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Radu, do you have the FWD and H2 changes, for some early testing?
- 04:09 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Radu Apetrii wrote:
> Alexandru Lungu wrote:
> > Create a flag like in the [[internal-documentation:H2_Database_For... - 04:05 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Alexandru Lungu wrote:
> Create a flag like in the [[internal-documentation:H2_Database_Fork]] Wiki and use it to di... - 04:09 PM Bug #7645: Simplify _meta database initialization by removing <schema>.meta.xml resource
- Eugenie Lyzenko wrote:
> Ovidiu Maxiniuc wrote:
> > Branch 7645a was merged into trunk as rev. 15070 and archived.
... - 03:06 PM Bug #7645: Simplify _meta database initialization by removing <schema>.meta.xml resource
- Ovidiu Maxiniuc wrote:
> Branch 7645a was merged into trunk as rev. 15070 and archived.
>
> Reconversion is not m... - 02:01 PM Bug #7645 (Test): Simplify _meta database initialization by removing <schema>.meta.xml resource
- Branch 7645a was merged into trunk as rev. 15070 and archived.
Reconversion is not mandatory. But if done the @<db... - 01:52 PM Feature #7323: Implement soft unique index in FWD-H2
- Found a regression in 7323a changes:...
- 10:31 AM Feature #7323 (Test): Implement soft unique index in FWD-H2
- Branch 7323a was merged into trunk as rev. 15065 and archived.
7323b_h2 was merged into FWD-H2 trunk rev 41 and ar... - 10:11 AM Feature #7323: Implement soft unique index in FWD-H2
- Yes, working on it.
- 09:52 AM Feature #7323: Implement soft unique index in FWD-H2
- Constantin, you need to merge H2 first, build, upload the FWD binary, commit to the FWD branch the upgrade and *after...
- 09:27 AM Feature #7323 (Merge Pending): Implement soft unique index in FWD-H2
- You can merge now.
- 04:18 AM Feature #7323: Implement soft unique index in FWD-H2
- *Review of 7323b_h2*
* I reviewed Radu's changes in the past and they were OK.
* Recent changes are fine to me. I... - 12:36 AM Feature #7323: Implement soft unique index in FWD-H2
- Code review 7323a/15068:
The changes look ok to me, though it is a little confusing that the SOFT_INDEX keyword is... - 12:15 PM Bug #8451 (Review): improve performance of H2 String column comparison
- Created 8451a_h2 from fwd-h2 trunk rev 41. In rev 42, I've implemented the idea in #8451-5 - cache the collation key...
03/18/2024
- 06:35 AM Bug #8451: improve performance of H2 String column comparison
- Please go ahead. I am quite -stuck- working with some heap dumps and #8380 at the moment.
- 06:09 AM Bug #8451: improve performance of H2 String column comparison
- Alexandru, the idea sounds promising - I can make the changes if you are busy with something else.
- 06:00 AM Bug #8451: improve performance of H2 String column comparison
- The idea I have for this task:
* As most of the (string) comparisons involve 1 or even 2 database fields, I sugges... - 05:35 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Radu, I think we should restrict this with a flag. H2 is used with other goals in FWD and I don't what to make this c...
- 05:34 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Radu Apetrii wrote:
> Alex/Constantin: Was the phrase @tt1.f1 is null@ added just for the H2 dialect, or is this nul... - 04:45 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Alex/Constantin: Was the phrase @tt1.f1 is null@ added just for the H2 dialect, or is this null equality an issue in ...
- 03:50 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- I've attached a patch for H2 in order to allow null equality. It certainly needs a review and a set of performance te...
03/17/2024
- 03:04 PM Feature #7323: Implement soft unique index in FWD-H2
- Constantin Asofiei wrote:
> I'm regression testing this with ETF.
ETF testing passed.
As a side note: we may wan... - 12:22 PM Feature #7323: Implement soft unique index in FWD-H2
- Created task branch 7323b_h2 from fwd-h2 trunk rev 40.
In rev 41, it adds a "soft_unique" option for index column...
03/16/2024
- 07:11 AM Feature #7323: Implement soft unique index in FWD-H2
- What we need is to mark the @recid@ trailing component of a 'soft-unique' index as @soft-unique@, too - so this can b...
- 08:47 PM Feature #7323: Implement soft unique index in FWD-H2
- I committed to 7323a rev. 15067 a rebase fix for classes @Persistence@, @Persister@, and @Validation@. It seemed that...
03/15/2024
- 03:23 PM Feature #7323: Implement soft unique index in FWD-H2
- I've placed on @devsrv01:/tmp/7323a_rev_14805_trunk_14789.7z@ the pre-rebase branch, in case you need it.
- 01:06 PM Feature #7323: Implement soft unique index in FWD-H2
- Constantin Asofiei wrote:
> @validateUniqueByQuery@ is still called for temp-tables. Why is that?
This shouldn't b... - 12:30 PM Feature #7323: Implement soft unique index in FWD-H2
- I've discussed this morning with Radu what this task is meant to do and I think I understand it: let H2 throw an exce...
- 01:30 PM Bug #7474: FindQuery provides the wrong result because the record is not updated in the database
- I think I've implemented a fix on this.
The issue was related with a fact, that @RecordNursery@ was only involved in... - 08:29 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- This test shows the 'unknown equality' in OpenEdge:...
- 07:38 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- If you have two big tables and none have indexes, on join, it should do scan on both tables (nested join - N * M comp...
- 07:36 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- Constantin Asofiei wrote:
> will make H2 use the scan index.
Constantin, is there a chance that you can point me to... - 07:03 AM Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
- I created branch 8459a_h2 for this matter.
- 04:12 AM Bug #8459 (WIP): investigate changing H2 to allow NULL to equal NULL (and the impact on the other...
- With #8363, FWD now has a MANDATORY option allowed at temp-table fields. When using joins, this can have a huge impa...
- 04:08 AM Bug #8459 (WIP): investigate changing H2 to allow NULL to equal NULL (and the impact on the other...
03/14/2024
- 03:48 PM Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
- Just to notify - I am still getting a lot of "Failed direct-access due to Error direct accessing for finding record b...
- 10:46 AM Feature #7323: Implement soft unique index in FWD-H2
- Alexandru/Radu, I think we may need a call to discuss the soft index approach.
Radu: I took a look again at 7323a ... - 10:43 AM Bug #8451: improve performance of H2 String column comparison
- When executing the #8363 scenarios, there are ~20 million calls of @CompareModeDefault.comapreString@. This relies o...
- 10:37 AM Bug #8451 (Test): improve performance of H2 String column comparison
03/13/2024
- 12:43 PM Feature #7323: Implement soft unique index in FWD-H2
- I've tested with #8363 and there is no impact or makes things slightly worse in some cases.
- 06:45 AM Feature #7323: Implement soft unique index in FWD-H2
- Radu Apetrii wrote:
> Constantin Asofiei wrote:
> > Radu Apetrii wrote:
> > > Done. Rebased 7323a with trunk rev.1... - 06:42 AM Feature #7323: Implement soft unique index in FWD-H2
- Constantin Asofiei wrote:
> Radu Apetrii wrote:
> > Done. Rebased 7323a with trunk rev.15051, meaning that 7323a is... - 06:36 AM Feature #7323: Implement soft unique index in FWD-H2
- Radu Apetrii wrote:
> Done. Rebased 7323a with trunk rev.15051, meaning that 7323a is now at rev. 15066.
Please che... - 06:34 AM Feature #7323: Implement soft unique index in FWD-H2
- Done. Rebased 7323a with trunk rev.15051, meaning that 7323a is now at rev. 15066.
- 05:14 AM Feature #7323: Implement soft unique index in FWD-H2
- OK, I'll handle this now since I'm waiting for an import anyways.
- 05:10 AM Feature #7323: Implement soft unique index in FWD-H2
- Constantin Asofiei wrote:
> I'm rebasing 7323a and 7323a_h2 to check them with #8363.
7323a_h2 was already merged t... - 04:56 AM Feature #7323: Implement soft unique index in FWD-H2
- I'm rebasing 7323a and 7323a_h2 to check them with #8363.
- 09:22 PM Bug #7645 (Review): Simplify _meta database initialization by removing <schema>.meta.xml resource
- The fixes are done. I also did a bit of cleanup and code maintenance.
Here is a bit of code which dumps the metadata...
03/12/2024
- 03:57 AM Bug #8249: Introduce a fast fill method to optimize Dataset.fill
- The changes in the patch were committed to trunk via 8363a, which was merged to trunk as revision 15049.
- 03:50 AM Bug #7645: Simplify _meta database initialization by removing <schema>.meta.xml resource
- Committed on 7645a, revision 15018.
In this commit I addressed most of the review issues, however I was investigat...
03/11/2024
- 02:16 PM Bug #6997: OUTPUT BY-REFERENCE records are not cleared
- The problem in this task still exists.
03/07/2024
- 02:44 PM Bug #7645 (WIP): Simplify _meta database initialization by removing <schema>.meta.xml resource
- Review of 7645a/15017.
So far, so good. I am OK with the revision, I like the splitting of the code in very specif... - 02:49 AM Bug #8249: Introduce a fast fill method to optimize Dataset.fill
- I've committed the patch to 8363a rev 15038.
- 02:45 AM Bug #8249: Introduce a fast fill method to optimize Dataset.fill
- Hmm, I am not 100% familiar of how the FILL works. I was supposing it can take any arbitrary query to do the fill. So...
- 02:32 AM Bug #8249: Introduce a fast fill method to optimize Dataset.fill
- Alexandru, using the patch helps #8363. But, I wonder if your patch is just something to do the same thing as inject...
03/05/2024
- 10:09 AM Bug #7474: FindQuery provides the wrong result because the record is not updated in the database
- I've hit the issue while working on intra session dirty share - in case record is modified in a transaction different...
- 06:01 AM Bug #8249: Introduce a fast fill method to optimize Dataset.fill
- Constantin, this is the patch I used in an attempt to optimize @ProgressiveResults@ into @ScrollingResults@ when usin...
Also available in: Atom