Project

General

Profile

Activity

From 04/17/2025 to 05/16/2025

05/16/2025

06:31 PM Bug #9969: Parsing query string error with \r character.
After upgrading to trunk 15913 (including 15910), the antlr build target results in a lot (30+) of nondeterminism err... Ovidiu Maxiniuc
10:04 AM Bug #9969: Parsing query string error with \r character.
Constantin Asofiei wrote:
> I think we need to handle and escape all control characters - see https://www.ascii-code...
Octavian Adrian Gavril
10:00 AM Bug #9969: Parsing query string error with \r character.
I think we need to handle and escape all control characters - see https://www.ascii-code.com/characters/control-chara... Constantin Asofiei
09:55 AM Bug #9969: Parsing query string error with \r character.
This is more related to #8027 than this task. Octavian Adrian Gavril
09:54 AM Bug #9969: Parsing query string error with \r character.
Constantin Asofiei wrote:
> Octavian, I think there may be a problem. In a project there is a var defined like:
> ...
Octavian Adrian Gavril
09:43 AM Bug #9969: Parsing query string error with \r character.
Octavian, I think there may be a problem. In a project there is a var defined like:... Constantin Asofiei
06:57 AM Bug #9969 (Test): Parsing query string error with \r character.
Branch *9969a* was merged into trunk as *rev. 15910* and archived. Octavian Adrian Gavril
06:33 AM Bug #9969 (Merge Pending): Parsing query string error with \r character.
Please merge to trunk after 9834a. Greg Shah
03:16 AM Bug #9969: Parsing query string error with \r character.
Conversion of appserver application completed successfully. The runtime is also working fine. Octavian Adrian Gavril
12:47 PM Feature #7020: always use "expanded" extent fields
+Review of 7020d r15919+
I see nothing wrong with the new code. In fact, I slightly remember writing code similar ...
Ovidiu Maxiniuc
07:34 AM Feature #7020: always use "expanded" extent fields
Ovidiu, could you take a quick look at 7020d revision 15919? Stefanel Pezamosca
09:46 AM Feature #9440: get-codepage() function should work with CLOB fields
I did managed to get the testcases project setup done. Right now, TestGetCodepage.cls fails because the code page is ... Teodor Gorghe
07:04 AM Feature #9440 (WIP): get-codepage() function should work with CLOB fields
Commited revision 15909 on branch 9440a.
- Implemented a new method on I18nOps getCodePage(BaseDataType).
- Changed...
Teodor Gorghe
08:40 AM Feature #7504: Export data tool from FWD into .d files
Greg Shah wrote:
> > After import, the stored value in the database was @1919-12-31@ (disregarding the formatting), ...
Lorian Sandu
08:31 AM Feature #7504: Export data tool from FWD into .d files
> After import, the stored value in the database was @1919-12-31@ (disregarding the formatting), which indicates the ... Greg Shah
08:26 AM Feature #7504: Export data tool from FWD into .d files
I tested my current implementation by exporting data from a large database and comparing the newly generated @*.d@ fi... Lorian Sandu
06:39 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
As Constantin pointed out in #9810-98, this error also occurs in OE in situations where a field is used but not defin... Stefanel Pezamosca
06:13 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
Okay, but this still doesn’t explain why a customer application fails with this exact error when running a query like... Paula Păstrăguș
05:52 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
This could be the issue, as the @f3@ column is added manually and is not part of the @.df@. Additionally, the @f3@ pr... Stefanel Pezamosca
05:48 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
I’ve attached the .d and .df files. After importing them, please update the pt table in pgAdmin by adding a new colum... Paula Păstrăguș
05:38 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
Paula Păstrăguș wrote:
> I m using rev *15907*. I'm still able to replicate the issue.
Please post the DB schema ...
Alexandru Lungu
05:26 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
It seems the browser I’m using is messing with the task info a bit :) Sorry for the inconvenience! Paula Păstrăguș
05:24 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
I m using rev *15907*. I'm still able to replicate the issue. Paula Păstrăguș
05:02 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
I don't get the error as in #9994-1, the query is parsed correctly on my side. Am I missing something? Paula, could y... Stefanel Pezamosca
04:45 AM Bug #9994 (WIP): Err: Cannot run GET methods on query until it is opened.
Stefanel Pezamosca
04:45 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
First observation: The error does not reproduce when using a temp-table.
This works:
{{Collapse(Temp-Table testcase...
Stefanel Pezamosca
04:40 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
Unfortunately, I think this is an urgent one. It makes a customer application freeze, and the logs are overly populat... Radu Apetrii
04:28 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
Paula/Radu, please adjust the priority of this task accordingly. Alexandru Lungu
05:29 AM Feature #9477: implement missing QUERY handle methods/attributes
> REPOSITION-BACKWARDS (full/basic)
> REPOSITION-FORWARDS (full/basic)
AFAIK, these are both supported at convers...
Alexandru Lungu

05/15/2025

06:32 PM Feature #9543 (Internal Test): implement missing BUFFER attributes
I looked at the changes of this last revision. I think they should work. A couple of notes:
* the @isBufferCopyDesti...
Ovidiu Maxiniuc
05:38 PM Feature #9546: investigate and implement field options, if missing
First, a disclaimer: there is little information about these attributes, including on progress.com. The statements be... Ovidiu Maxiniuc
01:14 PM Feature #9546: investigate and implement field options, if missing
Eric, these are from the .df, right?
Ovidiu: can you take a quick look at would need to be implemented?
Constantin Asofiei
01:18 PM Feature #9477: implement missing QUERY handle methods/attributes
Alexandru, do you have any insight about the reposition methods in the first note? I recall seeing mentions about rep... Constantin Asofiei
11:34 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
The concern is from Cloud Ops because they do not have access directly to the databases in production. On our local ... Brian Woodard
11:23 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
I am sorry for the trouble.
The SQL statements stand in notes 6 (for PgSQL) and 8 (for H2). I adjusted them by dro...
Ovidiu Maxiniuc
10:18 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
This was a breaking change for deployed environments because the upgrade of the landlord schema changes were not auto... Brian Woodard
10:22 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
This error is thrown when performing @GET-NEXT@ on a query like the following:
@for each pt where f3 = false and f...
Paula Păstrăguș
10:17 AM Bug #9994 (Rejected): Err: Cannot run GET methods on query until it is opened.
Paula Păstrăguș
09:43 AM Feature #7504: Export data tool from FWD into .d files
+Update on the Implementation+
* Successfully made the @ExportWorker@ runnable in offline mode using a lightweight...
Lorian Sandu
09:00 AM Bug #9969 (Internal Test): Parsing query string error with \r character.
Yes, you're right. Greg Shah
08:19 AM Bug #9969: Parsing query string error with \r character.
Shouldn't I wait for the appserver application conversion test results? Octavian Adrian Gavril
08:16 AM Bug #9969 (Merge Pending): Parsing query string error with \r character.
You can merge to trunk now. Greg Shah
08:11 AM Bug #9969: Parsing query string error with \r character.
Greg Shah wrote:
> > I used this testcase to see if the behavior is as expected:
> > [...]
> >
> > Converted cod...
Octavian Adrian Gavril
08:05 AM Bug #9969: Parsing query string error with \r character.
> I used this testcase to see if the behavior is as expected:
> [...]
>
> Converted code with @unixEscapes@ on @t...
Greg Shah
07:51 AM Bug #9969: Parsing query string error with \r character.
Eduard mentioned in #4602-50 that exception is not thrown anymore. Octavian Adrian Gavril
06:41 AM Bug #9969: Parsing query string error with \r character.
The conversion of another large GUI customer application was successfully completed. No source code differences were ... Octavian Adrian Gavril
03:12 AM Bug #9969 (Internal Test): Parsing query string error with \r character.
I've restarted the conversion regression testing plan with changes from *15904*:
* Conversion of large GUI customer ...
Octavian Adrian Gavril
08:17 AM Bug #9937: buffer argument with different DMO than the parameter
Could 9937a be merge to trunk, or additional tests should be done? Eduard Soltan
05:48 AM Bug #9937: buffer argument with different DMO than the parameter
Eduard Soltan wrote:
> Asked Danut to run ETF, we should have the results by tomorrow.
ETF tests passed.
Dănuț Filimon
08:34 PM Feature #9456: implement SQL Server dialect and helpers
A few weeks ago I created task branch 9456a for holding changes which would bring SQL Server dialect closer to all ot... Ovidiu Maxiniuc
08:33 PM Feature #9455: port native user defined functions to SQL Server
The goal of this task is to track the porting of native UDF functions for Microsoft SQL Server.
I already did par...
Ovidiu Maxiniuc

05/14/2025

04:25 PM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
The @breakAfterAcquireFailure@ is no longer settable. It is always active (that is, its value is @true@).
For more d...
Ovidiu Maxiniuc
10:39 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
I wanted to confirm that the breakAfterAcquireFailure is no longer needed in the directory.xml and is now being force... Brian Woodard
02:59 PM Feature #7504: Export data tool from FWD into .d files
Isn't the @dumpName@ attribute of @@Table@ DMO annotation useful (4GL @DUMP-NAME@ attribute) and neither the field na... Ovidiu Maxiniuc
02:21 PM Feature #7504: Export data tool from FWD into .d files
Greg Shah wrote:
> > In OE the .d file stores the name of the *.blb file
>
> At a minimum we should use @blb@ and...
Lorian Sandu
02:19 PM Feature #7504: Export data tool from FWD into .d files
The export isn't converted code and does not need to be executed using the FWD client. Writing the dump on the serv... Greg Shah
12:53 PM Feature #7504: Export data tool from FWD into .d files
Eric Faulhaber wrote:
> Do the exported files need to be on the client? It seems like going through the legacy strea...
Lorian Sandu
12:47 PM Feature #7504: Export data tool from FWD into .d files
Do the exported files need to be on the client? It seems like going through the legacy stream support will be a perfo... Eric Faulhaber
11:06 AM Feature #7504: Export data tool from FWD into .d files
> In OE the .d file stores the name of the *.blb file
At a minimum we should use @blb@ and @clb@ instead of @null@...
Greg Shah
10:51 AM Feature #7504: Export data tool from FWD into .d files
Lorian Sandu wrote:
> When importing the database, we don't store the original name of the file at the dmo level, th...
Ovidiu Maxiniuc
10:41 AM Feature #7504: Export data tool from FWD into .d files
I've got a working version and managed to export the data from the database to @.d@ files.
A few things i want to di...
Lorian Sandu
08:51 AM Bug #9937: buffer argument with different DMO than the parameter
Asked Danut to run ETF, we should have the results by tomorrow. Eduard Soltan
08:45 AM Bug #9937: buffer argument with different DMO than the parameter
Eduard Soltan wrote:
> Constantin Asofiei wrote:
>
> > Please continue testing.
>
> Runtime for Chui regressio...
Constantin Asofiei
08:38 AM Bug #9937: buffer argument with different DMO than the parameter
Constantin Asofiei wrote:
> Please continue testing.
Runtime for Chui regression testing and unit tests of a la...
Eduard Soltan
08:35 AM Bug #9937 (Internal Test): buffer argument with different DMO than the parameter
Eduard Soltan wrote:
> Changed @defineAlias@ and @makeArgumentBuffer@ to create a proxy without @plugin@. Committed ...
Constantin Asofiei
05:07 AM Bug #9937: buffer argument with different DMO than the parameter
Changed @defineAlias@ and @makeArgumentBuffer@ to create a proxy without @plugin@. Committed on #9937, rev. 15892.
...
Eduard Soltan
08:31 AM Feature #9543: implement missing BUFFER attributes
Some improvements of @buffer-copy@ in batch mode are in 9543b, rev. 15894. Eduard Soltan
08:28 AM Feature #9543: implement missing BUFFER attributes
Ovidiu Maxiniuc wrote:
> Review of 9543b, r15893.
>
> * @RecordBuffer.java@:
> ** line 2019: the field is missin...
Eduard Soltan
06:34 AM Feature #9543: implement missing BUFFER attributes
Review of 9543b, r15893.
* @RecordBuffer.java@:
** line 2019: the field is missing the javadoc;
** lines 3650, 4...
Ovidiu Maxiniuc
08:27 AM Feature #7020: always use "expanded" extent fields
After the rebase with the latest trunk, I discovered another issue related with fields include/exclude functionality.... Stefanel Pezamosca
07:26 AM Bug #9969 (Review): Parsing query string error with \r character.
I've reverted the changes from @character.java@ in *9969a/15904*. This double backslash gets an unescaped '\' charact... Octavian Adrian Gavril
06:36 AM Bug #9969 (WIP): Parsing query string error with \r character.
Octavian Adrian Gavril
06:36 AM Bug #9969: Parsing query string error with \r character.
The conversion of the ChUI regression test application completed successfully, but the source compilation failed. The... Octavian Adrian Gavril
03:06 AM Bug #9969: Parsing query string error with \r character.
The conversion of a large GUI client application has been completed successfully. The conversion log is clean and the... Octavian Adrian Gavril

05/13/2025

07:05 PM Feature #9831 (Test): add admin API to set c3p0 configuration for individual tenant databases
Branch 9831a was merged to trunk rev. 15905 and archived. Ovidiu Maxiniuc
06:48 PM Feature #9831 (Merge Pending): add admin API to set c3p0 configuration for individual tenant data...
The minor changes for #9988-12 look fine.
Please merge 9831a to trunk now.
Eric Faulhaber
05:54 PM Feature #7504: Export data tool from FWD into .d files
Lorian, I think you are on the right track:
* indeed, @DmoMeta.getFields()@ will give you the correct order of field...
Ovidiu Maxiniuc
06:31 AM Feature #7504: Export data tool from FWD into .d files
I have started working on the implementation.
Taking into consideration the discussion from the previous notes, i'...
Lorian Sandu
03:53 AM Feature #7504: Export data tool from FWD into .d files
I am raising the priority to High.
Please make regular updates on this task on the progress.
Alexandru Lungu
09:28 AM Feature #7020: always use "expanded" extent fields
I attached an sql script that will help with renaming old extent word tables, indexes and dropping old triggers/trigg... Stefanel Pezamosca
02:37 AM Feature #7020: always use "expanded" extent fields
I have rebased 7020d to trunk revision 15902 and it's now at rev.15918. Stefanel Pezamosca
08:07 AM Bug #9937 (Review): buffer argument with different DMO than the parameter
With 9937a, rev. 15890.
Unit tests of a customer application and Chui regression testing project are passing withou...
Eduard Soltan
07:20 AM Bug #9969: Parsing query string error with \r character.
This affects all string processing in the lexer in a profound way. Full conversion testing is needed. Greg Shah
06:59 AM Bug #9969: Parsing query string error with \r character.
Is conversion regression tesing necessary or run-time testing is enough? Octavian Adrian Gavril
06:51 AM Bug #9969 (Internal Test): Parsing query string error with \r character.
Code Review Task Branch 9969a Revisions 15901 through 15903
I'm OK with the changes. Let's get it tested across a...
Greg Shah
03:32 AM Bug #9969: Parsing query string error with \r character.
Ovidiu Maxiniuc wrote:
> +Review of 9969a/r15902.+
>
> * @UnicodeTranslationException@: missing javadocs for both...
Octavian Adrian Gavril
03:14 AM Bug #9969: Parsing query string error with \r character.
Ovidiu Maxiniuc wrote:
> +Review of 9969a/r15902.+
>
> * @progress.g@: My understanding is that the inlines for n...
Octavian Adrian Gavril
06:42 AM Bug #9318 (Review): Make record nursery visible on removeRecords
*9318a* contains *conversion changes* for Buffer.delete() and *runtime changes*, the test plan is:
* ETF (ddf) - alr...
Dănuț Filimon
06:36 AM Bug #9318: Make record nursery visible on removeRecords
> I rebased 9381a to trunk/15894 a while ago and the branch is now at revision 9318a/15898.
Please move this into ...
Alexandru Lungu
06:29 AM Bug #9318: Make record nursery visible on removeRecords
I rebased *9381a* to *trunk/15894* a while ago and the branch is now at revision *9318a/15898*.
I also retested E...
Dănuț Filimon
03:33 AM Feature #9543: implement missing BUFFER attributes
Ovidiu Maxiniuc wrote:
> +Review of 9543b, r15892.+
>
> * @RecordBuffer.java@
> ** lines 1708, 1711, 2200: I do ...
Eduard Soltan

05/12/2025

07:21 PM Feature #9976: eliminating DMO usage in inter-program linkage
> For parameters, the buffers should not construct their own @BaseRecord@, but use the 'pointer' to one already creat... Greg Shah
06:27 PM Feature #9976: eliminating DMO usage in inter-program linkage
Greg,
I am not sure I got all detail, in spite of being focused on the 1st not for some time now. It's clear we will...
Ovidiu Maxiniuc
08:52 AM Feature #9976: eliminating DMO usage in inter-program linkage
In the 4GL, there is no concept of a DMO. From the beginning (in the 1980s), the 4GL has always directly mapped comp... Greg Shah
03:57 PM Bug #9969: Parsing query string error with \r character.
+Review of 9969a/r15902.+
* @UnicodeTranslationException@: missing javadocs for both the class and the constructor...
Ovidiu Maxiniuc
10:38 AM Bug #9969 (Review): Parsing query string error with \r character.
Octavian Adrian Gavril
10:36 AM Bug #9969: Parsing query string error with \r character.
I made a few changes that fix the way Java escaping is handled. First, in @ClearStream.java@ sequences (with '\') are... Octavian Adrian Gavril
09:08 AM Bug #9969: Parsing query string error with \r character.
Branch *9969a* was rebased with trunk. The new revision is *15901*. Octavian Adrian Gavril
04:20 AM Bug #9969: Parsing query string error with \r character.
Greg wrote:
> Octavian Adrian Gavril wrote:
> > I investigated the issue. I think we can apply the "\r" processing ...
Octavian Adrian Gavril
10:47 AM Bug #9937: buffer argument with different DMO than the parameter
I found a regression with 9937a changes related to extend fields.
For extend fields in @ProxyAssembler@ there are ...
Eduard Soltan
03:44 AM Bug #9937 (Internal Test): buffer argument with different DMO than the parameter
Eduard Soltan wrote:
> Alexandru Lungu wrote:
> > Review of 9937a:
> > * @RecordBuffer.bufferProxy@ is a new stat...
Alexandru Lungu
03:29 AM Bug #9937: buffer argument with different DMO than the parameter
Alexandru Lungu wrote:
> Review of 9937a:
> * @RecordBuffer.bufferProxy@ is a new static method added with your ch...
Eduard Soltan
03:24 AM Bug #9937: buffer argument with different DMO than the parameter
Alexandru Lungu wrote:
>If this is statically impossible, then I think I am fully OK with the changes.
From my te...
Eduard Soltan
03:06 AM Bug #9937: buffer argument with different DMO than the parameter
Clear. This seems to be a case where we need to "disguise" a DMO as another DMO just to satisfy Java's strong type ch... Alexandru Lungu
09:51 AM Bug #9683 (WIP): CompoundQuery is doing extra hydration attempts
Alexandru Lungu
09:51 AM Bug #9683: CompoundQuery is doing extra hydration attempts
Review of 9683a:
* @implements@ should be aligned to @public@ (at 3 spaces from the start of the line).
* Typo in @...
Alexandru Lungu
08:03 AM Feature #9543: implement missing BUFFER attributes
+Review of 9543b, r15892.+
I think you are on the right track, but there are a couple of issues which should be ad...
Ovidiu Maxiniuc
04:19 AM Feature #9543 (Review): implement missing BUFFER attributes
It seems that CAN-READ attribute is no longer used in client application. So I will move this task in review. Eduard Soltan
07:26 AM Feature #7020: always use "expanded" extent fields
We don't want to leave behind any traces of the old modes. Greg Shah
07:24 AM Feature #7020: always use "expanded" extent fields
Apart from the situation described above, 7020d has been tested continuously with two projects I had on hand, but I w... Stefanel Pezamosca
07:20 AM Feature #7020: always use "expanded" extent fields
I have one last question:
With @denorm-extent@, @wordTableName@ was generated as @table__extname_1@ (since the field...
Stefanel Pezamosca

05/09/2025

05:06 PM Feature #9976 (New): eliminating DMO usage in inter-program linkage
Greg Shah
04:17 PM Bug #9937: buffer argument with different DMO than the parameter
Please look at the test case from #9937-5.
As you can see we have pretty similar temp-table definitions in
<pr...
Eduard Soltan
09:18 AM Bug #9937: buffer argument with different DMO than the parameter
> Alexandru, can you take a look, too, at 9937a? This touches the ArgumentProxy which IIRC was added by you.
I see...
Alexandru Lungu
08:06 AM Bug #9937: buffer argument with different DMO than the parameter
Alexandru, can you take a look, too, at 9937a? This touches the @ArgumentProxy@ which IIRC was added by you. Constantin Asofiei
07:09 AM Bug #9937 (Review): buffer argument with different DMO than the parameter
Eduard Soltan
07:01 AM Bug #9937: buffer argument with different DMO than the parameter
Constantin Asofiei wrote:
> Just to double-check, please do the same in @ctest@, but with the @btt2 for tt2@ buffer ...
Eduard Soltan
06:50 AM Bug #9937: buffer argument with different DMO than the parameter
Just to double-check, please do the same in @ctest@, but with the @btt2 for tt2@ buffer (which will not use the @buff... Constantin Asofiei
06:48 AM Bug #9937: buffer argument with different DMO than the parameter
Constantin Asofiei wrote:
> Are the tests in #9937-5 passing, plus what we discussed in previous notes (copy-temp-ta...
Eduard Soltan
06:19 AM Bug #9937: buffer argument with different DMO than the parameter
Eduard, the approach is good and it should work; your reasoning is correct, the temp-tables need to be schema-compati... Constantin Asofiei
06:16 AM Bug #9937: buffer argument with different DMO than the parameter
Eduard Soltan wrote:
> Could you take just a quick look at 9937a, rev. 15889?
The only problem that we are facing...
Eduard Soltan
06:03 AM Bug #9937: buffer argument with different DMO than the parameter
Could you take just a quick look at 9937a, rev. 15889? Eduard Soltan
04:58 AM Bug #9937: buffer argument with different DMO than the parameter
I checked and a single method will be created by the @ProxyAssembler@ for @Proxy3@ (@getF1@ and @setF1@), or any othe... Eduard Soltan
03:07 AM Bug #9937: buffer argument with different DMO than the parameter
Constantin Asofiei wrote:
> I don't think is OK to have methods from both Tt2_1 and TT1_1 DMO interfaces.
Then we...
Eduard Soltan
02:55 AM Bug #9937: buffer argument with different DMO than the parameter
I don't think is OK to have methods from both Tt2_1 and TT1_1 DMO interfaces.
I don't think @Proxy3@ should be ret...
Constantin Asofiei
02:47 AM Bug #9937: buffer argument with different DMO than the parameter
The proxy is a dynamic class created by @ProxyAssembler@ with the following structure:... Eduard Soltan
08:04 AM Bug #9950 (WIP): Upgrade the metadata schema to a newer version
I noticed the following changes in the currently supported meta files (from DDL PoV):
* 10 (mandatory) columns added...
Ovidiu Maxiniuc
06:28 AM Bug #9318: Make record nursery visible on removeRecords
I've tested ETF conversion & runtime with 9318a and found no issues with the current implementation, I will rebase to... Dănuț Filimon
04:44 AM Feature #7504: Export data tool from FWD into .d files
Andrei, please commit whatever changes you've done for #7504 and introduce Lorian to this task. Alexandru Lungu
03:23 AM Bug #9914 (Test): Investigate why ListenerSet implementation is not properly working
Branch 9914a was merged into trunk as rev. 15893 and archived. Razvan-Nicolae Chichirau
02:58 AM Bug #9914 (Merge Pending): Investigate why ListenerSet implementation is not properly working
9914a can be merged after 5471a. Radu Apetrii
02:57 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
Wonderful! I shall queue the branch up for merging. Radu Apetrii
02:51 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
> * ask Danut to run unit tests and fwdtests for the application he is managing
No issues found ✅
Dănuț Filimon
02:15 AM Bug #9683: CompoundQuery is doing extra hydration attempts
Rebased on trunk rev 15891. Alexandru, could you please look at the last commits, I would like to move on with testin... Artur Școlnic

05/08/2025

09:14 AM Feature #9543: implement missing BUFFER attributes
Committed on 9543b, rev. 15892. Added support for AUTO-SYNCHRONIZE attribute. Eduard Soltan
06:24 AM Feature #9543: implement missing BUFFER attributes
Constantin Asofiei wrote:
> BTW, if buffer-copy fails validation, does synchronize still happen?
No.
Eduard Soltan
06:23 AM Feature #9543: implement missing BUFFER attributes
Eduard Soltan wrote:
> Constantin Asofiei wrote:
> > Please also double-check the @ASSIGN@ statement if it trigger...
Constantin Asofiei
06:09 AM Feature #9543: implement missing BUFFER attributes
Constantin Asofiei wrote:... Eduard Soltan
04:53 AM Feature #9543: implement missing BUFFER attributes
What happens if you do:... Constantin Asofiei
04:51 AM Feature #9543: implement missing BUFFER attributes
Constantin Asofiei wrote:
> Please also double-check the @ASSIGN@ statement if it triggers the synchronize or not. ...
Eduard Soltan
04:39 AM Feature #9543: implement missing BUFFER attributes
Constantin Asofiei wrote:
> Please also double-check the @ASSIGN@ statement if it triggers the synchronize or not. ...
Eduard Soltan
03:37 AM Feature #9543: implement missing BUFFER attributes
For @CAN-READ@ the only information I could find in the docs is:... Eduard Soltan
02:52 AM Feature #9543: implement missing BUFFER attributes
Constantin Asofiei wrote:
> Please also double-check the @ASSIGN@ statement if it triggers the synchronize or not. ...
Eduard Soltan
02:32 AM Feature #9543: implement missing BUFFER attributes
Please also double-check the @ASSIGN@ statement if it triggers the synchronize or not. If the @ASSIGN@ part of @BUFF... Constantin Asofiei
01:48 AM Feature #9543: implement missing BUFFER attributes
I created some tests for @buffer-copy@ as a method and @buffer-copy@ statement.... Eduard Soltan
07:54 AM Bug #9318: Make record nursery visible on removeRecords
Rebased *9318a* to latest *trunk/15891*, the branch is now at revision *15895*. Dănuț Filimon
07:37 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
> * ask Lorian to run harness
Harness passed ✅
Lorian Sandu
04:41 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
> I will run unit tests and smoke tests of large customer application.
Everything is OK here.
Alexandru Lungu
04:24 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
* ChUI regression tests passed ✅
* Smoke-test for a large customer app passed ✅
* #9722 testing passed ✅
I think...
Razvan-Nicolae Chichirau

05/07/2025

04:20 PM Feature #9831 (Internal Test): add admin API to set c3p0 configuration for individual tenant data...
> Meanwhile, I am putting the branch to the test using the the hotel, webGUI navigation and harness smoke-tests of a ... Ovidiu Maxiniuc
03:31 PM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
Ovidiu Maxiniuc wrote:
> Radu, please do a quick review when you have the time.
I think 9831a is alright. I don't s...
Radu Apetrii
01:57 PM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
The @breakAfterAcquireFailure@ was removed from REST API and @landlord@ database.
The issues from note #9831-15 (th...
Ovidiu Maxiniuc
09:26 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
Please remove @breakAfterAcquireFailure@ from the REST API, since we hard-code this setting to @true@ in the runtime. Eric Faulhaber
05:21 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
I looked at the changes in 9831a, and I can say quite confidently that functionally they are safe. I don't think they... Radu Apetrii
03:36 PM Bug #9914: Investigate why ListenerSet implementation is not properly working
ETF testing passed! Lorian Sandu
12:19 PM Feature #9543: implement missing BUFFER attributes
For @BUFFER-COPY@, if the destination buffer has no loaded record, then it CREATE's a record in that buffer. So, ple... Constantin Asofiei
12:16 PM Feature #9543: implement missing BUFFER attributes
Constantin Asofiei wrote:
> Also, are there cases when @auto-synchronize@ is disabled temporarily, like for @save-ro...
Eduard Soltan
12:12 PM Feature #9543: implement missing BUFFER attributes
Constantin Asofiei wrote:
> Can this be described in short, the synchronize is automatically called when the buffer'...
Eduard Soltan
12:10 PM Feature #9543: implement missing BUFFER attributes
Constantin Asofiei wrote:
> Can this be described in short, the synchronize is automatically called when the buffer'...
Eduard Soltan
10:57 AM Feature #9543: implement missing BUFFER attributes
Also, are there cases when @auto-synchronize@ is disabled temporarily, like for @save-row-changes@ or @fill@ method c... Constantin Asofiei
10:56 AM Feature #9543: implement missing BUFFER attributes
Can this be described in short, the synchronize is automatically called when the buffer's record is either loaded, re... Constantin Asofiei
10:52 AM Feature #9543: implement missing BUFFER attributes
Created a few test cases for behaviour of @AUTO-SYNCHRONIZE@ attributes.... Eduard Soltan
10:11 AM Feature #9543: implement missing BUFFER attributes
OK, so we already support @SYNCHRONIZE@ method via @Buffer.querySynchronize@ - so looks like we just need to call it ... Constantin Asofiei
09:39 AM Feature #9543: implement missing BUFFER attributes
According to the docs for AUTO-SYNCHRONIZE attribute and a in a book *OpenEdge Development: ProDataSets* by John Sadd... Eduard Soltan
07:19 AM Feature #9543 (WIP): implement missing BUFFER attributes
Actually, this is back to WIP.
Eduard: did you get a chance to test how these attrs should behave at runtime?
Constantin Asofiei
07:18 AM Feature #9543 (Test): implement missing BUFFER attributes
Constantin Asofiei
09:25 AM Bug #9969 (WIP): Parsing query string error with \r character.
Octavian Adrian Gavril
09:20 AM Bug #9969: Parsing query string error with \r character.
The escape sequences should include an additional '\' prefix. The current revision handles this only for '\u' within ... Octavian Adrian Gavril
08:53 AM Bug #9969: Parsing query string error with \r character.
Alexandru Lungu wrote:
> Eduard, is @'bc\r'@ right? Shouldn't it be @'bc~r'@ to actually generate the CR?
It is e...
Eduard Soltan
08:51 AM Bug #9969: Parsing query string error with \r character.
Please also see #9967, which is somehow related to the escape char used under linux. Constantin Asofiei
08:48 AM Bug #9969: Parsing query string error with \r character.
Eduard, is @'bc\r'@ right? Shouldn't it be @'bc~r'@ to actually generate the CR? Alexandru Lungu
08:43 AM Bug #9969: Parsing query string error with \r character.
Our preprocessor/lexer strips @'\r'@ characters in a naive way that needs to be refined. Greg Shah
08:21 AM Bug #9969: Parsing query string error with \r character.
Alternatively this test case also reproduce the issues:... Eduard Soltan
08:06 AM Bug #9969: Parsing query string error with \r character.
... Eduard Soltan
08:02 AM Bug #9969 (WIP): Parsing query string error with \r character.
Eduard Soltan
08:20 AM Bug #9950: Upgrade the metadata schema to a newer version
Ovidiu, please get some preliminary changes in a branch, so we can patch 9457c and test FWD server startup. Constantin Asofiei
05:37 AM Bug #9937: buffer argument with different DMO than the parameter
I added my changes to 9937a rev. 15888.
When we have an ArgumentBuffer proxy, any direct field access (@btt1.getF1...
Eduard Soltan

05/06/2025

10:07 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
Radu,
I rebased and did a quick review of my own code, this revealed some small issues which were fixed.
You can ...
Ovidiu Maxiniuc
09:03 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
Ovidiu, is this ready to be reviewed? I see that it's been placed at 90%. Radu Apetrii
07:55 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
Added Radu as reviewer. Ovidiu Maxiniuc
07:37 AM Bug #9914 (Internal Test): Investigate why ListenerSet implementation is not properly working
I am OK with the changes in 9914a.
However, we will need some extensive testing with it, eventually across multiple ...
Alexandru Lungu
07:26 AM Bug #9937: buffer argument with different DMO than the parameter
Constantin Asofiei wrote:
> Does this solve cases when the field is in an expression, copy-temp-table and others? B...
Eduard Soltan
05:23 AM Bug #9937: buffer argument with different DMO than the parameter
Does this solve cases when the field is in an expression, copy-temp-table and others? Because @getDMOProxy();@ is us... Constantin Asofiei
05:21 AM Bug #9937: buffer argument with different DMO than the parameter
Constantin Asofiei wrote:
> I agree; but I'd like to solve this with the proxy, if possible; before committing to...
Eduard Soltan
02:15 AM Bug #9937: buffer argument with different DMO than the parameter
Ovidiu Maxiniuc wrote:
> Yes, I am aware, as you quoted me, _"[...] which declare the @new shared@ tables and *simpl...
Constantin Asofiei
07:10 AM Feature #7020: always use "expanded" extent fields
I have rebased 7020d to trunk revision 15884 and it's now at 15900. Stefanel Pezamosca

05/05/2025

04:19 PM Feature #7020 (Internal Test): always use "expanded" extent fields
Branch 7020c (now r15866) is rebased but does not seem to have changes from the last time I reviewed it (old r15824).... Ovidiu Maxiniuc
03:21 AM Feature #7020: always use "expanded" extent fields
Ovidiu, please provide a review for #7020-131. Alexandru Lungu
03:52 PM Bug #9937: buffer argument with different DMO than the parameter
Yes, I am aware, as you quoted me, _"[...] which declare the @new shared@ tables and *simple TT*."_ I was merely expr... Ovidiu Maxiniuc
01:48 PM Bug #9937: buffer argument with different DMO than the parameter
Ovidiu Maxiniuc wrote:
> So I think that would be the right implementation: to remove these attributes (like @xml-no...
Constantin Asofiei
01:29 PM Bug #9937: buffer argument with different DMO than the parameter
I think we have discussed about an idea similar to Eduard's, some time ago.
Currently, the DMO of a @shared@ temp-...
Ovidiu Maxiniuc
12:50 PM Bug #9937: buffer argument with different DMO than the parameter
Eduard Soltan wrote:
> Question: Since we established in #9763 that @xml-node-name@ is a property specific to the bu...
Constantin Asofiei
12:32 PM Bug #9937 (WIP): buffer argument with different DMO than the parameter
Eduard Soltan
12:31 PM Bug #9937: buffer argument with different DMO than the parameter
I will let out some of my findings.
h3. Structure of tt1 after TemporaryBuffer.define
After the call in @FooTes...
Eduard Soltan
04:04 AM Bug #9937: buffer argument with different DMO than the parameter
Eduard, I've tried something like this to create the proxy:... Constantin Asofiei
09:51 AM Bug #9965: Compound Query components not honoring the INCLUDE clause
... Lorian Sandu
09:44 AM Bug #9965 (New): Compound Query components not honoring the INCLUDE clause
Lorian Sandu

04/30/2025

02:15 PM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
Eric, please review.
I will rebase the branch since it is a bit behind the main trunk.
Ovidiu Maxiniuc
02:33 AM Bug #9633: bulk delete for permanent tables
Rebased *9633a* with trunk revision *15878*, new revision is *15880*. Andrei Iacob

04/28/2025

04:51 PM Bug #9950: Upgrade the metadata schema to a newer version
One of the latest customer projects uses a newer schema (@standard.df@) of the _meta database than the one we have. I... Ovidiu Maxiniuc
04:36 PM Bug #9950 (Test): Upgrade the metadata schema to a newer version
Ovidiu Maxiniuc
07:32 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
> Well, if the query is static, the scoping from #9914-14 would be correct! But the issue will still reproduce (?).
...
Razvan-Nicolae Chichirau

04/25/2025

10:33 AM Bug #9907: LOOKUP seems to evaluate fast in WHERE clauses from the legacy code, but slow in FWD
I agree with #9907-3. But I am more interested to find out how 4GL is able to make this work fast. INDEXED-REPOSITION... Alexandru Lungu
10:22 AM Bug #9907: LOOKUP seems to evaluate fast in WHERE clauses from the legacy code, but slow in FWD
I've seen this task an I thought of something. This:... Stefanel Pezamosca
05:42 AM Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
Tomasz Domin wrote:
> Just to notify - I am still getting a lot of "Failed direct-access due to Error direct accessi...
Dănuț Filimon

04/24/2025

08:19 AM Bug #9937: buffer argument with different DMO than the parameter
I've tested @DYNAMIC-INVOKE(.., BUFFER tt1)@ and runtime gets this @BUFFER parameter type not allowed for dynamic par... Constantin Asofiei
08:10 AM Bug #9937: buffer argument with different DMO than the parameter
In FWD, we create different DMO interfaces even if the schema matches, but the resource options, like @XML-NODE-NAME@... Constantin Asofiei
07:55 AM Bug #9937 (Test): buffer argument with different DMO than the parameter
Constantin Asofiei
06:52 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
> No matter how many nested RUN statements we have in this testcase, we always end up trying to register the query at... Alexandru Lungu
06:09 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
Experimented with @RUN custom.p@ from a @start.p@. Right before we should to add the query as a global listener, this... Razvan-Nicolae Chichirau
03:39 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
> Anyway, it would be defined globally.
I am not sure that "globally" is right. It is within the scope of the exte...
Alexandru Lungu
03:38 AM Bug #7364: Build a full test-suite for fast copy-temp-table
I extended the tests existent at @testcases/tests/table/TestCopyTempTable.cls@ as part of the work on #9397. These ar... Ioana-Cristina Prioteasa
03:15 AM Bug #7364: Build a full test-suite for fast copy-temp-table
Ioana, did you built a test-suite in your recent work for COPY-TEMP-TABLE construct? If so, is it based on plain proc... Alexandru Lungu
03:08 AM Bug #7403 (Closed): Copy-temp-table with replace-mode should replace already inserted records
Alexandru Lungu
02:48 AM Bug #7403: Copy-temp-table with replace-mode should replace already inserted records
Yes, thanks! Ioana-Cristina Prioteasa

04/23/2025

03:53 PM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
The default value for all of these is @null@ which means they will default to the c3p0 value of the default database.... Ovidiu Maxiniuc
03:22 PM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
Isn't @c3p0.break_on_fail@ always supposed to be @true@? I don't think we want customers to configure that. Greg Shah
03:00 PM Feature #9831 (Review): add admin API to set c3p0 configuration for individual tenant databases
The implementation is finished. I added the support even for @c3p0.break_on_fail@ which was recently added.
I've jus...
Ovidiu Maxiniuc
02:11 PM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
Ovidiu, what is the status of this task? I did not do a full review, but I took a look at 9831a and the implementatio... Eric Faulhaber
11:04 AM Bug #9397 (Closed): Fix COPY-TEMP-TABLE issues
This can be closed. Alexandru Lungu
11:04 AM Bug #7403: Copy-temp-table with replace-mode should replace already inserted records
> #7403 is fixed by 9397a - FWD behavior aligns with progress with trunk rev.15627.
Ioana, does this mean that #74...
Alexandru Lungu
11:00 AM Feature #7960 (Closed): Allow query logs to be collected in a H2 database
This can be closed now as the query logs seem to be accumulated well in H2. Alexandru Lungu
07:27 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
After converting @start.p@ from #9914-6:... Razvan-Nicolae Chichirau
07:18 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
I can't tell in #9914-5 where the buffer is defined. Alexandru Lungu
06:53 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
> It looks like you are registering the query at the first nested scope and the buffer at the second nested scope.
...
Razvan-Nicolae Chichirau
04:16 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
> So, I don't think the problem comes from the unlinking of PreselectQuery after popping the procedure local scope, b... Alexandru Lungu
02:19 AM Bug #9914 (Review): Investigate why ListenerSet implementation is not properly working
Razvan-Nicolae Chichirau
02:19 AM Bug #9914 (WIP): Investigate why ListenerSet implementation is not properly working
Commited to *9914a/rev. 15868*.
Alex: Please review.
Razvan-Nicolae Chichirau

04/22/2025

05:51 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
Attached the original testcase.
There are 2 important phases while opening the query in @createWidgets@:
# Initia...
Razvan-Nicolae Chichirau
02:36 AM Bug #9683: CompoundQuery is doing extra hydration attempts
Addressed a few formatting issues and rebased on trunk rev 15866. Artur Școlnic

04/17/2025

12:24 PM Feature #9093 (Closed): add protection for multi-tenant imports to optionally only import tables ...
Greg Shah
09:42 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
Given this situation:... Razvan-Nicolae Chichirau
08:39 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
Razvan-Nicolae Chichirau wrote:
> So, what we need to do is to replace the workaround of just combining all listener...
Alexandru Lungu
08:29 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
So, what we need to do is to replace the workaround of just combining all listeners sets and instead use the @Listene... Razvan-Nicolae Chichirau
08:18 AM Bug #9914: Investigate why ListenerSet implementation is not properly working
According to Eric, @ListenerSet@ from @ChangeBroker@ should have worked like a linked list which *references* other d... Alexandru Lungu
08:15 AM Bug #9914 (Test): Investigate why ListenerSet implementation is not properly working
Alexandru Lungu
09:40 AM Bug #9683 (Review): CompoundQuery is doing extra hydration attempts
I addressed the review and fixed a few bugs detected during testing, the code is in 9683a/15727. Artur Școlnic
 

Also available in: Atom