FWD » Core Development » User Interface

01/24/2015

07:56 PM Feature #2478: button image support

This updates has code merged with recent code base.
One interesting thing I've found. If the method @LOAD-IMAGE()@... Eugenie Lyzenko

01/23/2015

06:00 PM Feature #1790: implement menu support

I've fixed this bug. It was some sort of serialization bug. I also fixed a drawing of menu-item labels for menubar. H... Vadim Gindin

12:06 PM Feature #1790: implement menu support

Hopefully you are continuing to debug. I have no idea what is causing the problem. Greg Shah

10:02 AM Feature #1790: implement menu support

I did it and nevertheless the constructor of @SilentUnwindException@ is called from client-side with the error @com.g... Vadim Gindin

09:31 AM Feature #1790: implement menu support

I can't tell anything useful from the logs. You'll have to set breakpoints in the @SilentUnwindException@ constructo... Greg Shah

09:27 AM Feature #1790: implement menu support

In the future, when posting something that isn't large, please post it in-line here. Don't attach a file for such th... Greg Shah

09:23 AM Feature #1790: implement menu support

I need some advice. I got an error, that happen right in the moment of client call. I've filled @ScreenDefinition@ wi... Vadim Gindin

04:24 PM Feature #2494: DELETE() method runtime implementation

Done. I did it with meld - it appears to be almost as good as Araxis Merge I used before. Igor Skornyakov

04:14 PM Feature #2494: DELETE() method runtime implementation

The class definition itself has been changed:... Greg Shah

03:56 PM Feature #2494: DELETE() method runtime implementation

I see tow issues.
1. Invalid braces in constructor (fixed)
2. Reformatted comments/Javadocs.
I can revert my chang... Igor Skornyakov

03:39 PM Feature #2494: DELETE() method runtime implementation

Code Review ias_upd20150123c.zip
> I'm sorry.
No worries. Learning the coding standards is part of the ramp-up... Greg Shah

03:07 PM Feature #2494: DELETE() method runtime implementation

Oh, I'm sorry. It appears that one have to set this in two places in Eclipse now. Igor Skornyakov

02:44 PM Feature #2494: DELETE() method runtime implementation

Code Review ias_upd20150123b.zip
Actually, this update is very hard to compare with the first for @ComboBoxWidget@... Greg Shah

02:27 PM Feature #2494: DELETE() method runtime implementation

Greg Shah wrote:
> FYI, we prefer to minimize the linkages because there can be unintended consequences. For exampl... Igor Skornyakov

02:06 PM Feature #2494: DELETE() method runtime implementation

FYI, we prefer to minimize the linkages because there can be unintended consequences. For example, some of our code ... Greg Shah

02:05 PM Feature #2494: DELETE() method runtime implementation

Sadly, I see that it has also sneaked its way into @LogicalTerminal@ and @ChuiWebPageHandler@. We'll need to clean t... Greg Shah

02:00 PM Feature #2494: DELETE() method runtime implementation

Igor Skornyakov wrote:
> Got it.
> Regarding 3rd party dependencies. I used Google Guava classes only because the c... Constantin Asofiei

01:53 PM Feature #2494: DELETE() method runtime implementation

Got it.
Regarding 3rd party dependencies. I used Google Guava classes only because the corresponding jar is already ... Igor Skornyakov

01:14 PM Feature #2494: DELETE() method runtime implementation

Code Review ias_upd20150123.zip
Functionally, it is quite good. Most of the feedback relates to coding standards.... Greg Shah

12:54 PM Feature #2494: DELETE() method runtime implementation

Please find updated classes attached. Igor Skornyakov

12:27 PM Feature #2494: DELETE() method runtime implementation

That should not be needed.
OK, so you should do the following:
1. Upload the update zip file here so that we ca... Greg Shah

12:19 PM Feature #2494: DELETE() method runtime implementation

Thank you - it works. I've finished testing in ChUI mode. Shall I test on Windows as well? Igor Skornyakov

11:59 AM Feature #2494: DELETE() method runtime implementation

It's not the best way, but for now you can use this: @frame.getName(this)@ from within a widget. This corresponds to... Greg Shah

10:55 AM Feature #2494: DELETE() method runtime implementation

I've started testing in ChUI mode. Basically all works, but there is one minor(?) issues:
The type() return not th... Igor Skornyakov

09:44 AM Feature #2494: DELETE() method runtime implementation

It's OK - I understand. Thank you, Igor Skornyakov

09:43 AM Feature #2494: DELETE() method runtime implementation

Good. Sorry for the old docs. We are busy and haven't gotten them updated. And those docs reference an internal bz... Greg Shah

09:35 AM Feature #2494: DELETE() method runtime implementation

Yes, it works, thank you. Igor Skornyakov

09:23 AM Feature #2494: DELETE() method runtime implementation

The documentation is out of date. The @ServerDriver@ itself has no understanding of a @-z@ parameter. The @server.s... Greg Shah

09:12 AM Feature #2494: DELETE() method runtime implementation

I got the command from /books/conversion_handbook/p2j_conversion_handbook.pdf page 221 Igor Skornyakov

09:03 AM Feature #2494: DELETE() method runtime implementation

I don't fully understand what you are saying you did or what the problem is.
When I run a server for my converted ... Greg Shah

06:43 AM Feature #2494: DELETE() method runtime implementation

I've tried to launch the P2J Server as described in the "P2J Conversion Handbook", but got an error @"Too many config... Igor Skornyakov

03:46 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere

No, here it is. Greg Shah

03:45 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere

Good catch. Here is the version with javadoc. Greg Shah

03:03 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere

Greg Shah wrote:
> Merged update to bzr 10719 which includes the fix from #2495. I'm going to put this into testing... Constantin Asofiei

01:45 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere

Merged update to bzr 10719 which includes the fix from #2495. I'm going to put this into testing. Greg Shah

01:34 PM Bug #2495 (Closed): APPLY event TO handle does not work

Greg Shah

01:29 PM Bug #2495 (Review): APPLY event TO handle does not work

Greg Shah wrote:
> Please check it in.
Released to rev 10719. Constantin Asofiei

08:28 AM Bug #2495: APPLY event TO handle does not work

Please check it in. Greg Shah

07:13 AM Bug #2495: APPLY event TO handle does not work

Greg Shah wrote:
> Code Review ca_upd20150122c.zip
>
> It looks good.
0122c.zip passed runtime/conversion testing. Constantin Asofiei

12:31 PM Feature #2498: implement ADD-LAST() method

This method is available on selection list, combo-box, radio-set and browse column. Follow the same approach as for ... Greg Shah

12:30 PM Feature #2498 (Closed): implement ADD-LAST() method

Greg Shah

10:05 AM Feature #2478: button image support

This update for review adds @DEFINE IMAGE@ handling for deferred data loading for image widget.
Continue working. Eugenie Lyzenko

09:18 AM Feature #2252: implement GUI client support

Code Review ca_upd20150123a.zip
The changes look good. The result is cleaner too from a design perspective, so it... Greg Shah

07:48 AM Feature #2252: implement GUI client support

Fix for side-label in shared frames. Built on top of #2495 ca_upd20150122c.zip Constantin Asofiei

01/22/2015

06:15 PM Feature #2478: button image support

This update for review contains prototype for deferred image loading in button widget. Some notes:
1. There is only ... Eugenie Lyzenko

05:55 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere

The testcase is checked in as @testcases/uast/any_printable_event.p@. Greg Shah

05:53 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere

This is the fix. It ensures that ANY-PRINTABLE and ANY-KEY are searched on each pass through (specific-widget, frame... Greg Shah

05:49 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere

The following testcase illustrates this problem:... Greg Shah

05:48 PM Bug #2497 (Closed): ANY-PRINTABLE only works for specific widget triggers, but not frame or globa...

Greg Shah

02:20 PM Feature #2494: DELETE() method runtime implementation

Greg Shah wrote:
> For this task I think you can ignore the browse column aspects.
OK. Thank you.
Igor Skornyakov

02:17 PM Feature #2494: DELETE() method runtime implementation

> If I understand correctly this means that in the scope of this task there is nothing to do specifically for the BRO... Greg Shah

02:11 PM Feature #2494: DELETE() method runtime implementation

Here it is Igor Skornyakov

02:09 PM Feature #2494: DELETE() method runtime implementation

> If I understand correctly this means that in the scope of this task there is nothing to do specifically for the BRO... Greg Shah

01:43 PM Feature #2494: DELETE() method runtime implementation

Please note the generated code for the BROWSE widget contains nothing related to a combo-box column except @addWidget... Igor Skornyakov

01:22 PM Feature #2494: DELETE() method runtime implementation

Indeed - after commenting out p2j_test namespace the browse2.p converted OK (even with @f0+cb@)
Thanks a lot! Igor Skornyakov

01:20 PM Feature #2494: DELETE() method runtime implementation

Greg Shah wrote:
> The "b" reference in the define frame is being matched with a field in the book table of p2j_test... Eric Faulhaber

01:15 PM Feature #2494: DELETE() method runtime implementation

I guess that P2J is having a problem with @DEFINE FRAME f b.@ from line 10 of @r-browse2.p@, if that is the same prog... Greg Shah

12:55 PM Feature #2494: DELETE() method runtime implementation

Well, the conversion passed for combo, radio and select. I had to use @f2+m0+cb@ as @f0+cb@ disn't work (at some stag... Igor Skornyakov

12:39 PM Feature #2494: DELETE() method runtime implementation

Thank you very much.
Now the conversion started. However there are other problems at the later steps. I'll try to un... Igor Skornyakov

11:37 AM Feature #2494: DELETE() method runtime implementation

I believe that the current @testcases/uast/@ environment was broken at some point by some kind of metadata -nonsense-... Greg Shah

11:28 AM Feature #2494: DELETE() method runtime implementation

Greg,
I cannot perform the conversion:
Exception in thread "main" java.lang.ExceptionInInitializerError
Caused by:... Igor Skornyakov

09:57 AM Feature #2494: DELETE() method runtime implementation

> I understand that now I have to convert my 4GL sample programs and test. Is that correct?
Exactly right. Greg Shah

09:25 AM Feature #2494: DELETE() method runtime implementation

I see. Thank you.
I've implemented @DELETE()@ for RADIO-SET, SELECTION-LIST and COMBO-BOX. I understand that now I... Igor Skornyakov

08:44 AM Feature #2494: DELETE() method runtime implementation

Each resource type has a TYPE attribute. It comes from the @CommonHandle@ interface and is implemented for widgets a... Greg Shah

07:30 AM Feature #2494: DELETE() method runtime implementation

I have a question.
In 4GL warning contains a name of the widget - e.g. "The DELETE attribute on the SELECTION-LIST ... Igor Skornyakov

01:37 PM Bug #2495: APPLY event TO handle does not work

Code Review ca_upd20150122c.zip
It looks good. Greg Shah

01:19 PM Bug #2495: APPLY event TO handle does not work

Attached fixes the issues in notes 3 and 5. Testing is under way. Constantin Asofiei

12:52 PM Bug #2495: APPLY event TO handle does not work

> Should I continue fixing this?
Yes, if it can be done in a reasonable amount of time. I think it is time to get... Greg Shah

12:37 PM Bug #2495: APPLY event TO handle does not work

There is this case also:... Constantin Asofiei

10:24 AM Bug #2495: APPLY event TO handle does not work

Greg Shah wrote:
> 3. In @LogicalTerminal.apply(WrappedResource res, double eventCode)@, could a non-widget/non-fram... Constantin Asofiei

09:56 AM Bug #2495: APPLY event TO handle does not work

Code Review ca_upd20150122a.zip
This is really good. I like how you solved the ID lookup problem by using a diffe... Greg Shah

09:00 AM Bug #2495: APPLY event TO handle does not work

-------- Forwarded Message --------
Subject: Re: common idiom which we don't handle properly
Date: Thu, 22 Jan 2015... Greg Shah

08:59 AM Bug #2495: APPLY event TO handle does not work

I have found a common idiom which we don't handle properly. Here is an example:... Greg Shah

08:56 AM Bug #2495 (Closed): APPLY event TO handle does not work

Greg Shah

01/21/2015

06:17 PM Feature #2476: window icon support improvements

Committed in bzr as 10716. Eugenie Lyzenko

06:03 PM Feature #2476: window icon support improvements

Yes, go ahead. Greg Shah

05:47 PM Feature #2476: window icon support improvements

The @CTRL-C@ part completed without regressions. Had to start 3-way tests separately. The results file is on the shar... Eugenie Lyzenko

09:31 AM Feature #2476: window icon support improvements

The main part of the regression testing has been completed without regressions, starting the @CTRL-C@ tests. Eugenie Lyzenko

06:06 PM Feature #2478: button image support

OK, please take this into account in your design.
1. I think that the loadImage() methods should still be used by ... Greg Shah

05:32 PM Feature #2478: button image support

>Eugenie: please determine the answer to this question.
The answer is the moment when button is realized is the po... Eugenie Lyzenko

01:57 PM Feature #2478: button image support

> But if the image is loaded only when the frame (or button?) is realised, unless I've missed some discussion on the... Greg Shah

01:26 PM Feature #2478: button image support

>> Postpone the image loading to the moment when the button widget is created on the client side. This will requir... Eugenie Lyzenko

01:25 PM Feature #2478: button image support

Greg Shah wrote:
> > Postpone the image loading to the moment when the button widget is created on the client side. ... Constantin Asofiei

01:15 PM Feature #2478: button image support

> Postpone the image loading to the moment when the button widget is created on the client side. This will require ad... Greg Shah

12:56 PM Feature #2478: button image support

The button widget image processing note. There are two places when we need to set/load image integration into button ... Eugenie Lyzenko

01:29 PM Feature #2494: DELETE() method runtime implementation

Greg Shah wrote:
> I have not yet gotten the time to finish the code review on those changes (and on the other fix... Igor Skornyakov

01:06 PM Feature #2494: DELETE() method runtime implementation

> So, it seems that I can start coding now. Is that correct?\
Yes.
> Albeit these changes do not affect the cla... Greg Shah

01:01 PM Feature #2494: DELETE() method runtime implementation

Greg Shah wrote:
> Just change the @delete(int)@ to be @delete(long)@
Got it. So, it seems that I can start codin... Igor Skornyakov

12:51 PM Feature #2494: DELETE() method runtime implementation

> I see. However at this moment we have @delete(int)@ method in the @ControlSetEntity@ (and even in @GenericWidget@).... Greg Shah

12:22 PM Feature #2494: DELETE() method runtime implementation

Greg Shah wrote:
> > But I see entry(int) and entry(int64) in ControlSetEntity, but there is no entry(long)
>
> I... Igor Skornyakov

12:08 PM Feature #2494: DELETE() method runtime implementation

Constantin Asofiei wrote:
> To determine what is the message shown by the DELETE method (in this case), usually I ch... Igor Skornyakov

11:08 AM Feature #2494: DELETE() method runtime implementation

Constantin Asofiei wrote:
> On a side note, how do you use the @r-radio.p@ test? I've tried switching focus to the f... Igor Skornyakov

10:41 AM Feature #2494: DELETE() method runtime implementation

Greg Shah wrote:
> Constantin/Stanislav: can you think of other ways we code these warning cases in the P2J runtime?... Constantin Asofiei

10:21 AM Feature #2494: DELETE() method runtime implementation

> Does it just mean that there is no need to add delete(decimal idx) method?
Yes. Although how we would handle a ... Greg Shah

09:30 AM Feature #2494: DELETE() method runtime implementation

> This means we need some extra investigation. Some warnings are just formatted messages displayed in the message ... Igor Skornyakov

08:52 AM Feature #2494: DELETE() method runtime implementation

> method generates warning if
This means we need some extra investigation. Some warnings are just formatted mess... Greg Shah

07:29 AM Feature #2494: DELETE() method runtime implementation

Questions.
1. I understand that we should not care about thread safety of widgets' methods as they are supposed to b... Igor Skornyakov

07:09 AM Feature #2494: DELETE() method runtime implementation

Runtime support.
1. Server side.
a. Implement @delete(int idx)@, @delete(int64 idx)@, @delete(String item)@ and @de... Igor Skornyakov

06:04 AM Feature #2494: DELETE() method runtime implementation

1. The statement about raising error is not correct. Actually the @DELETE(list-index)@ method generates warning if ar... Igor Skornyakov

08:57 AM Feature #2422: add features to BROWSE

About this particular feature:
>If the previous page is fully deleted, you have to press Page Up twice in order to m... Stanislav Lomany

08:14 AM Feature #2422: add features to BROWSE

You'll be working on GUI soon, so do make sure that your approach can be easily adapted for those cases. Greg Shah

01/20/2015

05:59 PM Feature #2422: add features to BROWSE

Some differences in handling of Page Up/Down in ChUI and UI versions.
# About Page Down key (in ChUI it's not actu... Stanislav Lomany

04:31 PM Feature #2494: DELETE() method runtime implementation

Good results.
Please make sure you have tested the following:
* For @DELETE(list-index)@: @INTEGER@ inputs of 0... Greg Shah

02:59 PM Feature #2494: DELETE() method runtime implementation

1. The @DELETE()@ method exists for COMBO-BOX, RADIO-SET, SELECTION-LIST and BROWSE column widgets. Its semantics and... Igor Skornyakov

11:16 AM Feature #2494: DELETE() method runtime implementation

You can edit it manually like a normal cell. I'm not sure if drop-down list can actually appear in browse in ChUI. Po... Stanislav Lomany

07:45 AM Feature #2494: DELETE() method runtime implementation

Stanislav: in the 4GL, how does one get the ChUI browse cell for a combo-box into editing mode? Greg Shah

07:42 AM Feature #2494: DELETE() method runtime implementation

I failed to activate editing in Linux character mode. In Windows GUI mode the corresponding cell had standard clickab... Igor Skornyakov

07:38 AM Feature #2494: DELETE() method runtime implementation

FYI, LIST-ITEMS support in P2J may be partial (I think it is missing at least for browse columns).
When running th... Greg Shah

03:40 PM Feature #2476: window icon support improvements

The conversion testing completed. Generated codes are identical. Starting the runtime testing.
And I have committe... Eugenie Lyzenko

10:59 AM Feature #2476: window icon support improvements

> I suggest to run regression and commit icon related changes to have some intermediate work stage to shift the next... Greg Shah

10:59 AM Feature #2476: window icon support improvements

It is not a bad idea to load resources from a specific part of the jar, but I am OK with the current implementation a... Greg Shah

10:56 AM Feature #2476: window icon support improvements

Eugenie Lyzenko wrote:
> Regarding icon loading. Everything looks OK except one point I need to clarify:
> 1. Assum... Constantin Asofiei

10:42 AM Feature #2476: window icon support improvements

Regarding icon loading. Everything looks OK except one point I need to clarify:
1. Assume we start the server from @... Eugenie Lyzenko

08:02 PM Feature #2476: window icon support improvements

> I'm good with this.
>
> Does this pass all of your 4GL testcases?
>
> If so, please put it into conversion an... Eugenie Lyzenko

07:11 PM Feature #2476: window icon support improvements

Code Review evl_upd20150119c.zip
I'm good with this.
Does this pass all of your 4GL testcases?
If so, please... Greg Shah

01/19/2015

06:53 PM Feature #2476: window icon support improvements

Greg Shah wrote:
>
> The only thing I see is that @FileSystemOps.searchPath()@ should not be called from the clien... Eugenie Lyzenko

06:15 PM Feature #2476: window icon support improvements

Code Review evl_upd20150119b.zip
This is really good!
The only thing I see is that @FileSystemOps.searchPath(... Greg Shah

05:43 PM Feature #2476: window icon support improvements

Small change to eliminate point #4 from the notes. Eugenie Lyzenko

02:28 PM Feature #2476: window icon support improvements

The new update for review. The fixes for notes to the previous one. Also the @gclogo.ico@ default icon has been moved... Eugenie Lyzenko

11:44 AM Feature #2476: window icon support improvements

> Does it mean the @FileSystemOps.searchPath()@ must be called on client side?
Not exactly. Instead, the client ... Greg Shah

11:35 AM Feature #2476: window icon support improvements

One question.
>...If the app jar load fails, then it calls the client with a filename. It is the ThinClient.set*(S... Eugenie Lyzenko

03:33 PM Feature #2494: DELETE() method runtime implementation

> How the COMBO-BOX widget for the BROWSE column can be activated in the Linux character mode?
This is close, but... Greg Shah

08:07 PM Feature #2494: DELETE() method runtime implementation

Methods and attributes are functions and properties that can be invoked/read/written using a @HANDLE@ type. Each wid... Greg Shah

07:54 PM Feature #2494 (Closed): DELETE() method runtime implementation

Greg Shah

01/17/2015

10:35 AM Feature #2476: window icon support improvements

Code Review evl_upd20150116b.zip
1. You can't load @LogicalTerminal@ on the client, but you are trying to do so. ... Greg Shah

07:50 PM Feature #2476: window icon support improvements

This update has sources merged with the recent code base. Also cleanups, some common code rework(@Image@ class remove... Eugenie Lyzenko

08:15 AM Bug #2491 (Closed): SCREEN-VALUE returns a formatted value based on the widget's format string

CTRL-C tests passed (without any failures, including the 3-way ones). The attached version is checked in as bzr rev ... Greg Shah

06:40 AM Bug #2491: SCREEN-VALUE returns a formatted value based on the widget's format string

In regard to the use of screen-value in validation expressions, at least the basic functionality works as expected wi... Greg Shah

06:18 AM Bug #2491 (WIP): SCREEN-VALUE returns a formatted value based on the widget's format string

The @DateFormat@ class needed more changes to properly match the original behavior. With the attached changes, this ... Greg Shah

08:06 AM Feature #1790: implement menu support

Code Review vig_upd20150117a.zip
As a general approach, I'm not entirely convinced it is the best idea to add menu... Greg Shah

01/16/2015

04:54 PM Feature #2476: window icon support improvements

I'm more worried about the client falling back to the default icon when the @setWindowDefaultIcon()@ fails to load a ... Greg Shah

04:13 PM Feature #2476: window icon support improvements

>I think there is still a problem when the client side is told to do something (like load a filename) and that fails.... Eugenie Lyzenko

03:52 PM Feature #2476: window icon support improvements

Eugenie Lyzenko wrote:
> >3. Fallback to the default icon when other specified options fail.
>
> This is handled ... Greg Shah

03:50 PM Feature #2476: window icon support improvements

>3. Fallback to the default icon when other specified options fail.
This is handled in LT.setWindowDefaultIcon():
... Eugenie Lyzenko

02:27 PM Feature #2476: window icon support improvements

Code Review evl_upd20150116a.zip
This is really good. Keep going as per your plan.
I realize this is unfinishe... Greg Shah

02:05 PM Feature #2476: window icon support improvements

This update for review is not the final version to test. Just for you to see the default icon implementation and new ... Eugenie Lyzenko

03:58 PM Feature #1790: implement menu support

Here is the next update. I used @ScreenDefinition@ (not @ScreenBuffer@). Please confirm, that I'm on right way. Vadim Gindin

02:12 AM Feature #1790: implement menu support

> Constantin: thoughts?
# I suspect that showing the sub-menu (when a menu is activated in the menubar) will need to... Constantin Asofiei

08:04 AM Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> Greg Shah wrote:
> > Code Review ca_upd20150115b.zip
> >
> > I'm fine with the chang... Constantin Asofiei

05:42 AM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review ca_upd20150115b.zip
>
> I'm fine with the changes.
0115b.zip passed runtime testing. Constantin Asofiei

01:58 AM Bug #2491: SCREEN-VALUE returns a formatted value based on the widget's format string

Greg, I recall that SCREEN-VALUE was problematic in the widget validation expressions, too. It can be postponed if th... Constantin Asofiei

09:20 PM Bug #2491: SCREEN-VALUE returns a formatted value based on the widget's format string

It turns out that our SCREEN-VALUE implementation was nearly completely broken. MAJIC only uses a small number of ca... Greg Shah

09:15 PM Bug #2491 (Closed): SCREEN-VALUE returns a formatted value based on the widget's format string

Greg Shah

01/15/2015

06:35 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image

>Add @type == prog.define_image@ to that and I think the problem will be resolved.
Thank, this works. Eugenie Lyzenko

06:08 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image

> I've found I've missed one rule file update for image widget conversion support: convert/frame_generator.xml. Witho... Greg Shah

06:04 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image

Greg,
I've found I've missed one rule file update for image widget conversion support: convert/frame_generator.xml... Eugenie Lyzenko

05:04 PM Feature #1790: implement menu support

> ScreenBuffer is not really useful because it linked to a frame and we don't know what frame is the main (common). S... Greg Shah

03:17 PM Feature #1790: implement menu support

I trying to decide how to transfer information about main menu (menubar=true) to the client. @ScreenBuffer@ is not re... Vadim Gindin

11:35 AM Feature #1790: implement menu support

No, that is not something that is specific to the p2j project. It is a tool that we would add to the standard workst... Greg Shah

11:09 AM Feature #1790: implement menu support

Should I commit (without @work@ folder as you wrote) the script from the note #152? If yes - can I commit it right to... Vadim Gindin

11:03 AM Feature #1790: implement menu support

@vig_upd20150114d.zip@ is committed to bzr with rev №10709 Vadim Gindin

09:42 AM Feature #1790: implement menu support

Yes, please do check in vig_upd20150114d.zip and distribute it. Greg Shah

09:37 AM Feature #1790: implement menu support

The current update has passed conversion and regression testing. Can I commit it? Vadim Gindin

03:41 PM Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> Hynek, please check your tests, too.
Yes, works ok. Hynek Cihlar

01:58 PM Feature #2252: implement GUI client support

Code Review ca_upd20150115b.zip
I'm fine with the changes. Greg Shah

01:51 PM Feature #2252: implement GUI client support

Greg Shah wrote:
> > If down frame widgets are not moved by changing their ROW/COLUMN attribute, then I think we sh... Constantin Asofiei

01:23 PM Feature #2252: implement GUI client support

> If down frame widgets are not moved by changing their ROW/COLUMN attribute, then I think we should leave this as i... Greg Shah

01:14 PM Feature #2252: implement GUI client support

Greg,
> * moving widgets in a down frame; not sure yet, might be related to the layout issue.
This is related to th... Constantin Asofiei

10:12 AM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review ca_upd20150115a.zip
>
> It's good. Please check it in.
Released to rev 10708. Constantin Asofiei

09:44 AM Feature #2252: implement GUI client support

Code Review ca_upd20150115a.zip
It's good. Please check it in. Greg Shah

04:46 AM Feature #2252: implement GUI client support

This is replacement for ca_upd20150114b.zip and passed runtime testing. The @Assigning row/col attributes of a widg... Constantin Asofiei

01:40 PM Feature #2490: fix movement of widgets part of a down frame's body

The widgets part of the down body for a down frame can't be safely moved (by changing their ROW/COLUMN attributes) be... Constantin Asofiei

01:36 PM Feature #2490 (New): fix movement of widgets part of a down frame's body

Constantin Asofiei

12:53 PM Feature #2476: window icon support improvements

Actually, let's name @setDefaultWindowIcon()@ as @setWindowDefaultIcon()@ instead. I think it is more descriptive.
... Greg Shah

12:31 PM Feature #2476: window icon support improvements

>1. We want to minimize unnecessary calls from the client to the server. Generally, we want the server to dictate the... Eugenie Lyzenko

11:33 AM Feature #2476: window icon support improvements

Code Review evl_upd20150114a.zip
This is moving in the right direction, but I do have some questions/comments:
... Greg Shah

07:43 PM Feature #2476: window icon support improvements

The update includes icon related part of the icon/image implementation for review. Not completed testing but approach... Eugenie Lyzenko

01/14/2015

12:06 PM Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> Hynek, I'm planning on looking into solving these problems (based on my previous update)... Hynek Cihlar

11:58 AM Feature #2252: implement GUI client support

Hynek, I'm planning on looking into solving these problems (based on my previous update):
* Assigning row/col attrib... Constantin Asofiei

11:11 AM Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Second part of the SIDE-LABEL-... Hynek Cihlar

11:08 AM Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Second part of the SIDE-LABEL-HANDLE support, to allow changing... Constantin Asofiei

09:09 AM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review ca_upd20150114b.zip
>
> It looks like there were some tricky latent bugs that you ... Hynek Cihlar

09:08 AM Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> Second part of the SIDE-LABEL-HANDLE support, to allow changing the ROW/COLUMN attribute... Hynek Cihlar

09:06 AM Feature #2252: implement GUI client support

> The remaining issue is related to moving widgets in a down frame; root cause: server-side has only 1 widget which i... Greg Shah

09:05 AM Feature #2252: implement GUI client support

Code Review ca_upd20150114b.zip
It looks like there were some tricky latent bugs that you had to solve here. I se... Greg Shah

08:58 AM Feature #2252: implement GUI client support

The label moves ok and the position attributes are properly reported back to the server.
Btw. there are some (chui... Hynek Cihlar

06:51 AM Feature #2252: implement GUI client support

Second part of the SIDE-LABEL-HANDLE support, to allow changing the ROW/COLUMN attributes from the server-side. Runt... Constantin Asofiei

10:09 AM Feature #1790: implement menu support

> Can It be useful for somebody?
Very cool! I like it.
The only thing we need to do here is to eliminate the d... Greg Shah

10:03 AM Feature #1790: implement menu support

I was using an eclipse plugin to merge files last time and didn't accustom to this plugin probably. The reason of the... Vadim Gindin

09:54 AM Feature #1790: implement menu support

Thank you. These folders are different. diff*_ddl.txt is empty, but diff_*_src.txt is not empty. I'm trying to interp... Vadim Gindin

09:35 AM Feature #1790: implement menu support

As noted in the @timco.html@:
*Build and Save a Comparison Version*
Before running any conversion regression te... Greg Shah

09:30 AM Feature #1790: implement menu support

I've ran conv-regression task. It executed, but failed at the end. Here is the end of the log:... Vadim Gindin

08:35 AM Feature #1790: implement menu support

Code Review vig_upd20150114c.zip
This is really good. Please put it into both conversion and runtime regression t... Greg Shah

05:31 AM Feature #1790: implement menu support

I missed several files. Vadim Gindin

04:48 AM Feature #1790: implement menu support

Thank you. Here is the current update with these changes. Vadim Gindin

04:18 AM Feature #1790: implement menu support

Vadim Gindin wrote:
> Please, recall me, should I change a year of a Copyright block in each modified file to 2015?
... Constantin Asofiei

03:16 AM Feature #1790: implement menu support

I've merged @method_attributes.rules@ and changed @text@ with @names.convert(text, names.variable)@ corresponding to ... Vadim Gindin

09:06 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget

The @READ-FILE()@ method is already supported in @methods_attributes.rules@ (and the runtime stubs are in the @Editor... Greg Shah

08:32 PM Feature #2487 (Closed): implement READ-FILE() and SAVE-FILE() methods in the editor widget

Greg Shah

08:29 PM Feature #2486: enhance editor functionality

This task is just here to aggregate the related sub-tasks. Greg Shah

08:28 PM Feature #2486 (Closed): enhance editor functionality

Greg Shah

01/13/2015

01:19 PM Feature #1790: implement menu support

Code Review vig_upd20150113a.zip
The only problem I see is that you still have a duplicate section for @kw_full_h_... Greg Shah

01:14 PM Feature #1790: implement menu support

I think the triggers code looks fine. Is there anything else to do for the conversion? Greg Shah

12:48 PM Feature #1790: implement menu support

Here are the source and generated files for menu references in triggers as you asked earlier. Vadim Gindin

12:44 PM Feature #1790: implement menu support

The next update.
# Fixed remarks.
# Fixed @lvalue@ rule in progress.g (added KW_SUB_MENU as possible widget qualifi... Vadim Gindin

09:39 AM Feature #1790: implement menu support

It is a good question. We already have quite a bit of logic that handles these cases differently. Right now they ca... Greg Shah

09:38 AM Feature #1790: implement menu support

I suppose I should make the common AST subtree for both cases. How can I make it and where? May be it is also a parse... Vadim Gindin

09:33 AM Feature #1790: implement menu support

After I fixed some parsing problem I faced with the following difficulty during conversion of the following trigger:
... Vadim Gindin

07:18 AM Feature #2252: implement GUI client support

Committed to bzr revision 10704.
Greg Shah wrote:
> Code Review hc_upd20150112a.zip
>
> It looks good. Pleas... Hynek Cihlar

08:37 PM Feature #2252: implement GUI client support

Code Review hc_upd20150112a.zip
It looks good. Please check it in. Greg Shah

08:41 PM Feature #2476: window icon support improvements

OK, do whatever matches the behavior of the 4GL. Greg Shah

08:30 PM Feature #2476: window icon support improvements

The important finding. Progress does not load the icon from current directory if the current directory is not in @PRO... Eugenie Lyzenko

01/12/2015

06:30 PM Feature #2252: implement GUI client support

In ref to #2424.
The attached change set resolves widget positioning in a frame and passed regression testing. Ple... Hynek Cihlar

12:29 PM Feature #2422: add features to BROWSE

Here is the list of 4GL bugs which I'm not going to reproduce. It's obviously not full and may expand it as I'll find... Stanislav Lomany

12:13 PM Feature #1790: implement menu support

I'm OK with what I saw in the code.
Please post some examples here (both the 4GL and then the converted Java for t... Greg Shah

11:54 AM Feature #1790: implement menu support

The only triggers references are left. What do you think about approach I used for that? Vadim Gindin

11:10 AM Feature #1790: implement menu support

Code Review vig_upd20150112a.zip
Generally, the changes are quite good. I see the following cleanup items. It se... Greg Shah

09:39 AM Feature #1790: implement menu support

Here is the current update with the following changes.
# Fixed extra ';' for EXPRESSION/NUM_LITERAL. Check please is... Vadim Gindin

10:45 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image

Please add @CREATE IMAGE@ support by adding the widget to the list @DynamicWidgetFactory.java@. Greg Shah

01/10/2015

05:21 PM Feature #2476: window icon support improvements

>1. In ImageGuiImpl, should line 258 be if (readers.hasNext()) or should it be while (readers.hasNext())?
I use fi... Eugenie Lyzenko

01:07 PM Feature #2476: window icon support improvements

Code Review evl_upd20150109b.zip
1. In @ImageGuiImpl@, should line 258 be @if (readers.hasNext())@ or should it be... Greg Shah

07:36 PM Feature #2476: window icon support improvements

This update for review adds current path adding to be included in image loading approach. If the image or icon was no... Eugenie Lyzenko

01/09/2015

03:20 PM Feature #1790: implement menu support

You'll have to upload the entire update for me to get a better sense of your approach. We should not have to put lot... Greg Shah

12:29 PM Feature #1790: implement menu support

I found some interesting place in @expressions.rules@ line 1234:... Vadim Gindin

12:02 PM Feature #1790: implement menu support

I'm trying to find out a solution for extra semicolon emission (see note #71). I still can't find a place where it is... Vadim Gindin

01:24 PM Feature #2476: window icon support improvements

This upload for review implements small/regular icon loading. The idea is the difference we need to make is the image... Eugenie Lyzenko

07:55 AM Feature #2476: window icon support improvements

> Moreover according to 4GL document icon size difference should work in Windows 95 or NT method). So I do not even s... Greg Shah

07:54 AM Feature #2476: window icon support improvements

Please make sure you support all the variants of these methods (with more than one parameter).
In addition, it is ... Greg Shah

10:05 PM Feature #2476: window icon support improvements

>2. Add Window.loadSmallIcon() runtime support.
About LOAD-SMALL-ICON. Generally speaking there is no difference b... Eugenie Lyzenko

01/08/2015

08:55 AM Feature #2478: button image support

Greg Shah wrote:
> Is there any behavior yet to be implemented?
If we think about images processing here - handle... Eugenie Lyzenko

08:45 AM Feature #2478: button image support

Is there any behavior yet to be implemented? Greg Shah

07:36 AM Feature #2478: button image support

The update @evl_upd20150107a.zip@ has been committed in bzr as 10698. Eugenie Lyzenko

10:42 PM Feature #2478: button image support

Good, go ahead. Greg Shah

08:37 PM Feature #2478: button image support

Runtime testing completed. The results - @10696_65fcb0a_20150107_evl.zip@. The 3-way tests was started in separate se... Eugenie Lyzenko

07:03 PM Feature #2478: button image support

The update @evl_upd20150107a.zip@ has passed the main runtime regression cycle. Waiting for CTRL-C part to be completed. Eugenie Lyzenko

08:02 AM Feature #2476: window icon support improvements

The update @evl_upd20150107b.zip@ has been committed in bzr as 10699. Eugenie Lyzenko

05:28 AM Feature #2476: window icon support improvements

Eugenie: OK, go ahead and check it in. Greg Shah

05:26 AM Feature #2476: window icon support improvements

Greg Shah wrote:
> I don't know that we need to runtime test this since from a ChUI perspective this just adds a no-... Constantin Asofiei

05:25 AM Feature #2476: window icon support improvements

I don't know that we need to runtime test this since from a ChUI perspective this just adds a no-op method. Thoughts? Greg Shah

04:58 AM Feature #2476: window icon support improvements

Eugenie, your changes seem OK, but I'm not sure when the GUI code broke, as something simple as this doesn't work any... Constantin Asofiei

08:22 PM Feature #2476: window icon support improvements

Also note the new window in 4GL is placed over the main one, while in P2J the main window remains on top. This is the... Eugenie Lyzenko

08:02 PM Feature #2476: window icon support improvements

>1. Loading icons using using a handle that isn't CURRENT-WINDOW does not work.
The main issue with loading icons ... Eugenie Lyzenko

04:46 AM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review ca_upd20150108a.zip
>
> I'm fine with the code. Please check it in.
Committed ... Constantin Asofiei

04:38 AM Feature #2252: implement GUI client support

Code Review ca_upd20150108a.zip
I'm fine with the code. Please check it in. Greg Shah

01:57 AM Feature #2252: implement GUI client support

This is replacement for ca_upd20150105c.zip , adds SIDE-LABEL-HANDLE support. The positioning via ROW/COLUMN attribut... Constantin Asofiei

01/07/2015

03:04 PM Feature #1798: implement full frame family support (parent-child relationships between frames)

The above notes are really about the widget-level requirements, which perhaps should be placed in another task. I do... Greg Shah

03:00 PM Feature #1798: implement full frame family support (parent-child relationships between frames)

I think the conversion already supports these features. If I understand correctly, the work is on the runtime side.
... Greg Shah

12:55 PM Feature #2481 (Closed): enable, test and fix clipping for both rectangle and button GUI widgets

Greg Shah

12:53 PM Feature #1832 (Closed): implement image support

This work will be completed as part of #2446. Greg Shah

12:51 PM Feature #2446 (WIP): implement BUTTON and IMAGE GUI widgets (runtime and conversion support)

Greg Shah

10:30 AM Feature #2480: add support for button and image attributes and options

Some of these attributes are available for both button and image (but no other widgets). Other attributes are availa... Greg Shah

09:01 AM Feature #2480 (Closed): add support for button and image attributes and options

Greg Shah

10:27 AM Feature #2252: implement GUI client support

The conversion testing completed. Generated code files are identical. Starting the runtime regression tests. Eugenie Lyzenko

09:20 AM Feature #2252: implement GUI client support

Code Review evl_upd20150107a.zip
It looks fine. Greg Shah

08:57 AM Feature #2252: implement GUI client support

The new file for regression testing. There was missing enclosing quote (") in @methods_attributes.rules@ file. This c... Eugenie Lyzenko

09:55 PM Feature #2252: implement GUI client support

Code Review evl_upd20150106c.zip
Everything looks good. Please go ahead with testing. Greg Shah

09:50 PM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review evl_upd20150106b.zip
>
> @load-small-icon()@ is missing from the newer @methods_at... Eugenie Lyzenko

09:27 PM Feature #2252: implement GUI client support

Code Review evl_upd20150106b.zip
@load-small-icon()@ is missing from the newer @methods_attributes.rules@. Greg Shah

09:14 PM Feature #2252: implement GUI client support

>3. All the @ButtonWidget.loadImage*(character)@ methods are silently returning when you pass unknown value as the pa... Eugenie Lyzenko

08:14 PM Feature #2252: implement GUI client support

This:... Greg Shah

08:04 PM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review
>
> This is good. Some minor things:
>
> 1. Please move the @methods_attribut... Eugenie Lyzenko

07:26 PM Feature #2252: implement GUI client support

Code Review
This is good. Some minor things:
1. Please move the @methods_attributes.rules@ changes into the @... Greg Shah

08:54 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image

It is important to note that full DEFINE IMAGE conversion support is part of this task. Currently, we have some prov... Greg Shah

10:01 PM Feature #2425 (Closed): implement GUI rectangle widget

Greg Shah

01/06/2015

05:53 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image

Full Image phrase support for DEFINE BUTTON and DEFINE IMAGE widgets:
size-phrase({SIZE | SIZE-CHARS | SIZE-PIXELS... Greg Shah

05:53 PM Feature #2479 (Closed): DEFINE IMAGE and image phrase support for both button and image

Greg Shah

05:50 PM Feature #2478: button image support

Image handling methods for buttons:
LOAD-MAGE-UP
LOAD-IMAGE-DOWN
LOAD-IMAGE-INSENSITIVE
Reproduce native 4GL ... Greg Shah

05:49 PM Feature #2478 (Closed): button image support

Greg Shah

05:43 PM Bug #2477: button remains pressed when it should not

Sometimes button seems to lose track of mouse events. Perhaps it has something to do with dragging and then releasin... Greg Shah

05:43 PM Bug #2477 (Closed): button remains pressed when it should not

Greg Shah

05:42 PM Feature #2252: implement GUI client support

The update for review contains LOAD-MAGE-UP, LOAD-IMAGE-DOWN, LOAD-IMAGE-INSENSITIVE implementation for conversion an... Eugenie Lyzenko

05:39 PM Feature #2476: window icon support improvements

1. Loading icons using using a handle that isn't CURRENT-WINDOW does not work.
2. Add Window.loadSmallIcon() runti... Greg Shah

05:36 PM Feature #2476 (Closed): window icon support improvements

Greg Shah

01/05/2015

04:51 PM Feature #2252: implement GUI client support

Code Review ca_upd20150105c.zip
The update looks quite good.
The only thing I would suggest is to move @process... Greg Shah

04:00 PM Feature #2252: implement GUI client support

First pass at the SIDE-LABEL-HANDLE attribute. This can be used with these widgets: COMBO-BOX, EDITOR, FILL-IN, RADI... Constantin Asofiei

11:39 AM Feature #2252: implement GUI client support

Committed to bzr revision 10694.
Greg Shah wrote:
> Code Review hc_upd20150103a.zip
>
> The change is fine. P... Hynek Cihlar

11:10 AM Feature #2252: implement GUI client support

Code Review hc_upd20150103a.zip
The change is fine. Please check it in. Greg Shah

11:04 AM Feature #2252: implement GUI client support

The attached update resolves the runtime regression introduced by hc_upd20141221c. The problem was in unwanted change... Hynek Cihlar

09:42 AM Feature #2252: implement GUI client support

The @evl_upd20150103a.zip@ has been committed in bzr as @10693@. Eugenie Lyzenko

09:20 AM Feature #2252: implement GUI client support

The runtime testing for @evl_upd20150103a.zip@ completed including CTRL-C. No regressions except knowing @TC-INQUIRY-... Eugenie Lyzenko

04:10 AM Feature #1790: implement menu support

Greg Shah wrote:
> I'm not sure if we need to implement this tracking for shared menus. ... If I am right, then you... Constantin Asofiei

01/04/2015

09:29 AM Feature #2252: implement GUI client support

> Is it supposed the new dynamic window be shown in separate window in addition to the default one(I mean we should s... Greg Shah

01/03/2015

02:39 PM Feature #2252: implement GUI client support

>I didn't try it directly with CURRENT-WINDOW. Please see if the above handle-based @hwin@ code works for you.
The... Eugenie Lyzenko

12:05 PM Feature #2252: implement GUI client support

I was trying like this:... Greg Shah

10:31 AM Feature #2252: implement GUI client support

Greg,
>
> 1. I couldn't get the customer icons to load using simple testcases. It didn't matter which icon files ... Eugenie Lyzenko

10:19 AM Feature #2252: implement GUI client support

Summary of remaining work on image, icons, button and tooltip support:
+Icons+
1. I couldn't get the customer i... Greg Shah

10:01 AM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review evl_upd20150103a.zip
>
> The merge looks good. If it passes testing, please check... Eugenie Lyzenko

07:31 AM Feature #2252: implement GUI client support

Code Review evl_upd20150103a.zip
The merge looks good. If it passes testing, please check it in. Greg Shah

06:50 AM Feature #2252: implement GUI client support

>Eugenie: on second thought, please hold off of checking in and distributing the @evl_upd20141222a.zip@. I have been ... Eugenie Lyzenko

01/02/2015

04:56 PM Feature #2474: dynamically execute applhelp.p instead of driving it from a static directory entry

Today P2J can only have a static @applhelp.p@ equivalent, but in the 4GL the propath is searched dynamically to find ... Greg Shah

04:55 PM Feature #2474 (New): dynamically execute applhelp.p instead of driving it from a static directory...

Greg Shah

02:52 PM Bug #2473: ENABLE/DISABLE by themselves don't define frames (but they do add to them if the frame...

Consider these cases:
+Case 1+... Greg Shah

02:47 PM Bug #2473 (New): ENABLE/DISABLE by themselves don't define frames (but they do add to them if the...

Greg Shah

12/31/2014

01:56 PM Feature #1790: implement menu support

The parser will be connecting the @##@ node to the rest of the tree AFTER the @def_menu_stmt@ is done processing. So... Greg Shah

01:19 PM Feature #1790: implement menu support

I'm calling @sym.addMenuLike(#m.getText(), like_name, ##);@ in the end of @def_menu_stmt@ rule in @progress.g@. Insid... Vadim Gindin

01:02 PM Feature #1790: implement menu support

I don't really understand what you are doing. If @getParent()@ returns @null@, then that subtree hasn't yet been gra... Greg Shah

12:34 PM Feature #1790: implement menu support

How to hide/remove unnecessary AST nodes? I need to replace @DEFINE MENU m1 LIKE m@ with @DEFINE MENU m ....@. I've t... Vadim Gindin

09:30 AM Feature #1790: implement menu support

The @copyDefaultOptions()@ only saves a reference (inside the @Variable@ instance) to the copied subtree. It does no... Greg Shah

09:21 AM Feature #1790: implement menu support

My method is the following... Vadim Gindin

08:54 AM Feature #1790: implement menu support

Now I understand. Thank you! Vadim Gindin

08:45 AM Feature #1790: implement menu support

Vadim Gindin wrote:
> Thank you for quick answer. I've seen this method earlier and decided to write separate method... Greg Shah

08:39 AM Feature #1790: implement menu support

Thank you for quick answer. I've seen this method earlier and decided to write separate method @addMenuLike@ for menu... Vadim Gindin

08:17 AM Feature #1790: implement menu support

Vadim Gindin wrote:
> Greg, I don't understand about LIKE. Lets look at simple statement @define menu m like m1@. As... Greg Shah

08:04 AM Feature #1790: implement menu support

I thought so until now, but I just didn't find the place where the copying is happen. Vadim Gindin

08:00 AM Feature #1790: implement menu support

Greg, I don't understand about LIKE. Lets look at simple statement @define menu m like m1@. As a result, Do I need to... Vadim Gindin

12/30/2014

02:27 PM Feature #1790: implement menu support

Vadim Gindin wrote:
> The question about SHARED menus implementation. How about @MenuWidget.createStaticSharedMenu@?... Greg Shah

01:53 PM Feature #1790: implement menu support

The question about SHARED menus implementation. How about @MenuWidget.createStaticSharedMenu@? Is its implementation ... Vadim Gindin

12:14 PM Feature #1790: implement menu support

> The difficulty here is the fact, that already existing menu-item or sub-menu can be a part of DEFINE MENU/SUB-MENU ... Greg Shah

11:57 AM Feature #1790: implement menu support

Greg Shah wrote:
> Vadim Gindin wrote:
> > About ambiguity with DOTs. I've made additional testing and found the fo... Vadim Gindin

11:54 AM Feature #1790: implement menu support

Code Review vig_upd20141225a.zip
This looks pretty good.
1. Does referencing @convert/methods_attributes.rules@... Greg Shah

10:33 AM Feature #1790: implement menu support

Vadim Gindin wrote:
> About ambiguity with DOTs. I've made additional testing and found the following.
> # This amb... Greg Shah

10:31 AM Feature #1790: implement menu support

> About LIKE clause. I didn't find conversion implementation of LIKE in other statements for example DEFINE VARIABLE,... Greg Shah

12/29/2014

04:47 PM Feature #2422: add features to BROWSE

OK, sounds good to me. Eric Faulhaber

01:55 PM Feature #2422: add features to BROWSE

Eric, I'm not going to cache all rows, I'm only going to additionally cache row numbers and number of @rows + row num... Stanislav Lomany

01:15 PM Feature #2422: add features to BROWSE

Greg Shah wrote:
> > Considering all of the above I suggest to cache rows on the client side together with their row... Eric Faulhaber

08:14 AM Feature #2422: add features to BROWSE

> Windows version of Progress has bugs - in case of record deletion cursor may jump, some extra records may be missin... Greg Shah

04:29 PM Feature #1790: implement menu support

About ambiguity with DOTs. I've made additional testing and found the following.
# This ambiguity also appears for S... Vadim Gindin

03:03 PM Feature #1790: implement menu support

About LIKE clause. I didn't find conversion implementation of LIKE in other statements for example DEFINE VARIABLE, D... Vadim Gindin

08:40 AM Feature #1790: implement menu support

I will respond with a code review later, but for now I am responding to your parser ambiguity issue.
> In the curr... Greg Shah

12/28/2014

12:11 PM Feature #2252: implement GUI client support

The changes passed regression testing. They are checked in as follows:
# ges_upd20141222a.zip - bzr rev 10688
# ... Greg Shah

09:46 AM Feature #2252: implement GUI client support

Eugenie: on second thought, please hold off of checking in and distributing the @evl_upd20141222a.zip@. I have been ... Greg Shah

08:20 AM Feature #2252: implement GUI client support

There is no need to wait for the fix. Please check in and distribute evl_upd20141222a.zip. Greg Shah

12/27/2014

05:38 PM Feature #2422: add features to BROWSE

Some thoughts:
* Uncommitted deletions are deleted from the result list if records failed to load into a view. Row n... Stanislav Lomany

12/26/2014

12:03 PM Feature #2252: implement GUI client support

The runtime testing for @evl_upd20141222a.zip@ has been completed. All including CTRL-C tests are OK.
The only exc... Eugenie Lyzenko

10:44 AM Feature #1790: implement menu support

Just for documenting purposes. The parser problem of ambiguity is in @def_menu_stmt@ rule from @progress.g@:... Vadim Gindin

12/25/2014

05:55 PM Feature #1790: implement menu support

The next update containing following changes
* fixed and tested conversion of menu widgets references, based on "fin... Vadim Gindin