Activity

From 10/26/2017 to 11/24/2017

11/25/2017

09:56 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Constantin Asofiei wrote:
> > > 3369a rev 11231 contains... Eric Faulhaber
07:50 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > 3369a rev 11231 contains some performance fixes:
> > # a... Constantin Asofiei
07:38 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Branch 3369a rebased from trunk rev 11204. The latest revision is 11236.
This will require a full reconversion of... Greg Shah
07:13 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: I'm rebasing now. Greg Shah

11/24/2017

06:52 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Can I rebase 3369a? I know the 3375a change is not yet available, but I think it is best to go ahead and pick up the... Greg Shah
06:34 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Constantin Asofiei wrote:
> 3369a rev 11231 contains some performance fixes:
> # avoid unnecessary repaints
There ... Constantin Asofiei
05:10 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: 3369a rev 11231 contains some performance fixes:
# avoid logging overhead in the EmulatedWindowState and SwingEmulat... Constantin Asofiei
04:56 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Hynek Cihlar wrote:
> 3369a 11220 improves performance of coordinate values rounding.
There are still these cases w... Constantin Asofiei
04:29 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Yes, but I want to wait for Hynek's update first. Constantin Asofiei
04:28 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Does it need to rebase 3369a? Sergey Ivanovskiy
09:19 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Greg Shah wrote:
> Code Review Task Branch 3369a Revision 11226
I fixed a regression in 11227, I was not considerin... Constantin Asofiei
08:55 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Code Review Task Branch 3369a Revision 11226
I think the code is correct from a logical standpoint.
If we had... Greg Shah
07:25 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: 3369a rev 11225/11226 fixes class name collisions for converted external program names. Full conversion is required.... Constantin Asofiei
05:40 PM Bug #3375: Stack overflow kills the client: Greg Shah wrote:
> Code Review Task Branch 3375a Revision 11204
>
> The changes are fine. The difference now is ... Hynek Cihlar
12:40 PM Bug #3375: Stack overflow kills the client: Code Review Task Branch 3375a Revision 11204
The changes are fine. The difference now is very slight.
If it pa... Greg Shah
12:04 PM Bug #3375: Stack overflow kills the client: Hynek Cihlar wrote:
> It finished with one regression, I am currently fixing the issue. I don't expect the fix to ta... Hynek Cihlar
11:01 AM Bug #3375: Stack overflow kills the client: Greg Shah wrote:
> Code Review Task Branch 3375a Revision 11203
>
> I'm fine with the changes. Did ChUI regressi... Hynek Cihlar
08:09 AM Bug #3375: Stack overflow kills the client: Code Review Task Branch 3375a Revision 11203
I'm fine with the changes. Did ChUI regression testing finish? Greg Shah
02:37 PM Bug #3370 (Closed): READ-ONLY attribute error in server log: Greg Shah
02:26 PM Bug #3370: READ-ONLY attribute error in server log: Committed revision 11204.
Branch was archived. Notification email was sent to team. Ovidiu Maxiniuc
02:00 PM Bug #3370: READ-ONLY attribute error in server log: Please merge 3370a to trunk. Greg Shah
01:13 PM Bug #3370: READ-ONLY attribute error in server log: The conversion test on devsrv01 ended with success. The generated code by 3370a/11203 is unchanged.
Ovidiu Maxiniuc
08:58 AM Bug #3370: READ-ONLY attribute error in server log: Indeed, we should have an interface for each P4GL attribute / method. Some of them can be grouped together if they ar... Ovidiu Maxiniuc
08:41 AM Bug #3370: READ-ONLY attribute error in server log: Code Review Task branch 3370a Revision 11203
The changes look good.
I think you have found a more widespread fl... Greg Shah
06:49 AM Bug #3373: incremental scroll in non-full Browse page: Agreed.
Stanislav: Please put that change in 3369a. Then you can fix this issue later. Greg Shah
06:42 AM Bug #3373: incremental scroll in non-full Browse page: I noticed that in the log, but throwing exceptions in this manner is dangerous. This time the @incrementalScroll()@ w... Ovidiu Maxiniuc
06:30 AM Bug #3373: incremental scroll in non-full Browse page: Ovidiu: Does this affect a user or is it just a report in the log? Greg Shah

11/23/2017

12:09 PM Bug #3382: Client-side popup menus abend: I've created a client-side popup menu for browse (using the same approach used as in @ScrollPopupGuiImpl@) and called... Stanislav Lomany
12:01 PM Bug #3382: Client-side popup menus abend: Stanislav, do you remember the actual case when the exception happened? I would rather have a real recreate for this. Hynek Cihlar
11:45 AM Bug #3382 (WIP): Client-side popup menus abend: Hynek Cihlar
11:33 AM Bug #3373: incremental scroll in non-full Browse page: Greg, I'll fix it, but considering the amount of work for #3261 I'm not sure if I should fix it before or after Nov 30. Stanislav Lomany
11:30 AM Bug #3373 (WIP): incremental scroll in non-full Browse page: Stanislav,
I understand you are working on this issue so I am assigning it to you. Ovidiu Maxiniuc
11:33 AM Bug #3375 (WIP): Stack overflow kills the client: Ovidiu Maxiniuc
10:22 AM Bug #3375: Stack overflow kills the client: Created task branch 3375a and checked in the fix. The changes passed GUI regression tests, ChUI regression testing is... Hynek Cihlar
11:32 AM Bug #3374 (WIP): NPE in ConfigManager: I committed the fix for this issue was committed to 3369a with revision 11211. Ovidiu Maxiniuc
11:26 AM Bug #3371: NPE in AbstractGuiDriver in client log: The revision 11212 of 3369a makes sure the window is selected in @EditorGuiImpl.computeLineWidths()@. The exceptions ... Ovidiu Maxiniuc
11:22 AM Bug #3370: READ-ONLY attribute error in server log: I created 3370a created and committed a patch for this issue. Current revision is 11203. Please review. Ovidiu Maxiniuc

11/22/2017

04:02 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: 3369a 11220 improves performance of coordinate values rounding. Hynek Cihlar
03:57 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Code Review Task Branch 3369a Revision 11219
I'm good with the change.
Greg Shah
02:43 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Revision 11219 contains a fix for unresponsive message boxes. Somebody please review. Hynek Cihlar
02:25 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Committed revision 11218 removed waste code due to the web client profiling done by Eric. Sergey Ivanovskiy
09:41 AM Bug #3382: Client-side popup menus abend: The problem with popup menus created at client side is that they can cause abend under a certain circumstances, e.g. ... Stanislav Lomany
09:18 AM Bug #3382 (Closed): Client-side popup menus abend: Stanislav Lomany
08:33 AM Bug #3368 (Closed): dialog-box frame height is not set correctly: Greg Shah
08:20 AM Bug #3368: dialog-box frame height is not set correctly: 3368a was merged in trunk as revision 11202 and archived. Hynek Cihlar
06:23 AM Bug #3368: dialog-box frame height is not set correctly: Code Review Task Branch 3368a Revision 11205
The changes are good. You can merge to trunk. Greg Shah
05:22 AM Bug #3368: dialog-box frame height is not set correctly: 3368a revision 11205 contains a small change that resolves a regression found during ChUI testing. The revision has ... Hynek Cihlar
08:12 AM Bug #3381: Sub-menu drawing issues: Testcase attached (@sub-menus.p@). The following scenarios have issues:
# Right-click on the button: in swing the ri... Stanislav Lomany
05:43 AM Bug #3381 (Closed): Sub-menu drawing issues: Stanislav Lomany
06:57 AM Bug #3370: READ-ONLY attribute error in server log: I think this needs to be separate from 3369a, so that we don't introduce a delay in getting the most critical changes... Greg Shah
05:23 AM Bug #3370 (WIP): READ-ONLY attribute error in server log: Ovidiu Maxiniuc
05:22 AM Bug #3370: READ-ONLY attribute error in server log: Greg,
I finished moving the READ-ONLY attribute to a new interface.
Because the introduction of the new interface @... Ovidiu Maxiniuc
05:10 AM Bug #3370: READ-ONLY attribute error in server log: I found that @CommonHandle.readOnlyError(String)@ is annotated with @@LegacyAttribute(name = "READ-ONLY")@.
I cons... Ovidiu Maxiniuc
02:48 AM Bug #3373: incremental scroll in non-full Browse page: The issue occurs because the browse is not yet initialized at the point when "END" event is applied. So we must figur... Stanislav Lomany

11/21/2017

04:03 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: 3355a was merged into 3369a rev. 11213. Sergey Ivanovskiy
12:37 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: > As far as I understand file choose dialog (for choosing report output file) is in WIP state, so it works to a cert... Greg Shah
09:01 AM Bug #3371: NPE in AbstractGuiDriver in client log: Constantin Asofiei wrote:
> Ovidiu, please try something: is @EditorGuiImpl.processScrollPane@ called when i.e. the ... Ovidiu Maxiniuc
08:41 AM Bug #3371: NPE in AbstractGuiDriver in client log: Ovidiu, please try something: is @EditorGuiImpl.processScrollPane@ called when i.e. the editor is drawn? I wonder if... Constantin Asofiei
08:33 AM Bug #3371: NPE in AbstractGuiDriver in client log: I tried to move the code in a @withSelectedWindow()@, but the widget is not fully reconstructed so the parent is not ... Ovidiu Maxiniuc
06:42 AM Bug #3368: dialog-box frame height is not set correctly: Code Review Task Branch 3368a Revision 11204
I'm fine with the code. If it passes regression testing, you can mer... Greg Shah
06:21 AM Bug #3368: dialog-box frame height is not set correctly: Greg Shah wrote:
> except it is not clear why the null check was removed from @FrameGuiImpl@.
The null check was ... Hynek Cihlar
07:01 PM Bug #3368: dialog-box frame height is not set correctly: Code Review Task Branch 3368a Revision 11203
I'm fine with the changes, except it is not clear why the null check ... Greg Shah

11/20/2017

05:35 PM Bug #3371: NPE in AbstractGuiDriver in client log: Ovidiu, I would rather ensure that @EditorGuiImpl.computeLineWidths@ has a window selected (i.e. is bracketed in @gd.... Constantin Asofiei
03:11 PM Bug #3371: NPE in AbstractGuiDriver in client log: Code Review Task Branch 3369a Revision 11211
I generally OK with the changes. The one thing that is not clear to ... Greg Shah
04:46 PM Bug #3368: dialog-box frame height is not set correctly: The incorrect size turned to be a problem in the frame layout itself. The frame height is not calculated correctly wh... Hynek Cihlar
01:28 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Code Review Task Branch 3369a Revision 11209
I'm fine with the changes. I checked in some minor changes to make i... Greg Shah
01:08 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Constantin Asofiei wrote:
> Eric, I couldn't reproduce the iframe issue you've reported with 3369a. If you have any... Eric Faulhaber
01:02 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Constantin Asofiei wrote:
> Eric: Persistence.java needs a history entry.
Done. Eric Faulhaber
12:58 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Eric, I couldn't reproduce the iframe issue you've reported with 3369a. If you have any other details I can use to d... Constantin Asofiei
12:46 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Greg, 3369a rev 11208 is ready for review.
Eric: Persistence.java needs a history entry. Constantin Asofiei
10:30 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: 3369a rebased from trunk 11201. new rev is 11207. Constantin Asofiei
10:26 AM Bug #2799: browse widget doesn't execute validation expressions in P2J (both chui and gui): Stanislav Lomany wrote:
> > And now the BROWSE version is also fully supported, right?
> Right.
Please update th... Greg Shah
10:12 AM Bug #2799: browse widget doesn't execute validation expressions in P2J (both chui and gui): > And now the BROWSE version is also fully supported, right?
Right. Stanislav Lomany
09:50 AM Bug #2799: browse widget doesn't execute validation expressions in P2J (both chui and gui): > @FRAME:NO-AUTO-VALIDATE@ option is mentioned here and I didn't deal with it. Otherwise it can be closed.
I belie... Greg Shah
09:53 AM Bug #3373: incremental scroll in non-full Browse page: Stanislav Lomany wrote:
> I'm not sure.
> Ovidiu, how did you managed to create a @0 DOWN@ browse? (normally you ca... Ovidiu Maxiniuc
09:46 AM Bug #3373: incremental scroll in non-full Browse page: I'm not sure.
Ovidiu, how did you managed to create a @0 DOWN@ browse? (normally you can't create a browse with less... Stanislav Lomany
09:40 AM Bug #3373: incremental scroll in non-full Browse page: How much work is it to fix? Greg Shah
09:38 AM Bug #3373: incremental scroll in non-full Browse page: Yes. Stanislav Lomany
09:36 AM Bug #3373: incremental scroll in non-full Browse page: > No, it's internal P2J error.
@recordOrShowError()@ is only for "real" 4GL errors.
Is this a P2J bug? Greg Shah
09:01 AM Bug #3373: incremental scroll in non-full Browse page: No, it's internal P2J error. Stanislav Lomany
08:59 AM Bug #3373: incremental scroll in non-full Browse page: Is there an error in the 4GL? Greg Shah
08:49 AM Bug #3373: incremental scroll in non-full Browse page: Let me know if I should fix it (before/after deadline?). Stanislav Lomany
08:46 AM Bug #3373: incremental scroll in non-full Browse page: That is the event which represents a programming error. The text can be changed to "Incremental scroll cannot be used... Stanislav Lomany
08:06 AM Bug #3373: incremental scroll in non-full Browse page: The call to @incrementalScroll@ is caused by an... Ovidiu Maxiniuc
09:39 AM Bug #3370: READ-ONLY attribute error in server log: I agree with the solution. Greg Shah
09:06 AM Bug #3370: READ-ONLY attribute error in server log: I investigated this issue. The root cause of this error is the fact that the @READ-ONLY@ attribute is declared in @Co... Ovidiu Maxiniuc

11/19/2017

05:31 PM Bug #3306: Improve intermediate state in ROW-DISPLAY trigger.: That is still an amount of unplesant work which IMO we don't need to touch until customer meets a real problem with i... Stanislav Lomany
05:19 PM Bug #2799: browse widget doesn't execute validation expressions in P2J (both chui and gui): @FRAME:NO-AUTO-VALIDATE@ option is mentioned here and I didn't deal with it. Otherwise it can be closed. Stanislav Lomany
05:11 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: I was creating pop-up menu from a browse and met some issues:
1. As far as I understand file choose dialog (for choo... Stanislav Lomany
07:28 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Stanislav Lomany wrote:
> We need to have the switch for enhanced browse features, so I created this container, sear... Greg Shah

11/18/2017

06:46 PM Bug #3306: Improve intermediate state in ROW-DISPLAY trigger.: What is the status of this? Greg Shah
06:45 PM Bug #2799: browse widget doesn't execute validation expressions in P2J (both chui and gui): Can this be closed? Greg Shah
06:43 PM Feature #3275 (Closed): improve browse support: Greg Shah

11/17/2017

02:30 PM Bug #3374: NPE in ConfigManager: Ovidiu Maxiniuc wrote:
> Also, the location (@ConfigManager.java@:350) does not make sense: the @dirtyConfigs@ is in... Ovidiu Maxiniuc
01:54 PM Bug #3374: NPE in ConfigManager: The client is reset (back to login screen) when clicking various widgets. I found this is client log:... Ovidiu Maxiniuc
01:48 PM Bug #3374 (Closed): NPE in ConfigManager: Ovidiu Maxiniuc
02:09 PM Bug #3375: Stack overflow kills the client: The client got killed (not reset). Just before that the two shown windows started blinking alternatively. This is pro... Ovidiu Maxiniuc
02:06 PM Bug #3375 (Closed): Stack overflow kills the client: Ovidiu Maxiniuc
01:43 PM Bug #3373: incremental scroll in non-full Browse page: I found the following stack trace in client log:... Ovidiu Maxiniuc
01:38 PM Bug #3373 (Closed): incremental scroll in non-full Browse page: Ovidiu Maxiniuc
11:45 AM Bug #3371 (WIP): NPE in AbstractGuiDriver in client log: Found following exception in client log:... Ovidiu Maxiniuc
11:36 AM Bug #3371 (Closed): NPE in AbstractGuiDriver in client log: Ovidiu Maxiniuc

11/16/2017

03:13 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: We need to have the switch for enhanced browse features, so I created this container, searchable under @Directory.ID_... Stanislav Lomany
10:11 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Rebased task branch 3261a from P2J trunk revision 11201. Stanislav Lomany
08:09 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Created task branch 3261a from P2J trunk revision 11200. Stanislav Lomany
09:54 AM Feature #3275 (Review): improve browse support: 3275d has been merged into the trunk as bzr revision 11201. Stanislav Lomany
09:04 AM Feature #3275: improve browse support: Please merge 3275d to trunk. Greg Shah
08:55 AM Feature #3275: improve browse support: Customer POC works fine, any possible regressions are related to "interactive" browse features, I think it is OK to c... Stanislav Lomany
08:21 AM Feature #3275: improve browse support: Code Review Task Branch 3275d Revision 11203
The changes are good.
What testing do you recommend? The impact o... Greg Shah
07:06 AM Feature #3275: improve browse support: Rebased task branch 3275d from P2J trunk revision 11200. Please review. Stanislav Lomany

11/15/2017

09:18 AM Feature #3291: implement SYSTEM-DIALOG-COLOR: > The same code in FWD will only update the the color table entry, followed by a synch operation with the client. Thi... Greg Shah

11/14/2017

03:41 PM Feature #3291: implement SYSTEM-DIALOG-COLOR: Greg Shah wrote:
> > After the the user makes a selection, the selection will be used by widgets that are subsequent... Ovidiu Maxiniuc

11/09/2017

07:15 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: No, please create one. Stanislav Lomany
07:12 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Do we have a branch for this? Hynek Cihlar
05:36 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: > This dynamic layout (if enabled) will be in effect only when a browse widget will appear in any of the affected fra... Greg Shah
05:30 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: This dynamic layout (if enabled) will be in effect only when a browse widget will appear in any of the affected frame... Hynek Cihlar
05:18 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: I should have mentioned that if the browse is not positioned at the top left and there is space in either of those di... Greg Shah
05:13 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Greg Shah wrote:
> This is the concept:
> # Expand the size of both the containing frame and the enhanced browse to... Hynek Cihlar
05:10 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Greg Shah wrote:
> This is the concept:
On which events should the layout be changed? Is it after it is displayed... Hynek Cihlar
05:06 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: This is the concept:
# Detect if the containing window has empty space horizontally, vertically or both. If the b... Greg Shah
04:54 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Stanislav, Greg mentioned that you could use some help on "Automatically and sensibly expand to fit more space availa... Hynek Cihlar
07:08 AM Feature #3275: improve browse support: Created task branch 3275d from trunk revision 11198 (for "column and row resizing doesn't work properly" issues which... Stanislav Lomany

11/08/2017

03:27 PM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: Code Review Task Branch 3332a Revision 11207
I'm good with the code.
You will need to rebase (Eric is about to ... Greg Shah
02:57 PM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: 3332a 11207 makes the @loadImage@ methods accept @int64@ and added the overloads with Java primitive types. The revis... Hynek Cihlar
11:21 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: Greg Shah wrote:
> My concern is that this converted code won't compile because @integer@ is more specific than @int... Hynek Cihlar
11:14 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: > This should be covered. Although the native 4GL allows passing int64 values, anything above the max int value will ... Greg Shah
10:33 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: Greg Shah wrote:
> Code Review Task Branch 3332a Revision 11206
>
> 2. I would prefer to leave the primitive vers... Hynek Cihlar
10:14 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: Code Review Task Branch 3332a Revision 11206
1. I have no problem with forced wrapping for @load-image*()@. Don't... Greg Shah
09:51 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: 3332a revision 11206 is rebased againt trunk 11196. Please review. Hynek Cihlar
09:45 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: 3332a revision 11206 resolves the review points except one exception mentioned below, fixes several widget sizing cas... Hynek Cihlar

11/05/2017

02:14 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: > If we hide a column in interactive mode it is, obviously, hidden in the report. Is it hidden when we return to norm... Greg Shah

11/04/2017

01:28 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: > Are we talking about the same thing?
Yes.
> Everything is correct except that I don't understand why the Age ... Stanislav Lomany
09:25 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: >> Do you mean replaced with an enhanced version of itself?
>
> I mean a version where:
I think this is the sam... Greg Shah
09:18 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Everything is correct except that I don't understand why the Age column exists in the final browse (bottom left to th... Greg Shah

11/03/2017

05:32 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: To make sure that we are on the same page. Is this diagram right?
!diagram1.png! Stanislav Lomany
01:42 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: > Do you mean replaced with an enhanced version of itself?
I mean a version where:
# column resize is on;
# col... Stanislav Lomany
12:51 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: > In that mode, browse is "replaced" with an interactive version of itself.
Do you mean replaced with an enhanced... Greg Shah
12:30 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Consider user enters interactive mode. In that mode, browse is "replaced" with an interactive version of itself. Are ... Stanislav Lomany
11:55 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: > So, when a column is hidden in report, it is hidden in the current browse too, right?
I would say it the other ... Greg Shah
11:53 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: I assume "yes" means that formats match. So, when a column is hidden in report, it is hidden in the current browse to... Stanislav Lomany
11:33 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Yes, that is the idea. Greg Shah
11:27 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Should in-application browse format (i.e. the current view) match output browse format or not?
Stanislav Lomany
11:05 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: The idea is that the user should be able to customize the look and feel of the actual browse columns in interactive m... Greg Shah
09:47 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: > I want the user to be able to override formatting choices like ... the width of a column
Do you mean column widt... Stanislav Lomany
08:05 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: As noted above, I want the user to be able to override formatting choices like font, font color, cell background colo... Greg Shah
08:02 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: I like the idea of a custom report template. That will be powerful capability.
Please note that there should be a... Greg Shah
11:53 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: Eugenie Lyzenko wrote:
> Actually I do not understand why to change so lot. The image with offset is the regular ima... Hynek Cihlar
10:52 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: Greg Shah wrote:
> Code Review Task Branch 3332a Revision 11201
>
> Eugenie: Please review that code.
1. @load... Eugenie Lyzenko
09:15 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: Greg Shah wrote:
> On which line of code does that occur? I must be having a mental block, I don't see it.
See t... Hynek Cihlar
09:14 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: Greg Shah wrote:
> The caller can be using literals that will normally emit as Java primitives. When mixing those t... Hynek Cihlar
09:10 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: >> 5. I don't understand the implementation of ButtonWidget.loadImageInt(). All the offset and width/height data is u... Greg Shah
09:07 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: >> 4. We don't support the full range of method signatures for ButtonWidget.loadImage*(). We are currently missing th... Greg Shah
06:35 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: Greg Shah wrote:
> Code Review Task Branch 3332a Revision 11201
>
> 1. In the versions of @ButtonWidget.loadImage... Hynek Cihlar
05:57 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: Code Review Task Branch 3332a Revision 11201
1. In the versions of @ButtonWidget.loadImage*()@ which have @integer... Greg Shah
11:06 AM Bug #3335 (Closed): buggy no-validate in browse widget: These changes are included in trunk rev 11185. Greg Shah
10:25 AM Bug #3335 (Review): buggy no-validate in browse widget: Fixed as part of #3275 Stanislav Lomany

11/02/2017

05:53 PM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: 3332a contains the implemented IMAGE and BUTTON load size and offset plus related changes. Also the branch includes t... Hynek Cihlar
05:40 PM Feature #3261 (WIP): enhanced browse that can optionally selected as a replacement for the defaul...: > One idea is to provide generic export to the following formats:
>
> * csv
> * xls/xlsx
> * pdf
I think we c... Stanislav Lomany
11:23 AM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Greg Shah wrote:
> These seem important:
>
> * keyboard navigation
> * search combobox
> * New folder
> * More... Ovidiu Maxiniuc
11:01 AM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: These seem important:
* keyboard navigation
* search combobox
* New folder
* More options (at least the user sh... Greg Shah
10:40 AM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: The basic functionality is there. One can navigate to desired location and select the desired file. Here are some scr... Ovidiu Maxiniuc

11/01/2017

02:28 PM Feature #3289: implement SYSTEM-DIALOG-GET-DIR: Greg Shah wrote:
> The runtime implementation for this task was written in branch 1830b and was merged to trunk as r... Ovidiu Maxiniuc
02:22 PM Feature #3289: implement SYSTEM-DIALOG-GET-DIR: The runtime implementation for this task was written in branch 1830b and was merged to trunk as revision 11188.
An... Greg Shah
02:25 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: An update from Ovidiu:
> File dialogs are well connected with Windows Explorer. One can use it as a 'shell' and: c... Greg Shah
02:15 PM Feature #3291: implement SYSTEM-DIALOG-COLOR: > After the the user makes a selection, the selection will be used by widgets that are subsequently created, but alre... Greg Shah
02:14 PM Feature #3291: implement SYSTEM-DIALOG-COLOR: The runtime implementation for this task was written in branch 1830b and was merged to trunk as revision 11188.
Th... Greg Shah
02:15 PM Feature #3290: implement SYSTEM-DIALOG-FONT: > After the the user makes a selection, the selection will be used by widgets that are subsequently created, but alre... Greg Shah
02:14 PM Feature #3290: implement SYSTEM-DIALOG-FONT: The runtime implementation for this task was written in branch 1830b and was merged to trunk as revision 11188.
Th... Greg Shah
01:31 PM Feature #2368: allow widget output to stream in GUI mode: > To be clear, issues mentioned in #2368-12 are not fixed.
OK, then log this case too (VIEW of a STREAM-IO frame).... Greg Shah
01:04 PM Feature #2368: allow widget output to stream in GUI mode: Greg Shah wrote:
> > We should be good as long as a frame is not used in mixed mode (and from all code I've seen, fr... Constantin Asofiei
01:02 PM Feature #2368: allow widget output to stream in GUI mode: > We should be good as long as a frame is not used in mixed mode (and from all code I've seen, frames are usually sin... Greg Shah
12:56 PM Feature #2368: allow widget output to stream in GUI mode: Greg Shah wrote:
> Constantin: Did you ever check to see if STREAM-IO frames have different behavior when used inter... Constantin Asofiei
12:50 PM Feature #2368: allow widget output to stream in GUI mode: Constantin: Did you ever check to see if STREAM-IO frames have different behavior when used interactively?
If I ... Greg Shah

10/30/2017

06:45 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Branch 1830b was rebased and merged to trunk as r11188.
The branch was archived and a notification email sent to tea... Ovidiu Maxiniuc
06:27 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Please rebase and then merge to trunk. Greg Shah
06:21 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Greg,
After doing some manual tests I identified a possible regression in 1830b/11210 that caused a NPE. Because o... Ovidiu Maxiniuc
04:54 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Ignore this failure. Greg Shah
04:53 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: The extra line is (14):
@ 1234 14.0 6.1 0.0 20.2 -7.9 18.4 16.0 -5.4@
It is p... Ovidiu Maxiniuc
04:41 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: It may be just a rare timing issue.
Eugenie: what do you think? Greg Shah
04:09 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Branch 1830b was rebased to latest trunk (r11186). Current revision is 11210.
I tried to understand the extra line... Ovidiu Maxiniuc
03:45 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Ovidiu Maxiniuc wrote:
> Hynek Cihlar wrote:
> > The window of windowId should be passed to @DialogBoxWindow.setOwn... Hynek Cihlar
03:39 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Hynek Cihlar wrote:
> The window of windowId should be passed to @DialogBoxWindow.setOwner()@ before the modal windo... Ovidiu Maxiniuc
03:21 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Ovidiu Maxiniuc wrote:
> > The parameter windowId in FontChooserGuiImpl.createInstance is not referenced. I think th... Hynek Cihlar
03:10 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Hynek Cihlar wrote:
> Code review 1830b revision 11208.
>
> Please remove "Invalidates HSL encoding." from ColorR... Ovidiu Maxiniuc
01:17 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Code review 1830b revision 11208, part two.
In DirDialogGuiImpl the copyright statement should only contain the cu... Hynek Cihlar
01:08 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Code review 1830b revision 11208.
Here is a few minor points.
Please remove "Invalidates HSL encoding." from Co... Hynek Cihlar
10:32 AM Feature #3282: create a 4GL language extension to control screen refresh: 3282b merged to trunk as revision 11186 and archived. Hynek Cihlar
07:30 AM Feature #3282: create a 4GL language extension to control screen refresh: Code Review Task Branch 3282b Revision 11187
The code is good.
Please rebase. There will be some minor conflic... Greg Shah
02:46 AM Feature #3282: create a 4GL language extension to control screen refresh: I checked in a fix of the regression of combo box and menu not handling mouse input in 3282b and also addressed the p... Hynek Cihlar
11:32 PM Feature #3282: create a 4GL language extension to control screen refresh: Code Review Task Branch 3282b Revision 11186
I'm fine with the code. Greg Shah
06:04 AM Feature #3275: improve browse support: 3275c has been merged into the trunk as bzr revision 11185. Stanislav Lomany
04:43 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: 3332a rebased against latest trunk. Hynek Cihlar

10/29/2017

01:40 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: After replacing @ModalBox@ with @IsModal@ interface and fixing other regressions caused by rebase operation I committ... Ovidiu Maxiniuc
12:35 PM Feature #3282: create a 4GL language extension to control screen refresh: Greg Shah wrote:
> One question: What is the reason that @Window.isRepaintDisabled()@ is hard coded to @false@?
T... Hynek Cihlar
10:19 PM Feature #3282: create a 4GL language extension to control screen refresh: Code Review Task Branch 3282b Revision 11184
I'm generally fine with the changes.
One question: What is the rea... Greg Shah
06:40 AM Feature #3275: improve browse support: Rebased task branch 3275c from P2J trunk revision 11184. Stanislav Lomany
09:54 PM Feature #3275: improve browse support: Code Review Task Branch 3275c Revision 11194
I'm good with the changes. If it passes testing you can merge to trunk. Greg Shah
04:18 AM Feature #3287: local web client installation: 3287a was merged into the trunc rev 11183 and archived. Sergey Ivanovskiy
09:26 PM Feature #1795 (Closed): implement printing support (real GUI printing not the child process stuff...: Greg Shah
09:26 PM Feature #3313 (Closed): implement SYSTEM-DIALOG-PRINTER-SETUP: For now, the implementation is not directly mapped to the Windows printer dialog. Instead it is designed to support ... Greg Shah

10/28/2017

03:44 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Hynek Cihlar wrote:
> * build.xml is missing change history entry.
Added
> * It may be a bit confusing that ColorR... Ovidiu Maxiniuc
01:18 PM Feature #3275: improve browse support: I'm good with the persistence-related changes. Also, I successfully ran the ETF full search test suite against 3275c/... Eric Faulhaber
10:30 AM Feature #3282: create a 4GL language extension to control screen refresh: 3282b rebased against trunk revision 11184. Hynek Cihlar
10:14 AM Feature #2368: allow widget output to stream in GUI mode: 1795b was merged to trunk as revision 11184. Hynek Cihlar
10:13 AM Feature #3313: implement SYSTEM-DIALOG-PRINTER-SETUP: Runtime support of the print dialog in the limited support for the internal PDF printer was merged to trunk in 1795b ... Hynek Cihlar
10:11 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...: 1795b passed ChUI regression tests, was rebased against trunk revision 11183 and merged to trunk as revision 11184.
... Hynek Cihlar

10/27/2017

07:42 PM Feature #3275: improve browse support: Please review 3275c revision 11194, it has significant refactoring according to the notes above. Stanislav Lomany
03:41 PM Feature #3275: improve browse support: > * @BufferFieldImpl.java@:1265, instead of manually prefixing the error message with @**@ use the @prefix@ parameter... Stanislav Lomany
07:59 AM Feature #3275: improve browse support: Eric Faulhaber wrote:
> Ovidiu, please review the changes specific to the dynamic compilation and runtime JAST inter... Ovidiu Maxiniuc
07:22 PM Feature #3287: local web client installation: The last result 20171027_153157 were not good but the target test TC-JOB-CLOCK-002 passed - OK. Planning to merge int... Sergey Ivanovskiy
06:41 PM Feature #3287: local web client installation: OK. Running majic_regression_testing_tc.xml test case for TC-JOB-CLOCK-002, according to logs it should be completed ... Sergey Ivanovskiy
05:35 PM Feature #3287: local web client installation: And please merge 3287a to trunk. Constantin Asofiei
04:15 PM Feature #3287: local web client installation: Sergey Ivanovskiy wrote:
> Yes, planning to create deploy/broker/ folder. It seems that I am very needed the tool th... Constantin Asofiei
04:13 PM Feature #3287: local web client installation: Yes, planning to create @deploy/broker/@ folder. It seems that I am very needed the tool that can update only one new... Sergey Ivanovskiy
04:05 PM Feature #3287: local web client installation: Ok, then 3287a can be released.
For Hotel GUI and POC: can you make the changes so that it doesn't affect the curr... Constantin Asofiei
03:53 PM Feature #3287: local web client installation: I meant this broker user in @client.xml@ for the broker agent.... Sergey Ivanovskiy
03:49 PM Feature #3287: local web client installation: Yes, it is the first case from #3287-72 with the dedicated mode. The broker user is a trusted FWD user used for trust... Sergey Ivanovskiy
03:42 PM Feature #3287: local web client installation: OK, so if a broker is started on the client's machine, the server will spawn the FWD client for the embedded app via ... Constantin Asofiei
03:40 PM Feature #3287: local web client installation: If there are no brokers, then web clients are created locally. Sergey Ivanovskiy
03:37 PM Feature #3287: local web client installation: Yes, it should work without any additional setup. There are only required to change Hotel GUI embedded and customer's... Sergey Ivanovskiy
03:33 PM Feature #3287: local web client installation: Sergey Ivanovskiy wrote:
> Greg, Constantin, can this branch be merged into trunc if this test will be OK?
Is there... Constantin Asofiei
02:59 PM Feature #3287: local web client installation: Greg, Constantin, can this branch be merged into trunc if this test will be OK? Sergey Ivanovskiy
02:57 PM Feature #3287: local web client installation: gso_ctrlc_3way_tests tests were passed in this 20171027_124426 run. There is only suspected TC-JOB-CLOCK-002. Sergey Ivanovskiy
12:39 AM Feature #3287: local web client installation: In the last run gso_ctrlc_tests passed, but gso_ctrlc_3way_tests failed for:... Sergey Ivanovskiy
08:14 PM Feature #3287: local web client installation: ctrl_c tests are frozen in two runs. Running this test again. Sergey Ivanovskiy
04:24 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Ovidiu Maxiniuc wrote:
> Hynek,
>
> I got the notification because I am the assignee. Thank you very much for the... Hynek Cihlar
04:18 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Hynek,
I got the notification because I am the assignee. Thank you very much for the quick review. I will do the f... Ovidiu Maxiniuc
04:14 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Ovidiu, I added you as the issue watcher. Please see the review in note 18. Hynek Cihlar
04:10 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support: Code Review Task Branch 1830b Revision 11199.
The changes are impressive, hands down. I found only some minor issu... Hynek Cihlar
11:30 AM Feature #3282: create a 4GL language extension to control screen refresh: Extended DSIABLE-REDRAW to all widget types. Previously only WINDOW widget was supported. I checked in the change int... Hynek Cihlar

10/26/2017

05:08 PM Feature #3275: improve browse support: I'm OK with adding a version that takes a boolean flag to disable the message box. Greg Shah
02:59 PM Feature #3275: improve browse support: > 1. In @ControlEntity@, the use of @LogicalTerminal.message()@ instead of something in @ErrorManager@ seems incorrec... Stanislav Lomany
02:05 PM Feature #3275: improve browse support: > * In @DynamicQueryHelper.injectVariable@, why are all literal values replaced with the same variable?
I needed a f... Stanislav Lomany
01:42 PM Feature #3275: improve browse support: Greg Shah wrote:
> Eric: Please review the changes in the persist package.
Wow, that's a big set of changes! The up... Eric Faulhaber
09:25 AM Feature #3275: improve browse support: Code Review Task Branch 3275c Revision 11193
Eric: Please review the changes in the persist package.
Everything... Greg Shah
07:53 AM Feature #3275: improve browse support: Yes, just finished. Please review 3275c revision 11193. Stanislav Lomany
07:33 AM Feature #3275: improve browse support: Is 3275c ready for review? Greg Shah
01:55 PM Feature #3287: local web client installation: OK. (It is recommended to run TC-JOB-CLOCK-002 after 16-00 of the server time. Thus I will run it later.) Planning st... Sergey Ivanovskiy
01:54 PM Feature #3287: local web client installation: Sergey Ivanovskiy wrote:
> Yes, you are correct. I mean tc_job_clock_002.
I've checked the failed screen and this o... Constantin Asofiei
01:47 PM Feature #3287: local web client installation: Yes, you are correct. I mean tc_job_clock_002. Sergey Ivanovskiy
01:44 PM Feature #3287: local web client installation: Sergey Ivanovskiy wrote:
> Thus, tc_job_002 is suspected.
This is the single test which still fails in FWD, so you ... Constantin Asofiei
01:43 PM Feature #3287: local web client installation: In two runs of the main-regression task there were
failed tests in the first run... Sergey Ivanovskiy
12:06 PM Feature #3331 (Closed): translate 4GL menu widget processing into a standardized embedded web cli...: Greg Shah
11:26 AM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...: Greg, this task can be closed too - the standard/default FWD menu for embedded mode works. Constantin Asofiei
12:06 PM Feature #3260 (Closed): auto-conversion and enablement for the embedded web client: Greg Shah
11:25 AM Feature #3260: auto-conversion and enablement for the embedded web client: Greg, this task can be closed. Constantin Asofiei
09:46 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...: Code Review Task branch 1795b Revision 11203
I'm good with the changes.
If it passes ChUI regression testing, p... Greg Shah
09:33 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...: The latest 1795b resolves the points from review, point 3 from note 42, plus some related changes. I don't expect any... Hynek Cihlar
04:32 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...: Sergey Ivanovskiy wrote:
> Were these pdf pages in your test pure text pages without graphics?
Yes, all were pure... Hynek Cihlar
04:30 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...: Hynek Cihlar wrote:
> Greg Shah wrote:
> > Code Review Task branch 1795b Revision 11200
> > 1. The thing I wonder ... Sergey Ivanovskiy
04:26 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...: Greg Shah wrote:
> Code Review Task branch 1795b Revision 11200
> 1. The thing I wonder about is how well the strea... Hynek Cihlar

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » User Interface

Activity

Activity

11/25/2017

11/24/2017

11/23/2017

11/22/2017

11/21/2017

11/20/2017

11/19/2017

11/18/2017

11/17/2017

11/16/2017

11/15/2017

11/14/2017

11/13/2017

11/12/2017

11/10/2017

11/09/2017

11/08/2017

11/05/2017

11/04/2017

11/03/2017

11/02/2017

11/01/2017

10/30/2017

10/29/2017

10/28/2017

10/27/2017

10/26/2017