Activity

From 11/06/2017 to 12/05/2017

12/06/2017

09:49 PM Bug #3382: Client-side popup menus abend: Unfortunately this is not enough to fix the issue. Moving @MenuItemGuiImpl.selectMenuItem()@ before @ScrollPopupGuiIm... Eugenie Lyzenko

12/05/2017

02:34 PM Bug #3382: Client-side popup menus abend: Eugenie Lyzenko wrote:
> You mean execution @selectMenuItem()@ first, then mouse adapters?
Exactly so. Hynek Cihlar
05:55 AM Bug #3382: Client-side popup menus abend: Hynek Cihlar wrote:
> Please try to move the execution of mouse adapters in @MenuItemGuiImpl.mouseClicked@ before @s... Eugenie Lyzenko
04:29 AM Bug #3382: Client-side popup menus abend: Eugenie Lyzenko wrote:
> So the suggested fix approach can be the following change in @ThinClient.invokeTriggers(...... Hynek Cihlar
09:35 PM Bug #3382: Client-side popup menus abend: So the suggested fix approach can be the following change in @ThinClient.invokeTriggers(...)@, line starting at @1822... Eugenie Lyzenko

12/04/2017

06:36 PM Bug #3382: Client-side popup menus abend: Debugging result. The current events data flow:
1. After the user clicks on @Scroll here@ pop up menu from scrollb... Eugenie Lyzenko
04:00 PM Feature #3394: generic drawing improvements: repaint and other misc code: Sergey Ivanovskiy wrote:
> The order of repaints can be the root cause?
No, as they just determine which widgets wi... Constantin Asofiei
03:27 PM Feature #3394: generic drawing improvements: repaint and other misc code: The order of repaints can be the root cause? Sergey Ivanovskiy
03:25 PM Feature #3394: generic drawing improvements: repaint and other misc code: Updated #3394-18 with correct logs. Yes, they are 121 and 124. Sergey Ivanovskiy
03:10 PM Feature #3394: generic drawing improvements: repaint and other misc code: Sergey Ivanovskiy wrote:
> Finally, the last two nodes: "Twin" and "Luxury Suite " were not repainted.
Do you now t... Constantin Asofiei
03:08 PM Feature #3394: generic drawing improvements: repaint and other misc code: Yes, I tested Hotel GUI Add Room Dialog and opened the first node and then opened the second node. Finally, the last ... Sergey Ivanovskiy
01:38 PM Feature #3394: generic drawing improvements: repaint and other misc code: Sergey Ivanovskiy wrote:
> Interesting note if setup conditional breakpoints for the tree control widgets in @Abstra... Constantin Asofiei
01:35 PM Feature #3394: generic drawing improvements: repaint and other misc code: Interesting note if setup conditional breakpoints for the tree control widgets in @AbstractWidget.afterConfigUpdateBa... Sergey Ivanovskiy
03:57 PM Bug #2766: implement a text metrics server process: Code Review Task Branch 3394a Revisions 11232/11233
I'm good with the changes. Greg Shah
02:36 PM Bug #2766: implement a text metrics server process: Greg, please review 3394a rev 11232/11233. Constantin Asofiei
01:27 PM Bug #2766: implement a text metrics server process: Greg Shah wrote:
> You recently added the captured @text-metrics.xml@ to the project. Was there a problem that drov... Constantin Asofiei
01:21 PM Bug #2766: implement a text metrics server process: > Another note: currently FontManager reads the entire font-table (~46k strings) into the client-side's memory. In th... Greg Shah
01:18 PM Bug #2766: implement a text metrics server process: I was not using the properly derived font (as Swing was doing) when computing the metrics. With current changes, the... Constantin Asofiei
10:52 AM Bug #2766: implement a text metrics server process: Some quick and dirty changes in web code allow AWT Font and FontMetrics to be used. But I think I'm not using the co... Constantin Asofiei
08:02 AM Bug #2766: implement a text metrics server process: Agreed. Greg Shah
06:26 AM Bug #2766: implement a text metrics server process: Greg Shah wrote:
> Another approach might be to use caching for the calculated metrics. This would have to be done ... Constantin Asofiei
06:14 AM Bug #2766: implement a text metrics server process: I agree we should resolve this.
If we can calculate suitable metrics in the Java client, I would be fine with that... Greg Shah
06:05 AM Bug #2766: implement a text metrics server process: In addition to the functional issues we see from deviations from the Windows metrics when encountering dynamic text, ... Greg Shah

12/02/2017

11:44 AM Bug #3382: Client-side popup menus abend: Eugenie Lyzenko wrote:
>
> This also eliminates the exception for widgets that detached from parent, like pop-up m... Hynek Cihlar

12/01/2017

05:46 PM Bug #3382: Client-side popup menus abend: Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
>
> If in the menu-item it is expected that the top-level window may... Eugenie Lyzenko
04:56 PM Bug #3382: Client-side popup menus abend: Eugenie Lyzenko wrote:
> This change resolve the issue. Any objections or notes?
The exception thrown from @topLe... Hynek Cihlar
04:38 PM Bug #3382: Client-side popup menus abend: The root cause for this issue is the code in pop up menu item:... Eugenie Lyzenko
04:42 PM Bug #3401: clarifications for windows related methods in Widget and GuiDriver classes: Patch committed to 3394a as revision 11221. Ovidiu Maxiniuc
03:07 PM Bug #3401: clarifications for windows related methods in Widget and GuiDriver classes: Recently I used the @window()@ method to pass the window id of a @EditorGuiImpl@ in the @GuiDriver@ for accessing som... Ovidiu Maxiniuc
02:42 PM Bug #3401 (Closed): clarifications for windows related methods in Widget and GuiDriver classes: Ovidiu Maxiniuc
10:27 AM Feature #3394: generic drawing improvements: repaint and other misc code: 3394a was rebased from trunk rev 11208 - new rev 11219. Constantin Asofiei
09:55 AM Feature #3394: generic drawing improvements: repaint and other misc code: Constantin Asofiei wrote:
> I'm rebasing 3394a rev 11217 in 15 minutes if nobody objects.
Constantin Asofiei
09:40 AM Feature #3394: generic drawing improvements: repaint and other misc code: I'm rebasing 3394a rev 11217 in 15 minutes if nobody objects. Constantin Asofiei

11/29/2017

05:58 AM Feature #3394: generic drawing improvements: repaint and other misc code: 3394a 11213 passed main runtime testing. Constantin Asofiei

11/28/2017

04:11 PM Feature #3394: generic drawing improvements: repaint and other misc code: Greg Shah wrote:
> 1. In @Button.setText()@ and @ToggleBox.setText()@ why is it safe to only repaint in @autoResize@... Constantin Asofiei
04:08 PM Feature #3394: generic drawing improvements: repaint and other misc code: Code Review Task Branch 3394a Revision 11211
1. In @Button.setText()@ and @ToggleBox.setText()@ why is it safe to ... Greg Shah
01:15 PM Feature #3394: generic drawing improvements: repaint and other misc code: > I think the improvements I made to postpone the drawing should be done only in GUI; ChUI has the PUT SCREEN stuff w... Greg Shah
11:43 AM Feature #3394: generic drawing improvements: repaint and other misc code: Greg Shah wrote:
> Do you want to make 3394a the next "accumulate the fixes" branch? Or would you prefer to keep it... Constantin Asofiei
10:57 AM Feature #3394: generic drawing improvements: repaint and other misc code: Do you want to make 3394a the next "accumulate the fixes" branch? Or would you prefer to keep it separate? Greg Shah
02:26 PM Bug #3390 (Closed): Eliminate unnecessary frame redraws due to inconsistent calculated height: Greg Shah
02:15 PM Bug #3390: Eliminate unnecessary frame redraws due to inconsistent calculated height: 3390a was merged to trunk as revision 11207 and archived. Hynek Cihlar
02:10 PM Bug #3390: Eliminate unnecessary frame redraws due to inconsistent calculated height: Please merge to trunk. Greg Shah
01:53 PM Bug #3390: Eliminate unnecessary frame redraws due to inconsistent calculated height: 3390a passed regression tests and was rebased against trunk 11206. No more changes are expected in the branch. Hynek Cihlar
01:11 PM Bug #3373: incremental scroll in non-full Browse page: It is OK to call @UnimplementedFeature@ on the client. It will be logged there and that is OK.
Since 3369a is merg... Greg Shah
07:29 AM Bug #3395: rectangle:edge-chars is not working in GUI: The @RECTANGLE:EDGE-CHARS@ is not working in GUI clients. We need to be able for @EDGE-PIXELS@ and @EDGE-CHARS@ to w... Constantin Asofiei
07:28 AM Bug #3395 (Closed): rectangle:edge-chars is not working in GUI: Constantin Asofiei

11/27/2017

06:49 PM Feature #3394: generic drawing improvements: repaint and other misc code: 3394a rev 11208 adds this:
* Batch the MSG_REGISTER_HOVERABLE_WIDGET messages.
* Avoid gd.setCurrentSelection(null)... Constantin Asofiei
05:38 PM Feature #3394: generic drawing improvements: repaint and other misc code: I've been looking into the JS code and there are some findings:
# we can reduce the @MSG_REGISTER_HOVERABLE_WIDGET@ ... Constantin Asofiei
04:40 PM Feature #3394: generic drawing improvements: repaint and other misc code: For #3394-3, the changes are in 3394a rev 11207. Constantin Asofiei
03:22 PM Feature #3394: generic drawing improvements: repaint and other misc code: Another issue to improve is described by this email chain:
-------
Constantin,
according to win32 api docs... Constantin Asofiei
03:20 PM Feature #3394: generic drawing improvements: repaint and other misc code: An issue to try to improve is described by this email chain:
-------------
I agree that Hynek's idea of two que... Constantin Asofiei
03:19 PM Feature #3394: generic drawing improvements: repaint and other misc code: In branch 3369a (trunk rev 11206), there are some fixes which remove some aggressive @repaint()@ calls when i.e. fram... Constantin Asofiei
03:18 PM Feature #3394 (Closed): generic drawing improvements: repaint and other misc code: Constantin Asofiei
03:56 PM Bug #3390: Eliminate unnecessary frame redraws due to inconsistent calculated height: Hynek Cihlar wrote:
> A fix checked in to 3390a revision 11206. Please review.
I'm OK with the changes. Constantin Asofiei
03:47 PM Bug #3374 (Closed): NPE in ConfigManager: Branch 3369a was merged to trunk as revision 11206. Greg Shah
03:46 PM Bug #3371 (Closed): NPE in AbstractGuiDriver in client log: Branch 3369a was merged to trunk as revision 11206. Greg Shah
03:44 PM Feature #3369 (Closed): add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Greg Shah
03:11 PM Feature #3369 (WIP): add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: 3369a Was merged to trunk rev 11206 and archived. Constantin Asofiei
02:29 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: No problem. I am un-committing 3369a/ right now. Ovidiu Maxiniuc
01:30 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: No, I want to get the 3369a into the trunk.
Ovidiu: Would you please move the changes 11248 into a separate branch? Greg Shah
01:15 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Constantin Asofiei wrote:
> Another regression fixed, 3369a rev 11247 is in testing.
Rev 11247 passed main part of ... Constantin Asofiei
08:56 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Another regression fixed, 3369a rev 11247 is in testing. Constantin Asofiei
03:33 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Don't mind it works now, after external jconsole has been accessed to the client process. It is not a bug probably. Sergey Ivanovskiy
03:29 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: I am using 3369a to work on #3385 and it seems that the Login screen (Swing client) doesn't accept keys input. Sergey Ivanovskiy
09:29 AM Bug #3373: incremental scroll in non-full Browse page: > I thing we should log the event instead (@UnimplementedFeature.TODO@) as a reminder and return @false@ because no r... Stanislav Lomany

11/26/2017

02:56 PM Bug #3390: Eliminate unnecessary frame redraws due to inconsistent calculated height: A fix checked in to 3390a revision 11206. Please review. Hynek Cihlar
02:28 PM Bug #3390: Eliminate unnecessary frame redraws due to inconsistent calculated height: On 11/25/2017 09:37 PM, Hynek Cihlar wrote:
> Constantin,
>
> the problem is caused by the char->pixel->char round... Hynek Cihlar
02:28 PM Bug #3390 (Closed): Eliminate unnecessary frame redraws due to inconsistent calculated height: Hynek Cihlar

11/25/2017

10:34 AM Bug #3375 (Closed): Stack overflow kills the client: Greg Shah
10:32 AM Bug #3375: Stack overflow kills the client: 3375a passed regression tests, rebased, merged to trunk as revision 11205 and archived. Hynek Cihlar
09:07 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Eric Faulhaber wrote:
> There are some issues with repainting in the ADM screens: e.g., an old tab remains "selecte... Constantin Asofiei
07:40 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Eric Faulhaber wrote:
> Also, I don't notice the same issue with buttons from one screen being painted incorrectly i... Eric Faulhaber
07:33 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: An observation: I've noticed that the embedded mode drawing seems much more "crisp" than virtual desktop mode or the ... Eric Faulhaber
07:20 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Eric Faulhaber wrote:
> There are some issues with repainting in the ADM screens: e.g., an old tab remains "selecte... Constantin Asofiei
07:20 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: I did some testing with the large app in Swing mode and in virtual desktop mode (converted with 3369a rev. 11237). It... Eric Faulhaber
09:56 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Constantin Asofiei wrote:
> > > 3369a rev 11231 contains... Eric Faulhaber
07:50 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > 3369a rev 11231 contains some performance fixes:
> > # a... Constantin Asofiei
07:38 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Branch 3369a rebased from trunk rev 11204. The latest revision is 11236.
This will require a full reconversion of... Greg Shah
07:13 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: I'm rebasing now. Greg Shah

11/24/2017

06:52 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Can I rebase 3369a? I know the 3375a change is not yet available, but I think it is best to go ahead and pick up the... Greg Shah
06:34 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Constantin Asofiei wrote:
> 3369a rev 11231 contains some performance fixes:
> # avoid unnecessary repaints
There ... Constantin Asofiei
05:10 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: 3369a rev 11231 contains some performance fixes:
# avoid logging overhead in the EmulatedWindowState and SwingEmulat... Constantin Asofiei
04:56 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Hynek Cihlar wrote:
> 3369a 11220 improves performance of coordinate values rounding.
There are still these cases w... Constantin Asofiei
04:29 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Yes, but I want to wait for Hynek's update first. Constantin Asofiei
04:28 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Does it need to rebase 3369a? Sergey Ivanovskiy
09:19 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Greg Shah wrote:
> Code Review Task Branch 3369a Revision 11226
I fixed a regression in 11227, I was not considerin... Constantin Asofiei
08:55 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Code Review Task Branch 3369a Revision 11226
I think the code is correct from a logical standpoint.
If we had... Greg Shah
07:25 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: 3369a rev 11225/11226 fixes class name collisions for converted external program names. Full conversion is required.... Constantin Asofiei
05:40 PM Bug #3375: Stack overflow kills the client: Greg Shah wrote:
> Code Review Task Branch 3375a Revision 11204
>
> The changes are fine. The difference now is ... Hynek Cihlar
12:40 PM Bug #3375: Stack overflow kills the client: Code Review Task Branch 3375a Revision 11204
The changes are fine. The difference now is very slight.
If it pa... Greg Shah
12:04 PM Bug #3375: Stack overflow kills the client: Hynek Cihlar wrote:
> It finished with one regression, I am currently fixing the issue. I don't expect the fix to ta... Hynek Cihlar
11:01 AM Bug #3375: Stack overflow kills the client: Greg Shah wrote:
> Code Review Task Branch 3375a Revision 11203
>
> I'm fine with the changes. Did ChUI regressi... Hynek Cihlar
08:09 AM Bug #3375: Stack overflow kills the client: Code Review Task Branch 3375a Revision 11203
I'm fine with the changes. Did ChUI regression testing finish? Greg Shah
02:37 PM Bug #3370 (Closed): READ-ONLY attribute error in server log: Greg Shah
02:26 PM Bug #3370: READ-ONLY attribute error in server log: Committed revision 11204.
Branch was archived. Notification email was sent to team. Ovidiu Maxiniuc
02:00 PM Bug #3370: READ-ONLY attribute error in server log: Please merge 3370a to trunk. Greg Shah
01:13 PM Bug #3370: READ-ONLY attribute error in server log: The conversion test on devsrv01 ended with success. The generated code by 3370a/11203 is unchanged.
Ovidiu Maxiniuc
08:58 AM Bug #3370: READ-ONLY attribute error in server log: Indeed, we should have an interface for each P4GL attribute / method. Some of them can be grouped together if they ar... Ovidiu Maxiniuc
08:41 AM Bug #3370: READ-ONLY attribute error in server log: Code Review Task branch 3370a Revision 11203
The changes look good.
I think you have found a more widespread fl... Greg Shah
06:49 AM Bug #3373: incremental scroll in non-full Browse page: Agreed.
Stanislav: Please put that change in 3369a. Then you can fix this issue later. Greg Shah
06:42 AM Bug #3373: incremental scroll in non-full Browse page: I noticed that in the log, but throwing exceptions in this manner is dangerous. This time the @incrementalScroll()@ w... Ovidiu Maxiniuc
06:30 AM Bug #3373: incremental scroll in non-full Browse page: Ovidiu: Does this affect a user or is it just a report in the log? Greg Shah

11/23/2017

12:09 PM Bug #3382: Client-side popup menus abend: I've created a client-side popup menu for browse (using the same approach used as in @ScrollPopupGuiImpl@) and called... Stanislav Lomany
12:01 PM Bug #3382: Client-side popup menus abend: Stanislav, do you remember the actual case when the exception happened? I would rather have a real recreate for this. Hynek Cihlar
11:45 AM Bug #3382 (WIP): Client-side popup menus abend: Hynek Cihlar
11:33 AM Bug #3373: incremental scroll in non-full Browse page: Greg, I'll fix it, but considering the amount of work for #3261 I'm not sure if I should fix it before or after Nov 30. Stanislav Lomany
11:30 AM Bug #3373 (WIP): incremental scroll in non-full Browse page: Stanislav,
I understand you are working on this issue so I am assigning it to you. Ovidiu Maxiniuc
11:33 AM Bug #3375 (WIP): Stack overflow kills the client: Ovidiu Maxiniuc
10:22 AM Bug #3375: Stack overflow kills the client: Created task branch 3375a and checked in the fix. The changes passed GUI regression tests, ChUI regression testing is... Hynek Cihlar
11:32 AM Bug #3374 (WIP): NPE in ConfigManager: I committed the fix for this issue was committed to 3369a with revision 11211. Ovidiu Maxiniuc
11:26 AM Bug #3371: NPE in AbstractGuiDriver in client log: The revision 11212 of 3369a makes sure the window is selected in @EditorGuiImpl.computeLineWidths()@. The exceptions ... Ovidiu Maxiniuc
11:22 AM Bug #3370: READ-ONLY attribute error in server log: I created 3370a created and committed a patch for this issue. Current revision is 11203. Please review. Ovidiu Maxiniuc

11/22/2017

04:02 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: 3369a 11220 improves performance of coordinate values rounding. Hynek Cihlar
03:57 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Code Review Task Branch 3369a Revision 11219
I'm good with the change.
Greg Shah
02:43 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Revision 11219 contains a fix for unresponsive message boxes. Somebody please review. Hynek Cihlar
02:25 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Committed revision 11218 removed waste code due to the web client profiling done by Eric. Sergey Ivanovskiy
09:41 AM Bug #3382: Client-side popup menus abend: The problem with popup menus created at client side is that they can cause abend under a certain circumstances, e.g. ... Stanislav Lomany
09:18 AM Bug #3382 (Closed): Client-side popup menus abend: Stanislav Lomany
08:33 AM Bug #3368 (Closed): dialog-box frame height is not set correctly: Greg Shah
08:20 AM Bug #3368: dialog-box frame height is not set correctly: 3368a was merged in trunk as revision 11202 and archived. Hynek Cihlar
06:23 AM Bug #3368: dialog-box frame height is not set correctly: Code Review Task Branch 3368a Revision 11205
The changes are good. You can merge to trunk. Greg Shah
05:22 AM Bug #3368: dialog-box frame height is not set correctly: 3368a revision 11205 contains a small change that resolves a regression found during ChUI testing. The revision has ... Hynek Cihlar
08:12 AM Bug #3381: Sub-menu drawing issues: Testcase attached (@sub-menus.p@). The following scenarios have issues:
# Right-click on the button: in swing the ri... Stanislav Lomany
05:43 AM Bug #3381 (Closed): Sub-menu drawing issues: Stanislav Lomany
06:57 AM Bug #3370: READ-ONLY attribute error in server log: I think this needs to be separate from 3369a, so that we don't introduce a delay in getting the most critical changes... Greg Shah
05:23 AM Bug #3370 (WIP): READ-ONLY attribute error in server log: Ovidiu Maxiniuc
05:22 AM Bug #3370: READ-ONLY attribute error in server log: Greg,
I finished moving the READ-ONLY attribute to a new interface.
Because the introduction of the new interface @... Ovidiu Maxiniuc
05:10 AM Bug #3370: READ-ONLY attribute error in server log: I found that @CommonHandle.readOnlyError(String)@ is annotated with @@LegacyAttribute(name = "READ-ONLY")@.
I cons... Ovidiu Maxiniuc
02:48 AM Bug #3373: incremental scroll in non-full Browse page: The issue occurs because the browse is not yet initialized at the point when "END" event is applied. So we must figur... Stanislav Lomany

11/21/2017

04:03 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: 3355a was merged into 3369a rev. 11213. Sergey Ivanovskiy
12:37 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: > As far as I understand file choose dialog (for choosing report output file) is in WIP state, so it works to a cert... Greg Shah
09:01 AM Bug #3371: NPE in AbstractGuiDriver in client log: Constantin Asofiei wrote:
> Ovidiu, please try something: is @EditorGuiImpl.processScrollPane@ called when i.e. the ... Ovidiu Maxiniuc
08:41 AM Bug #3371: NPE in AbstractGuiDriver in client log: Ovidiu, please try something: is @EditorGuiImpl.processScrollPane@ called when i.e. the editor is drawn? I wonder if... Constantin Asofiei
08:33 AM Bug #3371: NPE in AbstractGuiDriver in client log: I tried to move the code in a @withSelectedWindow()@, but the widget is not fully reconstructed so the parent is not ... Ovidiu Maxiniuc
06:42 AM Bug #3368: dialog-box frame height is not set correctly: Code Review Task Branch 3368a Revision 11204
I'm fine with the code. If it passes regression testing, you can mer... Greg Shah
06:21 AM Bug #3368: dialog-box frame height is not set correctly: Greg Shah wrote:
> except it is not clear why the null check was removed from @FrameGuiImpl@.
The null check was ... Hynek Cihlar
07:01 PM Bug #3368: dialog-box frame height is not set correctly: Code Review Task Branch 3368a Revision 11203
I'm fine with the changes, except it is not clear why the null check ... Greg Shah

11/20/2017

05:35 PM Bug #3371: NPE in AbstractGuiDriver in client log: Ovidiu, I would rather ensure that @EditorGuiImpl.computeLineWidths@ has a window selected (i.e. is bracketed in @gd.... Constantin Asofiei
03:11 PM Bug #3371: NPE in AbstractGuiDriver in client log: Code Review Task Branch 3369a Revision 11211
I generally OK with the changes. The one thing that is not clear to ... Greg Shah
04:46 PM Bug #3368: dialog-box frame height is not set correctly: The incorrect size turned to be a problem in the frame layout itself. The frame height is not calculated correctly wh... Hynek Cihlar
01:28 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Code Review Task Branch 3369a Revision 11209
I'm fine with the changes. I checked in some minor changes to make i... Greg Shah
01:08 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Constantin Asofiei wrote:
> Eric, I couldn't reproduce the iframe issue you've reported with 3369a. If you have any... Eric Faulhaber
01:02 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Constantin Asofiei wrote:
> Eric: Persistence.java needs a history entry.
Done. Eric Faulhaber
12:58 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Eric, I couldn't reproduce the iframe issue you've reported with 3369a. If you have any other details I can use to d... Constantin Asofiei
12:46 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: Greg, 3369a rev 11208 is ready for review.
Eric: Persistence.java needs a history entry. Constantin Asofiei
10:30 AM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes: 3369a rebased from trunk 11201. new rev is 11207. Constantin Asofiei
10:26 AM Bug #2799: browse widget doesn't execute validation expressions in P2J (both chui and gui): Stanislav Lomany wrote:
> > And now the BROWSE version is also fully supported, right?
> Right.
Please update th... Greg Shah
10:12 AM Bug #2799: browse widget doesn't execute validation expressions in P2J (both chui and gui): > And now the BROWSE version is also fully supported, right?
Right. Stanislav Lomany
09:50 AM Bug #2799: browse widget doesn't execute validation expressions in P2J (both chui and gui): > @FRAME:NO-AUTO-VALIDATE@ option is mentioned here and I didn't deal with it. Otherwise it can be closed.
I belie... Greg Shah
09:53 AM Bug #3373: incremental scroll in non-full Browse page: Stanislav Lomany wrote:
> I'm not sure.
> Ovidiu, how did you managed to create a @0 DOWN@ browse? (normally you ca... Ovidiu Maxiniuc
09:46 AM Bug #3373: incremental scroll in non-full Browse page: I'm not sure.
Ovidiu, how did you managed to create a @0 DOWN@ browse? (normally you can't create a browse with less... Stanislav Lomany
09:40 AM Bug #3373: incremental scroll in non-full Browse page: How much work is it to fix? Greg Shah
09:38 AM Bug #3373: incremental scroll in non-full Browse page: Yes. Stanislav Lomany
09:36 AM Bug #3373: incremental scroll in non-full Browse page: > No, it's internal P2J error.
@recordOrShowError()@ is only for "real" 4GL errors.
Is this a P2J bug? Greg Shah
09:01 AM Bug #3373: incremental scroll in non-full Browse page: No, it's internal P2J error. Stanislav Lomany
08:59 AM Bug #3373: incremental scroll in non-full Browse page: Is there an error in the 4GL? Greg Shah
08:49 AM Bug #3373: incremental scroll in non-full Browse page: Let me know if I should fix it (before/after deadline?). Stanislav Lomany
08:46 AM Bug #3373: incremental scroll in non-full Browse page: That is the event which represents a programming error. The text can be changed to "Incremental scroll cannot be used... Stanislav Lomany
08:06 AM Bug #3373: incremental scroll in non-full Browse page: The call to @incrementalScroll@ is caused by an... Ovidiu Maxiniuc
09:39 AM Bug #3370: READ-ONLY attribute error in server log: I agree with the solution. Greg Shah
09:06 AM Bug #3370: READ-ONLY attribute error in server log: I investigated this issue. The root cause of this error is the fact that the @READ-ONLY@ attribute is declared in @Co... Ovidiu Maxiniuc

11/19/2017

05:31 PM Bug #3306: Improve intermediate state in ROW-DISPLAY trigger.: That is still an amount of unplesant work which IMO we don't need to touch until customer meets a real problem with i... Stanislav Lomany
05:19 PM Bug #2799: browse widget doesn't execute validation expressions in P2J (both chui and gui): @FRAME:NO-AUTO-VALIDATE@ option is mentioned here and I didn't deal with it. Otherwise it can be closed. Stanislav Lomany
05:11 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: I was creating pop-up menu from a browse and met some issues:
1. As far as I understand file choose dialog (for choo... Stanislav Lomany
07:28 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Stanislav Lomany wrote:
> We need to have the switch for enhanced browse features, so I created this container, sear... Greg Shah

11/18/2017

06:46 PM Bug #3306: Improve intermediate state in ROW-DISPLAY trigger.: What is the status of this? Greg Shah
06:45 PM Bug #2799: browse widget doesn't execute validation expressions in P2J (both chui and gui): Can this be closed? Greg Shah
06:43 PM Feature #3275 (Closed): improve browse support: Greg Shah

11/17/2017

02:30 PM Bug #3374: NPE in ConfigManager: Ovidiu Maxiniuc wrote:
> Also, the location (@ConfigManager.java@:350) does not make sense: the @dirtyConfigs@ is in... Ovidiu Maxiniuc
01:54 PM Bug #3374: NPE in ConfigManager: The client is reset (back to login screen) when clicking various widgets. I found this is client log:... Ovidiu Maxiniuc
01:48 PM Bug #3374 (Closed): NPE in ConfigManager: Ovidiu Maxiniuc
02:09 PM Bug #3375: Stack overflow kills the client: The client got killed (not reset). Just before that the two shown windows started blinking alternatively. This is pro... Ovidiu Maxiniuc
02:06 PM Bug #3375 (Closed): Stack overflow kills the client: Ovidiu Maxiniuc
01:43 PM Bug #3373: incremental scroll in non-full Browse page: I found the following stack trace in client log:... Ovidiu Maxiniuc
01:38 PM Bug #3373 (Closed): incremental scroll in non-full Browse page: Ovidiu Maxiniuc
11:45 AM Bug #3371 (WIP): NPE in AbstractGuiDriver in client log: Found following exception in client log:... Ovidiu Maxiniuc
11:36 AM Bug #3371 (Closed): NPE in AbstractGuiDriver in client log: Ovidiu Maxiniuc

11/16/2017

03:13 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: We need to have the switch for enhanced browse features, so I created this container, searchable under @Directory.ID_... Stanislav Lomany
10:11 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Rebased task branch 3261a from P2J trunk revision 11201. Stanislav Lomany
08:09 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Created task branch 3261a from P2J trunk revision 11200. Stanislav Lomany
09:54 AM Feature #3275 (Review): improve browse support: 3275d has been merged into the trunk as bzr revision 11201. Stanislav Lomany
09:04 AM Feature #3275: improve browse support: Please merge 3275d to trunk. Greg Shah
08:55 AM Feature #3275: improve browse support: Customer POC works fine, any possible regressions are related to "interactive" browse features, I think it is OK to c... Stanislav Lomany
08:21 AM Feature #3275: improve browse support: Code Review Task Branch 3275d Revision 11203
The changes are good.
What testing do you recommend? The impact o... Greg Shah
07:06 AM Feature #3275: improve browse support: Rebased task branch 3275d from P2J trunk revision 11200. Please review. Stanislav Lomany

11/15/2017

09:18 AM Feature #3291: implement SYSTEM-DIALOG-COLOR: > The same code in FWD will only update the the color table entry, followed by a synch operation with the client. Thi... Greg Shah

11/14/2017

03:41 PM Feature #3291: implement SYSTEM-DIALOG-COLOR: Greg Shah wrote:
> > After the the user makes a selection, the selection will be used by widgets that are subsequent... Ovidiu Maxiniuc

11/09/2017

07:15 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: No, please create one. Stanislav Lomany
07:12 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Do we have a branch for this? Hynek Cihlar
05:36 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: > This dynamic layout (if enabled) will be in effect only when a browse widget will appear in any of the affected fra... Greg Shah
05:30 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: This dynamic layout (if enabled) will be in effect only when a browse widget will appear in any of the affected frame... Hynek Cihlar
05:18 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: I should have mentioned that if the browse is not positioned at the top left and there is space in either of those di... Greg Shah
05:13 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Greg Shah wrote:
> This is the concept:
> # Expand the size of both the containing frame and the enhanced browse to... Hynek Cihlar
05:10 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Greg Shah wrote:
> This is the concept:
On which events should the layout be changed? Is it after it is displayed... Hynek Cihlar
05:06 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: This is the concept:
# Detect if the containing window has empty space horizontally, vertically or both. If the b... Greg Shah
04:54 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Stanislav, Greg mentioned that you could use some help on "Automatically and sensibly expand to fit more space availa... Hynek Cihlar
07:08 AM Feature #3275: improve browse support: Created task branch 3275d from trunk revision 11198 (for "column and row resizing doesn't work properly" issues which... Stanislav Lomany

11/08/2017

03:27 PM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: Code Review Task Branch 3332a Revision 11207
I'm good with the code.
You will need to rebase (Eric is about to ... Greg Shah
02:57 PM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: 3332a 11207 makes the @loadImage@ methods accept @int64@ and added the overloads with Java primitive types. The revis... Hynek Cihlar
11:21 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: Greg Shah wrote:
> My concern is that this converted code won't compile because @integer@ is more specific than @int... Hynek Cihlar
11:14 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: > This should be covered. Although the native 4GL allows passing int64 values, anything above the max int value will ... Greg Shah
10:33 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: Greg Shah wrote:
> Code Review Task Branch 3332a Revision 11206
>
> 2. I would prefer to leave the primitive vers... Hynek Cihlar
10:14 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: Code Review Task Branch 3332a Revision 11206
1. I have no problem with forced wrapping for @load-image*()@. Don't... Greg Shah
09:51 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: 3332a revision 11206 is rebased againt trunk 11196. Please review. Hynek Cihlar
09:45 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...: 3332a revision 11206 resolves the review points except one exception mentioned below, fixes several widget sizing cas... Hynek Cihlar

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » User Interface

Activity

Activity

12/06/2017

12/05/2017

12/04/2017

12/02/2017

12/01/2017

11/29/2017

11/28/2017

11/27/2017

11/26/2017

11/25/2017

11/24/2017

11/23/2017

11/22/2017

11/21/2017

11/20/2017

11/19/2017

11/18/2017

11/17/2017

11/16/2017

11/15/2017

11/14/2017

11/13/2017

11/12/2017

11/10/2017

11/09/2017

11/08/2017